Differential D25360

Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting
ClosedPublic
Actions

Authored by ngraham on Nov 17 2019, 11:48 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Plasma
Commits
R252:dcadc14c952d: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals…
Summary

CCBUG: 379498

Test Plan
  • Set ScrollbarLeftClickNavigatesByPage=true in the [KDE] section of ~/.config/kdeglobals
  • Click in the scroll trough in a Qt/KDE app
  • See that the scroll handle position jumps right there
  • Set ScrollbarLeftClickNavigatesByPage=false or remove it from kdeglobals
  • Click in the scroll trough in a Qt/KDE app
  • See that the scroll handle moves up or down by one page height

Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 17 2019, 11:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 17 2019, 11:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 17 2019, 11:48 PM
broulik added a subscriber: broulik.Nov 18 2019, 9:26 AM
broulik added inline comments.
src/kstyle/kstyle.cpp
504

ScrollBarLeftClick...?

ngraham updated this revision to Diff 69932.Nov 18 2019, 4:04 PM
ngraham marked an inline comment as done.

Improve config file entry name

ngraham edited the test plan for this revision. (Show Details)Nov 29 2019, 4:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 2 2019, 6:18 PM
Closed by commit R252:dcadc14c952d: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals… (authored by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.
IlyaBizyaev added a subscriber: IlyaBizyaev.Dec 8 2019, 10:46 AM

Should this also affect GTK apps? There's a matching radio group in the GTK KCM.

GB_2 added a subscriber: GB_2.Dec 8 2019, 12:13 PM
In D25360#573798, @IlyaBizyaev wrote:

Should this also affect GTK apps? There's a matching radio group in the GTK KCM.

D25703

Revision Contents
Changeset List

PathPackages
Msrc/kstyle/kstyle.cpp (5 lines)

Diff 70769

View Options

src/kstyle/kstyle.cpp

Loading...