Works for me, can't find any regressions, and the code looks clean.

plasma-workspace does compile without D13670 and KRunner seems to work, but it gives me a whole lotta console spew:

This fixes B262837 (how do you show this in phab?) and relies on D13670

Is there/should there be any provision to remove it if it's already installed? Or is that something that distros should/would/will take care of for us? If not, I worry that people with KDE Connect already installed will see duplicates.

I might recommend Ctrl+← and Ctrl+→ to go to the previous and next songs instead of or in addition to the PgUp and PgDn keys.

Use Dolphin::VERTICAL_SPACER_HEIGHT instead of a hardcoded value

Do you have commit access yet?

No name shows up in the list:

Ok, that's fine. So our two scrollbar style options are basically:

Nice, works for me!

There are three use cases for these kinds of inline messages:

• An error, warning, or informational message regarding user input for a specific control (e.g. the Konsole example you started out with)
• A transient or semi-transient message showing either general program status or the result of a command (e.g. number of results in a Kate search, URL of a shared image in Spectacle)

The actual code change looks sane and fixes the bug.

There's a problem with the git setup on the computer you used to make this commit; the name field appears to be empty, so I get an error when I try to apply the patch:

libinput debug-gui shows that my touchpad and touchscreen can both can see two, three, and four finger swipes, two-finger pinches, two-finger rotation, and two finger scrolling.

Add a label to help people understand what the metadata list is for

Like this?

In D13768#287873, @abetts wrote:

In D13768#287867, @ngraham wrote:

Maybe "Additional information to show" or "Show additional information" or even "Additional information"?I'm not yet convinced this really needs to be changed at all, though.

Here I was thinking that the triangle button caused an effect. It was like a button so I wanted the string to start with an active verb.

Merge master and shorten a string

In D13768#287517, @abetts wrote:

"Current folder including all sub-folders"

to

Current folder and sub-folders

Sounds good to me! It sounds like we're all in agreement?

Thanks!

Yeah, I had to create a new account to get it to happen. If this happens in Neon too, it's not Kubuntu-specific, so let's track the upstream bug report instead. Thanks everyone!

Thanks for your patience on this!

Sounds good. You don't need to post a new diff; just make your changes and update the current one with arc diff (Thanks for using arc, by the way!)

Thanks! If you're not totally sick of my UI changes yet, there's also D13768: Modernize View Properties window. ;-)

Thanks for the patch! I've got touch hardware and am excited to test this out. I should be able to do that within the next day. In the meantime, I noticed some style issues with your code, which I've pointed out below. Here's some light reading on the subject: https://techbase.kde.org/Policies/Frameworks_Coding_Style

This was fixed upstream with https://cgit.kde.org/plasma-workspace.git/commit/?id=ee48796ec5561f540ed8b328a302e44b4364a234

Actually, cannot reproduce in Neon.

Adding a few others because I think this is something that if changed, should be changed in quite a few other places, so let's make sure relevant folks are aware and approve.

Preserve alphabetical sorting of local includes

Verified that the Information Panel still works. :)

Globally.

If it's important for uninstalled tools to be not always be visible, maybe what we should do is embed the content of the KNewStuff menu in Spectacle rather than exposing the whole thing as a sub-menu. Then we could make a few string changes, and it would be like this in Spectacle:

Yes, unfortunately Lollypop recently added a global playlist and I've struggled to adapt to it. :/ I'm addicted to its auto-fetching lyrics display though.

Also also T9128: Ship some more of the best KDE apps with Cosmic

Thanks! Now we investigate the issue and try to find a fix. :)

Thanks, works as expected and I couldn't find any regressions. Code looks good.

See T9127: Ship some KDE games with Cosmic

Agreed. Whether you want the global playlist visible is probably a pretty good indication of your preferred style. Perhaps when the global playlist is hidden we could also hide the Enqueue button and make the Replace and Play button just say "Play."

After investigating, it looks like this failure may be an installation issue on the build machine. The test is failing there because the new group property is inappropriately visible, but the approved change expressly covered this case by adding it to the baloofileinformationrc blacklist and bumping the version, which should have had the effect of not making the property visible. I suspect baloofileinformationrc did not get updated on the build machine the way it did on my local machine, where the test passes.

Oooh darn, for some reason I've missed these test failures in baloo-widgets, sorry! Will fix.

Since global playlist vs non-global-playlist seems to be cardinal UI design decision in music players, let me explain why I personally prefer the non-global-playlist approach:

See T9126: Breeze scrollbar look-and-feel unification

Or even this:

You are the most awesome person in the world today.

You learn something every day, I didn't even know about this &; trick!

Can confirm. :(

In D13777#286557, @rjvbb wrote:

That just doesn't look good, sorry.

Again, that's an argument one should avoid. It's too subjective. I myself find it looks much better (I'm biased against everything Breeze, sorry) and easier on the eyes because I prefer almost monochromatic palettes.

Keep #includes alphabetically ordered and use a global for the 18px spacer height

In D13745#286544, @hein wrote:

Can we discuss this somewhere else, e.g. on plasma-devel or in one of the Plasma monday meetings? This is a review thread for a libtaskmanager code patch.

@raddison what is the actionable path forward here?

Regular DPI screen with no scaling for me.

In D13777#286439, @rjvbb wrote:

Have you guys considered using the 4 colours in question only for the message text and outer frame, keeping the background intact (or possibly just a bit lighter or darker depending on its initial brightness and/or the theme/user's contrast setting)? The result should be more subtle (edit: less gaudy) and more reliably as readable as allowed by the theme.
[...]

That's Breeze vs. Breeze Dark vs. my custom theme.

+1 visually. Sadly @hpereiradacosta stepped down as Breeze maintainer recently, but since he's already given his stamp of approval, I think this can go in.

What's the status of this? Any progress toward resolving the outstanding TODO? Would be nice if we can get it in for 5.14 alongside the effort to clean up GHNS a bit.

FWIW, I'd be okay with bumping the minimum KIO version to 5.47 in master.

Very nice! You'll lure me away from Lollypop yet. :)

Lovely. :)

Too late, somebody else already filed it: https://bugs.kde.org/show_bug.cgi?id=395618

It would be really nice to have eyes from some more Dolphin folks on this. :)

In D13643#285745, @abetts wrote:

My first impression is that it looks a lot like a file emblem. I would probably remove the background and keep only the logo.

Gotta remove the link, sorry. :) It just needs to be plain old FEATURE: 395954.

Thanks for the patch! Can you change Fixes #395954 to FEATURE: 395954? See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

Nice, I think this is looking great. +1 on the latest wording. A lovely first patch!

Thanks! @pino?

What you say theoretically makes sense, but try it out: the document appears in the Recent Documents menu for both Kate and KWrite, while multi-app aggregator UIs continue to not accumulate duplicates.

Thanks for the patch! Conceptually, this makes sense to me. Can you attach some before-and-after screenshots showing the impact of the change?

The bug report indicates that this patch is for adapting to a change in Qt 5.11. Is this patch fully backwards-compatible with older Qt versions? If not, we'll need to guard this behind a Qt version check.

@aacid, can you offer any guidance here regarding how we might move forward?

Interesting! In your "after" video, I notice that the dialog still somewhat awkwardly moves behind its parent window for a moment after you click on the Discard button. Is there any way to improve upon that too?