[KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com
Needs ReviewPublic

Authored by tagorechandanreddy on Sat, Jul 7, 2:08 PM.

Details

Reviewers
ngraham
kossebau
Group Reviewers
Plasma
Summary

Added new Picture of the Day provider handling 'Image of the day' from Space.com at address:
http://www.space.com/imageoftheday/

Language translations need looking into.

Test Plan

All plugins should work as usual. Language translations may need few corrections.

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptSat, Jul 7, 2:08 PM
tagorechandanreddy requested review of this revision.Sat, Jul 7, 2:08 PM

Thanks for offering this for inclusion. No time to test myself currently.

Important: can you tell what license space.com has on those images? Can they be used e.g. without a fee by 3rd-party software, like this plugin? I could not find a hint on the linked page on a quick look.

BTW, while I did some fixes to the potd dataengine , I am not the maintainer of it (nor plan to be). So it has to be someone else deciding about whether this plugin can be added.
Given there seems no maintainer of this dataengine these days it would have to be the Plasma team in general, or the person overseeing things like the release manager (@jriddell).

dataengines/potd/siodprovider.h
3–4

Please update the copyright of all files, your name and the year is missing here.

dataengines/potd/siodprovider.json
5

The KDE translation system needs such in-source translations to be added to the translation database directly. This is a work done by the translator teams, but who first need to see the original string.
The daily-run translation updating script (called scripty) will extract any strings to translate and update with strings from the translation database, but also remove any translations from the sources which are not in the database.
So adding translations here directly will result in scripty removing them simply on next run. Thus no use to add them -> remove all here :)

kossebau resigned from this revision.Sat, Jul 7, 2:39 PM

Made copyright, translation changes as suggested.

And regarding the license of the images, Space.com acquires them from twitter and other public outlets that belong to NASA and its Astronauts. All images are taken by Space.com from public domains with credit to the original contributors. No other mention of any additional copyright notices.

ngraham requested changes to this revision.Sat, Jul 7, 9:45 PM
ngraham added a subscriber: ngraham.

No name shows up in the list:

Also, using it doesn't seem to actually work; the wallpaper remains black.

This revision now requires changes to proceed.Sat, Jul 7, 9:45 PM

Fixed siodprovider.json file. It should work now.