Add LabPlot project file icon
ClosedPublic

Authored by mtrescott on Jun 21 2018, 2:02 AM.

Details

Summary

Rather than simply displaying the gzip icon, Breeze should include a nice icon for LabPlot files. Here's a screenshot:

It uses the colors from the Breeze palette, Icon Grey, Icon Blue, Icon Red, and for the axes a color that I copied from the Breeze LabPlot icon.

Test Plan
  • Make sure the icon is easy enough to understand

Diff Detail

Repository
R266 Breeze Icons
Lint
Lint Skipped
Unit
Unit Tests Skipped
mtrescott created this revision.Jun 21 2018, 2:02 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 21 2018, 2:02 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mtrescott requested review of this revision.Jun 21 2018, 2:02 AM

Icon patches always need screenshots! :)

mtrescott edited the summary of this revision. (Show Details)Jun 21 2018, 8:49 PM

@ngraham I edited it to have a screenshot.

mtrescott edited the summary of this revision. (Show Details)Jun 21 2018, 8:53 PM
asemke added a subscriber: asemke.Jul 1 2018, 7:47 PM

Thank for this work. It looks nice to me. However, maybe it's better for people from VDG and Breeze teams to accept this or to raise objections.

abetts added a subscriber: abetts.Jul 1 2018, 8:11 PM

My first impression is that it looks a lot like a file emblem. I would probably remove the background and keep only the logo.

My first impression is that it looks a lot like a file emblem. I would probably remove the background and keep only the logo.

But it is a file icon...

Typically the way these are done with the Breeze icon theme is that the small size shows only the icon, while the larger size uses a generic colored document icon with the app's icon or else some other symbolic icon in the center.

I think this looks great!

abetts added a comment.Jul 1 2018, 8:34 PM

Oh great! I thought the team was looking for a logo. Then, I have nothing more to add. It looks great.

ngraham accepted this revision.Jul 1 2018, 10:32 PM
This revision is now accepted and ready to land.Jul 1 2018, 10:32 PM

Bump. Please, can someone merge this? For all that I read on Planet KDE about "streamlined onboarding of contributors" nothing has happened here.

Whoops, sorry this was missed. I can merge it for you, since it looks great! In order to do this, I'll need to know your real name and preferred email address. Can you tell me those?

Sure.
Real name: Matthew Trescott
Email: matthewtrescott@gmail.com

ngraham closed this revision.Aug 25 2018, 6:05 PM

Thanks again for your contribution! Next time, we'll try to be more on the ball about the review. :)