Mon, Apr 8
Well, actually, it was caught by @hetzenecker: https://phabricator.kde.org/D7581?id=22415#change-vIXPDUvyb3sZ
You are welcome!
I started to implement highdpi support from scratch, but then I found this change and it was a huge help!
re-target to master
Sun, Apr 7
Wow, it's so great to see this finally merged.
@volkov - a huge thank you that you took over this patch and for all the work you put in to finally resolve this.
Sat, Apr 6
Fri, Apr 5
Thanks, this looks perfect now.
Thanks for the patch!
Thu, Apr 4
@volkov Go for it!
add a comment about turning off opacity effect
Wed, Apr 3
A surprisingly clean diff. Very nice.
D9078 should fix thumbnails.
Nice to see this. It's definitely better than nothing, but HiDPI support for the thumbnails would be nice too. :)
turn off opacity effect for highdpi with Qt < 5.12.4
Tue, Apr 2
Currently there is a bug in Qt which makes QGraphicsOpacityEffect not working: https://codereview.qt-project.org/#/c/257946/
rebase + refactoring
Sat, Mar 23
i'll land it in a minute
Mar 16 2019
No worries, and thanks for the attempt! Once they're in, that'll really help other QWidgets-based KDE apps.
I started to transfer the gestures to the framework, but I cannot promise anything.
I imagine by adding what's here into the framework first, and then later raising the Gwenview frameworks dependency high enough and using them from there framework.
Thanks for the patch. How is the gesture code going to get into KWidgetAddons now?
Thanks so much for your patience on this. I think it's ready to land now!
Mar 10 2019
Move the gestureEvent(QGestureEvent* event) and event(QEvent* event) functions from documentview.cpp and thumbnailview.cpp to the Touch class.
I think this is now ready to land.
Mar 9 2019
I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?
Mar 3 2019
+1 to adding gesture recognizers to KWidgetsAddons
- move some of the duplicate code in documentview and thumbnailview to functions in touch and touch_helper
- fix some typos
- fix copyright
Mar 2 2019
Feb 27 2019
Feb 24 2019
Thanks, that makes sense. However, it might also make sense to add generic support for all of this into Qt itself, or at least into a KDE Framework (KWidgetsAddons maybe?). There are lots of other QWidgets-based KDE apps that could benefit from this stuff too! Dolphin and Okular immediately come to mind.