GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Yesterday

ngraham added a comment to D13901: Touch support for Gwenview.

Hi @ngraham

Rotation should only happen when one of the fingers remains still

I am not sure, that I agree with you in this matter, because I move both fingers if I want to rotate the image.

Mon, Sep 24, 7:26 PM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

Hi @ngraham

Rotation should only happen when one of the fingers remains still

I am not sure, that I agree with you in this matter, because I move both fingers if I want to rotate the image.

Mon, Sep 24, 5:39 PM · Gwenview

Sun, Sep 23

ngraham added a comment to D13901: Touch support for Gwenview.

Wow, pinch zooming is hugely improved with this new version. Nice work!

Sun, Sep 23, 8:57 PM · Gwenview

Sat, Sep 22

steffenh updated the diff for D13901: Touch support for Gwenview.

The patch has completely rewritten, to implement changes based on review comments.

Sat, Sep 22, 1:57 PM · Gwenview

Fri, Sep 21

muhlenpfordt closed D15455: Fix orientation when saving/transforming JPEG images.
Fri, Sep 21, 6:30 AM · Gwenview

Thu, Sep 20

anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

This does not work in every situation but maybe it's a starting point for you.

Thu, Sep 20, 6:55 AM · Gwenview
anthonyfieroni requested review of D15612: [ThumbnailView] Fix mouse buttons handling.
Thu, Sep 20, 6:55 AM · Gwenview

Wed, Sep 19

muhlenpfordt added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

I had a quick look at the Browse Mode problem and tried adding the following event handler:

void ThumbnailView::mousePressEvent(QMouseEvent* event)
{
    if (event->button() == Qt::ForwardButton || event->button() == Qt::BackButton) {
        return;
    }
    QListView::mousePressEvent(event);
}

This does not work in every situation but maybe it's a starting point for you.

  • After (left-)clicking an image to view and pressing Return to come back to Browse Mode, pressing a navigation button while over a thumbnail switches to View Mode again
  • Subfolders and archives are ignored in navigating by mouse buttons
Wed, Sep 19, 3:55 PM · Gwenview

Tue, Sep 18

ngraham accepted D15455: Fix orientation when saving/transforming JPEG images.

Sorry for the extended review time. It's just not the same since @rkflx left :(

Tue, Sep 18, 1:57 PM · Gwenview
muhlenpfordt added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Issues in Browse mode persist without the patch, you can click with Forward/Backward button over image, it's selected.

Tue, Sep 18, 9:57 AM · Gwenview
muhlenpfordt updated the diff for D15398: Use FlowLayout for Crop toolbar.

Set background in tool container (fixes slide out color change)
Use for instead of foreach loops

Tue, Sep 18, 8:34 AM · Gwenview
anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Issues in Browse mode persist without the patch, you can click with Forward/Backward button over image, it's selected.

Tue, Sep 18, 7:48 AM · Gwenview
muhlenpfordt added a comment to D15455: Fix orientation when saving/transforming JPEG images.

If there are no objections I'll commit this at end of the week.

Tue, Sep 18, 7:19 AM · Gwenview
muhlenpfordt updated the diff for D15455: Fix orientation when saving/transforming JPEG images.

Added comment and grouping

Tue, Sep 18, 7:18 AM · Gwenview
muhlenpfordt added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

What you expect to change on it?

Tue, Sep 18, 7:10 AM · Gwenview

Mon, Sep 17

anthonyfieroni edited reviewers for D14583: [MainWindow] Navigate through mouse forward/back buttons, added: muhlenpfordt; removed: rkflx.

What you expect to change on it?

Mon, Sep 17, 11:32 AM · Gwenview

Sun, Sep 16

huoni abandoned D11008: Fix issues regarding available operations being out of sync with selected image.

No time to look at this :(

Sun, Sep 16, 12:26 AM · Gwenview

Fri, Sep 14

tdarboux triaged T9674: Camera stores both jpeg and raw, handle both as one as Wishlist priority.
Fri, Sep 14, 12:21 PM · Gwenview
tdarboux added a watcher for Gwenview: tdarboux.
Fri, Sep 14, 9:54 AM
ngraham added a comment to D15398: Use FlowLayout for Crop toolbar.

Behavior seems perfect to me! Code review is not my strong suit but I'll give it a shot.

Fri, Sep 14, 3:02 AM · Gwenview

Wed, Sep 12

muhlenpfordt added a comment to D15455: Fix orientation when saving/transforming JPEG images.
Wed, Sep 12, 5:56 PM · Gwenview
muhlenpfordt added a comment to D15455: Fix orientation when saving/transforming JPEG images.

I noticed this bug report but can't confirm a change in JPEG quality or file size when saving (as the original reporter stated).
ATM the transformation is not done by just changing the Exif orientation as Christoph suggested, but by lossless data transformation.
So I think this patch does not really fix that bug.

Wed, Sep 12, 3:37 PM · Gwenview
ngraham added a comment to D15455: Fix orientation when saving/transforming JPEG images.

NIce catch. On another note, did 6597d3f35196 fix https://bugs.kde.org/show_bug.cgi?id=324597?

Wed, Sep 12, 3:27 PM · Gwenview
muhlenpfordt added a comment to D15455: Fix orientation when saving/transforming JPEG images.

A good set of sample images can be found here:
https://github.com/ianare/exif-samples/tree/master/jpg/orientation

Wed, Sep 12, 3:14 PM · Gwenview
muhlenpfordt requested review of D15455: Fix orientation when saving/transforming JPEG images.
Wed, Sep 12, 3:14 PM · Gwenview
ngraham added a comment to D13901: Touch support for Gwenview.

@muhlenpfordt, I can take point on the behavioral part of the review, but would appreciate your code expertise for the code review!

Wed, Sep 12, 12:01 AM · Gwenview

Tue, Sep 11

muhlenpfordt added a comment to D15398: Use FlowLayout for Crop toolbar.

Thanks, this looks like it'll be a nice improvement! I'll review soon.

Tue, Sep 11, 10:22 AM · Gwenview
muhlenpfordt updated the diff for D15398: Use FlowLayout for Crop toolbar.

Center all lines in multiline layout too
Readded original margin (Crop and RedEye toolbar)

Tue, Sep 11, 10:16 AM · Gwenview
muhlenpfordt added a comment to D13901: Touch support for Gwenview.

Sorry, forgot about your question here.
I have no touch hardware too but try to help out with the code part.

Tue, Sep 11, 7:51 AM · Gwenview

Mon, Sep 10

ngraham added a comment to D15398: Use FlowLayout for Crop toolbar.

Thanks, this looks like it'll be a nice improvement! I'll review soon.

Mon, Sep 10, 10:29 PM · Gwenview
volkov closed D15270: Don't show Plugins menu if built without KIPI support.
Mon, Sep 10, 11:44 AM · Gwenview
volkov closed D15271: Don't show empty Rating menu when built without semantic info backend.
Mon, Sep 10, 11:44 AM · Gwenview
muhlenpfordt accepted D15270: Don't show Plugins menu if built without KIPI support.
Mon, Sep 10, 11:29 AM · Gwenview
muhlenpfordt accepted D15271: Don't show empty Rating menu when built without semantic info backend.
Mon, Sep 10, 11:29 AM · Gwenview
volkov updated the diff for D15271: Don't show empty Rating menu when built without semantic info backend.

style fix

Mon, Sep 10, 10:17 AM · Gwenview
volkov updated the diff for D15270: Don't show Plugins menu if built without KIPI support.

style fix

Mon, Sep 10, 10:17 AM · Gwenview
volkov closed D15296: Use QOverload to select overloaded functions.
Mon, Sep 10, 10:13 AM · Gwenview
muhlenpfordt accepted D15296: Use QOverload to select overloaded functions.

Looks good to me. Compiles, works as before and enhances readability.

Mon, Sep 10, 9:48 AM · Gwenview
muhlenpfordt added a comment to D15398: Use FlowLayout for Crop toolbar.

I found no way to add a custom layout to Qt Designer, so CropWidget is now created in (not generated) code.

Mon, Sep 10, 8:39 AM · Gwenview
muhlenpfordt requested review of D15398: Use FlowLayout for Crop toolbar.
Mon, Sep 10, 8:38 AM · Gwenview

Fri, Sep 7

volkov added a comment to D15270: Don't show Plugins menu if built without KIPI support.

Right.

Fri, Sep 7, 3:58 PM · Gwenview
ngraham added a comment to D15270: Don't show Plugins menu if built without KIPI support.

Ah I see, if kipi support wasn't compiled in, then without this patch the menu will *always* be empty, right?

Fri, Sep 7, 3:14 PM · Gwenview
muhlenpfordt added a comment to D15270: Don't show Plugins menu if built without KIPI support.

But the menu isn't empty, is it? It has "Install Plugins" in it, which lets you populate it.

Fri, Sep 7, 2:41 PM · Gwenview
abetts added a comment to D15325: Set file name on print job.

+1

Fri, Sep 7, 2:02 PM · Gwenview
ngraham added a comment to D15270: Don't show Plugins menu if built without KIPI support.

But the menu isn't empty, is it? It has "Install Plugins" in it, which lets you populate it.

Fri, Sep 7, 1:42 PM · Gwenview
muhlenpfordt added a comment to D15270: Don't show Plugins menu if built without KIPI support.

The empty menu looked really odd.
Maybe it would be better to not only depend on KIPI's absence, but it's the only one using Plugins ATM and because of the delayed population it's a bit tricky to check for an empty menu.
So I think it's ok to hide it this way, if there are no objections from anybody else.

Fri, Sep 7, 12:22 PM · Gwenview
broulik closed D15325: Set file name on print job.
Fri, Sep 7, 9:55 AM · Gwenview
muhlenpfordt accepted D15325: Set file name on print job.

Looks good to me, printing to hardware and file shows the image name now.
Btw. there's a bug report for this: https://bugs.kde.org/show_bug.cgi?id=332207

Fri, Sep 7, 9:53 AM · Gwenview
broulik requested review of D15325: Set file name on print job.
Fri, Sep 7, 9:16 AM · Gwenview

Wed, Sep 5

volkov added a reviewer for D15296: Use QOverload to select overloaded functions: Gwenview.
Wed, Sep 5, 2:53 PM · Gwenview