GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Mon, Jun 10

ngraham added a comment to D21468: [WIP/RFC] Use Purpose for sharing.

Friendly ping!

Mon, Jun 10, 8:50 PM · Gwenview

Sun, Jun 9

aacid added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

Honestly i'd prefer if we wait for 5.10 and then use QMetaObject::invokeMethod instead of QTimer::singleShot.

Sun, Jun 9, 10:39 PM · Gwenview

Mon, Jun 3

ngraham added inline comments to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Mon, Jun 3, 3:41 PM · Gwenview

Sun, Jun 2

ngraham closed D21398: Correctly crop Sony's embedded thumbnails.
Sun, Jun 2, 9:23 PM · Gwenview
ngraham accepted D21398: Correctly crop Sony's embedded thumbnails.

Thanks!

Sun, Jun 2, 9:21 PM · Gwenview
tommo added inline comments to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sun, Jun 2, 5:51 AM · Gwenview

Sat, Jun 1

ngraham added inline comments to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sat, Jun 1, 10:08 PM · Gwenview
tommo added a comment to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.

Need to postpone this until end of June.

Sat, Jun 1, 11:46 AM · Gwenview
tommo updated the diff for D21398: Correctly crop Sony's embedded thumbnails.

Constness.

Sat, Jun 1, 11:44 AM · Gwenview

Tue, May 28

ngraham requested changes to D21468: [WIP/RFC] Use Purpose for sharing.

Spectacle also supports both. We could probably do the same here in the meantime. I'm fine with replacing the current toolbar button with this though; it's much more useful, and Kipi still gets its own menu. Please also add the new action's to the file menu, context menu, and Operations panel. That way it's still accessible for people who don't want it in the toolbar.

Tue, May 28, 9:15 PM · Gwenview
nicolasfella requested review of D21468: [WIP/RFC] Use Purpose for sharing.
Tue, May 28, 8:28 PM · Gwenview

Sun, May 26

ngraham added a dependency for D21407: Disable smoothing thumbnails in LowResourceUsageMode: D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sun, May 26, 3:55 PM · Gwenview
ngraham added a dependent revision for D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode: D21407: Disable smoothing thumbnails in LowResourceUsageMode.
Sun, May 26, 3:55 PM · Gwenview
ngraham requested changes to D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.

By renaming the config name in gwenviewconfig.kcfg, you'll reset existing users' preferences. Whenever you want to rename a key in a config file, you need to ship a kconfig update script to update existing users' config files. Look at the contents of the kconf_update folder in the source tree for an example of an existing one. And here's the documentation: https://techbase.kde.org/Development/Tools/Using_kconf_update

Sun, May 26, 3:53 PM · Gwenview
ngraham added a comment to D21398: Correctly crop Sony's embedded thumbnails.

All of these new variables can be const

Sun, May 26, 3:43 PM · Gwenview

Sat, May 25

tommo added a comment to D21407: Disable smoothing thumbnails in LowResourceUsageMode.

...also a blurred thumbnail suggests that the image is defocused.

Sat, May 25, 3:39 PM · Gwenview
tommo updated the diff for D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sat, May 25, 3:37 PM · Gwenview
tommo updated the summary of D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sat, May 25, 3:36 PM · Gwenview
tommo requested review of D21407: Disable smoothing thumbnails in LowResourceUsageMode.
Sat, May 25, 3:36 PM · Gwenview
tommo requested review of D21406: Rename DeleteThumbnailCacheOnExit -> LowResourceUsageMode.
Sat, May 25, 3:34 PM · Gwenview
tommo added a comment to D21398: Correctly crop Sony's embedded thumbnails.

E.g.:

Sat, May 25, 12:49 PM · Gwenview
tommo requested review of D21398: Correctly crop Sony's embedded thumbnails.
Sat, May 25, 12:38 PM · Gwenview
tommo added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

I haven't checked which folder Gwenview actually tries to delete, but the thumbnails are stored in ~/.cache/thumbnails instead of ~/.thumbnails.

Sat, May 25, 3:32 AM · Documentation, Gwenview

Fri, May 24

cfeck added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Regarding astyle, see https://cgit.kde.org/kde-dev-scripts.git/commit/?id=e93a28b3eb153695e8edb7ae259243b7b409a29d

Fri, May 24, 5:00 PM · Documentation, Gwenview
cfeck added inline comments to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Fri, May 24, 4:55 PM · Documentation, Gwenview
ngraham closed D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Fri, May 24, 4:37 PM · Documentation, Gwenview
ngraham accepted D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Fri, May 24, 4:36 PM · Documentation, Gwenview
ngraham closed D21284: Accelerate thumnailgenerator when loading RAW files.
Fri, May 24, 3:52 PM · Gwenview
ngraham accepted D21284: Accelerate thumnailgenerator when loading RAW files.
Fri, May 24, 3:51 PM · Gwenview
ngraham closed D21285: Remove redundant QImage::loadFromData().
Fri, May 24, 3:47 PM · Gwenview
ngraham accepted D21285: Remove redundant QImage::loadFromData().
Fri, May 24, 3:46 PM · Gwenview
ngraham closed D21337: Do not re-use previously generated thumbnails in case of error.
Fri, May 24, 3:44 PM · Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

You guys really have to setup clang-format or astyle to automate those whitespace formatting issues, IMO.

Fri, May 24, 3:28 PM · Documentation, Gwenview
ngraham added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Thanks, just one last little thing...

Fri, May 24, 3:07 PM · Documentation, Gwenview
ngraham retitled D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small from Use the embedded thumbnail for preview even if it's too small to Optionally use images' embedded thumbnails for greater performance, even if they're too small.
Fri, May 24, 3:04 PM · Documentation, Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Fix unit test.

Fri, May 24, 8:45 AM · Documentation, Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Sry, I missed that.

Fri, May 24, 5:55 AM · Documentation, Gwenview
ngraham added a comment to D21285: Remove redundant QImage::loadFromData().

It's on my to-do list, I'll take a look tomorrow!

Fri, May 24, 4:52 AM · Gwenview
ngraham accepted D21337: Do not re-use previously generated thumbnails in case of error.
Fri, May 24, 4:52 AM · Gwenview

Thu, May 23

ngraham added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Thanks. To account for this behavioral change, I think we need to adjust the UI strings in the settings window as well. Did my suggestion above make sense?

Thu, May 23, 7:20 PM · Documentation, Gwenview
ngraham closed D21329: Correctly crop embedded thumbs for Canon JPEGs.
Thu, May 23, 7:06 PM · Gwenview
ngraham accepted D21329: Correctly crop embedded thumbs for Canon JPEGs.

Ahh whatever, this is fine as-is then.

Thu, May 23, 7:02 PM · Gwenview
tommo updated the diff for D21329: Correctly crop embedded thumbs for Canon JPEGs.
Thu, May 23, 2:45 PM · Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Sry, I should really enable Kate's spell checking.

Thu, May 23, 6:58 AM · Documentation, Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
Thu, May 23, 6:49 AM · Gwenview
yurchor added a comment to D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Thanks in advance for fixing this minor typo.

Thu, May 23, 6:46 AM · Documentation, Gwenview
tommo updated subscribers of D21285: Remove redundant QImage::loadFromData().

@ngraham Missed?

Thu, May 23, 6:32 AM · Gwenview
tommo updated subscribers of D21284: Accelerate thumnailgenerator when loading RAW files.

@ngraham Missed?

Thu, May 23, 6:32 AM · Gwenview
tommo updated the diff for D21330: Optionally use images' embedded thumbnails for greater performance, even if they're too small.

Docs updated. Need to apply https://phabricator.kde.org/D21329 first, to avoid conflict.

Thu, May 23, 6:30 AM · Documentation, Gwenview
tommo updated the diff for D21337: Do not re-use previously generated thumbnails in case of error.
Thu, May 23, 4:53 AM · Gwenview