Oy gevalt! Nice catch.
Thu, Feb 6
I'm closing this issue for now because from my point of view the core issue seems to be sufficiently dealt with.
Wed, Jan 29
Jan 9 2020
Also check prevWidth
Oh, good spot. I haven't considered malformed zero-size thumbnails, indeed.
In this case, you should also check for prevWidth > 0, otherwise scale
would become zero and we would have another div-by-zero.
Jan 8 2020
Thanks, that worked. I'm landing your patch now. Nice job, may it be the first of many!
I was trying to avoid it, mostly due to possible spambot reasons, so I tried arc. If it still doesn't work, then I will post a comment with it. I'll be sure to use arc next time from the beginning. Apologies again.
Use arc to submit the patch
Just mention it in a comment here. For silly reasons, Phabricator disregards authorship in patches submitted using the web interface. It really wants you to use its arc command-line tool.
Use git format-patch to hopefully add author information
Thanks for the patch! Works for me. Can you provide your email address so we can land it with correct authorship information?
Jan 7 2020
Jan 5 2020
Dupe of D26349, not sure what happened
Jan 4 2020
Jan 3 2020
rebase onto separated cleanup commit
+1 to everything @kossebau said, then shipit
Jan 2 2020
Have not tested. Looks good code-wise, is what I would have done.
Jan 1 2020
Also needs JSON metadata
Dec 27 2019
Dec 26 2019
May it be the first of many. :)
Very nice change, and very nice first patch! I love it when something like this is simple.
Dec 21 2019
Dec 3 2019
I will follow up, as promised, with a patch to refactor the internationalization of the info/warning/error messages.
- Use single arg fucntion
Thanks, looking better! When you edit app/gwenviewui.rc, you need to bump the version number that's at the top of the file. In addition, I added some inline comments that need to be addressed: