Sweet, will add the dep in another patch.
FTR: kra support comes from kimageformats plugins to qimage. so do other already listed mimetypes though - it's fine.
Rebase on current master
Clever! Works great.
Just noticed this: should similar support be added into gvpart.desktop too?
Wed, Feb 13
Tue, Feb 12
modify existing desktop file instead of installing a new one
Mon, Feb 11
@steffenh thanks for your patience here, and I'm sorry this hasn't landed yet. Could you rebase it on current master please? I'll redouble my efforts to test and rustle up some code reviewers for you.
Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.
Gwenview supports these formats only when it is built with KDcraw.
I used the approach from okular: when okular is built with support for a set of formats, then a separate desktop file is installed for them.
And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.
Sat, Feb 9
Does Gwenview actually support all these file formats? If so, why can't we add their mimetypes to the pre-existing desktop file?
Please do not add the translations manually, as they are handled by scripty automatically.
Fri, Feb 8
Mon, Feb 4
Use CTRL + SHIFT + R
No, I meant change the "rotate left" shortcut to ctrl+⇧+r.
Change rotate left action's default shortcut to CTRL + SHIFT + L
Nice can confirm that it works now. Perhaps we should change the "rotate left" shortcut to ctrl+⇧+r?
Sat, Feb 2
This version now works as expected, but now CTRL + L shortcut for replaceLocation action is an ambiguous shortcut with rotate left action. Please give me some suggestions, whether to change this shortcut or rotate left shortcut.
Fix connect error
@ngraham thanks for reply, btw can you also reply to my inline comment at 394, I think thats perfectly valid connect syntax, still error is seen.
Fri, Feb 1
Wed, Jan 30
Jan 20 2019