GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Yesterday

rkflx added a comment to D11877: Allow dragging from View mode to external applications.

The cursor problem is kind of solved. There is still some flickering sometimes.

Nice. Let me look into this in the next days, then we can decide whether we can fix things now or simply open a bug to work on it later…

Thu, Jun 21, 11:25 PM · Gwenview

Tue, Jun 19

rkflx requested changes to D11877: Allow dragging from View mode to external applications.

We are pretty close now, just some final polishing 👍

Tue, Jun 19, 10:25 PM · Gwenview

Sun, Jun 10

huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • Remove redundent comments
  • Improve variable naming, code readability
Sun, Jun 10, 12:15 AM · Gwenview

Sat, Jun 9

huoni added a comment to D11877: Allow dragging from View mode to external applications.

ThumbnailProvider worked nicely. I was initially put off by the complicated use in ThumbnailView which is why I didn't try it to begin with.

Sat, Jun 9, 3:18 AM · Gwenview
huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • Clean up KFileItemList code
Sat, Jun 9, 3:13 AM · Gwenview
huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • Change to using ThumbnailProvider to generate drag pix
  • Fix stuck cursor after dragging an image
Sat, Jun 9, 3:04 AM · Gwenview

Fri, Jun 8

huoni planned changes to D11877: Allow dragging from View mode to external applications.

Just one note regarding KIO::PreviewJob: This is only a small part of ThumbnailProvider, which seems to contain lots of additional code for special cases. For example this can be observed for fish://, where your approach fails to provide a pixmap, while you'd get a proper thumbnail when dragging from the Thumbnail Bar. I'm sure there are many more cases.

Would it be possible to create a new ThumbnailProvider upon initiating the drag, connect its thumbnailLoaded signal to setPixmap, and then appendItems? That would be the next thing I would try, as it uses proven code and avoids creating a thumbnail when not starting to drag at all.

Fri, Jun 8, 11:06 PM · Gwenview
rkflx added a comment to D11877: Allow dragging from View mode to external applications.
  • Don't drag if document failed to load
  • Update to use MimeTypeUtils::selectionMimeData
  • Respect mimimum drag distance
  • Use DragPixmapGenerator
Fri, Jun 8, 12:59 PM · Gwenview

Mon, Jun 4

rkflx closed D13213: Add possibility to sort by descending order.
Mon, Jun 4, 7:07 PM · Gwenview

Sun, Jun 3

huoni added a comment to D11877: Allow dragging from View mode to external applications.

Thanks for the update ;)

Any ideas would be helpful.

I'll try to look into it later.

Sun, Jun 3, 10:57 AM · Gwenview
rkflx added a comment to D11879: Allow dragging files/folders to View mode.

@huoni The bug reporter likes your patch 👍: https://bugs.kde.org/show_bug.cgi?id=169408#c8

Sun, Jun 3, 10:40 AM · Gwenview
rkflx added a comment to D11877: Allow dragging from View mode to external applications.

Thanks for the update ;)

Sun, Jun 3, 6:28 AM · Gwenview
huoni added a comment to D11877: Allow dragging from View mode to external applications.

I kept everything in DocumentView because I wanted to support dragging a video.

Sun, Jun 3, 6:20 AM · Gwenview
rkflx closed D13197: Prompt to install kipi-plugins when the share button is clicked .
Sun, Jun 3, 6:19 AM · Gwenview
huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • Don't drag if document failed to load
  • Update to use MimeTypeUtils::selectionMimeData
  • Respect mimimum drag distance
  • Use DragPixmapGenerator
Sun, Jun 3, 6:17 AM · Gwenview

Sat, Jun 2

huoni closed D11879: Allow dragging files/folders to View mode.
Sat, Jun 2, 11:31 PM · Gwenview
faridb added a comment to D13213: Add possibility to sort by descending order.

@rkflx Thanks for reviewing and accepting the patch! This is my second patch and your feedback and your advices are encouraging me to keep contributing :-).

Sat, Jun 2, 10:53 PM · Gwenview
rkflx accepted D13213: Add possibility to sort by descending order.

Excellent. I tested everything again, and the issue with the folders not appearing first anymore is now solved.

Sat, Jun 2, 10:18 PM · Gwenview
faridb updated the diff for D13213: Add possibility to sort by descending order.

I made the changes you requested in your inline comments.

Sat, Jun 2, 9:54 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

I updated the summary. Is it a suitable commit message?

Sat, Jun 2, 8:52 PM · Gwenview
faridb added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

I updated the summary. Is it a suitable commit message?

Sat, Jun 2, 8:45 PM · Gwenview
faridb updated the summary of D13197: Prompt to install kipi-plugins when the share button is clicked .
Sat, Jun 2, 8:40 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Ah, one more thing: You might want to update the summary a bit to reflect the current state of the patch, as it will become the commit message. Simply click on Edit Revision on the top.

Sat, Jun 2, 8:32 PM · Gwenview
rkflx accepted D13197: Prompt to install kipi-plugins when the share button is clicked .

I created a separate Diff for the bug fix at D13289.

Sat, Jun 2, 8:30 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

I created a separate Diff for the bug fix at D13289.

Sat, Jun 2, 8:27 PM · Gwenview
rkflx added a comment to D13213: Add possibility to sort by descending order.

Great, LGTM now except for two minor comments.

Sat, Jun 2, 6:56 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Rebase on D13252

Sat, Jun 2, 6:56 PM · Gwenview
rkflx added inline comments to D11879: Allow dragging files/folders to View mode.
Sat, Jun 2, 6:56 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Rebase on D13252

Sat, Jun 2, 6:25 PM · Gwenview
faridb added a dependent revision for D13213: Add possibility to sort by descending order: D13283: Add possibility to sort folders first.
Sat, Jun 2, 12:16 PM · Gwenview
faridb updated the diff for D13213: Add possibility to sort by descending order.

Thanks for your detailed feedback! I have made the changes you have requested in your inline comments.
I have also added the ability to sort folders first but I will create a separate revision for that.

Sat, Jun 2, 10:38 AM · Gwenview
rkflx accepted D11879: Allow dragging files/folders to View mode.

Thanks, LGTM now :)

Sat, Jun 2, 6:06 AM · Gwenview

Fri, Jun 1

huoni added a comment to D11879: Allow dragging files/folders to View mode.

But there's one problem I haven't been able to solve - accepting drops when a video is displayed. Something to do with QGraphicsProxyWidget not forwarding the events, or something along those lines. I'm not sure if this is a show stopper though, given Gwenview's primarily an image viewer, not a video viewer.

Hm, adding the corresponding override I could get it to show the "accept" cursor briefly, but then it crashed in some kind of endless event loop. Let's not worry about it.

Fri, Jun 1, 11:33 PM · Gwenview
huoni updated the diff for D11879: Allow dragging files/folders to View mode.
  • const
  • Remove unnecessary QObject::
  • Call QGraphicsWidget instead of QGraphicsItem in drag events
  • Rebase
Fri, Jun 1, 11:31 PM · Gwenview
rkflx requested changes to D13213: Add possibility to sort by descending order.

Thanks again for the patch, works great for folders with only images in them and even title/summary/test plan are looking excellent.

Fri, Jun 1, 8:35 PM · Gwenview

Thu, May 31

rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Hm, I don't really like leaking that implementation detail. Let me think about an alternative way.

Thu, May 31, 7:12 PM · Gwenview
rkflx added a comment to D11877: Allow dragging from View mode to external applications.

I also think waiting until we can put the mimedata code in a central place is a good idea. I think Document::mimeData could be a good spot?

Sneak peak: P225

@huoni I hope passing a KFileItemList will work for your case too?

Thu, May 31, 7:10 PM · Gwenview

Wed, May 30

ngraham added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

appstream://photolayoutseditor.desktop

I wonder whether it would be feasible to ship something like kipi-plugins.desktop via upstream R480 Kipi Plugins? (Just an idea in case someone wants to investigate that, I don't have time to work in it right now.)

Wed, May 30, 11:40 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

I wonder whether it would be feasible to ship something like kipi-plugins.desktop via upstream R480 Kipi Plugins? (Just an idea in case someone wants to investigate that, I don't have time to work in it right now.)

Wed, May 30, 10:49 PM · Gwenview
ngraham added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Reading the commit history of that feature, this looks more like something which was added with packaging of a particular distro in mind. Why would this be called "photolayoutseditor" anyway, when that plugin is only part of a much larger set of plugins? Also, the description looks quite broken in Discover on that distro, while on other distros the description of the regular "kipi-plugins" package is perfectly reasonable.

Wed, May 30, 10:05 PM · Gwenview
D13197: Prompt to install kipi-plugins when the share button is clicked now requires review to proceed.

@faridb Awesome, works great. @ngraham already provided some valuable feedback, there's only one thing I'm hesitant about (see inline comment).

Wed, May 30, 9:56 PM · Gwenview
rkflx added a comment to D13213: Add possibility to sort by descending order.

@faridb Thanks for your patches, I'll have a look on this one in the next days.

Wed, May 30, 9:55 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Fixed the coding style issue

Wed, May 30, 6:59 PM · Gwenview
ngraham accepted D13197: Prompt to install kipi-plugins when the share button is clicked .

Thanks, this seems like a much cleaner and more appropriate approach to me. Just one more minor style nitpick below, then I'm satisfied!

Wed, May 30, 6:53 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Made the changes to use mInstallPluginAction instead of the action's text.
It also solved the bug I was having with the Plugins menu.

Wed, May 30, 6:38 PM · Gwenview
ngraham added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

That might be more reliable and semantically correct, so let's try it out and see if we like it!

Wed, May 30, 6:18 PM · Gwenview
faridb added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Thanks! One more thought: instead of comparing the action's text, could we compare the action itself, to see if it's mInstallPluginAction?

Wed, May 30, 6:11 PM · Gwenview
ngraham added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Thanks! One more thought: instead of comparing the action's text, could we compare the action itself, to see if it's mInstallPluginAction?

Wed, May 30, 5:53 PM · Gwenview
xyquadrat added a reviewer for D13213: Add possibility to sort by descending order: Gwenview.

I think you forgot to specify reviewers, so I added them for you.

Wed, May 30, 2:34 PM · Gwenview
faridb requested review of D13213: Add possibility to sort by descending order.
Wed, May 30, 1:40 PM · Gwenview