GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Yesterday

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Searching and debugging and I just can't find the reason why.
So currently the counter works fine when the first image of a folder is opened and THEN one goes into fullscreen. But if one goes directly into fullscreen with the first image loaded, than it sets the counter to 0.

Fri, Oct 18, 10:44 PM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Removed comment that was used for the timer

Fri, Oct 18, 10:38 PM · Gwenview

Wed, Oct 16

ngraham added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Go ahead, take your time. :)

Wed, Oct 16, 5:52 PM · Gwenview
aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Did you mean to remove the timer in this patch?

Wed, Oct 16, 5:48 PM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Remove timer. Use simple method call instead.

Wed, Oct 16, 5:46 PM · Gwenview
ngraham added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Did you mean to remove the timer in this patch?

Wed, Oct 16, 5:22 PM · Gwenview
aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Reverted the timer to 0.
Now it works when switching to fullscreen. Next step: make the counter work properly when -f for fullscreen is used.

Wed, Oct 16, 10:57 AM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Revert timer and add additional updateDocumentCountLabel call

Wed, Oct 16, 10:55 AM · Gwenview

Tue, Oct 15

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

And if updating the current index takes longer than 250 msec it would fail again, wouldn't it?

Probably, I can't get to that case where it's so slow. But I am aware that it can happen.

Tue, Oct 15, 8:17 PM · Gwenview

Mon, Oct 14

tommo added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

And if updating the current index takes longer than 250 msec it would fail again, wouldn't it?

Mon, Oct 14, 4:31 PM · Gwenview

Sun, Oct 13

apol added a comment to D24576: Don't link directly against Purpose for sharing.

I don't really understand. What Purpose dependency actually bothers you?

Sun, Oct 13, 11:00 PM · Gwenview
aprcela requested review of D24622: Proper numbering on first image in folder when using Fullscreen mode.
Sun, Oct 13, 10:38 PM · Gwenview
aprcela added a watcher for Gwenview: aprcela.
Sun, Oct 13, 9:45 PM
davidedmundson added a comment to D17732: Respect animation settings.

Something like this I think should work:

Sun, Oct 13, 2:32 AM · Gwenview
ngraham added reviewers for D24576: Don't link directly against Purpose for sharing: nicolasfella, apol.

This results in the purpose functionality disappearing even though I have Purpose installed.

Sun, Oct 13, 2:23 AM · Gwenview
ngraham added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

That was the plan, but I don't have a dev environment for plasma set up, and submitting patches that don't even compile is a bit embarrassing. :-)

But fixing that should fix animations in other Qt apps with custom widgets as well.

Sun, Oct 13, 2:08 AM · Gwenview

Sat, Oct 12

tommo added a comment to D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".

Oh, I didn't know about that, thx for the hint. Will see how it can be integrated.

Sat, Oct 12, 1:00 PM · Gwenview

Fri, Oct 11

sandsmark added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

Fri, Oct 11, 9:44 PM · Gwenview
sandsmark added a comment to D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".

Any reason not to use kexiv2?

Fri, Oct 11, 9:42 PM · Gwenview
sandsmark updated the diff for D24576: Don't link directly against Purpose for sharing.
Fri, Oct 11, 9:38 PM · Gwenview
sandsmark requested review of D24576: Don't link directly against Purpose for sharing.
Fri, Oct 11, 9:34 PM · Gwenview
ngraham added a comment to D17732: Respect animation settings.

Please feel free to send a Plasma patch!

Fri, Oct 11, 8:01 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

Something like this I think should work:

Fri, Oct 11, 7:39 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

In fact we now have a shiny new global animation slider in the General Behavior KCM. If you change the patch to make Gwenview respect that setting, I'll be happy with it.

Do you know what that adjusts? If it adjusts the normal Qt animation hints/properties like QStyle::SH_Widget_Animation_Duration this patch Should Just Work™.

Fri, Oct 11, 7:29 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

In fact we now have a shiny new global animation slider in the General Behavior KCM. If you change the patch to make Gwenview respect that setting, I'll be happy with it.

Fri, Oct 11, 7:12 PM · Gwenview
sandsmark closed D24364: Fix crash with animations disabled.

Already fixed with another approach in master.

Fri, Oct 11, 7:10 PM · Gwenview

Wed, Oct 9

ngraham updated subscribers of D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".

Wow, a very ambitious change.

Wed, Oct 9, 3:48 PM · Gwenview
tommo requested review of D24521: [RFC] Remove JpegContent class, replace with "Exiv2Content".
Wed, Oct 9, 2:47 PM · Gwenview

Sat, Oct 5

ngraham accepted D24364: Fix crash with animations disabled.
Sat, Oct 5, 1:51 PM · Gwenview
ngraham added a comment to D24364: Fix crash with animations disabled.

Gwenview does not crash after the patch, but still animates the GIF's when "None" for animation is checked in the settings. Is this expected?

Sat, Oct 5, 1:50 PM · Gwenview
yurchor added a comment to D24364: Fix crash with animations disabled.

Gwenview does not crash after the patch, but still animates the GIF's when "None" for animation is checked in the settings. Is this expected?

Sat, Oct 5, 12:36 PM · Gwenview
sandsmark added reviewers for D24364: Fix crash with animations disabled: mlaurent, meven, ngraham, yurchor, tommo.
Sat, Oct 5, 9:42 AM · Gwenview

Wed, Oct 2

ngraham added a watcher for Gwenview: ngraham.
Wed, Oct 2, 9:33 PM
ngraham added a comment to D17732: Respect animation settings.

In fact we now have a shiny new global animation slider in the General Behavior KCM. If you change the patch to make Gwenview respect that setting, I'll be happy with it.

Wed, Oct 2, 9:25 PM · Gwenview
ngraham closed D24290: Remove extra pixel when cropping with an aspect ratio.
Wed, Oct 2, 5:07 PM · Gwenview
sandsmark updated the diff for D17732: Respect animation settings.
Wed, Oct 2, 2:36 PM · Gwenview
sandsmark requested review of D24364: Fix crash with animations disabled.
Wed, Oct 2, 2:28 PM · Gwenview
ngraham closed D24309: Change UI for setting jpeg quality to slider.
Wed, Oct 2, 1:50 PM · Gwenview
ngraham accepted D24290: Remove extra pixel when cropping with an aspect ratio.
Wed, Oct 2, 1:45 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

However, I'm seeing that this appears to always disable all animations for me, no matter what value the animation speed is set up in the Breeze style settings:

Wed, Oct 2, 1:35 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.

As for the discussion above, I don't see how plasma-integration is relevant. It does control QStyleHints, but you're not using any of that.
Everything you use here comes from the QStyle which is all from Breeze.

Wed, Oct 2, 1:21 PM · Gwenview
MrPepe added a comment to D24309: Change UI for setting jpeg quality to slider.

I'm in China and the arcanist download takes forever and then fails.

Wed, Oct 2, 1:07 AM · Gwenview

Tue, Oct 1

ngraham added a reviewer for D24290: Remove extra pixel when cropping with an aspect ratio: Gwenview.
Tue, Oct 1, 11:01 PM · Gwenview
ngraham accepted D24309: Change UI for setting jpeg quality to slider.

Thanks, this is lovely. Much better. Can you provide an email address so I can land the patch with correct git authorship information?

Tue, Oct 1, 7:53 PM · Gwenview
MrPepe updated the diff for D24309: Change UI for setting jpeg quality to slider.

Replaced the Label with a SpinBox

Tue, Oct 1, 5:19 AM · Gwenview
MrPepe added a comment to D24309: Change UI for setting jpeg quality to slider.

Removed the explicit call to GwenviewConfig::setJPEGQuality().
Still works.

Tue, Oct 1, 1:01 AM · Gwenview
MrPepe updated the diff for D24309: Change UI for setting jpeg quality to slider.
Tue, Oct 1, 12:58 AM · Gwenview

Mon, Sep 30

ngraham added reviewers for D24309: Change UI for setting jpeg quality to slider: VDG, Gwenview.
Mon, Sep 30, 8:48 PM · Gwenview
ngraham requested changes to D24309: Change UI for setting jpeg quality to slider.

On one hand, a slider looks nicer and it's easier to set gross values, but the lack of a text input field makes it harder to enter precise values. I wonder if we should replace the label that's next to the slider with an text field. That way we'd get the best of both worlds (and then we'd do this for Spectacle too).

Mon, Sep 30, 8:48 PM · Gwenview
MrPepe requested review of D24309: Change UI for setting jpeg quality to slider.
Mon, Sep 30, 12:35 PM · Gwenview