Mon, Dec 17
I prefer this style too, but KDE coding style says to use "QWidget *mFooWidget;" (*& always to the right)
This is not struct to conform to it, the basic formula is to see the surrounding code and follow the same coding style.
I found no way to add a custom layout to Qt Designer
Sorry for taking so long on this! Feel free to land at any time.
Will test again after you land D15612
Sat, Dec 8
Fri, Nov 30
Tue, Nov 20
Hm... I guess this would be good to have in Krita, too, which also has a findExiv2.cmake
Oct 17 2018
Oct 16 2018
Moved vertical item centering from CropWidget to FlowLayout
Removed some superfluous layout settings
Some style fixes
Oct 13 2018
Oct 12 2018
simplify, leave only invokeMethod() -> QTimer::singleShot() change
Oct 11 2018
Yes, but gwenview requires at least 5.9.
And code is longer with QMetaObject::invokeMethod, compare:
QTimer::singleShot(0, this, &FileOpsContextManagerItem::updateActions);
QMetaObject::invokeMethod(this, &FileOpsContextManagerItem::updateActions, Qt::QueuedConnection);
QMetaObject::invokeMethod takes function pointers since Qt 5.10
Oct 10 2018
Oct 9 2018
Just hijacking this Diff b/c I see several places where this can be improved :)
Oct 6 2018
Whoops, I had forgotten about that!
What's the difference to T9226?
Oct 2 2018
No objections from me. 🙂
Excellent. Final review, @muhlenpfordt?