Mon, Mar 19
Started to think about this, but then got really confused. I'm not even sure what state the buttons should have in every possible situation, i.e. what is a bug and what is a feature 🙄. The elephant in the room here is Configure → Image View → Keep same zoom and position, and this might also be related to D10897: Enlarge smaller images by default.
Sat, Mar 17
Thu, Mar 15
Follow-up remark: I just found some flaw in KDE Connect's MPRIS controller plugin, on discovering a new MPRIS service it seems to not properly init to existing Can* flags of the player, only handles change signals. Which existing media players seem to send a lot :) Hopefully can get a fix done and in for kdeconnect-kde 1.2.2, whenever that will appear.
DesktopEntry property only with Qt >=5.7
Thanks so much, Friedrich. Latest changes work great, only one more small thing found (but solvable, I guess).
Wed, Mar 14
add missing init of mScreenSaverInterface
add listener for screenlock, based on kwin's ScreenLockerWatcher, and
unregister MPRIS if in locked screen mode
Simple change - but feels more convenient this way. 👍
Looks good to me too, and works great!
Perfect. I'll leave it open for a day or two to give others a chance to comment. In case there are no objections, I'll land the patch on your behalf.
(images comparing before and after)
fix last code update into compilable/working version
- use folder name as "album title"
- set also xesam:userRating
- remove no longer needed indexOfUrl method
- if !fullscreen, be in stopped mode
have some old music videos directories which I sometimes play just for the music
Haha, I should not have scrolled to the end of the Diff again…
Thanks for the updates, works even neater than before ;) Changes to the code look good to me (even though you sneaked in more changes than announced, making me wonder whether some parts could be shared with other users like Okular in the future…).
Tue, Mar 13
Mon, Mar 12
The title updates correctly when selecting the image by mouse click.
But when adding or removing images to the multi view or while resizing the window (zoom factor change) the title does not always stick to the selected image.
Sat, Mar 10
Nice focused change. The test plan works for me, and some quick spot-checks of existing focus-related functionality all still work:
- Switch between images
- Rename an image
- Copy and navigate to copied image
Tue, Mar 6
- Remove unwanted blank line
Thanks for working on this ;)