GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Mon, Apr 8

volkov closed D20251: Drop unnecessary PaintUtils::containingRect().
Mon, Apr 8, 5:12 PM · Gwenview
volkov updated subscribers of D20251: Drop unnecessary PaintUtils::containingRect().

Well, actually, it was caught by @hetzenecker: https://phabricator.kde.org/D7581?id=22415#change-vIXPDUvyb3sZ

Mon, Apr 8, 5:12 PM · Gwenview
ngraham accepted D20251: Drop unnecessary PaintUtils::containingRect().

Nice catch!

Mon, Apr 8, 1:33 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

You are welcome!
I started to implement highdpi support from scratch, but then I found this change and it was a huge help!

Mon, Apr 8, 12:54 PM · Gwenview
volkov updated the diff for D20251: Drop unnecessary PaintUtils::containingRect().

re-target to master

Mon, Apr 8, 11:22 AM · Gwenview

Sun, Apr 7

hetzenecker added a comment to D7581: HiDPI Support for Gwenview.

Wow, it's so great to see this finally merged.
@volkov - a huge thank you that you took over this patch and for all the work you put in to finally resolve this.

Sun, Apr 7, 9:36 PM · Gwenview
ngraham closed D20267: Add HiDPI support for thumbnails.
Sun, Apr 7, 2:09 PM · Gwenview
ngraham accepted D20267: Add HiDPI support for thumbnails.
Sun, Apr 7, 2:01 PM · Gwenview

Sat, Apr 6

volkov updated the diff for D20267: Add HiDPI support for thumbnails.

small fixes

Sat, Apr 6, 9:34 AM · Gwenview

Fri, Apr 5

ngraham accepted D20267: Add HiDPI support for thumbnails.

Thanks, this looks perfect now.

Fri, Apr 5, 8:34 PM · Gwenview
ngraham updated the summary of D20267: Add HiDPI support for thumbnails.
Fri, Apr 5, 8:28 PM · Gwenview
volkov updated the diff for D20267: Add HiDPI support for thumbnails.

fixed

Fri, Apr 5, 6:59 PM · Gwenview
ngraham added a comment to D20267: Add HiDPI support for thumbnails.

Thanks for the patch!

Fri, Apr 5, 3:36 PM · Gwenview
volkov added a reviewer for D20267: Add HiDPI support for thumbnails: Gwenview.
Fri, Apr 5, 1:47 PM · Gwenview
volkov requested review of D20267: Add HiDPI support for thumbnails.
Fri, Apr 5, 1:46 PM · Gwenview

Thu, Apr 4

volkov added a reviewer for D20251: Drop unnecessary PaintUtils::containingRect(): Gwenview.
Thu, Apr 4, 3:13 PM · Gwenview
volkov requested review of D20251: Drop unnecessary PaintUtils::containingRect().
Thu, Apr 4, 3:12 PM · Gwenview
volkov closed D7581: HiDPI Support for Gwenview.
Thu, Apr 4, 2:41 PM · Gwenview
ngraham added a comment to D7581: HiDPI Support for Gwenview.

@volkov Go for it!

Thu, Apr 4, 1:32 PM · Gwenview
ngraham accepted D7581: HiDPI Support for Gwenview.
Thu, Apr 4, 1:16 PM · Gwenview
ngraham added a reviewer for D7581: HiDPI Support for Gwenview: Gwenview.
Thu, Apr 4, 1:16 PM · Gwenview
ngraham accepted D7581: HiDPI Support for Gwenview.
Thu, Apr 4, 1:15 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

add a comment about turning off opacity effect

Thu, Apr 4, 12:11 PM · Gwenview

Wed, Apr 3

ngraham added a comment to D7581: HiDPI Support for Gwenview.

A surprisingly clean diff. Very nice.

Wed, Apr 3, 8:51 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

D9078 should fix thumbnails.

Wed, Apr 3, 4:11 PM · Gwenview
ngraham added a comment to D7581: HiDPI Support for Gwenview.

Nice to see this. It's definitely better than nothing, but HiDPI support for the thumbnails would be nice too. :)

Wed, Apr 3, 3:45 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

turn off opacity effect for highdpi with Qt < 5.12.4

Wed, Apr 3, 3:26 PM · Gwenview
volkov added inline comments to D7581: HiDPI Support for Gwenview.
Wed, Apr 3, 11:16 AM · Gwenview

Tue, Apr 2

davidedmundson added inline comments to D7581: HiDPI Support for Gwenview.
Tue, Apr 2, 5:35 PM · Gwenview
volkov added a comment to D7581: HiDPI Support for Gwenview.

Currently there is a bug in Qt which makes QGraphicsOpacityEffect not working: https://codereview.qt-project.org/#/c/257946/

Tue, Apr 2, 5:06 PM · Gwenview
volkov updated the diff for D7581: HiDPI Support for Gwenview.

rebase + refactoring

Tue, Apr 2, 5:02 PM · Gwenview

Sat, Mar 23

aacid closed D19993: Fix -Wreturn-type warning for jpeg version check.
Sat, Mar 23, 5:05 PM · Gwenview
aacid accepted D19993: Fix -Wreturn-type warning for jpeg version check.

i'll land it in a minute

Sat, Mar 23, 5:03 PM · Gwenview
i.Dark_Templar requested review of D19993: Fix -Wreturn-type warning for jpeg version check.
Sat, Mar 23, 12:13 PM · Gwenview

Mar 16 2019

ngraham added a comment to D13901: Touch support for Gwenview.

No worries, and thanks for the attempt! Once they're in, that'll really help other QWidgets-based KDE apps.

Mar 16 2019, 8:52 PM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

I started to transfer the gestures to the framework, but I cannot promise anything.

Mar 16 2019, 5:41 PM · Gwenview
ngraham added a comment to D13901: Touch support for Gwenview.

I imagine by adding what's here into the framework first, and then later raising the Gwenview frameworks dependency high enough and using them from there framework.

Mar 16 2019, 4:18 PM · Gwenview
sander added a comment to D13901: Touch support for Gwenview.

Thanks for the patch. How is the gesture code going to get into KWidgetAddons now?

Mar 16 2019, 2:44 PM · Gwenview
ngraham closed D13901: Touch support for Gwenview.
Mar 16 2019, 10:52 AM · Gwenview
ngraham accepted D13901: Touch support for Gwenview.

Thanks so much for your patience on this. I think it's ready to land now!

Mar 16 2019, 10:51 AM · Gwenview

Mar 10 2019

steffenh updated the diff for D13901: Touch support for Gwenview.

Move the gestureEvent(QGestureEvent* event) and event(QEvent* event) functions from documentview.cpp and thumbnailview.cpp to the Touch class.
I think this is now ready to land.

Mar 10 2019, 8:46 AM · Gwenview

Mar 9 2019

ngraham added a comment to D13901: Touch support for Gwenview.

Hi @ngraham

+1 to adding gesture recognizers to KWidgetsAddons

I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?

https://cgit.kde.org/kwidgetsaddons.git

I was thinking over this in the last days, but I'm not sure my coding is up to the task. Perhaps after I have finished this patch I can try it.
But with this idea in the background, I'm beginning to complete remove the event and gestureEvent function in dokumentview.cpp and thumbnailview.cpp, and use the Signal / Slot mechanics from Qt .

Mar 9 2019, 4:18 PM · Gwenview
steffenh added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?

https://cgit.kde.org/kwidgetsaddons.git

Mar 9 2019, 7:46 AM · Gwenview

Mar 3 2019

ngraham added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

Mar 3 2019, 9:24 PM · Gwenview
volkov added a comment to D13901: Touch support for Gwenview.

+1 to adding gesture recognizers to KWidgetsAddons

Mar 3 2019, 8:56 PM · Gwenview
steffenh updated the diff for D13901: Touch support for Gwenview.
  • move some of the duplicate code in documentview and thumbnailview to functions in touch and touch_helper
  • fix some typos
  • fix copyright
Mar 3 2019, 5:22 PM · Gwenview

Mar 2 2019

sandsmark added a comment to D17732: Respect animation settings.

As for the discussion above, I don't see how plasma-integration is relevant. It does control QStyleHints, but you're not using any of that.
Everything you use here comes from the QStyle which is all from Breeze.

Mar 2 2019, 7:40 PM · Gwenview

Feb 27 2019

ngraham added inline comments to D13901: Touch support for Gwenview.
Feb 27 2019, 2:18 PM · Gwenview
steffenh added inline comments to D13901: Touch support for Gwenview.
Feb 27 2019, 1:17 PM · Gwenview

Feb 24 2019

ngraham added a comment to D13901: Touch support for Gwenview.

Thanks, that makes sense. However, it might also make sense to add generic support for all of this into Qt itself, or at least into a KDE Framework (KWidgetsAddons maybe?). There are lots of other QWidgets-based KDE apps that could benefit from this stuff too! Dolphin and Okular immediately come to mind.

Feb 24 2019, 4:20 PM · Gwenview