GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Sun, Aug 18

ngraham added a comment to D23106: Allow the user to select the JPEG save/compression quality.

If there are no further comments or objections, I will land this in a week.

Sun, Aug 18, 10:44 PM · Gwenview

Wed, Aug 14

ngraham added a comment to D23106: Allow the user to select the JPEG save/compression quality.

Actually, I think it is, since when using portals, you'll see the standard save dialog, not our customized one.

Wed, Aug 14, 4:38 PM · Gwenview

Tue, Aug 13

ngraham added a reviewer for D23106: Allow the user to select the JPEG save/compression quality: VDG.

Question for VDG people: is the settings UI unnecessary? I'm now wondering if it would make more sense to only put the UI in the Save as dialog, and not even bother with showing it elsewhere.

Tue, Aug 13, 2:13 AM · Gwenview
ngraham updated the summary of D23106: Allow the user to select the JPEG save/compression quality.
Tue, Aug 13, 2:11 AM · Gwenview

Mon, Aug 12

filipf added a comment to D23106: Allow the user to select the JPEG save/compression quality.

I believe I've just recently had some noticeable image quality loss after doing a save in Gwenview; the fact that it would happen was unbeknownst to me.

Mon, Aug 12, 8:48 PM · Gwenview
ngraham updated the test plan for D23106: Allow the user to select the JPEG save/compression quality.
Mon, Aug 12, 8:29 PM · Gwenview
ngraham updated the diff for D23106: Allow the user to select the JPEG save/compression quality.

Populate the quality in the Save As dialog's spinbox correctly every time

Mon, Aug 12, 8:25 PM · Gwenview
ngraham updated the diff for D23106: Allow the user to select the JPEG save/compression quality.

Don't set quality when saving a non-JPEG image (it triggers https://bugreports.qt.io/browse/QTBUG-43618)

Mon, Aug 12, 8:21 PM · Gwenview
ngraham updated the diff for D23106: Allow the user to select the JPEG save/compression quality.

Fix remaining issues; ready for review

Mon, Aug 12, 8:06 PM · Gwenview
ngraham updated the test plan for D23106: Allow the user to select the JPEG save/compression quality.
Mon, Aug 12, 6:38 PM · Gwenview
ngraham planned changes to D23106: Allow the user to select the JPEG save/compression quality.

Doesn't work unless the image is somehow otherwise changed; fixing

Mon, Aug 12, 6:08 PM · Gwenview
ngraham updated the test plan for D23106: Allow the user to select the JPEG save/compression quality.
Mon, Aug 12, 5:48 PM · Gwenview
ngraham updated the test plan for D23106: Allow the user to select the JPEG save/compression quality.
Mon, Aug 12, 5:48 PM · Gwenview
ngraham updated the diff for D23106: Allow the user to select the JPEG save/compression quality.

Add custom quality chooser UI in Save As dialog when saving as a JPEG file

Mon, Aug 12, 5:44 PM · Gwenview
ngraham added a comment to D23106: Allow the user to select the JPEG save/compression quality.
In D23106#510665, @pino wrote:

It is implemented purely as a setting in the settings dialog rather than a new
part of the save dialog because that would add a kdelibs4support dependency and
not be compatible with Flatpak portals.

Not true, see KFileCustomDialog in kio.

Mon, Aug 12, 4:49 AM · Gwenview
pino added a comment to D23106: Allow the user to select the JPEG save/compression quality.

It is implemented purely as a setting in the settings dialog rather than a new
part of the save dialog because that would add a kdelibs4support dependency and
not be compatible with Flatpak portals.

Mon, Aug 12, 4:48 AM · Gwenview
ngraham requested review of D23106: Allow the user to select the JPEG save/compression quality.
Mon, Aug 12, 4:44 AM · Gwenview

Tue, Jul 23

nicolasfella requested review of D22706: Port KRun::runService to KRun::runApplication.
Tue, Jul 23, 11:03 PM · Gwenview

Jul 20 2019

yurchor closed D22527: Replace some obsolete methods with non-obsolete ones.
Jul 20 2019, 2:15 PM · Gwenview
ngraham accepted D22527: Replace some obsolete methods with non-obsolete ones.

Thanks, shipit! 👍

Jul 20 2019, 2:09 PM · Gwenview
yurchor updated the diff for D22527: Replace some obsolete methods with non-obsolete ones.

Remove QScreen includes.

Jul 20 2019, 2:08 PM · Gwenview
ngraham added a comment to D22527: Replace some obsolete methods with non-obsolete ones.

Thanks! Almost done...

Jul 20 2019, 1:40 PM · Gwenview
yurchor updated the diff for D22527: Replace some obsolete methods with non-obsolete ones.

Revert screenGeometry() changes to keep Qt 5.9 dependency, add appropriate comments.

Jul 20 2019, 6:06 AM · Gwenview

Jul 19 2019

ngraham added a comment to D22527: Replace some obsolete methods with non-obsolete ones.

Darn. Don't port those, then, and instead just add a TODO that says what we should do when we're going to bump the dep to a newer Qt version.

Jul 19 2019, 7:18 PM · Gwenview
yurchor added a comment to D22527: Replace some obsolete methods with non-obsolete ones.

Thanks in advance for your answer.

Jul 19 2019, 6:13 PM · Gwenview
ngraham added inline comments to D22527: Replace some obsolete methods with non-obsolete ones.
Jul 19 2019, 5:36 PM · Gwenview
yurchor updated the diff for D22527: Replace some obsolete methods with non-obsolete ones.

Use constant iterators.

Jul 19 2019, 7:43 AM · Gwenview
yurchor added a comment to D22527: Replace some obsolete methods with non-obsolete ones.

Thanks.

Jul 19 2019, 7:42 AM · Gwenview
meven added inline comments to D22527: Replace some obsolete methods with non-obsolete ones.
Jul 19 2019, 7:27 AM · Gwenview

Jul 18 2019

yurchor updated the summary of D22527: Replace some obsolete methods with non-obsolete ones.
Jul 18 2019, 7:27 PM · Gwenview
ngraham added a comment to D22527: Replace some obsolete methods with non-obsolete ones.

the description needs to be changed now

Jul 18 2019, 7:26 PM · Gwenview
yurchor updated the diff for D22527: Replace some obsolete methods with non-obsolete ones.

Revert Qt 5.9 -> 5.10 and byteCount() -> sizeInBytes() change.

Jul 18 2019, 5:28 PM · Gwenview
tommo added a comment to D22527: Replace some obsolete methods with non-obsolete ones.

I vote against bumping Qt to 5.10 just because of a single obsolete method. Qt 5.9 is a LTS release, which is supported until May 2020. E.g. I'm using openSUSE Leap 15.1, which uses 5.9.7 . Also, QImage::sizeInBytes() is recommend for images bigger 2GiB, but I never had success to open images that big with Gwenview.

Jul 18 2019, 4:48 PM · Gwenview
yurchor requested review of D22527: Replace some obsolete methods with non-obsolete ones.
Jul 18 2019, 11:14 AM · Gwenview

Jul 7 2019

ngraham closed D22305: Fix MIME type not determined for small files.
Jul 7 2019, 12:09 PM · Gwenview
ngraham accepted D22305: Fix MIME type not determined for small files.

Thanks!

Jul 7 2019, 12:08 PM · Gwenview
tommo updated the summary of D22305: Fix MIME type not determined for small files.
Jul 7 2019, 10:25 AM · Gwenview
tommo requested review of D22305: Fix MIME type not determined for small files.
Jul 7 2019, 10:22 AM · Gwenview

Jul 6 2019

cfeck closed D22251: Make KF5Purpose dependency optional.
Jul 6 2019, 10:00 AM · Gwenview

Jul 5 2019

ngraham accepted D22251: Make KF5Purpose dependency optional.
Jul 5 2019, 11:49 AM · Gwenview

Jul 3 2019

cfeck added a comment to D21468: [WIP/RFC] Use Purpose for sharing.

I added https://phabricator.kde.org/D22251 for making it optional.

Jul 3 2019, 7:35 PM · Gwenview
cfeck requested review of D22251: Make KF5Purpose dependency optional.
Jul 3 2019, 7:31 PM · Gwenview

Jun 28 2019

asturmlechner closed D22117: Add missing KF5WidgetsAddons and header to fix build.
Jun 28 2019, 6:26 PM · Gwenview
ngraham closed D21407: Disable smoothing thumbnails in LowResourceUsageMode.
Jun 28 2019, 6:14 PM · Gwenview
ngraham accepted D21407: Disable smoothing thumbnails in LowResourceUsageMode.

Thanks!

Jun 28 2019, 6:00 PM · Gwenview
tommo updated the diff for D21407: Disable smoothing thumbnails in LowResourceUsageMode.
Jun 28 2019, 5:05 PM · Gwenview
ngraham accepted D22117: Add missing KF5WidgetsAddons and header to fix build.

Good catch, thanks.

Jun 28 2019, 3:39 PM · Gwenview
ngraham requested changes to D21407: Disable smoothing thumbnails in LowResourceUsageMode.
Jun 28 2019, 2:36 PM · Gwenview

Jun 27 2019

tommo updated subscribers of D21407: Disable smoothing thumbnails in LowResourceUsageMode.

@ngraham ping

Jun 27 2019, 3:21 PM · Gwenview
asturmlechner requested review of D22117: Add missing KF5WidgetsAddons and header to fix build.
Jun 27 2019, 10:45 AM · Gwenview