GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Tue, Dec 3

bdevries added a comment to D25111: Implement KMessageWidget to report import errors..

No problem.
I will follow up, as promised, with a patch to refactor the internationalization of the info/warning/error messages.

Tue, Dec 3, 10:27 PM · Gwenview
nicolasfella closed D25693: Port away from deprecated DesktopIcon.
Tue, Dec 3, 7:24 PM · Gwenview
nicolasfella updated the diff for D25693: Port away from deprecated DesktopIcon.
  • Use single arg fucntion
Tue, Dec 3, 7:24 PM · Gwenview
ngraham requested changes to D25112: Allow users to disable bird view.

Thanks, looking better! When you edit app/gwenviewui.rc, you need to bump the version number that's at the top of the file. In addition, I added some inline comments that need to be addressed:

Tue, Dec 3, 6:56 PM · Gwenview
ngraham closed D24875: Importer: convert all file operations to allow remote URLs.
Tue, Dec 3, 6:43 PM · Gwenview
ngraham accepted D24875: Importer: convert all file operations to allow remote URLs.
Tue, Dec 3, 6:37 PM · Gwenview
ngraham retitled D24875: Importer: convert all file operations to allow remote URLs from Importer: convert all file operations to allow remote URLs. to Importer: convert all file operations to allow remote URLs.
Tue, Dec 3, 6:34 PM · Gwenview
ngraham closed D25224: Solve a bug which can happen with multiple files with the same name.
Tue, Dec 3, 6:33 PM · Gwenview
ngraham retitled D25224: Solve a bug which can happen with multiple files with the same name from Solve a bug which can happen with multiple files with the same name. to Solve a bug which can happen with multiple files with the same name.
Tue, Dec 3, 6:33 PM · Gwenview
ngraham accepted D25224: Solve a bug which can happen with multiple files with the same name.

Yep, makes sense, thanks!

Tue, Dec 3, 6:26 PM · Gwenview
ngraham closed D25111: Implement KMessageWidget to report import errors..
Tue, Dec 3, 6:22 PM · Gwenview
ngraham accepted D25111: Implement KMessageWidget to report import errors..

Yep, thanks. Sorry this patch has dragged on for so long. I'm landing it today!

Tue, Dec 3, 6:22 PM · Gwenview
vkrause accepted D25693: Port away from deprecated DesktopIcon.
Tue, Dec 3, 8:02 AM · Gwenview

Mon, Dec 2

nicolasfella added a task to D25693: Port away from deprecated DesktopIcon: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.
Mon, Dec 2, 8:33 PM · Gwenview
nicolasfella requested review of D25693: Port away from deprecated DesktopIcon.
Mon, Dec 2, 8:32 PM · Gwenview
nicolasfella closed D25675: Remove ContextBarButton.
Mon, Dec 2, 11:41 AM · Gwenview
ngraham accepted D25675: Remove ContextBarButton.
Mon, Dec 2, 3:09 AM · Gwenview
nicolasfella requested review of D25675: Remove ContextBarButton.
Mon, Dec 2, 12:54 AM · Gwenview

Sat, Nov 23

nicolasfella closed D25464: Remove unused include.
Sat, Nov 23, 5:31 PM · Gwenview
cullmann accepted D25464: Remove unused include.
Sat, Nov 23, 4:19 PM · Gwenview
juchatycapelle updated the diff for D25112: Allow users to disable bird view.

I took a little bit longer. I moved the option in the View menu. I still use the configuration to make the changes persistent.
The ViewMainPage class is in charge of handling the signals from the menu. It was necessary to do the initial handling on a top level view so that changes can be handled at any time, lower level views are not guaranted to be loaded.

Sat, Nov 23, 5:44 AM · Gwenview

Fri, Nov 22

bdevries added a comment to D25111: Implement KMessageWidget to report import errors..

Yes, sounds good.
The current patch is quite aligned with what the existing code is doing, so no modification should be required. This patch could then be used as-is.

Fri, Nov 22, 9:25 PM · Gwenview
ngraham added inline comments to D25111: Implement KMessageWidget to report import errors..
Fri, Nov 22, 6:14 PM · Gwenview
nicolasfella requested review of D25464: Remove unused include.
Fri, Nov 22, 3:03 PM · Gwenview
bdevries added inline comments to D25111: Implement KMessageWidget to report import errors..
Fri, Nov 22, 2:58 PM · Gwenview
bdevries updated the diff for D25111: Implement KMessageWidget to report import errors..

Internationalize strings.

Fri, Nov 22, 2:48 PM · Gwenview

Fri, Nov 15

ngraham requested changes to D25111: Implement KMessageWidget to report import errors..

Thanks again for the patch!

Fri, Nov 15, 5:53 PM · Gwenview

Nov 8 2019

ngraham added a comment to D25111: Implement KMessageWidget to report import errors..

Nice, will review soon.

Nov 8 2019, 9:52 PM · Gwenview
bdevries requested review of D25224: Solve a bug which can happen with multiple files with the same name.
Nov 8 2019, 9:44 PM · Gwenview
bdevries added inline comments to D24875: Importer: convert all file operations to allow remote URLs.
Nov 8 2019, 9:17 PM · Gwenview
bdevries updated the diff for D24875: Importer: convert all file operations to allow remote URLs.

A few additional changes based on Nate's comments.

Nov 8 2019, 9:16 PM · Gwenview
ngraham added a comment to D24875: Importer: convert all file operations to allow remote URLs.

Nice work. Just a few inline comments:

Nov 8 2019, 4:09 PM · Gwenview
ngraham closed D25005: Fix image loading performance.
Nov 8 2019, 3:03 PM · Gwenview
ngraham accepted D25005: Fix image loading performance.

Nice work.

Nov 8 2019, 3:01 PM · Gwenview
hoffmannrobert added inline comments to D25005: Fix image loading performance.
Nov 8 2019, 2:14 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move connect to constructor
Nov 8 2019, 2:11 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

I've tested it and it works fine for me, thanks. One minor issue is noted below.

Nov 8 2019, 1:30 PM · Gwenview

Nov 5 2019

hoffmannrobert updated the summary of D25005: Fix image loading performance.
Nov 5 2019, 8:57 AM · Gwenview

Nov 4 2019

tommo added a comment to D25005: Fix image loading performance.

Ok. I would like to test this, will need a few days though.

Nov 4 2019, 3:44 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Remove unnecessary include
Nov 4 2019, 2:52 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

Thanks, I moved the reload() and added a signal readyForDirListerStart() to DocumentFactory, which is emitted when the document is loaded or failed. In ContextManager::setUrlToSelect() this signal is connected to the dirlister start.

Nov 4 2019, 2:35 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move reload(), add DocumentFactory::readyForDirListerStart()
Nov 4 2019, 2:31 PM · Gwenview

Nov 3 2019

ngraham added a reviewer for D25112: Allow users to disable bird view: Gwenview.
Nov 3 2019, 2:51 PM · Gwenview
juchatycapelle added a comment to D25112: Allow users to disable bird view.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view

Nov 3 2019, 9:23 AM · Gwenview

Nov 2 2019

ngraham added a comment to D25112: Allow users to disable bird view.

Maybe it could be an option in the View menu? This seems like something people may want to toggle on and off with a keyboard shortcut (remembering the state from previous instances) rather than opening the settings dialog to enable/disable.

Nov 2 2019, 8:45 PM · Gwenview
ndavis added a comment to D25112: Allow users to disable bird view.

I'm not necessarily opposed to this, but Gwenview's Image View settings page is already quite cluttered with options. I wonder if there is a better way to toggle this on or off. Perhaps the checkbox could be located in the toolbar below the image view, or in a new overflow menu button we could add on the right side of that toolbar.

Alternatively, if living in the Image View page makes the most sense, we should probably condense the view by replacing some or all of those multi-item radio buttons with comboboxes, which will save a lot of space.

Thoughts, VDG folks?

Nov 2 2019, 8:36 PM · Gwenview
ngraham requested changes to D25112: Allow users to disable bird view.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view:

Nov 2 2019, 7:56 PM · Gwenview
tommo added a comment to D25005: Fix image loading performance.

The same determination is done in LoadingDocumentImpl::init().

Nov 2 2019, 10:57 AM · Gwenview
juchatycapelle requested review of D25112: Allow users to disable bird view.
Nov 2 2019, 7:06 AM · Gwenview

Nov 1 2019

bdevries requested review of D25111: Implement KMessageWidget to report import errors..
Nov 1 2019, 10:50 PM · Gwenview