rjvbb (René J.V. Bertin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2016, 12:33 PM (127 w, 2 d)
Availability
Available

Recent Activity

Today

rjvbb added a comment to D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.
Can you explain in more detail how an unreachable `break` after a `return` statement makes the code more readable?
Sun, Sep 23, 7:33 PM · KDevelop
rjvbb added a comment to D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.

As mentioned on another ticket, I don't like the idea of not putting breaks, no matter how clever the compiler and hard-coded choice of compiler options; I don't think you gain anything from it, and it doesn't improve code readability either for me (esp. when switch cases aren't indented w.r.t the switch context, as in the last hunk in plugins/qmljs/codecompletion/context.cpp.
Making it obligatory to add a token confirming that fallthrough is intended is a good idea, though using a largish term in all-caps like Q_FALLTHROUGH also doesn't improve readibilty. And what about the most common type of fallthrough, are we really going to have to write something like the following?

Sun, Sep 23, 5:31 PM · KDevelop
rjvbb added a comment to D15530: kdev-clang : somewhat more complete ObjC(++) support.

Doesn't KDevelop already add (install) a few mimetypes of its own? I think I mentioned before that I do have a .xml file for SMI, adding the x-objc++src definition and I presume that's why I am not seeing mimetype warnings about ObC (I'm seeing others though.)

Sun, Sep 23, 3:59 PM · KDevelop

Yesterday

rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

I have no (big) problems with a fallthrough attribute, but if it's going to be obligatory I'd want the complementary attribute (the break) to be obligatory too...

Sat, Sep 22, 7:05 PM · KDevelop
rjvbb added a comment to D15530: kdev-clang : somewhat more complete ObjC(++) support.

You should probably also add a few lines to the custom-definesandincludes plugin.

Sat, Sep 22, 8:20 AM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
Eventually we have to compile our code anyway, so aren't we all dependent on the compiler?
Sat, Sep 22, 8:14 AM · KDevelop

Fri, Sep 21

rjvbb committed R32:ee092ebbadfc: Companion change for the customscript plugin to match #a0992d3166 (authored by rjvbb).
Companion change for the customscript plugin to match #a0992d3166
Fri, Sep 21, 7:54 PM
rjvbb set the repository for D7930: Kdevelop CMake plugin : use canonical paths to build.dir to R32 KDevelop.
Fri, Sep 21, 3:32 PM · KDevelop
rjvbb updated the diff for D7930: Kdevelop CMake plugin : use canonical paths to build.dir.

Refactored for the 5.3 branch + completed.

Fri, Sep 21, 3:30 PM · KDevelop
rjvbb added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.
"If you have inherited this class to access the formatter, you will need to add a method similar to getPeekStart() in the ASStreamIterator class in astyle_main.h." from http://astyle.sourceforge.net/news.html is the only info I have, which leaves lots of room.
Have you seen any docs for that method?
Fri, Sep 21, 12:36 PM · KDevelop
rjvbb set the repository for D15530: kdev-clang : somewhat more complete ObjC(++) support to R32 KDevelop.
Fri, Sep 21, 10:33 AM · KDevelop
rjvbb updated the diff for D15530: kdev-clang : somewhat more complete ObjC(++) support.

Updated as suggested. No switch yet but a layout that looks more like one.

Fri, Sep 21, 10:33 AM · KDevelop
rjvbb added a comment to D15625: Sublime: Fix crash caused when all tool view items are small.

Looks good at first glance. The failsafe should work evidently but I'll have to test to be certain if the other fix prevents the situation I ran into. Maybe this afternoon, otherwise tomorrow.

Fri, Sep 21, 10:30 AM · KDevelop
rjvbb added a comment to D15530: kdev-clang : somewhat more complete ObjC(++) support.

You should probably also add a few lines to the custom-definesandincludes plugin.

Fri, Sep 21, 10:02 AM · KDevelop
rjvbb reopened D15605: kdev-astyle : upgrade libastyle to v3.1.

Would this be OK as a fix?

Fri, Sep 21, 9:50 AM · KDevelop
rjvbb added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

Is there some API dox what one should implement for getPeekStart(), especially which values are valid?

Fri, Sep 21, 8:58 AM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

We could activate -Wunreachable-code so the compiler tells you where break isn't needed.

Fri, Sep 21, 8:53 AM · KDevelop

Thu, Sep 20

rjvbb set the repository for D15530: kdev-clang : somewhat more complete ObjC(++) support to R32 KDevelop.
Thu, Sep 20, 8:52 PM · KDevelop
rjvbb updated the diff for D15530: kdev-clang : somewhat more complete ObjC(++) support.

A small additional change to the plugin json, and a request for a bit of help.

Thu, Sep 20, 8:51 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
C is not a subset of C++ (let me point to Mr. Stroustrup who should know it :)
Thu, Sep 20, 12:48 PM · KDevelop
rjvbb committed R32:a0992d316631: [Astyle] Add Objective C to list of languages with formatters (authored by rjvbb).
[Astyle] Add Objective C to list of languages with formatters
Thu, Sep 20, 12:12 PM
rjvbb closed D15532: [Astyle] Add Objective C to list of languages with formatters.
Thu, Sep 20, 12:12 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
... shared-mime-info has this questionable inheritage for C++ and Objective-C from C.
Thu, Sep 20, 12:10 PM · KDevelop
rjvbb set the repository for D15532: [Astyle] Add Objective C to list of languages with formatters to R32 KDevelop.
Thu, Sep 20, 9:54 AM · KDevelop
rjvbb updated the diff for D15532: [Astyle] Add Objective C to list of languages with formatters.

Updated as requested, waiting for final a-ok.

Thu, Sep 20, 9:53 AM · KDevelop
rjvbb added inline comments to D15532: [Astyle] Add Objective C to list of languages with formatters.
Thu, Sep 20, 9:52 AM · KDevelop
rjvbb committed R32:378a6e02cec5: astyle plugin: upgrade bundled astyle copy to v3.1 (authored by rjvbb).
astyle plugin: upgrade bundled astyle copy to v3.1
Thu, Sep 20, 8:34 AM
rjvbb closed D15605: kdev-astyle : upgrade libastyle to v3.1.
Thu, Sep 20, 8:34 AM · KDevelop

Wed, Sep 19

rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
Possibly because Qt on macOS uses the macOS mimettype database
Wed, Sep 19, 11:23 PM · KDevelop
rjvbb added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.
Not really: https://repology.org/metapackage/astyle/versions
Wed, Sep 19, 10:05 PM · KDevelop
rjvbb added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

Normally I'd agree, but here we're dealing with really a tiny amount of additional code and a project which isn't exactly being kept up-to-date by distributions either (on Linux I'd get 2.04 from the system, on Mac 2.05 from MacPorts). Bundling the few files involved means that at least everyone gets the astyle plugin and with the same version.

Wed, Sep 19, 8:34 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
Code looks fine to me, modulo all the comments made, and works where I tested it. Please also update the summary text and title of the patch.
Wed, Sep 19, 8:26 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

BTW, this change is still marked as approved, is it?

Wed, Sep 19, 6:09 PM · KDevelop
rjvbb set the repository for D15532: [Astyle] Add Objective C to list of languages with formatters to R32 KDevelop.
Wed, Sep 19, 6:08 PM · KDevelop
rjvbb updated the diff for D15532: [Astyle] Add Objective C to list of languages with formatters.

The libastyle was split off as D15605, as requested.
(Fortunately the 2 changesets were orthogonal.)

Wed, Sep 19, 6:08 PM · KDevelop
rjvbb requested review of D15605: kdev-astyle : upgrade libastyle to v3.1.
Wed, Sep 19, 6:06 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

It's just that I use the 5.3 branch.

Wed, Sep 19, 1:04 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Yeah, I was expecting this, though I hoped it could just be separate commit, not a separate review.

Wed, Sep 19, 11:43 AM · KDevelop
rjvbb set the repository for D15532: [Astyle] Add Objective C to list of languages with formatters to R32 KDevelop.
Wed, Sep 19, 9:25 AM · KDevelop
rjvbb updated the diff for D15532: [Astyle] Add Objective C to list of languages with formatters.

I added ObjC previews as requested, and doing so I noticed I had to make a few more changes, justifying a ticket name change. I did mention the change was going to be a bit more elaborate than one might have thought, didn't I? :)

Wed, Sep 19, 9:22 AM · KDevelop

Tue, Sep 18

rjvbb added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

seems to still lead us here into a situation where only "smallItems" exists?

I would suspect some rounding errors.
Tue, Sep 18, 2:19 PM · KDevelop
rjvbb added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

No, I haven't pushed a fix, but I have one which seems to work just fine. Feel free to clean it up as you see fit (I see an accidental indentation change) and push it yourself.

Tue, Sep 18, 12:08 PM · KDevelop
rjvbb added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

https://bugs.kde.org/show_bug.cgi?id=398790

Tue, Sep 18, 11:31 AM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

On it, but the changes go a bit further than I (and you?) might have guessed ([private] method renaming e.g.). I hope to have something by the end of day, but if you think it'd end up having to be split into a separate commit I could just as well hear that now ;)

Tue, Sep 18, 8:46 AM · KDevelop

Sat, Sep 15

rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
Thanks. Learned about ObjC++ this way... the world is full of strange things :)
Sat, Sep 15, 12:53 PM · KDevelop
rjvbb set the repository for D15530: kdev-clang : somewhat more complete ObjC(++) support to R32 KDevelop.
Sat, Sep 15, 12:22 PM · KDevelop
rjvbb updated the diff for D15530: kdev-clang : somewhat more complete ObjC(++) support.

astye change split off as D15532

Sat, Sep 15, 12:21 PM · KDevelop
rjvbb requested review of D15532: [Astyle] Add Objective C to list of languages with formatters.
Sat, Sep 15, 12:20 PM · KDevelop
rjvbb requested review of D15530: kdev-clang : somewhat more complete ObjC(++) support.
Sat, Sep 15, 12:07 PM · KDevelop

Wed, Sep 5

rjvbb added a comment to D15295: [konsole]: proper fix for a crash-on-exit.

it should be connected destroyed to containerEmpty too.

Wed, Sep 5, 9:11 PM · Konsole
rjvbb added a comment to D15295: [konsole]: proper fix for a crash-on-exit.
I say that because in one of my konsole branches I removed that and it indeed worked.
Wed, Sep 5, 3:07 PM · Konsole
rjvbb added a comment to D15295: [konsole]: proper fix for a crash-on-exit.

I think these do different things; containerEmpty is called when a container (Konsole window, presumably) closed its last tab but doesn't unregister the container. I'd guess that containerEmpty will be called first, and then containerDestroyed when the container is being disposed off (because it's empty).
There may not be an explicit current need to handle these separately, but I don't see why one should NOT do that.

Wed, Sep 5, 2:46 PM · Konsole
rjvbb set the repository for D15295: [konsole]: proper fix for a crash-on-exit to R319 Konsole.
Wed, Sep 5, 2:13 PM · Konsole
rjvbb updated the diff for D15295: [konsole]: proper fix for a crash-on-exit.

No need to specify Qt::DirectConnection explicitly.

Wed, Sep 5, 2:12 PM · Konsole
rjvbb requested review of D15295: [konsole]: proper fix for a crash-on-exit.
Wed, Sep 5, 2:11 PM · Konsole

Aug 22 2018

rjvbb added a comment to R246:0a96acf251ba: Use the current hunspell API.

Food for thought: what ‘s the KF5 frameworks version in that CentOS?

Aug 22 2018, 8:17 PM

Aug 21 2018

rjvbb added a comment to R246:0a96acf251ba: Use the current hunspell API.

Why does that build not use the current hunspell? The old api has been obsolete for quite a while IIRC and hunspell is not a core/base system library

Aug 21 2018, 7:53 PM

Aug 14 2018

rjvbb added a comment to D14828: remove highlighting download dialog.

Downloading already didn't work for me since quite a while (the operation never completed) but what does this mean for highlighting files I write myself (or someone's mom does)?

Aug 14 2018, 5:55 PM · Frameworks, Kate

Aug 13 2018

rjvbb set the repository for D14800: kioslave/Mac : proxy the bundle-exec and make an agent to R241 KIO.
Aug 13 2018, 4:49 PM · Frameworks
rjvbb updated the diff for D14800: kioslave/Mac : proxy the bundle-exec and make an agent.

Use a current instead of an obsolete platform token.

Aug 13 2018, 4:48 PM · Frameworks
rjvbb requested review of D14800: kioslave/Mac : proxy the bundle-exec and make an agent.
Aug 13 2018, 4:46 PM · Frameworks
rjvbb added a comment to D14758: use view lines for wheel scrolling, not real lines.

I'll test the patch ASAP, but I think there's a simple guideline to observe here (apologies if it's as much an open door as I think it is):

Aug 13 2018, 8:26 AM · Frameworks, Kate

Aug 6 2018

rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....

OK, if no one else cares :)

Aug 6 2018, 9:20 PM · Frameworks
rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....

I'd still like that message not to appear if I just dismissed DrKonqi myself.

Aug 6 2018, 2:10 PM · Frameworks
rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....
I don't see why. We try to start drkonqi even the very first time.
Aug 6 2018, 11:22 AM · Frameworks
rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....
The crash recursion counter is increased when a SEGV happens inside the crash handler itself.
Aug 6 2018, 10:47 AM · Frameworks

Aug 5 2018

rjvbb abandoned D14606: KCrash: DrKonqi cancelled = able to start....

I'm abandoning this for now because my assumption was wrong even though my patch had the effect I intended. I'll reopen if/when I have a real fix, because there are still 2 issues here:

Aug 5 2018, 6:19 PM · Frameworks
rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....

Actually, it's even worse than that: I didn't double-check my assumptions about the use of DrKonqi's return/exit code. Looking at the code again there is actually no way that information is even obtained. The startProcess function simply starts DrKonqi and then waits for it to exit if so instructed; the only information obtained about the crashreporter is its PID.

Aug 5 2018, 6:06 PM · Frameworks
rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....
> if DrKonqi gives an exit code that means it was started

It could have crashed though...
Aug 5 2018, 8:13 AM · Frameworks

Aug 4 2018

rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....

But there's a catch, on my system I get some plasma popup on which I have to click "Report Bug" in order to get the usual drkonqi dialog. Do you get that too?

Aug 4 2018, 9:45 PM · Frameworks
rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....
When I click "Close" in drkonqi (there's no Cancel button), crashtest resumes and exits, without any error message from KCrash.
Aug 4 2018, 7:13 PM · Frameworks
rjvbb added a comment to D14606: KCrash: DrKonqi cancelled = able to start....
When I click "Close" in drkonqi (there's no Cancel button), crashtest resumes and exits, without any error message from KCrash.
Aug 4 2018, 7:09 PM · Frameworks
rjvbb requested review of D14606: KCrash: DrKonqi cancelled = able to start....
Aug 4 2018, 3:30 PM · Frameworks

Aug 1 2018

rjvbb added a comment to D14397: Support libcanberra for audio notification.

That was already mentioned :)

Aug 1 2018, 11:45 AM · Frameworks

Jul 31 2018

rjvbb added a comment to D14397: Support libcanberra for audio notification.

I really don't see what the big fuss is all about.

Jul 31 2018, 3:46 PM · Frameworks
rjvbb added inline comments to D14397: Support libcanberra for audio notification.
Jul 31 2018, 3:06 PM · Frameworks
rjvbb added a comment to D14397: Support libcanberra for audio notification.

I have no other objections than the ones above, as long as there's a fallback to NOT using libcanberra which can be enforced without having to patch the code (= via CMAKE_DISABLE_FIND_PACKAGE_FOO or a dedicated option).

Jul 31 2018, 1:55 PM · Frameworks

Jul 30 2018

rjvbb added a comment to D14397: Support libcanberra for audio notification.
I don't really care about your artificially created problems. You *have* libcanberra but want to use it for one project and not the other. Sorry, but no.
Jul 30 2018, 8:31 AM · Frameworks
rjvbb added a comment to D14397: Support libcanberra for audio notification.
(Oh btw it's not like I didn't try, I originally ported all of this to QtMultimedia but `QAudioEffect` which is for low-latency sound effects only supports WAV sounds and `QMediaPlayer` had significant overhead and initialization times as well which is why I eventually ended up using canberra)
Jul 30 2018, 8:20 AM · Frameworks
rjvbb committed R32:3934fcea209e: Use platform-specific default shortcuts in the document switcher (authored by rjvbb).
Use platform-specific default shortcuts in the document switcher
Jul 30 2018, 8:00 AM
rjvbb closed D6060: platform-specific document switcher default shortcuts.
Jul 30 2018, 8:00 AM · KDevelop

Jul 29 2018

rjvbb requested review of D14469: KDevelop: word wrapping the problem text in the Problem Reporter (WIP).
Jul 29 2018, 7:41 PM · KDevelop

Jul 28 2018

rjvbb added a comment to D14397: Support libcanberra for audio notification.

[I didn't get to send this yesterday]

Jul 28 2018, 7:43 AM · Frameworks

Jul 27 2018

rjvbb added a comment to D14397: Support libcanberra for audio notification.
That's reinventing the wheel to a point.
Jul 27 2018, 10:26 AM · Frameworks

Jul 26 2018

rjvbb added a comment to D14397: Support libcanberra for audio notification.

However I rather like the idea of improving QTMultiMedia's sound handling features rather than working around the lack of them by using a different library.

Jul 26 2018, 4:07 PM · Frameworks
rjvbb added a comment to D14397: Support libcanberra for audio notification.

Anyway, if using QtMultiMedia cannot be considered please make it a build option to use just QApplication::beep() for sound notifications so that packagers can decide whether or not they want to introduce dependencies on libcanberra and everything it needs. On Mac at least QApplication::beep() will trigger the user-selected system notification sound (which can but doesn't have to be a horrible beep).

Jul 26 2018, 12:32 PM · Frameworks
rjvbb added a comment to D14397: Support libcanberra for audio notification.

That's a nicety, not necessarily a requirement, at least not for playing notification sounds. Just how often do you get sound alerts at such high rates that caching becomes unavoidable, before you get mad and resolve the issue or yank the plug? I think that proper cross-platform support without requiring multiple 3rd-party libraries is more important than being able to leverage PA caching directly.

Jul 26 2018, 12:23 PM · Frameworks
rjvbb added a comment to D14397: Support libcanberra for audio notification.
According to its website  "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)"
Jul 26 2018, 11:23 AM · Frameworks
rjvbb added a comment to D14397: Support libcanberra for audio notification.
  • gstreamer is technically x-platform, whether one actually wants to attempt building and using it on these platforms is another question I suppose
Jul 26 2018, 10:05 AM · Frameworks
rjvbb added a comment to D14397: Support libcanberra for audio notification.
We probably lose the ability to play sound on Windows and Mac?
Jul 26 2018, 10:02 AM · Frameworks

Jul 25 2018

rjvbb set the repository for D14376: kdev-clang/tests/test_assistants.cpp : avoid crash and failures due to symlinks in the test filenames to R32 KDevelop.
Jul 25 2018, 7:30 PM · KDevelop
rjvbb updated the diff for D14376: kdev-clang/tests/test_assistants.cpp : avoid crash and failures due to symlinks in the test filenames.

This is an even lower-level fix which applies to all cases where the temporary directory is obtained by reading TMPDIR. That variable contains the path containing the /var symlink; the patch basically sets the variable to the canonical representation of itself, or else sets it to the fallback temp. dir.

Jul 25 2018, 7:28 PM · KDevelop
rjvbb set the repository for D14376: kdev-clang/tests/test_assistants.cpp : avoid crash and failures due to symlinks in the test filenames to R32 KDevelop.
Jul 25 2018, 6:19 PM · KDevelop
rjvbb updated the diff for D14376: kdev-clang/tests/test_assistants.cpp : avoid crash and failures due to symlinks in the test filenames.

This should be a real fix for the issue I've been seeing.

Jul 25 2018, 6:19 PM · KDevelop
rjvbb added a comment to D14376: kdev-clang/tests/test_assistants.cpp : avoid crash and failures due to symlinks in the test filenames.
What is your own answer to this? ;)
Jul 25 2018, 5:41 PM · KDevelop
rjvbb requested review of D14376: kdev-clang/tests/test_assistants.cpp : avoid crash and failures due to symlinks in the test filenames.
Jul 25 2018, 3:32 PM · KDevelop

Jul 24 2018

rjvbb committed R108:df802d49a1da: Require KDecoration >= 5.13.0 . (authored by rjvbb).
Require KDecoration >= 5.13.0 .
Jul 24 2018, 11:59 AM
rjvbb closed D14320: KWin requires KDecoration >= 5.12.90.
Jul 24 2018, 11:59 AM · KWin
rjvbb committed R600:6e50b39c651b: Make --list output independent on Qt logging settings (authored by rjvbb).
Make --list output independent on Qt logging settings
Jul 24 2018, 11:17 AM
rjvbb committed R600:65e9d6119f12: make build against KDecoration 5.13.x . (authored by rjvbb).
make build against KDecoration 5.13.x .
Jul 24 2018, 11:17 AM