- User Since
- Apr 15 2016, 12:33 PM (197 w, 2 d)
Tue, Jan 21
Mon, Jan 13
I am a firm +1 on splitting Calligra
So no urgent need for me to revisit the code?
Thu, Jan 9
Difficult to wrap my head around this, so much later!
Tue, Jan 7
KF5's Qt support strategy is sound
But why, there's nothing that requires this other than that single env. var. function that may not even be the most appropriate one (I find the documentation a bit confusing).
Dec 23 2019
Nov 14 2019
I disagree since it will change the current precondition of the function for the need of one of its users.
Nov 13 2019
Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?
Nov 12 2019
Apologies, I've been stretched way too thin since about the time this diff was accepted, I don't think I even noticed the fact.
Oct 21 2019
Rebased for the 5.4 branch. Still working perfectly for me, without noticeably slower reaction times on local filesystems.
Rebased for the 5.4 branch.
Oct 19 2019
Oct 11 2019
Oct 10 2019
I'm not suggesting to not create a preamble at all, but to create it only when we **know** it is needed.
Oct 6 2019
Oct 4 2019
A little tinker tool:
Oct 3 2019
And my point is that you are doing 720 translations and 360 rotations per cycle, with subsequent smoothing of an image, continuously and with sufficient temporal resolution to get a fluid animation that is completely overkill here. Indicating a busy state (a two-state entity) is not the same as indicating progress and could be done by something like a stoplight changing colour.
Does it happen with every code that uses QPropertyAnimation, or just with this KBusyIndicator?
I'll repeat here what I muttered on the associated commit page:
Oct 2 2019
Quick question: how would you make this animate once every 2 seconds to reduce the CPU overhead (the test app runs at >12% CPU, too much for a busy indicator IMVHO)? I don't grok the 1s interval duration from the parameters (nor the API documentation).
Sep 30 2019
This delay can also be used as a cheap mechanism to compress events and prevent spurious reloads, something you're bound to get when doing something potentially all-encompassing as checking out a different branch. A mod like the one below is highly effective in my own dirwatching implementation that only monitors directories for changes, but I see a comparable number of skipped redudant reloads when I use stock dirwatching implementation.
Sep 25 2019
Sep 16 2019
Yeah, you're right that we should check system version for back-compatibility.
I haven't been able to give this much attention, sorry.
Aug 26 2019
Updated to use the "cool solution" ;)
Aug 23 2019
Aug 15 2019
Untested: have you tried to make dolphinprivate a PUBLIC dependency of kdeinit_dolphin?
Aug 14 2019
Can you try to build another kdeinit app (i.e. `khelpcenter`) to check if you get the same error?
Aug 1 2019
As I thought this needs some hacking on OS X < 10.10 but a priori all one loses is the user notifications.
Jul 29 2019
It's probably not a bad idea too to return early if ever the computed realname is empty, and avoid the iteration which should be pointless in that case. Right?!
Jul 25 2019
Would you mind checking if using QCoreApplication::applicationName() would be an alternative? I'd do it myself but since I cannot reproduce your issue I can't answer the question fully.
Jul 24 2019
Just `pinentry-qt` and then `BYE`. Backtrace and more info on https://bugzilla.opensuse.org/show_bug.cgi?id=1141883
That backtrace isn't very helpful, since missing most line numbers.
Didn't know this can happen and lgtm.
Jul 20 2019
There is another condition here: `if (lastShownMenu)`. So if the QMenu object instance got deleted
Jul 18 2019
I'll activate the debug trace on change of my lastShownMenu though
In any case there isn't much else you can do; stepping through the code with a debugger is near impossible (the menu about-to-be-opened will already have grabbed mouse and keyboard focus so you'd need to display remotely).
Please add a line qDebug() << "Showing context menu" << menu; to KDevelop::TextDocument::populateContextMenu.
>> > FWIW I got to look at the KTE implementation of the context menu mechanism that is used here. It indeed uses and reuses a single QMenu instance (there's even a comment in the code about that). >> >> Please give links into the code, as I am lost what you exactly refer to here. > > see the source of `KTextEditor::ViewPrivate::contextMenu()`. The ctx menu is in fact managed by KXMLGUI. The context menu is queried every time from KXMLGUI that method is called. So if KXMLGUI internally decides to recreate the context menu, you get another object the next time. Please see again the description of this very bug.
The other option would have been to release 5.3.3 without a fix for ctags plugin users, rendering it unusable for people relying on packaged kdevelop.
Friedrich W. H. Kossebau wrote on 20190717::00:12:44 re: "D22424: TextDocument: remove actions from contextmenu on hide already"
Kai Uwe Broulik wrote on 20190718::07:13:16 re: "D22365: KNotification macOS native support by NSNotificationCenter"
Jul 16 2019
It seems to me there's a way to tell the translators that a string shouldn't be translated. Why not use that, or put a name that doesn't require translation (like name=kded5.desktop)?
Jul 14 2019
Jul 13 2019
I've tested this in the 5.3 branch now, which required applying hunk #3 manually to texteditor.cpp .
I could try your solution, of course, but what annoys me is that it comes months after I worked on mine. I currently have too many other things going on in my life to dive in and figure out what on earth was going on again. I do think I outlined it well enough above in the initial description and/or exchange; I should find a moment this weekend to sit down and re-read it with a fresh mind.
It would help if you had a specific critique on my solution other than "it doesn't use this or that signal" (or, what I kind of sense, "it comes from you"). No disrespect intended, but your description in D22424 isn't that easy to read either (it felt like reading German, for some inexplicable reason ;) ).
Just a few remarks on the comments that should make them easier to understand (a priori comments should illustrate code and not require lots of different code the understand their meaning ;))
Jul 12 2019
Please check the earlier discussion; IIRC there is a reliability problem with that signal, and I did try reverting to its use before coming up with the current solution.
Jun 26 2019
Indeed Gitlab should simplify things a lot.
> I suggest to do a `arc amend` (to basically update the commit message with current reviewers, "Differentiatl Revision" line, etc.) and then `git push` your change manually to the right branch. Let's you use your normal git command-line to actually push changes, which to me is a much more thrust-worthy approach than to rely on arc to do that for me... Probably this should be added to the guide. And probably it should also be added that the commits should be squashed (thing that `arc land` does automatically).
Jun 8 2019
Jun 4 2019
code wise looks good
May 16 2019
you are removing a feature
May 15 2019
Sounds good enough for me then!
You identified an event chain which leads to the browsing mode not being restored correctly. This should happen less often with the Alt modifier but it can still happen (hit Alt to display a tooltip or open a menu and then move the mouse over that tooltip or select a menu item?).
May 9 2019
I didn't read the full encyclopedia of discussions here, I only looked at the patch.
May 7 2019
(User, not VDG member)
May 1 2019
Apr 15 2019
Do you mean something like `#include <Foo>` which then contains a `#include <foo.h>`?
Apr 14 2019
- "simplifies the code by removing the dynamic item text logic"
Apr 9 2019
(Sorry for the inconvinience, I've never been very friendly with arc/phab)
Mar 17 2019
Not really: it says that a temporary directory for every kdevelop instance is created
no need for making it "deterministic" in any way. There is no benefit in doing that.
OK, I stand corrected on this. OTOH, the rest of my notes about this being wrong anyway still stand.
using the user ID is definitely wrong here: with this change, opening a second kdevelop will erase the temporary directory of the first...
Mar 15 2019
Milian Wolff wrote on 20190312::20:02:54 re: "D17289: KDevelop/Shell: set dedicated TMPDIR"
Mar 14 2019
...aaaaaand that's exactly what happened. :(
Re: reparsing reliably each time a headerfile is changed: wouldn't the use of forwarding headers increase the chance of missing a change?
Mar 12 2019
And there are probably places where the simpler QProcess API was used
Mar 2 2019
On, with the partially reverted patch:
But now the state is just like it was before: If you have a font that does fallbacks for some glyphs
I would rather keep the current behavior and let people use sane fonts if the want unicode.
Mar 1 2019
FWIW, Calligra Words can (idem QWE and QWK) so I guess you mean KTE cannot without a complete rewrite of how text is displayed?
Just load the XML file from bug 404713. Before this changes here, you did overpaint the next line randomly with the "oversized one", now you "cut" the oversized line.
So it seems that the partial revert works; you lost me re: what would break again by doing that?
We just can't use one fixed height for such texts.
Feb 28 2019
That is a good observation: @cullmann Could you give this partial revert a try?
@loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed?
Next Frameworks Tag is on Saturday, 2nd, i.e. in 2 days. Revert, or give it a try?
That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.