rjvbb (René J.V. Bertin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2016, 12:33 PM (113 w, 5 d)
Availability
Available

Recent Activity

Sat, Jun 9

rjvbb committed R17:ade8676d238d: avoid nullptr dereference when no devices are found (authored by rjvbb).
avoid nullptr dereference when no devices are found
Sat, Jun 9, 12:27 PM
rjvbb closed D13445: partitionmanager: avoid NULL dereference when no devices are found.
Sat, Jun 9, 12:27 PM · KDE Partition Manager
rjvbb requested review of D13445: partitionmanager: avoid NULL dereference when no devices are found.
Sat, Jun 9, 9:26 AM · KDE Partition Manager

Sun, Jun 3

rjvbb added a comment to D12129: Make Qt5Network conditional on BUILD_TESTS.

You're right, didn't notice that - and couldn't imagine that anyone would bother, too. You probably end up with all QtBase sub/split packages installed pretty quickly anyway.

Sun, Jun 3, 5:44 PM

Sat, Jun 2

rjvbb accepted D12129: Make Qt5Network conditional on BUILD_TESTS.

LGTM - but is QtNetwork ever installed as a separate package rather than as a part of QtBase?

Sat, Jun 2, 11:47 PM

Mon, May 28

rjvbb added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).

If no objections are made I'll interpret Milian's "feel free to respin" as "feel free to commit" in a couple of days.

Mon, May 28, 2:27 PM · KDevelop

May 18 2018

rjvbb added a comment to D12746: KDevelop: alternative monolithic storage options for TopDUContexts (WIP/PoC).

How about I clean this up a little (removing at least the KyotoCabinet backend) and then push it to a branch so it's easier to pick up for anyone else who like to work on this or even just check it out?

May 18 2018, 8:06 AM · KDevelop

May 15 2018

rjvbb updated the summary of D12903: KDevelop : support whitespace between the '#' and 'include' (or 'import').
May 15 2018, 6:06 PM · KDevelop
rjvbb requested review of D12903: KDevelop : support whitespace between the '#' and 'include' (or 'import').
May 15 2018, 6:05 PM · KDevelop

May 9 2018

rjvbb updated the summary of D12746: KDevelop: alternative monolithic storage options for TopDUContexts (WIP/PoC).
May 9 2018, 9:36 AM · KDevelop

May 8 2018

rjvbb set the repository for D12746: KDevelop: alternative monolithic storage options for TopDUContexts (WIP/PoC) to R32 KDevelop.
May 8 2018, 2:27 PM · KDevelop
rjvbb updated the diff for D12746: KDevelop: alternative monolithic storage options for TopDUContexts (WIP/PoC).

This revision brings some code cleanup (including the use of a qresource in the unittest/benchmark) and above all, a signficant performance improvement.
It turns out that the default LMDB environment uses synchronous I/O. In our case we can take the risk to use async I/O because we would at most lose the last few changes if a crash occurs - and most of the time the entire cache will be deleted after a crash anyway.

May 8 2018, 2:25 PM · KDevelop

May 7 2018

rjvbb added a comment to D12746: KDevelop: alternative monolithic storage options for TopDUContexts (WIP/PoC).

EDIT: while C++ exceptions are apparently with almost zero cost as long as they don't occur (https://stackoverflow.com/questions/13835817/are-exceptions-in-c-really-slow) there must also be a reason why they're disabled by default for KF5. Should I expect a benefit of rewriting lmdbxx so topducontextdynamicdata_p.cpp doesn't require exception support?

May 7 2018, 9:36 PM · KDevelop
rjvbb added a comment to D12746: KDevelop: alternative monolithic storage options for TopDUContexts (WIP/PoC).
so what's your plan with this now?
May 7 2018, 9:21 PM · KDevelop
rjvbb requested review of D12746: KDevelop: alternative monolithic storage options for TopDUContexts (WIP/PoC).
May 7 2018, 5:17 PM · KDevelop

May 2 2018

rjvbb committed R32:3b136d49eaed: fix typo (authored by rjvbb).
fix typo
May 2 2018, 9:46 AM

Apr 30 2018

rjvbb requested review of D9344: [KDevelop] : consistent use of the project name (WIP).
Apr 30 2018, 11:50 AM · KDevelop
rjvbb set the repository for D9344: [KDevelop] : consistent use of the project name (WIP) to R32 KDevelop.
Apr 30 2018, 11:49 AM · KDevelop
rjvbb updated the diff for D9344: [KDevelop] : consistent use of the project name (WIP).

Please double-check if the issue is indeed solved and no new regressions are introduced.

Apr 30 2018, 11:49 AM · KDevelop
rjvbb reopened D9344: [KDevelop] : consistent use of the project name (WIP).
Apr 30 2018, 11:47 AM · KDevelop
rjvbb added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).
I'm pretty sure this is due to `QUrl::RemoveFilename`, which removes the last directory if the URL refers to a directory.
Apr 30 2018, 11:00 AM · KDevelop

Apr 18 2018

rjvbb added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).

That's possible (your analysis I mean) and annoying that we missed it during the review. I'm away from my dev environment for a while, so cannot do much right now. IIRC most of the changes are around the location where it's also decided whether an override dialog has to be posted. If that's also where the last path component is removed, it should be possible to make that removal conditional on whether or not the selectedUrl points to a file or to a directory.

Apr 18 2018, 5:22 PM · KDevelop

Apr 16 2018

rjvbb added a comment to D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

Actually, no. I haven't been following that part at all (and am taking 2 weeks off of intensive dev stuff ;) )

Apr 16 2018, 6:26 AM · Frameworks, Kate

Apr 14 2018

rjvbb added a comment to D9070: KDE platform plugin: don't force default stylename on user-specified fonts.

Could you please push it for me? I probably won't be able to do so for at least a week and it'd be a pity if the change just misses a release because of that.

Apr 14 2018, 10:16 AM · Plasma

Apr 7 2018

rjvbb committed R246:e63a234d55d9: Don't impose using the default client (authored by rjvbb).
Don't impose using the default client
Apr 7 2018, 5:41 PM
rjvbb closed D11183: Sonnet: don't impose the default client.
Apr 7 2018, 5:41 PM · Frameworks
rjvbb set the repository for D11183: Sonnet: don't impose the default client to R246 Sonnet.
Apr 7 2018, 3:16 PM · Frameworks
rjvbb updated the diff for D11183: Sonnet: don't impose the default client.

Unnecessary rebump, pardon, rebase.

Apr 7 2018, 3:15 PM · Frameworks

Apr 5 2018

rjvbb committed R32:a44554ef038a: Use the project name more consistently (authored by rjvbb).
Use the project name more consistently
Apr 5 2018, 10:29 AM
rjvbb closed D9344: [KDevelop] : consistent use of the project name (WIP).
Apr 5 2018, 10:29 AM · KDevelop
rjvbb added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).

That was quick! :)

Apr 5 2018, 9:16 AM · KDevelop

Apr 4 2018

rjvbb requested review of D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.
Apr 4 2018, 9:34 PM
rjvbb set the repository for D9344: [KDevelop] : consistent use of the project name (WIP) to R32 KDevelop.
Apr 4 2018, 7:23 PM · KDevelop
rjvbb updated the diff for D9344: [KDevelop] : consistent use of the project name (WIP).

Updated as discussed.

Apr 4 2018, 7:23 PM · KDevelop
rjvbb added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).
> "Except", are you sure about that? I'm pretty certain I got the override dialog when I forced a new import from, say, the project's CMake file, and <dirname>.kdev4 existed already.


Ah, yes - that could be it. Then we should probably change the code to first construct a projectFileUrl that actually points to a .kdev4 file, and then use that in the conditional. And add comments that explain what is going on here.
Apr 4 2018, 7:21 PM · KDevelop
rjvbb accepted D11921: CMake Server: Reuse existing build directory path when available.
@rjvbb does this solve issues you are having and trying to workaround with https://phabricator.kde.org/D7930 ?
Apr 4 2018, 5:13 PM
rjvbb added a comment to D11921: CMake Server: Reuse existing build directory path when available.
(oh how I hate arc)
Apr 4 2018, 4:35 PM
rjvbb added a comment to D11921: CMake Server: Reuse existing build directory path when available.

I can try to test with 5.2.1, but not before tonight.

Apr 4 2018, 12:03 PM

Apr 3 2018

rjvbb added a comment to D11891: Fix crashes in NotifyByAudio when closing applications.

This is about better and more concise English. The queued connection is the indirect explanation why the patch is necessary, and thus comes after the direct explanation (the fact that there may be pending signals). Think of it as a courtesy to people who want to get to the point first and maybe deal with the finer detail later.

Apr 3 2018, 11:53 PM · Frameworks
rjvbb added a comment to D9344: [KDevelop] : consistent use of the project name (WIP).

I don't get this change, can you explain? the old code checks whether the profileFileUrl (which should *always* ends on .kdev4, no?) exists. In that case, we want to ask the user if he wants to override, except if the project file is equal to what we'd write out anyways.

Apr 3 2018, 9:02 PM · KDevelop
rjvbb committed R5:194b9410199c: Merge branch 'master' (v0.6.5-298-gbeedc2b0) into work/frameworks-Mac (authored by rjvbb).
Merge branch 'master' (v0.6.5-298-gbeedc2b0) into work/frameworks-Mac
Apr 3 2018, 8:03 PM
rjvbb committed R626:9aae21bb6830: Minor X11-related build fixes: (authored by rjvbb).
Minor X11-related build fixes:
Apr 3 2018, 4:22 PM
rjvbb committed R5:e7f9b4b09c8b: Merge branch 'frameworks' (v0.6.5-55-g6311c239) into work/frameworks-Mac (authored by rjvbb).
Merge branch 'frameworks' (v0.6.5-55-g6311c239) into work/frameworks-Mac
Apr 3 2018, 2:56 PM
rjvbb added a comment to D11891: Fix crashes in NotifyByAudio when closing applications.

(Oops, missed that one :-/)

Apr 3 2018, 10:21 AM · Frameworks
rjvbb requested changes to D11891: Fix crashes in NotifyByAudio when closing applications.

(sorry, keep forgetting to set the action. Consider this a change request at least for the typo in the comment ;))

Apr 3 2018, 9:35 AM · Frameworks
rjvbb added a comment to D11891: Fix crashes in NotifyByAudio when closing applications.

So the difference here is that finishNotification isn't called if notification == nullptr, with the crucial difference probably being the fact that m isn't added multiple times to the list of reusable items?

Apr 3 2018, 9:32 AM · Frameworks

Mar 28 2018

rjvbb committed R5:3904f3609b0d: Only ask launchd to start a session DBus if none is running already (authored by rjvbb).
Only ask launchd to start a session DBus if none is running already
Mar 28 2018, 4:38 PM
rjvbb committed R5:ecbb68e6502a: use non-deprecated KMultiTabBar::appendTab (authored by rjvbb).
use non-deprecated KMultiTabBar::appendTab
Mar 28 2018, 4:38 PM

Mar 26 2018

rjvbb set the repository for D11183: Sonnet: don't impose the default client to R246 Sonnet.
Mar 26 2018, 7:59 PM · Frameworks
rjvbb updated the diff for D11183: Sonnet: don't impose the default client.

next iteration

Mar 26 2018, 7:58 PM · Frameworks
rjvbb added a comment to D11183: Sonnet: don't impose the default client.

If I suggest something and Milian suggests something else then Milian is right :-)

Mar 26 2018, 7:56 PM · Frameworks
rjvbb added a comment to D11183: Sonnet: don't impose the default client.

ah, then this should be simplified by using std::any_of instead

Mar 26 2018, 12:55 PM · Frameworks
rjvbb set the repository for D11183: Sonnet: don't impose the default client to R246 Sonnet.
Mar 26 2018, 11:33 AM · Frameworks
rjvbb updated the diff for D11183: Sonnet: don't impose the default client.

Modified as requested.
(Please double-check, it works AFAICT but it's the first time I use this construct.)

Mar 26 2018, 11:32 AM · Frameworks

Mar 25 2018

rjvbb added a comment to D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function.

That's because of the MSVC remarks you made inline?

Mar 25 2018, 8:57 PM · Build System, Frameworks

Mar 24 2018

rjvbb added a comment to D11193: Sonnet : use current hunspell API.

No problem if there's a good reason to wait!

Mar 24 2018, 9:21 PM · Frameworks
rjvbb added a comment to D11193: Sonnet : use current hunspell API.
Which version of hunspell does this raise the requirement to?
Mar 24 2018, 8:25 PM · Frameworks
rjvbb added a comment to D11193: Sonnet : use current hunspell API.

Any objections if I commit this by the end of the week?

Mar 24 2018, 2:54 PM · Frameworks
rjvbb added a comment to D11183: Sonnet: don't impose the default client.

Any objections if I commit this by the end of the week?

Mar 24 2018, 2:53 PM · Frameworks

Mar 22 2018

rjvbb added a comment to D11480: Qca: fix cypto.prf on MacOs.
Arcanist does it better https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
Mar 22 2018, 11:18 AM
rjvbb accepted D11480: Qca: fix cypto.prf on MacOs.
Mar 22 2018, 10:22 AM
rjvbb added a comment to D11480: Qca: fix cypto.prf on MacOs.

Thanks for answering and apologies for asking, I didn't have much time to find the entire sources online. And yes, I could easily imagine it was necessary, sorry also if I gave a different impression.

Mar 22 2018, 10:14 AM
rjvbb requested changes to D11480: Qca: fix cypto.prf on MacOs.

Looks good, but could you elaborate the commit message a little bit, explaining why this is necessary, preferably including what the framework's (new) name is?

Mar 22 2018, 9:30 AM

Mar 14 2018

rjvbb added reviewers for D11183: Sonnet: don't impose the default client: dfaure, mlaurent, vkrause.
Mar 14 2018, 8:53 AM · Frameworks
rjvbb added reviewers for D11193: Sonnet : use current hunspell API: dfaure, mlaurent, vkrause.
Mar 14 2018, 8:52 AM · Frameworks

Mar 11 2018

rjvbb set the repository for D11193: Sonnet : use current hunspell API to R246 Sonnet.
Mar 11 2018, 2:54 PM · Frameworks
rjvbb updated the diff for D11193: Sonnet : use current hunspell API.

add missing context (patch unchanged)

Mar 11 2018, 2:53 PM · Frameworks
rjvbb set the repository for D11183: Sonnet: don't impose the default client to R246 Sonnet.
Mar 11 2018, 2:51 PM · Frameworks
rjvbb updated the diff for D11183: Sonnet: don't impose the default client.

Add missing context (patch unchanged)

Mar 11 2018, 2:50 PM · Frameworks

Mar 9 2018

rjvbb requested review of D11193: Sonnet : use current hunspell API.
Mar 9 2018, 8:40 PM · Frameworks
rjvbb requested review of D11183: Sonnet: don't impose the default client.
Mar 9 2018, 3:56 PM · Frameworks
rjvbb committed R246:6a5b1bfa8811: Include replacement strings in the suggestion list (authored by rjvbb).
Include replacement strings in the suggestion list
Mar 9 2018, 3:40 PM
rjvbb committed R246:9268b18d4582: NSSpellChecker plugin cleanup (authored by rjvbb).
NSSpellChecker plugin cleanup
Mar 9 2018, 3:40 PM
rjvbb committed R246:f4425edabc15: initialise NSSpellChecker language in NSSpellCheckerDict ctor (authored by rjvbb).
initialise NSSpellChecker language in NSSpellCheckerDict ctor
Mar 9 2018, 3:40 PM
rjvbb committed R246:c7e118c38d31: implement NSSpellCheckerDict::addPersonal() (authored by rjvbb).
implement NSSpellCheckerDict::addPersonal()
Mar 9 2018, 3:40 PM
rjvbb committed R246:04de42555a0e: NSSpellCheckerDict::suggest() returns a list of suggestions (authored by rjvbb).
NSSpellCheckerDict::suggest() returns a list of suggestions
Mar 9 2018, 3:40 PM
rjvbb committed R246:b908682bf602: implement NSSpellChecker logging category (authored by rjvbb).
implement NSSpellChecker logging category
Mar 9 2018, 3:40 PM
rjvbb committed R246:2652858cfae5: NSSpellChecker requires AppKit (authored by rjvbb).
NSSpellChecker requires AppKit
Mar 9 2018, 3:40 PM
rjvbb committed R246:cf6d1944ea49: Move NSSpellCheckerClient::reliability() out of line (authored by rjvbb).
Move NSSpellCheckerClient::reliability() out of line
Mar 9 2018, 3:40 PM
rjvbb committed R246:5a1479af998f: use the preferred Mac platform token (authored by rjvbb).
use the preferred Mac platform token
Mar 9 2018, 3:40 PM

Mar 7 2018

rjvbb added a comment to D11075: Make Okular show the list of opened windows in the Dock menu.

Qt Assistant also rolls its own Window (sans s...) menu.

Mar 7 2018, 8:47 AM · Okular
rjvbb added a comment to D11074: Fix opening files via a file manager on Mac.
I mean this patch D11075 <https://phabricator.kde.org/D11075> (the Dock menu). setAsDockMenu() is a Mac-only function.
Mar 7 2018, 8:41 AM · Okular

Mar 6 2018

rjvbb added a comment to D11074: Fix opening files via a file manager on Mac.
Would not it end with having #ifdefs scattered all over the QApplication anyway?
Mar 6 2018, 7:37 PM · Okular
rjvbb added a comment to D11075: Make Okular show the list of opened windows in the Dock menu.

Actually, I do not know, whether there is an API that allows to force Mac OS to create such list in the Dock menu, but if an app implements "Window" menu (systemMenu="window" in the menu xib file), then this list is generated automatically.

Mar 6 2018, 7:32 PM · Okular
rjvbb added a comment to D11074: Fix opening files via a file manager on Mac.

In addition to the inline comments:

Mar 6 2018, 5:48 PM · Okular
rjvbb accepted D11075: Make Okular show the list of opened windows in the Dock menu.

I'm not sure if all Mac applications always show the open documents under their Dock tile (that menu can be used for anything, of course), and I also think that it would be more useful to have a Windows menu like (most) native Mac apps have.
Other than that, LGTM.

Mar 6 2018, 12:39 PM · Okular

Mar 5 2018

rjvbb added a comment to D11074: Fix opening files via a file manager on Mac.
One could try to reimplement this with Objective-C, I do not know whether it makes sense though.
Mar 5 2018, 10:39 PM · Okular
rjvbb added a comment to D11074: Fix opening files via a file manager on Mac.
The legacy argc,argv is handled by QCommandLineParser.
Mar 5 2018, 10:37 PM · Okular
rjvbb added a comment to D11074: Fix opening files via a file manager on Mac.
Isn't this another case of "should be fixed in QApplication or another lower level library"?
Mar 5 2018, 9:40 PM · Okular

Mar 1 2018

rjvbb committed R245:3642f7c6a329: fix a leak and incorrect nullptr check in DADictionary. (authored by rjvbb).
fix a leak and incorrect nullptr check in DADictionary.
Mar 1 2018, 1:11 PM

Feb 25 2018

rjvbb added a comment to D10808: Implement the generation of a custom Info.plist for the Mac OS bundle.

Then again, all "not non-gui" applications need an application icon, and adding one is simple enough that it can be done in cmake with a few simple enough operations. And a little bit of extra care in the source code to avoid undoing the effect of ecm_add_app_icon.

Feb 25 2018, 1:58 PM · Okular
rjvbb added a comment to D10808: Implement the generation of a custom Info.plist for the Mac OS bundle.

My original implementation is used in conjunction with a build system that ensures all dependencies are available.

Feb 25 2018, 1:05 PM · Okular
rjvbb accepted D10808: Implement the generation of a custom Info.plist for the Mac OS bundle.

I can hardly NOT accept this, given I'm the original author :)

Feb 25 2018, 11:23 AM · Okular

Feb 21 2018

rjvbb committed R626:2bb3e383c12f: migrate away from KGlobalSettings::*Font() methods (authored by rjvbb).
migrate away from KGlobalSettings::*Font() methods
Feb 21 2018, 10:15 PM
rjvbb closed D10725: QtCurve/KF5 : migrate away from KGlobalSettings::*Font() methods.
Feb 21 2018, 10:15 PM
rjvbb requested review of D10725: QtCurve/KF5 : migrate away from KGlobalSettings::*Font() methods.
Feb 21 2018, 6:42 PM

Feb 17 2018

rjvbb committed R245:cbe5085a646e: Mac/IOKit backend: support for drives, discs and volumes (authored by rjvbb).
Mac/IOKit backend: support for drives, discs and volumes
Feb 17 2018, 10:33 AM
rjvbb closed D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP).
Feb 17 2018, 10:33 AM · Frameworks

Feb 11 2018

rjvbb added a comment to D10415: Fix realDpi function for Mac.

Curious, I cannot give a green light (too), please consider that done...

Feb 11 2018, 7:33 PM · Okular
rjvbb added a comment to D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP).

Thanks Gilles.

Feb 11 2018, 5:12 PM · Frameworks