rjvbb (René J.V. Bertin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2016, 12:33 PM (215 w, 2 d)
Availability
Available

Recent Activity

Sat, May 9

rjvbb added a comment to D25339: update lineHeight if boundingRect indicates a larger value..
I assume the lineHeight usages in the renderer are easy to replace with the proper "height()" of the individual lines of the layout.
Sat, May 9, 2:56 PM · Frameworks, Kate
rjvbb added a comment to D25339: update lineHeight if boundingRect indicates a larger value..
Looking at the code, might it make more sense to just move away from the fixed height we have?
It isn't used that often and in most cases one could just query the height of the current line.
Sat, May 9, 12:06 PM · Frameworks, Kate

Thu, May 7

rjvbb added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

the code can be smart

Thu, May 7, 6:42 PM · Frameworks, Kate
rjvbb added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

This new version does not cause a lineheight regression for me (after backporting it to 5.60.0). However, contrary to what I thought it does not react to emoji

Thu, May 7, 12:39 PM · Frameworks, Kate
rjvbb added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

With "we've ever seen" you do mean that lineheight only changes when a line that requires it scrolls into view?

Thu, May 7, 8:31 AM · Frameworks, Kate

Wed, May 6

rjvbb added a comment to D29227: [dolphin] move settings to more appropriate location.
I like your split, for the most part.
Wed, May 6, 8:20 AM · Dolphin

Tue, May 5

rjvbb added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Yes, but look at the traditional meaning of a text editor, which typically means "plain text" editor. KTextEditor's design decision to use a single lineheight puts it squarely in that domain - to reply in style: It's "TKextEditor", not "KRichTextEditor" (and even less "KWordProcessor") ...

Tue, May 5, 9:23 AM · Frameworks, Kate

Mon, May 4

rjvbb added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

This patch is only needed when mixing a main Latin1 (like) alphanumeric font with occasional glyphs from a font that have a different, taller height?

Mon, May 4, 8:37 PM · Frameworks, Kate
rjvbb requested changes to D25339: update lineHeight if boundingRect indicates a larger value..

I can't speak for the special cases where this change would improve matters, but for me it introduces a clear regression (waste of vertical space: 12 lines less) in a basic ascii code editing context. Font used is Ubuntu Mono 10pt.

Mon, May 4, 5:47 PM · Frameworks, Kate

Sat, May 2

rjvbb added a comment to D18551: clang: Create preamble only on second parse.

Where?

Sat, May 2, 9:01 AM · KDevelop

Apr 28 2020

rjvbb added a comment to D29227: [dolphin] move settings to more appropriate location.

No worry, I only followed this suggestion because I myself had looked for the open-in-tabs option in the Navigation panel more than once.

Apr 28 2020, 5:47 PM · Dolphin
rjvbb added a comment to D29220: Update docs for startup page of configuration.

Of course, I didn't want to suggest that the documentation should already contain views from a future commit. Far from it, IMHO there's so little hurry with this kind of thing that this change could have waited a few days longer as far as I would be concerned ;)

Apr 28 2020, 5:41 PM · Documentation, Dolphin
rjvbb added a comment to D29227: [dolphin] move settings to more appropriate location.

Ha, OK, I'll let you figure this out among yourselves and update my patch once you've come to a consensus :P

Apr 28 2020, 5:38 PM · Dolphin
rjvbb added a comment to F8268049: image.png.
Can it be a standard Breeze theme for consistency?
Apr 28 2020, 1:40 PM
rjvbb added a comment to D29220: Update docs for startup page of configuration.

You mean this? 8-)

Apr 28 2020, 10:41 AM · Documentation, Dolphin
rjvbb set the repository for D28043: [KDevelop] background parser job control to R32 KDevelop.
Apr 28 2020, 9:08 AM · KDevelop
rjvbb updated the diff for D28043: [KDevelop] background parser job control.

I've been addressing issues related to controller proxy instances surviving too long during shutdown and accessing stale memory.

Apr 28 2020, 9:02 AM · KDevelop
rjvbb added a comment to D29220: Update docs for startup page of configuration.

Pity you didn't catch D29227!

Apr 28 2020, 8:48 AM · Documentation, Dolphin
rjvbb set the repository for D29178: [dolphin] : Mac integration to R318 Dolphin.
Apr 28 2020, 8:42 AM · Dolphin
rjvbb updated the diff for D29178: [dolphin] : Mac integration.

I think these were the last outstanding corrections to make?

Apr 28 2020, 8:41 AM · Dolphin
rjvbb added a comment to D29227: [dolphin] move settings to more appropriate location.
How about moving "New windows" to Navigation ?
(Not expected to be done here, could be done later)
Apr 28 2020, 8:12 AM · Dolphin
rjvbb updated the test plan for D29227: [dolphin] move settings to more appropriate location.
Apr 28 2020, 8:10 AM · Dolphin

Apr 27 2020

rjvbb updated the diff for D29227: [dolphin] move settings to more appropriate location.

Updated as requested.

Apr 27 2020, 9:48 PM · Dolphin
rjvbb updated the diff for D29227: [dolphin] move settings to more appropriate location.

Added spacer as requested.

Apr 27 2020, 4:44 PM · Dolphin
rjvbb added inline comments to D29227: [dolphin] move settings to more appropriate location.
Apr 27 2020, 4:43 PM · Dolphin
rjvbb added a comment to D29178: [dolphin] : Mac integration.
In D29178#658443, @alex wrote:

Nope, that is something different, to give you an example:

QStringLiteral("cat %1").arg(KShell::quoteArg("/my/crappy filepath/"));  => cat '/my/crappy filepath/' 
KShell::quoteArg(QStringLiteral("cat %1").arg("/my/crappy filepath/")); => 'cat /my/crappy filepath/'
Apr 27 2020, 4:37 PM · Dolphin
rjvbb added a comment to D29178: [dolphin] : Mac integration.

This causes a compile error: ‘quoteArgs’ is not a member of ‘KShell’

Apr 27 2020, 3:09 PM · Dolphin
rjvbb requested review of D29227: [dolphin] move settings to more appropriate location.
Apr 27 2020, 12:59 PM · Dolphin
rjvbb added inline comments to D29178: [dolphin] : Mac integration.
Apr 27 2020, 9:25 AM · Dolphin
rjvbb set the repository for D29178: [dolphin] : Mac integration to R318 Dolphin.
Apr 27 2020, 8:53 AM · Dolphin
rjvbb updated the diff for D29178: [dolphin] : Mac integration.

Fixed.

Apr 27 2020, 8:53 AM · Dolphin
rjvbb added inline comments to D29178: [dolphin] : Mac integration.
Apr 27 2020, 8:51 AM · Dolphin
rjvbb committed R318:d3813ee65e1d: prevent a QFileInfo warning (authored by rjvbb).
prevent a QFileInfo warning
Apr 27 2020, 8:33 AM
rjvbb closed D29194: [dolphin] : prevent QFileInfo warning.
Apr 27 2020, 8:33 AM · Dolphin

Apr 26 2020

rjvbb planned changes to D29178: [dolphin] : Mac integration.
Apr 26 2020, 10:28 PM · Dolphin
rjvbb added a comment to D29194: [dolphin] : prevent QFileInfo warning.
Shouldn't this be fixed in Baloo then?
Apr 26 2020, 2:40 PM · Dolphin
rjvbb added a comment to D29194: [dolphin] : prevent QFileInfo warning.
What do those warnings look like, could you copy them in the commit comment ?
Apr 26 2020, 1:12 PM · Dolphin
rjvbb updated the summary of D29194: [dolphin] : prevent QFileInfo warning.
Apr 26 2020, 1:11 PM · Dolphin
rjvbb requested review of D29194: [dolphin] : prevent QFileInfo warning.
Apr 26 2020, 10:49 AM · Dolphin
rjvbb added inline comments to D29178: [dolphin] : Mac integration.
Apr 26 2020, 9:05 AM · Dolphin
rjvbb updated the diff for D29178: [dolphin] : Mac integration.

Updated as requested.

Apr 26 2020, 9:05 AM · Dolphin
rjvbb added a comment to D29178: [dolphin] : Mac integration.

Please see the test plan in the diff that I mentioned. Should be readily reproducible in that scenario.

Apr 26 2020, 8:42 AM · Dolphin
rjvbb added inline comments to D29178: [dolphin] : Mac integration.
Apr 26 2020, 8:16 AM · Dolphin

Apr 25 2020

rjvbb added a comment to D29178: [dolphin] : Mac integration.

+ QString command = QStringLiteral("%1 --new-window").arg(QCoreApplication::applicationFilePath());

I think you need a KShell::quoteArgs in case there's spaces in the path

Apr 25 2020, 7:46 PM · Dolphin
rjvbb added a comment to D29178: [dolphin] : Mac integration.
I cannot test, by the patch seems correct and not intrusive.
Apr 25 2020, 7:32 PM · Dolphin
rjvbb set the repository for D29178: [dolphin] : Mac integration to R318 Dolphin.
Apr 25 2020, 12:58 PM · Dolphin
rjvbb updated the diff for D29178: [dolphin] : Mac integration.

Remove spurious hunk.

Apr 25 2020, 12:57 PM · Dolphin
rjvbb requested review of D29178: [dolphin] : Mac integration.
Apr 25 2020, 12:56 PM · Dolphin

Apr 22 2020

rjvbb added a comment to D16648: Open externally called files/directories in new tabs.

A thought: shouldn't the KRun::run* functions use QCoreApplication::applicationFilePath() instead of invoking "dolphin" and hope the path leads to the same application?

Apr 22 2020, 9:22 AM · Dolphin

Apr 21 2020

rjvbb added a comment to D20739: Handle multiple entries in map.
Instead of adding Windows support where the platform *is* different, you introduce additional differences.
Apr 21 2020, 4:44 PM · Baloo
rjvbb added a comment to D20739: Handle multiple entries in map.

any bug reports for the Windows platform will be rejected immediately then.

Apr 21 2020, 1:46 PM · Baloo
rjvbb added a comment to D20739: Handle multiple entries in map.

Ultimately this wasn't difficult, so apologies for the noise!

Apr 21 2020, 12:39 PM · Baloo
rjvbb added a comment to D20739: Handle multiple entries in map.
> std::for_each(beginKey, rangeEnd, [&list,&propMap](const KFileMetaData::Property::Property& s) { list.append(propMap[s]); });

the []operator always returns the most recently inserted value for the same key according to docs. You must iterate over the values directly.
Apr 21 2020, 11:57 AM · Baloo
rjvbb added a comment to D20739: Handle multiple entries in map.
Qt 5.10. is required since KF 5.55: https://kde.org/announcements/kde-frameworks-5.55.0.php.
Apr 21 2020, 11:05 AM · Baloo
rjvbb added a comment to D20739: Handle multiple entries in map.

I'm updating some of my packaging for a set-up that should meet the minimum requirements that were current when this commit was made (Qt 5.9 and KF5 5.60.0; baloo-widgets 19.08.3 requires Qt 5.8 and KF5 5.58.0). Evidently this change wasn't checked against those requirements; the constKeyValue* iterators were introduced in Qt 5.10 (this lack of testing is also apparent in filemetadatadatedisplaytest.cpp:57!)

Apr 21 2020, 9:23 AM · Baloo

Apr 12 2020

rjvbb set the repository for D28043: [KDevelop] background parser job control to R32 KDevelop.
Apr 12 2020, 2:55 PM · KDevelop
rjvbb updated the diff for D28043: [KDevelop] background parser job control.

Don't just stop parsing files when shutting down, also ignore new document add requests.

Apr 12 2020, 2:55 PM · KDevelop

Apr 11 2020

rjvbb set the repository for D28043: [KDevelop] background parser job control to R32 KDevelop.
Apr 11 2020, 3:21 PM · KDevelop
rjvbb updated the diff for D28043: [KDevelop] background parser job control.

Updated and improved version:

  • the registration with the ProcessController is done "JIT", just before enqueing the first document for actual parsing
  • keep track of documents via the QUrls of IndexedStrings
Apr 11 2020, 3:20 PM · KDevelop

Mar 17 2020

rjvbb set the repository for D28043: [KDevelop] background parser job control to R32 KDevelop.
Mar 17 2020, 4:53 PM · KDevelop
rjvbb updated the diff for D28043: [KDevelop] background parser job control.

This addresses a few issues, notably by using a queued signal to trigger url (un)registering from the requesting (weaver) thread in the thread where the JobController lives too.

Mar 17 2020, 4:53 PM · KDevelop

Mar 14 2020

rjvbb added a comment to T12815: Create Calligra Framework by separating out applications and libraries.
I sometimes find myself feeling this way about Frameworks too. A recent experience at a hackathon where I helped 8 students set up complete development environments from scratch reinforced this viewpoint. Not that I'm seriously recommending re-merging the frameworks, but I would like to challenge the notion that splitting a monolithic codebase across multiple repos is a boon to onboarding; I don't think it is. It may have other benefits, but I don't think onboarding is one of them.
Mar 14 2020, 5:40 PM · Calligra: 3.0
rjvbb added a comment to T12815: Create Calligra Framework by separating out applications and libraries.
As an aside, I think splitting up kdepim into so many repositories was a huge mistake.
Mar 14 2020, 12:39 PM · Calligra: 3.0
rjvbb requested review of D28043: [KDevelop] background parser job control.
Mar 14 2020, 10:30 AM · KDevelop

Mar 13 2020

rjvbb added a comment to T12815: Create Calligra Framework by separating out applications and libraries.

What's the size of the .git directory of the calligra repo these days? I seem to recall it was what I thought really huge already in KDE4 days. Last time I tried git wouldn't let you push from a clone that didn't have the full history. And yes, for me there's a point where I consider the value of my few and smallish contributions don't justify wasting "that much" disk space on what's literally old history.

Mar 13 2020, 8:56 PM · Calligra: 3.0

Mar 7 2020

rjvbb added a comment to D18551: clang: Create preamble only on second parse.
Our discussion is about when to create the preamble for open documents. If I were to stop that job, I wouldn't get the AST, but I want the AST. I just don't want the preamble before I've started editing the file.
Mar 7 2020, 9:14 AM · KDevelop

Mar 6 2020

rjvbb added a comment to D18551: clang: Create preamble only on second parse.

As I said, I thought the possibility to cancel jobs could be a comprise (I don't get the impression you've been able to find one yet), but OK. I've started to peek around in the code to see about job control, if these are based on KJob it shouldn't be hard to add them to the existing job controller.

Mar 6 2020, 7:40 AM · KDevelop

Mar 5 2020

rjvbb added a comment to D18551: clang: Create preamble only on second parse.
Rene, I'm missing context - what are you replying to? This doesn't seem to be related to the preamble?
Mar 5 2020, 9:21 PM · KDevelop

Mar 4 2020

rjvbb added a comment to D18551: clang: Create preamble only on second parse.

Re: the time and resources spent by the background parser when you'd rather not:

Mar 4 2020, 9:18 AM · KDevelop

Feb 15 2020

rjvbb accepted D27065: Fix inverted logic in IOKitStorage::isRemovable.

Works fine as far as I can tell, amazing no one else noticed this before!

Feb 15 2020, 10:45 PM · Frameworks
rjvbb updated subscribers of D27065: Fix inverted logic in IOKitStorage::isRemovable.

Well, I got as far as confirming you're probably right, when I finally got to sit at my Mac yesterday night ... and then when I woke up it was 3am.

Feb 15 2020, 9:36 AM · Frameworks

Feb 13 2020

rjvbb added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.

Sorry, no. Swamped with last-minute reconstruction efforts in the, erm, structure that's supposed to become my new house next week :-/

Feb 13 2020, 12:35 PM · Frameworks

Feb 10 2020

rjvbb added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.
This is a MacBook Pro Retina, 13-inch, Mid 2014 with macOS 10.15.2 with only this one disk. It's clearly not supposed to get removed, imo :)
Feb 10 2020, 2:32 PM · Frameworks
rjvbb added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.

How do you connect? The Mac OS has a built-in VNC server but it has to be activated. Once it is you should be able to connect using any VNC client (possibly using ssh tunnelling?).

Feb 10 2020, 12:50 PM · Frameworks
rjvbb added a comment to D27065: Fix inverted logic in IOKitStorage::isRemovable.
The output comes from running `solid-hardware5 details` and `solid-hardware nonportableinfo` on the UID.
Feb 10 2020, 11:24 AM · Frameworks
rjvbb added a reviewer for D27065: Fix inverted logic in IOKitStorage::isRemovable: cgilles.

before:

[snip]

Note the Ejectable = false (bool) vs. StorageDrive.removable = true (bool). The patch here fixes it to yield StorageDrive.removable = false (bool)

Feb 10 2020, 10:59 AM · Frameworks

Feb 3 2020

rjvbb added a comment to D18551: clang: Create preamble only on second parse.

You don't have control over where those pch files are written, right, other than through setting $TMPDIR?

Feb 3 2020, 9:44 PM · KDevelop

Feb 2 2020

rjvbb added a comment to D22801: [KIO] silence a QFileInfo warning.

Whatever, I'm staying at 5.60.0 anyway, with whatever patches I deem appropriate.

Feb 2 2020, 6:13 PM · Frameworks
rjvbb added a comment to D22801: [KIO] silence a QFileInfo warning.

I might (if I can find the trouble location) but IMHO KIO should still account for the possibility of this situation too (or more in general, bail out this function for any path that cannot be a mountpoint).

Feb 2 2020, 1:37 PM · Frameworks

Jan 30 2020

rjvbb closed D22719: Avoid yet another crash on exit.

Go figure... I had exactly this kind of crash the other day, despite your proposed change.

Jan 30 2020, 9:33 AM

Jan 21 2020

rjvbb committed R626:e996040b6972: Use cached appName for DBus (dis)connecting. (authored by rjvbb).
Use cached appName for DBus (dis)connecting.
Jan 21 2020, 1:43 PM

Jan 13 2020

rjvbb added a comment to D26050: Fix build with poppler 82.
I am a firm +1 on splitting Calligra
Jan 13 2020, 3:28 PM · Calligra: 3.0
rjvbb added a comment to D15797: [kdev-clazy] : use canonical paths.

So no urgent need for me to revisit the code?

Jan 13 2020, 7:32 AM · KDevelop

Jan 9 2020

rjvbb added a comment to D15797: [kdev-clazy] : use canonical paths.

Difficult to wrap my head around this, so much later!

Jan 9 2020, 9:38 PM · KDevelop

Jan 7 2020

rjvbb added a comment to D26180: phonon : build against "older" Qt5 versions.
KF5's Qt support strategy is sound
Jan 7 2020, 3:41 PM
rjvbb added a comment to D26180: phonon : build against "older" Qt5 versions.

But why, there's nothing that requires this other than that single env. var. function that may not even be the most appropriate one (I find the documentation a bit confusing).

Jan 7 2020, 1:32 PM

Dec 23 2019

rjvbb requested review of D26180: phonon : build against "older" Qt5 versions.
Dec 23 2019, 10:13 AM

Nov 14 2019

rjvbb added a comment to D22801: [KIO] silence a QFileInfo warning.
I disagree since it will change the current precondition of the function for the need of one of its users.
Nov 14 2019, 12:07 PM · Frameworks

Nov 13 2019

rjvbb added a comment to D22801: [KIO] silence a QFileInfo warning.

Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?

Nov 13 2019, 3:21 PM · Frameworks

Nov 12 2019

rjvbb added a comment to D22802: [dolphin] make link with LLVM.

Apologies, I've been stretched way too thin since about the time this diff was accepted, I don't think I even noticed the fact.

Nov 12 2019, 4:50 PM · Dolphin
rjvbb committed R318:83dc0afe4670: make link with LLVM (authored by rjvbb).
make link with LLVM
Nov 12 2019, 4:49 PM
rjvbb closed D22802: [dolphin] make link with LLVM.
Nov 12 2019, 4:49 PM · Dolphin

Oct 21 2019

rjvbb updated the diff for D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).

Rebased for the 5.4 branch. Still working perfectly for me, without noticeably slower reaction times on local filesystems.

Oct 21 2019, 4:11 PM · KDevelop
rjvbb updated the diff for D4981: patchreview : allow choice of the number of context lines.

Rebased for the 5.4 branch.

Oct 21 2019, 4:04 PM · KDevelop

Oct 19 2019

rjvbb committed R32:24d0c68338b7: [Grepview] Use the correct fallback icon for Collapse All (authored by rjvbb).
[Grepview] Use the correct fallback icon for Collapse All
Oct 19 2019, 12:35 PM

Oct 11 2019

rjvbb committed R32:900d5ec826bc: FileManagerListJob: use a semaphore for locking (authored by rjvbb).
FileManagerListJob: use a semaphore for locking
Oct 11 2019, 1:35 PM

Oct 10 2019

rjvbb added a comment to D18551: clang: Create preamble only on second parse.
I'm not suggesting to not create a preamble at all, but to create it only when we **know** it is needed.
Oct 10 2019, 8:26 AM · KDevelop

Oct 6 2019

rjvbb committed R113:ad3cddb5954e: Fix the KDE4 build of the oxygen-demo (authored by rjvbb).
Fix the KDE4 build of the oxygen-demo
Oct 6 2019, 2:25 PM
rjvbb closed D13881: oxygen-demo : add KMessage preview.
Oct 6 2019, 2:25 PM · Plasma

Oct 4 2019

rjvbb added a comment to D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.

A little tinker tool:

Oct 4 2019, 1:20 PM · Frameworks