rjvbb (René J.V. Bertin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2016, 12:33 PM (139 w, 4 d)
Availability
Available

Recent Activity

Fri, Dec 14

rjvbb committed R495:72ea330791f0: remove obsolete comment (authored by rjvbb).
remove obsolete comment
Fri, Dec 14, 12:07 PM
rjvbb committed R32:dc6a95e9628c: 2 missing KTextEditorPluginIntegration::MainWindow slots (authored by rjvbb).
2 missing KTextEditorPluginIntegration::MainWindow slots
Fri, Dec 14, 8:49 AM
rjvbb closed D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.
Fri, Dec 14, 8:49 AM · KDevelop

Tue, Dec 11

rjvbb added a comment to D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.

No objections?

Tue, Dec 11, 3:33 PM · KDevelop

Mon, Dec 10

rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

The current master is fontconfig only, since there is no way to leave the fontconfig specific parts out of QML.

Mon, Dec 10, 8:49 PM · Plasma: KCM Redesign
rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

It's not clear who wrote that about being fontconfig specific (or the IMHO incorrect suggestion that Freetype is implemented 3x).

Mon, Dec 10, 7:31 PM · Plasma: KCM Redesign
rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

Why not make these separate KCMs? I don't know how usual it is to open just the fonts KCM (kcmshell5 fonts) or if the vast majority of users gets to that config page only via the systemsettings app. For those you don't need to implement a tab-like mode switch because systemsettings already provides that for different KCMs. And users who go through kcmshell5 can probably learn quite easily to modify their commandline.
This approach also means you don't have to worry about whether and how to implement mode persistence.

Mon, Dec 10, 6:22 PM · Plasma: KCM Redesign
rjvbb closed D17314: Projects Plugin: Add ShellCheck analyzer.

Fixed in 66a84c9e0f94351b8f328f3c0af259983bfc1592

Mon, Dec 10, 1:15 PM · Kate
rjvbb added a comment to D17314: Projects Plugin: Add ShellCheck analyzer.

I can commit if you want (if nobody else beats me to it).

Mon, Dec 10, 12:29 PM · Kate
rjvbb reopened D17314: Projects Plugin: Add ShellCheck analyzer.

I'm not finding any information on a QStringLiteral header file in the official documentation; it certainly doesn't exist in Qt 5.9.7 yet. AFAIK the header to include is the one for QString.

Mon, Dec 10, 12:10 PM · Kate
rjvbb committed R40:1b5396cedbbc: set icon and title on the CTags/Configure dialog (authored by rjvbb).
set icon and title on the CTags/Configure dialog
Mon, Dec 10, 10:13 AM
rjvbb added a comment to D16779: kate-ctags plugin: support KDevelop (WIP).

Better late than never: I also figured out how to make the plugin's toolview display correctly in KDevelop: https://commits.kde.org/kate/3cd03f408eed2d66ae008fb8349f8b5af24260e9

Mon, Dec 10, 9:43 AM · KDevelop, KTextEditor, Kate
rjvbb updated the test plan for D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.
Mon, Dec 10, 9:40 AM · KDevelop
rjvbb committed R40:3cd03f408eed: CTags plugin : missed KDevelop integration aspects (authored by rjvbb).
CTags plugin : missed KDevelop integration aspects
Mon, Dec 10, 9:29 AM

Sun, Dec 9

rjvbb requested review of D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.
Sun, Dec 9, 10:06 PM · KDevelop
rjvbb committed R40:9af81dd535c7: CTags plugin: make usable in KDevelop (authored by rjvbb).
CTags plugin: make usable in KDevelop
Sun, Dec 9, 7:39 PM
rjvbb closed D16779: kate-ctags plugin: support KDevelop (WIP).
Sun, Dec 9, 7:39 PM · KDevelop, KTextEditor, Kate
rjvbb committed R32:a5ca3cd1b0a3: polish Purpose integration in the PatchReview plugin (authored by rjvbb).
polish Purpose integration in the PatchReview plugin
Sun, Dec 9, 7:13 PM
rjvbb closed D17424: KDevelop/PatchReview: polish Purpose integration.
Sun, Dec 9, 7:13 PM · KDevelop

Sat, Dec 8

rjvbb requested review of D17424: KDevelop/PatchReview: polish Purpose integration.
Sat, Dec 8, 9:10 AM · KDevelop

Fri, Dec 7

rjvbb committed R495:8002a0259daf: add missing properties (authored by rjvbb).
add missing properties
Fri, Dec 7, 9:20 PM
Restricted Application added a project to D1420: [OS X] build in a more "traditional" way (for distribution systems like MacPorts, Fink etc) (and a bit of code clean-up): KDE Edu.
Fri, Dec 7, 7:10 PM · KDE Edu, Marble
rjvbb updated the diff for D1420: [OS X] build in a more "traditional" way (for distribution systems like MacPorts, Fink etc) (and a bit of code clean-up).

Refactored for current git/master.

Fri, Dec 7, 6:45 PM · KDE Edu, Marble

Thu, Dec 6

rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.

This revision was not accepted when it landed; it landed in state "Needs Review".

Thu, Dec 6, 10:03 AM · Plasma
rjvbb closed D4929: DrKonqi : lldb and Mac support.
Thu, Dec 6, 9:57 AM · Plasma
rjvbb committed R871:13121f4a303b: lldb and Mac support (authored by rjvbb).
lldb and Mac support
Thu, Dec 6, 9:57 AM

Wed, Dec 5

rjvbb added a reverting change for R302:3af09cd83051: ksvg2icns: use QCoreApplication instead of QGuiApplication: R302:dde8ded03158: Revert "ksvg2icns: use QCoreApplication instead of QGuiApplication".
Wed, Dec 5, 4:05 PM
rjvbb committed R302:dde8ded03158: Revert "ksvg2icns: use QCoreApplication instead of QGuiApplication" (authored by rjvbb).
Revert "ksvg2icns: use QCoreApplication instead of QGuiApplication"
Wed, Dec 5, 4:05 PM
rjvbb set the repository for D16779: kate-ctags plugin: support KDevelop (WIP) to R40 Kate.
Wed, Dec 5, 3:05 PM · KDevelop, KTextEditor, Kate
rjvbb updated the diff for D16779: kate-ctags plugin: support KDevelop (WIP).

Updated as requested.

Wed, Dec 5, 3:04 PM · KDevelop, KTextEditor, Kate
rjvbb committed R302:4bb76d8882a9: ksvg2icns : use QStringLiteral() (authored by rjvbb).
ksvg2icns : use QStringLiteral()
Wed, Dec 5, 11:47 AM
rjvbb committed R302:2e32fcb53175: ksvg2icns : use Qt 5.9+ QTemporaryDir API (authored by rjvbb).
ksvg2icns : use Qt 5.9+ QTemporaryDir API
Wed, Dec 5, 11:47 AM
rjvbb committed R302:3af09cd83051: ksvg2icns: use QCoreApplication instead of QGuiApplication (authored by rjvbb).
ksvg2icns: use QCoreApplication instead of QGuiApplication
Wed, Dec 5, 11:47 AM

Tue, Dec 4

rjvbb set the repository for D16779: kate-ctags plugin: support KDevelop (WIP) to R40 Kate.
Tue, Dec 4, 8:53 PM · KDevelop, KTextEditor, Kate
rjvbb updated the diff for D16779: kate-ctags plugin: support KDevelop (WIP).

undesirable qWarning() removed

Tue, Dec 4, 8:52 PM · KDevelop, KTextEditor, Kate

Mon, Dec 3

rjvbb set the repository for D17289: KDevelop/Shell: set dedicated TMPDIR to R32 KDevelop.
Mon, Dec 3, 11:02 AM · KDevelop
rjvbb updated the diff for D17289: KDevelop/Shell: set dedicated TMPDIR.

FIxed and streamlined version.

Mon, Dec 3, 11:01 AM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
Also, considering that "session" in `Core::initialize` is user-specified and defaults to an empty string, please do not use a 100% deterministic name,
Mon, Dec 3, 10:21 AM · KDevelop
rjvbb added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.

No, it went beyond that: the original underlying principle was "don't assume or hardcode /usr/local anywhere, use whatever install prefix the user specified".

Mon, Dec 3, 9:02 AM · KDevelop

Sun, Dec 2

rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Actually, issues with clang temp files is why I started to think about this kind of change but ultimately I realised it didn't seem such a bad idea at all to put all KDevelop-related temporary files in a dedicated location. I often clean out a bunch of KDevelop's own temp files that were left behind, e.g. after a crash. I just didn't mention them because they're negligible in size (and I purge before their numbers really start to grow).

Sun, Dec 2, 9:26 PM · KDevelop
rjvbb added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.
On Linux quite possibly too, I think many packaging systems install into some temporary dir and then copy the deployment out of there for archiving.
Sun, Dec 2, 9:13 PM · KDevelop

Sat, Dec 1

rjvbb requested review of D17289: KDevelop/Shell: set dedicated TMPDIR.
Sat, Dec 1, 7:56 PM · KDevelop
rjvbb set the repository for D17255: KDevelop: support for installing into a non-standard parallel prefix to R32 KDevelop.
Sat, Dec 1, 11:04 AM · KDevelop
rjvbb updated the diff for D17255: KDevelop: support for installing into a non-standard parallel prefix.

The python script changes were committed to the master branch as requested (db05710cb6931a7b44d7fc70bfcfe75c7ccc9f4a).

Sat, Dec 1, 11:04 AM · KDevelop
rjvbb committed R32:db05710cb693: QMLJS plugin: Use dynamic interpreter lookup in python scripts (authored by rjvbb).
QMLJS plugin: Use dynamic interpreter lookup in python scripts
Sat, Dec 1, 10:15 AM
rjvbb committed R32:7898bb4174e3: fix version detection in test_cmakeserver (authored by rjvbb).
fix version detection in test_cmakeserver
Sat, Dec 1, 9:46 AM

Fri, Nov 30

rjvbb committed R495:f338282db51e: DiffListModel::refresh(): return at once when already active. (authored by rjvbb).
DiffListModel::refresh(): return at once when already active.
Fri, Nov 30, 9:39 PM
rjvbb committed R495:36b17c15e01b: phabricator plugin: use Arcanist's diff.rev. order (authored by rjvbb).
phabricator plugin: use Arcanist's diff.rev. order
Fri, Nov 30, 9:29 PM
rjvbb added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.

The change doesn't change the default, but why would using '/usr' (instead of '/usr/local') be worse than using 'c:\Program Files' under MS Windows?

Nope. It *does* change the default if KDevelop's install prefix is not /usr/local.

Fri, Nov 30, 2:57 PM · KDevelop
rjvbb added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Fri, Nov 30, 1:55 PM · KDevelop
rjvbb requested review of D17255: KDevelop: support for installing into a non-standard parallel prefix.
Fri, Nov 30, 11:38 AM · KDevelop

Tue, Nov 27

rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.

David, it seems our posts crossed, or did you actually see the new version I just uploaded?

Tue, Nov 27, 12:01 PM · Plasma
rjvbb set the repository for D4929: DrKonqi : lldb and Mac support to R871 DrKonqi.
Tue, Nov 27, 12:00 PM · Plasma
rjvbb updated the diff for D4929: DrKonqi : lldb and Mac support.

Fixed the AppleTerminal oversight in the non-Apple lldbrc.

Tue, Nov 27, 11:59 AM · Plasma
rjvbb added inline comments to D4929: DrKonqi : lldb and Mac support.
Tue, Nov 27, 8:07 AM · Plasma

Mon, Nov 26

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

A more complete draft:

Mon, Nov 26, 10:36 PM · Build System
rjvbb added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

bump?

Mon, Nov 26, 9:15 AM · KDevelop

Sun, Nov 25

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

You will notice that I plan to maintain an option to disable the Apple-specific behaviour for anyone who depends on the current behaviour (that includes me, but your script would also continue to work). Cf. the APPLE_FORCE_X11 option

Sun, Nov 25, 11:42 AM · Build System
rjvbb added a comment to D16370: KTextEditor : syntax definition priority UI usability.
Allowing negative prios makes sense.
Sun, Nov 25, 9:46 AM · Frameworks, Kate, KTextEditor
rjvbb closed D16370: KTextEditor : syntax definition priority UI usability.
Sun, Nov 25, 9:35 AM · Frameworks, Kate, KTextEditor
rjvbb committed R39:4009bc1e919d: Allow negative syntax definition priorities. (authored by rjvbb).
Allow negative syntax definition priorities.
Sun, Nov 25, 9:35 AM

Sat, Nov 24

rjvbb closed D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps.
Sat, Nov 24, 9:35 AM · Plasma
rjvbb committed R858:1e02355c1786: Support for QGuiApplication-based apps (authored by rjvbb).
Support for QGuiApplication-based apps
Sat, Nov 24, 9:35 AM

Fri, Nov 23

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

Can we set DATAROOTDIR=/Library/Application Support/KDE so that everything remains nicely bundled?

Fri, Nov 23, 1:38 PM · Build System
rjvbb updated subscribers of T10112: KDEInstallDirs on Mac.
Fri, Nov 23, 1:33 PM · Build System
rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

At that time hinting with freetype wasn't state of the art due to patent issues, but that has changed with the v40 engine in freetype 2.7.

Fri, Nov 23, 11:54 AM · Plasma: KCM Redesign
rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

The current KCM already has a control for that.

Fri, Nov 23, 10:13 AM · Plasma: KCM Redesign
rjvbb created T10112: KDEInstallDirs on Mac.
Fri, Nov 23, 10:00 AM · Build System
rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

Found this by accident, and had only one immediate thought

Fri, Nov 23, 9:17 AM · Plasma: KCM Redesign
rjvbb added inline comments to D4929: DrKonqi : lldb and Mac support.
Fri, Nov 23, 9:02 AM · Plasma
rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.

That'll probably be when we move to Qt6.

Fri, Nov 23, 8:38 AM · Plasma

Thu, Nov 22

rjvbb set the repository for D4929: DrKonqi : lldb and Mac support to R871 DrKonqi.
Thu, Nov 22, 10:12 PM · Plasma
rjvbb updated the diff for D4929: DrKonqi : lldb and Mac support.

includes the root cmake file changes.

Thu, Nov 22, 10:11 PM · Plasma
rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.
a find_packge for `KF5::WindowSystem` is missing in the root CMakeLists file.
Thu, Nov 22, 9:55 PM · Plasma
rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.
Can you rebase it over the last master branch ?
Thu, Nov 22, 6:58 PM · Plasma
rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.

FWIW, anyone can request changes to a review, but also accept it. And while I would probably not take that as a green light to commit unless it comes from a known KDE dev it *does* go to show demand/need for a change. And hopefully, confirmation that it doesn't only work for the author.

Thu, Nov 22, 5:03 PM · Plasma
rjvbb updated subscribers of D4929: DrKonqi : lldb and Mac support.
Thu, Nov 22, 4:54 PM · Plasma
rjvbb set the repository for D4929: DrKonqi : lldb and Mac support to R871 DrKonqi.
Thu, Nov 22, 4:54 PM · Plasma
rjvbb updated the diff for D4929: DrKonqi : lldb and Mac support.

Refactored for the standalone DrKonqi repo and disabled the integration testing on Mac.

Thu, Nov 22, 4:51 PM · Plasma
rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.

Sorry, I had updating this on my list but it drifted to the bottom...

Thu, Nov 22, 4:42 PM · Plasma

Wed, Nov 21

rjvbb requested changes to D17054: Retina Support for MacOS.

Actually, I realise this patch too is a somewhat stripped down version of a patch I've been using for a long time in my MacPorts packaging for Okular:

Wed, Nov 21, 9:56 AM · Okular
rjvbb requested changes to D17053: Fix link on MacOS.

@rjvbb what do you say? makes sense?

Wed, Nov 21, 12:15 AM · Okular
rjvbb added a comment to D17054: Retina Support for MacOS.

This change does more than just enabling hidpi support in the plist.

Wed, Nov 21, 12:09 AM · Okular

Tue, Nov 20

rjvbb added a comment to D16915: Disable plugin project config if project without a IBuildSystemManager dep.

Found back my ML post entitled

("compiledb-generator and the generic Makefile proj.manager"). Francis Herne replied

*this*:

Tue, Nov 20, 9:34 AM · KDevelop
rjvbb added a comment to D16915: Disable plugin project config if project without a IBuildSystemManager dep.
That must have been magic code then, quick, try to catch it, we all want that ;)
Tue, Nov 20, 8:40 AM · KDevelop
rjvbb added a comment to D16915: Disable plugin project config if project without a IBuildSystemManager dep.
Not supported, since in your case KDevelop simply does not know a compile_commands.json exist,
Tue, Nov 20, 12:20 AM · KDevelop

Mon, Nov 19

rjvbb set the repository for D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions to R32 KDevelop.
Mon, Nov 19, 12:00 PM · KDevelop
rjvbb updated the diff for D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

Well, apparently the contextmenu CAN change during a session (at least on Mac and when I open it in different opened-at-session-load documents when the initial project load and parsing activity is still in progress).

Mon, Nov 19, 12:00 PM · KDevelop
rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Mon, Nov 19, 9:51 AM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

This implements and uses my idea of an ecm_add_<lang>_compiler_flags_if_supported function set for C and C++. It uses compiler ID+version conditions to determine if flag(s) are supported when those conditions are known and reliable - otherwise and only then does it resort to querying the compiler.

Mon, Nov 19, 9:50 AM · Frameworks, Build System
rjvbb added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.
E.g. I would have expected before looking at things that each view has their own separate context menu instance, possibly even created on the fly per display :)
Mon, Nov 19, 9:14 AM · KDevelop
rjvbb set the repository for D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions to R32 KDevelop.
Mon, Nov 19, 9:03 AM · KDevelop
rjvbb updated the diff for D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

Another fix: use the active MainWindow as the parent of the contextMenuData instance and do NOT delete it in the TextDocumentPrivate dtor.

Mon, Nov 19, 9:03 AM · KDevelop

Nov 18 2018

rjvbb updated the diff for D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

Apologies, the tear-off bit shouldn't have been included of course.

Nov 18 2018, 10:41 PM · KDevelop
rjvbb set the repository for D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions to R32 KDevelop.
Nov 18 2018, 10:34 PM · KDevelop
rjvbb updated the diff for D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

updated as suggested:

  • moves the context menu added stuff logic into a dedicated class (as an upbeat to possible future improvement)
  • caches the QMenu* to which actions were last added, and removes them from that menu when the next context menu is shown. This should be equivalent to removing the items on contextMenuAboutToHide.
Nov 18 2018, 10:34 PM · KDevelop
rjvbb added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation.

Sh@@t, sorry, I allowed some unrelated (and potential future) changes to pollute this version. Will fix tomorrow.

Nov 18 2018, 9:53 PM · KDevelop
rjvbb updated subscribers of D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.
I would see the flaw also in that there is no specification in the KTextEditor API how the context menu is shared/reused.
Nov 18 2018, 9:30 PM · KDevelop

Nov 17 2018

rjvbb updated subscribers of D16779: kate-ctags plugin: support KDevelop (WIP).
Nov 17 2018, 4:11 PM · KDevelop, KTextEditor, Kate
rjvbb set the repository for D16779: kate-ctags plugin: support KDevelop (WIP) to R40 Kate.
Nov 17 2018, 4:11 PM · KDevelop, KTextEditor, Kate