gregormi (gregormi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2015, 8:50 PM (175 w, 5 d)
Availability
Available

Recent Activity

Yesterday

gregormi added inline comments to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Wed, Oct 17, 9:47 PM · Kate
gregormi added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

Hi Gregor, I just did a post-review again, and noticed several issues I think we should address. I have a patch ready for most of the stuff, but did not yet post it on Phabricator, since I indeed use KTextEditor::Document as member pointer in the FileListItem, and its constructor now reads the icon etc from the document, which destroys the tsttestapp demo. So the comments are just here to make you aware of the issues. We can have the real discussion when I post the patch.

Wed, Oct 17, 9:36 PM · Kate
gregormi added inline comments to D15804: Fix Duplicates on Quick Open File.
Wed, Oct 17, 7:16 PM · Kate

Mon, Oct 15

gregormi committed R40:5009ec07d044: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp (authored by gregormi).
Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp
Mon, Oct 15, 9:20 PM
gregormi closed D16215: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp.
Mon, Oct 15, 9:20 PM · Kate
gregormi updated the summary of D16215: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp.
Mon, Oct 15, 7:47 PM · Kate
gregormi added inline comments to D15804: Fix Duplicates on Quick Open File.
Mon, Oct 15, 7:44 PM · Kate
gregormi updated the diff for D16204: Quick Open: Remove file:/// prefix.
  • Proposal for column sizing for the case of long file names
Mon, Oct 15, 10:51 AM · Kate
gregormi added inline comments to D15804: Fix Duplicates on Quick Open File.
Mon, Oct 15, 10:35 AM · Kate
gregormi added a comment to D16204: Quick Open: Remove file:/// prefix.

@tcanabrava Does this clash with your patch in D15804 ?

Mon, Oct 15, 10:30 AM · Kate
gregormi updated the diff for D16204: Quick Open: Remove file:/// prefix.
  • use toDisplayString
Mon, Oct 15, 10:07 AM · Kate
gregormi added a comment to D16214: New Tabswitcher: Fix cut-off path strings.

I would prefer that the contents of main.cpp goes to tstestapp.cpp, since this would allow to have multiple tests over time.

Mon, Oct 15, 1:22 AM · Kate
gregormi added a reviewer for D16215: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp: Kate.
Mon, Oct 15, 1:22 AM · Kate
gregormi requested review of D16215: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp.
Mon, Oct 15, 1:21 AM · Kate
gregormi committed R40:b9dba2d2c16b: New Tabswitcher: Fix cut-off path strings (authored by gregormi).
New Tabswitcher: Fix cut-off path strings
Mon, Oct 15, 1:09 AM
gregormi closed D16214: New Tabswitcher: Fix cut-off path strings.
Mon, Oct 15, 1:09 AM · Kate
gregormi committed R40:4b33a7e44a27: tabswitchertest: use QFETCH (authored by gregormi).
tabswitchertest: use QFETCH
Mon, Oct 15, 1:07 AM
gregormi closed D16209: tabswitchertest: use QFETCH.
Mon, Oct 15, 1:07 AM · Kate
gregormi added a reviewer for D16214: New Tabswitcher: Fix cut-off path strings: Kate.
Mon, Oct 15, 1:02 AM · Kate
gregormi requested review of D16214: New Tabswitcher: Fix cut-off path strings.
Mon, Oct 15, 12:57 AM · Kate

Sun, Oct 14

gregormi added a comment to D16090: Add benevity and Amazon Smile to "Other ways to Donate".

On both of the Amazon links, I only get Amazon login screens. It is not possible to review this information.

Sun, Oct 14, 10:16 PM
gregormi added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

Yes, please push. In a separate patch, could you possibly look at KateTabSwitcherTest::testLongestCommonPrefix() again? It looks as if you could use QFETCH along eith a function KateTabSwitcherTest::testLongestCommonPrefix_data()? QFETCH is typically used when testing a data set.

Sun, Oct 14, 7:23 PM · Kate
gregormi added a reviewer for D16209: tabswitchertest: use QFETCH: Kate.
Sun, Oct 14, 7:23 PM · Kate
gregormi requested review of D16209: tabswitchertest: use QFETCH.
Sun, Oct 14, 7:22 PM · Kate
gregormi updated the diff for D16204: Quick Open: Remove file:/// prefix.
  • Revert unrelated "tabswitchertest: use QFETCH"
Sun, Oct 14, 7:21 PM · Kate
gregormi updated the diff for D16204: Quick Open: Remove file:/// prefix.
  • tabswitchertest: use QFETCH
Sun, Oct 14, 7:16 PM · Kate
gregormi added a reviewer for D16204: Quick Open: Remove file:/// prefix: Kate.
Sun, Oct 14, 6:05 PM · Kate
gregormi updated the diff for D16204: Quick Open: Remove file:/// prefix.
  • clean
Sun, Oct 14, 6:05 PM · Kate
gregormi updated the summary of D16204: Quick Open: Remove file:/// prefix.
Sun, Oct 14, 6:00 PM · Kate
gregormi updated the summary of D16204: Quick Open: Remove file:/// prefix.
Sun, Oct 14, 5:59 PM · Kate
gregormi requested review of D16204: Quick Open: Remove file:/// prefix.
Sun, Oct 14, 5:58 PM · Kate
gregormi committed R40:47cf54ddf423: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named… (authored by gregormi).
Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named…
Sun, Oct 14, 5:20 PM
gregormi closed D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Sun, Oct 14, 5:20 PM · Kate
gregormi updated the diff for D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
  • revert unrelated change
Sun, Oct 14, 5:16 PM · Kate
gregormi updated the summary of D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Sun, Oct 14, 5:13 PM · Kate
gregormi updated the summary of D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Sun, Oct 14, 5:09 PM · Kate
gregormi updated the diff for D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
  • clean code and add comments
Sun, Oct 14, 5:06 PM · Kate

Sat, Oct 13

gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Sat, Oct 13, 12:17 PM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Sat, Oct 13, 8:49 AM · Gwenview
gregormi updated the diff for D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
  • keep / at the beginning if only this would have been stripped
Sat, Oct 13, 8:41 AM · Kate
gregormi updated the test plan for D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Sat, Oct 13, 8:36 AM · Kate
gregormi added a reviewer for D16172: WIP: Add the transposed aspect ratio of current image to combobox: Gwenview.
Sat, Oct 13, 8:17 AM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Sat, Oct 13, 8:16 AM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Sat, Oct 13, 8:14 AM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Sat, Oct 13, 8:09 AM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Sat, Oct 13, 8:06 AM · Gwenview
gregormi requested review of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Sat, Oct 13, 7:58 AM · Gwenview

Fri, Oct 12

gregormi accepted D16145: Adapt autotest to new menu structure.
Fri, Oct 12, 7:38 AM · Frameworks

Mon, Oct 8

gregormi retitled D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files from POC: Show partial path in Tabswitcher Ctrl+Tab list to better identify files to POC: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Mon, Oct 8, 10:07 PM · Kate
gregormi updated the summary of D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Mon, Oct 8, 10:03 PM · Kate
gregormi updated the test plan for D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Mon, Oct 8, 10:00 PM · Kate
gregormi added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

Hi Nate, you review faster than I can fill out the Reviewer field :-).

Mon, Oct 8, 9:52 PM · Kate
gregormi updated the summary of D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Mon, Oct 8, 9:39 PM · Kate
gregormi requested review of D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.
Mon, Oct 8, 9:32 PM · Kate

Tue, Sep 25

gregormi added a comment to D14830: Add "Configure Displays" context menu entry on the desktop.

I am still waiting for a single justification.

Tue, Sep 25, 7:01 PM · Plasma

Sep 2 2018

gregormi committed R102:c0f28efd280f: Add "Copy Info" button to the About System KCM (authored by gregormi).
Add "Copy Info" button to the About System KCM
Sep 2 2018, 12:34 PM
gregormi closed D7087: Add "Copy Info" button to the About System KCM.
Sep 2 2018, 12:34 PM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Use QVector instead of QList
  • Use the term "Operating System:" instead of "Distro"
Sep 2 2018, 12:31 PM · Plasma

Aug 8 2018

gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.

Rebase on master

Aug 8 2018, 5:51 PM · Plasma

Jul 16 2018

gregormi added a comment to D14145: Show a vertical menu for the panel widget options pop-up.

+1; great to have also text on the Configure button (as a new Plasma user I thought this was just a non-clickable icon)

Jul 16 2018, 9:21 PM · Plasma
gregormi updated the summary of D7087: Add "Copy Info" button to the About System KCM.
Jul 16 2018, 6:41 PM · Plasma
gregormi updated the summary of D7087: Add "Copy Info" button to the About System KCM.
Jul 16 2018, 6:39 PM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

You're welcome. And: thanks for the patience to help improving this patch comes also from my side :).

Jul 16 2018, 6:32 PM · Plasma

Jul 15 2018

gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Module.ui: add horizontal spacers
Jul 15 2018, 8:58 AM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

What do you think about this minor layout change? It is noticeable when the window is resized horizontally. Instead of centering the grid's middle line, it makes the left and right padding space to the window border equal which looks more pleasing at least to my eye.

Jul 15 2018, 8:55 AM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Jul 15 2018, 8:28 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Module.ui: Fix glitch near KernelName
  • Avoid double connection of copyToClipboard
  • Hide dummy label
  • Better naming of loop variable and optimize loop code
Jul 15 2018, 8:27 AM · Plasma
gregormi committed R111:d039c8c74dcb: Add new "Tools" button above System Monitor's process list (authored by gregormi).
Add new "Tools" button above System Monitor's process list
Jul 15 2018, 7:38 AM
gregormi closed D10297: Add new "Tools" button above System Monitor's process list.
Jul 15 2018, 7:38 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Use setShortcuts to simplify code
Jul 15 2018, 7:36 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Use setShortcuts to simplify code
Jul 15 2018, 7:35 AM · Plasma

Jul 14 2018

gregormi added a comment to D14116: Use a better icon for "Remove" on the widget handle.

+1. I have a similar experience with the red X-Button as shown here for the Activity Manager:

Jul 14 2018, 9:00 PM · Plasma

Jul 8 2018

gregormi added a comment to D13970: Handle empty preview lists.

I am rather familiar with KMoreTools but not with the rest of KNewStuff.

Jul 8 2018, 8:27 PM · Frameworks

Jul 7 2018

gregormi committed R417:b6e059b12644: Improve two messages (authored by gregormi).
Improve two messages
Jul 7 2018, 4:55 PM
gregormi closed D12908: Improve two messages.
Jul 7 2018, 4:55 PM

Jul 6 2018

gregormi added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

The spirit goes in the right direction; please proceed :-). Note, that Kate's project plugin also uses KMoreTools.

Jul 6 2018, 2:30 PM · Frameworks
gregormi added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

You are the most awesome person in the world today.

Jul 6 2018, 12:04 AM · Frameworks

Jun 29 2018

gregormi added a reviewer for D12908: Improve two messages: aacid.

@aacid I used your suggestion to fix the message. It sounds more natural and fluent. From my side this is now ready to land.

Jun 29 2018, 9:50 PM
gregormi updated the diff for D12908: Improve two messages.
  • rebase on master
  • improve "enable all messages" message
  • improve "difficulty warning" message
Jun 29 2018, 9:45 PM
gregormi abandoned D13802: fix author.

wrong arc usage

Jun 29 2018, 9:32 PM
gregormi requested review of D13802: fix author.
Jun 29 2018, 9:31 PM
gregormi committed R417:dd1039909761: Improve Hint and Solve action visibility and enabled state (authored by gregormi).
Improve Hint and Solve action visibility and enabled state
Jun 29 2018, 8:40 PM
gregormi closed D12912: Improve Hint and Solve action visibility and enabled state.
Jun 29 2018, 8:40 PM
gregormi updated the diff for D12912: Improve Hint and Solve action visibility and enabled state.
  • Fix spacing: use tabs instead of spaces
  • Make method const
Jun 29 2018, 8:38 PM
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.
Jun 29 2018, 4:46 PM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • info comment
  • Remove the now useless "not set" string
  • Set shortcut text with Qt methods and omit the translation context string and \t
Jun 29 2018, 4:46 PM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Jun 29 2018, 3:57 PM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Rework the Module.ui layout to fix the spacing
  • Add dummy label to remove special case for "Distro"
  • Use C++11 for loop and add qAsConst
  • Make RTL aware by not removing the colon
  • Improve translation context message
Jun 29 2018, 3:53 PM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

I added some qDebug code in Module::copyToClipboard() and noticed that the method is always called twice when the Copy to clipboard button is clicked.

Jun 29 2018, 3:11 PM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

Thanks Henrik for the review. I fixed the layout and it looks now like this in Qt Designer:

Jun 29 2018, 2:31 PM · Plasma

Jun 25 2018

gregormi added a comment to D13706: [KMoreTools] Enable installing tools via appstream url.

I'd like to see the missing AppStream URLs filled in for all the software in this list. There are currently some claring omissions, especially for KDE software (e.g. ksysguard) for which there is definitely an appstream ID available). For any software that doesn't have any AppStream information (and is therefore not visible or installable via Discover), I would actually advocate removing it from the list, and making the presence of AppStream data a pre-condition of inclusion--the reason being that otherwise an Install button can't be presented to the user. Entries without an Install button are just frustrating, tantamount to taunting them ("here's some cool software you could use; oh, sorry, can't actually install it lol")

Jun 25 2018, 6:03 PM · Frameworks

Jun 24 2018

gregormi accepted D13706: [KMoreTools] Enable installing tools via appstream url.

Ok from my side. Please let also Dominik give his approval.

Jun 24 2018, 10:08 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Jun 24 2018, 9:48 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Jun 24 2018, 9:24 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Jun 24 2018, 9:06 PM · Frameworks
gregormi added a comment to D13706: [KMoreTools] Enable installing tools via appstream url.

First of all, thanks for adding this feature. This was missing a long time :-). I will do some comments in the code.

Jun 24 2018, 8:49 PM · Frameworks

May 30 2018

gregormi added a comment to D12908: Improve two messages.

To summarize the current reviewers responses,

May 30 2018, 9:32 AM
gregormi updated the summary of D12908: Improve two messages.
May 30 2018, 9:27 AM
gregormi added a comment to D12912: Improve Hint and Solve action visibility and enabled state.

I agree with the general UI best practice. But this change is different. As far as I understood the program, there are two modes: "Enter/edit a game" and "Play the game". The "Check" action is currently always grayed out during "Play the game" because it makes no sense there. And the "Hint" action only makes sense when playing the game not when creating one. In either mode, the user gets more confused because a deactivated button indicates that it might come available which is not true (as far as I can see it).

May 30 2018, 9:19 AM
gregormi committed R417:1dd6e4bd2e5e: Implement wish 319522: Option to restart current game (authored by gregormi).
Implement wish 319522: Option to restart current game
May 30 2018, 9:10 AM