gregormi (gregormi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2015, 8:50 PM (150 w, 1 d)
Availability
Available

Recent Activity

Fri, Apr 6

gregormi added a comment to T8447: Indexing encrypted mails.

@gregormi This is only partially related. We already have an option how to automatically decrypt all incoming emails in KMail, although it's not very intuitive to set up. You can create a local filter (Settings -> Configure filters) for all incoming emails and choose the "Decrypt" action. The reason it's not done by default is due to privacy concerns. For example you may want to keep your personal emails always encrypted on your employer's computer so they can't read your private emails.

Fri, Apr 6, 9:26 AM · KDE PIM, Goal settings 2017
gregormi added a comment to T8447: Indexing encrypted mails.

I have a question to that because I encountered this issue years ago when used Thunderbird with Enigmail. I assume the indexing we are talking about here takes place in the local mail client, not in a web client, right? I wonder why incoming encrypted mails are also stored encrypted? Why not always decrypt those mails permanently? This would prevent losing old mail because of lost private key and there would be no problem with indexing. In this Enigmail bug report (https://sourceforge.net/p/enigmail/bugs/1/) from 2003 this request was made. The main reason for not implementing it is a technical one ("this feature is blocked by necessary Thunderbird changes") not fundamental ones. I thought the goal of end-to-end encryption is protect the data when it is underway and not also on the end-points themselves. Are there any reasons why KDE PIM does not decrypt incoming encrypted mail permanently? (or is there already and option to do that? Then sorry for the fuzz)

Fri, Apr 6, 8:09 AM · KDE PIM, Goal settings 2017

Fri, Mar 30

gregormi added a comment to D11733: Allow opening items from the open/save dialogs.

and the bug reporter's use case of selecting a file in a web browser for upload essentially wants the existing F11 preview feature and perhaps a better preview feature in the web application itself.

The inline preview only gives thumbnails which are not usable when one wants to read text on the image (zoom to 100%). For me, the preview should take place before it is uploaded to the web application because I want to make sure the right thing is uploaded.

Fri, Mar 30, 11:41 AM · Frameworks

Mar 13 2018

gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.
In D10297#224935, @apol wrote:

Here's some thoughts:

  • Why is there only one with the keyboard shortcut? many of these have (e.g. run a command)
Mar 13 2018, 7:11 PM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Any more thoughts on this patch before it is ready to land?

Mar 13 2018, 5:58 PM · Plasma

Mar 7 2018

gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Some people from Plasma reviewed the original review request on reviewboard. Should we add some more reviewers before it can go in?

Only looked at it briefly, but I did not spot something about KSysGuard (the multi-page app), it was all about "System Monitor" (the single page dialog) so far. Anyway, I'm not the maintainer, I only added a comment about something I noticed.

Mar 7 2018, 11:45 AM · Plasma
gregormi added reviewers for D10297: Add new "Tools" button above System Monitor's process list: colomar, kossebau.
Mar 7 2018, 11:29 AM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.
In D7087#207306, @rkflx wrote:

In fact, I wonder whether there already is a script or similar helper tools that give you this kind of system information. I currently do not remember, though... Anyone else?

Do you mean inxi -Fxxxz? Surely that's material for a different patch, but might be a nice idea to integrate. It's more hardware related, though, less about software versions.

I guess for a useful https://bugs.kde.org report the only thing missing is the KDE Applications version and some info about the graphics card + driver.

Mar 7 2018, 11:21 AM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Just tried the patch. I think for System Activity / Ctrl+ the button is fine (annoyingly with a slightly larger height than the combobox, but that's life…). For KSysGuard itself it looks a bit odd, why would it appear exactly on this tab page? I could imagine the menubar would be a better place.

(Sorry this comes so late, I only reviewed in more detail because nobody from Plasma bothered so far. Ignore my comment if you want.)

Mar 7 2018, 10:42 AM · Plasma
gregormi added a comment to D10542: Add docbook content which was lost during a merge and more cleanup.

@gregormi Sorry to bother again. If you are busy currently, just tell me and I'll take over.

Mar 7 2018, 10:32 AM

Feb 24 2018

gregormi added a comment to D10542: Add docbook content which was lost during a merge and more cleanup.

@gregormi Ping.

Take your time with the spaces/tabs fix in D10529, but this Diff is a fix for a merge which did go wrong, so it should be landed sooner rather than later.

Feb 24 2018, 7:02 PM

Feb 15 2018

gregormi added a comment to D10561: Reorganize tools button menu for best user experience.

Screenshot looks great.

Feb 15 2018, 10:02 PM
gregormi updated the summary of D7087: Add "Copy Info" button to the About System KCM.
Feb 15 2018, 3:19 PM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

Fine from my side. We still need to figure out the translation issue--either work to make it translatable, or accept that this output will be English-only. I'll let the other reviewers have their say on that matter.

Feb 15 2018, 3:17 PM · Plasma
gregormi added a comment to D10542: Add docbook content which was lost during a merge and more cleanup.

Thanks for the fix.

Seems like you based this on D10529 instead of master, but let's not change tabs in this patch.

Feb 15 2018, 2:26 PM
gregormi retitled D10542: Add docbook content which was lost during a merge and more cleanup from Summary:Add docbook content which was lost during merge to Add docbook content which was lost during a merge.
Feb 15 2018, 1:59 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

I identified some of the lost changes in index.docbook and added a new patch: https://phabricator.kde.org/D10542

Feb 15 2018, 1:58 PM
gregormi retitled D10542: Add docbook content which was lost during a merge and more cleanup from Summary: Add docbook content which was lost during merge to Summary:Add docbook content which was lost during merge.
Feb 15 2018, 1:58 PM
gregormi requested review of D10542: Add docbook content which was lost during a merge and more cleanup.
Feb 15 2018, 1:57 PM
gregormi added a comment to D10528: reset and remove non-relevant changes.

Tried to use another branch to update an existing revision. Failed.

You can check with arc which what Arcanist will do before peforming the actual upload with arc diff.

Also, grep arc help diff for --update revision_id, which should've helped in your case.

Feb 15 2018, 12:46 PM
gregormi committed R111:50229e7ec3c2: Fix whitespace (authored by gregormi).
Fix whitespace
Feb 15 2018, 12:34 PM
gregormi closed D10535: Fix whitespace.
Feb 15 2018, 12:34 PM · Plasma
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

@gregormi D10301 just landed, you might want to watch out for docbook merge conflicts.

Mhm, seems like we lost a bunch of changes. Not sure what's gone wrong, either bad editing of merge conflict or rebase on stale master instead of fresh origin/master?

Feb 15 2018, 12:32 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

[... ] As KNewStuff has its own project on Phab, just use the one over there: https://phabricator.kde.org/project/view/127/.

Thanks ;)

Feb 15 2018, 11:19 AM
gregormi updated the task description for T7971: Ideas for KMoreTools.
Feb 15 2018, 11:18 AM · KNewStuff
gregormi updated the task description for T7971: Ideas for KMoreTools.
Feb 15 2018, 11:17 AM · KNewStuff
gregormi triaged T7971: Ideas for KMoreTools as Low priority.
Feb 15 2018, 11:12 AM · KNewStuff
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Unrelated whitespace changes here: https://phabricator.kde.org/D10535

Feb 15 2018, 11:03 AM · Plasma
gregormi retitled D10535: Fix whitespace from Fix whitespace; this patch was extracted from here https://phabricator.kde.org/D10297 to Fix whitespace.
Feb 15 2018, 11:03 AM · Plasma
gregormi requested review of D10535: Fix whitespace.
Feb 15 2018, 11:02 AM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Ready from my side.

Feb 15 2018, 10:55 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • remove unrelated changes
Feb 15 2018, 10:55 AM · Plasma
gregormi abandoned D10534: remove unrelated changes.
Feb 15 2018, 10:51 AM · Plasma
gregormi updated the diff for D10534: remove unrelated changes.

...

Feb 15 2018, 10:50 AM · Plasma
gregormi abandoned D10534: remove unrelated changes.

Tried to remove unrelated changes which results in a separate Phabricator Differential

Feb 15 2018, 10:46 AM · Plasma
gregormi requested review of D10534: remove unrelated changes.
Feb 15 2018, 10:42 AM · Plasma
gregormi updated the summary of D10297: Add new "Tools" button above System Monitor's process list.
Feb 15 2018, 10:28 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • add missing include
Feb 15 2018, 10:27 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Merge remote-tracking branch 'origin/master'
Feb 15 2018, 10:17 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • fix mem leak
  • Set application-menu icon for Tools button
Feb 15 2018, 10:15 AM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

Is there anything else I can do for this patch?

Feb 15 2018, 9:57 AM · Plasma
gregormi added a comment to T7116: Streamlined onboarding of new contributors.

Recently, I tried to find out KDE best practices to work with Docbook.

Feb 15 2018, 9:38 AM · Goal settings 2017
gregormi retitled D10529: Convert tabs to spaces in docbook from convert tabs to spaces to docbook file: convert tabs to spaces.
Feb 15 2018, 9:13 AM
gregormi added a reviewer for D10529: Convert tabs to spaces in docbook: Spectacle.
Feb 15 2018, 9:13 AM
gregormi updated the diff for D10529: Convert tabs to spaces in docbook.
  • remove odd spaces
Feb 15 2018, 9:13 AM
gregormi requested review of D10529: Convert tabs to spaces in docbook.
Feb 15 2018, 9:11 AM
gregormi committed R166:45c37a64e1cc: Add new button "Record screen" that allows to select a Screen Recording tool (authored by gregormi).
Add new button "Record screen" that allows to select a Screen Recording tool
Feb 15 2018, 9:09 AM
gregormi closed D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
Feb 15 2018, 9:09 AM
gregormi added inline comments to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
Feb 15 2018, 9:05 AM
gregormi updated the diff for D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
  • docbook: make first letters upper case; fix indentation
Feb 15 2018, 9:04 AM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

@rkflx: May I ask what is your toolchain when dealing with docbook? I found out this:

Feb 15 2018, 8:59 AM
gregormi updated the diff for D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

rebase

Feb 15 2018, 8:52 AM
gregormi abandoned D10528: reset and remove non-relevant changes.

Tried to use another branch to update an existing revision. Failed.

Feb 15 2018, 8:42 AM
gregormi requested review of D10528: reset and remove non-relevant changes.
Feb 15 2018, 8:41 AM

Feb 11 2018

gregormi updated the diff for D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
  • Add documentation in index.docbook and minor improvements in the same section
  • fix code according to suggestions
  • Revert "Use AddSection and rework Tools menu to remove nesting": now the menu is nested again
Feb 11 2018, 5:22 PM

Feb 8 2018

gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

I just did a quick search for "menu" in the icon name:

Feb 8 2018, 6:40 PM · Plasma
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

So back to nesting?

I guess so. At least we tried, and identified what needs to be improved.

@gregormi It's fine if you are short on time to work on this, but it would be a shame if the ideas got lost in a random Phabricator comment. Could you open tasks on some Phab workboard to at least track this?

Feb 8 2018, 6:33 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

So back to nesting?

Feb 8 2018, 6:12 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

Yes, I agree that we need to optimize for this case. Does KNS open Discover with the app in question if you opt to install it?

For me it will open the browser, see D10295#203095. Do you see any appstream URL in D10390?

Feb 8 2018, 6:06 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

Yes, I agree that we need to optimize for this case. Does KNS open Discover with the app in question if you opt to install it?

For me it will open the browser, see D10295#203095. Do you see any appstream URL in D10390?

That's pretty useless then; Linux users don't install apps from random websites! We need to fix this in KNewStuff!

Feb 8 2018, 6:03 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

Let's step back a bit: What's the common case? None of the apps is installed, I guess (correct me if I'm wrong).

Yes, I agree that we need to optimize for this case. Does KNS open Discover with the app in question if you opt to install it?

Feb 8 2018, 6:02 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

The centered "Record Screen" title in the menu is somehow bothering me. Doesn't feel quite right. Might be nicer if it were left-aligned, had a colon on the end of it, and it was grayed out. That way it would look more like a header introducing a section and less like a weird menu item.

Feb 8 2018, 5:56 PM
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

One more thought. For for consistency, maybe the tools menu should have a horrible hamburger menu icon like the otherwise identiacal one we added to Spectacle recently?

Feb 8 2018, 5:50 PM · Plasma
gregormi updated the summary of D10297: Add new "Tools" button above System Monitor's process list.
Feb 8 2018, 5:39 PM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Do not show KSysGuard item if we are within KSysGuard
Feb 8 2018, 5:39 PM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Feature-wise, I love it. My only objection is that I'd really like to somehow remove the redundant KSysGuard entry from the menu if it was opened as a standalone app, not via the alt+ shortcut.

Feb 8 2018, 5:38 PM · Plasma
gregormi updated the summary of D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
Feb 8 2018, 5:09 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

I underestimated the current API :). Now it looks not really perfect but much better:

Feb 8 2018, 5:09 PM
gregormi updated the diff for D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
  • Use AddSection and rework Tools menu to remove nesting
Feb 8 2018, 5:06 PM
gregormi updated the summary of D10297: Add new "Tools" button above System Monitor's process list.
Feb 8 2018, 4:58 PM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

How about a new screenshot in the Summary section? ;)

Feb 8 2018, 4:56 PM · Plasma
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

Here's how it looks for me:

I'd really love to omit one level of extra nesting.

Feb 8 2018, 4:55 PM
gregormi committed R304:bf82fe7c222f: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping (authored by gregormi).
Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping
Feb 8 2018, 4:36 PM
gregormi closed D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping.
Feb 8 2018, 4:36 PM · Frameworks
gregormi added a reviewer for D10297: Add new "Tools" button above System Monitor's process list: Plasma.
Feb 8 2018, 4:33 PM · Plasma
gregormi updated the diff for D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
  • Menu title is now "Record Screen" again.
Feb 8 2018, 4:30 PM
gregormi updated the summary of D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
Feb 8 2018, 4:29 PM
gregormi added a comment to D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping.

Screenshot of test program:

. One can see the new item.

Feb 8 2018, 4:27 PM · Frameworks
gregormi retitled D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping from Minor fix: rename info file to _README.md to Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping.
Feb 8 2018, 4:25 PM · Frameworks
gregormi requested review of D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping.
Feb 8 2018, 4:24 PM · Frameworks
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

Instead of "Record Screen Video", how about "Make Screen Recording" or just "Record screen"?

Feb 8 2018, 4:20 PM
gregormi updated the diff for D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
  • Move "Record Screen Video" to Tools menu (see screenshot)
Feb 8 2018, 4:07 PM
gregormi updated the summary of D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
Feb 8 2018, 4:03 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

Feb 8 2018, 4:02 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.
Feb 8 2018, 3:26 PM
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Maybe make it a PushButton instead of a ToolButton, and it will magically work? Here's how @rkflx implemented an appropriate Tools menu in Spectacle recently: D10371: Move printing to a new tools button

Feb 8 2018, 3:12 PM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Use to PushButton instead of QToolButton to put the down arrow to right side. Still no manual setting of the icon needed.
Feb 8 2018, 3:10 PM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.

Rebase to master. Tested again successfully. Ready from my side.

Feb 8 2018, 2:44 PM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Feb 8 2018, 2:30 PM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • remove unrelated change
Feb 8 2018, 2:26 PM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.
  • Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not work (I will remove it if that's not easily fixable)

@dhaumann: any idea why the shortcut does not work here? Maybe a general thing how Plasma handles keyboard shortcuts?

Feb 8 2018, 2:19 PM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

The "All processes" button is a QCombobox. It feels like a dirty hack to turn QCombobox into a drop down menu just to get the arrow at the correct position. @ngraham: Just to be sure, do you think this is the way to go?

Feb 8 2018, 2:08 PM · Plasma

Feb 6 2018

gregormi added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@dporobic I'm not a KDE programmer (yet!) but I have in my mind something like KTextEditor for text editing (KImageEditor?).

Feb 6 2018, 10:40 PM · Spectacle

Feb 4 2018

gregormi added a comment to T7841: Revamp buttons on the bottom to solve various usability issues.
In T7841#126510, @rkflx wrote:

Another (rather controversial) idea: Move Copy To Clipboard also to the tools menu. At the same time, provide overlay (on mouse-over) buttons on the thumbnail for Copy To Clipboard and Annotate.

Feb 4 2018, 11:22 PM · Spectacle
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.
  • Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not work (I will remove it if that's not easily fixable)
Feb 4 2018, 11:13 PM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Feb 4 2018, 11:11 PM · Plasma
gregormi added a comment to T7841: Revamp buttons on the bottom to solve various usability issues.
In T7841#126507, @rkflx wrote:
Feb 4 2018, 11:09 PM · Spectacle
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

Translation is not yet working correctly, see above comment.

Feb 4 2018, 11:05 PM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

You can't just add the appropriate arrow icon to a regular button; you have to actually use the correct type of button from the start, and then it gets the icon in the right place automatically. Check out how the "All Processes" button is constructed, and you can copy the same approach.

Feb 4 2018, 3:34 PM · Plasma
gregormi added a reviewer for D10297: Add new "Tools" button above System Monitor's process list: floeser.

Seems useful! Couple of nitpicks:

  • KsysGuard itself appears in the menu :)

Yes, I know :-(. When someone presses Ctrl+Esc then the System Monitor opens which has less features than KSysGuard. I thought it would be good to find KSysGuard from there. I didn't come up with an idea of how to remove the item when the Tools menu is actually opened from KSysGuard.

Feb 4 2018, 3:24 PM · Plasma