gregormi (gregormi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2015, 8:50 PM (159 w, 2 d)
Availability
Available

Recent Activity

Yesterday

gregormi accepted D13706: [KMoreTools] Enable installing tools via appstream url.

Ok from my side. Probably Dominik also wants to approve.

Sun, Jun 24, 10:08 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Sun, Jun 24, 9:48 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Sun, Jun 24, 9:24 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Sun, Jun 24, 9:06 PM · Frameworks
gregormi added a comment to D13706: [KMoreTools] Enable installing tools via appstream url.

First of all, thanks for adding this feature. This was missing a long time :-). I will do some comments in the code.

Sun, Jun 24, 8:49 PM · Frameworks

Wed, May 30

gregormi added a comment to D12908: Improve two messages.

To summarize the current reviewers responses,

Wed, May 30, 9:32 AM
gregormi updated the summary of D12908: Improve two messages.
Wed, May 30, 9:27 AM
gregormi added a comment to D12912: Improve Hint and Solve action visibility and enabled state.

I agree with the general UI best practice. But this change is different. As far as I understood the program, there are two modes: "Enter/edit a game" and "Play the game". The "Check" action is currently always grayed out during "Play the game" because it makes no sense there. And the "Hint" action only makes sense when playing the game not when creating one. In either mode, the user gets more confused because a deactivated button indicates that it might come available which is not true (as far as I can see it).

Wed, May 30, 9:19 AM
gregormi committed R417:1dd6e4bd2e5e: Implement wish 319522: Option to restart current game (authored by gregormi).
Implement wish 319522: Option to restart current game
Wed, May 30, 9:10 AM
gregormi closed D12907: Implement wish 319522: Option to restart current game.
Wed, May 30, 9:10 AM
gregormi updated the summary of D12907: Implement wish 319522: Option to restart current game.
Wed, May 30, 9:00 AM
gregormi updated the summary of D12907: Implement wish 319522: Option to restart current game.
Wed, May 30, 8:59 AM
gregormi added a reviewer for D10297: Add new "Tools" button above System Monitor's process list: rkflx.
Wed, May 30, 8:50 AM · Plasma
gregormi updated the summary of D10297: Add new "Tools" button above System Monitor's process list.
Wed, May 30, 8:42 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.

The text should use title case: "Kill a Window"

DONE

Wed, May 30, 8:37 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • use auto, add comment
Wed, May 30, 8:05 AM · Plasma
gregormi added a reviewer for D7087: Add "Copy Info" button to the About System KCM: rkflx.
Wed, May 30, 7:31 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Handle colon (:) problem for translating and fix one label bug
Wed, May 30, 7:28 AM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Wed, May 30, 7:12 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Fix comment
  • Clean ui file
  • Shortcut handling
Wed, May 30, 7:11 AM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Wed, May 30, 6:40 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Translate the Distro string
  • Rename button to 'Copy to Clipboard' for more clarity; and consistency with other applications
  • Use a QList of QPairs to collect labels and then use a loop
Wed, May 30, 6:39 AM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Wed, May 30, 6:00 AM · Plasma

May 23 2018

gregormi updated the summary of D12912: Improve Hint and Solve action visibility and enabled state.
May 23 2018, 8:29 AM
gregormi updated the summary of D12912: Improve Hint and Solve action visibility and enabled state.
May 23 2018, 8:29 AM
gregormi updated the diff for D12912: Improve Hint and Solve action visibility and enabled state.
  • Enable Hint button again when after solved puzzle Undo was used
May 23 2018, 8:28 AM
gregormi committed R417:dc8be89137cf: Remove TODO file (authored by gregormi).
Remove TODO file
May 23 2018, 7:38 AM
gregormi closed D12922: Remove TODO file.
May 23 2018, 7:38 AM
gregormi updated the summary of D12922: Remove TODO file.
May 23 2018, 7:36 AM
gregormi committed R417:d79e2ff3e842: Remove AUTHORS file (authored by gregormi).
Remove AUTHORS file
May 23 2018, 7:27 AM
gregormi closed D12920: Remove AUTHORS file.
May 23 2018, 7:27 AM
gregormi updated the summary of D12920: Remove AUTHORS file.
May 23 2018, 7:24 AM
gregormi committed R417:3c848ecee3ff: Remove obsolete INSTALL and VERSION files (authored by gregormi).
Remove obsolete INSTALL and VERSION files
May 23 2018, 7:21 AM
gregormi closed D12921: Remove obsolete INSTALL and VERSION files.
May 23 2018, 7:20 AM
gregormi committed R417:6ba2528a64c3: Remove file TODOPORT (authored by gregormi).
Remove file TODOPORT
May 23 2018, 7:15 AM
gregormi closed D12900: Remove file TODOPORT.
May 23 2018, 7:15 AM
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

@rkflx: Hi Henrik, I resolved all your code remarks. Could you look it over and give a go to have this landed.

May 23 2018, 7:07 AM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

@ngraham , @rkflx, @dhaumann: Do you have any more suggestions to this? I think it is now ready to land.

May 23 2018, 7:05 AM · Plasma
gregormi added a comment to D12907: Implement wish 319522: Option to restart current game.

Do you think it's a good idea that the undo stack is not wiped when doing restart?

I.e. you can do restart and then you can do redo.

I don't have an opinion, just want to know if it's on purpose or a side effect of the implementation of ::restart

May 23 2018, 7:00 AM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • clear history on restart
May 23 2018, 6:58 AM

May 16 2018

gregormi updated the summary of D12922: Remove TODO file.
May 16 2018, 9:18 AM
gregormi updated the summary of D12922: Remove TODO file.
May 16 2018, 9:15 AM
gregormi updated the summary of D12922: Remove TODO file.
May 16 2018, 8:44 AM
gregormi requested review of D12922: Remove TODO file.
May 16 2018, 8:41 AM
gregormi retitled D12921: Remove obsolete INSTALL and VERSION files from Remove obsolete INSTALL file to Remove obsolete INSTALL and VERSION files.
May 16 2018, 8:35 AM
gregormi updated the diff for D12921: Remove obsolete INSTALL and VERSION files.
  • Also remove outdated VERSION file
May 16 2018, 8:35 AM
gregormi requested review of D12921: Remove obsolete INSTALL and VERSION files.
May 16 2018, 8:34 AM
gregormi updated the summary of D12920: Remove AUTHORS file.
May 16 2018, 8:32 AM
gregormi requested review of D12920: Remove AUTHORS file.
May 16 2018, 8:31 AM
gregormi updated the summary of D12908: Improve two messages.
May 16 2018, 12:44 AM
gregormi updated the diff for D12908: Improve two messages.
  • Bug 357999: improve "Low Difficulty" warning
May 16 2018, 12:43 AM
gregormi requested review of D12912: Improve Hint and Solve action visibility and enabled state.
May 16 2018, 12:04 AM

May 15 2018

gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 10:51 PM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • use tabs in files where mostly tabs instead of spaces are used
May 15 2018, 10:49 PM
gregormi updated the diff for D12908: Improve two messages.
  • change spaces back to tabs
May 15 2018, 10:39 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 10:38 PM
gregormi requested review of D12908: Improve two messages.
May 15 2018, 10:27 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 10:11 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 10:02 PM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • ksudokuui.rc: increase version
May 15 2018, 10:01 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 9:59 PM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • use tabs instead of spaces
May 15 2018, 9:58 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 9:55 PM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • fix whitespace and improve if statement
May 15 2018, 9:45 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 9:40 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 9:35 PM
gregormi retitled D12907: Implement wish 319522: Option to restart current game from Fix Bug 319522: Option to restart current game to Implement wish 319522: Option to restart current game.
May 15 2018, 8:42 PM
gregormi retitled D12900: Remove file TODOPORT from Remove TODOPORT to Remove file TODOPORT.
May 15 2018, 8:41 PM
gregormi updated the summary of D12900: Remove file TODOPORT.
May 15 2018, 8:41 PM
gregormi updated the diff for D12900: Remove file TODOPORT.
  • Remove TODOPORT
May 15 2018, 8:39 PM
gregormi requested review of D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 8:33 PM
gregormi requested review of D12900: Remove file TODOPORT.
May 15 2018, 5:12 PM
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

This now ready from my side.

May 15 2018, 3:27 PM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Use qApp->desktopFileName()
May 15 2018, 3:24 PM · Plasma
gregormi added inline comments to D10297: Add new "Tools" button above System Monitor's process list.
May 15 2018, 3:16 PM · Plasma
gregormi added inline comments to D10297: Add new "Tools" button above System Monitor's process list.
May 15 2018, 2:29 PM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Revert unrelated changes
  • Remove not needed Plasma dependency
  • Undo unrelated whitespace change
  • Clean code
  • Use blank lines instead of blocks
May 15 2018, 2:28 PM · Plasma

May 14 2018

gregormi updated the summary of D7087: Add "Copy Info" button to the About System KCM.
May 14 2018, 8:35 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Apply comments by reviewers:
    • move declaration near to usage
    • Reuse label texts
May 14 2018, 8:31 AM · Plasma

Apr 6 2018

gregormi added a comment to T8447: Indexing encrypted mails.

@gregormi This is only partially related. We already have an option how to automatically decrypt all incoming emails in KMail, although it's not very intuitive to set up. You can create a local filter (Settings -> Configure filters) for all incoming emails and choose the "Decrypt" action. The reason it's not done by default is due to privacy concerns. For example you may want to keep your personal emails always encrypted on your employer's computer so they can't read your private emails.

Apr 6 2018, 9:26 AM · KDE PIM, Goal settings 2017
gregormi added a comment to T8447: Indexing encrypted mails.

I have a question to that because I encountered this issue years ago when I used Thunderbird with Enigmail. I assume the indexing we are talking about here takes place in the local mail client, not in a web client, right? I wonder why incoming encrypted mails are also stored encrypted? Why not always decrypt those mails permanently? This would prevent losing old mail because of lost private key and there would be no problem with indexing. In this Enigmail bug report (https://sourceforge.net/p/enigmail/bugs/1/) from 2003 this request was made. The main reason for not implementing it is a technical one ("this feature is blocked by necessary Thunderbird changes") not fundamental ones. I thought the goal of end-to-end encryption is protect the data when it is underway and not also on the end-points themselves. Are there any reasons why KDE PIM does not decrypt incoming encrypted mail permanently? (or is there already and option to do that? Then sorry for the fuzz)

Apr 6 2018, 8:09 AM · KDE PIM, Goal settings 2017

Mar 30 2018

gregormi added a comment to D11733: Allow opening items from the open/save dialogs.

and the bug reporter's use case of selecting a file in a web browser for upload essentially wants the existing F11 preview feature and perhaps a better preview feature in the web application itself.

The inline preview only gives thumbnails which are not usable when one wants to read text on the image (zoom to 100%). For me, the preview should take place before it is uploaded to the web application because I want to make sure the right thing is uploaded.

Mar 30 2018, 11:41 AM · Frameworks

Mar 13 2018

gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.
In D10297#224935, @apol wrote:

Here's some thoughts:

  • Why is there only one with the keyboard shortcut? many of these have (e.g. run a command)
Mar 13 2018, 7:11 PM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Any more thoughts on this patch before it is ready to land?

Mar 13 2018, 5:58 PM · Plasma

Mar 7 2018

gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Some people from Plasma reviewed the original review request on reviewboard. Should we add some more reviewers before it can go in?

Only looked at it briefly, but I did not spot something about KSysGuard (the multi-page app), it was all about "System Monitor" (the single page dialog) so far. Anyway, I'm not the maintainer, I only added a comment about something I noticed.

Mar 7 2018, 11:45 AM · Plasma
gregormi added reviewers for D10297: Add new "Tools" button above System Monitor's process list: colomar, kossebau.
Mar 7 2018, 11:29 AM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.
In D7087#207306, @rkflx wrote:

In fact, I wonder whether there already is a script or similar helper tools that give you this kind of system information. I currently do not remember, though... Anyone else?

Do you mean inxi -Fxxxz? Surely that's material for a different patch, but might be a nice idea to integrate. It's more hardware related, though, less about software versions.

I guess for a useful https://bugs.kde.org report the only thing missing is the KDE Applications version and some info about the graphics card + driver.

Mar 7 2018, 11:21 AM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Just tried the patch. I think for System Activity / Ctrl+ the button is fine (annoyingly with a slightly larger height than the combobox, but that's life…). For KSysGuard itself it looks a bit odd, why would it appear exactly on this tab page? I could imagine the menubar would be a better place.

(Sorry this comes so late, I only reviewed in more detail because nobody from Plasma bothered so far. Ignore my comment if you want.)

Mar 7 2018, 10:42 AM · Plasma
gregormi added a comment to D10542: Add docbook content which was lost during a merge and more cleanup.

@gregormi Sorry to bother again. If you are busy currently, just tell me and I'll take over.

Mar 7 2018, 10:32 AM

Feb 24 2018

gregormi added a comment to D10542: Add docbook content which was lost during a merge and more cleanup.

@gregormi Ping.

Take your time with the spaces/tabs fix in D10529, but this Diff is a fix for a merge which did go wrong, so it should be landed sooner rather than later.

Feb 24 2018, 7:02 PM

Feb 15 2018

gregormi added a comment to D10561: Reorganize tools button menu for best user experience.

Screenshot looks great.

Feb 15 2018, 10:02 PM
gregormi updated the summary of D7087: Add "Copy Info" button to the About System KCM.
Feb 15 2018, 3:19 PM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

Fine from my side. We still need to figure out the translation issue--either work to make it translatable, or accept that this output will be English-only. I'll let the other reviewers have their say on that matter.

Feb 15 2018, 3:17 PM · Plasma
gregormi added a comment to D10542: Add docbook content which was lost during a merge and more cleanup.

Thanks for the fix.

Seems like you based this on D10529 instead of master, but let's not change tabs in this patch.

Feb 15 2018, 2:26 PM
gregormi retitled D10542: Add docbook content which was lost during a merge and more cleanup from Summary:Add docbook content which was lost during merge to Add docbook content which was lost during a merge.
Feb 15 2018, 1:59 PM
gregormi added a comment to D10295: Add new button "Record screen" that allows to select a Screen Recording tool.

I identified some of the lost changes in index.docbook and added a new patch: https://phabricator.kde.org/D10542

Feb 15 2018, 1:58 PM
gregormi retitled D10542: Add docbook content which was lost during a merge and more cleanup from Summary: Add docbook content which was lost during merge to Summary:Add docbook content which was lost during merge.
Feb 15 2018, 1:58 PM
gregormi requested review of D10542: Add docbook content which was lost during a merge and more cleanup.
Feb 15 2018, 1:57 PM
gregormi added a comment to D10528: reset and remove non-relevant changes.

Tried to use another branch to update an existing revision. Failed.

You can check with arc which what Arcanist will do before peforming the actual upload with arc diff.

Also, grep arc help diff for --update revision_id, which should've helped in your case.

Feb 15 2018, 12:46 PM
gregormi committed R111:50229e7ec3c2: Fix whitespace (authored by gregormi).
Fix whitespace
Feb 15 2018, 12:34 PM