gregormi (gregormi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2015, 8:50 PM (167 w, 2 h)
Availability
Available

Recent Activity

Wed, Aug 8

gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.

Rebase on master

Wed, Aug 8, 5:51 PM · Plasma

Jul 16 2018

gregormi added a comment to D14145: Show a vertical menu for the panel widget options pop-up.

+1; great to have also text on the Configure button (as a new Plasma user I thought this was just a non-clickable icon)

Jul 16 2018, 9:21 PM · Plasma
gregormi updated the summary of D7087: Add "Copy Info" button to the About System KCM.
Jul 16 2018, 6:41 PM · Plasma
gregormi updated the summary of D7087: Add "Copy Info" button to the About System KCM.
Jul 16 2018, 6:39 PM · Plasma
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

You're welcome. And: thanks for the patience to help improving this patch comes also from my side :).

Jul 16 2018, 6:32 PM · Plasma

Jul 15 2018

gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Module.ui: add horizontal spacers
Jul 15 2018, 8:58 AM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

What do you think about this minor layout change? It is noticeable when the window is resized horizontally. Instead of centering the grid's middle line, it makes the left and right padding space to the window border equal which looks more pleasing at least to my eye.

Jul 15 2018, 8:55 AM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Jul 15 2018, 8:28 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Module.ui: Fix glitch near KernelName
  • Avoid double connection of copyToClipboard
  • Hide dummy label
  • Better naming of loop variable and optimize loop code
Jul 15 2018, 8:27 AM · Plasma
gregormi committed R111:d039c8c74dcb: Add new "Tools" button above System Monitor's process list (authored by gregormi).
Add new "Tools" button above System Monitor's process list
Jul 15 2018, 7:38 AM
gregormi closed D10297: Add new "Tools" button above System Monitor's process list.
Jul 15 2018, 7:38 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Use setShortcuts to simplify code
Jul 15 2018, 7:36 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • Use setShortcuts to simplify code
Jul 15 2018, 7:35 AM · Plasma

Jul 14 2018

gregormi added a comment to D14116: Use a better icon for "Remove" on the widget handle.

+1. I have a similar experience with the red X-Button as shown here for the Activity Manager:

Jul 14 2018, 9:00 PM · Plasma

Jul 8 2018

gregormi added a comment to D13970: Handle empty preview lists.

I am rather familiar with KMoreTools but not with the rest of KNewStuff.

Jul 8 2018, 8:27 PM · Frameworks

Jul 7 2018

gregormi committed R417:b6e059b12644: Improve two messages (authored by gregormi).
Improve two messages
Jul 7 2018, 4:55 PM
gregormi closed D12908: Improve two messages.
Jul 7 2018, 4:55 PM

Jul 6 2018

gregormi added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

The spirit goes in the right direction; please proceed :-). Note, that Kate's project plugin also uses KMoreTools.

Jul 6 2018, 2:30 PM · Frameworks
gregormi added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

You are the most awesome person in the world today.

Jul 6 2018, 12:04 AM · Frameworks

Jun 29 2018

gregormi added a reviewer for D12908: Improve two messages: aacid.

@aacid I used your suggestion to fix the message. It sounds more natural and fluent. From my side this is now ready to land.

Jun 29 2018, 9:50 PM
gregormi updated the diff for D12908: Improve two messages.
  • rebase on master
  • improve "enable all messages" message
  • improve "difficulty warning" message
Jun 29 2018, 9:45 PM
gregormi abandoned D13802: fix author.

wrong arc usage

Jun 29 2018, 9:32 PM
gregormi requested review of D13802: fix author.
Jun 29 2018, 9:31 PM
gregormi committed R417:dd1039909761: Improve Hint and Solve action visibility and enabled state (authored by gregormi).
Improve Hint and Solve action visibility and enabled state
Jun 29 2018, 8:40 PM
gregormi closed D12912: Improve Hint and Solve action visibility and enabled state.
Jun 29 2018, 8:40 PM
gregormi updated the diff for D12912: Improve Hint and Solve action visibility and enabled state.
  • Fix spacing: use tabs instead of spaces
  • Make method const
Jun 29 2018, 8:38 PM
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.
Jun 29 2018, 4:46 PM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.
  • info comment
  • Remove the now useless "not set" string
  • Set shortcut text with Qt methods and omit the translation context string and \t
Jun 29 2018, 4:46 PM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
Jun 29 2018, 3:57 PM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Rework the Module.ui layout to fix the spacing
  • Add dummy label to remove special case for "Distro"
  • Use C++11 for loop and add qAsConst
  • Make RTL aware by not removing the colon
  • Improve translation context message
Jun 29 2018, 3:53 PM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

I added some qDebug code in Module::copyToClipboard() and noticed that the method is always called twice when the Copy to clipboard button is clicked.

Jun 29 2018, 3:11 PM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

Thanks Henrik for the review. I fixed the layout and it looks now like this in Qt Designer:

Jun 29 2018, 2:31 PM · Plasma

Jun 25 2018

gregormi added a comment to D13706: [KMoreTools] Enable installing tools via appstream url.

I'd like to see the missing AppStream URLs filled in for all the software in this list. There are currently some claring omissions, especially for KDE software (e.g. ksysguard) for which there is definitely an appstream ID available). For any software that doesn't have any AppStream information (and is therefore not visible or installable via Discover), I would actually advocate removing it from the list, and making the presence of AppStream data a pre-condition of inclusion--the reason being that otherwise an Install button can't be presented to the user. Entries without an Install button are just frustrating, tantamount to taunting them ("here's some cool software you could use; oh, sorry, can't actually install it lol")

Jun 25 2018, 6:03 PM · Frameworks

Jun 24 2018

gregormi accepted D13706: [KMoreTools] Enable installing tools via appstream url.

Ok from my side. Please let also Dominik give his approval.

Jun 24 2018, 10:08 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Jun 24 2018, 9:48 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Jun 24 2018, 9:24 PM · Frameworks
gregormi added inline comments to D13706: [KMoreTools] Enable installing tools via appstream url.
Jun 24 2018, 9:06 PM · Frameworks
gregormi added a comment to D13706: [KMoreTools] Enable installing tools via appstream url.

First of all, thanks for adding this feature. This was missing a long time :-). I will do some comments in the code.

Jun 24 2018, 8:49 PM · Frameworks

May 30 2018

gregormi added a comment to D12908: Improve two messages.

To summarize the current reviewers responses,

May 30 2018, 9:32 AM
gregormi updated the summary of D12908: Improve two messages.
May 30 2018, 9:27 AM
gregormi added a comment to D12912: Improve Hint and Solve action visibility and enabled state.

I agree with the general UI best practice. But this change is different. As far as I understood the program, there are two modes: "Enter/edit a game" and "Play the game". The "Check" action is currently always grayed out during "Play the game" because it makes no sense there. And the "Hint" action only makes sense when playing the game not when creating one. In either mode, the user gets more confused because a deactivated button indicates that it might come available which is not true (as far as I can see it).

May 30 2018, 9:19 AM
gregormi committed R417:1dd6e4bd2e5e: Implement wish 319522: Option to restart current game (authored by gregormi).
Implement wish 319522: Option to restart current game
May 30 2018, 9:10 AM
gregormi closed D12907: Implement wish 319522: Option to restart current game.
May 30 2018, 9:10 AM
gregormi updated the summary of D12907: Implement wish 319522: Option to restart current game.
May 30 2018, 9:00 AM
gregormi updated the summary of D12907: Implement wish 319522: Option to restart current game.
May 30 2018, 8:59 AM
gregormi added a reviewer for D10297: Add new "Tools" button above System Monitor's process list: rkflx.
May 30 2018, 8:50 AM · Plasma
gregormi updated the summary of D10297: Add new "Tools" button above System Monitor's process list.
May 30 2018, 8:42 AM · Plasma
gregormi updated the diff for D10297: Add new "Tools" button above System Monitor's process list.

The text should use title case: "Kill a Window"

DONE

May 30 2018, 8:37 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • use auto, add comment
May 30 2018, 8:05 AM · Plasma
gregormi added a reviewer for D7087: Add "Copy Info" button to the About System KCM: rkflx.
May 30 2018, 7:31 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Handle colon (:) problem for translating and fix one label bug
May 30 2018, 7:28 AM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
May 30 2018, 7:12 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Fix comment
  • Clean ui file
  • Shortcut handling
May 30 2018, 7:11 AM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
May 30 2018, 6:40 AM · Plasma
gregormi updated the diff for D7087: Add "Copy Info" button to the About System KCM.
  • Translate the Distro string
  • Rename button to 'Copy to Clipboard' for more clarity; and consistency with other applications
  • Use a QList of QPairs to collect labels and then use a loop
May 30 2018, 6:39 AM · Plasma
gregormi added inline comments to D7087: Add "Copy Info" button to the About System KCM.
May 30 2018, 6:00 AM · Plasma

May 23 2018

gregormi updated the summary of D12912: Improve Hint and Solve action visibility and enabled state.
May 23 2018, 8:29 AM
gregormi updated the summary of D12912: Improve Hint and Solve action visibility and enabled state.
May 23 2018, 8:29 AM
gregormi updated the diff for D12912: Improve Hint and Solve action visibility and enabled state.
  • Enable Hint button again when after solved puzzle Undo was used
May 23 2018, 8:28 AM
gregormi committed R417:dc8be89137cf: Remove TODO file (authored by gregormi).
Remove TODO file
May 23 2018, 7:38 AM
gregormi closed D12922: Remove TODO file.
May 23 2018, 7:38 AM
gregormi updated the summary of D12922: Remove TODO file.
May 23 2018, 7:36 AM
gregormi committed R417:d79e2ff3e842: Remove AUTHORS file (authored by gregormi).
Remove AUTHORS file
May 23 2018, 7:27 AM
gregormi closed D12920: Remove AUTHORS file.
May 23 2018, 7:27 AM
gregormi updated the summary of D12920: Remove AUTHORS file.
May 23 2018, 7:24 AM
gregormi committed R417:3c848ecee3ff: Remove obsolete INSTALL and VERSION files (authored by gregormi).
Remove obsolete INSTALL and VERSION files
May 23 2018, 7:21 AM
gregormi closed D12921: Remove obsolete INSTALL and VERSION files.
May 23 2018, 7:20 AM
gregormi committed R417:6ba2528a64c3: Remove file TODOPORT (authored by gregormi).
Remove file TODOPORT
May 23 2018, 7:15 AM
gregormi closed D12900: Remove file TODOPORT.
May 23 2018, 7:15 AM
gregormi added a comment to D10297: Add new "Tools" button above System Monitor's process list.

@rkflx: Hi Henrik, I resolved all your code remarks. Could you look it over and give a go to have this landed.

May 23 2018, 7:07 AM · Plasma
gregormi added a comment to D7087: Add "Copy Info" button to the About System KCM.

@ngraham , @rkflx, @dhaumann: Do you have any more suggestions to this? I think it is now ready to land.

May 23 2018, 7:05 AM · Plasma
gregormi added a comment to D12907: Implement wish 319522: Option to restart current game.

Do you think it's a good idea that the undo stack is not wiped when doing restart?

I.e. you can do restart and then you can do redo.

I don't have an opinion, just want to know if it's on purpose or a side effect of the implementation of ::restart

May 23 2018, 7:00 AM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • clear history on restart
May 23 2018, 6:58 AM

May 16 2018

gregormi updated the summary of D12922: Remove TODO file.
May 16 2018, 9:18 AM
gregormi updated the summary of D12922: Remove TODO file.
May 16 2018, 9:15 AM
gregormi updated the summary of D12922: Remove TODO file.
May 16 2018, 8:44 AM
gregormi requested review of D12922: Remove TODO file.
May 16 2018, 8:41 AM
gregormi retitled D12921: Remove obsolete INSTALL and VERSION files from Remove obsolete INSTALL file to Remove obsolete INSTALL and VERSION files.
May 16 2018, 8:35 AM
gregormi updated the diff for D12921: Remove obsolete INSTALL and VERSION files.
  • Also remove outdated VERSION file
May 16 2018, 8:35 AM
gregormi requested review of D12921: Remove obsolete INSTALL and VERSION files.
May 16 2018, 8:34 AM
gregormi updated the summary of D12920: Remove AUTHORS file.
May 16 2018, 8:32 AM
gregormi requested review of D12920: Remove AUTHORS file.
May 16 2018, 8:31 AM
gregormi updated the summary of D12908: Improve two messages.
May 16 2018, 12:44 AM
gregormi updated the diff for D12908: Improve two messages.
  • Bug 357999: improve "Low Difficulty" warning
May 16 2018, 12:43 AM
gregormi requested review of D12912: Improve Hint and Solve action visibility and enabled state.
May 16 2018, 12:04 AM

May 15 2018

gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 10:51 PM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • use tabs in files where mostly tabs instead of spaces are used
May 15 2018, 10:49 PM
gregormi updated the diff for D12908: Improve two messages.
  • change spaces back to tabs
May 15 2018, 10:39 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 10:38 PM
gregormi requested review of D12908: Improve two messages.
May 15 2018, 10:27 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 10:11 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 10:02 PM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • ksudokuui.rc: increase version
May 15 2018, 10:01 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 9:59 PM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • use tabs instead of spaces
May 15 2018, 9:58 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 9:55 PM
gregormi updated the diff for D12907: Implement wish 319522: Option to restart current game.
  • fix whitespace and improve if statement
May 15 2018, 9:45 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 9:40 PM
gregormi added inline comments to D12907: Implement wish 319522: Option to restart current game.
May 15 2018, 9:35 PM
gregormi retitled D12907: Implement wish 319522: Option to restart current game from Fix Bug 319522: Option to restart current game to Implement wish 319522: Option to restart current game.
May 15 2018, 8:42 PM