gregormi (gregormi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2015, 8:50 PM (193 w, 1 d)
Availability
Available

Recent Activity

Yesterday

gregormi added a comment to D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.

That I don't misunderstand: the clickable thingy is the thing shown in the first screenshots inside the lineedits?

Sat, Feb 16, 5:04 PM · Kate
gregormi updated the test plan for D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.
Sat, Feb 16, 4:59 PM · Kate
gregormi added a comment to D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.

Hi Christoph, thanks for the ping.
There are two possible paths for this change in total:

  1. Revert the changes which introduce the new clickable icons because they are considered visual clutter
  2. Keep the clickable icons and revert the tooltip changes
Sat, Feb 16, 3:53 PM · Kate

Wed, Feb 6

gregormi added a comment to D17971: Revive External Tools plugin.
  • I like the idea of "Show as popup" or "Display as inline note". I was misunderstanding this first, though: For "Display as inline note" I first thought of the new InlineNoteInterface, but I think you are talking about KTextEditor::Message.

Actually, I meant both, KTextEditor::Message for "Show as popup" and InlineNoteInterface for the other one. For first one, there are some use cases; the second one could be used to display git blame information more persistently than with a disappearing note. Both nice to have, of course.

Wed, Feb 6, 7:10 PM · Kate

Mon, Feb 4

gregormi added a comment to D17971: Revive External Tools plugin.

@gregormi

  • Output "Replace Current Document": works fine. Idea: restore cursor position after operation.
    • Given the document usually changed afterwards, "restoring the cursor position" is pretty much undefined, and almost never correct...
Mon, Feb 4, 8:55 PM · Kate

Sun, Feb 3

gregormi added a comment to D17971: Revive External Tools plugin.

I tried the plugin, these are my observations:

Sun, Feb 3, 5:40 PM · Kate

Thu, Jan 24

gregormi added a comment to T8484: Making settting up a development environment quick and easy.

https://community.kde.org/Get_Involved/development.
What do people think? Does it work?

Thu, Jan 24, 11:21 PM

Jan 16 2019

gregormi updated the task description for T10317: Search&Replace plugin improvements.
Jan 16 2019, 9:30 PM · Kate
gregormi updated the task description for T10317: Search&Replace plugin improvements.
Jan 16 2019, 9:29 PM · Kate
gregormi updated subscribers of T10317: Search&Replace plugin improvements.
In T10317#173650, @sars wrote:
  1. Ctrl+Shift+F is a semi standard full-screen shortcut in KDE. Gwenview, Ocular and Konqueror are examples of this.
Jan 16 2019, 9:26 PM · Kate
gregormi updated the task description for T10317: Search&Replace plugin improvements.
Jan 16 2019, 9:21 PM · Kate

Jan 14 2019

gregormi added a comment to T10281: Create an "Outline View".
Jan 14 2019, 8:42 PM · Kate
gregormi updated the task description for T10281: Create an "Outline View".
Jan 14 2019, 8:26 PM · Kate

Jan 13 2019

gregormi added a comment to T10281: Create an "Outline View".

Yes, my English is bad. But "Outline View" sound to me less fitting than my "Index View".

Jan 13 2019, 9:22 PM · Kate
gregormi updated the task description for T10320: Usage of the Build Plugin.
Jan 13 2019, 9:16 PM · Kate
gregormi updated the task description for T10319: Ideas for External Tools.
Jan 13 2019, 9:12 PM · Kate
gregormi added a comment to T10319: Ideas for External Tools.

The example of the diff of two views is out of scope: On KTextEditor level, we don't even have a concept of having multiple views side by side, that is business of the host application. You will really only have the concept of one active view.

Jan 13 2019, 9:11 PM · Kate
gregormi updated the task description for T10324: Add a dedicated "Run/Runtime" Konsole.
Jan 13 2019, 9:08 PM · Kate
gregormi updated the task description for T10324: Add a dedicated "Run/Runtime" Konsole.
Jan 13 2019, 9:07 PM · Kate
gregormi updated the task description for T10324: Add a dedicated "Run/Runtime" Konsole.
Jan 13 2019, 9:01 PM · Kate
gregormi updated the task description for T10324: Add a dedicated "Run/Runtime" Konsole.
Jan 13 2019, 9:00 PM · Kate
gregormi renamed T10324: Add a dedicated "Run/Runtime" Konsole from Add a "Run/Runtime" Konsole to Add a dedicated "Run/Runtime" Konsole.
Jan 13 2019, 8:55 PM · Kate
gregormi updated the task description for T10324: Add a dedicated "Run/Runtime" Konsole.
Jan 13 2019, 8:55 PM · Kate
gregormi updated the task description for T10320: Usage of the Build Plugin.
Jan 13 2019, 8:44 PM · Kate
gregormi triaged T10324: Add a dedicated "Run/Runtime" Konsole as Low priority.
Jan 13 2019, 8:43 PM · Kate
gregormi added a comment to T10317: Search&Replace plugin improvements.
In T10317#173006, @sars wrote:
  1. These buttons are different than the other buttons in that they modify the UI of the toolview but not the search. So mixing them is maybe not the best? One could think about moving them to the right side of the other buttons and have some type of separator between...
Jan 13 2019, 8:40 PM · Kate
gregormi updated the task description for T10319: Ideas for External Tools.
Jan 13 2019, 8:26 PM · Kate
gregormi updated the task description for T10319: Ideas for External Tools.
Jan 13 2019, 8:25 PM · Kate
gregormi updated the task description for T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).
Jan 13 2019, 8:23 PM · KTextEditor
gregormi updated the task description for T10319: Ideas for External Tools.
Jan 13 2019, 8:21 PM · Kate
gregormi added a comment to D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.
In D18083#392525, @sars wrote:

My personal taste would be to only have a small tool-tip saying: See the "Add.." context menu entry for regular expression help.

The search plugin is already cluttered with a lot of buttons...

Jan 13 2019, 7:43 PM · Kate
gregormi updated subscribers of D17308: Make CTags/Projects context menu more accessible.

Thanks Kåre for the review. I'll update the change.

Jan 13 2019, 7:31 PM · Kate
gregormi updated the task description for T10319: Ideas for External Tools.
Jan 13 2019, 6:49 PM · Kate
gregormi updated the test plan for D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.
Jan 13 2019, 3:56 PM · Kate
gregormi added a comment to T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).

But I'm not sure if "navigate up/down/left/right" in some list should be done by a shortcut where you jump "free" in some text like in Kate or a Web-Browser.

Jan 13 2019, 3:53 PM · KTextEditor
gregormi updated the summary of D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.
Jan 13 2019, 3:45 PM · Kate
gregormi updated the diff for D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.
  • Add line edit action icons which makes the tooltip obsolete

(Screenshots in the description)

Jan 13 2019, 3:41 PM · Kate
gregormi updated subscribers of T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).

Um, can't find here a hint that this is try to follow some "defined standard", like CUA. https://en.wikipedia.org/wiki/IBM_Common_User_Access

"...all major Unix GUI environments/toolkits, whether or not based on the X 
Window System, have featured varying levels of CUA compatibility.." 
"The current major environments, GNOME and KDE, also feature extensive CUA 
compatibility..."

Web-search list some KDE docs for Krusader or Gwenview but so far no "master page".

Particularly I ask me why the S&R plugin should use own shortcuts when there is F3/Shift-F3 already defined (at least here and there listed as Standard) I would prefer that the default short cuts always works, independent what was the initial search tool.

But probably I once again misunderstood something :-)

Jan 13 2019, 3:25 PM · KTextEditor
gregormi added a comment to D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.

@loh.tar: I redirect the general discussion to here: https://phabricator.kde.org/T10279

Jan 13 2019, 3:24 PM · Kate
gregormi triaged T10320: Usage of the Build Plugin as Low priority.
Jan 13 2019, 2:38 PM · Kate
gregormi updated the task description for T10319: Ideas for External Tools.
Jan 13 2019, 2:01 PM · Kate
gregormi triaged T10319: Ideas for External Tools as Wishlist priority.
Jan 13 2019, 1:59 PM · Kate
gregormi added a comment to D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.

This is the plan :) https://phabricator.kde.org/T10279

Jan 13 2019, 10:58 AM · Kate
gregormi updated the diff for D17138: Kate: File menu: Put Save, Print and Export actions into submenus.
  • Adapt kwriteui.rc
Jan 13 2019, 2:58 AM · Kate
gregormi added a comment to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

What I wonder: during the work with the .rc menu files I noticed that even the menu in Kate which is installed in root got affected by the changes I made in the development version and I had to regularly change the version number to make changes take effect. Is this normal?

Jan 13 2019, 2:16 AM · Frameworks, Kate
gregormi updated the diff for D17138: Kate: File menu: Put Save, Print and Export actions into submenus.
Jan 13 2019, 2:09 AM · Kate
gregormi added a comment to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

This is what is looks like now (together with latest changes from https://phabricator.kde.org/D17138):

Jan 13 2019, 2:07 AM · Frameworks, Kate
gregormi updated the diff for D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.
  • Move "Save As..." out of the submenu
Jan 13 2019, 2:03 AM · Frameworks, Kate
gregormi triaged T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search) as Normal priority.
Jan 13 2019, 12:58 AM · KTextEditor
gregormi updated the task description for T10317: Search&Replace plugin improvements.
Jan 13 2019, 12:51 AM · Kate
gregormi updated the task description for T10317: Search&Replace plugin improvements.
Jan 13 2019, 12:51 AM · Kate
gregormi triaged T10316: Status bar: modified indicator as Wishlist priority.
Jan 13 2019, 12:34 AM · KTextEditor
gregormi triaged T10317: Search&Replace plugin improvements as Wishlist priority.
Jan 13 2019, 12:33 AM · Kate
gregormi created T10316: Status bar: modified indicator.
Jan 13 2019, 12:27 AM · KTextEditor
gregormi added a comment to D17730: Review KateStatusBar .

@loh.tar: I like the new status bar.

Jan 13 2019, 12:26 AM · Frameworks, Kate

Jan 12 2019

gregormi added a comment to D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.

Could you serch for Key_F6 in the KTextEditor and Kate source code? I want to avoid that we overlook something.

I'll report back.

Jan 12 2019, 11:40 PM · Kate
gregormi retitled D17442: KTextEditor: Tweak keyboard shortcuts to free F keys from KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate to KTextEditor: Tweak keyboard shortcuts to free F keys.
Jan 12 2019, 11:33 PM · Frameworks, Kate
gregormi added a comment to D17442: KTextEditor: Tweak keyboard shortcuts to free F keys.

With respect to bringing this https://phabricator.kde.org/T10279 forward, how should I proceed here? Can this go in as first step (after I removed F10 and F11)? (see also https://phabricator.kde.org/D17443)

Jan 12 2019, 11:32 PM · Frameworks, Kate
gregormi added a comment to D17308: Make CTags/Projects context menu more accessible.
In D17308#370361, @sars wrote:

What if you have Project, CTags and the new Zeal plugins active? You need to differentiate them somehow.
[...]
As it is right now for the project plugin, it is a bit strange to have a sub-menu for one action, but we could get more....

Jan 12 2019, 11:24 PM · Kate

Jan 11 2019

gregormi added a comment to D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.

Can you make the RegExp tool-tip available only when we are in RegExp mode?

Jan 11 2019, 11:26 PM · Kate

Jan 10 2019

gregormi updated the task description for T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).
Jan 10 2019, 8:44 PM · KTextEditor
gregormi created T10309: Use InlineNoteInterface for a "Current Line Blame".
Jan 10 2019, 8:38 PM · Kate

Jan 9 2019

gregormi added a comment to D17971: Revive External Tools plugin.

This is definitely worth to proceed, thanks!

Jan 9 2019, 9:40 PM · Kate

Jan 7 2019

gregormi updated the summary of D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.
Jan 7 2019, 11:26 PM · Kate
gregormi added a reviewer for D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch: Kate.
Jan 7 2019, 11:26 PM · Kate
gregormi requested review of D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.
Jan 7 2019, 11:25 PM · Kate
gregormi added a reviewer for D18082: kate/README: add a minimal list of build dependencies: Kate.
Jan 7 2019, 11:11 PM · Kate
gregormi requested review of D18082: kate/README: add a minimal list of build dependencies.
Jan 7 2019, 11:10 PM · Kate
gregormi placed T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search) up for grabs.
Jan 7 2019, 12:08 AM · KTextEditor
gregormi placed T10280: Ctrl+Space Autocomplete: Do not delete after completion up for grabs.
Jan 7 2019, 12:07 AM · KTextEditor
gregormi updated the task description for T10281: Create an "Outline View".
Jan 7 2019, 12:06 AM · Kate
gregormi updated the task description for T10281: Create an "Outline View".
Jan 7 2019, 12:05 AM · Kate
gregormi updated the task description for T10281: Create an "Outline View".
Jan 7 2019, 12:01 AM · Kate

Jan 6 2019

gregormi created T10281: Create an "Outline View".
Jan 6 2019, 11:56 PM · Kate
gregormi moved T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search) from Backlog to In Progress on the KTextEditor board.
Jan 6 2019, 11:53 PM · KTextEditor
gregormi moved T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search) from Multi-Cursor to Backlog on the KTextEditor board.
Jan 6 2019, 11:52 PM · KTextEditor
gregormi moved T10280: Ctrl+Space Autocomplete: Do not delete after completion from Multi-Cursor to Backlog on the KTextEditor board.
Jan 6 2019, 11:52 PM · KTextEditor
gregormi assigned T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search) to dhaumann.
Jan 6 2019, 11:50 PM · KTextEditor
gregormi renamed T10280: Ctrl+Space Autocomplete: Do not delete after completion from Ctrl+Space Autocomplete: Option _not_ to delete to Ctrl+Space Autocomplete: Do not delete after completion.
Jan 6 2019, 11:50 PM · KTextEditor
gregormi created T10280: Ctrl+Space Autocomplete: Do not delete after completion.
Jan 6 2019, 11:49 PM · KTextEditor
gregormi updated the task description for T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).
Jan 6 2019, 11:45 PM · KTextEditor
gregormi updated the task description for T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).
Jan 6 2019, 11:43 PM · KTextEditor
gregormi updated the task description for T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).
Jan 6 2019, 11:25 PM · KTextEditor
gregormi created T10279: Tidy up keyboard shortcuts (e.g. Ctrl+Shift+F for file search).
Jan 6 2019, 11:25 PM · KTextEditor

Dec 21 2018

gregormi added a comment to D17704: Copy to clipboard always copy English texts.

Hi, here is the discussion around my the patch that introduced the Copy button: https://phabricator.kde.org/D7087

Dec 21 2018, 5:27 PM · Plasma

Dec 19 2018

gregormi added a comment to D17308: Make CTags/Projects context menu more accessible.
In D17308#370361, @sars wrote:

What if you have Project, CTags and the new Zeal plugins active? You need to differentiate them somehow.

Dec 19 2018, 11:37 PM · Kate
gregormi added a comment to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

If there are no further comments, would proceed with:

Dec 19 2018, 11:32 PM · Frameworks, Kate
gregormi added a comment to D17442: KTextEditor: Tweak keyboard shortcuts to free F keys.

Yes, those shortcuts exist long time. I would like to change them for these specific reasons which I think are worth to be considered:

Dec 19 2018, 11:16 PM · Frameworks, Kate
gregormi added a comment to D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.

The changes in the replicode plugin certainly look good to me and can be committed.

Dec 19 2018, 11:02 PM · Kate

Dec 16 2018

gregormi added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

One task would be to move the code of KImageAnnotator (which currently lives at https://github.com/DamirPorobic/KImageAnnotator; with a dependency to https://github.com/DamirPorobic/kColorPicker) to KDE infrastructure.

Dec 16 2018, 8:01 PM · VDG, Spectacle

Dec 10 2018

gregormi added a comment to D17314: Projects Plugin: Add ShellCheck analyzer.

Yes, current master does not compile because of that. Sorry. #include
<QString> works. I cannot commit ATM.

Dec 10 2018, 12:21 PM · Kate

Dec 9 2018

gregormi added a comment to D17442: KTextEditor: Tweak keyboard shortcuts to free F keys.

I always re-bind Find Next and and Find Previous to use Ctrl+G and Ctrl++G. These are the shortcuts that are used by most 3rd-party apps, as well as all GNOME and macOS apps. It might make more sense to standardize on those.

Just to clarify: F3/Shift+F3 would stay the same, right?

Yeah, as backup/additional shortcuts so we don't break workflows for people who currently use them.

Dec 9 2018, 6:45 PM · Frameworks, Kate
gregormi requested review of D17449: WIP: Projects Tree View: Try to enable context menu also for directory nodes.
Dec 9 2018, 10:53 AM · Kate
gregormi retitled D17432: WIP: Add Analyzer Tool "Cppcheck (for C)" from WIP: Add Analyzer Tool "Cppcheck (C only)" to WIP: Add Analyzer Tool "Cppcheck (for C)".
Dec 9 2018, 9:35 AM · Kate
gregormi retitled D17432: WIP: Add Analyzer Tool "Cppcheck (for C)" from WIP: Add Analyzer Tool "Cppcheck (C++ only)" to WIP: Add Analyzer Tool "Cppcheck (C only)".
Dec 9 2018, 9:35 AM · Kate
gregormi added a comment to D17432: WIP: Add Analyzer Tool "Cppcheck (for C)".

I dislike the fact that we have two times almost the same thing. Then again I can see that if C++ is set explicitly, the cppcheck plugin will be unusable for C. Then again, cppcheck contains 'cpp' in its name. So should we care about C at all here? If the answer is 'no', I would prefer to simply add the command line option and be done with it :-) or add an option in the Projects config page.

Dec 9 2018, 9:22 AM · Kate
gregormi added a comment to D17442: KTextEditor: Tweak keyboard shortcuts to free F keys.

I always re-bind Find Next and and Find Previous to use Ctrl+G and Ctrl++G. These are the shortcuts that are used by most 3rd-party apps, as well as all GNOME and macOS apps. It might make more sense to standardize on those.

Dec 9 2018, 9:10 AM · Frameworks, Kate
gregormi requested review of D17445: WIP: Add function to compare unsaved with saved version of the document.
Dec 9 2018, 12:03 AM · Kate

Dec 8 2018

gregormi added a reviewer for D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match: Kate.
Dec 8 2018, 11:15 PM · Kate
gregormi added a reviewer for D17442: KTextEditor: Tweak keyboard shortcuts to free F keys: Kate.
Dec 8 2018, 11:14 PM · Frameworks, Kate