pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (160 w, 1 d)
Availability
Available

Recent Activity

Yesterday

pino added a comment to D20626: Refactor and cleanup.

Also, please explicitly mention what are the changes done. "refactor and cleanup" is very vague, while saying that, for example, QSysInfo is used on all the OSes is better.

Fri, Apr 19, 8:28 AM · Frameworks

Sat, Apr 13

pino added a comment to D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes.

Shouldn't the same applied to columnCount too?

Sat, Apr 13, 2:08 PM · Frameworks

Tue, Apr 9

pino added a comment to D20389: doc: drop almost all bits related to installation.

I've just returned from vacation, and there is currently a string/doc freeze, so please give me some days to review, but I'll probably agree.

Tue, Apr 9, 6:00 PM · Documentation
pino added inline comments to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
Tue, Apr 9, 5:44 PM · Frameworks
pino added a comment to D20335: Remove warning static member accessed through instance.

true, but then the instance is there anyway. what we gain from this?

we remove compiler warning

Tue, Apr 9, 4:55 AM
pino added a comment to D20398: Remove warning: do not use 'else' after 'return'.

Which warnings do the two function trigger?
Also, adding { ... } breaks the code style.

Tue, Apr 9, 4:51 AM

Mon, Apr 8

pino updated subscribers of D20389: doc: drop almost all bits related to installation.
Mon, Apr 8, 7:02 PM · Documentation
pino requested review of D20389: doc: drop almost all bits related to installation.
Mon, Apr 8, 7:02 PM · Documentation

Sun, Apr 7

pino added inline comments to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
Sun, Apr 7, 8:05 PM · Frameworks
pino committed R883:1539387: updates.
updates
Sun, Apr 7, 7:12 PM
pino committed R883:1539386: complete.
complete
Sun, Apr 7, 6:41 PM
pino added inline comments to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
Sun, Apr 7, 6:04 PM · Frameworks
pino added inline comments to D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.
Sun, Apr 7, 5:30 PM · KDE PIM
pino added inline comments to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
Sun, Apr 7, 10:08 AM · Frameworks
pino added a comment to D20334: Speed up invert colors effect.

The API documentation of kpEffectInvert::applyEffect() says:

// Inverts the colours of each pixel in the given image.
// These functions differ from QImage::invertPixels() in the following ways:
//
// 1. for 8-bit images, it inverts the colours of the Colour Table
//    (this means that you would get visually similar results to inversion
//     at higher bit depths - rather than a "random-looking" inversion
//     depending on the contents of the Colour Table)
// 2. never inverts the Alpha Buffer

Did you check that the change does not invalidate these? (especially point 1)

Sun, Apr 7, 7:26 AM
pino committed R468:30a1433e4b75: Fix float assignment (authored by pino).
Fix float assignment
Sun, Apr 7, 6:37 AM
pino committed R468:a5b5f1ef4bfa: Fix bool check (authored by pino).
Fix bool check
Sun, Apr 7, 6:37 AM
pino committed R468:172192a28848: Qualify QObject::connect in lambda (authored by pino).
Qualify QObject::connect in lambda
Sun, Apr 7, 6:37 AM
pino committed R468:591e44da4f79: Fix KileUtilities::standardLocations (authored by pino).
Fix KileUtilities::standardLocations
Sun, Apr 7, 6:25 AM
pino committed R468:333a87656c10: Fix KileUtilities::findExecutable (authored by pino).
Fix KileUtilities::findExecutable
Sun, Apr 7, 6:22 AM
pino committed R468:fccee49090de: Remove unused icons (authored by pino).
Remove unused icons
Sun, Apr 7, 6:13 AM
pino committed R468:c00b3065b2af: Fix installation of kile svg icon (authored by pino).
Fix installation of kile svg icon
Sun, Apr 7, 6:13 AM
pino committed R883:1539353: old doc bit recently removed.
old doc bit recently removed
Sun, Apr 7, 4:32 AM

Sat, Apr 6

pino committed R167:9a584ee60f16: doc: drop almost all bits related to installation (authored by pino).
doc: drop almost all bits related to installation
Sat, Apr 6, 8:53 AM
pino closed D20287: doc: drop almost all bits related to installation.
Sat, Apr 6, 8:53 AM · Documentation
pino requested review of D20287: doc: drop almost all bits related to installation.
Sat, Apr 6, 8:29 AM · Documentation
pino committed R261:dae72c5e5ed7: doc: use more entities (authored by pino).
doc: use more entities
Sat, Apr 6, 6:35 AM

Thu, Apr 4

pino committed R91:6bc5add4219f: Merge branch 'Applications/19.04' (authored by pino).
Merge branch 'Applications/19.04'
Thu, Apr 4, 6:02 AM
pino added a reverting change for R91:d55c0b5458ef: Fix typo in i18n: R91:e9ea940ca594: Revert "Fix typo in i18n".
Thu, Apr 4, 6:02 AM
pino committed R91:e9ea940ca594: Revert "Fix typo in i18n" (authored by pino).
Revert "Fix typo in i18n"
Thu, Apr 4, 6:02 AM
pino added a comment to D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API.

Sessionbackend.h is not installed.

Thu, Apr 4, 5:21 AM · Plasma

Wed, Apr 3

pino added a comment to D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API.
  • loginddbustypes.h requires a license header
  • SessionBackend needs a d-pointer to minimize BIC changes
  • I'd move all the SessionBackend subclasses in a private header; they are not exported anyway, so unusable for users of this public library
Wed, Apr 3, 9:57 PM · Plasma
pino added a comment to D17991: Refactor the way device backends are built and registered.

BTW if nobody will comment on this within one month, I will commit it as-is.

Wed, Apr 3, 9:52 PM · Frameworks
pino updated the diff for D17991: Refactor the way device backends are built and registered.

Rebase on master.

Wed, Apr 3, 9:00 PM · Frameworks

Mon, Apr 1

pino committed R261:02c7b64b72a9: doc: few more changes (authored by pino).
doc: few more changes
Mon, Apr 1, 8:32 PM
pino committed R86:76e4b8a480e8: Merge branch 'Applications/19.04' (authored by pino).
Merge branch 'Applications/19.04'
Mon, Apr 1, 6:26 PM
pino committed R86:d585af51ee3e: Revert "Add more emoticons" (authored by pino).
Revert "Add more emoticons"
Mon, Apr 1, 6:26 PM
pino added a reverting change for R86:5f35f89b1441: Add more emoticons: R86:d585af51ee3e: Revert "Add more emoticons".
Mon, Apr 1, 6:26 PM
pino added inline comments to R86:5f35f89b1441: Add more emoticons.
Mon, Apr 1, 6:21 PM
pino added a comment to R86:5f35f89b1441: Add more emoticons.

@mlaurent please do not introduce new UI strings during a feature freeze and string freeze.

Mon, Apr 1, 6:56 AM

Sun, Mar 31

pino committed R883:1538645: updates.
updates
Sun, Mar 31, 6:21 PM
pino added inline comments to D20143: ora:kra: qstrcmp -> qstrncmp.
Sun, Mar 31, 4:02 PM · Frameworks
pino committed R456:283bb6356f1c: doc: fix few kde4 leftovers (authored by pino).
doc: fix few kde4 leftovers
Sun, Mar 31, 9:54 AM
pino committed R883:1538620: update and complete.
update and complete
Sun, Mar 31, 9:26 AM
pino committed R883:1538619: updates.
updates
Sun, Mar 31, 9:24 AM
pino added inline comments to D14147: Port from GConf to GSettings.
Sun, Mar 31, 8:39 AM · Plasma
pino added a comment to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

Note that, even if the system supports statx() (so with glibc >= 2.28), you must support systems without it at runtime anyway: for example, if you boot with a kernel older than 4.11 (which IIRC is the version where the syscall was added) then the glibc function will return ENOSYS (IIRC, better check). This can happen for example in containers: you boot a Debian testing container (so with glibc 2.28) on a Debian stable system (with Linux 4.9).

Sun, Mar 31, 8:38 AM · Frameworks
pino added inline comments to D14147: Port from GConf to GSettings.
Sun, Mar 31, 8:26 AM · Plasma

Sat, Mar 30

pino committed R883:1538596: remove stale documentation.
remove stale documentation
Sat, Mar 30, 11:49 PM
pino committed R883:1538595: remove stale documentation.
remove stale documentation
Sat, Mar 30, 11:49 PM
pino added inline comments to D20092: New class KOSRelease - a parser for os-release files.
Sat, Mar 30, 5:16 PM · Frameworks
pino added a comment to D20109: Be consistent with rest of coding style.

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

I have not changed the type for percent() signal, I have changed type for emitProgress()

Sat, Mar 30, 3:12 PM · KDE Partition Manager
pino added a comment to D19960: bluez-qt: remove warnings.

Please describe what are the warnings: otherwise it is not clear what the problem was, and what was the solution implemented.
Remember: just because you see something on your system, it does not necessarly mean everybody else will, so each commit needs a proper explanation so everybody can understand why a change was made.

Sat, Mar 30, 10:58 AM · Frameworks

Fri, Mar 29

pino added a comment to D19092: Add bison minimum version of 2.4.1 due to %code.

Not on the 19.04 branch, ...

This is a Framework (kservice).

Fri, Mar 29, 8:56 AM · Frameworks
pino requested changes to D20109: Be consistent with rest of coding style.
Fri, Mar 29, 8:55 AM · KDE Partition Manager
pino requested changes to D20107: Simplify write condition.
Fri, Mar 29, 6:39 AM · KDE Partition Manager

Wed, Mar 27

pino committed R883:1538455: update and complete.
update and complete
Wed, Mar 27, 8:44 PM

Tue, Mar 26

pino added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

Broken feature? What doesn't work? I tested it out and it worked fine for me.

Tue, Mar 26, 10:04 PM · Spectacle
pino added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

Because of the broken feature and string freezes, the commit was reverted in Applications/19.04, while still part of master (so it will be part of Applications 19.08).

Tue, Mar 26, 9:56 PM · Spectacle
pino committed R166:aa9600cfd9b4: Merge branch 'Applications/19.04' (authored by pino).
Merge branch 'Applications/19.04'
Tue, Mar 26, 9:52 PM
pino committed R166:69dfd182e761: Revert "Add option to copy screenshot to clipboard in background mode" (authored by pino).
Revert "Add option to copy screenshot to clipboard in background mode"
Tue, Mar 26, 9:52 PM
pino added a reverting change for R166:ec5e918743e7: Add option to copy screenshot to clipboard in background mode: R166:69dfd182e761: Revert "Add option to copy screenshot to clipboard in background mode".
Tue, Mar 26, 9:52 PM
pino added inline comments to D20049: Fix unexpected behaviour when calling dolphin with a file as an argument.
Tue, Mar 26, 5:32 AM · Dolphin

Sun, Mar 24

pino added a comment to D19812: Add a web page to view and compare icons of different sizes.
In D19812#436154, @pino wrote:
  • please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty string (to prevent typos)

Sorry, I am not very familiar with shell script. What does the -e or -u flags mean and how to use them? Can you give an example? Thanks.

Sun, Mar 24, 4:54 PM · Frameworks
pino committed R238:433211b5889f: it entities: update URLs to use https (authored by pino).
it entities: update URLs to use https
Sun, Mar 24, 7:26 AM

Sat, Mar 23

pino committed R883:1538237: update and complete.
update and complete
Sat, Mar 23, 9:12 PM
pino committed R883:1538236: various updates.
various updates
Sat, Mar 23, 8:54 PM

Fri, Mar 22

pino added a comment to D19812: Add a web page to view and compare icons of different sizes.

Few notes on the new generate_web_data.sh script:

  • please quote the paths properly, otherwise it will break when either the source directory or the build directory contain e.g. spaces
  • it does not seem using any bash-specific features, so make it using /bin/sh, to help non-Linux Unices (where usually bash is not available by default, and/or not in /bin)
  • please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty string (to prevent typos)
Fri, Mar 22, 8:46 AM · Frameworks
pino added inline comments to D19967: [kpeople] make it compile without foreach.
Fri, Mar 22, 8:40 AM · Frameworks
pino committed R23:37039394f88d: i18n fixes (authored by pino).
i18n fixes
Fri, Mar 22, 6:11 AM

Thu, Mar 21

pino added a comment to D19914: Fix i18n in "Save" section of configuration dialog.

Sorry, this was caused by a change from me. Could you please explain what I did wrong so I can avoid it in the future? Also why is the duplicate context in SaveOptionsPage needed? Does the context in ExportManager.cpp not suffice?

Now, ExportManager::filenamePlaceholders does not actually translate the strings because option.value() cannot get the translation when loaded (it has no idea that it will be translated and when it is loaded it is too late for the translations).

Thu, Mar 21, 6:43 PM · Spectacle

Mar 20 2019

pino added inline comments to D19551: [knotifications] compile without foreach.
Mar 20 2019, 7:43 AM · Frameworks

Mar 18 2019

pino added inline comments to D19828: [Kinit] Compile without foreach.
Mar 18 2019, 7:42 AM · Frameworks
pino added a comment to D19830: Force build order to prevent build happening before ui .h file exists.

It's a simple race condition between two targets:

  • ui_alarmtyperadiowidget.h is included by ../shared/alarmtyperadiowidget.cpp
  • ui_alarmtyperadiowidget.h is built only as part of the akonadi_kalarm_resource target
  • both the akonadi_kalarm_resource, and kalarmconfig targets have ../shared/alarmtyperadiowidget.cpp as source

hence, if ui_alarmtyperadiowidget.h is not generated before the build of the kalarmconfig starts, then the error happens

Mar 18 2019, 6:16 AM · KDE PIM

Mar 17 2019

pino added a comment to D17760: astyle: support the system astyle library.

Is this part of the astyle tarball, or a separate project?

Mar 17 2019, 1:02 PM · KDevelop
pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

no need for making it "deterministic" in any way. There is no benefit in doing that.

I think there is so, it's the whole point of this PR.

Mar 17 2019, 11:56 AM · KDevelop
pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
OK, I stand corrected on this. OTOH, the rest of my notes about this being wrong anyway still stand.

I'm not convinced about those arguments but have no objection either to making the temp dir user-exclusive - it's a detail that should be easy enough. There's probably a reason I'm not using QTemporaryDir though

Mar 17 2019, 11:24 AM · KDevelop
pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

using the user ID is definitely wrong here: with this change, opening a second kdevelop will erase the temporary directory of the first...

Maybe test-drive the patch (like I have been doing) before advancing hypotheses - don't you think I'd have noticed this kind of astronomically stupid error?
The tmp.dir name also includes the session ID, and you can only open a given session once.

Mar 17 2019, 10:29 AM · KDevelop
pino requested changes to D17289: KDevelop/Shell: set dedicated TMPDIR.
Mar 17 2019, 9:21 AM · KDevelop
pino updated subscribers of D17760: astyle: support the system astyle library.

Question: does any distro package that?

At least my openSUSE doesn't nor any other distro I know of, only thing I found was:

https://rpmfind.net/linux/rpm2html/search.php?query=libastyle-devel

I skimmed through https://repology.org/project/astyle/packages and found none.

Mar 17 2019, 8:58 AM · KDevelop
pino updated the diff for D17760: astyle: support the system astyle library.
  • add some rudimental version detection of the astyle library, since it provides no pkg-config file nor version macros/variables...
  • request libastyle >= 3.1
Mar 17 2019, 8:47 AM · KDevelop
pino added a comment to D19813: Fix freeze when resize with transparent option.

I don't think is necessary to revert. I'm working to modernize and clean up the code and this commit solves the problem at this time. In the future, I will create a better solution and maybe complete remove these logs.

Mar 17 2019, 7:46 AM · KDE Applications
pino added a comment to D19813: Fix freeze when resize with transparent option.

Pino, it doesn't. If you enabled the debug messages the code wouldn't
compile as the code that happened with the debug messages where actually
broken.

Mar 17 2019, 7:37 AM · KDE Applications
pino added a comment to D19813: Fix freeze when resize with transparent option.
In D19813#432369, @pino wrote:

The commit message is too generic, and it does not actually say what was the problem.
Also, the patch is completely unrelated to what the commit message (generically) says.

After this patch fff60307ff06 many qCDebug messages make resize slowing down if option transparent is selected.
This commit solves this problem just turning off that debug messages.

Mar 17 2019, 7:01 AM · KDE Applications
pino added a comment to D19813: Fix freeze when resize with transparent option.

The commit message is too generic, and it does not actually say what was the problem.
Also, the patch is completely unrelated to what the commit message (generically) says.

Mar 17 2019, 5:06 AM · KDE Applications

Mar 16 2019

pino added a comment to D19798: Fix Words & Chars String on katestatusbar..

The reason why I just change %1/%2 to %2/%1 not swap wordsInDocument and wordsInSelection, because I want to notify
translators about this change (or those current translation may have some issue when applied this fix.)

Mar 16 2019, 7:00 AM · Frameworks, Kate

Mar 13 2019

pino committed R158:b21dbb643bea: remove extra ';' (authored by pino).
remove extra ';'
Mar 13 2019, 7:10 AM
pino committed R158:2ae4ce1b6080: i18n fixes (authored by pino).
i18n fixes
Mar 13 2019, 6:53 AM
pino committed R158:3d2cd8b6d665: remove extra ';' (authored by pino).
remove extra ';'
Mar 13 2019, 6:53 AM
pino committed R158:fed503eb3dee: fixuifiles (authored by pino).
fixuifiles
Mar 13 2019, 5:55 AM

Mar 7 2019

pino committed R876:9f0a27f7bd5d: Use <gui> instead of deprecated <kpartgui> (authored by pino).
Use <gui> instead of deprecated <kpartgui>
Mar 7 2019, 6:56 AM

Mar 5 2019

pino added a comment to D18770: [KStatusNotifierItem] use fallback sizes when none is available.

ping?

Mar 5 2019, 7:26 AM · Frameworks
pino committed R37:703cbfbfae56: i18n: do not extract action files from 'tests' subdirs (authored by pino).
i18n: do not extract action files from 'tests' subdirs
Mar 5 2019, 7:15 AM
pino committed R462:2da1629e9c9c: Get rid of manual paper sizes translations (authored by pino).
Get rid of manual paper sizes translations
Mar 5 2019, 6:44 AM

Mar 1 2019

pino committed R883:1536401: typo fix.
typo fix
Mar 1 2019, 1:01 PM

Feb 23 2019

pino added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.

@pino also please consider that the same fix in another place was submitted, reviewed, accepted and landed, months ago

Feb 23 2019, 3:47 PM · Frameworks
pino added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.
In D18798#418056, @pino wrote:

Also, please do not resort to psychological tricks like "torture our users", as if this is any worse than any behaviour issues there.

There is no psychological trick. This is simply how I see things: we are doing this for the users. [...]

Feb 23 2019, 3:45 PM · Frameworks
pino added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.

Let me add also this: this behaviour seems triggered only when using breeze so far; hence, I see two possible explanations:

  1. it is a bug in breeze
  2. it is a bug in Qt, that somehow breeze manages to trigger
Feb 23 2019, 3:14 PM · Frameworks
pino added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.

@pino, can you help fix us the root cause then? The reason why we've resorted to these workarounds is because nobody's been able to adequately understand the root cause or implement a risk-free fix.

Ping. The workaround is known to work and cause no regressions, and I see no reason to torture our users with broken behavior for any longer. I would like to land this for Frameworks 5.56 if we aren't going to be able to work on fixing the root cause anytime soon.

Feb 23 2019, 3:11 PM · Frameworks

Feb 20 2019

pino added a comment to D19191: Windows: Work around path returned by QUrl.

Usually, if a url refers to local file (so isLocalFile() return true), then the right fix to get its local path is to use toLocalFile() instead of path().
Can you please try that change unconditionally?

Feb 20 2019, 8:27 PM · KDE Applications