pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (168 w, 2 d)
Availability
Available

Recent Activity

Today

pino added a comment to D19011: Thunderbolt KCM and KDED module.

Plasma 5.16 has been released and master is wide open for new features. Can we get this landed in some capacity soon? It would be great to have more testing time.

Sun, Jun 16, 7:05 PM · Plasma

Yesterday

pino added a comment to D21661: add snoretoast backend for KNotifications on Windows.

Ah, one last thing I apparently forgot to mention so far: the names of class variables must start with m_.

Sat, Jun 15, 8:26 AM · Frameworks
pino added a comment to D21661: add snoretoast backend for KNotifications on Windows.

I think I should make a new diff for further discussions, as this one is quite riddled with suggestions now. Are there any more issues with this patch or should I continue with a new one instead?

Sat, Jun 15, 8:24 AM · Frameworks

Thu, Jun 13

pino committed R158:4ffe3bbbcf99: Merge remote-tracking branch 'origin/Applications/19.04' (authored by pino).
Merge remote-tracking branch 'origin/Applications/19.04'
Thu, Jun 13, 7:24 AM
pino committed R158:1c8a88a9d828: i18n fixes (authored by pino).
i18n fixes
Thu, Jun 13, 7:17 AM

Tue, Jun 11

pino added a comment to D21661: add snoretoast backend for KNotifications on Windows.
In D21661#476571, @pino wrote:

It seems the snoretoast library provides a SnoreToasts class to do this instead of spawning an helper tool, what about using it instead?

@vonreth can probably explain better, but basically the situation as I understand it is on Windows you need to be installed in a special place and registered with the OS in order to show notifications. Since KNotifications is a library, an app using it can't (feasibly) be properly registered with the OS. It is possible we could come up with some complicated solution which would require every KNotification-using app to do some special and probably difficult to understand change to support Windows. Or we can have SnoreNotify.exe take care of all that nonsense for us. Note that, up to this point, there have been no special KNotifications changes to the generic KDE Connect codebase to make this work, just some tweaks to the Windows installer to pull in SnoreToast.

Tue, Jun 11, 5:00 AM · Frameworks

Mon, Jun 10

pino committed R496:a9459c9691f4: Use proper KStandardGuiItem items (authored by pino).
Use proper KStandardGuiItem items
Mon, Jun 10, 6:14 AM

Sun, Jun 9

pino committed R496:09c2779cdf45: cmake: fix few installation directories (authored by pino).
cmake: fix few installation directories
Sun, Jun 9, 4:45 AM
pino committed R496:94851e389ed6: Adapt icon file names to the new ecm_install_icons (authored by pino).
Adapt icon file names to the new ecm_install_icons
Sun, Jun 9, 4:45 AM

Sat, Jun 8

pino added a comment to D21661: add snoretoast backend for KNotifications on Windows.

This comment was removed by brute4s99.

Sat, Jun 8, 10:59 PM · Frameworks
pino added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 8, 10:56 PM · Frameworks
pino added a comment to D21661: add snoretoast backend for KNotifications on Windows.
In D21661#476156, @pino wrote:

how is snoretoast actually used here? you are requiring the library for building and linking, but then:

  • snoretoastactions.h, which is part of the headers of snoretoast, is copied here
  • the snoretoast library is never used, as the utilities of it are invoked instead If the library does all the work already, then I'd prefer to use it directly instead of spawning executables all the time...
Sat, Jun 8, 10:52 PM · Frameworks
pino added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 8, 8:38 AM · Frameworks
pino added a comment to D21661: add snoretoast backend for KNotifications on Windows.

how is snoretoast actually used here? you are requiring the library for building and linking, but then:

  • snoretoastactions.h, which is part of the headers of snoretoast, is copied here
  • the snoretoast library is never used, as the utilities of it are invoked instead

If the library does all the work already, then I'd prefer to use it directly instead of spawning executables all the time...

Sat, Jun 8, 6:33 AM · Frameworks

Tue, Jun 4

pino committed R216:5d9ec3b4ce53: debchangelog: add Eoan Ermine (authored by pino).
debchangelog: add Eoan Ermine
Tue, Jun 4, 9:08 PM

Mon, Jun 3

pino committed R883:1543224: check_po_files.
check_po_files
Mon, Jun 3, 5:10 AM

Sun, Jun 2

pino committed R1045:9a45be7b09db: i18n: typo fix (authored by pino).
i18n: typo fix
Sun, Jun 2, 12:32 PM

Sat, Jun 1

pino committed R883:1543121: typo fix.
typo fix
Sat, Jun 1, 4:25 PM
pino committed R773:906583e8ec37: React to the screensaver properly (authored by pino).
React to the screensaver properly
Sat, Jun 1, 1:16 PM
pino committed R773:5b6a825619dd: Remove wrong methods from D-Bus interface (authored by pino).
Remove wrong methods from D-Bus interface
Sat, Jun 1, 1:16 PM
pino committed R773:ef4b8c995160: Drop the session widget (authored by pino).
Drop the session widget
Sat, Jun 1, 1:16 PM
pino committed R773:0861b46daa68: Delete all the AmorAnimationGroup's (authored by pino).
Delete all the AmorAnimationGroup's
Sat, Jun 1, 1:16 PM
pino committed R773:5d3ec6007497: Hash the AmorAnimationGroup lists by value (authored by pino).
Hash the AmorAnimationGroup lists by value
Sat, Jun 1, 1:16 PM
pino committed R773:bda5cbfbaa1d: Delete cache pixmaps when changing theme (authored by pino).
Delete cache pixmaps when changing theme
Sat, Jun 1, 1:16 PM
pino committed R773:340ae64bda92: Delete the context menu (authored by pino).
Delete the context menu
Sat, Jun 1, 1:16 PM
pino committed R773:93b5121bea3a: Store QueueItem's by value (authored by pino).
Store QueueItem's by value
Sat, Jun 1, 1:16 PM

Fri, May 31

pino committed R773:b68f1c7089e7: Remove Q_OS_LINUX conditionals for XCB code (authored by pino).
Remove Q_OS_LINUX conditionals for XCB code
Fri, May 31, 7:51 AM
pino committed R773:f99eae979a0b: cmake: use feature_summary() (authored by pino).
cmake: use feature_summary()
Fri, May 31, 7:51 AM

Mon, May 27

pino committed R883:1542768: move few urls to https.
move few urls to https
Mon, May 27, 3:42 AM
pino committed R883:1542767: move few urls to https.
move few urls to https
Mon, May 27, 3:41 AM
pino committed R883:1542766: move few urls to https.
move few urls to https
Mon, May 27, 3:39 AM
pino committed R883:1542765: move few urls to https.
move few urls to https
Mon, May 27, 3:36 AM
pino committed R883:1542764: move few urls to https.
move few urls to https
Mon, May 27, 3:33 AM

Sat, May 25

pino added a comment to D21404: require cmake 3.8 and declare the version into a single place.

Instead of reusing config-upnp-qt.h (whose name seems a bit off, considering what that file contains), IMHO it is better to use a separate version header.
You can use the ECMSetupVersion module from ECM for this.

Sat, May 25, 2:33 PM
pino committed R71:0cd06ec799d9: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Sat, May 25, 5:19 AM
pino committed R71:88ac2b4a1386: cmake: find PostgreSQL 12 (authored by pino).
cmake: find PostgreSQL 12
Sat, May 25, 5:12 AM
pino committed R15:11623c99fdfb: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Sat, May 25, 5:06 AM
pino committed R15:6bba3130f896: cmake: find PostgreSQL 12 (authored by pino).
cmake: find PostgreSQL 12
Sat, May 25, 5:00 AM
pino added a comment to D21091: Try a standardised versioning scheme using KDE Apps version.

You don't need a config-bovo.h file, instead use ECMSetupVersion to generate the version.h file.

Sat, May 25, 4:07 AM

Fri, May 24

pino added a comment to D17760: astyle: support the system astyle library.

Ping?

Fri, May 24, 8:03 PM · KDevelop
pino added a comment to D21306: Add converter from Linux 'perf record'.

A couple of notes:

  • can you please remove the .py extension? the other scripts do not have it
  • what about installing it, just like the other scripts?
  • since it is a new Python script, what about formatting it according to PEP5? (so 4 spaces indentation, 80 chars limit per line, etc)
Fri, May 24, 8:51 AM

Mon, May 20

pino committed R1044:f3b8d44b8cdb: KCM: fix category in desktop file (authored by pino).
KCM: fix category in desktop file
Mon, May 20, 9:57 PM
pino added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Remove [ru] and [x-test] translations from desktop and json files

Mon, May 20, 6:19 AM
pino added inline comments to D21298: Add example app for printing highlighted text to pdf.
Mon, May 20, 5:28 AM · Frameworks, Kate
pino committed R458:b343f96f3993: use https for bugs.kde.org in Report-Msgid-Bugs-To (authored by pino).
use https for bugs.kde.org in Report-Msgid-Bugs-To
Mon, May 20, 5:16 AM

Sun, May 19

pino committed R883:1542116: updates.
updates
Sun, May 19, 4:44 PM
pino added inline comments to D21290: kio_ftp: improve error handling when copying to FTP fails.
Sun, May 19, 1:05 PM · Frameworks
pino committed R883:1542109: use https for bugs.kde.org in Report-Msgid-Bugs-To.
use https for bugs.kde.org in Report-Msgid-Bugs-To
Sun, May 19, 11:08 AM
pino committed R883:1542107: use https for bugs.kde.org in Report-Msgid-Bugs-To.
use https for bugs.kde.org in Report-Msgid-Bugs-To
Sun, May 19, 10:59 AM
pino committed R883:1542106: use https for bugs.kde.org in Report-Msgid-Bugs-To.
use https for bugs.kde.org in Report-Msgid-Bugs-To
Sun, May 19, 10:58 AM
pino committed R883:1542105: use https for bugs.kde.org in Report-Msgid-Bugs-To.
use https for bugs.kde.org in Report-Msgid-Bugs-To
Sun, May 19, 10:56 AM
pino committed R883:1542104: use https for bugs.kde.org in Report-Msgid-Bugs-To.
use https for bugs.kde.org in Report-Msgid-Bugs-To
Sun, May 19, 10:54 AM

Sat, May 18

pino added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.

P.S. If I uderstand it right, this change goes to master and not to Applications/19.04 because of the new translatable string added, though it is only bug fix?

Sat, May 18, 11:35 AM · KDE Applications
pino accepted D21267: Do not crash on wayland, gracefully exit with error instead.

LGTM now, thanks.
Works in X11; I assume you tested it under wayland, right?

Sat, May 18, 11:04 AM · KDE Applications
pino added a comment to D14527: Show hostname in krfb connection info.

This patch does not apply on master now, needs some changes like that:
[...]

Sat, May 18, 11:00 AM
pino added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Btw, please remove all the translations (ru, and x-test) from .desktop, and .json files. There is a system to handle them, so these manually injected ones will be removed the day after this work is merged.

Sat, May 18, 10:18 AM
pino added a comment to D21267: Do not crash on wayland, gracefully exit with error instead.

Another idea is to borrow a small bit from D20402, in particular the change in main() that wraps checkX11Capabilities() within a X11 check: as "else" case for that if, you add the error message added here.
This way, after this is done, D20402 will need to add a no-op check for wayland.

Sat, May 18, 10:15 AM · KDE Applications
pino added inline comments to D21267: Do not crash on wayland, gracefully exit with error instead.
Sat, May 18, 10:12 AM · KDE Applications
pino committed R1045:33c250027913: tests: delete temporary files (authored by pino).
tests: delete temporary files
Sat, May 18, 10:07 AM
pino committed R1045:4a8da89243ae: doc: few easy changes (authored by pino).
doc: few easy changes
Sat, May 18, 9:57 AM
pino committed R1045:baf354fecc84: i18n: simplify markups (authored by pino).
i18n: simplify markups
Sat, May 18, 7:48 AM
pino committed R1045:5a3aa6ca0928: cmake: switch to ECMSetupVersion (authored by pino).
cmake: switch to ECMSetupVersion
Sat, May 18, 7:48 AM
pino committed R1045:ce93898b0908: KTIMETRACKER_VERSION -> KTIMETRACKER_VERSION_STRING (authored by pino).
KTIMETRACKER_VERSION -> KTIMETRACKER_VERSION_STRING
Sat, May 18, 7:48 AM
pino committed R1045:3b7278ca1865: doc: switch to docbook 4.5 (authored by pino).
doc: switch to docbook 4.5
Sat, May 18, 7:48 AM
pino committed R1045:0902670a834e: cmake: restore documentation build (authored by pino).
cmake: restore documentation build
Sat, May 18, 7:48 AM
pino committed R1045:3698514171a5: cmake: lower KF5 requirement to 5.54.0 (authored by pino).
cmake: lower KF5 requirement to 5.54.0
Sat, May 18, 7:48 AM
pino added inline comments to D21267: Do not crash on wayland, gracefully exit with error instead.
Sat, May 18, 7:00 AM · KDE Applications

May 17 2019

pino committed R1044:09e3451af4f6: i18n fixes (authored by pino).
i18n fixes
May 17 2019, 3:55 PM
pino committed R1044:195fc9f70036: i18n: extract kcm messages from js files as well (authored by pino).
i18n: extract kcm messages from js files as well
May 17 2019, 3:55 PM
pino committed R883:1541940: updates.
updates
May 17 2019, 3:55 PM

May 16 2019

pino added inline comments to D21202: [WIP] Support animated PDF.
May 16 2019, 6:27 AM · Okular

May 15 2019

pino committed R883:1541714: new files.
new files
May 15 2019, 9:40 PM
pino committed R883:1541709: new file.
new file
May 15 2019, 9:15 PM

May 13 2019

pino added a comment to D21146: KProcessInfoList -- add proclist backend for FreeBSD.

Gargh, the code kdelibs code formatter changed a lot more in kprocesslist_unix_proc.cpp than wanted :/

May 13 2019, 8:31 PM · Frameworks

May 12 2019

pino added inline comments to D20737: Convert c arrays to std::array.
May 12 2019, 11:21 AM · Dolphin
pino committed R462:ef7aec50fd89: doc: &pdf; -> &PDF; (authored by pino).
doc: &pdf; -> &PDF;
May 12 2019, 5:44 AM
pino committed R462:52afd2dbd513: doc: remove own latex entity (authored by pino).
doc: remove own latex entity
May 12 2019, 5:44 AM
pino added a comment to D21146: KProcessInfoList -- add proclist backend for FreeBSD.

What about create a separate kprocesslist_libprocstat.cpp (or so) to implement KProcessList::processInfoList() using libprocstat, instead of overloading the existing kprocesslist_unix.cpp?

May 12 2019, 4:54 AM · Frameworks

May 11 2019

pino committed R245:280bf18d8ba6: tests: build some tests depending on the used backend (authored by pino).
tests: build some tests depending on the used backend
May 11 2019, 10:11 AM
pino committed R245:97d95e3171c3: Refactor the way device backends are built and registered (authored by pino).
Refactor the way device backends are built and registered
May 11 2019, 10:00 AM
pino closed D17991: Refactor the way device backends are built and registered.
May 11 2019, 10:00 AM · Frameworks

May 9 2019

pino committed R261:d6315b9df8da: Merge remote-tracking branch 'origin/5.0' (authored by pino).
Merge remote-tracking branch 'origin/5.0'
May 9 2019, 8:06 PM
pino committed R261:6bffb7d0d9b6: doc: drop almost all bits related to installation (authored by pino).
doc: drop almost all bits related to installation
May 9 2019, 8:05 PM
pino closed D20389: doc: drop almost all bits related to installation.
May 9 2019, 7:46 PM · Documentation
pino added a comment to D20983: Exclude .gcode and virtual machine files from indexing consideration.

While you are there adding filters, what about:

  • *.qcow2 -- QCOW2 disk images for QEMU
  • *.raw/*.img -- typical extensions for raw disk images (there is no fixed extension, as a raw disk image is just a file with bit-by-bit representation of the disk of a VM)
  • *.vmdk -- VMware disk images
  • *.vhd/*.vhdx -- Hyper-V disk images
May 9 2019, 7:11 PM · Baloo, Frameworks

May 7 2019

pino committed R468:62dc2df53718: appdata: use https for the screenshot (authored by pino).
appdata: use https for the screenshot
May 7 2019, 5:00 AM
pino committed R468:e184352fce78: appdata: fix help URL (authored by pino).
appdata: fix help URL
May 7 2019, 5:00 AM
pino committed R468:9a4058f9cfab: Fix location of temporary lyx pipes (authored by pino).
Fix location of temporary lyx pipes
May 7 2019, 4:53 AM

May 6 2019

pino added inline comments to D20760: Okular Annotation: add support for line ending style for Straight Line tool.
May 6 2019, 6:34 AM · Okular

May 5 2019

pino added inline comments to D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes.
May 5 2019, 6:45 PM · Frameworks
pino added a comment to D21029: UpdatesPage: Don't try to translate version numbers.

The explanation of this change does not match the code changes: the code never translated the version numbers, but it composed a string showing the version numbers before and after the upgrade.
Could it simply be that one of the two (for example installedVersion) is null?

May 5 2019, 9:05 AM · Plasma

May 4 2019

pino added inline comments to D13284: [decorations] Let KDecoration plugins recommend a border size per default.
May 4 2019, 5:59 AM · KWin

May 2 2019

pino requested changes to D20735: [KPropertiesDialog] Add octal permissions.

The permission changes to ktelnetservice5.desktop are unrelated, please revert them.

May 2 2019, 8:32 PM · Frameworks

May 1 2019

pino added inline comments to D20945: KContacts - fix compile warnings .
May 1 2019, 9:29 PM · KDE PIM
pino added a comment to D20933: Increase buffer for cpuinfo.

I don't think that 1024 represents anything here, just the factor to get kibibytes.
So just bump the first value to 64, or even 128.

May 1 2019, 2:57 PM · Plasma
pino accepted D20929: fix compilation to not require filesystem stl c++ header.

Looks ok now, thanks for the changes.

May 1 2019, 2:03 PM · Elisa
pino requested changes to D20735: [KPropertiesDialog] Add octal permissions.

Also, there was feedback it was still not taken care.

May 1 2019, 2:00 PM · Frameworks
pino added inline comments to D20929: fix compilation to not require filesystem stl c++ header.
May 1 2019, 12:45 PM · Elisa
pino added a comment to D20929: fix compilation to not require filesystem stl c++ header.

Or, even better, just unconditionally use QDir::rename? This way there is no need to maintain two different code paths with a number of arbitrary #ifdef blocks.

May 1 2019, 7:27 AM · Elisa

Apr 24 2019

pino requested changes to D20795: Remove warning - modernize: pass an argument by values and use std::move().

Using std::move for these cases is not needed:

  • QString parameters are better passed as const&, so they are not copied nor moved
  • QColor parameters can be passed by value, as they are trivial to copy
Apr 24 2019, 9:59 PM