pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (142 w, 4 d)
Availability
Available

Recent Activity

Yesterday

pino added a comment to D17654: Fix translated text.

However, the whole structure of the messages after 958fdc0a2532e30e7edfd1ec71f63fd3c87b5d35 is a classic case of word puzzles [1]. Anyway. it is better with this patch. So my +1.

Oh I see. I think lines 64-65 in particular violate this rule. Do the translators get to see the actual code, or do they just work with individual strings? In case of the former, I can leave a note to the translators in a comment.

Tue, Dec 18, 5:50 PM · Spectacle

Mon, Dec 17

pino added a comment to D17533: Make the button's purpose more clear.

Regarding the use of bold: please note that using bold in some languages (usually eastern ones) either is not possible, or it does not make sense. So please do not solely rely on it to convey anything.

Mon, Dec 17, 10:32 AM · Plasma

Sun, Dec 16

pino requested changes to D17494: Allow translation of the style plugin names in molecule viewer.
Sun, Dec 16, 10:18 AM · Documentation, KDE Edu
pino added a comment to D17494: Allow translation of the style plugin names in molecule viewer.
In D17494#377816, @pino wrote:

The approach here should be changed: instead of hardcoding the names of plugins in the styleCombo, they ought to be read directly from the sceneModel() of the GL widget. This way:

  1. the strings come directly from avogadro itself, no more need to translate them in kalzium
  2. the list of styles reflects what avogadro provides, so no more mismatch between what is hardcoded in kalzium vs the plugins avogadro has
  3. the documentation of kalzium ought to better not list all the plugins/styles available, since they depend on what avogadro has (mentioning a couple is more than enough, IMHO)

    This also means that more i18n work is needed in avogadro itself.

What is the way to proceed?

Sun, Dec 16, 10:18 AM · Documentation, KDE Edu
pino requested changes to D17494: Allow translation of the style plugin names in molecule viewer.

The approach here should be changed: instead of hardcoding the names of plugins in the styleCombo, they ought to be read directly from the sceneModel() of the GL widget. This way:

  1. the strings come directly from avogadro itself, no more need to translate them in kalzium
  2. the list of styles reflects what avogadro provides, so no more mismatch between what is hardcoded in kalzium vs the plugins avogadro has
  3. the documentation of kalzium ought to better not list all the plugins/styles available, since they depend on what avogadro has (mentioning a couple is more than enough, IMHO)
Sun, Dec 16, 8:49 AM · Documentation, KDE Edu

Sat, Dec 15

pino added inline comments to D17595: Upstream Dolphin's file rename dialog.
Sat, Dec 15, 10:11 PM · Frameworks
pino requested changes to D17494: Allow translation of the style plugin names in molecule viewer.
Sat, Dec 15, 6:45 PM · Documentation, KDE Edu
pino added a comment to D17599: Confirm closing if multiple tabs are open..

Is there a KateTabBar already here?

Sat, Dec 15, 9:42 AM · Kate
pino added a comment to D17599: Confirm closing if multiple tabs are open..

The tab->count() is not giving correct number , any help what may be the problem?

Sat, Dec 15, 9:34 AM · Kate
pino added inline comments to D17595: Upstream Dolphin's file rename dialog.
Sat, Dec 15, 8:01 AM · Frameworks
pino added a comment to D17598: Improve "No internet connection!" error message.

The error message is still not optimal (contractions, not correct spelling of "the Internet", etc).
"Could not load any application; please verify your network connectivity."

Sat, Dec 15, 7:53 AM · Plasma

Mon, Dec 10

pino added a comment to D17494: Allow translation of the style plugin names in molecule viewer.

IMHO it's better if you use the addItem(name, data) API, storing the name of each plugin in the combobox. Then it's easy to fetch the data of the selected item.
Also, the use of QOverload does not belong to this i18n fix, so it needs to be a separate patch.

Mon, Dec 10, 6:47 PM · Documentation, KDE Edu
pino added inline comments to R32:d91e22649ab1: patchreview: Allow to translate string.
Mon, Dec 10, 8:21 AM

Sun, Dec 9

pino committed R40:35da79fcf5f3: fixuifiles (authored by pino).
fixuifiles
Sun, Dec 9, 5:09 AM

Sat, Dec 8

pino added a comment to D17428: ViewManager: Fix I18n_ARGUMENT_MISSING hint in message box when open a very large file.

This ought to be backported to Applications/18.12.

Sat, Dec 8, 1:24 PM · Kate

Fri, Dec 7

pino added a comment to D17396: Add keywords to .desktop file.

Please remove all the translations, since there is an automatic system that takes care of them.

Fri, Dec 7, 8:29 AM · Spectacle

Thu, Dec 6

pino committed R86:d25fa38cc9ec: remove extra check (authored by pino).
remove extra check
Thu, Dec 6, 7:12 AM
pino committed R86:b07dab5fb753: i18n: fix broken English (authored by pino).
i18n: fix broken English
Thu, Dec 6, 7:12 AM

Mon, Dec 3

pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Also, considering that "session" in Core::initialize is user-specified and defaults to an empty string, please do not use a 100% deterministic name, otherwise two different users will have a temporary directory conflict when launching kdevelop. Please use the "XXXXXX" variable part.

Mon, Dec 3, 6:10 AM · KDevelop
pino committed R983:024cab0c05dc: drop extra 'void' for parameter-less methods (authored by pino).
drop extra 'void' for parameter-less methods
Mon, Dec 3, 5:52 AM
pino committed R471:e66f2fedf8bf: i18n: move Messages for libalkimia (authored by pino).
i18n: move Messages for libalkimia
Mon, Dec 3, 5:44 AM
pino committed R471:07051a3d928b: i18n: there are no grantlee themes nor tips (authored by pino).
i18n: there are no grantlee themes nor tips
Mon, Dec 3, 5:44 AM
pino added a reverting change for R471:a9678e609e2d: GIT_SILENT Add new file (after extraction): R471:2caa6430b1fa: Revert "GIT_SILENT Add new file (after extraction)".
Mon, Dec 3, 5:44 AM
pino committed R471:2caa6430b1fa: Revert "GIT_SILENT Add new file (after extraction)" (authored by pino).
Revert "GIT_SILENT Add new file (after extraction)"
Mon, Dec 3, 5:44 AM

Sun, Dec 2

pino committed R876:a5b7cadc7b60: select game: a new game can have no master set yet (authored by pino).
select game: a new game can have no master set yet
Sun, Dec 2, 10:13 PM
pino committed R425:3c6e20f9aeba: Merge remote-tracking branch 'origin/Applications/18.12' (authored by pino).
Merge remote-tracking branch 'origin/Applications/18.12'
Sun, Dec 2, 3:01 PM
pino committed R425:8e0f03559e25: Delay creation of QTextToSpeech (authored by pino).
Delay creation of QTextToSpeech
Sun, Dec 2, 3:00 PM

Tue, Nov 27

pino committed R37:73524bf58d4a: Fix Exec for krita_jpeg.desktop (authored by pino).
Fix Exec for krita_jpeg.desktop
Tue, Nov 27, 10:15 PM

Mon, Nov 26

pino committed R74:043ab720ca45: Merge branch '1.4' (authored by pino).
Merge branch '1.4'
Mon, Nov 26, 7:48 PM
pino committed R74:8ad500134416: Fix installation of clazy wrapper scripts (authored by pino).
Fix installation of clazy wrapper scripts
Mon, Nov 26, 7:48 PM

Nov 18 2018

pino committed R469:f9ab9aa9e411: Remove code to support Qt < 5.7 (authored by pino).
Remove code to support Qt < 5.7
Nov 18 2018, 2:32 PM
pino committed R240:96d169b87292: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core (authored by pino).
FindQHelpGenerator: try to find Qt5Help instead of Qt5Core
Nov 18 2018, 9:33 AM
pino closed D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core.
Nov 18 2018, 8:57 AM · Build System, Frameworks

Nov 17 2018

pino requested review of D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core.
Nov 17 2018, 8:01 AM · Build System, Frameworks

Nov 15 2018

pino committed R883:1528409: no WLM nor Yahoo anymore.
no WLM nor Yahoo anymore
Nov 15 2018, 10:25 PM
pino committed R883:1528408: no WLM nor Yahoo anymore.
no WLM nor Yahoo anymore
Nov 15 2018, 10:25 PM

Nov 13 2018

pino committed R883:1528295: drop obsolete unused messages.
drop obsolete unused messages
Nov 13 2018, 2:49 PM
pino committed R262:5c2c6a1dc1c4: fixuifiles (authored by pino).
fixuifiles
Nov 13 2018, 6:38 AM

Nov 12 2018

pino committed R883:1528209: copy calligra stuff for calligraplan.
copy calligra stuff for calligraplan
Nov 12 2018, 6:22 AM
pino committed R37:98de1e6769a2: fixuifiles (authored by pino).
fixuifiles
Nov 12 2018, 6:21 AM

Nov 10 2018

pino added a comment to D16799: fixing inbox detection.

Also: the BUG: NNN ought to be in a new line on its own, not in the title of the commit (i.e. the first line).

Nov 10 2018, 12:55 PM · KDE PIM
pino added inline comments to D16799: fixing inbox detection.
Nov 10 2018, 12:31 PM · KDE PIM

Nov 8 2018

pino committed R216:39a08c070d34: debchangelog: add Disco Dingo (authored by pino).
debchangelog: add Disco Dingo
Nov 8 2018, 7:40 AM

Nov 3 2018

pino committed R37:cdaf8913593b: krita_qimageio.desktop: Fix MimeType separators (authored by asturmlechner).
krita_qimageio.desktop: Fix MimeType separators
Nov 3 2018, 3:26 PM

Nov 1 2018

pino added a comment to D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript.

Please answer why you consider running a full blown postscript interpreter in an uncontrolled environment (no sandboxing, runs without user interaction) is better than 20 code lines of trivial text parsing.

Nov 1 2018, 6:31 PM · Baloo, Frameworks

Oct 30 2018

pino added a comment to D16134: Secure history file.

@pino, but you had just said that "KF5 plasma does not use qca, the code for that was dropped as dead/unmaintained".

Oct 30 2018, 11:55 AM · Konsole

Oct 29 2018

pino added a comment to D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript.
In D16498#350422, @pino wrote:
In D16498#350286, @pino wrote:

Ugh no manual parsing of PS files -- please use libspectre.

This is not Postscript parsing, but DSC parsing - read the specification to understand the difference!

http://www.lprng.com/RESOURCES/ADOBE/5001.DSC_Spec.pdf

An EPS file is also a PostScript file, and indeed ghostscript opens it perfectly

  • also **
Oct 29 2018, 12:02 PM · Baloo, Frameworks
pino added a comment to D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript.
In D16498#350286, @pino wrote:

Ugh no manual parsing of PS files -- please use libspectre.

This is not Postscript parsing, but DSC parsing - read the specification to understand the difference!

http://www.lprng.com/RESOURCES/ADOBE/5001.DSC_Spec.pdf

Oct 29 2018, 10:59 AM · Baloo, Frameworks
pino requested changes to D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript.

Ugh no manual parsing of PS files -- please use libspectre.

Oct 29 2018, 9:17 AM · Baloo, Frameworks

Oct 28 2018

pino committed R468:1c9e6ff642b7: no need to declare "void" functions with no parameters (authored by pino).
no need to declare "void" functions with no parameters
Oct 28 2018, 4:59 PM
pino requested changes to D15645: Add scheme selection menu with a "System" entry..
Oct 28 2018, 4:45 AM · Frameworks

Oct 26 2018

pino added a comment to D16388: Fix build with poppler 0.69.

Build failure:

Oct 26 2018, 7:05 AM · Calligra: 3.0

Oct 24 2018

pino requested changes to D16406: Fix build with poppler<0.64.

Please do a feature test at cmake time instead.

Oct 24 2018, 5:01 PM · Calligra: 3.0

Oct 22 2018

pino committed R883:1526972: update.
update
Oct 22 2018, 7:19 AM
pino committed R883:1526971: updates.
updates
Oct 22 2018, 7:00 AM

Oct 21 2018

pino requested changes to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Not sure why I was added as reviewer... anyway:

  • no need to use this-> to call own class members, unless there is a conflict (which does not look like)
  • please never hardcode colors! use KColorScheme instead
  • it does not seem that the palette is reverted back when the space changes to less than the threshold
Oct 21 2018, 4:03 PM · Dolphin

Oct 20 2018

pino committed R321:16e301823538: fixuifiles (authored by pino).
fixuifiles
Oct 20 2018, 6:05 AM

Oct 19 2018

pino added a comment to D16191: Don't save to a temp file if exporting to another app.

@pino 👌 , so what would be the preferred way to fix those small but eventually-needed changes?

Oct 19 2018, 9:02 AM · Spectacle
pino added inline comments to D16191: Don't save to a temp file if exporting to another app.
Oct 19 2018, 8:26 AM · Spectacle
pino committed R883:1526849: remove backup file.
remove backup file
Oct 19 2018, 8:08 AM

Oct 16 2018

pino requested changes to D16258: plasma-pk-updates Hungarian support.

Hi Charles,

Oct 16 2018, 7:22 PM · Plasma

Oct 15 2018

pino committed R466:a32a55f15964: doc: typo fix (authored by pino).
doc: typo fix
Oct 15 2018, 6:29 AM
pino committed R883:1526610: typo fix.
typo fix
Oct 15 2018, 5:59 AM
pino added a comment to D16134: Secure history file.

I think I can replace QCA with libssl (that is used by libqt5network5) at some point during the next week or two.

Oct 15 2018, 4:30 AM · Konsole

Oct 13 2018

pino added a comment to D16134: Secure history file.

@hindenburg, I'm using Debian Buster and apt-cache shows that kde-runtime depends on libplasma3 that depends on libqca2.

Oct 13 2018, 5:05 PM · Konsole
pino added a comment to D16169: Add option to close Kate when last file closes.

*personally* I'd hate it to be the default, since clearing all the open files to get an empty one where i can write is something i do several times a day.

Oct 13 2018, 5:01 PM · Kate
pino committed R263:2c0c959f35d7: KAboutApplicationDialog: fix typo in apidox (authored by pino).
KAboutApplicationDialog: fix typo in apidox
Oct 13 2018, 2:38 PM
pino added a comment to D16164: Specifying http protocol when getting Open Sans font to fix Scripting API.

I don't like that. What happens if the person is not int he internet? can you remove that url completely and see if it works?
*if* it works, I'd rather remove the need to be on the internet.

Oct 13 2018, 9:23 AM · KDE Edu

Oct 12 2018

pino accepted D16150: Add Messages.sh for KIO slave.

to Applications/18.08 please :)

Oct 12 2018, 7:43 AM
pino added a comment to D16150: Add Messages.sh for KIO slave.

This could go into stable branch, I guess?

Oct 12 2018, 7:06 AM
pino added a comment to D16150: Add Messages.sh for KIO slave.

Even if the kioslave is still called "kio_kamera", and not installed in a kf5-specific directory, can you please use "kio5_kamera" as catalog name?
This way it will be slightly more future-proof, and one step less from potential parallel installation with a future KF6.

Oct 12 2018, 7:06 AM
pino added a comment to D15997: Make KPimGAPI optional.

KMailTransport is a PIM library in the first place. PIM already depends on WebEngine, so I'm not much in favor of this change, sorry.

Oct 12 2018, 5:31 AM · KDE PIM
pino added a comment to D16132: Refactored some casts.

This patch was splitted from D16120 because he was trying to create different reviews for different changes. Were you asking for it, no?

Oct 12 2018, 5:22 AM · KDE Edu

Oct 11 2018

pino committed R326:8a57afc64002: Revert "Refactored some casts" (authored by pino).
Revert "Refactored some casts"
Oct 11 2018, 10:10 PM
pino added a reverting change for R326:06940c77181a: Refactored some casts: R326:8a57afc64002: Revert "Refactored some casts".
Oct 11 2018, 10:10 PM
pino added a comment to D16132: Refactored some casts.

@filipesaraiva are you even reviewing this stuff? OK, let me revert it, so it can be done properly

Oct 11 2018, 10:09 PM · KDE Edu
pino requested changes to D16132: Refactored some casts.

I don't see why this was split from D16120: Changed old style casts -- please move these changed there, and abandon this revision.

Oct 11 2018, 10:07 PM · KDE Edu
pino requested changes to D16120: Changed old style casts.

please remove the mention of changes different than old style casts in the commit message

Oct 11 2018, 4:42 AM · KDE Edu

Oct 10 2018

pino accepted D16039: Fix compilation issues on Windows.

Seems OK for me -- wait a bit in case the other reviewers have concerns.

Oct 10 2018, 6:24 AM · KDE Edu
pino added a comment to D16039: Fix compilation issues on Windows.

@sdepiets for the sake of completeness, can you please tell what the issue were with compiling (or rather linking?) on windows?

The problem was with lib/test and python/backend libraries sharing the same export flag than lib.

Oct 10 2018, 5:01 AM · KDE Edu

Oct 9 2018

pino committed R32:ce4b5afe3802: i18n: do not extract messages from 'tests' subdirs (authored by pino).
i18n: do not extract messages from 'tests' subdirs
Oct 9 2018, 12:55 PM
pino committed R32:3512c5e9641a: cmake: find and use boost (authored by pino).
cmake: find and use boost
Oct 9 2018, 12:54 PM
pino committed R157:18e6cda7417f: i18n: typo fixes (authored by pino).
i18n: typo fixes
Oct 9 2018, 5:26 AM
pino committed R883:1526109: update.
update
Oct 9 2018, 5:26 AM
pino requested changes to D16039: Fix compilation issues on Windows.

please amend the commit message to not mention the <repository.h> changes

Oct 9 2018, 4:57 AM · KDE Edu

Oct 8 2018

pino committed R883:1526071: typo fix.
typo fix
Oct 8 2018, 6:10 PM
pino requested changes to D16039: Fix compilation issues on Windows.

please remove all the <repository.h> changes from this patch, since they are nothing to do with the actual export fixes

Oct 8 2018, 5:48 PM · KDE Edu
pino committed R468:7cfc3f74f00d: User menu: do not attempt to load an empty file name (authored by pino).
User menu: do not attempt to load an empty file name
Oct 8 2018, 5:44 AM

Oct 7 2018

pino committed R883:1526007: minor updates.
minor updates
Oct 7 2018, 9:55 PM
pino committed R468:e1ba32fec4be: i18n: fix few string puzzles (authored by pino).
i18n: fix few string puzzles
Oct 7 2018, 6:01 PM
pino committed R883:1525992: updates.
updates
Oct 7 2018, 4:24 PM
pino committed R883:1525991: remove useless obsolete messages.
remove useless obsolete messages
Oct 7 2018, 4:03 PM
pino committed R310:97734ba8297a: ktextedit: lazy load the QTextToSpeech object (authored by pino).
ktextedit: lazy load the QTextToSpeech object
Oct 7 2018, 2:13 PM
pino closed D16001: ktextedit: lazy load the QTextToSpeech object.
Oct 7 2018, 2:13 PM · Frameworks
pino added inline comments to D16002: QUrl.toString() is not a valid local file.
Oct 7 2018, 12:10 PM
pino committed R344:c9b35d4f9a53: WebImageFetcher: check better last.fm results (authored by pino).
WebImageFetcher: check better last.fm results
Oct 7 2018, 11:55 AM
pino committed R344:c43602856b60: Merge remote-tracking branch 'origin/Applications/18.08' (authored by pino).
Merge remote-tracking branch 'origin/Applications/18.08'
Oct 7 2018, 11:46 AM
pino committed R344:441cb735dd34: WebImageFetcher: properly destroy dialog after any request (authored by pino).
WebImageFetcher: properly destroy dialog after any request
Oct 7 2018, 11:30 AM
pino added a comment to D15997: Make KPimGAPI optional.

What other components outside of Kontact/KDE PIM depend on KMailTransport?

Oct 7 2018, 10:22 AM · KDE PIM
pino requested review of D16001: ktextedit: lazy load the QTextToSpeech object.
Oct 7 2018, 10:17 AM · Frameworks