pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (151 w, 4 d)
Availability
Available

Recent Activity

Sun, Feb 17

pino added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.

The workaround isn't required everywhere, just in a small number of places.

Sun, Feb 17, 9:08 AM · Frameworks
pino updated subscribers of D17991: Refactor the way device backends are built and registered.
Sun, Feb 17, 7:54 AM · Frameworks
pino updated the diff for D17991: Refactor the way device backends are built and registered.

Hopefully rebase on master.

Sun, Feb 17, 7:38 AM · Frameworks
pino updated the diff for D17991: Refactor the way device backends are built and registered.

Rebased on master.

Sun, Feb 17, 7:37 AM · Frameworks

Sat, Feb 16

pino added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.

Wait, do we need to add this workaround to every popup menu around? What about 3d-party apps?

Sat, Feb 16, 8:54 PM · Frameworks

Wed, Feb 13

pino added inline comments to D18977: Polish KDE SDK appstream data.
Wed, Feb 13, 5:31 AM

Tue, Feb 12

pino committed R262:cb119da37356: fixuifiles (authored by pino).
fixuifiles
Tue, Feb 12, 6:02 AM

Sun, Feb 10

pino updated subscribers of D18770: [KStatusNotifierItem] use fallback sizes when none is available.

@davidedmundson any idea about this?

Sun, Feb 10, 12:00 PM · Frameworks
pino added inline comments to D18866: Use check_symbol_exists instead of check_function_exists.
Sun, Feb 10, 11:14 AM · Calligra: 3.0
pino committed R167:ca29822064ac: i18n: move URL out of message (authored by pino).
i18n: move URL out of message
Sun, Feb 10, 10:53 AM

Sat, Feb 9

pino added a comment to D18882: [Image Thumbnailer] Support eps files.

But that will create additional, potentially defunct entries in Previewer settings?

Sat, Feb 9, 11:03 PM · Frameworks, Dolphin
pino added a comment to D18883: Add PDF thumbnailer.

Conceptually I think it makes sense to have all the thumbnailers in their own package so it's easy to remove them all if for people who really don't want them.

Sat, Feb 9, 11:02 PM · Frameworks, Dolphin
pino added a comment to D18882: [Image Thumbnailer] Support eps files.

Then just ship a desktop file for that format in kimageformats:

  • if kio-extras is not installed, that desktop file will be unused (although just a couple of kilobytes on disk)
  • if ko-extras is installed, it will register PS as thumbnail format using imagethumbnail
Sat, Feb 9, 10:52 PM · Frameworks, Dolphin
pino added a comment to D18882: [Image Thumbnailer] Support eps files.

OTOH this will not work if kimageformats is not installed, and the thumbnailer gives no hint about that.

Sat, Feb 9, 10:34 PM · Frameworks, Dolphin
pino added inline comments to D18883: Add PDF thumbnailer.
Sat, Feb 9, 10:00 PM · Frameworks, Dolphin
pino added inline comments to D18883: Add PDF thumbnailer.
Sat, Feb 9, 8:10 PM · Frameworks, Dolphin
pino added a comment to D18852: Add mime types for raw image formats to desktop file.

Please do not add the translations manually, as they are handled by scripty automatically.

Sat, Feb 9, 2:06 PM · Gwenview

Fri, Feb 8

pino committed R514:70587b4edd10: python: exclude the embedded PyCXX from krazy checks (authored by pino).
python: exclude the embedded PyCXX from krazy checks
Fri, Feb 8, 10:37 PM
pino committed R514:d350f27d4988: python: bump PyCXX to 7.1.0 (authored by pino).
python: bump PyCXX to 7.1.0
Fri, Feb 8, 10:37 PM
pino committed R514:d837a8c06c4a: python: simplify dicts comparisons (authored by pino).
python: simplify dicts comparisons
Fri, Feb 8, 9:52 PM
pino committed R514:05b9267dc9da: python: modernize usage of assert_() (authored by pino).
python: modernize usage of assert_()
Fri, Feb 8, 9:52 PM
pino committed R514:0517b41cdacc: python: initialize PythonExtension only once (authored by pino).
python: initialize PythonExtension only once
Fri, Feb 8, 9:52 PM
pino committed R514:babf591eb414: python: use a decorator to skip tests based on imports (authored by pino).
python: use a decorator to skip tests based on imports
Fri, Feb 8, 9:52 PM
pino committed R514:af272429cca4: python: PEP8 whitespace changes (authored by pino).
python: PEP8 whitespace changes
Fri, Feb 8, 9:52 PM
pino committed R514:73104079db5b: python: PEP8 empty lines (authored by pino).
python: PEP8 empty lines
Fri, Feb 8, 9:52 PM
pino added a comment to D18606: [WIP]Close tab on middle mouse button event.

I've been against this in the past - it is too easy to accidentally close a tab. Unlike other KDE apps, accidentally closing a Konsole tab would be really bad IMHO.

Fri, Feb 8, 8:30 AM · Konsole
pino added a comment to D18836: Make the button tooltips on the "Configure Virtual Desktops" page translatable.

Please leave the existing context, so there is no string change, and this can be fixed in stable branches (in case it applies there).

Fri, Feb 8, 7:31 AM · KWin

Tue, Feb 5

pino requested review of D18770: [KStatusNotifierItem] use fallback sizes when none is available.
Tue, Feb 5, 9:52 PM · Frameworks

Mon, Feb 4

pino committed R514:ec19c6b14db8: cmake: remove unused PythonMacros.cmake (authored by pino).
cmake: remove unused PythonMacros.cmake
Mon, Feb 4, 9:12 PM

Thu, Jan 31

pino committed R883:1534331: followup kdiff3 move to extragear.
followup kdiff3 move to extragear
Thu, Jan 31, 6:29 AM
pino committed R883:1534330: SVN_SILENT remove extra space.
SVN_SILENT remove extra space
Thu, Jan 31, 6:27 AM

Tue, Jan 29

pino added a comment to D18571: Add "apply on double-click" feature to most other recent ported KCMs.

-1 for this:

  • hidden feature
  • it does not make sense when the general paradigm is OK/Apply/Cancel, so we are teaching users that options are applied only when OK/Apply is pressed (and thus they are left free to play with options as they fit)
  • if an user accidentally double-clicks, then the options are saved a) against the user choice b) with no feedback at all
Tue, Jan 29, 5:45 AM · Plasma
pino committed R120:2d78b169cd67: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by pino).
Merge remote-tracking branch 'origin/Plasma/5.15'
Tue, Jan 29, 5:08 AM
pino committed R120:b5787215e6a6: Merge remote-tracking branch 'origin/Plasma/5.12' into Plasma/5.15 (authored by pino).
Merge remote-tracking branch 'origin/Plasma/5.12' into Plasma/5.15
Tue, Jan 29, 4:53 AM

Mon, Jan 28

pino committed R120:65f3a9610f44: StatusItemNotifier: fix overlays by name with icons by name (authored by pino).
StatusItemNotifier: fix overlays by name with icons by name
Mon, Jan 28, 8:54 PM
pino closed D17983: StatusItemNotifier: fix overlays by name with icons by name.
Mon, Jan 28, 8:52 PM · Plasma
pino added a comment to D17760: astyle: support the system astyle library.

do we have custom patches in our libastyle?

Mon, Jan 28, 8:28 PM · KDevelop
pino added a comment to D17760: astyle: support the system astyle library.

ping?

Mon, Jan 28, 7:18 AM · KDevelop
pino added a comment to D17991: Refactor the way device backends are built and registered.

ping?

Mon, Jan 28, 7:18 AM · Frameworks
pino added a comment to D17983: StatusItemNotifier: fix overlays by name with icons by name.
In D17983#388160, @pino wrote:

Thanks -- which branch should I push this to? Plasma/5.12, Plasma/5.14, or only master for now?

Mon, Jan 28, 7:18 AM · Plasma

Sun, Jan 27

pino committed R878:788e7ad4d905: fix project_license in appstream file (authored by pino).
fix project_license in appstream file
Sun, Jan 27, 7:58 AM
pino committed R878:72341142a2ff: fix project_license in appstream file (authored by pino).
fix project_license in appstream file
Sun, Jan 27, 7:58 AM

Jan 20 2019

pino committed R983:6c7b0fd8c46f: i18n: avoid string puzzles (authored by pino).
i18n: avoid string puzzles
Jan 20 2019, 8:22 PM
pino added inline comments to D18224: Clang Plugin: Report some problems from included files.
Jan 20 2019, 7:35 PM · KDevelop
pino added a comment to D18384: Allow creating directory named '~' and throw a warning before creating it..

Ah yes, now I see it better, the whole KMessageBox::shouldBeShownContinue() check is bogus, since that key is not set by anything.

Jan 20 2019, 3:04 PM · Frameworks
pino added a comment to D18384: Allow creating directory named '~' and throw a warning before creating it..

@pino got it what you meant.

Jan 20 2019, 2:37 PM · Frameworks
pino added inline comments to D17739: Add a po file for the list of words in GCompris.
Jan 20 2019, 2:22 PM · KDE Edu, GCompris
pino added inline comments to D17739: Add a po file for the list of words in GCompris.
Jan 20 2019, 2:13 PM · KDE Edu, GCompris
pino added inline comments to D18384: Allow creating directory named '~' and throw a warning before creating it..
Jan 20 2019, 1:58 PM · Frameworks
pino added a comment to D18384: Allow creating directory named '~' and throw a warning before creating it..

Also, not related to the code: @shubham, you seem to often remove your own comments. This is a bad practice for many POV of views (transparency, breaks the logic of a conversation, etc). As these reviews send notification emails to mailing lists usually, then your removed messages are archived, and thus removing them is useless.
Please stop doing this anti-social practice, thank you.

Jan 20 2019, 1:53 PM · Frameworks
pino committed R983:69137f5199b1: remove unused pixmaps (authored by pino).
remove unused pixmaps
Jan 20 2019, 9:16 AM

Jan 19 2019

pino added a comment to D18394: Add OTP support for openconnect VPN.

Hi Enrique,

Jan 19 2019, 10:31 PM · Plasma
pino committed R983:17e52c0d1b25: make desktop file executable (authored by pino).
make desktop file executable
Jan 19 2019, 7:23 PM
pino committed R983:ae80f4e89096: cmake: fix installation of appdata file (authored by pino).
cmake: fix installation of appdata file
Jan 19 2019, 7:23 PM

Jan 17 2019

pino added a comment to D18317: Display an error message if loading a dictionary fails.
In D18317#395513, @pino wrote:

This makes a "core" library grow a dependency on widgets -- not really a good idea, considering there is the sonnetui library for that.

Jan 17 2019, 10:30 PM · Frameworks
pino added a comment to D18317: Display an error message if loading a dictionary fails.

This makes a "core" library grow a dependency on widgets -- not really a good idea, considering there is the sonnetui library for that.

Jan 17 2019, 10:22 PM · Frameworks

Jan 16 2019

pino committed R32:e9dbb09fe3a2: fixuifiles (authored by pino).
fixuifiles
Jan 16 2019, 8:54 PM

Jan 14 2019

pino committed R983:a4da2fd353a6: do not use the description as "other text" (authored by pino).
do not use the description as "other text"
Jan 14 2019, 10:11 PM
pino committed R983:2cdb6070b730: qMin/qMax -> std::min/std::max (authored by pino).
qMin/qMax -> std::min/std::max
Jan 14 2019, 9:50 PM
pino committed R983:e8a10a63ca1b: Rewrite min3/max3 using <algorithm> (authored by pino).
Rewrite min3/max3 using <algorithm>
Jan 14 2019, 9:50 PM
pino committed R983:d2adce79f136: minMaxLimiter -> qBound (authored by pino).
minMaxLimiter -> qBound
Jan 14 2019, 9:50 PM

Jan 12 2019

pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Though probably it's going to be enough for now to set TMPDIR temporarily in the background thread where we launch the parse job via libclang?

Jan 12 2019, 12:22 PM · KDevelop

Jan 8 2019

pino added inline comments to D17955: Skanlite may create missing output directories automtically (with user's permission).
Jan 8 2019, 10:27 AM
pino added a comment to D17853: Add a CMake option for ASAN address sanitizer.

Just noticed this... note that ECM already provides it: https://api.kde.org/ecm/module/ECMEnableSanitizers.html

Jan 8 2019, 10:10 AM · Krita
pino added a comment to R858:e1ec36138c99: Minor: Use nullptr.

@kfunk see the notes please

Jan 8 2019, 7:31 AM

Jan 7 2019

pino added inline comments to D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector.
Jan 7 2019, 5:51 PM · Frameworks
pino added inline comments to D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector.
Jan 7 2019, 5:24 PM · Frameworks
pino added a comment to D17983: StatusItemNotifier: fix overlays by name with icons by name.

Thanks -- which branch should I push this to? Plasma/5.12, Plasma/5.14, or only master for now?

Jan 7 2019, 3:58 PM · Plasma
pino added inline comments to D17983: StatusItemNotifier: fix overlays by name with icons by name.
Jan 7 2019, 3:47 PM · Plasma
pino added a comment to D17790: Port away from QCA.

Using the command line tool means this is a runtime dependency only. You could run kdeconnect without having openssl installed and it would fail mysteriously.

We can either check that it exists and output a specific error, or change to a compile-time dependency (libopenssl? Not sure if it exists).

I'm not sure I'm understanding the conversation. The library is called libssl. It's apparently a little complicated to use, but there is a good StackOverflow example of how it is done: https://stackoverflow.com/questions/256405/programmatically-create-x509-certificate-using-openssl

Jan 7 2019, 11:10 AM · KDE Connect
pino added a comment to D17533: Make the button's purpose more clear.

I'm personally still not convinced about the usage of the bold for questions, as I wrote in an earlier comment.
The rest is not up to me.

Jan 7 2019, 10:47 AM · Plasma
pino removed a reviewer for D18035: Fix two-digit year formats issue: do not allow by default: pino.
Jan 7 2019, 10:07 AM · KEXI
pino added inline comments to D18018: [Digital Clock] Add ability to change first day of week.
Jan 7 2019, 9:47 AM · Plasma

Jan 5 2019

pino added a comment to D17991: Refactor the way device backends are built and registered.

This is tested so far only on Linux, where the cmake output for the device backends is:

Jan 5 2019, 4:23 PM · Frameworks
pino requested review of D17991: Refactor the way device backends are built and registered.
Jan 5 2019, 4:19 PM · Frameworks
pino committed R773:278a0d415ccd: Use ecm_setup_version (authored by pino).
Use ecm_setup_version
Jan 5 2019, 2:39 PM
pino committed R773:bec80b680b33: i18n: avoid string puzzles (authored by pino).
i18n: avoid string puzzles
Jan 5 2019, 2:38 PM
pino added a comment to D17971: Revive External Tools plugin.

Can you please add a "kate" prefix to the message catalog? See TRANSLATION_DOMAIN in CMakeLists.txt, and Messages.sh.

Jan 5 2019, 11:52 AM · Kate
pino requested review of D17983: StatusItemNotifier: fix overlays by name with icons by name.
Jan 5 2019, 10:33 AM · Plasma

Jan 4 2019

pino added a comment to D17956: DocumentPrivate: Fix broken doc links in qCWarning.

Also, I do not understand why a console warning is translated: normal users will not see it, and if they do the message is not actionable for them.

Jan 4 2019, 11:15 AM · Frameworks, Kate
pino committed R773:ab9df5a6828f: Remove wrong TRANSLATION_DOMAIN (authored by pino).
Remove wrong TRANSLATION_DOMAIN
Jan 4 2019, 11:11 AM
pino committed R773:f4238196865f: i18n: make preparetips script executable (authored by pino).
i18n: make preparetips script executable
Jan 4 2019, 11:11 AM
pino committed R773:9864e80ca00e: i18n: improve tips extraction (authored by pino).
i18n: improve tips extraction
Jan 4 2019, 11:11 AM

Jan 3 2019

pino added a comment to D17816: Support for xattrs on kio copy/move.

Nice progresses, thanks for the fixes. I added few more notes, just mentioning the first occurrence of each.
One more thing is to print errno (and possibly its string representation using strerror/strerror_r) on failure, so that the debugging is easier.

Jan 3 2019, 1:37 PM · Frameworks

Jan 1 2019

pino added a comment to D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17).

I don't understand what is tested in KDbTestUtils::testDriver() now, related to the mimetypes. The old logic looked better (and simpler too) to me, I'd just leave that.
The only simple addition IMHO is that manager.driverIdsForMimeType(mimeName) returns a valid driver for each of the mimetypes specified in the plugin metadata.

Jan 1 2019, 9:52 PM · KDb
pino added a comment to D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17).
In D17887#384687, @pino wrote:

Shorter: what change in kdb_sqlitedriver.json do you propose?

With the draft of patch I proposed, none.

OK but that means you propose to revert change for the json or keeping the change as is?

Jan 1 2019, 7:25 PM · KDb
pino added a comment to D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17).

Shorter: what change in kdb_sqlitedriver.json do you propose?

Jan 1 2019, 5:53 PM · KDb
pino added a comment to D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17).

If I understand correctly if we do not explicitly list "application/vnd.sqlite3" in the JSON, current FD.o master https://cgit.freedesktop.org/xdg/shared-mime-info/commit/freedesktop.org.xml.in?id=36a88b01f6ae90da35a2f6a072db159c84cea768 resolves "application/vnd.sqlite3" into "application/x-kexiproject-sqlite3" only if we go to parent mime type "application/x-sqlite3" which is alias of real parent "application/vnd.sqlite3". I see that "application/x-kexiproject-sqlite3" has room for improvements. I do not see that we use QMimeType::parentMimeTypes().

Jan 1 2019, 4:26 PM · KDb
pino removed a reviewer for D17872: Use forward declaration for Exiv2::Image, port to std::unique_ptr: pino.
Jan 1 2019, 2:59 AM · Gwenview

Dec 31 2018

pino added a comment to D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17).

OK, second attempt (still untested!), resolving mimetypes on lookup:

Dec 31 2018, 5:39 PM · KDb
pino added a comment to D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17).

Ah your test is for something else than I wrote above and might be useful but I just learned that we never know (like in the case of the linked FD.o change) what happens on user's OS and whether the OS provide type alias or regular type as a result of detection. So I'd be safer if we handle all mime types and aliases declared by the plugins.

Dec 31 2018, 5:31 PM · KDb
pino added a comment to D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17).
In D17887#384384, @pino wrote:

The QSet is used to avoid that the same metadats is registered twice in m_metadata_by_mimetype for the same mimetype, in case a plugin specifies two entries (mime name and one alias of it).

Thanks. Interesting though m_metadata_by_mimetype.insertMulti(mimeType, metaData.data()) is used for a purpose, it's valid case to have multiple plugins supporting the same type.

Dec 31 2018, 5:26 PM · KDb
pino added a comment to D17887: Fix detection of .kexi file types after recent change of mime database on Linux for SQLite type (2018-06-17).

Another option could be to resolve the mimetypes when loading the metadata of the plugins, in DriverManagerInternal::lookupDriversInternal().

Dec 31 2018, 4:47 PM · KDb

Dec 30 2018

pino added a comment to D17816: Support for xattrs on kio copy/move.

general notes:

  • NULL -> nullptr
  • there is not just glibc
  • the changes to file_unix.cpp seem unrelated to you patch now, so better split them in an own patch
  • use constData() instead of data() every time the data needed is read-only
Dec 30 2018, 6:49 PM · Frameworks

Dec 28 2018

pino added inline comments to D17810: Fix building against exiv2-0.27.
Dec 28 2018, 12:22 AM · Krita

Dec 27 2018

pino committed R245:3aae548ccc8c: Use nullptr in more places (authored by pino).
Use nullptr in more places
Dec 27 2018, 1:13 PM
pino committed R245:bf0a8c1ecac4: lexer: disable input and unput functions (authored by pino).
lexer: disable input and unput functions
Dec 27 2018, 1:04 PM
pino committed R245:b7606cb68b05: Use nullptr in more places (authored by pino).
Use nullptr in more places
Dec 27 2018, 1:04 PM

Dec 26 2018

pino added a comment to D17810: Fix building against exiv2-0.27.

TBH inverting all the EXIV2_TEST_VERSION(...) conditions will avoid swapping all the code branches for old and new exiv2, reducing the diff of this patch.

Dec 26 2018, 4:07 PM · Krita
pino added a comment to T8630: Release 2.6.

@asemke please update this task before editing it, because most probably you keep re-subscribing me to this task

Dec 26 2018, 11:46 AM · LabPlot