- User Since
- Mar 25 2016, 4:10 PM (142 w, 4 d)
Mon, Dec 17
Regarding the use of bold: please note that using bold in some languages (usually eastern ones) either is not possible, or it does not make sense. So please do not solely rely on it to convey anything.
Sun, Dec 16
The approach here should be changed: instead of hardcoding the names of plugins in the styleCombo, they ought to be read directly from the sceneModel() of the GL widget. This way:
- the strings come directly from avogadro itself, no more need to translate them in kalzium
- the list of styles reflects what avogadro provides, so no more mismatch between what is hardcoded in kalzium vs the plugins avogadro has
- the documentation of kalzium ought to better not list all the plugins/styles available, since they depend on what avogadro has (mentioning a couple is more than enough, IMHO)
Sat, Dec 15
The error message is still not optimal (contractions, not correct spelling of "the Internet", etc).
"Could not load any application; please verify your network connectivity."
Mon, Dec 10
IMHO it's better if you use the addItem(name, data) API, storing the name of each plugin in the combobox. Then it's easy to fetch the data of the selected item.
Also, the use of QOverload does not belong to this i18n fix, so it needs to be a separate patch.
Sun, Dec 9
Sat, Dec 8
This ought to be backported to Applications/18.12.
Fri, Dec 7
Please remove all the translations, since there is an automatic system that takes care of them.
Thu, Dec 6
Mon, Dec 3
Also, considering that "session" in Core::initialize is user-specified and defaults to an empty string, please do not use a 100% deterministic name, otherwise two different users will have a temporary directory conflict when launching kdevelop. Please use the "XXXXXX" variable part.
Sun, Dec 2
Tue, Nov 27
Mon, Nov 26
Nov 18 2018
Nov 17 2018
Nov 15 2018
Nov 13 2018
Nov 12 2018
Nov 10 2018
Also: the BUG: NNN ought to be in a new line on its own, not in the title of the commit (i.e. the first line).
Nov 8 2018
Nov 3 2018
Nov 1 2018
Oct 30 2018
Oct 29 2018
Ugh no manual parsing of PS files -- please use libspectre.
Oct 28 2018
Oct 26 2018
Oct 24 2018
Please do a feature test at cmake time instead.
Oct 22 2018
Oct 21 2018
Not sure why I was added as reviewer... anyway:
- no need to use this-> to call own class members, unless there is a conflict (which does not look like)
- please never hardcode colors! use KColorScheme instead
- it does not seem that the palette is reverted back when the space changes to less than the threshold
Oct 20 2018
Oct 19 2018
Oct 16 2018
Oct 15 2018
Oct 13 2018
Oct 12 2018
to Applications/18.08 please :)
This could go into stable branch, I guess?
Even if the kioslave is still called "kio_kamera", and not installed in a kf5-specific directory, can you please use "kio5_kamera" as catalog name?
This way it will be slightly more future-proof, and one step less from potential parallel installation with a future KF6.
Oct 11 2018
@filipesaraiva are you even reviewing this stuff? OK, let me revert it, so it can be done properly
I don't see why this was split from D16120: Changed old style casts -- please move these changed there, and abandon this revision.
please remove the mention of changes different than old style casts in the commit message
Oct 10 2018
Seems OK for me -- wait a bit in case the other reviewers have concerns.
Oct 9 2018
please amend the commit message to not mention the <repository.h> changes
Oct 8 2018
please remove all the <repository.h> changes from this patch, since they are nothing to do with the actual export fixes