- User Since
- Mar 25 2016, 4:10 PM (151 w, 4 d)
Sun, Feb 17
Hopefully rebase on master.
Rebased on master.
Sat, Feb 16
Wed, Feb 13
Tue, Feb 12
Sun, Feb 10
@davidedmundson any idea about this?
Sat, Feb 9
Then just ship a desktop file for that format in kimageformats:
- if kio-extras is not installed, that desktop file will be unused (although just a couple of kilobytes on disk)
- if ko-extras is installed, it will register PS as thumbnail format using imagethumbnail
OTOH this will not work if kimageformats is not installed, and the thumbnailer gives no hint about that.
Please do not add the translations manually, as they are handled by scripty automatically.
Fri, Feb 8
Please leave the existing context, so there is no string change, and this can be fixed in stable branches (in case it applies there).
Tue, Feb 5
Mon, Feb 4
Thu, Jan 31
Tue, Jan 29
-1 for this:
- hidden feature
- it does not make sense when the general paradigm is OK/Apply/Cancel, so we are teaching users that options are applied only when OK/Apply is pressed (and thus they are left free to play with options as they fit)
- if an user accidentally double-clicks, then the options are saved a) against the user choice b) with no feedback at all
Mon, Jan 28
Sun, Jan 27
Jan 20 2019
Ah yes, now I see it better, the whole KMessageBox::shouldBeShownContinue() check is bogus, since that key is not set by anything.
Also, not related to the code: @shubham, you seem to often remove your own comments. This is a bad practice for many POV of views (transparency, breaks the logic of a conversation, etc). As these reviews send notification emails to mailing lists usually, then your removed messages are archived, and thus removing them is useless.
Please stop doing this anti-social practice, thank you.
Jan 19 2019
Jan 17 2019
This makes a "core" library grow a dependency on widgets -- not really a good idea, considering there is the sonnetui library for that.
Jan 16 2019
Jan 14 2019
Jan 12 2019
Jan 8 2019
Just noticed this... note that ECM already provides it: https://api.kde.org/ecm/module/ECMEnableSanitizers.html
@kfunk see the notes please
Jan 7 2019
Thanks -- which branch should I push this to? Plasma/5.12, Plasma/5.14, or only master for now?
I'm personally still not convinced about the usage of the bold for questions, as I wrote in an earlier comment.
The rest is not up to me.
Jan 5 2019
This is tested so far only on Linux, where the cmake output for the device backends is:
Can you please add a "kate" prefix to the message catalog? See TRANSLATION_DOMAIN in CMakeLists.txt, and Messages.sh.
Jan 4 2019
Also, I do not understand why a console warning is translated: normal users will not see it, and if they do the message is not actionable for them.
Jan 3 2019
Nice progresses, thanks for the fixes. I added few more notes, just mentioning the first occurrence of each.
One more thing is to print errno (and possibly its string representation using strerror/strerror_r) on failure, so that the debugging is easier.
Jan 1 2019
I don't understand what is tested in KDbTestUtils::testDriver() now, related to the mimetypes. The old logic looked better (and simpler too) to me, I'd just leave that.
The only simple addition IMHO is that manager.driverIdsForMimeType(mimeName) returns a valid driver for each of the mimetypes specified in the plugin metadata.
Dec 31 2018
OK, second attempt (still untested!), resolving mimetypes on lookup:
Another option could be to resolve the mimetypes when loading the metadata of the plugins, in DriverManagerInternal::lookupDriversInternal().
Dec 30 2018
- NULL -> nullptr
- there is not just glibc
- the changes to file_unix.cpp seem unrelated to you patch now, so better split them in an own patch
- use constData() instead of data() every time the data needed is read-only
Dec 28 2018
Dec 27 2018
Dec 26 2018
TBH inverting all the EXIV2_TEST_VERSION(...) conditions will avoid swapping all the code branches for old and new exiv2, reducing the diff of this patch.