pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (224 w, 4 d)
Availability
Available

Recent Activity

Sat, Jun 20

pino committed R883:1572404: typo fix.
typo fix
Sat, Jun 20, 4:57 PM

Fri, Jun 19

pino closed D29857: Fix: kwalletmanager cannot be started by systemsettings/account details/launch.

Patch won't apply directly, but you've done the work finding the bug, I can sort that.

Fri, Jun 19, 8:56 AM

Jun 14 2020

pino added a comment to D27633: Port to KPluginLoader.

I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE?

@nicolasfella can you please look at it?

On top of that that's a BIC change, you can't do BIC changes on KF5 repos, so revert?

Jun 14 2020, 4:19 AM

Jun 13 2020

pino committed R883:1571573: updates.
updates
Jun 13 2020, 6:33 PM

Jun 10 2020

pino committed R181:eab66b0e29b3: Remove MPRIS1 support (authored by pino).
Remove MPRIS1 support
Jun 10 2020, 12:04 PM
pino committed R181:728492c391b0: Remove MPRIS1 support (authored by pino).
Remove MPRIS1 support
Jun 10 2020, 12:04 PM
pino committed R181:f86dade7ceb0: Merge branch 'remove-mpris1' into 'master' (authored by pino).
Merge branch 'remove-mpris1' into 'master'
Jun 10 2020, 12:04 PM

Jun 9 2020

pino committed R73:65894e6929f8: Merge remote-tracking branch 'origin/release/20.04' (authored by pino).
Merge remote-tracking branch 'origin/release/20.04'
Jun 9 2020, 2:14 PM
pino committed R73:f36bb0e2a6a2: cmake: fix version in config header (authored by pino).
cmake: fix version in config header
Jun 9 2020, 2:12 PM

Jun 8 2020

pino committed R883:1570847: updates.
updates
Jun 8 2020, 9:05 AM
pino committed R883:1570832: remove spurious </p> in msgstr.
remove spurious </p> in msgstr
Jun 8 2020, 7:21 AM
pino committed R883:1570830: SVN_SILENT create empty directories.
SVN_SILENT create empty directories
Jun 8 2020, 7:06 AM

Jun 7 2020

pino committed R319:1027e127f912: fixuifiles (authored by pino).
fixuifiles
Jun 7 2020, 6:24 AM

Jun 6 2020

pino committed R883:1570713: typo fix.
typo fix
Jun 6 2020, 5:06 PM
pino committed R883:1570705: typo fix.
typo fix
Jun 6 2020, 4:42 PM

Jun 5 2020

pino committed R883:1570584: create empty az messages dir.
create empty az messages dir
Jun 5 2020, 8:32 AM
pino committed R341:169931bfca2d: Merge remote-tracking branch 'origin/release/20.04' (authored by pino).
Merge remote-tracking branch 'origin/release/20.04'
Jun 5 2020, 8:01 AM
pino committed R341:40735c939fde: i18n: use dummy source for objinfo and example catalogs (authored by pino).
i18n: use dummy source for objinfo and example catalogs
Jun 5 2020, 7:59 AM
pino committed R865:010aedded587: i18n: fix message extraction (authored by pino).
i18n: fix message extraction
Jun 5 2020, 7:37 AM

Jun 4 2020

pino committed R331:2d80035915f1: Merge remote-tracking branch 'origin/release/20.04' (authored by pino).
Merge remote-tracking branch 'origin/release/20.04'
Jun 4 2020, 5:10 PM
pino committed R331:f3f5d9ae505f: cmake: remove duplicate lines (authored by pino).
cmake: remove duplicate lines
Jun 4 2020, 5:09 PM
pino committed R331:2f3ffbd3cdd8: scripting: remove support for Python < 3 (authored by pino).
scripting: remove support for Python < 3
Jun 4 2020, 4:28 PM
pino committed R331:b10b1a880498: Merge remote-tracking branch 'origin/release/20.04' (authored by pino).
Merge remote-tracking branch 'origin/release/20.04'
Jun 4 2020, 4:28 PM
pino committed R331:e31a8926e0eb: Remove old script for releasing from CVS (authored by pino).
Remove old script for releasing from CVS
Jun 4 2020, 4:24 PM
pino committed R331:a787359daa79: Remove the old kfile plugins (authored by pino).
Remove the old kfile plugins
Jun 4 2020, 4:24 PM
pino committed R167:2d07d452c2ac: Remove unused KRandom include (authored by pino).
Remove unused KRandom include
Jun 4 2020, 4:09 PM
pino committed R883:1570491: updates.
updates
Jun 4 2020, 9:22 AM

Jun 3 2020

pino committed R883:1570443: fix typo.
fix typo
Jun 3 2020, 10:56 PM
pino committed R883:1570438: update and complete.
update and complete
Jun 3 2020, 9:36 PM
pino committed R883:1570437: updates.
updates
Jun 3 2020, 9:28 PM
pino committed R883:1570436: SVN_SILENT remove empty dirs.
SVN_SILENT remove empty dirs
Jun 3 2020, 9:14 PM

Jun 2 2020

pino committed R883:1570146: updates.
updates
Jun 2 2020, 10:47 PM

May 30 2020

pino added a comment to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.
In D29805#674206, @pino wrote:
In D29805#674204, @pino wrote:

FIXED-IN: 20.08

still for 20.08...

Yes kio-extra is released with KDE Applications

Yes, I know. Asked to land this fix instead to release/20.04, and thus change the commit message accordingly.

Please be explicit when you comment, no one could deduce what you meant.

May 30 2020, 3:58 PM · Frameworks, Dolphin
pino added a comment to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.
In D29805#674204, @pino wrote:

FIXED-IN: 20.08

still for 20.08...

Yes kio-extra is released with KDE Applications

May 30 2020, 1:39 PM · Frameworks, Dolphin
pino added a comment to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.

still for 20.08...

May 30 2020, 1:13 PM · Frameworks, Dolphin
pino added inline comments to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.
May 30 2020, 10:27 AM · Frameworks, Dolphin
pino added a comment to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.

please target release/20.04 for this fix, thanks

May 30 2020, 8:16 AM · Frameworks, Dolphin

May 22 2020

pino committed R71:bb955d4838c5: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
May 22 2020, 5:00 PM
pino committed R71:a794a33e82d2: cmake: find PostgreSQL 13 (authored by pino).
cmake: find PostgreSQL 13
May 22 2020, 5:00 PM
pino committed R15:e6d55550aaa9: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
May 22 2020, 4:59 PM
pino committed R15:fb5dafb01ffb: cmake: find PostgreSQL 13 (authored by pino).
cmake: find PostgreSQL 13
May 22 2020, 4:59 PM

May 19 2020

pino added a comment to D28673: [PackageUrlInterceptor] Make QRegularExpression static.

so, can the regexp be replaced or does it need to stay?

May 19 2020, 8:28 AM · Frameworks

May 17 2020

pino requested changes to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.

Please update the text of the revision and the commit message, as they don't make much sense. Please mention that it fixes a crash in case ddjvu is not installed, by avoiding executing it, and using _exit() to not run atexit handlers in case execvp() fails.

May 17 2020, 7:51 AM · Frameworks, Dolphin
pino requested changes to D29805: Thumbnail djvu: Avoid a crash when djvu is not installed.

This change is definitely not correct.

May 17 2020, 7:05 AM · Frameworks, Dolphin

May 6 2020

pino requested changes to D29343: [kcm] Fix label.

Please read what @zzag and me wrote: you must fix the buddy of the label widget, not its name.

May 6 2020, 3:11 PM · KWin
pino added a comment to R456:d52726681d26: Bump Qt Min Version.

@sdepiets bumping dependencies in a stable branch is against the freeze policy:
https://community.kde.org/Schedules/release_service/20.04_Release_Schedule#Thursday.2C_March_12.2C_2020:_20.04_Dependency_Freeze

May 6 2020, 6:57 AM

May 5 2020

pino committed R181:f34a04640758: Remove MPRIS1 support (authored by pino).
Remove MPRIS1 support
May 5 2020, 9:47 PM

May 3 2020

pino added a comment to D29381: Thumbnail text: use libmagic to detect encoding.

why not KEncodingProber from the KCodecs framework, like also the commented bits hint about?

May 3 2020, 11:07 AM · Frameworks, Dolphin
pino committed R331:1fdeff25f5f1: cmake: switch python & boost-python search to py3 (authored by pino).
cmake: switch python & boost-python search to py3
May 3 2020, 8:15 AM
pino committed R331:c36a3ccddd6f: scripting: update Python-Kig highlight definition (authored by pino).
scripting: update Python-Kig highlight definition
May 3 2020, 7:31 AM
pino committed R331:8ef1d20cb0f3: scripting: use PyErr_NormalizeException (authored by pino).
scripting: use PyErr_NormalizeException
May 3 2020, 7:31 AM
pino committed R331:a3e63345750b: scripting: properly enable line numbers (authored by pino).
scripting: properly enable line numbers
May 3 2020, 7:31 AM

May 2 2020

pino committed R331:51033a10398e: Merge remote-tracking branch 'origin/release/20.04' (authored by pino).
Merge remote-tracking branch 'origin/release/20.04'
May 2 2020, 8:52 PM
pino committed R331:92bc71f0b8c7: i18n: translate UI menu (authored by pino).
i18n: translate UI menu
May 2 2020, 8:47 PM

May 1 2020

pino committed R337:cdc1c65fdb8d: Merge remote-tracking branch 'origin/release/20.04' (authored by pino).
Merge remote-tracking branch 'origin/release/20.04'
May 1 2020, 9:20 PM
pino committed R341:74988e417331: Merge remote-tracking branch 'origin/release/20.04' (authored by pino).
Merge remote-tracking branch 'origin/release/20.04'
May 1 2020, 7:19 PM
pino committed R341:d9e121557ab3: Revert "GIT_SILENT: it compiles fine without deprecated method" (authored by pino).
Revert "GIT_SILENT: it compiles fine without deprecated method"
May 1 2020, 7:17 PM
pino added a reverting change for R341:e4ac0b432146: GIT_SILENT: it compiles fine without deprecated method: R341:d9e121557ab3: Revert "GIT_SILENT: it compiles fine without deprecated method".
May 1 2020, 7:17 PM
pino added a comment to D29343: [kcm] Fix label.

The accelerator is correct to use, as it will activate the buddy associated to to label... which is wrong, as quickTileLabel does not exist.
Did you try changing the buddy of quickTileLabel to kcfg_ElectricBorderTiling?

May 1 2020, 4:47 PM · KWin
pino added inline comments to D29321: Port and enable the User Agent Changer plugin.
May 1 2020, 11:06 AM

Apr 30 2020

pino added inline comments to D29254: [RenameDialog] Add an arrow indicating direction from src to dest.
Apr 30 2020, 6:33 PM · Frameworks
pino added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.
In D29299#660519, @pino wrote:

Because people do strange things, and I prefer to rather not break their card house unless necessary.

Again, in which cases? The only way it might change the path is: use ki18n AND build with cmake AND use the ki18n_install macro AND define a KDE_INSTALL_LOCALEDIR variable yourself. Too many factors to make it even something to even bother thinking about TBH.

Mileages difer :)

One does not need to define KDE_INSTALL_LOCALEDIR oneself. One only needs to use find_package(KF5Plasma) or find_package(KF5Package), because some subrepo also does a plasma applet for Plasma integration or have someone cluelessly copied cmake code together because ENOTIMEFORBUILDSYSTEM and copying from the best=KDE and now-it-builds-so-do-not-touch-again.

Apr 30 2020, 6:28 PM · Frameworks
pino added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.

Because people do strange things, and I prefer to rather not break their card house unless necessary.

Apr 30 2020, 4:45 PM · Frameworks
pino added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.

D29136 in the current version though changes behaviour by favouring KDE_INSTALL_LOCALEDIR over LOCALE_INSTALL_DIR. Which at least in theory might somewhere in some distant galaxy break things ;)

Apr 30 2020, 4:31 PM · Frameworks
pino added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.
In D29299#660465, @pino wrote:

Also, your patch basically includes D29136 in the case of no DESTINATION parameter specified, hence my suggestion is:

  • edit D29136 to do the fallback using the same logic introduced here: this way marble is already fixed with no other changes, and ki18n_install will work also with KDE_INSTALL_DIRS_NO_DEPRECATED (e.g. for release-service packages)
  • have this to add the DESTINATION parameter, so packages can opt-in to use it if they can/want

Not exactly sure what you mean? Do you want two separate commits/reviews, one per issue?

Apr 30 2020, 4:13 PM · Frameworks
pino added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.

The patch should not require existing users to adapt

Apr 30 2020, 4:05 PM · Frameworks
pino added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.

The problem is that ki18n_install() is rarely used manually

Apr 30 2020, 3:46 PM · Frameworks
pino added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.

The problem is that ki18n_install() is rarely used manually, and generally it is appended by the release scripts to the top-level CMakeLists.txt file that goes into the tarballs.
This means that either the majority of the packages will not make use of this, or a mass-bump of the ki18n dependency (which I'd rather not do).

Apr 30 2020, 3:39 PM · Frameworks
pino added inline comments to D29254: [RenameDialog] Add an arrow indicating direction from src to dest.
Apr 30 2020, 1:32 PM · Frameworks

Apr 29 2020

pino committed R139:ff066c14ca28: Switch to https for bugs.kde.org (authored by pino).
Switch to https for bugs.kde.org
Apr 29 2020, 7:39 AM
pino committed R226:ee502a7c75b0: Switch to https for bugs.kde.org (authored by pino).
Switch to https for bugs.kde.org
Apr 29 2020, 7:36 AM
pino committed R434:2d30a68460c3: Switch to https for bugs.kde.org (authored by pino).
Switch to https for bugs.kde.org
Apr 29 2020, 7:36 AM
pino committed R318:0f1c0158091c: doc: switch to https for bugs.kde.org (authored by pino).
doc: switch to https for bugs.kde.org
Apr 29 2020, 7:30 AM
pino added inline comments to D29270: Fix broken localization of kcmkwinrules.
Apr 29 2020, 6:26 AM · KWin

Apr 27 2020

pino updated subscribers of R163:32bf62a5f138: minuet: Update set's properties in fluid synth sound controller..

@tcanabrava @carneirogustavo this change does not look correct to me: now both the setters are effectively no-op if the new values are different than the old ones.
Are you sure it was not meant to be if (m_foo == foo) return; instead?

Apr 27 2020, 8:16 AM

Apr 26 2020

pino added a comment to D29195: Add AppStream file.

My concern is that this change is about adding an AppStream file, with no mention of other changes to the desktop file. So it is not clear (especially when looking at this after some time) whether the change was somehow related (which doesn't look like), or maybe it was a local change for testing that slipped in while committing.

Apr 26 2020, 6:24 PM
pino added a comment to D29195: Add AppStream file.

Is the change to GenericName intentional?

Apr 26 2020, 6:15 PM
pino committed R216:ff67bbbeff62: debchangelog: add Groovy Gorilla (authored by pino).
debchangelog: add Groovy Gorilla
Apr 26 2020, 12:20 PM

Apr 24 2020

pino added a comment to D29077: Fix MacOS build for missing bundle.

@pino if you can, please the history if of this patch to see my first and working version.
https://phabricator.kde.org/D29077?id=80827

Apr 24 2020, 12:59 PM · KDE Edu
pino added a comment to D29077: Fix MacOS build for missing bundle.

CMake Error at src/app/CMakeLists.txt:87 (install):

Apr 24 2020, 12:47 PM · KDE Edu

Apr 23 2020

pino committed R470:a5dec9e16a09: Normalize return value of TitleComparison::compare (authored by pino).
Normalize return value of TitleComparison::compare
Apr 23 2020, 8:00 AM
pino committed R470:aee9e90c1ce0: Use unnamespaced hex for Qt < 5.14 (authored by pino).
Use unnamespaced hex for Qt < 5.14
Apr 23 2020, 7:32 AM

Apr 22 2020

pino added inline comments to D29087: [KJotsTreeView] Fix "copy link address" action.
Apr 22 2020, 1:38 PM · KDE PIM
pino added a comment to D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended.

(Commented in the wrong place)

Apr 22 2020, 7:10 AM · Frameworks
pino added a comment to R290:bb560f8dfa0a: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended.

Shouldn't the test completely ignore the system location, to avoid interferences from the system installation?

Apr 22 2020, 7:09 AM

Apr 21 2020

pino added a comment to D29048: [KJots] Translate statusbar messages.

LGTM for me from an i18n POV, I'll let @dvratil give a final review/approval.

Apr 21 2020, 12:39 PM · KDE PIM
pino added a comment to D29048: [KJots] Translate statusbar messages.

The actual i18n changes LGTM, thanks!

Apr 21 2020, 11:48 AM · KDE PIM
pino added a comment to D29044: [KJots] Port deprecated code.

a couple of notes for a followup patch -- no need to change this patch, as the code lacked the i18n handling also before (so this patch is not a regression).

Apr 21 2020, 11:32 AM · KDE PIM

Apr 20 2020

pino added a comment to R865:956304dcf63a: Revert "Lower deprecation versions to what was tested GIT_SILENT".

The best idea I had so far to support Laurent's workflow might be to have a CMake switch, like -DDISABLE_ALL_QTKF_DEPRECATED, to enable the fail-build-on-deprecated-Qt/KF-API:

Apr 20 2020, 11:11 AM
pino added a comment to R865:956304dcf63a: Revert "Lower deprecation versions to what was tested GIT_SILENT".

if a distro decides to package an application which was not released based on git source it's the problem of distro not my problem.

There are also distros that keep the sources of packages in git repositories. In this case .git exists but it is not the upstream git repository. The assumption "it is a git repository, so it is the upstream one" is not correct.

As I wrote if distro decided to use git repo it's not my problem, they want to use unrelease code source, they accept the potential problem. Using an unrelease apps is never a good solution for a distro.

Apr 20 2020, 10:29 AM
pino added a comment to R865:956304dcf63a: Revert "Lower deprecation versions to what was tested GIT_SILENT".

if a distro decides to package an application which was not released based on git source it's the problem of distro not my problem.

Apr 20 2020, 9:36 AM

Apr 16 2020

pino committed R875:c725b5dd6a78: Merge remote-tracking branch 'origin/Falkon/3.1' (authored by pino).
Merge remote-tracking branch 'origin/Falkon/3.1'
Apr 16 2020, 11:11 AM
pino committed R875:da5a1754ca9b: Add Intl_LIBRARIES and Intl_INCLUDE_DIRS to FalkonPrivate (authored by tcberner).
Add Intl_LIBRARIES and Intl_INCLUDE_DIRS to FalkonPrivate
Apr 16 2020, 11:08 AM
pino committed R241:c5feb4fdb838: Use nullptr (authored by pino).
Use nullptr
Apr 16 2020, 10:24 AM
pino committed R875:0f0261e96648: Merge remote-tracking branch 'origin/Falkon/3.1' (authored by pino).
Merge remote-tracking branch 'origin/Falkon/3.1'
Apr 16 2020, 10:23 AM
pino committed R875:5eedcb5b44da: Add missing include in last qt5.14 (authored by mlaurent).
Add missing include in last qt5.14
Apr 16 2020, 10:02 AM
pino added a comment to D28755: Breeze Icons cannot be built from read-only source location.

Fixed with def21bf6c691a40bef233efd898fcb7ff57d55bb, thanks for the notice.

Apr 16 2020, 9:54 AM · Frameworks
pino committed R266:def21bf6c691: build: quote source directory path (authored by pino).
build: quote source directory path
Apr 16 2020, 9:48 AM

Apr 15 2020

pino added inline comments to R493:bebd62878981: Just use tr().
Apr 15 2020, 9:33 PM

Apr 13 2020

pino committed R478:6538b24fdf4c: Remove unused variables (authored by pino).
Remove unused variables
Apr 13 2020, 8:17 AM