pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (116 w, 3 d)
Availability
Available

Recent Activity

Today

pino added a comment to D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib.

The problem with that is cmake picking the wrong dir (first in order is lib, while it should be e.g. lib64).

Mon, Jun 18, 5:43 AM · Baloo, Frameworks
pino added a comment to D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib.

Or just drop the two HINTS (for find_path and find_library) altogether, as cmake already looks in standard include/library paths.

Mon, Jun 18, 2:56 AM · Baloo, Frameworks

Sat, Jun 16

pino accepted D13564: Remove ReviewBoard file.

This kind of changes does not need an explicit review request IMHO...

Sat, Jun 16, 9:12 AM
pino committed R37:26bc337acf97: i18n fix (authored by pino).
i18n fix
Sat, Jun 16, 8:30 AM
pino committed R37:ee9ad6aab57b: i18n fix (authored by pino).
i18n fix
Sat, Jun 16, 8:30 AM
pino committed R37:427526ad89af: i18n fixes (authored by pino).
i18n fixes
Sat, Jun 16, 8:14 AM
pino committed R37:6211fedad479: i18n fixes (authored by pino).
i18n fixes
Sat, Jun 16, 8:12 AM

Fri, Jun 15

pino committed R37:8b35f97c18e3: i18n fixes (authored by pino).
i18n fixes
Fri, Jun 15, 9:30 PM
pino committed R37:0e2dce2b7b86: Fix minor typos (authored by yurchor).
Fix minor typos
Fri, Jun 15, 9:30 PM
pino committed R37:797bd66080bb: i18n: extract messages for Python plugin (authored by pino).
i18n: extract messages for Python plugin
Fri, Jun 15, 9:30 PM
pino committed R37:1e33bc1456f5: i18n fixes (authored by pino).
i18n fixes
Fri, Jun 15, 9:28 PM
pino committed R37:4794fdf36d4b: Use KFormat for formatting byte sizes (authored by pino).
Use KFormat for formatting byte sizes
Fri, Jun 15, 7:56 PM
pino added a comment to D13548: Use KFormat for formatting byte sizes.

It would be nice to consult @rempt on IRC about that. Does KFormat belong to KF5 Tier1?

Fri, Jun 15, 7:46 PM · Krita
pino committed R37:04db4caeb910: Use KFormat for formatting byte sizes (authored by pino).
Use KFormat for formatting byte sizes
Fri, Jun 15, 7:43 PM
pino closed D13548: Use KFormat for formatting byte sizes.
Fri, Jun 15, 7:43 PM · Krita
pino added a comment to D13548: Use KFormat for formatting byte sizes.

We cannot backport it into 4.1 though, because we are in a string freeze. But in the future we should really use KFormat for such things :)

Fri, Jun 15, 7:41 PM · Krita
pino committed R883:1517925: typo fix.
typo fix
Fri, Jun 15, 7:52 AM

Thu, Jun 14

pino committed R37:5d4c275a1dd3: i18n: extract messages for Python plugin (authored by pino).
i18n: extract messages for Python plugin
Thu, Jun 14, 9:02 PM
pino committed R167:481c0f083442: Remove the unused KMountMan::convertSize() (authored by pino).
Remove the unused KMountMan::convertSize()
Thu, Jun 14, 8:38 PM
pino requested review of D13549: Switch KIO::convertSize() to KFormat::formatByteSize().
Thu, Jun 14, 8:20 PM · Frameworks
pino requested review of D13548: Use KFormat for formatting byte sizes.
Thu, Jun 14, 8:12 PM · Krita
pino committed R37:cc25aeddb2ea: pykrita: use KDesktopFile to read desktop files of plugins (authored by pino).
pykrita: use KDesktopFile to read desktop files of plugins
Thu, Jun 14, 6:56 AM

Sun, Jun 10

pino committed R983:1ca11ad047fb: i18n: pass correctly the arguments to i18n() (authored by pino).
i18n: pass correctly the arguments to i18n()
Sun, Jun 10, 6:38 PM

Fri, Jun 8

pino committed R983:9d7ab15d8e1a: fileaction plugin: remove const_cast hack (authored by pino).
fileaction plugin: remove const_cast hack
Fri, Jun 8, 6:22 AM
pino committed R983:9672ae2ba27c: i18n fixes (authored by pino).
i18n fixes
Fri, Jun 8, 6:22 AM

Thu, Jun 7

pino committed R181:4ae365fdf45e: Drop the local libattica-ocsclient (authored by pino).
Drop the local libattica-ocsclient
Thu, Jun 7, 10:47 AM
pino committed R181:497bf1ab30fd: Switch to the Attica framework (authored by pino).
Switch to the Attica framework
Thu, Jun 7, 10:34 AM
pino closed D13180: Switch to the Attica framework.
Thu, Jun 7, 10:34 AM
pino committed R983:e07b097de920: Remove unused kreplacements bits (authored by pino).
Remove unused kreplacements bits
Thu, Jun 7, 5:57 AM
pino closed D13348: Remove unused kreplacements bits.
Thu, Jun 7, 5:57 AM

Tue, Jun 5

pino requested review of D13348: Remove unused kreplacements bits.
Tue, Jun 5, 7:02 AM
pino committed R983:c194285a96ab: add a .arcconfig file (authored by pino).
add a .arcconfig file
Tue, Jun 5, 6:46 AM

Mon, Jun 4

pino updated the diff for D13180: Switch to the Attica framework.

Fix a connection to Attica::ProviderManager

Mon, Jun 4, 6:07 PM

Sun, Jun 3

pino committed R206:22e9c067f18e: remove the locolor icons (authored by pino).
remove the locolor icons
Sun, Jun 3, 4:22 PM
pino committed R413:3acb7e541da1: remove the locolor icons (authored by pino).
remove the locolor icons
Sun, Jun 3, 3:51 PM

Fri, Jun 1

pino committed R434:1811c54e4597: Merge remote-tracking branch 'origin/Applications/18.04' (authored by pino).
Merge remote-tracking branch 'origin/Applications/18.04'
Fri, Jun 1, 7:41 AM
pino committed R434:df00be6f07de: cmake: remove extra "plugins" (authored by pino).
cmake: remove extra "plugins"
Fri, Jun 1, 7:36 AM

Tue, May 29

pino committed R37:8b59bf27b4af: Fix loading of the Python library (authored by pino).
Fix loading of the Python library
Tue, May 29, 9:35 AM
pino added a comment to D13144: Fix loading of the Python library.

Done, should I backport it to krita/4.0 as well?

Tue, May 29, 8:47 AM
pino committed R37:1553c12637e1: Fix loading of the Python library (authored by pino).
Fix loading of the Python library
Tue, May 29, 8:46 AM
pino closed D13144: Fix loading of the Python library.
Tue, May 29, 8:46 AM
pino updated the diff for D13144: Fix loading of the Python library.

Rebased on master.

Tue, May 29, 7:49 AM
pino added a comment to D13144: Fix loading of the Python library.

This only applies to the krita/4.0, doesn't it?

Tue, May 29, 7:09 AM

Mon, May 28

pino added a comment to D13180: Switch to the Attica framework.

Out-of-commit annotation: the code in src/aboutdialog/libattica-ocsclient/ will be removed in a followup commit after this patch is in.

Mon, May 28, 8:57 PM
pino requested review of D13180: Switch to the Attica framework.
Mon, May 28, 8:56 PM
pino committed R181:ed38fe752fd9: Removed last references to clamz (authored by pino).
Removed last references to clamz
Mon, May 28, 12:20 PM

Sun, May 27

pino committed R181:21d701af2fd0: cmake: fix SONAME/SOVERSION of libamarokocsclient (authored by pino).
cmake: fix SONAME/SOVERSION of libamarokocsclient
Sun, May 27, 10:01 PM
pino committed R216:a41c9be582b7: debchangelog: add Cosmic Cuttlefish (authored by pino).
debchangelog: add Cosmic Cuttlefish
Sun, May 27, 5:07 PM
pino requested review of D13144: Fix loading of the Python library.
Sun, May 27, 8:39 AM
pino committed R32:27be9b3e5b1b: Merge remote-tracking branch 'origin/5.2' (authored by pino).
Merge remote-tracking branch 'origin/5.2'
Sun, May 27, 7:19 AM
pino committed R32:046b18140d12: i18n: extract messages for kdevheaptrack (authored by pino).
i18n: extract messages for kdevheaptrack
Sun, May 27, 7:18 AM
pino committed R883:1516582: typo fix.
typo fix
Sun, May 27, 7:13 AM

Tue, May 22

pino committed R321:8c880dc9dca9: Make Xplanet an optional runtime-only dependency (authored by pino).
Make Xplanet an optional runtime-only dependency
Tue, May 22, 8:23 PM
pino committed R71:4df84818d4d6: Merge remote-tracking branch 'origin/3.1' (authored by pino).
Merge remote-tracking branch 'origin/3.1'
Tue, May 22, 4:52 PM
pino committed R15:ba860e8a8886: Merge remote-tracking branch 'origin/3.1' (authored by pino).
Merge remote-tracking branch 'origin/3.1'
Tue, May 22, 4:51 PM
pino committed R15:675d51d86b37: cmake: find PostgreSQL 11 (authored by pino).
cmake: find PostgreSQL 11
Tue, May 22, 4:51 PM
pino committed R71:54b2bcfb2ff1: cmake: find PostgreSQL 11 (authored by pino).
cmake: find PostgreSQL 11
Tue, May 22, 4:48 PM

May 12 2018

pino committed R434:7881d11ddbc7: Merge remote-tracking branch 'origin/Applications/18.04' (authored by pino).
Merge remote-tracking branch 'origin/Applications/18.04'
May 12 2018, 5:21 AM
pino committed R434:c21991982f42: Remove the WLM protocol (authored by pino).
Remove the WLM protocol
May 12 2018, 5:00 AM
pino closed D12530: Remove the WLM protocol.
May 12 2018, 5:00 AM · Documentation, Kopete

May 6 2018

pino committed R134:de6019e59ded: i18n: use plural form where needed (authored by pino).
i18n: use plural form where needed
May 6 2018, 5:21 PM
pino committed R241:2a685bccc773: i18n: use plural form again for plugin message (authored by pino).
i18n: use plural form again for plugin message
May 6 2018, 4:28 AM

May 3 2018

pino committed R883:1515022: remove extra doublequotes.
remove extra doublequotes
May 3 2018, 4:55 AM
pino committed R44:78f2f2933051: i18n: remove extra quotes from Comment keys (authored by pino).
i18n: remove extra quotes from Comment keys
May 3 2018, 4:54 AM
pino committed R44:18f934204692: i18n: remove extra quotes from Comment key (authored by pino).
i18n: remove extra quotes from Comment key
May 3 2018, 4:54 AM

May 2 2018

pino updated subscribers of D12530: Remove the WLM protocol.
May 2 2018, 4:21 AM · Documentation, Kopete

Apr 28 2018

pino committed R321:d72f27143078: tests: do not add KStarsUiTests as autotest (authored by pino).
tests: do not add KStarsUiTests as autotest
Apr 28 2018, 11:05 PM
pino committed R321:7a8c670b46b1: cmake: demote AstrometryNet as runtime dependency (authored by pino).
cmake: demote AstrometryNet as runtime dependency
Apr 28 2018, 9:50 PM
pino committed R473:672c5076de7e: QTimer may not be an incomplete type as it is used as a member variable. Add… (authored by adridg).
QTimer may not be an incomplete type as it is used as a member variable. Add…
Apr 28 2018, 3:18 PM

Apr 26 2018

pino removed a reviewer for D12174: FFMpeg plugin: port away from deprecated data structure: pino.
Apr 26 2018, 8:39 PM
pino removed a reviewer for D12115: FFMpeg plugin cleanup: pino.
Apr 26 2018, 8:39 PM
pino resigned from D12115: FFMpeg plugin cleanup.
Apr 26 2018, 8:39 PM
pino edited reviewers for D12530: Remove the WLM protocol, added: pali; removed: dfaure.
Apr 26 2018, 5:04 AM · Documentation, Kopete
pino requested review of D12530: Remove the WLM protocol.
Apr 26 2018, 5:03 AM · Documentation, Kopete

Apr 24 2018

pino committed R434:07b5d49ceaf2: Merge remote-tracking branch 'origin/Applications/18.04' (authored by pino).
Merge remote-tracking branch 'origin/Applications/18.04'
Apr 24 2018, 4:41 AM
pino committed R434:b1f4fa1401cb: oscar: include buffer.h (authored by pino).
oscar: include buffer.h
Apr 24 2018, 4:31 AM

Apr 22 2018

pino committed R440:f5a87b21d2cd: i18n: spell "OK" correctly (authored by pino).
i18n: spell "OK" correctly
Apr 22 2018, 5:14 AM

Apr 20 2018

pino committed R983:c9c7cd003116: use QDialogButtonBox (authored by pino).
use QDialogButtonBox
Apr 20 2018, 6:19 AM

Apr 18 2018

pino added a comment to D12272: Fix build with Qt 5.11_beta3 (dropping qt5_use_modules).

Sounds OK, but please push it to the 0.12 branch instead, and then merge it to master.

Apr 18 2018, 6:57 AM

Apr 14 2018

pino committed R321:a4189c33ee45: tests: fix KStarsUiTests (authored by pino).
tests: fix KStarsUiTests
Apr 14 2018, 5:21 PM

Apr 11 2018

pino committed R321:02183d4bc1a0: use KFormat::formatByteSize() (authored by pino).
use KFormat::formatByteSize()
Apr 11 2018, 6:43 AM

Apr 7 2018

pino committed R434:51b94d6fbd8f: Merge remote-tracking branch 'origin/Applications/18.04' (authored by pino).
Merge remote-tracking branch 'origin/Applications/18.04'
Apr 7 2018, 12:06 PM
pino committed R434:e8a42a845acc: mostly fix the installation of icons (authored by pino).
mostly fix the installation of icons
Apr 7 2018, 11:39 AM
pino committed R434:7ee60c6e76f0: desktop: remove duplicated X-DBUS-StartupType (authored by pino).
desktop: remove duplicated X-DBUS-StartupType
Apr 7 2018, 8:10 AM

Apr 1 2018

pino committed R241:52307a81b152: file: do not assume layout of sockaddr_un struct (authored by pino).
file: do not assume layout of sockaddr_un struct
Apr 1 2018, 6:05 AM

Mar 25 2018

pino removed a reviewer for D11669: Fix pixmap scaling on HiDPI screens: pino.
Mar 25 2018, 4:59 AM
pino resigned from D11669: Fix pixmap scaling on HiDPI screens.
Mar 25 2018, 4:59 AM

Mar 22 2018

pino committed R478:bb32a07c10cf: remove stray unicode characters (authored by pino).
remove stray unicode characters
Mar 22 2018, 7:36 AM

Mar 19 2018

pino added a comment to D11070: An alternative to the web interface.

True. I'll do it once I've fixed the desktop problem.

Mar 19 2018, 7:37 AM
pino added a comment to D11070: An alternative to the web interface.

Note that correct way is:

  • squash (i.e. "merge") all the commits in your local htmlinterface branch into a single commit
  • rebase your branch on current master
  • push the single commit as update to this revision
Mar 19 2018, 7:14 AM

Mar 17 2018

pino requested changes to D11409: Summary:.

Please reuse D11070: An alternative to the web interface by editing it, instead of creating a new revision...
Also:

  • please create a cmake module that looks for microhttpd, and enable the build of the plugin only if found
  • please address the concerns I expressed when reviewing D11070: An alternative to the web interface regarding memory leaks, exposure/visibility of private/internal functions in headers, commented code, etc
Mar 17 2018, 9:14 AM

Mar 16 2018

pino added a comment to D11250: Expose presentation via MPRIS to rich remote controllers.

Please do not restrict it to Q_OS_LINUX, as there is no Linux-only code (nor the feature is specific to Linux in any way).

Mar 16 2018, 2:21 PM · Okular

Mar 12 2018

pino committed R71:4d9920fe92ae: Merge remote-tracking branch 'origin/3.1' (authored by pino).
Merge remote-tracking branch 'origin/3.1'
Mar 12 2018, 9:03 PM
pino committed R71:12eed3a629a0: Install the application icons (authored by pino).
Install the application icons
Mar 12 2018, 8:59 PM

Mar 11 2018

pino committed R883:1512143: typo fix.
typo fix
Mar 11 2018, 9:58 AM

Mar 10 2018

pino added a comment to D11070: An alternative to the web interface.

Not sure why I was added for this review, since I'm not a ktorrent developer...

Mar 10 2018, 11:42 AM
pino requested changes to D11070: An alternative to the web interface.
Mar 10 2018, 11:42 AM

Mar 8 2018

pino committed R434:f444038234b8: add .arcconfig file (authored by pino).
add .arcconfig file
Mar 8 2018, 9:10 AM

Mar 4 2018

pino committed R983:7bc4e3107a14: cmake: remove manual include_directories() (authored by pino).
cmake: remove manual include_directories()
Mar 4 2018, 11:46 AM
pino committed R983:a7d315799656: cmake: do not add wrong dirs for modules (authored by pino).
cmake: do not add wrong dirs for modules
Mar 4 2018, 11:46 AM