pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (193 w, 1 d)
Availability
Available

Recent Activity

Tue, Dec 3

pino committed R40:2e212576821d: Make the strings translatable, fix typo (authored by yurchor).
Make the strings translatable, fix typo
Tue, Dec 3, 6:31 PM

Sun, Dec 1

pino added a comment to D25643: Use PERL_EXECUTABLE on all platforms.

Duplicate of D25638: autotests: Find perl executable on all platforms.

Sun, Dec 1, 7:22 AM · KDE PIM

Sat, Nov 30

pino added inline comments to D25640: RDP: Warn if trying to share a non existing folder.
Sat, Nov 30, 11:23 PM

Fri, Nov 29

pino committed R883:1557245: updates.
updates
Fri, Nov 29, 4:51 AM

Wed, Nov 27

pino committed R883:1557101: fix typos.
fix typos
Wed, Nov 27, 9:54 PM
pino committed R883:1557100: fix typos.
fix typos
Wed, Nov 27, 9:49 PM
pino committed R883:1557088: update.
update
Wed, Nov 27, 6:40 PM
pino committed R883:1557071: updates.
updates
Wed, Nov 27, 7:31 AM

Sat, Nov 23

pino added a comment to D25484: Enable closing a tab by middle click.
In D25484#566477, @pino wrote:

Do people frequently misclick with the middle mouse button?

It can happen, and more often with a touchpad.

I hadn't considered that. By default, you have to tap with 3 fingers to middle click. What are you doing with the touchpad when this happens? [...]

Sat, Nov 23, 11:08 AM · Okular
pino added a comment to D25484: Enable closing a tab by middle click.

Do people frequently misclick with the middle mouse button?

Sat, Nov 23, 10:33 AM · Okular
pino committed R883:1556785: updates.
updates
Sat, Nov 23, 10:10 AM
pino added a comment to D25484: Enable closing a tab by middle click.

Please make it configurable, and off by default (otherwise it is too easy to mis-click and close a document).

Sat, Nov 23, 9:55 AM · Okular
pino committed R883:1556779: updates.
updates
Sat, Nov 23, 8:41 AM
pino committed R883:1556774: updates.
updates
Sat, Nov 23, 8:29 AM

Thu, Nov 21

pino committed R20:b7e93f563027: i18n fixes (authored by pino).
i18n fixes
Thu, Nov 21, 8:27 AM

Wed, Nov 20

pino added inline comments to D25405: Fix Step infobrowser and examples localization.
Wed, Nov 20, 10:48 PM · KDE Edu
pino committed R476:e521f16545b2: remove reviewboard configuration (authored by pino).
remove reviewboard configuration
Wed, Nov 20, 6:04 AM

Tue, Nov 19

pino added a comment to R1045:426d362cf6b0: i18n: remove rc.cpp only after xgettext.

Behaviour did not change, however I think the former version was more bulletproof.

Tue, Nov 19, 6:24 PM
pino committed R883:1556555: remove old obsolete messages.
remove old obsolete messages
Tue, Nov 19, 12:19 PM
pino committed R1045:426d362cf6b0: i18n: remove rc.cpp only after xgettext (authored by pino).
i18n: remove rc.cpp only after xgettext
Tue, Nov 19, 12:13 PM

Sun, Nov 17

pino added a comment to R883:1556373: Import kup translations (all but 'tl').

Import kup translations (all but 'tl')

... and enable extraction.
tl (Tagalog) has not been imported for now
because we don't have any other translation for it.

Sun, Nov 17, 4:09 PM
pino committed R169:f9700eea16eb: i18n: extract messages also from C++ sources (authored by pino).
i18n: extract messages also from C++ sources
Sun, Nov 17, 11:18 AM
pino committed R7:3bf5270d130f: Merge remote-tracking branch 'origin/1.7' (authored by pino).
Merge remote-tracking branch 'origin/1.7'
Sun, Nov 17, 7:24 AM
pino committed R7:44ffe6ca1491: Remove extra Python shebang (authored by pino).
Remove extra Python shebang
Sun, Nov 17, 7:24 AM

Sat, Nov 16

pino added a comment to T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.
In T4803#208465, @pino wrote:
  1. Import the 5 branches (*/l10n-kf5*/scripts and */l10n-kde4/scripts) to Git as subling directories:
    • branches_stable_l10n-kde4

Ugh no, please import them as branches, as they actually are.

As a counter-argument to this statement, I'm going to explain why */l10n-kf5*/ and */l10n-kde4/ are not real branches. Even though the various scripts/ directories are stored under branches/stable/ and trunk/ in SVN, they are not used as branches anymore.

Sat, Nov 16, 10:34 PM · Localization
pino added a comment to T4803: Consolidate {branches/stable,trunk}/l10n-{kde4,kf5}/scripts into a git repository.
  1. Import the 5 branches (*/l10n-kf5*/scripts and */l10n-kde4/scripts) to Git as subling directories:
    • branches_stable_l10n-kde4
    • branches_stable_l10n-kf5
    • branches_stable_l10n-kf5-plasma-lts
    • trunk_l10n-kde4
    • trunk_l10n-kf5
Sat, Nov 16, 5:22 PM · Localization
pino committed R321:b566a2ad4b75: appdata: update homepage and help URLs (authored by pino).
appdata: update homepage and help URLs
Sat, Nov 16, 11:33 AM

Fri, Nov 15

pino committed R470:f90e7f21a85e: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Fri, Nov 15, 9:55 PM
pino committed R470:dd03ad35f053: appdata: sort versions by most recent ones (authored by pino).
appdata: sort versions by most recent ones
Fri, Nov 15, 9:49 PM
pino committed R1026:22db12512239: cmake: remove zlib requirement (authored by pino).
cmake: remove zlib requirement
Fri, Nov 15, 9:28 PM

Sun, Nov 10

pino requested changes to D24987: Add Kompare as compare application with KIO support.

Mostly OK from my POV, just please remove the unrelated changes to the patch (i.e. the brackets additions in two places).
I have no idea what "Boy Scout rule" is supposed to mean, however adding unrelated changes makes history reading harder, especially when wanting to check why certain changes were done. Again, material for a different patch than this.

Sun, Nov 10, 5:26 PM · Krusader

Sat, Nov 9

pino committed R52:35d7813028e9: Merge remote-tracking branch 'origin/5.4' (authored by pino).
Merge remote-tracking branch 'origin/5.4'
Sat, Nov 9, 3:21 PM
pino committed R52:983e9994e5f5: Update phpfunctions.php to phpdoc revision 348276. (authored by pino).
Update phpfunctions.php to phpdoc revision 348276.
Sat, Nov 9, 3:20 PM

Nov 6 2019

pino committed R488:35862f3ac002: cmake: remove use of old PHONON_BUILD_PHONON4QT5 (authored by pino).
cmake: remove use of old PHONON_BUILD_PHONON4QT5
Nov 6 2019, 7:06 PM

Nov 5 2019

pino committed R482:485697525619: i18n: "Ok" -> "OK" (authored by pino).
i18n: "Ok" -> "OK"
Nov 5 2019, 6:49 AM

Nov 2 2019

pino requested changes to D24987: Add Kompare as compare application with KIO support.
Nov 2 2019, 10:48 PM · Krusader

Oct 31 2019

pino added a comment to D25095: Include fixx11.h to fix the build with Qt 5.14.

Not sure if that makes it worth to depend on KWindowSystem, or if it's maybe better to copy the header over.

Oct 31 2019, 6:03 PM
pino added a comment to D25095: Include fixx11.h to fix the build with Qt 5.14.

IMHO:

  • moving includes like this is more an hack than a real solution, as future changes in other Qt includes may cause this issue again -- see also the comment right before the phonon include...
  • the real solution is to #include <fixx11h.h> right after the X11 includes -- see the KWindowSystem framework
Oct 31 2019, 4:55 PM
pino committed R71:59ca6b5858b7: add override where needed (authored by pino).
add override where needed
Oct 31 2019, 7:49 AM
pino committed R71:18cbb5c92bad: Q_DECL_OVERRIDE -> override (authored by pino).
Q_DECL_OVERRIDE -> override
Oct 31 2019, 7:49 AM
pino committed R71:1881c071635e: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Oct 31 2019, 7:30 AM
pino committed R71:66f7d02bfa02: Q_DECL_OVERRIDE -> override (authored by pino).
Q_DECL_OVERRIDE -> override
Oct 31 2019, 7:11 AM
pino committed R71:4f8f15669e39: add override where needed (authored by pino).
add override where needed
Oct 31 2019, 7:11 AM

Oct 29 2019

pino committed R1026:f906c1066582: appdata: switch http URLs to https (authored by pino).
appdata: switch http URLs to https
Oct 29 2019, 11:16 AM
pino committed R15:33646b3455dc: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Oct 29 2019, 7:07 AM
pino committed R15:40cdaea4d782: PgSQL driver: fix build with PostgreSQL 12+ (authored by pino).
PgSQL driver: fix build with PostgreSQL 12+
Oct 29 2019, 6:53 AM

Oct 25 2019

pino added a comment to D24476: [KPropertiesDialog] Only show volume-related info for volumes.

Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount.

Don't you already have the free space information in the status bar though?

Oct 25 2019, 10:08 PM · Frameworks

Oct 24 2019

pino committed R458:9bf4f87ea55d: cmake: build/run tests only when enabled (authored by pino).
cmake: build/run tests only when enabled
Oct 24 2019, 6:11 PM

Oct 22 2019

pino committed R216:e292f14be062: debchangelog: add Focal Fossa (authored by pino).
debchangelog: add Focal Fossa
Oct 22 2019, 7:26 PM

Oct 12 2019

pino committed R226:b5d81938d345: Merge remote-tracking branch 'origin/Applications/19.08' (authored by pino).
Merge remote-tracking branch 'origin/Applications/19.08'
Oct 12 2019, 3:10 PM
pino committed R226:9119e90c00eb: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 (authored by stefanocrocco).
Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12
Oct 12 2019, 3:10 PM
pino committed R238:4a7d60c5cc90: man: use <arg> instead of <group> (authored by pino).
man: use <arg> instead of <group>
Oct 12 2019, 10:41 AM
pino committed R7:c01d1b6e4501: Merge remote-tracking branch 'origin/1.7' (authored by pino).
Merge remote-tracking branch 'origin/1.7'
Oct 12 2019, 6:31 AM
pino committed R7:d4d694b895ef: appdata: use https for URLs (authored by pino).
appdata: use https for URLs
Oct 12 2019, 6:28 AM

Oct 10 2019

pino committed R13:36a0a63a9659: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Oct 10 2019, 5:41 AM
pino committed R13:e1bdc4e6e857: Restore KPropertyDoubleSpinBox::resizeEvent() override (authored by pino).
Restore KPropertyDoubleSpinBox::resizeEvent() override
Oct 10 2019, 5:40 AM

Oct 5 2019

pino committed R1026:a18049be089f: fixuifiles (authored by pino).
fixuifiles
Oct 5 2019, 4:31 AM

Oct 2 2019

pino added inline comments to D7446: [Places panel] Revamp the Recently Saved section.
Oct 2 2019, 8:23 PM · Frameworks, Dolphin

Oct 1 2019

pino committed R883:1552885: typo fix.
typo fix
Oct 1 2019, 4:13 PM
pino committed R39:34d82c0eabe0: i18n: use translated section names of highlight defs (authored by pino).
i18n: use translated section names of highlight defs
Oct 1 2019, 4:03 PM
pino committed R39:7c8e51feebbe: i18n: translate placeholder (authored by pino).
i18n: translate placeholder
Oct 1 2019, 4:03 PM
pino committed R216:1873102570c5: i18n: fix context for the "None" definition (authored by pino).
i18n: fix context for the "None" definition
Oct 1 2019, 4:08 AM

Sep 27 2019

pino committed R40:d6f9923063b4: fixuifiles (authored by pino).
fixuifiles
Sep 27 2019, 4:37 AM

Sep 24 2019

pino added a comment to T11721: Splitting of i18n strings.

! In T11721#201558, @romangg wrote:
If not via newlines could it be possible to make it work by combining strings with +? Like:

i18n("Lorem ipsum dolor sit amet, consectetur adipisici elit, " +
     "sed eiusmod tempor incidunt ut labore et dolore magna aliqua.")

Not sure why this doesn't work at the moment. Is it because of this xgettext tool?

Sep 24 2019, 4:15 AM · Localization, Kirigami, Plasma

Sep 23 2019

pino added a comment to D24154: Add comment to desktop file for KRuler.

Also, please write why a Comment was added, especially that the referenced bug does not explain that either.

Sep 23 2019, 4:38 AM

Sep 22 2019

pino requested changes to D24140: Internationalize the default project name in the title bar.
Sep 22 2019, 3:29 PM
pino added a comment to D24140: Internationalize the default project name in the title bar.

I do not think this solution is correct. The project ID is set by the user, so translating it with i18n() will simply not work.

Sep 22 2019, 3:29 PM

Sep 21 2019

pino added inline comments to D23579: port ftp slave to new error reporting system.
Sep 21 2019, 5:48 AM · Frameworks

Sep 20 2019

pino added a comment to T11721: Splitting of i18n strings.

BTW, since the "100 characters per line" was brought as single argument, let's actually check what the KDE Frameworks Coding Style actually say.
Quoting bits from https://techbase.kde.org/Policies/Frameworks_Coding_Style (emphases mine):

Sep 20 2019, 6:02 AM · Localization, Kirigami, Plasma

Sep 19 2019

pino committed R104:6ae066c02573: i18n fixes (authored by pino).
i18n fixes
Sep 19 2019, 4:39 AM
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.

@aspotashev: please read the discussion in this review request...

Sep 19 2019, 3:32 AM · Plasma

Sep 17 2019

pino added a comment to D23815: [KConfig] port away from deprecated methods in Qt 5.14.

If we want to enable this flag (to "punish" the first KDE developer who upgrades Qt, like me currently), then at least we should only do so in git checkouts, not in release tarballs.
This is easy to do: if (EXISTS "${CMAKE_SOURCE_DIR}/.git").

Sep 17 2019, 4:38 AM · Frameworks

Sep 14 2019

pino committed R883:1551657: fill empty Language headers.
fill empty Language headers
Sep 14 2019, 5:38 AM
pino committed R883:1551656: fill empty Language headers.
fill empty Language headers
Sep 14 2019, 5:35 AM
pino committed R341:38eea27b1f29: i18n: fix extraction of objectinfo HTML files (authored by pino).
i18n: fix extraction of objectinfo HTML files
Sep 14 2019, 5:32 AM

Sep 13 2019

pino committed R245:eaa8ed787333: fstab: include QThreadStorage in all cases (authored by pino).
fstab: include QThreadStorage in all cases
Sep 13 2019, 5:27 PM

Sep 8 2019

pino added a reverting change for R104:a798e78d477e: [kcm] Fix i18n output file name and split texts: R104:512437cf464e: Partially revert "[kcm] Fix i18n output file name and split texts".
Sep 8 2019, 8:39 PM
pino committed R104:512437cf464e: Partially revert "[kcm] Fix i18n output file name and split texts" (authored by pino).
Partially revert "[kcm] Fix i18n output file name and split texts"
Sep 8 2019, 8:39 PM
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.

BTW: if by 2200 UTC none of the two solutions mentioned above (continuation lines, or single long lines) is implemented, I will revert the majority of a798e78d477e (leaving only the .pot renaming, which is correct).

Sep 8 2019, 3:06 PM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.
In D23783#527582, @pino wrote:

It's a normal QML function ...

If it's just a QML function why is it a problem to + some strings when providing them as an argument?

Sep 8 2019, 1:55 PM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.
diff --git a/kcm/package/contents/ui/main.qml b/kcm/package/contents/ui/main.qml
index 2e61aa5..191daf3 100644
--- a/kcm/package/contents/ui/main.qml
+++ b/kcm/package/contents/ui/main.qml
@@ -41,8 +41,8 @@ KCM.SimpleKCM {
 
             Layout.fillWidth: true
             type: Kirigami.MessageType.Warning
-            text: i18n("Are you sure you want to disable all outputs? ") +
-                  i18n("This might render the device unusable.")
+            text: i18n("Are you sure you want to disable all outputs? \
+This might render the device unusable.")
             showCloseButton: true
 
             actions: [

This also works, but it's ugly because the second line has not the right indent.

Sep 8 2019, 9:03 AM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.
In D23783#527579, @pino wrote:

Which macro?

i18n(...) or "function"?

Sep 8 2019, 8:49 AM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.
In D23783#527562, @pino wrote:

Please do not split the messages just for sake of column width.

If there is a better solution than splitting text with a + while still respecting the line chars limit I will upload a new patch.

Sep 8 2019, 8:47 AM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.

Please do not split the messages just for sake of column width.

Sep 8 2019, 8:35 AM · Plasma
pino committed R883:1551343: updates.
updates
Sep 8 2019, 6:50 AM

Sep 4 2019

pino added inline comments to D23713: strongswan support for custom proposals.
Sep 4 2019, 4:58 AM · Plasma, Frameworks

Sep 3 2019

pino added a comment to D23667: Add == and != operators to KIO::UDSEntry.

please use QCOMPARE/QVERIFY instead of Q_ASSERT in QTest tests

Sep 3 2019, 10:02 PM · Frameworks
pino added a comment to D23667: Add == and != operators to KIO::UDSEntry.

Oh, and also please add tests for them in UDSEntryTest.

Sep 3 2019, 4:39 AM · Frameworks
pino added a comment to D23667: Add == and != operators to KIO::UDSEntry.

Please move the implementations in the cpp file, otherwise it will be impossible to change/fix the implementation later on in a binary compatible way.

Sep 3 2019, 4:38 AM · Frameworks

Sep 2 2019

pino added inline comments to D22510: Added dialog to set execute permission for executable file when trying to run it..
Sep 2 2019, 5:25 PM · Frameworks
pino committed R883:1550841: remove old doc.
remove old doc
Sep 2 2019, 4:09 AM

Aug 29 2019

pino added inline comments to D23538: [dolphin] Animate gifs on preview.
Aug 29 2019, 9:05 PM · Dolphin

Aug 27 2019

pino committed R119:4064c065a47a: i18n fixes (authored by pino).
i18n fixes
Aug 27 2019, 3:56 AM

Aug 26 2019

pino added inline comments to D23470: Offer an xdg-compatible mode for convertToQVariant.
Aug 26 2019, 5:39 PM · Frameworks

Aug 23 2019

pino added a comment to D23364: Remove QtMultimedia as playback option.

(Not arguing for or against this patch, just providing more info on the Fedora situation.)

Aug 23 2019, 4:04 AM · Elisa

Aug 22 2019

pino added a comment to D23332: [Aurorae] Don't delay initial blit..

FWIW there is a typo in the commit title: "Aurorea" -> "Aurorae"

Aug 22 2019, 4:49 AM · KWin
pino added a comment to D23309: Change the document about helping Krusader, add other ways.

The only problem with https://krusader.org/get-involved/ is that it is even more conservative than our user docs

Aug 22 2019, 4:47 AM · Krusader, Documentation

Aug 21 2019

pino added a comment to D23309: Change the document about helping Krusader, add other ways.

Note: There are some reasons why Krusader users have documentation available in their computers, maybe Yuri Chornoivan can give more information about it.

Aug 21 2019, 7:17 AM · Krusader, Documentation
pino added a comment to D23309: Change the document about helping Krusader, add other ways.

TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.
Just like we do not add compilation/build instructions to documentations anymore, IMHO it makes sense to not add contribution instructions either: they are generally not related to "using the application", and thus the old documentation shipped with an old version would show outdated links. Some of the changes in this patch perfectly show this: imagine that users installing krusader in stable distros have outdated links to freshmeat and linux-apps in the documentation they read.

Aug 21 2019, 5:03 AM · Krusader, Documentation

Aug 19 2019

pino added a comment to D23250: Only display old and new versions when both are available.

This looks like a workaround to me: if installedVersion is not available (is it known when, actually?), why keep using it anyway, with or without i18n?
Also, -1 to string puzzles and to UI strings not translatable.

Aug 19 2019, 4:59 AM · Plasma