pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (177 w, 5 d)
Availability
Available

Recent Activity

Today

pino added a comment to D23309: Change the document about helping Krusader, add other ways.

Note: There are some reasons why Krusader users have documentation available in their computers, maybe Yuri Chornoivan can give more information about it.

Wed, Aug 21, 7:17 AM · Documentation, Krusader
pino added a comment to D23309: Change the document about helping Krusader, add other ways.

TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.
Just like we do not add compilation/build instructions to documentations anymore, IMHO it makes sense to not add contribution instructions either: they are generally not related to "using the application", and thus the old documentation shipped with an old version would show outdated links. Some of the changes in this patch perfectly show this: imagine that users installing krusader in stable distros have outdated links to freshmeat and linux-apps in the documentation they read.

Wed, Aug 21, 5:03 AM · Documentation, Krusader

Mon, Aug 19

pino added a comment to D23250: Only display old and new versions when both are available.

This looks like a workaround to me: if installedVersion is not available (is it known when, actually?), why keep using it anyway, with or without i18n?
Also, -1 to string puzzles and to UI strings not translatable.

Mon, Aug 19, 4:59 AM · Plasma

Sat, Aug 17

pino added a comment to D23224: Fix capitalization of Nextcloud.

I'm guessing the changed English strings will trigger a "untranslated string" warning in the translation software, so the translators should notice it, right?

Sat, Aug 17, 4:57 PM · Frameworks
pino added a comment to D23224: Fix capitalization of Nextcloud.

Please do not change the translations manually -- there is an automatic system that takes care of extracting the English strings, and merging back the translators for desktop/json/xml/alike files.

Sat, Aug 17, 4:46 PM · Frameworks

Thu, Aug 15

pino committed R440:c69858f39f22: Drop config.h (authored by pino).
Drop config.h
Thu, Aug 15, 5:57 AM
pino committed R440:89a8627fd298: Use ECMSetupVersion (authored by pino).
Use ECMSetupVersion
Thu, Aug 15, 5:57 AM
pino committed R440:d7133edfd9b0: Remove dead/unused config.h includes (authored by pino).
Remove dead/unused config.h includes
Thu, Aug 15, 5:57 AM

Tue, Aug 13

pino committed R37:c5f53ebd1f5b: i18n fixes (authored by pino).
i18n fixes
Tue, Aug 13, 7:38 PM

Mon, Aug 12

pino added a comment to D23106: Allow the user to select the JPEG save/compression quality.

It is implemented purely as a setting in the settings dialog rather than a new
part of the save dialog because that would add a kdelibs4support dependency and
not be compatible with Flatpak portals.

Mon, Aug 12, 4:48 AM · Gwenview

Sun, Aug 11

pino committed R52:32f7a5717cde: i18n: update message to new default (authored by pino).
i18n: update message to new default
Sun, Aug 11, 2:00 PM
pino committed R52:0c50eaab22cf: Merge remote-tracking branch 'origin/5.4' (authored by pino).
Merge remote-tracking branch 'origin/5.4'
Sun, Aug 11, 2:00 PM
pino committed R52:7dbc9c1e30c5: Update phpfunctions.php to phpdoc revision 347831. (authored by pino).
Update phpfunctions.php to phpdoc revision 347831.
Sun, Aug 11, 1:58 PM
pino committed R52:aec473c02c8d: Switch few http URLs to https (authored by pino).
Switch few http URLs to https
Sun, Aug 11, 1:58 PM

Fri, Aug 9

pino added inline comments to D23027: Add information about substituting font into properties dialog.
Fri, Aug 9, 7:48 AM · Okular
pino added a comment to D23037: Add support for cb7 comic book archives.

why did you abandon this?

Fri, Aug 9, 7:47 AM · Okular
pino added inline comments to D23027: Add information about substituting font into properties dialog.
Fri, Aug 9, 6:56 AM · Okular
pino added a comment to D23037: Add support for cb7 comic book archives.

Please do not manually change translated keys in desktop files: there is an automatic system that takes care of them.

Fri, Aug 9, 6:55 AM · Okular
pino committed R457:dbdbdfe2b127: Merge remote-tracking branch 'origin/0.26' (authored by pino).
Merge remote-tracking branch 'origin/0.26'
Fri, Aug 9, 6:33 AM
pino committed R457:7a64e4a3aee1: Fix typos in license texts (authored by pino).
Fix typos in license texts
Fri, Aug 9, 6:33 AM

Thu, Aug 8

pino committed R365:46f28ab0f0ee: appdata: add missing </li> (authored by pino).
appdata: add missing </li>
Thu, Aug 8, 5:19 AM

Mon, Aug 5

pino committed R883:1548859: few updates.
few updates
Mon, Aug 5, 9:05 PM

Sat, Aug 3

pino committed R883:1548563: update.
update
Sat, Aug 3, 9:32 AM

Tue, Jul 30

pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

That as well, as also discussed on irc today.

Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test that, this patch might allow to at least get the api.kde.org being updated again, which it was not since April for all the repos covered by kapidox.

I agree that getting api.kde.org uo to date again is a priority.

Tue, Jul 30, 9:26 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Ok, yep i may have misunderstood :)

But if you say "kapidox supports Python 2.7" we need to commit this to keep it true :)

Tue, Jul 30, 9:23 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Pino please take a step back and rethink your position.
Yes, supporting Python2 sucks, but this is 2 lines of code while porting everything to Python 3 is lots of work more.

Tue, Jul 30, 9:15 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Let me add one more thing: I understand you care about API docs, about making them available for our users on api.kde.org, and about giving the best impression possible about them (I remember various patches about that in the past).

Tue, Jul 30, 8:05 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.
In D22836#504358, @pino wrote:

Oh dear, and what about switching the api generation to Python 3 instead?

Nobody is stopped to work on that. I am not a Python expert, I just providing here the small fix which fall off from me local testing at why the build fails. Which also includes testing whether the bug reproduced locally also is seen with Python3 (it is not). Sorry if I left out this details here, they had been mentioned on Sysadmin.

This fix could "potentially" just buy some more time, and not solve the issue of keep using Python 2 further.

Keeping things broken has not worked to make you switch api.kde.org to Python3, right? ;)

Tue, Jul 30, 8:01 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.
In D22836#504356, @pino wrote:

Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test that,

At this point, making Python stuff work with Python3 is priority one.

Oh dear, any chance we could look at this simple fix provided here, which get us potentially api.kde.org back the day this simple patch is confirmed and in?

Tue, Jul 30, 7:12 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test that,

Tue, Jul 30, 6:53 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Or maybe just drop support for Python 2 entirely?

  • kapidox is rarely used
  • Python 2 will be EOL in 5 months
  • distros either switched kapidox to Python 3, or will do it soon
Tue, Jul 30, 6:40 PM · Documentation, Frameworks
pino added a comment to D22837: Update atom feed for new site.

Iàd say to commit it directly - it's your website, after all.

Tue, Jul 30, 6:38 PM
pino committed R23:aceab06cbf1a: i18n: fix string puzzle (authored by pino).
i18n: fix string puzzle
Tue, Jul 30, 4:35 AM

Mon, Jul 29

pino committed R262:04d842eaa5b7: i18n: typo fix (authored by pino).
i18n: typo fix
Mon, Jul 29, 3:28 AM

Sun, Jul 28

pino committed R883:1547847: fill empty Language headers.
fill empty Language headers
Sun, Jul 28, 2:03 PM
pino committed R883:1547834: updates of unmaintained.
updates of unmaintained
Sun, Jul 28, 11:28 AM
pino committed R883:1547808: fill empty Language headers.
fill empty Language headers
Sun, Jul 28, 6:56 AM

Sat, Jul 27

pino committed R883:1547783: update.
update
Sat, Jul 27, 4:21 PM
pino committed R883:1547782: updates of unmaintained/unassigned.
updates of unmaintained/unassigned
Sat, Jul 27, 4:21 PM
pino committed R384:0bd4296962c2: i18n: use a plural form where needed (authored by pino).
i18n: use a plural form where needed
Sat, Jul 27, 4:19 PM
pino committed R32:70296f1a7688: Merge remote-tracking branch 'origin/5.4' (authored by pino).
Merge remote-tracking branch 'origin/5.4'
Sat, Jul 27, 4:02 PM
pino committed R32:271e4f0fc1c7: i18n: use plural forms where needed (authored by pino).
i18n: use plural forms where needed
Sat, Jul 27, 3:50 PM
pino committed R226:7aea9156d25d: i18n: spell "D-Bus" correctly (authored by pino).
i18n: spell "D-Bus" correctly
Sat, Jul 27, 3:48 PM
pino committed R883:1547779: updates.
updates
Sat, Jul 27, 3:41 PM

Thu, Jul 25

pino requested changes to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

other than building, please also check that it actually still works on Linux

Thu, Jul 25, 4:33 AM · Frameworks, Dolphin

Tue, Jul 23

pino committed R883:1547321: typo fix.
typo fix
Tue, Jul 23, 5:48 AM

Jul 22 2019

pino committed R262:9bee13cb7c83: fixuifiles (authored by pino).
fixuifiles
Jul 22 2019, 3:24 AM

Jul 21 2019

pino added a comment to D22616: Remove phonon KCM.

@sitter said he has a version of the settings to be integtated into phonon so the remaining three users can still access them

this

Jul 21 2019, 6:50 PM · Plasma
pino added a comment to D22616: Remove phonon KCM.

Erm, so what if you do not use plasma-pa?

Jul 21 2019, 5:03 PM · Plasma
pino added a comment to D22605: Set notifications entry icon size to medium.

I would like to test it and post a screenshot, however I am not able to compile it:

  1. I cloned the source from the git repository
  2. mkdir plasma-workspace/applets/notifications/build
  3. cd plasma-workspace/applets/notifications/build
  4. cmake ..

    This resulted in ` CMake Error at CMakeLists.txt:11 (kcoreaddons_desktop_to_json): Unknown CMake command "kcoreaddons_desktop_to_json". `
Jul 21 2019, 10:09 AM · Plasma
pino added a comment to D22606: add missing semicolon.

Patch landed, and build successfully everywhere.
Congratulations for your first patch :)

Jul 21 2019, 9:47 AM · Baloo, Frameworks
pino committed R286:8f23194f7891: add missing semicolon (authored by antonioh).
add missing semicolon
Jul 21 2019, 9:40 AM
pino closed D22606: add missing semicolon.
Jul 21 2019, 9:40 AM · Baloo, Frameworks
pino accepted D22606: add missing semicolon.

Do you have permissions to push patches on your own? If not, please specify your email so I can properly attribute this patch to you.

Jul 21 2019, 9:33 AM · Baloo, Frameworks
pino added a comment to R262:2db4e2c9ceb5: [translation] add copy of po files for building packages.

@sgerlach why?? please do NOT copy translations statically into sources!

Jul 21 2019, 9:19 AM
pino added a comment to D22599: Make first and last name available separately.

How would first + last name work, when
a) you have multiple first names
b) you have multiple last names
c) you have only one "name" -- http://wookware.org/name.html

Jul 21 2019, 9:17 AM · Frameworks
pino committed R466:5581d10c5215: i18n: reduce the string puzzles (authored by pino).
i18n: reduce the string puzzles
Jul 21 2019, 9:13 AM
pino added inline comments to D22064: General improvements to stamp annotation.
Jul 21 2019, 8:54 AM · Okular
pino added inline comments to D22105: Fix SFTP Plugin of KIO for Windows.
Jul 21 2019, 8:43 AM · Frameworks, Dolphin
pino committed R71:a86e74fc6364: Fix build with Qt 5.13 (authored by lbeltrame).
Fix build with Qt 5.13
Jul 21 2019, 8:06 AM
pino committed R470:43851a0a655a: Fix build with Qt 5.13 (authored by lbeltrame).
Fix build with Qt 5.13
Jul 21 2019, 8:05 AM
pino added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

drop translations

Jul 21 2019, 8:01 AM · Plasma
pino added a comment to D22601: i18n: Add context @title:window to window titles.

Since you are changing the strings, I suggest changing them to bein line with the HIG:
https://hig.kde.org/style/writing/capitalization.html

Jul 21 2019, 5:43 AM · KDE PIM

Jul 20 2019

pino added inline comments to D22588: [Pager] Don't link kdelibs4support.
Jul 20 2019, 4:09 PM · Plasma
pino committed R883:1547126: updates.
updates
Jul 20 2019, 1:19 PM
pino committed R883:1547104: fill empty Language headers.
fill empty Language headers
Jul 20 2019, 5:10 AM
pino committed R883:1547102: fill empty Language headers.
fill empty Language headers
Jul 20 2019, 4:48 AM
pino added a comment to D22545: Add missing include QDate.
In D22545#498239, @usta wrote:

i will just commit this to master or do i need to xommit to a branch then merge it to master ?

Jul 20 2019, 3:25 AM · Calligra: 3.0

Jul 19 2019

pino committed R1045:b3f50790b43a: HistoryDialog: use QDialogButtonBox (authored by pino).
HistoryDialog: use QDialogButtonBox
Jul 19 2019, 5:35 AM

Jul 18 2019

pino committed R32:9f33bbadbfcb: fixuifiles (authored by pino).
fixuifiles
Jul 18 2019, 3:08 AM

Jul 17 2019

pino committed R32:707fbbfb43ae: doc: drop all bits related to installation (authored by pino).
doc: drop all bits related to installation
Jul 17 2019, 3:46 AM

Jul 16 2019

pino committed R883:1546824: remove duplicate templates.
remove duplicate templates
Jul 16 2019, 6:05 AM
pino committed R883:1546819: fix message.
fix message
Jul 16 2019, 5:34 AM
pino committed R883:1546818: fill empty Language fields.
fill empty Language fields
Jul 16 2019, 5:10 AM
pino committed R883:1546817: fill empty Language fields.
fill empty Language fields
Jul 16 2019, 5:06 AM
pino committed R883:1546816: fill empty Language fields.
fill empty Language fields
Jul 16 2019, 5:06 AM
pino committed R883:1546814: fuzzy strings which definitely need a revision....
fuzzy strings which definitely need a revision...
Jul 16 2019, 4:47 AM
pino committed R470:c9bbdff863c9: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Jul 16 2019, 4:43 AM
pino committed R470:0e74227a9fd1: i18n: translate UI string (authored by pino).
i18n: translate UI string
Jul 16 2019, 4:36 AM

Jul 15 2019

pino committed R883:1546744: manually fix template.
manually fix template
Jul 15 2019, 6:11 AM
pino committed R318:c2312b1323da: i18n: drop servicemenuinstaller messages from main po file (authored by pino).
i18n: drop servicemenuinstaller messages from main po file
Jul 15 2019, 6:09 AM
pino committed R225:67f10ab694aa: i18n: drop obsolete messages before merging (authored by pino).
i18n: drop obsolete messages before merging
Jul 15 2019, 6:06 AM
pino committed R225:c1006d87e1d1: i18n: prune @-langs earlier on translation import (authored by pino).
i18n: prune @-langs earlier on translation import
Jul 15 2019, 5:40 AM

Jul 14 2019

pino committed R883:1546667: fill empty Language headers.
fill empty Language headers
Jul 14 2019, 6:52 AM
pino committed R883:1546662: fill empty Language headers.
fill empty Language headers
Jul 14 2019, 5:08 AM
pino committed R883:1546661: fill empty Language headers.
fill empty Language headers
Jul 14 2019, 5:05 AM

Jul 13 2019

pino committed R883:1546562: updates.
updates
Jul 13 2019, 5:54 AM

Jul 12 2019

pino committed R247:81c815d59046: GIT_SILENT remove spurious empty file (authored by pino).
GIT_SILENT remove spurious empty file
Jul 12 2019, 3:22 AM

Jul 11 2019

pino committed R871:b6c5c1079e33: fixuifiles (authored by pino).
fixuifiles
Jul 11 2019, 2:49 AM

Jul 7 2019

pino committed R876:69ede74af4b4: switch away from QSignalMapper (authored by pino).
switch away from QSignalMapper
Jul 7 2019, 3:55 PM
pino committed R883:1545911: update.
update
Jul 7 2019, 8:51 AM
pino committed R883:1545898: updates.
updates
Jul 7 2019, 5:19 AM
pino committed R883:1545897: check_po_files.
check_po_files
Jul 7 2019, 5:10 AM
pino committed R883:1545896: fill empty Language headers.
fill empty Language headers
Jul 7 2019, 4:54 AM

Jul 6 2019

pino committed R72:8b04e5931336: i18n fixes (authored by pino).
i18n fixes
Jul 6 2019, 12:22 PM
pino committed R883:1545802: updates.
updates
Jul 6 2019, 11:46 AM
pino committed R883:1545762: update and complete.
update and complete
Jul 6 2019, 8:27 AM
pino committed R883:1545761: updates.
updates
Jul 6 2019, 8:20 AM
pino committed R883:1545749: check_po_files.
check_po_files
Jul 6 2019, 5:22 AM
pino added inline comments to D22199: New plugin to open the selected file path.
Jul 6 2019, 3:31 AM · Documentation, Kate