pino (Pino Toscano)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2016, 4:10 PM (185 w, 2 d)
Availability
Available

Recent Activity

Sat, Oct 12

pino committed R226:b5d81938d345: Merge remote-tracking branch 'origin/Applications/19.08' (authored by pino).
Merge remote-tracking branch 'origin/Applications/19.08'
Sat, Oct 12, 3:10 PM
pino committed R226:9119e90c00eb: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 (authored by stefanocrocco).
Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12
Sat, Oct 12, 3:10 PM
pino committed R238:4a7d60c5cc90: man: use <arg> instead of <group> (authored by pino).
man: use <arg> instead of <group>
Sat, Oct 12, 10:41 AM
pino committed R7:c01d1b6e4501: Merge remote-tracking branch 'origin/1.7' (authored by pino).
Merge remote-tracking branch 'origin/1.7'
Sat, Oct 12, 6:31 AM
pino committed R7:d4d694b895ef: appdata: use https for URLs (authored by pino).
appdata: use https for URLs
Sat, Oct 12, 6:28 AM

Thu, Oct 10

pino committed R13:36a0a63a9659: Merge remote-tracking branch 'origin/3.2' (authored by pino).
Merge remote-tracking branch 'origin/3.2'
Thu, Oct 10, 5:41 AM
pino committed R13:e1bdc4e6e857: Restore KPropertyDoubleSpinBox::resizeEvent() override (authored by pino).
Restore KPropertyDoubleSpinBox::resizeEvent() override
Thu, Oct 10, 5:40 AM

Sat, Oct 5

pino committed R1026:a18049be089f: fixuifiles (authored by pino).
fixuifiles
Sat, Oct 5, 4:31 AM

Wed, Oct 2

pino added inline comments to D7446: [Places panel] Revamp the Recently Saved section.
Wed, Oct 2, 8:23 PM · Frameworks, Dolphin

Tue, Oct 1

pino committed R883:1552885: typo fix.
typo fix
Tue, Oct 1, 4:13 PM
pino committed R39:34d82c0eabe0: i18n: use translated section names of highlight defs (authored by pino).
i18n: use translated section names of highlight defs
Tue, Oct 1, 4:03 PM
pino committed R39:7c8e51feebbe: i18n: translate placeholder (authored by pino).
i18n: translate placeholder
Tue, Oct 1, 4:03 PM
pino committed R216:1873102570c5: i18n: fix context for the "None" definition (authored by pino).
i18n: fix context for the "None" definition
Tue, Oct 1, 4:08 AM

Fri, Sep 27

pino committed R40:d6f9923063b4: fixuifiles (authored by pino).
fixuifiles
Fri, Sep 27, 4:37 AM

Tue, Sep 24

pino added a comment to T11721: Splitting of i18n strings.

! In T11721#201558, @romangg wrote:
If not via newlines could it be possible to make it work by combining strings with +? Like:

i18n("Lorem ipsum dolor sit amet, consectetur adipisici elit, " +
     "sed eiusmod tempor incidunt ut labore et dolore magna aliqua.")

Not sure why this doesn't work at the moment. Is it because of this xgettext tool?

Tue, Sep 24, 4:15 AM · Localization, Kirigami, Plasma

Mon, Sep 23

pino added a comment to D24154: Add comment to desktop file for KRuler.

Also, please write why a Comment was added, especially that the referenced bug does not explain that either.

Mon, Sep 23, 4:38 AM

Sun, Sep 22

pino requested changes to D24140: Internationalize the default project name in the title bar.
Sun, Sep 22, 3:29 PM
pino added a comment to D24140: Internationalize the default project name in the title bar.

I do not think this solution is correct. The project ID is set by the user, so translating it with i18n() will simply not work.

Sun, Sep 22, 3:29 PM

Sat, Sep 21

pino added inline comments to D23579: port ftp slave to new error reporting system.
Sat, Sep 21, 5:48 AM · Frameworks

Fri, Sep 20

pino added a comment to T11721: Splitting of i18n strings.

BTW, since the "100 characters per line" was brought as single argument, let's actually check what the KDE Frameworks Coding Style actually say.
Quoting bits from https://techbase.kde.org/Policies/Frameworks_Coding_Style (emphases mine):

Fri, Sep 20, 6:02 AM · Localization, Kirigami, Plasma

Thu, Sep 19

pino committed R104:6ae066c02573: i18n fixes (authored by pino).
i18n fixes
Thu, Sep 19, 4:39 AM
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.

@aspotashev: please read the discussion in this review request...

Thu, Sep 19, 3:32 AM · Plasma

Tue, Sep 17

pino added a comment to D23815: [KConfig] port away from deprecated methods in Qt 5.14.

If we want to enable this flag (to "punish" the first KDE developer who upgrades Qt, like me currently), then at least we should only do so in git checkouts, not in release tarballs.
This is easy to do: if (EXISTS "${CMAKE_SOURCE_DIR}/.git").

Tue, Sep 17, 4:38 AM · Frameworks

Sep 14 2019

pino committed R883:1551657: fill empty Language headers.
fill empty Language headers
Sep 14 2019, 5:38 AM
pino committed R883:1551656: fill empty Language headers.
fill empty Language headers
Sep 14 2019, 5:35 AM
pino committed R341:38eea27b1f29: i18n: fix extraction of objectinfo HTML files (authored by pino).
i18n: fix extraction of objectinfo HTML files
Sep 14 2019, 5:32 AM

Sep 13 2019

pino committed R245:eaa8ed787333: fstab: include QThreadStorage in all cases (authored by pino).
fstab: include QThreadStorage in all cases
Sep 13 2019, 5:27 PM

Sep 8 2019

pino added a reverting change for R104:a798e78d477e: [kcm] Fix i18n output file name and split texts: R104:512437cf464e: Partially revert "[kcm] Fix i18n output file name and split texts".
Sep 8 2019, 8:39 PM
pino committed R104:512437cf464e: Partially revert "[kcm] Fix i18n output file name and split texts" (authored by pino).
Partially revert "[kcm] Fix i18n output file name and split texts"
Sep 8 2019, 8:39 PM
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.

BTW: if by 2200 UTC none of the two solutions mentioned above (continuation lines, or single long lines) is implemented, I will revert the majority of a798e78d477e (leaving only the .pot renaming, which is correct).

Sep 8 2019, 3:06 PM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.
In D23783#527582, @pino wrote:

It's a normal QML function ...

If it's just a QML function why is it a problem to + some strings when providing them as an argument?

Sep 8 2019, 1:55 PM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.
diff --git a/kcm/package/contents/ui/main.qml b/kcm/package/contents/ui/main.qml
index 2e61aa5..191daf3 100644
--- a/kcm/package/contents/ui/main.qml
+++ b/kcm/package/contents/ui/main.qml
@@ -41,8 +41,8 @@ KCM.SimpleKCM {
 
             Layout.fillWidth: true
             type: Kirigami.MessageType.Warning
-            text: i18n("Are you sure you want to disable all outputs? ") +
-                  i18n("This might render the device unusable.")
+            text: i18n("Are you sure you want to disable all outputs? \
+This might render the device unusable.")
             showCloseButton: true
 
             actions: [

This also works, but it's ugly because the second line has not the right indent.

Sep 8 2019, 9:03 AM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.
In D23783#527579, @pino wrote:

Which macro?

i18n(...) or "function"?

Sep 8 2019, 8:49 AM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.
In D23783#527562, @pino wrote:

Please do not split the messages just for sake of column width.

If there is a better solution than splitting text with a + while still respecting the line chars limit I will upload a new patch.

Sep 8 2019, 8:47 AM · Plasma
pino added a comment to D23783: [kcm] Fix i18n output file name and split texts.

Please do not split the messages just for sake of column width.

Sep 8 2019, 8:35 AM · Plasma
pino committed R883:1551343: updates.
updates
Sep 8 2019, 6:50 AM

Sep 4 2019

pino added inline comments to D23713: strongswan support for custom proposals.
Sep 4 2019, 4:58 AM · Plasma, Frameworks

Sep 3 2019

pino added a comment to D23667: Add == and != operators to KIO::UDSEntry.

please use QCOMPARE/QVERIFY instead of Q_ASSERT in QTest tests

Sep 3 2019, 10:02 PM · Frameworks
pino added a comment to D23667: Add == and != operators to KIO::UDSEntry.

Oh, and also please add tests for them in UDSEntryTest.

Sep 3 2019, 4:39 AM · Frameworks
pino added a comment to D23667: Add == and != operators to KIO::UDSEntry.

Please move the implementations in the cpp file, otherwise it will be impossible to change/fix the implementation later on in a binary compatible way.

Sep 3 2019, 4:38 AM · Frameworks

Sep 2 2019

pino added inline comments to D22510: Added dialog to set execute permission for executable file when trying to run it..
Sep 2 2019, 5:25 PM · Frameworks
pino committed R883:1550841: remove old doc.
remove old doc
Sep 2 2019, 4:09 AM

Aug 29 2019

pino added inline comments to D23538: [dolphin] Animate gifs on preview.
Aug 29 2019, 9:05 PM · Dolphin

Aug 27 2019

pino committed R119:4064c065a47a: i18n fixes (authored by pino).
i18n fixes
Aug 27 2019, 3:56 AM

Aug 26 2019

pino added inline comments to D23470: Offer an xdg-compatible mode for convertToQVariant.
Aug 26 2019, 5:39 PM · Frameworks

Aug 23 2019

pino added a comment to D23364: Remove QtMultimedia as playback option.

(Not arguing for or against this patch, just providing more info on the Fedora situation.)

Aug 23 2019, 4:04 AM · Elisa

Aug 22 2019

pino added a comment to D23332: [Aurorae] Don't delay initial blit..

FWIW there is a typo in the commit title: "Aurorea" -> "Aurorae"

Aug 22 2019, 4:49 AM · KWin
pino added a comment to D23309: Change the document about helping Krusader, add other ways.

The only problem with https://krusader.org/get-involved/ is that it is even more conservative than our user docs

Aug 22 2019, 4:47 AM · Documentation, Krusader

Aug 21 2019

pino added a comment to D23309: Change the document about helping Krusader, add other ways.

Note: There are some reasons why Krusader users have documentation available in their computers, maybe Yuri Chornoivan can give more information about it.

Aug 21 2019, 7:17 AM · Documentation, Krusader
pino added a comment to D23309: Change the document about helping Krusader, add other ways.

TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.
Just like we do not add compilation/build instructions to documentations anymore, IMHO it makes sense to not add contribution instructions either: they are generally not related to "using the application", and thus the old documentation shipped with an old version would show outdated links. Some of the changes in this patch perfectly show this: imagine that users installing krusader in stable distros have outdated links to freshmeat and linux-apps in the documentation they read.

Aug 21 2019, 5:03 AM · Documentation, Krusader

Aug 19 2019

pino added a comment to D23250: Only display old and new versions when both are available.

This looks like a workaround to me: if installedVersion is not available (is it known when, actually?), why keep using it anyway, with or without i18n?
Also, -1 to string puzzles and to UI strings not translatable.

Aug 19 2019, 4:59 AM · Plasma

Aug 17 2019

pino added a comment to D23224: Fix capitalization of Nextcloud.

I'm guessing the changed English strings will trigger a "untranslated string" warning in the translation software, so the translators should notice it, right?

Aug 17 2019, 4:57 PM · Frameworks
pino added a comment to D23224: Fix capitalization of Nextcloud.

Please do not change the translations manually -- there is an automatic system that takes care of extracting the English strings, and merging back the translators for desktop/json/xml/alike files.

Aug 17 2019, 4:46 PM · Frameworks

Aug 15 2019

pino committed R440:c69858f39f22: Drop config.h (authored by pino).
Drop config.h
Aug 15 2019, 5:57 AM
pino committed R440:89a8627fd298: Use ECMSetupVersion (authored by pino).
Use ECMSetupVersion
Aug 15 2019, 5:57 AM
pino committed R440:d7133edfd9b0: Remove dead/unused config.h includes (authored by pino).
Remove dead/unused config.h includes
Aug 15 2019, 5:57 AM

Aug 13 2019

pino committed R37:c5f53ebd1f5b: i18n fixes (authored by pino).
i18n fixes
Aug 13 2019, 7:38 PM

Aug 12 2019

pino added a comment to D23106: Allow the user to select the JPEG save/compression quality.

It is implemented purely as a setting in the settings dialog rather than a new
part of the save dialog because that would add a kdelibs4support dependency and
not be compatible with Flatpak portals.

Aug 12 2019, 4:48 AM · Gwenview

Aug 11 2019

pino committed R52:32f7a5717cde: i18n: update message to new default (authored by pino).
i18n: update message to new default
Aug 11 2019, 2:00 PM
pino committed R52:0c50eaab22cf: Merge remote-tracking branch 'origin/5.4' (authored by pino).
Merge remote-tracking branch 'origin/5.4'
Aug 11 2019, 2:00 PM
pino committed R52:7dbc9c1e30c5: Update phpfunctions.php to phpdoc revision 347831. (authored by pino).
Update phpfunctions.php to phpdoc revision 347831.
Aug 11 2019, 1:58 PM
pino committed R52:aec473c02c8d: Switch few http URLs to https (authored by pino).
Switch few http URLs to https
Aug 11 2019, 1:58 PM

Aug 9 2019

pino added inline comments to D23027: Add information about substituting font into properties dialog.
Aug 9 2019, 7:48 AM · Okular
pino added a comment to D23037: Add support for cb7 comic book archives.

why did you abandon this?

Aug 9 2019, 7:47 AM · Okular
pino added inline comments to D23027: Add information about substituting font into properties dialog.
Aug 9 2019, 6:56 AM · Okular
pino added a comment to D23037: Add support for cb7 comic book archives.

Please do not manually change translated keys in desktop files: there is an automatic system that takes care of them.

Aug 9 2019, 6:55 AM · Okular
pino committed R457:dbdbdfe2b127: Merge remote-tracking branch 'origin/0.26' (authored by pino).
Merge remote-tracking branch 'origin/0.26'
Aug 9 2019, 6:33 AM
pino committed R457:7a64e4a3aee1: Fix typos in license texts (authored by pino).
Fix typos in license texts
Aug 9 2019, 6:33 AM

Aug 8 2019

pino committed R365:46f28ab0f0ee: appdata: add missing </li> (authored by pino).
appdata: add missing </li>
Aug 8 2019, 5:19 AM

Aug 5 2019

pino committed R883:1548859: few updates.
few updates
Aug 5 2019, 9:05 PM

Aug 3 2019

pino committed R883:1548563: update.
update
Aug 3 2019, 9:32 AM

Jul 30 2019

pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

That as well, as also discussed on irc today.

Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test that, this patch might allow to at least get the api.kde.org being updated again, which it was not since April for all the repos covered by kapidox.

I agree that getting api.kde.org uo to date again is a priority.

Jul 30 2019, 9:26 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Ok, yep i may have misunderstood :)

But if you say "kapidox supports Python 2.7" we need to commit this to keep it true :)

Jul 30 2019, 9:23 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Pino please take a step back and rethink your position.
Yes, supporting Python2 sucks, but this is 2 lines of code while porting everything to Python 3 is lots of work more.

Jul 30 2019, 9:15 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Let me add one more thing: I understand you care about API docs, about making them available for our users on api.kde.org, and about giving the best impression possible about them (I remember various patches about that in the past).

Jul 30 2019, 8:05 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.
In D22836#504358, @pino wrote:

Oh dear, and what about switching the api generation to Python 3 instead?

Nobody is stopped to work on that. I am not a Python expert, I just providing here the small fix which fall off from me local testing at why the build fails. Which also includes testing whether the bug reproduced locally also is seen with Python3 (it is not). Sorry if I left out this details here, they had been mentioned on Sysadmin.

This fix could "potentially" just buy some more time, and not solve the issue of keep using Python 2 further.

Keeping things broken has not worked to make you switch api.kde.org to Python3, right? ;)

Jul 30 2019, 8:01 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.
In D22836#504356, @pino wrote:

Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test that,

At this point, making Python stuff work with Python3 is priority one.

Oh dear, any chance we could look at this simple fix provided here, which get us potentially api.kde.org back the day this simple patch is confirmed and in?

Jul 30 2019, 7:12 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test that,

Jul 30 2019, 6:53 PM · Documentation, Frameworks
pino added a comment to D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7.

Or maybe just drop support for Python 2 entirely?

  • kapidox is rarely used
  • Python 2 will be EOL in 5 months
  • distros either switched kapidox to Python 3, or will do it soon
Jul 30 2019, 6:40 PM · Documentation, Frameworks
pino added a comment to D22837: Update atom feed for new site.

I'd say to commit it directly - it's your website, after all.

Jul 30 2019, 6:38 PM
pino committed R23:aceab06cbf1a: i18n: fix string puzzle (authored by pino).
i18n: fix string puzzle
Jul 30 2019, 4:35 AM

Jul 29 2019

pino committed R262:04d842eaa5b7: i18n: typo fix (authored by pino).
i18n: typo fix
Jul 29 2019, 3:28 AM

Jul 28 2019

pino committed R883:1547847: fill empty Language headers.
fill empty Language headers
Jul 28 2019, 2:03 PM
pino committed R883:1547834: updates of unmaintained.
updates of unmaintained
Jul 28 2019, 11:28 AM
pino committed R883:1547808: fill empty Language headers.
fill empty Language headers
Jul 28 2019, 6:56 AM

Jul 27 2019

pino committed R883:1547783: update.
update
Jul 27 2019, 4:21 PM
pino committed R883:1547782: updates of unmaintained/unassigned.
updates of unmaintained/unassigned
Jul 27 2019, 4:21 PM
pino committed R384:0bd4296962c2: i18n: use a plural form where needed (authored by pino).
i18n: use a plural form where needed
Jul 27 2019, 4:19 PM
pino committed R32:70296f1a7688: Merge remote-tracking branch 'origin/5.4' (authored by pino).
Merge remote-tracking branch 'origin/5.4'
Jul 27 2019, 4:02 PM
pino committed R32:271e4f0fc1c7: i18n: use plural forms where needed (authored by pino).
i18n: use plural forms where needed
Jul 27 2019, 3:50 PM
pino committed R226:7aea9156d25d: i18n: spell "D-Bus" correctly (authored by pino).
i18n: spell "D-Bus" correctly
Jul 27 2019, 3:48 PM
pino committed R883:1547779: updates.
updates
Jul 27 2019, 3:41 PM

Jul 25 2019

pino requested changes to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

other than building, please also check that it actually still works on Linux

Jul 25 2019, 4:33 AM · Frameworks, Dolphin

Jul 23 2019

pino committed R883:1547321: typo fix.
typo fix
Jul 23 2019, 5:48 AM

Jul 22 2019

pino committed R262:9bee13cb7c83: fixuifiles (authored by pino).
fixuifiles
Jul 22 2019, 3:24 AM

Jul 21 2019

pino added a comment to D22616: Remove phonon KCM.

@sitter said he has a version of the settings to be integtated into phonon so the remaining three users can still access them

this

Jul 21 2019, 6:50 PM · Documentation, Plasma
pino added a comment to D22616: Remove phonon KCM.

Erm, so what if you do not use plasma-pa?

Jul 21 2019, 5:03 PM · Documentation, Plasma
pino added a comment to D22605: Set notifications entry icon size to medium.

I would like to test it and post a screenshot, however I am not able to compile it:

  1. I cloned the source from the git repository
  2. mkdir plasma-workspace/applets/notifications/build
  3. cd plasma-workspace/applets/notifications/build
  4. cmake ..

    This resulted in ` CMake Error at CMakeLists.txt:11 (kcoreaddons_desktop_to_json): Unknown CMake command "kcoreaddons_desktop_to_json". `
Jul 21 2019, 10:09 AM · Plasma
pino added a comment to D22606: add missing semicolon.

Patch landed, and build successfully everywhere.
Congratulations for your first patch :)

Jul 21 2019, 9:47 AM · Baloo, Frameworks
pino committed R286:8f23194f7891: add missing semicolon (authored by antonioh).
add missing semicolon
Jul 21 2019, 9:40 AM