- User Since
- Mar 25 2016, 4:10 PM (224 w, 4 d)
Sat, Jun 20
Fri, Jun 19
Patch won't apply directly, but you've done the work finding the bug, I can sort that.
Jun 14 2020
Jun 13 2020
Jun 10 2020
Jun 9 2020
Jun 8 2020
Jun 7 2020
Jun 6 2020
Jun 5 2020
Jun 4 2020
Jun 3 2020
Jun 2 2020
May 30 2020
still for 20.08...
please target release/20.04 for this fix, thanks
May 22 2020
May 19 2020
May 17 2020
Please update the text of the revision and the commit message, as they don't make much sense. Please mention that it fixes a crash in case ddjvu is not installed, by avoiding executing it, and using _exit() to not run atexit handlers in case execvp() fails.
This change is definitely not correct.
May 6 2020
Please read what @zzag and me wrote: you must fix the buddy of the label widget, not its name.
@sdepiets bumping dependencies in a stable branch is against the freeze policy:
May 5 2020
May 3 2020
why not KEncodingProber from the KCodecs framework, like also the commented bits hint about?
May 2 2020
May 1 2020
The accelerator is correct to use, as it will activate the buddy associated to to label... which is wrong, as quickTileLabel does not exist.
Did you try changing the buddy of quickTileLabel to kcfg_ElectricBorderTiling?
Apr 30 2020
The patch should not require existing users to adapt
The problem is that ki18n_install() is rarely used manually
The problem is that ki18n_install() is rarely used manually, and generally it is appended by the release scripts to the top-level CMakeLists.txt file that goes into the tarballs.
This means that either the majority of the packages will not make use of this, or a mass-bump of the ki18n dependency (which I'd rather not do).
Apr 29 2020
Apr 27 2020
@tcanabrava @carneirogustavo this change does not look correct to me: now both the setters are effectively no-op if the new values are different than the old ones.
Are you sure it was not meant to be if (m_foo == foo) return; instead?
Apr 26 2020
My concern is that this change is about adding an AppStream file, with no mention of other changes to the desktop file. So it is not clear (especially when looking at this after some time) whether the change was somehow related (which doesn't look like), or maybe it was a local change for testing that slipped in while committing.
Is the change to GenericName intentional?
Apr 24 2020
CMake Error at src/app/CMakeLists.txt:87 (install):
Apr 23 2020
Apr 22 2020
(Commented in the wrong place)
Shouldn't the test completely ignore the system location, to avoid interferences from the system installation?
Apr 21 2020
LGTM for me from an i18n POV, I'll let @dvratil give a final review/approval.
The actual i18n changes LGTM, thanks!
a couple of notes for a followup patch -- no need to change this patch, as the code lacked the i18n handling also before (so this patch is not a regression).
Apr 20 2020
Apr 16 2020
Fixed with def21bf6c691a40bef233efd898fcb7ff57d55bb, thanks for the notice.