ScalableTest, add "scalable" plasma-browser-integration
AcceptedPublic

Authored by maximilianocuria on May 14 2018, 11:50 AM.

Details

Reviewers
dfaure
andreaska
andreask
ngraham
Group Reviewers
Frameworks
Summary

With the introduction of the plasma-browser-integration icon (Add
plasma-browser-integration system tray icon, 47b8e71a) the ScalableTest started
failing [1]. The test seems to expect a "larger" icon (greater than 48)
available to consider that there is a scalable icon. I'm not
sure if this test is still useful, as all the icons are now in svg format, and
while they might be designed for a low resolution, they are "scalable".

This patch simply adds symlinks to the 48 and 64 res, in order to make the
test pass.

[1]: https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/81/

BUG: 393999
FIXED-IN: 5.49

Diff Detail

Repository
R266 Breeze Icons
Branch
scalable_pbi (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 14 2018, 11:50 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
maximilianocuria requested review of this revision.May 14 2018, 11:50 AM
maximilianocuria edited the test plan for this revision. (Show Details)May 14 2018, 1:17 PM
dfaure accepted this revision.Sun, Jul 8, 10:45 PM

Yes, please. My emails to Andreas Kainz about this unittest failure (on 9 June and 8 July -- ok that second one was yesterday) didn't get any reaction. Let's fix the tests, and if this is wrong someone can tell us ;)

This revision is now accepted and ready to land.Sun, Jul 8, 10:45 PM

+1

Btw, this is BUG: 393999

ngraham edited the summary of this revision. (Show Details)Mon, Jul 9, 12:37 PM
ngraham accepted this revision.Mon, Jul 9, 1:06 PM