Oh so nice. Confirmed fixed!
I am unable to get arc to properly download this review patch. I will be waiting for D22769 to land and a rebase. Sorry
Sat, Aug 17
Let's go. I have not enough time for a proper review but a big +1
Great, thanks again
Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?
If you would like to start contributing, you may have a look at the Junior Jobs column of the tasks or try to fix some bugs at https://bugs.kde.org/buglist.cgi?component=general&list_id=1655384&product=elisa&resolution=---
Okay thanks. No, I haven't faced these issues.
Fri, Aug 16
Thu, Aug 15
Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?
- rebase on master
Is anyone working on this? If not I'd like to help out with this.
Wed, Aug 14
On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.
Really nice. Thank you
Tue, Aug 13
- fix code style again
- fix code style and unrelated changes
- fix remaining tracks label
I don't want to remove ManageHeaderBar, on the contrary. This is a simplification and cleanup in order to easily extend it in the future after D22771, which is the goal of this whole series.
While working on it, I found that the ManageHeaderBar is needlessly entangled to the MediaPlayList by connecting to all of those signals, but which are mostly ignored. This is just because of the remaining tracks, for which the MediaPlayList is the correct place to retrieve the information.
By only connecting to the currentTrackChanged signal, the rest can be implemented much more easily. D22771 is working towards T7674
Please note that I cannot test this myself due to lack of a high DPI monitor
I forgot to say that the very big reduction in line count is really good. Thanks for that
Could you please add a general overview of what is the goal of this change ?