I'll try to look into this again next weekend. I think Elisa was missing some way to go properly from Now Playing to a specific album view, so it went straight to all albums.
Unfortunetaly, due to your request of making the creation of trackslistener on demand (D15078), they are quite some #ifdefs in musiclistenersmanager. But I don't know how to do it better than this.
This is currently not fully working yet. I could verify that the track gets added correctly to the database, and the artist query is correctly skipped. But the track is not fetched from the database with the selectTrackFromIdQuery, and hence the test fails. I'm no expert in SQL, and haven't found a solution for that yet, so any help is appreciated.
Sat, Oct 13
I'm currently quite busy with other things and would like to finish more of that before adding stuff to my todo list again...
Fri, Oct 12
- make const ref and use auto
- fix test
I still have high doubt with your current approach (ElisaToolButton). See my inline comment.
I fear that with your patch patch we increase the maintenance cost and add more things to learn for newcommers.
master branch of Elisa is now using vlc to play music. This allows to have a very good out of the box experience on Windows.
I need to improve craft packaging to decrease package size.
Thu, Oct 11
- explicitly forbid tracks with empty title and artists for now
- alter one of the test file to be incomplete
Wed, Oct 10
Tue, Oct 9
Thanks for your work.
This has now been deployed.
Mon, Oct 8
Hi guys, sorry I've been dropping the ball on this one. I had reverted this some weeks ago but couldn't find another way to center it. And then I didn't have time to get back on it.
+1 for landing it now
Sun, Oct 7
- remove explicit this->
If no-one objects, I will accept and land this diff soon, and fix the error afterwards
@mgallien could you comment if this is acceptable or not?
I think right now is a good time to merge it into master. I expect there to be at least some issue with the GUI where we previously always expected a value, and it would give some time to sort all issues out before the next release.
- implement feedback
The rationale is given in the summary. The basic idea is to allow multiple clients.