ElisaProject
ActivePublic

Recent Activity

Yesterday

januz added a comment to D12975: Hide stars when there is no rating.

Unfortunately still a while. KFileMetaData has currently not the ability to write these tags, and Elisa itself also has no infrastructure yet to actually edit the metadata

Wed, Jun 20, 10:30 PM · Elisa
januz closed D12975: Hide stars when there is no rating.
Wed, Jun 20, 10:27 PM · Elisa
mgallien accepted D12975: Hide stars when there is no rating.

Works fine thanks.
Sorry for the delay due to me being sick

Wed, Jun 20, 9:06 PM · Elisa

Sat, Jun 16

astippich closed T8330: Update the playing indicator with new icons from breeze-icons v5.45 as Resolved.
Sat, Jun 16, 10:30 AM · Elisa
astippich added a comment to T6255: Add support for cover images embedded in tracks.

kfilemetadata support added in 885616cee7a0 and will be released as part of kf 5.48

Sat, Jun 16, 10:18 AM · Elisa
astippich closed T8598: add a fallback theme for quick controls v2 as Resolved.
Sat, Jun 16, 10:16 AM · Elisa
astippich moved T8598: add a fallback theme for quick controls v2 from Backlog to Done on the Elisa board.
Sat, Jun 16, 10:16 AM · Elisa

Sun, Jun 10

astippich added a comment to D12975: Hide stars when there is no rating.

we could actually flip the position of the buttons and the star ratings...

I've given this a try but it still looks weird. Is setting ratings too far away? We could put this patch in the backburner until that's working. That way we don't have to worry about the buttons jumping around.

Sun, Jun 10, 7:14 AM · Elisa

Sat, Jun 9

astippich abandoned D12978: move mpris interface to c++.

I am unsure about the added value of this diff. At least, you should fiwx the reported issues. I would really prefer not to add many #ifdef in the c++ code in favor of platform specific qml files.

Sat, Jun 9, 4:29 PM · Elisa
astippich added a comment to T8598: add a fallback theme for quick controls v2.

can we close this one?

Sat, Jun 9, 9:30 AM · Elisa

Fri, Jun 8

januz added a comment to D12841: Align view buttons vertically.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Thanks for your work.

I tried increasing the font size to 14 (OK, this is a corner case) and the bottom of the buttons are no longer aligned.
Did you consider using TextMetrics to get the exact height of the label ?

Fri, Jun 8, 10:45 PM · Elisa
januz added a comment to D12975: Hide stars when there is no rating.

we could actually flip the position of the buttons and the star ratings...

Fri, Jun 8, 10:15 PM · Elisa
januz updated the diff for D12975: Hide stars when there is no rating.

Make filter rating stars always visible

Fri, Jun 8, 9:59 PM · Elisa

Thu, Jun 7

mgallien moved T6293: Fix HeaderBar for missing animations from Backlog to Junior Jobs on the Elisa board.
Thu, Jun 7, 9:47 PM · Elisa
mgallien triaged T8953: Improve detection of different albums as High priority.
Thu, Jun 7, 9:44 PM · Elisa
mgallien added a revision to T8953: Improve detection of different albums: D13423: unmerge albums by using the paths of their tracks.
Thu, Jun 7, 9:43 PM · Elisa

Wed, Jun 6

mgallien requested changes to D12978: move mpris interface to c++.
Wed, Jun 6, 8:31 PM · Elisa
mgallien added a comment to D12978: move mpris interface to c++.

I am unsure about the added value of this diff. At least, you should fiwx the reported issues. I would really prefer not to add many #ifdef in the c++ code in favor of platform specific qml files.

Wed, Jun 6, 8:31 PM · Elisa
mgallien added a comment to D12992: New elisa icon.

@abetts Yes, I've been concepting a little on different ideas but not really coming anywhere I feel would fit in.

Looks great!

As for the background, when I think of soundwaves I think of something that would be produced by a visualizer, or a sine wave.

Did you make the letters yourself or is it a font? I'm asking just in case the font is licensed.

The letters are from a font from Google Fonts. We should be OK to use it. We can also modify a bit if you want. Although I feel it looks good.

Wed, Jun 6, 8:26 PM · Frameworks, Elisa

Mon, Jun 4

mgallien created T8953: Improve detection of different albums.
Mon, Jun 4, 4:15 PM · Elisa
mgallien requested changes to D12975: Hide stars when there is no rating.
Mon, Jun 4, 3:51 PM · Elisa
mgallien added a comment to D12841: Align view buttons vertically.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Mon, Jun 4, 3:48 PM · Elisa
mgallien added a comment to D12841: Align view buttons vertically.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Mon, Jun 4, 3:47 PM · Elisa
mgallien added a revision to T8695: Ensure user visible paths are looking native and easy to read: D13337: makes path returned by TrackDataHelper looks local when they are local.
Mon, Jun 4, 3:30 PM · Elisa
mgallien added a revision to T8330: Update the playing indicator with new icons from breeze-icons v5.45: D13324: use new icons from Breeze to indicate pauses and playing status.
Mon, Jun 4, 5:53 AM · Elisa
mgallien claimed T8330: Update the playing indicator with new icons from breeze-icons v5.45.
Mon, Jun 4, 5:24 AM · Elisa
mgallien claimed T8695: Ensure user visible paths are looking native and easy to read.
Mon, Jun 4, 5:23 AM · Elisa
mgallien moved T8330: Update the playing indicator with new icons from breeze-icons v5.45 from Backlog to In Progress on the Elisa board.
Mon, Jun 4, 5:23 AM · Elisa
mgallien moved T8695: Ensure user visible paths are looking native and easy to read from Backlog to In Progress on the Elisa board.
Mon, Jun 4, 5:23 AM · Elisa
mgallien raised the priority of T7883: year and genre browser from High to Needs Triage.
Mon, Jun 4, 5:22 AM · Elisa

Sun, Jun 3

januz added a comment to T7884: file browser.

Tried this from master and it works really well. The thing that gets excites me the most is that Elisa can now play MOD files! I can confirm that .xm, .it, .mod and .s3m formats work. MIDI files are also recognized and shown but they failed to play for me.

Sun, Jun 3, 12:52 AM · Elisa
januz added a comment to T7883: year and genre browser.

Tried this again from Master after nuking my DB. I get more genres (I think) but they are all empty and I try to play them I get an empty playlist.

Sun, Jun 3, 12:34 AM · Elisa

Sat, Jun 2

mgallien added a comment to D12975: Hide stars when there is no rating.

Here's a test for the "columns" idea.

Sat, Jun 2, 8:25 AM · Elisa
ngraham added a comment to T7883: year and genre browser.

I've been having some trouble getting Elisa to run after compilation (qml errors), but I'll try to sort them out and test this. Thanks so much for your hard work getting it done!

Sat, Jun 2, 5:57 AM · Elisa
januz updated the diff for D12841: Align view buttons vertically.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Sat, Jun 2, 12:02 AM · Elisa

Fri, Jun 1

mgallien added a comment to T7883: year and genre browser.

Thanks for the feedback so far. I have fixed some problems. One of them was a wrong size of genre metadata in database. It requires to remove it and index your music again.

Fri, Jun 1, 4:48 PM · Elisa

Thu, May 31

januz added a comment to T7883: year and genre browser.

Gave this a quick try:

Thu, May 31, 11:02 PM · Elisa
astippich added a comment to T7883: year and genre browser.

I just gave it a quick try, it does not really seem to work.
-the genre is using the artist icon for the delegates
-clicking a genre shows an empty page

Thu, May 31, 9:05 PM · Elisa
mgallien updated subscribers of T7883: year and genre browser.

@astippich , @ngraham are you able to test and provide me feedback before Saturday. This is more or less finished and I would like to push it in master before the feature freeze.

Thu, May 31, 8:15 PM · Elisa
astippich added a comment to D12975: Hide stars when there is no rating.

we could actually flip the position of the buttons and the star ratings...

Thu, May 31, 9:41 AM · Elisa
astippich updated subscribers of D12975: Hide stars when there is no rating.

Sorry for the delay. I think with the column there is too much wasted space, especially with long titles.
I still cannot think of a good way to solve this now. It will eventually go away once Elisa gets the editing of ratings. Maybe you first version is still the best.
Let's wait for @mgallien opinion.

Thu, May 31, 9:39 AM · Elisa

Wed, May 30

januz added a comment to D12842: Tweak size and color of handles for the seek/volume sliders.

No problem :)

Wed, May 30, 12:36 AM · Elisa
januz closed D12842: Tweak size and color of handles for the seek/volume sliders.
Wed, May 30, 12:35 AM · Elisa

Tue, May 29

mgallien accepted D12842: Tweak size and color of handles for the seek/volume sliders.

Thanks and sorry for the delays from my side

Tue, May 29, 8:10 PM · Elisa

Mon, May 28

abetts added a comment to D12992: New elisa icon.

@abetts Yes, I've been concepting a little on different ideas but not really coming anywhere I feel would fit in.

Looks great!

As for the background, when I think of soundwaves I think of something that would be produced by a visualizer, or a sine wave.

Did you make the letters yourself or is it a font? I'm asking just in case the font is licensed.

Mon, May 28, 7:35 PM · Frameworks, Elisa
lshoravi added a comment to D12992: New elisa icon.

@abetts Yes, I've been concepting a little on different ideas but not really coming anywhere I feel would fit in.

Mon, May 28, 6:15 PM · Frameworks, Elisa
ngraham added a comment to D12992: New elisa icon.

I like it!

Mon, May 28, 2:12 AM · Frameworks, Elisa
abetts added a comment to D12992: New elisa icon.

I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for commonalities. I feel also that the icon is busy, it is trying really hard to tell you that this app is about music. I feel we can simplify and provide other ideas.

Mon, May 28, 12:39 AM · Frameworks, Elisa

Sun, May 27

januz added a comment to D12992: New elisa icon.

I agree in that a circle doesn't have as much personality as maybe a
casette. I also agree in that the casette felt off when looking at it.

How would something like an LP player with the E on top feel? I won't have
time until Monday (finals coming up), but my gut says that a brown-ish
square with a dark circle (like seeing an LP player from above) with some
iconography on top could look good.

Sun, May 27, 11:04 PM · Frameworks, Elisa
mgallien updated subscribers of D12992: New elisa icon.

@januz and @astippich I really understand your point of view about the current icon. I share your point of view the need to have an icon easy to differentiate from many other players. For example, I would like Elisa be easy to spot on this page: https://flathub.org/apps/category/AudioVideo .

Sun, May 27, 9:19 PM · Frameworks, Elisa