@ognarb, I will take a look at it and see if I can help.
Not the bug is still here:
Still, an external drive but Baloo is now disabled. If you want, I could try enabling Baloo again to see if the bug appears again or not.
Btw retried Elisa with my big music collection, and it works now. :)
Eventually, all metadata should be optional...
I think for database insertion the track title is still the only one that is a hard requirement, but this should also be removed.
Sat, Jun 22
Turns out that was some leftover code :) so the ToolButton does the correct sizing. I'll just abandon this one here and open a new one. Thanks for insisting! :)
LOL! That's probably because of the height of the player bar being hardcoded rather than sizing itself according to its contents + top and bottom padding (an anti-pattern best moved away from in QML user interfaces). I think basing this on a ToolButton rather than a Button is more semantically correct since that's what it is, so +1 if you want to do that.
True, but then again these are basically glorified ToolButtons, and you don't need to set the size for every ToolButton; it has a correct default size and you only override it as needed. It just seems odd to me that we have to do this at all, and I feel like it points to a problem in the component itself. It should have a correct default size without us having to tell every instance of it how big it needs to be.
Maybe we could just make the aspect ratio fixed to square in the FlatButtonWithToolTip control? Then we wouldn't need any custom sizing in the player control bar because the width would be limited by the height, which would be correctly chosen based on the height of the player bar.
- fix previous commit
- use Layout.preferredHeight/Width
Why that? If you do not specify a button size, the style will automatically scale it. Also happes with a plain QML Button
It seems like that bug should be fixed in FlatButtonWithToolTip then.
with different styles, this can look like:
Thu, Jun 20
Do we even need to manually specify the width and height at all? To me they look just fine without these lines:
qqc2, with patch for desktop style
If you do so, you may hit https://bugs.kde.org/show_bug.cgi?id=405541. But maybe you can find a clever way around that (or just fix it) that I didn't find. :)
This is a CCBUG: 405144. You could probably upgrade it all the way to BUG: by porting the menu, too.
@lshoravi ping! Any chance we can finish up work on this icon and get it in?
+1, though these messages are currently not very useful because they're not actionable. If loading or saving of the playlist failed, what can I do about it? it's not clear. Especially for persistent messages, it's worth it to try to make them actionable somehow. Options include a better error message, a "Try again" button to preserve the illusion of user agency, etc.