ElisaProject
ActivePublic

Recent Activity

Today

januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

I'll try to look into this again next weekend. I think Elisa was missing some way to go properly from Now Playing to a specific album view, so it went straight to all albums.

Mon, Oct 15, 12:56 AM · Elisa

Yesterday

januz removed a watcher for Elisa: januz.
Sun, Oct 14, 10:46 PM
mgallien added inline comments to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.
Sun, Oct 14, 7:18 PM · Elisa
astippich added a comment to D16194: move metadata scanning to trackslistener.

Unfortunetaly, due to your request of making the creation of trackslistener on demand (D15078), they are quite some #ifdefs in musiclistenersmanager. But I don't know how to do it better than this.

Sun, Oct 14, 10:48 AM · Elisa
astippich added a comment to D16194: move metadata scanning to trackslistener.

Unfortunetaly, due to your request of making the creation of trackslistener on demand (D15078), they are quite some #ifdefs in musiclistenersmanager. But I don't know how to do it better than this.

Sun, Oct 14, 10:35 AM · Elisa
astippich requested review of D16194: move metadata scanning to trackslistener.
Sun, Oct 14, 10:33 AM · Elisa
astippich updated the diff for D16193: [WIP] allow tracks with empty artist tag in database.
  • cleanup
Sun, Oct 14, 8:44 AM · Elisa
astippich added a comment to D16193: [WIP] allow tracks with empty artist tag in database.

This is currently not fully working yet. I could verify that the track gets added correctly to the database, and the artist query is correctly skipped. But the track is not fetched from the database with the selectTrackFromIdQuery, and hence the test fails. I'm no expert in SQL, and haven't found a solution for that yet, so any help is appreciated.

Sun, Oct 14, 8:41 AM · Elisa
astippich requested review of D16193: [WIP] allow tracks with empty artist tag in database.
Sun, Oct 14, 8:38 AM · Elisa

Sat, Oct 13

astippich added a comment to D14018: [WIP] Make labels in header bar clickeable.

I'm currently quite busy with other things and would like to finish more of that before adding stuff to my todo list again...

Sat, Oct 13, 8:41 AM · Elisa
astippich requested review of D16175: bump frameworks to 5.48 and use new icon.
Sat, Oct 13, 8:39 AM · Elisa

Fri, Oct 12

astippich updated the diff for D13825: optimize adding album and multiple files to mediaplaylist.
  • make const ref and use auto
  • fix test
Fri, Oct 12, 8:35 PM · Elisa
mgallien updated subscribers of D14018: [WIP] Make labels in header bar clickeable.

This is mostly done too but there's still one small bug: when I go to the now playing view and then click on the album name it doesn't open the album, but only switches to the album view.
Still trying to figure this out

Fri, Oct 12, 8:13 PM · Elisa
astippich added inline comments to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.
Fri, Oct 12, 8:05 PM · Elisa
mgallien added inline comments to D13825: optimize adding album and multiple files to mediaplaylist.
Fri, Oct 12, 7:36 PM · Elisa
mgallien added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

I still have high doubt with your current approach (ElisaToolButton). See my inline comment.
I fear that with your patch patch we increase the maintenance cost and add more things to learn for newcommers.

Fri, Oct 12, 7:33 PM · Elisa
mgallien claimed T9641: Publish Elisa in the Microsoft Store.
Fri, Oct 12, 7:26 PM · Elisa, Windows
mgallien added a comment to T9641: Publish Elisa in the Microsoft Store.

master branch of Elisa is now using vlc to play music. This allows to have a very good out of the box experience on Windows.
I need to improve craft packaging to decrease package size.

Fri, Oct 12, 7:25 PM · Elisa, Windows
astippich closed D13685: allow metadata of tracks without album and tracknumber in database.
Fri, Oct 12, 6:55 PM · Elisa

Thu, Oct 11

joaonetto removed a watcher for Elisa: joaonetto.
Thu, Oct 11, 9:10 PM
astippich added a comment to D13825: optimize adding album and multiple files to mediaplaylist.

ping

Thu, Oct 11, 5:03 PM · Elisa
astippich added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

ping

Thu, Oct 11, 5:02 PM · Elisa
astippich updated the diff for D13685: allow metadata of tracks without album and tracknumber in database.
  • rebase
  • explicitly forbid tracks with empty title and artists for now
  • alter one of the test file to be incomplete
Thu, Oct 11, 5:02 PM · Elisa
joaonetto added a watcher for Elisa: joaonetto.
Thu, Oct 11, 11:17 AM

Wed, Oct 10

drod added a member for Elisa: drod.
Wed, Oct 10, 8:58 PM
astippich closed D14120: Tweak inital state for playlist.
Wed, Oct 10, 6:58 PM · Elisa
astippich accepted D14120: Tweak inital state for playlist.

Hi guys, sorry I've been dropping the ball on this one. I had reverted this some weeks ago but couldn't find another way to center it. And then I didn't have time to get back on it.
+1 for landing it now

Wed, Oct 10, 6:31 PM · Elisa
astippich closed D14126: add ability to load playlists from file browser.
Wed, Oct 10, 6:30 PM · Elisa
astippich closed D15078: keep pointer of track listener.
Wed, Oct 10, 6:29 PM · Elisa

Tue, Oct 9

mgallien accepted D15078: keep pointer of track listener.
Tue, Oct 9, 3:19 PM · Elisa
mgallien accepted D14126: add ability to load playlists from file browser.

Thanks for your work.

Tue, Oct 9, 3:14 PM · Elisa
mgallien accepted D13685: allow metadata of tracks without album and tracknumber in database.

@mgallien could you comment if this is acceptable or not?
I think right now is a good time to merge it into master. I expect there to be at least some issue with the GUI where we previously always expected a value, and it would give some time to sort all issues out before the next release.

Tue, Oct 9, 3:12 PM · Elisa
mgallien added a comment to T9811: Add support for libvlc on build.kde.org.

This has now been deployed.

Tue, Oct 9, 11:48 AM · Elisa, build.kde.org
bcooksley closed T9811: Add support for libvlc on build.kde.org as Resolved.

This has now been deployed.

Tue, Oct 9, 10:29 AM · Elisa, build.kde.org
bcooksley added a commit to T9811: Add support for libvlc on build.kde.org: R857:dfd9cf8a7077: Include VLC as part of our Windows CI platform deployment..
Tue, Oct 9, 9:45 AM · Elisa, build.kde.org

Mon, Oct 8

januz added a comment to D14120: Tweak inital state for playlist.

Hi guys, sorry I've been dropping the ball on this one. I had reverted this some weeks ago but couldn't find another way to center it. And then I didn't have time to get back on it.
+1 for landing it now

Mon, Oct 8, 6:51 PM · Elisa
mgallien closed T6259: Fix restore ofvolume on start on Windows as Resolved.
Mon, Oct 8, 5:18 AM · Elisa
mgallien closed T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets as Resolved.
Mon, Oct 8, 5:18 AM · Elisa

Sun, Oct 7

astippich updated the diff for D15078: keep pointer of track listener.
  • remove explicit this->
Sun, Oct 7, 5:45 PM · Elisa
mgallien closed D15782: add support for progress bar built in the Plasma task bar.
Sun, Oct 7, 3:21 PM · Elisa
mgallien added inline comments to D14126: add ability to load playlists from file browser.
Sun, Oct 7, 3:06 PM · Elisa
mgallien added inline comments to D15078: keep pointer of track listener.
Sun, Oct 7, 3:06 PM · Elisa
mgallien added a comment to D14120: Tweak inital state for playlist.

If no-one objects, I will accept and land this diff soon, and fix the error afterwards

Sun, Oct 7, 3:03 PM · Elisa
astippich accepted D15782: add support for progress bar built in the Plasma task bar.
Sun, Oct 7, 2:57 PM · Elisa
astippich added a comment to D14120: Tweak inital state for playlist.

If no-one objects, I will accept and land this diff soon, and fix the error afterwards

Sun, Oct 7, 2:51 PM · Elisa
astippich added a comment to D13685: allow metadata of tracks without album and tracknumber in database.

@mgallien could you comment if this is acceptable or not?
I think right now is a good time to merge it into master. I expect there to be at least some issue with the GUI where we previously always expected a value, and it would give some time to sort all issues out before the next release.

Sun, Oct 7, 2:36 PM · Elisa
astippich added inline comments to D14126: add ability to load playlists from file browser.
Sun, Oct 7, 2:35 PM · Elisa
astippich updated the diff for D14126: add ability to load playlists from file browser.
  • rebase
  • implement feedback
Sun, Oct 7, 2:33 PM · Elisa
astippich added a comment to D15078: keep pointer of track listener.

The rationale is given in the summary. The basic idea is to allow multiple clients.

Sun, Oct 7, 2:19 PM · Elisa
astippich updated the diff for D15078: keep pointer of track listener.
  • create trackslistener on demand
Sun, Oct 7, 2:19 PM · Elisa