ElisaProject
ActivePublic

Recent Activity

Sat, Aug 11

ognarb added a comment to T7676: Add a mode where all the bottom part can be hidden.
Sat, Aug 11, 3:12 PM · Elisa

Fri, Aug 10

ognarb added a comment to T7676: Add a mode where all the bottom part can be hidden.

I was able to implement the button. Before I continue, can someone review my diff? https://phabricator.kde.org/D14736

Fri, Aug 10, 6:18 PM · Elisa

Thu, Aug 9

mgallien updated subscribers of T7676: Add a mode where all the bottom part can be hidden.

Welcome to the Elisa project.

Thu, Aug 9, 4:35 PM · Elisa
jamesmintram claimed T9082: Add filtering by path in the Baloo support.

Thanks for the advice.

Thu, Aug 9, 2:59 PM · Elisa
ognarb claimed T7676: Add a mode where all the bottom part can be hidden.

I'm interested to claim this task. I just have a small question: Where can I find the mockup for the party mode?

Thu, Aug 9, 2:52 PM · Elisa

Wed, Aug 8

mgallien added a comment to T9082: Add filtering by path in the Baloo support.

I am Interested in taking this task but I am unsure how to proceed.

Wed, Aug 8, 7:47 PM · Elisa
jamesmintram added a comment to T9082: Add filtering by path in the Baloo support.

I am Interested in taking this task but I am unsure how to proceed.

Wed, Aug 8, 3:17 PM · Elisa

Mon, Aug 6

mgallien moved T9315: Make an Android service with Elisa c++ code from Backlog to In Progress on the Elisa board.
Mon, Aug 6, 3:21 PM · Elisa
mgallien triaged T9315: Make an Android service with Elisa c++ code as High priority.
Mon, Aug 6, 3:21 PM · Elisa
mgallien moved T6700: Improve Baloo Support and Add Automatic Tests from In Progress to Backlog on the Elisa board.

Move back to backlog to give room for higher priority tasks

Mon, Aug 6, 3:16 PM · Elisa

Jul 15 2018

januz closed D14015: New header style for playlist.
Jul 15 2018, 11:35 PM · Elisa
januz added a comment to T7884: file browser.
  • Names in both dolphin and elisa are aligned to the center

Do you mean this as a wish? They are left aligned, which is also consistent with the other views.

Jul 15 2018, 11:34 PM · Elisa
astippich requested review of D14126: add ability to load playlists from file browser.
Jul 15 2018, 9:11 AM · Elisa
astippich added a comment to T7884: file browser.

sorry for the late response, I lost track when I was busy with work.

Jul 15 2018, 8:48 AM · Elisa
astippich claimed T7576: port to controls2.
Jul 15 2018, 8:08 AM · Elisa
astippich moved T7576: port to controls2 from Backlog to In Progress on the Elisa board.
Jul 15 2018, 8:07 AM · Elisa
astippich moved T6255: Add support for cover images embedded in tracks from In Progress to Backlog on the Elisa board.
Jul 15 2018, 8:07 AM · Elisa
astippich requested changes to D14120: Tweak inital state for playlist.
Jul 15 2018, 8:00 AM · Elisa
astippich accepted D14015: New header style for playlist.

looking great!

Jul 15 2018, 7:17 AM · Elisa
astippich updated the summary of D13872: introduce ElisaToolButton and use it in MediaPlayerControl.
Jul 15 2018, 7:03 AM · Elisa
astippich added a reviewer for D13872: introduce ElisaToolButton and use it in MediaPlayerControl: januz.
Jul 15 2018, 7:02 AM · Elisa

Jul 14 2018

januz added a project to D14120: Tweak inital state for playlist: Elisa.
Jul 14 2018, 11:07 PM · Elisa
januz updated the diff for D14015: New header style for playlist.
  • Reverse clear list icon
  • Add ellipsis on load/save texts (for tooltips)
Jul 14 2018, 9:37 PM · Elisa
mgallien added a comment to D14015: New header style for playlist.

Looks like ToolButtons ignore text. I managed to hack this by shoving a Text object inside them but it really messes up the layout and only the icon is clickable.

I think having icons only would be fine, that's what tooltips are for anyways :)

@mgallien, @astippich What do you think about the clear icon? Should we revert back to the line (current one) or bump KF to 5.48 to use the new broom icon?

Jul 14 2018, 9:19 PM · Elisa
astippich added a comment to D14015: New header style for playlist.

imho only toolbuttons is fine.
I would suggest to keep the old icon for now, since it is also somewhat unrelated to the rest. You can change it afterwards when Elisa requires KF 5.48. Since it was just released, it is probably a little bit too early.

Jul 14 2018, 1:14 PM · Elisa
astippich added a comment to D13685: allow metadata of tracks without album and tracknumber in database.

I've significantly reduced the scope of this revision by only allowing empty albums and track numbers in the database. After this, I would like to work on empty artists, and then finally empty titles

Jul 14 2018, 1:10 PM · Elisa
astippich updated the test plan for D13685: allow metadata of tracks without album and tracknumber in database.
Jul 14 2018, 1:09 PM · Elisa
astippich updated the diff for D13685: allow metadata of tracks without album and tracknumber in database.
  • rebase
  • only allow tracks without album for now
  • enhance tests for removing tracks with incomplete metadata
Jul 14 2018, 1:08 PM · Elisa
januz added a comment to D14015: New header style for playlist.

Looks like ToolButtons ignore text. I managed to hack this by shoving a Text object inside them but it really messes up the layout and only the icon is clickable.

Jul 14 2018, 12:34 AM · Elisa

Jul 13 2018

ngraham added a comment to D14015: New header style for playlist.

I mean they could be buttons with:

  • no visible borders (the borders appear on hover)
  • the icon on top, rather than on the side
Jul 13 2018, 9:30 PM · Elisa
januz added a comment to D14015: New header style for playlist.

How about putting the icons on top and making them toolbuttons without a visible button-looking border? There's plenty of unused vertical space there, and square buttons might fit well in the available space.

Jul 13 2018, 2:31 PM · Elisa
ngraham added a comment to D14015: New header style for playlist.

How about putting the icons on top and making them toolbuttons without a visible button-looking border? There's plenty of unused vertical space there, and square buttons might fit well in the available space.

Jul 13 2018, 2:21 PM · Elisa
januz added a comment to D14015: New header style for playlist.

There is some room, but it ends up looking more cramped.

Jul 13 2018, 2:19 PM · Elisa
januz updated the diff for D14015: New header style for playlist.

Replace menu with buttons (also eliminates the reverse mode problem)

Jul 13 2018, 2:17 PM · Elisa
ngraham added a comment to D14015: New header style for playlist.

Might there even be room for buttons with text?

Jul 13 2018, 2:08 PM · Elisa
januz added a comment to D14015: New header style for playlist.

Hey guys, yeah there's room for the 4 buttons up there. The main pro for the dropdown was having text for the buttons that modified the playlist, but having the buttons could also simplify things. Sorry I keep forgetting about reversed mode

Jul 13 2018, 2:00 PM · Elisa
ngraham added a comment to D14015: New header style for playlist.

Yeah, it looks like there's room for some buttons up on top without needing a drop-down menu.

Jul 13 2018, 12:55 PM · Elisa

Jul 12 2018

astippich added a comment to D14015: New header style for playlist.

I like the idea of removing the bar at the bottom, but imho the actions should either be all accessible through the menu or still have dedicated buttons, for consistency. Isn't there enough space to add 4 actions instead?

Jul 12 2018, 7:46 PM · Elisa
januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

@mgallien Thanks!

Jul 12 2018, 1:22 AM · Elisa
januz closed D13834: Allow playlist to be hidden.
Jul 12 2018, 1:21 AM · Elisa

Jul 11 2018

mgallien accepted D13834: Allow playlist to be hidden.

Thanks

Jul 11 2018, 6:58 PM · Elisa
januz added inline comments to D13834: Allow playlist to be hidden.
Jul 11 2018, 5:41 PM · Elisa
januz updated the diff for D13834: Allow playlist to be hidden.

Bring back goBack action

Jul 11 2018, 5:41 PM · Elisa
mgallien added a comment to D14018: [WIP] Make labels in header bar clickeable.

This patch isn't finished yet. I've come across a problem with the album view: the openOneAlbum() function requires a databaseID to get the album data but I have no way of getting that in the header bar. I looked around the headerbarmanager code for a bit but I have no idea how we could fetch that. Everything else works.

Jul 11 2018, 5:09 PM · Elisa
mgallien requested changes to D13834: Allow playlist to be hidden.
Jul 11 2018, 3:54 PM · Elisa
januz added a comment to D13834: Allow playlist to be hidden.

I don't quite understand what you guys mean by a different workflow.

I downloaded Lollypop to try it out, but the workflow is almost the same as Elisa for me. There's a global playlist (in a popup), if you click the play button the playlist is cleared and replaced, and you can click the + button to enqueue.

(offtopic: I'm really digging those giant cover images)

I do not know Lolypop very well. I meant players in general where you do not see an explicit global playlist but where you just play the music currently shown.
Some people kept asking for an iTunes like behavior. I also do not know it but I understood that it was optimized to work well without a global playlist.

Jul 11 2018, 3:46 PM · Elisa
mgallien added a comment to D13834: Allow playlist to be hidden.

Thanks for your work.

Jul 11 2018, 3:46 PM · Elisa
hantzv claimed T6293: Fix HeaderBar for missing animations.

I have played a bit with QML, I expect to do okay. But if the team already have something in mind, I'll be glad to implement it.

Jul 11 2018, 6:07 AM · Elisa
mgallien updated subscribers of T6293: Fix HeaderBar for missing animations.

I will mostly be away from keyboard for the next three weeks. If you have questions do not hesitate to also ask in the mailing list. @januz and @ngraham can also help the design of a working solution.
Welcome to the Elisa project

Jul 11 2018, 6:02 AM · Elisa
hantzv added a comment to T6293: Fix HeaderBar for missing animations.

What type of animation should be there? I'm thinking a sliding of the whole background followed by the information (title, album name, etc) fading in.

Jul 11 2018, 5:57 AM · Elisa