ElisaProject
ActivePublic

Recent Activity

Yesterday

mikeroyal added a comment to T7597: Add a progress bar under the current track in playlist.

@ognarb, I will take a look at it and see if I can help.

Mon, Jun 24, 10:47 PM · Elisa
ognarb added a comment to T7597: Add a progress bar under the current track in playlist.

Not the bug is still here:

Mon, Jun 24, 9:20 PM · Elisa
ognarb added a comment to T7597: Add a progress bar under the current track in playlist.

Still, an external drive but Baloo is now disabled. If you want, I could try enabling Baloo again to see if the bug appears again or not.

Mon, Jun 24, 9:15 PM · Elisa
mgallien added a comment to T7597: Add a progress bar under the current track in playlist.

Btw retried Elisa with my big music collection, and it works now. :)

Mon, Jun 24, 9:08 PM · Elisa
ognarb added a comment to T7597: Add a progress bar under the current track in playlist.

Btw retried Elisa with my big music collection, and it works now. :)

Mon, Jun 24, 9:00 PM · Elisa
mgallien closed D21900: fix restore of tracks with missing metadata in playlist.
Mon, Jun 24, 3:33 PM · Elisa
astippich accepted D21900: fix restore of tracks with missing metadata in playlist.

Eventually, all metadata should be optional...
I think for database insertion the track title is still the only one that is a hard requirement, but this should also be removed.

Mon, Jun 24, 3:23 PM · Elisa

Sat, Jun 22

astippich abandoned D21945: Set height and width for MediaPlayerControl buttons.

Turns out that was some leftover code :) so the ToolButton does the correct sizing. I'll just abandon this one here and open a new one. Thanks for insisting! :)

Sat, Jun 22, 6:43 PM · Elisa
ngraham added a comment to D21945: Set height and width for MediaPlayerControl buttons.

LOL! That's probably because of the height of the player bar being hardcoded rather than sizing itself according to its contents + top and bottom padding (an anti-pattern best moved away from in QML user interfaces). I think basing this on a ToolButton rather than a Button is more semantically correct since that's what it is, so +1 if you want to do that.

Sat, Jun 22, 6:21 PM · Elisa
astippich added a comment to D21945: Set height and width for MediaPlayerControl buttons.

True, but then again these are basically glorified ToolButtons, and you don't need to set the size for every ToolButton; it has a correct default size and you only override it as needed. It just seems odd to me that we have to do this at all, and I feel like it points to a problem in the component itself. It should have a correct default size without us having to tell every instance of it how big it needs to be.

Maybe I'm just being a grumpy pedantic old man though. :) I'll let @mgallien decide.

Sat, Jun 22, 6:19 PM · Elisa
ngraham added a comment to D21945: Set height and width for MediaPlayerControl buttons.

True, but then again these are basically glorified ToolButtons, and you don't need to set the size for every ToolButton; it has a correct default size and you only override it as needed. It just seems odd to me that we have to do this at all, and I feel like it points to a problem in the component itself. It should have a correct default size without us having to tell every instance of it how big it needs to be.

Sat, Jun 22, 6:01 PM · Elisa
astippich added a comment to D21945: Set height and width for MediaPlayerControl buttons.

Maybe we could just make the aspect ratio fixed to square in the FlatButtonWithToolTip control? Then we wouldn't need any custom sizing in the player control bar because the width would be limited by the height, which would be correctly chosen based on the height of the player bar.

Sat, Jun 22, 5:59 PM · Elisa
ngraham added a comment to D21945: Set height and width for MediaPlayerControl buttons.

Maybe we could just make the aspect ratio fixed to square in the FlatButtonWithToolTip control? Then we wouldn't need any custom sizing in the player control bar because the width would be limited by the height, which would be correctly chosen based on the height of the player bar.

Sat, Jun 22, 5:29 PM · Elisa
astippich added a comment to D21945: Set height and width for MediaPlayerControl buttons.

Why that? If you do not specify a button size, the style will automatically scale it. Also happes with a plain QML Button

I'm saying that it makes sense to do this change in one place (the parent control) rather than in n places (all the instances of that control).

Sat, Jun 22, 5:27 PM · Elisa
astippich retitled D21945: Set height and width for MediaPlayerControl buttons from set implicitHeight and Width for MediaPlayerControl buttons to Set height and width for MediaPlayerControl buttons.
Sat, Jun 22, 5:26 PM · Elisa
ngraham added a comment to D21945: Set height and width for MediaPlayerControl buttons.

Why that? If you do not specify a button size, the style will automatically scale it. Also happes with a plain QML Button

Sat, Jun 22, 12:36 PM · Elisa
astippich updated the diff for D21945: Set height and width for MediaPlayerControl buttons.
  • fix previous commit
Sat, Jun 22, 12:35 PM · Elisa
astippich updated the diff for D21945: Set height and width for MediaPlayerControl buttons.
  • use Layout.preferredHeight/Width
Sat, Jun 22, 12:31 PM · Elisa
astippich added a comment to D21945: Set height and width for MediaPlayerControl buttons.

Why that? If you do not specify a button size, the style will automatically scale it. Also happes with a plain QML Button

Sat, Jun 22, 12:18 PM · Elisa
ngraham added a comment to D21945: Set height and width for MediaPlayerControl buttons.

It seems like that bug should be fixed in FlatButtonWithToolTip then.

Sat, Jun 22, 12:05 PM · Elisa
astippich added a comment to D21945: Set height and width for MediaPlayerControl buttons.

with different styles, this can look like:

Sat, Jun 22, 11:46 AM · Elisa

Thu, Jun 20

ngraham added a comment to D21945: Set height and width for MediaPlayerControl buttons.

Do we even need to manually specify the width and height at all? To me they look just fine without these lines:

Thu, Jun 20, 10:08 PM · Elisa
astippich added a comment to D21945: Set height and width for MediaPlayerControl buttons.

Basically a tweaked 21430984e5a4 up for review, which I reverted since @ngraham raised concerns

Thu, Jun 20, 6:00 PM · Elisa
astippich requested review of D21945: Set height and width for MediaPlayerControl buttons.
Thu, Jun 20, 5:58 PM · Elisa
astippich updated the summary of D21943: Port the application menu to qqc2.
Thu, Jun 20, 5:23 PM · Elisa
astippich added a comment to D21943: Port the application menu to qqc2.

qqc2, with patch for desktop style

Thu, Jun 20, 5:22 PM · Elisa
astippich requested review of D21943: Port the application menu to qqc2.
Thu, Jun 20, 5:21 PM · Elisa
astippich added a comment to D21920: Port elisa kcm to qqc2.

If you do so, you may hit https://bugs.kde.org/show_bug.cgi?id=405541. But maybe you can find a clever way around that (or just fix it) that I didn't find. :)

Thu, Jun 20, 1:27 PM · Elisa
astippich updated the summary of D21920: Port elisa kcm to qqc2.
Thu, Jun 20, 1:22 PM · Elisa
ngraham added a comment to D21920: Port elisa kcm to qqc2.

If you do so, you may hit https://bugs.kde.org/show_bug.cgi?id=405541. But maybe you can find a clever way around that (or just fix it) that I didn't find. :)

Thu, Jun 20, 1:07 PM · Elisa
ngraham added a comment to D21920: Port elisa kcm to qqc2.

This is a CCBUG: 405144. You could probably upgrade it all the way to BUG: by porting the menu, too.

Thu, Jun 20, 1:06 PM · Elisa
ngraham added a comment to D12992: New elisa icon.

@lshoravi ping! Any chance we can finish up work on this icon and get it in?

Thu, Jun 20, 12:45 PM · Frameworks, Elisa
astippich requested review of D21920: Port elisa kcm to qqc2.
Thu, Jun 20, 10:07 AM · Elisa
astippich added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

+1, though these messages are currently not very useful because they're not actionable. If loading or saving of the playlist failed, what can I do about it? it's not clear. Especially for persistent messages, it's worth it to try to make them actionable somehow. Options include a better error message, a "Try again" button to preserve the illusion of user agency, etc.

Thu, Jun 20, 8:47 AM · Elisa
ngraham added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

+1, though these messages are currently not very useful because they're not actionable. If loading or saving of the playlist failed, what can I do about it? it's not clear. Especially for persistent messages, it's worth it to try to make them actionable somehow. Options include a better error message, a "Try again" button to preserve the illusion of user agency, etc.

I do not think it is such a good idea.
We should better try to use the passive notification by using more components from Kirigami instead of removing them.

Thu, Jun 20, 8:37 AM · Elisa
mgallien added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

+1, though these messages are currently not very useful because they're not actionable. If loading or saving of the playlist failed, what can I do about it? it's not clear. Especially for persistent messages, it's worth it to try to make them actionable somehow. Options include a better error message, a "Try again" button to preserve the illusion of user agency, etc.

Thu, Jun 20, 7:40 AM · Elisa
ngraham added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

+1, though these messages are currently not very useful because they're not actionable. If loading or saving of the playlist failed, what can I do about it? it's not clear. Especially for persistent messages, it's worth it to try to make them actionable somehow. Options include a better error message, a "Try again" button to preserve the illusion of user agency, etc.

Thu, Jun 20, 7:36 AM · Elisa

Wed, Jun 19

astippich added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

Wed, Jun 19, 5:55 PM · Elisa
astippich requested review of D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.
Wed, Jun 19, 5:53 PM · Elisa
astippich closed D21858: Port playlist entry to qqc2.
Wed, Jun 19, 5:35 PM · Elisa
astippich closed D21853: Port track delegate to qqc2.
Wed, Jun 19, 5:35 PM · Elisa
astippich closed D21854: Port mediaplaylistview to qqc2.
Wed, Jun 19, 5:34 PM · Elisa
mgallien accepted D21854: Port mediaplaylistview to qqc2.

Thanks

Wed, Jun 19, 3:33 PM · Elisa
mgallien accepted D21853: Port track delegate to qqc2.

Thanks

Wed, Jun 19, 3:32 PM · Elisa
mgallien added a project to D21900: fix restore of tracks with missing metadata in playlist: Elisa.
Wed, Jun 19, 3:27 PM · Elisa
bcooksley closed T11115: Add environment variable when running tests accessing kfilemetadata extractors as Resolved by committing R857:e973aef222dd: Make sure we specify the needed search paths for QT_PLUGIN_PATH and….
Wed, Jun 19, 7:14 AM · Elisa, build.kde.org
mgallien created T11115: Add environment variable when running tests accessing kfilemetadata extractors.
Wed, Jun 19, 5:51 AM · Elisa, build.kde.org
mgallien accepted D21858: Port playlist entry to qqc2.

Thanks

Wed, Jun 19, 5:25 AM · Elisa

Mon, Jun 17

lemuel added a watcher for Elisa: lemuel.
Mon, Jun 17, 10:08 AM
astippich closed D21859: Use view-media-lyrics for Now Playing View.
Mon, Jun 17, 5:49 AM · Elisa