Create Task
Maniphest T9153

Global shortcuts
Open, WishlistPublic
Actions

Description

This is a task to discuss Elisa's global shortcuts, based on Bug 392989
Note that making a patch for this depends on D13872 and its follow-up patches.

I propose we only let the side-playlist and content views have keyboard focus and have customizable shortcuts for everything else.

Possible Keys:

ActionDefault Key
Toggle FindCTRL+F
Go to Playing now ViewCTRL+0
Go to Album ViewCTRL+1
Go to Artist ViewCTRL+2
Go to Tracks ViewCTRL+3
Go to Genres ViewCTRL+4
Go to Views ViewCTRL+5
Toggle side PlaylistCTRL+T
Play/PauseSpace
Next TrackPage Up
Previous TrackPage Down
Volume UpCTRL++
Volume DownCTRL+-
Skip ahead +5s>
Skip back -5s<

Keys inside content views (not global, whether they are in the browser or playlist depends on keyboard focus):

ActionDefault Key
Open (album/artist/etc)Enter
Replace and PlayShift+Enter
EnqueueCTRL+E
Go BackBackspace
Switch between content view and playlist (if visible)Tab

Related Objects

januz created this task.Jul 7 2018, 9:22 PM
januz triaged this task as Wishlist priority.
ngraham added a subscriber: ngraham.Jul 8 2018, 7:08 PM

Ctrl+T is typically "Open new tab" in apps that have tabs; we might not want to use it for something else here.

I might recommend Ctrl+← and Ctrl+→ to go to the previous and next songs instead of or in addition to the PgUp and PgDn keys.

One thing I miss from iTunes and Rhythmbox is a "Go to currently playing song" shortcut. It would show you the original view style that you were looking at when you started playing something, not the Now Playing view. For some reason this

januz added a comment.Jul 9 2018, 10:19 PM

@ngraham Good point about Ctrl+T , I tried to make them mnemonic but I can see how it could be confusing. What do you think about F9? It's used by the place's panel in Dolphin, so it's a bit similar.

About PgDn /PgUp: I personally prefer single keys to chords but if these are more standard we could add them, or include them as alternates.

In T9153#150470, @ngraham wrote:

One thing I miss from iTunes and Rhythmbox is a "Go to currently playing song" shortcut. It would show you the original view style that you were looking at when you started playing something, not the Now Playing view. For some reason this

I have a patch coming up where the header bar text becomes clickable and you jump to the album/artist view of the song that's playing. We could have shortcuts for those too.

ngraham added a comment.Jul 9 2018, 10:52 PM

F9 is OK, but in general I'm not in favor of using function keys for new shortcuts (except as the secondary shortcut) because increasingly people use laptops that have function keys which are awkward to access. Chords are generally standard, and there's actually a good reason: they still work when you're editing text. That may be rare or nonexistent in Elisa, but it's the principle that counts. :)

I'm ok with PgUp / PgDn being used as secondary shortcuts as long as we have a chord for the primary shortcut.

Gosh, it sure is nice that KDE software supports multiple shortcuts for a single action.

januz added a comment.Jul 10 2018, 3:16 AM

Thinking a bit more about this, we might want to use PgUp/ PgDn to scroll in the playlist/content views so maybe we should go straight for the chord.

Gosh, it sure is nice that KDE software supports multiple shortcuts for a single action.

Yeah, the whole shorcut system is crazy powerful

mgallien added a subscriber: mgallien.Jul 10 2018, 9:08 AM
In T9153#150618, @januz wrote:

Thinking a bit more about this, we might want to use PgUp/ PgDn to scroll in the playlist/content views so maybe we should go straight for the chord.

Gosh, it sure is nice that KDE software supports multiple shortcuts for a single action.

Yeah, the whole shorcut system is crazy powerful

This is a nice feature I have taken from Discover. Thanks to free software I could stand on the shoulders of giants.