| davidedmundson | |
| kossebau |
| Plasma |
The web address for NOAA is no longer valid. So, the new address had to be provided.
Old address: http://www.nnvl.noaa.gov/imageoftheday.php
new address: https://www.nesdis.noaa.gov/content/imagery-and-data
'Image of the day' has a new landing page everyday. So the code had to slightly altered to fetch image from new address.
All plugins should work as usual.
| Lint Skipped |
| Unit Tests Skipped |
Looks like proper work from a quick reading glance at the patch, thanks for providing the patch, Again, not the maintainer and no time to properly review. Needs someone from the active Plasma team to get this in. If no-one responded in the next few days, please ping people again by making another comment here and perhaps trying to poke individual members from https://phabricator.kde.org/project/members/35/ by mentioning them in the comment.
Please also consider becoming maintainer of the potd project, at least for a while, now that you care for it a bit :)
When pushing in the end, please consider applying to 5.12 branch as well, so users of that LTS version can continue to use this potd source instead of experiencing it being dead.
@tagorechandanreddy Hmm, I'm not seeing that this actually works. Console spew says:
kf5.kio.core: Invalid URL: QUrl("/content/three-views-winter-solstice-space")
file:///usr/share/plasma/wallpapers/org.kde.potd/contents/ui/main.qml:46: TypeError: Cannot read property 'Image' of undefinedIs this a bug in your code, or a side effect of the U.S. government being shut down right now? The data source web page (https://www.nesdis.noaa.gov/content/imagery-and-data) says:
Given the frequency with which it seems to be happening these days, maybe we should explicitly handle this case!
😩