Feed Advanced Search

Today

ngraham added a comment to D15718: Do not index the path if the path has no execute permissions..

Making files executable that don't need to be executable is a bad security habit. What if the contents get replaced with something malicious? Suddenly that now-malicious file has execute permissions.

Mon, Sep 24, 4:11 AM · Baloo, Frameworks
ngraham created T9730: Spin down ejected hard drives.
Mon, Sep 24, 4:04 AM · Frameworks
ngraham is attending E477: Bugsquad Bug Day - Okular.
Mon, Sep 24, 3:52 AM · Event: Bugsquad
ngraham is attending E478: Bugsquad Bug Day - Okular.
Mon, Sep 24, 3:52 AM · Event: Bugsquad
ngraham is attending E476: Bugsquad Bug Day - Konsole.
Mon, Sep 24, 3:52 AM · Event: Bugsquad
ngraham is attending E475: Bugsquad Bug Day - Konsole.
Mon, Sep 24, 3:52 AM · Event: Bugsquad
ngraham added a comment to D11880: Add firewall-config and firewall-applet icons.

For the panic mode icon, how about leaving the wall itself black, and only the lock is orange?

Mon, Sep 24, 3:49 AM · Frameworks
ngraham accepted D15719: Create attachment warning for patches.

Wonderful.

Mon, Sep 24, 3:39 AM
ngraham added a comment to D15718: Do not index the path if the path has no execute permissions..

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

A default mask of 0002 or more permissive looks fairly common across distros, and is permissive enough to index files by default.

setfacl -d -m u::rwx ~ or umask 0022 will set default execute permissions on created files. You can set something less permissive on your downloads directory or plasma vault mount with setfacl -d u::rw or similar.

chmod -R 755 ~ will recursively give every file in your home directory execute permisions.

Mon, Sep 24, 3:26 AM · Baloo, Frameworks
ngraham requested changes to D15718: Do not index the path if the path has no execute permissions..
Mon, Sep 24, 3:06 AM · Baloo, Frameworks
ngraham added a comment to T7983: Reevaluate design vision and principles.

Whoops! I do indeed. Edited the original to be accurate. :)

Mon, Sep 24, 12:52 AM · VDG, KDE Human Interface Guidelines
ngraham requested changes to D15718: Do not index the path if the path has no execute permissions..

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

Mon, Sep 24, 12:51 AM · Baloo, Frameworks

Yesterday

ngraham added a comment to D15717: Fix spelling errors.

Landed on master, so the change will show up in KDE Plasma 5.15. See https://community.kde.org/Schedules/Plasma_5 for more information.

Sun, Sep 23, 10:06 PM · Plasma
ngraham committed R99:d3c6da59f723: Fix spelling errors (authored by borispek).
Fix spelling errors
Sun, Sep 23, 10:05 PM
ngraham closed D15717: Fix spelling errors.
Sun, Sep 23, 10:05 PM · Plasma
ngraham added a comment to D15717: Fix spelling errors.

Hi,

I'll need to know your real name and email address. Can you provide that information?

Boris Pek <tehnick-8@yandex.ru>

I supposed that all necessary information was in the patch prepared using git format-patch .... It looks I have missed something in phabricator documentation. (This is my first patch to KDE after a huge break...)

Sun, Sep 23, 10:04 PM · Plasma
ngraham accepted D15717: Fix spelling errors.

Whoops! Thanks for fixing those.

Sun, Sep 23, 9:49 PM · Plasma
ngraham added a comment to D11880: Add firewall-config and firewall-applet icons.

For the benefit of others, here's what they look like now:

Sun, Sep 23, 9:27 PM · Frameworks
ngraham added a comment to D13901: Touch support for Gwenview.

Wow, pinch zooming is hugely improved with this new version. Nice work!

Sun, Sep 23, 8:57 PM · Gwenview
ngraham added a comment to D15093: Add WireGuard capability..

How about changing the outline or background of the text box to the Positive or Negative color from the active color theme? That way (for people with sensible color themes), the text box would show red if the value is invalid. I believe GNOME does something similar to this for their IP address validator, and in my experience it works quite nicely.

Sun, Sep 23, 8:41 PM · Plasma
ngraham requested changes to D7962: Implement several new print scaling options.

I gave this a try today and it works nicely! Awesome work! I'd still like some user interface improvements though, because gating these scaling options behind Force rasterization is not very user friendly: the connection between that setting and the scaling options is not likely to be apparent to any user who does not also happen to be a PDF expert or an Okular developer. :)

Sun, Sep 23, 8:31 PM · Okular
ngraham added a reviewer for D7962: Implement several new print scaling options: VDG.
Sun, Sep 23, 8:24 PM · Okular
ngraham added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

Ok, thanks for the info. I'll excuse myself now since the technical discussion is way over my head. I just wanted to express support for the idea behind this patch.

Sun, Sep 23, 7:51 PM · Plasma
ngraham added reviewers for D8532: [WIP] Restrict file extractor with Seccomp: Frameworks, smithjd, bruns.

+1 for something rather than nothing. No comment on the technical aspect, but I'm adding more reviewers who can hopefully help un-wedge this patch.

Sun, Sep 23, 7:47 PM · Baloo, Frameworks
ngraham added a comment to D15514: [libbreezecommon] Use box blur instead of FFT blur.

Still +1, looks great!

Sun, Sep 23, 7:42 PM · Plasma
ngraham added a comment to D15645: [WIP] Add scheme selection menu with a "System" entry..

Very much +1 on the end goal!

Sun, Sep 23, 3:52 AM · Frameworks
ngraham added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

We're past 5.14 and into 5.15 territory now. Does this deserve another look?

Sun, Sep 23, 3:27 AM · Plasma

Sat, Sep 22

ngraham added a comment to T7785: PipeWire support in remote access to KWin.

What's the status of this?

Sat, Sep 22, 11:06 PM · Plasma (Plasma 5.14), KWin, Plasma on Wayland
ngraham added a comment to D15448: Send file contents in chunks.

How is this looking now that D15426 has gone in?

Sat, Sep 22, 10:59 PM
ngraham added a comment to T9460: Consider a more user-friendly SpinBox control.

For what it's worth, I notice that ElementaryOS is already doing this:

Sat, Sep 22, 10:56 PM · KDE Human Interface Guidelines, Kirigami, Breeze, VDG
ngraham committed R119:17892cd23ff2: Relabel "Mouse Click Emulation" to "Tap to Click" (authored by sharvey).
Relabel "Mouse Click Emulation" to "Tap to Click"
Sat, Sep 22, 10:42 PM
ngraham closed D15699: Relabel "Mouse Click Emulation" to "Tap to Click".
Sat, Sep 22, 10:42 PM · Plasma
ngraham updated the summary of D15699: Relabel "Mouse Click Emulation" to "Tap to Click".
Sat, Sep 22, 10:41 PM · Plasma
ngraham accepted D15699: Relabel "Mouse Click Emulation" to "Tap to Click".

+1; "Tap to Click" is by far the more commonly used and understood string.

Sat, Sep 22, 10:40 PM · Plasma
ngraham added a comment to D15524: Cirkuit version 0.5.0.

(also, thank you for doing all this work!)

Sat, Sep 22, 9:02 PM · Documentation
ngraham added a comment to D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

So this doesn't completely fix https://bugs.kde.org/show_bug.cgi?id=375765? More is needed?

Sat, Sep 22, 8:56 PM · Frameworks
ngraham updated the test plan for D15583: [Balooctl] remove directory parent check.
Sat, Sep 22, 8:28 PM · Baloo, Frameworks
ngraham updated the diff for D15583: [Balooctl] remove directory parent check.

Remove parent directory check entirely; it's not necessary

Sat, Sep 22, 8:25 PM · Baloo, Frameworks
ngraham added a comment to D15583: [Balooctl] remove directory parent check.

Oh wow, you're right. Let me fix balooctl to support that, then.

Sat, Sep 22, 8:15 PM · Baloo, Frameworks
ngraham added a comment to D15589: Add proper labels to Trash Emptied notification.

If that's the case, do we have just a trash icon, without the folder?

Sat, Sep 22, 8:01 PM · Dolphin
ngraham added a comment to D15644: Provide option to hide menu bar for Ksysguard.

Hi Nathaniel, thanks for all the support.
I can understand and agree with your concerns.
Not sure but maybe an option could be to add the hide menu bar entry in the setting menu via kxmlguiwindow

Ah but won't that menu become invisible once the menubar is disabled?

Sat, Sep 22, 7:52 PM · Plasma
ngraham committed R119:c4dbf66fe135: Merge branch 'Plasma/5.14' (authored by ngraham).
Merge branch 'Plasma/5.14'
Sat, Sep 22, 3:42 PM
ngraham committed R119:a5e45788fa33: Add lock icon to desktop context menu (authored by anemeth).
Add lock icon to desktop context menu
Sat, Sep 22, 3:42 PM
ngraham closed D15683: Add lock icon to desktop context menu.
Sat, Sep 22, 3:40 PM · Plasma
ngraham added a comment to D15683: Add lock icon to desktop context menu.

Why not also add icons to other items instead of other X number of commits coming later by Y number of people?
Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one as “group”, like ascending for sorting, center for alignement, etc.

Sat, Sep 22, 3:40 PM · Plasma
ngraham added a comment to D9336: Change default mouse mode to TextSelect.

Thanks anyway Michael!

Sat, Sep 22, 3:36 PM · Okular
ngraham added a comment to D15687: [Device Notifier] Avoid accessing attributes of stale UDIs.

Code change looks pretty sane to me.

Sat, Sep 22, 3:33 PM · Plasma
ngraham added inline comments to D15589: Add proper labels to Trash Emptied notification.
Sat, Sep 22, 3:22 PM · Dolphin
ngraham added a comment to D15583: [Balooctl] remove directory parent check.

I think the whole startsWith is flawed - it should be possible to have a e.g. "/home/user/foo/bar" include when "/home/user/foo" has been excluded.

Sat, Sep 22, 3:20 PM · Baloo, Frameworks

Fri, Sep 21

ngraham added a comment to D7962: Implement several new print scaling options.

No problem, and don't let me rush you!

Fri, Sep 21, 6:56 PM · Okular
ngraham added a comment to D11880: Add firewall-config and firewall-applet icons.

Now that's what I'm talkin' about. Those are awesome in my book. Other VDG folks, thoughts?

Fri, Sep 21, 6:50 PM · Frameworks
ngraham accepted D15683: Add lock icon to desktop context menu.

LGTM!

Fri, Sep 21, 6:46 PM · Plasma
ngraham added a comment to D11880: Add firewall-config and firewall-applet icons.

I like your depiction of the logical consequences of the firewall being depicted as a wall, @bruns. That seems great. I think a further exploration is warranted:

Fri, Sep 21, 5:05 PM · Frameworks
ngraham added inline comments to D15644: Provide option to hide menu bar for Ksysguard.
Fri, Sep 21, 4:47 PM · Plasma
ngraham added a comment to D15644: Provide option to hide menu bar for Ksysguard.

Thanks! Please also remove - Bug 395349 from the title and replace it with BUG: 395349 in the Summary section.

Fri, Sep 21, 4:44 PM · Plasma
ngraham added a comment to D14561: [kcmkwin/compositing] Rename Candy category to Eye Candy.

Can't we work out some agreement here? "Eye Candy" in an unambiguously better user-visible string than "Candy", and it would be a shame to not change it because of a disagreement that I'm sure we can resolve.

Fri, Sep 21, 4:32 PM · KWin
ngraham added a comment to D12162: Add support for touch scrolling in Dolphin.

Awesome, thank you!

Fri, Sep 21, 4:13 PM · Dolphin
ngraham added a comment to D9336: Change default mouse mode to TextSelect.

Doesn't this make Okular much less touch-friendly by default?

Possibly. I did not have this in mind when creating this revision. How can I test this without a touch screen? Is using just the left mouse button on a "normal" computer a proper way to simulate this?

Fri, Sep 21, 3:55 PM · Okular
ngraham committed R102:a0aa9373092a: Merge branch 'Plasma/5.14' (authored by ngraham).
Merge branch 'Plasma/5.14'
Fri, Sep 21, 3:15 PM
ngraham committed R102:fde8d23beeae: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM (authored by bosimonsen).
Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM
Fri, Sep 21, 3:12 PM
ngraham closed D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM.
Fri, Sep 21, 3:12 PM · Plasma
ngraham updated the summary of D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM.
Fri, Sep 21, 3:04 PM · Plasma
ngraham reopened D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM.

Whoops! I saw the name and didn't check the paths. Will land it for you.

Fri, Sep 21, 3:04 PM · Plasma
ngraham closed D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM.

Looks like @zzag landed this patch for you last month: https://bugs.kde.org/show_bug.cgi?id=366451#c21

Fri, Sep 21, 2:50 PM · Plasma
ngraham added a comment to D15632: Change bug writing guideling link to bug reporting wiki page.

@bcooksley, I think you'll need to land this since permissions to the websites- repos are quite restricted.

Fri, Sep 21, 2:44 PM · Bugsquad
ngraham added a comment to D15631: Add .arcconfig file.

@bcooksley, I think you'll need to land this since permissions to the websites- repos are quite restricted.

Fri, Sep 21, 2:43 PM · Bugsquad
ngraham requested changes to D15644: Provide option to hide menu bar for Ksysguard.

Thank you for the patch! I see that this is your first KDE contribution, how exciting! This needs some work, so please don't get discouraged, and I'll help you where I can. Here are the problems that need to be solved in order for the patch to be landable:

Fri, Sep 21, 2:28 PM · Plasma
ngraham requested changes to D6280: Dolphin softer drop shadow for thumbnails.

Yeah, I think this would need some tweaks to be land-able at this point.

Fri, Sep 21, 2:16 PM · Dolphin
ngraham added a comment to D15630: Create text template for bug creation comments.

Yeah if you don't mind, let's do the arcconfig file in another patch. It's good practice to keep commits atomic. :)

Fri, Sep 21, 4:44 AM · Bugsquad
ngraham added a comment to D15630: Create text template for bug creation comments.

Awesome, I'm impressed that you found this! What do you think about adding a link to https://community.kde.org/Get_Involved/Bug_Reporting into the template somewhere? Or should that be done somewhere in the main UI elsewhere?

Fri, Sep 21, 4:23 AM · Bugsquad
ngraham added a comment to D6280: Dolphin softer drop shadow for thumbnails.

We removed the shadow entirely for small sizes in cf0052c2968a7c3e110e24134dbe7ef13c835995. So this change would just be for large sizes now. Do you think this is still needed?

Fri, Sep 21, 3:21 AM · Dolphin
ngraham added a comment to T7983: Reevaluate design vision and principles.

Open questions to me

• What is the default indicator for edges? e.g. in material design it‘s shadows and secondary indicators is different background color and/or opacity. We often use lines.
Fri, Sep 21, 3:15 AM · VDG, KDE Human Interface Guidelines
ngraham accepted D11880: Add firewall-config and firewall-applet icons.

I like the brick wall metaphor, which does a good job of communicating the point, while being visually distinct from the shield.

Fri, Sep 21, 3:05 AM · Frameworks
ngraham updated the test plan for D15583: [Balooctl] remove directory parent check.
Fri, Sep 21, 2:43 AM · Baloo, Frameworks
ngraham updated the diff for D15583: [Balooctl] remove directory parent check.
  • Address review comments and do it better
Fri, Sep 21, 2:38 AM · Baloo, Frameworks
ngraham planned changes to D15583: [Balooctl] remove directory parent check.

Actually it looks like we shouldn't even use it anyway for other reasons per the documentation: https://doc.qt.io/qt-5/qdir.html#separator

Fri, Sep 21, 2:30 AM · Baloo, Frameworks
ngraham added a comment to T9091: Merge PulseAudio and Phonon KCM.

Cool, thanks for the status update. And if you ask your questions here, maybe whoever's in the know can have a shot at can answering them.

Fri, Sep 21, 2:04 AM · Plasma

Thu, Sep 20

ngraham accepted D12098: Resize content area to correct dimensions after zooming to Auto Fit.

Works for me: fixes the bug and doesn't seem to regress things after a number of other move and zoom operations.

Thu, Sep 20, 8:45 PM · Okular
ngraham added a comment to D9336: Change default mouse mode to TextSelect.

Doesn't this make Okular much less touch-friendly by default?

Thu, Sep 20, 8:32 PM · Okular
ngraham added a comment to D7962: Implement several new print scaling options.

Any movement on Henrik's review comments?

Thu, Sep 20, 8:30 PM · Okular
ngraham added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

Where are we at with this? What are the blockers to landing it?

Thu, Sep 20, 8:30 PM · Okular
ngraham added a comment to D15611: [KCollapsibleGroupBox] Respect style's widget animation duration.

That would only affect the speed of appearing and disappearing though, right? Not the total duration that is status on the screen.

Thu, Sep 20, 5:02 PM · Frameworks
ngraham added a comment to D15598: Sort icon and cursor themes case-insensitively.

Darn, looks like arc didn't notice my rebase on 5.14. Oh well, I guess this'll go into 5.15.

Thu, Sep 20, 3:28 PM · Plasma
ngraham committed R99:b943d4ac6e2c: Sort icon and cursor themes case-insensitively (authored by ngraham).
Sort icon and cursor themes case-insensitively
Thu, Sep 20, 3:25 PM
ngraham closed D15598: Sort icon and cursor themes case-insensitively.
Thu, Sep 20, 3:25 PM · Plasma
ngraham added a comment to D15598: Sort icon and cursor themes case-insensitively.

I'll keep setSortRole(Qt::DisplayRole) for explicitness if nobody objects.

Thu, Sep 20, 3:23 PM · Plasma
ngraham added a comment to D15598: Sort icon and cursor themes case-insensitively.

@wbauer, thanks for the hint. I've tested this with xcursor-themes and verified that it works for me too.

Thu, Sep 20, 3:22 PM · Plasma
ngraham abandoned D15610: Add "Create Folder" action to default toolbar.

Maybe the amount of buttons is not really the issue, if they didn't have labels by default, we would have a lot more room. Thoughts?

Thu, Sep 20, 2:39 PM · Dolphin
ngraham committed R266:65ea55df42ca: Add plus symbol to document-new.svg (authored by pstefan).
Add plus symbol to document-new.svg
Thu, Sep 20, 2:18 PM
ngraham closed D15618: Add plus symbol to document-new.svg.
Thu, Sep 20, 2:11 PM · Frameworks
ngraham accepted D15618: Add plus symbol to document-new.svg.

Perfecto!

Thu, Sep 20, 1:58 PM · Frameworks
ngraham requested changes to D15618: Add plus symbol to document-new.svg.

Thanks, this looks perfect for the 16px size! But we'll need the same change for the 22, 24, and 23 px sizes too. Could you do those, too?

Thu, Sep 20, 1:18 PM · Frameworks
ngraham updated the summary of D15618: Add plus symbol to document-new.svg.
Thu, Sep 20, 1:15 PM · Frameworks
ngraham added reviewers for D15618: Add plus symbol to document-new.svg: Breeze, VDG.

Wow, that was fast.

Thu, Sep 20, 1:15 PM · Frameworks
ngraham added a comment to D15598: Sort icon and cursor themes case-insensitively.

Maybe it would be better to derive CursorThemesModel and IconThemesModel from QSortFilterProxyModel instead of QStandardItemModel, and keep the previous fix?

Thu, Sep 20, 1:14 PM · Plasma
ngraham updated the diff for D15598: Sort icon and cursor themes case-insensitively.

Address review comments

Thu, Sep 20, 1:11 PM · Plasma
ngraham accepted D15611: [KCollapsibleGroupBox] Respect style's widget animation duration.

Indeed Breeze style was already updated to return the actual configured duration on Qt 5.10.

Would KMessageWidget need the same change?

Thu, Sep 20, 1:05 PM · Frameworks
ngraham added a comment to D15611: [KCollapsibleGroupBox] Respect style's widget animation duration.

Shouldn't the duration respect the global setting rather than being hardcoded to 500ms?

Thu, Sep 20, 4:07 AM · Frameworks
ngraham updated the diff for D15598: Sort icon and cursor themes case-insensitively.

Rebase on Plasma/5.14 branch

Thu, Sep 20, 4:06 AM · Plasma
ngraham added reviewers for D15583: [Balooctl] remove directory parent check: Frameworks, cfeck.
Thu, Sep 20, 4:03 AM · Baloo, Frameworks