Feed Advanced Search

Yesterday

ngraham added a comment to D16861: Improve contrast for crosshair cursors.

Imagine that, reading the README. :) If manual work is required for each image, that seems like all the more reason to only include the two changed ones in the diff.

Tue, Nov 13, 10:35 PM · Plasma
ngraham updated the diff for D16848: Revamp Icon Design and Emblem pages.

Correct spelling error

Tue, Nov 13, 9:38 PM · KDE Human Interface Guidelines
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

FWIW the actual crosshair cursors seem better to me now, especially the Breeze snow one. You could maybe just take the changed files for the crosshairs and make a new diff with just them if you can't figure out the other issue.

Tue, Nov 13, 9:36 PM · Plasma
ngraham added a comment to D16082: Notify headphone being plugged in on some hardware.

Now that I think about it, maybe we keep it the way it is and see if anyone actually complains rather than trying to make the perfect the enemy of the good. I don't think I've actually heard any complaints from the jack always displaying a headphone icon in the applet itself.

Tue, Nov 13, 9:32 PM · Plasma
ngraham added a comment to D16082: Notify headphone being plugged in on some hardware.

So now the question is whether it is acceptable to show a headphone on the OSD when we could have been plugging something else in the jack.

Tue, Nov 13, 8:56 PM · Plasma
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

So is there a script that regenerates all the X11 cursor files from the SVG whenever it's changed or something? Because I'm willing to bet you didn't change all 654 cursors...

Tue, Nov 13, 8:52 PM · Plasma
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

Don't ask me, I just live here. :)

Tue, Nov 13, 8:49 PM · Plasma
ngraham updated the summary of D16824: [PlacesPanel] Port to KFilePlaceEditDialog.
Tue, Nov 13, 8:45 PM · Dolphin
ngraham accepted D16825: Export again KFilePlaceEditDialog.
Tue, Nov 13, 8:45 PM · Frameworks
ngraham added a comment to D16824: [PlacesPanel] Port to KFilePlaceEditDialog.

Shouldn't that be 19.04.0? It doesn't matter that it will be in a future beta release; that's implied.

Tue, Nov 13, 8:44 PM · Dolphin
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

I think either way would work. For maximum surety, I would download it locally and then do arc diff --update D16861.

Tue, Nov 13, 8:39 PM · Plasma
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

Go for it! That bugged me too.

Tue, Nov 13, 7:40 PM · Plasma
ngraham updated the summary of D16832: fix empty runner list after switching to new locale.
Tue, Nov 13, 7:12 PM · Localization, Frameworks
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

Would you like to take over? I have a feeling that you can do a better job than I can, and you also know what you're doing with the tools, too. :)

Tue, Nov 13, 7:08 PM · Plasma
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

Yeah, they currently have hard edges. I'm sadly pretty abysmal with this kind of pixel art, but hopefully I'll muddle through...

Maybe the original cursors were made with SVG sources? Could those be found somewhere?

Tue, Nov 13, 7:03 PM · Plasma
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

Yeah, they currently have hard edges. I'm sadly pretty abysmal with this kind of pixel art, but hopefully I'll muddle through...

Tue, Nov 13, 6:57 PM · Plasma
ngraham updated the diff for D16861: Improve contrast for crosshair cursors.

Remove interior gradients in favor of a flat fill of the standard color

Tue, Nov 13, 6:51 PM · Plasma
ngraham updated the test plan for D16861: Improve contrast for crosshair cursors.
Tue, Nov 13, 6:48 PM · Plasma
ngraham requested changes to D16864: Updated page about typography.

I think this needs an implementation/How to use section that recommends the use of Heading elements to generatedifferently-sized text. Otherwise it's not clear how developers are supposed to accomplish this if they aren't supposed to use fixed point values.

Tue, Nov 13, 6:33 PM · KDE Human Interface Guidelines
ngraham accepted D16867: Don't generate appstream data for files that lack a description.

Thanks, this looks like a good fix.

Tue, Nov 13, 6:14 PM · Frameworks
ngraham added a comment to D16861: Improve contrast for crosshair cursors.

It is indeed a weird gradient. I was just trying to make the minimum required number of changes to fix the bug, but I can fix that too if you'd like.

Tue, Nov 13, 6:13 PM · Plasma
ngraham updated subscribers of T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 2:38 PM · VDG, Dolphin
ngraham added a revision to T8349: Improve Places panel usability and presentation: D7700: Show list of tags in PlacesView.
Tue, Nov 13, 2:36 PM · VDG, Dolphin
ngraham added a task to D7700: Show list of tags in PlacesView: T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 2:36 PM · Frameworks, Dolphin
ngraham accepted D7700: Show list of tags in PlacesView.

A surprisingly small amount of code for a nice feature. Code looks good to me except for one minor thing. This works great in my testing now. I say let's ship it, especially because it won't result in any UI changes at all for people who don't use tags.

Tue, Nov 13, 2:35 PM · Frameworks, Dolphin
ngraham added a comment to D7700: Show list of tags in PlacesView.

Me neither. Can you rebase this on current master?

Tue, Nov 13, 12:02 PM · Frameworks, Dolphin
ngraham added a reviewer for D16861: Improve contrast for crosshair cursors: Plasma.
Tue, Nov 13, 11:39 AM · Plasma
ngraham requested review of D16861: Improve contrast for crosshair cursors.
Tue, Nov 13, 11:38 AM · Plasma
ngraham added inline comments to D16827: Revamp menu guidelines.
Tue, Nov 13, 11:14 AM · KDE Human Interface Guidelines
ngraham updated the task description for T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 11:13 AM · VDG, Dolphin
ngraham added a revision to T8349: Improve Places panel usability and presentation: D16852: Add Documents to the default list of Places.
Tue, Nov 13, 11:12 AM · VDG, Dolphin
ngraham added a task to D16852: Add Documents to the default list of Places: T8349: Improve Places panel usability and presentation.
Tue, Nov 13, 11:12 AM · Frameworks
ngraham added a project to D16827: Revamp menu guidelines: KDE Human Interface Guidelines.
Tue, Nov 13, 11:10 AM · KDE Human Interface Guidelines
ngraham added a comment to D16141: Disable unmount option for / or /home.

Cool, go for it!

Tue, Nov 13, 11:10 AM · Frameworks
ngraham edited reviewers for D16857: Do not disconnect all StorageAccess signals when unmounting, added: Frameworks, bruns; removed: VDG.
Tue, Nov 13, 11:04 AM · Dolphin
ngraham added a comment to D16836: [effects] Split the Fade effect.

Very cool, +1 for putting these effects into an exclusive group.

Have we given any thought to how to better present the exclusive groups in the KCM? Right now it's not as clear as it could be.

As I spent quite some time on that: it's difficult to present this in a good way and I implemented the best solution I found. If we want to present it better we might have to completely rethink the effects kcm, but we also did that several times. The big problem is that it's exclusive group which could also contain none. That's from a UI perspective really difficult.

Tue, Nov 13, 11:03 AM · KWin
ngraham accepted D16858: [effects] Move Fade, Glide, and Scale effect into exclusive group.
Tue, Nov 13, 11:01 AM · KWin
ngraham updated the diff for D16848: Revamp Icon Design and Emblem pages.
  • Improve clarify of action/status icon section
  • Replace one more old image that showed outdated icons
Tue, Nov 13, 10:55 AM · KDE Human Interface Guidelines
ngraham added inline comments to D16848: Revamp Icon Design and Emblem pages.
Tue, Nov 13, 10:20 AM · KDE Human Interface Guidelines
ngraham updated the diff for D16848: Revamp Icon Design and Emblem pages.

Address review comments

Tue, Nov 13, 10:20 AM · KDE Human Interface Guidelines
ngraham added a comment to D16848: Revamp Icon Design and Emblem pages.

Actually, the 8px emblem icons at the very bottom of the page look blurry. Are you sure you took that screenshot with them at 100% size?

Tue, Nov 13, 9:59 AM · KDE Human Interface Guidelines
ngraham updated the summary of D16848: Revamp Icon Design and Emblem pages.
Tue, Nov 13, 4:06 AM · KDE Human Interface Guidelines
ngraham accepted D16852: Add Documents to the default list of Places.

Oh, this doesn't actually have any effect on the test since the item is only created conditionally, and the testing environment's homedir doesn't create the XDG dirs by default. So the tests still pass, whoo. Though it isn't actually being tested, but that's also happening for the other conditional XDG items. Not your fault, and that should be fixed elsewhere.

Tue, Nov 13, 4:05 AM · Frameworks
ngraham updated the diff for D16848: Revamp Icon Design and Emblem pages.

Correct Shade Black color code

Tue, Nov 13, 3:59 AM · KDE Human Interface Guidelines
ngraham updated the diff for D16848: Revamp Icon Design and Emblem pages.

Address review comments

Tue, Nov 13, 3:51 AM · KDE Human Interface Guidelines
ngraham requested changes to D16852: Add Documents to the default list of Places.

+1 conceptually, but...

Tue, Nov 13, 3:39 AM · Frameworks
ngraham accepted D16141: Disable unmount option for / or /home.

Wouldn't you know it, now it works for me. It probably worked all along; I bet I was doing something wrong, sorry!

Tue, Nov 13, 1:07 AM · Frameworks
ngraham added a comment to D16848: Revamp Icon Design and Emblem pages.

The new icon to show video, it reminds me heavily about VLC. Are we going with that design?

Tue, Nov 13, 1:05 AM · KDE Human Interface Guidelines

Mon, Nov 12

ngraham added a reviewer for D16827: Revamp menu guidelines: VDG.
Mon, Nov 12, 11:49 PM · KDE Human Interface Guidelines
ngraham updated the diff for D16827: Revamp menu guidelines.
  • Address review comments
  • Clarify when a menu bar is mandatory, optional, or not permitted
Mon, Nov 12, 11:47 PM · KDE Human Interface Guidelines
ngraham added inline comments to D16827: Revamp menu guidelines.
Mon, Nov 12, 11:47 PM · KDE Human Interface Guidelines
ngraham added a reviewer for D16848: Revamp Icon Design and Emblem pages: KDE Human Interface Guidelines.
Mon, Nov 12, 11:22 PM · KDE Human Interface Guidelines
ngraham requested review of D16848: Revamp Icon Design and Emblem pages.
Mon, Nov 12, 11:21 PM · KDE Human Interface Guidelines
ngraham added a comment to D16840: Fix contrast and other small visual issues of Kdots icon.

Let's also update the title so the commit message is accurate.

Mon, Nov 12, 5:53 PM · Frameworks
ngraham accepted D16840: Fix contrast and other small visual issues of Kdots icon.

Same. That's fantastic!

Mon, Nov 12, 5:52 PM · Frameworks
ngraham added a comment to D16840: Fix contrast and other small visual issues of Kdots icon.

If the contrast is bad, I don't think this would require a full re-do; probably the light gray outline around the square could just be darkened up a bit.

Mon, Nov 12, 5:11 PM · Frameworks
ngraham added a comment to D16810: Update breeze-light and breeze-dark colorschemes.

As far as I could tell this diff was only about improving consistency, not introducing any design changes. If the orange color in Breeze Dark is too dark, it should be changed everywhere all at once, after some discussion. :)

Mon, Nov 12, 5:01 PM · Plasma, Breeze, VDG, Frameworks
ngraham added a comment to D16841: Mobile text selection controls.

I was thinking within the same text field.

Mon, Nov 12, 4:43 PM · Frameworks
ngraham added a comment to D16841: Mobile text selection controls.

I've always thought a "move" action for text would be nice on mobile. Traditional copy-paste is the kind of multi-step operation that's a lot more cumbersome to do with your fingers than it is with a keyboard.

Mon, Nov 12, 4:31 PM · Frameworks
ngraham accepted D16810: Update breeze-light and breeze-dark colorschemes.

Just tried it out and it's good for me too. Since Plasma folks approve, I say ship it!

Mon, Nov 12, 2:12 PM · Plasma, Breeze, VDG, Frameworks
ngraham added a comment to D16609: replace postinst flatpak addition with a service attempting it every 30m.

(e.g. train wifi

Mon, Nov 12, 2:12 PM
ngraham added a comment to D16836: [effects] Split the Fade effect.

Very cool, +1 for putting these effects into an exclusive group.

Mon, Nov 12, 2:05 PM · KWin
ngraham added a comment to D16830: WIP: Tabbar: Add 'File Properties' menu item and three more (Rename, Delete and Compare).

Can you propose the exact place in the File menu where those items should be located? E.g. below "Print Preview"? Maybe in a submenu to avoid cluttering the top level? Maybe remove the separator above "Export as HTML..."?

Mon, Nov 12, 4:14 AM · Kate
ngraham accepted D16767: Improve Ux for the places panel's hidden items.

Thanks, this is great UI-wise now! Big thumbs up.

Mon, Nov 12, 4:13 AM · Dolphin

Sun, Nov 11

ngraham added a comment to D8912: Added a set of Game Folder icons.

That git command doesn't work for me.

╰ git commit --amend author="Andrey Orst <andreyorst@gmail.com>"
error: pathspec 'author=Andrey Orst <andreyorst@gmail.com>' did not match any file(s) known to git
Sun, Nov 11, 11:21 PM · Frameworks
ngraham accepted D8912: Added a set of Game Folder icons.

Looks great!

Sun, Nov 11, 10:09 PM · Frameworks
ngraham added a comment to D16830: WIP: Tabbar: Add 'File Properties' menu item and three more (Rename, Delete and Compare).

Ah, I have wanted these for years!!! Can you make sure these are also in the File menu? We can't have functionality that's only accessible via context menu.

Sun, Nov 11, 8:32 PM · Kate
ngraham added a comment to D16819: Use 'Copy Path' instead of 'Copy Filename' consistently.

Yeah, "Copy file path" is fine too. Maybe even better.

Sun, Nov 11, 8:03 PM · Kate
ngraham added a reviewer for D16827: Revamp menu guidelines: KDE Human Interface Guidelines.
Sun, Nov 11, 6:35 PM · KDE Human Interface Guidelines
ngraham requested review of D16827: Revamp menu guidelines.
Sun, Nov 11, 6:34 PM · KDE Human Interface Guidelines
ngraham added a dependent revision for D16822: WIP: Add 'Open Containing Folder' to Project plugin's tree context menu: D16823: Add 'Properties' to Project plugin's tree context menu.
Sun, Nov 11, 5:37 PM · Kate
ngraham added a dependency for D16823: Add 'Properties' to Project plugin's tree context menu: D16822: WIP: Add 'Open Containing Folder' to Project plugin's tree context menu.
Sun, Nov 11, 5:37 PM · Kate
ngraham accepted D16815: Create new Sublime Text icon.

Looks great to me too. I say ship it! Wanna do the honors, @ndavis? :)

Sun, Nov 11, 4:51 PM · Frameworks
ngraham added inline comments to D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 4:44 PM · Dolphin
ngraham requested changes to D16767: Improve Ux for the places panel's hidden items.
Sun, Nov 11, 4:28 PM · Dolphin
ngraham added a comment to D16641: Enable three more plugins by default.

+1!

Sun, Nov 11, 4:20 PM · Kate
ngraham accepted D16647: Make plugin titles and descriptions consistent in casing and wording.

Looks great to me!

Sun, Nov 11, 4:18 PM · Kate
ngraham added a reviewer for D16647: Make plugin titles and descriptions consistent in casing and wording: VDG.
Sun, Nov 11, 4:18 PM · Kate
ngraham added a comment to D8912: Added a set of Game Folder icons.

Thanks for the status update, Andrey. I'm sorry we didn't notice this last year! Noah, would you like to commandeer this and finish it up?

Sun, Nov 11, 3:57 PM · Frameworks
ngraham added a comment to D16819: Use 'Copy Path' instead of 'Copy Filename' consistently.

+1 on "Copy Path."

Sun, Nov 11, 3:51 PM · Kate
ngraham added a comment to D8912: Added a set of Game Folder icons.

It's actually already in the HIG, kind of, but it's not obvious. A rewrite would help a lot.

Sun, Nov 11, 2:23 PM · Frameworks
ngraham accepted D16818: Copy to clipboard: match item order of copied text with GUI.

Thanks for the quick patch! Works for me.

Sun, Nov 11, 2:21 PM · Plasma
ngraham added a comment to D16652: Terminal plugin: add default shortcut F4 for Toggle Focus.
Sun, Nov 11, 2:13 PM · Kate
ngraham added a comment to D16815: Create new Sublime Text icon.

I have made a proper Breeze version of the Sublime icon.


It has the slightly rounded edges and the light and dark bars of the Konsole and VLC Icons at the top and bottom.

Sun, Nov 11, 1:42 PM · Frameworks
ngraham committed R985:f61a59978603: generally improve "Contribute" page and add Arch instructions (authored by ngraham).
generally improve "Contribute" page and add Arch instructions
Sun, Nov 11, 6:32 AM
ngraham requested changes to D16815: Create new Sublime Text icon.

I know this is a bugfix, but...

Sun, Nov 11, 12:35 AM · Frameworks

Sat, Nov 10

ngraham committed R241:f87ac6813fa5: [Places panel] Use new `folder-root` icon for Root item (authored by ngraham).
[Places panel] Use new `folder-root` icon for Root item
Sat, Nov 10, 3:48 PM
ngraham added a comment to D8912: Added a set of Game Folder icons.

I've had so bad times of getting rid of Cuttlefish on my system because there was no package with the similar name. I'll install it though.

Sat, Nov 10, 3:33 PM · Frameworks
ngraham added a comment to D16677: Add BrightScript syntax.

That comment was meant for other KDE developers. :) There's nothing you need to do on that front... however, since you submitted the patch using the web interface rather than using arc, your authorship information was not included with the patch and we'll need your full name and preferred email address before we can land the patch. Can you provide that?

Sat, Nov 10, 3:30 PM · Frameworks, Kate
ngraham requested changes to D8912: Added a set of Game Folder icons.

Phabricator unfortunately doesn't offer SVG previews, so posting new screenshots every time you update the diff is appreciated. :)

Sat, Nov 10, 3:16 PM · Frameworks
ngraham committed R134:c693800980af: Use correct name on Sources page itself CCBUG: 389717 (authored by ngraham).
Use correct name on Sources page itself CCBUG: 389717
Sat, Nov 10, 3:46 AM

Fri, Nov 9

ngraham added a comment to T9420: [KOrganizer] Improve event display.

BTW, here is the official Breeze color palette: https://hig.kde.org/style/color/default.html

Fri, Nov 9, 11:50 PM · KDE PIM: Junior Jobs, KDE PIM
ngraham closed D16772: Add new icons for root.
Fri, Nov 9, 10:26 PM · Frameworks
ngraham committed R266:e2270613fc25: Add new icons for root (authored by ndavis).
Add new icons for root
Fri, Nov 9, 10:26 PM
ngraham added a comment to D16772: Add new icons for root.

Other VDG folks in chat seem happy as well. Landing it!

Fri, Nov 9, 10:24 PM · Frameworks
ngraham committed R112:f1637beef1b9: [Plasmoid] Clean up layout (authored by ngraham).
[Plasmoid] Clean up layout
Fri, Nov 9, 10:12 PM
ngraham closed D16622: [Plasmoid] Clean up layout.
Fri, Nov 9, 10:12 PM · Plasma
ngraham added a comment to D16772: Add new icons for root.

Usually the time is right when someone recommends that you do so! :-)

Fri, Nov 9, 10:02 PM · Frameworks
ngraham added a comment to D16622: [Plasmoid] Clean up layout.

Thanks David!

Fri, Nov 9, 9:52 PM · Plasma
ngraham added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

I'm separating out all the potentially controversial changes into a separate patch (and will probably revert the font size changes; you guys are right about that). I might not have time until later tonight or sometime tomorrow evening since I'm single-parenting for a few days and my kids are both sick at the moment. Stay tuned.

Fri, Nov 9, 9:52 PM · Plasma