Feed Advanced Search

Today

ngraham accepted D25015: Update breeze theme shadows.

Looks like you fixed the rounded corner issues, nice. This does look much better IMO. +1 from me.

Sat, Jan 18, 8:23 PM · Frameworks
ngraham added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

You can't shrink the size of it to fit within the blue border?

Sat, Jan 18, 5:43 AM · Plasma
ngraham added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

Yeah. I don't disagree. But if I just ensure that the highlight effect is the highest item, the borders still get obscured by the player controls and album art. And the rounded corners of the highlight leave a pixel or two of the art to escape the bounds too.

Sat, Jan 18, 4:40 AM · Plasma
ngraham added a reviewer for D26744: Support opening new sessions in current working dir: Yakuake.
Sat, Jan 18, 2:43 AM

Yesterday

ngraham added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

I'm not 100% sold on drawing the highlight on top and tinting everything, and can revert that part if everyone else hates it.

Fri, Jan 17, 9:07 PM · Plasma
ngraham requested review of D26739: [applets/Task Manager] Refine tooltip highlight effect.
Fri, Jan 17, 9:06 PM · Plasma
ngraham added a comment to D26733: sync tooltip delay with systemsettings.

Yeah, it might be nice to extract this into a framework that can bee used by all three apps so it can't diverge this way again.

Fri, Jan 17, 6:18 PM · Plasma
ngraham abandoned D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI.

Abandoning in favor of those patches. Thanks @meven!

Fri, Jan 17, 4:49 PM · Plasma
ngraham added a comment to D26690: Make "Default Applications" in mimeapps.list the preferred applications.

Does this fix https://bugs.kde.org/show_bug.cgi?id=403499?

Fri, Jan 17, 4:24 PM · Frameworks
ngraham updated the summary of D26731: KCM/Component Revamp Browser config.
Fri, Jan 17, 4:24 PM · Plasma
ngraham accepted D26731: KCM/Component Revamp Browser config.

Works for me FWIW.

Fri, Jan 17, 4:23 PM · Plasma
ngraham added a comment to D26731: KCM/Component Revamp Browser config.

The "Dans une application fondée sue le contenu d l'URL" setting is actually something I proposed removing in D17372, and it got approval in theory, but it seems like this is quite a far-reaching change that requires many considerations.

Fri, Jan 17, 4:21 PM · Plasma
ngraham added inline comments to D26640: [applets/weather] Port weather station picker to QQC2+ListView.
Fri, Jan 17, 3:56 PM · Plasma
ngraham updated the diff for D26640: [applets/weather] Port weather station picker to QQC2+ListView.

Address review comments

Fri, Jan 17, 3:56 PM · Plasma
ngraham updated subscribers of D25743: Expose IndexerState enum to QML.

@broulik discovered that this needs qRegisterMetaType<Baloo::IndexerState>(); added

Fri, Jan 17, 3:25 PM · Baloo, Frameworks
ngraham added a comment to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Re-added the namespace but the state checking still doesn't seem to work properly.

Fri, Jan 17, 3:24 PM · Baloo, Plasma
ngraham updated the diff for D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Re-add namespace

Fri, Jan 17, 3:24 PM · Baloo, Plasma
ngraham accepted D26531: [Wallpaper] Show author as subtitle in configuration.
Fri, Jan 17, 3:16 PM · Plasma
ngraham committed R296:083b21c4073f: Correctly compute bottom margin for grid delegates with subtitles (authored by ngraham).
Correctly compute bottom margin for grid delegates with subtitles
Fri, Jan 17, 3:16 PM
ngraham closed D26634: Correctly compute bottom margin for grid delegates with subtitles.
Fri, Jan 17, 3:15 PM · Frameworks
ngraham committed R134:52f93cb4035d: Merge branch 'Plasma/5.18' (authored by ngraham).
Merge branch 'Plasma/5.18'
Fri, Jan 17, 3:13 PM
ngraham committed R134:b49b97b2fe2c: Merge branch 'Plasma/5.18' (authored by ngraham).
Merge branch 'Plasma/5.18'
Fri, Jan 17, 3:08 PM
ngraham added a comment to D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size.

The goal is to have a sane default size.

Fri, Jan 17, 3:00 PM · Plasma
ngraham updated the summary of D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.
Fri, Jan 17, 2:51 PM · Baloo, Plasma
ngraham updated the diff for D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Adjust to changes in D25743

Fri, Jan 17, 2:51 PM · Baloo, Plasma
ngraham added a comment to D25743: Expose IndexerState enum to QML.

Baloo::Suspended doesn't seem to be exported properly or set. Also it seems like toggleSuspendState() only ever suspends and never resumes. Looking at the code in monitor.cpp, it seems like these may be related.

Fri, Jan 17, 2:50 PM · Baloo, Frameworks
ngraham updated the diff for D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Rebase

Fri, Jan 17, 2:34 PM · Baloo, Plasma
ngraham added a comment to D8208: Add Duplicate feature.

Friendly Dolphin ping. :)

Fri, Jan 17, 2:33 PM · Dolphin
ngraham added a comment to D26640: [applets/weather] Port weather station picker to QQC2+ListView.

Ping

Fri, Jan 17, 2:20 PM · Plasma
ngraham added a comment to D26634: Correctly compute bottom margin for grid delegates with subtitles.

Ping

Fri, Jan 17, 2:20 PM · Frameworks
ngraham added a comment to D25820: SimpleScreenRecorder icon added.

@vinzenzv are you interested in finishing this, or should someone else take it over?

Fri, Jan 17, 2:01 PM · Frameworks, Breeze
ngraham added a comment to D25815: Transmission-Qt tray icon added.

@vinzenzv are you interested in finishing this, or should someone else take it over?

Fri, Jan 17, 2:01 PM · Frameworks, Breeze
ngraham added a comment to T12221: Webpage advertising hardware with plasma.

The "advanced users" bit is targeting at openSUSE, not at Gnome, Xfce or Plasma. We chose Ubuntu as basis for various reasons and went with Budgie as some simple, classic DE especially for newbies. This decision dates from early 2017 and is something we currently re-evaluate. Some details still need to be clarified but everything points towards Plasma as our default DE on all devices (ultrabooks, gaming laptops, mini & regular PCs).

Fri, Jan 17, 2:00 PM · KDE Promo
ngraham accepted D26727: Fix font bug in ProgressBox.

LGTM but please wait for confirmation from @sandsmark

Fri, Jan 17, 1:45 PM
ngraham updated subscribers of D26717: [App Style KCM] Use QtQuick NewStuff dialogs.
Fri, Jan 17, 1:43 PM · Plasma
ngraham added a comment to D26727: Fix font bug in ProgressBox.

Please always add screenshots for patches that result in UI changes.

Fri, Jan 17, 1:31 PM
ngraham accepted D26714: KCM/Component Revamp FileManager UI.
Fri, Jan 17, 1:29 PM · Plasma
ngraham accepted D26717: [App Style KCM] Use QtQuick NewStuff dialogs.

Looks good, and this should go on the plasma/5.18 branch to make sure it gets into Plasma 5.18 so this KCM isn't the odd one out.

Fri, Jan 17, 1:27 PM · Plasma
ngraham added a comment to D26720: Cache single image wallpapers locally.

Good point, I totally forgot to consider that. I have no idea how it works and will need to look into it.

Fri, Jan 17, 1:17 PM · Plasma
ngraham accepted D26726: [Breeze Cursors] Add some more cursor names.

I suppose it doesn't hurt anything to add these even though they're still "up for discussion."

Fri, Jan 17, 1:14 PM · Plasma
ngraham added a comment to D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results.

When set to false, it makes the label look less lighter without manually setting the opacity to some value that we'll often forget to be consistent on which would (and does) result in labels of opacity values varying between 0.3 and 0.6.

Fri, Jan 17, 1:10 PM · Plasma
ngraham abandoned D18006: Include only the largest size for the "Next" wallpaper.

All right, no problem!

Fri, Jan 17, 1:04 PM · Plasma
ngraham added a comment to D26714: KCM/Component Revamp FileManager UI.

Selecting the "Other..." option for this one takes me to the filetype editor for inode/directory instead of the app chooser as in the other patches. Is that intentional?

Fri, Jan 17, 4:03 AM · Plasma
ngraham committed R119:ce5094c02a87: [Widget Explorer] Show placeholder message when there are no widgets or search… (authored by ngraham).
[Widget Explorer] Show placeholder message when there are no widgets or search…
Fri, Jan 17, 3:20 AM
ngraham closed D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results.
Fri, Jan 17, 3:20 AM · Plasma
ngraham added a comment to D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results.

Yep.

Fri, Jan 17, 3:19 AM · Plasma
ngraham added a comment to D18006: Include only the largest size for the "Next" wallpaper.

The whole point was to save some space on the user's machine. However trading space savings for load time maybe isn't the best trade-off? 18 MB isn't really all that much of a savings.

Fri, Jan 17, 3:18 AM · Plasma
ngraham added a comment to D24706: [RFC] Change button style.

Thanks Noah.

Fri, Jan 17, 12:26 AM · Breeze, VDG, Plasma
ngraham added a task to D26440: Add KSharedConfig::openStateConfig for storing state information: T12549: Remove cache data from config files.
Fri, Jan 17, 12:19 AM · Frameworks
ngraham added a revision to T12549: Remove cache data from config files: D26440: Add KSharedConfig::openStateConfig for storing state information.
Fri, Jan 17, 12:19 AM · KF6

Thu, Jan 16

ngraham updated the test plan for D26720: Cache single image wallpapers locally.
Thu, Jan 16, 11:31 PM · Plasma
ngraham added a dependency for D18006: Include only the largest size for the "Next" wallpaper: D26720: Cache single image wallpapers locally.
Thu, Jan 16, 11:29 PM · Plasma
ngraham added a dependent revision for D26720: Cache single image wallpapers locally: D18006: Include only the largest size for the "Next" wallpaper.
Thu, Jan 16, 11:29 PM · Plasma
ngraham added a task to D26720: Cache single image wallpapers locally: T10269: Improve wallpapers.
Thu, Jan 16, 11:28 PM · Plasma
ngraham added a revision to T10269: Improve wallpapers: D26720: Cache single image wallpapers locally.
Thu, Jan 16, 11:28 PM · VDG, Plasma
ngraham added a dependent revision for D26720: Cache single image wallpapers locally: D18078: [plasma-workspace-wallpapers] Improve wallpaper selection.
Thu, Jan 16, 11:28 PM · Plasma
ngraham added a dependency for D18078: [plasma-workspace-wallpapers] Improve wallpaper selection: D26720: Cache single image wallpapers locally.
Thu, Jan 16, 11:28 PM · Plasma
ngraham added a comment to D26720: Cache single image wallpapers locally.

Note that I found the code here very complicated so it's possible I may have done this in a sub-optimal way.

Thu, Jan 16, 11:28 PM · Plasma
ngraham requested review of D26720: Cache single image wallpapers locally.
Thu, Jan 16, 11:27 PM · Plasma
ngraham added a comment to D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView.

IIRC we used to do this, but changed it to run-on-demand to save some memory on startup.

Thu, Jan 16, 8:55 PM · Plasma
ngraham added a comment to D26717: [App Style KCM] Use QtQuick NewStuff dialogs.

No I see it as a consistency/polish/bugfix thing. The rest of the KCMs got ported to use the new dialog for Plasma 5.18; it would be a bit weird if this one didn't get the same treatment.

Thu, Jan 16, 8:54 PM · Plasma
ngraham added a comment to D26717: [App Style KCM] Use QtQuick NewStuff dialogs.

Even better would be if we can use the new QML dialogs too. See D26544

Thu, Jan 16, 8:47 PM · Plasma
ngraham retitled D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results from [Widget Explorer] Show placeholder message when there are no widgets or searc results to [Widget Explorer] Show placeholder message when there are no widgets or search results.
Thu, Jan 16, 8:11 PM · Plasma
ngraham requested review of D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results.
Thu, Jan 16, 8:05 PM · Plasma
ngraham committed R320:b18be2ed1a80: Improved quality of JPEG thumbnails (authored by chroniceel).
Improved quality of JPEG thumbnails
Thu, Jan 16, 5:17 PM
ngraham closed D26648: Improved quality of JPEG thumbnails.
Thu, Jan 16, 5:17 PM · Frameworks, Dolphin
ngraham added a comment to D26648: Improved quality of JPEG thumbnails.

Very nice first patch. May it be the first of many! :)

Thu, Jan 16, 5:17 PM · Frameworks, Dolphin
ngraham added a comment to D26648: Improved quality of JPEG thumbnails.

no in a comment is fine

Thu, Jan 16, 5:16 PM · Frameworks, Dolphin
ngraham added a reviewer for D26711: Add kde.org/hardware webpage: VDG.

+ ten million, this is a fantastic idea. By showing this, we close the loop for regular users who want to know how to get our software, and we also highlight partners and incentivize future hardware vendors to ship our stuff because of the free publicity they'll get.

Thu, Jan 16, 5:15 PM
ngraham accepted D26648: Improved quality of JPEG thumbnails.

@chroniceel Can you provid an email address so we can land this patch with correct authorship information?

Thu, Jan 16, 5:13 PM · Frameworks, Dolphin
ngraham accepted D26565: KCM/Component Revamp email config.

I'm so sorry, this was my mistake. Somehow KMail got re-installed without my knowledge. Probably https://bugzilla.suse.com/show_bug.cgi?id=1035802 biting me again.

Thu, Jan 16, 5:10 PM · Plasma
ngraham accepted D26686: Remove scrollbar related workarounds from list delegates.
Thu, Jan 16, 4:37 PM · Plasma
ngraham added a comment to D26565: KCM/Component Revamp email config.

Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I don't think that makes sense.

Thu, Jan 16, 4:10 PM · Plasma
ngraham accepted D26705: KCM/Component Revamp Terminal Emulator UI.
Thu, Jan 16, 4:05 PM · Plasma
ngraham edited projects for T12551: Revamp KCM/Component chooser, added: Plasma: KCM Redesign; removed Plasma.
Thu, Jan 16, 3:57 PM · Plasma: KCM Redesign, VDG
ngraham moved T12551: Revamp KCM/Component chooser from To Do to Work in Progress on the Plasma board.
Thu, Jan 16, 3:56 PM · Plasma: KCM Redesign, VDG
ngraham moved T12551: Revamp KCM/Component chooser from Backlog/Planned to Sent to dev on the VDG board.
Thu, Jan 16, 3:56 PM · Plasma: KCM Redesign, VDG
ngraham added projects to T12551: Revamp KCM/Component chooser: Plasma, VDG.
Thu, Jan 16, 3:56 PM · Plasma: KCM Redesign, VDG
ngraham updated the task description for T12551: Revamp KCM/Component chooser.
Thu, Jan 16, 3:56 PM · Plasma: KCM Redesign, VDG
ngraham added a comment to D26688: WIP: [Night Color] Display time when the next transition will start.

Here's my suggestions for what to display in the applet for various conditions:

Thu, Jan 16, 3:54 PM · Plasma
ngraham added a comment to D24706: [RFC] Change button style.

Would you mind rebasing this? It seems like we're moving forward with the idea of iterating on Breeze rather than making a whole new theme, and since Plasma 5.18 just branched, we have some space to hack on master now. I'd like to see if we can move forward with this.

Thu, Jan 16, 3:51 PM · Breeze, VDG, Plasma
ngraham added a comment to D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse.

Hmm, I'm not totally sure I agree. If the text becomes focusable by tabbing, then I think that just clutters up the focus chain with non-interactive UI elements that nobody is actually going to care about doing something with 99% of the time.

Thu, Jan 16, 1:41 AM · Frameworks
ngraham committed R120:047bd22c5cb3: [KCMs/Feedback] Polish presentation - Don't make the text less opaque - Don't… (authored by ngraham).
[KCMs/Feedback] Polish presentation - Don't make the text less opaque - Don't…
Thu, Jan 16, 1:36 AM

Wed, Jan 15

ngraham accepted D26698: [widgetexplorer] Fix animate in animation.

Oh never mind, I see it now. Quite subtle! Nice fix.

Wed, Jan 15, 9:04 PM · Plasma
ngraham accepted D26699: [widgetexplorer] Animate column moves.

Much nicer.

Wed, Jan 15, 8:59 PM · Plasma
ngraham added a comment to D26698: [widgetexplorer] Fix animate in animation.

Hmm, I don't notice a difference before and after this patch. Maybe I'm not noticing the original problem

Wed, Jan 15, 8:58 PM · Plasma
ngraham added a comment to D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size.

I don't know of any netbooks shorter with screens shorter than 600px, which is why I chose 600. Also, the window is resizable to be smaller.

Wed, Jan 15, 8:56 PM · Plasma
ngraham requested review of D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size.
Wed, Jan 15, 7:46 PM · Plasma
ngraham added a comment to D26570: Improve Plasma user feedback introspection.

Very nice. It occurs to me that by showing the full list of what gets sent, we no longer need to show the details text. It's rendered obsolete by showing the actual list of what gets sent. Can we remove the description from the KCM here without touching KUSerFeedback again?

Wed, Jan 15, 5:58 PM · Plasma
ngraham added inline comments to D26688: WIP: [Night Color] Display time when the next transition will start.
Wed, Jan 15, 5:04 PM · Plasma
ngraham accepted D26525: Fix wallpaper destination path.

Yep, go ahead.

Wed, Jan 15, 5:02 PM · Plasma
ngraham accepted D26671: Cleanup and add 22px media repeat icons.

LGTM. @ndavis?

Wed, Jan 15, 5:01 PM · Frameworks
ngraham added a comment to D26686: Remove scrollbar related workarounds from list delegates.

Will we still need the LayoutMirroring.enabled ? logic to account for when using an RTL language where the scrollbar is on the left side?

Wed, Jan 15, 4:59 PM · Plasma
ngraham added a comment to D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line.

Strings can't be changed during the beta.

Wed, Jan 15, 4:26 PM · Plasma
ngraham added a comment to T10611: Set options for GTK apps in the respective KCMs.

Ah I didn't even notice, perfect.

Wed, Jan 15, 3:50 PM · Plasma: KCM Redesign
ngraham updated the task description for T10611: Set options for GTK apps in the respective KCMs.
Wed, Jan 15, 3:49 PM · Plasma: KCM Redesign
ngraham added a comment to D26586: [SystemTray] Rework system tray settings.

Push it! Push it real good! :)

Wed, Jan 15, 3:42 PM · Plasma
ngraham updated the task description for T10611: Set options for GTK apps in the respective KCMs.
Wed, Jan 15, 3:39 PM · Plasma: KCM Redesign
ngraham closed T10611: Set options for GTK apps in the respective KCMs, a subtask of T11939: Plasma 5.18, as Resolved.
Wed, Jan 15, 3:39 PM · Plasma
ngraham closed T10611: Set options for GTK apps in the respective KCMs as Resolved.

I think we can call this done. There are a few enhancements such as syncing the window decoration button orders (https://bugs.kde.org/show_bug.cgi?id=414113) and presence or absence of the circle behind the close button but I think we can do those later since they weren't already implemented. The original scope is definitely done now.

Wed, Jan 15, 3:39 PM · Plasma: KCM Redesign