Feed Advanced Search

Today

ngraham committed R134:ad5044034e32: Merge branch 'Plasma/5.15' (authored by ngraham).
Merge branch 'Plasma/5.15'
Fri, Feb 22, 1:53 AM
ngraham committed R134:d2d33a20b0e0: [Updates page] Try our best to not elide version strings (authored by ngraham).
[Updates page] Try our best to not elide version strings
Fri, Feb 22, 1:51 AM
ngraham closed D19210: [Updates page] Try our best to not elide version strings.
Fri, Feb 22, 1:51 AM · Plasma
ngraham added a comment to D12162: Add support for touch scrolling in Dolphin.

Thank you so much! Don't let me rush you and make your studies suffer, though. :)

Fri, Feb 22, 1:49 AM · Dolphin
ngraham added a comment to D19011: Thunderbolt KCM and KDED module.

Thanks, much better! Just a few more UI nitpicks. And one more thing: What does "Stored" mean in this context? As a non-Thunderbolt expert, I don't know what this means, and I suspect most users wouln't, either.

Fri, Feb 22, 1:46 AM · Plasma
ngraham added a comment to D19214: [sddm-theme] Replace login button label with icon.

Issues unresolved so far:
(1) Should this be done at all?

I think so!

Fri, Feb 22, 1:43 AM · Plasma
ngraham added a comment to D19214: [sddm-theme] Replace login button label with icon.

+1 for this design as well. It's much better-looking overall.

Fri, Feb 22, 1:40 AM · Plasma

Yesterday

Restricted Application added a project to D11382: Add an option to show tabs from last time when Dolphin starts: Dolphin.

@rominf, are you planning to come back and work on this at all?

Thu, Feb 21, 11:10 PM · Dolphin
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

"Activation Key" ?

Thu, Feb 21, 11:08 PM · Spectacle
ngraham added a comment to D19077: Redesign the theme preview window.

This introduces a new warning:

Thu, Feb 21, 11:05 PM · Plasma
ngraham committed R166:d1e84278a6f7: Correct "Rectangular Region" header string punctuation (authored by ngraham).
Correct "Rectangular Region" header string punctuation
Thu, Feb 21, 10:48 PM
ngraham updated the summary of D19210: [Updates page] Try our best to not elide version strings.
Thu, Feb 21, 10:33 PM · Plasma
ngraham requested review of D19210: [Updates page] Try our best to not elide version strings.
Thu, Feb 21, 10:32 PM · Plasma
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Looks great now! One final thing: can you see about reading the configuration to find the keyboard shortcut rather than always assuming it's PrintScreen?

Thu, Feb 21, 10:32 PM · Spectacle
ngraham requested changes to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Uh-oh, something went wrong with the layout in this latest version:

Thu, Feb 21, 10:02 PM · Spectacle
ngraham added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

If someone steal events it's not problem of the patch, similar patch as D15612 should be applied for that view.

Thu, Feb 21, 9:58 PM · Gwenview
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Great! Now what happens if a user sets the focus option on X11, logs into a Wayland session, and tries to use it? :)

Thu, Feb 21, 9:45 PM · Spectacle
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Excellent. Can you make the focus option not appear on Wayland? Then I think we'll be good to go.

Thu, Feb 21, 9:24 PM · Spectacle
ngraham updated the diff for D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend".

Correct awkward string

Thu, Feb 21, 9:09 PM · Documentation, Plasma
ngraham added a comment to D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend".

-0.2 from my side, the thing is called suspend not sleep, if you look for "linux sleep" in a search engine you get references to the sleep (3) and sleep (1) man pages, which would only confuse the users.

Thu, Feb 21, 9:03 PM · Documentation, Plasma
ngraham requested changes to D18744: Add action in Edit menu to select the text on current page.

All right, let's do this. In final testing, I just found some blockers:

Thu, Feb 21, 8:43 PM · Documentation, Okular
ngraham added a comment to D19209: [sddm-kcm] Adjust Background label and button.

Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper

Thu, Feb 21, 8:35 PM · Plasma
ngraham committed R134:09d70dc0d9c0: Improve/correct string formatting from the prior commit (authored by ngraham).
Improve/correct string formatting from the prior commit
Thu, Feb 21, 8:22 PM
ngraham committed R241:c063b1ce8489: Add support for portals in KRun (authored by GeeXT).
Add support for portals in KRun
Thu, Feb 21, 8:16 PM
ngraham closed D18762: Add support for portals in KRun.
Thu, Feb 21, 8:16 PM · Frameworks
ngraham added a comment to D18762: Add support for portals in KRun.

No problem, I'll take care of this for you!

Thu, Feb 21, 8:14 PM · Frameworks
ngraham accepted D19201: New tab placed after current tab when middle-clicking.

Thanks, much better. Putting the DolphinTabPlacement class in dolphintabwidget makes sense to me, but make sure @elvisangelaccio agrees. :)

Thu, Feb 21, 8:10 PM · Dolphin
ngraham committed R134:5d254de6fa4f: [Updates page] Improve selected/unselected explanation view (authored by ngraham).
[Updates page] Improve selected/unselected explanation view
Thu, Feb 21, 8:04 PM
ngraham closed D19192: [Updates page] Improve selected/unselected explanation view.
Thu, Feb 21, 8:04 PM · Plasma
ngraham requested changes to D19201: New tab placed after current tab when middle-clicking.

Thanks for sending a follow-up patch so quickly!

Thu, Feb 21, 7:38 PM · Dolphin
ngraham accepted D13901: Touch support for Gwenview.

Thanks @steffenh. I went back and re-tested everything and it all works *flawlessly* for me. Very impressive work. I really hope we can get it in for KDE Applications 19.04. I'll start on the code review:

Thu, Feb 21, 7:35 PM · Gwenview
ngraham added a comment to T8177: Run plasmashell with "PLASMA_USE_QT_SCALING=1" : Wait until 18.10; re-test.
In T8177#176789, @dos wrote:

Small glitch I noticed: when using PLASMA_USE_QT_SCALING=1 on X11 and minimizing window with a KWin effect, Plasma reports unscaled iconGeometry (in logical coordinates instead of real pixels, like 200x850 instead of 400x1700 on 2x screen), resulting in wrong animations. This doesn't happen on Wayland.

Other than that, I've been using it for months now and seems to work fine.

Thu, Feb 21, 6:47 PM · Kubuntu
ngraham added a comment to D19183: Use logically correct icon for direction arrows.

Personally i don't like it given than it is a very horizontal layout.

To me, the mental image here is page turning.

Thu, Feb 21, 6:42 PM · Okular
ngraham accepted D18939: KMenuEdit: add search/filter bar.

LGTM. @cfeck, are you happy now?

Thu, Feb 21, 5:46 PM · Plasma
ngraham committed R119:eaccf58e886b: Merge branch 'Plasma/5.15' (authored by ngraham).
Merge branch 'Plasma/5.15'
Thu, Feb 21, 4:46 PM
ngraham committed R119:7a33e1130612: [Kickoff] Don't respond to window resizing/tiling shortcuts (authored by ngraham).
[Kickoff] Don't respond to window resizing/tiling shortcuts
Thu, Feb 21, 4:46 PM
ngraham closed D19023: [Kickoff] Don't respond to window resizing/tiling shortcuts.
Thu, Feb 21, 4:46 PM · Plasma
ngraham committed R119:f8f5cd05427b: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by ngraham).
Merge remote-tracking branch 'origin/Plasma/5.15'
Thu, Feb 21, 4:43 PM
ngraham committed R119:1312ab1cb4fe: [Kickoff] remove hint state (authored by matthieugras).
[Kickoff] remove hint state
Thu, Feb 21, 4:40 PM
ngraham closed D19154: [Kickoff] remove hint state.
Thu, Feb 21, 4:40 PM · Plasma
ngraham added a comment to D19096: Improvements for long label items in Application Dashboard.

Works great on my 1920x1080 screen BTW.

Thu, Feb 21, 4:38 PM · Plasma
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

My general rule is that you should only ever use it if you have no other feasible option and in response to an explicit user action.

You meet both those criteria, but it would definitely be worth looking at moving this to be activated via kglobalaccel directly.

Thu, Feb 21, 4:37 PM · Spectacle
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Ok, so let's do this for now @davidre:

Thu, Feb 21, 4:06 PM · Spectacle
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

On Wayland we should just forget about the feature? That seems... less that ideal. What's the plan to fix this?

Thu, Feb 21, 3:02 PM · Spectacle
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.
In D19153#416515, @zzag wrote:

I urge you not to deal with focus. On X11, applications usually abuse such power, so it led to things like fsp. For what it's worth, clients can't activate by themselves on Wayland \o/.

Thu, Feb 21, 2:29 PM · Spectacle
ngraham accepted D19197: [File Tree] Add "Open Containing Folder" menu entry.

I always miss these when they're not there. :) +1

Thu, Feb 21, 2:27 PM · Kate
ngraham added reviewers for D19194: Adjust date string height to match time string with vertical panel: Plasma, davidedmundson, Zren.

Thank you for the patch! You did great, and on the first try, too!

Thu, Feb 21, 2:14 PM · Plasma

Wed, Feb 20

ngraham requested changes to D19077: Redesign the theme preview window.

With the default System Settings window size (and default font & size), the URLs now get cut off at the bottom nearly all the time. Also, having all the metadata in a stacked list of strings isn't as nice as I think it could be. We could save a lot of space by combining things, like this:

Wed, Feb 20, 10:11 PM · Plasma
ngraham added inline comments to D18915: Fix batchrename changing extension to lower case.
Wed, Feb 20, 9:45 PM · Frameworks
ngraham added inline comments to D19077: Redesign the theme preview window.
Wed, Feb 20, 9:44 PM · Plasma
ngraham requested changes to D19077: Redesign the theme preview window.

Neato, getting there...

Wed, Feb 20, 9:38 PM · Plasma
ngraham added a comment to D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend".

Even if we do change it, krunner should still match for search queries "suspend" and "sleep"

Wed, Feb 20, 9:25 PM · Plasma
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Yeah, I think Take a new screenshot makes sense as the default option.

Wed, Feb 20, 8:26 PM · Spectacle
ngraham requested review of D19192: [Updates page] Improve selected/unselected explanation view.
Wed, Feb 20, 8:05 PM · Plasma
ngraham added a comment to D19077: Redesign the theme preview window.

Hmm, you might have to keep the hardcoded height, given that the QWidgets container expects the QML view to have a certain size.

Wed, Feb 20, 8:00 PM · Plasma
ngraham accepted D19183: Use logically correct icon for direction arrows.

Makes sense to me. Seems to make more sense when using an RTL layout too. Okular folks, are you good with this?

Wed, Feb 20, 7:02 PM · Okular
ngraham updated the test plan for D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Wed, Feb 20, 5:37 PM · Dolphin
ngraham added inline comments to D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Wed, Feb 20, 5:36 PM · Dolphin
ngraham updated the summary of D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Wed, Feb 20, 5:31 PM · Dolphin
ngraham updated the diff for D19190: Improve scroll wheel speed by basing it on label height, not icon height.

Use font metrics

Wed, Feb 20, 5:29 PM · Dolphin
ngraham requested review of D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Wed, Feb 20, 5:11 PM · Dolphin
ngraham added inline comments to D19014: [plasma-pa] Add command to switch all applications to the selected device.
Wed, Feb 20, 5:04 PM · Plasma
ngraham added a comment to D18716: Add an ActionTextField component.

Then again there's an argument to be made for consistency. I would be okay with using clickable icons instead of toolbuttons as long as we make sure to use a pointing hand cursor when hovered.

Wed, Feb 20, 4:52 PM · Kirigami
ngraham added a comment to D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

However in our case we would call this only if configured by the user to do so and explicitly requested by the user by pressing the Print key. Also if spectacle isn't running and the Print key is pressed , currently Spectacle will open and steal the focus even if I'm typing in another application for example Konsole. Considering these two points I think it's reasonable to argue that this behavior would be acceptable.

Wed, Feb 20, 4:49 PM · Spectacle
ngraham committed R260:fe0dbadaecc5: Compile tests files with enabled exceptions, required for exiv2 0.27 (authored by tgurr).
Compile tests files with enabled exceptions, required for exiv2 0.27
Wed, Feb 20, 4:22 PM
ngraham closed D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.
Wed, Feb 20, 4:22 PM · Gwenview
ngraham added a comment to D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.

Oh no, you didn't do anything wrong at all. It's a Phabricator bug that your authorship information gets discarded when if you use git format-patch (Phab wants everyone to use arc; see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist).

Wed, Feb 20, 4:20 PM · Gwenview
ngraham added a comment to D18716: Add an ActionTextField component.

Even though we use clickable icons rather than toolbuttons in the QWidgets version, I think we should use ToolButtons if the visual style isn't too bad. People complained about the lack of pressed and hover states when the SwipeListItem used clickable icons instead of toolbuttons.

Wed, Feb 20, 4:15 PM · Kirigami
ngraham added a comment to T10402: The Desktop Toolbox.

Not being a user of Activities myself, I have a hard time commenting on whether it's really necessary or not, but I suspect it is just a nice-to-have since the Desktop Toolbox only fulfills this function when it's been deliberately dragged out of the corner.

Wed, Feb 20, 4:09 PM · Plasma, VDG
ngraham updated the diff for D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend".

Add context

Wed, Feb 20, 4:05 PM · Documentation, Plasma
ngraham accepted D18986: [breeze-icons] Add video camera icons.

Now that's what I'm talkin' about!!! I love these!

Wed, Feb 20, 4:03 PM · Frameworks
ngraham updated the diff for D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend".

Add context

Wed, Feb 20, 4:03 PM · Plasma
ngraham updated the diff for D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend".

Add context

Wed, Feb 20, 3:54 PM · Plasma
ngraham moved T10500: Use the word "Sleep" instead of "Suspend" from To Do to Needs Review on the Plasma board.
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham moved T10500: Use the word "Sleep" instead of "Suspend" from Backlog/Planned to Sent to dev on the VDG board.
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham added a revision to T10500: Use the word "Sleep" instead of "Suspend": D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham requested review of D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Documentation, Plasma
ngraham added a revision to T10500: Use the word "Sleep" instead of "Suspend": D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham requested review of D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma
ngraham added a revision to T10500: Use the word "Sleep" instead of "Suspend": D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma, VDG
ngraham requested review of D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 2:42 PM · Plasma
ngraham updated the task description for T10500: Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 6:09 AM · Plasma, VDG
ngraham updated the summary of D19023: [Kickoff] Don't respond to window resizing/tiling shortcuts.
Wed, Feb 20, 6:00 AM · Plasma
ngraham updated the task description for T10500: Use the word "Sleep" instead of "Suspend".
Wed, Feb 20, 4:32 AM · Plasma, VDG
ngraham accepted D19169: Compile tests files with enabled exceptions, required for exiv2 0.27.

Thanks. Can you please provide your real name and email address so I can land your patch with correct authorship information?

Wed, Feb 20, 3:56 AM · Gwenview
ngraham added a comment to T10402: The Desktop Toolbox.

Currently the only place that we use long press (to my knowledge) is to enter the Widget's own private edit mode. I'm not real thrilled about that TBH, but I could accept it as a secondary, touch-centric UI once we have a better desktop-specific UI for it (See T10190: (Re)define modes when editing panels and widgets)

Wed, Feb 20, 3:55 AM · Plasma, VDG
ngraham added a comment to D19148: Make shadow sizes linear.

...Looks better on my non-cheap display, too. :)

Wed, Feb 20, 3:16 AM · Plasma
ngraham added a comment to D15742: Add close tab and create new tab on middle click event.

Nice job, @shubham. Wanna do the same thing for Okular next? https://bugs.kde.org/show_bug.cgi?id=361756. Probably doesn't need an option there.

Wed, Feb 20, 3:16 AM · Konsole
ngraham added a comment to D18975: [PotD] Port mostly to QQC2.

Friendly ping!

Wed, Feb 20, 12:20 AM · Plasma
ngraham added a comment to T9041: New "Home" tab for Kickoff.

Thanks for that very valuable information, @anemeth. It's great to hear from someone in the trenches, so to speak. Your reasoning is exactly why I wanted to put the power- and user-related buttons front and center. Sometimes we forget just how confusing it can be for normal users when something commonly-used isn't front-and-center, and how unlabeled icons-only ToolButtons can cause problems even when they use a nearly universal icon.

Wed, Feb 20, 12:19 AM · Plasma, VDG
ngraham accepted D19148: Make shadow sizes linear.

This is much better. I think this is a visual improvement. Please make sure @zzag is good with the code before landing, and also let's maybe wait for a few more VDG opinions. :)

Wed, Feb 20, 12:11 AM · Plasma
ngraham added a comment to D19163: Make it possible to show all spaces in the document.

I have wanted this for so long!

Wed, Feb 20, 12:03 AM · Frameworks, Kate

Tue, Feb 19

ngraham added a comment to T10497: Clean up the default color scheme selection.

I don't personally use a dark theme, so I'll leave this to you guys. :) But I think editing the colors to be more modern and visually appealing makes sense.

Tue, Feb 19, 11:49 PM · VDG
ngraham added a comment to T10495: wallpaper cache.

I don't have a very strong opinion but I kind of like the idea of each one being its own plugin. That way you could see and choose a POTD provider in one step rather than two (1. choose POTD plugin -> 2. then go through list of POTD options)

Tue, Feb 19, 11:45 PM · Plasma
ngraham updated subscribers of D19173: [InlineMessage] Tint icon and text color.

Also as @mart pointed out in D19044, it might make sense to do all the styling in the qqc2 desktop style theme for this control, rather than here in Kirigami itself.

Tue, Feb 19, 11:43 PM · Kirigami
ngraham requested changes to D19173: [InlineMessage] Tint icon and text color.

I'm not in favor of this at all in its current form. Any tinting of the text with the background color under it reduces legibility. I'm as in favor of aesthetically appealing user interfaces as anyone, but not at the expense of usability.

Tue, Feb 19, 11:39 PM · Kirigami
ngraham added a comment to D16648: Open externally called files/directories in new tabs.

@feverfew, are you still around to work on these issues?

Tue, Feb 19, 11:36 PM · Dolphin
ngraham added a comment to T10497: Clean up the default color scheme selection.

Maybe we should just update the Breeze Dark color scheme instead? People who want something dark want something dark, if you know what I mean.

Tue, Feb 19, 6:22 PM · VDG
ngraham accepted D15742: Add close tab and create new tab on middle click event.

@hindenburg?

Tue, Feb 19, 5:58 PM · Konsole
ngraham updated subscribers of D19153: [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running.

Nice! So now the only problem I can still find is that the "Return focus to Spectacle" option doesn't work, just like you said. I don't know enough about how Spectacle interacts with the window manager to help with that, but maybe @zzag or @davidedmundson can offer some insight here?

Tue, Feb 19, 5:52 PM · Spectacle