Feed Advanced Search

Yesterday

ngraham updated the test plan for D14256: Fix sidebar search field with fractional scale factors.
Fri, Jul 20, 11:18 PM · Plasma
ngraham requested review of D14256: Fix sidebar search field with fractional scale factors.
Fri, Jul 20, 11:16 PM · Plasma
ngraham added a comment to D14254: Fix rendering of on-screen help texts for fractional scaling.

Can we get a comment or a TODO in the code that explains the reason for this workaround?

Fri, Jul 20, 9:43 PM
ngraham added a comment to D13937: Update formulas and add option to change grid thickness.

With Phabricator, patches can have parents, and multi-commit dependency chains are fully supported: https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project

Fri, Jul 20, 3:20 PM · Plasma
ngraham added a comment to T9244: Backport fix for https://bugreports.qt.io/browse/QTBUG-66036.

Your choice, and if we do, then fractional-scale-factor-hi-dpi users of Kate and KDevelop on Bionic will be happy!

Fri, Jul 20, 2:30 PM · Kubuntu
ngraham added a comment to T9244: Backport fix for https://bugreports.qt.io/browse/QTBUG-66036.

It is a problem for 5.9 (confirmed), but I thought it best not to unnecessarily mess with the LTS release.

Fri, Jul 20, 2:08 PM · Kubuntu
ngraham added a comment to D14238: Polish Notifier Plasmoid's UI.

@broulik addressed your remaining comments in another commit. Sorry for missing them the first time around; flaky bus wifi didn't show me the email for your comments until after I had already landed the patch, following Aleix's approval.

Fri, Jul 20, 2:01 PM · Plasma
ngraham committed R134:ef66f3d0f894: Polish the code change for the previous commit Missed Kai's last review… (authored by ngraham).
Polish the code change for the previous commit Missed Kai's last review…
Fri, Jul 20, 2:00 PM
ngraham committed R119:9adb94dc5b83: Show a vertical menu for the panel widget options pop-up (authored by ngraham).
Show a vertical menu for the panel widget options pop-up
Fri, Jul 20, 1:55 PM
ngraham closed D14145: Show a vertical menu for the panel widget options pop-up.
Fri, Jul 20, 1:55 PM · Plasma
ngraham committed R134:ee062be1ca0e: Polish Notifier Plasmoid's UI (authored by ngraham).
Polish Notifier Plasmoid's UI
Fri, Jul 20, 1:41 PM
ngraham closed D14238: Polish Notifier Plasmoid's UI.
Fri, Jul 20, 1:41 PM · Plasma
ngraham added a comment to D14238: Polish Notifier Plasmoid's UI.

I'd thought of that idea too, but it requires more substantial changes than just playing around with the UI, so it'll have to be done in another patch.

Fri, Jul 20, 1:18 PM · Plasma
ngraham updated the test plan for D14238: Polish Notifier Plasmoid's UI.
Fri, Jul 20, 1:08 PM · Plasma
ngraham added a comment to D14238: Polish Notifier Plasmoid's UI.

Just a quick question. Why does it have to be so big and waste so much space? It still feels kind of weird.

Thank you Nate, btw. You are doing amazing work everywhere.

Fri, Jul 20, 1:07 PM · Plasma
ngraham updated the diff for D14238: Polish Notifier Plasmoid's UI.

Address review comments

Fri, Jul 20, 1:07 PM · Plasma
ngraham updated the test plan for D14238: Polish Notifier Plasmoid's UI.
Fri, Jul 20, 2:54 AM · Plasma
ngraham requested review of D14238: Polish Notifier Plasmoid's UI.
Fri, Jul 20, 2:53 AM · Plasma

Thu, Jul 19

ngraham updated the summary of D14237: Make Konqi look good in HiDPI.
Thu, Jul 19, 11:32 PM · Frameworks
ngraham updated the test plan for D14237: Make Konqi look good in HiDPI.
Thu, Jul 19, 11:30 PM · Frameworks
ngraham updated the diff for D14237: Make Konqi look good in HiDPI.

Use smooth transformation to slightly improve appearance

Thu, Jul 19, 11:28 PM · Frameworks
ngraham updated the summary of D14237: Make Konqi look good in HiDPI.
Thu, Jul 19, 11:22 PM · Frameworks
ngraham updated the test plan for D14237: Make Konqi look good in HiDPI.
Thu, Jul 19, 11:18 PM · Frameworks
ngraham requested review of D14237: Make Konqi look good in HiDPI.
Thu, Jul 19, 11:17 PM · Frameworks
ngraham created T9244: Backport fix for https://bugreports.qt.io/browse/QTBUG-66036.
Thu, Jul 19, 9:47 PM · Kubuntu
ngraham added a comment to D7700: Show list of tags in PlacesView.

Results of testing:

  • After I create a new tag, it doesn't show up in the Places panel tag list or under the tags:/ ioslave until I restart Dolphin.
  • When I navigate to tags:/ ioslave using the All Tags item in the Places panel and I click on a tag, its icon disappears.
  • When I remove a tag from an item and navigate to that tag entry on the Places panel, the un-tagged item still shows up there until I restart Dolphin.
  • When I add a tag to an item and navigate to that tag entry on the Places panel, the item does not show up there until I restart Dolphin.
Thu, Jul 19, 9:22 PM · Frameworks, Dolphin
ngraham added a comment to D14196: Improve inline documentation for magnifier toggle feature.

Or maybe there's something wrong with us, or maybe git is just obtuse and it takes 10 years of constant use to avoid making silly mistakes with it. :)

Thu, Jul 19, 9:15 PM
ngraham committed R166:2ea102e2ad01: Improve inline documentation for magnifier toggle feature (authored by ngraham).
Improve inline documentation for magnifier toggle feature
Thu, Jul 19, 9:00 PM
ngraham committed R166:e42511c1e2b5: Improve inline documentation for magnifier toggle feature (authored by ngraham).
Improve inline documentation for magnifier toggle feature
Thu, Jul 19, 8:58 PM
ngraham closed D14196: Improve inline documentation for magnifier toggle feature.
Thu, Jul 19, 8:57 PM
ngraham accepted D14234: [Folder View] Improve file name text rendering.

Looks better with fractional scaling and doesn't regress at all for 1x scaling. Drop shadows are still rendered. Code looks good.

Thu, Jul 19, 8:43 PM · Plasma
ngraham updated the diff for D14196: Improve inline documentation for magnifier toggle feature.

Update the string

Thu, Jul 19, 8:21 PM
ngraham updated the test plan for D14196: Improve inline documentation for magnifier toggle feature.
Thu, Jul 19, 8:20 PM
ngraham requested changes to D14224: Make kcm size hint bigger.

This doesn't seem to have the desired effect. Here's how it looks for me without the patch:

Thu, Jul 19, 8:08 PM · Plasma
ngraham added a comment to D14196: Improve inline documentation for magnifier toggle feature.

"while dragging selection box" is pretty common and well understood in English.

You are dragging "something", and as I tried to point out above, that "something" is not the rectangle, box or whatever you call it. The rectangle stays stationary, and only changes its size. What you are dragging is the physical mouse, the cursor on the screen, and the selection handle under it (along with the edges attached to it, but not all edges and thus not the complete box).

Thu, Jul 19, 7:40 PM
ngraham added a comment to D14196: Improve inline documentation for magnifier toggle feature.

It's probably impossible to specify the exact conditions the magnifier appears in, unless you put tens of lines of code into writing. Therefore we have to find the most accurate compromise.

Since initially drawing the selection and afterwards using the mouse to modify it are the most common scenarios, the text should adapt to those. Also, for keyboard navigation (which I'd assume is a rather minor use case) the meaning of Shift is redefined in the text, so I don't think it would be that confusing.

Thu, Jul 19, 7:29 PM
ngraham added a comment to D14196: Improve inline documentation for magnifier toggle feature.

"Changing" also seems to cover the case of using the new keyboard shortcuts to modify the selection rectangle, even though it won't actually appear while doing so.

Thu, Jul 19, 6:37 PM
ngraham added a comment to D14196: Improve inline documentation for magnifier toggle feature.

To me, "Resizing selection" communicates modifying something that already exists, not creating it anew. Also, it wouldn't be accurate now that we have the keyboard manipulation feature merged, because it's now possible to resize the selection with the keyboard and not see the magnifier.

Thu, Jul 19, 5:38 PM
ngraham added a comment to T9215: Give Nate Graham moderation rights.

Should this be marked as resolved?

Thu, Jul 19, 5:35 PM · KDE Store
ngraham added a comment to T9215: Give Nate Graham moderation rights.

Fantastic, thanks!

Thu, Jul 19, 5:21 PM · KDE Store
ngraham added a comment to T9151: Move default hotcorner to top-left corner.

You don't have to ask the majority to determine a good default. That's the job of a good UX designer, using the skill of empathy.

Thu, Jul 19, 5:21 PM · Kubuntu
ngraham committed R318:2cbf3cb11ea6: Fixes small memory leak in DolphinContextMenu (authored by hallas).
Fixes small memory leak in DolphinContextMenu
Thu, Jul 19, 2:29 PM
ngraham committed R318:80bc133da937: [KItemListSelectionToggle] Adjust painting icon for high dpi scaling (authored by broulik).
[KItemListSelectionToggle] Adjust painting icon for high dpi scaling
Thu, Jul 19, 2:29 PM
ngraham added inline comments to D14145: Show a vertical menu for the panel widget options pop-up.
Thu, Jul 19, 2:19 PM · Plasma
ngraham updated the diff for D14145: Show a vertical menu for the panel widget options pop-up.

Address review comments and adjust side padding

Thu, Jul 19, 2:18 PM · Plasma

Wed, Jul 18

ngraham committed R119:02dadc40efb4: Give file and folder names a bit more room in Folder View (authored by ngraham).
Give file and folder names a bit more room in Folder View
Wed, Jul 18, 11:14 PM
ngraham committed R318:f186124f0e2c: Fixes small memory leak in DolphinContextMenu (authored by hallas).
Fixes small memory leak in DolphinContextMenu
Wed, Jul 18, 10:48 PM
ngraham closed D14178: Fixes small memory leak in DolphinContextMenu.
Wed, Jul 18, 10:48 PM · Dolphin
ngraham committed R119:cab9078eaf21: Fix drop between shared views (authored by hoffmannrobert).
Fix drop between shared views
Wed, Jul 18, 10:46 PM
ngraham closed D13612: Fix drop between shared views.
Wed, Jul 18, 10:42 PM · Plasma
ngraham added a comment to D13612: Fix drop between shared views.

Sorry for the delay!

Wed, Jul 18, 10:42 PM · Plasma
ngraham added a comment to D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app.

Thanks! BTW, It's now technically acceptable for the BUG: keyword to go at the beginning. Sysadmins fixed the bug that was preventing this from working before.

Wed, Jul 18, 10:00 PM · Frameworks
ngraham added a comment to D14199: Simplify the context menu handling functions in FoldersPanel.

Since this code is somewhat counterintuitive, we might want to add a comment explaining it.

Wed, Jul 18, 9:14 PM · Dolphin
ngraham added a comment to D13805: Present error dialog when user tries to create directory named "." or "..".

Thanks for the update!

Wed, Jul 18, 6:27 PM · Dolphin, Frameworks
ngraham added a comment to D13805: Present error dialog when user tries to create directory named "." or "..".

@tmarshall, any update on this?

Wed, Jul 18, 6:21 PM · Dolphin, Frameworks
ngraham added a comment to D14199: Simplify the context menu handling functions in FoldersPanel.

I will land the patches later today. Thanks again for submitting them and making Dolphin even more awesome!

Wed, Jul 18, 4:41 PM · Dolphin
ngraham added a comment to D14199: Simplify the context menu handling functions in FoldersPanel.

For now, one of us can land these very nice patches for you. Since you didn't use arc to upload the patches (see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches), we'll need to add the git authorship information by hand. Can you tell us your real name and preferred email address?

Wed, Jul 18, 4:36 PM · Dolphin
ngraham added a project to T9226: Unifiy folder views: Frameworks.
Wed, Jul 18, 2:55 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham updated the task description for T9226: Unifiy folder views.
Wed, Jul 18, 2:55 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Yeah, the magnifier shows up while dragging the selection rect (or not, depending on whether or not you've holding down ), but it currently doesn't show up when you're using Alt to resize the rect using the keyboard arrow keys.

Wed, Jul 18, 2:17 PM · Documentation
ngraham added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I'm noticing that the magnifier doesn't er show up while you're using the keyboard to resize the selection rect. Might wanna hook that up.

Wed, Jul 18, 2:02 PM · Documentation
ngraham added a comment to D14204: [KEditFileType] Show application icon in preference list.

Retroactive +1 :)

Wed, Jul 18, 1:13 PM · Plasma
ngraham added a comment to D14196: Improve inline documentation for magnifier toggle feature.

Heh, each of our preferred wordings reveals our workflow: I always drag a new selection rectangle, so to me, "dragging" makes sense as a description of how it's used. But as I recall now, you prefer to have Spectacle remember the previous selection, and you resize it from one of the handles, so "resizing" is the word that best describes how you use it. It seems we need to think of a string that adequately describes both use cases...

Wed, Jul 18, 2:45 AM

Tue, Jul 17

ngraham requested verification of R320:8b6c4e393bb0: Use KIO::PreviewJob::defaultPlugins().

Fixed in 75a3723c45e3cfeae6c57b7661e0a8864f42b51c. Code in question is no longer in master, 18.08, or 18.04 branch; 17.12 branch is obsolete.

Tue, Jul 17, 11:12 PM
ngraham added a comment to D14118: Improve "Remove this [widget]" text.

Ping? Is the proposed wording good enough, or should we maybe instead just remove the word "this" and make it use "Remove <widget name>?

Tue, Jul 17, 7:04 PM · Frameworks
ngraham updated the summary of D14196: Improve inline documentation for magnifier toggle feature.
Tue, Jul 17, 6:44 PM
ngraham updated the test plan for D14196: Improve inline documentation for magnifier toggle feature.
Tue, Jul 17, 6:44 PM
ngraham requested review of D14196: Improve inline documentation for magnifier toggle feature.
Tue, Jul 17, 6:43 PM
ngraham accepted D14195: Replace kolourpaint.org with a kde.org address.
Tue, Jul 17, 6:34 PM
ngraham accepted D13450: Add arrow keys to move and resize selection rectangle.

Excellent. @rkflx, any last comments or objections, or shall we push this to the 18.08 branch?

Tue, Jul 17, 3:56 PM · Documentation
ngraham added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Tue, Jul 17, 3:48 PM · Documentation
ngraham added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Tue, Jul 17, 3:47 PM · Documentation
ngraham added a comment to D13936: Improve dialer UI and format phone number.

I mean, they have an outline when not hovered. As in, they look like buttons. :)

Tue, Jul 17, 3:44 PM
ngraham added a comment to D13936: Improve dialer UI and format phone number.

Maybe out of scope here, but I'd really like to see borders around the number buttons. I've used software dialers where the numbers didn't look buttonlike, and they always felt slower and more awkward to use.

Tue, Jul 17, 3:11 PM
ngraham accepted D13882: Use QTabBar: drop tons of code.

Fantastic, that's fixed it! This is a terrific patch, IMHO. Let's land it in master rather than the just-created 18.08 branch, and let's also probably wait for @hindenburg's opinion, too. :) I don't feel comfortable doing a real code review for this kind of diff, so my review is for behavior only.

Tue, Jul 17, 2:39 PM · Konsole
ngraham added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I'm happy with this patch now. The behavior seems useful and is invoked naturally, the inline documentation is clear, the code is sensible, and I couldn't find any regressions.

Tue, Jul 17, 2:31 PM · Documentation
ngraham added a comment to D14174: Fix blur behind folderview context menus.
In D14174#293468, @hein wrote:

We have blurred context menus now? Wtf.

But ok.

Tue, Jul 17, 2:21 PM · Plasma
ngraham added a comment to D14178: Fixes small memory leak in DolphinContextMenu.

Thanks! Can you commit this to the Applications/18.08 branch so we can be sure it gets into the 18.08 release?

Tue, Jul 17, 2:03 PM · Dolphin
ngraham added a comment to D13882: Use QTabBar: drop tons of code.

Well done. You fixed one of my biggest annoyances with Konsole: the high precision required to re-order tabs without detaching them. I feel like the size of the dead zone could be increased even a bit more, but this implementation is already radically better then what we had before. Kudos!

Tue, Jul 17, 1:47 PM · Konsole
ngraham added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Sorry to hear that, and I hope things get easier.

Tue, Jul 17, 4:44 AM · Documentation
ngraham added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Yeah, I say let's remove the test for now so we can commit this, and then you can add the test back in another patch please (in working form, of course!). :)

Tue, Jul 17, 4:36 AM · Frameworks
ngraham added a comment to D6083: Bump max thumbnail size to 512px.

Whoops, my bad! It has been so long since I last saw this that I forgot completely what it was about and trusted the Phabricator metadata.

Tue, Jul 17, 4:26 AM · Gwenview
ngraham updated the test plan for D13773: [KDirOperator] Use alternating background colors for multi-column views.
Tue, Jul 17, 3:28 AM · Frameworks
ngraham updated the diff for D13773: [KDirOperator] Use alternating background colors for multi-column views.

Only use the alternating row colors for multi-column views, to avoid having it on any vertical sidebar-style lists

Tue, Jul 17, 3:24 AM · Frameworks
ngraham added a comment to D14089: [WIP] Moved form alignment to a dedicated content pattern. added andy betts content about genreal alignment.

Also, the title of this patch needs to follow commit message best practices. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch and https://chris.beams.io/posts/git-commit/#seven-rules

Tue, Jul 17, 2:51 AM · KDE Human Interface Guidelines
ngraham added inline comments to D14089: [WIP] Moved form alignment to a dedicated content pattern. added andy betts content about genreal alignment.
Tue, Jul 17, 2:51 AM · KDE Human Interface Guidelines
ngraham added a comment to D13901: Touch support for Gwenview.

Hi, @ngraham,

thank you again for your time, to test this patch.

Tue, Jul 17, 2:43 AM
ngraham updated the test plan for D14145: Show a vertical menu for the panel widget options pop-up.
Tue, Jul 17, 2:32 AM · Plasma
ngraham updated the diff for D14145: Show a vertical menu for the panel widget options pop-up.
  • Address review comments
  • Make it a level 3 label to match other Headings used for panel adjustment
  • Make the buttons span the full width of the menu
Tue, Jul 17, 2:32 AM · Plasma
ngraham added a comment to D13882: Use QTabBar: drop tons of code.

Here are the behavioral quirks that I found during testing:

  • When drag-re-ordering tabs, the dragged tab visually stays on the bar now and only moves horizontally (yay!) but if you release the mouse outside of the tab bar, the dragged tab now detaches with no warning*
  • Tab context menu lost its Close menu item
  • When "Show new tab and close tab buttons" becomes checked after being unchecked, the space reserved for the New Tab button doesn't actually have that button in it until you quit and restart Konsole
Tue, Jul 17, 1:01 AM · Konsole

Mon, Jul 16

ngraham added a reviewer for D14168: Fixes memory leak in KItemListViewAccessible: jtamate.
Mon, Jul 16, 8:44 PM · Dolphin
ngraham accepted D13720: [effects] Rewrite the Dim Inactive effect.

+1 from VDG. As with others, please get a code review too.

Mon, Jul 16, 6:44 PM · KWin
ngraham accepted D13338: [effects] Rewrite the Glide effect.

VDG-approved, but please get a code review too.

Mon, Jul 16, 6:42 PM · KWin
ngraham accepted D13461: [effects] Add Scale effect.

+1 visually and conceptually (I like the idea of a single Scale effect that animates both opening and closing). KCM looks fine. No comment on the code since this isn't my area of expertise.

Mon, Jul 16, 6:40 PM · KWin
ngraham added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Shall we commit this? maxrd2 , can you do it, or does one of us need to commit it for you?

Mon, Jul 16, 6:29 PM · Frameworks
ngraham added a comment to D13773: [KDirOperator] Use alternating background colors for multi-column views.

Ping?

Mon, Jul 16, 3:40 PM · Frameworks
ngraham committed R266:ca645a423dbb: Add `drive-optical` icon (authored by ngraham).
Add `drive-optical` icon
Mon, Jul 16, 3:23 PM
ngraham closed D14123: Add `drive-optical` icon.
Mon, Jul 16, 3:23 PM · Frameworks
ngraham added a comment to D14123: Add `drive-optical` icon.

@andreask verbally (textually?) approved this in the VDG room; landing it.

Mon, Jul 16, 3:22 PM · Frameworks
ngraham added reviewers for D6083: Bump max thumbnail size to 512px: Konsole, tcanabrava, dhaumann.
Mon, Jul 16, 3:14 PM · Gwenview