Don't show confirmation dialog for Trash action by default
ClosedPublic

Authored by aleksejshilin on Fri, Jul 6, 11:07 AM.

Details

Summary

Dolphin and KIO default confirmation settings were not in sync: the former
defaults to not showing the dialog while the latter used to default to the
opposite.

This change resolves the inconsistency by adjusting KIO defaults.

BUG: 385492
FIXED-IN: 5.48

Test Plan
  1. Create a new user account and log into it.
  2. Open Dolphin.
  3. Create a text file and hit Del. The confirmation dialog should *not* appear.
  4. Check that permanent deletion (Shift+Del) and emptying the Trash still show the confirmation dialog.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aleksejshilin created this revision.Fri, Jul 6, 11:07 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFri, Jul 6, 11:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aleksejshilin requested review of this revision.Fri, Jul 6, 11:07 AM

There's a problem with the git setup on the computer you used to make this commit; the name field appears to be empty, so I get an error when I try to apply the patch:

Created and checked out branch arcpatch-D13921.
Checking patch src/widgets/jobuidelegate.cpp...
Applied patch src/widgets/jobuidelegate.cpp cleanly.
Exception
Command failed with error #128!
COMMAND
git commit -a --author='  <rootlexx@mail.ru>' -F - --no-verify

STDOUT
(empty)

STDERR
fatal: empty ident name (for <rootlexx@mail.ru>) not allowed

(Run with `--trace` for a full exception trace.)

The actual code change looks sane and fixes the bug.

Are you planning to update konqueror/settings/konq/behaviour.cpp as the comment asked? ;)

dfaure accepted this revision.Sat, Jul 7, 9:57 PM

Are you planning to update konqueror/settings/konq/behaviour.cpp as the comment asked? ;)

AFAICS that file doesn't have anything about confirmation-for-deletions anymore. Probably ever since konqueror embeds dolphinpart.

This revision is now accepted and ready to land.Sat, Jul 7, 9:57 PM
ngraham accepted this revision.Sat, Jul 7, 11:02 PM

Perfect!

Do you have commit access yet?

There's a problem with the git setup on the computer you used to make this commit; the name field appears to be empty, so I get an error when I try to apply the patch

That's weird. It is the very same machine which I previously used to submit all of my revisions, and actual commits look fine, too. I'll look into it tomorrow when I get to that PC.

Are you planning to update konqueror/settings/konq/behaviour.cpp as the comment asked? ;)

As @dfaure said, these things are no longer there, that's why I had changed the comment to point to the new location.

Do you have commit access yet?

I do, thanks! Will land tomorrow.

aleksejshilin edited the summary of this revision. (Show Details)Mon, Jul 9, 10:34 AM
This revision was automatically updated to reflect the committed changes.