In D15718#330844, @smithjd wrote:

In D15718#330836, @ngraham wrote:

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

A default mask of 0002 or more permissive looks fairly common across distros, and is permissive enough to index files by default.

setfacl -d -m u::rwx ~ or umask 0022 will set default execute permissions on created files. You can set something less permissive on your downloads directory or plasma vault mount with setfacl -d u::rw or similar.

chmod -R 755 ~ will recursively give every file in your home directory execute permisions.

In D15718#330836, @ngraham wrote:

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

In D15583#330799, @smithjd wrote:

Technically, this check isn't actually needed, though it does prevent the user from entering a path more than once. At first glance this looks like it should work:

if (folder.startsWith(path))

This doesn't prevent the user from also re-specifying valid paths.

Ok, I created the calendar events, I moved the 25th to the 27th. That whole week will be rough, but we should at least host a day for anyone that does not celebrate Christmas or has nothing to do. ;)

Ok, I've created the next calendar events. Thanks for the suggestions!

This is completely wrong ...

In T7983#159764, @ngraham wrote:

"Solid" is one of the big reasons why I keep trying to do D14850: [effects] Turn off Translucency by default. Our software can't feel solid when it literally becomes transparent when you move a window. :)

Whoops! I do indeed. Edited the original to be accurate. :)

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

You mean single-pixel* lines right? Just to be clear.

Files/folders should not be automatically indexed if the execute bit is unset. Downloads from most if not all popular browsers are not executable by default.

updated revision, it is probably ; ) fine now :D

Here's how the checkmark idea looks. I prefer the plain wall since it fits in with the other icons better.

Thanks for the review. I will address your comments and hopefully have a patch ready in the next days. :)

I have been working on Halium and Plasma Mobile Debian packages for more than a year now, mostly building and testing things. I have been helping to promote Plasma Mobile in social networks, then presented at a conference in St Petersburg. I've just finished working on KDE Russia's website and switched to Kaidan, a Kirigami XMPP messenger, in hope to improve my programming skills to participate in development.

I am able to reproduce them both. @wbauer do you want to fix them? If not, I can spend some time on it. :)

In D11880#330788, @ngraham wrote:

I like firewall-config and firewall-applet-error as they are.

I think that firewall-applet looks maybe a bit too plain at its 22px size. The wall seems to need something.

Thank you!

Landed on master, so the change will show up in KDE Plasma 5.15. See https://community.kde.org/Schedules/Plasma_5 for more information.

In D15717#330804, @borispek wrote:

Hi,

I'll need to know your real name and email address. Can you provide that information?

Boris Pek <tehnick-8@yandex.ru>

I supposed that all necessary information was in the patch prepared using git format-patch .... It looks I have missed something in phabricator documentation. (This is my first patch to KDE after a huge break...)

I'll need to know your real name and email address. Can you provide that information?

Whoops! Thanks for fixing those.

Technically, this check isn't actually needed, though it does prevent the user from entering a path more than once. At first glance this looks like it should work:

if (folder.startsWith(path))

For the benefit of others, here's what they look like now:

After testing the GitHub provider and the QmlJS code completion I'm somewhat confident that these changes are correct, but I want to give the experts on that code a chance to weigh in before I merge this. Now onto the discussion.

In D8532#289500, @davidk wrote:

I was asked in private about the current state of libseccomp integration and why there was no progress in a long time.
The current state is, that I have implemented seccomp support in kfilemetadata using this API:

bool setProcessReadOnly(uint32_t defaultAction, std::vector<SeccompFilter> addionalWhitelist)

But there are two blockers, related to external plugins:

• External plugins based on interpreters like python/lua/perl etc. need a huge whitelist. This is problematic as I want to keep the list of allowed syscalls as small as possible (the list would be huge). Additionally, it would be difficult to get a list of all needed syscalls. Thus, we would break many external plugins.
• Baloo is basically unmaintained. Thus, if something breaks, fixing it should be as easy as possible. But what if QT requires a new syscall and thus, the tests (and deployments) are failing? We need a way to know which syscall failed. This works for kfilemetadata plugins, but not for external plugins (because they are separate processes). The only way I can image, would be running the whole test with strace.
  
  So, if anyone is willing to continue this work, I would be happy to share my current state. Otherwise, if everyone agrees that we don't care about external plugins (users of external plugins can disable Seccomp support with an environment variable), I can finish the patches.

The ported dialog looks bad, both because the layout of the new widget is not where you would want it to be and because it has much less functionality than the native dialog.

I'm working on bringing KDE Connect to Plasma Mobile and also proposed that we use the SMS app that we are currently developing for KDE Connect as the SMS app for Plasma Mobile. I'd like to discuss ideas about KDE Connect on Plasma Mobile and work on the PM-specific parts of the SMS app task

In D15530#330605, @rjvbb wrote:

Doesn't KDevelop already add (install) a few mimetypes of its own? I think I mentioned before that I do have a .xml file for SMI, adding the x-objc++src definition and I presume that's why I am not seeing mimetype warnings about ObC (I'm seeing others though.)

Installing our own is the best way to be certain the definition is there - cf. the discussion around the astyle library and e.g. Debian Stable.

Wow, pinch zooming is hugely improved with this new version. Nice work!

In D15524#330685, @andrewgr wrote:

Dear Luigi,
    I should inform you that I've been in touch with Andreas Sturnlechner (you were copied in) - who has pointed out that there is a KF5 version already. It's a pity I did not discover this earlier - but I am new to a number of the software tools, including GitHub.

 https://github.com/kmorwinski/cirkuit/tree/frameworks

How about changing the outline or background of the text box to the Positive or Negative color from the active color theme? That way (for people with sensible color themes), the text box would show red if the value is invalid. I believe GNOME does something similar to this for their IP address validator, and in my experience it works quite nicely.

I gave this a try today and it works nicely! Awesome work! I'd still like some user interface improvements though, because gating these scaling options behind Force rasterization is not very user friendly: the connection between that setting and the scaling options is not likely to be apparent to any user who does not also happen to be a PDF expert or an Okular developer. :)

A way to detect the distro and running version

In D15694#330761, @rjvbb wrote:

I'll point out that we're no longer living with Q_FOREACH and that nothing forbids anyone to provide a less conspicuous pattern than Q_FALLTHROUGH.

Can we please first answer this and this before going on with this? I feel they are just ignored without any reasonable explanation. Thanks.

Ok, thanks for the info. I'll excuse myself now since the technical discussion is way over my head. I just wanted to express support for the idea behind this patch.

In D15607#329852, @astippich wrote:

I think there is still one issue: when the view is not collapsed and you click on e.g. artist view, the search field also doesn't get focus immediately. but it's an improvement anyway

+1 for something rather than nothing. No comment on the technical aspect, but I'm adding more reviewers who can hopefully help un-wedge this patch.

Still +1, looks great!