User Details
- User Since
- May 7 2016, 7:15 AM (417 w, 6 d)
- Availability
- Available
Jun 17 2019
May 27 2019
- [Plasma Search KCM] Re-organize the tab and widget layouts.
- Add edit actions.
- [KRunner] Change start of line shortcut to CTRL + S.
- [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.
- Make edit actions configurable.
- Follow standard shortcuts nomenclature.
- Fix clear action.
Mar 11 2019
The change was ack'ed in this review, and this review closed by the commit.
Mar 10 2019
This test fails:
Feb 27 2019
Feb 25 2019
Feb 23 2019
Anyway, most of this special handling of mimetypes goes away with D18826, where TagLib will do the conversion automatically.
Feb 21 2019
I realise that with all the fields referenced here having at least one standard fieldname parsed now that complaining may seem to be flogging a dead horse, but I'd like to re-iterate that identically-purposed fields should not be encouraged. This is at best a specialized re-purposing that really shouldn't be. Maintaining a branch / fork for this is probably appropriate.
- Use the de-facto Album Artist field name for APE tags.
Re-base.
Jan 22 2019
Timezone name expansion, date into the future, and multiple matches:
Jan 21 2019
"Locking" the scheduler is simpler here than identifying that it "has gone idle". "Locking" only happens here for a small number of runnables (two) that can't run concurrently.
- Re-write the file index scheduler. Combine content indexer suspend logic.
- Update the balooctl tool with the changed suspend/resume behaviour.
- Re-order and use IndexerState to prioritize the indexer thread pool.
- Newline and tab fixes.
- Prevent a scheduler race condition.
- Separate runnableStateChanged into two functors.
- Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
- Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
- Simplify locking the scheduler.
- Adapt index cleaner to scheduler.
- Rebase
Jan 20 2019
- [DateTime Runner] Add from-zone, to-zone and 24-hour time conversion. Improve timezone lookups (i.e. identical zone names now return all matches). The zone name is now used instead of the abbreviation in matches.
- Rebase to current master.
Nov 27 2018
Rebase around multiple zone matching, and some improvements.
Nov 4 2018
Nov 2 2018
- Use the de-facto Album Artist field name for APE tags.
Nov 1 2018
I would instead recommend a tag editor that properly tags APE files, such as puddletag. APE-using formats are less mainstream than id3 using formats. Users with APE-using formats usually know WHY they use their format of choice, and will know there are potential support shortfalls such as non-compliant tagging software, or software that allows to circumvent the accepted tagging standard, and will know how to mitigate or avoid such issues. I must also point out that stricter tag field adherence is better for APE-using formats in particular, and is better for all tag-using formats in general.
I would also argue that accepting values from tag field names that have identically-purposed, widely-acceptable alternatives is irresponsible. Changing your tags to meet the standard then is a more viable course of action.
- Change the unit test to check if the APE 'disc' value is correct.
Useful tag mapping information:
Oct 14 2018
- Re-write the file index scheduler. Combine content indexer suspend logic.
- Update the balooctl tool with the changed suspend/resume behaviour.
- Re-order and use IndexerState to prioritize the indexer thread pool.
- Newline and tab fixes.
- Prevent a scheduler race condition.
- Separate runnableStateChanged into two functors.
- Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
- Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
- Simplify locking the scheduler.
- Adapt index cleaner to scheduler.
Oct 11 2018
https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the storagedevices object was required: https://phabricator.kde.org/D15047. The alternative, implementing a path lookup function is here: https://phabricator.kde.org/D15843.
Oct 10 2018
Rebase.
Rebase.
Rebase.
- Rebase.
- Re-write the file index scheduler. Combine content indexer suspend logic.
- Update the balooctl tool with the changed suspend/resume behaviour.
- Re-order and use IndexerState to prioritize the indexer thread pool.
- Newline and tab fixes.
- Prevent a scheduler race condition.
- Separate runnableStateChanged into two functors.
- Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
- Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
- Simplify locking the scheduler.
- Adapt index cleaner to scheduler.
- Re-write the file index scheduler. Combine content indexer suspend logic.
- Update the balooctl tool with the changed suspend/resume behaviour.
- Re-order and use IndexerState to prioritize the indexer thread pool.
- Newline and tab fixes.
- Prevent a scheduler race condition.
- Separate runnableStateChanged into two functors.
- Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
- Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
- Simplify locking the scheduler.
- Adapt index cleaner to scheduler.
Oct 9 2018
Does this run at startup? If so, this will erase the entries of files on a removable volume not already mounted.
Oct 7 2018
- [DateTime Runner] Show a date match if needed on conversion both to and from local
Oct 1 2018
Sep 30 2018
As a side note - cross-device indexing is broken anyway and can never work reliably in the current scheme using device ids as part of the baloo document id. Device ids are not stable. For the home partition it works somewhat reliable as the device setup is sufficiently fixed, but for any network share, Vault, disk image, whatever, it depends on the mounting order.
I will keep opposing any changes trying to paper over it.
I have not had a problem with mounted external volumes. FYI, complain to the Solid people about the non-randomness of the udi. That isn't a fault of Baloo.
You clearly lack understanding of the problem. This is not about solid UDIs, but about device ids provided by the kernel (man 7 inode) . Complain to the Linux folks!?
There is no need for this, just create a new StorageDevices where you need it.
Creating a second StorageDevices instance in a process is quite cheap.Creating a separate object cluttered the console with duplicated debug output and raised a threading error.
Sep 29 2018
Sep 27 2018
A slightly smarter approach would be for Plasma Vaults itself to add such a rule for whatever mountpoint is chosen during new vault creation.
Sep 25 2018
xattrs are no good for vaults because the xattr is ignored for the mountpoint, only restored when the volume is unmounted.
What's wrong with a .balooignore file in the root of the vault? Tracker uses .trackerignore.
No, because even if the default umask is 002, or 022, POSIX says that the default permissions of a file on creation are going to be 0666, not 0777:
https://www.freedesktop.org/wiki/CommonExtendedAttributes suggests xattrs to use to store do-not-index information and also requires each file to be explicitly set to be indexed.
Sep 24 2018
What was wrong with https://phabricator.kde.org/D15583?id=42018 ?
- [DateTime Runner] Add two new syntaxes for conversion to and from 24 hour time.
Files/folders should not be automatically indexed if the execute bit is unset. Downloads from most if not all popular browsers are not executable by default.
Sep 23 2018
Technically, this check isn't actually needed, though it does prevent the user from entering a path more than once. At first glance this looks like it should work:
if (folder.startsWith(path))
Sep 21 2018
Sep 11 2018
Sep 10 2018
Sep 7 2018
- [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.
Aug 25 2018
- New DBus method updateIndex().
- Document indexing options.
- Prevent a scheduler race condition.
- Rebase for separate statechanged functors.
- Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
Aug 24 2018
Closing this because it breaks at least the settings:// ioslave, and the tags:// slave no longer has urls attached to the filename.
- New DBus method updateIndex().
- Document indexing options.
- Prevent a scheduler race condition.
- Run de-indexing file check in parallel.
- Rebase for separate statechanged functors.
Rebase.
Rebase.
- Re-write the file index scheduler. Combine content indexer suspend logic.
- Update the balooctl tool with the changed suspend/resume behaviour.
- Re-order and use IndexerState to prioritize the indexer thread pool.
- Newline and tab fixes.
- Prevent a scheduler race condition.
- Separate runnableStateChanged into two functors.
- Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.