smithjd (James Smith)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 7 2016, 7:15 AM (175 w, 2 d)
Availability
Available

Recent Activity

Jun 17 2019

smithjd abandoned D13425: File indexer closing improvements..
Jun 17 2019, 1:05 AM · Baloo, Frameworks

May 27 2019

smithjd updated the summary of D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts..
May 27 2019, 1:44 AM · Plasma
smithjd updated the diff for D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts..
  • [Plasma Search KCM] Re-organize the tab and widget layouts.
  • Add edit actions.
May 27 2019, 1:40 AM · Plasma
smithjd updated the diff for D14739: [KRunner] Allow modifying the keyboard shortcuts..
  • [KRunner] Change start of line shortcut to CTRL + S.
  • [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.
  • Make edit actions configurable.
  • Follow standard shortcuts nomenclature.
  • Fix clear action.
May 27 2019, 1:36 AM · Plasma

Mar 11 2019

smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

The change, as you pushed it, was never open for review, so there was not even the chance to review.

Mar 11 2019, 11:16 PM · Baloo, Frameworks
smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

The change was ack'ed in this review, and this review closed by the commit.

Mar 11 2019, 7:58 AM · Baloo, Frameworks
smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

Two reviewers had open "Changes Requested" statuses on this patch when you committed it, and from the latest comments, it's not clear that their concerns were addressed first. Can you explain your thought process regarding why you felt it was appropriate to ignore your reviewers as well as KDE community norms and commit this anyway?

Mar 11 2019, 5:06 AM · Baloo, Frameworks

Mar 10 2019

smithjd updated the test plan for D16579: Remove support for non-standard APE tag field names from the test files.
Mar 10 2019, 6:58 PM · Baloo, Frameworks
smithjd closed D16579: Remove support for non-standard APE tag field names from the test files.
Mar 10 2019, 6:57 PM · Baloo, Frameworks
smithjd committed R286:4c5c4f5b91ab: Use 'ALBUM ARTIST' field name for APEv2 test files. (authored by smithjd).
Use 'ALBUM ARTIST' field name for APEv2 test files.
Mar 10 2019, 6:57 PM
smithjd added a comment to D18826: Rewrite the taglib extractor to use the generic PropertyMap interface.

This test fails:

Mar 10 2019, 6:38 PM · Baloo, Frameworks

Feb 27 2019

smithjd committed R293:7463067967d3: [tags_kio] Fix local file tagging by checking only tag: urls for double slashes. (authored by smithjd).
[tags_kio] Fix local file tagging by checking only tag: urls for double slashes.
Feb 27 2019, 6:18 AM
smithjd added inline comments to D18826: Rewrite the taglib extractor to use the generic PropertyMap interface.
Feb 27 2019, 1:09 AM · Baloo, Frameworks

Feb 25 2019

smithjd added inline comments to D18826: Rewrite the taglib extractor to use the generic PropertyMap interface.
Feb 25 2019, 4:00 AM · Baloo, Frameworks

Feb 23 2019

smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

Anyway, most of this special handling of mimetypes goes away with D18826, where TagLib will do the conversion automatically.

Feb 23 2019, 8:46 PM · Baloo, Frameworks

Feb 21 2019

smithjd updated the summary of D16579: Remove support for non-standard APE tag field names from the test files.
Feb 21 2019, 3:33 AM · Baloo, Frameworks
smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

I realise that with all the fields referenced here having at least one standard fieldname parsed now that complaining may seem to be flogging a dead horse, but I'd like to re-iterate that identically-purposed fields should not be encouraged. This is at best a specialized re-purposing that really shouldn't be. Maintaining a branch / fork for this is probably appropriate.

Feb 21 2019, 3:30 AM · Baloo, Frameworks
smithjd updated the diff for D16579: Remove support for non-standard APE tag field names from the test files.
  • Use the de-facto Album Artist field name for APE tags.

Re-base.

Feb 21 2019, 3:30 AM · Baloo, Frameworks

Jan 22 2019

smithjd committed R293:f4dd3f7bab79: [tags_kio] Disable access with a double slashed url, i.e. "tags://". (authored by smithjd).
[tags_kio] Disable access with a double slashed url, i.e. "tags://".
Jan 22 2019, 8:54 PM
smithjd added a comment to D15684: DateTime Runner timezone and 24 hour clock time conversion..

Timezone name expansion, date into the future, and multiple matches:

Jan 22 2019, 12:00 AM · Plasma

Jan 21 2019

smithjd added a comment to D13216: Overhaul the file index scheduler..

"Locking" the scheduler is simpler here than identifying that it "has gone idle". "Locking" only happens here for a small number of runnables (two) that can't run concurrently.

Jan 21 2019, 6:04 AM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..
  • Re-write the file index scheduler. Combine content indexer suspend logic.
  • Update the balooctl tool with the changed suspend/resume behaviour.
  • Re-order and use IndexerState to prioritize the indexer thread pool.
  • Newline and tab fixes.
  • Prevent a scheduler race condition.
  • Separate runnableStateChanged into two functors.
  • Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
  • Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
  • Simplify locking the scheduler.
  • Adapt index cleaner to scheduler.
  • Rebase
Jan 21 2019, 12:41 AM · Baloo, Frameworks

Jan 20 2019

smithjd updated the diff for D15684: DateTime Runner timezone and 24 hour clock time conversion..
  • [DateTime Runner] Add from-zone, to-zone and 24-hour time conversion. Improve timezone lookups (i.e. identical zone names now return all matches). The zone name is now used instead of the abbreviation in matches.
  • Rebase to current master.
Jan 20 2019, 11:48 PM · Plasma

Nov 27 2018

smithjd requested review of D15684: DateTime Runner timezone and 24 hour clock time conversion..
Nov 27 2018, 4:28 AM · Plasma
smithjd updated the diff for D15684: DateTime Runner timezone and 24 hour clock time conversion..

Rebase around multiple zone matching, and some improvements.

Nov 27 2018, 4:27 AM · Plasma

Nov 4 2018

smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

You're doing the exact opposite of what we're asking for.
Look, I'd love to merge the bug fix for the DISC property. But we need compatibility.
I'll give you another reason: KFileMetaData has basically required that users use the DISCNUMBER field until now. And now you want to change that without providing any suitable transition. That's not user-friendly.

Nov 4 2018, 12:00 AM · Baloo, Frameworks

Nov 2 2018

smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.
  • Use the de-facto Album Artist field name for APE tags.

    Since the discussion around this patch has also included the Album Artist field, add the changes required for this field to this review.
Nov 2 2018, 4:50 PM · Baloo, Frameworks
smithjd added a reviewer for D16579: Remove support for non-standard APE tag field names from the test files: mgallien.
Nov 2 2018, 4:42 PM · Baloo, Frameworks
smithjd updated the diff for D16579: Remove support for non-standard APE tag field names from the test files.
  • Use the de-facto Album Artist field name for APE tags.
Nov 2 2018, 4:28 PM · Baloo, Frameworks

Nov 1 2018

smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

I would instead recommend a tag editor that properly tags APE files, such as puddletag. APE-using formats are less mainstream than id3 using formats. Users with APE-using formats usually know WHY they use their format of choice, and will know there are potential support shortfalls such as non-compliant tagging software, or software that allows to circumvent the accepted tagging standard, and will know how to mitigate or avoid such issues. I must also point out that stricter tag field adherence is better for APE-using formats in particular, and is better for all tag-using formats in general.

Good luck "educating" every APE user, they will really like to be told they should do what you consider right.

Nov 1 2018, 8:17 PM · Baloo, Frameworks
smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

I would instead recommend a tag editor that properly tags APE files, such as puddletag. APE-using formats are less mainstream than id3 using formats. Users with APE-using formats usually know WHY they use their format of choice, and will know there are potential support shortfalls such as non-compliant tagging software, or software that allows to circumvent the accepted tagging standard, and will know how to mitigate or avoid such issues. I must also point out that stricter tag field adherence is better for APE-using formats in particular, and is better for all tag-using formats in general.

Nov 1 2018, 5:29 PM · Baloo, Frameworks
smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

I would also argue that accepting values from tag field names that have identically-purposed, widely-acceptable alternatives is irresponsible. Changing your tags to meet the standard then is a more viable course of action.

Nov 1 2018, 4:25 PM · Baloo, Frameworks
smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

The ape tag tests fail with this patch, but the test is actually wrong in that regard. It tests for an empty disc number, which I haven't noticed before.
I've found references to both DISCNUMBER and DISC, so the safest way is probably to check both.
So please query both tags like it is already done for the album artist and adjust the taglibextractortest.

DISCNUMBER doesn't seem to be a valid (or widely used) field for APEv2.

More (Picard) information: https://picard.musicbrainz.org/docs/mappings

Also it appears Picard, Puddletag and ffmpeg use 'Album Artist', not 'ALBUMARTIST'. And the link I provided (https://wiki.hydrogenaud.io/index.php?title=Tag_Mapping) also lists 'Album Artist' not 'ALBUMARTIST'. The unit test file has an 'ALBUMARTIST' field that should be changed to 'Album Artist'.

Yes, maybe it's not widely used, but it is used. Kodi for example supports both reading from DISCNUMBER and DISC. If you use kid3 to edit the metadata of ape tags, the standard behavior is to actually to write to DISCNUMBER (and similar to ALBUMARTIST).
One thing I've learned when I digged into metadata of audio files is that there is no standard, and KFileMetaData should handle as much cases as possible. Since it is easy to query both, please add it.

Nov 1 2018, 4:00 PM · Baloo, Frameworks
smithjd updated the diff for D16579: Remove support for non-standard APE tag field names from the test files.
  • Change the unit test to check if the APE 'disc' value is correct.
Nov 1 2018, 2:23 PM · Baloo, Frameworks
smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

The ape tag tests fail with this patch, but the test is actually wrong in that regard. It tests for an empty disc number, which I haven't noticed before.
I've found references to both DISCNUMBER and DISC, so the safest way is probably to check both.
So please query both tags like it is already done for the album artist and adjust the taglibextractortest.

Nov 1 2018, 2:18 PM · Baloo, Frameworks
smithjd added a comment to D16579: Remove support for non-standard APE tag field names from the test files.

Useful tag mapping information:

Nov 1 2018, 5:49 AM · Baloo, Frameworks
smithjd requested review of D16579: Remove support for non-standard APE tag field names from the test files.
Nov 1 2018, 5:48 AM · Baloo, Frameworks

Oct 14 2018

smithjd updated the diff for D13216: Overhaul the file index scheduler..
  • Re-write the file index scheduler. Combine content indexer suspend logic.
  • Update the balooctl tool with the changed suspend/resume behaviour.
  • Re-order and use IndexerState to prioritize the indexer thread pool.
  • Newline and tab fixes.
  • Prevent a scheduler race condition.
  • Separate runnableStateChanged into two functors.
  • Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
  • Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
  • Simplify locking the scheduler.
  • Adapt index cleaner to scheduler.
Oct 14 2018, 8:38 PM · Baloo, Frameworks
smithjd abandoned D13424: Run a file changed check when the file watches are updated..
Oct 14 2018, 8:28 PM · Baloo, Frameworks
smithjd added a comment to D15939: Perform checks for unindexed files and stale index entries on startup.

https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the storagedevices object was required: https://phabricator.kde.org/D15047. The alternative, implementing a path lookup function is here: https://phabricator.kde.org/D15843.

Sorry, I was not aware of those patches (didn't do my homework). I'll look at those!

UPD: but will those help? I mean, if device is not present at the moment, Solid won't pop it up, and index entries will be forgotten.
It seems like it will help only if device is present, but not yet mounted.

Oct 14 2018, 7:55 PM · Baloo, Frameworks

Oct 11 2018

smithjd added a comment to D15939: Perform checks for unindexed files and stale index entries on startup.

https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the storagedevices object was required: https://phabricator.kde.org/D15047. The alternative, implementing a path lookup function is here: https://phabricator.kde.org/D15843.

Oct 11 2018, 2:44 AM · Baloo, Frameworks

Oct 10 2018

smithjd updated the diff for D13425: File indexer closing improvements..

Rebase.

Oct 10 2018, 11:51 PM · Baloo, Frameworks
smithjd added a comment to D13425: File indexer closing improvements..

https://bugs.kde.org/show_bug.cgi?id=353559

Oct 10 2018, 9:27 PM · Baloo, Frameworks
smithjd removed a dependency for D11529: Balooctl: Deindex unfound files with check command.: D13216: Overhaul the file index scheduler..
Oct 10 2018, 9:24 PM · Baloo, Frameworks
smithjd removed a dependent revision for D13216: Overhaul the file index scheduler.: D11529: Balooctl: Deindex unfound files with check command..
Oct 10 2018, 9:24 PM · Baloo, Frameworks
smithjd removed a dependency for D11529: Balooctl: Deindex unfound files with check command.: D15047: Export the StorageDevices object..
Oct 10 2018, 9:22 PM · Baloo, Frameworks
smithjd removed a dependent revision for D15047: Export the StorageDevices object.: D11529: Balooctl: Deindex unfound files with check command..
Oct 10 2018, 9:22 PM · Baloo, Frameworks
smithjd updated the diff for D13425: File indexer closing improvements..

Rebase.

Oct 10 2018, 9:14 PM · Baloo, Frameworks
smithjd updated the diff for D13425: File indexer closing improvements..

Rebase.

Oct 10 2018, 9:12 PM · Baloo, Frameworks
smithjd updated the diff for D15047: Export the StorageDevices object..
  • Rebase.
Oct 10 2018, 9:07 PM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..
  • Re-write the file index scheduler. Combine content indexer suspend logic.
  • Update the balooctl tool with the changed suspend/resume behaviour.
  • Re-order and use IndexerState to prioritize the indexer thread pool.
  • Newline and tab fixes.
  • Prevent a scheduler race condition.
  • Separate runnableStateChanged into two functors.
  • Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
  • Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
  • Simplify locking the scheduler.
  • Adapt index cleaner to scheduler.
Oct 10 2018, 9:05 PM · Baloo, Frameworks
smithjd updated the diff for D15047: Export the StorageDevices object..
  • Re-write the file index scheduler. Combine content indexer suspend logic.
  • Update the balooctl tool with the changed suspend/resume behaviour.
  • Re-order and use IndexerState to prioritize the indexer thread pool.
  • Newline and tab fixes.
  • Prevent a scheduler race condition.
  • Separate runnableStateChanged into two functors.
  • Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
  • Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
  • Simplify locking the scheduler.
  • Adapt index cleaner to scheduler.
Oct 10 2018, 9:00 PM · Baloo, Frameworks

Oct 9 2018

smithjd added a comment to D15939: Perform checks for unindexed files and stale index entries on startup.

Does this run at startup? If so, this will erase the entries of files on a removable volume not already mounted.

Oct 9 2018, 3:03 AM · Baloo, Frameworks
smithjd abandoned D11529: Balooctl: Deindex unfound files with check command..
Oct 9 2018, 2:47 AM · Baloo, Frameworks

Oct 7 2018

smithjd updated the diff for D15684: DateTime Runner timezone and 24 hour clock time conversion..
  • [DateTime Runner] Show a date match if needed on conversion both to and from local
Oct 7 2018, 10:31 PM · Plasma

Oct 1 2018

smithjd added a comment to D15843: Allow FileIndexerConfig to check device mounted status by path..

Perhaps we should discuss the implementation of multi-device indexing in a Phab ticket instead of across the comments of multiple patches. Then we can settle on an agreed-upon approach and go implement it instead of going in circles with different approaches.

Oct 1 2018, 7:35 PM · Baloo, Frameworks

Sep 30 2018

smithjd added a comment to D15843: Allow FileIndexerConfig to check device mounted status by path..

As a side note - cross-device indexing is broken anyway and can never work reliably in the current scheme using device ids as part of the baloo document id. Device ids are not stable. For the home partition it works somewhat reliable as the device setup is sufficiently fixed, but for any network share, Vault, disk image, whatever, it depends on the mounting order.

I will keep opposing any changes trying to paper over it.

I have not had a problem with mounted external volumes. FYI, complain to the Solid people about the non-randomness of the udi. That isn't a fault of Baloo.

You clearly lack understanding of the problem. This is not about solid UDIs, but about device ids provided by the kernel (man 7 inode) . Complain to the Linux folks!?

Sep 30 2018, 11:29 PM · Baloo, Frameworks
smithjd added a comment to D15843: Allow FileIndexerConfig to check device mounted status by path..

There is no need for this, just create a new StorageDevices where you need it.
Creating a second StorageDevices instance in a process is quite cheap.

Creating a separate object cluttered the console with duplicated debug output and raised a threading error.

Sep 30 2018, 11:14 PM · Baloo, Frameworks
smithjd added a comment to D15843: Allow FileIndexerConfig to check device mounted status by path..

Most obvious problem with this change - as far as I can deduce from your description, this is about runtime behaviour. The config class is the wrong place to add this method.

Sep 30 2018, 9:06 PM · Baloo, Frameworks

Sep 29 2018

smithjd added a comment to D15843: Allow FileIndexerConfig to check device mounted status by path..

Whats the use case exactly? "Some parts" is not sufficient ...

Sep 29 2018, 11:05 PM · Baloo, Frameworks
smithjd requested review of D15843: Allow FileIndexerConfig to check device mounted status by path..
Sep 29 2018, 10:32 PM · Baloo, Frameworks

Sep 27 2018

smithjd added a comment to T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems.

A slightly smarter approach would be for Plasma Vaults itself to add such a rule for whatever mountpoint is chosen during new vault creation.

Sep 27 2018, 11:49 PM · Baloo

Sep 25 2018

smithjd abandoned D15718: Do not index the path if the path has no execute permissions..
Sep 25 2018, 10:52 PM · Baloo, Frameworks
smithjd added a comment to D15718: Do not index the path if the path has no execute permissions..

xattrs are no good for vaults because the xattr is ignored for the mountpoint, only restored when the volume is unmounted.

Sep 25 2018, 10:50 PM · Baloo, Frameworks
smithjd added a comment to T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems.

What's wrong with a .balooignore file in the root of the vault? Tracker uses .trackerignore.

Sep 25 2018, 10:39 PM · Baloo
smithjd added a comment to D15718: Do not index the path if the path has no execute permissions..

No, because even if the default umask is 002, or 022, POSIX says that the default permissions of a file on creation are going to be 0666, not 0777:

Sep 25 2018, 4:47 AM · Baloo, Frameworks
smithjd added a comment to D15718: Do not index the path if the path has no execute permissions..

https://www.freedesktop.org/wiki/CommonExtendedAttributes suggests xattrs to use to store do-not-index information and also requires each file to be explicitly set to be indexed.

Sep 25 2018, 1:18 AM · Baloo, Frameworks

Sep 24 2018

smithjd added a comment to D15583: [Balooctl] remove directory parent check.

What was wrong with https://phabricator.kde.org/D15583?id=42018 ?

Sep 24 2018, 11:00 PM · Baloo, Frameworks
smithjd updated the diff for D15684: DateTime Runner timezone and 24 hour clock time conversion..
  • [DateTime Runner] Add two new syntaxes for conversion to and from 24 hour time.
Sep 24 2018, 10:25 PM · Plasma
smithjd added a comment to D15718: Do not index the path if the path has no execute permissions..

Making files executable that don't need to be executable is a bad security habit. What if the contents get replaced with something malicious? Suddenly that now-malicious file has execute permissions.

Sep 24 2018, 4:44 AM · Baloo, Frameworks
smithjd added a comment to D15718: Do not index the path if the path has no execute permissions..

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

A default mask of 0002 or more permissive looks fairly common across distros, and is permissive enough to index files by default.

setfacl -d -m u::rwx ~ or umask 0022 will set default execute permissions on created files. You can set something less permissive on your downloads directory or plasma vault mount with setfacl -d u::rw or similar.

chmod -R 755 ~ will recursively give every file in your home directory execute permisions.

You are proposing fundamentally breaking Baloo and then requiring that users or distros clean up our mess for us by making all their files executable--in the process reducing their own security. Sorry, but this is simply unacceptable.

No part of this proposal makes any sense to me. We just can't do this.

Sep 24 2018, 4:05 AM · Baloo, Frameworks
smithjd added a comment to D15718: Do not index the path if the path has no execute permissions..

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

Sep 24 2018, 3:21 AM · Baloo, Frameworks
smithjd committed R293:cacd6f91c72b: [tags_kio] Fix parenthesis. Somehow this got by my code checker. (authored by smithjd).
[tags_kio] Fix parenthesis. Somehow this got by my code checker.
Sep 24 2018, 12:46 AM
smithjd committed R293:4e3c769bd627: [tags_kio] Remove intermediate QString. (authored by smithjd).
[tags_kio] Remove intermediate QString.
Sep 24 2018, 12:46 AM
smithjd added a comment to D15718: Do not index the path if the path has no execute permissions..

Files/folders should not be automatically indexed if the execute bit is unset. Downloads from most if not all popular browsers are not executable by default.

Sep 24 2018, 12:15 AM · Baloo, Frameworks
smithjd requested review of D15718: Do not index the path if the path has no execute permissions..
Sep 24 2018, 12:00 AM · Baloo, Frameworks

Sep 23 2018

smithjd added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sep 23 2018, 10:35 PM · Baloo, Frameworks
smithjd added a comment to D15583: [Balooctl] remove directory parent check.

Technically, this check isn't actually needed, though it does prevent the user from entering a path more than once. At first glance this looks like it should work:

if (folder.startsWith(path))
Sep 23 2018, 9:46 PM · Baloo, Frameworks

Sep 21 2018

smithjd requested review of D15684: DateTime Runner timezone and 24 hour clock time conversion..
Sep 21 2018, 8:49 PM · Plasma
smithjd committed R114:ed2e23bc44f2: [DateTime Runner] Fix a copyright typo. (authored by smithjd).
[DateTime Runner] Fix a copyright typo.
Sep 21 2018, 8:38 PM

Sep 11 2018

smithjd added a comment to D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts..

KRunner as a standalone application does much more than search for files. Therefore adding independent shortcut configurability isn't so hard to justify. Kicker/Kickoff and dolphin search text input shortcuts on the other hand are configurable globally already, and only perform a subset of what KRunner does.

Can you explain why the fact that KRunner does more than the search fields in Kicker/Kickoff and Dolphin is a justification for allowing you to customize a small subset of the navigation shortcuts there, but not elsewhere? Help me understand where you're coming from. If you'd want to use ctrl+e and ctrl+s (etc.) to navigate in KRunner, why wouldn't you want to use them elsewhere too? What's the difference?

Sep 11 2018, 7:02 AM · Plasma
smithjd added a comment to D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts..

Kicker/Kickoff and the dolphin search aren't full-fledged launchers like KRunner, only search fields for Baloo.

  1. Kicker/Kickoff actually are: they're full-fledged interfaces to KRunner, with the exception that they have a semi-hardcoded list of enabled runners.
  2. Not sure how that would make a difference anyway; the point is, if these navigation shortcuts are valuable for the KRunner input field, why wouldn't they be useful for every input field?
Sep 11 2018, 12:09 AM · Plasma

Sep 10 2018

smithjd added a comment to D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts..

I appreciate the patch and the fact that you considered the prior comments in D14739. But I must admit I'm still left with a nagging question: "Why?"

Why here? Why not elsewhere? How about the search field in Kicker and Kickoff? The one in Dolphin? If this should be done at all, shouldn't it be done everywhere? And if it can't be done everywhere due to conflicts (i.e. because ctrl+a and ctrl+s have existing meanings in GUI software), then should it be done at all?

Sep 10 2018, 9:12 PM · Plasma

Sep 7 2018

smithjd updated the summary of D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts..
Sep 7 2018, 9:50 PM · Plasma
smithjd updated the test plan for D14739: [KRunner] Allow modifying the keyboard shortcuts..
Sep 7 2018, 9:49 PM · Plasma
smithjd requested review of D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts..
Sep 7 2018, 9:46 PM · Plasma
smithjd updated the diff for D14739: [KRunner] Allow modifying the keyboard shortcuts..
  • [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.
Sep 7 2018, 9:40 PM · Plasma

Aug 25 2018

smithjd updated the diff for D11529: Balooctl: Deindex unfound files with check command..
  • New DBus method updateIndex().
  • Document indexing options.
  • Prevent a scheduler race condition.
  • Rebase for separate statechanged functors.
Aug 25 2018, 3:03 AM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..
  • Revert "Re-order and use IndexerState to prioritize the indexer thread pool."
Aug 25 2018, 2:57 AM · Baloo, Frameworks

Aug 24 2018

smithjd added inline comments to D13216: Overhaul the file index scheduler..
Aug 24 2018, 7:57 PM · Baloo, Frameworks
smithjd added inline comments to D11529: Balooctl: Deindex unfound files with check command..
Aug 24 2018, 7:56 PM · Baloo, Frameworks
smithjd added a comment to D15047: Export the StorageDevices object..

There is no need for this, just create a new StorageDevices where you need it.
Creating a second StorageDevices instance in a process is quite cheap.

Creating a separate object cluttered the console with duplicated debug output and raised a threading error.

Then your code is wrong anyway. This is lazy initialization, and if you can not not guarantee it is save to do so, don't do it.

Aug 24 2018, 7:55 PM · Baloo, Frameworks
smithjd updated the summary of D13216: Overhaul the file index scheduler..
Aug 24 2018, 6:33 PM · Baloo, Frameworks
smithjd abandoned D13291: [kioclient] Use UDS_DISPLAY_NAME for file names..

Closing this because it breaks at least the settings:// ioslave, and the tags:// slave no longer has urls attached to the filename.

Aug 24 2018, 3:48 AM · Frameworks, Plasma
smithjd updated the diff for D11529: Balooctl: Deindex unfound files with check command..
  • New DBus method updateIndex().
  • Document indexing options.
  • Prevent a scheduler race condition.
  • Run de-indexing file check in parallel.
  • Rebase for separate statechanged functors.
Aug 24 2018, 3:26 AM · Baloo, Frameworks
smithjd updated the diff for D13424: Run a file changed check when the file watches are updated..

Rebase.

Aug 24 2018, 3:24 AM · Baloo, Frameworks
smithjd updated the diff for D13425: File indexer closing improvements..

Rebase.

Aug 24 2018, 3:23 AM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..
  • Re-write the file index scheduler. Combine content indexer suspend logic.
  • Update the balooctl tool with the changed suspend/resume behaviour.
  • Re-order and use IndexerState to prioritize the indexer thread pool.
  • Newline and tab fixes.
  • Prevent a scheduler race condition.
  • Separate runnableStateChanged into two functors.
  • Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time.
Aug 24 2018, 3:20 AM · Baloo, Frameworks
smithjd abandoned D15048: Re-write the file index scheduler. Combine content indexer suspend logic..
Aug 24 2018, 3:15 AM · Baloo, Frameworks
smithjd requested review of D15048: Re-write the file index scheduler. Combine content indexer suspend logic..
Aug 24 2018, 3:13 AM · Baloo, Frameworks