astippich (Alexander Stippich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2017, 1:49 PM (105 w, 3 h)
Availability
Available

Recent Activity

Thu, Oct 17

astippich added a comment to T7878: Create or find Icon.

48px


32px with own icon, since its required for system settings

Thu, Oct 17, 7:16 PM · VDG, Baloo
astippich updated the diff for D24598: Update elisa icon.
  • update and save as optimized svg
Thu, Oct 17, 7:01 PM · Elisa, Frameworks
astippich added a comment to D23402: Show tracks with empty titles.

I spent some time on this. It should be possible to at least cover the no metadata case with requests only on TracksData. What do you think?

If you want, I can try to do that on gitlab?

It should be easier to extend it to the full solution by working together on it and using your work as a basis.

Thu, Oct 17, 6:58 PM · Elisa

Wed, Oct 16

astippich added a comment to D23859: Radios: add support for images.

Sorry for the late reply.
To be honest, I don't know how useful this is when the image must be added manually. Ideally, this would be retrieved automatically. However, this could provide the base for such a feature.

Wed, Oct 16, 7:12 PM
astippich added a comment to T7878: Create or find Icon.

Proposal:

Wed, Oct 16, 6:24 PM · VDG, Baloo
astippich added a comment to D24598: Update elisa icon.

This is with the tape window moved up 1px


When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment.
If everyone is okay with this, I will update the revision with the optimized svgs.
I don't think that filling this space is useful.

Wed, Oct 16, 4:55 PM · Elisa, Frameworks

Sun, Oct 13

astippich added a comment to T5375: Add Management of Ratings for Tracks from Local Files.

just did it: https://invent.kde.org/kde/elisa/merge_requests/9

Sun, Oct 13, 12:01 PM · Elisa
astippich added a comment to T5375: Add Management of Ratings for Tracks from Local Files.

no, not yet. it will require Kf 5.64

Sun, Oct 13, 11:53 AM · Elisa
astippich claimed T5375: Add Management of Ratings for Tracks from Local Files.

https://invent.kde.org/astippich/elisa/tree/writeRating

Sun, Oct 13, 11:43 AM · Elisa
astippich moved T5375: Add Management of Ratings for Tracks from Local Files from Backlog to In Progress on the Elisa board.
Sun, Oct 13, 11:42 AM · Elisa
astippich closed T8196: KFileMetadata: String lists. How do clients cope? as Resolved.

Baloo now only outputs multiple entries in the property map instead of stringlist as of D19088 and clients all handle this since Applications 19.08

Sun, Oct 13, 11:41 AM · Dolphin, Elisa, Frameworks, Baloo
astippich added a comment to D24598: Update elisa icon.

Sun, Oct 13, 11:38 AM · Elisa, Frameworks
astippich updated the diff for D24598: Update elisa icon.
  • update
Sun, Oct 13, 11:37 AM · Elisa, Frameworks

Sat, Oct 12

astippich added inline comments to D23402: Show tracks with empty titles.
Sat, Oct 12, 6:55 PM · Elisa
astippich added a comment to D24598: Update elisa icon.

I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer.
I was unsatisfied with the icon and @mgallien agreed on some slight adjustments to the current one.
D12992 has been around for ages. I hope that this incremental update can be agreed upon faster and land for next frameworks release. Especially I find the "Elisa" text ugly and worth removing it quickly.

Sat, Oct 12, 6:44 PM · Elisa, Frameworks
astippich added a comment to D24598: Update elisa icon.

old icons
22px


48px

Sat, Oct 12, 6:30 PM · Elisa, Frameworks
astippich requested review of D24598: Update elisa icon.
Sat, Oct 12, 6:29 PM · Elisa, Frameworks
astippich added a comment to D19088: Use propertymap to store properties in Baloo::Result.

ping @bruns
are you going to land this series?

Sat, Oct 12, 4:30 PM · Baloo, Frameworks

Mon, Oct 7

astippich added inline comments to D23402: Show tracks with empty titles.
Mon, Oct 7, 6:15 PM · Elisa
astippich added a comment to D24100: add icons needed to handle the Windows Store publication.

Since D12992 seems to be stuck, I think we could improve the current icon a litte bit by removing the imho ugly "Elisa" text. What do you think?

Yes, it could be better this way. Do you plan to do it ?

Mon, Oct 7, 5:58 PM
astippich committed R286:494b068af264: Fix crash in writer collection and cleanup (authored by astippich).
Fix crash in writer collection and cleanup
Mon, Oct 7, 5:18 PM
astippich closed D23411: Fix crash in writer collection and cleanup.
Mon, Oct 7, 5:18 PM · Baloo, Frameworks

Sun, Oct 6

astippich updated the diff for D23411: Fix crash in writer collection and cleanup.
  • actually add test file for writercollection
Sun, Oct 6, 12:56 PM · Baloo, Frameworks
astippich added a comment to D20476: [WIP] starts to make the list of renderers available and use it to play music.

I think this will break the gstreamer backend

Sun, Oct 6, 11:39 AM
astippich added a comment to D23411: Fix crash in writer collection and cleanup.

ping!

Sun, Oct 6, 11:39 AM · Baloo, Frameworks
astippich updated the diff for D23411: Fix crash in writer collection and cleanup.
  • improve
Sun, Oct 6, 11:39 AM · Baloo, Frameworks
astippich committed R255:c6ac1306793a: Factor out dataTypes from databaseinterface (authored by astippich).
Factor out dataTypes from databaseinterface
Sun, Oct 6, 11:32 AM
astippich closed D23844: Factor out dataTypes from databaseinterface.
Sun, Oct 6, 11:32 AM · Elisa
astippich accepted D24231: avoid metadata persisting in header bar when missing from playing track.
Sun, Oct 6, 11:32 AM
astippich accepted D24100: add icons needed to handle the Windows Store publication.

Since D12992 seems to be stuck, I think we could improve the current icon a litte bit by removing the imho ugly "Elisa" text. What do you think?

Sun, Oct 6, 11:15 AM

Sep 14 2019

astippich added inline comments to D23402: Show tracks with empty titles.
Sep 14 2019, 12:55 PM · Elisa
astippich added a comment to D23411: Fix crash in writer collection and cleanup.

friendly ping. Since this solves a crash and I want to start using the writers in Elisa, I would like to have it rather sooner in a frameworks release and I'm away the next weeks

Sep 14 2019, 9:20 AM · Baloo, Frameworks
astippich updated the diff for D23844: Factor out dataTypes from databaseinterface.
  • rebase
Sep 14 2019, 8:11 AM · Elisa
astippich committed R255:ba273cdbf25d: fix trackmetadatamodeltest (authored by astippich).
fix trackmetadatamodeltest
Sep 14 2019, 8:06 AM
astippich committed R255:6ce0e91ed3b7: Fetch all metadata and fix metadata view (authored by astippich).
Fetch all metadata and fix metadata view
Sep 14 2019, 7:56 AM
astippich closed D23934: Fetch all metadata and fix metadata view.
Sep 14 2019, 7:56 AM · Elisa

Sep 13 2019

astippich committed R255:821f4660b10a: try to fix Qt 5.14 build (authored by astippich).
try to fix Qt 5.14 build
Sep 13 2019, 9:22 PM
astippich committed R255:fb10ed052317: add EditableMetaData to cmake (authored by astippich).
add EditableMetaData to cmake
Sep 13 2019, 9:22 PM
astippich committed R255:74ae8a7a81d5: silence one ebn warning (authored by astippich).
silence one ebn warning
Sep 13 2019, 9:22 PM
astippich requested review of D23934: Fetch all metadata and fix metadata view.
Sep 13 2019, 8:43 PM · Elisa

Sep 11 2019

astippich updated the diff for D23844: Factor out dataTypes from databaseinterface.
  • fixup
Sep 11 2019, 6:05 AM · Elisa

Sep 10 2019

astippich requested review of D23844: Factor out dataTypes from databaseinterface.
Sep 10 2019, 6:26 PM · Elisa

Sep 8 2019

astippich added a comment to D23280: fix issues related to radio and view details in playlist.

What is the status here?

Sep 8 2019, 12:41 PM
astippich added inline comments to D23411: Fix crash in writer collection and cleanup.
Sep 8 2019, 10:01 AM · Baloo, Frameworks
astippich added a comment to R169:f1884b125d77: use opacity to hide buttons that don't fit.

This causes https://bugs.kde.org/show_bug.cgi?id=411188
It breaks the InlineMessage positioning of the button when an action is added at least in Elisa.

Sep 8 2019, 9:57 AM

Sep 7 2019

astippich added inline comments to D23402: Show tracks with empty titles.
Sep 7 2019, 1:52 PM · Elisa
astippich updated the diff for D23402: Show tracks with empty titles.
  • deduce filename on demand
Sep 7 2019, 1:51 PM · Elisa
astippich added a comment to D23411: Fix crash in writer collection and cleanup.

ping

Sep 7 2019, 12:40 PM · Baloo, Frameworks
astippich accepted D19088: Use propertymap to store properties in Baloo::Result.
Sep 7 2019, 12:39 PM · Baloo, Frameworks
astippich accepted D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.

Since released versions of dolphin, baloo-widgets and elisa now actually cope with this case, I am no longer opposed merging this

Sep 7 2019, 12:38 PM · Baloo, Frameworks
astippich accepted D23541: fix some issues reported by clazy static analyser.
Sep 7 2019, 12:36 PM
astippich committed R255:2ccf00821edc: Rework the mediaplayercontrol (authored by astippich).
Rework the mediaplayercontrol
Sep 7 2019, 12:33 PM
astippich closed D22772: Rework the mediaplayercontrol.
Sep 7 2019, 12:33 PM · Elisa

Aug 27 2019

astippich added a comment to T7674: Add previous and next track indicator in the top bar.

The groundwork has now been done. On the c++ side, the manageheaderbar must be connected to the previousTrack and nextTrack signals of the mediaplaylist.
The information must be made available to qml similar to the currentTrack properties.
On the qml side, the HeaderBar must listen to the added properties and display them.

Aug 27 2019, 7:41 PM · Elisa
astippich triaged T7674: Add previous and next track indicator in the top bar as Wishlist priority.
Aug 27 2019, 7:38 PM · Elisa
astippich updated the diff for D22772: Rework the mediaplayercontrol.
  • rebase
Aug 27 2019, 7:01 PM · Elisa
astippich committed R255:54b2ad0c42cf: Add previous and next tracks to mediaplaylist (authored by astippich).
Add previous and next tracks to mediaplaylist
Aug 27 2019, 6:55 PM
astippich closed D22771: Add previous and next tracks to mediaplaylist.
Aug 27 2019, 6:55 PM · Elisa

Aug 26 2019

astippich committed R255:975dc0991b45: remove unrequired file (authored by astippich).
remove unrequired file
Aug 26 2019, 5:22 PM
astippich updated the diff for D22771: Add previous and next tracks to mediaplaylist.
  • rebase onto master
Aug 26 2019, 5:20 PM · Elisa
astippich added a comment to D23394: Add xattrfetchjob.

Hmm I don't know. IndexedDataRetriever is very different from FileFetchJob due to the usage of an external process.

Aug 26 2019, 4:41 PM · Baloo
astippich committed R286:4a90e8f348c2: Implement writing of images (authored by astippich).
Implement writing of images
Aug 26 2019, 4:39 PM
astippich closed D22922: Implement writing of images.
Aug 26 2019, 4:39 PM · Baloo, Frameworks
astippich committed R255:aa0cd61793b2: Rework shuffle handling (authored by astippich).
Rework shuffle handling
Aug 26 2019, 4:38 PM
astippich closed D22770: Rework shuffle handling.
Aug 26 2019, 4:38 PM · Elisa

Aug 25 2019

astippich committed R255:311c0a93710e: fix display of single/multi disc albums and cleanup (authored by astippich).
fix display of single/multi disc albums and cleanup
Aug 25 2019, 8:46 PM
astippich updated the diff for D23411: Fix crash in writer collection and cleanup.
  • further improvements
Aug 25 2019, 10:36 AM · Baloo, Frameworks

Aug 24 2019

astippich requested review of D23411: Fix crash in writer collection and cleanup.
Aug 24 2019, 8:24 PM · Baloo, Frameworks
astippich added a comment to D23402: Show tracks with empty titles.

Note that there are two issues with this patch:

  1. Loading the all tracks view seems to take longer
  2. Restoring of the playlist for tracks with empty title does not work
Aug 24 2019, 3:22 PM · Elisa
astippich requested review of D23402: Show tracks with empty titles.
Aug 24 2019, 3:17 PM · Elisa
astippich added a comment to D22770: Rework shuffle handling.

this should now apply cleanly

Aug 24 2019, 3:12 PM · Elisa
astippich committed R824:09e58fb9f63b: Unify inserting data between FileFetchJob and IndexedDataRetriever (authored by astippich).
Unify inserting data between FileFetchJob and IndexedDataRetriever
Aug 24 2019, 10:47 AM
astippich closed D23220: Unify inserting data between FileFetchJob and IndexedDataRetriever.
Aug 24 2019, 10:47 AM · Baloo
astippich added a comment to D23395: Retry manual metadata extraction when baloo returns an empty map.

Obvious downside is that resources are slightly wasted when there is no metadata

Aug 24 2019, 9:30 AM · Baloo
astippich added a dependent revision for D23394: Add xattrfetchjob: D23395: Retry manual metadata extraction when baloo returns an empty map.
Aug 24 2019, 9:29 AM · Baloo
astippich added a dependency for D23395: Retry manual metadata extraction when baloo returns an empty map: D23394: Add xattrfetchjob.
Aug 24 2019, 9:29 AM · Baloo
astippich requested review of D23395: Retry manual metadata extraction when baloo returns an empty map.
Aug 24 2019, 9:29 AM · Baloo
astippich requested review of D23394: Add xattrfetchjob.
Aug 24 2019, 9:21 AM · Baloo
astippich added a comment to D23364: Remove QtMultimedia as playback option.

That is a good idea, or at least basing the two implementation on a common base class. I'm currently planning to do other things first though, and I don't know when and if I have time to look into it

Aug 24 2019, 9:12 AM · Elisa

Aug 23 2019

astippich committed R255:0f7e1063e045: fix file browser delegate sizing (authored by astippich).
fix file browser delegate sizing
Aug 23 2019, 8:16 PM
astippich abandoned D23364: Remove QtMultimedia as playback option.

I see... I still think the situation is not optimal, but dropping Fedora is also not a good option.

Aug 23 2019, 8:00 PM · Elisa
astippich committed R255:bc33a3a6fa30: Avoid anchor loop in NavigationActionBar (authored by astippich).
Avoid anchor loop in NavigationActionBar
Aug 23 2019, 7:46 PM
astippich closed D23363: Avoid anchor loop in NavigationActionBar.
Aug 23 2019, 7:46 PM · Elisa

Aug 22 2019

astippich added a comment to D23364: Remove QtMultimedia as playback option.

There are RPM Fusion packages available, but from a quick glimpse I could not find packages directly from Fedora.
Debian(based), Arch and openSUSE etc seem to have packages available.

Aug 22 2019, 9:32 PM · Elisa
astippich updated the diff for D23364: Remove QtMultimedia as playback option.
  • cleanup unused AudioRole
Aug 22 2019, 9:03 PM · Elisa
astippich requested review of D23364: Remove QtMultimedia as playback option.
Aug 22 2019, 8:58 PM · Elisa
astippich closed D23359: Always open menu at the same position.
Aug 22 2019, 8:51 PM · Elisa
astippich committed R255:6296f888666f: Always open menu at the same position (authored by astippich).
Always open menu at the same position
Aug 22 2019, 8:51 PM
astippich added a comment to D23363: Avoid anchor loop in NavigationActionBar.

Don't know exactly why and when it started, but this bug makes Elisa quite unusable.

Aug 22 2019, 8:50 PM · Elisa
astippich requested review of D23363: Avoid anchor loop in NavigationActionBar.
Aug 22 2019, 8:49 PM · Elisa
astippich added a comment to D22922: Implement writing of images.

friendly ping

Aug 22 2019, 8:04 PM · Baloo, Frameworks
astippich requested review of D23359: Always open menu at the same position.
Aug 22 2019, 7:15 PM · Elisa
astippich accepted D23280: fix issues related to radio and view details in playlist.

Okay from my side if @jguidon's feedback is incorporated

Aug 22 2019, 6:29 PM
astippich updated the diff for D22772: Rework the mediaplayercontrol.
  • rebase
Aug 22 2019, 6:18 PM · Elisa
astippich updated the diff for D22771: Add previous and next tracks to mediaplaylist.
  • rebase
Aug 22 2019, 6:17 PM · Elisa
astippich updated the diff for D22770: Rework shuffle handling.
  • add space
  • rebase
Aug 22 2019, 6:16 PM · Elisa
astippich committed R255:9e28b0081335: Make MediaPlayList responsible for remaining tracks (authored by astippich).
Make MediaPlayList responsible for remaining tracks
Aug 22 2019, 6:12 PM
astippich closed D22769: Make MediaPlayList responsible for remaining tracks.
Aug 22 2019, 6:12 PM · Elisa
astippich committed R255:999d10eb8ff4: Cleanup main content view (authored by astippich).
Cleanup main content view
Aug 22 2019, 6:12 PM
astippich closed D23239: Cleanup main content view.
Aug 22 2019, 6:12 PM · Elisa