astippich (Alexander Stippich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2017, 1:49 PM (96 w, 5 d)
Availability
Available

Recent Activity

Tue, Aug 20

astippich requested changes to D23280: fix issues related to radio and view details in playlist.

deleting a radio is not possible anymore, and upon opening the metadata view qml shows some warnings

Tue, Aug 20, 5:41 AM

Sun, Aug 18

astippich updated the summary of D23240: Resolve symlink for file listener.
Sun, Aug 18, 6:54 PM · Elisa
astippich requested review of D23240: Resolve symlink for file listener.
Sun, Aug 18, 10:21 AM · Elisa
astippich requested review of D23239: Cleanup main content view.
Sun, Aug 18, 9:42 AM · Elisa
astippich committed R255:286e46a8b845: Remove all remnants of outdated notification system (authored by astippich).
Remove all remnants of outdated notification system
Sun, Aug 18, 9:20 AM
astippich closed D23223: Remove all remnants of outdated notification system.
Sun, Aug 18, 9:20 AM · Elisa
astippich updated the summary of D23223: Remove all remnants of outdated notification system.
Sun, Aug 18, 9:19 AM · Elisa

Sat, Aug 17

astippich requested review of D23223: Remove all remnants of outdated notification system.
Sat, Aug 17, 3:57 PM · Elisa
astippich committed R255:f9e3c546fd84: Revert "remove all remnants of outdated notification system" (authored by astippich).
Revert "remove all remnants of outdated notification system"
Sat, Aug 17, 3:52 PM
astippich added a reverting change for R255:43a65838ea1e: remove all remnants of outdated notification system: R255:f9e3c546fd84: Revert "remove all remnants of outdated notification system".
Sat, Aug 17, 3:52 PM
astippich committed R255:7cbe87e7b984: try to fix bsd test (authored by astippich).
try to fix bsd test
Sat, Aug 17, 3:45 PM
astippich committed R255:43a65838ea1e: remove all remnants of outdated notification system (authored by astippich).
remove all remnants of outdated notification system
Sat, Aug 17, 3:45 PM
astippich requested review of D23220: Unify inserting data between FileFetchJob and IndexedDataRetriever.
Sat, Aug 17, 2:06 PM · Baloo
astippich accepted D21525: Add support for radio streams.

From my point of view, this is mergeable. The trackmetadata stuff is not ideal yet, but this is something we can do later. We have to revisit this anyways when Elisa gets metadata editing.

Sat, Aug 17, 1:46 PM
astippich committed R255:cc7687e94c01: slightly adjust delegate height (authored by astippich).
slightly adjust delegate height
Sat, Aug 17, 1:44 PM
astippich committed R255:d9711eceb2bd: Fix old-style HighDPI problems in Tracks and GridBrowser (authored by mykolak).
Fix old-style HighDPI problems in Tracks and GridBrowser
Sat, Aug 17, 1:42 PM
astippich closed D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.
Sat, Aug 17, 1:42 PM · Elisa
astippich accepted D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Great, thanks again

Sat, Aug 17, 1:41 PM · Elisa
astippich committed R255:3606b2d729c2: small cleanup in ContentView (authored by astippich).
small cleanup in ContentView
Sat, Aug 17, 1:39 PM
astippich updated the diff for D22772: Rework the mediaplayercontrol.
  • rebase
Sat, Aug 17, 9:51 AM · Elisa
astippich updated the diff for D22771: Add previous and next tracks to mediaplaylist.
  • rebase
Sat, Aug 17, 9:50 AM · Elisa
astippich added a comment to D23206: Fix old-style HighDPI problems in Tracks and GridBrowser.

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

Sat, Aug 17, 9:33 AM · Elisa
astippich closed T7570: Investigate bugs where busy indicator spins forever as Resolved.

If you would like to start contributing, you may have a look at the Junior Jobs column of the tasks or try to fix some bugs at https://bugs.kde.org/buglist.cgi?component=general&list_id=1655384&product=elisa&resolution=---

Sat, Aug 17, 9:20 AM · Elisa

Thu, Aug 15

astippich added a comment to T7570: Investigate bugs where busy indicator spins forever.

Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?

Thu, Aug 15, 6:46 PM · Elisa
astippich updated the diff for D22770: Rework shuffle handling.
  • rebase
Thu, Aug 15, 6:44 PM · Elisa
astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • rebase on master
Thu, Aug 15, 6:43 PM · Elisa

Wed, Aug 14

astippich committed R255:3710916442cb: Use Qt's highDPI scaling (authored by astippich).
Use Qt's highDPI scaling
Wed, Aug 14, 6:28 PM
astippich closed T7530: High DPI support as Resolved by committing R255:3710916442cb: Use Qt's highDPI scaling.
Wed, Aug 14, 6:28 PM · Elisa
astippich closed D23132: Use Qt's highDPI scaling.
Wed, Aug 14, 6:28 PM · Elisa
astippich accepted D23007: Add expanding space between grid delegates as window is resized.
Wed, Aug 14, 6:27 PM
astippich added a comment to D23007: Add expanding space between grid delegates as window is resized.

Sorry, overlooked this one.
I quite like the behavior, but why do you limit it to 3 minimum items? This prohibits scaling the window to a small size and actually makes them items overlapped when forcing it into one corner of the screen.

Wed, Aug 14, 5:48 PM
astippich committed R255:51b654f03574: set implicit size for FlatButtonWithToolTip (authored by astippich).
set implicit size for FlatButtonWithToolTip
Wed, Aug 14, 5:43 PM
astippich committed R255:4e087ef44754: set vertical alignment for track import notification (authored by astippich).
set vertical alignment for track import notification
Wed, Aug 14, 5:39 PM
astippich added a comment to D23132: Use Qt's highDPI scaling.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Wed, Aug 14, 4:04 PM · Elisa

Tue, Aug 13

astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • fix code style again
Tue, Aug 13, 6:59 PM · Elisa
astippich moved T7530: High DPI support from Backlog to In Progress on the Elisa board.
Tue, Aug 13, 6:57 PM · Elisa
astippich committed R255:acba15b27d39: improve click on hamburger menu icon (authored by astippich).
improve click on hamburger menu icon
Tue, Aug 13, 6:56 PM
astippich committed R255:c7939481101e: Port the application menu to qqc2 (authored by astippich).
Port the application menu to qqc2
Tue, Aug 13, 6:55 PM
astippich closed D21943: Port the application menu to qqc2.
Tue, Aug 13, 6:55 PM · Elisa
astippich updated the diff for D22769: Make MediaPlayList responsible for remaining tracks.
  • fix code style and unrelated changes
  • fix remaining tracks label
Tue, Aug 13, 6:47 PM · Elisa
astippich added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

I don't want to remove ManageHeaderBar, on the contrary. This is a simplification and cleanup in order to easily extend it in the future after D22771, which is the goal of this whole series.
While working on it, I found that the ManageHeaderBar is needlessly entangled to the MediaPlayList by connecting to all of those signals, but which are mostly ignored. This is just because of the remaining tracks, for which the MediaPlayList is the correct place to retrieve the information.
By only connecting to the currentTrackChanged signal, the rest can be implemented much more easily. D22771 is working towards T7674

Tue, Aug 13, 6:41 PM · Elisa
astippich added a task to D23132: Use Qt's highDPI scaling: T7530: High DPI support.
Tue, Aug 13, 6:41 PM · Elisa
astippich added a revision to T7530: High DPI support: D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 6:41 PM · Elisa
astippich closed T7576: port to controls2 as Resolved.
Tue, Aug 13, 6:38 PM · Elisa
astippich added a comment to D23132: Use Qt's highDPI scaling.

Please note that I cannot test this myself due to lack of a high DPI monitor

Tue, Aug 13, 6:37 PM · Elisa
astippich requested review of D23132: Use Qt's highDPI scaling.
Tue, Aug 13, 6:37 PM · Elisa

Thu, Aug 8

astippich added a comment to D22772: Rework the mediaplayercontrol.

Thanks. Just wanted to make sure that it does not fall through

Thu, Aug 8, 10:14 AM · Elisa
astippich added a comment to D22499: fix the compilation album insertion.

The artists view is not working properly now with a fresh database. The artists are correctly shown. But when clicking on them no albums show up

Thu, Aug 8, 8:02 AM
astippich added a comment to D22772: Rework the mediaplayercontrol.

friendly ping @mgallien for the series

Thu, Aug 8, 7:55 AM · Elisa
astippich committed R255:3cd39553a49e: Use standard icon names (authored by astippich).
Use standard icon names
Thu, Aug 8, 7:53 AM
astippich closed D22921: Use standard icon names.
Thu, Aug 8, 7:53 AM
astippich added a comment to D22921: Use standard icon names.

Awesome, thanks!

Thu, Aug 8, 7:52 AM

Sun, Aug 4

astippich requested review of D22922: Implement writing of images.
Sun, Aug 4, 11:43 AM · Baloo, Frameworks
astippich requested review of D22921: Use standard icon names.
Sun, Aug 4, 10:40 AM

Sat, Aug 3

astippich updated the task description for T8176: explore using Kirigami.
Sat, Aug 3, 6:33 PM · Elisa
astippich placed T6293: Fix HeaderBar for missing animations up for grabs.
Sat, Aug 3, 6:33 PM · Elisa
astippich added a comment to D22499: fix the compilation album insertion.

It now shows duplicated artists in the albums view here

Sat, Aug 3, 3:00 PM
astippich updated the diff for D22772: Rework the mediaplayercontrol.
  • further simplify
Sat, Aug 3, 2:54 PM · Elisa
astippich committed R255:2a42ef196511: fix qml test (authored by astippich).
fix qml test
Sat, Aug 3, 2:51 PM
astippich committed R255:140db5359b3f: fix qml test failures and warnings (authored by astippich).
fix qml test failures and warnings
Sat, Aug 3, 8:15 AM
astippich committed R255:0d52e4f183ac: Fix setup of search shortcut (authored by astippich).
Fix setup of search shortcut
Sat, Aug 3, 7:57 AM
astippich closed D22781: Fix setup of search shortcut.
Sat, Aug 3, 7:57 AM · Elisa

Mon, Jul 29

astippich added inline comments to D21525: Add support for radio streams.
Mon, Jul 29, 3:23 PM

Sun, Jul 28

astippich added a comment to D21525: Add support for radio streams.

Nice progress, I think we are getting there!
Some comments inline which look like a lot, but most of them are style nitpicks

Sun, Jul 28, 2:01 PM
astippich committed R255:09e5ad06ecd8: Revert "make it possible to retrieve the embedded image data from the… (authored by astippich).
Revert "make it possible to retrieve the embedded image data from the…
Sun, Jul 28, 10:14 AM
astippich added a reverting change for R255:01478548e1bd: make it possible to retrieve the embedded image data from the filescanner: R255:09e5ad06ecd8: Revert "make it possible to retrieve the embedded image data from the….
Sun, Jul 28, 10:14 AM
astippich committed R255:01478548e1bd: make it possible to retrieve the embedded image data from the filescanner (authored by astippich).
make it possible to retrieve the embedded image data from the filescanner
Sun, Jul 28, 10:03 AM
astippich committed R255:ac19d4f97473: make EBN happy (authored by astippich).
make EBN happy
Sun, Jul 28, 9:29 AM
astippich added a comment to D22781: Fix setup of search shortcut.

It's amazing how you notice these little things :) thanks!

Sun, Jul 28, 9:12 AM · Elisa
astippich updated the diff for D22781: Fix setup of search shortcut.
  • force focus upon entering expandend state
Sun, Jul 28, 9:11 AM · Elisa

Sat, Jul 27

astippich requested review of D22781: Fix setup of search shortcut.
Sat, Jul 27, 3:51 PM · Elisa
astippich added inline comments to D21525: Add support for radio streams.
Sat, Jul 27, 12:06 PM
astippich triaged T7597: Add a progress bar under the current track in playlist as Wishlist priority.
Sat, Jul 27, 11:59 AM · Elisa
astippich moved T7576: port to controls2 from Backlog to In Progress on the Elisa board.
Sat, Jul 27, 11:57 AM · Elisa
astippich added a dependent revision for D22771: Add previous and next tracks to mediaplaylist: D22772: Rework the mediaplayercontrol.
Sat, Jul 27, 8:20 AM · Elisa
astippich added a dependency for D22772: Rework the mediaplayercontrol: D22771: Add previous and next tracks to mediaplaylist.
Sat, Jul 27, 8:20 AM · Elisa
astippich added a reviewer for D22771: Add previous and next tracks to mediaplaylist: mgallien.
Sat, Jul 27, 8:19 AM · Elisa
astippich added a reviewer for D22771: Add previous and next tracks to mediaplaylist: ngraham.
Sat, Jul 27, 8:19 AM · Elisa
astippich requested review of D22772: Rework the mediaplayercontrol.
Sat, Jul 27, 8:18 AM · Elisa
astippich added a project to D22771: Add previous and next tracks to mediaplaylist: Elisa.
Sat, Jul 27, 8:15 AM · Elisa
astippich requested review of D22771: Add previous and next tracks to mediaplaylist.
Sat, Jul 27, 8:15 AM · Elisa
astippich added a dependent revision for D22770: Rework shuffle handling: D22771: Add previous and next tracks to mediaplaylist.
Sat, Jul 27, 8:15 AM · Elisa
astippich updated the test plan for D22770: Rework shuffle handling.
Sat, Jul 27, 8:12 AM · Elisa
astippich requested review of D22770: Rework shuffle handling.
Sat, Jul 27, 8:11 AM · Elisa
astippich added a dependent revision for D22769: Make MediaPlayList responsible for remaining tracks: D22770: Rework shuffle handling.
Sat, Jul 27, 8:11 AM · Elisa
astippich requested review of D22769: Make MediaPlayList responsible for remaining tracks.
Sat, Jul 27, 8:08 AM · Elisa

Thu, Jul 25

astippich created T11281: year browser.
Thu, Jul 25, 7:23 PM · Elisa
astippich renamed T7883: genre browser from year and genre browser to genre browser.
Thu, Jul 25, 7:22 PM · Elisa
astippich added a comment to T6293: Fix HeaderBar for missing animations.

Is anybody working on this?

Thu, Jul 25, 7:21 PM · Elisa
astippich closed T7884: file browser as Resolved.
Thu, Jul 25, 7:18 PM · Elisa
astippich moved T7884: file browser from Backlog to Done on the Elisa board.
Thu, Jul 25, 7:18 PM · Elisa
astippich moved T8176: explore using Kirigami from Backlog to Junior Jobs on the Elisa board.
Thu, Jul 25, 7:17 PM · Elisa
astippich updated the task description for T8176: explore using Kirigami.
Thu, Jul 25, 7:17 PM · Elisa
astippich committed R255:463508b6e026: guard against invalid index (authored by astippich).
guard against invalid index
Thu, Jul 25, 5:18 PM
astippich committed R255:cd4c54c9ba11: Improve metadata scanning a bit (authored by astippich).
Improve metadata scanning a bit
Thu, Jul 25, 4:34 PM
astippich closed D22591: Improve metadata scanning a bit.
Thu, Jul 25, 4:34 PM · Elisa
astippich committed R255:3a240602846f: bump Qt version to 5.11 and remove unrequired code (authored by astippich).
bump Qt version to 5.11 and remove unrequired code
Thu, Jul 25, 4:33 PM
astippich closed D22741: bump Qt version to 5.11 and remove unrequired code.
Thu, Jul 25, 4:33 PM · Elisa
astippich added inline comments to D21525: Add support for radio streams.
Thu, Jul 25, 4:29 PM
astippich requested review of D22741: bump Qt version to 5.11 and remove unrequired code.
Thu, Jul 25, 4:23 PM · Elisa