astippich (Alexander Stippich)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2017, 1:49 PM (79 w, 4 h)
Availability
Available

Recent Activity

Tue, Apr 16

astippich requested review of D20608: Declare properties as meta type.
Tue, Apr 16, 5:47 PM · Baloo, Frameworks
astippich committed R286:4808263e41bf: Change properties attributes for consistency (authored by astippich).
Change properties attributes for consistency
Tue, Apr 16, 5:47 PM
astippich closed D20528: Change properties attributes for consistency.
Tue, Apr 16, 5:47 PM · Baloo, Frameworks
astippich committed R286:ffdee4011145: Handle variant list in formatting functions (authored by astippich).
Handle variant list in formatting functions
Tue, Apr 16, 5:46 PM
astippich closed D19445: Handle variant list in formatting functions.
Tue, Apr 16, 5:46 PM · Baloo, Frameworks
astippich committed R286:eb9b1ef9b30d: add license to python test files (authored by astippich).
add license to python test files
Tue, Apr 16, 5:46 PM
astippich closed D20529: add license to python test files.
Tue, Apr 16, 5:45 PM · Baloo, Frameworks
astippich updated the summary of D20531: Use artist when inserting a new album when album artist is not available.
Tue, Apr 16, 5:45 PM
astippich added a comment to D20531: Use artist when inserting a new album when album artist is not available.

This is used only when adding the album (insertAlbum function). It is not added to the tracks in the database, so I believe this change is correct. This is also done the same way a few lines above when checking for albums already in the database. I will change the title to make that clear.

Tue, Apr 16, 5:44 PM

Sun, Apr 14

astippich requested changes to D20526: fix extracting of some properties to match what was writen.

IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much.
How about inserting the TStringList entry by entry, without using the contactsFromString method? That would maintain the exact representation of metadata tags also for the baloo database.

When searching is left to baloo, it already splits up strings at whitespace etc., so you can provide the string as is.

Sun, Apr 14, 2:25 PM · Baloo, Frameworks
astippich added a comment to D20531: Use artist when inserting a new album when album artist is not available.

Elisa is barely usable for me without this as most of my files apparently do not have an album artist tag.
Please have a look if I correctly changed all the tests, especially the addTwoAlbumsWithDifferentPathsAndSameTracks test

Sun, Apr 14, 11:00 AM
astippich requested review of D20531: Use artist when inserting a new album when album artist is not available.
Sun, Apr 14, 10:59 AM
astippich accepted D20523: Remove a dead declaration.
Sun, Apr 14, 9:20 AM · Baloo
astippich requested review of D20529: add license to python test files.
Sun, Apr 14, 9:19 AM · Baloo, Frameworks
astippich added a dependent revision for D19445: Handle variant list in formatting functions: D20528: Change properties attributes for consistency.
Sun, Apr 14, 9:18 AM · Baloo, Frameworks
astippich added a dependency for D20528: Change properties attributes for consistency: D19445: Handle variant list in formatting functions.
Sun, Apr 14, 9:18 AM · Baloo, Frameworks
astippich requested review of D20528: Change properties attributes for consistency.
Sun, Apr 14, 9:18 AM · Baloo, Frameworks
astippich updated the diff for D20502: Check for string lists and multi-values in property map.
  • fix typo, check entry count
Sun, Apr 14, 9:10 AM
astippich added a comment to D20526: fix extracting of some properties to match what was writen.

IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much.
How about inserting the TStringList entry by entry, without using the contactsFromString method? That would maintain the exact representation of metadata tags also for the baloo database.

Sun, Apr 14, 9:07 AM · Baloo, Frameworks

Sat, Apr 13

astippich added a comment to T7878: Create or find Icon.

There is an icon in the git repo:

Sat, Apr 13, 12:55 PM · Baloo
astippich committed R286:ccc0e0b9238e: Force en locale for propertyinfotest (authored by astippich).
Force en locale for propertyinfotest
Sat, Apr 13, 12:52 PM
astippich closed D20358: Force en locale for propertyinfotest.
Sat, Apr 13, 12:52 PM · Baloo, Frameworks
astippich added a comment to D12222: baloodb: Use complete access filtering for all outputs.

@bruns this still applies cleanly to current master, do you think this and the dependent revision are still worth it to merge?

Sat, Apr 13, 11:09 AM · Baloo, Frameworks
astippich updated the diff for D20502: Check for string lists and multi-values in property map.
  • use localized strings
Sat, Apr 13, 9:25 AM
astippich requested review of D20502: Check for string lists and multi-values in property map.
Sat, Apr 13, 8:51 AM

Thu, Apr 11

astippich added a comment to D17500: Get mobipocket extractor up-to-date, but keep disabled.

And I propose a different one :)
IMHO bundling these two is sub-optimal as it creates an unnecessary dependency on kde-specific libraries and limits its deployment. To me, this is the equivalent of bundling the audio thumbnailer with taglib.

Thu, Apr 11, 5:44 PM · Baloo, Frameworks
astippich updated the diff for D20358: Force en locale for propertyinfotest.
  • add comment
Thu, Apr 11, 5:19 PM · Baloo, Frameworks
astippich added a comment to D17500: Get mobipocket extractor up-to-date, but keep disabled.

It creates a dependency loop as you pointed out in the first comment

Thu, Apr 11, 5:16 PM · Baloo, Frameworks
astippich accepted D20459: [balooctl] Extend options help text, improve error checking.
Thu, Apr 11, 5:13 PM · Baloo, Frameworks

Wed, Apr 10

astippich updated the diff for D19445: Handle variant list in formatting functions.
  • remove unrequired parenthesis
Wed, Apr 10, 5:29 PM · Baloo, Frameworks
astippich added a comment to D17500: Get mobipocket extractor up-to-date, but keep disabled.

The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think a KIO dependency for such a library is inconvenient.

qmobipocket only depends on Qt::Core and Qt::Gui.

Wed, Apr 10, 5:25 PM · Baloo, Frameworks
astippich committed R824:22ea087cec1a: Display metadata information in case only basic indexing is enabled (authored by astippich).
Display metadata information in case only basic indexing is enabled
Wed, Apr 10, 5:24 PM
astippich closed D20412: Display metadata information in case only basic indexing is enabled.
Wed, Apr 10, 5:24 PM · Baloo
astippich added a comment to D20358: Force en locale for propertyinfotest.

It is a documentation bug.

Wed, Apr 10, 5:23 PM · Baloo, Frameworks

Tue, Apr 9

astippich committed R286:ff59f5c539e1: add missing mimetype to taglib writer (authored by astippich).
add missing mimetype to taglib writer
Tue, Apr 9, 6:54 PM
astippich committed R286:a17bdf0b417b: remove unnecessary parenthesis (authored by astippich).
remove unnecessary parenthesis
Tue, Apr 9, 6:54 PM
astippich added a comment to D17500: Get mobipocket extractor up-to-date, but keep disabled.

The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think a KIO dependency for such a library is inconvenient.

Tue, Apr 9, 6:36 PM · Baloo, Frameworks
astippich updated the summary of D17500: Get mobipocket extractor up-to-date, but keep disabled.
Tue, Apr 9, 6:08 PM · Baloo, Frameworks
astippich updated the diff for D17500: Get mobipocket extractor up-to-date, but keep disabled.
  • rebase and update
  • update test
  • disable mobi extractor
Tue, Apr 9, 6:07 PM · Baloo, Frameworks
astippich added inline comments to D20412: Display metadata information in case only basic indexing is enabled.
Tue, Apr 9, 5:59 PM · Baloo
astippich updated the diff for D20412: Display metadata information in case only basic indexing is enabled.
  • remove superfluous check
Tue, Apr 9, 5:59 PM · Baloo
astippich committed R824:170a52b0baae: Use helper from KFileMetaData to detect mimetype (authored by astippich).
Use helper from KFileMetaData to detect mimetype
Tue, Apr 9, 5:55 PM
astippich closed D20411: Use helper from KFileMetaData to detect mimetype.
Tue, Apr 9, 5:55 PM · Baloo
astippich added a comment to D20358: Force en locale for propertyinfotest.

https://bugreports.qt.io/browse/QTBUG-75069

Tue, Apr 9, 5:54 PM · Baloo, Frameworks
astippich added a comment to D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code..

windows build fails
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/143/console

Tue, Apr 9, 5:53 PM · Baloo, Frameworks
astippich added a comment to D19445: Handle variant list in formatting functions.

ping

Tue, Apr 9, 4:25 PM · Baloo, Frameworks
astippich requested review of D20412: Display metadata information in case only basic indexing is enabled.
Tue, Apr 9, 4:23 PM · Baloo
astippich requested review of D20411: Use helper from KFileMetaData to detect mimetype.
Tue, Apr 9, 4:19 PM · Baloo

Mon, Apr 8

astippich added a comment to D20358: Force en locale for propertyinfotest.

There already was a bug report some time ago
https://bugreports.qt.io/browse/QTBUG-15488

Mon, Apr 8, 6:04 PM · Baloo, Frameworks
astippich updated the diff for D20358: Force en locale for propertyinfotest.
  • use enum
Mon, Apr 8, 6:04 PM · Baloo, Frameworks

Sun, Apr 7

astippich added a comment to D11882: autotests: Use built executable instead of installed.

@bruns this diff tries to accomplish the same as D19268, and can be closed, right?

Sun, Apr 7, 7:35 PM · Baloo
astippich accepted D20345: Use compact Json format when converting query URLs.
Sun, Apr 7, 7:02 PM · Baloo, Frameworks
astippich accepted D20364: Dont add default valued date filters to json.
Sun, Apr 7, 6:52 PM · Baloo, Frameworks
astippich added inline comments to D20358: Force en locale for propertyinfotest.
Sun, Apr 7, 6:44 PM · Baloo, Frameworks
astippich committed R286:0cfa32c2a376: Test all extractors with strict mime type (authored by astippich).
Test all extractors with strict mime type
Sun, Apr 7, 6:44 PM
astippich closed D20360: Test all extractors with strict mime type.
Sun, Apr 7, 6:44 PM · Baloo, Frameworks
astippich accepted D20328: [balooshow] Do not print a bogus warning for a non-indexed file.

only one minor nitpick

Sun, Apr 7, 6:40 PM · Baloo, Frameworks
astippich committed R286:ca4ae3d5f3ba: Fix typo (authored by astippich).
Fix typo
Sun, Apr 7, 5:00 PM
astippich committed R286:65b8e31d97a8: fix warnings (authored by astippich).
fix warnings
Sun, Apr 7, 4:30 PM
astippich requested review of D20360: Test all extractors with strict mime type.
Sun, Apr 7, 4:29 PM · Baloo, Frameworks
astippich closed D20120: Use new mimetype helper in taglib extractor test.
Sun, Apr 7, 4:28 PM · Baloo, Frameworks
astippich committed R286:0d9aebdd05b5: Use new mimetype helper in taglib extractor test (authored by astippich).
Use new mimetype helper in taglib extractor test
Sun, Apr 7, 4:28 PM
astippich added a comment to T5375: Add Management of Ratings for Tracks from Local Files.

FYI, writing rating information was added to KF 5.57 via the TagLib writer plugin

Sun, Apr 7, 4:16 PM · Elisa
astippich added a comment to D20120: Use new mimetype helper in taglib extractor test.

ping

Sun, Apr 7, 4:14 PM · Baloo, Frameworks
astippich accepted D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code..

Still kind of hard to read, especially on phabricator. Anyway, a definite improvement.
Untested on anything besides linux

Sun, Apr 7, 4:13 PM · Baloo, Frameworks
astippich requested review of D20359: Fix rating write for mp4 in newer TagLib versions.
Sun, Apr 7, 4:07 PM · Baloo, Frameworks
astippich requested review of D20358: Force en locale for propertyinfotest.
Sun, Apr 7, 4:05 PM · Baloo, Frameworks

Thu, Apr 4

astippich accepted D20033: Default string formatting test to C locale, add localized run.

works nicely!

Thu, Apr 4, 5:21 PM · Baloo, Frameworks
astippich added inline comments to D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.
Thu, Apr 4, 5:07 PM · Baloo, Frameworks
astippich committed R286:452edb1b4c80: Cleanup taglib writer test (authored by astippich).
Cleanup taglib writer test
Thu, Apr 4, 5:03 PM
astippich closed D18665: Cleanup taglib writer test.
Thu, Apr 4, 5:03 PM · Baloo, Frameworks
astippich committed R286:8e79f7ce2b7c: Implement support for writing rating information for taglib writer (authored by astippich).
Implement support for writing rating information for taglib writer
Thu, Apr 4, 5:01 PM
astippich closed D18604: Implement support for writing rating information for taglib writer.
Thu, Apr 4, 5:01 PM · Baloo, Frameworks
astippich closed D18603: Implement more tags for taglib writer.
Thu, Apr 4, 4:58 PM · Baloo, Frameworks
astippich committed R286:926c70460edc: Implement more tags for taglib writer (authored by astippich).
Implement more tags for taglib writer
Thu, Apr 4, 4:58 PM
astippich committed R286:982ebe58b3c8: Rewrite taglib writer to use property interface (authored by astippich).
Rewrite taglib writer to use property interface
Thu, Apr 4, 4:52 PM
astippich closed D18601: Rewrite taglib writer to use property interface.
Thu, Apr 4, 4:52 PM · Baloo, Frameworks
astippich closed D20121: Test ffmpeg extractor using mime type helper.
Thu, Apr 4, 4:52 PM · Baloo, Frameworks
astippich committed R286:25eca3185ffa: Test ffmpeg extractor using mime type helper (authored by astippich).
Test ffmpeg extractor using mime type helper
Thu, Apr 4, 4:52 PM

Wed, Apr 3

astippich updated the diff for D19445: Handle variant list in formatting functions.
  • rebase on master
Wed, Apr 3, 6:13 AM · Baloo, Frameworks
astippich added a comment to D20219: Propose Stefan Bruns as KFileMetaData maintainer.

I think @bruns is much more qualified than me as a maintainer as I lack overall experience in programming. He still finds wrong stuff in almost any revision of mine :)
also +1 for baloo

Wed, Apr 3, 5:36 AM · Baloo, Frameworks

Tue, Apr 2

astippich updated the diff for D20121: Test ffmpeg extractor using mime type helper.
  • add friend and use member function
Tue, Apr 2, 7:15 PM · Baloo, Frameworks
astippich updated the diff for D18604: Implement support for writing rating information for taglib writer.
  • cleanup and formatting
Tue, Apr 2, 6:40 PM · Baloo, Frameworks
astippich added a comment to D20046: Verify mimetypes for all existing sample files, add some more.

This causes one test failure on FreeBSD:
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/51/

Tue, Apr 2, 6:32 PM · Baloo, Frameworks
astippich committed R286:1ac4253f3cf0: Safeguard against invalid files (authored by astippich).
Safeguard against invalid files
Tue, Apr 2, 6:28 PM
astippich closed D20082: Safeguard against invalid files.
Tue, Apr 2, 6:28 PM · Baloo, Frameworks

Sun, Mar 31

astippich added a comment to D20138: Add a helper to determine actual supported parent mime type.

Oh, another idea: Cannot this be used to determine that the extractor supports the inheriting mimetype as required in D20121? Would need to be public for this, though, or the test needs to be made a friend class.

Sun, Mar 31, 1:08 PM · Baloo, Frameworks
astippich accepted D20138: Add a helper to determine actual supported parent mime type.

Forget my comment, I thought it would be possible to share some code with the ExtractorCollection, but the implementation is too different

Sun, Mar 31, 12:43 PM · Baloo, Frameworks
astippich updated the diff for D18604: Implement support for writing rating information for taglib writer.
  • rebase
  • simplify id3 rating to array
Sun, Mar 31, 12:26 PM · Baloo, Frameworks
astippich updated the diff for D18603: Implement more tags for taglib writer.
  • rebase
Sun, Mar 31, 11:58 AM · Baloo, Frameworks
astippich updated the diff for D18601: Rewrite taglib writer to use property interface.
  • check that file is valid
  • rebase
Sun, Mar 31, 11:56 AM · Baloo, Frameworks
astippich added a comment to D20082: Safeguard against invalid files.

ping. I would like to land this for KF 5.57 to fix crashes in the taglib extractors because of invalid files once and for all.

Sun, Mar 31, 11:41 AM · Baloo, Frameworks
astippich added a comment to D19445: Handle variant list in formatting functions.

ping. This will be beneficial for handling lists regardless of the discussion in D19087

Sun, Mar 31, 11:40 AM · Baloo, Frameworks
astippich added a comment to D20138: Add a helper to determine actual supported parent mime type.

Shouldn't this go into MimeUtils?

Sun, Mar 31, 11:38 AM · Baloo, Frameworks
astippich updated subscribers of D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.

My main concern is that this changes current behavior and as such is not backwards compatible. The rest is a bonus.
That is why my plan was to make the extractors output (string-)lists as outlined in T8196 (this task has been there for quite a while, feedback would have been nice).
This way, current behavior can be preserved while also fixing all bugs with multi-value properties.
If changing this behavior is okay, then you should at least post patches that adapt all clients. I know of Baloo-widgets, Dolphin and Elisa.
But there will be combinations of frameworks and applications that will not work correctly for multi-value properties.
What do others think of this? @mgallien?

Sun, Mar 31, 11:37 AM · Baloo, Frameworks

Sat, Mar 30

astippich added inline comments to D20121: Test ffmpeg extractor using mime type helper.
Sat, Mar 30, 10:01 AM · Baloo, Frameworks
astippich requested review of D20121: Test ffmpeg extractor using mime type helper.
Sat, Mar 30, 9:53 AM · Baloo, Frameworks
astippich requested review of D20120: Use new mimetype helper in taglib extractor test.
Sat, Mar 30, 9:30 AM · Baloo, Frameworks
astippich added a comment to D18604: Implement support for writing rating information for taglib writer.

After some thinking, I have split up the function for writing specific Ape and Vorbis tags, as many more tags like "Opus" etc. are in use for Vorbis tags and not for Ape, and can be easily added this way. I am still using the property map, though.
Are you fine with this?

Sat, Mar 30, 9:12 AM · Baloo, Frameworks
astippich updated the diff for D18604: Implement support for writing rating information for taglib writer.
  • split ape and vorbis tag writing functions
Sat, Mar 30, 9:09 AM · Baloo, Frameworks