- User Since
- Oct 14 2017, 1:49 PM (60 w, 4 d)
I was recently wondering if this is actually desired behavior. Right now it is definitely required since KFileMetaData wrongly outputs QStrings instead of a QStringList, but when this is fixed, this behavior should be removed imho. Otherwise, querying metadata via KFileMetaData and via Baloo differs in output, which it shouldn't.
Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :(
Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail extractor actually be part of kio-extras? Seems quite kio-specific, and a quick look at lxr didn't reveal any usages of the thumbnailer.
Tue, Dec 11
- add missing test file
I was unable to get a version check running with cmake, any help is appreciated
any further comments/objections?
- updates for master
Thu, Dec 6
Well, if it is not even signaled via ctest, that's pretty bad, I agree
- use QFAIL
- rephase description of TermGenerator
Wed, Dec 5
- new lines, handle dataPosition == -1
Tue, Dec 4
Thanks for your patience :)
- remove docstring for reimplemented functions
I'm wondering, anything else to do if I add a new dependency to KFileMetaData?
- small fixes
Mon, Dec 3
Sun, Dec 2
- more adjustments
Unfortunately I missed the deadline with this one for Applications 18.12. I don't know the exact criteria if this is acceptable for stable or not.
anyone? I would like to extend the support to the same file types as supported by the taglibextractor
This one doesn't apply, looks like D17824 is a dependency?
- small fixes
- implement feedback
Really just a cosmetic change for consistency, if you don't want it in, I'm fine with dropping it
- update strings for image orientation
- use param
Didn't found what I wanted to find, but since the code is there we can add it.
I had the impression that I have to read a lot of code just to know which variable does what, so I wrote some simple documentation.
Please check if I got anything wrong.
- only add uints for now
Sat, Dec 1
Okay, so there is more work to do for floats. What about then reducing this patch to uints for now, and doubles are added when everything else is in place?
I have something in the pipeline for the Result class, which I added for figuring out how string lists are handled, I can probably post that tomorrow. I could then extend the test for floats