astippich (Alexander Stippich)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2017, 1:49 PM (136 w, 2 d)
Availability
Available

Recent Activity

Mon, May 4

astippich closed D29200: test the extractNothing flag.
Mon, May 4, 5:40 PM · Baloo, Frameworks
astippich committed R286:5e1ed919bdf6: test the extractNothing flag (authored by astippich).
test the extractNothing flag
Mon, May 4, 5:40 PM
astippich committed R286:538c34b58057: honor the extractMetaData flag (authored by astippich).
honor the extractMetaData flag
Mon, May 4, 5:36 PM
astippich closed D29199: honor the extractMetaData flag.
Mon, May 4, 5:36 PM · Baloo, Frameworks

Sun, Apr 26

astippich updated the diff for D29199: honor the extractMetaData flag.
  • use continue
Sun, Apr 26, 4:55 PM · Baloo, Frameworks
astippich updated the diff for D29199: honor the extractMetaData flag.
  • fix another stupid mistake
Sun, Apr 26, 4:50 PM · Baloo, Frameworks
astippich added inline comments to D29199: honor the extractMetaData flag.
Sun, Apr 26, 3:11 PM · Baloo, Frameworks
astippich updated the diff for D29199: honor the extractMetaData flag.
  • more fixes
Sun, Apr 26, 3:10 PM · Baloo, Frameworks
astippich added inline comments to D29199: honor the extractMetaData flag.
Sun, Apr 26, 2:47 PM · Baloo, Frameworks
astippich updated the diff for D29199: honor the extractMetaData flag.
  • implement review
Sun, Apr 26, 2:47 PM · Baloo, Frameworks
astippich added a dependent revision for D29199: honor the extractMetaData flag: D29200: test the extractNothing flag.
Sun, Apr 26, 1:18 PM · Baloo, Frameworks
astippich requested review of D29200: test the extractNothing flag.
Sun, Apr 26, 1:18 PM · Baloo, Frameworks
astippich requested review of D29199: honor the extractMetaData flag.
Sun, Apr 26, 1:16 PM · Baloo, Frameworks

Apr 21 2020

astippich added a comment to D20739: Handle multiple entries in map.

That said, I think the issue is in this line

Apr 21 2020, 10:52 AM · Baloo

Apr 19 2020

astippich removed a watcher for Elisa: astippich.
Apr 19 2020, 6:55 PM
astippich removed a member for Elisa: astippich.
Apr 19 2020, 6:55 PM
astippich removed a reviewer for D28980: Revert "add Baloo DBus signals for moved or removed files": astippich.
Apr 19 2020, 6:54 PM · Baloo, Frameworks
astippich abandoned D25515: Only extract lyrics when the plain text flag is set.
Apr 19 2020, 6:51 PM · Baloo, Frameworks
astippich abandoned D25679: Implement writing of front cover in taglibwriter.
Apr 19 2020, 6:51 PM · Baloo, Frameworks
astippich abandoned D25518: Extract front cover in the taglib extractor.
Apr 19 2020, 6:51 PM · Baloo, Frameworks
astippich abandoned D25517: Add an option to extract image data and add front cover property.

Okay, since there seems to be no interest at all as even a short reply is not given, I am done here

Apr 19 2020, 6:51 PM · Baloo, Frameworks

Apr 12 2020

astippich committed R293:19e71b3e4a5f: rename and export newBatchTime signal in filecontentindexer (authored by astippich).
rename and export newBatchTime signal in filecontentindexer
Apr 12 2020, 8:20 AM
astippich closed D28682: rename and export newBatchTime signal in filecontentindexer.
Apr 12 2020, 8:20 AM · Baloo, Frameworks
astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

Thanks

Apr 12 2020, 8:18 AM · Baloo, Frameworks
astippich updated the summary of D28682: rename and export newBatchTime signal in filecontentindexer.
Apr 12 2020, 8:17 AM · Baloo, Frameworks
astippich updated the diff for D28682: rename and export newBatchTime signal in filecontentindexer.
  • implement feedback
Apr 12 2020, 8:14 AM · Baloo, Frameworks

Apr 10 2020

astippich retitled D28682: rename and export newBatchTime signal in filecontentindexer from export done signal in filecontentindexer to rename and export done signal in filecontentindexer.
Apr 10 2020, 8:00 AM · Baloo, Frameworks
astippich updated the diff for D28682: rename and export newBatchTime signal in filecontentindexer.
  • rename signal
Apr 10 2020, 7:59 AM · Baloo, Frameworks

Apr 9 2020

astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

How about committedBatch so that it's clear that they have been committed to the database?

Apr 9 2020, 7:31 PM · Baloo, Frameworks
astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call.

Apr 9 2020, 4:15 PM · Baloo, Frameworks

Apr 8 2020

astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.

This is the reason why it is so slow in Elisa?

Apr 8 2020, 6:09 PM · Baloo, Frameworks
astippich requested review of D28682: rename and export newBatchTime signal in filecontentindexer.
Apr 8 2020, 4:58 PM · Baloo, Frameworks

Mar 22 2020

astippich committed R255:66ab5d0ee8df: add icons to dialogs (authored by astippich).
add icons to dialogs
Mar 22 2020, 1:30 PM
astippich placed T5375: Add Management of Ratings for Tracks from Local Files up for grabs.
Mar 22 2020, 12:15 PM · Elisa
astippich added a comment to D25517: Add an option to extract image data and add front cover property.

Due to the recent circumstances I will probably not implement the support in Elisa, so I won't land this unless @bruns explicitly is okay with it (I still think this is an improvement over the status quo).

Mar 22 2020, 12:15 PM · Baloo, Frameworks

Mar 19 2020

astippich committed R255:2c1b8f1677cc: remove check for stringlist (authored by astippich).
remove check for stringlist
Mar 19 2020, 5:59 PM

Mar 18 2020

astippich updated the diff for D25679: Implement writing of front cover in taglibwriter.
  • adapt to changes
  • use QMimeDatabase
Mar 18 2020, 7:07 PM · Baloo, Frameworks
astippich updated the diff for D25518: Extract front cover in the taglib extractor.
  • adapt to changes
Mar 18 2020, 6:44 PM · Baloo, Frameworks
astippich added a comment to D25517: Add an option to extract image data and add front cover property.

Since I got one accept and no other response, I will merge on the weekend

Mar 18 2020, 6:43 PM · Baloo, Frameworks
astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
  • fix label comment
  • tweaks
  • rename flag to ImageData
  • adress review comments
  • udpate since tag
  • update since tag
Mar 18 2020, 6:43 PM · Baloo, Frameworks

Mar 16 2020

astippich added a comment to D25517: Add an option to extract image data and add front cover property.

ping @bruns
this has now been open and unanswered for month!
Same for the dependent patches

Mar 16 2020, 4:38 PM · Baloo, Frameworks

Mar 14 2020

astippich committed R255:dfe1d97ccf31: fix margin in grid view with scrollbar (authored by astippich).
fix margin in grid view with scrollbar
Mar 14 2020, 7:56 PM
astippich committed R255:16b3d8c7de11: use standard icon names (authored by astippich).
use standard icon names
Mar 14 2020, 10:42 AM
astippich committed R255:98e80b4fa457: minor filescanner optimizations (authored by astippich).
minor filescanner optimizations
Mar 14 2020, 10:38 AM
astippich committed R255:345a9faaa6cf: delete unused file (authored by astippich).
delete unused file
Mar 14 2020, 10:26 AM

Mar 11 2020

astippich committed R255:5c4b45a0a88f: prepare metadata writing (authored by astippich).
prepare metadata writing
Mar 11 2020, 6:32 PM

Mar 10 2020

astippich committed R255:f5078aa71c19: consistently name it shuffle (authored by astippich).
consistently name it shuffle
Mar 10 2020, 8:22 PM

Mar 8 2020

astippich committed R255:f21051705b2e: fix and improve toggling shuffle mode (authored by astippich).
fix and improve toggling shuffle mode
Mar 8 2020, 2:39 PM
astippich committed R255:f385349d4ccb: Never emit dataChanged signal when inserting new entries (authored by astippich).
Never emit dataChanged signal when inserting new entries
Mar 8 2020, 8:47 AM

Mar 7 2020

astippich committed R255:6026c09ec5a3: wait for data changed in test (authored by astippich).
wait for data changed in test
Mar 7 2020, 7:10 PM
astippich committed R255:189712b9b316: fix enqueue all from album view (authored by astippich).
fix enqueue all from album view
Mar 7 2020, 12:19 PM
astippich committed R255:e44be6a1b999: wait for test until data is updated (authored by astippich).
wait for test until data is updated
Mar 7 2020, 11:15 AM
astippich committed R255:0c629f46eb9c: try to fix test (authored by astippich).
try to fix test
Mar 7 2020, 11:02 AM
astippich committed R255:374f754f8c4b: remove more leftover debug output (authored by astippich).
remove more leftover debug output
Mar 7 2020, 9:55 AM
astippich committed R255:3c925162ec8c: New shuffle mode for playlist (authored by astippich).
New shuffle mode for playlist
Mar 7 2020, 9:42 AM
astippich committed R255:6700c9a2904e: remove leftover debug (authored by astippich).
remove leftover debug
Mar 7 2020, 9:42 AM

Mar 3 2020

astippich added a comment to D27767: [ModifiedFileIndexer] Correct time checks for new files.

I would like to request a clear answer for https://phabricator.kde.org/D25517 once again

Mar 3 2020, 7:01 PM · Baloo, Frameworks
astippich accepted D27767: [ModifiedFileIndexer] Correct time checks for new files.
Mar 3 2020, 6:59 PM · Baloo, Frameworks
astippich accepted D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required.
Mar 3 2020, 6:56 PM · Baloo, Frameworks

Mar 1 2020

astippich added inline comments to D27767: [ModifiedFileIndexer] Correct time checks for new files.
Mar 1 2020, 6:09 PM · Baloo, Frameworks
astippich committed R255:8368d8765f11: unify animations when showing/hiding items in the content view (authored by astippich).
unify animations when showing/hiding items in the content view
Mar 1 2020, 6:09 PM
astippich committed R255:e3864b151828: use duration values provided from Kirigami (authored by astippich).
use duration values provided from Kirigami
Mar 1 2020, 6:09 PM

Feb 29 2020

astippich added a comment to D25517: Add an option to extract image data and add front cover property.

Ping! At least a reply would be nice

Feb 29 2020, 10:34 AM · Baloo, Frameworks
astippich committed R255:d7ec61c9ea9f: Use kirigami's gridUnit for text height throughout Elisa (authored by astippich).
Use kirigami's gridUnit for text height throughout Elisa
Feb 29 2020, 10:11 AM

Feb 27 2020

astippich committed R255:b285d75daebe: fix margins when view selector is collapsed (authored by astippich).
fix margins when view selector is collapsed
Feb 27 2020, 7:40 PM
astippich committed R255:73c6211465a7: replace view selector delegates with kirigami (authored by astippich).
replace view selector delegates with kirigami
Feb 27 2020, 7:40 PM

Feb 25 2020

astippich committed R255:9fc378078570: Derive layout margins based on kirigami values (authored by astippich).
Derive layout margins based on kirigami values
Feb 25 2020, 6:52 PM
astippich committed R255:169e301bfff4: remove uneeded function (authored by astippich).
remove uneeded function
Feb 25 2020, 5:01 PM

Feb 17 2020

astippich committed R255:404cee858aee: fix qml test (authored by astippich).
fix qml test
Feb 17 2020, 8:59 PM
astippich committed R255:a85b1a683019: replace hardoced values with kirigami ones (authored by astippich).
replace hardoced values with kirigami ones
Feb 17 2020, 8:45 PM
astippich committed R255:2d6fc872557d: Add ImageWithFallback component and use it for cover art (authored by astippich).
Add ImageWithFallback component and use it for cover art
Feb 17 2020, 8:45 PM

Feb 16 2020

astippich committed R255:a03fdc9e1dd6: fix simple play list view (authored by astippich).
fix simple play list view
Feb 16 2020, 11:57 AM
astippich committed R255:100d4cfb0def: reuse the persistent state to restore playlist and cleanup (authored by astippich).
reuse the persistent state to restore playlist and cleanup
Feb 16 2020, 10:47 AM
astippich committed R255:e19a783e5bd4: rework undo logic (authored by astippich).
rework undo logic
Feb 16 2020, 10:47 AM
astippich committed R255:310cf1181f3d: rename signals for clarification (authored by astippich).
rename signals for clarification
Feb 16 2020, 10:47 AM
astippich committed R255:4cbdb6b6b74e: remove unused function (authored by astippich).
remove unused function
Feb 16 2020, 10:47 AM
astippich committed R255:8e1c7f3fa600: remove unused function (authored by astippich).
remove unused function
Feb 16 2020, 10:47 AM
astippich committed R255:6b2b9b038b03: cleanup and simplify mediaplaylist (authored by astippich).
cleanup and simplify mediaplaylist
Feb 16 2020, 10:47 AM
astippich committed R255:757dff823e1c: remove special handling of radios and use generic functions, remove unused… (authored by astippich).
remove special handling of radios and use generic functions, remove unused…
Feb 16 2020, 10:47 AM

Feb 11 2020

astippich committed R255:f807e02a287d: compute playlist delegate height based on font size (authored by astippich).
compute playlist delegate height based on font size
Feb 11 2020, 5:42 PM
astippich committed R255:e110db887c25: fix heights (authored by astippich).
fix heights
Feb 11 2020, 5:42 PM

Feb 9 2020

astippich added a comment to D25517: Add an option to extract image data and add front cover property.

Where are we with this? @bruns are you accepting the proposed solution or do you reject it completely?
I think it is at least way better than the current solution and maintains current API.
A larger refactoring could be done for KF6

Feb 9 2020, 4:01 PM · Baloo, Frameworks
astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
  • udpate since tag
Feb 9 2020, 4:00 PM · Baloo, Frameworks

Feb 8 2020

astippich committed R255:3b369fa63354: Merge branch 'release/19.12' (authored by astippich).
Merge branch 'release/19.12'
Feb 8 2020, 12:01 PM

Feb 4 2020

astippich committed R255:0b2c4be90bcb: Rework size calculation for list delegates and cleanup (authored by astippich).
Rework size calculation for list delegates and cleanup
Feb 4 2020, 4:19 PM
astippich committed R255:ec5197521066: limit the rate with which progress is sent via MPRIS (authored by astippich).
limit the rate with which progress is sent via MPRIS
Feb 4 2020, 4:19 PM

Feb 2 2020

astippich committed R255:ecbe3f75a5e2: fix grid delegate test (authored by astippich).
fix grid delegate test
Feb 2 2020, 4:52 PM
astippich committed R255:6c999209b0ba: rework sizing of the grid delegate (authored by astippich).
rework sizing of the grid delegate
Feb 2 2020, 4:34 PM
astippich committed R255:09855fefbe09: consolidate the interface between file and baloo indexers (authored by astippich).
consolidate the interface between file and baloo indexers
Feb 2 2020, 2:18 PM

Jan 29 2020

astippich committed R255:7a48106b0ff3: Update README.md (authored by astippich).
Update README.md
Jan 29 2020, 8:43 PM

Jan 26 2020

astippich committed R255:8e1967d7a910: implement loading tracks from genre (authored by astippich).
implement loading tracks from genre
Jan 26 2020, 9:04 PM
astippich committed R255:1691274e52b8: disable playlist animations to fix display corruption (authored by astippich).
disable playlist animations to fix display corruption
Jan 26 2020, 8:20 PM

Jan 25 2020

astippich added a comment to D25517: Add an option to extract image data and add front cover property.

friendly ping for the series

Jan 25 2020, 10:23 AM · Baloo, Frameworks

Jan 22 2020

astippich committed R255:baa589f73411: do not signal property change for position via MPRIS (authored by astippich).
do not signal property change for position via MPRIS
Jan 22 2020, 8:27 PM

Jan 18 2020

astippich accepted D23859: Radios: add support for images.

good to go from my side

Jan 18 2020, 12:31 PM
astippich committed R266:936f84707708: Cleanup and add 22px media repeat icons (authored by astippich).
Cleanup and add 22px media repeat icons
Jan 18 2020, 12:06 PM
astippich closed D26671: Cleanup and add 22px media repeat icons.
Jan 18 2020, 12:06 PM · Frameworks

Jan 15 2020

astippich added a comment to D26671: Cleanup and add 22px media repeat icons.

here you go:

Jan 15 2020, 7:18 AM · Frameworks
astippich updated the diff for D26671: Cleanup and add 22px media repeat icons.
  • remove color
Jan 15 2020, 7:18 AM · Frameworks

Jan 14 2020

astippich requested review of D26671: Cleanup and add 22px media repeat icons.
Jan 14 2020, 8:56 PM · Frameworks