I would honestly prefer just to check within the QML side of things and display the default image in case of an error. This way, this would actually also catch issues with local tracks (in case an image was deleted or similar).
But @mgallien would like to check it before, so let's wait for his response.
Actually, I think the way the url checking is implemented is synchronous, e.g. blocking in case of no reply, if I am not mistaken. This should definitely be changed.

ping!

taglibwriter should get the same treatment

• rebase

• fix label comment
• tweaks

For baloo-widgets, the display of the lyrics tag is disabled anyways. Displaying a large chunk of text does not really look good in the information panel...

• put all helper functions into anonymous namespace

• fix label comment

This is probably how it should have been implemented from the beginning, and not how I did it in the embeddedimagedata class, which duplicates a lot of code and requires additional file operations.
Baloo can continue to work as is due to the new flags.
Taglib writer will follow if this is accepted. Afterwards, I will deprecate embeddedimagedata

For the concept a big +1 from me. I did not even know that we had that in the infocenter...

• tweak icon and shadows
• remove baloo symlink

the scalable test fails with this one. Is the right solution to just delete the 32px symlink under .../preferences?

nice

any more comments?

Thanks! I pushed a fix which disables the test if taglib is not installed

• tweak icon and shadows

• tweak shadows

ping!

I also think that this is too thin.
If you'd like to do the updates, please go ahead! You can do it much better than me I think

This is a scaled copy of the kfind magnifier glass. However, it was way too small to be directly usable imho

• modified icon with shadow

Thanks @broulik for the hint and @ngraham for being faster than me :)

Someone was faster :)
https://phabricator.kde.org/R318:686a03550f34270d917125b760e740571ba63360

Can you give me a hint exactly where? I searched for usages and found none, and still cannot find it now

New proposal

Yes, that is the plan

ping

Correct

In D23859#550854, @jguidon wrote:

Thanks for your feedback,

To be honest, I don't know how useful this is when the image must be added manually. Ideally, this would be retrieved automatically. However, this could provide the base for such a feature.

I agree about the fact that images should be retrieved automatically in some way. We should define how, what do you think ?
I also think it can be useful if the user adds its how radio and wants a particular image to visually identify it in the list.

Before:

Before opening a revision, I have actually a question about what to update in breeze-icons.
There are currently 32px icons under preferences:
-preferences-desktop-baloo.svg, which is a 32px version of the kfind app icon
-baloo.svg as a symlink to preferences-desktop-baloo.svg, which seems to be used by the kcm
-nepomuk.svg (!) as a symlink to -preferences-desktop-baloos.svg

48px

• update and save as optimized svg

In D23402#548526, @mgallien wrote:

I spent some time on this. It should be possible to at least cover the no metadata case with requests only on TracksData. What do you think?

If you want, I can try to do that on gitlab?

It should be easier to extend it to the full solution by working together on it and using your work as a basis.

Sorry for the late reply.
To be honest, I don't know how useful this is when the image must be added manually. Ideally, this would be retrieved automatically. However, this could provide the base for such a feature.

Proposal:

This is with the tape window moved up 1px

just did it: https://invent.kde.org/kde/elisa/merge_requests/9

no, not yet. it will require Kf 5.64