User Details
User Details
- User Since
- Oct 14 2017, 1:49 PM (136 w, 2 d)
- Availability
- Available
Mon, May 4
Mon, May 4
test the extractNothing flag
honor the extractMetaData flag
Sun, Apr 26
Sun, Apr 26
astippich updated the diff for D29199: honor the extractMetaData flag.
- use continue
astippich updated the diff for D29199: honor the extractMetaData flag.
- fix another stupid mistake
astippich added inline comments to D29199: honor the extractMetaData flag.
astippich updated the diff for D29199: honor the extractMetaData flag.
- more fixes
astippich added inline comments to D29199: honor the extractMetaData flag.
astippich updated the diff for D29199: honor the extractMetaData flag.
- implement review
astippich added a dependent revision for D29199: honor the extractMetaData flag: D29200: test the extractNothing flag.
astippich requested review of D29200: test the extractNothing flag.
astippich requested review of D29199: honor the extractMetaData flag.
Apr 21 2020
Apr 21 2020
astippich added a comment to D20739: Handle multiple entries in map.
That said, I think the issue is in this line
Apr 19 2020
Apr 19 2020
astippich removed a reviewer for D28980: Revert "add Baloo DBus signals for moved or removed files": astippich.
Okay, since there seems to be no interest at all as even a short reply is not given, I am done here
Apr 12 2020
Apr 12 2020
astippich committed R293:19e71b3e4a5f: rename and export newBatchTime signal in filecontentindexer (authored by astippich).
rename and export newBatchTime signal in filecontentindexer
astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.
Thanks
astippich updated the summary of D28682: rename and export newBatchTime signal in filecontentindexer.
astippich updated the diff for D28682: rename and export newBatchTime signal in filecontentindexer.
- implement feedback
Apr 10 2020
Apr 10 2020
astippich retitled D28682: rename and export newBatchTime signal in filecontentindexer from export done signal in filecontentindexer to rename and export done signal in filecontentindexer.
astippich updated the diff for D28682: rename and export newBatchTime signal in filecontentindexer.
- rename signal
Apr 9 2020
Apr 9 2020
astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.
How about committedBatch so that it's clear that they have been committed to the database?
astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.
Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call.
Apr 8 2020
Apr 8 2020
astippich added a comment to D28682: rename and export newBatchTime signal in filecontentindexer.
astippich requested review of D28682: rename and export newBatchTime signal in filecontentindexer.
Mar 22 2020
Mar 22 2020
add icons to dialogs
astippich placed T5375: Add Management of Ratings for Tracks from Local Files up for grabs.
astippich added a comment to D25517: Add an option to extract image data and add front cover property.
Due to the recent circumstances I will probably not implement the support in Elisa, so I won't land this unless @bruns explicitly is okay with it (I still think this is an improvement over the status quo).
Mar 19 2020
Mar 19 2020
remove check for stringlist
Mar 18 2020
Mar 18 2020
astippich updated the diff for D25679: Implement writing of front cover in taglibwriter.
- adapt to changes
- use QMimeDatabase
astippich updated the diff for D25518: Extract front cover in the taglib extractor.
- adapt to changes
astippich added a comment to D25517: Add an option to extract image data and add front cover property.
Since I got one accept and no other response, I will merge on the weekend
astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
- fix label comment
- tweaks
- rename flag to ImageData
- adress review comments
- udpate since tag
- update since tag
Mar 16 2020
Mar 16 2020
astippich added a comment to D25517: Add an option to extract image data and add front cover property.
ping @bruns
this has now been open and unanswered for month!
Same for the dependent patches
Mar 14 2020
Mar 14 2020
astippich committed R255:dfe1d97ccf31: fix margin in grid view with scrollbar (authored by astippich).
fix margin in grid view with scrollbar
use standard icon names
minor filescanner optimizations
delete unused file
Mar 11 2020
Mar 11 2020
prepare metadata writing
Mar 10 2020
Mar 10 2020
consistently name it shuffle
Mar 8 2020
Mar 8 2020
astippich committed R255:f21051705b2e: fix and improve toggling shuffle mode (authored by astippich).
fix and improve toggling shuffle mode
astippich committed R255:f385349d4ccb: Never emit dataChanged signal when inserting new entries (authored by astippich).
Never emit dataChanged signal when inserting new entries
Mar 7 2020
Mar 7 2020
wait for data changed in test
fix enqueue all from album view
wait for test until data is updated
try to fix test
remove more leftover debug output
New shuffle mode for playlist
remove leftover debug
Mar 3 2020
Mar 3 2020
astippich added a comment to D27767: [ModifiedFileIndexer] Correct time checks for new files.
I would like to request a clear answer for https://phabricator.kde.org/D25517 once again
Mar 1 2020
Mar 1 2020
astippich added inline comments to D27767: [ModifiedFileIndexer] Correct time checks for new files.
astippich committed R255:8368d8765f11: unify animations when showing/hiding items in the content view (authored by astippich).
unify animations when showing/hiding items in the content view
astippich committed R255:e3864b151828: use duration values provided from Kirigami (authored by astippich).
use duration values provided from Kirigami
Feb 29 2020
Feb 29 2020
astippich added a comment to D25517: Add an option to extract image data and add front cover property.
Ping! At least a reply would be nice
astippich committed R255:d7ec61c9ea9f: Use kirigami's gridUnit for text height throughout Elisa (authored by astippich).
Use kirigami's gridUnit for text height throughout Elisa
Feb 27 2020
Feb 27 2020
astippich committed R255:b285d75daebe: fix margins when view selector is collapsed (authored by astippich).
fix margins when view selector is collapsed
astippich committed R255:73c6211465a7: replace view selector delegates with kirigami (authored by astippich).
replace view selector delegates with kirigami
Feb 25 2020
Feb 25 2020
astippich committed R255:9fc378078570: Derive layout margins based on kirigami values (authored by astippich).
Derive layout margins based on kirigami values
remove uneeded function
Feb 17 2020
Feb 17 2020
fix qml test
astippich committed R255:a85b1a683019: replace hardoced values with kirigami ones (authored by astippich).
replace hardoced values with kirigami ones
astippich committed R255:2d6fc872557d: Add ImageWithFallback component and use it for cover art (authored by astippich).
Add ImageWithFallback component and use it for cover art
Feb 16 2020
Feb 16 2020
fix simple play list view
astippich committed R255:100d4cfb0def: reuse the persistent state to restore playlist and cleanup (authored by astippich).
reuse the persistent state to restore playlist and cleanup
rework undo logic
rename signals for clarification
remove unused function
remove unused function
cleanup and simplify mediaplaylist
astippich committed R255:757dff823e1c: remove special handling of radios and use generic functions, remove unused… (authored by astippich).
remove special handling of radios and use generic functions, remove unused…
Feb 11 2020
Feb 11 2020
astippich committed R255:f807e02a287d: compute playlist delegate height based on font size (authored by astippich).
compute playlist delegate height based on font size
fix heights
Feb 9 2020
Feb 9 2020
astippich added a comment to D25517: Add an option to extract image data and add front cover property.
Where are we with this? @bruns are you accepting the proposed solution or do you reject it completely?
I think it is at least way better than the current solution and maintains current API.
A larger refactoring could be done for KF6
astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
- udpate since tag
Feb 8 2020
Feb 8 2020
Merge branch 'release/19.12'
Feb 4 2020
Feb 4 2020
astippich committed R255:0b2c4be90bcb: Rework size calculation for list delegates and cleanup (authored by astippich).
Rework size calculation for list delegates and cleanup
astippich committed R255:ec5197521066: limit the rate with which progress is sent via MPRIS (authored by astippich).
limit the rate with which progress is sent via MPRIS
Feb 2 2020
Feb 2 2020
fix grid delegate test
rework sizing of the grid delegate
astippich committed R255:09855fefbe09: consolidate the interface between file and baloo indexers (authored by astippich).
consolidate the interface between file and baloo indexers
Jan 29 2020
Jan 29 2020
Update README.md
Jan 26 2020
Jan 26 2020
implement loading tracks from genre
astippich committed R255:1691274e52b8: disable playlist animations to fix display corruption (authored by astippich).
disable playlist animations to fix display corruption
Jan 25 2020
Jan 25 2020
astippich added a comment to D25517: Add an option to extract image data and add front cover property.
friendly ping for the series
Jan 22 2020
Jan 22 2020
astippich committed R255:baa589f73411: do not signal property change for position via MPRIS (authored by astippich).
do not signal property change for position via MPRIS
Jan 18 2020
Jan 18 2020
good to go from my side
astippich committed R266:936f84707708: Cleanup and add 22px media repeat icons (authored by astippich).
Cleanup and add 22px media repeat icons
Jan 15 2020
Jan 15 2020
astippich added a comment to D26671: Cleanup and add 22px media repeat icons.
here you go:
astippich updated the diff for D26671: Cleanup and add 22px media repeat icons.
- remove color
Jan 14 2020
Jan 14 2020
astippich requested review of D26671: Cleanup and add 22px media repeat icons.