astippich (Alexander Stippich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2017, 1:49 PM (122 w, 4 d)
Availability
Available

Recent Activity

Mon, Feb 17

astippich committed R255:404cee858aee: fix qml test (authored by astippich).
fix qml test
Mon, Feb 17, 8:59 PM
astippich committed R255:a85b1a683019: replace hardoced values with kirigami ones (authored by astippich).
replace hardoced values with kirigami ones
Mon, Feb 17, 8:45 PM
astippich committed R255:2d6fc872557d: Add ImageWithFallback component and use it for cover art (authored by astippich).
Add ImageWithFallback component and use it for cover art
Mon, Feb 17, 8:45 PM

Sun, Feb 16

astippich committed R255:a03fdc9e1dd6: fix simple play list view (authored by astippich).
fix simple play list view
Sun, Feb 16, 11:57 AM
astippich committed R255:100d4cfb0def: reuse the persistent state to restore playlist and cleanup (authored by astippich).
reuse the persistent state to restore playlist and cleanup
Sun, Feb 16, 10:47 AM
astippich committed R255:e19a783e5bd4: rework undo logic (authored by astippich).
rework undo logic
Sun, Feb 16, 10:47 AM
astippich committed R255:310cf1181f3d: rename signals for clarification (authored by astippich).
rename signals for clarification
Sun, Feb 16, 10:47 AM
astippich committed R255:4cbdb6b6b74e: remove unused function (authored by astippich).
remove unused function
Sun, Feb 16, 10:47 AM
astippich committed R255:8e1c7f3fa600: remove unused function (authored by astippich).
remove unused function
Sun, Feb 16, 10:47 AM
astippich committed R255:6b2b9b038b03: cleanup and simplify mediaplaylist (authored by astippich).
cleanup and simplify mediaplaylist
Sun, Feb 16, 10:47 AM
astippich committed R255:757dff823e1c: remove special handling of radios and use generic functions, remove unused… (authored by astippich).
remove special handling of radios and use generic functions, remove unused…
Sun, Feb 16, 10:47 AM

Tue, Feb 11

astippich committed R255:f807e02a287d: compute playlist delegate height based on font size (authored by astippich).
compute playlist delegate height based on font size
Tue, Feb 11, 5:42 PM
astippich committed R255:e110db887c25: fix heights (authored by astippich).
fix heights
Tue, Feb 11, 5:42 PM

Sun, Feb 9

astippich added a comment to D25517: Add an option to extract image data and add front cover property.

Where are we with this? @bruns are you accepting the proposed solution or do you reject it completely?
I think it is at least way better than the current solution and maintains current API.
A larger refactoring could be done for KF6

Sun, Feb 9, 4:01 PM · Baloo, Frameworks
astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
  • udpate since tag
Sun, Feb 9, 4:00 PM · Baloo, Frameworks

Sat, Feb 8

astippich committed R255:3b369fa63354: Merge branch 'release/19.12' (authored by astippich).
Merge branch 'release/19.12'
Sat, Feb 8, 12:01 PM

Tue, Feb 4

astippich committed R255:0b2c4be90bcb: Rework size calculation for list delegates and cleanup (authored by astippich).
Rework size calculation for list delegates and cleanup
Tue, Feb 4, 4:19 PM
astippich committed R255:ec5197521066: limit the rate with which progress is sent via MPRIS (authored by astippich).
limit the rate with which progress is sent via MPRIS
Tue, Feb 4, 4:19 PM

Sun, Feb 2

astippich committed R255:ecbe3f75a5e2: fix grid delegate test (authored by astippich).
fix grid delegate test
Sun, Feb 2, 4:52 PM
astippich committed R255:6c999209b0ba: rework sizing of the grid delegate (authored by astippich).
rework sizing of the grid delegate
Sun, Feb 2, 4:34 PM
astippich committed R255:09855fefbe09: consolidate the interface between file and baloo indexers (authored by astippich).
consolidate the interface between file and baloo indexers
Sun, Feb 2, 2:18 PM

Wed, Jan 29

astippich committed R255:7a48106b0ff3: Update README.md (authored by astippich).
Update README.md
Wed, Jan 29, 8:43 PM

Sun, Jan 26

astippich committed R255:8e1967d7a910: implement loading tracks from genre (authored by astippich).
implement loading tracks from genre
Sun, Jan 26, 9:04 PM
astippich committed R255:1691274e52b8: disable playlist animations to fix display corruption (authored by astippich).
disable playlist animations to fix display corruption
Sun, Jan 26, 8:20 PM

Sat, Jan 25

astippich added a comment to D25517: Add an option to extract image data and add front cover property.

friendly ping for the series

Sat, Jan 25, 10:23 AM · Baloo, Frameworks

Wed, Jan 22

astippich committed R255:baa589f73411: do not signal property change for position via MPRIS (authored by astippich).
do not signal property change for position via MPRIS
Wed, Jan 22, 8:27 PM

Jan 18 2020

astippich accepted D23859: Radios: add support for images.

good to go from my side

Jan 18 2020, 12:31 PM
astippich committed R266:936f84707708: Cleanup and add 22px media repeat icons (authored by astippich).
Cleanup and add 22px media repeat icons
Jan 18 2020, 12:06 PM
astippich closed D26671: Cleanup and add 22px media repeat icons.
Jan 18 2020, 12:06 PM · Frameworks

Jan 15 2020

astippich added a comment to D26671: Cleanup and add 22px media repeat icons.

here you go:

Jan 15 2020, 7:18 AM · Frameworks
astippich updated the diff for D26671: Cleanup and add 22px media repeat icons.
  • remove color
Jan 15 2020, 7:18 AM · Frameworks

Jan 14 2020

astippich requested review of D26671: Cleanup and add 22px media repeat icons.
Jan 14 2020, 8:56 PM · Frameworks

Jan 12 2020

astippich added a comment to D25517: Add an option to extract image data and add front cover property.

The problem is the extractor serves two different use cases:

  • retrieval for searching/caching properties
  • on-demand extraction

    Baloo falls into the first category. It is only interested in properties which can be queried/compared in a meaningful way. Even storing the properties as a cache for e.g. Dolphin is a little bit of a stretch.

    Elisa falls into the second category. It does not store the extracted data persistently, but is fine extracting e.g. the front cover on demand.

    Currently the only large/blob property is the front cover. But what about BackCover, Leaflet pages, ..., Video Thumbnails? Returning all of these even when not required is wasteful. If you want a front cover, say so.
Jan 12 2020, 3:56 PM · Baloo, Frameworks

Jan 8 2020

astippich added a comment to D23859: Radios: add support for images.

Thanks, looking good! Just one question inline

Jan 8 2020, 8:33 PM
astippich updated the diff for D25679: Implement writing of front cover in taglibwriter.
  • adapt to changes
Jan 8 2020, 8:30 PM · Baloo, Frameworks
astippich updated the diff for D25518: Extract front cover in the taglib extractor.
  • adapt to changes
Jan 8 2020, 8:29 PM · Baloo, Frameworks
astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
  • adress review comments
Jan 8 2020, 8:29 PM · Baloo, Frameworks

Jan 6 2020

astippich committed R255:bffff05b51c2: Merge branch 'headerBackgroundResize' into 'release/19.12' (authored by astippich).
Merge branch 'headerBackgroundResize' into 'release/19.12'
Jan 6 2020, 6:07 PM
astippich committed R255:0f31ea5c730b: set the cover art in the header to a fixed source size (authored by astippich).
set the cover art in the header to a fixed source size
Jan 6 2020, 6:07 PM
astippich committed R255:e5fe012b4d03: set the background source size to a fixed value (authored by astippich).
set the background source size to a fixed value
Jan 6 2020, 6:07 PM
astippich committed R255:4ab3bea4fdf8: Merge branch 'fixRadioEdit' into 'release/19.12' (authored by astippich).
Merge branch 'fixRadioEdit' into 'release/19.12'
Jan 6 2020, 5:46 PM
astippich committed R255:eb2fd038582a: Use textEdided signal in EditableMetaDataDelegate (authored by astippich).
Use textEdided signal in EditableMetaDataDelegate
Jan 6 2020, 5:46 PM

Jan 5 2020

astippich added a comment to D25517: Add an option to extract image data and add front cover property.

I have thought about this and have come to the conclusion this is not really future proof.

The Property::FrontCover is IMHO fine, i.e. the changes to propertyinfo.cpp and properties.h could go in as is.

The request of additional properties should be done differently. How about the following:

  1. divide properties into (currently) two sets, "Simple Metadata" (all the current ones but frontcover) and "Complex Metadata" (currently frontcover).
  2. allow to specify extra properties for SimpleExtractionResult
Jan 5 2020, 2:10 PM · Baloo, Frameworks

Jan 4 2020

astippich abandoned D23402: Show tracks with empty titles.
Jan 4 2020, 5:37 PM · Elisa
astippich added a comment to D25517: Add an option to extract image data and add front cover property.

friendly ping! I would like to continue work on this. Is the new name better? If so, I will rebase follow-up patches

Jan 4 2020, 2:49 PM · Baloo, Frameworks

Dec 22 2019

astippich accepted D26054: partial fix for accentuated characters in file name on Windows.
Dec 22 2019, 12:09 PM · Baloo, Frameworks

Dec 15 2019

astippich retitled D25517: Add an option to extract image data and add front cover property from Add an option to extract binary data and add front cover property to Add an option to extract image data and add front cover property.
Dec 15 2019, 7:37 PM · Baloo, Frameworks
astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
  • rename flag to ImageData
Dec 15 2019, 7:36 PM · Baloo, Frameworks
astippich closed D25516: Remove unrequired private declarations for taglibextractor.
Dec 15 2019, 7:27 PM · Baloo, Frameworks
astippich committed R286:f66662fea112: Remove unrequired private declarations for taglibextractor (authored by astippich).
Remove unrequired private declarations for taglibextractor
Dec 15 2019, 7:27 PM

Dec 7 2019

astippich added a comment to D23859: Radios: add support for images.

I would honestly prefer just to check within the QML side of things and display the default image in case of an error. This way, this would actually also catch issues with local tracks (in case an image was deleted or similar).
But @mgallien would like to check it before, so let's wait for his response.
Actually, I think the way the url checking is implemented is synchronous, e.g. blocking in case of no reply, if I am not mistaken. This should definitely be changed.

Dec 7 2019, 8:27 PM
astippich added a comment to D25517: Add an option to extract image data and add front cover property.

ping!

Dec 7 2019, 6:33 PM · Baloo, Frameworks

Dec 2 2019

astippich added a comment to D25622: partial solution to accept accentuated characters on windows.

taglibwriter should get the same treatment

Dec 2 2019, 8:39 AM · Baloo, Frameworks
astippich added a dependent revision for D25518: Extract front cover in the taglib extractor: D25679: Implement writing of front cover in taglibwriter.
Dec 2 2019, 8:32 AM · Baloo, Frameworks
astippich added a dependency for D25679: Implement writing of front cover in taglibwriter: D25518: Extract front cover in the taglib extractor.
Dec 2 2019, 8:32 AM · Baloo, Frameworks
astippich requested review of D25679: Implement writing of front cover in taglibwriter.
Dec 2 2019, 8:32 AM · Baloo, Frameworks
astippich updated the diff for D25518: Extract front cover in the taglib extractor.
  • rebase
Dec 2 2019, 8:30 AM · Baloo, Frameworks
astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
  • fix label comment
  • tweaks
Dec 2 2019, 8:29 AM · Baloo, Frameworks

Nov 27 2019

astippich added a comment to D25515: Only extract lyrics when the plain text flag is set.

For baloo-widgets, the display of the lyrics tag is disabled anyways. Displaying a large chunk of text does not really look good in the information panel...

Nov 27 2019, 8:20 AM · Baloo, Frameworks
astippich updated the diff for D25516: Remove unrequired private declarations for taglibextractor.
  • put all helper functions into anonymous namespace
Nov 27 2019, 8:20 AM · Baloo, Frameworks
astippich added inline comments to D25516: Remove unrequired private declarations for taglibextractor.
Nov 27 2019, 8:12 AM · Baloo, Frameworks
astippich added inline comments to D25517: Add an option to extract image data and add front cover property.
Nov 27 2019, 8:09 AM · Baloo, Frameworks

Nov 25 2019

astippich updated the diff for D25517: Add an option to extract image data and add front cover property.
  • fix label comment
Nov 25 2019, 3:55 PM · Baloo, Frameworks
astippich added a dependent revision for D25517: Add an option to extract image data and add front cover property: D25518: Extract front cover in the taglib extractor.
Nov 25 2019, 11:07 AM · Baloo, Frameworks
astippich added dependencies for D25518: Extract front cover in the taglib extractor: D25517: Add an option to extract image data and add front cover property, D25516: Remove unrequired private declarations for taglibextractor.
Nov 25 2019, 11:07 AM · Baloo, Frameworks
astippich added a dependent revision for D25516: Remove unrequired private declarations for taglibextractor: D25518: Extract front cover in the taglib extractor.
Nov 25 2019, 11:07 AM · Baloo, Frameworks
astippich added a comment to D25518: Extract front cover in the taglib extractor.

This is probably how it should have been implemented from the beginning, and not how I did it in the embeddedimagedata class, which duplicates a lot of code and requires additional file operations.
Baloo can continue to work as is due to the new flags.
Taglib writer will follow if this is accepted. Afterwards, I will deprecate embeddedimagedata

Nov 25 2019, 11:05 AM · Baloo, Frameworks
astippich requested review of D25518: Extract front cover in the taglib extractor.
Nov 25 2019, 11:03 AM · Baloo, Frameworks
astippich requested review of D25517: Add an option to extract image data and add front cover property.
Nov 25 2019, 11:01 AM · Baloo, Frameworks
astippich requested review of D25516: Remove unrequired private declarations for taglibextractor.
Nov 25 2019, 10:46 AM · Baloo, Frameworks
astippich requested review of D25515: Only extract lyrics when the plain text flag is set.
Nov 25 2019, 10:45 AM · Baloo, Frameworks

Nov 23 2019

astippich added a comment to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

For the concept a big +1 from me. I did not even know that we had that in the infocenter...

Nov 23 2019, 2:29 PM · Baloo, Plasma
astippich added a project to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing: Baloo.
Nov 23 2019, 2:26 PM · Baloo, Plasma
astippich committed R124:a7a2d277e81f: use new icon for search category (authored by astippich).
use new icon for search category
Nov 23 2019, 11:53 AM
astippich closed D25345: use new icon for search category.
Nov 23 2019, 11:53 AM · Plasma
astippich committed R119:f1a6bfa3b876: change icon for baloo kcm (authored by astippich).
change icon for baloo kcm
Nov 23 2019, 11:52 AM
astippich closed D25344: change icon for baloo kcm.
Nov 23 2019, 11:52 AM · Plasma

Nov 19 2019

astippich committed R255:d757f47aca2d: always set new source when track is set (authored by astippich).
always set new source when track is set
Nov 19 2019, 6:52 PM
astippich committed R255:bec40142aa96: Merge branch 'fixPlaybackSameTrack' into 'release/19.12' (authored by astippich).
Merge branch 'fixPlaybackSameTrack' into 'release/19.12'
Nov 19 2019, 6:52 PM
astippich committed R255:03f2ac2eaa71: Merge branch 'fixDirectoryPaths' into 'release/19.12' (authored by astippich).
Merge branch 'fixDirectoryPaths' into 'release/19.12'
Nov 19 2019, 6:52 PM
astippich committed R255:485895c52ce8: always add a slash to the directory path (authored by astippich).
always add a slash to the directory path
Nov 19 2019, 6:52 PM

Nov 17 2019

astippich committed R255:7312f34c62bd: Merge branch 'cleanupAndPreparation' into 'release/19.12' (authored by astippich).
Merge branch 'cleanupAndPreparation' into 'release/19.12'
Nov 17 2019, 12:12 PM
astippich committed R255:907f9ee80d0f: fix one forgotten file modification time and cleanup (authored by astippich).
fix one forgotten file modification time and cleanup
Nov 17 2019, 12:12 PM

Nov 16 2019

astippich requested review of D25345: use new icon for search category.
Nov 16 2019, 7:47 PM · Plasma
astippich committed R266:61331d6ce20a: Add new baloo icons (authored by astippich).
Add new baloo icons
Nov 16 2019, 7:38 PM
astippich closed T7878: Create or find Icon as Resolved by committing R266:61331d6ce20a: Add new baloo icons.
Nov 16 2019, 7:38 PM · VDG, Baloo
astippich closed D24957: Add new baloo icons.
Nov 16 2019, 7:38 PM · Frameworks
astippich requested review of D25344: change icon for baloo kcm.
Nov 16 2019, 7:36 PM · Plasma
astippich updated the diff for D24957: Add new baloo icons.
  • tweak icon and shadows
  • remove baloo symlink
Nov 16 2019, 7:32 PM · Frameworks
astippich added a comment to D24957: Add new baloo icons.

the scalable test fails with this one. Is the right solution to just delete the 32px symlink under .../preferences?

Nov 16 2019, 9:27 AM · Frameworks
astippich committed R266:40acd718572a: Add new preferences search icons (authored by astippich).
Add new preferences search icons
Nov 16 2019, 9:25 AM
astippich closed D24959: Add new preferences search icons.
Nov 16 2019, 9:25 AM · Frameworks

Nov 13 2019

astippich abandoned D23395: Retry manual metadata extraction when baloo returns an empty map.
Nov 13 2019, 8:41 PM · Baloo
astippich abandoned D23394: Add xattrfetchjob.
Nov 13 2019, 8:41 PM · Baloo
astippich accepted D25251: Remove no longer used IndexedDataRetriever.
Nov 13 2019, 8:41 PM · Baloo
astippich accepted D25250: Use realtime indexing as fallback when DB has no property data.

nice

Nov 13 2019, 8:40 PM · Baloo
astippich accepted D25248: Split handling of on-demand extractor process from IndexedDataRetriever.
Nov 13 2019, 8:20 PM · Baloo
astippich accepted D25247: Add categorized logging for baloo-widgets.
Nov 13 2019, 8:13 PM · Baloo
astippich added a comment to D24959: Add new preferences search icons.

any more comments?

Nov 13 2019, 7:05 PM · Frameworks

Nov 11 2019

astippich added a comment to D23411: Fix crash in writer collection and cleanup.

Thanks! I pushed a fix which disables the test if taglib is not installed

Nov 11 2019, 4:46 PM · Baloo, Frameworks