User Details
- User Since
- Oct 14 2017, 1:49 PM (112 w, 5 d)
- Availability
- Available
Sat, Dec 7
I would honestly prefer just to check within the QML side of things and display the default image in case of an error. This way, this would actually also catch issues with local tracks (in case an image was deleted or similar).
But @mgallien would like to check it before, so let's wait for his response.
Actually, I think the way the url checking is implemented is synchronous, e.g. blocking in case of no reply, if I am not mistaken. This should definitely be changed.
ping!
Mon, Dec 2
taglibwriter should get the same treatment
- rebase
- fix label comment
- tweaks
Wed, Nov 27
For baloo-widgets, the display of the lyrics tag is disabled anyways. Displaying a large chunk of text does not really look good in the information panel...
- put all helper functions into anonymous namespace
Mon, Nov 25
- fix label comment
This is probably how it should have been implemented from the beginning, and not how I did it in the embeddedimagedata class, which duplicates a lot of code and requires additional file operations.
Baloo can continue to work as is due to the new flags.
Taglib writer will follow if this is accepted. Afterwards, I will deprecate embeddedimagedata
Sat, Nov 23
For the concept a big +1 from me. I did not even know that we had that in the infocenter...
Tue, Nov 19
Sun, Nov 17
Sat, Nov 16
- tweak icon and shadows
- remove baloo symlink
the scalable test fails with this one. Is the right solution to just delete the 32px symlink under .../preferences?
Wed, Nov 13
nice
any more comments?
Nov 11 2019
Thanks! I pushed a fix which disables the test if taglib is not installed
Nov 10 2019
Nov 9 2019
- tweak icon and shadows
- tweak shadows
Nov 8 2019
Nov 7 2019
Nov 6 2019
Nov 3 2019
I also think that this is too thin.
If you'd like to do the updates, please go ahead! You can do it much better than me I think
Oct 31 2019
Oct 30 2019
This is a scaled copy of the kfind magnifier glass. However, it was way too small to be directly usable imho
Oct 29 2019
- modified icon with shadow
Someone was faster :)
https://phabricator.kde.org/R318:686a03550f34270d917125b760e740571ba63360
Can you give me a hint exactly where? I searched for usages and found none, and still cannot find it now
New proposal
Oct 26 2019
Yes, that is the plan
ping
Correct
Basically the icon from D24957 without the paw
Before:
which is basically a copy of the kfind icon
Oct 25 2019
Oct 21 2019
Before opening a revision, I have actually a question about what to update in breeze-icons.
There are currently 32px icons under preferences:
-preferences-desktop-baloo.svg, which is a 32px version of the kfind app icon
-baloo.svg as a symlink to preferences-desktop-baloo.svg, which seems to be used by the kcm
-nepomuk.svg (!) as a symlink to -preferences-desktop-baloos.svg
Oct 17 2019
48px
32px with own icon, since its required for system settings
- update and save as optimized svg
Oct 16 2019
Sorry for the late reply.
To be honest, I don't know how useful this is when the image must be added manually. Ideally, this would be retrieved automatically. However, this could provide the base for such a feature.
This is with the tape window moved up 1px
When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment.
If everyone is okay with this, I will update the revision with the optimized svgs.
I don't think that filling this space is useful.
Oct 13 2019
just did it: https://invent.kde.org/kde/elisa/merge_requests/9
no, not yet. it will require Kf 5.64