astippich (Alexander Stippich)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2017, 1:49 PM (70 w, 4 d)
Availability
Available

Recent Activity

Yesterday

astippich added inline comments to D19102: Fix extraction of aspect ratio property.
Wed, Feb 20, 6:56 AM · Baloo, Frameworks

Tue, Feb 19

astippich updated the diff for D19106: Use new display string function from KFileMetaData.
  • use Qlatin1
Tue, Feb 19, 9:33 PM · Baloo
astippich added a comment to D19098: Add PropertyMap to QVariantMap conversion function using names.

It already does at two different places, because it fuses different information into a single QMap later on (xattr, file size etc...)
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/filefetchjob.cpp$62

This can be done by using a KFM::PropertyMap directly, and adding property types for the UserMetaData (tags, comment, rating). Note, the strings returned by PropertyInfo::name() are not shared ...

It is not only xattr, also everything from kfileitems{group,size,owner...}. Adding these as property with no users in KFileMetaData does not seem clean.
Also, you would have to construct the properties from the name. Why not use the names directly then? Changing everything to a PropertyMap requires a rewrite of large parts, and I certainly will not rewrite baloo-widgets right now.
This is just for a small cleanup.

Tue, Feb 19, 9:01 PM · Baloo, Frameworks
astippich added a comment to D19109: [Extractor] Add metadata to extractors.

A few general remarks:

  • I really do not like that there are two lists of supported mimetypes now which have to be kept in sync

I think this is trivial enough. Also this is covered by the unit test.

Tue, Feb 19, 8:57 PM · Baloo, Frameworks
astippich requested changes to D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.

The stringlist case is still not handled. And a test case for multiple ints (2 ReleaseYear properties) will also likely fail. When going with JSON, I think this has to be done by always inserting values as an array (even if there is only one value), and removing this during deserialization. Stringlist will then be an array in an array in JSON. That will ensure that the map is of the same structure as it was put in, and this should also be possible to do in a backwards compatible way.

Tue, Feb 19, 8:51 PM · Baloo, Frameworks
astippich added inline comments to D19102: Fix extraction of aspect ratio property.
Tue, Feb 19, 8:32 PM · Baloo, Frameworks
astippich updated the diff for D19102: Fix extraction of aspect ratio property.
  • do not use QString::number
Tue, Feb 19, 8:27 PM · Baloo, Frameworks
astippich updated the diff for D19101: Increase precision of frame rate property.
  • do not use QString::number
Tue, Feb 19, 8:20 PM · Baloo, Frameworks
astippich committed R286:2e593cbfab1e: fix build (authored by astippich).
fix build
Tue, Feb 19, 7:52 PM
astippich updated the diff for D19102: Fix extraction of aspect ratio property.
  • rebase
  • use exact value for test
Tue, Feb 19, 7:28 PM · Baloo, Frameworks
astippich removed a dependent revision for D19100: Cleanup ffmpeg extractor: D19101: Increase precision of frame rate property.
Tue, Feb 19, 7:25 PM · Baloo, Frameworks
astippich removed a dependency for D19101: Increase precision of frame rate property: D19100: Cleanup ffmpeg extractor.
Tue, Feb 19, 7:25 PM · Baloo, Frameworks
astippich updated the diff for D19101: Increase precision of frame rate property.
  • rebase on master
  • use exact value in test
Tue, Feb 19, 7:24 PM · Baloo, Frameworks
astippich committed R286:96b08a1a601f: Cleanup ffmpeg extractor (authored by astippich).
Cleanup ffmpeg extractor
Tue, Feb 19, 7:17 PM
astippich closed D19100: Cleanup ffmpeg extractor.
Tue, Feb 19, 7:17 PM · Baloo, Frameworks
astippich committed R286:f4c72f517911: Add a test for ffmpeg extractor (authored by astippich).
Add a test for ffmpeg extractor
Tue, Feb 19, 7:17 PM
astippich closed D19099: Add a test for ffmpeg extractor.
Tue, Feb 19, 7:17 PM · Baloo, Frameworks

Mon, Feb 18

astippich added a comment to D19109: [Extractor] Add metadata to extractors.

A few general remarks:

  • I really do not like that there are two lists of supported mimetypes now which have to be kept in sync
  • Do we really need versioning per mimetype? IMHO it is sufficient to have a version number per extractor. From my experience, fixing an extractor usually impacts all its supported mimetypes, and rarily affects only one mimetype. Also, this makes the list hard to maintain, also regarding file types which have multiple mime types, e.g. audio/wav and audio/x-wav
  • Do we need an x.y version? I think a single integer is enough or what do you have in mind?
  • I prefer to directly construct the qvariantmap in the extractors, and re-use the mimetype list which is already available.
Mon, Feb 18, 6:59 PM · Baloo, Frameworks
astippich added inline comments to D19099: Add a test for ffmpeg extractor.
Mon, Feb 18, 6:54 PM · Baloo, Frameworks
astippich updated the diff for D19099: Add a test for ffmpeg extractor.
  • emphasize test properties
Mon, Feb 18, 6:46 PM · Baloo, Frameworks
astippich added a comment to D19098: Add PropertyMap to QVariantMap conversion function using names.

It already does at two different places, because it fuses different information into a single QMap later on (xattr, file size etc...)
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/filefetchjob.cpp$62
I would like to consolidate the two different implementations of the conversion functions. I think it is also useful for debugging purposes, e.g. dumping a property map to cmd line.

Mon, Feb 18, 6:42 PM · Baloo, Frameworks
astippich added a comment to D19105: Use new display string function from KFileMetaData.

Thanks! Who should I ask for a dependency rebuild? sysadmin?
If you don't mind, please also have a look at D19106, which does the same for baloo-widgets. I'd like to land them at the same time for consistency.

Mon, Feb 18, 6:38 PM · Dolphin

Sun, Feb 17

astippich added a comment to D19106: Use new display string function from KFileMetaData.

This can only be merged when it is okay that KDE applications can rely on KF 5.56

Sun, Feb 17, 8:16 PM · Baloo
astippich requested review of D19106: Use new display string function from KFileMetaData.
Sun, Feb 17, 8:14 PM · Baloo
astippich added a comment to D19105: Use new display string function from KFileMetaData.

This can of course only be merged when it is deemed okay to rely on KF 5.56

Sun, Feb 17, 8:10 PM · Dolphin
astippich requested review of D19105: Use new display string function from KFileMetaData.
Sun, Feb 17, 8:08 PM · Dolphin
astippich added a dependency for D19102: Fix extraction of aspect ratio property: D19101: Increase precision of frame rate property.
Sun, Feb 17, 7:39 PM · Baloo, Frameworks
astippich added a dependent revision for D19101: Increase precision of frame rate property: D19102: Fix extraction of aspect ratio property.
Sun, Feb 17, 7:39 PM · Baloo, Frameworks
astippich added a dependent revision for D19100: Cleanup ffmpeg extractor: D19101: Increase precision of frame rate property.
Sun, Feb 17, 7:38 PM · Baloo, Frameworks
astippich added a dependency for D19101: Increase precision of frame rate property: D19100: Cleanup ffmpeg extractor.
Sun, Feb 17, 7:38 PM · Baloo, Frameworks
astippich added a dependency for D19100: Cleanup ffmpeg extractor: D19099: Add a test for ffmpeg extractor.
Sun, Feb 17, 7:38 PM · Baloo, Frameworks
astippich added a dependent revision for D19099: Add a test for ffmpeg extractor: D19100: Cleanup ffmpeg extractor.
Sun, Feb 17, 7:38 PM · Baloo, Frameworks
astippich requested review of D19102: Fix extraction of aspect ratio property.
Sun, Feb 17, 7:37 PM · Baloo, Frameworks
astippich requested review of D19101: Increase precision of frame rate property.
Sun, Feb 17, 7:31 PM · Baloo, Frameworks
astippich requested review of D19100: Cleanup ffmpeg extractor.
Sun, Feb 17, 7:28 PM · Baloo, Frameworks
astippich requested review of D19099: Add a test for ffmpeg extractor.
Sun, Feb 17, 7:26 PM · Baloo, Frameworks
astippich added a dependent revision for D19097: Add a test and document PropertyMap/VariantMap conversion: D19098: Add PropertyMap to QVariantMap conversion function using names.
Sun, Feb 17, 7:21 PM · Baloo, Frameworks
astippich requested review of D19098: Add PropertyMap to QVariantMap conversion function using names.
Sun, Feb 17, 7:21 PM · Baloo, Frameworks
astippich requested review of D19097: Add a test and document PropertyMap/VariantMap conversion.
Sun, Feb 17, 7:15 PM · Baloo, Frameworks
astippich added a comment to D18601: Rewrite taglib writer to use property interface.

ping

Sun, Feb 17, 7:09 PM · Baloo, Frameworks
astippich added a comment to D18826: Rewrite the taglib extractor to use the generic PropertyMap interface.

ping. I know this is quite a large diff, but it fixes a potential crash

Sun, Feb 17, 7:08 PM · Baloo, Frameworks
astippich added a comment to D19087: Add standalone conversion functions for PropertyMap to Json and vice versa.

I was wondering if using QDataStream would be simpler, but the data size was over twice the amount compared to the size using JSON during my testing. But this would solve a lot of the limitations which JSON imposes, like handling int and doubles, qdatetime objects, and there would be no need for merging/unmerging items after fixing KFileMetaData.

Sun, Feb 17, 7:00 PM · Baloo, Frameworks

Tue, Feb 12

astippich committed R286:e2bd6629783e: Format EXIF photo flash data (authored by astippich).
Format EXIF photo flash data
Tue, Feb 12, 9:33 PM
astippich closed D18972: Format EXIF photo flash data.
Tue, Feb 12, 9:33 PM · Baloo, Frameworks
astippich added inline comments to D18972: Format EXIF photo flash data.
Tue, Feb 12, 9:22 PM · Baloo, Frameworks
astippich added a comment to D12950: add test which checks the property types.

If no-one objects, I will land this next week

Tue, Feb 12, 9:12 PM · Baloo, Frameworks
astippich updated the diff for D12950: add test which checks the property types.
  • fix space
Tue, Feb 12, 9:09 PM · Baloo, Frameworks
astippich added a comment to D18972: Format EXIF photo flash data.

The data is taken from exiv2 library:
https://github.com/Exiv2/exiv2/blob/master/src/tags_int.cpp#L348
Unfortunately, reusing that data would introduce a lot of #ifdefs in the code, hence I added it to KFileMetaData.
This is the only property remaining that needs translation this way which KFileMetaData queries.

Tue, Feb 12, 9:05 PM · Baloo, Frameworks
astippich requested review of D18972: Format EXIF photo flash data.
Tue, Feb 12, 9:03 PM · Baloo, Frameworks
astippich committed R858:974efd584666: Respect the display property of buttons (authored by astippich).
Respect the display property of buttons
Tue, Feb 12, 8:57 PM
astippich closed D16658: Respect the display property of buttons.
Tue, Feb 12, 8:57 PM · Plasma

Mon, Feb 11

astippich added a comment to D17302: Add test for adding properties to result.

Currently, both
Result::add(prop, "value1"); Result::add(prop, "value2");
and
Result::add(prop, {"value1", "value2"});
are serialized (JSON) in the same way as {prop: ["value1", "value2"]} by Baloo, which is IMHO fine.

Mon, Feb 11, 10:57 PM · Baloo, Frameworks
astippich added a comment to D17302: Add test for adding properties to result.

Is this a please don't merge or can I land it?

Mon, Feb 11, 8:17 PM · Baloo, Frameworks
astippich added a comment to D16658: Respect the display property of buttons.

friendly ping

Mon, Feb 11, 8:15 PM · Plasma

Sun, Feb 10

astippich committed R286:ce756712695a: Try to fix test on windows (authored by astippich).
Try to fix test on windows
Sun, Feb 10, 10:17 PM
astippich committed R286:e1fa79b30da2: Use Kformat for bit and sample rate (authored by astippich).
Use Kformat for bit and sample rate
Sun, Feb 10, 9:47 PM
astippich closed D18910: Use Kformat for bit and sample rate.
Sun, Feb 10, 9:47 PM · Baloo, Frameworks
astippich committed R286:a14030bf7182: Add units to framerate and gps data (authored by astippich).
Add units to framerate and gps data
Sun, Feb 10, 9:27 PM
astippich closed D18911: Add units to framerate and gps data.
Sun, Feb 10, 9:27 PM · Baloo, Frameworks
astippich added a comment to D18910: Use Kformat for bit and sample rate.

The unit will be corrected (it is _bit_rate) and three significant digits will always be shown:
123 400 will be displayed as 123 kbit/s
1 234 000 will be displayed as 1.23 Mbit/s
12 345 000 will be displayed as 12.3 Mbit/s

Sun, Feb 10, 9:26 PM · Baloo, Frameworks
astippich updated the diff for D18911: Add units to framerate and gps data.
  • remove unrelated new lines
Sun, Feb 10, 8:52 PM · Baloo, Frameworks
astippich requested review of D18911: Add units to framerate and gps data.
Sun, Feb 10, 8:51 PM · Baloo, Frameworks
astippich abandoned D12443: fix bitrate unit.

will be superseded by D18910

Sun, Feb 10, 8:42 PM · Baloo
astippich added a comment to D18910: Use Kformat for bit and sample rate.

I actually have not started porting Dolphin to the new feature yet, since this will require Kf 5.56 and is probably stuff for 19.08. If a screenshot is a must I will adjust priorities :)

Sun, Feb 10, 8:36 PM · Baloo, Frameworks
astippich requested review of D18910: Use Kformat for bit and sample rate.
Sun, Feb 10, 8:05 PM · Baloo, Frameworks
astippich accepted D18900: Avoid side effects due to stale errno value.
Sun, Feb 10, 6:50 PM · Baloo, Frameworks
astippich committed R499:6f21826d9e8d: Add new dependency for KFileMetaData (authored by astippich).
Add new dependency for KFileMetaData
Sun, Feb 10, 6:44 PM
astippich closed D18906: Add new dependency for KFileMetaData.
Sun, Feb 10, 6:44 PM
astippich requested review of D18906: Add new dependency for KFileMetaData.
Sun, Feb 10, 6:37 PM
astippich committed R877:4cf9bccf38f7: Add KCoreAddons as dependency for KFileMetaData (authored by astippich).
Add KCoreAddons as dependency for KFileMetaData
Sun, Feb 10, 6:10 PM
astippich closed D18905: Add KCoreAddons as dependency for KFileMetaData.
Sun, Feb 10, 6:10 PM
astippich requested review of D18905: Add KCoreAddons as dependency for KFileMetaData.
Sun, Feb 10, 5:58 PM
astippich committed R286:4bedfd6609c6: Add string formatting function to property info (authored by astippich).
Add string formatting function to property info
Sun, Feb 10, 5:36 PM
astippich closed D17245: Add string formatting function to property info.
Sun, Feb 10, 5:36 PM · Baloo, Frameworks

Sat, Feb 9

astippich updated the diff for D17245: Add string formatting function to property info.
  • rebase onto current master
  • rename header
  • update docs
Sat, Feb 9, 4:42 PM · Baloo, Frameworks
astippich committed R293:7415aa60d9f6: Use content to determine mime type (authored by astippich).
Use content to determine mime type
Sat, Feb 9, 2:48 PM
astippich closed D18819: Use content to determine mime type.
Sat, Feb 9, 2:48 PM · Baloo, Frameworks

Thu, Feb 7

astippich updated the test plan for D18826: Rewrite the taglib extractor to use the generic PropertyMap interface.
Thu, Feb 7, 8:06 PM · Baloo, Frameworks
astippich requested review of D18826: Rewrite the taglib extractor to use the generic PropertyMap interface.
Thu, Feb 7, 8:05 PM · Baloo, Frameworks
astippich added a comment to D18819: Use content to determine mime type.

The default match mode tries both file extension and content; this would make it just do content. So I guess if they don't match, the default match mode uses the file extension rather than content? That seems kinda like the opposite of the behavior you'd want; might be worth a Qt bug report and aldo a comment in the code here explaining why we're doing this.

The change itself seems sane since we're actually doing less, more correct work now.

What more is needed to fix 403902?

Thu, Feb 7, 8:01 PM · Baloo, Frameworks
astippich requested review of D18819: Use content to determine mime type.
Thu, Feb 7, 5:21 PM · Baloo, Frameworks

Tue, Feb 5

astippich added inline comments to D18604: Implement support for writing rating information for taglib writer.
Tue, Feb 5, 10:11 PM · Baloo, Frameworks
astippich added a comment to D17245: Add string formatting function to property info.

Can someone please give this a yes or a no?

Tue, Feb 5, 9:44 PM · Baloo, Frameworks
astippich added inline comments to D18604: Implement support for writing rating information for taglib writer.
Tue, Feb 5, 6:50 PM · Baloo, Frameworks
astippich added inline comments to D18601: Rewrite taglib writer to use property interface.
Tue, Feb 5, 6:49 PM · Baloo, Frameworks
astippich added inline comments to D17302: Add test for adding properties to result.
Tue, Feb 5, 6:42 PM · Baloo, Frameworks

Sun, Feb 3

astippich added a comment to D17302: Add test for adding properties to result.

Since nobody seems to care and this is just testing the status quo, I'll merge it next week unless somebody objects

Sun, Feb 3, 1:44 PM · Baloo, Frameworks

Sat, Feb 2

astippich added a dependent revision for D18604: Implement support for writing rating information for taglib writer: D18665: Cleanup taglib writer test.
Sat, Feb 2, 12:14 PM · Baloo, Frameworks
astippich added a dependency for D18665: Cleanup taglib writer test: D18604: Implement support for writing rating information for taglib writer.
Sat, Feb 2, 12:14 PM · Baloo, Frameworks
astippich requested review of D18665: Cleanup taglib writer test.
Sat, Feb 2, 12:14 PM · Baloo, Frameworks
astippich added inline comments to D18604: Implement support for writing rating information for taglib writer.
Sat, Feb 2, 11:45 AM · Baloo, Frameworks
astippich updated the diff for D18604: Implement support for writing rating information for taglib writer.
  • rebase on latest parent revision
Sat, Feb 2, 11:41 AM · Baloo, Frameworks
astippich updated the diff for D18603: Implement more tags for taglib writer.
  • rebase on latest parent revision
Sat, Feb 2, 11:00 AM · Baloo, Frameworks
astippich added inline comments to D18603: Implement more tags for taglib writer.
Sat, Feb 2, 11:00 AM · Baloo, Frameworks
astippich added a comment to D18601: Rewrite taglib writer to use property interface.

I think this becomes better structured when you:

  1. Create one function per file type, with parameters (Taglib::Filestream, KFM::PropertyMap)
  2. From this function, call a generic updateProperties(oldProperties, newProperties) -> mergedProperties
  3. Call the type specific function from TaglibWriter::write(...)

    Especially when taking the changes for writing the rating into account, this would make the code easier to read - handling of different types just once (not once for reading and once for writing), and no upcasting/dynamic_cast of Taglib::File*. It also saves the heap allocation of the concrete TagLib::File implementation.
Sat, Feb 2, 10:46 AM · Baloo, Frameworks
astippich updated the diff for D18601: Rewrite taglib writer to use property interface.
  • rewrite for better readability and to avoid heap allocation
Sat, Feb 2, 10:44 AM · Baloo, Frameworks

Thu, Jan 31

astippich accepted D18450: Add extractor for AppImage files.

Just noticed, you never use the AppDataParser.name(). Is that intentional?
Otherwise looks good, but you may want to wait for someone more experienced than me.

Thu, Jan 31, 10:26 PM · Baloo, Frameworks
astippich added a comment to D18450: Add extractor for AppImage files.

got it up and running!
One question: Why is the extra desktop file parser necessary? Shouldn't all required information be available from the app data parser?

Thu, Jan 31, 9:12 PM · Baloo, Frameworks

Wed, Jan 30

astippich added a dependent revision for D18603: Implement more tags for taglib writer: D18604: Implement support for writing rating information for taglib writer.
Wed, Jan 30, 7:45 AM · Baloo, Frameworks
astippich added a dependency for D18604: Implement support for writing rating information for taglib writer: D18603: Implement more tags for taglib writer.
Wed, Jan 30, 7:45 AM · Baloo, Frameworks