astippich (Alexander Stippich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2017, 1:49 PM (112 w, 5 d)
Availability
Available

Recent Activity

Sat, Dec 7

astippich added a comment to D23859: Radios: add support for images.

I would honestly prefer just to check within the QML side of things and display the default image in case of an error. This way, this would actually also catch issues with local tracks (in case an image was deleted or similar).
But @mgallien would like to check it before, so let's wait for his response.
Actually, I think the way the url checking is implemented is synchronous, e.g. blocking in case of no reply, if I am not mistaken. This should definitely be changed.

Sat, Dec 7, 8:27 PM
astippich added a comment to D25517: Add an option to extract binary data and add front cover property.

ping!

Sat, Dec 7, 6:33 PM · Baloo, Frameworks

Mon, Dec 2

astippich added a comment to D25622: partial solution to accept accentuated characters on windows.

taglibwriter should get the same treatment

Mon, Dec 2, 8:39 AM · Baloo, Frameworks
astippich added a dependent revision for D25518: Extract front cover in the taglib extractor: D25679: Implement writing of front cover in taglibwriter.
Mon, Dec 2, 8:32 AM · Baloo, Frameworks
astippich added a dependency for D25679: Implement writing of front cover in taglibwriter: D25518: Extract front cover in the taglib extractor.
Mon, Dec 2, 8:32 AM · Baloo, Frameworks
astippich requested review of D25679: Implement writing of front cover in taglibwriter.
Mon, Dec 2, 8:32 AM · Baloo, Frameworks
astippich updated the diff for D25518: Extract front cover in the taglib extractor.
  • rebase
Mon, Dec 2, 8:30 AM · Baloo, Frameworks
astippich updated the diff for D25517: Add an option to extract binary data and add front cover property.
  • fix label comment
  • tweaks
Mon, Dec 2, 8:29 AM · Baloo, Frameworks

Wed, Nov 27

astippich added a comment to D25515: Only extract lyrics when the plain text flag is set.

For baloo-widgets, the display of the lyrics tag is disabled anyways. Displaying a large chunk of text does not really look good in the information panel...

Wed, Nov 27, 8:20 AM · Baloo, Frameworks
astippich updated the diff for D25516: Remove unrequired private declarations for taglibextractor.
  • put all helper functions into anonymous namespace
Wed, Nov 27, 8:20 AM · Baloo, Frameworks
astippich added inline comments to D25516: Remove unrequired private declarations for taglibextractor.
Wed, Nov 27, 8:12 AM · Baloo, Frameworks
astippich added inline comments to D25517: Add an option to extract binary data and add front cover property.
Wed, Nov 27, 8:09 AM · Baloo, Frameworks

Mon, Nov 25

astippich updated the diff for D25517: Add an option to extract binary data and add front cover property.
  • fix label comment
Mon, Nov 25, 3:55 PM · Baloo, Frameworks
astippich added a dependent revision for D25517: Add an option to extract binary data and add front cover property: D25518: Extract front cover in the taglib extractor.
Mon, Nov 25, 11:07 AM · Baloo, Frameworks
astippich added dependencies for D25518: Extract front cover in the taglib extractor: D25517: Add an option to extract binary data and add front cover property, D25516: Remove unrequired private declarations for taglibextractor.
Mon, Nov 25, 11:07 AM · Baloo, Frameworks
astippich added a dependent revision for D25516: Remove unrequired private declarations for taglibextractor: D25518: Extract front cover in the taglib extractor.
Mon, Nov 25, 11:07 AM · Baloo, Frameworks
astippich added a comment to D25518: Extract front cover in the taglib extractor.

This is probably how it should have been implemented from the beginning, and not how I did it in the embeddedimagedata class, which duplicates a lot of code and requires additional file operations.
Baloo can continue to work as is due to the new flags.
Taglib writer will follow if this is accepted. Afterwards, I will deprecate embeddedimagedata

Mon, Nov 25, 11:05 AM · Baloo, Frameworks
astippich requested review of D25518: Extract front cover in the taglib extractor.
Mon, Nov 25, 11:03 AM · Baloo, Frameworks
astippich requested review of D25517: Add an option to extract binary data and add front cover property.
Mon, Nov 25, 11:01 AM · Baloo, Frameworks
astippich requested review of D25516: Remove unrequired private declarations for taglibextractor.
Mon, Nov 25, 10:46 AM · Baloo, Frameworks
astippich requested review of D25515: Only extract lyrics when the plain text flag is set.
Mon, Nov 25, 10:45 AM · Baloo, Frameworks

Sat, Nov 23

astippich added a comment to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

For the concept a big +1 from me. I did not even know that we had that in the infocenter...

Sat, Nov 23, 2:29 PM · Baloo, Plasma
astippich added a project to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing: Baloo.
Sat, Nov 23, 2:26 PM · Baloo, Plasma
astippich committed R124:a7a2d277e81f: use new icon for search category (authored by astippich).
use new icon for search category
Sat, Nov 23, 11:53 AM
astippich closed D25345: use new icon for search category.
Sat, Nov 23, 11:53 AM · Plasma
astippich committed R119:f1a6bfa3b876: change icon for baloo kcm (authored by astippich).
change icon for baloo kcm
Sat, Nov 23, 11:52 AM
astippich closed D25344: change icon for baloo kcm.
Sat, Nov 23, 11:52 AM · Plasma

Tue, Nov 19

astippich committed R255:d757f47aca2d: always set new source when track is set (authored by astippich).
always set new source when track is set
Tue, Nov 19, 6:52 PM
astippich committed R255:bec40142aa96: Merge branch 'fixPlaybackSameTrack' into 'release/19.12' (authored by astippich).
Merge branch 'fixPlaybackSameTrack' into 'release/19.12'
Tue, Nov 19, 6:52 PM
astippich committed R255:03f2ac2eaa71: Merge branch 'fixDirectoryPaths' into 'release/19.12' (authored by astippich).
Merge branch 'fixDirectoryPaths' into 'release/19.12'
Tue, Nov 19, 6:52 PM
astippich committed R255:485895c52ce8: always add a slash to the directory path (authored by astippich).
always add a slash to the directory path
Tue, Nov 19, 6:52 PM

Sun, Nov 17

astippich committed R255:7312f34c62bd: Merge branch 'cleanupAndPreparation' into 'release/19.12' (authored by astippich).
Merge branch 'cleanupAndPreparation' into 'release/19.12'
Sun, Nov 17, 12:12 PM
astippich committed R255:907f9ee80d0f: fix one forgotten file modification time and cleanup (authored by astippich).
fix one forgotten file modification time and cleanup
Sun, Nov 17, 12:12 PM

Sat, Nov 16

astippich requested review of D25345: use new icon for search category.
Sat, Nov 16, 7:47 PM · Plasma
astippich committed R266:61331d6ce20a: Add new baloo icons (authored by astippich).
Add new baloo icons
Sat, Nov 16, 7:38 PM
astippich closed T7878: Create or find Icon as Resolved by committing R266:61331d6ce20a: Add new baloo icons.
Sat, Nov 16, 7:38 PM · VDG, Baloo
astippich closed D24957: Add new baloo icons.
Sat, Nov 16, 7:38 PM · Frameworks
astippich requested review of D25344: change icon for baloo kcm.
Sat, Nov 16, 7:36 PM · Plasma
astippich updated the diff for D24957: Add new baloo icons.
  • tweak icon and shadows
  • remove baloo symlink
Sat, Nov 16, 7:32 PM · Frameworks
astippich added a comment to D24957: Add new baloo icons.

the scalable test fails with this one. Is the right solution to just delete the 32px symlink under .../preferences?

Sat, Nov 16, 9:27 AM · Frameworks
astippich committed R266:40acd718572a: Add new preferences search icons (authored by astippich).
Add new preferences search icons
Sat, Nov 16, 9:25 AM
astippich closed D24959: Add new preferences search icons.
Sat, Nov 16, 9:25 AM · Frameworks

Wed, Nov 13

astippich abandoned D23395: Retry manual metadata extraction when baloo returns an empty map.
Wed, Nov 13, 8:41 PM · Baloo
astippich abandoned D23394: Add xattrfetchjob.
Wed, Nov 13, 8:41 PM · Baloo
astippich accepted D25251: Remove no longer used IndexedDataRetriever.
Wed, Nov 13, 8:41 PM · Baloo
astippich accepted D25250: Use realtime indexing as fallback when DB has no property data.

nice

Wed, Nov 13, 8:40 PM · Baloo
astippich accepted D25248: Split handling of on-demand extractor process from IndexedDataRetriever.
Wed, Nov 13, 8:20 PM · Baloo
astippich accepted D25247: Add categorized logging for baloo-widgets.
Wed, Nov 13, 8:13 PM · Baloo
astippich added a comment to D24959: Add new preferences search icons.

any more comments?

Wed, Nov 13, 7:05 PM · Frameworks

Nov 11 2019

astippich added a comment to D23411: Fix crash in writer collection and cleanup.

Thanks! I pushed a fix which disables the test if taglib is not installed

Nov 11 2019, 4:46 PM · Baloo, Frameworks
astippich committed R286:983c49c6953f: disable writercollectiontest when taglib is not installed (authored by astippich).
disable writercollectiontest when taglib is not installed
Nov 11 2019, 4:46 PM

Nov 10 2019

astippich committed R255:fb4503a6db9c: fix for file browser metadata loading after rebase (authored by astippich).
fix for file browser metadata loading after rebase
Nov 10 2019, 11:23 AM
astippich committed R255:cf12bc3a0cf2: remove the musicaudiotrack from databaseinterface (authored by astippich).
remove the musicaudiotrack from databaseinterface
Nov 10 2019, 11:23 AM
astippich committed R255:80c7f1482fdd: cleanup the listeners from MusicAudioTrack (authored by astippich).
cleanup the listeners from MusicAudioTrack
Nov 10 2019, 11:23 AM
astippich committed R255:a52341bae323: consolidate the file scanner (authored by astippich).
consolidate the file scanner
Nov 10 2019, 11:23 AM

Nov 9 2019

astippich updated the diff for D24957: Add new baloo icons.
  • tweak icon and shadows
Nov 9 2019, 11:21 AM · Frameworks
astippich added a comment to D24959: Add new preferences search icons.

Nov 9 2019, 7:54 AM · Frameworks
astippich updated the diff for D24959: Add new preferences search icons.
  • tweak shadows
Nov 9 2019, 7:53 AM · Frameworks

Nov 8 2019

astippich committed R255:216a7e9412ab: Merge branch 'cleanupAudio' into 'master' (authored by astippich).
Merge branch 'cleanupAudio' into 'master'
Nov 8 2019, 9:22 PM
astippich committed R255:3ec1e797f58b: small cleanup (authored by astippich).
small cleanup
Nov 8 2019, 9:22 PM

Nov 7 2019

astippich added inline comments to D23859: Radios: add support for images.
Nov 7 2019, 5:48 PM

Nov 6 2019

astippich added a comment to D23394: Add xattrfetchjob.

ping!

Nov 6 2019, 5:23 PM · Baloo

Nov 3 2019

astippich added a comment to D24959: Add new preferences search icons.

I also think that this is too thin.
If you'd like to do the updates, please go ahead! You can do it much better than me I think

Nov 3 2019, 5:25 PM · Frameworks

Oct 31 2019

astippich committed R255:73a6f36885c5: Merge branch 'fileModificationFixes' into 'master' (authored by astippich).
Merge branch 'fileModificationFixes' into 'master'
Oct 31 2019, 3:41 PM
astippich committed R255:35157c55c791: fixes for file modifications (authored by astippich).
fixes for file modifications
Oct 31 2019, 3:41 PM

Oct 30 2019

astippich added a comment to D24959: Add new preferences search icons.

This is a scaled copy of the kfind magnifier glass. However, it was way too small to be directly usable imho

Oct 30 2019, 3:37 PM · Frameworks

Oct 29 2019

astippich added a comment to D24957: Add new baloo icons.

Oct 29 2019, 6:21 PM · Frameworks
astippich updated the diff for D24959: Add new preferences search icons.
  • modified icon with shadow
Oct 29 2019, 2:43 PM · Frameworks
astippich added a comment to D24958: Delete nepomuk icon.

Thanks @broulik for the hint and @ngraham for being faster than me :)

Oct 29 2019, 2:17 PM · Frameworks
astippich abandoned D25044: Change nepomuk to baloo icon.

Someone was faster :)
https://phabricator.kde.org/R318:686a03550f34270d917125b760e740571ba63360

Oct 29 2019, 2:16 PM · Dolphin
astippich requested review of D25044: Change nepomuk to baloo icon.
Oct 29 2019, 2:15 PM · Dolphin
astippich added a comment to D24958: Delete nepomuk icon.

Can you give me a hint exactly where? I searched for usages and found none, and still cannot find it now

Oct 29 2019, 1:14 PM · Frameworks
astippich committed R255:e27340c3c0e9: Merge branch 'fileModification' into 'master' (authored by astippich).
Merge branch 'fileModification' into 'master'
Oct 29 2019, 11:47 AM
astippich committed R255:f0e7991664ac: check for ctime, not mtime for file modification time (authored by astippich).
check for ctime, not mtime for file modification time
Oct 29 2019, 11:47 AM
astippich committed R266:34fa249177e1: Delete nepomuk icon (authored by astippich).
Delete nepomuk icon
Oct 29 2019, 11:46 AM
astippich closed D24958: Delete nepomuk icon.
Oct 29 2019, 11:46 AM · Frameworks
astippich added a comment to D24959: Add new preferences search icons.

New proposal

Oct 29 2019, 11:39 AM · Frameworks

Oct 26 2019

astippich added a comment to D24959: Add new preferences search icons.

Yes, that is the plan

Oct 26 2019, 7:14 PM · Frameworks
astippich added a comment to D21004: [UserMetaData] Shortcut attribute queries for the common case.

ping

Oct 26 2019, 3:55 PM · Baloo
astippich added a comment to D24959: Add new preferences search icons.

Correct

Oct 26 2019, 3:41 PM · Frameworks
astippich added a comment to D23859: Radios: add support for images.

Thanks for your feedback,

To be honest, I don't know how useful this is when the image must be added manually. Ideally, this would be retrieved automatically. However, this could provide the base for such a feature.

I agree about the fact that images should be retrieved automatically in some way. We should define how, what do you think ?
I also think it can be useful if the user adds its how radio and wants a particular image to visually identify it in the list.

Oct 26 2019, 10:34 AM
astippich added a comment to D24959: Add new preferences search icons.


Basically the icon from D24957 without the paw

Oct 26 2019, 9:41 AM · Frameworks
astippich requested review of D24959: Add new preferences search icons.
Oct 26 2019, 9:39 AM · Frameworks
astippich added a comment to D24957: Add new baloo icons.

Before:


which is basically a copy of the kfind icon

Oct 26 2019, 9:35 AM · Frameworks
astippich requested review of D24958: Delete nepomuk icon.
Oct 26 2019, 8:24 AM · Frameworks
astippich added a comment to D24957: Add new baloo icons.

Oct 26 2019, 8:23 AM · Frameworks
astippich requested review of D24957: Add new baloo icons.
Oct 26 2019, 8:22 AM · Frameworks

Oct 25 2019

astippich committed R255:419aca6f6f4f: Merge branch 'newIcons' into 'master' (authored by astippich).
Merge branch 'newIcons' into 'master'
Oct 25 2019, 6:56 AM
astippich committed R255:535081e34fe0: update to new Elisa icon (authored by astippich).
update to new Elisa icon
Oct 25 2019, 6:56 AM

Oct 21 2019

astippich added a comment to T7878: Create or find Icon.

Before opening a revision, I have actually a question about what to update in breeze-icons.
There are currently 32px icons under preferences:
-preferences-desktop-baloo.svg, which is a 32px version of the kfind app icon
-baloo.svg as a symlink to preferences-desktop-baloo.svg, which seems to be used by the kcm
-nepomuk.svg (!) as a symlink to -preferences-desktop-baloos.svg

Oct 21 2019, 6:37 PM · VDG, Baloo
astippich committed R266:a51651fd91a2: Update elisa icon (authored by astippich).
Update elisa icon
Oct 21 2019, 6:25 PM
astippich closed D24598: Update elisa icon.
Oct 21 2019, 6:25 PM · Elisa, Frameworks

Oct 17 2019

astippich added a comment to T7878: Create or find Icon.

48px


32px with own icon, since its required for system settings

Oct 17 2019, 7:16 PM · VDG, Baloo
astippich updated the diff for D24598: Update elisa icon.
  • update and save as optimized svg
Oct 17 2019, 7:01 PM · Elisa, Frameworks
astippich added a comment to D23402: Show tracks with empty titles.

I spent some time on this. It should be possible to at least cover the no metadata case with requests only on TracksData. What do you think?

If you want, I can try to do that on gitlab?

It should be easier to extend it to the full solution by working together on it and using your work as a basis.

Oct 17 2019, 6:58 PM · Elisa

Oct 16 2019

astippich added a comment to D23859: Radios: add support for images.

Sorry for the late reply.
To be honest, I don't know how useful this is when the image must be added manually. Ideally, this would be retrieved automatically. However, this could provide the base for such a feature.

Oct 16 2019, 7:12 PM
astippich added a comment to T7878: Create or find Icon.

Proposal:

Oct 16 2019, 6:24 PM · VDG, Baloo
astippich added a comment to D24598: Update elisa icon.

This is with the tape window moved up 1px


When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment.
If everyone is okay with this, I will update the revision with the optimized svgs.
I don't think that filling this space is useful.

Oct 16 2019, 4:55 PM · Elisa, Frameworks

Oct 13 2019

astippich added a comment to T5375: Add Management of Ratings for Tracks from Local Files.

just did it: https://invent.kde.org/kde/elisa/merge_requests/9

Oct 13 2019, 12:01 PM · Elisa
astippich added a comment to T5375: Add Management of Ratings for Tracks from Local Files.

no, not yet. it will require Kf 5.64

Oct 13 2019, 11:53 AM · Elisa