astippich (Alexander Stippich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 14 2017, 1:49 PM (60 w, 4 d)
Availability
Available

Recent Activity

Yesterday

astippich added a comment to D17302: add simple test for string merging.

I was recently wondering if this is actually desired behavior. Right now it is definitely required since KFileMetaData wrongly outputs QStrings instead of a QStringList, but when this is fixed, this behavior should be removed imho. Otherwise, querying metadata via KFileMetaData and via Baloo differs in output, which it shouldn't.

Wed, Dec 12, 9:49 AM · Baloo, Frameworks
astippich added a comment to D17500: Restore mobipocket extractor.

Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :(
Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail extractor actually be part of kio-extras? Seems quite kio-specific, and a quick look at lxr didn't reveal any usages of the thumbnailer.

Wed, Dec 12, 9:19 AM · Baloo, Frameworks

Tue, Dec 11

astippich updated the diff for D17500: Restore mobipocket extractor.
  • add missing test file
Tue, Dec 11, 9:02 AM · Baloo, Frameworks
astippich added a comment to D17500: Restore mobipocket extractor.

I was unable to get a version check running with cmake, any help is appreciated

Tue, Dec 11, 8:50 AM · Baloo, Frameworks
astippich updated the summary of D17500: Restore mobipocket extractor.
Tue, Dec 11, 8:49 AM · Baloo, Frameworks
astippich requested review of D17500: Restore mobipocket extractor.
Tue, Dec 11, 8:48 AM · Baloo, Frameworks
astippich added a comment to D17245: Add string formatting function to property info.

any further comments/objections?

Tue, Dec 11, 8:33 AM · Baloo, Frameworks
astippich committed R293:60d6fc82ae5a: add documentation to result class (authored by astippich).
add documentation to result class
Tue, Dec 11, 8:32 AM
astippich closed D17301: add documentation to result class.
Tue, Dec 11, 8:32 AM · Baloo, Frameworks
astippich updated the diff for D17302: add simple test for string merging.
  • updates for master
Tue, Dec 11, 8:31 AM · Baloo, Frameworks
astippich committed R286:239b0ef2b23b: fail writing test if mime type is not supported by the extractor (authored by astippich).
fail writing test if mime type is not supported by the extractor
Tue, Dec 11, 8:28 AM
astippich closed D16716: fail writing test if mime type is not supported by the extractor.
Tue, Dec 11, 8:28 AM · Baloo, Frameworks
astippich accepted D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace.
Tue, Dec 11, 8:27 AM · Baloo, Frameworks

Thu, Dec 6

astippich added a comment to D16658: Respect the display property of buttons.

ping

Thu, Dec 6, 7:12 PM · Plasma
astippich retitled D16716: fail writing test if mime type is not supported by the extractor from skip writing test if mime type is not supported by the extractor to fail writing test if mime type is not supported by the extractor.
Thu, Dec 6, 7:09 PM · Baloo, Frameworks
astippich requested review of D17391: add support for more mimetypes to taglibwriter.
Thu, Dec 6, 6:47 PM · Baloo, Frameworks
astippich added a comment to D16716: fail writing test if mime type is not supported by the extractor.

Well, if it is not even signaled via ctest, that's pretty bad, I agree

Thu, Dec 6, 6:28 PM · Baloo, Frameworks
astippich updated the diff for D16716: fail writing test if mime type is not supported by the extractor.
  • use QFAIL
Thu, Dec 6, 6:27 PM · Baloo, Frameworks
astippich added inline comments to D17301: add documentation to result class.
Thu, Dec 6, 6:23 PM · Baloo, Frameworks
astippich updated the diff for D17301: add documentation to result class.
  • rephase description of TermGenerator
Thu, Dec 6, 6:22 PM · Baloo, Frameworks
astippich committed R286:5ac6f4eac1d2: fix ape disc number extraction (authored by astippich).
fix ape disc number extraction
Thu, Dec 6, 6:14 PM
astippich committed R286:2a41e4b45262: implement cover extraction for asf files (authored by astippich).
implement cover extraction for asf files
Thu, Dec 6, 6:12 PM
astippich closed D17358: implement cover extraction for asf files.
Thu, Dec 6, 6:12 PM · Baloo, Frameworks
astippich committed R286:9f67b436f851: extend list of supported mimetypes for embedded image extractor (authored by astippich).
extend list of supported mimetypes for embedded image extractor
Thu, Dec 6, 6:10 PM
astippich closed D17357: extend list of supported mimetypes for embedded image extractor.
Thu, Dec 6, 6:10 PM · Baloo, Frameworks
astippich updated the summary of D17357: extend list of supported mimetypes for embedded image extractor.
Thu, Dec 6, 6:09 PM · Baloo, Frameworks
astippich committed R286:7929a896b5e1: Refactor embedded image extractor for greater extensibility (authored by astippich).
Refactor embedded image extractor for greater extensibility
Thu, Dec 6, 6:08 PM
astippich closed D16671: Refactor embedded image extractor for greater extensibility.
Thu, Dec 6, 6:08 PM · Baloo, Frameworks
astippich committed R244:0b58dc656d1a: make units and prefixes of formatValue translatable (authored by astippich).
make units and prefixes of formatValue translatable
Thu, Dec 6, 5:47 PM
astippich closed D15829: make units and prefixes of formatValue translatable.
Thu, Dec 6, 5:47 PM · Frameworks

Wed, Dec 5

astippich added inline comments to D16671: Refactor embedded image extractor for greater extensibility.
Wed, Dec 5, 7:20 AM · Baloo, Frameworks
astippich updated the diff for D16671: Refactor embedded image extractor for greater extensibility.
  • new lines, handle dataPosition == -1
Wed, Dec 5, 7:19 AM · Baloo, Frameworks

Tue, Dec 4

astippich accepted D17324: Move internal helper from BasicIndexingJob to anonymous namespace.
Tue, Dec 4, 8:00 PM · Baloo, Frameworks
astippich updated the diff for D17358: implement cover extraction for asf files.
  • fix
Tue, Dec 4, 7:54 PM · Baloo, Frameworks
astippich added a dependency for D17358: implement cover extraction for asf files: D17357: extend list of supported mimetypes for embedded image extractor.
Tue, Dec 4, 7:52 PM · Baloo, Frameworks
astippich added a dependent revision for D17357: extend list of supported mimetypes for embedded image extractor: D17358: implement cover extraction for asf files.
Tue, Dec 4, 7:52 PM · Baloo, Frameworks
astippich added a dependency for D17357: extend list of supported mimetypes for embedded image extractor: D16671: Refactor embedded image extractor for greater extensibility.
Tue, Dec 4, 7:52 PM · Baloo, Frameworks
astippich added a dependent revision for D16671: Refactor embedded image extractor for greater extensibility: D17357: extend list of supported mimetypes for embedded image extractor.
Tue, Dec 4, 7:52 PM · Baloo, Frameworks
astippich committed R286:9af53a0b33f4: add missing wav mimetype (authored by astippich).
add missing wav mimetype
Tue, Dec 4, 7:48 PM
astippich updated the task description for T8196: KFileMetadata: String lists. How do clients cope?.
Tue, Dec 4, 7:42 PM · Dolphin, Elisa, Frameworks, Baloo
astippich added a comment to D17301: add documentation to result class.

Thanks for your patience :)

Tue, Dec 4, 7:31 PM · Baloo, Frameworks
astippich updated the diff for D17301: add documentation to result class.
  • remove docstring for reimplemented functions
Tue, Dec 4, 7:31 PM · Baloo, Frameworks
astippich requested review of D17358: implement cover extraction for asf files.
Tue, Dec 4, 7:30 PM · Baloo, Frameworks
astippich requested review of D17357: extend list of supported mimetypes for embedded image extractor.
Tue, Dec 4, 7:27 PM · Baloo, Frameworks
astippich updated the diff for D16671: Refactor embedded image extractor for greater extensibility.
  • rebase
Tue, Dec 4, 7:24 PM · Baloo, Frameworks
astippich added a comment to D17245: Add string formatting function to property info.

I'm wondering, anything else to do if I add a new dependency to KFileMetaData?

Tue, Dec 4, 7:23 PM · Baloo, Frameworks
astippich updated the diff for D17245: Add string formatting function to property info.
  • small fixes
Tue, Dec 4, 7:21 PM · Baloo, Frameworks

Mon, Dec 3

astippich abandoned D17300: add result to baloo namespace.
Mon, Dec 3, 6:43 PM · Baloo, Frameworks
astippich accepted D17315: Avoid potential nullptr access for Document, use reference instead.
Mon, Dec 3, 6:43 PM · Baloo, Frameworks

Sun, Dec 2

astippich closed D16931: Extract more tags from exif metadata.
Sun, Dec 2, 8:58 PM · Baloo, Frameworks
astippich committed R286:0b35de4243aa: Extract more tags from exif metadata (authored by astippich).
Extract more tags from exif metadata
Sun, Dec 2, 8:58 PM
astippich committed R824:b253e8c78bc4: Merge branch 'Applications/18.12' (authored by astippich).
Merge branch 'Applications/18.12'
Sun, Dec 2, 8:53 PM
astippich committed R824:2ec4467468af: Fix display of string lists (authored by astippich).
Fix display of string lists
Sun, Dec 2, 8:48 PM
astippich closed D17322: Fix display of string lists.
Sun, Dec 2, 8:48 PM · Baloo
astippich updated the diff for D17301: add documentation to result class.
  • more adjustments
Sun, Dec 2, 8:34 PM · Baloo, Frameworks
astippich added a comment to D17315: Avoid potential nullptr access for Document, use reference instead.

This one doesn't apply, looks like D17824 is a dependency?

D17312

Sun, Dec 2, 8:27 PM · Baloo, Frameworks
astippich added a reviewer for D17322: Fix display of string lists: Baloo.
Sun, Dec 2, 8:04 PM · Baloo
astippich closed D17298: remove unused docId from result.
Sun, Dec 2, 7:57 PM · Baloo, Frameworks
astippich committed R293:647823d36592: remove unused docId from result (authored by astippich).
remove unused docId from result
Sun, Dec 2, 7:57 PM
astippich added a comment to D17322: Fix display of string lists.

Unfortunately I missed the deadline with this one for Applications 18.12. I don't know the exact criteria if this is acceptable for stable or not.

Sun, Dec 2, 7:53 PM · Baloo
astippich requested review of D17322: Fix display of string lists.
Sun, Dec 2, 7:52 PM · Baloo
astippich updated the task description for T8196: KFileMetadata: String lists. How do clients cope?.
Sun, Dec 2, 7:05 PM · Dolphin, Elisa, Frameworks, Baloo
astippich added a comment to D16671: Refactor embedded image extractor for greater extensibility.

anyone? I would like to extend the support to the same file types as supported by the taglibextractor

Sun, Dec 2, 6:43 PM · Baloo, Frameworks
astippich added a comment to D17315: Avoid potential nullptr access for Document, use reference instead.

This one doesn't apply, looks like D17824 is a dependency?

Sun, Dec 2, 6:40 PM · Baloo, Frameworks
astippich updated the diff for D17300: add result to baloo namespace.
  • rebase
Sun, Dec 2, 6:25 PM · Baloo, Frameworks
astippich accepted D17313: Use Compact json formatting for storing document metadata.
Sun, Dec 2, 6:24 PM · Baloo, Frameworks
astippich accepted D17312: Remove unused map() getter from Result.
Sun, Dec 2, 6:09 PM · Baloo, Frameworks
astippich removed a dependency for D17298: remove unused docId from result: D16826: Treat uints the same as ints.
Sun, Dec 2, 6:05 PM · Baloo, Frameworks
astippich removed a dependent revision for D16826: Treat uints the same as ints: D17298: remove unused docId from result.
Sun, Dec 2, 6:05 PM · Baloo, Frameworks
astippich abandoned D17299: move implementation of document get to cpp file.
Sun, Dec 2, 6:02 PM · Baloo, Frameworks
astippich updated the summary of D17298: remove unused docId from result.
Sun, Dec 2, 5:54 PM · Baloo, Frameworks
astippich added inline comments to D17302: add simple test for string merging.
Sun, Dec 2, 2:49 PM · Baloo, Frameworks
astippich updated the diff for D17302: add simple test for string merging.
  • small fixes
Sun, Dec 2, 2:48 PM · Baloo, Frameworks
astippich committed R293:f6f9ecb2a17e: Treat uints the same as ints (authored by astippich).
Treat uints the same as ints
Sun, Dec 2, 2:37 PM
astippich closed D16826: Treat uints the same as ints.
Sun, Dec 2, 2:37 PM · Baloo, Frameworks
astippich updated the diff for D17301: add documentation to result class.
  • implement feedback
Sun, Dec 2, 2:12 PM · Baloo, Frameworks
astippich added a comment to D17299: move implementation of document get to cpp file.

Really just a cosmetic change for consistency, if you don't want it in, I'm fine with dropping it

Sun, Dec 2, 2:05 PM · Baloo, Frameworks
astippich accepted D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups.
Sun, Dec 2, 11:46 AM · Baloo, Frameworks
astippich added a comment to D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups.

Weird, why does Phabricator think termgeneratortest.cpp is a binary file?

Sun, Dec 2, 11:46 AM · Baloo, Frameworks
astippich updated the diff for D17245: Add string formatting function to property info.
  • update strings for image orientation
Sun, Dec 2, 11:40 AM · Baloo, Frameworks
astippich added a comment to D17301: add documentation to result class.

Thanks!

Sun, Dec 2, 11:36 AM · Baloo, Frameworks
astippich updated the diff for D17301: add documentation to result class.
  • use param
Sun, Dec 2, 11:34 AM · Baloo, Frameworks
astippich added a comment to D17302: add simple test for string merging.

Didn't found what I wanted to find, but since the code is there we can add it.

Sun, Dec 2, 11:29 AM · Baloo, Frameworks
astippich requested review of D17302: add simple test for string merging.
Sun, Dec 2, 11:28 AM · Baloo, Frameworks
astippich added a comment to D17301: add documentation to result class.

I had the impression that I have to read a lot of code just to know which variable does what, so I wrote some simple documentation.
Please check if I got anything wrong.

Sun, Dec 2, 11:21 AM · Baloo, Frameworks
astippich added a dependent revision for D17300: add result to baloo namespace: D17301: add documentation to result class.
Sun, Dec 2, 11:20 AM · Baloo, Frameworks
astippich added a dependency for D17301: add documentation to result class: D17300: add result to baloo namespace.
Sun, Dec 2, 11:20 AM · Baloo, Frameworks
astippich added a dependent revision for D17299: move implementation of document get to cpp file: D17300: add result to baloo namespace.
Sun, Dec 2, 11:19 AM · Baloo, Frameworks
astippich added a dependency for D17300: add result to baloo namespace: D17299: move implementation of document get to cpp file.
Sun, Dec 2, 11:19 AM · Baloo, Frameworks
astippich added a dependency for D17299: move implementation of document get to cpp file: D17298: remove unused docId from result.
Sun, Dec 2, 11:19 AM · Baloo, Frameworks
astippich added a dependent revision for D17298: remove unused docId from result: D17299: move implementation of document get to cpp file.
Sun, Dec 2, 11:19 AM · Baloo, Frameworks
astippich added a dependency for D17298: remove unused docId from result: D16826: Treat uints the same as ints.
Sun, Dec 2, 11:18 AM · Baloo, Frameworks
astippich added a dependent revision for D16826: Treat uints the same as ints: D17298: remove unused docId from result.
Sun, Dec 2, 11:18 AM · Baloo, Frameworks
astippich requested review of D17301: add documentation to result class.
Sun, Dec 2, 11:18 AM · Baloo, Frameworks
astippich requested review of D17300: add result to baloo namespace.
Sun, Dec 2, 11:15 AM · Baloo, Frameworks
astippich requested review of D17299: move implementation of document get to cpp file.
Sun, Dec 2, 11:13 AM · Baloo, Frameworks
astippich requested review of D17298: remove unused docId from result.
Sun, Dec 2, 11:07 AM · Baloo, Frameworks
astippich updated the summary of D16826: Treat uints the same as ints.
Sun, Dec 2, 10:58 AM · Baloo, Frameworks
astippich updated the diff for D16826: Treat uints the same as ints.
  • only add uints for now
Sun, Dec 2, 10:57 AM · Baloo, Frameworks

Sat, Dec 1

astippich added a comment to D16826: Treat uints the same as ints.

Okay, so there is more work to do for floats. What about then reducing this patch to uints for now, and doubles are added when everything else is in place?
I have something in the pipeline for the Result class, which I added for figuring out how string lists are handled, I can probably post that tomorrow. I could then extend the test for floats

Sat, Dec 1, 5:38 PM · Baloo, Frameworks