- User Since
- Oct 14 2017, 1:49 PM (96 w, 5 d)
Tue, Aug 20
deleting a radio is not possible anymore, and upon opening the metadata view qml shows some warnings
Sun, Aug 18
Sat, Aug 17
From my point of view, this is mergeable. The trackmetadata stuff is not ideal yet, but this is something we can do later. We have to revisit this anyways when Elisa gets metadata editing.
Great, thanks again
Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?
If you would like to start contributing, you may have a look at the Junior Jobs column of the tasks or try to fix some bugs at https://bugs.kde.org/buglist.cgi?component=general&list_id=1655384&product=elisa&resolution=---
Thu, Aug 15
Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?
- rebase on master
Wed, Aug 14
Sorry, overlooked this one.
I quite like the behavior, but why do you limit it to 3 minimum items? This prohibits scaling the window to a small size and actually makes them items overlapped when forcing it into one corner of the screen.
Tue, Aug 13
- fix code style again
- fix code style and unrelated changes
- fix remaining tracks label
I don't want to remove ManageHeaderBar, on the contrary. This is a simplification and cleanup in order to easily extend it in the future after D22771, which is the goal of this whole series.
While working on it, I found that the ManageHeaderBar is needlessly entangled to the MediaPlayList by connecting to all of those signals, but which are mostly ignored. This is just because of the remaining tracks, for which the MediaPlayList is the correct place to retrieve the information.
By only connecting to the currentTrackChanged signal, the rest can be implemented much more easily. D22771 is working towards T7674
Please note that I cannot test this myself due to lack of a high DPI monitor
Thu, Aug 8
Thanks. Just wanted to make sure that it does not fall through
The artists view is not working properly now with a fresh database. The artists are correctly shown. But when clicking on them no albums show up
friendly ping @mgallien for the series
Sun, Aug 4
Sat, Aug 3
It now shows duplicated artists in the albums view here
- further simplify
Mon, Jul 29
Sun, Jul 28
Nice progress, I think we are getting there!
Some comments inline which look like a lot, but most of them are style nitpicks
It's amazing how you notice these little things :) thanks!
- force focus upon entering expandend state
Sat, Jul 27
Thu, Jul 25
Is anybody working on this?