ouwerkerk (Johan Ouwerkerk)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 3 2017, 7:23 PM (160 w, 5 d)
Availability
Available

Recent Activity

Thu, Mar 26

ouwerkerk committed R169:c9bbe6dea5a1: Add useful input method hints to password field by default (authored by ouwerkerk).
Add useful input method hints to password field by default
Thu, Mar 26, 7:03 PM
ouwerkerk closed D28316: Add useful input method hints to password field by default.
Thu, Mar 26, 7:03 PM · Kirigami
ouwerkerk updated the summary of D28316: Add useful input method hints to password field by default.
Thu, Mar 26, 5:56 PM · Kirigami
ouwerkerk added a reviewer for D28316: Add useful input method hints to password field by default: Kirigami.
Thu, Mar 26, 5:52 PM · Kirigami
ouwerkerk requested review of D28316: Add useful input method hints to password field by default.
Thu, Mar 26, 5:51 PM · Kirigami

Sun, Mar 22

ouwerkerk committed R857:bb31c1c061de: Update builder images to include libsodium (authored by ouwerkerk).
Update builder images to include libsodium
Sun, Mar 22, 7:20 AM

Fri, Mar 13

ouwerkerk committed R857:01fbc16524a5: Provide a generic autotools helper script (wrapper around build-standalone) (authored by ouwerkerk).
Provide a generic autotools helper script (wrapper around build-standalone)
Fri, Mar 13, 7:12 PM

Jan 12 2020

ouwerkerk committed R365:c1bab23978ec: Add 'native' support for using CMake toolchain files with KDE projects (authored by ouwerkerk).
Add 'native' support for using CMake toolchain files with KDE projects
Jan 12 2020, 7:17 PM
ouwerkerk committed R365:2cd07365db50: Update documentation to cover CMake toolchain support. (authored by ouwerkerk).
Update documentation to cover CMake toolchain support.
Jan 12 2020, 7:17 PM

Jan 5 2020

ouwerkerk committed R365:c8c091d94b48: Update old tests to take CMake generator options into account. (authored by ouwerkerk).
Update old tests to take CMake generator options into account.
Jan 5 2020, 12:48 AM
ouwerkerk committed R365:54621a068cba: Update documentation to cover CMake generator support. (authored by ouwerkerk).
Update documentation to cover CMake generator support.
Jan 5 2020, 12:48 AM
ouwerkerk committed R365:041118921fcb: Add 'native' support for using Ninja with CMake for KDE projects (authored by ouwerkerk).
Add 'native' support for using Ninja with CMake for KDE projects
Jan 5 2020, 12:48 AM

Jan 2 2020

ouwerkerk abandoned D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12)..

Cleanup.

Jan 2 2020, 3:02 PM · Kirigami
ouwerkerk abandoned D26344: Fix building plasma-desktop without X11 cursor development headers.

Superseded by: https://phabricator.kde.org/D26367

Jan 2 2020, 3:01 PM · Plasma
ouwerkerk committed R119:1c43e1b4f7b1: Make the lookandfeel KCM build without XCursor support (authored by ouwerkerk).
Make the lookandfeel KCM build without XCursor support
Jan 2 2020, 2:58 PM
ouwerkerk closed D26367: Make the lookandfeel KCM build without XCursor support.
Jan 2 2020, 2:58 PM · Plasma
ouwerkerk added a reviewer for D26367: Make the lookandfeel KCM build without XCursor support: Plasma.
Jan 2 2020, 2:34 PM · Plasma
ouwerkerk requested review of D26367: Make the lookandfeel KCM build without XCursor support.
Jan 2 2020, 2:32 PM · Plasma
ouwerkerk added a comment to D26354: Introduce ActionRow widget.

Are we certain about naming here: SwipeAction.isDelete? Maybe SwipeAction.collapse ? It doesn't necessarily have to be a real "delete" action that is backing this, maybe all you want to convey with the name of this setting is that the list entry will be collapsed in an animation?

Jan 2 2020, 12:14 AM · Kirigami

Jan 1 2020

ouwerkerk added a comment to D26344: Fix building plasma-desktop without X11 cursor development headers.

Right now the KCM CmakeListst does stuff like:

Jan 1 2020, 11:55 PM · Plasma
ouwerkerk added a comment to T12400: Consider what position KDE Neon should take regarding Flatpak, Snaps, and packages future.

If I understand "the Neon position" correctly here, Neon aims to be the base OS + Plasma desktop. The only reason it still bothers with packaging apps is because it has to because nobody is going to use an empty shell, and the Linux world isn't all app-ified yet.

Jan 1 2020, 11:41 PM · Neon
ouwerkerk updated the diff for D26344: Fix building plasma-desktop without X11 cursor development headers.

Fixed commit message typo

Jan 1 2020, 4:09 PM · Plasma
ouwerkerk added a reviewer for D26344: Fix building plasma-desktop without X11 cursor development headers: Plasma.
Jan 1 2020, 3:50 PM · Plasma
ouwerkerk requested review of D26344: Fix building plasma-desktop without X11 cursor development headers.
Jan 1 2020, 3:50 PM · Plasma
ouwerkerk added a comment to T12400: Consider what position KDE Neon should take regarding Flatpak, Snaps, and packages future.

As far as I am aware our flatpaks are purely packaging formats and don't take advantage of any sandboxing features. So I don't see what is there to recommend our flatpak implementation over our snap implementation, say. But then again, that could be part of this: pushing the packaging forward.
On the other hand: has anybody asked the application developers about their opinion on this? After all, they will be expected to take on additional maintenance efforts to make sure their app continue to work well with the chosen packaging format and they might just have opinions on that.

Jan 1 2020, 2:19 PM · Neon

Dec 31 2019

ouwerkerk committed R499:76d422dd773c: Update dependency data for Keysmith to include KF5 i18n (authored by ouwerkerk).
Update dependency data for Keysmith to include KF5 i18n
Dec 31 2019, 8:04 PM
ouwerkerk closed D26336: Update dependency data for Keysmith to include KF5 i18n.
Dec 31 2019, 8:04 PM
ouwerkerk updated the diff for D26336: Update dependency data for Keysmith to include KF5 i18n.

Rebased onto latest master

Dec 31 2019, 6:18 PM
ouwerkerk requested review of D26336: Update dependency data for Keysmith to include KF5 i18n.
Dec 31 2019, 6:11 PM
ouwerkerk added a comment to D26304: [PageRow] Disable swipe forwards/backwards gesture by default.

This completely alters one of the core propositions of how a Kirigami UX works. I may be mistaken, but if I understand it correctly drawers are supposed to be accessible via buttons. If gestures conflict, why remove page row navigation by gesture rather than drawer gestures?

Dec 31 2019, 4:59 PM · Kirigami

Dec 28 2019

ouwerkerk committed R499:23b6c435db4d: Add proper dependency data for Keysmith: it does not actually need all of KF5 (authored by ouwerkerk).
Add proper dependency data for Keysmith: it does not actually need all of KF5
Dec 28 2019, 12:25 PM
ouwerkerk closed D26249: Add proper dependency data for Keysmith: it does not actually need all of KF5.
Dec 28 2019, 12:25 PM
ouwerkerk requested review of D26249: Add proper dependency data for Keysmith: it does not actually need all of KF5.
Dec 28 2019, 3:00 AM

Oct 22 2019

ouwerkerk committed R857:caef857fc303: Use default parameters instead of a global before_script block (authored by ouwerkerk).
Use default parameters instead of a global before_script block
Oct 22 2019, 10:17 AM

Sep 30 2019

ouwerkerk added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

Also side note, as a non-native English speaker I find "grossly" to be a bit of an odd adjective to use here -- "coarsely" would be more familiar: as in fine/coarse grained. Perhaps something to keep in mind when this lands and you start blogging about it :)

Sep 30 2019, 9:19 PM · Plasma
ouwerkerk added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

Ideally you would also warn if the reciprocal times the horizontal, vertical resolution yields a non-integer output, not just if some value is chosen which cannot be represented in floating point exactly.

Sep 30 2019, 9:01 PM · Plasma

Sep 24 2019

ouwerkerk added a comment to D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12)..

And if so, sure I can 'fix' this by downgrading to QQC 2.4 instead but in that case: is this 'safe'? I.e. does this introduce bugs/regressions?

Sep 24 2019, 3:02 PM · Kirigami
ouwerkerk added a comment to D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12)..

If Kirigami is supposed to depend on Qt 5.11, then *why* were these old imports there in the first place? They cannot work with Qt 5.11, because then the max QQC version is 2.4

Sep 24 2019, 3:01 PM · Kirigami
ouwerkerk requested review of D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12)..
Sep 24 2019, 2:17 PM · Kirigami

Sep 8 2019

ouwerkerk committed R365:a245faba85cb: Make sure to record & expose the modules derived from the command line in ksb… (authored by ouwerkerk).
Make sure to record & expose the modules derived from the command line in ksb…
Sep 8 2019, 6:08 PM
ouwerkerk committed R365:eb5451199b31: Reimplement dependency tree output formatting in the TTY client UI. (authored by ouwerkerk).
Reimplement dependency tree output formatting in the TTY client UI.
Sep 8 2019, 6:08 PM

Sep 7 2019

ouwerkerk committed R365:a29c7f6d583c: Introduce a DTO for exporting dependency information. (authored by ouwerkerk).
Introduce a DTO for exporting dependency information.
Sep 7 2019, 8:07 PM

Aug 24 2019

ouwerkerk committed R365:86faa8999996: Merge branch 'patch-1' into 'master' (authored by ouwerkerk).
Merge branch 'patch-1' into 'master'
Aug 24 2019, 7:47 PM

Aug 20 2019

ouwerkerk committed R365:472fb418b714: Update smoke test(s) to the refactored ksb::Application (authored by ouwerkerk).
Update smoke test(s) to the refactored ksb::Application
Aug 20 2019, 12:31 AM
ouwerkerk committed R365:8fd02395cf27: Print a top 5 of most 'interesting' failures when the build fails. (authored by ouwerkerk).
Print a top 5 of most 'interesting' failures when the build fails.
Aug 20 2019, 12:31 AM
ouwerkerk committed R365:4becb4eba1ec: Add unit tests for debug ordering feature. (authored by ouwerkerk).
Add unit tests for debug ordering feature.
Aug 20 2019, 12:31 AM
ouwerkerk committed R365:8be6358cafb6: Provide utilities to estimate how 'interesting' one failure (module) is versus… (authored by ouwerkerk).
Provide utilities to estimate how 'interesting' one failure (module) is versus…
Aug 20 2019, 12:31 AM

Aug 16 2019

ouwerkerk committed R365:9265efc18a20: Fixup: do not print the most 'interesting' module list if there are fewer than… (authored by ouwerkerk).
Fixup: do not print the most 'interesting' module list if there are fewer than…
Aug 16 2019, 9:29 PM
ouwerkerk committed R365:5835e6c2eb02: Fixup: persistent failure count is available directly from the module, need not… (authored by ouwerkerk).
Fixup: persistent failure count is available directly from the module, need not…
Aug 16 2019, 8:53 PM
ouwerkerk committed R365:9922e2d11eda: Fixup: no need to populate persistent failure counts in extra debug info… (authored by ouwerkerk).
Fixup: no need to populate persistent failure counts in extra debug info…
Aug 16 2019, 8:53 PM

Aug 10 2019

ouwerkerk committed R365:fa8cd4710e1b: Print a top 5 of most 'interesting' failures when the build fails. (authored by ouwerkerk).
Print a top 5 of most 'interesting' failures when the build fails.
Aug 10 2019, 9:32 PM
ouwerkerk committed R365:bf98639136eb: Provide utilities to estimate how 'interesting' one failure (module) is versus… (authored by ouwerkerk).
Provide utilities to estimate how 'interesting' one failure (module) is versus…
Aug 10 2019, 9:32 PM

Apr 21 2019

ouwerkerk committed R365:e240d0cb5867: Use a well-known 'third-party/' prefix for dependency paths of non-KDE modules. (authored by ouwerkerk).
Use a well-known 'third-party/' prefix for dependency paths of non-KDE modules.
Apr 21 2019, 5:31 PM
ouwerkerk committed R365:ec336711def3: Remove the hack for prioritising non-KDE modules when sorting modules in build… (authored by ouwerkerk).
Remove the hack for prioritising non-KDE modules when sorting modules in build…
Apr 21 2019, 5:31 PM
ouwerkerk committed R499:4259d816fe70: Attempt to fixup dependency data declarations for non-KDE modules (authored by ouwerkerk).
Attempt to fixup dependency data declarations for non-KDE modules
Apr 21 2019, 5:25 PM
ouwerkerk closed D20279: Attempt to fixup dependency data declarations for non-KDE modules.
Apr 21 2019, 5:25 PM

Apr 17 2019

ouwerkerk added a comment to D20279: Attempt to fixup dependency data declarations for non-KDE modules.

This looks fine to me, subject to being okayed by @mpyne

Only thing I do see is Qt5 being changed to third-party/Qt5

Apr 17 2019, 7:59 PM

Apr 13 2019

ouwerkerk added a comment to D20279: Attempt to fixup dependency data declarations for non-KDE modules.

@bcooksley is this more to your liking now? I used the third-party/ prefix to mark non KDE modules.

Apr 13 2019, 12:11 PM
ouwerkerk updated the diff for D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Fixup search & replace breakage.

Apr 13 2019, 12:09 PM
ouwerkerk updated the diff for D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Fixup for gpgme -> third-party/gpgme

Apr 13 2019, 12:07 PM
ouwerkerk updated the diff for D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Fixup for search & replace breakage.

Apr 13 2019, 12:06 PM
ouwerkerk updated the diff for D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Introduce the third-party/ prefix like bcooksley requested

Apr 13 2019, 12:04 PM

Apr 6 2019

ouwerkerk added a comment to D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Would it be possible to have all the external items sitting in their own namespace?

Apr 6 2019, 11:19 AM

Apr 5 2019

ouwerkerk updated the test plan for D20279: Attempt to fixup dependency data declarations for non-KDE modules.
Apr 5 2019, 6:40 PM
ouwerkerk committed R365:e50435e7a0ac: Remove the hack for prioritising non-KDE modules when sorting modules in build… (authored by ouwerkerk).
Remove the hack for prioritising non-KDE modules when sorting modules in build…
Apr 5 2019, 6:36 PM
ouwerkerk requested review of D20279: Attempt to fixup dependency data declarations for non-KDE modules.
Apr 5 2019, 6:32 PM

Mar 31 2019

ouwerkerk committed R365:141d71497879: Add a unit test job to the Gitlab CI pipeline. (authored by ouwerkerk).
Add a unit test job to the Gitlab CI pipeline.
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:817fb3bdfd40: Add initial test suite for new dependency resolution algorithm(s). (authored by ouwerkerk).
Add initial test suite for new dependency resolution algorithm(s).
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:1a0de3ea0c63: Fixup Gitlab CI smoke test pipeline: mention the git package only once. (authored by ouwerkerk).
Fixup Gitlab CI smoke test pipeline: mention the git package only once.
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:19789dd3b688: Suggest to run `prove` with recursion into subdirectories enabled. Doing so by… (authored by ouwerkerk).
Suggest to run `prove` with recursion into subdirectories enabled. Doing so by…
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:7dd1d0f98c54: Update Gitlab CI pipeline to specifically select smoke tests for the job which… (authored by ouwerkerk).
Update Gitlab CI pipeline to specifically select smoke tests for the job which…
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:a84bfd533c60: Move smoke tests to a separate t/smoke directory and fixup assumptions/mocking… (authored by ouwerkerk).
Move smoke tests to a separate t/smoke directory and fixup assumptions/mocking…
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:8bbd89546281: Document the new --list-build and --dependency-tree commandline options. (authored by ouwerkerk).
Document the new --list-build and --dependency-tree commandline options.
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:085f9e32bd4f: Use the new dependency resolver. (authored by ouwerkerk).
Use the new dependency resolver.
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:2ec5a3a93be5: Create an entirely new dependency resolver to help solve #22 and #23 because… (authored by ouwerkerk).
Create an entirely new dependency resolver to help solve #22 and #23 because…
Mar 31 2019, 2:50 PM
ouwerkerk committed R365:5ee43214d42b: Fix typo: rename the Qt 5 module set ('qt5' -> 'Qt5'). (authored by ouwerkerk).
Fix typo: rename the Qt 5 module set ('qt5' -> 'Qt5').
Mar 31 2019, 2:50 PM

Mar 3 2019

ouwerkerk committed R365:625778bafccb: Use the new dependency resolver. (authored by ouwerkerk).
Use the new dependency resolver.
Mar 3 2019, 8:58 PM
ouwerkerk committed R365:3801fa4932ce: Create an entire new dependency resolver to help solve #22 and #23 because… (authored by ouwerkerk).
Create an entire new dependency resolver to help solve #22 and #23 because…
Mar 3 2019, 8:58 PM

Feb 24 2019

ouwerkerk committed R365:032f34bf270e: Add a work-around for well known cycles in kde-build-metadata. (authored by ouwerkerk).
Add a work-around for well known cycles in kde-build-metadata.
Feb 24 2019, 5:28 PM
ouwerkerk committed R365:7727d59c3c9c: Fix kdesrc-buid to consider 'special' dependencies configured in kdesrc-build.rc (authored by ouwerkerk).
Fix kdesrc-buid to consider 'special' dependencies configured in kdesrc-build.rc
Feb 24 2019, 4:55 PM
ouwerkerk committed R365:73d2b4944f71: Add helper functions to the dependency resolver for working with 'special'… (authored by ouwerkerk).
Add helper functions to the dependency resolver for working with 'special'…
Feb 24 2019, 4:55 PM
ouwerkerk committed R365:019eff9efa2c: Fix typo: rename the Qt 5 module set ('qt5' -> 'Qt5'). (authored by ouwerkerk).
Fix typo: rename the Qt 5 module set ('qt5' -> 'Qt5').
Feb 24 2019, 4:55 PM

Feb 20 2019

ouwerkerk abandoned D19171: Fix typo in qt5 module set name..

Ok, so let's abandon this approach and reconsider our options (see also update to b.k.o bug report)

Feb 20 2019, 9:46 PM
ouwerkerk added a comment to D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.
Feb 20 2019, 9:34 PM
ouwerkerk committed R365:69ca1a31fcd2: Consider and prefer using tools from qtdir/bin and kdedir/bin if available. (authored by ouwerkerk).
Consider and prefer using tools from qtdir/bin and kdedir/bin if available.
Feb 20 2019, 9:32 PM
ouwerkerk committed R365:0d6abbec2187: Include qtdir when adjusting build context environment (variables) (authored by ouwerkerk).
Include qtdir when adjusting build context environment (variables)
Feb 20 2019, 9:32 PM
ouwerkerk committed R365:7cd2815dfeba: Do not complain about missing qmake if it is going to be built as part of… (authored by ouwerkerk).
Do not complain about missing qmake if it is going to be built as part of…
Feb 20 2019, 9:32 PM
ouwerkerk closed D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.
Feb 20 2019, 9:32 PM
ouwerkerk updated the diff for D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Update commit message to track corresponding kdesrc-build issue in Gitlab on invent.kde.org

Feb 20 2019, 7:18 PM

Feb 19 2019

ouwerkerk added a comment to D19171: Fix typo in qt5 module set name..

Hmm, doing this produces a dependency cycle when you *don't* include qt5-build-include through your kdesrc-build.rc. E.g.: kdesrc-build --include-dependencies --no-metadata kio explodes with:

Feb 19 2019, 11:27 PM
ouwerkerk updated the diff for D19171: Fix typo in qt5 module set name..

Fixed up commit message/bug tag.

Feb 19 2019, 8:23 PM
ouwerkerk requested review of D19171: Fix typo in qt5 module set name..
Feb 19 2019, 8:22 PM
ouwerkerk updated the diff for D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Rework absPathToExecutable

Feb 19 2019, 6:20 PM

Feb 18 2019

ouwerkerk closed T9850: Privacy Options for Notifications Forwarded to Desktop as Resolved.
Feb 18 2019, 11:55 PM · Junior Jobs, KDE Connect
ouwerkerk retitled D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5 from Do not complain about missing qmake if it is going to be built as part of building Qt5. to Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.
Feb 18 2019, 11:36 PM
ouwerkerk updated the diff for D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

Rebased git history to get proper tags in commit messages.

Feb 18 2019, 9:48 PM
ouwerkerk added inline comments to D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.
Feb 18 2019, 9:35 PM
ouwerkerk added a comment to D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

With the last change bug #404486 should be fully fixed.

Feb 18 2019, 9:24 PM
ouwerkerk updated the diff for D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.
  • Consider and prefer using tools from qtdir/bin and kdedir/bin if available.
Feb 18 2019, 9:21 PM
ouwerkerk added a comment to D19127: Do not complain about missing qmake if it can actually be found or is going to be built as part of Qt 5.

The only thing missing is to adjust Util & Application modules, specifically the sub _checkForEssentialBuildPrograms in Application to consider qtdir/kdedir as well as $PATH (absPathToExecutable).
Possibly using a copy of the absPathToExecutable which takes an additional second @paths positional argument (list).

Feb 18 2019, 8:51 PM