ouwerkerk (Johan Ouwerkerk)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 3 2017, 7:23 PM (178 w, 6 d)
Availability
Available

Recent Activity

May 18 2020

ouwerkerk committed R993:694c81f1eb5f: Drop custom libsodium dependency for Keysmith (authored by ouwerkerk).
Drop custom libsodium dependency for Keysmith
May 18 2020, 9:44 PM
ouwerkerk committed R365:631dbf74435e: Ignore `hasrepo` metadata field. (authored by ouwerkerk).
Ignore `hasrepo` metadata field.
May 18 2020, 7:34 PM
ouwerkerk committed R116:ce91de0268ee: Fix importing key-direction from *.ovpn files (authored by ouwerkerk).
Fix importing key-direction from *.ovpn files
May 18 2020, 7:22 AM

May 17 2020

ouwerkerk abandoned D29781: Fix importing key-direction from *.ovpn files.

With the move to gitlab/invent.kde.org it seems better to abandon this in favour of a straightforward MR using the new shiny :)
See: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/1

May 17 2020, 6:14 PM · Plasma
ouwerkerk committed R365:940f335506d4: Make sure to remove old pushInsteadOf mapping if git-desired-protocol changes. (authored by ouwerkerk).
Make sure to remove old pushInsteadOf mapping if git-desired-protocol changes.
May 17 2020, 4:45 PM

May 15 2020

ouwerkerk requested review of D29781: Fix importing key-direction from *.ovpn files.
May 15 2020, 3:59 PM · Plasma

May 14 2020

ouwerkerk committed R857:6a5e53dd9b13: Minor cleanup: grep has -q for this. (authored by ouwerkerk).
Minor cleanup: grep has -q for this.
May 14 2020, 4:29 PM
ouwerkerk committed R857:0bbb19e8064f: Fix build-standalone to pick up on ANDROID_ARCH if it is set. (authored by ouwerkerk).
Fix build-standalone to pick up on ANDROID_ARCH if it is set.
May 14 2020, 4:29 PM
ouwerkerk committed R857:137016469a5c: Fix error handling: make sure the temporary dir is always removed (authored by ouwerkerk).
Fix error handling: make sure the temporary dir is always removed
May 14 2020, 4:29 PM

May 9 2020

ouwerkerk committed R365:857c5ff212c1: Prepare for new project metadata format in kde-build-metadata. (authored by ouwerkerk).
Prepare for new project metadata format in kde-build-metadata.
May 9 2020, 11:23 PM

May 3 2020

ouwerkerk committed R365:001202e2aa38: Avoid needless conversion to full URL and then back to KDE-prefixed shorthand. (authored by ouwerkerk).
Avoid needless conversion to full URL and then back to KDE-prefixed shorthand.
May 3 2020, 6:48 PM
ouwerkerk committed R365:66e5e6920879: Document new behaviour of git-desired-protocol (authored by ouwerkerk).
Document new behaviour of git-desired-protocol
May 3 2020, 6:48 PM
ouwerkerk committed R365:28c29941b9ce: Refactor: pass build context to verifyGitConfig. (authored by ouwerkerk).
Refactor: pass build context to verifyGitConfig.
May 3 2020, 6:48 PM
ouwerkerk committed R365:f44506f6be64: Automatically recover remote URLs for KDE projects based on repo metadata. (authored by ouwerkerk).
Automatically recover remote URLs for KDE projects based on repo metadata.
May 3 2020, 6:48 PM
ouwerkerk committed R365:5cc6986e9d5e: Optionally configure invent.kde.org for git push URLs of KDE projects. (authored by ouwerkerk).
Optionally configure invent.kde.org for git push URLs of KDE projects.
May 3 2020, 6:48 PM
ouwerkerk committed R857:79a77752dfae: Avoid interference from stuff left over by a previous arch by performing clean… (authored by ouwerkerk).
Avoid interference from stuff left over by a previous arch by performing clean…
May 3 2020, 4:48 PM

May 2 2020

ouwerkerk committed R365:56ccff11ddba: Bump default Qt branch to 5.14 because Plasma git master has started to depend… (authored by ouwerkerk).
Bump default Qt branch to 5.14 because Plasma git master has started to depend…
May 2 2020, 5:34 PM
ouwerkerk committed R857:ac266957b8eb: Apparently eval eats the newlines, so use && to continue with next command… (authored by ouwerkerk).
Apparently eval eats the newlines, so use && to continue with next command…
May 2 2020, 12:05 PM

May 1 2020

ouwerkerk committed R857:74488e7b4cc6: Apply the filthy hack of hardcoding supported architectures. (authored by ouwerkerk).
Apply the filthy hack of hardcoding supported architectures.
May 1 2020, 11:41 PM
ouwerkerk committed R857:67a9f0b5c52d: Remove liboath: it has not been needed for Keysmith for some time now (authored by ouwerkerk).
Remove liboath: it has not been needed for Keysmith for some time now
May 1 2020, 5:06 AM

Apr 30 2020

ouwerkerk committed R993:6b7045b4ecf4: Bundle libsodium when building Keysmith (authored by ouwerkerk).
Bundle libsodium when building Keysmith
Apr 30 2020, 7:10 PM

Apr 23 2020

ouwerkerk added a comment to D29095: Change mouse icon to have better dark theme contrast.

FWIW all the mice in my house have this exact shape, but they're black, not gray. So I don't think the shape is too old-fashioned per se. It's the gray color that's anacrhonistic part, since it's a very 90s/early 2000s color and modern mice tend to be black:

Apr 23 2020, 6:03 PM · Frameworks

Apr 22 2020

ouwerkerk added a comment to D29095: Change mouse icon to have better dark theme contrast.

Maybe this is just me but the overall width to height ratio makes it seem that the closest "real" mice are quite dated as well.

I don't understand what you mean with this, do you think it should be slimmer? I kind of followed the old one in this, even if it doesn't seem like it. Right now its ratio is ~0,67 while microsoft's standard old mouse is kind of close to that (but has a different shape)

Apr 22 2020, 8:16 PM · Frameworks
ouwerkerk added a comment to D29095: Change mouse icon to have better dark theme contrast.

One thing I find really striking about the new icon is how closely it resembles stress balls:

Apr 22 2020, 7:25 PM · Frameworks
ouwerkerk added a comment to D29095: Change mouse icon to have better dark theme contrast.

Hmm, the old icon also has the virtue of looking more like genuine computer mice: it resembles the logi(tech) & copycat style of mouse design quite well in a stylised sort of way. It's got the side buttons, the smooth/fast scrolling thing and managed to capture the ergonomic mouse shape. It's also got colour accents.

Apr 22 2020, 7:13 PM · Frameworks

Apr 17 2020

ouwerkerk committed R169:57c63e7ceeb9: Couple of 'trivial' fixes for broken code (authored by ouwerkerk).
Couple of 'trivial' fixes for broken code
Apr 17 2020, 5:18 PM
ouwerkerk closed D28730: Couple of 'trivial' fixes for broken code.
Apr 17 2020, 5:18 PM · Kirigami

Apr 12 2020

ouwerkerk requested changes to D28768: Sort bencoded dictionary in extension protocol handshake.
Apr 12 2020, 10:58 AM
ouwerkerk added a comment to D28768: Sort bencoded dictionary in extension protocol handshake.

General comment: your patch might fix this, but there is no source code comment explaining things *must* be added sorted on key order and the code still does not enforce this invariant either. (Which makes a comment about it all the more important.)

Apr 12 2020, 9:24 AM

Apr 10 2020

ouwerkerk added a reviewer for D28730: Couple of 'trivial' fixes for broken code: Kirigami.
Apr 10 2020, 8:05 PM · Kirigami
ouwerkerk requested review of D28730: Couple of 'trivial' fixes for broken code.
Apr 10 2020, 8:04 PM · Kirigami

Apr 6 2020

ouwerkerk committed R365:ca90af91d60c: Merge branch 'feat-group-deps-by-config-order' into 'master' (authored by ouwerkerk).
Merge branch 'feat-group-deps-by-config-order' into 'master'
Apr 6 2020, 5:32 PM
ouwerkerk updated the task description for T12906: Mini Plasma Mobile sprint.
Apr 6 2020, 4:36 PM · Plasma: Mobile
ouwerkerk updated the task description for T12906: Mini Plasma Mobile sprint.
Apr 6 2020, 4:32 PM · Plasma: Mobile

Mar 26 2020

ouwerkerk committed R169:c9bbe6dea5a1: Add useful input method hints to password field by default (authored by ouwerkerk).
Add useful input method hints to password field by default
Mar 26 2020, 7:03 PM
ouwerkerk closed D28316: Add useful input method hints to password field by default.
Mar 26 2020, 7:03 PM · Kirigami
ouwerkerk updated the summary of D28316: Add useful input method hints to password field by default.
Mar 26 2020, 5:56 PM · Kirigami
ouwerkerk added a reviewer for D28316: Add useful input method hints to password field by default: Kirigami.
Mar 26 2020, 5:52 PM · Kirigami
ouwerkerk requested review of D28316: Add useful input method hints to password field by default.
Mar 26 2020, 5:51 PM · Kirigami

Mar 22 2020

ouwerkerk committed R857:bb31c1c061de: Update builder images to include libsodium (authored by ouwerkerk).
Update builder images to include libsodium
Mar 22 2020, 7:20 AM

Mar 13 2020

ouwerkerk committed R857:01fbc16524a5: Provide a generic autotools helper script (wrapper around build-standalone) (authored by ouwerkerk).
Provide a generic autotools helper script (wrapper around build-standalone)
Mar 13 2020, 7:12 PM

Jan 12 2020

ouwerkerk committed R365:c1bab23978ec: Add 'native' support for using CMake toolchain files with KDE projects (authored by ouwerkerk).
Add 'native' support for using CMake toolchain files with KDE projects
Jan 12 2020, 7:17 PM
ouwerkerk committed R365:2cd07365db50: Update documentation to cover CMake toolchain support. (authored by ouwerkerk).
Update documentation to cover CMake toolchain support.
Jan 12 2020, 7:17 PM

Jan 5 2020

ouwerkerk committed R365:c8c091d94b48: Update old tests to take CMake generator options into account. (authored by ouwerkerk).
Update old tests to take CMake generator options into account.
Jan 5 2020, 12:48 AM
ouwerkerk committed R365:54621a068cba: Update documentation to cover CMake generator support. (authored by ouwerkerk).
Update documentation to cover CMake generator support.
Jan 5 2020, 12:48 AM
ouwerkerk committed R365:041118921fcb: Add 'native' support for using Ninja with CMake for KDE projects (authored by ouwerkerk).
Add 'native' support for using Ninja with CMake for KDE projects
Jan 5 2020, 12:48 AM

Jan 2 2020

ouwerkerk abandoned D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12)..

Cleanup.

Jan 2 2020, 3:02 PM · Kirigami
ouwerkerk abandoned D26344: Fix building plasma-desktop without X11 cursor development headers.

Superseded by: https://phabricator.kde.org/D26367

Jan 2 2020, 3:01 PM · Plasma
ouwerkerk committed R119:1c43e1b4f7b1: Make the lookandfeel KCM build without XCursor support (authored by ouwerkerk).
Make the lookandfeel KCM build without XCursor support
Jan 2 2020, 2:58 PM
ouwerkerk closed D26367: Make the lookandfeel KCM build without XCursor support.
Jan 2 2020, 2:58 PM · Plasma
ouwerkerk added a reviewer for D26367: Make the lookandfeel KCM build without XCursor support: Plasma.
Jan 2 2020, 2:34 PM · Plasma
ouwerkerk requested review of D26367: Make the lookandfeel KCM build without XCursor support.
Jan 2 2020, 2:32 PM · Plasma
ouwerkerk added a comment to D26354: Introduce ActionRow widget.

Are we certain about naming here: SwipeAction.isDelete? Maybe SwipeAction.collapse ? It doesn't necessarily have to be a real "delete" action that is backing this, maybe all you want to convey with the name of this setting is that the list entry will be collapsed in an animation?

Jan 2 2020, 12:14 AM · Kirigami

Jan 1 2020

ouwerkerk added a comment to D26344: Fix building plasma-desktop without X11 cursor development headers.

Right now the KCM CmakeListst does stuff like:

Jan 1 2020, 11:55 PM · Plasma
ouwerkerk added a comment to T12400: Consider what position KDE Neon should take regarding Flatpak, Snaps, and packages future.

If I understand "the Neon position" correctly here, Neon aims to be the base OS + Plasma desktop. The only reason it still bothers with packaging apps is because it has to because nobody is going to use an empty shell, and the Linux world isn't all app-ified yet.

Jan 1 2020, 11:41 PM · Neon
ouwerkerk updated the diff for D26344: Fix building plasma-desktop without X11 cursor development headers.

Fixed commit message typo

Jan 1 2020, 4:09 PM · Plasma
ouwerkerk added a reviewer for D26344: Fix building plasma-desktop without X11 cursor development headers: Plasma.
Jan 1 2020, 3:50 PM · Plasma
ouwerkerk requested review of D26344: Fix building plasma-desktop without X11 cursor development headers.
Jan 1 2020, 3:50 PM · Plasma
ouwerkerk added a comment to T12400: Consider what position KDE Neon should take regarding Flatpak, Snaps, and packages future.

As far as I am aware our flatpaks are purely packaging formats and don't take advantage of any sandboxing features. So I don't see what is there to recommend our flatpak implementation over our snap implementation, say. But then again, that could be part of this: pushing the packaging forward.
On the other hand: has anybody asked the application developers about their opinion on this? After all, they will be expected to take on additional maintenance efforts to make sure their app continue to work well with the chosen packaging format and they might just have opinions on that.

Jan 1 2020, 2:19 PM · Neon

Dec 31 2019

ouwerkerk committed R499:76d422dd773c: Update dependency data for Keysmith to include KF5 i18n (authored by ouwerkerk).
Update dependency data for Keysmith to include KF5 i18n
Dec 31 2019, 8:04 PM
ouwerkerk closed D26336: Update dependency data for Keysmith to include KF5 i18n.
Dec 31 2019, 8:04 PM
ouwerkerk updated the diff for D26336: Update dependency data for Keysmith to include KF5 i18n.

Rebased onto latest master

Dec 31 2019, 6:18 PM
ouwerkerk requested review of D26336: Update dependency data for Keysmith to include KF5 i18n.
Dec 31 2019, 6:11 PM
ouwerkerk added a comment to D26304: [PageRow] Disable swipe forwards/backwards gesture by default.

This completely alters one of the core propositions of how a Kirigami UX works. I may be mistaken, but if I understand it correctly drawers are supposed to be accessible via buttons. If gestures conflict, why remove page row navigation by gesture rather than drawer gestures?

Dec 31 2019, 4:59 PM · Kirigami

Dec 28 2019

ouwerkerk committed R499:23b6c435db4d: Add proper dependency data for Keysmith: it does not actually need all of KF5 (authored by ouwerkerk).
Add proper dependency data for Keysmith: it does not actually need all of KF5
Dec 28 2019, 12:25 PM
ouwerkerk closed D26249: Add proper dependency data for Keysmith: it does not actually need all of KF5.
Dec 28 2019, 12:25 PM
ouwerkerk requested review of D26249: Add proper dependency data for Keysmith: it does not actually need all of KF5.
Dec 28 2019, 3:00 AM

Oct 22 2019

ouwerkerk committed R857:caef857fc303: Use default parameters instead of a global before_script block (authored by ouwerkerk).
Use default parameters instead of a global before_script block
Oct 22 2019, 10:17 AM

Sep 30 2019

ouwerkerk added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

Also side note, as a non-native English speaker I find "grossly" to be a bit of an odd adjective to use here -- "coarsely" would be more familiar: as in fine/coarse grained. Perhaps something to keep in mind when this lands and you start blogging about it :)

Sep 30 2019, 9:19 PM · Plasma
ouwerkerk added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

Ideally you would also warn if the reciprocal times the horizontal, vertical resolution yields a non-integer output, not just if some value is chosen which cannot be represented in floating point exactly.

Sep 30 2019, 9:01 PM · Plasma

Sep 24 2019

ouwerkerk added a comment to D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12)..

And if so, sure I can 'fix' this by downgrading to QQC 2.4 instead but in that case: is this 'safe'? I.e. does this introduce bugs/regressions?

Sep 24 2019, 3:02 PM · Kirigami
ouwerkerk added a comment to D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12)..

If Kirigami is supposed to depend on Qt 5.11, then *why* were these old imports there in the first place? They cannot work with Qt 5.11, because then the max QQC version is 2.4

Sep 24 2019, 3:01 PM · Kirigami
ouwerkerk requested review of D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12)..
Sep 24 2019, 2:17 PM · Kirigami

Sep 8 2019

ouwerkerk committed R365:a245faba85cb: Make sure to record & expose the modules derived from the command line in ksb… (authored by ouwerkerk).
Make sure to record & expose the modules derived from the command line in ksb…
Sep 8 2019, 6:08 PM
ouwerkerk committed R365:eb5451199b31: Reimplement dependency tree output formatting in the TTY client UI. (authored by ouwerkerk).
Reimplement dependency tree output formatting in the TTY client UI.
Sep 8 2019, 6:08 PM

Sep 7 2019

ouwerkerk committed R365:a29c7f6d583c: Introduce a DTO for exporting dependency information. (authored by ouwerkerk).
Introduce a DTO for exporting dependency information.
Sep 7 2019, 8:07 PM

Aug 24 2019

ouwerkerk committed R365:86faa8999996: Merge branch 'patch-1' into 'master' (authored by ouwerkerk).
Merge branch 'patch-1' into 'master'
Aug 24 2019, 7:47 PM

Aug 20 2019

ouwerkerk committed R365:472fb418b714: Update smoke test(s) to the refactored ksb::Application (authored by ouwerkerk).
Update smoke test(s) to the refactored ksb::Application
Aug 20 2019, 12:31 AM
ouwerkerk committed R365:8fd02395cf27: Print a top 5 of most 'interesting' failures when the build fails. (authored by ouwerkerk).
Print a top 5 of most 'interesting' failures when the build fails.
Aug 20 2019, 12:31 AM
ouwerkerk committed R365:4becb4eba1ec: Add unit tests for debug ordering feature. (authored by ouwerkerk).
Add unit tests for debug ordering feature.
Aug 20 2019, 12:31 AM
ouwerkerk committed R365:8be6358cafb6: Provide utilities to estimate how 'interesting' one failure (module) is versus… (authored by ouwerkerk).
Provide utilities to estimate how 'interesting' one failure (module) is versus…
Aug 20 2019, 12:31 AM

Aug 16 2019

ouwerkerk committed R365:9265efc18a20: Fixup: do not print the most 'interesting' module list if there are fewer than… (authored by ouwerkerk).
Fixup: do not print the most 'interesting' module list if there are fewer than…
Aug 16 2019, 9:29 PM
ouwerkerk committed R365:5835e6c2eb02: Fixup: persistent failure count is available directly from the module, need not… (authored by ouwerkerk).
Fixup: persistent failure count is available directly from the module, need not…
Aug 16 2019, 8:53 PM
ouwerkerk committed R365:9922e2d11eda: Fixup: no need to populate persistent failure counts in extra debug info… (authored by ouwerkerk).
Fixup: no need to populate persistent failure counts in extra debug info…
Aug 16 2019, 8:53 PM

Aug 10 2019

ouwerkerk committed R365:fa8cd4710e1b: Print a top 5 of most 'interesting' failures when the build fails. (authored by ouwerkerk).
Print a top 5 of most 'interesting' failures when the build fails.
Aug 10 2019, 9:32 PM
ouwerkerk committed R365:bf98639136eb: Provide utilities to estimate how 'interesting' one failure (module) is versus… (authored by ouwerkerk).
Provide utilities to estimate how 'interesting' one failure (module) is versus…
Aug 10 2019, 9:32 PM

Apr 21 2019

ouwerkerk committed R365:e240d0cb5867: Use a well-known 'third-party/' prefix for dependency paths of non-KDE modules. (authored by ouwerkerk).
Use a well-known 'third-party/' prefix for dependency paths of non-KDE modules.
Apr 21 2019, 5:31 PM
ouwerkerk committed R365:ec336711def3: Remove the hack for prioritising non-KDE modules when sorting modules in build… (authored by ouwerkerk).
Remove the hack for prioritising non-KDE modules when sorting modules in build…
Apr 21 2019, 5:31 PM
ouwerkerk committed R499:4259d816fe70: Attempt to fixup dependency data declarations for non-KDE modules (authored by ouwerkerk).
Attempt to fixup dependency data declarations for non-KDE modules
Apr 21 2019, 5:25 PM
ouwerkerk closed D20279: Attempt to fixup dependency data declarations for non-KDE modules.
Apr 21 2019, 5:25 PM

Apr 17 2019

ouwerkerk added a comment to D20279: Attempt to fixup dependency data declarations for non-KDE modules.

This looks fine to me, subject to being okayed by @mpyne

Only thing I do see is Qt5 being changed to third-party/Qt5

Apr 17 2019, 7:59 PM

Apr 13 2019

ouwerkerk added a comment to D20279: Attempt to fixup dependency data declarations for non-KDE modules.

@bcooksley is this more to your liking now? I used the third-party/ prefix to mark non KDE modules.

Apr 13 2019, 12:11 PM
ouwerkerk updated the diff for D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Fixup search & replace breakage.

Apr 13 2019, 12:09 PM
ouwerkerk updated the diff for D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Fixup for gpgme -> third-party/gpgme

Apr 13 2019, 12:07 PM
ouwerkerk updated the diff for D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Fixup for search & replace breakage.

Apr 13 2019, 12:06 PM
ouwerkerk updated the diff for D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Introduce the third-party/ prefix like bcooksley requested

Apr 13 2019, 12:04 PM

Apr 6 2019

ouwerkerk added a comment to D20279: Attempt to fixup dependency data declarations for non-KDE modules.

Would it be possible to have all the external items sitting in their own namespace?

Apr 6 2019, 11:19 AM

Apr 5 2019

ouwerkerk updated the test plan for D20279: Attempt to fixup dependency data declarations for non-KDE modules.
Apr 5 2019, 6:40 PM
ouwerkerk committed R365:e50435e7a0ac: Remove the hack for prioritising non-KDE modules when sorting modules in build… (authored by ouwerkerk).
Remove the hack for prioritising non-KDE modules when sorting modules in build…
Apr 5 2019, 6:36 PM
ouwerkerk requested review of D20279: Attempt to fixup dependency data declarations for non-KDE modules.
Apr 5 2019, 6:32 PM