acrouthamel (Andrew Crouthamel)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2018, 6:07 AM (22 w, 20 h)
Availability
Available

Recent Activity

Apr 13 2018

acrouthamel added a comment to T7566: Discover Backends : Wait until 18.04.1; re-test.

I'm surprised Neon is using snap due to the appstream issue. It also has problems with respecting themes (or the lack thereof). Having used both for a variety of popular desktop apps, I would rather see Flatpak enabled as a backend than Snap.

Apr 13 2018, 9:28 PM · Kubuntu

Apr 6 2018

acrouthamel closed T8433: Breeze Dark compatible Nicklist icon theme as Invalid.

Abandoned in favor of Bugzilla 392811.

Apr 6 2018, 5:47 PM · Konversation
acrouthamel closed T8432: Utilize SVG for Nicklist icons as Invalid.

Abandoned in favor of Bugzilla 392810.

Apr 6 2018, 5:44 PM · Konversation
acrouthamel closed T8431: Implement Matrix as Invalid.

Abandoned in favor of Buzilla 392809.

Apr 6 2018, 5:42 PM · Konversation
acrouthamel closed T8430: Implement Color Themes as Invalid.

Abandoned in favor of Buzilla 371881 and 386138.

Apr 6 2018, 5:35 PM · Konversation

Apr 5 2018

acrouthamel created T8433: Breeze Dark compatible Nicklist icon theme.
Apr 5 2018, 4:34 AM · Konversation
acrouthamel created T8432: Utilize SVG for Nicklist icons.
Apr 5 2018, 4:30 AM · Konversation
acrouthamel created T8431: Implement Matrix.
Apr 5 2018, 4:12 AM · Konversation
acrouthamel updated subscribers of T8430: Implement Color Themes.
Apr 5 2018, 4:06 AM · Konversation
acrouthamel triaged T8430: Implement Color Themes as Wishlist priority.
Apr 5 2018, 4:04 AM · Konversation

Apr 4 2018

acrouthamel added a comment to D11876: Display star ratings.

I like the bigger stars, but then again I seem to increase font size and whatnot for a lot of things.

Apr 4 2018, 3:01 PM · Plasma
acrouthamel added a comment to D11876: Display star ratings.

Yeah I like it without since they are already on separate cards.

Apr 4 2018, 1:23 PM · Plasma
acrouthamel added a comment to D10352: Fix insufficient icon theme issues.
In D10352#211406, @nmel wrote:

Martin, thanks for investigation and for writing details about it. I propose we ask at the appropriate mailing list or forum anyway, just to make sure we are not trying to reinvent the wheel. There should be a lot of other KDE apps with the same problem and it's likely their devs already solved the issue. If not, we can try to extend KIconLoader for supporting the logic we need.

Apr 4 2018, 3:30 AM · Krusader

Apr 3 2018

acrouthamel added a comment to D6313: Support Icon Scale from Icon naming specification 0.13.
In D6313#239212, @cfeck wrote:

In other words, the icon theme designer can now decide if he makes HiDPI only bigger or more detailed by symlinking to either the less detailed or the more detailed svg, without duplicating the icon files?

Exactly, that is correct. They could also make special icons if they desire, just like the other folders (32x32, 64x64, etc).

Apr 3 2018, 9:55 PM · Frameworks, Plasma
acrouthamel added a comment to D6313: Support Icon Scale from Icon naming specification 0.13.

@ngraham, in the initial description @broulik forced a @2x folder via symlink to test. Otherwise no change will be observed. :)

Apr 3 2018, 2:32 PM · Frameworks, Plasma

Apr 2 2018

acrouthamel added a comment to D11876: Display star ratings.

Nice placement too. I really, really like how this looks.

Apr 2 2018, 7:51 PM · Plasma
acrouthamel added a comment to D6313: Support Icon Scale from Icon naming specification 0.13.
In D6313#238697, @rkflx wrote:

@2x-compatible

How will this work for 4x / 2.7x / 1.4x / etc. scaling? Of course we could define a point where it snaps from 1x to 2x icons, but eventually this approach would also need 4x + larger versions…

Apr 2 2018, 7:42 PM · Frameworks, Plasma
acrouthamel added a comment to T8349: Improve Places panel usability and presentation.

@sharvey Let me know what icons you prefer where, and I can put together a patch for review.

Apr 2 2018, 4:50 PM · Dolphin
acrouthamel added a comment to D6313: Support Icon Scale from Icon naming specification 0.13.

I think both of us missed this part at the bottom of @broulik's description:

Apr 2 2018, 4:30 PM · Frameworks, Plasma
acrouthamel added a comment to D6313: Support Icon Scale from Icon naming specification 0.13.

I'm just saying if you prefer colored over symbolic line art, that is something for Breeze or VDG to work out. Not that they are really taking advantage of anything.

Apr 2 2018, 4:04 PM · Frameworks, Plasma
acrouthamel added a comment to D11838: Turn on line numbers by default.

I wouldn't mind seeing it on in KDevelop. From using it though, I really don't need them much in it. Especially since when debugging I can just click on an error and it will take me to the line.

Apr 2 2018, 2:26 PM · Frameworks, Kate
acrouthamel added a comment to D6313: Support Icon Scale from Icon naming specification 0.13.

@ngraham and @hein, while I agree that in some instances I like the colored hi-res icons showing, this issue causes a mixture of icons to be displayed depending on the app. The examples here show a nice homogeneous selection of icons that change from A to B, so I can see why you like the colored versions better. But in diffs such as D11669 and D10688, you can see how there are now colored icons where they were once symbolic, mixed within the interface.

Apr 2 2018, 2:12 PM · Frameworks, Plasma

Apr 1 2018

acrouthamel awarded D11876: Display star ratings a Love token.
Apr 1 2018, 11:44 PM · Plasma
acrouthamel added a comment to D11876: Display star ratings.

Awesome patch!

Apr 1 2018, 11:43 PM · Plasma

Mar 31 2018

acrouthamel added a comment to T7911: Kubuntu should install PowerTOP and TLP and turn them on during installation : Publicity & Testing needed; re-evaluate for 18.10.

TLP and PowerTOP are very stable and safe to use. I don't know of anyone who has a had a problem with the defaults. The link @ngraham provides explains the settings Fedora is pushing out, which are much more aggressive, and yet those made it through review over there.

Mar 31 2018, 9:35 PM · Kubuntu
acrouthamel added a comment to T7566: Discover Backends : Wait until 18.04.1; re-test.

@valorie Should this be named 18.04 point release based on @rikmills suggestion?

Mar 31 2018, 8:53 PM · Kubuntu
acrouthamel added a comment to T7523: Product Manager.

Is there a written declaration somewhere of :

the market direction of Kubuntu

Mar 31 2018, 8:50 PM · Kubuntu
acrouthamel added a comment to T7523: Product Manager.

Uh oh :)

Mar 31 2018, 8:15 PM · Kubuntu

Mar 28 2018

acrouthamel awarded T7854: Use default wallpaper as background for KScreenlocker and SDDM lock screen a Like token.
Mar 28 2018, 2:17 PM · Kubuntu

Mar 25 2018

acrouthamel updated the task description for T6831: Top-notch usability and productivity for basic software.
Mar 25 2018, 3:51 AM · Goal settings 2017
acrouthamel updated the summary of D11669: Fix pixmap scaling on HiDPI screens.
Mar 25 2018, 3:32 AM
acrouthamel added reviewers for D11669: Fix pixmap scaling on HiDPI screens: pino, aacid.
Mar 25 2018, 3:29 AM
acrouthamel requested review of D11669: Fix pixmap scaling on HiDPI screens.
Mar 25 2018, 3:26 AM

Mar 24 2018

acrouthamel added a comment to D11631: Fix pixelated icon scaling for HiDPI screens.

@acrouthamel Awesome, you made it!

Mar 24 2018, 1:59 PM · Plasma
acrouthamel added reviewers for D11631: Fix pixelated icon scaling for HiDPI screens: rkflx, broulik.
Mar 24 2018, 4:09 AM · Plasma
acrouthamel requested review of D11631: Fix pixelated icon scaling for HiDPI screens.
Mar 24 2018, 4:04 AM · Plasma

Mar 21 2018

acrouthamel added a comment to T7854: Use default wallpaper as background for KScreenlocker and SDDM lock screen.

This would be great, the default blue is ridiculous and looks unprofessional.

Mar 21 2018, 3:35 PM · Kubuntu

Mar 16 2018

acrouthamel added a comment to D11390: new icons for disconnected/disabled devices.

They look great!

Mar 16 2018, 3:52 PM · Frameworks
acrouthamel awarded D11390: new icons for disconnected/disabled devices a Love token.
Mar 16 2018, 3:52 PM · Frameworks
acrouthamel added a comment to D6313: Support Icon Scale from Icon naming specification 0.13.

Thanks for working on this again, it really helps. :)

Mar 16 2018, 3:43 PM · Frameworks, Plasma

Mar 13 2018

acrouthamel added a comment to D6313: Support Icon Scale from Icon naming specification 0.13.

Hey there, any movement on this? I've been submitting some patches to fix icon scaling in apps and have noticed how they switch from monochrome to colored (hires) versions when fixed. Getting the underlying issue fixed would be great as more people buy HiDPI/Retina displays and run with scaling.

Mar 13 2018, 3:45 PM · Frameworks, Plasma
acrouthamel added a comment to T8187: Single click vs double-click.

@valorie's experience is exactly what I was talking about in T7928. If you want people to migrate to Linux for desktop use, you need to make it familiar. It may not be "the best" behavior, but you need to make them as comfortable as possible. Unfortunately (to some), that means replicating Windows/Mac behavior. If you have spent any time with an "average" computer user, you know very well that they will be exceptionally frustrated as stuff starts opening without reason (to them). They don't care if it is more efficient, they expect a computer's basic input to work the same, regardless of OS.

Mar 13 2018, 2:46 AM · VDG

Mar 12 2018

acrouthamel added a comment to T8187: Single click vs double-click.

Do you feel we have to choose one or the other? Is there room for having both methods changing depending on the device they are on?

Right now we do. It's a global setting, and single-click is the default. Device introspection is a slippery slope: I have a convertible laptop and I can tap the screen when it's in laptop mode; what mode should it use? Ideally we have a UI that seamlessly accommodates all use cases and form factors without explicitly switching behavior.

Oh yeah. That's kind of a given. If you have a convertible, then convert the OS to behave automatically.

Mar 12 2018, 3:05 PM · VDG

Mar 11 2018

acrouthamel updated subscribers of T7928: Change default click settings to Double-Click.

@raddison What about those of us that use touchpads? I have tap-to-click enabled (as pretty much everyone using a laptop on any OS does), and if I tap to select a folder or file in Dolphin for example, it will launch, rather than select it. Very annoying and confusing at first. Kubuntu is supposed to be the go-to distro for new users. New users are already adapting to a lot of other things with a Linux system, interface usability shouldn't be another one. This should be the same as Windows/Mac.

Mar 11 2018, 12:44 PM · Kubuntu
acrouthamel added a comment to T8177: Run plasmashell with "PLASMA_USE_QT_SCALING=1" : Wait until 18.10; re-test.

Yes yes yes! I had no idea about this variable. It fixes a bunch of icon scaling and spacing issues. Lots of people will still be using Xorg for a while due to missing features in Wayland (such as myself). Enabling this for them will go a long way to making Plasma look good on newer computers. The only thing I noticed that happened to me, was my panel reset it's width (it's on the left of my screen).

Mar 11 2018, 12:39 PM · Kubuntu

Mar 6 2018

acrouthamel added a comment to T7856: Turn on Fade effect.

+1 for Fade, I think it's much more pleasing and professional.

Mar 6 2018, 3:05 PM · Kubuntu

Mar 4 2018

acrouthamel awarded D11003: Fix the Add Source dialog a Like token.
Mar 4 2018, 7:18 PM · Plasma
acrouthamel added a comment to D11003: Fix the Add Source dialog.

Nice and clean! I like the change.

Mar 4 2018, 7:18 PM · Plasma

Feb 27 2018

acrouthamel awarded D10896: Show config selection OSD when display button is pressed a Mountain of Wealth token.
Feb 27 2018, 5:27 PM · Plasma
acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

More thoughts on the matter (but no time to take any action…):

https://community.kde.org/Frameworks/Epics/Contributions_to_Qt5 is quite interesting, as it mentions our QPA:

DONE Extend QPA theme plugin to use KIconLoader within QIcon::fromTheme()

What does that mean?

Feb 27 2018, 5:17 PM · Gwenview
acrouthamel added a comment to D10843: Remove symbolic icons in favor of standard icons.

Ok should be fixed up now. Thanks for the nitpicking to make me a better coder. :)

Feb 27 2018, 4:38 AM · Gwenview
acrouthamel updated the diff for D10843: Remove symbolic icons in favor of standard icons.
  • Fixed comment formatting and verbage
Feb 27 2018, 4:36 AM · Gwenview

Feb 26 2018

acrouthamel added a comment to T8074: Make custom stamp image support more discoverable.

Thanks for working on this, Simone! This is a high priority on my "how would my mother figure this out? " list.

Agreed! It's things like this (and digital signatures) that are important for business adoption. For example, my company stamps documents with a whole list of various terms to classify them. Making this easy to do is important.

Feb 26 2018, 2:57 PM · VDG, Okular
acrouthamel added a comment to D10843: Remove symbolic icons in favor of standard icons.

I've added the bug link to the code comment. Let me know if that looks good now.

Feb 26 2018, 2:11 PM · Gwenview
acrouthamel updated the diff for D10843: Remove symbolic icons in favor of standard icons.
  • Merge branch 'Applications/17.12' into icons-symbolic-removal
  • Added bug link in comment for mTrashAction
Feb 26 2018, 2:09 PM · Gwenview
acrouthamel updated the summary of D10847: Change icons to more appropriate versions.
Feb 26 2018, 3:40 AM · Gwenview
acrouthamel requested review of D10847: Change icons to more appropriate versions.
Feb 26 2018, 3:38 AM · Gwenview
acrouthamel added a comment to D10843: Remove symbolic icons in favor of standard icons.

Added bug report for gwenview. https://bugs.kde.org/show_bug.cgi?id=391078

Feb 26 2018, 2:33 AM · Gwenview

Feb 25 2018

acrouthamel updated the summary of D10843: Remove symbolic icons in favor of standard icons.
Feb 25 2018, 8:58 PM · Gwenview
acrouthamel requested review of D10843: Remove symbolic icons in favor of standard icons.
Feb 25 2018, 8:52 PM · Gwenview
acrouthamel added a comment to D9414: Implement OSD to select action when unknown monitors is connected.

Could this be implemented for bug 390096? Having the display button open this OSD would be an improvement over the current operation, in my opinion.

Feb 25 2018, 6:19 PM · Plasma
acrouthamel abandoned D10770: Icon fixes to choose more appropriate icons in some areas.
Feb 25 2018, 5:48 PM · Gwenview
acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

@rkflx I agree, thank you for the detailed analysis. The longer I looked at this with you the deeper into the rabbit hole we got; sorry for taking your time. This certainly brings up some good questions and issues for Breeze to work out, as it will only get worse as more people buy newer computers with HiDPI. I'll take your comments and my own thoughts and write up some discussions on it.

Feb 25 2018, 5:48 PM · Gwenview
acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

I could then follow up with Breeze on any inconsistencies we notice, and any tips from them on ensuring the correct scaled icons show.

Feb 25 2018, 2:40 AM · Gwenview
acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

The more I look at it, the more I think @rkflx is correct. (BAH!) :)

Feb 25 2018, 2:18 AM · Gwenview
acrouthamel retitled D10770: Icon fixes to choose more appropriate icons in some areas from Fix icons so they use symbolic versions where available. This fixes line weight and icon size. to Icon fixes to choose more appropriate icons in some areas.
Feb 25 2018, 2:10 AM · Gwenview
acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

After playing around with a couple of icon themes, to me it looks like that -symbolic is about what the name says: Less colours, simpler but bolder shapes, flat look. Breeze is the exception here really, because even the non-symbolic versions are essentially already quite symbolic and only for some larger sizes icons gain in colour and detail. The different line weights for HiDPI might be more of an issue wrt. to available sizes!?

Feb 25 2018, 1:28 AM · Gwenview

Feb 24 2018

acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

One obvious thing I noticed was all of the image ops icons revert to an image of... an image.

Feb 24 2018, 11:37 PM · Gwenview
acrouthamel added a comment to D10700: KCalc display padding improvement.

@teran Doesn't seem to be very active on here, is there anyone else who can review?

Feb 24 2018, 10:25 PM
acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

OK, so this breaks Oxygen and some other non-default themes.

Feb 24 2018, 5:07 PM · Gwenview

Feb 23 2018

acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

Awesome patch; this is gonna look so good soon.

Feb 23 2018, 11:10 PM · Gwenview
acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

@rkflx Ok no problem. Let me know your feedback and I'll rebase then.

Feb 23 2018, 11:07 PM · Gwenview
acrouthamel updated the summary of D10770: Icon fixes to choose more appropriate icons in some areas.
Feb 23 2018, 10:40 PM · Gwenview
acrouthamel added a comment to D10770: Icon fixes to choose more appropriate icons in some areas.

Ok I think I'm done updating this for now, unless you can find more icons I missed.

Feb 23 2018, 9:11 PM · Gwenview
acrouthamel updated the summary of D10770: Icon fixes to choose more appropriate icons in some areas.
Feb 23 2018, 9:09 PM · Gwenview
acrouthamel updated the summary of D10770: Icon fixes to choose more appropriate icons in some areas.
Feb 23 2018, 9:08 PM · Gwenview
acrouthamel updated the diff for D10770: Icon fixes to choose more appropriate icons in some areas.
  • Fixed a bunch more for the top toolbar, close dialog, slideshow, etc.
Feb 23 2018, 8:57 PM · Gwenview
acrouthamel updated the summary of D10770: Icon fixes to choose more appropriate icons in some areas.
Feb 23 2018, 8:26 PM · Gwenview
acrouthamel updated the diff for D10770: Icon fixes to choose more appropriate icons in some areas.
  • Fixed Image Operations to use symbolic icons
Feb 23 2018, 8:24 PM · Gwenview
acrouthamel updated the summary of D10770: Icon fixes to choose more appropriate icons in some areas.
Feb 23 2018, 3:26 PM · Gwenview
acrouthamel updated the summary of D10770: Icon fixes to choose more appropriate icons in some areas.
Feb 23 2018, 3:22 PM · Gwenview
acrouthamel requested review of D10770: Icon fixes to choose more appropriate icons in some areas.
Feb 23 2018, 3:17 PM · Gwenview
acrouthamel abandoned D10768: Fixed icons in menus, including provided appropriate icons for HiDPI systems..

Messed up using arcanist.

Feb 23 2018, 3:14 PM
acrouthamel requested review of D10768: Fixed icons in menus, including provided appropriate icons for HiDPI systems..
Feb 23 2018, 3:01 PM

Feb 22 2018

acrouthamel added a comment to D10756: Reduce sidebar width.

I like it!

Feb 22 2018, 10:40 PM · Plasma
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

For me both look just the same, no difference in size. Perhaps share a screenshot? For me it looks like this:

Which app is this? This one?

https://phabricator.kde.org/source/plasma-sdk/browse/master/cuttlefish/

Not sure about Ubuntu, on openSUSE it's in the package plasma5-sdk.

Feb 22 2018, 8:18 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

For me both look just the same, no difference in size. Perhaps share a screenshot? For me it looks like this:

Which app is this? This one?

Feb 22 2018, 8:13 PM · Gwenview
acrouthamel updated the diff for D10726: Add icons for context and sidebar menu.

Rebase as requested.

Feb 22 2018, 7:16 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

@acrouthamel, if you'd like to land this on stable, then you'll need to re-base it on the stable branch. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

Feb 22 2018, 6:19 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

One more thing I just noticed, if you want bonus points:

use edit-delete-symbolic for the red Trash icons, so their lines have the same weight as the black/white Trash icons.

Ok 1 sec. It looks like that icon is built-in, so I believe I can override it.

In that case, we might instead need to change a KStandardAction somewhere...

Feb 22 2018, 6:08 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

One more thing I just noticed, if you want bonus points:

use edit-delete-symbolic for the red Trash icons, so their lines have the same weight as the black/white Trash icons.

Ok 1 sec. It looks like that icon is built-in, so I believe I can override it.

Feb 22 2018, 6:07 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

Phew, OK. I think it's all fixed now. New screenshots as well. Man, now I have to go fix poor KTorrent...

Feb 22 2018, 5:55 PM · Gwenview
acrouthamel updated the summary of D10726: Add icons for context and sidebar menu.
Feb 22 2018, 5:55 PM · Gwenview
acrouthamel updated the diff for D10726: Add icons for context and sidebar menu.

Fixed icons with -symbolic versions for HiDPI screens.

Feb 22 2018, 5:54 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

How about document-open-folder?

That works!

Feb 22 2018, 5:47 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

I think there's one final bit of polish we can do here. In the "after" screenshots, most icons use the "symbolic" line-art style, but a few show colored folders when run in HiDPI mode, which your screenshots depict. Perhaps we should take the opportunity to fix this, too. It's especially odd for the Trash icon. Looks like it's using user-trash when it should be using user-trash-symbolic.

Feb 22 2018, 5:45 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

I think there's one final bit of polish we can do here. In the "after" screenshots, most icons use the "symbolic" line-art stylr with Breeze, but a few show colored folders when run in HiDPI mode, which your screenshots depict. Perhaps we should take the opportunity to fix this, too. It's especially odd for the Trash icon.

Feb 22 2018, 5:37 PM · Gwenview
acrouthamel added a comment to D10726: Add icons for context and sidebar menu.

Yeah let's go with

Feb 22 2018, 5:33 PM · Gwenview
acrouthamel updated the summary of D10726: Add icons for context and sidebar menu.
Feb 22 2018, 5:31 PM · Gwenview
acrouthamel updated the summary of D10726: Add icons for context and sidebar menu.
Feb 22 2018, 5:28 PM · Gwenview