- User Since
- Feb 17 2018, 6:07 AM (39 w, 2 d)
I'll poke around.
I had submitted this with the intention of being a follow-up to D15739, as that would clear a slot for this. I think right now, T9795 is outside my skill set. I'd be glad to make D15739 a parent to this and wait for that to land.
I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Looking for help to fix this.
Fri, Nov 16
I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Do I need to run this test on a new user account or something?
Tue, Nov 13
Thanks, I spent some time looking through Elvis' commits to the Dolphin PlacesItemModelTest. I believe I added m_hasDocumentsFolder in the various locations properly, but I am still getting a failure in the test. Any tips are appreciated @elvisangelaccio. My attempt is at https://paste.kde.org/pey6davmw
Fri, Nov 9
Thu, Nov 8
Mon, Nov 5
I did not add drive-harddisk-home in this commit because it was simply too difficult to make an easily readable symbol for home on the 16px version.
Sat, Nov 3
Tue, Oct 30
Oops! I forgot to copy over the Etherpad contents until now! Sorry everyone! Bug batches are now up!
Sun, Oct 28
Oct 19 2018
Oct 9 2018
Can you only use amazon.de? Or can USA people use amazon.com as well?
Oct 7 2018
Fair enough, just something that I noticed after dealing with some of that with Gwenview.
Could you add some screenshots?
Oct 5 2018
+1 btw from me, makes sense and the context menu isn't very cluttered.
Hey Thomas, just a note that you should put your initial comments and screenshot in the Summary/Details of the diff so it doesn't get lost after lengthy discussion.
I like the idea, it makes it more easily discoverable if you're using touch. Not that I'm advocating cluttering this menu with a million things, but something to think about are the other functions in the right-click menu. Just thinking out loud.
Oct 3 2018
+1 from me, makes sense. I say that as a guy who stares at server racks all day.
Oct 2 2018
I would even suggest a gesture where you position 2 fingers in the window and move a third finger (from the other hand) in the direction you want to resize the window.
Oct 1 2018
What are the different possible emblems that can be applied automatically by the mount process?
Sep 26 2018
@sitter, if you have any more issues you've noticed since that kde-community discussion, please post them here and I'll make sure they get addressed (eventually).
Sep 25 2018
Ooh my first time being added as reviewer. ;)
I'm going to pull the automated NEEDSINFO handling from here, since this task is specific to new bug reporter experience. I'll work with Harald or whoever else would like to help. For now, I have a manual set of searches that seem to work well enough. I have some other automation ideas as well, so I'll just track that all in a separate task.
Ok, let's try this.
- Remove patch wording
Seeing "Root" written as such, also makes me think of /root, which makes no sense to have there. The odds of needing quick access to / via Dolphin are extremely rare, and there is already a link anyway. People are used to clicking the primary drive to get to root dir.
Sep 24 2018
Changed to OBSERVED.
- Fix wording some more
Improved wording so I don't scare people. ;)
Good point, @broulik thoughts?
- Wording tweak
The text is current set to be italicized ("emphasized"). Not sure if you'd prefer bold, or what. Let me know if you want a change.
Ok, I created the calendar events, I moved the 25th to the 27th. That whole week will be rough, but we should at least host a day for anyone that does not celebrate Christmas or has nothing to do. ;)
Ok, I've created the next calendar events. Thanks for the suggestions!
Sep 23 2018
@sitter - I just wanted to loop you in here since you had offered to script the NEEDSINFO closure bot.
Sep 22 2018
Sep 21 2018
- Change text formatting
Good catch, apparently LibreOffice made a mistake! ;)
- Change default text placement
Yeah I think that is a mistake. D42047 which precedes the current diff, makes much more sense.