acrouthamel (Andrew Crouthamel)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2018, 6:07 AM (39 w, 2 d)
Availability
Available

Recent Activity

Today

acrouthamel added a comment to D16852: Add Documents to the default list of Places.

you could tackle the patch to make Dolphin's default window size a tad taller.

I'll poke around.

Mon, Nov 19, 3:03 PM · Frameworks
acrouthamel added a reviewer for D16941: Fix inconsistent viewport positioning in PageView: Okular.
Mon, Nov 19, 2:50 PM · Okular
acrouthamel added a comment to D16852: Add Documents to the default list of Places.

I had submitted this with the intention of being a follow-up to D15739, as that would clear a slot for this. I think right now, T9795 is outside my skill set. I'd be glad to make D15739 a parent to this and wait for that to land.

Mon, Nov 19, 2:00 PM · Frameworks

Yesterday

acrouthamel awarded D16980: Return editable URL navigator to breadcrumb mode when it has focus and Ctrl+L is pressed a Like token.
Sun, Nov 18, 4:28 PM · Dolphin
acrouthamel added a comment to D16967: Add Documents shortcut detection.

I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Looking for help to fix this.

Sun, Nov 18, 4:59 AM · Dolphin
acrouthamel added a comment to D16852: Add Documents to the default list of Places.

@acrouthamel Please open another diff with your patch thats updates the dolphin test, so I can try easily try it out

Sun, Nov 18, 4:58 AM · Frameworks
acrouthamel updated the summary of D16967: Add Documents shortcut detection.
Sun, Nov 18, 4:57 AM · Dolphin
acrouthamel added a dependency for D16967: Add Documents shortcut detection: D16852: Add Documents to the default list of Places.
Sun, Nov 18, 4:56 AM · Dolphin
acrouthamel added a dependent revision for D16852: Add Documents to the default list of Places: D16967: Add Documents shortcut detection.
Sun, Nov 18, 4:56 AM · Frameworks
acrouthamel requested review of D16967: Add Documents shortcut detection.
Sun, Nov 18, 4:55 AM · Dolphin

Fri, Nov 16

acrouthamel added a comment to D16852: Add Documents to the default list of Places.

I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Do I need to run this test on a new user account or something?

Fri, Nov 16, 3:21 AM · Frameworks

Tue, Nov 13

davidc awarded D16852: Add Documents to the default list of Places a Like token.
Tue, Nov 13, 11:10 AM · Frameworks
acrouthamel added a comment to D16852: Add Documents to the default list of Places.

Thanks, I spent some time looking through Elvis' commits to the Dolphin PlacesItemModelTest. I believe I added m_hasDocumentsFolder in the various locations properly, but I am still getting a failure in the test. Any tips are appreciated @elvisangelaccio. My attempt is at https://paste.kde.org/pey6davmw

Tue, Nov 13, 5:06 AM · Frameworks
acrouthamel requested review of D16852: Add Documents to the default list of Places.
Tue, Nov 13, 3:37 AM · Frameworks

Fri, Nov 9

acrouthamel added a comment to D16474: Change Software and OS Versions in Template.

Friendly ping.

Fri, Nov 9, 6:05 AM · Bugsquad

Thu, Nov 8

acrouthamel awarded D16767: Improve Ux for the places panel's hidden items a Like token.
Thu, Nov 8, 9:24 PM · Dolphin
acrouthamel added a comment to D15739: [Places panel] Don't show Root by default.

+1 it's an entry I always hide when I setup someone's computer

you can still get to / on your machine in one click using the appropriate disk entry on the bottom of the Places panel.

Which I think shouldn't be there, but I'm too afraid of touching Solid's ignore rules ever again.

Thu, Nov 8, 6:43 PM · Frameworks

Mon, Nov 5

acrouthamel added a comment to D16633: Add root version of drive-harddisk.

I did not add drive-harddisk-home in this commit because it was simply too difficult to make an easily readable symbol for home on the 16px version.

What about

~

or

$

?

Mon, Nov 5, 2:05 AM · Frameworks

Sat, Nov 3

acrouthamel awarded D16653: Use the new `drive-harddisk-root` icon for the root volume a Love token.
Sat, Nov 3, 10:35 PM · Frameworks
acrouthamel awarded D16633: Add root version of drive-harddisk a Love token.
Sat, Nov 3, 10:35 PM · Frameworks

Tue, Oct 30

acrouthamel added a comment to E476: Bugsquad Bug Day - Konsole.

Oops! I forgot to copy over the Etherpad contents until now! Sorry everyone! Bug batches are now up!

Tue, Oct 30, 12:57 PM · Event: Bugsquad

Sun, Oct 28

acrouthamel added a project to D16474: Change Software and OS Versions in Template: Bugsquad.
Sun, Oct 28, 5:02 AM · Bugsquad
acrouthamel requested review of D16474: Change Software and OS Versions in Template.
Sun, Oct 28, 4:55 AM · Bugsquad

Oct 19 2018

acrouthamel awarded D16307: [KStandardItemListWidget] Pass icon state to overlay painter a Orange Medal token.
Oct 19 2018, 1:42 PM · Dolphin

Oct 9 2018

acrouthamel added a comment to D16090: Add benevity and Amazon Smile to "Other ways to Donate".

Can you only use amazon.de? Or can USA people use amazon.com as well?

Oct 9 2018, 9:49 PM

Oct 7 2018

acrouthamel added a comment to D16019: Added missing icons to panel places items.

Fair enough, just something that I noticed after dealing with some of that with Gwenview.

Oct 7 2018, 11:56 PM · Dolphin
acrouthamel added a comment to D16019: Added missing icons to panel places items.

Could you add some screenshots?

Oct 7 2018, 4:32 PM · Dolphin

Oct 5 2018

acrouthamel added a comment to D15974: Add 'Mount' option to context menu of unmounted device in Places.

+1 btw from me, makes sense and the context menu isn't very cluttered.

Oct 5 2018, 9:00 PM · Dolphin
acrouthamel added a comment to D15974: Add 'Mount' option to context menu of unmounted device in Places.

Hey Thomas, just a note that you should put your initial comments and screenshot in the Summary/Details of the diff so it doesn't get lost after lengthy discussion.

Oct 5 2018, 8:55 PM · Dolphin
acrouthamel added a comment to D15609: Add "Create New" menu to "Control" button.

I like the idea, it makes it more easily discoverable if you're using touch. Not that I'm advocating cluttering this menu with a million things, but something to think about are the other functions in the right-click menu. Just thinking out loud.

Oct 5 2018, 7:41 PM · Dolphin

Oct 3 2018

acrouthamel added a comment to D15931: [Places panel] use more appropriate network icon.

+1 from me, makes sense. I say that as a guy who stares at server racks all day.

Oct 3 2018, 11:12 PM · Frameworks

Oct 2 2018

acrouthamel added a comment to T9780: Find/invent interaction pattern for window touch resizing.

! In T9780#162302, @fabianr wrote:
You can just use both hands? We are mainly talking about laptop and desktop touchscreens here aren't we?

I would even suggest a gesture where you position 2 fingers in the window and move a third finger (from the other hand) in the direction you want to resize the window.

Oct 2 2018, 5:54 PM · KDE Human Interface Guidelines, VDG

Oct 1 2018

acrouthamel added a comment to D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon.

What are the different possible emblems that can be applied automatically by the mount process?

Oct 1 2018, 8:53 PM · Frameworks

Sep 26 2018

acrouthamel updated subscribers of T9757: Clean up Bugzilla products and components.
Sep 26 2018, 7:11 PM · Bugsquad
acrouthamel updated subscribers of T9757: Clean up Bugzilla products and components.
Sep 26 2018, 7:08 PM · Bugsquad
acrouthamel updated the task description for T9757: Clean up Bugzilla products and components.
Sep 26 2018, 7:05 PM · Bugsquad
acrouthamel updated the task description for T9757: Clean up Bugzilla products and components.
Sep 26 2018, 7:01 PM · Bugsquad
ngraham awarded T9757: Clean up Bugzilla products and components a Like token.
Sep 26 2018, 4:58 PM · Bugsquad
acrouthamel added a comment to T9757: Clean up Bugzilla products and components.

@sitter, if you have any more issues you've noticed since that kde-community discussion, please post them here and I'll make sure they get addressed (eventually).

Sep 26 2018, 4:51 PM · Bugsquad
acrouthamel triaged T9757: Clean up Bugzilla products and components as Low priority.
Sep 26 2018, 4:50 PM · Bugsquad

Sep 25 2018

acrouthamel added a comment to D15749: Add tooltips to krunner configure and close buttons.

would you like to do the honors and land this for him, @acrouthamel?

Sep 25 2018, 9:27 PM · Plasma
acrouthamel committed R120:f57460a61643: Add tooltips to krunner configure and close buttons (authored by slenz).
Add tooltips to krunner configure and close buttons
Sep 25 2018, 9:26 PM
acrouthamel closed D15749: Add tooltips to krunner configure and close buttons.
Sep 25 2018, 9:26 PM · Plasma
acrouthamel accepted D15749: Add tooltips to krunner configure and close buttons.

Ooh my first time being added as reviewer. ;)

Sep 25 2018, 8:42 PM · Plasma
acrouthamel moved T9625: Review and revise Bug Triaging wiki page from Backlog to Active on the Bugsquad board.
Sep 25 2018, 2:08 PM · Bugsquad
acrouthamel awarded T7116: Streamlined onboarding of new contributors a Party Time token.
Sep 25 2018, 2:05 PM · Goal settings 2017
acrouthamel added a comment to T7116: Streamlined onboarding of new contributors.

Hey @neofytosk, you can cross off all of the Bugzilla stuff. We've completed those items in the T6832 subtask.

Sep 25 2018, 2:05 PM · Goal settings 2017
ngraham awarded T6832: Improvements to Bugzilla - Making it easier and simpler a Mountain of Wealth token.
Sep 25 2018, 2:01 PM · Bugsquad, Goal settings 2017
acrouthamel closed T6832: Improvements to Bugzilla - Making it easier and simpler as Resolved.

I'm going to pull the automated NEEDSINFO handling from here, since this task is specific to new bug reporter experience. I'll work with Harald or whoever else would like to help. For now, I have a manual set of searches that seem to work well enough. I have some other automation ideas as well, so I'll just track that all in a separate task.

Sep 25 2018, 1:57 PM · Bugsquad, Goal settings 2017
acrouthamel closed T6832: Improvements to Bugzilla - Making it easier and simpler, a subtask of T7116: Streamlined onboarding of new contributors, as Resolved.
Sep 25 2018, 1:57 PM · Goal settings 2017
acrouthamel updated the task description for T6832: Improvements to Bugzilla - Making it easier and simpler.
Sep 25 2018, 1:53 PM · Bugsquad, Goal settings 2017
acrouthamel updated the task description for T6832: Improvements to Bugzilla - Making it easier and simpler.
Sep 25 2018, 1:24 PM · Bugsquad, Goal settings 2017
acrouthamel added a comment to D15719: Create attachment warning for patches.

Ok, let's try this.

Sep 25 2018, 2:59 AM
acrouthamel updated the diff for D15719: Create attachment warning for patches.
  • Remove patch wording
Sep 25 2018, 2:58 AM
acrouthamel added a comment to D15739: [Places panel] Don't show Root by default.

Seeing "Root" written as such, also makes me think of /root, which makes no sense to have there. The odds of needing quick access to / via Dolphin are extremely rare, and there is already a link anyway. People are used to clicking the primary drive to get to root dir.

Sep 25 2018, 2:47 AM · Frameworks

Sep 24 2018

acrouthamel added a comment to T8707: Window borders.

The resize area issue was rendered moot for smaller-than-normal border sizes at some point in the past with a clever change that allowed windows with "No Borders" to keep the extended resize areas of a window with "Normal" borders.

Sep 24 2018, 8:07 PM · VDG
acrouthamel updated the task description for T6831: Top-notch usability and productivity for basic software.
Sep 24 2018, 6:16 PM · Goal settings 2017
acrouthamel added a comment to D15731: Change bug creation template words.

Ok, v2.0

Sep 24 2018, 2:44 PM
acrouthamel updated the summary of D15731: Change bug creation template words.
Sep 24 2018, 2:43 PM
acrouthamel updated the diff for D15731: Change bug creation template words.

Changed to OBSERVED.

Sep 24 2018, 2:41 PM
acrouthamel added a comment to D15719: Create attachment warning for patches.

Done. :)

Sep 24 2018, 2:33 PM
acrouthamel updated the diff for D15719: Create attachment warning for patches.
  • Fix wording some more
Sep 24 2018, 2:33 PM
acrouthamel abandoned D15733: Use OBSERVED instead of ACTUAL.
Sep 24 2018, 2:25 PM
acrouthamel requested review of D15733: Use OBSERVED instead of ACTUAL.
Sep 24 2018, 2:24 PM
acrouthamel added a comment to D15719: Create attachment warning for patches.

Improved wording so I don't scare people. ;)

Sep 24 2018, 2:22 PM
acrouthamel added a comment to D15731: Change bug creation template words.

Good point, @broulik thoughts?

Sep 24 2018, 2:21 PM
acrouthamel added a comment to D15731: Change bug creation template words.

+1
Thanks!

Sep 24 2018, 2:20 PM
acrouthamel added a reviewer for D15731: Change bug creation template words: Sysadmin.
Sep 24 2018, 2:19 PM
acrouthamel requested review of D15731: Change bug creation template words.
Sep 24 2018, 2:12 PM
acrouthamel updated the diff for D15719: Create attachment warning for patches.
  • Wording tweak
Sep 24 2018, 2:08 PM
acrouthamel added a comment to D15719: Create attachment warning for patches.

The text is current set to be italicized ("emphasized"). Not sure if you'd prefer bold, or what. Let me know if you want a change.

Sep 24 2018, 3:58 AM
acrouthamel updated the task description for T6832: Improvements to Bugzilla - Making it easier and simpler.
Sep 24 2018, 3:36 AM · Bugsquad, Goal settings 2017
acrouthamel retitled D15719: Create attachment warning for patches from Create attachemnt warning for patches to Create attachment warning for patches.
Sep 24 2018, 3:34 AM
acrouthamel added a reviewer for D15719: Create attachment warning for patches: Sysadmin.
Sep 24 2018, 3:34 AM
acrouthamel requested review of D15719: Create attachment warning for patches.
Sep 24 2018, 3:32 AM
acrouthamel closed T9690: Decide on Bug Day occurance as Resolved.

Ok, I created the calendar events, I moved the 25th to the 27th. That whole week will be rough, but we should at least host a day for anyone that does not celebrate Christmas or has nothing to do. ;)

Sep 24 2018, 3:08 AM · Bugsquad
acrouthamel closed T9691: Decide on 2018 products as Resolved.

Ok, I've created the next calendar events. Thanks for the suggestions!

Sep 24 2018, 3:07 AM · Bugsquad
acrouthamel changed E480: Bugsquad Bug Day - Kdenlive to an all day event.
Sep 24 2018, 3:03 AM · Event: Bugsquad
acrouthamel created E480: Bugsquad Bug Day - Kdenlive.
Sep 24 2018, 3:03 AM · Event: Bugsquad
acrouthamel changed E479: Bugsquad Bug Day - Kdenlive to an all day event.
Sep 24 2018, 3:01 AM · Event: Bugsquad
acrouthamel created E479: Bugsquad Bug Day - Kdenlive.
Sep 24 2018, 3:01 AM · Event: Bugsquad
acrouthamel changed E478: Bugsquad Bug Day - Okular to an all day event.
Sep 24 2018, 2:59 AM · Event: Bugsquad
acrouthamel created E478: Bugsquad Bug Day - Okular.
Sep 24 2018, 2:59 AM · Event: Bugsquad
acrouthamel changed E477: Bugsquad Bug Day - Okular to an all day event.
Sep 24 2018, 2:57 AM · Event: Bugsquad
acrouthamel created E477: Bugsquad Bug Day - Okular.
Sep 24 2018, 2:57 AM · Event: Bugsquad
acrouthamel updated the event description for E476: Bugsquad Bug Day - Konsole.
Sep 24 2018, 2:55 AM · Event: Bugsquad
acrouthamel changed E476: Bugsquad Bug Day - Konsole to an all day event.
Sep 24 2018, 2:55 AM · Event: Bugsquad
acrouthamel created E476: Bugsquad Bug Day - Konsole.
Sep 24 2018, 2:55 AM · Event: Bugsquad
acrouthamel changed E475: Bugsquad Bug Day - Konsole to an all day event.
Sep 24 2018, 2:53 AM · Event: Bugsquad
acrouthamel created E475: Bugsquad Bug Day - Konsole.
Sep 24 2018, 2:52 AM · Event: Bugsquad

Sep 23 2018

acrouthamel updated subscribers of T6832: Improvements to Bugzilla - Making it easier and simpler.

@sitter - I just wanted to loop you in here since you had offered to script the NEEDSINFO closure bot.

Sep 23 2018, 5:01 AM · Bugsquad, Goal settings 2017

Sep 22 2018

acrouthamel added a comment to T9690: Decide on Bug Day occurance.
  • 25. December (this is a bad date, we'll need to move that)
Sep 22 2018, 6:19 PM · Bugsquad

Sep 21 2018

acrouthamel updated the task description for T6832: Improvements to Bugzilla - Making it easier and simpler.
Sep 21 2018, 8:46 PM · Bugsquad, Goal settings 2017
acrouthamel updated the task description for T6832: Improvements to Bugzilla - Making it easier and simpler.
Sep 21 2018, 8:46 PM · Bugsquad, Goal settings 2017
acrouthamel added a comment to D15630: Create text template for bug creation comments.

Based on how the rest of the text is formatted i'd suggest removing the quotes and turning the newlines into actual newlines.

Sep 21 2018, 8:10 PM · Bugsquad
acrouthamel updated the diff for D15630: Create text template for bug creation comments.
  • Change text formatting
Sep 21 2018, 8:09 PM · Bugsquad
acrouthamel added a comment to D15630: Create text template for bug creation comments.

Good catch, apparently LibreOffice made a mistake! ;)

Sep 21 2018, 4:31 PM · Bugsquad
acrouthamel updated the diff for D15630: Create text template for bug creation comments.
  • Change default text placement
Sep 21 2018, 4:30 PM · Bugsquad
acrouthamel added a comment to D15644: Provide option to hide menu bar for Ksysguard.

Yeah I think that is a mistake. D42047 which precedes the current diff, makes much more sense.

Sep 21 2018, 2:57 PM · Plasma
acrouthamel added a comment to D15632: Change bug writing guideling link to bug reporting wiki page.

@bcooksley, I think you'll need to land this since permissions to the websites- repos are quite restricted.

Sep 21 2018, 2:54 PM · Bugsquad