@ngraham I'm assuming this should be committed since you just committed D16852?

How do dependencies work here? Does this force SMB1 to be installed and enabled in Dolphin now? I ask because many companies have disabled and removed version 1 due to the security issues.

Thanks for expanding the thumbnailer lately, awesome work with this and the eBook one. :)

Hey there, I see this is on the Bugsquad calendar. Should we be attending?

I've gone ahead and created the current schedule in the calendar. Please mark yourself as attending for whichever ones you are interested in. That way you receive updates on any discussion or updates on the event.

-1 from me. I would prefer we stick to Unix methodologies.

I made some tweaks to the list based on @xyquadrat's observations on bug load.

In T10409#174698, @xyquadrat wrote:

@acrouthamel I was just thinking about the fact that we need to kick off some more Bug days for this year when I saw the notification that you were a tiny bit faster than me... :)
List sounds very reasonable, and I do agree that it is important to contact as many of the developers in advance to ensure we are as efficient and productive as possible. My only concern is that we might not have enough KCalc bugs to triage for two sessions, so we might need to search an additional alternative. Are we going to keep the two-week-rhythm?

Yeah, good point, maybe we combine ark with kcalc since they're both small. I wanted to pick some easy, smaller ones that were common utilities, since activity was light end of 2018. Open to suggestions. :)

In T10409#174695, @cfeck wrote:

In T10409#174681, @Sebelbrecht wrote:

One question though: are the projects which bugs we triage aware of the plan?
I got the feeling last year a few times that there was no communication of us and the team (e.g. Krita).

It's indeed important that developers get involved beforehand. Especially digiKam developers, because they have long established bugzilla practices.

I like the new theme, much cleaner. Thanks @jriddell for taking this on, it's been sorely needed.

In D16299#363498, @sitter wrote:

If someone has a thought to offer on this please do.
Personally I am somewhat leaning towards assuming that systems should be properly configured. The problem with setting the URL to the ip address is that it messes with the visual look in the address bar. So, if we want reliable resolution and good looks we'd need to resolve each dnssd address (e.g. foobar.local) to their ip address (e.g. 172.17.0.1) via kdnssd and then resolve that back to a hostname via glibc/qhostinfo (e.g. foobar.sky.net). That way we'd know that the name we have in the end is in fact resolvable by the system without aid from dnssd. Speed impact of this aside it also adds 3 additional points of failure (and KDNSSD currently doesn't implement the resolver API it seems).

In D16852#362344, @ngraham wrote:

you could tackle the patch to make Dolphin's default window size a tad taller.

I'll poke around.

I had submitted this with the intention of being a follow-up to D15739, as that would clear a slot for this. I think right now, T9795 is outside my skill set. I'd be glad to make D15739 a parent to this and wait for that to land.

I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Looking for help to fix this.

In D16852#360940, @elvisangelaccio wrote:

@acrouthamel Please open another diff with your patch thats updates the dolphin test, so I can try easily try it out

I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Do I need to run this test on a new user account or something?

Thanks, I spent some time looking through Elvis' commits to the Dolphin PlacesItemModelTest. I believe I added m_hasDocumentsFolder in the various locations properly, but I am still getting a failure in the test. Any tips are appreciated @elvisangelaccio. My attempt is at https://paste.kde.org/pey6davmw

Friendly ping.

In D15739#331468, @broulik wrote:

+1 it's an entry I always hide when I setup someone's computer

you can still get to / on your machine in one click using the appropriate disk entry on the bottom of the Places panel.

Which I think shouldn't be there, but I'm too afraid of touching Solid's ignore rules ever again.

I did not add drive-harddisk-home in this commit because it was simply too difficult to make an easily readable symbol for home on the 16px version.

What about

~

or

$

?

Oops! I forgot to copy over the Etherpad contents until now! Sorry everyone! Bug batches are now up!

Can you only use amazon.de? Or can USA people use amazon.com as well?

Fair enough, just something that I noticed after dealing with some of that with Gwenview.

Could you add some screenshots?

+1 btw from me, makes sense and the context menu isn't very cluttered.

Hey Thomas, just a note that you should put your initial comments and screenshot in the Summary/Details of the diff so it doesn't get lost after lengthy discussion.

I like the idea, it makes it more easily discoverable if you're using touch. Not that I'm advocating cluttering this menu with a million things, but something to think about are the other functions in the right-click menu. Just thinking out loud.

+1 from me, makes sense. I say that as a guy who stares at server racks all day.

! In T9780#162302, @fabianr wrote:
You can just use both hands? We are mainly talking about laptop and desktop touchscreens here aren't we?

I would even suggest a gesture where you position 2 fingers in the window and move a third finger (from the other hand) in the direction you want to resize the window.

What are the different possible emblems that can be applied automatically by the mount process?

@sitter, if you have any more issues you've noticed since that kde-community discussion, please post them here and I'll make sure they get addressed (eventually).

In D15749#331860, @ngraham wrote:

would you like to do the honors and land this for him, @acrouthamel?

Ooh my first time being added as reviewer. ;)