aaronpuchert (Aaron Puchert)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2017, 9:32 PM (44 w, 5 d)
Availability
Available

Recent Activity

Jan 19 2018

aaronpuchert accepted D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry.

@rjvbb You certainly have a point when you say that there are more deficits to address, but nothing will ever get done unless someone does it. Nobody here is claiming that this solves all problems, but I don't see how it would hinder further improvements down the road, including those that you have sketched.

Jan 19 2018, 8:58 PM · Frameworks

Jan 18 2018

aaronpuchert added a comment to D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry.
In D9824#192793, @rjvbb wrote:

If real-world impact is in the order of a highly significant but millisecond-order reduction of reaction time to file change there may be little reason to commit this improvement now (and then risk forgetting about the rest again). My hunch is that it could be more effective then to keep this change pending and use it as a motivation to work on a more complete overhaul of the class.

Jan 18 2018, 9:13 PM · Frameworks

Jan 6 2018

aaronpuchert committed R32:cc43cfbd8486: Correct list of language standards for C/C++ (authored by aaronpuchert).
Correct list of language standards for C/C++
Jan 6 2018, 4:44 PM
aaronpuchert closed D9583: Correct list of language standards for C/C++.
Jan 6 2018, 4:44 PM

Dec 19 2017

aaronpuchert committed R32:2162de4b755b: Add -Werror=switch and -Wcovered-switch-default (authored by aaronpuchert).
Add -Werror=switch and -Wcovered-switch-default
Dec 19 2017, 7:54 PM
aaronpuchert closed D9042: Add -Werror=switch and -Wcovered-switch-default.
Dec 19 2017, 7:54 PM
aaronpuchert added inline comments to D9042: Add -Werror=switch and -Wcovered-switch-default.
Dec 19 2017, 7:54 PM

Dec 18 2017

aaronpuchert added a comment to D9316: Remove KF5::ItemModels from public interface of KDevPlatformUtil.

I'm fine with the change otherwise, but I think @kfunk and/or @brauch should have a chance to revise or reaffirm their position.

Dec 18 2017, 11:34 PM
aaronpuchert added a comment to D9042: Add -Werror=switch and -Wcovered-switch-default.

@mwolff Are the additional changes Ok? There are no new warnings anymore.

Dec 18 2017, 11:28 PM

Dec 17 2017

aaronpuchert updated the diff for D9042: Add -Werror=switch and -Wcovered-switch-default.

Fix remaining occurences of -Wcovered-switch-default.

Dec 17 2017, 11:54 PM

Dec 14 2017

aaronpuchert added a comment to D9316: Remove KF5::ItemModels from public interface of KDevPlatformUtil.
In D9316#179221, @kfunk wrote:

It's adding code which we need to maintain (what if the KSelectionProxyModel::FilterBehavior enum is extended?)

Since MultiLevelListView::FilterBehavior is translated into KSelectionProxyModel::FilterBehavior, there should be no problem if the latter is extended. Of course one could think about also extending the former then, but I don't see something terrible happen if we don't.

Dec 14 2017, 12:55 AM
aaronpuchert accepted D9236: Fill lists of default-constructed types directly, not append any by value.
Dec 14 2017, 12:32 AM

Dec 9 2017

aaronpuchert added a comment to D9236: Fill lists of default-constructed types directly, not append any by value.

I still have to complete my C++11 classes sadly. In my naive mind I would have hoped something like this would be possible, in general:

alloc heap memory for list items
for each item
    default constructor item on heap
    setup item on heap

I would not see any principal need to prepare the item on the stack. Is there? Why would C++11 still prefer a move operator, instead of going directly for the final memory destination?

Dec 9 2017, 8:48 PM

Dec 8 2017

aaronpuchert added a comment to D9236: Fill lists of default-constructed types directly, not append any by value.

By the way, it's usually a good idea to have vector elements nothrow-move constructible. This can be checked with

Dec 8 2017, 9:21 PM
aaronpuchert added a comment to D9236: Fill lists of default-constructed types directly, not append any by value.

It might not actually be faster though, because you go through the memory twice. If the vector doesn't fit into the cache, that could introduce quite some slowdown.

Dec 8 2017, 9:04 PM

Dec 1 2017

aaronpuchert committed R32:ada2a0442ab6: Custom defines/includes: Improve handling of parser arguments (authored by aaronpuchert).
Custom defines/includes: Improve handling of parser arguments
Dec 1 2017, 12:44 PM
aaronpuchert closed D8634: Custom defines/includes: Improve handling of parser arguments.
Dec 1 2017, 12:44 PM

Nov 30 2017

aaronpuchert updated the diff for D9042: Add -Werror=switch and -Wcovered-switch-default.

Fix -Wcovered-switch-default where it is safe to do so.

Nov 30 2017, 12:46 AM

Nov 29 2017

aaronpuchert added a comment to D9042: Add -Werror=switch and -Wcovered-switch-default.

There are no issues with -Wswitch, but some with -Wcovered-switch-default.

Nov 29 2017, 10:41 PM

Nov 28 2017

aaronpuchert created D9042: Add -Werror=switch and -Wcovered-switch-default.
Nov 28 2017, 11:32 PM
aaronpuchert added a comment to D8634: Custom defines/includes: Improve handling of parser arguments.

Good idea, -Wswitch is a nice tool. But it doesn't seem activated in the builds, at least with Clang.

Nov 28 2017, 9:50 PM
aaronpuchert updated the diff for D8634: Custom defines/includes: Improve handling of parser arguments.

Made sure switches over enums cover all values, and used more auto.

Nov 28 2017, 9:42 PM

Nov 27 2017

aaronpuchert added a comment to D8634: Custom defines/includes: Improve handling of parser arguments.

I figured - couldn't we simply replace ParserArguments with e.g. a QHash<Utils::LanguageType, QString>? Or, better yet, we make it a QString[Utils::LanguageType::Other]?

There is still that flag parseAmbiguousAsCPP, but I like the idea of using an array. Maybe we can get rid of the flag, but I wouldn't want to do too much in one change.

Nov 27 2017, 12:26 AM
aaronpuchert updated the diff for D8634: Custom defines/includes: Improve handling of parser arguments.

Incorporated review by Milian:

Nov 27 2017, 12:25 AM

Nov 24 2017

aaronpuchert added a comment to D8953: Make VcsLocation also implicitly shared.

It is indeed a mystery. Note that the member function isn't marked const, which it probably should be. Adding the const specifier produces a compiler error (about ambiguous function calls), as it should.

Nov 24 2017, 1:54 AM

Nov 13 2017

aaronpuchert committed R32:3512f8906466: Don't ask for compiler-specific includes in QmlJS (authored by aaronpuchert).
Don't ask for compiler-specific includes in QmlJS
Nov 13 2017, 11:33 PM
aaronpuchert closed D8654: Don't ask for compiler-specific includes in QmlJS.
Nov 13 2017, 11:33 PM

Nov 7 2017

aaronpuchert committed R32:8cbb71444fd5: Ignore unrecognized files in CompilerProvider (authored by aaronpuchert).
Ignore unrecognized files in CompilerProvider
Nov 7 2017, 2:22 PM
aaronpuchert added a comment to D8654: Don't ask for compiler-specific includes in QmlJS.

Technically, we need only D8653 or this change to fix bug 386388. Do we still want this change?

Nov 7 2017, 12:37 PM
aaronpuchert committed R32:2462a638732d: Ignore unrecognized files in CompilerProvider (authored by aaronpuchert).
Ignore unrecognized files in CompilerProvider
Nov 7 2017, 12:32 PM
aaronpuchert closed D8653: Ignore unrecognized files in CompilerProvider.
Nov 7 2017, 12:31 PM

Nov 4 2017

aaronpuchert committed R32:eb47a383b81c: Recognize MIME type text/x-opencl-src as OpenCL (authored by aaronpuchert).
Recognize MIME type text/x-opencl-src as OpenCL
Nov 4 2017, 7:59 PM
aaronpuchert closed D8644: Recognize MIME type text/x-opencl-src as OpenCL.
Nov 4 2017, 7:58 PM
aaronpuchert created D8654: Don't ask for compiler-specific includes in QmlJS.
Nov 4 2017, 6:38 PM
aaronpuchert created D8653: Ignore unrecognized files in CompilerProvider.
Nov 4 2017, 6:37 PM
aaronpuchert added a comment to D8317: Don't try to guess the language from given arguments.

I know that there is a problem, see the discussion on change D8634. The problem is that I'm not sure how to proceed: when do we encounter Utils::Other, and what do we do about it? The Clang Parser can probably not parse a file of type Utils::Other anyway.

Nov 4 2017, 5:24 PM

Nov 3 2017

aaronpuchert added a comment to D8634: Custom defines/includes: Improve handling of parser arguments.

I'm going to address the comments I didn't reply to.

Nov 3 2017, 5:53 PM
aaronpuchert created D8644: Recognize MIME type text/x-opencl-src as OpenCL.
Nov 3 2017, 5:42 PM
aaronpuchert created D8634: Custom defines/includes: Improve handling of parser arguments.
Nov 3 2017, 2:05 AM

Oct 20 2017

aaronpuchert added a comment to D8211: KDevelop/Documentation : implementation of a QTextBrowser-based viewer.

The discussion is getting really nasty and I don't think it leads anywhere.

Oct 20 2017, 8:46 PM · KDevelop

Oct 19 2017

aaronpuchert added a comment to D8211: KDevelop/Documentation : implementation of a QTextBrowser-based viewer.

And "more advanced rendering code" still makes sense in an integrated development environment, at least to me, I see rendering power orthogonal to being part of IDE. Actually I consider a separate general browser application an inferior solution, as it does not allow to be properly integrated into kdevelop project/session management (project/session specific bookmarks, browsing history, tight control about location in UI etc).

Oct 19 2017, 11:32 PM · KDevelop

Oct 17 2017

aaronpuchert added a comment to D8317: Don't try to guess the language from given arguments.

If you run arc patch D8317 locally, you should get the commit with all necessary information, including my email address.

Oct 17 2017, 8:01 PM

Oct 16 2017

aaronpuchert added a comment to D8317: Don't try to guess the language from given arguments.

I don't have commit access yet, so could you commit this for me?

Oct 16 2017, 8:45 PM

Oct 15 2017

aaronpuchert updated the diff for D8317: Don't try to guess the language from given arguments.

Added language flag for Objective C.

Oct 15 2017, 8:51 PM
aaronpuchert created D8317: Don't try to guess the language from given arguments.
Oct 15 2017, 8:31 PM

Oct 11 2017

aaronpuchert added a comment to D8211: KDevelop/Documentation : implementation of a QTextBrowser-based viewer.
In D8211#154109, @rjvbb wrote:

I tested the build using WebKit as the backend with and without my patch (not with the very latest version) and didn't notice any difference. I do notice that it won't follow most (if not all) links in the documentation (also without my patch), is there something wrong with my build there?

Oct 11 2017, 8:40 PM · KDevelop

Sep 27 2017

aaronpuchert added inline comments to D7995: KDevelop: address dirwatching inefficiency (WIP/PoC).
Sep 27 2017, 9:12 PM · KDevelop

Sep 17 2017

aaronpuchert added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..
In D7745#146271, @rjvbb wrote:

Seriously, how many of us use KDevelop to work on projects the size of GCC or llvm and need dirwatching on the whole tree? How expensive is that on Linux, *after* the initial import?

Watching directories is quite essential when working with Git or other SCMs. When checking out another branch, I want KDevelop's file tree to be updated as well.

Sep 17 2017, 1:59 PM · KDevelop

Sep 5 2017

aaronpuchert added a comment to D7693: Enable reproducible packaging of template archives.

Thanks!

Sep 5 2017, 8:28 PM
aaronpuchert added a comment to D7693: Enable reproducible packaging of template archives.

I see you already submitted the change, but you omitted --sort=name.

Sep 5 2017, 6:31 PM

Sep 4 2017

aaronpuchert created D7693: Enable reproducible packaging of template archives.
Sep 4 2017, 10:18 PM

Aug 18 2017

aaronpuchert updated the diff for D7280: Add syntax highlighting for Metamath.

Fix commit message and indentation.

Aug 18 2017, 10:21 PM · Frameworks

Aug 13 2017

aaronpuchert added inline comments to D5491: Improve detection of builtin defines from compiler command.
Aug 13 2017, 7:44 PM
aaronpuchert updated the diff for D7280: Add syntax highlighting for Metamath.

Changed license to MIT.

Aug 13 2017, 12:13 PM · Frameworks
aaronpuchert added a comment to D7280: Add syntax highlighting for Metamath.

I don't have a commit account, so I'd need you to commit the changes.

Aug 13 2017, 12:12 PM · Frameworks

Aug 12 2017

aaronpuchert added a comment to D7280: Add syntax highlighting for Metamath.

There are screenshots of other (known) syntax highlighters for Metamath on their homepage.

Aug 12 2017, 9:59 PM · Frameworks
aaronpuchert created D7280: Add syntax highlighting for Metamath.
Aug 12 2017, 9:46 PM · Frameworks

Jul 10 2017

aaronpuchert added a comment to D6184: restore horizontal scrollbar in the project manager plugin.
In D6184#123281, @rjvbb wrote:

I'm beginning to understand the objections from X11 users. Even with my settings horizontal scrolling behaves as if it's configured to scroll at least half the viewport width at a time. On Mac/Cocoa, horizontal and vertical scrolling are equally smooth, and that's where I did most of my testing (while replying to this ticket).

Jul 10 2017, 10:00 PM · KDevelop

Jul 8 2017

aaronpuchert added a comment to D6184: restore horizontal scrollbar in the project manager plugin.
In D6184#122970, @rjvbb wrote:

In these cases you don't want horizontal scrolling, because it destroys the alignment that helps the user orient. Which is especially important in source code, or a directory tree.

?? Who said my change implements per-line scrolling? The whole view is scrolled, just like in a text view where alignment is also not "destroyed" as you claim. Wrapping is much more detrimental to orientation.

Jul 8 2017, 10:25 PM · KDevelop

Jul 7 2017

aaronpuchert added a comment to D6184: restore horizontal scrollbar in the project manager plugin.

Just my two cents: I work with a touch pad most of the time and wouldn't like horizontal scrolling in the project manager. The problem is that it wobbles left and right when all you want is to scroll up and down. I'm also not using it in the source code view, instead the dynamic word wrap helps me to break long lines, if they occur.

Jul 7 2017, 9:25 PM · KDevelop

May 31 2017

aaronpuchert added a comment to D5978: Fix list of available OpenCL C standards.

If anyone cares, here is what the official documentation says on this matter. I want to address the -std= vs. -cl-std= issue in another commit.

May 31 2017, 9:33 PM

May 29 2017

aaronpuchert added a comment to D5978: Fix list of available OpenCL C standards.

@apol: Could you have a look again? I think there is nothing wrong here.

May 29 2017, 9:21 PM

May 27 2017

aaronpuchert added inline comments to D5978: Fix list of available OpenCL C standards.
May 27 2017, 8:56 PM

May 26 2017

This is a test notification, sent at Fri, May 26, 21:23.
May 26 2017, 7:23 PM
aaronpuchert created D5978: Fix list of available OpenCL C standards.
May 26 2017, 7:21 PM
aaronpuchert created D5977: Fix setting and enablement of parser options fields.
May 26 2017, 6:25 PM

May 8 2017

aaronpuchert added a comment to D5621: Install xdg mimetype definitions for OpenCL C & CUDA C.

By the way, I posted the question to Khronos. Their preferred channel seems to be opening an issue on one of their GitHub repositories. So I opened issue #27 at the OpenCL Registry. However, I do not expect an answer. From Khronos' point of view OpenCL source code is just a string in memory. Compiling OpenCL directly from file is not possible. (As far as I know the API.)

May 8 2017, 11:52 PM

Apr 29 2017

aaronpuchert added inline comments to D5621: Install xdg mimetype definitions for OpenCL C & CUDA C.
Apr 29 2017, 12:11 AM

Apr 28 2017

aaronpuchert added inline comments to D5621: Install xdg mimetype definitions for OpenCL C & CUDA C.
Apr 28 2017, 11:28 PM

Apr 27 2017

aaronpuchert added inline comments to D5621: Install xdg mimetype definitions for OpenCL C & CUDA C.
Apr 27 2017, 9:58 PM

Apr 18 2017

aaronpuchert added inline comments to D5491: Improve detection of builtin defines from compiler command.
Apr 18 2017, 6:35 PM
aaronpuchert added a comment to D5491: Improve detection of builtin defines from compiler command.

It might be that some OpenCL compilers support "clx.y", but the standard doesn't seem to allow it. (Even older standards don't: https://www.khronos.org/registry/OpenCL/sdk/1.1/docs/man/xhtml/clBuildProgram.html#idp145296)

Apr 18 2017, 2:02 PM

Apr 17 2017

aaronpuchert created D5485: The OpenCL language is actually called OpenCL C.
Apr 17 2017, 10:34 PM
aaronpuchert added a member for KDevelop: aaronpuchert.
Apr 17 2017, 9:42 PM