Create attachment warning for patches

Authored by acrouthamel on Sep 24 2018, 3:32 AM.



This creates a warning message when one creates an attachment,
informing of KDE's use of Phabricator to submit patches, and to not
submit a patch through Bugzilla.

Per request of T6832.

Diff Detail

R895 Customised Bugzilla for
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
acrouthamel requested review of this revision.Sep 24 2018, 3:32 AM
acrouthamel created this revision.
acrouthamel edited the summary of this revision. (Show Details)Sep 24 2018, 3:34 AM
acrouthamel added a reviewer: Sysadmin.
acrouthamel retitled this revision from Create attachemnt warning for patches to Create attachment warning for patches.
acrouthamel added a subscriber: ngraham.
ngraham accepted this revision.Sep 24 2018, 3:39 AM


This revision is now accepted and ready to land.Sep 24 2018, 3:39 AM

The text is current set to be italicized ("emphasized"). Not sure if you'd prefer bold, or what. Let me know if you want a change.

Rather than using a hard do not submit patches here perhaps it might be better to say that Bugzilla is not monitored actively for patches, and that any patches uploaded here will be missed?

  • Wording tweak

Improved wording so I don't scare people. ;)

I would change "may be missed" to "is likely to be missed" to add a bit more certainty to it, since in point of fact, the patch is indeed likely to be missed judging by historical trends.

  • Fix wording some more
ngraham requested changes to this revision.Sep 24 2018, 2:52 PM

OK, actually simulating this for a user workflow, I think we need more changes to get the point across:

  • On the main page, we should change "Add an attachment (proposed patch, testcase, etc.)" to "Add an attachment (screenshot of the issue, test case, etc.)"
  • On the patch submission page, we should remove all references to the attachment being a possible patch.

Basically, this is a good start but not enough: if we don't want people to submit patches on Bugzilla, we shouldn't make it look like we've gone out of our way to explicitly encourage and support that in the attachment UX.

This revision now requires changes to proceed.Sep 24 2018, 2:52 PM
  • Remove patch wording

Ok, let's try this.

ngraham accepted this revision.Sep 25 2018, 3:45 AM

+1, though I can't really test this. :) I'll defer to Sysadmin for code review here regarding the section that touches scripts.

This revision is now accepted and ready to land.Sep 25 2018, 3:45 AM
bcooksley accepted this revision.Sep 25 2018, 8:08 AM

This looks fine as far as I can tell.

If memory serves checkboxes only result in data being sent when they're checked, so this change should be totally safe.

This revision was automatically updated to reflect the committed changes.