In D11880#330810, @ndavis wrote:

While orange may mean "warning", it could mean any kind of warning. In this case, it's a warning that an extreme setting is being used, but there is a lock in the corner to show that it is at least safe.

• signature.asc833 BDownload

Ping, @davidedmundson let's make some change on this

I confirmed that contentItem()->childItems() did indeed send it to mainItem. It also sends it to the FrameSvgItem too. It no longer sends it to the mysterious ColorScope.

In D15355#330784, @aacid wrote:

The ported dialog looks bad, both because the layout of the new widget is not where you would want it to be and because it has much less functionality than the native dialog.

It's an interesting problem though which i don't know how to fix. Maybe it could be a post save dialog? Like "ok, since now you chose to save as jpeg i'll ask you which quality you want to use"

Which seems to be like how gimp does it. What do you think?

setParentItem sets visual parent. Object parent and visual parent can be different.

Get rid of "Q" at the beginning of the class names.

Renamed according to KpXXXX scheme.

16px

In D15718#330864, @ngraham wrote:

Making files executable that don't need to be executable is a bad security habit. What if the contents get replaced with something malicious? Suddenly that now-malicious file has execute permissions.

Change wall color of firewall-applet-panic to \#4d4d4d (breeze) and \#f2f2f2 (breeze-dark)

because gating these scaling options behind Force rasterization is not very user friendly

In D11880#330861, @ngraham wrote:

For the panic mode icon, how about leaving the wall itself black, and only the lock is orange?

Making files executable that don't need to be executable is a bad security habit. What if the contents get replaced with something malicious? Suddenly that now-malicious file has execute permissions.

In D15718#330845, @ngraham wrote:

In D15718#330844, @smithjd wrote:

In D15718#330836, @ngraham wrote:

Wouldn't this have the effect of un-indexing most files? A quick check of my documents (text, word processing, excel, etc) reveals that none of them have the execute bit set. As-is, I think this would render Baloo mostly useless.

A default mask of 0002 or more permissive looks fairly common across distros, and is permissive enough to index files by default.

setfacl -d -m u::rwx ~ or umask 0022 will set default execute permissions on created files. You can set something less permissive on your downloads directory or plasma vault mount with setfacl -d u::rw or similar.

chmod -R 755 ~ will recursively give every file in your home directory execute permisions.

You are proposing fundamentally breaking Baloo and then requiring that users or distros clean up our mess for us by making all their files executable--in the process reducing their own security. Sorry, but this is simply unacceptable.

No part of this proposal makes any sense to me. We just can't do this.

The text is current set to be italicized ("emphasized"). Not sure if you'd prefer bold, or what. Let me know if you want a change.

For the panic mode icon, how about leaving the wall itself black, and only the lock is orange?

Wonderful.