You can find me around as tosky.
- User Since
- Apr 18 2015, 1:18 PM (191 w, 1 d)
There may be another way: add a new public method which wraps the protected one, and when moving to KF6 a) make setHelp public and b) deprecate the new wrapper. I think - suggestions needed
Sat, Dec 15
Fri, Dec 14
If you tested it and it works, just approve https://phabricator.kde.org/D13231 ; this is a duplicate.
Wed, Dec 12
Tue, Dec 11
Mon, Dec 10
Sat, Dec 8
Fri, Dec 7
Thu, Dec 6
Wed, Dec 5
Uhm, the review landed already in the previous version (before some comments) and on master?
If this is targeted to Applications/18.12 as I think it is, the doc change would break the freeze. I'd suggest to leave out index.docbook from this change, and only fix it after merging the change into the master branch.
(if you want more time to think about this, given that the tagging of Applications 18.12 is tomorrow, I'd suggest to bump the version to 2.1 on the Applications/18.12 branch now anyway)
The version should be definitely increased at this point.
As the new de-facto maintainer, I'd say that you can bump the version to whatever version you want.
Tue, Dec 4
Before implementing breaking changes, please make sure that the discussion is tracked on a permanent storage system, whatever chat system is used.
Mon, Dec 3
Sun, Dec 2
Sat, Dec 1
Fri, Nov 30
Thu, Nov 29
Tue, Nov 27
Sun, Nov 25
Sat, Nov 24
Fri, Nov 23
Thu, Nov 22
Translators, what do you think about this request for a string exception for Applications/18.12?
Would this be useful on Applications/18.12 too?
That's a great idea! Would it be possible:
- to also (optionally) support the translators' information, like in the current about box? (probably in a future patch, but maybe some groundwork is needed here)
- to move this about page to some common kirigami-addons library?
Wed, Nov 21
But shouldn't ECM complain regardless of the operating system? Or do you have different requirements for ECM under different operating systems? Those should be kept aligned: if you require that option, you are basically requiring ECM 5.49 everywhere.
Tue, Nov 20
(Please fix the edit policy of the review, which is now too restricted)
Mon, Nov 19
ecm_add_app_icon should be a noop outside WIN32 and APPLE platforms, so the if()... should not be needed. Did you hit any issue that led to this change?
Sorry for the late review; thank you!
After fixing https://bugs.kde.org/show_bug.cgi?id=399274, the duplicated menu under KInfoCenter Modules" -> <module_name> -> "KInfoCenter" does not exist anymore. Is this fix still relevant then?
Thanks and sorry for the delay.
Sun, Nov 18
Anyone can use arcanist:
Thank you. I guess that you don't have a commit account, right? The patch was sent without using arcanist, which means that it does not have the information about the committer. So either @bcooksley retrieves them and amend the patch to use them, or you provide your email address here and I can do it.