ltoscano (Luigi Toscano)
Minion

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 1:18 PM (126 w, 6 d)
Availability
Available

You can find me around as tosky.

Recent Activity

Thu, Sep 21

ltoscano committed R223:e93cb78992e4: Fix string: no exclamation mark, add article (authored by ltoscano).
Fix string: no exclamation mark, add article
Thu, Sep 21, 7:19 PM
ltoscano committed R261:709c08acc9bf: New user wizard: check if the directory exists (authored by ltoscano).
New user wizard: check if the directory exists
Thu, Sep 21, 7:58 AM
ltoscano closed D7902: New user wizard: check if the directory exists.
Thu, Sep 21, 7:58 AM · KMyMoney
ltoscano committed R261:49b6fa4760c6: Remove the action which lead to old language KCM (authored by ltoscano).
Remove the action which lead to old language KCM
Thu, Sep 21, 7:57 AM
ltoscano closed D7901: Remove the action which lead to old language KCM.
Thu, Sep 21, 7:57 AM · KMyMoney

Wed, Sep 20

ltoscano committed R857:9522cdf854a5: Enable KTechLab under LegacyQt4 (authored by ltoscano).
Enable KTechLab under LegacyQt4
Wed, Sep 20, 10:58 PM
ltoscano added a project to D7902: New user wizard: check if the directory exists: KMyMoney.
Wed, Sep 20, 10:54 PM · KMyMoney
ltoscano created D7902: New user wizard: check if the directory exists.
Wed, Sep 20, 10:53 PM · KMyMoney
ltoscano added a project to D7901: Remove the action which lead to old language KCM: KMyMoney.
Wed, Sep 20, 10:51 PM · KMyMoney
ltoscano created D7901: Remove the action which lead to old language KCM.
Wed, Sep 20, 10:49 PM · KMyMoney
ltoscano committed R261:2cd39c5b3df3: Terminology fix in comments: "by KDE", not "for" (authored by ltoscano).
Terminology fix in comments: "by KDE", not "for"
Wed, Sep 20, 10:04 PM
ltoscano committed R261:58c19aeb070e: Terminology fix: the environment is not "KDE" (authored by ltoscano).
Terminology fix: the environment is not "KDE"
Wed, Sep 20, 10:04 PM
ltoscano committed R261:a469c88975ba: Set the translation domain after the QApplication (authored by ltoscano).
Set the translation domain after the QApplication
Wed, Sep 20, 8:12 PM
ltoscano committed R313:dcc123af2496: Remove the final endl at the end of qDebug &co (authored by ltoscano).
Remove the final endl at the end of qDebug &co
Wed, Sep 20, 3:19 PM
ltoscano closed D7875: Remove the final endl at the end of qDebug &co.
Wed, Sep 20, 3:19 PM · Frameworks

Tue, Sep 19

ltoscano committed R434:64ea854a484d: Fix translations: set the domain as early as possible (authored by ltoscano).
Fix translations: set the domain as early as possible
Tue, Sep 19, 11:44 PM
ltoscano committed R434:7e167dbf34f3: Re-enable the avconfig dialog in the preferences (authored by ltoscano).
Re-enable the avconfig dialog in the preferences
Tue, Sep 19, 11:44 PM
ltoscano committed R247:8f070d143b54: kmix/master is now fully/only KF5-based (authored by ltoscano).
kmix/master is now fully/only KF5-based
Tue, Sep 19, 8:17 PM
ltoscano committed R499:1700ff44e59c: Fix branches for kmix (master is now fully/only KF5) (authored by ltoscano).
Fix branches for kmix (master is now fully/only KF5)
Tue, Sep 19, 8:15 PM

Mon, Sep 18

ltoscano created D7875: Remove the final endl at the end of qDebug &co.
Mon, Sep 18, 8:27 PM · Frameworks
ltoscano committed R345:f40a25378eb1: Merge remote-tracking branch 'origin/master' into frameworks (authored by ltoscano).
Merge remote-tracking branch 'origin/master' into frameworks
Mon, Sep 18, 7:55 PM

Sun, Sep 17

ltoscano committed R857:592d6a1c546e: Enable kphotoalbum as part of Extragear (authored by ltoscano).
Enable kphotoalbum as part of Extragear
Sun, Sep 17, 8:22 PM

Sat, Sep 16

ltoscano added a comment to T6858: Falkon Translations.

Sorry, coming back from a business trip overseas; I will work on this in the next days.
One different though: we can't pack the translations in the qrc files, right now we distribute them in the LC_MESSAGES directory and the generated loader looks for them there.

Sat, Sep 16, 1:04 PM · Falkon

Thu, Sep 14

ltoscano committed R247:0b12cf599832: Track Plasma/5.11 as stable5 branch for Plasma (authored by ltoscano).
Track Plasma/5.11 as stable5 branch for Plasma
Thu, Sep 14, 7:59 PM

Tue, Sep 12

ltoscano added a reverting commit for R247:63b35b65e53b: kgraphviewer stable now kf5 master branch: R247:9999ae32963b: Revert "kgraphviewer stable now kf5 master branch".
Tue, Sep 12, 2:55 PM
ltoscano committed R247:9999ae32963b: Revert "kgraphviewer stable now kf5 master branch" (authored by ltoscano).
Revert "kgraphviewer stable now kf5 master branch"
Tue, Sep 12, 2:55 PM

Fri, Sep 8

ltoscano committed R247:3a426f06e81f: Fix branches for latte-dock: master is kf5 (authored by ltoscano).
Fix branches for latte-dock: master is kf5
Fri, Sep 8, 3:08 PM
ltoscano added a comment to D7732: Force KAuth helpers to have UTF-8 support.

C.UTF-8 is not glibc, even few distributions added it (historically Debian and Ubuntu, more recently Fedora).

Fri, Sep 8, 12:14 PM · Frameworks

Thu, Sep 7

ltoscano committed R247:4adac68865c4: krita stable branch is now krita/3.3 (authored by ltoscano).
krita stable branch is now krita/3.3
Thu, Sep 7, 6:48 AM

Wed, Sep 6

ltoscano committed R758:365f78cdf1e4: Bump the version number (authored by ltoscano).
Bump the version number
Wed, Sep 6, 11:28 PM
ltoscano committed R443:f4eeccd1af71: Recognize an image by MIME type, not extension (authored by ltoscano).
Recognize an image by MIME type, not extension
Wed, Sep 6, 11:15 PM
ltoscano committed R443:e418e0a68eb3: Port away from KDialog and K{H,V}Box (authored by ltoscano).
Port away from KDialog and K{H,V}Box
Wed, Sep 6, 10:46 PM
ltoscano committed R596:39d40f89435e: i18n: add the context for the distribution name (authored by ltoscano).
i18n: add the context for the distribution name
Wed, Sep 6, 3:18 PM
ltoscano closed D7442: i18n: add the context for the distribution name by committing R596:39d40f89435e: i18n: add the context for the distribution name.
Wed, Sep 6, 3:18 PM

Tue, Sep 5

ltoscano added a comment to D7689: Be compatible with KDE version in Ubuntu Xenial.

KDE_IS_VERSION(4,14,22) ? Is this an old kdelibs4-based branch?

Tue, Sep 5, 8:48 PM

Mon, Sep 4

ltoscano committed R239:0f7d924b9979: doc: validation not available in QInputDialog::getText (authored by ltoscano).
doc: validation not available in QInputDialog::getText
Mon, Sep 4, 10:30 AM
ltoscano closed D7675: doc: validation not available in QInputDialog::getText by committing R239:0f7d924b9979: doc: validation not available in QInputDialog::getText.
Mon, Sep 4, 10:30 AM · Frameworks

Sun, Sep 3

ltoscano committed R443:629c2a4c9df7: Port away from KTemporaryFile to QTemporaryFile (authored by ltoscano).
Port away from KTemporaryFile to QTemporaryFile
Sun, Sep 3, 11:06 PM
ltoscano added a reviewer for D7681: Update human-readable tier designation in API dox: mart.
Sun, Sep 3, 6:15 PM · Kirigami
ltoscano committed R443:4bfd2fea2bc6: Port away from KMimeType to QMime* and reorder headers (authored by ltoscano).
Port away from KMimeType to QMime* and reorder headers
Sun, Sep 3, 2:00 PM
ltoscano committed R443:c65965d7b76b: Remove few unused includes (from deprecated classes) (authored by ltoscano).
Remove few unused includes (from deprecated classes)
Sun, Sep 3, 2:00 PM
ltoscano added a comment to D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled.

Oh good point, I forgot that this won't work if Baloo is disabled. I'll guard it behind an #ifdef, which appears to be the standard way to do this, looking through Dolphin's code.

Since I'm proposing to change a default, the #ifdef will only avoid creating the bookmark on first launch for systems where Baloo is disabled at the distro-level. For users who opt to turn Baloo off themselves, I think it's safe to assume they're technically competent enough to understand the ramifications of that decision. But yes, it would be nice if there was a better error message. With Baloo disabled, I assume your Information panel also doesn't show Tags, right?

Sun, Sep 3, 1:52 PM · Frameworks, Dolphin
ltoscano committed R443:e63fe0fa6976: Check if the name returned by QInputDialog is not empty (authored by ltoscano).
Check if the name returned by QInputDialog is not empty
Sun, Sep 3, 1:18 PM
ltoscano created D7675: doc: validation not available in QInputDialog::getText.
Sun, Sep 3, 1:08 PM · Frameworks

Sat, Sep 2

ltoscano committed R443:3d37f974faa7: Port from KInputDialog to QInputDialog (authored by ltoscano).
Port from KInputDialog to QInputDialog
Sat, Sep 2, 11:21 PM
ltoscano committed R443:f85052eb2660: Merge remote-tracking branch 'origin/master' into frameworks (authored by ltoscano).
Merge remote-tracking branch 'origin/master' into frameworks
Sat, Sep 2, 10:58 PM
ltoscano committed R443:0bdc5ab42684: Remove the last references to kapplication.h (authored by ltoscano).
Remove the last references to kapplication.h
Sat, Sep 2, 10:58 PM
ltoscano committed R443:d80a060950e6: Merge remote-tracking branch 'origin/Applications/17.08' (authored by ltoscano).
Merge remote-tracking branch 'origin/Applications/17.08'
Sat, Sep 2, 10:55 PM
ltoscano committed R443:2919de746415: Fix: do not delete the map if Cancel is selected (authored by ltoscano).
Fix: do not delete the map if Cancel is selected
Sat, Sep 2, 10:53 PM
ltoscano added a comment to D7658: Change version to match KDE Applications (17.11.70).

As Albert wrote, you can use whatever version you want: check the version number of the games, or many applications of the edu group.

Sat, Sep 2, 5:40 PM · KDE Applications
ltoscano committed R443:a1b73ffab697: Port from KFileDialog to QFileDialog (authored by ltoscano).
Port from KFileDialog to QFileDialog
Sat, Sep 2, 12:27 AM

Fri, Sep 1

ltoscano committed R499:cd98a7797dcb: palapeli/master is now KF5-based, fix the branches (authored by ltoscano).
palapeli/master is now KF5-based, fix the branches
Fri, Sep 1, 9:00 PM
ltoscano committed R247:311e258be230: palapeli/master is now KF5-based, fix the branches (authored by ltoscano).
palapeli/master is now KF5-based, fix the branches
Fri, Sep 1, 9:00 PM
ltoscano committed R423:7a55b6517772: Bump the version number to 2.1 (authored by ltoscano).
Bump the version number to 2.1
Fri, Sep 1, 8:57 PM
ltoscano added a comment to D7442: i18n: add the context for the distribution name.

ping @jriddell !

Fri, Sep 1, 12:35 PM
ltoscano added a comment to R94:9abd645e0e74: not necessary to translate it.

I think thata it should be translates instead; can't you do like you did for other filters?

Fri, Sep 1, 7:39 AM

Thu, Aug 31

ltoscano committed R440:7d3a0cea87d0: ECM is released with Frameworks, use the same version (authored by ltoscano).
ECM is released with Frameworks, use the same version
Thu, Aug 31, 8:20 PM
ltoscano committed R440:14dc0febd5ac: Disable CMP0063 though ECM (authored by ltoscano).
Disable CMP0063 though ECM
Thu, Aug 31, 8:20 PM
ltoscano added a comment to D7578: Sort List by piece count does not work.

Only one commit was needed :)
I backported it to Applications/17.08 and forward-merged to master and frameworks.

Thu, Aug 31, 6:41 PM
ltoscano committed R423:8ec70d8cf6f7: Merge remote-tracking branch 'origin/master' into frameworks (authored by ltoscano).
Merge remote-tracking branch 'origin/master' into frameworks
Thu, Aug 31, 6:27 PM
ltoscano committed R423:ca0f2ed4e98b: Merge remote-tracking branch 'origin/Applications/17.08' (authored by ltoscano).
Merge remote-tracking branch 'origin/Applications/17.08'
Thu, Aug 31, 6:26 PM
ltoscano committed R423:4f6d95e54f40: Sort List by piece count does not work (authored by chehrlic).
Sort List by piece count does not work
Thu, Aug 31, 6:25 PM
ltoscano committed R247:610342dba951: libktorrent: kill 1.3 from stable4, track 2.1 as stable5 (authored by ltoscano).
libktorrent: kill 1.3 from stable4, track 2.1 as stable5
Thu, Aug 31, 2:00 PM

Wed, Aug 30

ltoscano accepted D7578: Sort List by piece count does not work.

It this works for the current stable, I'd strongly suggest to apply it there.

Wed, Aug 30, 11:23 PM
ltoscano retitled D7578: Sort List by piece count does not work from Sort List by piece count does not work, BUG: 376607 to Sort List by piece count does not work.
Wed, Aug 30, 11:21 PM
ltoscano added a reviewer for D7620: Fix KHelpMenu position on Wayland: davidedmundson.
Wed, Aug 30, 8:01 PM · Frameworks
ltoscano committed R750:fa3b6e716a77: Translations: extract the messages (authored by ltoscano).
Translations: extract the messages
Wed, Aug 30, 7:09 PM
ltoscano committed R750:14b77a62ec52: Translations: use ki18n_wrap_ui instead of qt5_wrap_ui (authored by ltoscano).
Translations: use ki18n_wrap_ui instead of qt5_wrap_ui
Wed, Aug 30, 7:09 PM

Tue, Aug 29

ltoscano committed R223:007030a6df81: Fix translation also for the new Markdown generator (authored by ltoscano).
Fix translation also for the new Markdown generator
Tue, Aug 29, 11:30 PM
ltoscano committed R223:d9584b30d885: Merge remote-tracking branch 'origin/Applications/17.08' (authored by ltoscano).
Merge remote-tracking branch 'origin/Applications/17.08'
Tue, Aug 29, 11:30 PM
ltoscano committed R223:4a4bba113703: Add the base .arcconfig file (authored by ltoscano).
Add the base .arcconfig file
Tue, Aug 29, 11:29 PM
ltoscano committed R223:e858ecdd7c21: Fix translations: add translation domain for generators (authored by ltoscano).
Fix translations: add translation domain for generators
Tue, Aug 29, 11:28 PM
ltoscano added a comment to D7588: Don't search for and link to libcln when using libqalculate>=2.0.

I'd say go for it.

Tue, Aug 29, 7:20 PM
ltoscano accepted D7588: Don't search for and link to libcln when using libqalculate>=2.0.

I tested it with the older libqalculate, and the linking works as well. Let's go for it; is it for Applications/17.08 as you did with other similar commits?

Tue, Aug 29, 7:17 PM
ltoscano added a comment to D7588: Don't search for and link to libcln when using libqalculate>=2.0.

Shouldn't also the following line be changed (step/CMakeLists.txt)?

Tue, Aug 29, 6:59 PM

Mon, Aug 28

ltoscano committed R479:f23fbd08df88: Use KI18N_INSTALL to handle the translations (authored by ltoscano).
Use KI18N_INSTALL to handle the translations
Mon, Aug 28, 11:58 PM
ltoscano committed R479:4e27225e1421: Re-enable the documentation with a bit of cleanup (authored by ltoscano).
Re-enable the documentation with a bit of cleanup
Mon, Aug 28, 11:58 PM
ltoscano committed R479:3ccf568a5f08: Call feature_summary at the end of the main CMakeLists (authored by ltoscano).
Call feature_summary at the end of the main CMakeLists
Mon, Aug 28, 11:58 PM
ltoscano committed R479:950f652370d4: Fix (almost all) translations for QML files (authored by ltoscano).
Fix (almost all) translations for QML files
Mon, Aug 28, 11:58 PM
ltoscano committed R557:d1ad8d4855c9: Fix: usage of i18n (no .arg) (authored by ltoscano).
Fix: usage of i18n (no .arg)
Mon, Aug 28, 9:50 PM
ltoscano committed R557:29cb76f061f1: Fix translations: set the translation domain (authored by ltoscano).
Fix translations: set the translation domain
Mon, Aug 28, 9:12 PM
ltoscano added a comment to D7033: Port ki18n from QtScript to QtQml.

@ilic, the repository was set incorrectly but it's really for KI18n.

Mon, Aug 28, 7:47 PM · Frameworks
ltoscano changed the repository for D7033: Port ki18n from QtScript to QtQml from R252 Framework Integration to R249 KI18n.
Mon, Aug 28, 7:46 PM · Frameworks
ltoscano committed R400:334cb8a563e9: Merge remote-tracking branch 'origin/Applications/17.04' into Applications/17.08 (authored by ltoscano).
Merge remote-tracking branch 'origin/Applications/17.04' into Applications/17.08
Mon, Aug 28, 5:43 PM
ltoscano committed R344:69c254f27f95: Remove the remaining redundant "endl" with debug output (authored by ltoscano).
Remove the remaining redundant "endl" with debug output
Mon, Aug 28, 7:08 AM

Sun, Aug 27

ltoscano added inline comments to D7407: audiocd-kio : modernise debugging.
Sun, Aug 27, 10:20 PM
ltoscano added a comment to T6858: Falkon Translations.

The second one is requires a conversion from the ts format to gettext, and we need to add some code to do the conversion during the compilation, like trojita does, or (avoiding code duplication) negotiate the usage of ECM which will simplifies this step (like gcompris does). It can simplify the life for other things as well and it's not really an heavy dependency.

We can't use ECM right now, as it uses qmake. However @dfaure offered to port the build system to CMake, so this should be only done after the build system is CMake to not have to write it twice.

Sun, Aug 27, 10:04 PM · Falkon
ltoscano committed R439:a371bee34bab: Merge remote-tracking branch 'origin/frameworks' (authored by ltoscano).
Merge remote-tracking branch 'origin/frameworks'
Sun, Aug 27, 9:55 PM
ltoscano committed R247:399f88d360a7: zeroconf-ioslave/master is now KF5-based (authored by ltoscano).
zeroconf-ioslave/master is now KF5-based
Sun, Aug 27, 9:19 PM
ltoscano committed R499:7109d77f49d7: zeroconf-ioslave: update branches and dependencies (authored by ltoscano).
zeroconf-ioslave: update branches and dependencies
Sun, Aug 27, 9:18 PM
ltoscano added a comment to D4826: Prefer place name over actual name in title bar.

Is there a reason why Konqueror is added in CC of all dolphin merge requests? Is that done manually or automatically? I don't see the relevance for konqueror, especially for a patch for DolphinMainWindow (no effect on dolphinpart).

Sun, Aug 27, 7:21 PM
ltoscano committed R407:da9e535e10fd: Fix porting: re-connect the slotOk on new game (authored by ltoscano).
Fix porting: re-connect the slotOk on new game
Sun, Aug 27, 5:19 PM
ltoscano committed R407:ed5ede872278: Fix initialization (command line, obsolete call) (authored by ltoscano).
Fix initialization (command line, obsolete call)
Sun, Aug 27, 5:19 PM
ltoscano committed R407:a15397635240: Use actionCollection()->setDefaultShortcut(s) as hinted (authored by ltoscano).
Use actionCollection()->setDefaultShortcut(s) as hinted
Sun, Aug 27, 5:19 PM
ltoscano committed R654:3f74cf9236d6: Fix icons: use the correct pattern and set it (authored by ltoscano).
Fix icons: use the correct pattern and set it
Sun, Aug 27, 3:18 PM
ltoscano committed R654:048b42324ef6: Fix desktop file and app metadata (authored by ltoscano).
Fix desktop file and app metadata
Sun, Aug 27, 3:18 PM
ltoscano accepted D7560: Properly show/hide preview dialog.

It works as expected. Technically the issue is not a regression, I've just noticed also in the kdelibs4 version. It *may* be fixed there, but up to you.
It was not reported as bug (btw, would you like to go through the bug list for palapeli to see if it's possible to close something?)

Sun, Aug 27, 2:46 PM
ltoscano updated the summary of D7560: Properly show/hide preview dialog.
Sun, Aug 27, 2:41 PM
ltoscano committed R654:75d08da2a2c9: Fix desktop file and app metadata (authored by ltoscano).
Fix desktop file and app metadata
Sun, Aug 27, 1:50 PM
ltoscano committed R654:12c7d23f4007: Fix fi (authored by ltoscano).
Fix fi
Sun, Aug 27, 1:50 PM