You can find me around as tosky.
- User Since
- Apr 18 2015, 1:18 PM (166 w, 15 h)
Thu, Jun 21
It makes sense, thanks.
Tue, Jun 19
Oh, well, the cpp part did not change, so let's consider the previous approval as still valid. Approving the documentation change.
Fine by me - @elvisangelaccio ?
Maybe the patch can be applied in this same change, so we don't forget.
Does this require a documentation change too (doc/)?
Mon, Jun 18
General suggestion about the review:
- please change the commit message to be a summary of the content ("Review and fixes of kwave documentation"), for example
- the commit message should not repeat all the change, but should summarize them. For example, common changes from 1 to 20 are "use of entities when defined", and so on.
Sun, Jun 17
Sat, Jun 16
Fri, Jun 15
Thu, Jun 14
Wed, Jun 13
Tue, Jun 12
Mon, Jun 11
Sat, Jun 9
Fri, Jun 8
Thu, Jun 7
This change was overridden by scripty as expected: if you want the translations, just fix them in the SVN repository.
Tue, Jun 5
Mon, Jun 4
Thu, May 31
Wed, May 30
I'd really like to have a clear answer to some questions:
- is this something that needs to be fixed in kdeclarative, which makes it impossible to have a proper fix it in 5.13?
- would a patch to fix this (define the translation domain in the same way as the other libraries, not related to component name) accepted?
Tue, May 29
Pushed to the gsoc branch, but reopening.
Mon, May 28
The repository is not docs.kde.org - did you use arcanist and it assigned the wrong repository?
Sat, May 26
Should I create a bug/task somewhere to track the work needed to fix this properly, where we can discuss about the proper solution? (fix in kdeclarative?)
Fri, May 25
Maybe it's not going to help, but how do other printing interfaces (free - Gtk+, libreoffice, mozilla,...or not - windows, macOS) deal with this? A bit of consistency (if it exists) *may* help (even if not 100% precise).
May 23 2018
Please also note that, if supporting a different name for the translation catalog would mean changing something in Frameworks, I think that this patch would be the correct way to fix 5.13. Nevertheless this use case should be fixed afterwards so that 5.14 could make use of it.
Libs connected to KCMs or other libraries part of Plasma? About the latter, I don't recall relevant case of renamings/reshuffling, so probably no need.
We already had changes in the structure of kcm, and I prefer the names to be future-proof.
May 22 2018
It looks good to me. Now let's wait for @mreeves
May 21 2018
May 20 2018
Looks generally fine.
Ok, so it seems that you only created a list and you are asking for feedback. Fine then, sorry for the misunderstanding, the wording could be misleading.
Just to be sure, @xyquadrat : did you already remove the products? In the future, don't remove first and ask later, but do the opposite. It's a bit too late to ask whether you had accidentally deleted an active product.
Maybe we need a basic document for the other KCM too; a small note here could be useful anyway.
May 19 2018
I expect the plasma developer to be able to help with fixing this.
I don't want to go back from kcm5_workspace to kcm_workspace. Any solution should allow to define a specific name for the KCMs.
May 18 2018
Sorry for the delay!