- User Since
- Aug 30 2016, 3:41 PM (171 w, 2 d)
Nov 5 2019
It has only been tagged so far, it's not been released yet.
The release will be next Saturday, maybe you should ask for a respin before that.
Oct 30 2019
FTR, we got a downstream bug report about this for openSUSE Leap 15.1 (which ships Plasma 5.12 LTS):
Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the gtk.css in the first place.
Could this be backported to 5.12 too maybe?
Oct 28 2019
Alternatively, the directory could also be created in TreeView::TreeView(), but I think this place is more logical (there is no reason to create the directory as long as the menu isn't saved) and it would also work if MenuFile would be used in other places as well, with files in different directories.
Oct 24 2019
Oct 22 2019
One thing maybe: with the Desktop layout, if you switch an applet to edit mode (by pressing and holding the left mouse button), it's not possible to exit edit mode by left-clicking on the desktop (even if no left-click action is configured). You need to click on a different applet now, but what if there is none...
Oct 21 2019
Yes, exactly. Adding a line ec->increaseVolume(); at that place gives the same compiler error:
/home/abuild/rpmbuild/BUILD/amarok-2.9.70git.20191004T143525~5ed62f9a08/src/MainWindow.cpp: In member function 'void MainWindow::createActions()': /home/abuild/rpmbuild/BUILD/amarok-2.9.70git.20191004T143525~5ed62f9a08/src/MainWindow.cpp:904:24: error: passing 'const EngineController' as 'this' argument discards qualifiers [-fpermissive] ec->increaseVolume(); ^
Oct 19 2019
Btw, I mainly followed what was done for the stop() action in commit 1b81541e, where a new regularStop() slot was created for similar reasons AIUI.
The patch fixes the problem here, and I didn't notice regressions either so far.
I only did a quick test though, and cannot really comment on the patch per se.
Oct 4 2019
PS: I think the argument is 0 because QAction::triggered() has a bool checked argument that's probably passed along.
But Qt's new signal/slots syntax doesn't support default arguments anyway, according to the docs.
Btw, I just found a bug report about this:
Oct 3 2019
+1 from me now as well.
Sep 30 2019
The problem apparently is that the mentioned plugins have their metadata in a .desktop file, but the code here creates the KFileMetaData from the .so file (so the metadata is empty).
See the bug report for more details.
Sep 22 2019
You should add '/' instead of QDir::separator()...
Sep 20 2019
Sep 19 2019
Sep 18 2019
Sep 10 2019
Sep 4 2019
That's actually part of libkcddb and not k3b, btw.
Sep 1 2019
Aug 29 2019
Yes, this does fix the crash as well, and it builds fine with Qt 5.9.
JFYI, I already tested the QScopeGuard fix from D23404 today, it alone does indeed fix the crash of BUG 395624.
There is a problem though: QScopeGuard was introduced in Qt 5.12, while the minimum required version is 5.9.
Aug 28 2019
Here's a valgrind log for now, maybe it contains a clue as well...
I played 3 times and got the same crash every time (at some point during play), so it seems to be rather reproducible.
I gave it a try and it does seem to fix the crashes from BUG 395624 here.
Aug 8 2019
Aug 7 2019
Use NOT VERSION_LESS instead to minimize the patch.
Use NOT VERSION_LESS instead to minimize patch.
Can this be pushed to the 5.12 branch as well, please?
It's broken in 5.12.8 as well (https://bugs.kde.org/390776 was actually reported against 5.12.1), the patch applies cleanly and does fix the problem.
Jul 20 2019
What about the stable 5.16 branch?
It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away...