- User Since
- Aug 30 2016, 3:41 PM (155 w, 2 d)
Thu, Aug 8
Wed, Aug 7
Use NOT VERSION_LESS instead to minimize the patch.
Use NOT VERSION_LESS instead to minimize patch.
Can this be pushed to the 5.12 branch as well, please?
It's broken in 5.12.8 as well (https://bugs.kde.org/390776 was actually reported against 5.12.1), the patch applies cleanly and does fix the problem.
Jul 20 2019
What about the stable 5.16 branch?
It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away...
Jul 12 2019
Remove accidental trailing spaces.
Btw, on an unrelated note:
I just noticed that it doesn't actually specify a minimum Qt version, even though it seems to be the intention:
set(QT_MIN_VERSION 5.9.0) find_package(Qt5 REQUIRED COMPONENTS Core DBus Gui Sql Widgets Xml )
Jul 7 2019
Nevermind though, lmontel fixed it meanwhile with commit 7b3249547b92.
Jul 6 2019
This doesn't work as intended (at least here on openSUSE).
I just built it with QtWebEngine 5.13(.0), and it incorrectly took the < 5.13.0 branch.
Jul 4 2019
Jul 3 2019
Jun 21 2019
Check already when setting info.mtime in CopyJobPrivate::addCopyInfoFromUDSEntry().
Jun 14 2019
Jun 1 2019
Adding some reviewers...
May 29 2019
May 21 2019
May 15 2019
May 3 2019
The change is part of 402cbee5e675.
May 2 2019
As mentioned in the bugreport, I noticed meanwhile that playback doesn't seem to work at all with libvlc 2.2.6.
Updated diff to include full context.
Apr 19 2019
PS: I just now found the same in core/dplugins/generic/webservices/unified/wizard/wsauthenticationpage.cpp, but that isn't compiled currently.
Apr 17 2019
Apr 5 2019
I just noticed that this change is missing again in 5.15.
Apparently it was reverted (by mistake?) in R98:e1f97ce5 ...
This reverted D17187, that probably wasn't intended.
Mar 13 2019
Wouldn't it make sense to backport this to 5.12 as well?
The mentioned bug was originally reported against 5.12.0, apparently it was a regression compared to 5.11.
What about 5.12?
The problem exists there too, and this patch fixes it.