wbauer (Wolfgang Bauer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 30 2016, 3:41 PM (188 w, 25 m)
Availability
Available

Recent Activity

Wed, Mar 25

wbauer added a comment to D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Wed, Mar 25, 7:29 PM · Amarok
wbauer added a comment to D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

On openSUSE, it doesn't enable MySQLe anymore:

Wed, Mar 25, 7:23 PM · Amarok
wbauer added a comment to D28165: Fix compatibility with modern MySQL.

The content of my /usr/include/mysql/mysql_version.h (which is just a symlink to mariadb_version.h):

I just went back and installed mariadb-connector-c in Gentoo in mysqlcompat-mode (a soon to be removed option) and interestingly, it does not provide that symlink.

Indeed, the symlink is added in openSUSE's packaging. From mariadb-connector-c.spec:

# add a compatibility symlink
ln -s mariadb_config %{buildroot}%{_bindir}/mysql_config
ln -s mariadb_version.h %{buildroot}%{_includedir}/mysql/mysql_version.h
Wed, Mar 25, 6:23 PM · Amarok
wbauer added a comment to D28165: Fix compatibility with modern MySQL.

Waiting for @wbauer to confirm it works as well

Yes, the latest version builds fine here (the previous did as well), and the embedded collection still works as well.

Wed, Mar 25, 6:09 PM · Amarok

Mon, Mar 23

wbauer added a comment to D28165: Fix compatibility with modern MySQL.

This breaks compilation here on openSUSE with MariaDB:

Mon, Mar 23, 9:49 PM · Amarok

Thu, Mar 19

wbauer added a comment to D27905: [resources/maildir] Reload configuraton on configuration change.

Also, I think this would now always change the resource name (to the name of the directory) when the user reconfigures the storage path, even if it was explicitly set to something (like "My mails") before.
I'm not sure that's really desired?

Thu, Mar 19, 2:09 PM · KDE PIM
wbauer added a comment to D27905: [resources/maildir] Reload configuraton on configuration change.

Also, I think this would now always change the resource name (to the name of the directory) when the user reconfigures the storage path, even if it was explicitly set to something (like "My mails") before.
I'm not sure that's really desired?

Thu, Mar 19, 8:43 AM · KDE PIM

Wed, Mar 18

wbauer added a comment to D27905: [resources/maildir] Reload configuraton on configuration change.

PS: AIUI, at least one thing that attemptConfigRestoring() does is trying to give every new resource a unique storage location, something like ~/.local/share/akonadi-maildir_resource1, by default.

Wed, Mar 18, 8:06 PM · KDE PIM
wbauer added a comment to D27905: [resources/maildir] Reload configuraton on configuration change.

With this change, all new maildir resources are now named "local-mail" and use ~/.local/share/local-mail/ by default, instead of something unique as before.

Wed, Mar 18, 7:58 PM · KDE PIM

Sun, Mar 15

wbauer committed R440:06c2fe16e7e3: Fix build with Qt 5.9 and lower (authored by wbauer).
Fix build with Qt 5.9 and lower
Sun, Mar 15, 4:52 PM
wbauer closed D28049: Fix build with Qt 5.9 and lower.
Sun, Mar 15, 4:52 PM · Smb4K

Sat, Mar 14

wbauer added a comment to D28049: Fix build with Qt 5.9 and lower.

This is intended for the 3.0 branch, master apparently will need similar (but different) changes (or a bump of the minimum Qt version).

Sat, Mar 14, 8:21 PM · Smb4K
wbauer added a reviewer for D28049: Fix build with Qt 5.9 and lower: areinholdt.
Sat, Mar 14, 7:53 PM · Smb4K
wbauer requested review of D28049: Fix build with Qt 5.9 and lower.
Sat, Mar 14, 7:52 PM · Smb4K

Fri, Mar 13

wbauer added a comment to D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).

Maybe it would be good to make a new release as well, now that Python2 is EOL...

I prepared one, if you want to test before it goes public:
https://dev.exherbo.org/~heirecka/telepathy-logger-qt-17.09.0.tar.xz
https://dev.exherbo.org/~heirecka/telepathy-logger-qt-17.09.0.tar.xz.sig

Fri, Mar 13, 9:45 PM · KDE Telepathy
wbauer added a comment to D27973: kcddb 6.

Under that view point shrinking the library seems like a very reasonable thing to do and going with musicbrainz is probably the better choice as there seems to be more interest for it (and thus more/better data one presumes) than for freedb/gnudb. According to google trends anyway.

Fri, Mar 13, 8:18 PM · Documentation

Thu, Mar 12

wbauer added a comment to D27973: kcddb 6.

AIUI, gnudb.org will still be available though, and should be compatible to freedb.org.
http://www.gnudb.org/howto.php

Thu, Mar 12, 9:06 AM · Documentation

Mar 3 2020

wbauer committed R155:248df64bb81a: Merge branch 'release/19.12' (authored by wbauer).
Merge branch 'release/19.12'
Mar 3 2020, 9:07 AM
wbauer committed R155:8a1990cba1b7: Use QStringLiteral (authored by wbauer).
Use QStringLiteral
Mar 3 2020, 9:07 AM
wbauer added inline comments to R155:2ef7f52ed589: Merge branch 'release/19.12'.
Mar 3 2020, 8:50 AM

Mar 2 2020

wbauer committed R155:2ef7f52ed589: Merge branch 'release/19.12' (authored by wbauer).
Merge branch 'release/19.12'
Mar 2 2020, 9:14 PM
wbauer added a comment to D27454: Unbreak the Accounts KCM.

When I committed D27474 to the 19.12 branch, I took the liberty to cherry-pick this as well, so that it will be part of the 19.12.3 release already.
I hope that's ok.

Mar 2 2020, 9:01 PM · Plasma
wbauer committed R155:67fc8d83b71f: Unbreak the Accounts KCM (authored by leinir).
Unbreak the Accounts KCM
Mar 2 2020, 8:59 PM
wbauer committed R155:4600d32a1c06: [CreateAccount job] Never set an empty name when creating an account (authored by wbauer).
[CreateAccount job] Never set an empty name when creating an account
Mar 2 2020, 8:59 PM
wbauer closed D27474: [CreateAccount job] Never set an empty name when creating an account.
Mar 2 2020, 8:59 PM
wbauer added a comment to D27454: Unbreak the Accounts KCM.

Shouldn't this one be pushed to the 19.12 branch as well? (it's currently only in master AFAICS)
After all, it regressed in 19.12.0 (or actually 19.11.80).

It probably does... what's the in-a-nutshell procedure for doing that? (since it's already landed, of course, arc won't do that)

Mar 2 2020, 10:53 AM · Plasma
wbauer added a comment to D27454: Unbreak the Accounts KCM.

Shouldn't this one be pushed to the 19.12 branch as well? (it's currently only in master AFAICS)
After all, it regressed in 19.12.0 (or actually 19.11.80).

Mar 2 2020, 10:46 AM · Plasma
wbauer updated the test plan for D27474: [CreateAccount job] Never set an empty name when creating an account.
Mar 2 2020, 10:35 AM
wbauer requested review of D27474: [CreateAccount job] Never set an empty name when creating an account.

Sorry for the delay.

Mar 2 2020, 10:34 AM

Feb 28 2020

wbauer committed R241:07ab04bfe774: Fix running konsole on Wayland (authored by wbauer).
Fix running konsole on Wayland
Feb 28 2020, 10:28 AM
wbauer closed D27654: [kio] Fix running konsole on Wayland.
Feb 28 2020, 10:28 AM · Frameworks

Feb 26 2020

wbauer added a comment to D27654: [kio] Fix running konsole on Wayland.

Wait, you're actually passing the icon of the command being executed now (while the old code would end up using the stuff from konsole.desktop I think)....

AFAICT passing the icon of the command being executed is what is wanted here.
I.e. the konsole window should use the icon of the application menu entry it is being started from.
And the original code (with %i) actually does the same, I verified that with additional debug output.

Feb 26 2020, 11:44 AM · Frameworks

Feb 25 2020

wbauer updated the diff for D27654: [kio] Fix running konsole on Wayland.

Use KShell::quoteArg() in case the icon name contains spaces or other special chars.
No idea if that's possible/allowed, but better be safe than sorry I suppose.

Feb 25 2020, 4:17 PM · Frameworks
wbauer updated the test plan for D27654: [kio] Fix running konsole on Wayland.
Feb 25 2020, 3:37 PM · Frameworks
wbauer requested review of D27654: [kio] Fix running konsole on Wayland.
Feb 25 2020, 3:22 PM · Frameworks

Feb 23 2020

wbauer added a comment to D27589: Try to apply the colorscheme of the current theme to QIcons.

Confirmed. I tried out the patch now, and that problem is gone.

Feb 23 2020, 4:21 PM · Frameworks
wbauer added a comment to D27589: Try to apply the colorscheme of the current theme to QIcons.

Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ?

Feb 23 2020, 1:45 AM · Frameworks

Feb 20 2020

wbauer planned changes to D27474: [CreateAccount job] Never set an empty name when creating an account.

One problem I see already is that this slot is called twice actually, once already *before* the authentification window shows up...

Hm, after thinking a bit more about it, I suppose that means that this patch is probably not a good idea after all.
It would set the name the first time already, while the username may only be available when it's being called the second time (and as the name is not empty anymore, it would not set it again).

Feb 20 2020, 12:56 PM

Feb 19 2020

wbauer added a comment to D27474: [CreateAccount job] Never set an empty name when creating an account.

i think that i'm with @wbauer here - but also Bhushan. This is most definitely a good fallback that i think we'll want in (also, good commenting), but a second patch to pull up more friendly names for accounts where that's possible/make sense/whatnot would also be pretty great. So... accept this one, and suggest further work i think (wow, it's almost like being at uni ;) )

Yes, I do agree with Bhushan too, I'm just not sure that this is the right place to do it.
As signon is used as an abstraction (isn't it?), it somehow feels wrong having to deal with specifics for some provider (or even authentification method) to me.

Feb 19 2020, 7:14 PM

Feb 18 2020

wbauer added a comment to D27474: [CreateAccount job] Never set an empty name when creating an account.

Hm, ideally I'd say we can use https://www.googleapis.com/auth/userinfo.email to retrieve username instead of adding ad-hoc stuff? At this point we do already have a auth data, so we can just make a data request using auth data and get userinfo...

Feb 18 2020, 1:24 PM
wbauer updated the test plan for D27474: [CreateAccount job] Never set an empty name when creating an account.
Feb 18 2020, 12:07 PM
wbauer added a comment to D27474: [CreateAccount job] Never set an empty name when creating an account.

As the new "Online Accounts" KCM in 19.12 actually shows the account type (i.e. info.caption()) in brackets after the name, we could also use a more generic name if preferred, e.g. something like "Account1" (but that should probably be translated as well so is not really suitable for the 19.12 branch I suppose).
I'm open to suggestions here, that's why I added VDG as subscriber.

Feb 18 2020, 11:41 AM
wbauer requested review of D27474: [CreateAccount job] Never set an empty name when creating an account.
Feb 18 2020, 11:38 AM

Feb 17 2020

wbauer added a comment to D11880: Add firewall-config and firewall-applet icons.
Feb 17 2020, 9:21 AM · Frameworks

Feb 16 2020

wbauer committed R295:ea7120ed901b: Check activeModule before using it (authored by wbauer).
Check activeModule before using it
Feb 16 2020, 5:33 PM
wbauer closed D27433: Check activeModule before using it.

Committed with https://commits.kde.org/kcmutils/ea7120ed901bf6161bb483ab73211a6491daac8f

Feb 16 2020, 5:11 PM · Frameworks
wbauer updated the summary of D27433: Check activeModule before using it.
Feb 16 2020, 1:41 PM · Frameworks
wbauer added inline comments to D26519: Show button respecting what is declared by KCModule.
Feb 16 2020, 1:35 PM · Frameworks
wbauer requested review of D27433: Check activeModule before using it.
Feb 16 2020, 1:35 PM · Frameworks
wbauer added a comment to D26519: Show button respecting what is declared by KCModule.

This change causes kontact to crash when opening its settings:
https://bugs.kde.org/show_bug.cgi?id=417396

Feb 16 2020, 12:25 PM · Frameworks

Jan 25 2020

wbauer added a comment to D16138: Create the default profile if it doesn't exist.

To me it makes sense to ship an internal profile that's equal to the default settings. That's kinda what profiles are, so it's a little odd to have the feature but not ship with one.

There also is a problem with this though, it is not possible to modify system-wide installed profiles due to missing permissions.
I filed a bug report about this: https://bugs.kde.org/show_bug.cgi?id=416752

Jan 25 2020, 3:02 PM · Konsole

Jan 17 2020

wbauer added inline comments to D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.
Jan 17 2020, 2:37 PM · KDE Edu

Jan 16 2020

wbauer added inline comments to D26550: Patch for possible resolution of https://bugs.kde.org/show_bug.cgi?id=416037.
Jan 16 2020, 7:58 PM · KDE Edu

Jan 15 2020

wbauer added a comment to D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).

Maybe it would be good to make a new release as well, now that Python2 is EOL...

Jan 15 2020, 10:25 AM · KDE Telepathy

Jan 8 2020

wbauer added a comment to D26479: Fix warning on launch from QCommandLineParser.

I think this needs a Qt5 and KF5 check; there's no reason to remove in earlier versions.

Jan 8 2020, 8:16 AM · Konsole

Jan 7 2020

wbauer added a comment to D26479: Fix warning on launch from QCommandLineParser.

But konsole's minimum KF5 version is 5.6.0 currently. Maybe this should be increased?

As the minimum Qt version is 5.9.0, I highly doubt that anyone would want to build konsole with KF5 5.6.0 (which is more than 2 years older) anyway...

Jan 7 2020, 12:58 PM · Konsole
wbauer added a comment to D26479: Fix warning on launch from QCommandLineParser.

Thanks I just noticed this - I wonder when it started or if depends on KF5/Qt5 version.

That warning is new in Qt 5.14:
https://code.qt.io/cgit/qt/qtbase.git/commit/src/corelib/tools/qcommandlineparser.cpp?h=5.14&id=90c86d738e0f36eaa48c7f81f6f5cc035a339d6b

Jan 7 2020, 12:54 PM · Konsole

Jan 5 2020

wbauer added a comment to D26439: Copy _colorRandomization when copying a new ColorScheme.

Thanks nice catch. We are trying to migrate to gitlab; if you can in the future use merge requests.

https://invent.kde.org/kde/konsole/merge_requests

Jan 5 2020, 6:21 PM · Konsole
wbauer updated the test plan for D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 5:33 PM · Konsole
wbauer requested review of D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 5:28 PM · Konsole

Jan 3 2020

wbauer accepted D26008: Include the gmock prefix in the search path.

Seems to be fine.
It still finds gmock here on openSUSE and builds successfully.

Jan 3 2020, 9:18 PM
wbauer added a comment to D21145: Make KTorrent work with current GeoIP files.

Unfortunately, this patch won't work as-is anymore because the "new" file is not available for download anymore either:
https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/

Jan 3 2020, 9:18 AM

Dec 13 2019

wbauer committed R230:de9931b46a48: Merge branch 'release/19.12' (authored by wbauer).
Merge branch 'release/19.12'
Dec 13 2019, 12:53 PM
wbauer committed R230:561ce23f87f4: Add my relicensing agreements (wbauer) (authored by wbauer).
Add my relicensing agreements (wbauer)
Dec 13 2019, 12:52 PM

Nov 5 2019

wbauer added a comment to D25019: Ensure that GlobalDrawer topContent always stays on top.
In D25019#558919, @mart wrote:

Unfortunately, it has been pushed too near to framework release, so now it has been released, breaking several apps for a whole framework release.

It has only been tagged so far, it's not been released yet.
The release will be next Saturday, maybe you should ask for a respin before that.

Nov 5 2019, 1:36 PM · Kirigami

Oct 30 2019

wbauer added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

FTR, we got a downstream bug report about this for openSUSE Leap 15.1 (which ships Plasma 5.12 LTS):
https://bugzilla.opensuse.org/show_bug.cgi?id=1155387

Oct 30 2019, 6:20 PM · Plasma
wbauer added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC.

Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the gtk.css in the first place.

Oct 30 2019, 1:46 PM · Plasma
wbauer added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

Could this be backported to 5.12 too maybe?

Oct 30 2019, 10:10 AM · Plasma

Oct 28 2019

wbauer committed R103:5d0e53f5602f: Merge branch 'Plasma/5.17' (authored by wbauer).
Merge branch 'Plasma/5.17'
Oct 28 2019, 8:09 AM
wbauer committed R103:d7dbd84e96b8: Create directory when saving the menu file (authored by wbauer).
Create directory when saving the menu file
Oct 28 2019, 8:09 AM
wbauer closed D24996: Create directory when saving the menu file.
Oct 28 2019, 8:09 AM · Plasma
wbauer added a comment to D24996: Create directory when saving the menu file.

Alternatively, the directory could also be created in TreeView::TreeView(), but I think this place is more logical (there is no reason to create the directory as long as the menu isn't saved) and it would also work if MenuFile would be used in other places as well, with files in different directories.

Oct 28 2019, 7:27 AM · Plasma
wbauer requested review of D24996: Create directory when saving the menu file.
Oct 28 2019, 7:24 AM · Plasma

Oct 24 2019

wbauer added a comment to D24748: [containmentlayoutmanager] Don't accept button events that only start timers.

You can try it like that:

if (!m_editMode) {
    event->setAccepted(false);
}

or

event->setAccepted(m_editMode);
Oct 24 2019, 6:33 PM · Plasma

Oct 22 2019

wbauer added a comment to D24748: [containmentlayoutmanager] Don't accept button events that only start timers.

One thing maybe: with the Desktop layout, if you switch an applet to edit mode (by pressing and holding the left mouse button), it's not possible to exit edit mode by left-clicking on the desktop (even if no left-click action is configured). You need to click on a different applet now, but what if there is none...

Oct 22 2019, 3:05 PM · Plasma

Oct 21 2019

wbauer added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

I'm always easy to confuse about pointers and const, but isn't ec a const pointer to a const object? So calling ec->increaseVolume() as a non-const function) wouldn't really work outside a lambda either.

Yes, exactly. Adding a line ec->increaseVolume(); at that place gives the same compiler error:

/home/abuild/rpmbuild/BUILD/amarok-2.9.70git.20191004T143525~5ed62f9a08/src/MainWindow.cpp: In member function 'void MainWindow::createActions()':
/home/abuild/rpmbuild/BUILD/amarok-2.9.70git.20191004T143525~5ed62f9a08/src/MainWindow.cpp:904:24: error: passing 'const EngineController' as 'this' argument discards qualifiers [-fpermissive]
     ec->increaseVolume();
                        ^
Oct 21 2019, 8:29 PM

Oct 19 2019

wbauer added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

Btw, I mainly followed what was done for the stop() action in commit 1b81541e, where a new regularStop() slot was created for similar reasons AIUI.

Oct 19 2019, 11:46 PM
wbauer added a comment to D24748: [containmentlayoutmanager] Don't accept button events that only start timers.

The patch fixes the problem here, and I didn't notice regressions either so far.
I only did a quick test though, and cannot really comment on the patch per se.

Oct 19 2019, 11:34 PM · Plasma

Oct 4 2019

wbauer added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

Since the method is only one line long, why not using lambda instead here?

Oct 4 2019, 3:15 PM
wbauer added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

PS: I think the argument is 0 because QAction::triggered() has a bool checked argument that's probably passed along.
But Qt's new signal/slots syntax doesn't support default arguments anyway, according to the docs.

Oct 4 2019, 1:22 PM
wbauer requested review of D24413: Fix Increase/Decrease Volume shortcuts.
Oct 4 2019, 1:21 PM
wbauer committed R181:5ed62f9a089d: Register Play/Pause as global shortcut again (authored by wbauer).
Register Play/Pause as global shortcut again
Oct 4 2019, 12:35 PM
wbauer closed D24381: Register Play/Pause as global shortcut again.
Oct 4 2019, 12:35 PM
wbauer added a comment to D24381: Register Play/Pause as global shortcut again.

Btw, I just found a bug report about this:
https://bugs.kde.org/show_bug.cgi?id=373590

Oct 4 2019, 12:33 PM

Oct 3 2019

wbauer retitled D24381: Register Play/Pause as global shortcut again from Register Play/Pause global shortcut again to Register Play/Pause as global shortcut again.
Oct 3 2019, 9:29 AM
wbauer updated the test plan for D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 9:13 AM
wbauer updated the test plan for D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 9:13 AM
wbauer updated subscribers of D24135: Fix missing directory separators when saving podcasts to disk.
Oct 3 2019, 9:07 AM
wbauer added a comment to D24135: Fix missing directory separators when saving podcasts to disk.

+1 from me now as well.

Oct 3 2019, 9:06 AM
wbauer updated the summary of D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 9:03 AM
wbauer requested review of D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 9:02 AM

Sep 30 2019

wbauer accepted D24314: Improve KFloppy icon.

Thanks!

Sep 30 2019, 6:36 PM · Frameworks
wbauer added a comment to D22258: Improve plugin caching.

I don't know the situation well enough to know whether it's valid that it's invalid or not. Let's follow that up in your bug report.

The problem apparently is that the mentioned plugins have their metadata in a .desktop file, but the code here creates the KFileMetaData from the .so file (so the metadata is empty).
See the bug report for more details.

Sep 30 2019, 10:43 AM · Frameworks
wbauer added inline comments to D22258: Improve plugin caching.
Sep 30 2019, 8:45 AM · Frameworks
wbauer added inline comments to D22258: Improve plugin caching.
Sep 30 2019, 8:26 AM · Frameworks

Sep 22 2019

wbauer added a comment to D24135: Fix missing directory separators when saving podcasts to disk.

You should add '/' instead of QDir::separator()...

Sep 22 2019, 7:09 AM

Sep 20 2019

wbauer closed D24040: Don't delete whole folder when deleting a track.
Sep 20 2019, 9:12 AM
wbauer committed R181:b986f52d1d53: Don't delete whole folder when deleting a track (authored by wbauer).
Don't delete whole folder when deleting a track
Sep 20 2019, 9:12 AM

Sep 19 2019

wbauer added a comment to D24040: Don't delete whole folder when deleting a track.

Looks OK. What is the status of the unit tests, though?

Sep 19 2019, 9:23 AM
wbauer committed R181:decd2a3ecb31: [TagDialog] Really enable "Open in filemanager" button for local files (authored by wbauer).
[TagDialog] Really enable "Open in filemanager" button for local files
Sep 19 2019, 8:31 AM