- User Since
- Aug 30 2016, 3:41 PM (163 w, 4 d)
Fri, Oct 4
PS: I think the argument is 0 because QAction::triggered() has a bool checked argument.
But Qt's new signal/slots syntax doesn't support default arguments anyway, according to the docs.
Btw, I just found a bug report about this:
Thu, Oct 3
+1 from me now as well.
Mon, Sep 30
The problem apparently is that the mentioned plugins have their metadata in a .desktop file, but the code here creates the KFileMetaData from the .so file (so the metadata is empty).
See the bug report for more details.
Sun, Sep 22
You should add '/' instead of QDir::separator()...
Fri, Sep 20
Sep 19 2019
Sep 18 2019
Sep 10 2019
Sep 4 2019
That's actually part of libkcddb and not k3b, btw.
Sep 1 2019
Aug 29 2019
Yes, this does fix the crash as well, and it builds fine with Qt 5.9.
JFYI, I already tested the QScopeGuard fix from D23404 today, it alone does indeed fix the crash of BUG 395624.
There is a problem though: QScopeGuard was introduced in Qt 5.12, while the minimum required version is 5.9.
Aug 28 2019
Here's a valgrind log for now, maybe it contains a clue as well...
I played 3 times and got the same crash every time (at some point during play), so it seems to be rather reproducible.
I gave it a try and it does seem to fix the crashes from BUG 395624 here.
Aug 8 2019
Aug 7 2019
Use NOT VERSION_LESS instead to minimize the patch.
Use NOT VERSION_LESS instead to minimize patch.
Can this be pushed to the 5.12 branch as well, please?
It's broken in 5.12.8 as well (https://bugs.kde.org/390776 was actually reported against 5.12.1), the patch applies cleanly and does fix the problem.
Jul 20 2019
What about the stable 5.16 branch?
It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away...
Jul 12 2019
Remove accidental trailing spaces.
Btw, on an unrelated note:
I just noticed that it doesn't actually specify a minimum Qt version, even though it seems to be the intention:
set(QT_MIN_VERSION 5.9.0) find_package(Qt5 REQUIRED COMPONENTS Core DBus Gui Sql Widgets Xml )
Jul 7 2019
Nevermind though, lmontel fixed it meanwhile with commit 7b3249547b92.
Jul 6 2019
This doesn't work as intended (at least here on openSUSE).
I just built it with QtWebEngine 5.13(.0), and it incorrectly took the < 5.13.0 branch.