wbauer (Wolfgang Bauer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 30 2016, 3:41 PM (171 w, 2 d)
Availability
Available

Recent Activity

Nov 5 2019

wbauer added a comment to D25019: Ensure that GlobalDrawer topContent always stays on top.
In D25019#558919, @mart wrote:

Unfortunately, it has been pushed too near to framework release, so now it has been released, breaking several apps for a whole framework release.

It has only been tagged so far, it's not been released yet.
The release will be next Saturday, maybe you should ask for a respin before that.

Nov 5 2019, 1:36 PM · Kirigami

Oct 30 2019

wbauer added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

FTR, we got a downstream bug report about this for openSUSE Leap 15.1 (which ships Plasma 5.12 LTS):
https://bugzilla.opensuse.org/show_bug.cgi?id=1155387

Oct 30 2019, 6:20 PM · Plasma
wbauer added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC.

Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the gtk.css in the first place.

Oct 30 2019, 1:46 PM · Plasma
wbauer added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

Could this be backported to 5.12 too maybe?

Oct 30 2019, 10:10 AM · Plasma

Oct 28 2019

wbauer committed R103:5d0e53f5602f: Merge branch 'Plasma/5.17' (authored by wbauer).
Merge branch 'Plasma/5.17'
Oct 28 2019, 8:09 AM
wbauer committed R103:d7dbd84e96b8: Create directory when saving the menu file (authored by wbauer).
Create directory when saving the menu file
Oct 28 2019, 8:09 AM
wbauer closed D24996: Create directory when saving the menu file.
Oct 28 2019, 8:09 AM · Plasma
wbauer added a comment to D24996: Create directory when saving the menu file.

Alternatively, the directory could also be created in TreeView::TreeView(), but I think this place is more logical (there is no reason to create the directory as long as the menu isn't saved) and it would also work if MenuFile would be used in other places as well, with files in different directories.

Oct 28 2019, 7:27 AM · Plasma
wbauer requested review of D24996: Create directory when saving the menu file.
Oct 28 2019, 7:24 AM · Plasma

Oct 24 2019

wbauer added a comment to D24748: [containmentlayoutmanager] Don't accept button events that only start timers.

You can try it like that:

if (!m_editMode) {
    event->setAccepted(false);
}

or

event->setAccepted(m_editMode);
Oct 24 2019, 6:33 PM · Plasma

Oct 22 2019

wbauer added a comment to D24748: [containmentlayoutmanager] Don't accept button events that only start timers.

One thing maybe: with the Desktop layout, if you switch an applet to edit mode (by pressing and holding the left mouse button), it's not possible to exit edit mode by left-clicking on the desktop (even if no left-click action is configured). You need to click on a different applet now, but what if there is none...

Oct 22 2019, 3:05 PM · Plasma

Oct 21 2019

wbauer added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

I'm always easy to confuse about pointers and const, but isn't ec a const pointer to a const object? So calling ec->increaseVolume() as a non-const function) wouldn't really work outside a lambda either.

Yes, exactly. Adding a line ec->increaseVolume(); at that place gives the same compiler error:

/home/abuild/rpmbuild/BUILD/amarok-2.9.70git.20191004T143525~5ed62f9a08/src/MainWindow.cpp: In member function 'void MainWindow::createActions()':
/home/abuild/rpmbuild/BUILD/amarok-2.9.70git.20191004T143525~5ed62f9a08/src/MainWindow.cpp:904:24: error: passing 'const EngineController' as 'this' argument discards qualifiers [-fpermissive]
     ec->increaseVolume();
                        ^
Oct 21 2019, 8:29 PM

Oct 19 2019

wbauer added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

Btw, I mainly followed what was done for the stop() action in commit 1b81541e, where a new regularStop() slot was created for similar reasons AIUI.

Oct 19 2019, 11:46 PM
wbauer added a comment to D24748: [containmentlayoutmanager] Don't accept button events that only start timers.

The patch fixes the problem here, and I didn't notice regressions either so far.
I only did a quick test though, and cannot really comment on the patch per se.

Oct 19 2019, 11:34 PM · Plasma

Oct 4 2019

wbauer added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

Since the method is only one line long, why not using lambda instead here?

Oct 4 2019, 3:15 PM
wbauer added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

PS: I think the argument is 0 because QAction::triggered() has a bool checked argument that's probably passed along.
But Qt's new signal/slots syntax doesn't support default arguments anyway, according to the docs.

Oct 4 2019, 1:22 PM
wbauer requested review of D24413: Fix Increase/Decrease Volume shortcuts.
Oct 4 2019, 1:21 PM
wbauer committed R181:5ed62f9a089d: Register Play/Pause as global shortcut again (authored by wbauer).
Register Play/Pause as global shortcut again
Oct 4 2019, 12:35 PM
wbauer closed D24381: Register Play/Pause as global shortcut again.
Oct 4 2019, 12:35 PM
wbauer added a comment to D24381: Register Play/Pause as global shortcut again.

Btw, I just found a bug report about this:
https://bugs.kde.org/show_bug.cgi?id=373590

Oct 4 2019, 12:33 PM

Oct 3 2019

wbauer retitled D24381: Register Play/Pause as global shortcut again from Register Play/Pause global shortcut again to Register Play/Pause as global shortcut again.
Oct 3 2019, 9:29 AM
wbauer updated the test plan for D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 9:13 AM
wbauer updated the test plan for D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 9:13 AM
wbauer updated subscribers of D24135: Fix missing directory separators when saving podcasts to disk.
Oct 3 2019, 9:07 AM
wbauer added a comment to D24135: Fix missing directory separators when saving podcasts to disk.

+1 from me now as well.

Oct 3 2019, 9:06 AM
wbauer updated the summary of D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 9:03 AM
wbauer requested review of D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 9:02 AM

Sep 30 2019

wbauer accepted D24314: Improve KFloppy icon.

Thanks!

Sep 30 2019, 6:36 PM · Frameworks
wbauer added a comment to D22258: Improve plugin caching.

I don't know the situation well enough to know whether it's valid that it's invalid or not. Let's follow that up in your bug report.

The problem apparently is that the mentioned plugins have their metadata in a .desktop file, but the code here creates the KFileMetaData from the .so file (so the metadata is empty).
See the bug report for more details.

Sep 30 2019, 10:43 AM · Frameworks
wbauer added inline comments to D22258: Improve plugin caching.
Sep 30 2019, 8:45 AM · Frameworks
wbauer added inline comments to D22258: Improve plugin caching.
Sep 30 2019, 8:26 AM · Frameworks

Sep 22 2019

wbauer added a comment to D24135: Fix missing directory separators when saving podcasts to disk.

You should add '/' instead of QDir::separator()...

Sep 22 2019, 7:09 AM

Sep 20 2019

wbauer closed D24040: Don't delete whole folder when deleting a track.
Sep 20 2019, 9:12 AM
wbauer committed R181:b986f52d1d53: Don't delete whole folder when deleting a track (authored by wbauer).
Don't delete whole folder when deleting a track
Sep 20 2019, 9:12 AM

Sep 19 2019

wbauer added a comment to D24040: Don't delete whole folder when deleting a track.

Looks OK. What is the status of the unit tests, though?

Sep 19 2019, 9:23 AM
wbauer committed R181:decd2a3ecb31: [TagDialog] Really enable "Open in filemanager" button for local files (authored by wbauer).
[TagDialog] Really enable "Open in filemanager" button for local files
Sep 19 2019, 8:31 AM
wbauer closed D24043: [TagDialog] Really enable "Open in filemanager" button for local files.
Sep 19 2019, 8:31 AM

Sep 18 2019

wbauer updated subscribers of D24043: [TagDialog] Really enable "Open in filemanager" button for local files.
Sep 18 2019, 8:54 AM
wbauer updated subscribers of D24040: Don't delete whole folder when deleting a track.
Sep 18 2019, 8:54 AM
wbauer updated the test plan for D24043: [TagDialog] Really enable "Open in filemanager" button for local files.
Sep 18 2019, 8:22 AM
wbauer requested review of D24043: [TagDialog] Really enable "Open in filemanager" button for local files.
Sep 18 2019, 8:17 AM
wbauer updated the test plan for D24040: Don't delete whole folder when deleting a track.
Sep 18 2019, 7:04 AM
wbauer requested review of D24040: Don't delete whole folder when deleting a track.
Sep 18 2019, 6:53 AM

Sep 10 2019

wbauer committed R443:6de7f7a49a3c: Merge branch 'Applications/19.08' (authored by wbauer).
Merge branch 'Applications/19.08'
Sep 10 2019, 2:18 PM
wbauer committed R443:5a1fe1578083: Fix build with cmake < 3.12 (authored by wbauer).
Fix build with cmake < 3.12
Sep 10 2019, 2:12 PM
wbauer committed R443:4e509b8735bf: Fix build with cmake < 3.12 (authored by wbauer).
Fix build with cmake < 3.12
Sep 10 2019, 2:09 PM
wbauer closed D23826: Fix build with cmake < 3.12.
Sep 10 2019, 2:09 PM · KDE Applications
wbauer requested review of D23826: Fix build with cmake < 3.12.
Sep 10 2019, 10:19 AM · KDE Applications

Sep 4 2019

wbauer added a comment to D23542: Promote KCM to top level and rename accordingly.

Please note that k3b ships the 'CDDB retrieval' KCM, which is in the Multimedia section as well

That's actually part of libkcddb and not k3b, btw.

Sep 4 2019, 5:49 AM · Plasma

Sep 1 2019

wbauer committed R73:a698894fdaac: Fix build with cmake < 3.7 (authored by wbauer).
Fix build with cmake < 3.7
Sep 1 2019, 6:52 PM
wbauer closed D23638: Fix build with cmake < 3.7.
Sep 1 2019, 6:52 PM · Rocs, KDE Edu
wbauer updated the summary of D23638: Fix build with cmake < 3.7.
Sep 1 2019, 12:17 PM · Rocs, KDE Edu
wbauer requested review of D23638: Fix build with cmake < 3.7.
Sep 1 2019, 11:45 AM · Rocs, KDE Edu
wbauer added a reviewer for D23635: Fix build with cmake < 3.7: Umbrello.
Sep 1 2019, 11:27 AM · Umbrello
wbauer requested review of D23635: Fix build with cmake < 3.7.
Sep 1 2019, 11:27 AM · Umbrello

Aug 29 2019

wbauer accepted D23570: FcSolveSolver: cleanup ressources.

Yes, this does fix the crash as well, and it builds fine with Qt 5.9.

Aug 29 2019, 6:15 PM
wbauer added a comment to D23570: FcSolveSolver: cleanup ressources.

This is hopefully already a minimal fix for the crash issues, and it does not depend on Qt 5.12 features. @wbauer It would be most helpful if you could test whether the original bug is indeed no longer occurring after this patch.

JFYI, I already tested the QScopeGuard fix from D23404 today, it alone does indeed fix the crash of BUG 395624.

Aug 29 2019, 5:08 PM
wbauer added inline comments to D23404: Revamp solver memory management.
Aug 29 2019, 8:11 AM
wbauer added a comment to D23404: Revamp solver memory management.

There is a problem though: QScopeGuard was introduced in Qt 5.12, while the minimum required version is 5.9.

Aug 29 2019, 8:09 AM
wbauer added a comment to D23404: Revamp solver memory management.

The issue with the previous version was that the memory accounting code was wrong, and the allocation would fail at some point. The most recent version fixes this, and I could successfully complete a game of Grandfather's Clock again.

Aug 29 2019, 8:03 AM

Aug 28 2019

wbauer added a comment to D23404: Revamp solver memory management.

Here's a valgrind log for now, maybe it contains a clue as well...

Aug 28 2019, 3:52 PM
wbauer added a comment to D23404: Revamp solver memory management.

Thank you very much for testing the patch. Could you maybe compile kpat with
cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address,leak,undefined' ..
and report back any backtrace you get from playing Grandfather's Clock? I again cannot reproduce the crash :-(

Aug 28 2019, 3:45 PM
wbauer added a comment to D23404: Revamp solver memory management.

I did get another crash while playing Grandfather's Clock now though, no idea if it is related to this change or not.

I played 3 times and got the same crash every time (at some point during play), so it seems to be rather reproducible.

Aug 28 2019, 12:36 PM
wbauer added a comment to D23404: Revamp solver memory management.

I gave it a try and it does seem to fix the crashes from BUG 395624 here.

Aug 28 2019, 11:44 AM

Aug 8 2019

wbauer committed R433:838bebfd2fde: Merge branch 'Applications/19.08' (authored by wbauer).
Merge branch 'Applications/19.08'
Aug 8 2019, 6:33 PM
wbauer committed R433:2ae63bea674c: [mirrorsearch] Remove no longer available services from default list (authored by wbauer).
[mirrorsearch] Remove no longer available services from default list
Aug 8 2019, 6:32 PM

Aug 7 2019

wbauer committed R36:84694592ceb5: Merge branch 'Applications/19.08' (authored by wbauer).
Merge branch 'Applications/19.08'
Aug 7 2019, 9:22 PM
wbauer committed R36:c81ef41ac6a6: Fix build with cmake < 3.7 (authored by wbauer).
Fix build with cmake < 3.7
Aug 7 2019, 9:21 PM
wbauer closed D22983: Fix build with cmake < 3.7.
Aug 7 2019, 9:21 PM · Ark
wbauer committed R443:2e8696c1133c: Merge branch 'Applications/19.08' (authored by wbauer).
Merge branch 'Applications/19.08'
Aug 7 2019, 6:51 PM
wbauer closed D22987: Fix build with cmake < 3.7.
Aug 7 2019, 6:51 PM · KDE Applications
wbauer committed R443:626358ec096a: Fix build with cmake < 3.7 (authored by wbauer).
Fix build with cmake < 3.7
Aug 7 2019, 6:51 PM
wbauer committed R226:3e2dc5be72f4: Merge branch 'Applications/19.08' (authored by wbauer).
Merge branch 'Applications/19.08'
Aug 7 2019, 6:45 PM
wbauer committed R226:b48855158093: [webenginepart] Fix build with cmake < 3.7 (authored by wbauer).
[webenginepart] Fix build with cmake < 3.7
Aug 7 2019, 6:43 PM
wbauer closed D23006: [webenginepart] Fix build with cmake < 3.7.
Aug 7 2019, 6:43 PM · Konqueror
wbauer updated subscribers of D23006: [webenginepart] Fix build with cmake < 3.7.
Aug 7 2019, 4:56 PM · Konqueror
wbauer requested review of D23006: [webenginepart] Fix build with cmake < 3.7.
Aug 7 2019, 4:35 PM · Konqueror
wbauer committed R336:1df7a2a45070: Merge branch 'Applications/19.08' (authored by wbauer).
Merge branch 'Applications/19.08'
Aug 7 2019, 4:16 PM
wbauer committed R336:36c658aaec85: Fix build with older cmake (authored by wbauer).
Fix build with older cmake
Aug 7 2019, 4:16 PM
wbauer closed D22990: Fix build with older cmake.
Aug 7 2019, 4:16 PM · KDE Applications, KDE Edu
wbauer committed R318:e39b7e8f5a91: Merge branch 'Applications/19.08' (authored by wbauer).
Merge branch 'Applications/19.08'
Aug 7 2019, 4:12 PM
wbauer committed R318:68aee5ed51b5: Fix build with cmake < 3.7 (authored by wbauer).
Fix build with cmake < 3.7
Aug 7 2019, 4:10 PM
wbauer closed D22984: Fix build with cmake < 3.7.
Aug 7 2019, 4:10 PM · Dolphin
wbauer requested review of D22990: Fix build with older cmake.
Aug 7 2019, 12:46 PM · KDE Applications, KDE Edu
wbauer requested review of D22987: Fix build with cmake < 3.7.
Aug 7 2019, 10:52 AM · KDE Applications
wbauer updated the diff for D22984: Fix build with cmake < 3.7.

Use NOT VERSION_LESS instead to minimize the patch.

Aug 7 2019, 9:57 AM · Dolphin
wbauer updated the diff for D22983: Fix build with cmake < 3.7.

Use NOT VERSION_LESS instead to minimize patch.

Aug 7 2019, 9:51 AM · Ark
wbauer added inline comments to D22983: Fix build with cmake < 3.7.
Aug 7 2019, 9:46 AM · Ark
wbauer requested review of D22984: Fix build with cmake < 3.7.
Aug 7 2019, 9:45 AM · Dolphin
wbauer added a reviewer for D22983: Fix build with cmake < 3.7: Ark.
Aug 7 2019, 9:29 AM · Ark
wbauer requested review of D22983: Fix build with cmake < 3.7.
Aug 7 2019, 9:29 AM · Ark
wbauer added a comment to D22814: Remove colon (:) prefix when looking up dictionary word.

Thank you!

Aug 7 2019, 8:47 AM · Plasma
wbauer added a comment to D22814: Remove colon (:) prefix when looking up dictionary word.

Can this be pushed to the 5.12 branch as well, please?
It's broken in 5.12.8 as well (https://bugs.kde.org/390776 was actually reported against 5.12.1), the patch applies cleanly and does fix the problem.

Aug 7 2019, 5:05 AM · Plasma

Jul 20 2019

wbauer added a comment to D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes..

What about the stable 5.16 branch?
It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away...

Jul 20 2019, 5:29 PM · Plasma

Jul 12 2019

wbauer committed R220:8b039ceb4f6e: Merge branch '2.1' (authored by wbauer).
Merge branch '2.1'
Jul 12 2019, 2:16 PM
wbauer closed D22415: Actually set minimum Qt version.
Jul 12 2019, 2:14 PM
wbauer committed R220:fc49e3ec5d80: Actually set minimum Qt version (authored by wbauer).
Actually set minimum Qt version
Jul 12 2019, 2:14 PM
wbauer closed D22412: Fix build with Qt 5.9.
Jul 12 2019, 2:14 PM
wbauer committed R220:9acb42845378: Fix build with Qt 5.9 (authored by wbauer).
Fix build with Qt 5.9
Jul 12 2019, 2:14 PM
wbauer updated the test plan for D22415: Actually set minimum Qt version.
Jul 12 2019, 10:02 AM