wbauer (Wolfgang Bauer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 30 2016, 3:41 PM (145 w, 4 d)
Availability
Available

Recent Activity

Fri, Jun 14

wbauer committed R181:cea336303aaf: Fix passing local file paths on the command line (authored by wbauer).
Fix passing local file paths on the command line
Fri, Jun 14, 12:03 PM
wbauer closed D21478: Fix passing local file paths on the command line.
Fri, Jun 14, 12:03 PM

Sat, Jun 1

wbauer added reviewers for D21145: Make KTorrent work with current GeoIP files: stikonas, trufanov.

Adding some reviewers...

Sat, Jun 1, 12:14 PM

Wed, May 29

wbauer added inline comments to D21478: Fix passing local file paths on the command line.
Wed, May 29, 3:14 PM
wbauer added inline comments to D21478: Fix passing local file paths on the command line.
Wed, May 29, 1:14 PM
wbauer updated the test plan for D21478: Fix passing local file paths on the command line.
Wed, May 29, 12:49 PM
wbauer updated the summary of D21478: Fix passing local file paths on the command line.
Wed, May 29, 12:48 PM
wbauer updated the summary of D21478: Fix passing local file paths on the command line.
Wed, May 29, 12:48 PM
wbauer requested review of D21478: Fix passing local file paths on the command line.
Wed, May 29, 12:47 PM

Tue, May 21

wbauer committed R201:d89036b18023: Merge branch 'Applications/19.04' (authored by wbauer).
Merge branch 'Applications/19.04'
Tue, May 21, 4:26 PM
wbauer committed R201:cfb973c74fec: Fix crashes with Qt 5.12 (authored by wbauer).
Fix crashes with Qt 5.12
Tue, May 21, 4:23 PM
wbauer closed D21236: Fix crashes with Qt 5.12.
Tue, May 21, 4:23 PM · KDE PIM

May 15 2019

wbauer added a reviewer for D21236: Fix crashes with Qt 5.12: KDE PIM.
May 15 2019, 7:52 PM · KDE PIM
wbauer updated the summary of D21236: Fix crashes with Qt 5.12.
May 15 2019, 7:34 PM · KDE PIM
wbauer requested review of D21236: Fix crashes with Qt 5.12.
May 15 2019, 7:31 PM · KDE PIM

May 3 2019

wbauer closed D20957: Fix build with libvlc 2.2.

The change is part of 402cbee5e675.

May 3 2019, 6:57 PM

May 2 2019

wbauer added a comment to D20957: Fix build with libvlc 2.2.

As mentioned in the bugreport, I noticed meanwhile that playback doesn't seem to work at all with libvlc 2.2.6.

May 2 2019, 12:14 PM
wbauer added a reviewer for D20957: Fix build with libvlc 2.2: mauroc.
May 2 2019, 10:41 AM
wbauer updated the diff for D20957: Fix build with libvlc 2.2.

Updated diff to include full context.

May 2 2019, 10:40 AM
wbauer requested review of D20957: Fix build with libvlc 2.2.
May 2 2019, 10:39 AM

Apr 19 2019

wbauer added a comment to D20681: Fix build with QtWebEngine 5.6.

PS: I just now found the same in core/dplugins/generic/webservices/unified/wizard/wsauthenticationpage.cpp, but that isn't compiled currently.

Apr 19 2019, 10:05 AM · Digikam
wbauer updated the test plan for D20681: Fix build with QtWebEngine 5.6.
Apr 19 2019, 8:51 AM · Digikam
wbauer requested review of D20681: Fix build with QtWebEngine 5.6.
Apr 19 2019, 8:50 AM · Digikam

Apr 17 2019

wbauer requested review of D20632: Fix build with Qt 5.6.
Apr 17 2019, 9:01 AM · Digikam

Apr 5 2019

wbauer added a comment to D17187: Set the default cursor theme to breeze_cursors.

I just noticed that this change is missing again in 5.15.
Apparently it was reverted (by mistake?) in R98:e1f97ce5 ...

Apr 5 2019, 8:19 AM · Plasma
wbauer added a comment to R98:e1f97ce52a81: Go back to SCSS..

This reverted D17187, that probably wasn't intended.

Apr 5 2019, 8:18 AM

Mar 13 2019

wbauer added a comment to D19520: Properly restore current desktop from session.

Wouldn't it make sense to backport this to 5.12 as well?
The mentioned bug was originally reported against 5.12.0, apparently it was a regression compared to 5.11.

Mar 13 2019, 9:13 AM · KWin
wbauer added a comment to D19552: [effects/screenshot] Set m_windowMode in screenshotWindowUnderCursor.

What about 5.12?
The problem exists there too, and this patch fixes it.

Mar 13 2019, 9:09 AM · KWin

Mar 8 2019

wbauer committed R71:b0d5285aa8b8: Merge branch '3.2' (authored by wbauer).
Merge branch '3.2'
Mar 8 2019, 7:07 PM
wbauer committed R71:bb554ba8bc74: Fix compilation with KIO < 5.33 (authored by wbauer).
Fix compilation with KIO < 5.33
Mar 8 2019, 7:07 PM

Mar 7 2019

l10n daemon script <scripty@kde.org> committed R216:0d75f65bb73b: Fix build with cmake < 3.7 (authored by wbauer).
Fix build with cmake < 3.7
Mar 7 2019, 10:06 AM
wbauer committed R216:a08e2ebd589f: Fix build with cmake < 3.7 (authored by wbauer).
Fix build with cmake < 3.7
Mar 7 2019, 8:26 AM
wbauer closed D19581: Fix build with cmake < 3.7.
Mar 7 2019, 8:26 AM · Frameworks, Kate, Framework: Syntax Highlighting
wbauer requested review of D19581: Fix build with cmake < 3.7.
Mar 7 2019, 8:16 AM · Frameworks, Kate, Framework: Syntax Highlighting

Mar 5 2019

wbauer updated the summary of D19513: Fix ibeam and underline cursor rendering.
Mar 5 2019, 12:35 PM · Konsole
wbauer added a comment to D19513: Fix ibeam and underline cursor rendering.

That's OK, can I get your email address so I can attribute the patch correctly?

Mar 5 2019, 10:01 AM · Konsole

Mar 4 2019

wbauer added a comment to D19513: Fix ibeam and underline cursor rendering.

Thanks, I'm looking at - if you are using arc, can you set it up to add your name/email to the commit message? Not a show stopper as I can fix when I commit

Mar 4 2019, 3:17 PM · Konsole
wbauer updated the test plan for D19513: Fix ibeam and underline cursor rendering.
Mar 4 2019, 2:53 PM · Konsole
wbauer updated the summary of D19513: Fix ibeam and underline cursor rendering.
Mar 4 2019, 2:12 PM · Konsole
wbauer requested review of D19513: Fix ibeam and underline cursor rendering.
Mar 4 2019, 2:10 PM · Konsole

Mar 3 2019

wbauer committed R241:01a7e0e757d3: Fix NTFS hidden check for symlinks to NTFS mountpoints (authored by wbauer).
Fix NTFS hidden check for symlinks to NTFS mountpoints
Mar 3 2019, 11:55 AM
wbauer closed D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints.
Mar 3 2019, 11:55 AM · Frameworks

Mar 2 2019

wbauer added a comment to D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints.

Ping?

Mar 2 2019, 8:55 PM · Frameworks

Feb 27 2019

wbauer accepted D18985: Port away from deprecated KIO::NetAccess.

Sorry for the delay again, I was busy with other things...
Thanks for the additional changes.

Feb 27 2019, 8:35 PM

Feb 22 2019

wbauer requested changes to D18985: Port away from deprecated KIO::NetAccess.

Should be good now, thanks!

Feb 22 2019, 3:38 PM
wbauer requested changes to D18985: Port away from deprecated KIO::NetAccess.

See inline, the if (job->error()) branch in particular looks quite broken to me.
OTOH, I'm not sure if trying to do something else in case of an error actually makes sense, it's probably sufficient to just return the original URL in case the job fails.
I.e., I think this could be reduced to just:

Feb 22 2019, 12:04 PM

Feb 20 2019

wbauer committed R433:f60ed6ee99bd: Add missing include (authored by wbauer).
Add missing include
Feb 20 2019, 7:29 PM
wbauer added a comment to D18985: Port away from deprecated KIO::NetAccess.

This should be fixed now. Thoroughly tested on a clean profile for generic testing downloads of zip files and torrents.

https://cgit.kde.org/kget.git/commit/?id=f12296b9241a218a9f88169e0cb450eda4dddb99

Feb 20 2019, 6:57 PM

Feb 13 2019

wbauer added a comment to D18985: Port away from deprecated KIO::NetAccess.

First of all, thank you for your contributions! ;-)

Feb 13 2019, 9:13 PM

Feb 12 2019

wbauer committed R286:1632a6972279: Fix build with cmake 3.5 (authored by wbauer).
Fix build with cmake 3.5
Feb 12 2019, 9:32 AM
wbauer closed D18941: Fix build with cmake 3.5.
Feb 12 2019, 9:32 AM · Frameworks, Baloo
wbauer updated the summary of D18941: Fix build with cmake 3.5.
Feb 12 2019, 7:17 AM · Frameworks, Baloo
wbauer updated the test plan for D18941: Fix build with cmake 3.5.
Feb 12 2019, 7:12 AM · Frameworks, Baloo
wbauer requested review of D18941: Fix build with cmake 3.5.
Feb 12 2019, 6:59 AM · Frameworks, Baloo

Jan 23 2019

wbauer added a comment to D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints.

The existing check did work fine for me back in D13782 also for symlinks for some reason.
Maybe this broke because of some change in the kernel or glibc? :-/

Jan 23 2019, 7:08 PM · Frameworks
wbauer added a comment to D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints.

The existing check did work fine for me back in D13782 also for symlinks for some reason.
Maybe this broke because of some change in the kernel or glibc? :-/

Jan 23 2019, 6:41 PM · Frameworks
wbauer requested review of D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints.
Jan 23 2019, 6:40 PM · Frameworks

Jan 3 2019

wbauer added a comment to D17873: Compile more files with enabled exceptions, required for exiv2 0.27.

I can't comment whether this is the desired way to do it

Jan 3 2019, 7:26 PM · Gwenview
wbauer added a comment to D17873: Compile more files with enabled exceptions, required for exiv2 0.27.

I can't comment whether this is the desired way to do it, but it does fix the build with exiv2 0.27, on openSUSE at least. (with D17872 in)
Without it, the compilation fails due to errors:
error: exception handling disabled, use -fexceptions to enable

Jan 3 2019, 7:20 PM · Gwenview
wbauer added a comment to D17810: Fix building against exiv2-0.27.

Yes, looks fine now.
Thank you! ;-)

Jan 3 2019, 10:57 AM · Krita
wbauer added a comment to D17810: Fix building against exiv2-0.27.

Outch, thanks for the hint. I'll fix that.

Jan 3 2019, 10:41 AM · Krita

Jan 2 2019

wbauer added inline comments to D17810: Fix building against exiv2-0.27.
Jan 2 2019, 11:07 PM · Krita

Dec 20 2018

wbauer committed R433:c952d0d5e6dd: Merge branch 'Applications/18.12' (authored by wbauer).
Merge branch 'Applications/18.12'
Dec 20 2018, 9:39 PM
wbauer committed R433:80adf24c1091: Set window icon in code instead of in the desktop file (authored by wbauer).
Set window icon in code instead of in the desktop file
Dec 20 2018, 9:37 PM

Dec 12 2018

wbauer closed D17529: [proxysetting] Fix build with NM 1.4.
Dec 12 2018, 1:44 PM · Frameworks
wbauer committed R282:88f3093c5237: [proxysetting] Fix build with NM 1.4 (authored by wbauer).
[proxysetting] Fix build with NM 1.4
Dec 12 2018, 1:44 PM
wbauer updated the summary of D17529: [proxysetting] Fix build with NM 1.4.
Dec 12 2018, 1:36 PM · Frameworks
wbauer requested review of D17529: [proxysetting] Fix build with NM 1.4.
Dec 12 2018, 1:35 PM · Frameworks
wbauer updated the diff for D17529: [proxysetting] Fix build with NM 1.4.

Don't define the enum, rather use the numbers directly

Dec 12 2018, 1:33 PM · Frameworks
wbauer added a comment to D17529: [proxysetting] Fix build with NM 1.4.

So maybe go with the easiest approach and just instead of defines use 0 and 1?

Dec 12 2018, 1:16 PM · Frameworks
wbauer added a comment to D17529: [proxysetting] Fix build with NM 1.4.

Hm, maybe I should add extern "C" though?
This is inside G_BEGIN_DECLS/G_END_DECLS in nm-setting-proxy.h, which are defined as extern "C" { and } (according to the docs).

Dec 12 2018, 12:47 PM · Frameworks
wbauer added a comment to D17529: [proxysetting] Fix build with NM 1.4.

I don't think that really is a problem here though, as it is defined in libnm/nm-setting-proxy.h (in NM 1.6+) which is included by this file (via NetworkManager.h that's included by setting.h).
I.e. the enum will still be there when building against NM 1.6.0+ (otherwise the build would fail in the first place anyway, as it is used just a few lines below).

Dec 12 2018, 12:15 PM · Frameworks
wbauer added a comment to D17529: [proxysetting] Fix build with NM 1.4.

I think the easiest solution here is just to set 0 and 1 to the enum values, instead of NM defines.

Sure, that would work as well.

Dec 12 2018, 12:06 PM · Frameworks
wbauer added a reviewer for D17529: [proxysetting] Fix build with NM 1.4: jgrulich.
Dec 12 2018, 9:28 AM · Frameworks
wbauer requested review of D17529: [proxysetting] Fix build with NM 1.4.
Dec 12 2018, 9:28 AM · Frameworks

Dec 6 2018

wbauer added a comment to D16947: fix drawing box chars, avoid storing and saving state all the time.

Just to confirm: this does fix https://bugs.kde.org/show_bug.cgi?id=401463 for me.

Dec 6 2018, 10:04 AM · Konsole

Dec 1 2018

wbauer abandoned D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Close with REVIEW: D17276 was not successful.

remote: https://commits.kde.org/digikam/60721615dd9af2b81dacce06adaa7e31d56eee32
remote: ERROR - Communication problem with Reviewboard. Please contact the KDE sysadmins.
remote: INFO - Please report the following:
remote: INFO - Request URL: https://git.reviewboard.kde.org/api/review-requests/17276/
remote: INFO - Status code: 404

Maik

Dec 1 2018, 3:47 PM · Digikam
wbauer added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

No, welcome page view is not present in Showfoto. Only the geolocation view. So the patch must be applied too to Showfoto::main().

Dec 1 2018, 3:20 PM · Digikam
wbauer updated the diff for D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Apply the same change to showfoto as well.

Dec 1 2018, 2:55 PM · Digikam
wbauer added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Did you test this king of patch with the geolocation view, in GoogleMaps mode which use also QWebEngine ?

Dec 1 2018, 11:07 AM · Digikam
wbauer updated the test plan for D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.
Dec 1 2018, 9:21 AM · Digikam
wbauer requested review of D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.
Dec 1 2018, 9:20 AM · Digikam

Nov 28 2018

wbauer added a comment to D17187: Set the default cursor theme to breeze_cursors.

Btw, It seems the gtk-cursor-theme-name option actually has no influence on GTK2 applications, so it probably wouldn't need to be written to the GTK2 config here.
But then, the KCM does save it to the GTK2 config as well...

Nov 28 2018, 4:34 PM · Plasma
wbauer added a comment to D17187: Set the default cursor theme to breeze_cursors.

The same happens already if one uses the GTK KCM though, as it will always write a cursor theme entry too.

Yes, that can be unexpected - even by not changing the cursor theme explicitly, it can make a difference. In that way this patch makes it more predictable.

Nov 28 2018, 4:21 PM · Plasma
wbauer added a comment to D17187: Set the default cursor theme to breeze_cursors.

That's not the full truth though.
The cursor theme KCM will affect the default theme of the whole session.
I.e. it actually will affect non-KDE applications too, unless they explicitly use a different one.

Nov 28 2018, 4:18 PM · Plasma
wbauer added a comment to D17187: Set the default cursor theme to breeze_cursors.

Actually, if the cursor theme is not set to anything, GTK would just use the session's default. I.e. this patch should not be necessary in the first place.

If it is set though, the default is different for GTK and Qt in a Plasma session, which can be surprising and this patch explicitly avoids that.

Nov 28 2018, 9:25 AM · Plasma

Nov 27 2018

wbauer added a comment to D17187: Set the default cursor theme to breeze_cursors.

Actually, if the cursor theme is not set to anything, GTK would just use the session's default. I.e. this patch should not be necessary in the first place.
But at least in openSUSE, the cursor theme is explicitly set to Adwaita in the system-wide GTK config, /etc/gtk-3.0/settings.ini . That is what caused GTK3 applications to use Adwaita by default.

Nov 27 2018, 9:03 PM · Plasma

Nov 8 2018

wbauer committed R433:bc0707ef3c56: Drop dead code for older KDE Frameworks versions (authored by wbauer).
Drop dead code for older KDE Frameworks versions
Nov 8 2018, 7:24 PM
wbauer committed R433:677f8a1d046a: Raise minimum required KDE Frameworks version to 5.44.0 (authored by wbauer).
Raise minimum required KDE Frameworks version to 5.44.0
Nov 8 2018, 7:03 PM

Nov 6 2018

wbauer added a comment to D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.

The point is, there is no reason to reference distos (which are downstream from us) when we fix issues here. It does not matter that many or even most reports came from Neon. All rolling release distros have Frameworks 5.51, so it certainly was not just Neon users experiencing the issue.

Nov 6 2018, 7:07 PM · KDE Connect

Oct 24 2018

wbauer committed R94:3d132097f9be: Merge branch 'master' of git://anongit.kde.org/messagelib (authored by wbauer).
Merge branch 'master' of git://anongit.kde.org/messagelib
Oct 24 2018, 10:11 PM
wbauer committed R94:c937230e825d: Merge branch 'Applications/18.08' (authored by wbauer).
Merge branch 'Applications/18.08'
Oct 24 2018, 10:11 PM
wbauer committed R94:569c3780a8f1: Check QtWebEngine version instead of Qt's (authored by wbauer).
Check QtWebEngine version instead of Qt's
Oct 24 2018, 10:07 PM
wbauer closed D16398: Check QtWebEngine version instead of Qt's.
Oct 24 2018, 10:07 PM · KDE PIM
wbauer updated the summary of D16398: Check QtWebEngine version instead of Qt's.
Oct 24 2018, 5:03 PM · KDE PIM
wbauer added a comment to D16398: Check QtWebEngine version instead of Qt's.

Cool, this should also benefit FreeBSD, where we have
Qt 5.11.2/QtWebengine 5.9.4

Oct 24 2018, 5:00 PM · KDE PIM
wbauer updated the summary of D16398: Check QtWebEngine version instead of Qt's.
Oct 24 2018, 10:09 AM · KDE PIM
wbauer requested review of D16398: Check QtWebEngine version instead of Qt's.
Oct 24 2018, 10:05 AM · KDE PIM

Oct 14 2018

wbauer abandoned D16192: Fix build with Qt 5.7 and lower.

As it turned out, support for Qt < 5.8 has been dropped intentionally.

Oct 14 2018, 10:09 PM · KPhotoAlbum
wbauer requested review of D16192: Fix build with Qt 5.7 and lower.
Oct 14 2018, 8:22 AM · KPhotoAlbum