Gives immediate focus to the search entry control after pressing the shortcut to show it
ClosedPublic
Actions

Authored by mgallien on Sep 19 2018, 8:12 PM.

Details

Reviewers

astippich
januz
ognarb

Commits

R255:3f15d516b980: Gives immediate focus to the search entry control after pressing the shortcut…

Summary

when showing the filter panel, give it focus immediately

clean up the logic behind the filter bar expanded and collapsed states

CCBUG: 398718

Test Plan

pressing the shortcut gives focus

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Sep 19 2018, 8:12 PM

mgallien created this revision.

Harbormaster completed remote builds in B3015: Diff 41947.Sep 19 2018, 8:12 PM

mgallien retitled this revision from clean up the logic behind the filter bar expanded and collapsed states to Gives immediate focus to the search entry control after pressing the shortcut to show it.Sep 19 2018, 8:16 PM

mgallien edited the summary of this revision. (Show Details)

mgallien added a project: Elisa.

I think there is still one issue: when the view is not collapsed and you click on e.g. artist view, the search field also doesn't get focus immediately. but it's an improvement anyway

This revision is now accepted and ready to land.Sep 21 2018, 3:34 PM

In D15607#329852, @astippich wrote:

I think there is still one issue: when the view is not collapsed and you click on e.g. artist view, the search field also doesn't get focus immediately. but it's an improvement anyway

Thanks for the review.

This is a good idea. I will do another review for it.

Closed by commit R255:3f15d516b980: Gives immediate focus to the search entry control after pressing the shortcut… (authored by mgallien). · Explain WhySep 23 2018, 7:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/qmltests/tst_NavigationActionBar.qml (36 lines)
M			src/qml/ContentView.qml (66 lines)
M			src/qml/ElisaMainWindow.qml (13 lines)
M			src/qml/FileBrowserView.qml (3 lines)
M			src/qml/GridBrowserView.qml (3 lines)
M			src/qml/ListBrowserView.qml (3 lines)
M			src/qml/NavigationActionBar.qml (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41947	773c093		Sep 19 2018, 8:12 PM	★	★
Diff 2	42203	a33a379	R255:3f15d516b98003e4a70ba2af368f8fa834104f07	Sep 23 2018, 7:55 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3f7805483622	8dd8ea06b7b0	834c71263170	Matthieu Gallien	when showing the filter panel, give it focus immediately	Sep 19 2018, 3:37 PM
834c71263170	61f804be3c83	80c8de50fd36	Matthieu Gallien	restore global shortcut to show the filter panel	Sep 19 2018, 3:37 PM
80c8de50fd36	6d4b385da3a8	773c093b7206	Matthieu Gallien	clean up the logic behind the filter bar expanded and collapsed states	Sep 17 2018, 7:37 PM