- User Since
- Jun 25 2016, 2:31 PM (159 w, 3 d)
Tue, Jun 25
This is great! Thanks!
Same issue in here: https://phabricator.kde.org/D13219
I'm not sure if this is the correct way of fixing it, but I think there isn't any other prvoided by Qt, other then QLocale::toString. Maybe it's the easy way here :)
Jun 1 2019
And what would happen to menus? How will that centered toolbar look with menus on the left?
How it will work with KDevelop for example?
May 31 2019
Even in Qt there aren't many (if any) developers who understands RTL text. That is why many bugs I reported to Qt didn't get resolved till now.
May 29 2019
Issue 1: https://bugs.kde.org/show_bug.cgi?id=385694 (In Qt, it happens only with bidi: https://bugreports.qt.io/browse/QTBUG-71489)
Issue 2: Yes, this happens. I don't know if a bug is reported or not. I remember seeing this with normal LTR text as well, and it got fixed. (I think some height algorithm was changed)
Issue 3: Seems related to issue 1.
Issue 4: This is new. So hitting up in the wrapped RTL text segments takes you to the beginning of the segment, not up to other segments.
May 8 2019
Can't test, but seems fine.
Thanks for informing! :)
Mar 17 2019
Wow! Great :)
Thanks for looking into this, but I'm afraid that the problem isn't with backspace/del, but with the cursor positioning, at least for RTL and mixed text.
I actually found this to be a problem in Qt after trying to solve it myself in KTextEditor: https://bugreports.qt.io/browse/QTBUG-65508
Not sure what's the root of the problem :(
Jan 13 2019
Just here for emoticons. We know that removing a feature will lead to a bug report, don't we?
Both Konversation and Choqok are using emotions to display emoji (even thought they are not supported officially anymore in Konvi, but that won't last for long, hopefully).
It is such a small KCM that just makes life easier for the users of those apps, why removing them? I rememberd one of the KDE goals was to implement a global text edit controls that support emoji by default. Even if we don't have that yet, but when we do, we certainly want users to be able to change the icons.
I don't plan to go to Telegram channel to get to know that. I don't need to. KDE uses Phabricator and IRC to be public to everybody and accessible, not private and require softwares and registration.
Jan 6 2019
mmm, sorry. I saw this today and I just took a minute to understand it. How does this looks consistent with the theme, or even nice (really sorry)? Please teach me.
Jan 3 2019
I am using the latest version and I really think that the background in the icon is too light. Like check the other apps (Dolphin, Firefox, KSysGuard, System Settings, etc). They don't use such light colors. Maybe with a bigger version it's fine, but the smaller (much more important and used version) is not.
Thanks for making stuff consistent! :)
Dec 26 2018
Well, basically (please ignore the Arabic/English text changing):
Dec 7 2018
Update based on comments given by bond
Oct 29 2018
tbh, I stopped working on it once I uploaded it. I'll get back to it soon, but need to fix my Linux working machine.
I will most probably change QRectFs to QRects again, and maybe make the comments a bit better.
Then I have to figure out why rendering of the items isn't updated in the moment of showing/hiding the layer.
Oct 28 2018
Oct 7 2018
I think this solved all my issues. I can for meter unit change the formatting so that tr("%1 %2", "no Prefix") is translated to "%1%2" and choose to keep the dot or remove it in the unitStrings translation. ("bit" -> ".bit", "m" -> "m")
By the way, shouldn't that also be the case for English? I don't see people write "1 m" but "1m", "200 B" but "200B", same for Hz, not sure about bits. The space is not there when abbreviation is used.
Sep 29 2018
I came into anther problem, this time with the unit selection.
In Arabic, we don't put a dot between the prefix and the unit if we're talking about meters (mm, cm, km), but we do with other units (k.Byte, M.Byte, G.Byte).
Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen.
Sep 27 2018
I understand that it's entirely up to Krita devs what suits best, but I really think that QQC1 shouldn't be used anymore. It is depracted and replaced by QQC2 (Although the latter is still lacking some stuff).
This is not a comment on this patch specifically, but to the whole QtQuick code in Krita.
Who knows, maybe I work on that one day if no one took the task.. :D
Sep 23 2018
Sep 21 2018
Why not also add icons to other items instead of other X number of commits coming later by Y number of people?
Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one as “group”, like ascending for sorting, center for alignement, etc.
Sep 18 2018
Alright. This changes many manual code to code that is dynamic, easy to understand and to maintain (for both LTR and RTL layouts).
Sep 17 2018
I forgot for a second that you don't need video support. Well I'm not entirely sure if QtAV supports many audio formats, but it depends on ffmpeg which I believe support many. I have very little knowledge here and just wanted to add some info about the existence of QtAV :)
Sep 16 2018
Digikam switched to QtAV once and they said it's better for cross-platform. It also has a QML interface and a similar API to Qt Multimedia. I think you should check that first before VLC.
Sep 8 2018
Sep 7 2018
No changes to “Misc.” from lasst screenshot.
Unique name for spacer (be in the safe side)
Add "General:" and a spacer.
Of course it be great if we can use KPluralHandlingSpinBox, but I am not entirely sure about dependencies and import stuff, so I'll keep this for real developers :)
The label in the Image Properties dialog didn't really change at all.
Sep 6 2018
I thought that this is a feature/cool look :D
Thanks a lot!
Aug 27 2018
This is nice! Let’s not forget that we have applications that have a name with more than 2 words (GIMP, Plasma X Explorer, KMail Import Wizard, and some others.). They aren’t many, but we don’t have any idea about 3rd-party apps. Maybe this is why applications are having horizontal items so the name can fit however long it is.
- Get rid of the name in favorites section and just use the icon.
- Resize sections and give the favorites the biggist area, then narraw down the number of allowed favorites and use a bigger item.
- Use marquee text (up and down) for long names.
Aug 25 2018
Aug 24 2018
Why don't we have a simple search icon that indicates that one can search in the kickoff, and once you click on it you get switched to the search layout, where you'll find a note saying you can also search by direct typing, and a “Got it” as many websites does? Youtube doesn’t force a long search input in the channel page.
Aug 23 2018
The original issue (in Neon/Kubuntu task, not sure) was that Kickoff is not clear if one can search or not, because of text changing. Why not just keeping the current “Type to search” label as is, and move the user@host text up as in the patch?
Aug 21 2018
I'm pretty sure no one uses these buttons if they have an actual mouse, but just the wheel. And I can say that those who use the touchpad don't need to change this (I don't see a usecase where one using his touchpad instead of a proper mouse, will need to change such values that are kept in settings mostly).
Aug 16 2018
I use an old laptop with 1280×800 display (not like you should really count for it, this is old).
Well, I always said that DamnedLies is much better than anything eles (Pootle/Transifex/Weblate/etc), but I think we need to keep normal SVN access available as we have lots of file in KDE that are just few strings, and the whole process of downloading translating uploading for each one will be a huge headache :)
Aug 12 2018
Aug 11 2018
I tried to read about a way to extend the holiday if happened in a weekend day but couldn't find one.
If any day of a holiday happen to be in a Friday or Saturday (Weekend days in Bahrain), the next working day will be a holiday.
Example: Eid ul-Fitr is 3 days, starting from Thursday. It happens on Thursday, Friday, Satarday, Sunday and Monday, where Sunday and Monday are not actually holidays, but they are now so that a holiday is really a day-off and not a usual weekend day.
I'll be done once I solve this for all the holidays in the file.
Aug 10 2018
No unrelated changes
Tbh I don't fully understand the struct and find statments (just saw working similar code and edited-copy-pasted). I prefer if someone can continue this instead of me.
Aug 9 2018
Can we please take a look at this before continuing here?
Aug 7 2018
Yes. As you said, these are symbols. For the names there may be transliterations, the symbols stay the same, to avoid ambiguities. This also matches my experience with datasheets, the text may be chinese, but measurements are given in SI units.
Aug 3 2018
Since this turned already into a discussion, shall we use %Lx version for KF5 libraries using Qt's translation system? I mean in the source text.
Aug 2 2018
Worked great, thanks!
Maybe you should use largeValue instead of largevalue.
But please take an approval from a developer, it worked for me but I have no idea if it can cause any trouble :)
Jul 29 2018
Jul 26 2018
Great! Now I know why the port to PC3 didn't start :D
Now to the patch. First, by this we will allow the user to get text under the icon, which will be impossible to read.
Second is what I'm here for :)
The clear button placement and icon should not follow the locale, but the actual text imh. You can write Arabic in an English system, and vice versa.
Jul 16 2018
I see the problem you are solving, but this is a less optimal solution.
This way the user must change the size with every launch of the app, and this is if he knows how to :) (no to mention he should change the size of both the boxes to match, or it will be ugly looking)
A solution that is used in Linux version is much better (a font setting)
Jul 14 2018
First, sorry for any language mistakes.
Jun 13 2018
Jun 12 2018
Jun 9 2018
Jun 8 2018
Small question, why we're not using QQC2-based controls?
Jun 5 2018
Jun 3 2018
Just saying... :)
May 31 2018
May 30 2018
May 29 2018
Sorry for reaching late.
This is a nice imporovment, it just needs one bit to work with RTL layouts as well :)
Right now, and before this patch, it's being displayed correctly (aligned to right).
May 17 2018
Apr 15 2018
Btw, the qt tag is from Qt3 days. I'm not sure if it must be richtext, if so then a simple html or even KUIT markups are better choice :)
Apr 12 2018
Mar 19 2018
Mar 17 2018
I'd like to thank you all for the work done on supporting SVG and RTL text. This is really appreciated.
Feb 25 2018
Feb 19 2018
Now since I'm a reviewer, sure :)
Feb 16 2018
Although this is really unlikly to happen, a widget having a combobox, but this is the case of Latte where the whole config overlay is just a MouseArea.
I've done some more testing and read some Qt docs. Popup item get reparented to the window once displayed, so LayoutMirroring is applied to it only at that point (applying it to the contentItem).
So my comments above about Popup not inheerting Item are wrong, sorry.
I'm still not sure if this is needed really.
Feb 15 2018
+1 and placeholders