Cool! Thank you.

That's not a bad icon, but again, I think we owe it to the app developers to be as true to the original icon as possible. That text-origami-bird icon is cool, but it has nothing to do with Kate's original icon. The HIG specifically recommends against this:

Hmm, that looks more like a mail application ;=)
As Tyson is already working on something, but at the moment has not much time, I would tend to just keep Kate's icon as is and look at the final stuff Tyson provides first.
Otherwise I think that is a bit unfair.

Nope, it's a CMake setting, default is OFF, ECM sets it to ON. So this is actually still relevant and in use.

Or let's just get it in. It's a small change and we still have the beta phase to test it.

Ok, you need this for 5.17?

I am sorry, I forgot to use --verbatim, please remove the line about directoriesForCanonicalPath() returning const from the commit message :/

Problem with the new design if you ask me is that it does not convey the information that you can roll around past the maximum as in a circle anymore.
All other widget styles (except now breeze), use a circle metaphor for a dial ... Personally I think the new look just looks ... broken. It looks like a bent scrollbar, (or a bent slider), which a dial is not ...

Would something like this being enough for Kate i.e. an origami bird made of current icon paper?

If found no other usage/documenation of BUILD_SHARED_LIBS, so I concluded this is some left-over from older (more promising) times?

In D23849#534126, @romangg wrote:

Thanks for the patch Jason. So the GSendStr(nullptr) is called on m_password.isNull() because this aborts the current PAM session? If this is correct, patch looks good to me.

Haha that's lucky!

OK, understood. But why did it happen that no frame has been captured? Was it due to the case that as soon as it would have been there turn to be started, they already hit their altitude or twilight limit, right?

Yes, the first job started, proceeded to focus, but in the meantime altitude got under 15°, at 14.6°, and the job aborted (completed).
The second job started at that moment, but immediately saw that its altitude was lower than 15° (I think), and aborted too (completed).

In D23849#534126, @romangg wrote:

Thanks for the patch Jason. So the GSendStr(nullptr) is called on m_password.isNull() because this aborts the current PAM session? If this is correct, patch looks good to me.

Updated.

Updating D24048: Inline styles from k.o/products moved to aether-sass

In D24060#534122, @dfaure wrote:

Does this break source compatibility with code currently doing Q_DECLARE_METATYPE(KColorScheme) already?

Thanks for the patch Jason. So the GSendStr(nullptr) is called on m_password.isNull() because this aborts the current PAM session? If this is correct, patch looks good to me.

I think instead of "Use Plasma to surf the web; keep in touch with colleagues, friends and family; manage your files, enjoy music and videos; and get creative and productive at work. Do it all in a beautiful environment that adapts to your needs, and with the safety, privacy-protection and peace of mind that the best Free Open Source Software has to offer." Need to make like in Zorin OS site "Your computer. + switching text"

There seems to be an overlap with this task: https://phabricator.kde.org/T6842

Please see https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/10/console

Does this break source compatibility with code currently doing Q_DECLARE_METATYPE(KColorScheme) already?

Right. Better messages (where needed) and more translations, will have to be done in Qt anyway.

In T10243#201347, @filipf wrote:

In T10243#201303, @ngraham wrote:

Yeah, an app's icon is a part of its branding. It should look distinctive, not generic. Ideally it communicates both its purpose ("I'm a text editor!") as well as its identity ("I'm Kate!"). I think the problem with some of these icons is that they only do the former, not the latter. I don't think there is a conflict here, though!

This seems like the crux of the issue to me, I don't think it's that much about the flat vs. skeuo debate.

Some icons listed here are distinguishable, still do a decent job in terms of branding, and would maybe only benefit from a little tweaking (e.g. Gwenview). But others such as the Okular, Konsole, Kate, KWrite, Yakuake, and the previous version of the Kolf icon look somewhat generic to me.

In T10243#201341, @alex-l wrote:

Here there is an example of brand artwork using that diagonal shape for Konsole:

Edit: to be honest I think this is both distinctive and descriptive:

In T10243#201303, @ngraham wrote:

Yeah, an app's icon is a part of its branding. It should look distinctive, not generic. Ideally it communicates both its purpose ("I'm a text editor!") as well as its identity ("I'm Kate!"). I think the problem with some of these icons is that they only do the former, not the latter. I don't think there is a conflict here, though!

for future releases:
https://invent.kde.org/kde/okular/commit/8ca6b85c24d1a1fe3695a17dc2b4a5cfc7705fda

With the new "Release Service" idea, we're basically giving back part of the promo to apps and letting the promo people actually focus on "the important apps", whatever those are :D

In ReplyStrategyTest:

• initTestCase() deletes emailidentities and emaildefaults, not .qttest.
• uses reference parameters.
• corrected coding style.

Here there is an example of brand artwork using that diagonal shape for Konsole:

OK, understood. But why did it happen that no frame has been captured? Was it due to the case that as soon as it would have been there turn to be started, they already hit their altitude or twilight limit, right?

What do you think about this kind of icon? This one is for Discover: the puzzle pieces indicate apps and other addons, the triangles the packages that ship the apps and the ">" shape looks like Plasma logo.

In D23849#532568, @zzag wrote:

@jfranklin Ping me if you don't get any feedback in a day or two.

Yeah, the issue I haven't mentioned is that those jobs are marked completed without any frame captured, so the behavior is not correct. I believe that setting those as ABORTED would have been OK : in the case of my mosaic, there's no problem retrying the job at the end of the queue, or "immediately", here rescheduled at a valid time.

In T10243#201336, @starbuck wrote:

Maybe look forward for this then for Plasma 6?