Differential D24038

Improve output enablement recovery and config write
ClosedPublic
Actions

Authored by romangg on Sep 17 2019, 11:22 PM.

Details

Reviewers

None

Group Reviewers

Plasma

Commits

R104:936d28ce8fca: Improve output enablement recovery and config write

Summary

Remember or calculate position and mode size after an output has been enabled
again. Additionally on disable do write back the last working output config
to the config file but not to the global one.

Test Plan

Tested on Wayland and X11.

Diff Detail

Repository

R104 KScreen

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Sep 17 2019, 11:22 PM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 17 2019, 11:22 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg requested review of this revision.Sep 17 2019, 11:22 PM

Harbormaster completed remote builds in B16717: Diff 66349.Sep 17 2019, 11:22 PM

romangg added a dependency: D24037: Add enforced mode size getter.Sep 17 2019, 11:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2019, 6:28 PM

Closed by commit R104:936d28ce8fca: Improve output enablement recovery and config write (authored by romangg). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcm/config_handler.cpp (21 lines)
M			kcm/output_model.h (7 lines)
M			kcm/output_model.cpp (90 lines)
M			kded/config.cpp (54 lines)
M			kded/output.h (3 lines)
M			kded/output.cpp (40 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66349	7efeabc		Sep 17 2019, 11:22 PM	★	★
Diff 2	66404	fc8fbbf	R104:936d28ce8fcaf861e4a126b0e7550f68c49daa82	Sep 18 2019, 6:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9c97ac9092cf	e8d2c197478a	e3c35ce53c86	Roman Gilg	Do not override old config values on disable	Sep 17 2019, 11:06 PM
e3c35ce53c86	091f5f552011	7efeabc5b4ac	Roman Gilg	Fix output enablement	Sep 17 2019, 11:05 PM