It bothered me that the groove for dials doesn't match the maximum area that the contents can use.
Details
Details
- Reviewers
ngraham - Group Reviewers
VDG Breeze - Commits
- R31:8e63d4509267: Make renderDialGroove() area match the maximum renderDialContents() area
Old:
New:
Diff Detail
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Doesn't this mean that the visual appearance of the dial will change depending on what the maximum value is?
Comment Actions
No, you can apply this patch and apply whatever maximum value you want to a dial in Qt Designer and the appearance will be the same. This is because the minimum and maximum values are converted to degrees. The only thing that will change is the number of steps that the handle can stop at.
Comment Actions
Problem with the new design if you ask me is that it does not convey the information that you can roll around past the maximum as in a circle anymore.
All other widget styles (except now breeze), use a circle metaphor for a dial ... Personally I think the new look just looks ... broken. It looks like a bent scrollbar, (or a bent slider), which a dial is not ...
Comment Actions
on the other hand, after checking that the dials keep the old appearance when "wrapping" is turned on, and since dials are rather seldom used anyway, I have no strong feeling against the change (still prefer the old look though)