wreissenberger (Wolfgang Reissenberger)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 16 2018, 6:19 AM (31 w, 1 d)
Availability
Available

Recent Activity

Fri, Feb 1

wreissenberger added a comment to D18235: Meridian flips handled by Mount.

Selecting checkbox in the Capture tab alone is not sufficient, the Mount Tab checkbox must be selected too, Right?

At the end, the values on the Mount tab count. But when you start an imaging session from the Capture tab, the values from the Capture tab are forwarded to the Mount tab and overwrite the settings there.

The fact that we have two places whith meridian cflip checkbox and setpoint is a bit confusing to me and will probably raise many questions by other users later on, but this is a cosmetic thing, the code works!

Agreed. I would prefer shifting it from the Capture tab to the Scheduler tab, since the Scheduler contains data of other tabs as well. But I do not want to make the steps too big.

I did not see the meridian flip beeing forwarded from capture to mount tab, I still had one value in capture tab and another in mount tab, and the value in mount tab is the one that triggered the flip. Is my interpretation correct?

The value from the Capture tab is not forwarded immediately when changing the values on the Capture tab but they change, when you press the "Start" button on the Capture tab.

Fri, Feb 1, 5:02 PM · KDE Edu
wreissenberger added a comment to D18235: Meridian flips handled by Mount.

I just checked the changes and confirm it is running as expected (tests 1 to 4)

Great, many thanks!

I noticed that the capture.ui still contains "Meridian Flip if HA" input field and interfers with the field in the mount tab when capture sequence is started.

That's left there intentionally so that imaging sequences can hold meridian flip parameters. As soon as an imaging sequence is started, its meridian flip setup is forwarded to the Mount tab.

Fri, Feb 1, 6:18 AM · KDE Edu

Thu, Jan 31

wreissenberger updated the summary of D18235: Meridian flips handled by Mount.
Thu, Jan 31, 8:56 PM · KDE Edu
wreissenberger added a comment to D18235: Meridian flips handled by Mount.

D18627 requires attention. Is it compatible/complementary/unnecessary with this diff?

Thu, Jan 31, 6:25 PM · KDE Edu
wreissenberger updated the diff for D18235: Meridian flips handled by Mount.

I think we come close to a version that could be integrated into the master.

  • Postponing meridian flip added when mount is not tracking
  • Cosmetic change: meridian flip text message box spans two columns
Thu, Jan 31, 5:51 PM · KDE Edu

Tue, Jan 29

wreissenberger updated the diff for D18235: Meridian flips handled by Mount.

Bug fix for post meridian flip alignment

Tue, Jan 29, 8:35 PM · KDE Edu
wreissenberger planned changes to D18235: Meridian flips handled by Mount.

Thanks I just tested this in my observatory. The flip was started, but it got stuck on post-flip alignment. The alignment actually finished OK, but it seems no signal was sent to capture module regarding this. Please check.

Problem confirmed, I'll work on it.

Tue, Jan 29, 8:17 PM · KDE Edu
wreissenberger updated the diff for D18235: Meridian flips handled by Mount.

Next iteration, now with improved handling of stopped tracking during meridian flip.

Tue, Jan 29, 5:41 PM · KDE Edu

Mon, Jan 28

wreissenberger planned changes to D18235: Meridian flips handled by Mount.

Currently, there are problems when you stop tracking. After restarting tracking, the meridian flip is not executed.

Mon, Jan 28, 5:58 PM · KDE Edu

Sun, Jan 27

wreissenberger updated the diff for D18235: Meridian flips handled by Mount.

Meridian limits set when capture starts and not when the imaging sequence
is loaded.

Sun, Jan 27, 9:33 PM · KDE Edu

Sat, Jan 26

wreissenberger added a comment to D18235: Meridian flips handled by Mount.

Is the Meridian control in the mount tab synchronized with the one in the capture type? It seems when I activated (checked) the meridian control in capture, nothing happen to the control in the mount tab.

Not yet to the full extend. Currently it is only propagated from Capture to Mount when a sequence file is loaded.

Sat, Jan 26, 8:24 PM · KDE Edu
wreissenberger updated the diff for D18235: Meridian flips handled by Mount.

Casts changed to static_cast and corrected the base commit.

Sat, Jan 26, 7:12 PM · KDE Edu
wreissenberger updated the diff for D18235: Meridian flips handled by Mount.
  • Manual rebasing through cherry picking
  • Status text for planning pause added
Sat, Jan 26, 6:06 PM · KDE Edu
wreissenberger added a comment to D18235: Meridian flips handled by Mount.

Can you please rebase again? I can't apply the patch now to test.

Sat, Jan 26, 3:51 PM · KDE Edu

Wed, Jan 23

wreissenberger added a comment to D18235: Meridian flips handled by Mount.

There's something I'd like clarified.
First, if the mount is set east of the meridian at an original position, and is not tracking, and we wait long enough that if it was tracking, it would flip. What happens if we then start tracking from that eastern position? Do we get an unneeded and ineffective flip request?

No, we don't. If we stop tracking, the meridian flip state is set back to "none" and nothing happens. As soon as we turn on tracking, a new target position is set. When this target position crosses the meridian, a flip is requested and executed.

Second, if a capture overlaps the meridian flip, I don't readily understand whether the capture is aborted, the flip executed, and the capture restarted, or if the capture continues and delays the flip, potentially for very long.

Nope, that’s why I introduced the request-accept mechanism. The mount requests to execute a flip, as soon as the meridian has been crossed by the given distance. If a capture is ongoing, capture answers with „wait“. As soon as the capture is completed, capture interrupts the sequence and sends an „accept“ to mount. Now mount executes the flip. As soon as the flip is completed, capture continues.

Wed, Jan 23, 10:38 PM · KDE Edu
wreissenberger updated the diff for D18235: Meridian flips handled by Mount.
  • Meridian flip timeout corrected to 2 minutes
Wed, Jan 23, 10:26 PM · KDE Edu
wreissenberger updated the test plan for D18235: Meridian flips handled by Mount.
Wed, Jan 23, 4:50 PM · KDE Edu
wreissenberger added a comment to D18235: Meridian flips handled by Mount.

Ok looks like it's clear tonight, so I'm ready to test it. Do you think you can add the non-tracking case as well today?

Wed, Jan 23, 4:44 PM · KDE Edu
wreissenberger updated the test plan for D18235: Meridian flips handled by Mount.
Wed, Jan 23, 4:43 PM · KDE Edu
wreissenberger updated the diff for D18235: Meridian flips handled by Mount.

diff span corrected

Wed, Jan 23, 4:37 PM · KDE Edu
wreissenberger updated the diff for D18235: Meridian flips handled by Mount.
  • Meridian flip only executed when mount is tracking
Wed, Jan 23, 4:35 PM · KDE Edu
wreissenberger added a comment to D18235: Meridian flips handled by Mount.

Ok looks like it's clear tonight, so I'm ready to test it. Do you think you can add the non-tracking case as well today?

I had it running during the lunar eclipse on Monday and it ran fine. So for normal operations, it should be stable enough to test in in reality.

Wed, Jan 23, 9:32 AM · KDE Edu

Jan 20 2019

wreissenberger updated the diff for D18235: Meridian flips handled by Mount.
  • Meridian flip during paused imaging sequence corrected
  • Meridian flip during capturing sequence corrected
Jan 20 2019, 8:19 PM · KDE Edu
wreissenberger added a comment to D18235: Meridian flips handled by Mount.

OK, I could reproduce the case. The problems occur when tracking is stopped while Mount is in the state FLIP_WAITING. In this case, things get out of order.

Jan 20 2019, 1:23 PM · KDE Edu
wreissenberger updated the test plan for D18235: Meridian flips handled by Mount.
Jan 20 2019, 9:24 AM · KDE Edu
wreissenberger planned changes to D18235: Meridian flips handled by Mount.

I also don't think meridian flip should be done when the mount is NOT tracking.

Jan 20 2019, 9:23 AM · KDE Edu

Jan 19 2019

wreissenberger added a comment to D18235: Meridian flips handled by Mount.

Does this also check if the mount is parked? Because now I'm getting meridian flip attempts with the mount parked! I didn't apply the above patch yet, but under the live system it behaves this way.

Jan 19 2019, 10:16 PM · KDE Edu
wreissenberger updated the test plan for D18235: Meridian flips handled by Mount.
Jan 19 2019, 8:03 PM · KDE Edu
wreissenberger updated the diff for D18235: Meridian flips handled by Mount.

Meridian flip during paused imaging sequence enabled

Jan 19 2019, 7:54 PM · KDE Edu
wreissenberger planned changes to D18235: Meridian flips handled by Mount.

I haven't tested this case yet, but no, there is no check yet. Will be fixed soon...

Jan 19 2019, 7:08 PM · KDE Edu

Jan 18 2019

wreissenberger updated the diff for D18235: Meridian flips handled by Mount.
  • Mount control of meridian flip for schedules added
Jan 18 2019, 9:28 PM · KDE Edu

Jan 16 2019

wreissenberger updated the diff for D18235: Meridian flips handled by Mount.
  • Error handling for failed slew for meridian flip added
  • Mount meridian flip stati renamed to FLIP_... to avoid confusion with Capture flip stages
  • Mount no longer exposes initialHA and currentTarget via D-Bus
Jan 16 2019, 8:44 PM · KDE Edu
wreissenberger added inline comments to D18235: Meridian flips handled by Mount.
Jan 16 2019, 10:38 AM · KDE Edu

Jan 15 2019

wreissenberger planned changes to D18235: Meridian flips handled by Mount.

Many thanks for the feedback, I will issue an update the next days.

Jan 15 2019, 11:18 PM · KDE Edu

Jan 13 2019

wreissenberger added reviewers for D18235: Meridian flips handled by Mount: mutlaqja, TallFurryMan.
Jan 13 2019, 9:36 PM · KDE Edu
wreissenberger requested review of D18235: Meridian flips handled by Mount.
Jan 13 2019, 9:35 PM · KDE Edu

Jan 7 2019

wreissenberger added a comment to D18041: Fixed START_AT jobs disregarded while evaluating, and fixed the update of their score..

I found some minor things while playing around, but nothing serious:

Jan 7 2019, 5:29 PM · KDE Edu

Jan 6 2019

wreissenberger added a reviewer for D18020: Meridian flip issued also when a target is slewed directly without using a schedule: mutlaqja.
Jan 6 2019, 8:44 PM · KDE Edu
wreissenberger added a comment to R321:7c6e9e03a974: Record initialHA after slew is complete. Without this, a premature meridian….

Please visit https://phabricator.kde.org/D18020. This diff should fix the case.

Jan 6 2019, 8:42 PM
wreissenberger requested review of D18020: Meridian flip issued also when a target is slewed directly without using a schedule.
Jan 6 2019, 8:39 PM · KDE Edu
wreissenberger added a comment to R321:7c6e9e03a974: Record initialHA after slew is complete. Without this, a premature meridian….

OK, I already started to create the fix. But it is not that easy, unfortunately.

Jan 6 2019, 10:42 AM

Jan 5 2019

wreissenberger added inline comments to R321:7c6e9e03a974: Record initialHA after slew is complete. Without this, a premature meridian….
Jan 5 2019, 8:47 PM
wreissenberger raised a concern with R321:7c6e9e03a974: Record initialHA after slew is complete. Without this, a premature meridian….

The initialHA is set incorrect in case that the initial HA is east of meridian. See inline comments above.

Jan 5 2019, 7:58 PM
wreissenberger added a comment to D17159: bug fix #400265: meridian flip check before capturing.

Ah, good point, that makes sense. Nevertheless, the current implementation relies on the fact that captures take place.

Jan 5 2019, 6:37 AM · KDE Edu

Dec 29 2018

wreissenberger updated the diff for D17159: bug fix #400265: meridian flip check before capturing.
  • Memory handling for mountInterface corrected
  • Code cleanup, D-Bus method name harmonized
Dec 29 2018, 12:23 PM · KDE Edu
wreissenberger updated the diff for D17159: bug fix #400265: meridian flip check before capturing.

D-Bus excluded for KStars Lite

Dec 29 2018, 9:30 AM · KDE Edu

Dec 28 2018

wreissenberger added a comment to D17159: bug fix #400265: meridian flip check before capturing.

OK, I will put the wrapping #ifdef in SkyPoint.h and SkyPoint.cpp.

Dec 28 2018, 9:27 PM · KDE Edu
wreissenberger added inline comments to D17159: bug fix #400265: meridian flip check before capturing.
Dec 28 2018, 7:58 PM · KDE Edu
wreissenberger updated the diff for D17159: bug fix #400265: meridian flip check before capturing.

Meridian flip check executed before capture started (Update)

Dec 28 2018, 7:53 PM · KDE Edu
wreissenberger added inline comments to D17159: bug fix #400265: meridian flip check before capturing.
Dec 28 2018, 5:08 AM · KDE Edu

Nov 26 2018

wreissenberger updated the diff for D17159: bug fix #400265: meridian flip check before capturing.

Commit range corrected

Nov 26 2018, 7:17 PM · KDE Edu
wreissenberger added inline comments to D17159: bug fix #400265: meridian flip check before capturing.
Nov 26 2018, 7:13 PM · KDE Edu
wreissenberger updated the diff for D17159: bug fix #400265: meridian flip check before capturing.

Exception handling added

Nov 26 2018, 7:12 PM · KDE Edu

Nov 25 2018

wreissenberger added reviewers for D17159: bug fix #400265: meridian flip check before capturing: TallFurryMan, mutlaqja.
Nov 25 2018, 9:01 PM · KDE Edu
wreissenberger requested review of D17159: bug fix #400265: meridian flip check before capturing.
Nov 25 2018, 8:51 PM · KDE Edu

Nov 22 2018

wreissenberger added a comment to D16429: Rewrite of Scheduler planning.

Go ahead and post, I can integrate it to this differential.

et voilà...

Nov 22 2018, 4:42 AM · KDE Edu

Nov 21 2018

wreissenberger added a comment to D16429: Rewrite of Scheduler planning.

I think I found the problem with the selection bug. The function reorderJobs() seems to be buggy and it does not look like a new bug.

Nov 21 2018, 6:19 PM · KDE Edu
wreissenberger requested changes to D16429: Rewrite of Scheduler planning.

With the option "Sort Jobs per Altitude and Priority" enabled, re-sorting in the edit mode leads to a wrong selection in the queue table.

Nov 21 2018, 3:11 PM · KDE Edu

Oct 28 2018

wreissenberger requested changes to D16429: Rewrite of Scheduler planning.

There are some things that do not work correctly:

  1. Select "Sort jobs by Altitude and Priority" and load a schedule with several jobs with priority 10. Now select a sequence for editing and change the priority of a sequence, e.g. first from 10 to 1. In my case, the job jumps on position 1. Up to here everything is fine. If you change it now to 15, it moves down, but the selection does not follow to the new position. In my case, the first line remains highlighted.
  2. Change the option "Sort jobs by Altitude and Priority". No matter in which direction, the Scheduler tab is not updated. If the option is set, the jobs remain unsorted. If the option is not set, the position buttons are disabled.
Oct 28 2018, 3:35 PM · KDE Edu

Oct 11 2018

wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

From I simplicity point of view, I would recommend not introducing this flag, as long as we have the reset buttons. It's meaning might be misinterpreted.
... and it's behavior is different depending on whether the sequence has been freshly loaded or not.

I would agree, but as stated by Jasem, we would lose the use case "Anytime I Press Start, I Want All Jobs Processed" if we don't keep some sort of Remember Job Progress for the Capture module.
And we do see that the option is now different from the one used in the Scheduler.

OK, that's right. But in this case I would make this option directly accessible (and visible) in the Capture tab. All options in the Options tab bear the risk of being forgotten.

Oct 11 2018, 4:38 AM · KDE Edu

Oct 10 2018

wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

... and it's behavior is different depending on whether the sequence has been freshly loaded or not.

Oct 10 2018, 1:45 PM · KDE Edu
wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

From a Capture perspective this sounds reasonable and very comfortable.

Oct 10 2018, 1:42 PM · KDE Edu
wreissenberger added a comment to D15937: Do not alter the state of the Scheduler while evaluating.

Sorry for the late response, looks good. One tiny thing: when changing list positions, evaluate... is multiply called. In all other situations I tested, it’s called only once.

Oct 10 2018, 10:34 AM · KDE Edu

Oct 9 2018

wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

Sorry for the distraction :-)
I meanwhile use the scheduler excessively and I have a lot of features in mind... But let's concentrate on making it stable as fast as possible.

Oct 9 2018, 11:03 AM · KDE Edu
wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

I agree with @TallFurryMan, Capture and Scheduler should not overlap in terms of control logics. We should keep Capture as simple as possible and leave all history stuff to Scheduler.

Oct 9 2018, 8:19 AM · KDE Edu
wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

Sorry, Eric, but arc patch complains about missing commit a651bd7ee7ba7ebba7e40f5b263021d534db14b6. It is neither in your repository nor in the main one (at least I cannot find it).

Oct 9 2018, 7:35 AM · KDE Edu

Oct 4 2018

wreissenberger added a comment to D15837: Fix for the Dome interface.

Just an idea: is it possible, that the correct name is parkingStatus?

Oct 4 2018, 9:24 AM · KDE Edu

Oct 3 2018

wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Looks good, my tests succeeded. Excellent, this feature is very helpful!!

Oct 3 2018, 8:53 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Hi Eric,
I get an error message from arc patch

arc patch D14942
Created and checked out branch arcpatch-D14942.

    This diff is against commit 018f6986f3887648a6f31f0597de063a53a92675, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (40d75559189dabe735a9f9e55c0641ba86a58ef7)

Should I continue or otherwise where could I get the missing commit? It does not seem to exist in the GIT master

I'm sorry I have no idea... Is it that you should fetch the remote server before patching?

Oct 3 2018, 3:16 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Hi Eric,
I get an error message from arc patch

arc patch D14942
Created and checked out branch arcpatch-D14942.
Oct 3 2018, 12:14 PM · KDE Edu
wreissenberger added a comment to D15837: Fix for the Dome interface.

Same situation with the RollOff Simulator. The INDI Control panel shows:

2018-10-03T08:19:51: [INFO] Dome is unparked. 
2018-10-03T08:19:51: [INFO] Roof is open. 
2018-10-03T08:19:41: [INFO] Roll off is unparking... 
2018-10-03T08:19:18: [INFO] Dome is parked.

But the log in the scheduler shows as last entry

2018-10-03T10:19:41 Unparking dome...
Oct 3 2018, 8:22 AM · KDE Edu
wreissenberger added a comment to D15837: Fix for the Dome interface.

OK, re-checked with the latest INDI version. No change.

Oct 3 2018, 8:17 AM · KDE Edu
wreissenberger added a comment to D15837: Fix for the Dome interface.

I use the DomeSimulator working on arcpatch-D15837.

Oct 3 2018, 7:57 AM · KDE Edu

Oct 1 2018

wreissenberger added a comment to D15837: Fix for the Dome interface.

Hm, my differential does not work properly. There are several things:

  1. Simply checking "unpack dome" after cancelling a scheduled job does not help. I need to double click on a job so that the change is recognized.
  2. If I do it like this, the dome simulator unparks the dome and opens the shutter, but the scheduler does not continue. It looks "Checking INDI State 4".
Oct 1 2018, 9:05 PM · KDE Edu

Sep 25 2018

wreissenberger raised a concern with R321:7d1295998fde: Improve timeout behavior for astrometry download with KAuth.

KAuth::Action.setTimeout() requires KF5 Version 5.29. On my Raspberry, I only have 5.28 - resulting into a failed compile.

Sep 25 2018, 11:22 AM

Sep 11 2018

wreissenberger accepted D15388: Do not abort a job that is repeating because it started long ago, that delay is expected..

Ok, checked. I could reproduce it on master and with the patch the message disappeared.

Sep 11 2018, 7:37 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Makes sense, DBUS should have priority.

Sep 11 2018, 11:50 AM · KDE Edu
wreissenberger added a comment to D15388: Do not abort a job that is repeating because it started long ago, that delay is expected..

I’ve seen the messages in my own logfile last night. I ca Test it late this afternoon.

Sep 11 2018, 11:48 AM · KDE Edu

Sep 10 2018

wreissenberger added a comment to D15388: Do not abort a job that is repeating because it started long ago, that delay is expected..

Could you please be a little more specific with the test case? I cannot reproduce it yet.

Sep 10 2018, 3:31 PM · KDE Edu
wreissenberger accepted D15363: Avoid losing completed count when capture was suspended by a guiding deviation..

The pros are that (a) the change is smaller and (b) there is no need to change an API. The cons are that (a) it makes the code more difficult to read and (b) we are talking of three occurrences, only inside of capture.cpp, where two are touched by this diff.

Sep 10 2018, 1:38 PM · KDE Edu
wreissenberger added a comment to D15363: Avoid losing completed count when capture was suspended by a guiding deviation..

Functionally OK, but it is difficult to read. Wouldn't it be better to add a flag to resetStatus() which indicates whether the count should be kept or not?

Sep 10 2018, 7:41 AM · KDE Edu

Sep 9 2018

wreissenberger accepted D15339: Fix mount not unparking after scheduler stops.

Looks good, I could reproduce the problem and checked it being fixed against simulators.

Sep 9 2018, 12:42 PM · KDE Edu

Sep 4 2018

wreissenberger commandeered D14928: Restarting looping schedule continues capturing.

Thanks for your rebasing, Eric!

Sep 4 2018, 3:29 PM · KDE Edu
wreissenberger added a comment to D15230: Fix cache discrepancy when a job is complete..

Looks good, my test cases with the duplicated schedule are running now. Two minor things that I found, but they are not critical:

  • Having two jobs with the same signature both with FINISH_REPEATand the second to run has less cycles than the first one, the second is started and finishes after one iteration. But I think this not a behavior introduced with this fix. Just to be mentioned...

Ah, yes. Probably a regression or a side-effect of an older change. This use case is a bit weird (but possible of course), perhaps we should order duplicates per repeat count?
Also, I'm weighting the possibility to reorder the jobs in the list per startup order, so that it's clearer for the end-user which one will start before the other.

This happens also if you have two identical cycle numbers. The second one starts once and detects after one cycle that it is completed. It seems like there is no check that jobs once scheduled might get completed without a single run.

  • When creating newFramesCountthere is no check whether it already contains the signature to be evaluated. This leads to duplicated calls to getCompletedFiles(). Functionally this is OK, but it makes the check slower.

Agreed. Perhaps I can add a check right now.

OK, checked, working.

Sep 4 2018, 8:06 AM · KDE Edu

Sep 3 2018

wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

OK - already done :-)

Sep 3 2018, 11:19 AM · KDE Edu
wreissenberger accepted D15230: Fix cache discrepancy when a job is complete..

Looks good, my test cases with the duplicated schedule are running now. Two minor things that I found, but they are not critical:

  • Having two jobs with the same signature both with FINISH_REPEATand the second to run has less cycles than the first one, the second is started and finishes after one iteration. But I think this not a behavior introduced with this fix. Just to be mentioned...
  • When creating newFramesCountthere is no check whether it already contains the signature to be evaluated. This leads to duplicated calls to getCompletedFiles(). Functionally this is OK, but it makes the check slower.
Sep 3 2018, 11:18 AM · KDE Edu

Aug 30 2018

wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Well, indeed, the feature name is not so self explanatory. But currently, the flag is not used inside of updateCompletedJobsCount(), right? As far as I understand, it is only used to estimate the duration. Looks like both methods could share a lot of code... OK, it looks like as there is room for improvement Capture.

Aug 30 2018, 8:40 PM · KDE Edu

Aug 29 2018

wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Do we really to consider what happens on the storage? I would simply count a frame if it has been stored successfully. If it disappears at a later stage, why should we care?

Aug 29 2018, 8:03 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

OK, got the point, you are right. But parallel asynchronous jobs - hm. That also adds complexity.

Aug 29 2018, 7:18 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Hm, I think the reason is the strategy how the cache is updated and not a pure invalid cache problem.

Aug 29 2018, 5:40 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

I did some tests, looks good. There is one test that already failed in D14684 and is still present. It might be exotic, but it leads to continuous looping.

The setup is the following: create a schedule with two jobs for the same target with the same sequence job (say 1xLum for example). The first job starts and captures the first frame.

And here is where the problem occurs: now calling Scheduler::updateCompletedJobsCount() detects the one frame, but when evaluating the second job (which did not run yet), the value in the captured frames map is overwritten. This leads to an endless loop of the first job.

Aug 29 2018, 12:40 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Give this test case a try:

Aug 29 2018, 10:58 AM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Another small thing: I observed that the counting update happens only after a single sequence is finished and not after each capture. I guess that's by intention...

Aug 29 2018, 10:51 AM · KDE Edu
wreissenberger accepted D14942: Update job completion counts, and fix regression on job rescheduling..

Agreed, no, this issue should not block. If it's OK for you, I can try to fix it. I know the place where it goes wrong...

Aug 29 2018, 10:49 AM · KDE Edu
wreissenberger requested changes to D14942: Update job completion counts, and fix regression on job rescheduling..

I did some tests, looks good. There is one test that already failed in D14684 and is still present. It might be exotic, but it leads to continuous looping.

Aug 29 2018, 9:15 AM · KDE Edu

Aug 28 2018

wreissenberger accepted D15073: Fix parking engine, and make observatory startup job-centric.

Agreed. The issues I found are not that critical. The only thing that may happen is that a connection loss during shutdown leads to unfinished shutdown of the observatory. This can be fixed in a separate diff.

Aug 28 2018, 8:09 AM · KDE Edu

Aug 27 2018

wreissenberger requested changes to D15073: Fix parking engine, and make observatory startup job-centric.

OK, now the scheduler does not crash any more, if the INDI server is not available during parking. But the scheduler module does not recognize that the job has finished. The "Stop"-button is still active and the spinning wheel on the right side is still running - although the text says "No job running".

Aug 27 2018, 1:50 PM · KDE Edu
wreissenberger added a comment to D14977: Bugfix for #397650 flat creation failed.

OK, I squashed the two commits.

Aug 27 2018, 11:56 AM · KDE Edu
wreissenberger updated the diff for D14977: Bugfix for #397650 flat creation failed.
Bugfix for #397650 flat creation failed
Aug 27 2018, 11:53 AM · KDE Edu
wreissenberger updated the diff for D14977: Bugfix for #397650 flat creation failed.

Bugfix for #397650 flat creation failed (Update)
Retry to submit the correct files.

Aug 27 2018, 8:47 AM · KDE Edu