wreissenberger (Wolfgang Reissenberger)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 16 2018, 6:19 AM (65 w, 2 d)
Availability
Available

Recent Activity

Yesterday

wreissenberger updated the diff for D24528: Weather sensor data graph display.
  • Add the option to clear the sensor data history
  • Bug fixing of the display when no weather or no dome is present
Tue, Oct 15, 9:35 PM · KDE Edu

Sat, Oct 12

wreissenberger planned changes to D24528: Weather sensor data graph display.

Great! now it works just fine. I think the only thing missing is a small clear button to reset all the data.

OK, update will come.

Sat, Oct 12, 9:17 AM · KDE Edu

Fri, Oct 11

wreissenberger added a comment to D24528: Weather sensor data graph display.

I also noticed another issue.. because there is warning, I see count-down.. however, there are no actions to take so why is there a count-down? it counts down to what?

That's not so easy to fix. Will be handled in a separate diff.

Fri, Oct 11, 9:07 PM · KDE Edu
wreissenberger updated the diff for D24528: Weather sensor data graph display.
  • Immediate replot sensor graph after rescaling axes
  • Show graph value as tool tip, display optimization
Fri, Oct 11, 9:05 PM · KDE Edu

Thu, Oct 10

wreissenberger added a comment to D24528: Weather sensor data graph display.

also, I think instead of displaying the tooltip in the graph, it should be like the guide graph in the sense that it displays the reading value @ time. Then it's very useful to know the exact value at a particular time stamp.

Good point, I will do it.

Thu, Oct 10, 8:27 PM · KDE Edu
wreissenberger added a comment to D24528: Weather sensor data graph display.

It seems there is problem when switching between weather parameters, check video below.

Repainting the entire graph happens with a certain delay - I have to investigate this whether it is possible to accelerate it. And I think it makes sense having the 0-line always visible.

Thu, Oct 10, 8:26 PM · KDE Edu

Wed, Oct 9

wreissenberger added a comment to D24528: Weather sensor data graph display.

Here a screenshot of the new graphs:

Wed, Oct 9, 9:46 PM · KDE Edu
wreissenberger requested review of D24528: Weather sensor data graph display.
Wed, Oct 9, 9:39 PM · KDE Edu

Thu, Oct 3

wreissenberger requested changes to D19998: Remove bypass of preliminary steps when no light frames are needed..

... but it needs to rebased manually. @TallFurryMan: I slightly doubt that it is worth the effort...

Thu, Oct 3, 11:55 AM · KDE Edu
wreissenberger added a comment to D19998: Remove bypass of preliminary steps when no light frames are needed..

Hm, indifferent. It does not seem like there is burning request for this feature. So never touch a running system?

Thu, Oct 3, 11:51 AM · KDE Edu
wreissenberger updated the diff for D24232: Hitting a constraint sets a job to IDLE instead of COMPLETE so that it might be restarted later.

Some code cleanup

Thu, Oct 3, 9:01 AM · KDE Edu
wreissenberger planned changes to D24232: Hitting a constraint sets a job to IDLE instead of COMPLETE so that it might be restarted later.

Looks good, I update the commented parts and re-submit the diff.

Thu, Oct 3, 8:44 AM · KDE Edu

Mon, Sep 30

wreissenberger requested changes to D24257: PHD2 Enhancements.

With "receive external guide frames" selected:

  1. pushing the "Capture" button in the Guide module creates an assertion failure in PHD2::captureSingleFrame().
  2. pushing the "Loop" button shows the warning "PHD2 Error: could not start looping", but PHD2 starts looping.
Mon, Sep 30, 1:31 PM · KDE Edu

Sat, Sep 28

wreissenberger added a comment to D24257: PHD2 Enhancements.

We don't really want to be disabling cameras that are connected to Ekos unless they are actually being used in PHD2 as a guide camera I would think? The images are received and displayed in fits viewer because PHD2 hasn't said that that is the guide camera yet.

Personally, I do not like it when the FITS viewer pops up with the image from the guiding camera - no matter in what state Ekos and PHD2 are. I am not fully aware of all the consequences what happens if it is turned off.

Sat, Sep 28, 10:09 AM · KDE Edu
wreissenberger accepted D24257: PHD2 Enhancements.

Changing to contains method

Fine, that solved the problem. I am using the latest PHD2 version 2.6.6dev2. Maybe they changed something.

Sat, Sep 28, 10:06 AM · KDE Edu

Fri, Sep 27

wreissenberger added inline comments to D24257: PHD2 Enhancements.
Fri, Sep 27, 11:55 PM · KDE Edu
wreissenberger added a comment to D24257: PHD2 Enhancements.

Fixing i18n

Great, thanks! But I now do not understand why this happens:
2019-09-28T01:24:39 PHD2's current camera: INDI Camera [Guide Simulator], is NOT connected to Ekos. It does not need to be connected, the PHD2 Guide Star Image should still be received.
This message always comes when I press "Connect" in the EKOS guiding module.

Fri, Sep 27, 11:30 PM · KDE Edu
wreissenberger added a comment to D24257: PHD2 Enhancements.

One behavior that seems to be new: if PHD2 is not connected to EKOS and PHD2 is looping, the images of the guiding camera are displayed in the FITS viewer. Is there a reason behind or is it simply a bug?

Fri, Sep 27, 11:24 PM · KDE Edu
wreissenberger added a comment to D24257: PHD2 Enhancements.

Looks good! There is one warning that seems to have a problem:
PHD2's current camera: Simulator(I18N_ARGUMENT_MISSING), is NOT connected to Ekos. It does not need to be connected, the PHD2 Guide Star Image should still be received.

Fri, Sep 27, 6:40 PM · KDE Edu

Thu, Sep 26

wreissenberger added a comment to D24151: Summary: Connect Scheduler sleep timer to Simulation Clock scale change..

I do not think it is super necessary. A user who is using KStars for astrophotography normally does not play around with the simulation clock. A message in the log should be a good compromise.

Thu, Sep 26, 8:06 AM · KDE Edu

Wed, Sep 25

wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

Please check D24232, this should hopefully fix the regressions we discussed here.

Wed, Sep 25, 9:27 PM · KDE Edu
wreissenberger requested review of D24232: Hitting a constraint sets a job to IDLE instead of COMPLETE so that it might be restarted later.
Wed, Sep 25, 9:26 PM · KDE Edu
wreissenberger updated the diff for D24064: Handling of aborts during parking/unparking of rolloff roofs corrected.

... hopefully the last i18n

Wed, Sep 25, 4:16 PM · KDE Edu
wreissenberger updated the diff for D24064: Handling of aborts during parking/unparking of rolloff roofs corrected.

... and now also in the dome model.

Wed, Sep 25, 4:10 PM · KDE Edu
wreissenberger updated the diff for D24064: Handling of aborts during parking/unparking of rolloff roofs corrected.

i18n arguments corrected (now hopefully complete)

Wed, Sep 25, 4:05 PM · KDE Edu

Tue, Sep 24

wreissenberger added a comment to D24064: Handling of aborts during parking/unparking of rolloff roofs corrected.

i18n message arguments corrected

Tue, Sep 24, 7:35 PM · KDE Edu
wreissenberger updated the diff for D24064: Handling of aborts during parking/unparking of rolloff roofs corrected.

i18n message for observatory handling corrected

Tue, Sep 24, 7:34 PM · KDE Edu

Mon, Sep 23

wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

OK, I found the problem with hitting a constraint. In this case the Scheduler calls stop() which sets the job to ABORTED. That's explains the behaviour.

Mon, Sep 23, 6:55 AM · KDE Edu

Sat, Sep 21

wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

[2019-09-20T04:54:00.721 EEST INFO ][ org.kde.kstars.ekos.scheduler] - "Job 'NGC1491' is now approaching astronomical twilight rise limit at pe syysk. 20 04:54:00 2019 (0 minutes safety margin), marking aborted."

Looks like at least the log warning is wrong. Assuming that @jpaana has the latest version, that's strange.

Sat, Sep 21, 5:50 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

So we try to set jobs to COMPLETED based on frame count, we make sure we do not touch the frame count except when receiving a frame or recounting storage frames, and we do that state change when starting evaluation only? In other words, we never complete jobs during execution? The problem with states is that we must not jitter between values needlessly. Do you have a state diagram in head?

Let me give a try defining COMPLETED for a sequence job seq_j:

Sat, Sep 21, 9:32 AM · KDE Edu

Fri, Sep 20

wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

I agree. It is a regression from this diff, isn't it?

Well, some kind of. Before my diff, these where set to "aborted", which was also wrong from my perspective.

Fri, Sep 20, 7:19 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

Hm, quite complicated. Has this ever worked? Nevertheless, I think when running multi-day-schedules, I would use "Remember job progress". In that case I think this situation would not happen.

Fri, Sep 20, 6:07 AM · KDE Edu

Thu, Sep 19

wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

Second regression observed minutes ago: when restarting after sleeping, all jobs are re-scheduled, even completed ones. I need to remove the jobs that were completed last night manually, or use Remember job progress.

Thu, Sep 19, 5:48 AM · KDE Edu
wreissenberger added a comment to D23892: Fix HFR calculation, add HFR on focus view, adjust focus UI..

Makes sense?

Good idea, far better!

Thu, Sep 19, 5:00 AM · KDE Edu

Wed, Sep 18

wreissenberger requested review of D24064: Handling of aborts during parking/unparking of rolloff roofs corrected.
Wed, Sep 18, 8:42 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

OK, understood. But why did it happen that no frame has been captured? Was it due to the case that as soon as it would have been there turn to be started, they already hit their altitude or twilight limit, right?

Wed, Sep 18, 5:59 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

When job #12 crossed the altitude restriction at 15° while focusing, it was incorrectly set to completed instead of aborted (KO).
When job #13 crossed the altitude restriction at 14.3° before starting, it was incorrectly set to completed instead of aborted (KO).

That's how it was intended from my side (see our discussion here).
I think I got your point now with the multi-day-schedules. As soon as a job is marked with JOB_COMPLETE, it will not be started the next night when the scheduler keeps running for more than one night.

Wed, Sep 18, 2:51 PM · KDE Edu

Sep 15 2019

wreissenberger accepted D23892: Fix HFR calculation, add HFR on focus view, adjust focus UI..
Sep 15 2019, 2:04 PM · KDE Edu
wreissenberger added a comment to D23892: Fix HFR calculation, add HFR on focus view, adjust focus UI..

Awesome job, Eric!

Sep 15 2019, 2:04 PM · KDE Edu

Sep 11 2019

wreissenberger accepted D23869: Implement customizable dusk and dawn offsets..

Very nice idea, Eric - well done!

Sep 11 2019, 1:31 PM · KDE Edu

Sep 9 2019

wreissenberger updated the test plan for D23805: Restrict pausing to image capturing.
Sep 9 2019, 8:22 PM · KDE Edu
wreissenberger requested review of D23805: Restrict pausing to image capturing.
Sep 9 2019, 8:21 PM · KDE Edu

Sep 5 2019

wreissenberger accepted D23735: Improvements is estimateJobTime.

Aaaah, sorry, I misinterpreted one thing. You're absolutely right, 60sec for aligning makes sense, since it is more than one single astrometry run.

Sep 5 2019, 4:53 PM · KDE Edu, KStars
wreissenberger requested changes to D23735: Improvements is estimateJobTime.

Good idea, Alex. And welcome to the Scheduler-Optimizing-Club :-)

Sep 5 2019, 4:51 PM · KDE Edu, KStars

Sep 3 2019

wreissenberger added a comment to D21879: Location of M 102 corrected.

Thanks, understood. But where does the M102 entry for N5457 come from? In the OpenNGC catalog it's only mentioned in the comment. Same for N5866, by the way.

Sep 3 2019, 6:52 AM · KDE Edu

Sep 2 2019

wreissenberger added a comment to D21879: Location of M 102 corrected.

@cdersch: when I understand OpenNGC right, then they do not contain any Messier names. Where do they come from?

Sep 2 2019, 4:33 PM · KDE Edu
wreissenberger added a comment to D21879: Location of M 102 corrected.

Did Christian answer? I learned meanwhile that it is historically not clear, whether NGC5866 is really the M102 from Messier's catalog.

Sep 2 2019, 7:51 AM · KDE Edu
wreissenberger abandoned D22956: Calculating current HA corrected so that -12 < HA <= 12.

Resolved.

Sep 2 2019, 7:50 AM · KDE Edu

Sep 1 2019

wreissenberger requested review of D23653: Display of weather sensor data added to Observatory module.
Sep 1 2019, 8:22 PM · KDE Edu

Aug 31 2019

wreissenberger requested review of D23596: Filename options selection preserved.
Aug 31 2019, 4:15 AM · KDE Edu

Aug 27 2019

wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

I‘ve been using it now since several weeks and really appreciate the „restart immediately“ function. I typically have 2-3 different targets per night and it is very handy restarting the aborted job after a cloud e.g passed by. In the past few weeks I had several partially cloudy nights and all worked well.

Aug 27 2019, 3:30 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

ping :-)

Aug 27 2019, 8:49 AM · KDE Edu

Aug 19 2019

wreissenberger requested review of D23258: Bugfix for focus looping with HFR setup.
Aug 19 2019, 10:40 AM · KDE Edu

Aug 7 2019

wreissenberger added inline comments to D22954: Rolloff roof handling introduced.
Aug 7 2019, 8:47 PM · KDE Edu
wreissenberger updated the diff for D22954: Rolloff roof handling introduced.

Proposed code cosmetics added

Aug 7 2019, 8:46 PM · KDE Edu
wreissenberger added a comment to D22956: Calculating current HA corrected so that -12 < HA <= 12.

Jasem, many thanks for the corrections, I wasn't aware of rangeHA. A small hint: is there a reason why you left the old code commented out in the code instead of simply deleting it?

Aug 7 2019, 12:26 AM · KDE Edu

Aug 5 2019

wreissenberger requested review of D22956: Calculating current HA corrected so that -12 < HA <= 12.
Aug 5 2019, 9:00 PM · KDE Edu
wreissenberger requested review of D22954: Rolloff roof handling introduced.
Aug 5 2019, 7:21 PM · KDE Edu

Jul 28 2019

wreissenberger requested review of D22788: Bug fix paused during dithering not resuming.
Jul 28 2019, 7:26 PM · KDE Edu

Jul 23 2019

wreissenberger added inline comments to D22583: Autofocus disturbing meridian flip corrected.
Jul 23 2019, 7:39 PM · KDE Edu
wreissenberger added a comment to D22583: Autofocus disturbing meridian flip corrected.

Ping :-)

Jul 23 2019, 5:46 PM · KDE Edu

Jul 22 2019

wreissenberger added a comment to D22651: Show the tracking box on the inital focusing frame.

Select "Sub Frame" and "Auto Select Star". Set "Box Size" to a small value, e.g. 128. Then start "Autofocus". Without this fix, the green box should be in the top left corner of the full frame image. With the fix, it is around the focus star.

Jul 22 2019, 3:36 PM · KDE Edu
wreissenberger requested review of D22651: Show the tracking box on the inital focusing frame.
Jul 22 2019, 2:55 PM · KDE Edu

Jul 21 2019

wreissenberger updated the diff for D22437: Check for refocus also during the calibration stage.

Re-focusing before capturing reworked, focusing states removed from calibration stages

Jul 21 2019, 7:30 PM · KDE Edu

Jul 20 2019

wreissenberger updated the summary of D22583: Autofocus disturbing meridian flip corrected.
Jul 20 2019, 4:12 PM · KDE Edu
wreissenberger added inline comments to D22583: Autofocus disturbing meridian flip corrected.
Jul 20 2019, 1:58 PM · KDE Edu
wreissenberger requested review of D22583: Autofocus disturbing meridian flip corrected.
Jul 20 2019, 1:54 PM · KDE Edu

Jul 17 2019

wreissenberger added a comment to D22437: Check for refocus also during the calibration stage.

Sorry, the description is misleading, the focus check is added to startNextExposure(). This is exactly the same place where I added the meridian flip check, where we had the same problem.

Jul 17 2019, 7:44 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

Update to the discussion regarding aborted jobs and limits.

Jul 17 2019, 12:02 PM · KDE Edu

Jul 14 2019

wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

Serialization changed as suggested, log messages corrected. Now we need to agree how to proceed with the problem, that restarting aborted jobs immediately conflicts with the idea of having multi-day schedules.

Jul 14 2019, 8:09 PM · KDE Edu
wreissenberger updated the diff for D22446: Adding error handling strategy control to Scheduler.

Serializing error strategy corrected, log messages for aborted jobs unified

Jul 14 2019, 8:02 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

We need to decide whether we want the scheduler to be able handling multi-day schedules (as currently, without this change) or being able to restart immediately aborted jobs. The latter is important for a robust scheduling during nights with some clouds, where a job gets aborted, but may be continue, as soon as the cloud has passed by.

Jul 14 2019, 2:27 PM · KDE Edu
wreissenberger planned changes to D22446: Adding error handling strategy control to Scheduler.

Many thanks for your comments. I will think about them and come back.

Jul 14 2019, 9:51 AM · KDE Edu

Jul 13 2019

wreissenberger accepted D22391: When evaluating twilight restriction, shift dusk to next day when it happens before dawn on the same day..

Works as described, good point!

Jul 13 2019, 8:03 PM · KDE Edu
wreissenberger requested review of D22446: Adding error handling strategy control to Scheduler.
Jul 13 2019, 7:17 PM · KDE Edu
wreissenberger requested review of D22437: Check for refocus also during the calibration stage.
Jul 13 2019, 1:24 PM · KDE Edu

Jul 10 2019

wreissenberger accepted D22380: Reset autofocus when executing a job, so that focus step is applied properly when checked..

Makes sense, good point!

Jul 10 2019, 8:48 PM · KDE Edu

Jul 2 2019

wreissenberger added a comment to D22224: Motion control for domes added.

Hope it's like you meant.

Jul 2 2019, 9:12 PM · KDE Edu
wreissenberger updated the diff for D22224: Motion control for domes added.
  • canRelativeMove added as D-Bus property
  • String formatting improved
Jul 2 2019, 9:11 PM · KDE Edu
wreissenberger requested review of D22224: Motion control for domes added.
Jul 2 2019, 8:24 PM · KDE Edu

Jun 23 2019

wreissenberger requested review of D22013: Bug fix for capture pausing and meridian flips.
Jun 23 2019, 6:44 AM · KDE Edu

Jun 19 2019

wreissenberger requested review of D21914: Do not abort PHD2 guiding while suspended.
Jun 19 2019, 6:34 PM · KDE Edu

Jun 18 2019

wreissenberger requested review of D21879: Location of M 102 corrected.
Jun 18 2019, 10:07 AM · KDE Edu

Jun 11 2019

wreissenberger added a comment to D21739: Make guiding more robust.

I am primarily working with PHD2. I've tested #1 also with the internal guider, it showed the same problem as PHD2 and should be fixed. #2 is PHD2 specific and #3 should work with all guiders.

Jun 11 2019, 7:22 AM · KDE Edu

Jun 10 2019

wreissenberger updated the summary of D21739: Make guiding more robust.
Jun 10 2019, 9:43 PM · KDE Edu
wreissenberger requested review of D21739: Make guiding more robust.
Jun 10 2019, 9:41 PM · KDE Edu

Jun 3 2019

wreissenberger added a comment to D21531: Bug fix in Scheduler for pausing after capturing sequence.

Hi Eric,
no problem, I not made out of sugar :-)
Indeed, I think this feature makes sense - exactly as you described it. Pausing - for example arranging cabling or testing a better guiding setup - makes sense. My typical setup is shooting LLLRGB sequences. When I have the ability to pause in order to fix something and capturing continues exactly the place where I paused, this would be nice to have (but maybe not more).

Jun 3 2019, 6:29 PM · KDE Edu
wreissenberger added a comment to D21291: Observatory module with basic dome and weather handling created.

Many thanks, so let's start the feature branch. As a next step I would like to discuss with you the interaction of Observatory and Scheduler.

Jun 3 2019, 9:08 AM · KDE Edu
wreissenberger added a comment to D21531: Bug fix in Scheduler for pausing after capturing sequence.

Eric, please be so kind and test the pause button on the current master without this diff. There you will see that after pressing the button a) the Scheduler waits for a capture sequence to complete and b) when you press the "Start/Resume" button after the sequence completion, nothing happens.

Jun 3 2019, 9:03 AM · KDE Edu

Jun 2 2019

wreissenberger added a comment to D21531: Bug fix in Scheduler for pausing after capturing sequence.

I guess you do not mean the bug fix part. For this the use case is very simple: "I want it working :-)"

Jun 2 2019, 2:13 PM · KDE Edu
wreissenberger requested review of D21531: Bug fix in Scheduler for pausing after capturing sequence.
Jun 2 2019, 7:37 AM · KDE Edu

May 29 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Checkboxes for weather status actions implemented

May 29 2019, 10:57 PM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Ready-button deactivated, showing only the status

May 29 2019, 8:33 PM · KDE Edu
wreissenberger added a comment to D21073: Impact of scheduler settings on total imaging time corrected.

ping :-)

May 29 2019, 11:54 AM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Switched to branch observatory_work

May 29 2019, 10:48 AM · KDE Edu

May 26 2019

wreissenberger added a comment to D21291: Observatory module with basic dome and weather handling created.

From my perspective, we could start now with the feature branch. Currently, the Observatory is standalone. As a next step, I would like to implement the interaction with the Scheduler, but this should be handled in a separate diff.

May 26 2019, 12:26 PM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Make observatory ready with one mouse click

May 26 2019, 6:35 AM · KDE Edu

May 25 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Observatory status added

May 25 2019, 10:17 PM · KDE Edu

May 24 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.
  • Shutter actions invisible if no shutter present
  • Measurement of delay in secs
  • Scheduler actions prepared, but left invisible
May 24 2019, 4:15 AM · KDE Edu

May 22 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Action check box for stopping the scheduler added (not implemented)

May 22 2019, 9:00 PM · KDE Edu