wreissenberger (Wolfgang Reissenberger)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 16 2018, 6:19 AM (57 w, 5 d)
Availability
Available

Recent Activity

Mon, Aug 19

wreissenberger requested review of D23258: Bugfix for focus looping with HFR setup.
Mon, Aug 19, 10:40 AM · KDE Edu

Wed, Aug 7

wreissenberger added inline comments to D22954: Rolloff roof handling introduced.
Wed, Aug 7, 8:47 PM · KDE Edu
wreissenberger updated the diff for D22954: Rolloff roof handling introduced.

Proposed code cosmetics added

Wed, Aug 7, 8:46 PM · KDE Edu
wreissenberger added a comment to D22956: Calculating current HA corrected so that -12 < HA <= 12.

Jasem, many thanks for the corrections, I wasn't aware of rangeHA. A small hint: is there a reason why you left the old code commented out in the code instead of simply deleting it?

Wed, Aug 7, 12:26 AM · KDE Edu

Mon, Aug 5

wreissenberger requested review of D22956: Calculating current HA corrected so that -12 < HA <= 12.
Mon, Aug 5, 9:00 PM · KDE Edu
wreissenberger requested review of D22954: Rolloff roof handling introduced.
Mon, Aug 5, 7:21 PM · KDE Edu

Sun, Jul 28

wreissenberger requested review of D22788: Bug fix paused during dithering not resuming.
Sun, Jul 28, 7:26 PM · KDE Edu

Jul 23 2019

wreissenberger added inline comments to D22583: Autofocus disturbing meridian flip corrected.
Jul 23 2019, 7:39 PM · KDE Edu
wreissenberger added a comment to D22583: Autofocus disturbing meridian flip corrected.

Ping :-)

Jul 23 2019, 5:46 PM · KDE Edu

Jul 22 2019

wreissenberger added a comment to D22651: Show the tracking box on the inital focusing frame.

Select "Sub Frame" and "Auto Select Star". Set "Box Size" to a small value, e.g. 128. Then start "Autofocus". Without this fix, the green box should be in the top left corner of the full frame image. With the fix, it is around the focus star.

Jul 22 2019, 3:36 PM · KDE Edu
wreissenberger requested review of D22651: Show the tracking box on the inital focusing frame.
Jul 22 2019, 2:55 PM · KDE Edu

Jul 21 2019

wreissenberger updated the diff for D22437: Check for refocus also during the calibration stage.

Re-focusing before capturing reworked, focusing states removed from calibration stages

Jul 21 2019, 7:30 PM · KDE Edu

Jul 20 2019

wreissenberger updated the summary of D22583: Autofocus disturbing meridian flip corrected.
Jul 20 2019, 4:12 PM · KDE Edu
wreissenberger added inline comments to D22583: Autofocus disturbing meridian flip corrected.
Jul 20 2019, 1:58 PM · KDE Edu
wreissenberger requested review of D22583: Autofocus disturbing meridian flip corrected.
Jul 20 2019, 1:54 PM · KDE Edu

Jul 17 2019

wreissenberger added a comment to D22437: Check for refocus also during the calibration stage.

Sorry, the description is misleading, the focus check is added to startNextExposure(). This is exactly the same place where I added the meridian flip check, where we had the same problem.

Jul 17 2019, 7:44 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

Update to the discussion regarding aborted jobs and limits.

Jul 17 2019, 12:02 PM · KDE Edu

Jul 14 2019

wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

Serialization changed as suggested, log messages corrected. Now we need to agree how to proceed with the problem, that restarting aborted jobs immediately conflicts with the idea of having multi-day schedules.

Jul 14 2019, 8:09 PM · KDE Edu
wreissenberger updated the diff for D22446: Adding error handling strategy control to Scheduler.

Serializing error strategy corrected, log messages for aborted jobs unified

Jul 14 2019, 8:02 PM · KDE Edu
wreissenberger added a comment to D22446: Adding error handling strategy control to Scheduler.

We need to decide whether we want the scheduler to be able handling multi-day schedules (as currently, without this change) or being able to restart immediately aborted jobs. The latter is important for a robust scheduling during nights with some clouds, where a job gets aborted, but may be continue, as soon as the cloud has passed by.

Jul 14 2019, 2:27 PM · KDE Edu
wreissenberger planned changes to D22446: Adding error handling strategy control to Scheduler.

Many thanks for your comments. I will think about them and come back.

Jul 14 2019, 9:51 AM · KDE Edu

Jul 13 2019

wreissenberger accepted D22391: When evaluating twilight restriction, shift dusk to next day when it happens before dawn on the same day..

Works as described, good point!

Jul 13 2019, 8:03 PM · KDE Edu
wreissenberger requested review of D22446: Adding error handling strategy control to Scheduler.
Jul 13 2019, 7:17 PM · KDE Edu
wreissenberger requested review of D22437: Check for refocus also during the calibration stage.
Jul 13 2019, 1:24 PM · KDE Edu

Jul 10 2019

wreissenberger accepted D22380: Reset autofocus when executing a job, so that focus step is applied properly when checked..

Makes sense, good point!

Jul 10 2019, 8:48 PM · KDE Edu

Jul 2 2019

wreissenberger added a comment to D22224: Motion control for domes added.

Hope it's like you meant.

Jul 2 2019, 9:12 PM · KDE Edu
wreissenberger updated the diff for D22224: Motion control for domes added.
  • canRelativeMove added as D-Bus property
  • String formatting improved
Jul 2 2019, 9:11 PM · KDE Edu
wreissenberger requested review of D22224: Motion control for domes added.
Jul 2 2019, 8:24 PM · KDE Edu

Jun 23 2019

wreissenberger requested review of D22013: Bug fix for capture pausing and meridian flips.
Jun 23 2019, 6:44 AM · KDE Edu

Jun 19 2019

wreissenberger requested review of D21914: Do not abort PHD2 guiding while suspended.
Jun 19 2019, 6:34 PM · KDE Edu

Jun 18 2019

wreissenberger requested review of D21879: Location of M 102 corrected.
Jun 18 2019, 10:07 AM

Jun 11 2019

wreissenberger added a comment to D21739: Make guiding more robust.

I am primarily working with PHD2. I've tested #1 also with the internal guider, it showed the same problem as PHD2 and should be fixed. #2 is PHD2 specific and #3 should work with all guiders.

Jun 11 2019, 7:22 AM · KDE Edu

Jun 10 2019

wreissenberger updated the summary of D21739: Make guiding more robust.
Jun 10 2019, 9:43 PM · KDE Edu
wreissenberger requested review of D21739: Make guiding more robust.
Jun 10 2019, 9:41 PM · KDE Edu

Jun 3 2019

wreissenberger added a comment to D21531: Bug fix in Scheduler for pausing after capturing sequence.

Hi Eric,
no problem, I not made out of sugar :-)
Indeed, I think this feature makes sense - exactly as you described it. Pausing - for example arranging cabling or testing a better guiding setup - makes sense. My typical setup is shooting LLLRGB sequences. When I have the ability to pause in order to fix something and capturing continues exactly the place where I paused, this would be nice to have (but maybe not more).

Jun 3 2019, 6:29 PM · KDE Edu
wreissenberger added a comment to D21291: Observatory module with basic dome and weather handling created.

Many thanks, so let's start the feature branch. As a next step I would like to discuss with you the interaction of Observatory and Scheduler.

Jun 3 2019, 9:08 AM · KDE Edu
wreissenberger added a comment to D21531: Bug fix in Scheduler for pausing after capturing sequence.

Eric, please be so kind and test the pause button on the current master without this diff. There you will see that after pressing the button a) the Scheduler waits for a capture sequence to complete and b) when you press the "Start/Resume" button after the sequence completion, nothing happens.

Jun 3 2019, 9:03 AM · KDE Edu

Jun 2 2019

wreissenberger added a comment to D21531: Bug fix in Scheduler for pausing after capturing sequence.

I guess you do not mean the bug fix part. For this the use case is very simple: "I want it working :-)"

Jun 2 2019, 2:13 PM · KDE Edu
wreissenberger requested review of D21531: Bug fix in Scheduler for pausing after capturing sequence.
Jun 2 2019, 7:37 AM · KDE Edu

May 29 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Checkboxes for weather status actions implemented

May 29 2019, 10:57 PM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Ready-button deactivated, showing only the status

May 29 2019, 8:33 PM · KDE Edu
wreissenberger added a comment to D21073: Impact of scheduler settings on total imaging time corrected.

ping :-)

May 29 2019, 11:54 AM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Switched to branch observatory_work

May 29 2019, 10:48 AM · KDE Edu

May 26 2019

wreissenberger added a comment to D21291: Observatory module with basic dome and weather handling created.

From my perspective, we could start now with the feature branch. Currently, the Observatory is standalone. As a next step, I would like to implement the interaction with the Scheduler, but this should be handled in a separate diff.

May 26 2019, 12:26 PM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Make observatory ready with one mouse click

May 26 2019, 6:35 AM · KDE Edu

May 25 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Observatory status added

May 25 2019, 10:17 PM · KDE Edu

May 24 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.
  • Shutter actions invisible if no shutter present
  • Measurement of delay in secs
  • Scheduler actions prepared, but left invisible
May 24 2019, 4:15 AM · KDE Edu

May 22 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Action check box for stopping the scheduler added (not implemented)

May 22 2019, 9:00 PM · KDE Edu
wreissenberger added a comment to D21291: Observatory module with basic dome and weather handling created.

Et voilà.

May 22 2019, 6:53 PM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Observatory windows title set to Observatory

May 22 2019, 6:52 PM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Execute actions for weather warnings and alerts

May 22 2019, 5:28 PM · KDE Edu
wreissenberger updated the summary of D21291: Observatory module with basic dome and weather handling created.
May 22 2019, 8:13 AM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Taking actions due to weather warnings or alerts implemented

May 22 2019, 8:12 AM · KDE Edu

May 20 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.
  • Handling disconnects for weather and dome added
  • UI elements for observatory actions and status added - not implemented yet
May 20 2019, 5:21 PM · KDE Edu
wreissenberger added a comment to D21291: Observatory module with basic dome and weather handling created.

Currently, the interference with with other modules isn't that heavy, so technically it is not necessary. Nevertheless, I would prefer a feature branch so that we can launch the module with a mature set of functionality.

May 20 2019, 7:12 AM · KDE Edu

May 19 2019

wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

Tool tips added to the Observatory module

May 19 2019, 8:30 PM · KDE Edu
wreissenberger updated the diff for D21291: Observatory module with basic dome and weather handling created.

D-Bus interface added.

May 19 2019, 8:05 PM · KDE Edu
wreissenberger requested review of D21291: Observatory module with basic dome and weather handling created.
May 19 2019, 1:25 PM · KDE Edu

May 15 2019

wreissenberger updated the summary of D21222: Meridian flip control removed from Capture module.
May 15 2019, 6:34 AM · KDE Edu
wreissenberger requested review of D21222: Meridian flip control removed from Capture module.
May 15 2019, 6:31 AM · KDE Edu

May 7 2019

wreissenberger requested review of D21073: Impact of scheduler settings on total imaging time corrected.
May 7 2019, 5:50 PM · KDE Edu

May 5 2019

wreissenberger requested review of D21034: Always check meridian flip before starting next capture.
May 5 2019, 2:25 PM · KDE Edu

May 2 2019

wreissenberger requested review of D20975: Meridian flip state logging extended.
May 2 2019, 9:33 PM · KDE Edu
wreissenberger abandoned D20001: Simplifying Scheduler.

We follow another path with D20068 - closed.

May 2 2019, 6:51 PM · KDE Edu

May 1 2019

wreissenberger closed D19429: Selection of rows in Capture instead of single cells.

Solved in D19456.

May 1 2019, 6:07 PM · KDE Edu
wreissenberger abandoned D14280: Handling multiple occurrence of the same sequence job corrected.

Solved in another diff.

May 1 2019, 6:05 PM
wreissenberger added a comment to D19456: Selection in imaging sequence keeps position after row deletion.

Seems like this is not merged into master.

May 1 2019, 5:48 PM · KDE Edu
wreissenberger added a comment to D20150: Meridian flip checks after capture completion removed.

I think this diff has not been merged yet.

May 1 2019, 5:47 PM · KDE Edu
wreissenberger updated the diff for D19648: Keep GUI parameters for scheduler and capture in sync with row selection.

Update diff after rebase (second try)

May 1 2019, 5:23 PM · KDE Edu
wreissenberger added a comment to D19648: Keep GUI parameters for scheduler and capture in sync with row selection.

Damn, that was wrong! Please wait for another update...

May 1 2019, 6:03 AM · KDE Edu
wreissenberger updated the diff for D19648: Keep GUI parameters for scheduler and capture in sync with row selection.

Rebased upon latest master version.

May 1 2019, 6:02 AM · KDE Edu
wreissenberger added a comment to D19648: Keep GUI parameters for scheduler and capture in sync with row selection.

I'm waiting for Eric's review. I can post a rebased version later if required.

May 1 2019, 5:27 AM · KDE Edu

Apr 21 2019

wreissenberger requested review of D20716: Saving after reordering jobs enabled.
Apr 21 2019, 6:34 PM · KDE Edu

Apr 19 2019

wreissenberger requested review of D20682: Bug fix for calculating required light frames.
Apr 19 2019, 9:11 AM · KDE Edu

Apr 13 2019

wreissenberger added a comment to D20029: Capture counting corrected.

I would opt for 3.2. The behavior is better than without the fix.

Apr 13 2019, 2:18 PM · KDE Edu

Apr 11 2019

wreissenberger added a comment to D20029: Capture counting corrected.

When a scheduler job aborts, it does not change the completed frame count. So probably an in-sequence focus failing might do the job?

Aborting, right, but restarting resets the counters to zero.

Apr 11 2019, 11:46 AM · KDE Edu
wreissenberger added a comment to D20029: Capture counting corrected.

Back to the original question, how to proceed. I tried to construct a situation where the calculation of captured frames is call after the partial completion of a scheduler job where exactly that problem occurs we discussed above - I failed, I could not bring kstars into such a state. So maybe we have a theoretical discussion here.

Apr 11 2019, 4:23 AM · KDE Edu

Apr 10 2019

wreissenberger added a comment to D20029: Capture counting corrected.

Related? https://indilib.org/forum/ekos/4995-ekos-scheduler-eats-frames-from-the-sequence.html#37550

With the latest information posted - YES. It's exactly the situation with a capture job of 18*L+3*R+3*G+3*B.

Turned out meanwhile that it is not related. It is simply missing awareness of the option "Remember job progress". Maybe we should consider moving this option directly to the scheduler tab - or show at least there, that the option is active.

Apr 10 2019, 3:57 PM · KDE Edu
wreissenberger added a comment to D20029: Capture counting corrected.

Related? https://indilib.org/forum/ekos/4995-ekos-scheduler-eats-frames-from-the-sequence.html#37550

With the latest information posted - YES. It's exactly the situation with a capture job of 18*L+3*R+3*G+3*B.

Apr 10 2019, 12:25 PM · KDE Edu
wreissenberger added a comment to D20029: Capture counting corrected.

It's unclear, but maybe, yes.

Agreed, the issue we are working here is a good hint. I asked for more details on the forum.

Could I offer my own implementation on the two fixes that are in this differential? I'd like to first fix the FindNextJob issue, then in another diff the frame counting via messages from the capture module.

Absolutely fine, I do not have the ambition that I fix it. I simply want it to be fixed asap. :-)

My previous message is about the calculation : the order of operators produces 1 when less than a full sequence is executed. It also considers sequences are distributed equally between jobs, which I disagree with as the code, in remember mode, is trying to gather frames to complete sequences in order, then schedule remaining ones.

You are right, the calculation of captured frames of a certain sequence job is only correct as long as the entire capture job has completed. If it does not run completely, the frames taken in the last cycle are not counted correctly.
Let's take an example with a LLLRGB sequence that completes twice and terminates after two L frames. In the calculation, we have schedJob->getCompletedCount() = 14, capturesPerRepeat=6 and seqJob->getCount() = 3. As a result we get 14/6*3 = 6 - which is wrong, it should be 8.

Apr 10 2019, 12:00 PM · KDE Edu

Apr 7 2019

wreissenberger requested review of D20365: Clean module registration.
Apr 7 2019, 7:08 PM · KDE Edu
wreissenberger added a comment to D20029: Capture counting corrected.

That's a good idea, but weeell I have two disagreements : first this is integer calculation and you probably need to reorder your operators, and second, if I understand correctly, you are considering the amount of captures to get equiprobable scattering over all sequence jobs.
I'll nonetheless test this asap.

Could you please be more specific? To be honest, I do not understand what you mean.

Apr 7 2019, 6:51 PM · KDE Edu

Apr 6 2019

wreissenberger updated the diff for D20029: Capture counting corrected.

Update: There was an another bug in calculating whether light frames are required by a schedule job. In the case that "Repeat for x runs" is selected and one sequence has more captures than required and another one has less, the scheduler job assumes than no light frames are required - which is wrong.

Apr 6 2019, 2:17 PM · KDE Edu
wreissenberger added a comment to D20029: Capture counting corrected.

Can you please check this?

https://indilib.org/forum/general/4908-meridian-flip-issue-with-the-scheduler.html

Resolved with D20150

Apr 6 2019, 1:50 PM · KDE Edu

Mar 31 2019

wreissenberger requested review of D20151: Unchecking the meridian flip checkbox reset the meridian flip state.
Mar 31 2019, 9:12 PM · KDE Edu
wreissenberger requested review of D20150: Meridian flip checks after capture completion removed.
Mar 31 2019, 8:27 PM · KDE Edu

Mar 29 2019

wreissenberger added a comment to D20029: Capture counting corrected.

Hm, maybe, but I think it's a different issue. But thanks for the hint, I will try to reproduce it.

Mar 29 2019, 5:45 AM · KDE Edu

Mar 28 2019

wreissenberger added a comment to D19648: Keep GUI parameters for scheduler and capture in sync with row selection.

OK, but I checked for the reordering problem:

  • It's possible to sort jobs while the Scheduler is running using the "Reset state and sort observations" button. That is not a regression, that is an existing bug.
  • It's possible to reorder and reset jobs while the Scheduler is running using the "Reset state and force reevaluation" button. That is a regression in this differential.

Eric, I cannot reproduce it. When I start the scheduler, all buttons on the top left side of the queue are deactivated.

Mar 28 2019, 7:54 AM · KDE Edu

Mar 27 2019

wreissenberger updated the diff for D20029: Capture counting corrected.

I think I found a way to correct the counting of frames for the case that remembering is ticked off.

Mar 27 2019, 11:19 PM · KDE Edu
wreissenberger added a comment to D19648: Keep GUI parameters for scheduler and capture in sync with row selection.

https://bugs.kde.org/show_bug.cgi?id=405901 related?

As mentioned above, right, this is an existing problem, but this diff neither addresses it nor makes it worse. Should be fixed separately.

Mar 27 2019, 8:47 PM · KDE Edu
wreissenberger added a comment to D20029: Capture counting corrected.

Well, filling the map in any cases will not help, because the intention of not ticking "Remember progress" is exactly, that we start counting from zero - no matter how many are in the file system.

Mar 27 2019, 4:07 PM · KDE Edu
wreissenberger added a comment to D20029: Capture counting corrected.

Your comment about capture_completed is right, I'm trying to fix it. The problem is, that captures_completed = schedJob->getCompletedCount() is called for each sequence job entry and added to totalCompletedCount, i.e. the total amount of the entire capture run is added multiply.

Mar 27 2019, 1:10 PM · KDE Edu
wreissenberger added a comment to D20001: Simplifying Scheduler.

@TallFurryMan: Absolutely not, that's the nature of discussion. And I appreciate the ambition of making a sports car out of it :-)

Mar 27 2019, 8:03 AM · KDE Edu

Mar 26 2019

wreissenberger added a comment to D20001: Simplifying Scheduler.

OK, @TallFurryMan , I give up :-) Here is the alternative with the score calculations shifted to SchedulerJob: D20068.

Mar 26 2019, 7:31 PM · KDE Edu
wreissenberger requested review of D20068: Shifted scheduler job specific scorings from Scheduler to SchedulerJob.
Mar 26 2019, 7:28 PM · KDE Edu
wreissenberger accepted D20058: Fix altitude restriction log and allow restriction down to -15 degrees.

OK, agreed.

Mar 26 2019, 6:47 PM · KDE Edu
wreissenberger updated the diff for D19648: Keep GUI parameters for scheduler and capture in sync with row selection.

Removal of table dis-/enabling completed.

Mar 26 2019, 6:37 PM · KDE Edu
wreissenberger updated the diff for D19648: Keep GUI parameters for scheduler and capture in sync with row selection.

Active job selected, enabling/disabling queue tables removed.

Mar 26 2019, 6:29 PM · KDE Edu
wreissenberger added a comment to D20029: Capture counting corrected.

By the way: I found out that the null pointer exception occurs also when there is only one scheduler entry. So I think it's quite urgent that we at least fix this issue...

Mar 26 2019, 8:55 AM · KDE Edu
wreissenberger added a comment to D20058: Fix altitude restriction log and allow restriction down to -15 degrees.

Better than the rather arbitrary limit of 15. But why -15 and not -90? And what about changing the maximum to 90 instead of 89.9?

Mar 26 2019, 8:50 AM · KDE Edu