wreissenberger (Wolfgang Reissenberger)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 16 2018, 6:19 AM (21 w, 1 d)
Availability
Available

Recent Activity

Mon, Nov 26

wreissenberger updated the diff for D17159: bug fix #400265: meridian flip check before capturing.

Commit range corrected

Mon, Nov 26, 7:17 PM
wreissenberger added inline comments to D17159: bug fix #400265: meridian flip check before capturing.
Mon, Nov 26, 7:13 PM
wreissenberger updated the diff for D17159: bug fix #400265: meridian flip check before capturing.

Exception handling added

Mon, Nov 26, 7:12 PM

Sun, Nov 25

wreissenberger added reviewers for D17159: bug fix #400265: meridian flip check before capturing: TallFurryMan, mutlaqja.
Sun, Nov 25, 9:01 PM
wreissenberger requested review of D17159: bug fix #400265: meridian flip check before capturing.
Sun, Nov 25, 8:51 PM

Thu, Nov 22

wreissenberger added a comment to D16429: Rewrite of Scheduler planning.

Go ahead and post, I can integrate it to this differential.

et voilà...

Thu, Nov 22, 4:42 AM · KDE Edu

Wed, Nov 21

wreissenberger added a comment to D16429: Rewrite of Scheduler planning.

I think I found the problem with the selection bug. The function reorderJobs() seems to be buggy and it does not look like a new bug.

Wed, Nov 21, 6:19 PM · KDE Edu
wreissenberger requested changes to D16429: Rewrite of Scheduler planning.

With the option "Sort Jobs per Altitude and Priority" enabled, re-sorting in the edit mode leads to a wrong selection in the queue table.

Wed, Nov 21, 3:11 PM · KDE Edu

Oct 28 2018

wreissenberger requested changes to D16429: Rewrite of Scheduler planning.

There are some things that do not work correctly:

  1. Select "Sort jobs by Altitude and Priority" and load a schedule with several jobs with priority 10. Now select a sequence for editing and change the priority of a sequence, e.g. first from 10 to 1. In my case, the job jumps on position 1. Up to here everything is fine. If you change it now to 15, it moves down, but the selection does not follow to the new position. In my case, the first line remains highlighted.
  2. Change the option "Sort jobs by Altitude and Priority". No matter in which direction, the Scheduler tab is not updated. If the option is set, the jobs remain unsorted. If the option is not set, the position buttons are disabled.
Oct 28 2018, 3:35 PM · KDE Edu

Oct 11 2018

wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

From I simplicity point of view, I would recommend not introducing this flag, as long as we have the reset buttons. It's meaning might be misinterpreted.
... and it's behavior is different depending on whether the sequence has been freshly loaded or not.

I would agree, but as stated by Jasem, we would lose the use case "Anytime I Press Start, I Want All Jobs Processed" if we don't keep some sort of Remember Job Progress for the Capture module.
And we do see that the option is now different from the one used in the Scheduler.

OK, that's right. But in this case I would make this option directly accessible (and visible) in the Capture tab. All options in the Options tab bear the risk of being forgotten.

Oct 11 2018, 4:38 AM · KDE Edu

Oct 10 2018

wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

... and it's behavior is different depending on whether the sequence has been freshly loaded or not.

Oct 10 2018, 1:45 PM · KDE Edu
wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

From a Capture perspective this sounds reasonable and very comfortable.

Oct 10 2018, 1:42 PM · KDE Edu
wreissenberger added a comment to D15937: Do not alter the state of the Scheduler while evaluating.

Sorry for the late response, looks good. One tiny thing: when changing list positions, evaluate... is multiply called. In all other situations I tested, it’s called only once.

Oct 10 2018, 10:34 AM · KDE Edu

Oct 9 2018

wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

Sorry for the distraction :-)
I meanwhile use the scheduler excessively and I have a lot of features in mind... But let's concentrate on making it stable as fast as possible.

Oct 9 2018, 11:03 AM · KDE Edu
wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

I agree with @TallFurryMan, Capture and Scheduler should not overlap in terms of control logics. We should keep Capture as simple as possible and leave all history stuff to Scheduler.

Oct 9 2018, 8:19 AM · KDE Edu
wreissenberger added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

Sorry, Eric, but arc patch complains about missing commit a651bd7ee7ba7ebba7e40f5b263021d534db14b6. It is neither in your repository nor in the main one (at least I cannot find it).

Oct 9 2018, 7:35 AM · KDE Edu

Oct 4 2018

wreissenberger added a comment to D15837: Fix for the Dome interface.

Just an idea: is it possible, that the correct name is parkingStatus?

Oct 4 2018, 9:24 AM · KDE Edu

Oct 3 2018

wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Looks good, my tests succeeded. Excellent, this feature is very helpful!!

Oct 3 2018, 8:53 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Hi Eric,
I get an error message from arc patch

arc patch D14942
Created and checked out branch arcpatch-D14942.

    This diff is against commit 018f6986f3887648a6f31f0597de063a53a92675, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (40d75559189dabe735a9f9e55c0641ba86a58ef7)

Should I continue or otherwise where could I get the missing commit? It does not seem to exist in the GIT master

I'm sorry I have no idea... Is it that you should fetch the remote server before patching?

Oct 3 2018, 3:16 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Hi Eric,
I get an error message from arc patch

arc patch D14942
Created and checked out branch arcpatch-D14942.
Oct 3 2018, 12:14 PM · KDE Edu
wreissenberger added a comment to D15837: Fix for the Dome interface.

Same situation with the RollOff Simulator. The INDI Control panel shows:

2018-10-03T08:19:51: [INFO] Dome is unparked. 
2018-10-03T08:19:51: [INFO] Roof is open. 
2018-10-03T08:19:41: [INFO] Roll off is unparking... 
2018-10-03T08:19:18: [INFO] Dome is parked.

But the log in the scheduler shows as last entry

2018-10-03T10:19:41 Unparking dome...
Oct 3 2018, 8:22 AM · KDE Edu
wreissenberger added a comment to D15837: Fix for the Dome interface.

OK, re-checked with the latest INDI version. No change.

Oct 3 2018, 8:17 AM · KDE Edu
wreissenberger added a comment to D15837: Fix for the Dome interface.

I use the DomeSimulator working on arcpatch-D15837.

Oct 3 2018, 7:57 AM · KDE Edu

Oct 1 2018

wreissenberger added a comment to D15837: Fix for the Dome interface.

Hm, my differential does not work properly. There are several things:

  1. Simply checking "unpack dome" after cancelling a scheduled job does not help. I need to double click on a job so that the change is recognized.
  2. If I do it like this, the dome simulator unparks the dome and opens the shutter, but the scheduler does not continue. It looks "Checking INDI State 4".
Oct 1 2018, 9:05 PM · KDE Edu

Sep 25 2018

wreissenberger raised a concern with R321:7d1295998fde: Improve timeout behavior for astrometry download with KAuth.

KAuth::Action.setTimeout() requires KF5 Version 5.29. On my Raspberry, I only have 5.28 - resulting into a failed compile.

Sep 25 2018, 11:22 AM

Sep 11 2018

wreissenberger accepted D15388: Do not abort a job that is repeating because it started long ago, that delay is expected..

Ok, checked. I could reproduce it on master and with the patch the message disappeared.

Sep 11 2018, 7:37 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Makes sense, DBUS should have priority.

Sep 11 2018, 11:50 AM · KDE Edu
wreissenberger added a comment to D15388: Do not abort a job that is repeating because it started long ago, that delay is expected..

I’ve seen the messages in my own logfile last night. I ca Test it late this afternoon.

Sep 11 2018, 11:48 AM · KDE Edu

Sep 10 2018

wreissenberger added a comment to D15388: Do not abort a job that is repeating because it started long ago, that delay is expected..

Could you please be a little more specific with the test case? I cannot reproduce it yet.

Sep 10 2018, 3:31 PM · KDE Edu
wreissenberger accepted D15363: Avoid losing completed count when capture was suspended by a guiding deviation..

The pros are that (a) the change is smaller and (b) there is no need to change an API. The cons are that (a) it makes the code more difficult to read and (b) we are talking of three occurrences, only inside of capture.cpp, where two are touched by this diff.

Sep 10 2018, 1:38 PM · KDE Edu
wreissenberger added a comment to D15363: Avoid losing completed count when capture was suspended by a guiding deviation..

Functionally OK, but it is difficult to read. Wouldn't it be better to add a flag to resetStatus() which indicates whether the count should be kept or not?

Sep 10 2018, 7:41 AM · KDE Edu

Sep 9 2018

wreissenberger accepted D15339: Fix mount not unparking after scheduler stops.

Looks good, I could reproduce the problem and checked it being fixed against simulators.

Sep 9 2018, 12:42 PM · KDE Edu

Sep 4 2018

wreissenberger commandeered D14928: Restarting looping schedule continues capturing.

Thanks for your rebasing, Eric!

Sep 4 2018, 3:29 PM · KDE Edu
wreissenberger added a comment to D15230: Fix cache discrepancy when a job is complete..

Looks good, my test cases with the duplicated schedule are running now. Two minor things that I found, but they are not critical:

  • Having two jobs with the same signature both with FINISH_REPEATand the second to run has less cycles than the first one, the second is started and finishes after one iteration. But I think this not a behavior introduced with this fix. Just to be mentioned...

Ah, yes. Probably a regression or a side-effect of an older change. This use case is a bit weird (but possible of course), perhaps we should order duplicates per repeat count?
Also, I'm weighting the possibility to reorder the jobs in the list per startup order, so that it's clearer for the end-user which one will start before the other.

This happens also if you have two identical cycle numbers. The second one starts once and detects after one cycle that it is completed. It seems like there is no check that jobs once scheduled might get completed without a single run.

  • When creating newFramesCountthere is no check whether it already contains the signature to be evaluated. This leads to duplicated calls to getCompletedFiles(). Functionally this is OK, but it makes the check slower.

Agreed. Perhaps I can add a check right now.

OK, checked, working.

Sep 4 2018, 8:06 AM · KDE Edu

Sep 3 2018

wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

OK - already done :-)

Sep 3 2018, 11:19 AM · KDE Edu
wreissenberger accepted D15230: Fix cache discrepancy when a job is complete..

Looks good, my test cases with the duplicated schedule are running now. Two minor things that I found, but they are not critical:

  • Having two jobs with the same signature both with FINISH_REPEATand the second to run has less cycles than the first one, the second is started and finishes after one iteration. But I think this not a behavior introduced with this fix. Just to be mentioned...
  • When creating newFramesCountthere is no check whether it already contains the signature to be evaluated. This leads to duplicated calls to getCompletedFiles(). Functionally this is OK, but it makes the check slower.
Sep 3 2018, 11:18 AM · KDE Edu

Aug 30 2018

wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Well, indeed, the feature name is not so self explanatory. But currently, the flag is not used inside of updateCompletedJobsCount(), right? As far as I understand, it is only used to estimate the duration. Looks like both methods could share a lot of code... OK, it looks like as there is room for improvement Capture.

Aug 30 2018, 8:40 PM · KDE Edu

Aug 29 2018

wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Do we really to consider what happens on the storage? I would simply count a frame if it has been stored successfully. If it disappears at a later stage, why should we care?

Aug 29 2018, 8:03 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

OK, got the point, you are right. But parallel asynchronous jobs - hm. That also adds complexity.

Aug 29 2018, 7:18 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Hm, I think the reason is the strategy how the cache is updated and not a pure invalid cache problem.

Aug 29 2018, 5:40 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

I did some tests, looks good. There is one test that already failed in D14684 and is still present. It might be exotic, but it leads to continuous looping.

The setup is the following: create a schedule with two jobs for the same target with the same sequence job (say 1xLum for example). The first job starts and captures the first frame.

And here is where the problem occurs: now calling Scheduler::updateCompletedJobsCount() detects the one frame, but when evaluating the second job (which did not run yet), the value in the captured frames map is overwritten. This leads to an endless loop of the first job.

Aug 29 2018, 12:40 PM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Give this test case a try:

Aug 29 2018, 10:58 AM · KDE Edu
wreissenberger added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Another small thing: I observed that the counting update happens only after a single sequence is finished and not after each capture. I guess that's by intention...

Aug 29 2018, 10:51 AM · KDE Edu
wreissenberger accepted D14942: Update job completion counts, and fix regression on job rescheduling..

Agreed, no, this issue should not block. If it's OK for you, I can try to fix it. I know the place where it goes wrong...

Aug 29 2018, 10:49 AM · KDE Edu
wreissenberger requested changes to D14942: Update job completion counts, and fix regression on job rescheduling..

I did some tests, looks good. There is one test that already failed in D14684 and is still present. It might be exotic, but it leads to continuous looping.

Aug 29 2018, 9:15 AM · KDE Edu

Aug 28 2018

wreissenberger accepted D15073: Fix parking engine, and make observatory startup job-centric.

Agreed. The issues I found are not that critical. The only thing that may happen is that a connection loss during shutdown leads to unfinished shutdown of the observatory. This can be fixed in a separate diff.

Aug 28 2018, 8:09 AM · KDE Edu

Aug 27 2018

wreissenberger requested changes to D15073: Fix parking engine, and make observatory startup job-centric.

OK, now the scheduler does not crash any more, if the INDI server is not available during parking. But the scheduler module does not recognize that the job has finished. The "Stop"-button is still active and the spinning wheel on the right side is still running - although the text says "No job running".

Aug 27 2018, 1:50 PM · KDE Edu
wreissenberger added a comment to D14977: Bugfix for #397650 flat creation failed.

OK, I squashed the two commits.

Aug 27 2018, 11:56 AM · KDE Edu
wreissenberger updated the diff for D14977: Bugfix for #397650 flat creation failed.
Bugfix for #397650 flat creation failed
Aug 27 2018, 11:53 AM · KDE Edu
wreissenberger updated the diff for D14977: Bugfix for #397650 flat creation failed.

Bugfix for #397650 flat creation failed (Update)
Retry to submit the correct files.

Aug 27 2018, 8:47 AM · KDE Edu

Aug 26 2018

wreissenberger requested changes to D15073: Fix parking engine, and make observatory startup job-centric.

I did a first check using a remote INDI server:

  • Running a single scheduled job: works fine.
  • Interrupting temporarily the INDI server during slewing and capturing: works fine, EKOS recovers.
  • Interrupting temporarily the INDI server during parking: segmentation fault in Scheduler::manageConnectionLoss() in stopGuiding(). currentJob is NULL which leads to a runtime exception.
Aug 26 2018, 3:37 PM · KDE Edu

Aug 25 2018

wreissenberger added a comment to D14977: Bugfix for #397650 flat creation failed.

The only changes I made were in capture.cpp - in addition to the new test case. The diff of my changes is attached.

Aug 25 2018, 6:49 PM · KDE Edu
wreissenberger added a comment to D14977: Bugfix for #397650 flat creation failed.

Oops, that was not the intention! I did a rebase in advance, so this small change includes a bunch of other changes. The only relevant change is that to capture.cpp.

Aug 25 2018, 3:33 PM · KDE Edu
wreissenberger updated the diff for D14977: Bugfix for #397650 flat creation failed.

Bugfix for #397650 flat creation failed (Update)
Separation of pure preview job from flat calibration preview now by calibration stage

Aug 25 2018, 3:29 PM · KDE Edu

Aug 21 2018

wreissenberger requested review of D14977: Bugfix for #397650 flat creation failed.
Aug 21 2018, 5:25 PM · KDE Edu
wreissenberger added a comment to D14941: Proper silencing for the switch-case fall-through warning.

Q_FALLTHROUGH() was introduced in Qt 5.8, but kstars supports Qt >= 5.4.0. Building on Raspbian Stretch (Debian 9) fails.

Aug 21 2018, 9:36 AM · KDE Edu

Aug 20 2018

wreissenberger updated the diff for D14928: Restarting looping schedule continues capturing.

Captured frames map not handed over for FINISH_LOOP and FINISH_AT
Additionally, switch statement used instead of a simple if clause.

Aug 20 2018, 8:32 AM · KDE Edu

Aug 19 2018

wreissenberger added a comment to D14928: Restarting looping schedule continues capturing.

Aaaa, it seems like my changes now made it into the Phabricator.
I simply leave the captured frames map empty for SchedulerJob::FINISH_LOOP. The Capture module remains untouched. The behavior in the capture module is quite simple: since it does not find the signature in the captured frames map, it assumes that there are no frames - i.e. it simply executes the entire set - as desired. Quite simple...

Aug 19 2018, 8:27 PM · KDE Edu
wreissenberger added a comment to D14928: Restarting looping schedule continues capturing.

Hm, it seems like my code changes did not find their way to this differential. Here is what I did:

Aug 19 2018, 6:49 PM · KDE Edu
wreissenberger updated the diff for D14928: Restarting looping schedule continues capturing.

Scheduler does not set captured frames map for SchedulerJob::FINISH_LOOP jobs.

Aug 19 2018, 5:34 PM · KDE Edu
wreissenberger added a comment to D14928: Restarting looping schedule continues capturing.

OK, makes sense. My thought was that ignoreJobProgress was set via ignoreSequenceHistory() from Scheduler for infinite looping jobs, but never used in Capture.
I'll revert the change and shift this as proposed to Scheduler.

Aug 19 2018, 5:04 PM · KDE Edu
wreissenberger requested review of D14928: Restarting looping schedule continues capturing.
Aug 19 2018, 12:32 PM · KDE Edu

Aug 14 2018

wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.

@TallFurryMan: OK, if you re-tested it, let's assume that I am making some mistake in obtaining the same codebase. Since I am very new in using the Phabricator, I wouldn't be surprised.

Aug 14 2018, 8:15 PM · KDE Edu
wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.

Hm, strange. I checked out the latest version of D14684, compile it and run the test. When I run it, the first of the two jobs loops endlessly instead of terminating after three runs. See the attached log file.

Aug 14 2018, 8:30 AM · KDE Edu

Aug 13 2018

wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.

@TallFurryMan: I did not run the entire test set yet, but my problem mentioned on Fri, Aug 10, 2:19 PM still exists. The attached test case illustrate the wrong behavior.

Not sure whether the problem still exists after your changes, but I found a situation where the scheduler loops endlessly.

If you have two jobs with the same capture file signature (path + filter etc.) and the second has less repeats than the first, the first job will repeat endlessly.

The problem is that Scheduler::updateCompletedJobsCount() overwrites the map entry such that a later evaluation thinks that it has less captures than requested.

Please find included a test illustrating it. Place it under /tmp/kstars_tests

-Wolfgang

Aug 13 2018, 9:15 PM · KDE Edu

Aug 10 2018

wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.
Aug 10 2018, 1:44 PM · KDE Edu
wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.

Not sure whether the problem still exists after your changes, but I found a situation where the scheduler loops endlessly.

Aug 10 2018, 12:19 PM · KDE Edu
wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.

Sorry folks for the stupid question - but how can I get access to these changes? I cannot find the mentioned branch on GitHub.

Aug 10 2018, 12:11 PM · KDE Edu

Aug 4 2018

wreissenberger added a comment to D14309: Handling multiple occurrence of the same sequence job corrected.

I made a small correction in the log output: https://phabricator.kde.org/D14605

Aug 4 2018, 2:56 PM
wreissenberger requested review of D14605: Summary: Logging output in Capture corrected, considering only the counts of a single sequence job.
Aug 4 2018, 2:52 PM · KDE Edu

Jul 25 2018

wreissenberger added a comment to D14309: Handling multiple occurrence of the same sequence job corrected.

It seems like this patch is not in the current master of 2.9.7. The code I found in capture.cpp looks like https://phabricator.kde.org/D14280 and not the corrected version from https://phabricator.kde.org/D14309.

Jul 25 2018, 7:04 PM
wreissenberger added a comment to R321:e5656839e73b: QPointF.center requires Qt 5.8 so we are going for the simpler version to make….

kstars/ekos/ekoslive/message.cpp has the same problem.

Jul 25 2018, 6:10 PM
wreissenberger added a comment to D14280: Handling multiple occurrence of the same sequence job corrected.

Yes, there is an update. I made all changes that Eric suggested and submitted a new version here:

Jul 25 2018, 7:53 AM

Jul 23 2018

wreissenberger requested review of D14309: Handling multiple occurrence of the same sequence job corrected.
Jul 23 2018, 7:02 PM

Jul 22 2018

wreissenberger requested review of D14280: Handling multiple occurrence of the same sequence job corrected.
Jul 22 2018, 8:20 PM

Jul 16 2018

wreissenberger updated the diff for D14149: calculating cumulative frequency corrected.
Jul 16 2018, 6:35 AM · KDE Edu
wreissenberger requested review of D14149: calculating cumulative frequency corrected.
Jul 16 2018, 6:29 AM · KDE Edu