KDE EduUmbrella
ActivePublic

Details

Description

The KDE Education Project

Recent Activity

Today

sirgienko added a comment to D14738: Add the markdown entry.

@kqwyf, Could you add feature, that if user's cursor comes from cell below, cursor appears not in begin of text, but in end?
Another type of entries have this functional, including text entry, so, I think, it's not very difficult to add this functional for MarkdownEntry.

Wed, Aug 15, 4:29 PM · KDE Edu
sirgienko added a comment to D14738: Add the markdown entry.

In this patch, a markdown entry without Discount support behaves just like a text entry, except that the latex formulas can be re-edited. I think it's a useful feature.

Wed, Aug 15, 4:13 PM · KDE Edu
kqwyf added a comment to D14738: Add the markdown entry.
  • change all the indentation tabs into spaces
  • remove extra changes
  • update CMakeLists.txt
  • bump the ui version in cantor_part.rc
  • fix the memory leak when converting markdown to HTML
  • feature: save evaluation results for markdown entries
Wed, Aug 15, 3:50 PM · KDE Edu
kqwyf updated the diff for D14738: Add the markdown entry.
  • change all the indentation tabs into spaces
  • remove extra changes
  • update CMakeLists.txt
  • bump the ui version in cantor_part.rc
  • fix the memory leak when converting markdown to HTML
  • feature: save evaluation results for markdown entries
Wed, Aug 15, 3:47 PM · KDE Edu
kqwyf added a comment to D14738: Add the markdown entry.
Wed, Aug 15, 2:55 PM · KDE Edu
jjazeix closed D14858: chess, put warning messages in red.
Wed, Aug 15, 1:25 PM · GCompris: Activities, KDE Edu
jjazeix accepted D14858: chess, put warning messages in red.

Merged in https://commits.kde.org/gcompris/65dd0f53ebde9645355c1eee18b882f0d957294b
Thank you!

Wed, Aug 15, 1:25 PM · GCompris: Activities, KDE Edu
jonathand added a comment to D14858: chess, put warning messages in red.

Good ! My email : jdemeyer hotmail com

Wed, Aug 15, 11:40 AM · GCompris: Activities, KDE Edu
filipesaraiva added a comment to D14738: Add the markdown entry.
In D14738#309525, @pino wrote:

Can I change the authorship of the commit and push now? Do you know @pino?

You definitely cannot change already pushed commits...

  1. revert the commit, because of wrong authorship, and unfixed issues still there
Wed, Aug 15, 11:11 AM · KDE Edu
sirgienko added a comment to D14738: Add the markdown entry.

Sorry again, and please continue the review guys, I will fix it when everyone has approved.

Wed, Aug 15, 10:56 AM · KDE Edu
jjazeix added a comment to D14858: chess, put warning messages in red.

Except the camel case, it's good for me, I can do the change and merge it. Can you share your email so I can commit with your name (else I can commit with my account)?

Wed, Aug 15, 10:47 AM · GCompris: Activities, KDE Edu
filipesaraiva added a comment to D14738: Add the markdown entry.
In D14738#309525, @pino wrote:

Can I change the authorship of the commit and push now? Do you know @pino?

You definitely cannot change already pushed commits...

  1. revert the commit, because of wrong authorship, and unfixed issues still there
  2. wait for @kqwyf to fix the issues
  3. once it is done, ask him/her for name and email (since silly phabricator cannot provide this info for commits sent with arc)
  4. take the patch, amend it fixing the authorship, and push
Wed, Aug 15, 10:43 AM · KDE Edu
pino added a comment to D14738: Add the markdown entry.

Can I change the authorship of the commit and push now? Do you know @pino?

Wed, Aug 15, 10:39 AM · KDE Edu
filipesaraiva reopened D14738: Add the markdown entry.

Oh no, sorry. I thought the authorship was maintained... when I answer:

Wed, Aug 15, 10:33 AM · KDE Edu
pino added a comment to D14738: Add the markdown entry.

@filipesaraiva you pushed a patch

  • without all the changes required (see my note about bumping the UI version in cantor_part.rc)
  • with known memory leaks
  • without the proper authorship
Wed, Aug 15, 10:29 AM · KDE Edu
filipesaraiva closed D14738: Add the markdown entry.
Wed, Aug 15, 10:26 AM · KDE Edu
jonathand added a project to D14858: chess, put warning messages in red: GCompris: Activities.
Wed, Aug 15, 9:31 AM · GCompris: Activities, KDE Edu
jonathand requested review of D14858: chess, put warning messages in red.
Wed, Aug 15, 9:30 AM · GCompris: Activities, KDE Edu
mutlaqja added a comment to D14684: Fixes for the Scheduler and Capture modules.

Well this is merged back to master, so please check against master now. If testing goes OK, we can release 2.9.8

Wed, Aug 15, 5:48 AM · KDE Edu

Yesterday

lancaster added a comment to D14813: Adding XPlanet Viewer.

Thank you for your feedback.

Tue, Aug 14, 8:16 PM · KDE Edu
wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.

@TallFurryMan: OK, if you re-tested it, let's assume that I am making some mistake in obtaining the same codebase. Since I am very new in using the Phabricator, I wouldn't be surprised.

Tue, Aug 14, 8:15 PM · KDE Edu
TallFurryMan added a comment to D14684: Fixes for the Scheduler and Capture modules.

@wreissenberger I don't see this part of my log in your log:

Tue, Aug 14, 7:27 PM · KDE Edu
TallFurryMan added a comment to D14684: Fixes for the Scheduler and Capture modules.

@wreissenberger I think I understand what happens in the log:

Tue, Aug 14, 7:07 PM · KDE Edu
pino added a comment to D14738: Add the markdown entry.

Sorry but I'm not sure about the rule to bump the ui version number. What number should it become? Maybe 2.1?

Tue, Aug 14, 5:42 PM · KDE Edu
kqwyf added a comment to D14738: Add the markdown entry.
In D14738#309034, @pino wrote:

Nitpick: please provide a consistent indentation in the new files -- they seem to mix spaces and tabs.
Also, was this tested when cantor is built without the Discount library? How does it behave when trying to add/edit markdown entries, and trying to load worksheets with such entries?

Tue, Aug 14, 5:26 PM · KDE Edu
pino added a comment to D14738: Add the markdown entry.

Nitpick: please provide a consistent indentation in the new files -- they seem to mix spaces and tabs.
Also, was this tested when cantor is built without the Discount library? How does it behave when trying to add/edit markdown entries, and trying to load worksheets with such entries?

Tue, Aug 14, 4:52 PM · KDE Edu
sirgienko added a comment to D14738: Add the markdown entry.

@kqwyf, after previous two diff changes, Markdown entries starts don't work for me (don't evaluate), is they works on your machine?

I think problem, that
#cmakedefine discount_FOUND 1 don't work now, because we start use Discount_FOUND.

I'm so sorry that I didn't build it again after I have done some changes. This time it is built and tested.

Thank you very much. :)

Tue, Aug 14, 4:48 PM · KDE Edu
kqwyf added a comment to D14738: Add the markdown entry.

@kqwyf, after previous two diff changes, Markdown entries starts don't work for me (don't evaluate), is they works on your machine?

I think problem, that
#cmakedefine discount_FOUND 1 don't work now, because we start use Discount_FOUND.

Tue, Aug 14, 4:33 PM · KDE Edu
kqwyf updated the diff for D14738: Add the markdown entry.
  • update macros about Discount
Tue, Aug 14, 4:31 PM · KDE Edu
sirgienko added a comment to D14738: Add the markdown entry.

@kqwyf, after previous two diff cheanges, Markdown entries starts don't work for me (don't evaluate), is they works on your machine?

Tue, Aug 14, 4:24 PM · KDE Edu
kqwyf added a comment to D14738: Add the markdown entry.

@kqwyf Could you find Discount twice? Because I could found Discount only in first cmake run, and in seconds I have

-- The following OPTIONAL packages have not been found:

 * Discount
Tue, Aug 14, 4:14 PM · KDE Edu
kqwyf updated the diff for D14738: Add the markdown entry.
  • fix the bug that it won't find Discount when doing cmake twice.
  • add package properties for Discount
Tue, Aug 14, 4:07 PM · KDE Edu
sirgienko added a comment to D14738: Add the markdown entry.

@kqwyf Could you find Discount twice? Because I could found Discount only in first cmake run, and in seconds I have

-- The following OPTIONAL packages have not been found:
Tue, Aug 14, 3:41 PM · KDE Edu
kqwyf added a comment to D14738: Add the markdown entry.

Thank you for your contribution @kqwyf. I built with Discount and it is working fine. I built without Discount, I could run Cantor correctly and the options to insert Markdown entries continues to show, but it is a problem with others entries options like LaTeX. Maybe it is time to some refactoring in this part.

For a first contribution it is very good, congrats. Stay with us to develop more features and fix bugs. :)

I will wait some hours for comments of the others reviewers, if they are nothing to ask I will push to you.

Tue, Aug 14, 3:39 PM · KDE Edu
kqwyf updated the diff for D14738: Add the markdown entry.
  • remove the commented code
  • fix a bug that a command entry is appended when clicking a new markdown entry
Tue, Aug 14, 3:24 PM · KDE Edu
sirgienko added a comment to D14738: Add the markdown entry.

If I insert Markdown entry from context menu (this menu also have "Evaluate Worksheet" action) in the end of worksheet and click after it, a command entry added. Could anyone reproduce it?

Tue, Aug 14, 2:32 PM · KDE Edu
filipesaraiva added a task to D14738: Add the markdown entry: T9108: Add support for markdown.
Tue, Aug 14, 10:12 AM · KDE Edu
filipesaraiva accepted D14738: Add the markdown entry.

Thank you for your contribution @kqwyf. I built with Discount and it is working fine. I built without Discount, I could run Cantor correctly and the options to insert Markdown entries continues to show, but it is a problem with others entries options like LaTeX. Maybe it is time to some refactoring in this part.

Tue, Aug 14, 10:09 AM · KDE Edu
filipesaraiva abandoned D14780: Fix Julia backend build for Julia minor version > 5.

@filipesaraiva, after 90b001d1b01556cc5d5b60791e9b43e6dfcff0b4, do you still have build errors?

Tue, Aug 14, 9:30 AM · Cantor, KDE Edu
wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.

Hm, strange. I checked out the latest version of D14684, compile it and run the test. When I run it, the first of the two jobs loops endlessly instead of terminating after three runs. See the attached log file.

Tue, Aug 14, 8:30 AM · KDE Edu
kqwyf updated the summary of D14738: Add the markdown entry.
Tue, Aug 14, 7:27 AM · KDE Edu
TallFurryMan added a comment to D14684: Fixes for the Scheduler and Capture modules.

@wreissenberger I tested your vector with the landed differential, and it succeeded in capturing the job with 3 batches, then the job with 2 batches.
While I didn't test specifically what could happen if I aborted the Scheduler in the middle of this test, I don't expect it to loop. I'll check again later.

Tue, Aug 14, 7:05 AM · KDE Edu
pino requested changes to D14813: Adding XPlanet Viewer.
  • all the visible UI strings must be translatable using i18n & friends
  • please cleanup the commit message, all the "merge branch" bits are not helpful (and beside that, the canonical location of kstars is git.kde.org, not github); also, please write more details on what is the feature, which code changes were done (e.g. code that was moved away form SkyMap), etc
  • all the this-> stuff are not needed
Tue, Aug 14, 6:28 AM · KDE Edu
TallFurryMan added a comment to D14684: Fixes for the Scheduler and Capture modules.

@TallFurryMan: I did not run the entire test set yet, but my problem mentioned on Fri, Aug 10, 2:19 PM still exists. The attached test case illustrate the wrong behavior.

Not sure whether the problem still exists after your changes, but I found a situation where the scheduler loops endlessly.

If you have two jobs with the same capture file signature (path + filter etc.) and the second has less repeats than the first, the first job will repeat endlessly.

The problem is that Scheduler::updateCompletedJobsCount() overwrites the map entry such that a later evaluation thinks that it has less captures than requested.

Please find included a test illustrating it. Place it under /tmp/kstars_tests

-Wolfgang

-Wolfgang

Tue, Aug 14, 6:01 AM · KDE Edu
mutlaqja added a reviewer for D14813: Adding XPlanet Viewer: mutlaqja.

Wow this is great and it's pretty much feature-complete! A few comments:

Tue, Aug 14, 5:19 AM · KDE Edu
kqwyf updated the diff for D14738: Add the markdown entry.
  • add FindDiscount.cmake
Tue, Aug 14, 5:09 AM · KDE Edu
kqwyf updated the diff for D14738: Add the markdown entry.
  • use Discount to convert Markdown to HTML
Tue, Aug 14, 2:58 AM · KDE Edu

Mon, Aug 13

lancaster requested review of D14813: Adding XPlanet Viewer.
Mon, Aug 13, 9:59 PM · KDE Edu
wreissenberger added a comment to D14684: Fixes for the Scheduler and Capture modules.

@TallFurryMan: I did not run the entire test set yet, but my problem mentioned on Fri, Aug 10, 2:19 PM still exists. The attached test case illustrate the wrong behavior.

Not sure whether the problem still exists after your changes, but I found a situation where the scheduler loops endlessly.

If you have two jobs with the same capture file signature (path + filter etc.) and the second has less repeats than the first, the first job will repeat endlessly.

The problem is that Scheduler::updateCompletedJobsCount() overwrites the map entry such that a later evaluation thinks that it has less captures than requested.

Please find included a test illustrating it. Place it under /tmp/kstars_tests

-Wolfgang

Mon, Aug 13, 9:15 PM · KDE Edu
mutlaqja closed D14684: Fixes for the Scheduler and Capture modules.
Mon, Aug 13, 8:51 PM · KDE Edu