The KDE Education Project
@kqwyf, Could you add feature, that if user's cursor comes from cell below, cursor appears not in begin of text, but in end?
Another type of entries have this functional, including text entry, so, I think, it's not very difficult to add this functional for MarkdownEntry.
- change all the indentation tabs into spaces
- remove extra changes
- update CMakeLists.txt
- bump the ui version in cantor_part.rc
- fix the memory leak when converting markdown to HTML
- feature: save evaluation results for markdown entries
Merged in https://commits.kde.org/gcompris/65dd0f53ebde9645355c1eee18b882f0d957294b
Good ! My email : jdemeyer hotmail com
Except the camel case, it's good for me, I can do the change and merge it. Can you share your email so I can commit with your name (else I can commit with my account)?
Oh no, sorry. I thought the authorship was maintained... when I answer:
@filipesaraiva you pushed a patch
- without all the changes required (see my note about bumping the UI version in cantor_part.rc)
- with known memory leaks
- without the proper authorship
Well this is merged back to master, so please check against master now. If testing goes OK, we can release 2.9.8
Thank you for your feedback.
@TallFurryMan: OK, if you re-tested it, let's assume that I am making some mistake in obtaining the same codebase. Since I am very new in using the Phabricator, I wouldn't be surprised.
@wreissenberger I don't see this part of my log in your log:
@wreissenberger I think I understand what happens in the log:
Nitpick: please provide a consistent indentation in the new files -- they seem to mix spaces and tabs.
Also, was this tested when cantor is built without the Discount library? How does it behave when trying to add/edit markdown entries, and trying to load worksheets with such entries?
- update macros about Discount
@kqwyf, after previous two diff cheanges, Markdown entries starts don't work for me (don't evaluate), is they works on your machine?
- fix the bug that it won't find Discount when doing cmake twice.
- add package properties for Discount
@kqwyf Could you find Discount twice? Because I could found Discount only in first cmake run, and in seconds I have
-- The following OPTIONAL packages have not been found:
- remove the commented code
- fix a bug that a command entry is appended when clicking a new markdown entry
If I insert Markdown entry from context menu (this menu also have "Evaluate Worksheet" action) in the end of worksheet and click after it, a command entry added. Could anyone reproduce it?
Thank you for your contribution @kqwyf. I built with Discount and it is working fine. I built without Discount, I could run Cantor correctly and the options to insert Markdown entries continues to show, but it is a problem with others entries options like LaTeX. Maybe it is time to some refactoring in this part.
Hm, strange. I checked out the latest version of D14684, compile it and run the test. When I run it, the first of the two jobs loops endlessly instead of terminating after three runs. See the attached log file.
@wreissenberger I tested your vector with the landed differential, and it succeeded in capturing the job with 3 batches, then the job with 2 batches.
While I didn't test specifically what could happen if I aborted the Scheduler in the middle of this test, I don't expect it to loop. I'll check again later.
- all the visible UI strings must be translatable using i18n & friends
- please cleanup the commit message, all the "merge branch" bits are not helpful (and beside that, the canonical location of kstars is git.kde.org, not github); also, please write more details on what is the feature, which code changes were done (e.g. code that was moved away form SkyMap), etc
- all the this-> stuff are not needed
Wow this is great and it's pretty much feature-complete! A few comments:
- add FindDiscount.cmake
- use Discount to convert Markdown to HTML
Mon, Aug 13
@TallFurryMan: I did not run the entire test set yet, but my problem mentioned on Fri, Aug 10, 2:19 PM still exists. The attached test case illustrate the wrong behavior.