TallFurryMan (Eric Dejouhanet)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 13 2018, 9:37 PM (116 w, 1 d)
Availability
Available

Recent Activity

May 31 2020

TallFurryMan added a comment to D29836: Code refactoring unifying capture initialization for new sequences and continuing of sequences.

Wolfgang, I sent you a Google Meet invite to help you out with this.

May 31 2020, 4:23 PM · KDE Edu

May 20 2020

TallFurryMan added a comment to D29821: Add autofocus on temperature change.

Excellent, thanks for this proposal! I have nothing but minor points, looks good to me.

May 20 2020, 6:01 AM · KDE Edu

May 11 2020

TallFurryMan added a comment to D29549: Updates to SkyPoint to improve positions.

This is excellent. Sorry to arrive late to the party, two comments from me, one about the test mode of QtTest, and the other about build failures with versions older than Qt 5.9.

May 11 2020, 7:31 AM · KDE Edu

May 7 2020

TallFurryMan added a comment to D29403: Add autofocus tests..

Actually, the fix for sigpipe would potentially be in INDI's baseclient.cpp...

May 7 2020, 5:52 AM · KDE Edu
TallFurryMan added a comment to D29403: Add autofocus tests..

@mutlaqja I debugged the last connect/disconnect issue of BaseClient to be a sigpipe exception. I'll file the fix with this differential.

May 7 2020, 5:35 AM · KDE Edu

May 4 2020

TallFurryMan planned changes to D29403: Add autofocus tests..

This differential is not finished yet. @mutlaqja please use it to test your changes with regards to INDI property usage.

May 4 2020, 11:58 AM · KDE Edu
TallFurryMan requested review of D29403: Add autofocus tests..
May 4 2020, 11:54 AM · KDE Edu
TallFurryMan added a comment to D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp).

My initial mail was blocked for moderation, sorry for this weird reply:

May 4 2020, 8:59 AM · KDE Edu
TallFurryMan added a comment to D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp).

Ah there will be a problem with your email being disclosed in the thread, so don't paste the commit log, sorry.
Tell us if your email matches your profile, in terms of committer or author.

May 4 2020, 7:18 AM · KDE Edu
TallFurryMan updated subscribers of D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp).

Patrick, could you share the result of "git log HEAD" (without the patch
part, only the header so we see the committer and the author) ? My KDE user
is "TallFurryMan" but my profile name there is "Eric Dejouhanet". More
importantly I think, my email is the same in my commits and in my profile.

May 4 2020, 7:14 AM · KDE Edu

May 3 2020

TallFurryMan updated the diff for D29389: Let UI tests customize the UI settings file..

Updated UI tests to properly set kstarsui.rc.

May 3 2020, 6:51 PM · KDE Edu
TallFurryMan requested review of D29389: Let UI tests customize the UI settings file..
May 3 2020, 6:50 PM · KDE Edu
TallFurryMan accepted D29388: Don't run fitsviewer test if no fitsio.

Thanks for this, I hadn't returned to it yet.

May 3 2020, 5:10 PM · KDE Edu, KStars

May 2 2020

TallFurryMan added a comment to D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp).

Well, we could redo this from the beginning.
You locate the commits that contain your changes and fixes (not the merges, let's leave those). You write down the commit identifiers.
You check kde/master out, and you derive a new branch from that with git checkout -tb new_bahtinov_attempt (-b will fork, -t will track).
You then sequentially apply your changes with git cherry-pick <commit-id>, resolving conflicts as they appear.
Then you push your changes with arc diff --update D29325 kde/master.

May 2 2020, 8:24 AM · KDE Edu

May 1 2020

TallFurryMan added a comment to D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp).

Yes you need the same committer name (not necessarily author name) in your tree and in phab.
You may change your user name by editing ~/.gitconfig.

May 1 2020, 3:09 PM · KDE Edu
TallFurryMan accepted D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp).

@mutlaqja This is great and good to go.

May 1 2020, 1:02 PM · KDE Edu
TallFurryMan added a comment to D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp).

Reviewing now.

May 1 2020, 12:48 PM · KDE Edu

Apr 25 2020

TallFurryMan added reviewers for D29099: Make the Focus capture action include star detection: mutlaqja, murveit.
Apr 25 2020, 7:19 AM · KDE Edu

Apr 24 2020

TallFurryMan added a comment to D29008: Use the mount Pier Side property to manage Pier Flip.

One small answer on the concurrent use of m_Status. Just for theory.

Apr 24 2020, 12:06 PM · KDE Edu

Apr 23 2020

TallFurryMan added a comment to D29008: Use the mount Pier Side property to manage Pier Flip.

Also, the summary will appear as commit in the kstars history, so you may want to rewrite it.

Apr 23 2020, 5:08 PM · KDE Edu
TallFurryMan added a comment to D29008: Use the mount Pier Side property to manage Pier Flip.

I'm sorry if I sounded harsh in my comments. The last thing I want is a flamewar between C# and C++ ;)

Apr 23 2020, 5:07 PM · KDE Edu

Apr 22 2020

TallFurryMan added a comment to D29099: Make the Focus capture action include star detection.

This is complete and ready to review.

Apr 22 2020, 9:59 PM · KDE Edu
TallFurryMan updated the diff for D29099: Make the Focus capture action include star detection.
  • Add a longer exposure test, add a delay based on required exposure frames, check stop button immediately.
  • Remove remaining reference to BZ398192, adjust timeouts.
  • Merge branch 'master' into improve__determine_star_detection_end
Apr 22 2020, 5:20 PM · KDE Edu
TallFurryMan requested review of D29099: Make the Focus capture action include star detection.
Apr 22 2020, 3:05 PM · KDE Edu
TallFurryMan added inline comments to D29008: Use the mount Pier Side property to manage Pier Flip.
Apr 22 2020, 9:15 AM · KDE Edu

Apr 21 2020

TallFurryMan added a comment to D29008: Use the mount Pier Side property to manage Pier Flip.

A few (pedantic) comments from me. Overall, this seems nice although I wasn't able to test. I am under the impression that something is missing for the new options, but I may be wrong.
The most annoying point for me is the broken test after stopping to track on HA limit. And also the system time instead of the simulation time, which will make things difficult to test.

Apr 21 2020, 7:51 PM · KDE Edu

Apr 17 2020

TallFurryMan requested review of D28928: Hotfix for non-INDI builds..
Apr 17 2020, 8:28 PM · KDE Edu

Apr 16 2020

TallFurryMan accepted D28767: SEP Focus improvements.

I will certainly not block a differential on an issue with source centers which we do not use afterwards :) Sorry for forgetting the "Accept Revision" flag.

Apr 16 2020, 8:41 PM · KDE Edu
TallFurryMan updated the diff for D28890: Make UI tests use a separate userdb.
  • Merge branch 'master' into improve__userdb_tests
Apr 16 2020, 5:15 PM · KDE Edu
TallFurryMan added a comment to D28890: Make UI tests use a separate userdb.

The Focus test is still quite long because there is currently no way to determine the star detection is finished.
And actually KStars sometimes crashes when a new capture is taken while the detection is still in progress. Another test to be built!

Apr 16 2020, 5:13 PM · KDE Edu
TallFurryMan added a comment to D28292: Refactoring the Focus module..

@bcooksley The fix for the non-INDI build is in D28890.

Apr 16 2020, 4:41 PM · KDE Edu
TallFurryMan updated the summary of D28890: Make UI tests use a separate userdb.
Apr 16 2020, 4:37 PM · KDE Edu
TallFurryMan requested review of D28890: Make UI tests use a separate userdb.
Apr 16 2020, 4:28 PM · KDE Edu
TallFurryMan added a comment to D28292: Refactoring the Focus module..

Should be fixed under the hour, I'm currently working on the diff.

Apr 16 2020, 4:27 PM · KDE Edu
TallFurryMan added a comment to D28767: SEP Focus improvements.

But when I look closely at your pictures, it seems the circles are offset to the right and bottom in both cases. I'm not referring to the width, I'm really talking about the center. Note that the pencil I was using had a width of 2, so it might be the reason? A pencil graphics code drawing stuff with all lines widths extended only to the right and bottom? That's entirely possible (and quite hateful).

Apr 16 2020, 6:41 AM · KDE Edu
TallFurryMan added a comment to D28767: SEP Focus improvements.

About my concerns on rendering red circles, my point was that when you use a center and a radius to draw an ellipse, the center is set to a pixel. Therefore you risk to offset your ellipses when you should be using a subpixel as center. Agreed, this is only visible on very small stars, but it was annoying for me at the time, and made me incorrectly think this could be the reason my focus wasn't good or my solver was failing (newbie thoughts of course, but very real).

Apr 16 2020, 6:32 AM · KDE Edu

Apr 12 2020

TallFurryMan added a comment to D28767: SEP Focus improvements.

Also would it be possible to report on the performance improvement with numbers? I'm curious!

Apr 12 2020, 8:00 AM · KDE Edu
TallFurryMan added a comment to D28767: SEP Focus improvements.

That's excellent! I have several points in the comments. I would also like you to add more FITS fixtures captured with the CCD Simulator or real pictures, with various FWHM values (use the focuser simulator) to verify your improvements.

Apr 12 2020, 7:59 AM · KDE Edu

Apr 10 2020

TallFurryMan added a comment to D28292: Refactoring the Focus module..

Hey that's cheating, it's a build that began 3 days ago :) Joking, thanks for reporting @bcooksley, test_ekos_focus should not be built when there is no INDI installed.

15:12:30  -- The following OPTIONAL packages have not been found:
15:12:30  
15:12:30   * INDI (required version >= 1.7.1), Astronomical instrumentation control, <https://www.indilib.org>
15:12:30     Support for controlling astronomical devices on Linux with KStars.
15:12:30   * WCSLIB, World Coordinate System library, <https://www.atnf.csiro.au/people/mcalabre/WCS>
15:12:30     WCS enables KStars to read and process world coordinate systems in FITS header.
Apr 10 2020, 7:20 PM · KDE Edu

Apr 8 2020

TallFurryMan added a comment to D28689: Hotfixes for the Focus module.

A few things I wanted to add but will delay:

  • UI does not reflect the use of SEP and Centroid for initial detection, nor for full-field analysis.
  • Due to the first point, the tests are not properly verifying the Threshold and Gradient algorithms because the full-field analysis option is set!
  • UI does a weird toggle on the capture button when preparing the screen, and re-enables said button *before* the star extraction completes (that code block is tricky to refactor).
  • Due to the first point, the tests need to wait an arbitrary duration to verify the detection results.
Apr 8 2020, 10:13 PM · KDE Edu
TallFurryMan requested review of D28689: Hotfixes for the Focus module.
Apr 8 2020, 10:03 PM · KDE Edu

Apr 6 2020

TallFurryMan updated subscribers of D28635: Tests for the star detection.

@murveit this should help you chase regressions. There's no obvious possibility to test the result of QBENCHMARK, but you just have to write the original duration down and evaluate your optimizations.

Apr 6 2020, 8:17 PM · KDE Edu
TallFurryMan added a comment to D28292: Refactoring the Focus module..

@murveit I added differential D28635 with a very simple test class for the FITS viewer. I simply picked a branch that I had created while waiting for more formalism to transpire from https://indilib.org/forum/wish-list/6591-collimation-circles.html, hence the name.

Apr 6 2020, 8:15 PM · KDE Edu
TallFurryMan requested review of D28635: Tests for the star detection.
Apr 6 2020, 8:09 PM · KDE Edu
TallFurryMan updated the diff for D28292: Refactoring the Focus module..
  • Reworked merged verification of BZ398192.
Apr 6 2020, 7:59 PM · KDE Edu

Apr 5 2020

TallFurryMan added a comment to D28292: Refactoring the Focus module..

Verification of BZ398192 is done with this simple test in test_ekos_simulator.cpp:

Apr 5 2020, 8:48 PM · KDE Edu
TallFurryMan updated the diff for D28292: Refactoring the Focus module..
  • Merged verification of BZ398192 in.
Apr 5 2020, 8:46 PM · KDE Edu
TallFurryMan updated the summary of D28292: Refactoring the Focus module..
Apr 5 2020, 12:40 PM · KDE Edu
TallFurryMan updated the summary of D28292: Refactoring the Focus module..
Apr 5 2020, 12:39 PM · KDE Edu
TallFurryMan added a comment to D28292: Refactoring the Focus module..

Also I should rewrite a bit the differential log, not exact.

Apr 5 2020, 11:32 AM · KDE Edu
TallFurryMan updated subscribers of D28292: Refactoring the Focus module..

@murveit the SEP code has been moved to fitsdatasepdetector.cpp.
If we merge your changes before mine, I can take care of merging.
If we merge my changes before yours, you will need to move your changes there.
I'll be creating a test for the detection code purely in another differential.
I need to verify the BZ bug about INDI disconnection hanging Ekos first.

Apr 5 2020, 11:31 AM · KDE Edu
TallFurryMan updated the diff for D28292: Refactoring the Focus module..

Not that difficult in the end.

Apr 5 2020, 11:27 AM · KDE Edu
TallFurryMan planned changes to D28292: Refactoring the Focus module..

Now the headache work: merging master changes in.

Apr 5 2020, 11:20 AM · KDE Edu
TallFurryMan updated the diff for D28292: Refactoring the Focus module..
  • Reset KStars time after starting Ekos.
  • Fix object fixture builder.
  • Slight delay to overcome the weird toggling of the capture button.
  • Separate/simplify annulus and threshold tests.
  • Delay target chip retrieval when capture is complete.
  • Test frame average, extract code averaging HFRs, fix HFR unexpected reset.
Apr 5 2020, 11:16 AM · KDE Edu
TallFurryMan requested changes to D28477: Fixes a bug where the HFR was not displayed..

I'd like to see a unitary test for this. A simple thing that loads a star cluster fits generated with the CCD simulator, and runs a star detection using SEP. My differential uses UI tests, which are an entirely different method, possibly maybe useful for changes spanning multiple modules.

Apr 5 2020, 7:34 AM · KDE Edu

Apr 3 2020

TallFurryMan requested changes to D28477: Fixes a bug where the HFR was not displayed..

I'm OK, except for the change from Centroid to SEP. SEP requires more cpu resources than Centroid, so should maybe not be the default. My position is arguable, of course. I agree there are not that many stars detected by the Centroid algorithm in the general real-life situation, so maybe we need to fix Centroid instead?

Apr 3 2020, 1:38 PM · KDE Edu

Mar 30 2020

TallFurryMan updated the summary of D28292: Refactoring the Focus module..
Mar 30 2020, 8:51 PM · KDE Edu
TallFurryMan planned changes to D28292: Refactoring the Focus module..

Still a WIP, but progressing fairly well I think.

Mar 30 2020, 8:48 PM · KDE Edu
TallFurryMan updated the diff for D28292: Refactoring the Focus module..

These additional changes build up on tests, and move detection methods out of the Focus class.

Mar 30 2020, 8:47 PM · KDE Edu

Mar 25 2020

TallFurryMan added a comment to D28292: Refactoring the Focus module..

Spotted KTRY_EKOS_CLICK that I forgot to refactor in the same vein as KTRY_FOCUS_CLICK.

Mar 25 2020, 11:10 PM · KDE Edu
TallFurryMan planned changes to D28292: Refactoring the Focus module..
Mar 25 2020, 11:08 PM · KDE Edu
TallFurryMan requested review of D28292: Refactoring the Focus module..
Mar 25 2020, 11:08 PM · KDE Edu

Mar 21 2020

TallFurryMan requested review of D28177: Removed simulator startup clock test for Qt<5.8..
Mar 21 2020, 7:19 AM · KDE Edu

Mar 18 2020

TallFurryMan requested review of D28117: Attempt to fix Ubuntu 16.04 build, that is using Qt 5.5..
Mar 18 2020, 9:00 AM · KDE Edu

Mar 4 2020

TallFurryMan requested review of D27820: Fix warning treated as error on bionic..
Mar 4 2020, 6:49 AM · KDE Edu

Mar 2 2020

TallFurryMan requested review of D27739: Auxiliary tests (skeletons)..
Mar 2 2020, 8:23 PM · KDE Edu
TallFurryMan planned changes to D27739: Auxiliary tests (skeletons)..

So, compatible with Extragear build as of now. As far as I understand, additional (empty) tests will be added to the test step automatically...?

Mar 2 2020, 8:22 PM · KDE Edu
TallFurryMan updated the diff for D27739: Auxiliary tests (skeletons)..
  • Revert to multiple test executables, fix copyrights.
Mar 2 2020, 8:19 PM · KDE Edu
TallFurryMan added a comment to D27739: Auxiliary tests (skeletons)..

Looking at the current Extragear build for SuSE, I see that:

Mar 2 2020, 7:49 PM · KDE Edu
TallFurryMan added a comment to D27739: Auxiliary tests (skeletons)..

Next I'll be looking into adding those tests to the build.

Mar 2 2020, 7:38 PM · KDE Edu
TallFurryMan updated the diff for D27739: Auxiliary tests (skeletons)..
  • Fix missing copyright.
Mar 2 2020, 7:33 PM · KDE Edu
TallFurryMan updated the diff for D27739: Auxiliary tests (skeletons)..

Rebased.

Mar 2 2020, 7:31 PM · KDE Edu
TallFurryMan requested review of D27773: Fix OpenSUSE build error on incomplete type KStarsData..
Mar 2 2020, 8:16 AM · KDE Edu

Feb 29 2020

TallFurryMan added a comment to D27678: Restructure tests, add simulator tests, spot expected failures..

Yes, as it now, it's ok to me.

Feb 29 2020, 11:16 PM · KDE Edu
TallFurryMan planned changes to D27739: Auxiliary tests (skeletons)..

This bases on D27678, so the diff may be quite unreadable for now. I'll rebase when D27678 is merged.

Feb 29 2020, 1:15 PM · KDE Edu
TallFurryMan requested review of D27739: Auxiliary tests (skeletons)..
Feb 29 2020, 1:14 PM · KDE Edu

Feb 27 2020

TallFurryMan added a comment to D27678: Restructure tests, add simulator tests, spot expected failures..

Updated. @yurchor there were apparently no issues with newlines at the end of files.

Feb 27 2020, 8:17 PM · KDE Edu
TallFurryMan updated the diff for D27678: Restructure tests, add simulator tests, spot expected failures..
  • Fix copyrights.
Feb 27 2020, 8:14 PM · KDE Edu
TallFurryMan planned changes to D27678: Restructure tests, add simulator tests, spot expected failures..
Feb 27 2020, 9:12 AM · KDE Edu

Feb 26 2020

TallFurryMan updated the diff for D27678: Restructure tests, add simulator tests, spot expected failures..
  • Fix formatting.
Feb 26 2020, 7:25 PM · KDE Edu
TallFurryMan added a comment to D27678: Restructure tests, add simulator tests, spot expected failures..

I'm writing that for kstars classes, with empty test plans. I'll see what I can do for UI tests, although that's less easy as the source of a UI test is a use case.

Feb 26 2020, 7:08 PM · KDE Edu
TallFurryMan added a comment to D27678: Restructure tests, add simulator tests, spot expected failures..

Please don't test this on your own setup, because it may change your userdb (it doesn't right now, but will certainly).
I need a way to use another database, so that options are all default.

Feb 26 2020, 1:42 PM · KDE Edu
TallFurryMan requested review of D27678: Restructure tests, add simulator tests, spot expected failures..
Feb 26 2020, 1:17 PM · KDE Edu

Feb 23 2020

TallFurryMan requested review of D27593: Adding test for Ekos start/stop..
Feb 23 2020, 10:30 AM · KDE Edu

Feb 20 2020

TallFurryMan requested review of D27524: Fix qCompare between strings..
Feb 20 2020, 4:50 PM · KDE Edu

Feb 15 2020

TallFurryMan updated the diff for D27008: Rework of UI tests, KStars window and Ekos profile..
  • Fix rogue include.
Feb 15 2020, 4:24 AM · KDE Edu

Feb 14 2020

TallFurryMan updated the diff for D27008: Rework of UI tests, KStars window and Ekos profile..
  • Update for rebase.
Feb 14 2020, 8:11 AM · KDE Edu

Jan 30 2020

TallFurryMan added a comment to D27008: Rework of UI tests, KStars window and Ekos profile..

In this diff, quite a few blocks could be refactored: finding gadgets, clicking things, managing dialogs...
Currently, the test runs as fast as it can by using timeouts on states instead of sleeping (except for QTimer::singleShot calls), so when tests all pass, the duration is ~5 seconds on my laptop (most of which is KStars loading).
Fixtures should be integrated in order to test many more situations with a single action flow.
Also, I did not investigate the lack of menu and toolbar in KStars.

Jan 30 2020, 7:10 AM · KDE Edu
TallFurryMan added a comment to D27008: Rework of UI tests, KStars window and Ekos profile..

The way the project was implemented originally is to test the end-user side of manipulations, using UI as much as possible.
Effectively, this is final integration test which could probably be difficult to maintain and automate.
Running tests with a full stack, from star map down to drivers, could also have a long duration, making it less suitable to automation (imagine scheduler tests over three days).

Jan 30 2020, 7:02 AM · KDE Edu

Jan 29 2020

TallFurryMan added a reviewer for D27008: Rework of UI tests, KStars window and Ekos profile.: KStars.
Jan 29 2020, 8:48 PM · KDE Edu
TallFurryMan requested review of D27008: Rework of UI tests, KStars window and Ekos profile..
Jan 29 2020, 8:48 PM · KDE Edu

Jan 8 2020

TallFurryMan added a comment to D26509: Fix manualfocusdrive based focus bug due to fix in commit de12d97ddefc.

I cannot test this, so I offer pedantic comments ;)

Jan 8 2020, 3:43 PM · KDE Edu

Dec 9 2019

TallFurryMan added a comment to D25380: Abort plate solving when slewing is detected.

(I originally posted this comment in the wrong diff, sorry)

Dec 9 2019, 7:00 AM · KDE Edu

Dec 4 2019

TallFurryMan added a comment to D19393: Prevent rescheduling aborted jobs until all jobs are processed.

EDIT: wrong ticket......

Dec 4 2019, 4:13 PM · KDE Edu

Nov 29 2019

TallFurryMan abandoned D15837: Fix for the Dome interface.
Nov 29 2019, 5:52 PM · KDE Edu
TallFurryMan added a comment to D15837: Fix for the Dome interface.

I think you fixed that long ago. I kept it to reinsert logs.

Nov 29 2019, 5:52 PM · KDE Edu
TallFurryMan added a comment to D15359: When auto-focusing, re-capture if no stars are detected, instead of waiting for user selection..

Sorry I'm overbooked, I can't return to this yet.

Nov 29 2019, 5:50 PM · KDE Edu
TallFurryMan added a comment to D15363: Avoid losing completed count when capture was suspended by a guiding deviation..

Sorry I'm overbooked, I can't return to this yet.

Nov 29 2019, 5:48 PM · KDE Edu

Nov 2 2019

TallFurryMan added inline comments to D25110: Ensure that guiding is running when capture is started.
Nov 2 2019, 10:22 AM · KDE Edu

Oct 3 2019

TallFurryMan added a comment to D19998: Remove bypass of preliminary steps when no light frames are needed..

Oh I totally forgot about this one. Actually, it's interesting in the sense it can be used to ensure a mean ADU over the frame. That is, calculate the ideal exposure duration. But there are things to fix, as seen in the comments. I keep this in my list and I'll have a look just because it's cool.

Oct 3 2019, 6:33 PM · KDE Edu