TallFurryMan (Eric Dejouhanet)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 13 2018, 9:37 PM (34 w, 4 d)
Availability
Available

Recent Activity

Fri, Dec 7

TallFurryMan updated the diff for D16429: Rewrite of Scheduler planning.
  • Minor grammar typo.
Fri, Dec 7, 7:30 AM · KDE Edu
TallFurryMan updated the diff for D16429: Rewrite of Scheduler planning.
  • Fix regression on current job status.
Fri, Dec 7, 7:25 AM · KDE Edu

Mon, Dec 3

TallFurryMan updated the test plan for D16429: Rewrite of Scheduler planning.
Mon, Dec 3, 7:24 AM · KDE Edu

Sun, Dec 2

TallFurryMan added a reviewer for D16429: Rewrite of Scheduler planning: lancaster.
Sun, Dec 2, 2:35 AM · KDE Edu
TallFurryMan updated the diff for D16429: Rewrite of Scheduler planning.

Complete list of changes. Job selection highlight is now under control.

Sun, Dec 2, 2:33 AM · KDE Edu

Wed, Nov 28

TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

OK the index concept of currentRow and the index concept of selectRow are different. I will move to a custom QModelIndex as soon as possible.

Wed, Nov 28, 12:51 PM · KDE Edu
TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

@wreissenberger Thanks your patch! I observed that when sorting jobs per altitude manually and sorting is not expected to change the order, the selection moves up by itself one row at a time. I'll check this.

Wed, Nov 28, 11:07 AM · KDE Edu

Mon, Nov 26

TallFurryMan accepted D17159: bug fix #400265: meridian flip check before capturing.
Mon, Nov 26, 8:34 PM
TallFurryMan added a comment to D17148: Make Star Profile Viewer localizable.

In the case of floating point, either QString("%L1").arg() or ki18n().subs() should be used, and HFR is a float (no i18n with args here).
But I didn't investigate whether, while the QString method systematically used the system locale, the ki18n could handle a locale switch in the application without system locale changes.

Mon, Nov 26, 8:38 AM · KDE Edu
TallFurryMan requested changes to D17159: bug fix #400265: meridian flip check before capturing.
Mon, Nov 26, 6:52 AM
TallFurryMan added a comment to D17148: Make Star Profile Viewer localizable.

You should use QString("%L1").arg(variable, width, 'f', précision) to properly format floating point values using the decimal point of the locale

Mon, Nov 26, 5:43 AM · KDE Edu

Thu, Nov 22

TallFurryMan added a comment to F6436162: reorderJobs.diff.

OK that's clear :) thanks for taking the time to check this!

Thu, Nov 22, 6:20 AM
TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

Go ahead and post, I can integrate it to this differential.

Thu, Nov 22, 12:10 AM · KDE Edu

Wed, Nov 21

TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

With the option "Sort Jobs per Altitude and Priority" enabled, re-sorting in the edit mode leads to a wrong selection in the queue table.

Test case:

  • Create a schedule with two jobs, where the two jobs have different priorities. Edit the job with the higher priority and change it to a value that its new priority is lower than that of the other job.
  • As a result, the schedule is automatically reordered.
  • Nevertheless, the selection in the queue table remains at the same position.
Wed, Nov 21, 5:01 PM · KDE Edu

Tue, Nov 20

TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

Issue found: when changing the start-up constraint from asap to fixed time, and there are two jobs in the list, the second job is overwritten with the first job contents.
Investigation in progress to determine the root cause.

Tue, Nov 20, 6:39 AM · KDE Edu

Sun, Nov 18

TallFurryMan updated the test plan for D16429: Rewrite of Scheduler planning.
Sun, Nov 18, 9:10 AM · KDE Edu

Sat, Nov 17

TallFurryMan planned changes to D15837: Fix for the Dome interface.

This went out of my list, I'll check this. I think the main point - the dome - was merged.

Sat, Nov 17, 9:50 PM · KDE Edu
TallFurryMan updated the test plan for D16429: Rewrite of Scheduler planning.
Sat, Nov 17, 2:33 PM · KDE Edu
TallFurryMan updated the summary of D16429: Rewrite of Scheduler planning.
Sat, Nov 17, 2:09 PM · KDE Edu
TallFurryMan updated the test plan for D16429: Rewrite of Scheduler planning.
Sat, Nov 17, 2:09 PM · KDE Edu
TallFurryMan updated the test plan for D16429: Rewrite of Scheduler planning.
Sat, Nov 17, 2:07 PM · KDE Edu

Thu, Nov 15

TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

Progressing on use cases at https://github.com/TallFurryMan/kstars/wiki.

Thu, Nov 15, 7:29 AM · KDE Edu

Mon, Nov 12

TallFurryMan updated the summary of D16429: Rewrite of Scheduler planning.
Mon, Nov 12, 7:29 AM · KDE Edu

Nov 10 2018

TallFurryMan updated the summary of D16429: Rewrite of Scheduler planning.
Nov 10 2018, 4:11 PM · KDE Edu
TallFurryMan updated the diff for D16429: Rewrite of Scheduler planning.

Differential changes are now complete.
Please start testing now while I write the changeset documentation and describe integration tests!

Nov 10 2018, 4:09 PM · KDE Edu

Nov 9 2018

TallFurryMan updated the diff for D16429: Rewrite of Scheduler planning.

Still WIP, not entirely rebased, but shows were the rewrite is at.
UI is probably prettier than it was before, but that won't help the first Ekos tab.
Altitude sorting is clarified with the UI rework, but clicking the sort button is not stable.
Row selection is still to be fixed.
All schedule consolidation issues are now fixed!
I'm nearly finished, still quite a bit of testing needed.

Nov 9 2018, 8:43 AM · KDE Edu

Nov 3 2018

TallFurryMan planned changes to D16429: Rewrite of Scheduler planning.
Nov 3 2018, 8:39 PM · KDE Edu
TallFurryMan reclaimed D16429: Rewrite of Scheduler planning.
Nov 3 2018, 8:39 PM · KDE Edu
TallFurryMan abandoned D16429: Rewrite of Scheduler planning.
Nov 3 2018, 8:38 PM · KDE Edu
TallFurryMan updated the diff for D16429: Rewrite of Scheduler planning.

Still WIP, need to rebase, fix a few logs and add altitude as a column.

  • Rewrote algorithm documentation.
  • Fixes from Phabricator comments.
Nov 3 2018, 8:38 PM · KDE Edu
TallFurryMan added inline comments to D16429: Rewrite of Scheduler planning.
Nov 3 2018, 8:37 PM · KDE Edu
TallFurryMan planned changes to D16429: Rewrite of Scheduler planning.
Nov 3 2018, 2:52 PM · KDE Edu
TallFurryMan added inline comments to D16429: Rewrite of Scheduler planning.
Nov 3 2018, 2:52 PM · KDE Edu

Nov 2 2018

TallFurryMan updated the diff for D16429: Rewrite of Scheduler planning.

This is still a WIP. Posting advancements to share progress.

Nov 2 2018, 9:08 PM · KDE Edu

Oct 28 2018

TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

I also plan to add altitude for startup time, with an icon showing whether the target is rising or setting.

Oct 28 2018, 5:48 PM · KDE Edu
TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

This weekend I found out that most calculations in the scheduler were using the current date instead of the job date (which could be the next day, thus offset with ~15min), and that sometimes local to universal conversions were using the time zone of the system running KStars, instead of the geographic location of the observatory. But trying for instance to calculate the culmination of a target at a future date is somewhat tricky with the current code.

Oct 28 2018, 5:46 PM · KDE Edu
TallFurryMan added a comment to D16429: Rewrite of Scheduler planning.

Thanks for this report!

  1. Yes, agreed, the way the QWidgetTable works for selection is implemented and documented in such a contrived way that it appears to be bugged. SelectRow() should be used, but never results in the right effect. There are apparently several follow-up signals that make a mess with the rendering...
  2. I agree also there, the behavior of the sort option is opaque. Well, for the altitude at least. It works well only when the targets are all asap, and all rising. I plan to change the order predicate so that prioritary targets are the one setting, not the highest ones. Moreover, there's no point in sorting both in priority and altitude probably. Except for infinitely looping jobs, priority is a weird feature now...
Oct 28 2018, 3:48 PM · KDE Edu

Oct 25 2018

TallFurryMan added reviewers for D16429: Rewrite of Scheduler planning: mutlaqja, wreissenberger.
Oct 25 2018, 7:48 PM · KDE Edu
TallFurryMan requested review of D16429: Rewrite of Scheduler planning.
Oct 25 2018, 7:47 PM · KDE Edu

Oct 13 2018

TallFurryMan retitled D16173: Fix regression on job deletion when sorting jobs based on altitude and priority is enabled. from Fix regression on job deletion when sorting jobs based on alitude and priority is enabled. to Fix regression on job deletion when sorting jobs based on altitude and priority is enabled..
Oct 13 2018, 8:01 AM · KDE Edu
TallFurryMan requested review of D16151: Use "Remember Job Progress" in Scheduler and "Always Reset Sequence When Starting" in Capture..

Regression fixed in D16173.

Oct 13 2018, 8:01 AM · KDE Edu
TallFurryMan requested review of D16173: Fix regression on job deletion when sorting jobs based on altitude and priority is enabled..
Oct 13 2018, 8:00 AM · KDE Edu

Oct 12 2018

TallFurryMan added inline comments to D15937: Do not alter the state of the Scheduler while evaluating.
Oct 12 2018, 8:19 PM · KDE Edu
TallFurryMan added inline comments to D14665: Edit scheduler jobs with double-click and update icon to match Capture module..
Oct 12 2018, 8:16 PM · KDE Edu
TallFurryMan added a comment to D16151: Use "Remember Job Progress" in Scheduler and "Always Reset Sequence When Starting" in Capture..

I can't believe it: the side-effect is in D14665... Back to August 7th... I'll issue a fix.

Oct 12 2018, 8:11 PM · KDE Edu
TallFurryMan added a comment to D16151: Use "Remember Job Progress" in Scheduler and "Always Reset Sequence When Starting" in Capture..

D15937Sorry! Finally got it. I tried to guess what would be your configuration, and found the relation with "Sort Jobs by Altitude and Priority".
This is a regression to D15937 indeed, unrelated to D16151.

Oct 12 2018, 8:05 PM · KDE Edu
TallFurryMan added a comment to D16151: Use "Remember Job Progress" in Scheduler and "Always Reset Sequence When Starting" in Capture..

DSooo I have no problem deleting scheduler jobs with my own codebase.
I'll check if I'm really up-to-date, right now I don't see any regression, neither in D16151 nor in D15937...

Oct 12 2018, 8:01 PM · KDE Edu
TallFurryMan added a comment to D16151: Use "Remember Job Progress" in Scheduler and "Always Reset Sequence When Starting" in Capture..

So that's certainly a regression on D15937. I remember testing with full schedules, but not trying to modify one. I'll double check, thanks.

Oct 12 2018, 11:01 AM · KDE Edu
TallFurryMan added a comment to D16151: Use "Remember Job Progress" in Scheduler and "Always Reset Sequence When Starting" in Capture..

Huh? I didn't expect this report :) you mean you can't delete scheduler jobs, or sequence jobs?

Oct 12 2018, 10:04 AM · KDE Edu
TallFurryMan abandoned D16058: Move "Remember Job Progress" to Scheduler option pane..

Differential is renewed as D16151, let's continue discussing there.

Oct 12 2018, 7:23 AM · KDE Edu
TallFurryMan requested review of D16151: Use "Remember Job Progress" in Scheduler and "Always Reset Sequence When Starting" in Capture..
Oct 12 2018, 7:22 AM · KDE Edu

Oct 11 2018

TallFurryMan added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

Having a visible option is not that good for user experience, I'll settle for the warning only.

Oct 11 2018, 8:25 PM · KDE Edu
TallFurryMan added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

For sure. Right now both Scheduler and Capture source codes are very hard to read, and it's possible that many contributions aren't concluding into pull requests because of that. Any attempt at cleanup should base on such a list of use cases. How could we involve the community on this?

Oct 11 2018, 11:06 AM · KDE Edu
TallFurryMan added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

Jasem I also need to remove your (early) optimization which is not re-loading the sequence when looping a schedule job, as counts have to be reset by the Scheduler if the end-user manipulated the storage. Also if for some reason a repeating job was interrupted and is restarting anew, we need to send again the sequence.

Oct 11 2018, 8:13 AM · KDE Edu
TallFurryMan added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

I tested a few use cases, and I couldn't find a situation where I myself would benefit from that option. So I added a warning in the bottom console when such reset happens. Will push soon.

Oct 11 2018, 6:07 AM · KDE Edu

Oct 10 2018

TallFurryMan added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

Thanks for these comments!

Oct 10 2018, 2:45 PM · KDE Edu
TallFurryMan added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

A few notes for clarity, and for you to shout if you disagree in advance:

Oct 10 2018, 12:21 PM · KDE Edu
TallFurryMan added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

I was about to push the missing history, but I'm delaying as I found an issue with the way the completed frame count is set when ignoreJobProgress is not set.
The count is taken to be sequenceID minus one, but that can't be correct if there are missing files in the series on disk.
I'll disconnect this relation, Capture should do what it is told to by the configured sequence, or rely on what required count the Scheduler is providing.

Oct 10 2018, 11:59 AM · KDE Edu
TallFurryMan added a comment to D15937: Do not alter the state of the Scheduler while evaluating.

Yes, when jobs are not sorted per priority/altitude, re-evaluating is necessary each time a job is moved. When that option is enabled, you can't move jobs anymore. I will push an additional differential to actually sort the visible list automatically when "Sort jobs by Altitude and Priority" is enabled for better user feedback.

Oct 10 2018, 11:19 AM · KDE Edu
TallFurryMan added a comment to D15937: Do not alter the state of the Scheduler while evaluating.

Could someone test and merge this one? Or does it have issues applying?

Oct 10 2018, 5:43 AM · KDE Edu

Oct 9 2018

TallFurryMan added a comment to D16058: Move "Remember Job Progress" to Scheduler option pane..

Ok currently there is no way in the capture module to "Forget job progress" hence it is taken from options. So there should be a way for the user to know "Ok, I don't want to resume, I want to start from scratch now". Maybe there are other use cases where the user _always_ want to start to scratch so this has to be taken into consideration.

Oct 9 2018, 10:44 AM · KDE Edu
TallFurryMan planned changes to D16058: Move "Remember Job Progress" to Scheduler option pane..

Indeed I missed many things here. Sorry for pushing something so incorrect...

Oct 9 2018, 7:54 AM · KDE Edu
TallFurryMan requested review of D16058: Move "Remember Job Progress" to Scheduler option pane..
Oct 9 2018, 7:07 AM · KDE Edu

Oct 8 2018

TallFurryMan added a comment to D15837: Fix for the Dome interface.

I did a quick test, and it appears the dome simulator is already unparked when starting. I'll fix the park/unpark request in the same way as the mount. I'll also check the dustcap.

Oct 8 2018, 11:36 AM · KDE Edu

Oct 4 2018

TallFurryMan added a comment to D15837: Fix for the Dome interface.

The property should match the content of the XMLs in the root folder. I can see there is a property named parkStatus and a signal named newParkStatus for those devices. I haven't yet returned to that diff, sorry.

Oct 4 2018, 10:52 AM · KDE Edu
TallFurryMan added a comment to D15937: Do not alter the state of the Scheduler while evaluating.

I also plan to reorder the jobs automatically directly in the queue table when "Sort jobs by Altitude and Priority" is enabled, to provide a clearer feedback to the end-user.

Oct 4 2018, 7:28 AM · KDE Edu
TallFurryMan added inline comments to D15937: Do not alter the state of the Scheduler while evaluating.
Oct 4 2018, 7:27 AM · KDE Edu
TallFurryMan updated the diff for D15937: Do not alter the state of the Scheduler while evaluating.

Rewrote cast to double with static_cast.

Oct 4 2018, 7:21 AM · KDE Edu
TallFurryMan requested review of D15937: Do not alter the state of the Scheduler while evaluating.
Oct 4 2018, 7:08 AM · KDE Edu

Oct 3 2018

TallFurryMan added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Ah ! Interesting ! Thanks!

Oct 3 2018, 3:49 PM · KDE Edu
TallFurryMan added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

Hi Eric,
I get an error message from arc patch

arc patch D14942
Created and checked out branch arcpatch-D14942.

    This diff is against commit 018f6986f3887648a6f31f0597de063a53a92675, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (40d75559189dabe735a9f9e55c0641ba86a58ef7)

Should I continue or otherwise where could I get the missing commit? It does not seem to exist in the GIT master

Oct 3 2018, 2:34 PM · KDE Edu
TallFurryMan added a comment to D14942: Update job completion counts, and fix regression on job rescheduling..

It seems I accepted my own change, but I have no idea how I did that. It was a bit late, sorry.
This morning I finished verifying all test vectors, so this differential is ready from my point of view and I will base further changes on it.
This differential might not be a bit rough in two cases: approaching twilight, and approaching altitude limit. Those issues are next on my list.

Oct 3 2018, 12:06 PM · KDE Edu
TallFurryMan added a comment to D15837: Fix for the Dome interface.

OK it might be that the property parkStatus is not converted properly. It is working for the mount interface, so I think it should be easy to spot differences there.

Oct 3 2018, 9:40 AM · KDE Edu

Oct 2 2018

TallFurryMan added a comment to D15837: Fix for the Dome interface.

I assume you have a Dome in your profile. I also assume that you have the syntax error fix in your tree (it is in this differential, but Jasem did also merge the fix in parallel before the final version of this fix), so hopefully there is no further syntax error introduced? Indi state 4 is INDI_PROPERTY_CHECK, so your setup is hung waiting for one of these four things to come up: dome, mount, dustcap or capture interface. There are logs for each of these, added by this differential. Which ones do you see?

Oct 2 2018, 5:57 AM · KDE Edu
TallFurryMan updated the diff for D14942: Update job completion counts, and fix regression on job rescheduling..

Reworked differential to fix schedule of jobs.

Oct 2 2018, 12:15 AM · KDE Edu
TallFurryMan updated the test plan for D14942: Update job completion counts, and fix regression on job rescheduling..
Oct 2 2018, 12:14 AM · KDE Edu

Sep 30 2018

TallFurryMan requested review of D15865: Use system locale to display numbers in the scheduler..
Sep 30 2018, 8:09 PM · KDE Edu
TallFurryMan added a comment to D15837: Fix for the Dome interface.

OK. Should I drop the rest of the differential?

Sep 30 2018, 7:43 AM · KDE Edu

Sep 29 2018

TallFurryMan requested review of D15837: Fix for the Dome interface.
Sep 29 2018, 4:23 PM · KDE Edu
TallFurryMan added a comment to D15546: Fix Scheduler slewing stage and dome interaction..

I'm working on the job termination issue. Will fix all of them at once. I'll first debug the cmake stuff with the moc generation, perhaps we could remove the XMLs in the source and install the generated XML interfaces instead. If that's already the case, I'll just drop the source XMLs.

Sep 29 2018, 11:54 AM · KDE Edu
TallFurryMan added a comment to D15546: Fix Scheduler slewing stage and dome interaction..

My problem is that I can't seem to regenerate mocs properly. The XML used by the mocs are generated on-the-fly, supposedly from the class header and not from the source XML, but while dustcap, mount and other interfaces create the ready() signal flawlessly, the dome interface will just not get it through. And I don't know why yet, which is irritating...

Sep 29 2018, 8:59 AM · KDE Edu
TallFurryMan added a comment to D15546: Fix Scheduler slewing stage and dome interaction..

Mmmh, dome recovery is not working entirely yet. But this is a first step. It can be merged, or I can push an update if I find the time to fix.

Sep 29 2018, 7:44 AM · KDE Edu

Sep 28 2018

TallFurryMan updated the diff for D15546: Fix Scheduler slewing stage and dome interaction..

Updated differential.

Sep 28 2018, 8:45 PM · KDE Edu
TallFurryMan updated the test plan for D15546: Fix Scheduler slewing stage and dome interaction..
Sep 28 2018, 8:44 PM · KDE Edu

Sep 27 2018

TallFurryMan added a comment to D15546: Fix Scheduler slewing stage and dome interaction..

OK, so properties are straightened up (not all of them) and I understand better the design.
I'm working on the issue that if the mount/dome/dustcap park/unpark is not checked, properties don't come up.
If scheduler is stopped, then those boxes are checked, then scheduler is restarted, scheduler hangs waiting for either one.
Mitigation is possible, but stopEkos does not reset its state properly, and cannot recover.
Probably a regression. I'm about to break through on this.

Sep 27 2018, 7:43 AM · KDE Edu

Sep 18 2018

TallFurryMan planned changes to D15546: Fix Scheduler slewing stage and dome interaction..

On hold until I really understand how QT_PROPERTY works.
Modifying the interface xml apparently has no impact on the resulting executable, and thus my test is not effective on dome's isMoving.
It just happens that the value returned by the QVariant conversion is false, and no actual communication with the mount interface is taking place through the properties!

Sep 18 2018, 4:37 PM · KDE Edu

Sep 17 2018

TallFurryMan updated the diff for D15492: Capture module: fixes for decimal numbers in various locales, and fix for CCD selection.

Rebased, and adjusted float format for coherence.

Sep 17 2018, 7:45 PM · KDE Edu
TallFurryMan retitled D15546: Fix Scheduler slewing stage and dome interaction. from Fix Scheduler slewing stage andwq dome interaction. to Fix Scheduler slewing stage and dome interaction..
Sep 17 2018, 9:12 AM · KDE Edu

Sep 16 2018

TallFurryMan added a comment to D15546: Fix Scheduler slewing stage and dome interaction..

I was thinking about https://github.com/KDE/kstars/commit/c5ef911920df5a4d47e2def464c41924ffc18c12, but this doesn't make use of RESLEWING. But because there is not much doc on this change and the state machine, I'm not sure how this was supposed to work.

Sep 16 2018, 6:09 PM · KDE Edu
TallFurryMan updated the diff for D15546: Fix Scheduler slewing stage and dome interaction..

Fixed raw cast on local time.

Sep 16 2018, 4:57 PM · KDE Edu
TallFurryMan planned changes to D15546: Fix Scheduler slewing stage and dome interaction..

Actually, I moved the dome check to checkJobStage to avoid code duplication, and to fix the concurrency issue. I'm not clear on why you think this is a problem?
This said, I didn't check the alignment stage. But because the tracking stage was not working, I'm not surprised the alignment stage isn't neither!

Sep 16 2018, 4:25 PM · KDE Edu
TallFurryMan added a comment to D15546: Fix Scheduler slewing stage and dome interaction..

I note only now that I left a vi :wq in the title :)

Sep 16 2018, 8:33 AM · KDE Edu
TallFurryMan added a comment to D15492: Capture module: fixes for decimal numbers in various locales, and fix for CCD selection.

I noted the two points. The diff will probably fix the 1e+1 display, that's a 'g' instead of a 'f', but will not fix the 900, which is due to no proper signal/callback being fired when leaving the focus from the widget. As if changes were canceled, sort of.

Sep 16 2018, 8:33 AM · KDE Edu
TallFurryMan added a comment to D15546: Fix Scheduler slewing stage and dome interaction..

Besides, I think there will be other parts of the code that check the job stage independently. Right now nothing stops guiding when the mount suddenly slews. Also, it's still possible to guide and align at the same time, to dramatic effect. As I mentioned in a forum thread, guiding corrections do break the mount model.

Sep 16 2018, 8:29 AM · KDE Edu
TallFurryMan added a comment to D15546: Fix Scheduler slewing stage and dome interaction..

Don't get me wrong, I completely agree with your changes. I am using slewStatus as a mean to check the mount is still there, because there's nothing else I can rely on. The problem is really to manage, on one hand, the best case, that is, the interface has a working connection with the device, and the problematic case, that is, the interface lost contact but because no one is requesting anything, no event will ever come up.

Sep 16 2018, 8:25 AM · KDE Edu
TallFurryMan requested review of D15546: Fix Scheduler slewing stage and dome interaction..
Sep 16 2018, 12:06 AM · KDE Edu

Sep 15 2018

TallFurryMan added a comment to D15492: Capture module: fixes for decimal numbers in various locales, and fix for CCD selection.

Yeah sure I can have a look at conflicts ;)

Sep 15 2018, 6:57 AM · KDE Edu

Sep 14 2018

TallFurryMan added a comment to D15492: Capture module: fixes for decimal numbers in various locales, and fix for CCD selection.

This is part of the fix for https://bugs.kde.org/show_bug.cgi?id=398405. It made sense to me to start with an UI that was close to the Scheduler in terms of behavior, and simpler at the same time.

Sep 14 2018, 6:17 AM · KDE Edu

Sep 13 2018

TallFurryMan requested review of D15492: Capture module: fixes for decimal numbers in various locales, and fix for CCD selection.
Sep 13 2018, 9:07 PM · KDE Edu

Sep 11 2018

TallFurryMan requested review of D15436: Remove prevention of autofocus when no prior focus was done, add warnings..
Sep 11 2018, 8:15 PM · KDE Edu