jfranklin (Jason Franklin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 8 2019, 4:03 PM (47 w, 4 d)
Availability
Available

Recent Activity

Sep 18 2019

jfranklin added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

+1. Do you wanna commit this, or should I?

Sep 18 2019, 8:21 PM · Plasma
jfranklin added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

Or let's just get it in. It's a small change and we still have the beta phase to test it.

Sep 18 2019, 8:08 PM · Plasma
jfranklin added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

Thanks for the patch Jason. So the GSendStr(nullptr) is called on m_password.isNull() because this aborts the current PAM session? If this is correct, patch looks good to me.

Sep 18 2019, 7:54 PM · Plasma
jfranklin added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).
In D23849#532568, @zzag wrote:

@jfranklin Ping me if you don't get any feedback in a day or two.

Sep 18 2019, 5:44 PM · Plasma

Sep 16 2019

jfranklin added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

Friendly ping concerning this issue. Has anyone related to the screen locker project had some time to take a quick look at this?

Sep 16 2019, 1:08 PM · Plasma

Sep 11 2019

jfranklin added a reviewer for D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access): zzag.
Sep 11 2019, 6:47 PM · Plasma
jfranklin added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

I also didn't point this out in my original post, but I fixed a misuse of pam_end(). The status passed to pam_end() should be the returned status of the last PAM library call. This is noted in the documentation for Linux-PAM.

Sep 11 2019, 2:53 PM · Plasma

Sep 10 2019

jfranklin requested review of D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).
Sep 10 2019, 7:29 PM · Plasma

Sep 6 2019

jfranklin abandoned D23734: Remove the "fail_delay()" function.

Problem exists in linux-pam. I will fix the issue there. Abandoning revision.

Sep 6 2019, 6:58 PM · Plasma
jfranklin added a comment to D23734: Remove the "fail_delay()" function.

I investigated this further in the linux-pam repository, and I ended up creating this issue. The developers there acknowledged that the documentation was not correct and have asked for a PR to fix it.

Sep 6 2019, 6:04 PM · Plasma

Sep 5 2019

jfranklin added a comment to D23734: Remove the "fail_delay()" function.
In D23734#526285, @zzag wrote:

Hmm, "Unlocking failed" doesn't show up immediately if I type wrong password.

Sep 5 2019, 5:57 PM · Plasma
jfranklin added a comment to D23734: Remove the "fail_delay()" function.
In D23734#526274, @zzag wrote:

We want to notify the user as soon as possible about authentication failure.

Sep 5 2019, 5:08 PM · Plasma
jfranklin updated the summary of D23734: Remove the "fail_delay()" function.
Sep 5 2019, 1:42 PM · Plasma
jfranklin added a reviewer for D23734: Remove the "fail_delay()" function: Plasma.
Sep 5 2019, 1:41 PM · Plasma
jfranklin updated the summary of D23734: Remove the "fail_delay()" function.
Sep 5 2019, 1:39 PM · Plasma
jfranklin requested review of D23734: Remove the "fail_delay()" function.
Sep 5 2019, 1:34 PM · Plasma

Aug 8 2019

jfranklin added a comment to D4785: Add a small test application for kcheckpass.

I'm working on a machine that uses kcheckpass with libpam-poldi for authentication. This allows for the usage of GPG smart cards at login.

Aug 8 2019, 4:16 PM · Plasma