ahmadsamir (Ahmad Samir)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2017, 8:08 PM (131 w, 6 d)
Availability
Available

Recent Activity

Today

ahmadsamir committed R241:1a74a840d1e7: Use ++ operator to advance QHash::const_iterator (authored by ahmadsamir).
Use ++ operator to advance QHash::const_iterator
Sun, May 31, 12:01 PM
ahmadsamir added a comment to D29362: [KCharSelect] Initially give focus to the search lineedit.

Moved to https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/2

Sun, May 31, 9:29 AM · Frameworks
ahmadsamir committed R236:c0c93cc0fcb5: [KCharSelect] Initially give focus to the search lineedit (authored by ahmadsamir).
[KCharSelect] Initially give focus to the search lineedit
Sun, May 31, 9:28 AM
ahmadsamir closed D29362: [KCharSelect] Initially give focus to the search lineedit.
Sun, May 31, 9:28 AM · Frameworks
ahmadsamir committed R318:91f46840470f: [DolphinStatusBar] Fix free space info height with bigger fonts (authored by ahmadsamir).
[DolphinStatusBar] Fix free space info height with bigger fonts
Sun, May 31, 7:16 AM
ahmadsamir committed R318:1a6adc4bcf72: [DolphinStatusBar] Fix free space info height with bigger fonts (authored by ahmadsamir).
[DolphinStatusBar] Fix free space info height with bigger fonts
Sun, May 31, 7:10 AM

Yesterday

ahmadsamir committed R241:002fc28f8298: [RenameDialog] Fix how percent-encoded filenames are shown in src/dest lables (authored by ahmadsamir).
[RenameDialog] Fix how percent-encoded filenames are shown in src/dest lables
Sat, May 30, 10:31 PM
ahmadsamir committed R241:1dcd3a22bb16: [DelegateAnimationHanlder] Replace deprecated QLinkedList with QList (authored by ahmadsamir).
[DelegateAnimationHanlder] Replace deprecated QLinkedList with QList
Sat, May 30, 7:35 PM
ahmadsamir committed R241:2400e6f4ae9e: [KNewFileMenuTest] Add test for tilde expansion when creating a new folder (authored by ahmadsamir).
[KNewFileMenuTest] Add test for tilde expansion when creating a new folder
Sat, May 30, 5:54 PM
ahmadsamir committed R241:cfca7e57b316: [KNewFileMenuTest] Test that a new folder named '~' can be created (authored by ahmadsamir).
[KNewFileMenuTest] Test that a new folder named '~' can be created
Sat, May 30, 2:47 PM
ahmadsamir committed R241:de172d8e1fa3: [KNewFileMenuTest] Test that a new folder named '~' can be created (authored by ahmadsamir).
[KNewFileMenuTest] Test that a new folder named '~' can be created
Sat, May 30, 2:46 PM
ahmadsamir committed R241:09690fcf98a3: It's search path not search file (authored by ahmadsamir).
It's search path not search file
Sat, May 30, 1:10 PM
ahmadsamir committed R241:16c2e581801b: [KSambaShare] Check that both smbd and testparm are available (authored by ahmadsamir).
[KSambaShare] Check that both smbd and testparm are available
Sat, May 30, 12:29 PM

Fri, May 29

ahmadsamir committed R241:05047f31962c: [KSambaShare] Don't hardcode path to smbd binary (authored by ahmadsamir).
[KSambaShare] Don't hardcode path to smbd binary
Fri, May 29, 9:43 AM
ahmadsamir committed R241:947e3ed0fe3a: file_unix.cpp: when ::rename is used as condition compare its return to -1 (authored by ahmadsamir).
file_unix.cpp: when ::rename is used as condition compare its return to -1
Fri, May 29, 9:09 AM
ahmadsamir added inline comments to D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error.
Fri, May 29, 8:51 AM · Frameworks
ahmadsamir added inline comments to D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error.
Fri, May 29, 8:43 AM · Frameworks

Thu, May 28

ahmadsamir committed R319:72e76de072aa: [SessionController] Fix crash caused by text encoding menu (authored by ahmadsamir).
[SessionController] Fix crash caused by text encoding menu
Thu, May 28, 7:53 PM
ahmadsamir committed R241:610435c11ff7: [KnewFileMenu] Allow creating a dir named '~' (authored by ahmadsamir).
[KnewFileMenu] Allow creating a dir named '~'
Thu, May 28, 9:24 AM
ahmadsamir committed R241:3e2749bb8320: [KnewFileMenu] Allow creating a dir named '~' (authored by ahmadsamir).
[KnewFileMenu] Allow creating a dir named '~'
Thu, May 28, 9:23 AM

Wed, May 27

ahmadsamir committed R241:f19603883ffc: [DelegateAnimationHandler] Port deprecated QLinkedList to std::list (authored by ahmadsamir).
[DelegateAnimationHandler] Port deprecated QLinkedList to std::list
Wed, May 27, 12:57 PM
ahmadsamir committed R241:4f0167b71a58: [PreviewJob] Port QLinkedList (deprecated) to std::list (authored by ahmadsamir).
[PreviewJob] Port QLinkedList (deprecated) to std::list
Wed, May 27, 11:52 AM
ahmadsamir committed R245:c9f3a08b52e2: Compile with -DQT_NO_FOREACH GIT_SILENT (authored by ahmadsamir).
Compile with -DQT_NO_FOREACH GIT_SILENT
Wed, May 27, 11:25 AM
ahmadsamir committed R241:576b612e0d3e: [HostInfo] Set QHostInfo::HostNotFound when a host isn't found in the DNS cache (authored by ahmadsamir).
[HostInfo] Set QHostInfo::HostNotFound when a host isn't found in the DNS cache
Wed, May 27, 7:14 AM
ahmadsamir committed R241:6c007d0d03c4: Coding style; one more const (authored by ahmadsamir).
Coding style; one more const
Wed, May 27, 7:06 AM
ahmadsamir committed R241:a4ffa6471cec: Remove redundant #include (authored by ahmadsamir).
Remove redundant #include
Wed, May 27, 7:06 AM
ahmadsamir committed R241:69e464bd8c37: Port away from deprecated QLinkedList (authored by ahmadsamir).
Port away from deprecated QLinkedList
Wed, May 27, 7:06 AM

Tue, May 26

ahmadsamir committed R241:9e44319501cb: [PreviewJob] Use "m_items" for the member container instead of "items"… (authored by ahmadsamir).
[PreviewJob] Use "m_items" for the member container instead of "items"…
Tue, May 26, 8:49 PM
ahmadsamir committed R241:ba039caa46f2: Remove redundant #include (authored by ahmadsamir).
Remove redundant #include
Tue, May 26, 7:40 PM
ahmadsamir committed R241:f8bf9f9b94db: Port away from deprecated QLinkedList (authored by ahmadsamir).
Port away from deprecated QLinkedList
Tue, May 26, 7:36 PM
ahmadsamir committed R241:0cd60ea7ee94: [HostInfo] Return a no-op QHostInfo when a host isn't found in the KIO DNS cache (authored by ahmadsamir).
[HostInfo] Return a no-op QHostInfo when a host isn't found in the KIO DNS cache
Tue, May 26, 9:52 AM

Mon, May 25

ahmadsamir committed R120:b2beb9099d18: Remove redundant #include (authored by ahmadsamir).
Remove redundant #include
Mon, May 25, 11:34 AM
ahmadsamir committed R120:ac70c8966178: Remove redundant #include (authored by ahmadsamir).
Remove redundant #include
Mon, May 25, 11:34 AM
ahmadsamir committed R120:065ba968018f: [kio_desktop] Implement SlaveBase::GetFileSystemFreeSpace (authored by ahmadsamir).
[kio_desktop] Implement SlaveBase::GetFileSystemFreeSpace
Mon, May 25, 11:34 AM

Sun, May 24

ahmadsamir committed R120:e246ac5898ce: [kio_desktop] Implement SlaveBase::GetFileSystemFreeSpace (authored by ahmadsamir).
[kio_desktop] Implement SlaveBase::GetFileSystemFreeSpace
Sun, May 24, 6:12 PM

Sat, May 23

ahmadsamir committed R241:38998e066aa7: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs (authored by ahmadsamir).
[StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs
Sat, May 23, 3:47 PM
ahmadsamir committed R241:349eeb16bf91: Construct QUrl correctly with trash:/ protocol (authored by ahmadsamir).
Construct QUrl correctly with trash:/ protocol
Sat, May 23, 3:44 PM
ahmadsamir committed R241:1e1e24a73f4c: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs (authored by ahmadsamir).
[StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs
Sat, May 23, 3:44 PM
ahmadsamir added a comment to D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs.

This wasn't landed on master, but rather phabricator is confused by me pushing to work/ branch on gitlab :)

Sat, May 23, 12:56 PM · Frameworks
ahmadsamir closed D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs.
Sat, May 23, 12:52 PM · Frameworks
ahmadsamir committed R241:f2984ff28e72: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs (authored by ahmadsamir).
[StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs
Sat, May 23, 12:52 PM
ahmadsamir committed R245:8cd63dca42e4: Just use '\n' since a QString doesn't need flushing anyway (authored by ahmadsamir).
Just use '\n' since a QString doesn't need flushing anyway
Sat, May 23, 9:51 AM
ahmadsamir committed R245:40cdec2ec041: Fix build on the CI GIT_SILENT (authored by ahmadsamir).
Fix build on the CI GIT_SILENT
Sat, May 23, 9:07 AM
ahmadsamir committed R245:b1bb227a0bf0: Port away from deprecated Qt Methods (authored by ahmadsamir).
Port away from deprecated Qt Methods
Sat, May 23, 8:45 AM
ahmadsamir committed R295:97b703a798a0: Fix windows build on the CI, apparently the plugin lib is a .dll GIT_SILENT (authored by ahmadsamir).
Fix windows build on the CI, apparently the plugin lib is a .dll GIT_SILENT
Sat, May 23, 3:19 AM

Fri, May 22

ahmadsamir committed R245:c9f20eb09b6b: [DeviceManager] Port one foreach to range-for (authored by ahmadsamir).
[DeviceManager] Port one foreach to range-for
Fri, May 22, 7:36 PM
ahmadsamir committed R245:8e0b4ad082d2: Apply suggestion to src/solid/devices/frontend/devicemanager.cpp (authored by ahmadsamir).
Apply suggestion to src/solid/devices/frontend/devicemanager.cpp
Fri, May 22, 7:04 PM
ahmadsamir committed R245:9ffcf0408c49: Apply suggestion to src/solid/devices/frontend/devicemanager.cpp (authored by ahmadsamir).
Apply suggestion to src/solid/devices/frontend/devicemanager.cpp
Fri, May 22, 6:29 PM
ahmadsamir committed R245:c4434688cae2: [DeviceManager] Port one foreach to range-for (authored by ahmadsamir).
[DeviceManager] Port one foreach to range-for
Fri, May 22, 6:29 PM
ahmadsamir committed R245:1b8360b06dee: Apply suggestion to src/solid/devices/frontend/devicemanager.cpp (authored by ahmadsamir).
Apply suggestion to src/solid/devices/frontend/devicemanager.cpp
Fri, May 22, 6:28 PM
ahmadsamir committed R245:2ac8a11cce77: [DeviceManager] Port one foreach to range-for (authored by ahmadsamir).
[DeviceManager] Port one foreach to range-for
Fri, May 22, 1:23 PM
ahmadsamir committed R242:9558e80d544c: Don't mix up variable names, to keep the original behaviour (authored by ahmadsamir).
Don't mix up variable names, to keep the original behaviour
Fri, May 22, 8:34 AM
ahmadsamir committed R242:c69593fb4303: Use Pino's tip (authored by ahmadsamir).
Use Pino's tip
Fri, May 22, 8:34 AM
ahmadsamir committed R242:c4bc4ee1462a: Address kbroulik's comments (authored by ahmadsamir).
Address kbroulik's comments
Fri, May 22, 8:34 AM
ahmadsamir committed R242:d2f7a70820a1: [PackageUrlInterceptor] Minor code optimisation (authored by ahmadsamir).
[PackageUrlInterceptor] Minor code optimisation
Fri, May 22, 8:34 AM

Thu, May 21

ahmadsamir committed R295:99466532f40f: Use KCModuleInfo::service() to load modules, for both KPluginInfo and KService… (authored by ahmadsamir).
Use KCModuleInfo::service() to load modules, for both KPluginInfo and KService…
Thu, May 21, 8:53 PM
ahmadsamir committed R295:4c999b4e30c6: Use KCModuleInfo::service() to load modules, for both KPluginInfo and KService… (authored by ahmadsamir).
Use KCModuleInfo::service() to load modules, for both KPluginInfo and KService…
Thu, May 21, 8:51 PM
ahmadsamir committed R245:aa57a4261459: [DeviceManager] Only call delete on DevicePrivate if the ref count is > 1 (authored by ahmadsamir).
[DeviceManager] Only call delete on DevicePrivate if the ref count is > 1
Thu, May 21, 12:56 PM
ahmadsamir committed R245:5b17ff5a8de9: [Solid] Port foreach to range-for (authored by ahmadsamir).
[Solid] Port foreach to range-for
Thu, May 21, 11:45 AM
ahmadsamir committed R245:3d4bb89c5f26: Port away from deprecated Qt Methods (authored by ahmadsamir).
Port away from deprecated Qt Methods
Thu, May 21, 10:47 AM
ahmadsamir committed R245:41c803f27e0a: [Solid] Port foreach to range-for (authored by ahmadsamir).
[Solid] Port foreach to range-for
Thu, May 21, 9:59 AM

Wed, May 20

ahmadsamir added a comment to D28765: KSettings::Dialog: add support for KPluginInfos without a KService.

I guess a proper fix will need to revert part of this to have the KModuleInfo ctor that took a KService not use KPluginInfo internally; better still, of course, is having the KPluginInfo ctor work for the case of X-KDE-ServiceTypes=SystemSettingsExternalApp, (I couldn't grok KPluginInfo stuff fully yet).

Wed, May 20, 7:50 PM · Frameworks
ahmadsamir added a comment to D28765: KSettings::Dialog: add support for KPluginInfos without a KService.

systemsettings uses KCModuleInfo::service() to check whether the moduleinfo is valid[1], the problem is creating a KPluginInfo from the KService based on a .desktop file with X-KDE-ServiceTypes=SystemSettingsExternalApp fails because it doesn't seem to have valid metadata. Since the KPluginInfo ctor fails, accessing d->pluginInfo.service() causes a crash, I've submitted a proposed fix at [2]. This doesn't fix the bug, but merely prevents the crash.

Wed, May 20, 7:46 PM · Frameworks
ahmadsamir committed R295:d8b6c7193e1f: [KCModuleInfo] Don't access KPluginInfo unless it's valid (authored by ahmadsamir).
[KCModuleInfo] Don't access KPluginInfo unless it's valid
Wed, May 20, 7:41 PM

Tue, May 19

ahmadsamir committed R242:102e5ae81ed8: Don't mix up variable names, to keep the original behaviour (authored by ahmadsamir).
Don't mix up variable names, to keep the original behaviour
Tue, May 19, 5:15 PM
ahmadsamir committed R242:a2c24c9fa00c: Address kbroulik's comments (authored by ahmadsamir).
Address kbroulik's comments
Tue, May 19, 5:15 PM
ahmadsamir committed R242:e5ae8d7f7bd5: [PackageUrlInterceptor] Minor code optimisation (authored by ahmadsamir).
[PackageUrlInterceptor] Minor code optimisation
Tue, May 19, 5:15 PM
ahmadsamir committed R242:cffd8e8cee1a: Use Pino's tip (authored by ahmadsamir).
Use Pino's tip
Tue, May 19, 5:15 PM
ahmadsamir committed R242:f01e52764a00: Don't mix up variable names, to keep the original behaviour (authored by ahmadsamir).
Don't mix up variable names, to keep the original behaviour
Tue, May 19, 3:35 PM
ahmadsamir committed R242:372b80962d7b: Address kbroulik's comments (authored by ahmadsamir).
Address kbroulik's comments
Tue, May 19, 1:36 PM
ahmadsamir committed R242:970c44eb94c1: Use Pino's tip (authored by ahmadsamir).
Use Pino's tip
Tue, May 19, 1:24 PM
ahmadsamir committed R242:f5e4d2e8eb53: [PackageUrlInterceptor] Minor code optimisation (authored by ahmadsamir).
[PackageUrlInterceptor] Minor code optimisation
Tue, May 19, 12:35 PM
ahmadsamir abandoned D28673: [PackageUrlInterceptor] Make QRegularExpression static.
Tue, May 19, 12:23 PM · Frameworks
ahmadsamir commandeered D28673: [PackageUrlInterceptor] Make QRegularExpression static.

Should be handled by https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/2

Tue, May 19, 12:23 PM · Frameworks
ahmadsamir committed R242:35aaf4b4fcaa: [PackageUrlInterceptor] Minor code optimisation (authored by ahmadsamir).
[PackageUrlInterceptor] Minor code optimisation
Tue, May 19, 12:19 PM
ahmadsamir committed R245:296fb0af37e1: [Solid] Port foreach to range/index for (authored by ahmadsamir).
[Solid] Port foreach to range/index for
Tue, May 19, 6:00 AM

Mon, May 18

ahmadsamir committed R245:6d8d64686e33: [Solid] Port foreach to range/index for (authored by ahmadsamir).
[Solid] Port foreach to range/index for
Mon, May 18, 7:44 PM
ahmadsamir committed R824:060aebfe261e: [FilePropertiesPlugin] Port KRun to OpenUrlJob (authored by ahmadsamir).
[FilePropertiesPlugin] Port KRun to OpenUrlJob
Mon, May 18, 6:17 PM
ahmadsamir committed R245:cb1c489559d3: [Solid] Port foreach to range/index for (authored by ahmadsamir).
[Solid] Port foreach to range/index for
Mon, May 18, 5:37 PM
ahmadsamir committed R241:fad78ac89c06: Fix typo in ApplicationLauncherJobTest GIT_SILENT (authored by ahmadsamir).
Fix typo in ApplicationLauncherJobTest GIT_SILENT
Mon, May 18, 2:09 PM
ahmadsamir committed R241:1f6596bf7ba4: Fix window build GIT_SILENT (authored by ahmadsamir).
Fix window build GIT_SILENT
Mon, May 18, 1:32 PM
ahmadsamir committed R241:83c5be998182: [KNewFileMenu] Remove redundant slot parameter (authored by ahmadsamir).
[KNewFileMenu] Remove redundant slot parameter
Mon, May 18, 12:34 PM
ahmadsamir committed R241:480e43b225de: Revert "KNewFileMenu: remove ununsed/redundant parameter" (authored by ahmadsamir).
Revert "KNewFileMenu: remove ununsed/redundant parameter"
Mon, May 18, 12:29 PM
ahmadsamir added a reverting change for R241:e4b8bdc65fbe: KNewFileMenu: remove ununsed/redundant parameter GIT_SILENT: R241:480e43b225de: Revert "KNewFileMenu: remove ununsed/redundant parameter".
Mon, May 18, 12:29 PM
ahmadsamir committed R241:e4b8bdc65fbe: KNewFileMenu: remove ununsed/redundant parameter GIT_SILENT (authored by ahmadsamir).
KNewFileMenu: remove ununsed/redundant parameter GIT_SILENT
Mon, May 18, 12:25 PM
ahmadsamir closed D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
Mon, May 18, 12:08 PM · Plasma
ahmadsamir committed R120:e3b251fd5b06: [IconApplet] Port KRun to ApplicationLauncherJob (authored by ahmadsamir).
[IconApplet] Port KRun to ApplicationLauncherJob
Mon, May 18, 12:08 PM
ahmadsamir committed R241:d1e9325fba37: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
Mon, May 18, 7:28 AM

Sun, May 17

ahmadsamir committed R241:938ed665fedb: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
Sun, May 17, 9:42 PM
ahmadsamir updated the diff for D29687: [IconApplet] Port KRun to ApplicationLauncherJob.

Remove one include

Sun, May 17, 1:56 PM · Plasma
ahmadsamir committed R241:af82fd9f575e: [KFileItemActions] Port away from KRun deprecated methods (authored by ahmadsamir).
[KFileItemActions] Port away from KRun deprecated methods
Sun, May 17, 1:53 PM
ahmadsamir added a comment to D29800: Fix URL being passed as argument when launching a .desktop file.
Sun, May 17, 9:52 AM · Frameworks
ahmadsamir added a comment to D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog.

Not committed after all.

Sun, May 17, 9:46 AM · Frameworks
ahmadsamir added a comment to D29787: Fix krununittest.

Let's hope the CI has xterm installed.... I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird.

Sun, May 17, 9:08 AM · Frameworks
ahmadsamir committed R241:ef7708d1f5ec: Fix krununittest (authored by ahmadsamir).
Fix krununittest
Sun, May 17, 1:55 AM
ahmadsamir closed D29787: Fix krununittest.
Sun, May 17, 1:55 AM · Frameworks
ahmadsamir committed R241:2c4d875c3ee4: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems (authored by ahmadsamir).
[kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems
Sun, May 17, 1:44 AM
ahmadsamir committed R241:bed09e39fe24: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems (authored by ahmadsamir).
[kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems
Sun, May 17, 1:42 AM
ahmadsamir closed D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems.
Sun, May 17, 1:42 AM · Frameworks

Sat, May 16

ahmadsamir added a comment to D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs.

I've just realised, we won't get an error with an http url; in that case we return the url the statjob was called on as-is and cancel the job.

Sat, May 16, 4:42 PM · Frameworks