ahmadsamir (Ahmad Samir)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2017, 8:08 PM (100 w, 1 d)
Availability
Available

Recent Activity

Today

ahmadsamir added a comment to T11587: Investigate making KColorScheme tier1.

[...]

  • Can we make KColorScheme less needed by applications by adding more colors to QPalette itself? Using a tier 3 framework for more advanced use-cases is far less of a problem than for just getting the warning or error color for example.

As far as I understand:

  • QGuiApplication by default uses the color palette of the style
  • KDE has kstyle (from frameworkintegration), which has a standardPalette()[1] method that calls KColorScheme which creates a QPalette and sets the colors, for the various color groups/roles, for it by getting the actual color scheme set in the system/user's settings, which means KColorScheme needs to read the config.
Tue, Oct 22, 1:17 PM · KF6

Yesterday

ahmadsamir requested review of D24828: KRun: don't override user preferred app when opening local *.*html and co. files.
Mon, Oct 21, 11:50 AM · Frameworks
ahmadsamir committed R241:103e13c2765e: [src/kpac/*] replace deprecated foreach with range for (authored by ahmadsamir).
[src/kpac/*] replace deprecated foreach with range for
Mon, Oct 21, 10:47 AM
ahmadsamir closed D24350: [src/kpac/*] replace deprecated foreach with range for.
Mon, Oct 21, 10:47 AM · Frameworks
ahmadsamir added inline comments to D24350: [src/kpac/*] replace deprecated foreach with range for.
Mon, Oct 21, 3:42 AM · Frameworks
ahmadsamir updated the diff for D24350: [src/kpac/*] replace deprecated foreach with range for.

In private API we can have a method return a const &, as it can be
changed later without side-effects.

Mon, Oct 21, 12:41 AM · Frameworks

Sun, Oct 20

ahmadsamir added a comment to D24350: [src/kpac/*] replace deprecated foreach with range for.

Ping...

Sun, Oct 20, 8:38 PM · Frameworks
ahmadsamir committed R226:5287b6f424a0: [src/] port more code away from kdelibs4support and other deprecated classes (authored by ahmadsamir).
[src/] port more code away from kdelibs4support and other deprecated classes
Sun, Oct 20, 5:22 PM
ahmadsamir closed D24791: [src/] port more code away from kdelibs4support and other deprecated classes.
Sun, Oct 20, 5:22 PM
ahmadsamir updated the diff for D24791: [src/] port more code away from kdelibs4support and other deprecated classes.

Verbatim

Sun, Oct 20, 1:59 PM
ahmadsamir updated the diff for D24791: [src/] port more code away from kdelibs4support and other deprecated classes.

Fix if() loop totally wrong logic

Sun, Oct 20, 1:58 PM
ahmadsamir committed R226:7e796febd29c: settings/konqhtml: use the in-tree ktabwidget class (authored by ahmadsamir).
settings/konqhtml: use the in-tree ktabwidget class
Sun, Oct 20, 11:50 AM
ahmadsamir closed D24790: settings/konqhtml: use the in-tree ktabwidget class.
Sun, Oct 20, 11:50 AM
ahmadsamir updated the diff for D24790: settings/konqhtml: use the in-tree ktabwidget class.

Use QTabWidget instead of KTabWidget

Sun, Oct 20, 11:21 AM
ahmadsamir added a comment to D24790: settings/konqhtml: use the in-tree ktabwidget class.

This looks wrong. This code doesn't need KTabWidget (which has webbrowser-specific features), it should be ported to QTabWidget instead.

Sun, Oct 20, 11:01 AM
ahmadsamir committed R226:331f96afa682: Use QStandardPaths::findExecutable instead of deprecated KStandardDirs::findExe (authored by ahmadsamir).
Use QStandardPaths::findExecutable instead of deprecated KStandardDirs::findExe
Sun, Oct 20, 9:24 AM
ahmadsamir closed D24787: Use QStandardPaths::findExecutable instead of deprecated KStandardDirs::findExe.
Sun, Oct 20, 9:24 AM
ahmadsamir committed R226:6bf04f53bbbe: Port KonqSessiondlg and KonqSessionManager away from KTempDir (authored by ahmadsamir).
Port KonqSessiondlg and KonqSessionManager away from KTempDir
Sun, Oct 20, 9:22 AM
ahmadsamir closed D24775: Port KonqSessiondlg and KonqSessionManager away from KTempDir.
Sun, Oct 20, 9:22 AM
ahmadsamir committed R226:99386bcf4f80: Replace deprecated QPixmap::serialNumber() with QPixmap::cacheKey() (authored by ahmadsamir).
Replace deprecated QPixmap::serialNumber() with QPixmap::cacheKey()
Sun, Oct 20, 9:20 AM
ahmadsamir closed D24788: Replace deprecated QPixmap::serialNumber() with QPixmap::cacheKey().
Sun, Oct 20, 9:20 AM
ahmadsamir updated the diff for D24789: Fix in-tree ktabwidget.

movedTab signal is redundant

Sun, Oct 20, 9:16 AM
ahmadsamir requested review of D24793: [Konqueror] Remove KonqView::setActiveComponent().
Sun, Oct 20, 5:08 AM
ahmadsamir added inline comments to D24791: [src/] port more code away from kdelibs4support and other deprecated classes.
Sun, Oct 20, 4:48 AM
ahmadsamir updated the diff for D24791: [src/] port more code away from kdelibs4support and other deprecated classes.

Less find_package calls

Sun, Oct 20, 4:47 AM

Sat, Oct 19

ahmadsamir added a reviewer for D24782: Port away from deprecated BarIcon method: mlaurent.
Sat, Oct 19, 9:12 PM · KDE PIM
ahmadsamir closed D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket.
Sat, Oct 19, 9:07 PM
ahmadsamir committed R7:458822190452: [Konversation] Port from deprecated KTcpSocket to QSslSocket (authored by ahmadsamir).
[Konversation] Port from deprecated KTcpSocket to QSslSocket
Sat, Oct 19, 9:07 PM
ahmadsamir added a revision to T11559: Port Konqueror away from KDELibs4Support: D24791: [src/] port more code away from kdelibs4support and other deprecated classes.
Sat, Oct 19, 9:06 PM · KF6
ahmadsamir requested review of D24791: [src/] port more code away from kdelibs4support and other deprecated classes.
Sat, Oct 19, 9:06 PM
ahmadsamir requested review of D24790: settings/konqhtml: use the in-tree ktabwidget class.
Sat, Oct 19, 9:03 PM
ahmadsamir added a revision to T11559: Port Konqueror away from KDELibs4Support: D24790: settings/konqhtml: use the in-tree ktabwidget class.
Sat, Oct 19, 9:03 PM · KF6
ahmadsamir added a revision to T11559: Port Konqueror away from KDELibs4Support: D24789: Fix in-tree ktabwidget.
Sat, Oct 19, 9:01 PM · KF6
ahmadsamir requested review of D24789: Fix in-tree ktabwidget.
Sat, Oct 19, 9:01 PM
ahmadsamir added a revision to T11559: Port Konqueror away from KDELibs4Support: D24788: Replace deprecated QPixmap::serialNumber() with QPixmap::cacheKey().
Sat, Oct 19, 9:00 PM · KF6
ahmadsamir requested review of D24788: Replace deprecated QPixmap::serialNumber() with QPixmap::cacheKey().
Sat, Oct 19, 9:00 PM
ahmadsamir requested review of D24787: Use QStandardPaths::findExecutable instead of deprecated KStandardDirs::findExe.
Sat, Oct 19, 7:49 PM
ahmadsamir added a revision to T11559: Port Konqueror away from KDELibs4Support: D24787: Use QStandardPaths::findExecutable instead of deprecated KStandardDirs::findExe.
Sat, Oct 19, 7:49 PM · KF6
ahmadsamir committed R239:556f102af097: KLocale api docs: make it easier to find how to port code away from it (authored by ahmadsamir).
KLocale api docs: make it easier to find how to port code away from it
Sat, Oct 19, 1:14 PM
ahmadsamir closed D24770: KLocale api docs: make it easier to find how to port code away from it.
Sat, Oct 19, 1:14 PM · Frameworks
ahmadsamir requested review of D24775: Port KonqSessiondlg and KonqSessionManager away from KTempDir.
Sat, Oct 19, 9:19 AM
ahmadsamir added a revision to T11559: Port Konqueror away from KDELibs4Support: D24775: Port KonqSessiondlg and KonqSessionManager away from KTempDir.
Sat, Oct 19, 9:19 AM · KF6
ahmadsamir requested review of D24770: KLocale api docs: make it easier to find how to port code away from it.
Sat, Oct 19, 8:21 AM · Frameworks

Thu, Oct 17

ahmadsamir added inline comments to D24746: [kpropertiesdialog] adjust ui for root directory.
Thu, Oct 17, 8:24 PM · Frameworks
ahmadsamir committed R244:b539685e9495: Fix grammar (authored by ahmadsamir).
Fix grammar
Thu, Oct 17, 11:08 AM
ahmadsamir closed D24725: Fix grammar.
Thu, Oct 17, 11:08 AM · Frameworks
ahmadsamir requested review of D24725: Fix grammar.
Thu, Oct 17, 9:47 AM · Frameworks

Wed, Oct 16

ahmadsamir added a comment to T11587: Investigate making KColorScheme tier1.

Some of the KColorScheme methods have a "config" object parameter, if that parameter is null, it uses use a local function, defaultConfig(), to get a default "config" object to work with.

Wed, Oct 16, 7:04 PM · KF6
ahmadsamir added a comment to T11587: Investigate making KColorScheme tier1.

It looks like KColorScheme provides more features, like color intesity and tint... etc. IINM, this is used when editing a color scheme (on the "Disabled" tab). Something similar was used in the icons kcm, i.e. you could change the hover effect of icons, i.e. more dark/gamma/tint... I looked just now (I haven't used that feature in ages) but it seems to be gone from the new kcm which was rewritten in QtQuick, probably dropped on the basis no one actually used it :)

Wed, Oct 16, 5:14 PM · KF6
ahmadsamir added a comment to T11587: Investigate making KColorScheme tier1.

KColorScheme uses KConfig and KColorUtils, and so, IIUC, it could be a tier2 but not a tier1.

Wed, Oct 16, 3:02 PM · KF6
ahmadsamir abandoned D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree.
Wed, Oct 16, 11:54 AM

Tue, Oct 15

ahmadsamir added a comment to D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree.

why ?
I don't like lots of these changes.

Tue, Oct 15, 7:25 PM
ahmadsamir added a reviewer for D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors: dfaure.
Tue, Oct 15, 5:05 PM · Frameworks
ahmadsamir added a comment to D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree.

T11214 is still being discussed, and we can always run clang-format later on.

Tue, Oct 15, 3:51 PM
ahmadsamir added a task to D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree: T11576: Port kolourpaint away from kdelibs4support.
Tue, Oct 15, 3:40 PM
ahmadsamir added a revision to T11576: Port kolourpaint away from kdelibs4support: D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree.
Tue, Oct 15, 3:40 PM · KF6
ahmadsamir added a reviewer for D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree: kde-frameworks-devel.
Tue, Oct 15, 3:38 PM
ahmadsamir requested review of D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree.
Tue, Oct 15, 3:35 PM
ahmadsamir added a comment to T5437: arcanist: option to ignore untracked files.

Yeah, better arc land than breaking something (until the next time it gets on my nerves and I try to hack the arcanist source code, I know next to nothing about PHP... :)).

Tue, Oct 15, 8:04 AM · Phabricator

Mon, Oct 14

ahmadsamir added a comment to T5437: arcanist: option to ignore untracked files.

Revisiting an old issue :)

Mon, Oct 14, 8:49 PM · Phabricator
ahmadsamir added a reviewer for D24631: exclude ioslaves directory from api docs: dfaure.
Mon, Oct 14, 12:52 PM · Frameworks
ahmadsamir added reviewers for D19504: Extend KHtmlView::print() to use a predefined QPrinter instance: dfaure, vkrause.
Mon, Oct 14, 11:40 AM · Frameworks
ahmadsamir closed D24588: [SslUi] Add api docs for askIgnoreSslErrors().
Mon, Oct 14, 10:58 AM · Frameworks
ahmadsamir committed R241:c38591b9d2a9: [SslUi] Add api docs for askIgnoreSslErrors() (authored by ahmadsamir).
[SslUi] Add api docs for askIgnoreSslErrors()
Mon, Oct 14, 10:58 AM
ahmadsamir closed D24615: Fix crash with sortAllByName/Description.
Mon, Oct 14, 10:58 AM · Plasma
ahmadsamir committed R103:3d4640bea622: Fix crash with sortAllByName/Description (authored by ahmadsamir).
Fix crash with sortAllByName/Description
Mon, Oct 14, 10:58 AM

Sun, Oct 13

ahmadsamir requested review of D24615: Fix crash with sortAllByName/Description.
Sun, Oct 13, 4:58 PM · Plasma
ahmadsamir updated the diff for D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket.

Better commit message

Sun, Oct 13, 11:25 AM
ahmadsamir updated the diff for D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Since I wrote the docs bit anyway

Sun, Oct 13, 11:24 AM · Frameworks
ahmadsamir removed a task from D24588: [SslUi] Add api docs for askIgnoreSslErrors(): T11577: Port Konversation away from KTcpSocket.
Sun, Oct 13, 11:18 AM · Frameworks
ahmadsamir removed a revision from T11577: Port Konversation away from KTcpSocket: D24588: [SslUi] Add api docs for askIgnoreSslErrors().
Sun, Oct 13, 11:18 AM · KF6
ahmadsamir updated the diff for D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket.

Use KSslErrorUiData directly when calling askIgnoreSslErrors

Sun, Oct 13, 11:17 AM
ahmadsamir added a comment to D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

That would be my gut feeling as well, ie. have sslui depend on the abstract error representation, not on all possible error sources. OTOH it's not changing the dependency situation overall here so no strong objection to that either. In any case the KTcpSocket variant should be deprecated eventually.

Sun, Oct 13, 11:07 AM · Frameworks
ahmadsamir committed R103:e3b8910670e3: Port away from deprecated KDELibs4Support (authored by ahmadsamir).
Port away from deprecated KDELibs4Support
Sun, Oct 13, 9:35 AM
ahmadsamir closed D24603: Port away from deprecated KDELibs4Support.
Sun, Oct 13, 9:35 AM · Plasma

Sat, Oct 12

ahmadsamir added a comment to D24603: Port away from deprecated KDELibs4Support.

Looking at kmenuedit and dolphin settings dialog, the margin and spacing look comparable, so those setContentMargins and setSpacing calls aren't needed any more.

Sat, Oct 12, 11:32 PM · Plasma
ahmadsamir added a revision to T11566: Port kmenuedit away from kdelibs4support: D24603: Port away from deprecated KDELibs4Support.
Sat, Oct 12, 11:29 PM · KF6
ahmadsamir added a task to D24603: Port away from deprecated KDELibs4Support: T11566: Port kmenuedit away from kdelibs4support.
Sat, Oct 12, 11:29 PM · Plasma
ahmadsamir requested review of D24603: Port away from deprecated KDELibs4Support.
Sat, Oct 12, 11:26 PM · Plasma
ahmadsamir updated the diff for D24588: [SslUi] Add api docs for askIgnoreSslErrors().

@since should actually be in the future

Sat, Oct 12, 11:09 PM · Frameworks
ahmadsamir updated the diff for D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Api docs...

Sat, Oct 12, 11:06 PM · Frameworks
ahmadsamir added a comment to D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

Sat, Oct 12, 10:33 PM · Frameworks
ahmadsamir added a comment to T11566: Port kmenuedit away from kdelibs4support.

Hello. I am working on the rest of the kdelibs4support bits in kmenuedit.

Sat, Oct 12, 9:27 PM · KF6
ahmadsamir committed R241:7c0402ed9fd7: Compile without deprecated foreach (authored by ahmadsamir).
Compile without deprecated foreach
Sat, Oct 12, 9:19 PM
ahmadsamir closed D24372: Compile without deprecated foreach.
Sat, Oct 12, 9:19 PM · Frameworks
ahmadsamir added a comment to D24372: Compile without deprecated foreach.

I had to fix one conflict when rebasing, and basically D24419 ate the foreach src/core/ksslcertificatemanager.cpp@line 128 (by returning the result of calling contains() on the container, neater :)).

Sat, Oct 12, 9:04 PM · Frameworks
ahmadsamir updated the diff for D24372: Compile without deprecated foreach.

Rebase

Sat, Oct 12, 8:57 PM · Frameworks
ahmadsamir added a task to D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket: T11577: Port Konversation away from KTcpSocket.
Sat, Oct 12, 4:55 PM
ahmadsamir added a revision to T11577: Port Konversation away from KTcpSocket: D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket.
Sat, Oct 12, 4:55 PM · KF6
ahmadsamir added reviewers for D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket: hein, mlaurent.
Sat, Oct 12, 4:53 PM
ahmadsamir added a comment to D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket.

I don't use IRC much, so I don't know how to thoroughly test the SSL encryption when authenticating with a name server; if someone could point me to some docs/guide about that, or test the patch himself, that'd be great.

Sat, Oct 12, 4:50 PM
ahmadsamir requested review of D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket.
Sat, Oct 12, 4:48 PM
ahmadsamir added a dependent revision for D24588: [SslUi] Add api docs for askIgnoreSslErrors(): D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket.
Sat, Oct 12, 4:48 PM · Frameworks
ahmadsamir added a revision to T11577: Port Konversation away from KTcpSocket: D24588: [SslUi] Add api docs for askIgnoreSslErrors().
Sat, Oct 12, 9:54 AM · KF6
ahmadsamir added a task to D24588: [SslUi] Add api docs for askIgnoreSslErrors(): T11577: Port Konversation away from KTcpSocket.
Sat, Oct 12, 9:54 AM · Frameworks
ahmadsamir claimed T11577: Port Konversation away from KTcpSocket.
Sat, Oct 12, 9:50 AM · KF6
ahmadsamir requested review of D24588: [SslUi] Add api docs for askIgnoreSslErrors().
Sat, Oct 12, 9:42 AM · Frameworks
ahmadsamir moved T11577: Port Konversation away from KTcpSocket from Backlog to In Progress on the KF6 board.
Sat, Oct 12, 9:39 AM · KF6

Tue, Oct 8

ahmadsamir added inline comments to D24372: Compile without deprecated foreach.
Tue, Oct 8, 11:59 PM · Frameworks
ahmadsamir updated the diff for D24372: Compile without deprecated foreach.
  • User more descriptive var names other than list2
  • qAsConst isn't needed if the method is const and the container is a member var
Tue, Oct 8, 2:59 PM · Frameworks