ahmadsamir (Ahmad Samir)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2017, 8:08 PM (43 w, 5 d)
Availability
Available

Recent Activity

Jun 14 2018

ahmadsamir added a comment to T5437: arcanist: option to ignore untracked files.

For the sake of the next person getting here through the frustrated-online-search tunnel (like I just did a few hours ago, after the untracked files conundrum hit me about 50 times), here's a simple bash function that I came up with to use --allow-untracked with arc diff (there are probably more elegant ways to do this, but this WFM, so):

Jun 14 2018, 4:50 PM · Phabricator
ahmadsamir added a comment to D13511: Remove SearchBar from the MainWindowOverview.

Consequently this patch will fix https://bugs.kde.org/show_bug.cgi?id=336129, (it should be mentioned in the commit message).

Jun 14 2018, 4:08 PM · Konsole
ahmadsamir added a comment to D13511: Remove SearchBar from the MainWindowOverview.

This looks really good.

  1. I notice there are times the mouse pointer disappears when over the searchbar: a) when there's a lot of history and search for some text, clicking up or down multiple times, the mouse pointer disappears. Moving the mouse out of the searchbar make the pointer reappear. b) sometimes when just moving mouse between searchbar widgets
Jun 14 2018, 3:42 PM · Konsole
ahmadsamir added inline comments to D13516: simplify isProfileDeletable.
Jun 14 2018, 8:09 AM · Konsole

Jun 13 2018

ahmadsamir added inline comments to D13516: simplify isProfileDeletable.
Jun 13 2018, 6:54 PM · Konsole

Jun 12 2018

ahmadsamir added a comment to D13174: New layout for the search bar..

I haven't tested this, but does it make sense to just make the searchBar part of the TerminalDisplay Class and do away the TerminalWidget concept? theoretically, in my mind anyway, it would make this patch a lot smaller as calls to TerminalDisplay objects wouldn't need to be changed then. (Just an untested thought, I'll hopefully try and test this tomorrow).

Jun 12 2018, 9:30 PM · Konsole

Jun 8 2018

ahmadsamir added inline comments to D13428: De duplicate setContainerFeatures.
Jun 8 2018, 6:52 PM · Konsole

Jun 7 2018

ahmadsamir added a comment to D13174: New layout for the search bar..

One corner case comes to mind (whether it has to be fixed here or in a separate review later on), if the matched text is under the search bar, the user won't be able to see it, this can be further split into two cases (and two different solutions?):
a) if there's room to scroll up/down to show the text
b) if there's no room to scroll.

Jun 7 2018, 11:43 AM · Konsole

Jun 6 2018

ahmadsamir updated the diff for D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().

Fix Q_ASSERT condition.
Fix session()->isPrimaryScreen() condition.

Jun 6 2018, 2:58 PM · Konsole
ahmadsamir added inline comments to D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Jun 6 2018, 12:49 PM · Konsole

Jun 5 2018

ahmadsamir added a reviewer for D13271: Use Q_ASSERT to catch null pointers for _sessionController and session(): hindenburg.
Jun 5 2018, 9:25 PM · Konsole
ahmadsamir updated the diff for D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().

Actually update the commit message

Jun 5 2018, 9:24 PM · Konsole
ahmadsamir updated the diff for D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().

Use Q_ASSERT instead of checking for nullptr

Jun 5 2018, 9:23 PM · Konsole
ahmadsamir added inline comments to D13356: Fix block selection mode in a couple of cases.
Jun 5 2018, 1:07 PM · Konsole
ahmadsamir updated the diff for D13356: Fix block selection mode in a couple of cases.

Tighten parentheses.

Jun 5 2018, 1:05 PM · Konsole
ahmadsamir requested review of D13356: Fix block selection mode in a couple of cases.
Jun 5 2018, 9:53 AM · Konsole

Jun 3 2018

ahmadsamir added a comment to D13174: New layout for the search bar..

A couple of notes:

  • Disabling "use current window size on next startup", the size setting in the profile seems to be ignored, the window that shows up is way too small
  • After starting a new window, initially the terminal display prompt doesn't have focus (empty block cursor), the same thing happens when opening a new tab
Jun 3 2018, 3:48 PM · Konsole

Jun 2 2018

ahmadsamir added inline comments to D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Jun 2 2018, 9:34 AM · Konsole

Jun 1 2018

ahmadsamir requested review of D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Jun 1 2018, 3:57 PM · Konsole
ahmadsamir added a comment to D13217: Move isPrimaryScreen() to Session.

OK thanks, using 'man man' did not work for me but yes vim file did work in the testing.

Jun 1 2018, 1:23 PM · Konsole

May 31 2018

ahmadsamir updated the diff for D13217: Move isPrimaryScreen() to Session.

Tweak commit message

May 31 2018, 4:45 PM · Konsole
ahmadsamir added inline comments to D13217: Move isPrimaryScreen() to Session.
May 31 2018, 4:37 PM · Konsole
ahmadsamir updated the diff for D13217: Move isPrimaryScreen() to Session.

Change the code to check that session* is valid before accessing it

May 31 2018, 4:36 PM · Konsole

May 30 2018

ahmadsamir updated the diff for D13217: Move isPrimaryScreen() to Session.

Used --verbatim before adding a Test Plan:

May 30 2018, 4:25 PM · Konsole
ahmadsamir requested review of D13217: Move isPrimaryScreen() to Session.
May 30 2018, 4:22 PM · Konsole

May 28 2018

ahmadsamir updated the diff for D13147: Replace setUserTitle() with setSessionAttribute().

Rebase.

May 28 2018, 2:47 PM · Konsole
ahmadsamir added a comment to D13134: Invert the logic for Mouse Tracking events.

Thanks, the only issue I see is that shouldn't the two constructor initialization be swamped for true? _usesMouseTracking(false), _usesMouseTracking(false),

May 28 2018, 12:51 PM · Konsole

May 27 2018

ahmadsamir updated the diff for D13147: Replace setUserTitle() with setSessionAttribute().

Corrections in the commit message

May 27 2018, 1:00 PM · Konsole
ahmadsamir requested review of D13147: Replace setUserTitle() with setSessionAttribute().
May 27 2018, 12:59 PM · Konsole

May 26 2018

ahmadsamir updated the diff for D13134: Invert the logic for Mouse Tracking events.

Clarify steps in the Test Plan

May 26 2018, 11:06 AM · Konsole
ahmadsamir updated the diff for D13134: Invert the logic for Mouse Tracking events.

Tweak the commit message some more

May 26 2018, 10:58 AM · Konsole
ahmadsamir updated the diff for D13134: Invert the logic for Mouse Tracking events.

Tweak the commit message (i.e. correct grammatical mistakes)

May 26 2018, 10:55 AM · Konsole
ahmadsamir added a comment to D13089: Fix mouse coords for programs interested with it.

I think we need to fix _mouseMarks at some point

FIXME: the actual value of _mouseMarks is the opposite of its semantic.
When using programs not interested with mouse(shell, less), it is true.
// When using programs interested with mouse(vim,mc), it is false.

May 26 2018, 9:13 AM · Konsole
ahmadsamir requested review of D13134: Invert the logic for Mouse Tracking events.
May 26 2018, 9:10 AM · Konsole

May 23 2018

ahmadsamir requested review of D13078: Ignore control characters in the text part of Xpe "ESC]" sequences.
May 23 2018, 8:09 PM · Konsole

May 22 2018

ahmadsamir updated the diff for D12981: Improve the Keyboard tab and the KeyBindings editor.

Add missing semicolon

May 22 2018, 4:34 PM · Konsole
ahmadsamir added a comment to D12981: Improve the Keyboard tab and the KeyBindings editor.

KeyBindingEditor.cpp:66:97: error: expected ';' after expression

_ui->descriptionEdit->setPlaceholderText(i18nc("@label:textbox", "Enter descriptive label"))
May 22 2018, 4:34 PM · Konsole
ahmadsamir updated subscribers of D12981: Improve the Keyboard tab and the KeyBindings editor.

I notice you can overwrite files w/o any notice - create multiple new key bindings files and apply/ok. You don't need to work on that just bringing it up.

May 22 2018, 2:29 PM · Konsole
ahmadsamir updated the diff for D12981: Improve the Keyboard tab and the KeyBindings editor.

Use the same placeholderText from the Edit Profile dialog General tab, more consistent wording across the application and saves the translators a bit of time

May 22 2018, 2:14 PM · Konsole
ahmadsamir updated subscribers of D12981: Improve the Keyboard tab and the KeyBindings editor.

doesn't build here

KeyBindingEditor.cpp:307:9: error: use of undeclared identifier 'KMessageBox'

KMessageBox::sorry(this, i18n("A key bindings scheme cannot be saved with an empty description."));
May 22 2018, 1:13 PM · Konsole
ahmadsamir updated the diff for D12981: Improve the Keyboard tab and the KeyBindings editor.

Add proper include

May 22 2018, 1:12 PM · Konsole
ahmadsamir updated subscribers of D12981: Improve the Keyboard tab and the KeyBindings editor.
May 22 2018, 12:31 PM · Konsole
ahmadsamir updated the diff for D12981: Improve the Keyboard tab and the KeyBindings editor.

Disallow saving a scheme with an empty description

May 22 2018, 12:30 PM · Konsole
ahmadsamir added a comment to D12981: Improve the Keyboard tab and the KeyBindings editor.

[..]

  1. You can remove the description which shouldn't be allowed - just like profile name can't be empty - I would not use a special kmessagewidget - just use something like setPlaceholderText(i18n("A name must be entered!")); and do the normal popup about missing description when Apply/OK
May 22 2018, 12:28 PM · Konsole

May 19 2018

ahmadsamir requested review of D12981: Improve the Keyboard tab and the KeyBindings editor.
May 19 2018, 12:45 PM · Konsole

May 16 2018

ahmadsamir updated the diff for D12899: Backspace without CTRL should send '^?'.

Add BUG and FIXED-IN lines

May 16 2018, 3:25 AM · Konsole

May 15 2018

ahmadsamir requested review of D12899: Backspace without CTRL should send '^?'.
May 15 2018, 4:10 PM · Konsole

May 10 2018

ahmadsamir updated the diff for D12797: Fix scoping issues with Screen::DecodingOptions.

Take 2

May 10 2018, 4:22 AM · Konsole
ahmadsamir updated the diff for D12797: Fix scoping issues with Screen::DecodingOptions.

Fix phabricator markup screw-up

May 10 2018, 4:20 AM · Konsole
ahmadsamir requested review of D12797: Fix scoping issues with Screen::DecodingOptions.
May 10 2018, 4:19 AM · Konsole

May 8 2018

ahmadsamir added a comment to D12733: The exported version env var should have a consistent length.

Ok sorry for the noise - I should have read this more closer

May 8 2018, 8:59 PM · Konsole
ahmadsamir added a comment to D12733: The exported version env var should have a consistent length.
I was wondering if .remove(".").append("0").left(6) would be easier.
May 8 2018, 7:42 AM · Konsole

May 7 2018

ahmadsamir added a comment to D12733: The exported version env var should have a consistent length.

Thanks for thinking of this. Would it be simplier to remove .; append '00' and then take left 6?

May 7 2018, 7:48 PM · Konsole
ahmadsamir requested review of D12733: The exported version env var should have a consistent length.
May 7 2018, 10:06 AM · Konsole

May 4 2018

ahmadsamir added a comment to D12621: Export KONSOLE_VERSION as an environment variable.

Thanks, you could use remove to simplify it slightly.

May 4 2018, 6:57 PM · Konsole
ahmadsamir updated the diff for D12621: Export KONSOLE_VERSION as an environment variable.

Use remove() instead of replace()

May 4 2018, 6:56 PM · Konsole
ahmadsamir updated the diff for D12621: Export KONSOLE_VERSION as an environment variable.

Use a numeric string for the version env var (by removing the dots from the version string).

May 4 2018, 6:27 AM · Konsole

May 3 2018

ahmadsamir added a comment to D12621: Export KONSOLE_VERSION as an environment variable.

Ok I should have explained better; do they want XX.YY.ZZ or something else? I notice xterm and vte just use a # (without .)

May 3 2018, 6:15 PM · Konsole

May 2 2018

ahmadsamir added a comment to D12621: Export KONSOLE_VERSION as an environment variable.

Thanks, have they expressed that this is what they'd like to check for? Do any other terminals export their versions?

May 2 2018, 3:46 PM · Konsole

Apr 30 2018

ahmadsamir requested review of D12621: Export KONSOLE_VERSION as an environment variable.
Apr 30 2018, 6:54 PM · Konsole
ahmadsamir abandoned D12564: Use an Enum for the DECSCUSR cursor styles.

Disregard this review request; Implementing DECRQSS is taking me too long (for so little gain), due to it having a an \e character at the end.

Apr 30 2018, 6:01 PM · Konsole

Apr 27 2018

ahmadsamir updated the diff for D12564: Use an Enum for the DECSCUSR cursor styles.

Tweak Test Plan section formatting

Apr 27 2018, 7:56 PM · Konsole
ahmadsamir requested review of D12564: Use an Enum for the DECSCUSR cursor styles.
Apr 27 2018, 7:54 PM · Konsole

Apr 19 2018

ahmadsamir added a comment to D12193: Add support for Set Cursor Style (DECSCUSR) escape sequences.

I notice that using 'reset' in FreeBSD does not change the cursor back to profile setting.

Apr 19 2018, 5:39 PM · Konsole

Apr 18 2018

ahmadsamir updated the diff for D12193: Add support for Set Cursor Style (DECSCUSR) escape sequences.

Support 'ESC[ q' too

Apr 18 2018, 3:14 PM · Konsole
ahmadsamir added a comment to D12193: Add support for Set Cursor Style (DECSCUSR) escape sequences.

In xterm, the number 0 or omitting the number is the same as number 1.

In vte we intentionally differ, the number 0 or omitting the number means to revert to the default (the shape is taken from profile prefs, blinking is from GNOME-wide setting).


I tested omitting the # in xterm and it works as if there was 1 - I think we'd rather follow xterm than vte ATM

Apr 18 2018, 2:34 PM · Konsole
ahmadsamir added a comment to D12193: Add support for Set Cursor Style (DECSCUSR) escape sequences.

The output looks great - was mimicking xterms '\e[ q' too hard or not worth the effort?

I am not sure what you mean, but if you mean the code in the Vt102Emulation, it took me a long time to understand the 'lec' and co. parts, and a lot of trial and error; the comment at the top of that section says "Ok, here comes the nasty part of the decoder.", which is true, it's quite nasty.

Apr 18 2018, 9:54 AM · Konsole
ahmadsamir updated the diff for D12193: Add support for Set Cursor Style (DECSCUSR) escape sequences.

Add note about 'reset' to the test section

Apr 18 2018, 9:49 AM · Konsole
ahmadsamir updated the diff for D12193: Add support for Set Cursor Style (DECSCUSR) escape sequences.

Update diff again because some bits of the commit message were wrongly commented out

Apr 18 2018, 9:46 AM · Konsole
ahmadsamir updated the diff for D12193: Add support for Set Cursor Style (DECSCUSR) escape sequences.

Add test plan section

Apr 18 2018, 9:43 AM · Konsole
ahmadsamir added a comment to D12255: Apply the key bindings changes to the current profile.

looks OK and my testing work - in general, try to keep columns to less than 78; if you use the commit-template it makes it easier to remember.

Apr 18 2018, 9:13 AM · Konsole

Apr 16 2018

ahmadsamir requested review of D12255: Apply the key bindings changes to the current profile.
Apr 16 2018, 5:39 PM · Konsole

Apr 14 2018

ahmadsamir requested review of D12193: Add support for Set Cursor Style (DECSCUSR) escape sequences.
Apr 14 2018, 11:49 AM · Konsole
ahmadsamir added a comment to D12140: Support XTerm Alternate Scroll Mode escape sequences.

This doesn't apply cleanly now - can you quickly fix it? If not, I can try to handle it.

Hopefully done (I might have mucked the git commands a bit... it's a lot of commands to wrap my head around).

Apr 14 2018, 11:35 AM · Konsole

Apr 13 2018

ahmadsamir requested review of D12175: Check for valid _foregroundProcessInfo to prevent crash.
Apr 13 2018, 3:31 PM · Konsole
ahmadsamir updated the summary of D12140: Support XTerm Alternate Scroll Mode escape sequences.
Apr 13 2018, 2:39 PM · Konsole
ahmadsamir added a comment to D12140: Support XTerm Alternate Scroll Mode escape sequences.

This doesn't apply cleanly now - can you quickly fix it? If not, I can try to handle it.

Apr 13 2018, 1:40 PM · Konsole
ahmadsamir updated the diff for D12140: Support XTerm Alternate Scroll Mode escape sequences.

Update commit message.

Apr 13 2018, 1:39 PM · Konsole
ahmadsamir updated the diff for D12140: Support XTerm Alternate Scroll Mode escape sequences.

Fix merge issues.

Apr 13 2018, 1:38 PM · Konsole

Apr 12 2018

ahmadsamir added a comment to D12139: Add profile property to toggle alternate scrolling.

OK, this is fine - I wonder who would disable this per-profile; especially with the upcoming other patch.

Apr 12 2018, 7:05 PM · Konsole
ahmadsamir updated the diff for D12032: Tweak README-KeyTab and README.keyboard a bit.

Rename README.KeyTab to README-KeyTab to prevent Konsole from trying to load it as a keyboard translator file.

Apr 12 2018, 5:57 PM · Konsole
ahmadsamir added a dependent revision for D12139: Add profile property to toggle alternate scrolling: D12140: Support XTerm Alternate Scroll Mode escape sequences.
Apr 12 2018, 7:57 AM · Konsole
ahmadsamir requested review of D12140: Support XTerm Alternate Scroll Mode escape sequences.
Apr 12 2018, 7:57 AM · Konsole
ahmadsamir requested review of D12139: Add profile property to toggle alternate scrolling.
Apr 12 2018, 7:40 AM · Konsole

Apr 8 2018

ahmadsamir updated the diff for D12015: Add docs to the user manual about the terminal key bindings.

Change <keycap>Ctrl</keycap> to &Ctrl;

Apr 8 2018, 9:32 AM · Konsole

Apr 7 2018

ahmadsamir requested review of D12032: Tweak README-KeyTab and README.keyboard a bit.
Apr 7 2018, 7:43 PM · Konsole
ahmadsamir added reviewers for D12015: Add docs to the user manual about the terminal key bindings: yurchor, ltoscano.
Apr 7 2018, 7:32 PM · Konsole
ahmadsamir updated the diff for D12015: Add docs to the user manual about the terminal key bindings.

I finally found doc/user/README.keyboard which mentioned some more stuff about the key bindings.
Added "credits" about the resources I used while writing this doc.

Apr 7 2018, 7:31 PM · Konsole
ahmadsamir updated the diff for D12015: Add docs to the user manual about the terminal key bindings.

Add a section about NewLine mode
Replace "Return" with Carriage Return in the output field section
Change version to 18.08

Apr 7 2018, 5:46 PM · Konsole
ahmadsamir updated the diff for D12015: Add docs to the user manual about the terminal key bindings.

Update the diff to address some of the issues pointed out in the review
request

Apr 7 2018, 2:11 PM · Konsole
ahmadsamir added a comment to D12015: Add docs to the user manual about the terminal key bindings.

The doc team was automatically added as subscriber.
Regarding the entity, just expand it inline, or define the entity in this file: we add it for people who have more contributions (and it would introduce a dependency on a new version of Frameworks, so you would need to keep the expanded version here anyway).

Apr 7 2018, 2:10 PM · Konsole
ahmadsamir added a comment to D12015: Add docs to the user manual about the terminal key bindings.

I totally missed the Newline mode, I'll update the diff (hopefully soon).

Apr 7 2018, 10:00 AM · Konsole
ahmadsamir added a comment to D12015: Add docs to the user manual about the terminal key bindings.

I couldn't find a guide on how to get my name and email added to the docbook entities in KDE, I would appreciate any pointers about that.

Apr 7 2018, 9:40 AM · Konsole
ahmadsamir requested review of D12015: Add docs to the user manual about the terminal key bindings.
Apr 7 2018, 9:38 AM · Konsole

Apr 6 2018

ahmadsamir added a comment to D11958: Make the keypad "5" key send "\E[E" when NumLock is off.

Thanks, in semi-unrelated news, the keybinding tab needs the "Remove" function that the ColorScheme Appearance tab has now.

Apr 6 2018, 1:37 PM · Konsole

Apr 5 2018

ahmadsamir added a comment to D11958: Make the keypad "5" key send "\E[E" when NumLock is off.

FTR, this fixes the original issue in the BR but not the other issues mentioned in the comments.

Apr 5 2018, 1:36 PM · Konsole
ahmadsamir requested review of D11958: Make the keypad "5" key send "\E[E" when NumLock is off.
Apr 5 2018, 1:24 PM · Konsole

Mar 30 2018

ahmadsamir requested review of D11821: Fix crash when using resetColorScheme().
Mar 30 2018, 8:58 PM · Konsole

Mar 24 2018

ahmadsamir added a comment to D11637: Make the key binding editor dialog bigger.

So 'arc diff' doesn't update the summary based on the new commit message done with 'git commit --amend'....

Mar 24 2018, 5:13 PM · Konsole
ahmadsamir updated the diff for D11637: Make the key binding editor dialog bigger.

I was careful not to make it bigger than the Edit Profile dialog, but it's still ok if it's shorter, I've changed it to make the initial height of the dialog 500px.

Mar 24 2018, 4:01 PM · Konsole