- User Since
- Nov 19 2017, 8:08 PM (100 w, 1 d)
- Can we make KColorScheme less needed by applications by adding more colors to QPalette itself? Using a tier 3 framework for more advanced use-cases is far less of a problem than for just getting the warning or error color for example.
As far as I understand:
- QGuiApplication by default uses the color palette of the style
- KDE has kstyle (from frameworkintegration), which has a standardPalette() method that calls KColorScheme which creates a QPalette and sets the colors, for the various color groups/roles, for it by getting the actual color scheme set in the system/user's settings, which means KColorScheme needs to read the config.
In private API we can have a method return a const &, as it can be
changed later without side-effects.
Sun, Oct 20
Fix if() loop totally wrong logic
Use QTabWidget instead of KTabWidget
movedTab signal is redundant
Less find_package calls
Sat, Oct 19
Thu, Oct 17
Wed, Oct 16
Some of the KColorScheme methods have a "config" object parameter, if that parameter is null, it uses use a local function, defaultConfig(), to get a default "config" object to work with.
It looks like KColorScheme provides more features, like color intesity and tint... etc. IINM, this is used when editing a color scheme (on the "Disabled" tab). Something similar was used in the icons kcm, i.e. you could change the hover effect of icons, i.e. more dark/gamma/tint... I looked just now (I haven't used that feature in ages) but it seems to be gone from the new kcm which was rewritten in QtQuick, probably dropped on the basis no one actually used it :)
KColorScheme uses KConfig and KColorUtils, and so, IIUC, it could be a tier2 but not a tier1.
Tue, Oct 15
T11214 is still being discussed, and we can always run clang-format later on.
Yeah, better arc land than breaking something (until the next time it gets on my nerves and I try to hack the arcanist source code, I know next to nothing about PHP... :)).
Mon, Oct 14
Revisiting an old issue :)
Sun, Oct 13
Better commit message
Since I wrote the docs bit anyway
Use KSslErrorUiData directly when calling askIgnoreSslErrors
Sat, Oct 12
Looking at kmenuedit and dolphin settings dialog, the margin and spacing look comparable, so those setContentMargins and setSpacing calls aren't needed any more.
@since should actually be in the future
Hello. I am working on the rest of the kdelibs4support bits in kmenuedit.
I had to fix one conflict when rebasing, and basically D24419 ate the foreach src/core/ksslcertificatemanager.cpp@line 128 (by returning the result of calling contains() on the container, neater :)).
I don't use IRC much, so I don't know how to thoroughly test the SSL encryption when authenticating with a name server; if someone could point me to some docs/guide about that, or test the patch himself, that'd be great.