ahmadsamir (Ahmad Samir)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2017, 8:08 PM (65 w, 1 d)
Availability
Available

Recent Activity

Yesterday

ahmadsamir added a comment to D18793: Handle text completion with block selection mode.

Ping?

Mon, Feb 18, 3:24 PM · Frameworks, Kate

Thu, Feb 14

ahmadsamir added a comment to D19017: Make "Save Session" action ask for a name for anonymous sessions.

From the referenced bug report this comment is talking about unnamed sessions getting saved in a way to allow configuring plugins and view layouts for such sessions... I looked at bug 156330, and this diff doesn't break the fix from the latter report; unless there's something I didn't understand.

Thu, Feb 14, 5:39 PM · Kate
ahmadsamir requested review of D19017: Make "Save Session" action ask for a name for anonymous sessions.
Thu, Feb 14, 5:32 PM · Kate

Wed, Feb 13

ahmadsamir added a comment to D18907: Handle the case if createSpeller is passed an unavailable language.

I don't have commit access, so please commit the diff.

Wed, Feb 13, 10:59 AM · Frameworks
ahmadsamir updated the diff for D18907: Handle the case if createSpeller is passed an unavailable language.

Avoid shorthand in api docs

Wed, Feb 13, 10:58 AM · Frameworks

Tue, Feb 12

ahmadsamir updated the diff for D18907: Handle the case if createSpeller is passed an unavailable language.

Improve api docs.
Use constFind() with languageClients, as that's more efficient than searching two separate data structures.

Tue, Feb 12, 9:16 PM · Frameworks
ahmadsamir added a comment to D18907: Handle the case if createSpeller is passed an unavailable language.

I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me.

Tue, Feb 12, 8:58 PM · Frameworks

Sun, Feb 10

ahmadsamir added a comment to D18317: Display an error message if loading a dictionary fails.

I've split the changes to the Loader in https://phabricator.kde.org/D18907.

Sun, Feb 10, 7:06 PM · Frameworks
ahmadsamir requested review of D18907: Handle the case if createSpeller is passed an unavailable language.
Sun, Feb 10, 7:04 PM · Frameworks

Wed, Feb 6

ahmadsamir requested review of D18793: Handle text completion with block selection mode.
Wed, Feb 6, 7:18 PM · Frameworks, Kate

Thu, Jan 31

ahmadsamir updated the diff for D18163: Set the color scheme to Printing for Print Preview.

Use a setter

Thu, Jan 31, 9:39 AM · Frameworks, Kate

Tue, Jan 29

ahmadsamir updated the diff for D18163: Set the color scheme to Printing for Print Preview.

Only set the color scheme to printing when using print preview

Tue, Jan 29, 6:27 PM · Frameworks, Kate
ahmadsamir added a comment to D18163: Set the color scheme to Printing for Print Preview.

Is KateRenderer::setPrinterFriendly() only called in print preview mode? I think not.

What is the bahavior currently when you print a page with another schema, and then print a page again? Does it always fallback to Printing without the patch, or does it remember the previous schema?

Tue, Jan 29, 4:34 PM · Frameworks, Kate
ahmadsamir added a reviewer for D18317: Display an error message if loading a dictionary fails: loh.tar.
Tue, Jan 29, 4:19 PM · Frameworks
ahmadsamir updated the diff for D18317: Display an error message if loading a dictionary fails.

Rework the patch:

  • so as not to change the config file without the user's intervention
  • core libs shouldn't depend on Gui bits
Tue, Jan 29, 4:18 PM · Frameworks
ahmadsamir added a comment to D18089: KLauncher: handle processes exiting without error.

Ping.

Tue, Jan 29, 8:13 AM · Frameworks

Tue, Jan 22

ahmadsamir added a comment to D18163: Set the color scheme to Printing for Print Preview.

A gentle ping.

Tue, Jan 22, 7:35 AM · Frameworks, Kate

Jan 19 2019

ahmadsamir added a comment to D18317: Display an error message if loading a dictionary fails.

Well, I'm not a Sonnet Guru, more a normal user.

Jan 19 2019, 5:13 PM · Frameworks
ahmadsamir added a comment to D18317: Display an error message if loading a dictionary fails.

Just my thoughts:

  • I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable.
Jan 19 2019, 12:53 PM · Frameworks

Jan 18 2019

ahmadsamir added a comment to D18317: Display an error message if loading a dictionary fails.

@loh.tar: I'll think that over, thanks for the pointers :)

Jan 18 2019, 6:42 PM · Frameworks
ahmadsamir added a comment to D18317: Display an error message if loading a dictionary fails.
In D18317#395530, @pino wrote:
In D18317#395513, @pino wrote:

This makes a "core" library grow a dependency on widgets -- not really a good idea, considering there is the sonnetui library for that.

In addition to the above, there are also really bad consquences: take a console-only application running QCoreApplication as application class and using sonnetcore. Now, in case of the situation described, sonnetcore will try spawn a QMessageBox, which IIRC exits the application, as no GUI is available.

Jan 18 2019, 2:02 PM · Frameworks

Jan 17 2019

ahmadsamir requested review of D18317: Display an error message if loading a dictionary fails.
Jan 17 2019, 1:06 PM · Frameworks

Jan 15 2019

ahmadsamir added a comment to D18163: Set the color scheme to Printing for Print Preview.

@dhaumann: in the screenshot that's "file -> print"; the issue here is with "file -> print preview", where the extra options tabs (including "Layout") aren't added by ktexteditor. :)

Jan 15 2019, 9:02 PM · Frameworks, Kate
This is a test notification, sent at Tue, Jan 15, 18:07.
Jan 15 2019, 4:07 PM
This is a test notification, sent at Tue, Jan 15, 18:07.
Jan 15 2019, 4:07 PM
This is a test notification, sent at Tue, Jan 15, 18:06.
Jan 15 2019, 4:06 PM

Jan 10 2019

ahmadsamir added reviewers for D18163: Set the color scheme to Printing for Print Preview: KTextEditor, dhaumann.
Jan 10 2019, 6:09 PM · Frameworks, Kate
ahmadsamir added a reviewer for D18163: Set the color scheme to Printing for Print Preview: cullmann.
Jan 10 2019, 6:03 PM · Frameworks, Kate
ahmadsamir requested review of D18163: Set the color scheme to Printing for Print Preview.
Jan 10 2019, 6:02 PM · Frameworks, Kate

Jan 9 2019

ahmadsamir added a comment to D18089: KLauncher: handle processes exiting without error.

I don't have commit access, so please commit the diff.

Jan 9 2019, 10:14 AM · Frameworks
ahmadsamir added inline comments to D18089: KLauncher: handle processes exiting without error.
Jan 9 2019, 10:09 AM · Frameworks
ahmadsamir updated the diff for D18089: KLauncher: handle processes exiting without error.

Make commit and debug messages less scary, i.e. exit instead of die

Jan 9 2019, 10:08 AM · Frameworks

Jan 8 2019

ahmadsamir updated the diff for D18089: KLauncher: handle processes exiting without error.

Fix commit message

Jan 8 2019, 9:23 AM · Frameworks
ahmadsamir added a reviewer for D18089: KLauncher: handle processes exiting without error: dfaure.
Jan 8 2019, 9:20 AM · Frameworks
ahmadsamir requested review of D18089: KLauncher: handle processes exiting without error.
Jan 8 2019, 9:19 AM · Frameworks

Dec 29 2018

ahmadsamir updated the diff for D17629: Add method to BackgroundChecker to add word to session.

Add doxygen doc for the new method including @since

Dec 29 2018, 9:53 AM · Frameworks

Dec 26 2018

ahmadsamir updated the diff for D17629: Add method to BackgroundChecker to add word to session.

arc diff verbatim

Dec 26 2018, 10:41 AM · Frameworks
ahmadsamir updated the diff for D17629: Add method to BackgroundChecker to add word to session.

Fix commit message

Dec 26 2018, 10:39 AM · Frameworks

Dec 24 2018

ahmadsamir requested review of D17781: Don't change alternate scrolling state after calling reset().
Dec 24 2018, 7:28 PM · Konsole

Dec 18 2018

ahmadsamir added a reviewer for D17629: Add method to BackgroundChecker to add word to session: sandsmark.
Dec 18 2018, 6:16 PM · Frameworks

Dec 16 2018

ahmadsamir added reviewers for D17630: Don't re-mark words added/ignored to the dictionary as misspelled: cullmann, davidedmundson.
Dec 16 2018, 6:18 PM · Frameworks, Kate
ahmadsamir requested review of D17630: Don't re-mark words added/ignored to the dictionary as misspelled.
Dec 16 2018, 6:17 PM · Frameworks, Kate
ahmadsamir added a dependent revision for D17629: Add method to BackgroundChecker to add word to session: D17630: Don't re-mark words added/ignored to the dictionary as misspelled.
Dec 16 2018, 6:17 PM · Frameworks
ahmadsamir added reviewers for D17629: Add method to BackgroundChecker to add word to session: davidedmundson, cullmann.
Dec 16 2018, 6:07 PM · Frameworks
ahmadsamir requested review of D17629: Add method to BackgroundChecker to add word to session.
Dec 16 2018, 6:04 PM · Frameworks

Dec 2 2018

ahmadsamir added a comment to D17266: Use DECSCUSR 0 to reset to default.

Yeah, the current way is fine, but I started using it in my own application, and I missed a way to just reset to the original state.

And ref. the linked discussion in the gnome bugtracker for gnome terminal/vte, the doc is a bit ambigous, so they chose to interpret it in a way that also enables applications to easily reset the cursor style.

Dec 2 2018, 9:19 AM · Konsole

Dec 1 2018

ahmadsamir added a comment to D17266: Use DECSCUSR 0 to reset to default.

IIRC, I researched that issue when I submitted the DECSCUSR diff; and the current behaviour matches the VT510[1], VT520[2] documentation and the XTerm implementation.

Dec 1 2018, 7:34 AM · Konsole

Jun 14 2018

ahmadsamir added a comment to T5437: arcanist: option to ignore untracked files.

For the sake of the next person getting here through the frustrated-online-search tunnel (like I just did a few hours ago, after the untracked files conundrum hit me about 50 times), here's a simple bash function that I came up with to use --allow-untracked with arc diff (there are probably more elegant ways to do this, but this WFM, so):

Jun 14 2018, 4:50 PM · Phabricator
ahmadsamir added a comment to D13511: Remove SearchBar from the MainWindowOverview.

Consequently this patch will fix https://bugs.kde.org/show_bug.cgi?id=336129, (it should be mentioned in the commit message).

Jun 14 2018, 4:08 PM · Konsole
ahmadsamir added a comment to D13511: Remove SearchBar from the MainWindowOverview.

This looks really good.

  1. I notice there are times the mouse pointer disappears when over the searchbar: a) when there's a lot of history and search for some text, clicking up or down multiple times, the mouse pointer disappears. Moving the mouse out of the searchbar make the pointer reappear. b) sometimes when just moving mouse between searchbar widgets
Jun 14 2018, 3:42 PM · Konsole
ahmadsamir added inline comments to D13516: simplify isProfileDeletable.
Jun 14 2018, 8:09 AM · Konsole

Jun 13 2018

ahmadsamir added inline comments to D13516: simplify isProfileDeletable.
Jun 13 2018, 6:54 PM · Konsole

Jun 12 2018

ahmadsamir added a comment to D13174: New layout for the search bar..

I haven't tested this, but does it make sense to just make the searchBar part of the TerminalDisplay Class and do away the TerminalWidget concept? theoretically, in my mind anyway, it would make this patch a lot smaller as calls to TerminalDisplay objects wouldn't need to be changed then. (Just an untested thought, I'll hopefully try and test this tomorrow).

Jun 12 2018, 9:30 PM · Konsole

Jun 8 2018

ahmadsamir added inline comments to D13428: De duplicate setContainerFeatures.
Jun 8 2018, 6:52 PM · Konsole

Jun 7 2018

ahmadsamir added a comment to D13174: New layout for the search bar..

One corner case comes to mind (whether it has to be fixed here or in a separate review later on), if the matched text is under the search bar, the user won't be able to see it, this can be further split into two cases (and two different solutions?):
a) if there's room to scroll up/down to show the text
b) if there's no room to scroll.

Jun 7 2018, 11:43 AM · Konsole

Jun 6 2018

ahmadsamir updated the diff for D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().

Fix Q_ASSERT condition.
Fix session()->isPrimaryScreen() condition.

Jun 6 2018, 2:58 PM · Konsole
ahmadsamir added inline comments to D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Jun 6 2018, 12:49 PM · Konsole

Jun 5 2018

ahmadsamir added a reviewer for D13271: Use Q_ASSERT to catch null pointers for _sessionController and session(): hindenburg.
Jun 5 2018, 9:25 PM · Konsole
ahmadsamir updated the diff for D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().

Actually update the commit message

Jun 5 2018, 9:24 PM · Konsole
ahmadsamir updated the diff for D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().

Use Q_ASSERT instead of checking for nullptr

Jun 5 2018, 9:23 PM · Konsole
ahmadsamir added inline comments to D13356: Fix block selection mode in a couple of cases.
Jun 5 2018, 1:07 PM · Konsole
ahmadsamir updated the diff for D13356: Fix block selection mode in a couple of cases.

Tighten parentheses.

Jun 5 2018, 1:05 PM · Konsole
ahmadsamir requested review of D13356: Fix block selection mode in a couple of cases.
Jun 5 2018, 9:53 AM · Konsole

Jun 3 2018

ahmadsamir added a comment to D13174: New layout for the search bar..

A couple of notes:

  • Disabling "use current window size on next startup", the size setting in the profile seems to be ignored, the window that shows up is way too small
  • After starting a new window, initially the terminal display prompt doesn't have focus (empty block cursor), the same thing happens when opening a new tab
Jun 3 2018, 3:48 PM · Konsole

Jun 2 2018

ahmadsamir added inline comments to D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Jun 2 2018, 9:34 AM · Konsole

Jun 1 2018

ahmadsamir requested review of D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Jun 1 2018, 3:57 PM · Konsole
ahmadsamir added a comment to D13217: Move isPrimaryScreen() to Session.

OK thanks, using 'man man' did not work for me but yes vim file did work in the testing.

Jun 1 2018, 1:23 PM · Konsole

May 31 2018

ahmadsamir updated the diff for D13217: Move isPrimaryScreen() to Session.

Tweak commit message

May 31 2018, 4:45 PM · Konsole
ahmadsamir added inline comments to D13217: Move isPrimaryScreen() to Session.
May 31 2018, 4:37 PM · Konsole
ahmadsamir updated the diff for D13217: Move isPrimaryScreen() to Session.

Change the code to check that session* is valid before accessing it

May 31 2018, 4:36 PM · Konsole

May 30 2018

ahmadsamir updated the diff for D13217: Move isPrimaryScreen() to Session.

Used --verbatim before adding a Test Plan:

May 30 2018, 4:25 PM · Konsole
ahmadsamir requested review of D13217: Move isPrimaryScreen() to Session.
May 30 2018, 4:22 PM · Konsole

May 28 2018

ahmadsamir updated the diff for D13147: Replace setUserTitle() with setSessionAttribute().

Rebase.

May 28 2018, 2:47 PM · Konsole
ahmadsamir added a comment to D13134: Invert the logic for Mouse Tracking events.

Thanks, the only issue I see is that shouldn't the two constructor initialization be swamped for true? _usesMouseTracking(false), _usesMouseTracking(false),

May 28 2018, 12:51 PM · Konsole

May 27 2018

ahmadsamir updated the diff for D13147: Replace setUserTitle() with setSessionAttribute().

Corrections in the commit message

May 27 2018, 1:00 PM · Konsole
ahmadsamir requested review of D13147: Replace setUserTitle() with setSessionAttribute().
May 27 2018, 12:59 PM · Konsole

May 26 2018

ahmadsamir updated the diff for D13134: Invert the logic for Mouse Tracking events.

Clarify steps in the Test Plan

May 26 2018, 11:06 AM · Konsole
ahmadsamir updated the diff for D13134: Invert the logic for Mouse Tracking events.

Tweak the commit message some more

May 26 2018, 10:58 AM · Konsole
ahmadsamir updated the diff for D13134: Invert the logic for Mouse Tracking events.

Tweak the commit message (i.e. correct grammatical mistakes)

May 26 2018, 10:55 AM · Konsole
ahmadsamir added a comment to D13089: Fix mouse coords for programs interested with it.

I think we need to fix _mouseMarks at some point

FIXME: the actual value of _mouseMarks is the opposite of its semantic.
When using programs not interested with mouse(shell, less), it is true.
// When using programs interested with mouse(vim,mc), it is false.

May 26 2018, 9:13 AM · Konsole
ahmadsamir requested review of D13134: Invert the logic for Mouse Tracking events.
May 26 2018, 9:10 AM · Konsole

May 23 2018

ahmadsamir requested review of D13078: Ignore control characters in the text part of Xpe "ESC]" sequences.
May 23 2018, 8:09 PM · Konsole

May 22 2018

ahmadsamir updated the diff for D12981: Improve the Keyboard tab and the KeyBindings editor.

Add missing semicolon

May 22 2018, 4:34 PM · Konsole
ahmadsamir added a comment to D12981: Improve the Keyboard tab and the KeyBindings editor.

KeyBindingEditor.cpp:66:97: error: expected ';' after expression

_ui->descriptionEdit->setPlaceholderText(i18nc("@label:textbox", "Enter descriptive label"))
May 22 2018, 4:34 PM · Konsole
ahmadsamir updated subscribers of D12981: Improve the Keyboard tab and the KeyBindings editor.

I notice you can overwrite files w/o any notice - create multiple new key bindings files and apply/ok. You don't need to work on that just bringing it up.

May 22 2018, 2:29 PM · Konsole
ahmadsamir updated the diff for D12981: Improve the Keyboard tab and the KeyBindings editor.

Use the same placeholderText from the Edit Profile dialog General tab, more consistent wording across the application and saves the translators a bit of time

May 22 2018, 2:14 PM · Konsole
ahmadsamir updated subscribers of D12981: Improve the Keyboard tab and the KeyBindings editor.

doesn't build here

KeyBindingEditor.cpp:307:9: error: use of undeclared identifier 'KMessageBox'

KMessageBox::sorry(this, i18n("A key bindings scheme cannot be saved with an empty description."));
May 22 2018, 1:13 PM · Konsole
ahmadsamir updated the diff for D12981: Improve the Keyboard tab and the KeyBindings editor.

Add proper include

May 22 2018, 1:12 PM · Konsole
ahmadsamir updated subscribers of D12981: Improve the Keyboard tab and the KeyBindings editor.
May 22 2018, 12:31 PM · Konsole
ahmadsamir updated the diff for D12981: Improve the Keyboard tab and the KeyBindings editor.

Disallow saving a scheme with an empty description

May 22 2018, 12:30 PM · Konsole
ahmadsamir added a comment to D12981: Improve the Keyboard tab and the KeyBindings editor.

[..]

  1. You can remove the description which shouldn't be allowed - just like profile name can't be empty - I would not use a special kmessagewidget - just use something like setPlaceholderText(i18n("A name must be entered!")); and do the normal popup about missing description when Apply/OK
May 22 2018, 12:28 PM · Konsole

May 19 2018

ahmadsamir requested review of D12981: Improve the Keyboard tab and the KeyBindings editor.
May 19 2018, 12:45 PM · Konsole

May 16 2018

ahmadsamir updated the diff for D12899: Backspace without CTRL should send '^?'.

Add BUG and FIXED-IN lines

May 16 2018, 3:25 AM · Konsole

May 15 2018

ahmadsamir requested review of D12899: Backspace without CTRL should send '^?'.
May 15 2018, 4:10 PM · Konsole

May 10 2018

ahmadsamir updated the diff for D12797: Fix scoping issues with Screen::DecodingOptions.

Take 2

May 10 2018, 4:22 AM · Konsole
ahmadsamir updated the diff for D12797: Fix scoping issues with Screen::DecodingOptions.

Fix phabricator markup screw-up

May 10 2018, 4:20 AM · Konsole
ahmadsamir requested review of D12797: Fix scoping issues with Screen::DecodingOptions.
May 10 2018, 4:19 AM · Konsole

May 8 2018

ahmadsamir added a comment to D12733: The exported version env var should have a consistent length.

Ok sorry for the noise - I should have read this more closer

May 8 2018, 8:59 PM · Konsole
ahmadsamir added a comment to D12733: The exported version env var should have a consistent length.
I was wondering if .remove(".").append("0").left(6) would be easier.
May 8 2018, 7:42 AM · Konsole

May 7 2018

ahmadsamir added a comment to D12733: The exported version env var should have a consistent length.

Thanks for thinking of this. Would it be simplier to remove .; append '00' and then take left 6?

May 7 2018, 7:48 PM · Konsole