ahmadsamir (Ahmad Samir)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2017, 8:08 PM (114 w, 1 h)
Availability
Available

Recent Activity

Today

ahmadsamir updated the diff for D23457: Port the search interface from QRegExp to QRegularExpression.
  • Rebase
  • Match the old code and check if the pattern is empty, this lets the vimode_emulatedcommandbar unit test pass
Sun, Jan 26, 12:08 PM · Frameworks, Kate

Yesterday

ahmadsamir committed R261:74a1b7f848c8: Port KRecursiveFilterProxyModel to QSortFilterProxyModel (authored by ahmadsamir).
Port KRecursiveFilterProxyModel to QSortFilterProxyModel
Sat, Jan 25, 8:51 PM
ahmadsamir closed D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.
Sat, Jan 25, 8:51 PM
ahmadsamir updated the diff for D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Rebase

Sat, Jan 25, 8:51 PM

Fri, Jan 24

ahmadsamir abandoned D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty.

OK.

Fri, Jan 24, 7:29 PM · Plasma
ahmadsamir requested review of D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty.
Fri, Jan 24, 7:11 PM · Plasma

Wed, Jan 22

ahmadsamir committed R45:1691cdd142d3: Port KRecursiveFilterProxyModel to QSortFilterProxyModel (authored by ahmadsamir).
Port KRecursiveFilterProxyModel to QSortFilterProxyModel
Wed, Jan 22, 12:00 PM
ahmadsamir closed D26568: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.
Wed, Jan 22, 12:00 PM
ahmadsamir added a comment to D26568: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

thanks, lgtm - do you have commit rights? if so, please push to master

Wed, Jan 22, 11:53 AM
ahmadsamir updated the diff for D26568: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Set requiered Qt version to 5.10

Wed, Jan 22, 9:48 AM
ahmadsamir committed R96:1526b7756a6f: [Syndication] Port QRegExp to QRegularExpression (authored by ahmadsamir).
[Syndication] Port QRegExp to QRegularExpression
Wed, Jan 22, 9:39 AM
ahmadsamir closed D26435: [Syndication] Port QRegExp to QRegularExpression.
Wed, Jan 22, 9:39 AM · KDE PIM

Tue, Jan 21

ahmadsamir added a comment to D26101: Port away from Qt 5.14 deprecated QList methods.

FTR, a recent discussion on #kde-devel on Freenode, which involved QSet and toSet(), made me understand why the original code was using toSet(), then fromSet(), it was to remove duplicates as QSet doesn't allow duplicates.

Tue, Jan 21, 7:34 PM · Baloo, Frameworks
ahmadsamir added a comment to D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

I tested the accountsproxymodel here with Qt 5.14.0, it works; and all unit tests pass (except qsqlcipher-test, which also fails on master). I couldn't figure out the Equities and Securities models, I haven't used KMyMoney before, so I don't know it that well.

Tue, Jan 21, 7:16 PM
ahmadsamir added a comment to D26568: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Ping.

Tue, Jan 21, 8:35 AM
ahmadsamir added a comment to D26119: Port QRegExp to QRegularExpression.

Ping.

Tue, Jan 21, 8:33 AM · KDE PIM
ahmadsamir updated the diff for D26119: Port QRegExp to QRegularExpression.

Rebase and tweak the commit message

Tue, Jan 21, 8:32 AM · KDE PIM
ahmadsamir added a comment to D26435: [Syndication] Port QRegExp to QRegularExpression.

Ping.

Tue, Jan 21, 8:30 AM · KDE PIM
ahmadsamir committed R241:0d2959c96b6b: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir).
Fix QRegularExpression::wildcardToRegularExpression() usage
Tue, Jan 21, 8:27 AM
ahmadsamir closed D26692: Fix QRegularExpression::wildcardToRegularExpression() usage.
Tue, Jan 21, 8:27 AM · Frameworks
ahmadsamir updated the diff for D26692: Fix QRegularExpression::wildcardToRegularExpression() usage.

Rebase

Tue, Jan 21, 8:27 AM · Frameworks
ahmadsamir committed R241:df383663d14e: [KCoreDirLister] Port QRegExp to QRegularExpression (authored by ahmadsamir).
[KCoreDirLister] Port QRegExp to QRegularExpression
Tue, Jan 21, 8:26 AM
ahmadsamir closed D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.
Tue, Jan 21, 8:26 AM · Frameworks
ahmadsamir updated the diff for D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.

Rebase and tweak the commit message

Tue, Jan 21, 8:25 AM · Frameworks
ahmadsamir committed R286:c36ecf9c474a: Port away from deprecated QList::toSet() method (authored by ahmadsamir).
Port away from deprecated QList::toSet() method
Tue, Jan 21, 5:56 AM
ahmadsamir closed D26786: Port away from deprecated QList::toSet() method.
Tue, Jan 21, 5:56 AM · Baloo, Frameworks

Mon, Jan 20

ahmadsamir added inline comments to D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.
Mon, Jan 20, 5:03 PM
ahmadsamir updated the diff for D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

setRecursiveFilteringEnabled() method provided for backward compatibility should be empty

Mon, Jan 20, 5:02 PM
ahmadsamir committed R4:f7e109f27bae: Make QRegularExpression filtering actually case-insensitive (authored by ahmadsamir).
Make QRegularExpression filtering actually case-insensitive
Mon, Jan 20, 4:55 PM
ahmadsamir closed D26795: Make QRegularExpression filtering actually case-insensitive.
Mon, Jan 20, 4:55 PM
ahmadsamir updated the diff for D26795: Make QRegularExpression filtering actually case-insensitive.

Only use QRegularExpression::CaseInsensitiveOption where needed

Mon, Jan 20, 4:21 PM
ahmadsamir added a comment to D26795: Make QRegularExpression filtering actually case-insensitive.

FTR, there's no way the quickseledctdialogtest could have passed locally; so it looks like I messed/mixed things up with the other diff (KRecursive* port), I must have ran ctest without remember to run make in the build dir when I switched branches, stooopid. Sorry about the trouble.

Mon, Jan 20, 4:08 PM
ahmadsamir requested review of D26795: Make QRegularExpression filtering actually case-insensitive.
Mon, Jan 20, 4:06 PM
ahmadsamir committed R4:f0ff160bca07: Port QRegExp to QRegularExpression (authored by ahmadsamir).
Port QRegExp to QRegularExpression
Mon, Jan 20, 1:49 PM
ahmadsamir closed D26567: Port QRegExp to QRegularExpression.
Mon, Jan 20, 1:49 PM
ahmadsamir committed R4:cb1e5e369fcf: Port KRecursiveFilterProxyModel to QSortFilterProxyModel (authored by ahmadsamir).
Port KRecursiveFilterProxyModel to QSortFilterProxyModel
Mon, Jan 20, 1:37 PM
ahmadsamir closed D26562: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.
Mon, Jan 20, 1:37 PM
ahmadsamir requested review of D26786: Port away from deprecated QList::toSet() method.
Mon, Jan 20, 11:49 AM · Baloo, Frameworks

Sun, Jan 19

ahmadsamir closed D26759: [Solid] Port away from deprecated QList methods.
Sun, Jan 19, 9:22 AM · Frameworks
ahmadsamir committed R245:4b3f108b1809: [Solid] Port away from deprecated QList methods (authored by ahmadsamir).
[Solid] Port away from deprecated QList methods
Sun, Jan 19, 9:22 AM
ahmadsamir requested review of D26759: [Solid] Port away from deprecated QList methods.
Sun, Jan 19, 7:52 AM · Frameworks
ahmadsamir updated the diff for D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Address comments

Sun, Jan 19, 7:34 AM

Sat, Jan 18

ahmadsamir added a comment to D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

It just crosses my mind, that it would be a lot safer if we add

#undef QSortFilterProxyModel

to the end of the header files and enclose all the source code in the affected cpp files also with

#if QT_VERSION < QT_VERSION_CHECK(5,10,0)
#define QSortFilterProxyModel KRecursiveFilterProxyModel
#endif
:
:
:
#undef QSortFilterProxyModel

This way, the redefinition of QSFP cannot escape this context which would otherwise happen if the header file is included in another source file and that one references the real QSFP.

Sat, Jan 18, 5:24 PM
ahmadsamir added a comment to D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Almost. It works on Qt < 5.10 only with the patch below on top of your change. Do you have write access to the KDE repo?

I'd checked the documentation and I know <KRecursiveFilterProxyModel> works with other apps, but indeed it doesn't work here; I tried to figure out why, then gave up after grep'ping in too many cmake files :)

Anyway, added your patch and updated the diff. And yes, I have write access to KDE repo.

From a cursory glance it could be because you are defining qsfpm to be krfpm but qsfpm is also mentioned within its header file.

Sat, Jan 18, 4:21 PM
ahmadsamir added a comment to D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Almost. It works on Qt < 5.10 only with the patch below on top of your change. Do you have write access to the KDE repo?

Sat, Jan 18, 3:29 PM
ahmadsamir updated the diff for D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.
  • Add patch from review to fix build on Qt < 5.10.0
Sat, Jan 18, 3:26 PM
ahmadsamir committed R311:02ab54ea6fe8: Revert readEntryList() to use QRegExp::Wildcard (authored by ahmadsamir).
Revert readEntryList() to use QRegExp::Wildcard
Sat, Jan 18, 12:51 PM
ahmadsamir closed D26734: Revert readEntryList() to use QRegExp::Wildcard.
Sat, Jan 18, 12:51 PM · Frameworks
ahmadsamir added a comment to D26734: Revert readEntryList() to use QRegExp::Wildcard.

Any longer terms plan for porting away from QRegExp then?

Or is it arguably a bug in QRegularExpression that is assumes globbing is only used for files?

Sat, Jan 18, 11:51 AM · Frameworks
ahmadsamir added a comment to D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one.

FRT, there's only one usage of perlSplit(QChar...), https://lxr.kde.org/source/kde/kdemultimedia/libkcddb/libkcddb/cdinfo.cpp#0313
nothing else uses any of the perlSplit() functions.

Sat, Jan 18, 8:03 AM · Frameworks
ahmadsamir closed D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one.
Sat, Jan 18, 7:17 AM · Frameworks
ahmadsamir committed R244:aa908f7b2006: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp… (authored by ahmadsamir).
Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp…
Sat, Jan 18, 7:17 AM
ahmadsamir updated the diff for D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Address comments

Sat, Jan 18, 6:32 AM
ahmadsamir updated the diff for D26734: Revert readEntryList() to use QRegExp::Wildcard.

Tweak commit message

Sat, Jan 18, 5:09 AM · Frameworks

Fri, Jan 17

ahmadsamir updated the diff for D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.
  • Don't use anchoredPattern() with wilcardToRegularExpression() as the latter already returns an anchored pattern
  • Remove the bit about setNameFilter() from the commit message, wildcardToRegularExpression() should work with file glob patterns
Fri, Jan 17, 9:12 PM · Frameworks
ahmadsamir added a comment to D26734: Revert readEntryList() to use QRegExp::Wildcard.

See D26205 for details.

Fri, Jan 17, 9:01 PM · Frameworks
ahmadsamir updated the diff for D26734: Revert readEntryList() to use QRegExp::Wildcard.

Tweak commit message and test plan

Fri, Jan 17, 6:34 PM · Frameworks
ahmadsamir added a comment to D26734: Revert readEntryList() to use QRegExp::Wildcard.

Another way to fix the issue, would be to pass an empty QString as the first argument to readEntryList(), in which case readEntryList() returns all the entries, and to change the behaviour of readEntryList to use a full-fledged regex pattern to use instead of supporting wildcards.

Fri, Jan 17, 6:32 PM · Frameworks
ahmadsamir requested review of D26734: Revert readEntryList() to use QRegExp::Wildcard.
Fri, Jan 17, 6:29 PM · Frameworks
ahmadsamir added inline comments to D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.
Fri, Jan 17, 7:32 AM · Frameworks

Thu, Jan 16

ahmadsamir committed R311:d4980443755f: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir).
Fix QRegularExpression::wildcardToRegularExpression() usage
Thu, Jan 16, 6:04 PM
ahmadsamir closed D26707: Fix QRegularExpression::wildcardToRegularExpression() usage.
Thu, Jan 16, 6:04 PM · Frameworks
ahmadsamir planned changes to D26215: Port QRegExp to QRegularExpression.
Thu, Jan 16, 3:10 PM · Dolphin
ahmadsamir added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.

otherwise, we could just revert this patch

The rest of the code is OK. The part that works funny is just the wildcard method, and since it's relatively new, I hope there could be a good workaround until the situation stabilizes

Thu, Jan 16, 2:00 PM · Frameworks
ahmadsamir requested review of D26707: Fix QRegularExpression::wildcardToRegularExpression() usage.
Thu, Jan 16, 1:59 PM · Frameworks
ahmadsamir added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.
Thu, Jan 16, 9:10 AM · Frameworks
ahmadsamir committed R495:ce27c7cf1121: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir).
Fix QRegularExpression::wildcardToRegularExpression() usage
Thu, Jan 16, 8:49 AM
ahmadsamir closed D26693: Fix QRegularExpression::wildcardToRegularExpression() usage.
Thu, Jan 16, 8:49 AM · Frameworks
ahmadsamir updated the diff for D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.

Add TODO KF6 notes to remove doNameFilter() and doMimeFilter()

Thu, Jan 16, 8:48 AM · Frameworks

Wed, Jan 15

ahmadsamir added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.

https://github.com/KDE/falkon/blob/master/src/plugins/KDEFrameworksIntegration/kwalletpasswordbackend.cpp#L187

QMap<QString, QByteArray> entries;
if (m_wallet->readEntryList("*", entries) != 0) {
    qWarning() << "KWalletPasswordBackend::initialize Cannot read entries!";
    return;
}

This is the problematic code. As you can see it uses "*" as a wildcard. So may be it is possible just to use a different wildcard and it could be solved IDK

Wed, Jan 15, 7:37 PM · Frameworks
ahmadsamir requested review of D26693: Fix QRegularExpression::wildcardToRegularExpression() usage.
Wed, Jan 15, 7:08 PM · Frameworks
ahmadsamir requested review of D26692: Fix QRegularExpression::wildcardToRegularExpression() usage.
Wed, Jan 15, 7:03 PM · Frameworks
ahmadsamir added inline comments to D26205: KWallet: Port QRegExp to QRegularExpression.
Wed, Jan 15, 4:12 PM · Frameworks
ahmadsamir added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.

A test case of what is broken would be appreciated, to try and fix/debug the issue.

Wed, Jan 15, 3:27 PM · Frameworks
ahmadsamir added inline comments to D26205: KWallet: Port QRegExp to QRegularExpression.
Wed, Jan 15, 3:26 PM · Frameworks
ahmadsamir updated the diff for D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.

Add TODO KF6 to doNameFilter()

Wed, Jan 15, 9:45 AM · Frameworks

Tue, Jan 14

ahmadsamir updated the diff for D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.

Verbatim

Tue, Jan 14, 2:47 PM · Frameworks
ahmadsamir added inline comments to D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.
Tue, Jan 14, 2:44 PM · Frameworks
ahmadsamir updated the diff for D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.

Verbatim

Tue, Jan 14, 2:44 PM · Frameworks
ahmadsamir updated the diff for D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.

Can't change doNameFilter due to BIC

Tue, Jan 14, 2:42 PM · Frameworks
ahmadsamir requested review of D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.
Tue, Jan 14, 12:18 PM · Frameworks
ahmadsamir requested review of D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one.
Tue, Jan 14, 11:32 AM · Frameworks

Mon, Jan 13

ahmadsamir updated the diff for D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Add QT_VERSION checks to keep the code buildable with older Qt versions

Mon, Jan 13, 5:48 PM
ahmadsamir committed R739:f3f3f97f96f7: Port KRecursiveFilterProxyModel to QSortFilterProxyModel (authored by ahmadsamir).
Port KRecursiveFilterProxyModel to QSortFilterProxyModel
Mon, Jan 13, 5:47 PM
ahmadsamir closed D26577: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.
Mon, Jan 13, 5:47 PM
ahmadsamir updated the diff for D26577: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Verbatim

Mon, Jan 13, 4:04 PM
ahmadsamir updated the diff for D26577: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Treat SectionProxyModel specially be borrowing code from KRecursiveFilterProxyModel::filterAcceptsRow()

Mon, Jan 13, 3:53 PM
ahmadsamir committed R293:eec35486c419: Port QRegExp to QRegularExpression (authored by ahmadsamir).
Port QRegExp to QRegularExpression
Mon, Jan 13, 8:53 AM
ahmadsamir closed D26099: Port QRegExp to QRegularExpression.
Mon, Jan 13, 8:53 AM · Baloo, Frameworks
ahmadsamir updated the diff for D26099: Port QRegExp to QRegularExpression.
  • Rebase\n- Move second match inside if condition, otherwise the control flow never passes through the next else if branch
Mon, Jan 13, 6:50 AM · Baloo, Frameworks

Sat, Jan 11

ahmadsamir added a comment to T12269: Remove KRecursiveFilterProxyModel.

(D26567 seems unrelated to this)

Yep, got it mixed up with D26562 (phabricator verbatim special "gift").

Sat, Jan 11, 9:15 PM · KF6
ahmadsamir removed a task from D26567: Port QRegExp to QRegularExpression: T12269: Remove KRecursiveFilterProxyModel.
Sat, Jan 11, 9:13 PM
ahmadsamir removed a revision from T12269: Remove KRecursiveFilterProxyModel: D26567: Port QRegExp to QRegularExpression.
Sat, Jan 11, 9:13 PM · KF6
ahmadsamir added a task to D26562: Port KRecursiveFilterProxyModel to QSortFilterProxyModel: T12269: Remove KRecursiveFilterProxyModel.
Sat, Jan 11, 9:13 PM
ahmadsamir added a revision to T12269: Remove KRecursiveFilterProxyModel: D26562: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.
Sat, Jan 11, 9:13 PM · KF6
ahmadsamir added a comment to D26577: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

I am looking into the performance issue, I'll see if I can track it down.

Sat, Jan 11, 1:33 PM
ahmadsamir updated the diff for D26577: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Fix function recursion

Sat, Jan 11, 1:32 PM
ahmadsamir added a comment to D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

OK, no problem. I'll add the necessary #ifdef's and update the diff.

Sat, Jan 11, 1:05 PM
ahmadsamir added a comment to T12269: Remove KRecursiveFilterProxyModel.

Only PIM left, is Kube, which looks like it copies the implementation from kitemmodels (or the other was around, whichever was developed first).

Sat, Jan 11, 10:01 AM · KF6
ahmadsamir added a comment to T12269: Remove KRecursiveFilterProxyModel.

KDevelop is done with https://cgit.kde.org/kdevelop.git/commit/?id=8c9f26dcbc832c574d89d2be6aabae52c9d94c1f

Sat, Jan 11, 9:58 AM · KF6