- User Since
- Nov 19 2017, 8:08 PM (91 w, 2 d)
Fri, Aug 9
@gawin: hello; how are you creating the diff? if you haven't used arc diff, that could be one reason why the commit authorship is messed up.
Sat, Aug 3
Jul 17 2019
FWIW, the combined effect of this patch and D22477, hopefully you'll no longer see the Q_RETRUN_ARG and co. completions unless the menu is manually invoked with the mode set to C++.
Fix test plan :/
I messed up the test plan; try with the mode set to Python. It looks like a corner case where if there's only one exact match, the completions menu doesn't get auto hidden.
Jul 16 2019
Change the diff altogether to not show the menu with "ContainsMatch"
Noted. Thought I most likely didn't add "only" because the config name was becoming rather too long, but you have a point.
Actually, perhaps that whole option could/should be even an enum for 3 cases:
a) from full word start
b) from subword start (CamelCase, _)
c) match anywhere in word.
I vaguely remember some cases where I got annoyed by cross-subword hits accidentally creating a match.
Jul 15 2019
Jul 13 2019
Jul 9 2019
- Make readProperties() call loadOpenRecent()
- If there are any kate main windows, loop over them
Jul 8 2019
If this is OK, please commit it too.
Fix action name, don't use camel case, use _
Fix comment indentation :)
Use an Enum instead of bool
IMHO, "Enable/Disable" is already implied by the checkbox :)
Jul 5 2019
Jul 4 2019
OK, fair point.
Ctrl+Enter/Return may be a too common shortcut, i.e. users probably have it already mapped to do something, so maybe we shouldn't set a default shortcut for that action...
OK. So "window configuration" here means, the window size, state, and the view properties e.g. splitters... etc. The name threw me off (I confused it with KMainWindow window configuration), and the fact that saveSessionTo() always executes KateMainWindow::saveProperties() regardless of the config setting.
Jul 3 2019
KateSessionManager::saveSessionTo(), only saves the window configuration, when the same condition is true:
(KConfigGroup(KSharedConfig::openConfig(), "General")).readEntry("Restore Window Configuration", true)
Jul 1 2019
OK. Here's where I am at the moment. If we store the position of the project and projectinfo plugin (one plugin, two tool views), if the user opens another session in the same window, things start getting messy as now there will be the position of the first session and the second session, so now we'd have to store the session name along with the position... this is starting to become too complicated for such a small issue.
Jun 27 2019
Jun 26 2019
Looking closer at this, it's more complicated than I initially thought :)
Jun 24 2019
Jun 23 2019
Great :). Please commit it too (as I don't have access to kde git).
Use a lambda instead of adding a standalone method
Jun 21 2019
Qt docs say that the signal must have at least as many arguments as the slot, and there is an implicit conversion between the types of the corresponding arguments in the signal and the slot.
Jun 20 2019
What I'm asking is if it ever makes sense for the user to tell Kate to always use the Breeze Light color scheme when the system is itself already using the Breeze Light color scheme.
Jun 17 2019
Jun 10 2019
With the last proposal the user won't be able to set the the color scheme/theme to Breeze unconditionally in kate (i.e. if the scheme in systemsettings5 is changed kate will follow it).
Jun 9 2019
I took a guess for the fixed-in: field, sorry if it's wrong.
Apr 9 2019
Please commit. Thanks.
Apr 8 2019
Please commit it too.
Apr 6 2019
Mar 26 2019
IMHO, there should be no dimming at all; the whole point of the present windows effect is to use visual identification instead of having to read the title of each window. Visual id is faster, I think.
Mar 25 2019
Mar 17 2019
- Split the code responsible for inserting text in block selection from typeChars() to a new function
- Don't add words where the block selection cursor is inside to the possible completion matches from the document
- Add unit test
Mar 5 2019
Mar 4 2019
Do we still need a unit test for this?
Feb 27 2019
No, it doesn't fix it.
! In D19161#415702, @dhaumann wrote:
Btw, searching in lxr.kde.org for FontUnderline reveals some more hits: https://lxr.kde.org/ident?_i=FontUnderline&_remember=1
Feb 26 2019
I changed the diff to make replaceText handle inserting the word completion text.
Change replaceText to handle inserting word completion with block selection mode
Feb 20 2019
Feb 19 2019
Feb 18 2019
Feb 14 2019
From the referenced bug report this comment is talking about unnamed sessions getting saved in a way to allow configuring plugins and view layouts for such sessions... I looked at bug 156330, and this diff doesn't break the fix from the latter report; unless there's something I didn't understand.
Feb 13 2019
I don't have commit access, so please commit the diff.
Avoid shorthand in api docs
Feb 12 2019
Improve api docs.
Use constFind() with languageClients, as that's more efficient than searching two separate data structures.
Feb 10 2019
I've split the changes to the Loader in https://phabricator.kde.org/D18907.
Feb 6 2019
Jan 31 2019
Use a setter
Jan 29 2019
Only set the color scheme to printing when using print preview
Rework the patch:
- so as not to change the config file without the user's intervention
- core libs shouldn't depend on Gui bits
Jan 22 2019
A gentle ping.
Jan 19 2019
Jan 18 2019
@loh.tar: I'll think that over, thanks for the pointers :)
Jan 17 2019
Jan 15 2019
@dhaumann: in the screenshot that's "file -> print"; the issue here is with "file -> print preview", where the extra options tabs (including "Layout") aren't added by ktexteditor. :)
Jan 10 2019
Jan 9 2019
I don't have commit access, so please commit the diff.