- User Since
- Nov 19 2017, 8:08 PM (17 w, 2 d)
Thu, Mar 15
Wed, Mar 14
Tue, Mar 13
Mon, Mar 12
Yes, I can still reproduce it with bash, zsh and tcsh. FWIW, I have a system with an nvidia gfx, using the proprietary driver.
Sun, Mar 11
FWIW, a similar bug existed in gnome-terminal: https://bugzilla.gnome.org/show_bug.cgi?id=709930
Sat, Mar 10
Did it work?
Sadly not. Until T5242 is solved, Phabricator will not take over any authorship information from patches uploaded via the web uploader.
I am using the same email in git, phabricator.kde.org and when using arc diff (the latter AFAIK).
For arc diff, make sure your local Git config is set up correctly:git config --global user.name <Your Real Name> git config --global user.email <Your identity.kde.org email>
git config is set up correctly.
@rkflx I will try harder next time I submit a diff, and will hopefully note down the steps I used (or used and it still did the wrong thing).
Fri, Mar 9
Remove explicit return statement from void function
Remove explicit return statement from void function
Thu, Mar 8
Looking at the info in the bug report again and at, I've changed the patch to only send the up/down key press events if the terminal is using the alternate screen, which is what less and co. use.
Wed, Mar 7
Related bug: https://bugs.kde.org/show_bug.cgi?id=385380
Tue, Feb 27
Sun, Feb 25
Assign getVTFont() to a variable instead of calling it twice
Mon, Feb 19
If you're having trouble with arc, I recommend reading https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
Feb 19 2018
Feb 14 2018
Keep the current default of copying text as HTML.
Feb 12 2018
Remove redundant changes inserted by Designer in the .ui file.
Feb 11 2018
Less comments in the source files.
Feb 3 2018
This is fixed upstream in Qt 5.9.5, so I changed the patch to make the fix/workaround conditional for QT_VERSION < 5.9.5.
Jan 23 2018
Addressed the issues in the inline comments.
Jan 22 2018
- Don't check if paths isEmpty, as that's redundant
- Use more generic names in the comments, e.g. "user's home dir location" and "system-wide location" instead of ~/.local/share/konsole/ and /usr/share/konsole resppectively.
I've addressed all the issues you pointed out (and one more comment issue in ColorSchemeManager.cpp, I used delete instead of overwrite as it indeed explains what's going on in a more accurate way).
Jan 21 2018
Any news about this patch?
Dec 21 2017
Dec 19 2017
Please check the permissions of "/usr/share/konsole/Profile 3a1a.profile", I am assuming anything under /usr/share/konsole is owned by root. If the file is owned by the user then the check in the patch will fail.
Dec 16 2017
- Display a warning message if the user tries to save settings to a profile with a read-only config file.
- Change accept() so that the user can still click OK if he made no changes to a read-only profile.
Dec 15 2017
Dec 14 2017
Dec 13 2017
Dec 12 2017
Add one more check, if the profile config file is not writable (e.g. it's under /usr/share/konsole) don't allow saving, and display a message asking the user to change the profile name if he/she wants to save the settings.
Assign the same shortcut of the old profile to the newly renamed profile.
Dec 11 2017
When I move that profile out of the way, the current code works - can you still try to handle this issue and perhaps the .profile as well?
Check if _tempProfile->name().isEmpty before displaying the "already exists" error message and blocking saving the profile after it's been renamed.
That's it, you have a profile without a name, a file named just ".profile", most likely in ~/.local/share/konsole.
I've added a couple of qInfo() calls to the patch I attach here, maybe it'll throw more light on the issue... :/
Dec 10 2017
IIRC, on the account where I had that issue I deleted konsolerc (it's a temp testing account, so I delete config files from there all the time, unfortunately). Could you attach your konsolerc? I am trying to replicate the issue and failing miserably :)
Dec 9 2017
There's an issue that I've just found out, when saving the fallback profile, named Default, every time I change a setting it creates a new profile 1, profile 2, profile 3. So please hold on the review until I see if I can get this issue fixed.
Nov 28 2017
I have xorg-x11-drv-libinput-0.26.0, but I think the issue probably appeared with much older versions; as ngraham said, you need to make sure your X11 is actually using the libinput X11 driver.
Nov 27 2017
Nov 26 2017
Nov 25 2017
I don't understand how phabricator works with inline comments. So just in case my reply to the tooltip part didn't get submitted:
- To reproduced the issue of the widgets on the statusbar, we just need to remove the stretch factor from the addWidget() call, or set it to zero (default). Here's a screencast showing the issue:
Re-add #include <QLabel>, this is safer since QLabel is used elsewhere in the code, and KSqueezedTextLabel could change in the future for whatever reasons.
Nov 24 2017
Nov 22 2017
Nov 21 2017
Text elided on the right:
Text elided in the middle:
Use _tempProfile->isPropertySet() to check if the environment property changed. This is more sane (than just checking if it's empty, because the environment could be empty if the user removed all lines from the edit env dialogue).