- User Since
- Nov 19 2017, 8:08 PM (43 w, 5 d)
Jun 14 2018
For the sake of the next person getting here through the frustrated-online-search tunnel (like I just did a few hours ago, after the untracked files conundrum hit me about 50 times), here's a simple bash function that I came up with to use --allow-untracked with arc diff (there are probably more elegant ways to do this, but this WFM, so):
Consequently this patch will fix https://bugs.kde.org/show_bug.cgi?id=336129, (it should be mentioned in the commit message).
Jun 13 2018
Jun 12 2018
I haven't tested this, but does it make sense to just make the searchBar part of the TerminalDisplay Class and do away the TerminalWidget concept? theoretically, in my mind anyway, it would make this patch a lot smaller as calls to TerminalDisplay objects wouldn't need to be changed then. (Just an untested thought, I'll hopefully try and test this tomorrow).
Jun 8 2018
Jun 7 2018
One corner case comes to mind (whether it has to be fixed here or in a separate review later on), if the matched text is under the search bar, the user won't be able to see it, this can be further split into two cases (and two different solutions?):
a) if there's room to scroll up/down to show the text
b) if there's no room to scroll.
Jun 6 2018
Fix Q_ASSERT condition.
Fix session()->isPrimaryScreen() condition.
Jun 5 2018
Actually update the commit message
Use Q_ASSERT instead of checking for nullptr
Jun 3 2018
A couple of notes:
- Disabling "use current window size on next startup", the size setting in the profile seems to be ignored, the window that shows up is way too small
- After starting a new window, initially the terminal display prompt doesn't have focus (empty block cursor), the same thing happens when opening a new tab
Jun 2 2018
Jun 1 2018
May 31 2018
Tweak commit message
Change the code to check that session* is valid before accessing it
May 30 2018
Used --verbatim before adding a Test Plan:
May 28 2018
May 27 2018
Corrections in the commit message
May 26 2018
Clarify steps in the Test Plan
Tweak the commit message some more
Tweak the commit message (i.e. correct grammatical mistakes)
May 23 2018
May 22 2018
Add missing semicolon
Use the same placeholderText from the Edit Profile dialog General tab, more consistent wording across the application and saves the translators a bit of time
Add proper include
Disallow saving a scheme with an empty description
- You can remove the description which shouldn't be allowed - just like profile name can't be empty - I would not use a special kmessagewidget - just use something like setPlaceholderText(i18n("A name must be entered!")); and do the normal popup about missing description when Apply/OK
May 19 2018
May 16 2018
Add BUG and FIXED-IN lines
May 15 2018
May 10 2018
Fix phabricator markup screw-up
May 8 2018
May 7 2018
May 4 2018
Use remove() instead of replace()
Use a numeric string for the version env var (by removing the dots from the version string).
May 3 2018
May 2 2018
Apr 30 2018
Disregard this review request; Implementing DECRQSS is taking me too long (for so little gain), due to it having a an \e character at the end.
Apr 27 2018
Tweak Test Plan section formatting
Apr 19 2018
Apr 18 2018
Support 'ESC[ q' too
I am not sure what you mean, but if you mean the code in the Vt102Emulation, it took me a long time to understand the 'lec' and co. parts, and a lot of trial and error; the comment at the top of that section says "Ok, here comes the nasty part of the decoder.", which is true, it's quite nasty.
Add note about 'reset' to the test section
Update diff again because some bits of the commit message were wrongly commented out
Add test plan section
Apr 16 2018
Apr 14 2018
Apr 13 2018
Update commit message.
Fix merge issues.
Apr 12 2018
Rename README.KeyTab to README-KeyTab to prevent Konsole from trying to load it as a keyboard translator file.
Apr 8 2018
Change <keycap>Ctrl</keycap> to &Ctrl;
Apr 7 2018
I finally found doc/user/README.keyboard which mentioned some more stuff about the key bindings.
Added "credits" about the resources I used while writing this doc.
Add a section about NewLine mode
Replace "Return" with Carriage Return in the output field section
Change version to 18.08
Update the diff to address some of the issues pointed out in the review
I totally missed the Newline mode, I'll update the diff (hopefully soon).
I couldn't find a guide on how to get my name and email added to the docbook entities in KDE, I would appreciate any pointers about that.
Apr 6 2018
Apr 5 2018
FTR, this fixes the original issue in the BR but not the other issues mentioned in the comments.
Mar 30 2018
Mar 24 2018
So 'arc diff' doesn't update the summary based on the new commit message done with 'git commit --amend'....