Differential D24062

Update public dependencies in installed CMake Config file
ClosedPublic
Actions

Authored by kossebau on Sep 18 2019, 7:54 PM.

Details

Reviewers
vkrause
Commits
R172:8e8788e0f0d2: Update public dependencies in installed CMake Config file

Diff Detail

Branch
fixcmakeconfigdeps
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16756
Build 16774: arc lint + arc unit
kossebau requested review of this revision.Sep 18 2019, 7:54 PM
kossebau created this revision.
kossebau added a comment.Sep 18 2019, 7:55 PM

If found no other usage/documenation of BUILD_SHARED_LIBS, so I concluded this is some left-over from older (more promising) times?

vkrause added a comment.Sep 18 2019, 8:02 PM

Nope, it's a CMake setting, default is OFF, ECM sets it to ON. So this is actually still relevant and in use.

kossebau added a comment.Sep 18 2019, 8:35 PM
In D24062#534157, @vkrause wrote:

Nope, it's a CMake setting, default is OFF, ECM sets it to ON. So this is actually still relevant and in use.

Eek, without CMAKE prefix? *mumble*quality*mumble*... And I missed that FindLibIcal.cmake is actually installed.
Okay, so it's just the missing Qt5Core check, updating.

kossebau updated this revision to Diff 66414.Sep 18 2019, 8:36 PM

+update to only add Qt5Core check

vkrause accepted this revision.Sep 19 2019, 6:44 AM
This revision is now accepted and ready to land.Sep 19 2019, 6:44 AM
kossebau closed this revision.Sep 19 2019, 9:59 AM

Revision Contents
Changeset List

PathPackages
MKF5CalendarCoreConfig.cmake.in (3 lines)

Diff 66414

View Options

KF5CalendarCoreConfig.cmake.in

Loading...