Differential D24048

Inline styles from k.o/products moved to aether-sass
ClosedPublic
Actions

Authored by vladimirmikulic on Sep 18 2019, 11:51 AM.

Details

Reviewers
ognarb
Commits
R883:1552192: Inline styles from k.o/products moved to aether-sass

Diff Detail

Repository
R883 Subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vladimirmikulic requested review of this revision.Sep 18 2019, 11:51 AM
vladimirmikulic created this revision.
ognarb requested changes to this revision.Sep 18 2019, 11:59 AM

I also added a comment in the merge request in gitlab

products/index.php
7 ↗(On Diff #66372)

Uncoment and link to 'https://cdn.kde.org/aether-devel/products.css'

This revision now requires changes to proceed.Sep 18 2019, 11:59 AM
vladimirmikulic marked an inline comment as done.Sep 18 2019, 12:25 PM

styleEntry added 👍

ognarb added a comment.Sep 18 2019, 12:28 PM

Thanks can you update this diff with arc diff --conduit-uri=https://phabricator.kde.org/?

ognarb added inline comments.Sep 18 2019, 3:57 PM
products/index.php
7 ↗(On Diff #66372)

'cssFile' => 'https://cdn.kde.org/aether-devel/products.css',

vladimirmikulic updated this revision to Diff 66408.Sep 18 2019, 7:43 PM
vladimirmikulic marked an inline comment as done.

Updating D24048: Inline styles from k.o/products moved to aether-sass

Add cdn for products.css file

vladimirmikulic updated this revision to Diff 66416.Sep 18 2019, 8:47 PM

Updating D24048: Inline styles from k.o/products/kirigami moved to aether-sass

ognarb accepted this revision.Sep 20 2019, 10:11 AM
This revision is now accepted and ready to land.Sep 20 2019, 10:11 AM
Closed by commit R883:1552192: Inline styles from k.o/products moved to aether-sass (authored by carlschwan, committed by ). · Explain WhySep 20 2019, 10:12 AM
This revision was automatically updated to reflect the committed changes.
Diffusion mentioned this in R883:1552192: Inline styles from k.o/products moved to aether-sass.

Revision Contents
Changeset List

Diff 66530

View Options

trunk/www/sites/www/products/index.php

Loading...
View Options

trunk/www/sites/www/products/kirigami/index.php

Loading...