port to QSslSocket
Details
Details
- Reviewers
vkrause dvratil dfaure - Maniphest Tasks
- T11578: Port libksieve away from KTcpSocket
- Commits
- R91:82fa716432f0: Port libksieve from ktcpsocket to QSslSocket
run
Diff Detail
Diff Detail
- Repository
- R91 PIM: Sieve Handling Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Confusing commit message. This isn't about port ktcpsocket, but about porting *ksieve* *FROM* ktcpsocket :)
| src/kmanagesieve/sessionthread_p.h | ||
|---|---|---|
| 55 | Hmm, didn't I use this somewhere? Are you sure this compiles? | |
Comment Actions
laurent@linux-zym0:/compile/kde5/framework/kde/pim/libksieve> git grep AuthenticationError
src/kmanagesieve/sessionthread_p.h:55: enum { AuthenticationError = 1500 }; // "extend" KTcpSocket::Error
in master code.
it was never used. I was a dead code :)
Comment Actions
Oh oops, indeed. I meant to use it in SessionThread::handleSaslAuthError but in the end it doesn't really matter since we only test for RemoteHostClosedError and SocketTimeoutError. At least currently :)