woltherav (Wolthera van Hövell)
Krita Dev/Manual Writer.

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2015, 8:04 AM (179 w, 6 d)
Availability
Available

Writes tutorials, does minor bugfixes.

Recent Activity

Yesterday

woltherav awarded D15755: Global Kinetic Scrolling a Love token.
Tue, Sep 25, 11:34 PM · Krita
woltherav closed D15734: Order books in their series number if available..

ack forgot to close this one O_O

Tue, Sep 25, 8:48 PM · Peruse
woltherav committed R157:6c68665614b1: Ensure to skip the element when you do not read it's contents. (authored by woltherav).
Ensure to skip the element when you do not read it's contents.
Tue, Sep 25, 3:28 PM
woltherav committed R157:9e643dd23301: BUG:398260 avoid removed entries in the cache (authored by woltherav).
BUG:398260 avoid removed entries in the cache
Tue, Sep 25, 2:16 PM
woltherav closed D15748: Remove entries from cache if their filename does not exist..
Tue, Sep 25, 2:16 PM · Peruse
woltherav updated the diff for D15748: Remove entries from cache if their filename does not exist..

This changes to QFileInfo::exists(filename), because the docs say that is a little faster.

Tue, Sep 25, 2:07 PM · Peruse
woltherav added a comment to D15748: Remove entries from cache if their filename does not exist..

hm... will have to chase down an sd card reader first :D

Tue, Sep 25, 1:53 PM · Peruse
woltherav added a comment to D15748: Remove entries from cache if their filename does not exist..

Well, the thing is, I have a large collection(sqlitebrowser counts about 586 entries right now), yes, but I also have a fairly beefy computer. Starting peruse with clear-db takes way longer than this(which is near instantaneous), but because I have a beefy computer I suspect it might be the debug messages that is the major cause of the slowdown with clear-db. Either someone with a slow harddrive should check this, or I'll drop the patch and wait for one that is theoretically speedier.

Tue, Sep 25, 1:48 PM · Peruse
woltherav committed R157:9b65d987776d: Remove debug messages. (authored by woltherav).
Remove debug messages.
Tue, Sep 25, 1:38 PM
woltherav requested review of D15748: Remove entries from cache if their filename does not exist..
Tue, Sep 25, 1:37 PM · Peruse
woltherav committed R157:2f03af527278: BUG:398327 Make delete work. (authored by woltherav).
BUG:398327 Make delete work.
Tue, Sep 25, 12:57 PM
woltherav committed R157:293fc2ec3c7f: BUG 398254 Remove call to non-exitent function. (authored by woltherav).
BUG 398254 Remove call to non-exitent function.
Tue, Sep 25, 12:17 PM
woltherav committed R157:234f1122bcda: BUG: 398417 Add little buttons on hover for the page mouse areas. (authored by woltherav).
BUG: 398417 Add little buttons on hover for the page mouse areas.
Tue, Sep 25, 12:07 PM
woltherav committed R157:1aeb33f9404d: BUG:398256 Allow the mouse areas to switch functionality when reading direction… (authored by woltherav).
BUG:398256 Allow the mouse areas to switch functionality when reading direction…
Tue, Sep 25, 12:07 PM
woltherav committed R157:626f9e8986b0: Allow books that have a sequence number to be order by that sequence number. (authored by woltherav).
Allow books that have a sequence number to be order by that sequence number.
Tue, Sep 25, 10:15 AM
woltherav committed R157:277abe110e9e: Document all the enum entries properly. (authored by woltherav).
Document all the enum entries properly.
Tue, Sep 25, 10:15 AM
woltherav committed R157:65933da20543: Ensure that the rating/tags/comment get updated when the file changes. (authored by woltherav).
Ensure that the rating/tags/comment get updated when the file changes.
Tue, Sep 25, 10:15 AM
woltherav added inline comments to D15734: Order books in their series number if available..
Tue, Sep 25, 10:02 AM · Peruse

Mon, Sep 24

woltherav requested review of D15734: Order books in their series number if available..
Mon, Sep 24, 6:24 PM · Peruse
woltherav committed R157:ea6c18259238: Check for pre-exisiting categories in a case-insentive manner. (authored by woltherav).
Check for pre-exisiting categories in a case-insentive manner.
Mon, Sep 24, 4:27 PM
woltherav committed R157:eaf60feb0de2: Make 'sort by publisher' work. (authored by woltherav).
Make 'sort by publisher' work.
Mon, Sep 24, 3:59 PM
woltherav added a comment to D15640: Set color scheme hint for compositor.

Merge this to the master branch. If it is a small fix (which it does seem to be :p ) you should try to cherry-pick it to krita/4.1, but if that seems scary, we'll cherry-pick it for you :)

Mon, Sep 24, 12:27 PM · Krita
woltherav added a task to R157:3794ea968ec6: Support multiple authors/ multiple series/description and ratings/tags/comments.: T1348: Rating.
Mon, Sep 24, 12:10 PM
woltherav added a commit to T1348: Rating: R157:3794ea968ec6: Support multiple authors/ multiple series/description and ratings/tags/comments..
Mon, Sep 24, 12:10 PM · Peruse
woltherav added a commit to T1349: Tags: R157:3794ea968ec6: Support multiple authors/ multiple series/description and ratings/tags/comments..
Mon, Sep 24, 12:10 PM · Peruse
woltherav added a task to R157:3794ea968ec6: Support multiple authors/ multiple series/description and ratings/tags/comments.: T1349: Tags.
Mon, Sep 24, 12:10 PM
woltherav committed R157:371bbafe26d3: Ensure tags and comments do not get erased by comicinfo.xml parsing. (authored by woltherav).
Ensure tags and comments do not get erased by comicinfo.xml parsing.
Mon, Sep 24, 12:09 PM
woltherav committed R157:547bebe1e06c: Avoid duplicate entries. (authored by woltherav).
Avoid duplicate entries.
Mon, Sep 24, 12:09 PM
woltherav committed R157:3794ea968ec6: Support multiple authors/ multiple series/description and ratings/tags/comments. (authored by woltherav).
Support multiple authors/ multiple series/description and ratings/tags/comments.
Mon, Sep 24, 12:09 PM
woltherav closed D15713: Extend the categories model with some extra items..
Mon, Sep 24, 12:09 PM · Peruse
woltherav committed R157:86406d3d1663: Actually check the proper model for acbf data. (authored by woltherav).
Actually check the proper model for acbf data.
Mon, Sep 24, 12:09 PM
woltherav committed R157:a73e0096abb9: Get rid of warning by checking whether acbf data exists before defining page. (authored by woltherav).
Get rid of warning by checking whether acbf data exists before defining page.
Mon, Sep 24, 12:09 PM
woltherav added a comment to D15713: Extend the categories model with some extra items..

Great stuff, push away! :)

No showstopper or anything, just for a bit of background: The reason behind caching everything is that file system access is super expensive, so causing file system access for cached entries seems perhaps less than good. To test whether this is sufficiently fast for you, turn off your file indexer (balooctl stop should do that nicely). If it is, indeed, fast enough, then go for it, otherwise caching will want to happen for those parts as well... We need some way to update the cache when the filesystem has changed, but i'm as yet unsure of how to properly deal with that... However, that doesn't have to stop the patch going in, just something to check :)

Mon, Sep 24, 11:49 AM · Peruse

Sun, Sep 23

woltherav requested review of D15713: Extend the categories model with some extra items..
Sun, Sep 23, 4:43 PM · Peruse
woltherav committed R157:f13b88ddbbe5: Ensure page areas do not go beyond the page boundaries. (authored by woltherav).
Ensure page areas do not go beyond the page boundaries.
Sun, Sep 23, 11:26 AM
woltherav committed R157:cb7e41e3e9b1: Preserve file suffix when copying files into archive. (authored by woltherav).
Preserve file suffix when copying files into archive.
Sun, Sep 23, 11:26 AM
woltherav committed R157:dd4363b8dd55: Ensure comicinfo/comet is only read when no acbf file was found. (authored by woltherav).
Ensure comicinfo/comet is only read when no acbf file was found.
Sun, Sep 23, 11:26 AM

Sat, Sep 22

woltherav abandoned D15692: Add POT export and PO import..
Sat, Sep 22, 10:01 PM · Peruse
woltherav added a comment to D15692: Add POT export and PO import..
In D15692#330282, @pino wrote:

Not sure I understand, what is the exact workflow that involves writing a .pot file, and reading .po files? Is it because peruse so far is not translatable?
If so, then it'd be much better to extract the messages, and make sure to use ki18n to translate the strings at runtime, just like all the other applications.

Sat, Sep 22, 7:56 PM · Peruse
woltherav updated the diff for D15692: Add POT export and PO import..

Updating with...

Sat, Sep 22, 6:37 PM · Peruse
woltherav requested review of D15692: Add POT export and PO import..
Sat, Sep 22, 4:17 PM · Peruse

Fri, Sep 21

woltherav committed R157:db4ac02beb7a: Remove warning by checking if the author object exists before getting data from… (authored by woltherav).
Remove warning by checking if the author object exists before getting data from…
Fri, Sep 21, 5:24 PM
woltherav committed R157:7e5a7168257f: Fix warning due bad variable naming. (authored by woltherav).
Fix warning due bad variable naming.
Fri, Sep 21, 4:50 PM
woltherav added a commit to T1350: Viewport-based comic book view support: R157:43a9ef2b962b: Frame based zoom in the image browser..
Fri, Sep 21, 2:50 PM · Peruse
woltherav added a task to R157:43a9ef2b962b: Frame based zoom in the image browser.: T1350: Viewport-based comic book view support.
Fri, Sep 21, 2:50 PM
woltherav added a task to D15661: Frame zoom in the image browser.: T1350: Viewport-based comic book view support.
Fri, Sep 21, 2:49 PM · Peruse
woltherav added a revision to T1350: Viewport-based comic book view support: D15661: Frame zoom in the image browser..
Fri, Sep 21, 2:49 PM · Peruse
woltherav committed R157:43a9ef2b962b: Frame based zoom in the image browser. (authored by woltherav).
Frame based zoom in the image browser.
Fri, Sep 21, 2:48 PM
woltherav closed D15661: Frame zoom in the image browser..
Fri, Sep 21, 2:48 PM · Peruse
woltherav requested review of D15661: Frame zoom in the image browser..
Fri, Sep 21, 1:15 PM · Peruse

Thu, Sep 20

woltherav triaged T9713: Translating entries support. as Wishlist priority.
Thu, Sep 20, 12:14 PM · Peruse
woltherav committed R157:560bedd2342f: Add ComicInfo.xml and CoMet parsing. (authored by woltherav).
Add ComicInfo.xml and CoMet parsing.
Thu, Sep 20, 10:30 AM
woltherav closed D15601: Add parsing of comicinfo.xml and CoMet..
Thu, Sep 20, 10:30 AM · Peruse

Wed, Sep 19

woltherav requested review of D15601: Add parsing of comicinfo.xml and CoMet..
Wed, Sep 19, 3:02 PM · Peruse

Tue, Sep 18

woltherav moved T9657: Make ACBF library data accesible from QML from Future Features to Ready for Testing on the Peruse board.
Tue, Sep 18, 11:15 AM · Peruse
woltherav committed R157:e97bbb317e57: Fix wrong placeholder text for content rating. (authored by woltherav).
Fix wrong placeholder text for content rating.
Tue, Sep 18, 11:11 AM
woltherav closed D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..

Okay, added the commit where I did the last change (labels for volumes and numbers in sequences), and the commit where I added the last thing we discussed :)

Tue, Sep 18, 11:01 AM · Peruse
woltherav added 2 commit(s) for D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them.: R157:14a3d22bc686: Make swaps work for page areas by using stringlists instead of ints., R157:bb6d0f27aebc: Add labels to sequence number and volume..
Tue, Sep 18, 11:01 AM · Peruse
woltherav added an edge to R157:bb6d0f27aebc: Add labels to sequence number and volume.: D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..
Tue, Sep 18, 11:01 AM
woltherav added an edge to R157:14a3d22bc686: Make swaps work for page areas by using stringlists instead of ints.: D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..
Tue, Sep 18, 11:01 AM
woltherav added a comment to D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..

I actually did manage to get the swap working just now, I replaced the counts with stringlists with the points of the frames(which should be useful for debug as well :) )

Tue, Sep 18, 10:51 AM · Peruse
woltherav committed R157:bb6d0f27aebc: Add labels to sequence number and volume. (authored by woltherav).
Add labels to sequence number and volume.
Tue, Sep 18, 10:49 AM
woltherav committed R157:4fa58000ec93: Give sequence spinboxes a higher value and make them editable. (authored by woltherav).
Give sequence spinboxes a higher value and make them editable.
Tue, Sep 18, 10:49 AM
woltherav committed R157:14a3d22bc686: Make swaps work for page areas by using stringlists instead of ints. (authored by woltherav).
Make swaps work for page areas by using stringlists instead of ints.
Tue, Sep 18, 10:38 AM

Mon, Sep 17

woltherav updated the diff for D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..

I forgot to save a file.

Mon, Sep 17, 4:19 PM · Peruse
woltherav committed R157:7f189ccd5ab1: Don't forget to save when adjusting a file >_> (authored by woltherav).
Don't forget to save when adjusting a file >_>
Mon, Sep 17, 4:18 PM
woltherav added a comment to D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..

Okay, updated with the changed you suggested. (And all my own changes I thought were really necessary.)

Mon, Sep 17, 2:17 PM · Peruse
woltherav updated the diff for D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..
Mon, Sep 17, 2:15 PM · Peruse
woltherav committed R157:5529ef0decb3: Remove too many brackets in contentrating.h (authored by woltherav).
Remove too many brackets in contentrating.h
Mon, Sep 17, 2:14 PM
woltherav committed R157:0622dd88b42f: Make homepagesChanged and emailsChanged multiples. (authored by woltherav).
Make homepagesChanged and emailsChanged multiples.
Mon, Sep 17, 2:14 PM
woltherav committed R157:14bd28807d6c: Make version spinbox floating point. (authored by woltherav).
Make version spinbox floating point.
Mon, Sep 17, 2:11 PM
woltherav committed R157:e2df67356ae9: Make change area creation behaviour to 'click+drag'. (authored by woltherav).
Make change area creation behaviour to 'click+drag'.
Mon, Sep 17, 2:11 PM
woltherav committed R157:a57995bec2ec: Add default language entry to make sure the acbf files are proper. (authored by woltherav).
Add default language entry to make sure the acbf files are proper.
Mon, Sep 17, 2:11 PM
woltherav committed R157:d708ff1d1513: Add reading direction. (authored by woltherav).
Add reading direction.
Mon, Sep 17, 2:11 PM
woltherav committed R157:49f9079b625e: Make year selector a textfield with input mask. (authored by woltherav).
Make year selector a textfield with input mask.
Mon, Sep 17, 2:11 PM
woltherav committed R157:2deb4c7a9cda: Allow editing body bgcolor and propegate the values as defaults. (authored by woltherav).
Allow editing body bgcolor and propegate the values as defaults.
Mon, Sep 17, 2:11 PM
woltherav committed R157:21d792f976ca: Don't edit the book title accidentally. (authored by woltherav).
Don't edit the book title accidentally.
Mon, Sep 17, 2:11 PM
woltherav committed R157:2a0484dac22c: Display numbers of the frames/textareas/jumps. (authored by woltherav).
Display numbers of the frames/textareas/jumps.
Mon, Sep 17, 2:11 PM
woltherav committed R157:cd589649fd36: Add some key board shortcuts. (authored by woltherav).
Add some key board shortcuts.
Mon, Sep 17, 2:11 PM
woltherav committed R157:990a26ba558a: Remove a warning by initialising variables properly. (authored by woltherav).
Remove a warning by initialising variables properly.
Mon, Sep 17, 2:11 PM
woltherav committed R157:b66d884cc78c: Ensure there's always a default text layer. (authored by woltherav).
Ensure there's always a default text layer.
Mon, Sep 17, 2:11 PM
woltherav updated the task description for T9657: Make ACBF library data accesible from QML.
Mon, Sep 17, 1:15 PM · Peruse
woltherav updated the summary of D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..
Mon, Sep 17, 11:45 AM · Peruse
woltherav added a comment to D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..

Frame/Textarea/Jump swap seems broken because I build up those repeaters from the count of those values, but if the count stays the same, the repeater has no need to change, so they effectively don't update.

Mon, Sep 17, 11:44 AM · Peruse

Sat, Sep 15

woltherav requested review of D15542: Make ACBF library data accesible from QML and update Peruse Creator to edit them..
Sat, Sep 15, 8:44 PM · Peruse
woltherav committed R157:504daaa8b180: Add adding/removing jumps, text-areas and frames. (authored by woltherav).
Add adding/removing jumps, text-areas and frames.
Sat, Sep 15, 8:11 PM
woltherav committed R157:899df3e10fed: Add a basic page data editor and preview the sub elements on the page. (authored by woltherav).
Add a basic page data editor and preview the sub elements on the page.
Sat, Sep 15, 6:16 PM
woltherav committed R157:01df763ed3ad: Add properties to Body, Page, Textlayer, Textarea, Frame and Jump (authored by woltherav).
Add properties to Body, Page, Textlayer, Textarea, Frame and Jump
Sat, Sep 15, 6:16 PM
woltherav updated the task description for T9657: Make ACBF library data accesible from QML.
Sat, Sep 15, 12:10 PM · Peruse
woltherav added a comment to T1350: Viewport-based comic book view support.

Yes, I've got it sort of working. But I am wondering whether the method used for 'author' isn't easier(count of objects, count notified, add/remove entries, getentry). It is what I've used for the other metadata.

Sat, Sep 15, 9:38 AM · Peruse
woltherav awarded M135: Artistic Color Selector: gamut mask rotation a Like token.
Sat, Sep 15, 9:04 AM · Krita
woltherav added a comment to M135: Artistic Color Selector: gamut mask rotation.

Added some subscribers to this.

Sat, Sep 15, 9:03 AM · Krita
woltherav updated subscribers of M135: Artistic Color Selector: gamut mask rotation.
Sat, Sep 15, 9:03 AM · Krita
woltherav closed T3498: Add-remove empty frames (spacing) between existing animation frames as Resolved.

I think this is resolved already with the 4.1 animation improvements :)

Sat, Sep 15, 9:02 AM · Krita: Next Features (Needs coding ), Krita: Dmitry's TODO (Small Junior Jobs)

Fri, Sep 14

woltherav added a comment to T9657: Make ACBF library data accesible from QML.

Okay, I've managed to get all the entries in the metadata section editable from peruse creator, meaning that part is done. This is pushed in a branch.

Fri, Sep 14, 4:27 PM · Peruse
woltherav updated the task description for T9657: Make ACBF library data accesible from QML.
Fri, Sep 14, 4:25 PM · Peruse
woltherav committed R157:242ae595da7e: Add multiple email and homepages to author editor and add document author… (authored by woltherav).
Add multiple email and homepages to author editor and add document author…
Fri, Sep 14, 4:25 PM
woltherav committed R157:f33a7ece161e: Add a few more labels. (authored by woltherav).
Add a few more labels.
Fri, Sep 14, 4:25 PM
woltherav committed R157:b905e97893f3: Add Document Info toggles to the editable metadata. (authored by woltherav).
Add Document Info toggles to the editable metadata.
Fri, Sep 14, 4:25 PM
woltherav committed R157:e7c39b8de9b2: Add publishing info edit entries. (authored by woltherav).
Add publishing info edit entries.
Fri, Sep 14, 4:24 PM