I think the problem here is that while themes have dedicated Positive, Negative, and Neutral colors, for the Informational color we just re-use the active or highlight color from the theme, which may not always be appropriate for use as a background for informational KMessageWidgets. With a lot of themes, this color winds up looking like the negative color or just being really weird.

This patch works as advertised, and does not imposes any visual regressions when using the Breeze color scheme.

Submitted a trivial patch to fix it: D14148

Found it. Here's the patch: D14138: Use a trash icon for anything that will remove a widget or a panel

Hmm actually that's for the toolbar above the panel, not the little menus that appear when you hover the mouse over a panel widget.

An excellent tweak. I think this looks better--more subtle and more professional, but still retains the original goal. Good for you for listening to user feedback, too. :)

In D14116#292301, @broulik wrote:

Can you make the same change also for the panel? There it's even more confusing as the "X" looks like it would close the popup but it's actually for deleting the widget.
Code is in plasma-desktop/desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

+1, I definitely prefer the version with the shadow box moved up a bit with a little bit of lightening. I think that looks fantastic!

Right, it's not a problem:

A little lightening is OK, but IMHO the problem here is not so much the darkness, but how much darker the bottom edge is than the sides. It's just a bit too much. My recommendation would be to move the shadow boxes up a few pixels.

Thanks! @Fuchs and/or @broulik?

I'm seeing this only show up for new user accounts and/or a clean katerc file. Looks like we forget to bump the version on kateui.rc.

Thanks for the patch!

Ah yes, I've accidentally removed my panel widgets that way too! I'll submit a similar patch for that shortly.

Retroactive +1 on the positioning and wording, but I would have stayed with an Informational (blue) KMessageWidget instead of making it Positive (and hence, green). Eh, not a huge deal. Shoulda piped up sooner!

Thanks!

In effect, it's the same. But the VERSION_GREATER_EQUAL macro is only present in newer versions of CMake, which makes it not work in, for example, KDE Neon, which ships with an older version of CMake.

Ping! @elvisangelaccio or anyone else in Dolphin? Tagging is fast approaching, and I think it would be nice to get this into 18.08.

Also use the new icon in the context menu

The progress here is excellent! Here are my comments with the latest revision of the patch:

Works like a charm, and the code change makes sense. I didn't even know about this feature!

I mean they could be buttons with:

• no visible borders (the borders appear on hover)
• the icon on top, rather than on the side

How about putting the icons on top and making them toolbuttons without a visible button-looking border? There's plenty of unused vertical space there, and square buttons might fit well in the available space.

Might there even be room for buttons with text?

Looks great and works great!

Yeah, it looks like there's room for some buttons up on top without needing a drop-down menu.

Good idea, @colomar. I did that in D10245#201638, resulting in a change supported by at least a little bit of user testing: D11768: Add Desktop and Downloads to the default list of Places.

In D14042#290555, @hein wrote:

Does it make sense to name the queries after XDG_USER_DIRS, so e.g. pictures instead of images?

https://www.freedesktop.org/wiki/Software/xdg-user-dirs/

Oops, the email notifications for these two patches were so similar that I assumed they were the more common case of duplicate emails rather than separate patches! This one looks just fine too.

In D14038#290801, @hindenburg wrote:

I had to add more info in the summary area to get the BUG: to be on a new line instead of summary line.

Please change Bug #386685: https://bugs.kde.org/show_bug.cgi?id=386685 to BUG: 386685. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords

Thanks for the patch! It will be nice to get the Dictionary runner working again.

Thanks for the patch! It will be nice to get the Dictionary runner working again.

Nah, let's wait. We'll have to see what the dependency plans are for Plasma; I'm not sure whether or not we'll be depending on Frameworks 5.49 for Plasma 5.14. Might wanna ask one of the Plasma folks.

Tested with a new and existing user. Entries in Kickoff, Dolphin, Gwenview, and the file dialogs all work perfectly, and the subtitles in Kickoff are pretty. Code looks sane.

Tested with a new and existing user. Entries in Kickoff, Dolphin, Gwenview, and the file dialogs all work perfectly, and the subtitles in Kickoff are pretty. Code looks sane.

Awesome, now don't forget to run arc amend on your local checkout before landing. :)

Please add BUG: 396119 since this fixes that bug.

I ran into an issue with the QtQuick tooltips, unfortunately: they don't wrap, and instead overflow the bounds of the window:

Revert unintentional changes

In D13593#282711, @mart wrote:

if as native speaker you think antialias isn't nearly common enough, go for it :)

Excellent progress. You managed to resolve nearly all the problems I encountered with the first version of this patch! Behavior-wise, here's all I found with this latest version:

In D10974#290127, @rkflx wrote:

• Scale to: Printable area | Paper size

Verified that this fixes the bug. Sadly this does make the subtitle somewhat ugly for the Search For entries in particular:

Very nice!

Add technical tooltips

Does this really resolve all of https://bugs.kde.org/show_bug.cgi?id=366451? I see several issues described in there...

"You can change it!" is not a helpful comment in a discussion about defaults. The whole point of good defaults is that they should work well for the majority of people and use cases without needing to be changed.

+1, makes sense to me. Wait for @hein or @broulik's approval too though.

In D14025#289826, @gladhorn wrote:

depends on https://phabricator.kde.org/D14024

OK, no problem. :)

If we're going to do any UI porting, how about to QML instead? That's the future.

My objection to using the term "Playlist" for this widget is that it conflicts with the same use of that term to mean "a saved list of songs you can access and play later" in most other contexts. Since the "Now Playing" string is also problematic because it conflicts with the use of that same term in the list on the left, how about instead "Playback Queue"? For the other strings, my recommendation would be:

• "Clear all"
• "Save as playlist file..."
• "Load playlist file..."

Nice, that resolves all my nitpicks!

I'm ok with PgUp / PgDn being used as secondary shortcuts as long as we have a chord for the primary shortcut.

Does this fix any of the bugs here? https://bugs.kde.org/buglist.cgi?component=webdav&list_id=1529637&product=kio&resolution=---

I don't think in practice it would be a problem to have the hotcorner separated from the Desktop Toolbox button. I wouldn't be in favor of moving the Desktop Toolbox patch to the left again because it's always supposed to have been be on the right with RTL keyboard layouts. Only a bug was preventing this, which has since been fixed upstream; when we revert our patch for the 5.13 timeframe, the Desktop Toolbox will remain on the right.