rkflx (Henrik Fehlauer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 6 2017, 7:59 PM (36 w, 5 d)
Availability
Available

Recent Activity

Today

rkflx added a comment to D8980: Fix rubber band selection drawing contents misaligned with scaling.

@davidedmundson Could you confirm/refute Anthony's concern?

Fri, Jan 19, 1:00 AM · Okular
rkflx added a comment to D9943: Add browse mode action to action collection again.

Great work, thanks Peter!

Fri, Jan 19, 12:59 AM
rkflx updated subscribers of D9886: Switch to browse mode when selecting directory in tree view.

Looked at the patch, I think it solves the bug in the best way possible. Perfect commit message, test plan and code.

Fri, Jan 19, 12:52 AM
rkflx added a comment to D9886: Switch to browse mode when selecting directory in tree view.

@rkflx I should be able now to commit. ;)

Fri, Jan 19, 12:49 AM
rkflx added a comment to D9731: Provide a dialog helper to handle properly its destruction.

@anthonyfieroni The "perfect forward" and the RAII semantics of DialogHelper are quite neat (a comment to make it easier to figure out the purpose could be added to the class, though, as Albert hints at). Still, I think Elvis also makes a good point, and I might prefer his solution actually.

Fri, Jan 19, 12:46 AM
rkflx updated subscribers of R230:a26dbf1cdc98: Add myself (muhlenpfordt) to relicensecheck.

@ngraham @michaelh What about you? You should add yourself to this file, too. :D

Fri, Jan 19, 12:45 AM
rkflx awarded R230:a26dbf1cdc98: Add myself (muhlenpfordt) to relicensecheck a Like token.
Fri, Jan 19, 12:44 AM
rkflx added a comment to R293:e733c7f72695: balooctl status: translatable message.

Won't comment on the patch, I just have some tips regarding future summary / commit messages in case you didn't know those already :). Have a look at https://chris.beams.io/posts/git-commit/, especially 3. and 5.

Fri, Jan 19, 12:41 AM
rkflx added a comment to D9937: synctex: Use Windows ANSI versions of the PathFind... methods.

Thanks for the Diff. I cannot try your patch on Windows, but if it works for you and fixes the problem I guess this is fine.

Fri, Jan 19, 12:30 AM · Okular
rkflx updated subscribers of D8763: Monitor profile should use relative colorimetric rendering intent by default.

@rempt Hi Boud, greetings from Gwenview land. I know you are busy, but it would be great if you could help us out with a question we have regarding an old commit of yours to Gwenview from 5 years ago: In d5635328f33c you introduce some colour correction and in particular INTENT_PERCEPTUAL, cmsFLAGS_BLACKPOINTCOMPENSATION.

Fri, Jan 19, 12:25 AM
rkflx added a comment to D9328: Add support for cancellable image rendering and text extraction.

First things first: The patch marks an impressive improvement in (perceived) drawing performance for slow-rendering PDFs, I'm glad your hard work payed off.

Fri, Jan 19, 12:23 AM · Okular

Mon, Jan 15

rkflx added a reviewer for D9731: Provide a dialog helper to handle properly its destruction: KDE Applications.

Read the linked blog, looked at the code and tested whether the affected dialogs in Gwenview still work. LGTM (apart from the location of dialoghelper.h), but I'd like to get a second opinion from someone longer in the game.

Mon, Jan 15, 11:57 PM

Wed, Jan 10

rkflx accepted D9632: Select only filename without extension in rename dialog box.

Accepting for now, but before committing, let's wait how D9731 plays out. Due to the i18n changes your patch is headed for master / 18.04 anyway.

Wed, Jan 10, 9:27 PM
rkflx added a comment to D9078: HiDPI fixes for thumbnails in gwenview.

Another thought I had: The thumbnail slider in Browse mode has a tooltip displaying the thumbnail size in pixels. Suppose the user moves the window from a low-res display (set to 1x scaling) to a HiDPI display (set to 2x scaling). Obviously, the size of the thumbnails (as measured with a tape measure) should stay the same, meaning the pixmap used to achieve this must become larger.

Wed, Jan 10, 9:24 PM

Tue, Jan 9

rkflx committed R260:d371a8e663ec: Rename setTargetUrl to setTargetDirUrl (authored by rkflx).
Rename setTargetUrl to setTargetDirUrl
Tue, Jan 9, 10:21 PM
rkflx retitled D9731: Provide a dialog helper to handle properly its destruction from [gwenview] Provide a dialog helper to handle properly its destruction to Provide a dialog helper to handle properly its destruction.
Tue, Jan 9, 10:12 PM
rkflx added a comment to D9731: Provide a dialog helper to handle properly its destruction.

Thanks for submitting this.

Tue, Jan 9, 10:12 PM
rkflx requested changes to D9632: Select only filename without extension in rename dialog box.
Tue, Jan 9, 10:09 PM

Mon, Jan 8

rkflx added a comment to D9078: HiDPI fixes for thumbnails in gwenview.

Finally got a chance to try your latest changes, here's how it looks for me:

Mon, Jan 8, 10:31 PM

Sun, Jan 7

rkflx added a comment to D9342: Make sure, a newly saved image is selected in ContextManager.
In D9342#181752, @rkflx wrote:

We could try to get rid of mDirListerFinished completely (it is a bit ugly, anyway). In D8196#160524 I have a long list of test cases, and there is a list of bugs in the summary as well. If you give me a couple of days, I can test those again and ask Valeriy what he thinks about this.

Sun, Jan 7, 11:54 PM
rkflx added 1 auditor(s) for R260:119ac4186e41: Respect custom filename for Copy/Move/Link To operations: muhlenpfordt.

@muhlenpfordt I promised to fix this for 17.12.1, but as this would need to go in by tomorrow and is pretty trivial, I already committed this. Still I'd appreciate it if you could have a short look, i.e. "audit" the commit – Thanks!

Sun, Jan 7, 11:52 PM
rkflx committed R260:4a3372497159: Merge remote-tracking branch 'origin/Applications/17.12' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/17.12'
Sun, Jan 7, 11:50 PM
rkflx committed R260:e8d799c9b522: Fix failing PlaceTreeModelTest autotest (authored by rkflx).
Fix failing PlaceTreeModelTest autotest
Sun, Jan 7, 11:50 PM
rkflx committed R260:119ac4186e41: Respect custom filename for Copy/Move/Link To operations (authored by rkflx).
Respect custom filename for Copy/Move/Link To operations
Sun, Jan 7, 11:50 PM
rkflx added a comment to F5620896: Make poppler scale text annotation icons to respect size in /Rect.
In F5620896#78, @rkflx wrote:

In Phabricator's side bar there is Edit File, you could try if this (possibly?) works for you.

Sun, Jan 7, 9:44 PM
rkflx added a comment to D9692: Improve dialog when PDF wants to open in presentation mode.

I think so. Thanks for all the tweaks, BTW.

Sun, Jan 7, 6:47 PM · Okular
rkflx added a comment to D9692: Improve dialog when PDF wants to open in presentation mode.

What is Normal Mode to the user, anyway? It's not bad, but does not click with me immediately, TBH.

Sun, Jan 7, 12:16 AM · Okular

Sat, Jan 6

rkflx accepted D9692: Improve dialog when PDF wants to open in presentation mode.

@aacid Are you okay with this change?

Sat, Jan 6, 10:56 PM · Okular
rkflx added a comment to D9692: Improve dialog when PDF wants to open in presentation mode.

That's even better. Just update the Diff, I'll check / approve and then we'll see what Albert says.

Sat, Jan 6, 10:50 PM · Okular
rkflx added a comment to D9692: Improve dialog when PDF wants to open in presentation mode.

Sounds great. Maybe "View Mode" in the title? ("Mode" is not really meaningful in itself.)

Sat, Jan 6, 10:42 PM · Okular
rkflx accepted D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.
Sat, Jan 6, 10:34 PM · Plasma
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.

Thanks for the review and your help ;)

Sat, Jan 6, 9:44 PM · Plasma
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.
In D9627#186696, @rkflx wrote:

I won't need to test again, as the screenshots clearly show it working fine ;)

Sat, Jan 6, 8:41 PM · Plasma
rkflx added a comment to D9692: Improve dialog when PDF wants to open in presentation mode.

How about this?

Sat, Jan 6, 6:27 PM · Okular
rkflx added a comment to D9692: Improve dialog when PDF wants to open in presentation mode.

(Helps saving inline comments before pressing "Submit").

Sat, Jan 6, 5:55 PM · Okular
rkflx added a comment to D9692: Improve dialog when PDF wants to open in presentation mode.

Yep. Take your time with rephrasing, it's 18.04 material anyway. Also, it should probably stay being a question (because it's not a warning or information either), hence the question mark icon.

Sat, Jan 6, 5:53 PM · Okular
rkflx added a comment to D9692: Improve dialog when PDF wants to open in presentation mode.

Now we have "Presentation Mode" (title), "Presentation Mode" (first sentence), "Presentation Mode" (second sentence), "Presentation Mode" (button). I find it a bit annoying to read ;) Can we do something about it, e.g. removing the second sentence? Any other idea?

Sat, Jan 6, 5:44 PM · Okular
rkflx added inline comments to D9632: Select only filename without extension in rename dialog box.
Sat, Jan 6, 8:03 AM
rkflx added a comment to D9632: Select only filename without extension in rename dialog box.

I saw other functions in this file are written as is but they are wrong too.

Sat, Jan 6, 8:02 AM
rkflx added a comment to D9632: Select only filename without extension in rename dialog box.

Seems fine functionality-wise and makes for a nice improvement in usability.

Sat, Jan 6, 7:58 AM
rkflx requested changes to D9692: Improve dialog when PDF wants to open in presentation mode.

You should open a 48h bugfixing service ;)

Sat, Jan 6, 7:49 AM · Okular
rkflx added a comment to D9632: Select only filename without extension in rename dialog box.

My phabricator mail is an old ugly gmx alias, which I want to get rid of - but found no way to change it here?

Sat, Jan 6, 7:15 AM
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.

Thanks for the update. I won't need to test again, as the screenshots clearly show it working fine ;)

Sat, Jan 6, 12:20 AM · Plasma

Fri, Jan 5

rkflx added a comment to F5620896: Make poppler scale text annotation icons to respect size in /Rect.

One can only change Name, Visible To, Subscribers in Edit File. But no file content. And I guess that's ok, I should not try to abuse the file app as a code review tool for external projects code.

Fri, Jan 5, 11:02 PM
rkflx added a comment to F5620896: Make poppler scale text annotation icons to respect size in /Rect.

In Phabricator's side bar there is Edit File, try if this works for you.

Fri, Jan 5, 7:52 PM
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.
In D9627#186631, @rkflx wrote:

Works for the menu, but the window shadow is not as before for me. Maybe insert Tiny with 16px + 16px?

Are you sure? the old shadow default was 16px, which is replicated in the Small option. Of course it doesn't look exactly the same as before since the old shadow was right-biased, so it looked bigger than 16px on the right side, and almost non-existent on the left side. But technically, we do still have a 16px shadow option.

Fri, Jan 5, 7:48 PM · Plasma
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.

FWIW, I rather prefer abstract words instead of numbers, since then we have more freedom to tweak the numbers under the hood in the future. The actual numbers aren't important enough to show to the user IMHO. And if we do expose the number, people will eventually ask for a spinbox to precisely input arbitrary values, and we'll be back to where we started from. :-)

Fri, Jan 5, 6:46 PM · Plasma
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.

How about "Medium"?

Fri, Jan 5, 5:45 PM · Plasma

Thu, Jan 4

rkflx added a comment to D9632: Select only filename without extension in rename dialog box.

you're much more familiar with this... ;)

Thu, Jan 4, 1:05 PM
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.
In D9627#185604, @rkflx wrote:

One more thing: Is the 100px max working for you? Mine is still capped at 64px

Thu, Jan 4, 12:21 PM · Plasma

Wed, Jan 3

rkflx added a comment to T7646: Make it SUPER obvious how to register for Phabricator for newer KDE fans.

Thanks for the video, you are making good progress towards changing things for the better. There are two root problems I can extract from it:

Wed, Jan 3, 9:31 PM · Goal settings 2017
rkflx added a comment to D9632: Select only filename without extension in rename dialog box.

Happy new year, everyone ;)

Wed, Jan 3, 6:24 PM
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.

Essentially this: D9549#184975 (but a "No" option could be added).

Wed, Jan 3, 6:21 PM · Plasma
rkflx added a comment to T7663: Setup an AskKDE Q&A Type Website.

Phabricator has an application called "Ponder" (not available on our instance yet) which essentially supports Q&A style workflows. This would nicely integrate with the existing notifications and project tags, and every forum user already has an Identity account anyway.

Wed, Jan 3, 6:09 PM · KDE Promo
rkflx accepted D9636: Fix displaying RW2 files with shared-mime-info 1.9.

Thanks for the patch.

Wed, Jan 3, 6:05 PM
rkflx added a comment to D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes.

Thanks Nate, your blog readership seems to like it too (congratulations on the blog, BTW ;) What about the inevitable "But can I change it back?". You claim we allow this, but if you actually try it, it does not work, i.e. the menu shadow is now almost completely gone for the former default shadow size of 16px. This is also the case for any user upgrading to 5.12 with a non-default size, e.g. 17px, where the shadow going away looks like an upgrade bug.

Wed, Jan 3, 5:57 PM · Plasma

Tue, Jan 2

rkflx added a comment to T5242: Display user information so that others can land/amend a patch.

In those links, I don't see any mention of changes to identity (which is different from Phab, right!?) as I am proposing, but I'll stop here. We'll need to wait for @bcooksley to comment, maybe he knows more about the current upstream status of the issue.

Tue, Jan 2, 10:56 PM · Phabricator
rkflx added a comment to T5242: Display user information so that others can land/amend a patch.

Of course I did read the entire ticket before posting. Care to elaborate what point I am missing? Note I am talking about identity (i.e. something we can fix now), while the proper fix would be in Phabricator (i.e. something which might be very far away).

Tue, Jan 2, 10:41 PM · Phabricator
rkflx added a comment to T5242: Display user information so that others can land/amend a patch.

I agree in light of our newly selected focus goals, i.e. T7116: Streamlined onboarding of new contributors, that this is kind of important to solve.

Tue, Jan 2, 10:20 PM · Phabricator
rkflx committed R223:7c837113eb35: Improve error message when parttest fails due to missing pdflatex (authored by rkflx).
Improve error message when parttest fails due to missing pdflatex
Tue, Jan 2, 8:33 PM
rkflx closed D9578: Improve error message when parttest fails due to missing pdflatex.
Tue, Jan 2, 8:33 PM · Okular
rkflx added a commit to T7532: Install pdflatex in the SuseQt5.9 builders: R223:7c837113eb35: Improve error message when parttest fails due to missing pdflatex.
Tue, Jan 2, 8:33 PM · build.kde.org
rkflx committed R223:804bb086a21c: Merge remote-tracking branch 'origin/Applications/17.12' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/17.12'
Tue, Jan 2, 8:32 PM
rkflx committed R223:454a53ff72d0: Fix testSaveAsUndoStackAnnotations autotest (authored by rkflx).
Fix testSaveAsUndoStackAnnotations autotest
Tue, Jan 2, 8:29 PM
rkflx closed D9579: Fix testSaveAsUndoStackAnnotations autotest.
Tue, Jan 2, 8:29 PM · Okular
rkflx added a comment to D9549: Horizontally center shadows and make them bigger.

I just pushed the necessary modification to the second file.

Tue, Jan 2, 5:40 PM · Plasma
rkflx added a comment to D9549: Horizontally center shadows and make them bigger.

Now I am confused. I thought the screenshots above show what the VDG proposed, i.e. small menu shadows, large window shadows? At least I like it this way.

Tue, Jan 2, 5:29 PM · Plasma
rkflx added a comment to D9580: Fix saving annotations to gzipped files.
In D9580#185022, @aacid wrote:

Do you think you could add an autotest so this doesn't regress in the future?

Tue, Jan 2, 5:07 PM · Okular
rkflx added a comment to D9347: Ignore baloo urls created from new KIO model.

Don't forget to merge your commits on the 17.12 branch back to master.

For master, I was expecting to land this: D9333 which is the proper fix but requires the new KIO version.

Tue, Jan 2, 5:02 PM
rkflx added a comment to D9549: Horizontally center shadows and make them bigger.

I can make the spinbox not affect menus; good catch. This was a pre-existing bug, but it gets bigger with the patch.

Tue, Jan 2, 4:58 PM · Plasma

Mon, Jan 1

rkflx added a comment to D9549: Horizontally center shadows and make them bigger.

New year, new look ;) Great work, this looks impressive and solves the left-side usability problem at the same time.

Mon, Jan 1, 4:19 PM · Plasma
rkflx committed R223:9f0aa37906c9: Document ".okular" filename extension (authored by rkflx).
Document ".okular" filename extension
Mon, Jan 1, 7:41 AM
rkflx closed D9577: Document ".okular" filename extension.
Mon, Jan 1, 7:41 AM · Okular
rkflx added a reviewer for D9578: Improve error message when parttest fails due to missing pdflatex: Okular.
Mon, Jan 1, 7:35 AM · Okular
rkflx added a reviewer for D9579: Fix testSaveAsUndoStackAnnotations autotest: Okular.
Mon, Jan 1, 7:34 AM · Okular
rkflx added a reviewer for D9580: Fix saving annotations to gzipped files: Okular.
Mon, Jan 1, 7:34 AM · Okular
rkflx retitled D9577: Document ".okular" filename extension from Document ".okular" extension to Document ".okular" filename extension.
Mon, Jan 1, 7:31 AM · Okular

Sun, Dec 31

rkflx added a revision to T7532: Install pdflatex in the SuseQt5.9 builders: D9578: Improve error message when parttest fails due to missing pdflatex.
Sun, Dec 31, 2:52 PM · build.kde.org

Sat, Dec 30

rkflx added a comment to D9545: Fix SEPA plugin installation.

Sorry, this issue seemed to be caused by phabricator or wrong phabricator usage. Running

arc patch --nobranch D9545

did run "git am" with the patch on the recent branch with my name as author, which was wrong.

Sat, Dec 30, 7:49 AM · KMyMoney

Tue, Dec 26

rkflx added a comment to T7646: Make it SUPER obvious how to register for Phabricator for newer KDE fans.

I agree there is still room for improvements to make it easier to register. People I have in mind here are those who want to start contributing changes to the code, get involved in the VDG, do promotional things etc., i.e. everything not related to bug reporting or triaging for which Bugzilla is the place to go at the moment.

Tue, Dec 26, 8:30 AM · Goal settings 2017

Sat, Dec 23

rkflx added a comment to D8763: Monitor profile should use relative colorimetric rendering intent by default.

@behrmann Thanks so much, your insights and perspective are really helpful.

Sat, Dec 23, 6:55 PM

Fri, Dec 22

rkflx added a comment to D9078: HiDPI fixes for thumbnails in gwenview.
In D9078#181876, @rkflx wrote:

You see that there is a slight change in rendering quality shortly after that (some recomputation? why?).

Fri, Dec 22, 6:27 PM

Thu, Dec 21

rkflx added a comment to D9078: HiDPI fixes for thumbnails in gwenview.

There are still a couple of issues, so I guess it might take some time until this patch can land. Note I have neither tested all things I want to test yet nor done a full code review. I'll do those once more things work.

Thu, Dec 21, 11:34 AM
rkflx added a comment to D9342: Make sure, a newly saved image is selected in ContextManager.

I wait until the first point is clarified, before updating the diff. No hurry. ;)
Or should I separate the second issue into a new diff?

Thu, Dec 21, 11:04 AM
rkflx committed R260:63cab4a27147: Merge remote-tracking branch 'origin/Applications/17.12' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/17.12'
Thu, Dec 21, 12:11 AM
rkflx committed R260:50e6fa3ffc49: Fix expanding of baloo URLs in folders sidebar tree view (authored by rkflx).
Fix expanding of baloo URLs in folders sidebar tree view
Thu, Dec 21, 12:08 AM

Wed, Dec 20

rkflx added a comment to D9342: Make sure, a newly saved image is selected in ContextManager.

Works now as it should, but I'm still not feeling 100% confident (but a lot better than with the previous iteration :)

Wed, Dec 20, 11:59 PM

Dec 19 2017

rkflx added a comment to D9078: HiDPI fixes for thumbnails in gwenview.
In D9078#173937, @rkflx wrote:

What a nice surprise, thanks for your contribution. My first impression is quite positive, I'll try to test more thoroughly in the next days. I think Lukas should comment, too.

Dec 19 2017, 11:23 PM

Dec 18 2017

rkflx accepted D9351: Fixed places side panel for baloo urls.

Perfect. Please commit to Applications/17.12, I'll do the follow-up fix and merge to master later.

Dec 18 2017, 5:19 PM
rkflx added a comment to D9025: Make current item in ThumbnailView visible.

Okay, played around a bit and thought about our options. In general it works good enough for me in normal and (since the latest Diff) in fullscreen mode and for opaque / non-opaque as well as for fully white / fully black images.

Dec 18 2017, 12:02 AM

Dec 17 2017

rkflx committed R260:a8e44bf45320: Merge remote-tracking branch 'origin/Applications/17.12' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/17.12'
Dec 17 2017, 7:26 AM
rkflx committed R260:5a7d105ae9de: Update titlebar after image modification (authored by muhlenpfordt).
Update titlebar after image modification
Dec 17 2017, 7:25 AM
rkflx closed D9293: Update titlebar after image modification.
Dec 17 2017, 7:25 AM
rkflx accepted D9293: Update titlebar after image modification.

Perfect, thanks.

Dec 17 2017, 7:25 AM

Dec 16 2017

rkflx committed R260:70a4b5cec42f: Merge remote-tracking branch 'origin/Applications/17.12' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/17.12'
Dec 16 2017, 7:16 AM
rkflx committed R260:92e63330ecdc: Correct margin for left sidebar (authored by kapillamba4).
Correct margin for left sidebar
Dec 16 2017, 7:15 AM
rkflx closed D9145: Correct margin for left sidebar.
Dec 16 2017, 7:15 AM · KDE Applications

Dec 15 2017

rkflx updated the summary of D9351: Fixed places side panel for baloo urls.
Dec 15 2017, 9:05 PM
rkflx requested changes to D9351: Fixed places side panel for baloo urls.

Thanks so much for your help, Renato! Seems like a straightforward fix for someone familiar with the new additions to KFilePlacesModel ;)

Dec 15 2017, 9:04 PM
rkflx added a comment to D9293: Update titlebar after image modification.

Amazing, this looks much more straightforward and at the same time fixes the * problem too. The flickering of the title I sometimes got is also gone :)

Dec 15 2017, 9:03 PM