rkflx (Henrik Fehlauer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 6 2017, 7:59 PM (83 w, 3 d)
Availability
Available

Recent Activity

Aug 27 2018

Restricted Application added a project to D13901: Touch support for Gwenview: Gwenview.

Now that 18.08 is released, it's finally time for the code review part of your patch. As mentioned before, I don't have any hardware to test this. Mouse-based usage still seems to be fine, with one exception though (see below).

Aug 27 2018, 6:46 AM · Gwenview

Aug 25 2018

rkflx removed a member for Gwenview: rkflx.
Aug 25 2018, 8:36 AM
rkflx resigned from D6083: Bump max thumbnail size to 512px.
Aug 25 2018, 8:36 AM · Gwenview
rkflx resigned from D7581: HiDPI Support for Gwenview.
Aug 25 2018, 8:36 AM
rkflx resigned from D9039: Add persistent user option to control wrap behavior.
Aug 25 2018, 8:36 AM · Gwenview
rkflx resigned from D10897: Enlarge smaller images by default.
Aug 25 2018, 8:35 AM · Gwenview
rkflx resigned from D11008: Fix issues regarding available operations being out of sync with selected image.
Aug 25 2018, 8:35 AM · Gwenview
rkflx resigned from D14583: [MainWindow] Navigate through mouse forward/back buttons.
Aug 25 2018, 8:35 AM · Gwenview
rkflx resigned from D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed.
Aug 25 2018, 8:34 AM · Gwenview
rkflx resigned from D9078: HiDPI fixes for thumbnails in gwenview.
Aug 25 2018, 8:34 AM
rkflx planned changes to D14889: Propagate more unused events in edit tools.
Aug 25 2018, 8:34 AM · Gwenview
rkflx planned changes to D15066: Elide labels in save bar instead of hiding them.
Aug 25 2018, 8:33 AM · Gwenview
rkflx added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Hi everyone. Sorry to say, but in light of recent events I lost all motivation to further contribute to Plasma. As for the Gwenview integration, Huon told me he's not very likely to contribute code anymore either. Not sure what this all means, but good luck anyway.

Aug 25 2018, 8:28 AM · VDG, Spectacle
rkflx abandoned D9987: Lessen log spam by not checking for existence of file with empty name.
Aug 25 2018, 6:46 AM · Frameworks
rkflx removed a member for Spectacle: rkflx.
Aug 25 2018, 6:44 AM
rkflx removed a watcher for Spectacle: rkflx.
Aug 25 2018, 6:43 AM
rkflx resigned from D10099: Use single number as filename for screenshot with empty filename template.
Aug 25 2018, 6:43 AM · Spectacle
rkflx resigned from D10952: Add Ctrl+T as addditional shortcut for Take Screenshot button.

At the risk of being redundant myself, are we scrapping CTRL + T or keeping it?

I'd say the existing shortcut in the code is enough for now, with the long-term goal of adding a Configure Shortcuts dialog to Spectacle, where users could change and add shortcuts as they like.

I'll update this submission - or create a new one, whichever is preferred.

It's probably best to create a new revision and abandon this one, because the topic changed quite a bit (sorry again).

Aug 25 2018, 6:43 AM
rkflx resigned from D11203: Prevent grouping/duplicating notifications and fix "Open" button issue.
Aug 25 2018, 6:42 AM · Spectacle
rkflx resigned from D10812: Fix non-working "-n" or "--nonotify" switch.
Aug 25 2018, 6:42 AM
rkflx resigned from D9117: Add shortcuts for copying screenshots to clipboard.

Sorry to say, but in light of recent events I lost all motivation to further contribute to Plasma. Someone else should take over.

Aug 25 2018, 6:42 AM · Spectacle
rkflx resigned from D10879: [RFC] Fix/remove command-line options; --delay needs review.
Aug 25 2018, 6:42 AM
rkflx requested changes to D10897: Enlarge smaller images by default.
Aug 25 2018, 6:41 AM · Gwenview
rkflx closed T9252: Improve default filename when saving as Sealed.
Aug 25 2018, 6:41 AM · Spectacle
rkflx resigned from D12692: Add back magnifier to QPainter port of rectangle selection.
Aug 25 2018, 6:41 AM · Spectacle
rkflx resigned from D12626: Port QML Rectangle cropper to QWidget + QPainter.

Sorry to say, but in light of recent events elsewhere I lost all motivation to further contribute to Plasma (this has nothing to do with you or your patch). Please find another reviewer.

Aug 25 2018, 6:41 AM · Spectacle

Aug 24 2018

rkflx resigned from D7087: Add "Copy Info" button to the About System KCM.
Aug 24 2018, 10:49 PM · Plasma
rkflx resigned from D7949: Allow to print pdf doc directly into a QPrinter.
Aug 24 2018, 10:48 PM · Okular
rkflx resigned from D11304: Fix bug where dolphin fails to select any item where a path is created using "Create New | Folder".
Aug 24 2018, 10:48 PM · Dolphin
rkflx resigned from D11324: Select files instead of opening them when trying to open a QUrl as a directory when in fact it is a file..
Aug 24 2018, 10:48 PM · Dolphin
rkflx resigned from D12130: Use the more user-friendly string "File type" in the save dialogs.
Aug 24 2018, 10:48 PM · Frameworks
rkflx resigned from D12545: Set focus on the filename line edit when a file is selected.
Aug 24 2018, 10:47 PM · Frameworks
rkflx abandoned D6695: Fix text labels in sidebar occasionally rendering cut off.
Aug 24 2018, 10:47 PM · Okular
rkflx abandoned D6696: Elide cut off text in sidebar header, remove restricted max width.
Aug 24 2018, 10:47 PM · Okular
rkflx abandoned D7240: Fix german translations to match the recorded audio.
Aug 24 2018, 10:47 PM · KDE Edu
rkflx abandoned D12591: KFileWidget: Provide faster access to the icon position setting.
Aug 24 2018, 10:47 PM · Frameworks
rkflx abandoned D12598: FileView: Provide faster access to the icon position setting.
Aug 24 2018, 10:47 PM
rkflx resigned from D7010: KSqueezedTextLabel: call updateGeometry() when text changes.
Aug 24 2018, 10:46 PM · Frameworks
rkflx resigned from D12327: Show Detailed Tree View by default.
Aug 24 2018, 10:46 PM · Frameworks
rkflx resigned from D12647: Move the inline preview button into the menu.
Aug 24 2018, 10:46 PM · Frameworks
rkflx closed T6982: KSqueezedTextLabel: Investigate resize handling to fix failing autotest as Resolved.
Aug 24 2018, 10:46 PM · Frameworks
rkflx added a comment to D14917: Fix Advanced settings crop toolbar sometimes cut off.

Yup. Even for the most extreme situations a user can reach via resizing, Gwenview should behave nicely. As such eliding is more elegant than simply cutting off the label…

Aug 24 2018, 10:45 PM · Gwenview
rkflx requested review of D15066: Elide labels in save bar instead of hiding them.
Aug 24 2018, 10:45 PM · Gwenview
rkflx committed R260:5e9a3ea0b0ff: Fix Enter key not working for new Close button in Red Eye Reduce tool (authored by rkflx).
Fix Enter key not working for new Close button in Red Eye Reduce tool
Aug 24 2018, 10:42 PM
rkflx closed D15014: Fix Enter key not working for new Close button in Red Eye Reduce tool.
Aug 24 2018, 10:42 PM · Gwenview
rkflx added a comment to P254 Get rid of RedEyeReductionTool mStatus.

Should we get rid of mStatus and just use stackedWidget->currentWidget()?
Something like this: P254 (diff against this patch).

Aug 24 2018, 10:42 PM
rkflx closed T7022: Improve confirmation dialog when closing multiple tabs as Sealed.

Abandoning after reassessing priorities.

Aug 24 2018, 6:55 AM · Okular
rkflx added a comment to T9460: Consider a more user-friendly SpinBox control.

talk to him in private about that and make suggestions on how to improve. I'm sure Nate wouldn't just ignore that.

Aug 24 2018, 6:36 AM · KDE Human Interface Guidelines, Kirigami, Breeze, VDG

Aug 23 2018

rkflx added a comment to T5242: Display user information so that others can land/amend a patch.

I had this same problem recently - land a commit from a different user but the authorsihp was changed. I reverted the commit. :(

Aug 23 2018, 11:00 PM · Phabricator
rkflx added a comment to T9460: Consider a more user-friendly SpinBox control.

@ngraham I have suggested this multiple times in response to similar apologies of yours before, and here I'm only doing it again because I still care at least a little bit and I still hope there will a chance for change: Please let go of your assumptions regarding hidden agendas or how often, where and why I comment on your work. Nobody is here to specifically pick on you, I'm sorry that you still seem to get that impression.

Aug 23 2018, 11:00 PM · KDE Human Interface Guidelines, Kirigami, Breeze, VDG
rkflx added a comment to D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.

Oh well, the joys of diverging branches. Only the "close" vs "cancel" button types were accounted for, but not the (now) differing button boxes themselves. Patch in D15014. Glad you checked again!

Aug 23 2018, 6:12 AM · Gwenview
rkflx requested review of D15014: Fix Enter key not working for new Close button in Red Eye Reduce tool.
Aug 23 2018, 6:11 AM · Gwenview
rkflx closed D14954: Center numbers in Crop and Reduce Red Eye spinboxes.
Aug 23 2018, 6:09 AM · Gwenview
rkflx committed R260:868e438a7413: Center numbers in Crop and Reduce Red Eye spinboxes (authored by rkflx).
Center numbers in Crop and Reduce Red Eye spinboxes
Aug 23 2018, 6:09 AM

Aug 22 2018

rkflx committed R318:79c485a66de7: Restore settings label and prevent warning when Baloo is unavailable (authored by rkflx).
Restore settings label and prevent warning when Baloo is unavailable
Aug 22 2018, 10:02 PM
rkflx closed D14980: Restore settings label and prevent warning when Baloo is unavailable.
Aug 22 2018, 10:02 PM · Dolphin
rkflx added a comment to D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed.

What about the lock ratio by holding Ctrl / ? That's why I did not change the cursor in the handle areas. Ctrl+click over a handle does not zoom but resize with locked ratio.

Aug 22 2018, 7:27 AM · Gwenview

Aug 21 2018

rkflx committed R260:3bd3a7eebc64: Merge remote-tracking branch 'origin/Applications/18.08' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 21 2018, 7:22 PM
rkflx committed R260:df8cb1abf5ba: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools (authored by rkflx).
Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools
Aug 21 2018, 7:16 PM
rkflx closed D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.
Aug 21 2018, 7:16 PM · Gwenview
rkflx added a comment to D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed.

I think this diff was branched before your invalid-rect and double-click-accept patches. After rebase and adding checks in mouseDoubleClickEvent these issues should be gone.

Aug 21 2018, 7:13 PM · Gwenview
rkflx accepted D14969: Fix Crop tool Aspect ratio sometimes randomly preselected.

I was not able to reproduce showing a wrong ratio in the checkbox, but CropRatioIndex=39816368 in gwenviewrc is certainly not correct ;)

Aug 21 2018, 7:13 PM · Gwenview
rkflx added a comment to T9460: Consider a more user-friendly SpinBox control.

@safaalfulaij Thanks for the links, those are quite interesting. So there are actually two different use cases for spinboxes:

  • Changing a value only a couple of ticks (e.g. the number of copies when printing), where you need precise control and therefore are likely to click.
  • Changing a value over a wider range (e.g. a width or height of an image), where scrolling is faster and does not need be precise. Those spinboxes are probably found in large professional apps with dense interfaces and less space for individual +/- buttons.
Aug 21 2018, 7:13 PM · KDE Human Interface Guidelines, Kirigami, Breeze, VDG
rkflx requested review of D14980: Restore settings label and prevent warning when Baloo is unavailable.
Aug 21 2018, 7:13 PM · Dolphin
rkflx added a comment to D14814: Port away from kdelibs4support.

Would you be ok if we just disable that checkbox?

Aug 21 2018, 7:12 PM · Dolphin
rkflx added a comment to T9460: Consider a more user-friendly SpinBox control.

I'm pretty sure no one uses these buttons if they have an actual mouse, but just the wheel.

Aug 21 2018, 9:36 AM · KDE Human Interface Guidelines, Kirigami, Breeze, VDG

Aug 20 2018

rkflx added a comment to D14954: Center numbers in Crop and Reduce Red Eye spinboxes.

Keyboard handling solved as requested and tests are running again, so now I can get back to what I was actually working on ;)

Aug 20 2018, 4:40 PM · Gwenview
rkflx requested review of D14954: Center numbers in Crop and Reduce Red Eye spinboxes.
Aug 20 2018, 4:39 PM · Gwenview
rkflx committed R260:da8ff685e7af: Port to ecm_add_test to stop skipping all test runs (authored by rkflx).
Port to ecm_add_test to stop skipping all test runs
Aug 20 2018, 4:38 PM
rkflx closed D14934: Port to ecm_add_test to stop skipping all test runs.
Aug 20 2018, 4:38 PM
rkflx added a comment to D14934: Port to ecm_add_test to stop skipping all test runs.

On my system an additional test appstreamtest is automatically created (no Gwenview source file). Isn't this created for you (because your log says Start 1: imagescalertest)?

Aug 20 2018, 4:38 PM
rkflx added a reviewer for D14921: Fix compilation error when removing file in test: Gwenview.

Hi, thanks for your patch. Sorry for not noticing it earlier, we don't get a notification if you don't set Gwenview as either the reviewer or project tag.

Aug 20 2018, 4:37 PM · Gwenview
rkflx added a comment to D14869: [RFC] Increase default font sizes by 1 pt.

@ngraham Could you comment on why (on your personal machine) you went for increasing the font size instead of changing the DPI value? (If this is a UI issue, telemetry might give skewed results, BTW.)

Aug 20 2018, 12:01 PM · Plasma
rkflx updated the diff for D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.
  • Fix crash
  • Use int
Aug 20 2018, 11:18 AM · Gwenview
rkflx updated subscribers of D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.

Btw. Backspace still goes to the previous image. But not sure if we should change this too. It's not used otherwise and could be assigned to any other action by the user.

Aug 20 2018, 11:17 AM · Gwenview
rkflx accepted D14917: Fix Advanced settings crop toolbar sometimes cut off.
Aug 20 2018, 11:16 AM · Gwenview

Aug 19 2018

rkflx accepted D14814: Port away from kdelibs4support.

I tried your test plan, which works as advertised. Code LGTM too. Let's get rid of kdelibs4support…

Aug 19 2018, 8:55 PM · Dolphin
rkflx requested review of D14934: Port to ecm_add_test to stop skipping all test runs.
Aug 19 2018, 8:54 PM
rkflx committed R260:c56cb90d7fe7: Restore CMake package descriptions for KIPI and KDcraw (authored by rkflx).
Restore CMake package descriptions for KIPI and KDcraw
Aug 19 2018, 8:52 PM
rkflx accepted D14917: Fix Advanced settings crop toolbar sometimes cut off.

Setting the message label to QSizePolicy::Fixed prevents from shrinking but it still adjusts to the current width hint.

Aug 19 2018, 8:51 PM · Gwenview
rkflx added a comment to D14923: Supress paste in screen locker.

Added bug no.

Aug 19 2018, 6:48 AM · Plasma
rkflx added a comment to D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.

Another idea I had (more suited for master, though): In addition to Enter and double-clicking I could also make Space accept a tool. Instead of doing nothing this could be handy for two-handed use (left hand on the keyboard, right hand on the mouse). Thoughts?

Aug 19 2018, 6:31 AM · Gwenview
rkflx requested review of D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.
Aug 19 2018, 6:30 AM · Gwenview

Aug 18 2018

rkflx updated the diff for D14889: Propagate more unused events in edit tools.

(Please ignore the previous attempt ;)

Aug 18 2018, 11:04 PM · Gwenview
rkflx requested changes to D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed.

Sorry for the wait, but I did not get to the focus/hover issue yet (and thus did not start with the actual review).

Aug 18 2018, 10:59 PM · Gwenview
rkflx added a dependent revision for D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed: D14889: Propagate more unused events in edit tools.
Aug 18 2018, 10:58 PM · Gwenview
rkflx updated the diff for D14889: Propagate more unused events in edit tools.

Ah, right. So doing the right thing here actually uncovers hidden problems elsewhere. Since you already solved them in
D14485, I'll depend on your Diff here.

Aug 18 2018, 10:58 PM · Gwenview
rkflx committed R260:c62ac92006d7: Adjust spacing in crop UI (authored by rkflx).
Adjust spacing in crop UI
Aug 18 2018, 10:57 PM
rkflx closed D14907: Adjust spacing in crop UI.
Aug 18 2018, 10:57 PM
rkflx added a comment to D14907: Adjust spacing in crop UI.

The Advanced settings bar is really wide. Should we try to split this into two lines if there is not enough space, e.g. with a floating layout?

Aug 18 2018, 10:56 PM
rkflx added a comment to D14917: Fix Advanced settings crop toolbar sometimes cut off.

Wow, you fixed it already! This also solves the problem of not being able to make the window smaller after disabling Advanced settings again.

Aug 18 2018, 10:54 PM · Gwenview

Aug 17 2018

rkflx requested review of D14907: Adjust spacing in crop UI.
Aug 17 2018, 7:03 PM
rkflx committed R260:0db8e6608507: Merge remote-tracking branch 'origin/Applications/18.08' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 17 2018, 7:00 PM
rkflx committed R260:74acf5fbe5e4: Keep the width of the crop spinboxes fixed to avoid wiggling (authored by rkflx).
Keep the width of the crop spinboxes fixed to avoid wiggling
Aug 17 2018, 7:00 PM
rkflx closed D14888: Keep the width of the crop spinboxes fixed to avoid wiggling.
Aug 17 2018, 7:00 PM

Aug 16 2018

rkflx added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Disable shadow for marker tool

Yay!

Aug 16 2018, 8:48 PM · VDG, Spectacle
rkflx requested review of D14889: Propagate more unused events in edit tools.
Aug 16 2018, 8:02 PM · Gwenview
rkflx added a comment to D14888: Keep the width of the crop spinboxes fixed to avoid wiggling.

Sounds simple once you know the trick, but to get there was a bit long-winded…

Aug 16 2018, 7:59 PM
rkflx requested review of D14888: Keep the width of the crop spinboxes fixed to avoid wiggling.
Aug 16 2018, 7:59 PM
rkflx committed R260:0c678376131d: Polish Reduce Red Eye UI (authored by rkflx).
Polish Reduce Red Eye UI
Aug 16 2018, 7:52 PM