- User Since
- May 6 2017, 7:59 PM (50 w, 22 h)
Some smaller things, but looks good mostly.
Cool, works great! Perfection level 99% in the code ;)
Maybe less dots?:
Looking better now ;)
One more idea: We could go all the way to a Windows style file dialog, i.e. use a single button to switch views, which has all options in it:
- Short View → Next to Filename (needs new name)
- Short View → Above to Filename (needs new name)
- Detailed View
- Tree View
- Detailed Tree View
Switch to KSqueezedTextLabel, and also use it in Browse mode
There's also this effect that going from "9 of 10" to "10 of 10" will hide the label, but I guess there is no elegant way to prevent this, and it will probably happen only rarely in regular window configurations.
Fri, Apr 20
Thanks for the update. "500 of 10000" on a single line in fullscreen mode does work quite well after all, I think. Glad you changed it!
…and another fix done in slotSaveResult. LGTM
I have nothing to add to the other reviewer's judgements :)
Always good to have less warnings…
Hm, I could imagine regular users will have a hard time selecting their preferred language. They'll see a list of languages, and look for some kind of checkbox to "select what they want". How should they realize that the top-most language will be used as the default, with the languages below as a fallback?
Sorry, I don't really get what you mean. I'm not proposing going back to KDE3, Nate is proposing going back to the KDE3 design! (In KDE4 this was improved to what we have in KF5, FYI.) Also, I don't see where you get from that I'm proposing to follow any "law"? Not sure what you mean with "2 sets of navigation buttons" which are "together in one horizontal plane", either. If you are referring to Nate's mockup, I'm the wrong person to ask. Comparisons to Windows are moot, because there you have different design constraints due to the position of the breadcrumb bar. Lastly, I don't get the connection between your example and the title of the Diff.
Thu, Apr 19
Hm, now you are getting quite off-topic. I thought we wanted to make sorting easier?
Video for the flickering I'm talking about (recorded with no "hacks", adding -1 will solve it):
Sorry for the back and forth, it seems this is all a bit tricky to get right…
Are we talking about the same thing? For me the issue is only with Oxygen, but not with Breeze or Fusion (look at the gap on the right which is not there upon start, but after resizing does not go away anymore):
Ok, let's not get distracted with Dolphin…
Thanks for looking into this. There is one way the "more ergonomic" might have been meant: When navigating in the file view, the distance for the mouse to travel to the navigation buttons is much shorter when they are directly above the file view, i.e. like they are currently in the file dialog, but not in Dolphin.
@ngraham One more idea: Instead of having the text right in the toolbar, move it as a header inside the menu, e.g. like this:
--- Sort by --- Name Size ...
Late to the party, but thanks for the patch anyway…
Thanks, works great for me, apart from two minor inline comments.
@anemeth Thanks for the update, I'll test it out later.
I know you feel strongly about putting Sort functionality right in the face of users ;) Let me play the devil's advocate to work out whether another solution would be feasible too:
- Introducing a new string to the UI comes at a cost: It draws attention away from what's really important, i.e. the files. I'm not saying sorting is not important, but is it really that important like you claim?
- Why would only a single icon get text added next to it?
- The text may be partly motivated by the lack of an appropriate icon. Shouldn't we improve the icons instead?
- This conflicts with Detailed View, where some of the options are more easily accessible by clicking on the table headers. Isn't this confusing for users?
@ngraham Any reason you removed the "Double-click to confirm" from your comment? That's one of the things I (and lot's of others) miss most!
There should be a single action from the user's point of view:
- In the menu (with the shortcut for Find written besides it).
- In the toolbar (ideally displaying the toggle state).
- In the Configure Shortcuts dialog (clearly allowing to set the shortcut for Find).
- In the Configure Toolbars dialog.
Any extra width will cause more wrapping for the filename, because the labels are in a horizontal layout. I will try a vertical layout, which will mean the filename will only get one line's worth of space at minimum (default) thumbnail size.
Wed, Apr 18
This also enables it for users who previously disabled it.
The relation between the Preview and the Zoom slider is now a bit weird: You can override with the button, but once you move the slider the setting will be gone again. Also, when showing the dialog after closing it, the slider has preference over the button. In addition, even though the button says "enabled", users will wonder why no thumbnails are showing!
While we all think having the toggling behaviour is a nice touch, duplicating entries in the shortcut dialog and in many other places is worse, IMO. Is there really no way to solve this? Can we override the shortcut handling somehow?
Move the File Name field to the top of the window, like GTK and Mac file pickers
Please add a mockup of how your final vision of the dialog looks like after all changes in T8552 are done, in particular "Move the File Name field to the top of the window" and any toolbar additions. Otherwise it's really hard to judge an individual change like this.
Cool. Some quick feedback and final tweaking for things we did not catch in the design phase:
- Please don't forget about BUG: 203042 ;)
- Browse mode:
- I'd prefer "with the last part hidden if there are no videos" over "0 videos".
- Adding filters works just fine.
- View mode:
- I know you seldomly show the sidebar in your screenshots, but it does exist after all… As I suggested in the bug regarding: "[O]nly display the label if there is enough space, i.e. based on the width of the label plus a (generous!) amount of whitespace on both sides.". Currently you are increasing the minimum width of Gwenview, and in some situations the label looks quite cramped as well.
- Good choice for the light table! I'm totally with you, and would not change anything.
- Fullscreen toolbar:
- The linebreak for >1000 images is not all that great after trying it. I think we might as well go with a single line. Some time ago I did some experiments with the toolbar which would make it wider, so there would be less need for this optimization (not done yet, because I first want to bring the number of open Gwenview reviews down…).
- "1 of 2" instead of "1/2" would look nicer and be more consistent. In this case I'd spend the little bit of extra space this requires, what do you think?
- Aligning the filename to the top even fixes a couple of old issues.
- Long filenames without spaces previously resulted in the toolbar getting wider. Now they are simply cut off. I think that's acceptable, as most image filenames are probably not that long.
While I first thought the problem has been there forever, via git blame it turns out that this is actually yet another sideeffect of D8196: Try to keep ContextManager in sync with viewed files in MainWindow, which on purpose prevented opening View without a valid URL. Your patch makes sense when you think about it in this light…
@ngraham Thanks for adding the task, really helps in coordinating things. Added some points I've been working on last weekend, will polish and post patches later.
Cool! Can you also tweak the vertical spacing a bit? Currently Nate displays 2 rows of text (left), while your patch shows 3 (right), resulting in fewer items visible at once. Of course the best course of action would be to make this adapt dynamically to the filename like in Dolphin, but if that is too complicated for now, I think we should go with 2 rows, because that seems to fit most situations:
Nice! Make sure to talk to @ngraham in D12149: Improve grid spacing in icons-on-top mode for open/save dialogs, where he worked on something similar (but also set a larger text width for small icons). We might want to pick parts from both patches, but currently they are conflicting.
FWIW, Foxit Reader does have a Reset Form button, which upon clicking shows a dialog asking "This option will reset all form fields to their default values. You may lose some data. Are you sure?".
Tue, Apr 17
Mon, Apr 16
@guotao Thanks for the updates! The config settings are working great now, just some final code polishing to be done.
Can we find a compromise? For example, the Places panel already seems to know when something is on a remote location. Could we show Refresh only for remote folders? The toolbar reorganizing itself would also make users aware of the need to manually refresh in some cases.
Sun, Apr 15
(Will look at the rest later.)
Sat, Apr 14
Ah, sorry. Thought you meant to enter a percentage for the zoom value. Just ignore my comment. Too many reviews today…
@ngraham The way I understood @elvisangelaccio was that the possibility to open a folder with another application should stay, but featured less prominently (i.e. like before). My ping was mainly to get the conversation going again, because it looked like Elvis' concern was being ignored.
LGTM, as discussed in D11569#235002.
Ah, small misunderstanding: I was mainly referring to not making Above filename (in conjunction with Short View) the overall default for the dialog. If Detailed (Tree) View was the default, changing the mode of Short View is probably fine. We could also add a third button, so it would work just like in Dolphin (needs removing Reload, but who is using that anyway, because it's not even present in Dolphin? See also D12215 ;).
Not sure what you mean?
Haha, reading the title I thought this was a fix for https://bugs.kde.org/show_bug.cgi?id=131068, but eliminating a crash is even better, of course ;)
First I wondered why now the zoom slider was jumping when rotating, but then it made sense: The minimum zoom changes for non-square images upon rotating due to it corresponding to Fit.
Elegant fix which works great ;)
Anybody from Frameworks still having objections on code or behaviour?
@yurchor I guess you can land this now.
Fri, Apr 13
Forgot something important:
I wonder if having a filter feature even makes any sense when saving files, and if it does--why only for Kate?
Ok, forget about Dolphin, which for small sizes IMO could be much more dense than it is now.
@ngraham Before I look at this in detail: Did you aim for a spacing consistent with Dolphin? Because on a short try with different icon sizes in both Dolphin and the file dialog, sometimes one was wider and sometimes the other…
Let's do one step at a time ;) First, decide which mode we want to show. Then think about the icon, i.e. either switch icons or redo the icon itself. (Basing the mode on the icon instead of on the behaviour is very questionable, I'm surprised you even bring this up…) The third step would be to look at Dolphin (where I think you should do a poll to gauge usage of what you describe as the "horrible" mode, an assessment which I'd agree with but maybe other don't…).