rkflx (Henrik Fehlauer)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 6 2017, 7:59 PM (58 w, 3 d)
Availability
Available

Recent Activity

Yesterday

rkflx requested changes to D13344: Add possibility to sort by rating.
  • Import header file only when needed
  • Use if instead of else if when using return
  • Avoid multiple conversions from QVarient to int
Tue, Jun 19, 10:30 PM
rkflx requested changes to D11877: Allow dragging from View mode to external applications.

We are pretty close now, just some final polishing 👍

Tue, Jun 19, 10:25 PM · Gwenview
rkflx accepted D13493: Auto-copy shared image link to clipboard.

LGTM, just a comment to keep the commit history spotless ;)

Tue, Jun 19, 10:21 PM · Documentation
rkflx added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Hmm, most drawing programs I'm familiar with move by single pixels with the unmodified arrow keys, and increase the movement with the key. I think that's what we were proposing. In other words, just change the modifier for the "large movement step" action.

Tue, Jun 19, 10:21 PM
rkflx added a comment to D13344: Add possibility to sort by rating.

@muhlenpfordt Thanks for testing, I think you found an important flaw.

Tue, Jun 19, 1:25 PM

Mon, Jun 18

rkflx added a comment to D13450: Add arrow keys to move and resize selection rectangle.

It's interesting how two people interpret the same goal a little differently. I saw this as a precision adjustment tool, as opposed to a core behavior.

Mon, Jun 18, 10:20 PM
rkflx added a comment to D13493: Auto-copy shared image link to clipboard.

Yeah, the right thing to do in the long term would be to step back and rethink how copying URLs or pixmaps should work from a user/workflow perspective. I tried to start with some peculiarities in my comment above, but obviously this needs more thought. It should be simple, not a myriad of buttons and options, yet support all existing workflows.

Mon, Jun 18, 10:19 PM · Documentation
rkflx requested changes to D13344: Add possibility to sort by rating.

Nice, works really great now. Some minor inline comments, then we are good to go.

Mon, Jun 18, 10:19 PM
rkflx committed R260:e5e5b9a888e8: Fix 'Loading...' action not showing (authored by faridb).
Fix 'Loading...' action not showing
Mon, Jun 18, 5:58 AM
rkflx closed D13312: Fix 'Loading...' action not showing.
Mon, Jun 18, 5:58 AM

Sun, Jun 17

rkflx added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Sorry I was busy last week, but thanks for the patch anyway. Could not look at it in detail yet, but here are some high-level comments:

  • Did Nate mention that currently there is work underway in D12626: Port QML Rectangle cropper to QWidget + QPainter? Not sure what's the best course of action though, i.e. whether to rebase on the port now, or finish the QML-based patch and port later.
  • With regards to the choice of shortcuts, I think users prefer consistency with other apps. For example in Inkscape and LibreOffice:
    • increases the distance per step
    • Ctrl changes the type of action performed
  • I find it a bit annoying how slow the feature is by default. Would it make sense to swap the the behaviour, i.e. you'd have to press the modifier to move slower?
  • There's only one hurdle left to make selecting a region possible from the keyboard only: You have to perform at least the initial click. Ideas?
  • Moving and resizing beyond the border of the screen should not be possible.
  • It's probably not necessary to describe every option in detail and overload the help text (doubling the number of options and tripling the covered screen area). How about this:
Arrow keys: Move selection
            Hold Ctrl to resize, fine-tune with Shift
Sun, Jun 17, 11:56 PM
rkflx added a comment to D13493: Auto-copy shared image link to clipboard.

Thanks, preferable over D13221 indeed.

Sun, Jun 17, 11:55 PM · Documentation
rkflx added a project to D12883: Adopt a more reasonable approach for passing the file to purpose: Spectacle.

Thanks for the patch and sorry for not noticing earlier – in general it's best to set Spectacle as a reviewer so Spectacle's members will have a chance to know about and review the patch before it lands without acceptance.

Sun, Jun 17, 11:54 PM · Spectacle
rkflx added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I've pushed a quick fix which also hides the handles while resizing on mouse down

Sun, Jun 17, 11:54 PM · Spectacle

Fri, Jun 8

rkflx added a comment to D13344: Add possibility to sort by rating.

Thanks for the update. Don't have time to look at this right now, but here's one more tip (which should come in handy for your next patches, of which I secretly hope there are many ;)

Fri, Jun 8, 1:00 PM
rkflx added a comment to D12626: Port QML Rectangle cropper to QWidget + QPainter.

Hey everyone, sorry I've been missing from the scene for so long, glad to be back!

Fri, Jun 8, 12:59 PM · Spectacle
rkflx added a comment to D11877: Allow dragging from View mode to external applications.
  • Don't drag if document failed to load
  • Update to use MimeTypeUtils::selectionMimeData
  • Respect mimimum drag distance
  • Use DragPixmapGenerator
Fri, Jun 8, 12:59 PM · Gwenview
rkflx committed R166:4e9720789e0f: Do not hide sharing URL automatically (authored by rkflx).
Do not hide sharing URL automatically
Fri, Jun 8, 12:58 PM
rkflx closed D13261: Do not hide sharing URL automatically.
Fri, Jun 8, 12:58 PM
rkflx committed R166:e9218fddfabd: Deduplicate code for showing inline messages (authored by rkflx).
Deduplicate code for showing inline messages
Fri, Jun 8, 12:49 PM
rkflx closed D13247: Deduplicate code for showing inline messages.
Fri, Jun 8, 12:49 PM
rkflx committed R166:9a71f5bbd454: Deduplicate code for quitting (authored by rkflx).
Deduplicate code for quitting
Fri, Jun 8, 12:41 PM
rkflx closed D13245: Deduplicate code for quitting.
Fri, Jun 8, 12:41 PM
rkflx committed R166:b56b755534e2: Improve readability of saving glue code (authored by rkflx).
Improve readability of saving glue code
Fri, Jun 8, 12:39 PM
rkflx closed D13244: Improve readability of saving glue code.
Fri, Jun 8, 12:39 PM
rkflx committed R119:ff78e7fe039f: Merge remote-tracking branch 'origin/Plasma/5.13' (authored by rkflx).
Merge remote-tracking branch 'origin/Plasma/5.13'
Fri, Jun 8, 12:38 PM
rkflx committed R119:540edfdd2a88: Fonts KCM: Fix text readability regression (authored by rkflx).
Fonts KCM: Fix text readability regression
Fri, Jun 8, 12:36 PM
rkflx closed D13390: Fonts KCM: Fix text readability regression.
Fri, Jun 8, 12:36 PM · Plasma

Thu, Jun 7

rkflx added a comment to D13247: Deduplicate code for showing inline messages.

The whole patch chain works nicely, and in fact, I even see the notification once more when using Save and Save As... with Quit after save or copy.

Thu, Jun 7, 10:54 PM
rkflx updated the diff for D13390: Fonts KCM: Fix text readability regression.

Okay, great. Thanks for investigating! I now changed to what you proposed, so we have something for 5.13.1.

Thu, Jun 7, 10:50 PM · Plasma
rkflx added a comment to D13390: Fonts KCM: Fix text readability regression.
In D13390#275153, @mart wrote:

what you should do is:
TextField {

readOnly: true
Kirigami.Theme.inherit: false   //always to be set when you are writing anything to the Theme attached proeprty
Kirigami.Theme.colorGroup: Kirigami.Theme.Window

}

changing the textfield colorgroup to window, will make its background to become gray, so a look somewhat less "clickable"

Thu, Jun 7, 11:34 AM · Plasma
rkflx added a comment to D12851: Change preview text background color to match with default combobox background color.

Sorry for the delay...

Thu, Jun 7, 6:42 AM · Plasma
rkflx added a comment to D13390: Fonts KCM: Fix text readability regression.

It will lead users to click into the field, expecting to be able to edit the name directly

Oh, you mean because the background turns white when enabled? I see.

Thu, Jun 7, 6:35 AM · Plasma
rkflx added a comment to D13390: Fonts KCM: Fix text readability regression.

Unfortunately that's not what I think is needed here.

Why not? You make the text field look as though it is enabled, which is what readOnly does. Still being able to select text isn't too bad, is it?

Thu, Jun 7, 6:30 AM · Plasma
rkflx added a comment to D13390: Fonts KCM: Fix text readability regression.
In D13390#275034, @Zren wrote:

Would the TextField.readOnly property be useful here?

http://doc.qt.io/qt-5/qml-qtquick-controls-textfield.html#readOnly-prop

Thu, Jun 7, 6:23 AM · Plasma

Wed, Jun 6

rkflx requested review of D13390: Fonts KCM: Fix text readability regression.
Wed, Jun 6, 9:49 PM · Plasma
rkflx added a comment to D12851: Change preview text background color to match with default combobox background color.

Anything left to be done here? I guess this should land on the Plasma/5.13 branch, since it's still broken there (I almost wrote a patch…).

Wed, Jun 6, 9:48 PM · Plasma
rkflx added a comment to D13247: Deduplicate code for showing inline messages.

@broulik @ngraham Any additional tips?

Wed, Jun 6, 9:48 PM
rkflx added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

From the git log:

Change selection rect from solid to dashed line

Wed, Jun 6, 9:48 PM · Spectacle
rkflx requested changes to D13344: Add possibility to sort by rating.

@faridb Thanks for the patch ;)

Wed, Jun 6, 9:48 PM
rkflx accepted D13312: Fix 'Loading...' action not showing.

Nice, LGTM now. I'll wait a couple of days whether we get any more updates on the bug, and then commit on your behalf.

Wed, Jun 6, 9:48 PM

Tue, Jun 5

rkflx added a comment to D13312: Fix 'Loading...' action not showing.

I filed this bug in which I attached videos of the test program which reproduces the bug.

Tue, Jun 5, 1:12 PM

Mon, Jun 4

rkflx added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I'm shifting the painter by 0.5 px on X and Y for all odd width/sizes, this should place all odd widths directly on the pixel.

Mon, Jun 4, 7:36 PM · Spectacle
rkflx added a comment to D13312: Fix 'Loading...' action not showing.

For me it seem Gwenview is not at fault, and until we fix the issue elsewhere, here we only can work around the problem.

Mon, Jun 4, 7:10 PM
rkflx committed R260:8f1283065235: Add possibility to sort by descending order (authored by faridb).
Add possibility to sort by descending order
Mon, Jun 4, 7:07 PM
rkflx closed D13213: Add possibility to sort by descending order.
Mon, Jun 4, 7:07 PM · Gwenview

Sun, Jun 3

rkflx added a comment to D13312: Fix 'Loading...' action not showing.
  • At the start of updateMenu() call menu->hide(), then call menu->show() at the end. However, this causes the menu to flicker because it's shown and hidden quickly. It causes the menu to be shown when it shouldn't.
Sun, Jun 3, 10:15 PM
rkflx added a comment to D13289: Fix share menu not showing the first time it is used.

I'll reply in the other Diff, as updating the code of an already landed Diff is always a bit confusing later on…

Sun, Jun 3, 10:15 PM
rkflx requested changes to D11203: Prevent grouping/duplicating notifications and fix "Open" button issue.

@kapillamba4 Apologies for the extremely long wait, I now looked at your patch (feel free to poke other people in the future if your original reviewer is too busy…).

Sun, Jun 3, 10:15 PM · Spectacle
rkflx added a comment to D11879: Allow dragging files/folders to View mode.

@huoni The bug reporter likes your patch 👍: https://bugs.kde.org/show_bug.cgi?id=169408#c8

Sun, Jun 3, 10:40 AM · Gwenview
rkflx added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I don't know if I get you correctly but to me this looks like an Antialiasing issue.

Sun, Jun 3, 10:40 AM · Spectacle
rkflx added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@dporobic Thanks logging those issues! (Once the code lives in KDE's repos, we should probably use tasks on Phabricator for tracking…)

Sun, Jun 3, 7:07 AM · Spectacle
rkflx added a comment to D11877: Allow dragging from View mode to external applications.

Thanks for the update ;)

Sun, Jun 3, 6:28 AM · Gwenview
rkflx committed R260:bc1d4c545a86: Prompt to install kipi-plugins when the share button is clicked (authored by faridb).
Prompt to install kipi-plugins when the share button is clicked
Sun, Jun 3, 6:19 AM
rkflx closed D13197: Prompt to install kipi-plugins when the share button is clicked .
Sun, Jun 3, 6:19 AM · Gwenview
rkflx committed R260:8759c1257793: Merge remote-tracking branch 'origin/Applications/18.04' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/18.04'
Sun, Jun 3, 6:18 AM
rkflx committed R260:bb8522f62679: Fix share menu not showing the first time it is used (authored by faridb).
Fix share menu not showing the first time it is used
Sun, Jun 3, 6:11 AM
rkflx closed D13289: Fix share menu not showing the first time it is used.
Sun, Jun 3, 6:11 AM

Sat, Jun 2

rkflx added a comment to D13283: Add possibility to sort folders first.

(but make sure to let us know before starting to work on something, as some bugs are a bit weird and not actually something we might want to add to Gwenview…).

How should I do that?

Sat, Jun 2, 11:26 PM
rkflx added a comment to D13283: Add possibility to sort folders first.

Space and Backspace navigate between images linearly, while +++ also allow to move to folders.

Sat, Jun 2, 11:16 PM
rkflx added a comment to D13289: Fix share menu not showing the first time it is used.

I could not find a way to test if Loading... was showing correctly because the plugins were loading almost instantaneously.

Sat, Jun 2, 11:10 PM
rkflx added a comment to D13283: Add possibility to sort folders first.

I think there is a way to make the browsing feature work even if Folders First is disabled. For example, skip the next element if it's a folder and go directly to the next document after it. Would that be an acceptable behaviour?

Sat, Jun 2, 11:04 PM
rkflx added a comment to D13289: Fix share menu not showing the first time it is used.

I'll land this on the stable branch, i.e. Applications/18.04, as it is a nice bugfix for an annoying problem.

Sat, Jun 2, 10:19 PM
rkflx accepted D13213: Add possibility to sort by descending order.

Excellent. I tested everything again, and the issue with the folders not appearing first anymore is now solved.

Sat, Jun 2, 10:18 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

I updated the summary. Is it a suitable commit message?

Sat, Jun 2, 8:52 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Ah, one more thing: You might want to update the summary a bit to reflect the current state of the patch, as it will become the commit message. Simply click on Edit Revision on the top.

Sat, Jun 2, 8:32 PM · Gwenview
rkflx accepted D13197: Prompt to install kipi-plugins when the share button is clicked .

I created a separate Diff for the bug fix at D13289.

Sat, Jun 2, 8:30 PM · Gwenview
rkflx accepted D13289: Fix share menu not showing the first time it is used.

I'll land it first thing in the morning!

Sat, Jun 2, 7:56 PM
rkflx updated the diff for D13261: Do not hide sharing URL automatically.
  • Rebase
Sat, Jun 2, 6:59 PM
rkflx updated the diff for D13247: Deduplicate code for showing inline messages.

Thanks, good point. I'm now using an enum. I wonder how I missed this obvious improvement.

Sat, Jun 2, 6:59 PM
rkflx updated the diff for D13245: Deduplicate code for quitting.
  • Use enum
Sat, Jun 2, 6:58 PM
rkflx committed R260:ed455f744def: Remove superfluous code for empty KIPI toolbar button (authored by rkflx).
Remove superfluous code for empty KIPI toolbar button
Sat, Jun 2, 6:57 PM
rkflx closed D13251: Remove superfluous code for empty KIPI toolbar button.
Sat, Jun 2, 6:57 PM
rkflx requested changes to D13283: Add possibility to sort folders first.

Nice! And thanks for using Arcanist to submit the patch.

Sat, Jun 2, 6:56 PM
rkflx added a comment to D13213: Add possibility to sort by descending order.

Great, LGTM now except for two minor comments.

Sat, Jun 2, 6:56 PM · Gwenview
rkflx added a comment to D10297: Add new "Tools" button above System Monitor's process list.

Awesome, I did not expect that the fix for the shortcuts would be so simple. Thanks for your patience, we are nearly there…

Sat, Jun 2, 6:56 PM · Plasma
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Rebase on D13252

Sat, Jun 2, 6:56 PM · Gwenview
rkflx added inline comments to D11879: Allow dragging files/folders to View mode.
Sat, Jun 2, 6:56 PM · Gwenview
rkflx added a comment to D7087: Add "Copy Info" button to the About System KCM.

Thanks for the update and sorry it took me a while to look at it.

Sat, Jun 2, 6:55 PM · Plasma
rkflx updated the diff for D13251: Remove superfluous code for empty KIPI toolbar button.

Rebase

Sat, Jun 2, 6:19 AM
rkflx committed R260:ecf62cc5cc7d: Merge remote-tracking branch 'origin/Applications/18.04' (authored by rkflx).
Merge remote-tracking branch 'origin/Applications/18.04'
Sat, Jun 2, 6:17 AM
rkflx committed R260:3a772173e287: Watch for installation of kipi-plugins only when needed (authored by rkflx).
Watch for installation of kipi-plugins only when needed
Sat, Jun 2, 6:16 AM
rkflx closed D13250: Watch for installation of kipi-plugins only when needed.
Sat, Jun 2, 6:16 AM
rkflx committed R260:69ffc4038bfd: Update KIPI toolbar button after installation of kipi-plugins (authored by rkflx).
Update KIPI toolbar button after installation of kipi-plugins
Sat, Jun 2, 6:15 AM
rkflx closed D13252: Update KIPI toolbar button after installation of kipi-plugins.
Sat, Jun 2, 6:15 AM
rkflx committed R260:3bb8beb56fba: Refine behaviour for dragging modified images to external applications (authored by rkflx).
Refine behaviour for dragging modified images to external applications
Sat, Jun 2, 6:13 AM
rkflx closed D13249: Refine behaviour for dragging modified images to external applications.
Sat, Jun 2, 6:13 AM
rkflx committed R260:7c43f583cf7a: Refactor determining mime data for selection (authored by rkflx).
Refactor determining mime data for selection
Sat, Jun 2, 6:12 AM
rkflx closed D13248: Refactor determining mime data for selection.
Sat, Jun 2, 6:11 AM
rkflx accepted D11879: Allow dragging files/folders to View mode.

Thanks, LGTM now :)

Sat, Jun 2, 6:06 AM · Gwenview

Fri, Jun 1

rkflx added a comment to D13249: Refine behaviour for dragging modified images to external applications.

Thanks for the quick review!

Fri, Jun 1, 8:38 PM
rkflx added inline comments to D13248: Refactor determining mime data for selection.
Fri, Jun 1, 8:37 PM
rkflx added a comment to D13252: Update KIPI toolbar button after installation of kipi-plugins.

@faridb Thanks for the review ;)

Fri, Jun 1, 8:37 PM
rkflx requested changes to D13213: Add possibility to sort by descending order.

Thanks again for the patch, works great for folders with only images in them and even title/summary/test plan are looking excellent.

Fri, Jun 1, 8:35 PM · Gwenview
rkflx added a comment to D7971: Add "Open containing folder" button to the notification.

I'd actually rather want to get rid of the "Open" button (but for that we would need to detect if the notification server supports previews which we currently can't).

Fri, Jun 1, 8:34 PM · Spectacle
rkflx added a dependent revision for D13247: Deduplicate code for showing inline messages: D13261: Do not hide sharing URL automatically.
Fri, Jun 1, 9:47 AM
rkflx requested review of D13261: Do not hide sharing URL automatically.
Fri, Jun 1, 9:47 AM
rkflx updated the diff for D13247: Deduplicate code for showing inline messages.

Allow to show persistent messages.

Fri, Jun 1, 9:46 AM

Thu, May 31

rkflx planned changes to D13247: Deduplicate code for showing inline messages.

https://bugs.kde.org/show_bug.cgi?id=394181
increase the timeout for the notification

I'd vote for disabling the timeout entirely in that case, because nothing is
more annoying than clicking a split second too late (which can happen
regardless of the timeout you choose).

+10. Heck, I'd support doing that now, because it's really annoying to miss
copying the URL because you were a tiny bit too late.

Thu, May 31, 7:29 PM
rkflx added a comment to D13221: Make it easier to copy the Imgur link to the clipboard.

https://bugs.kde.org/show_bug.cgi?id=394181

change the string to just "Copy link", ommitting the "to clipboard" part.

Thu, May 31, 7:26 PM