- User Since
- May 6 2017, 7:59 PM (66 w, 3 d)
Thanks! I added the context menu back, cleaned up the blur and most importantly redacted the window title :)
(You might want to use Rectangular Region, because none of the other modes can capture both a shadow and a context menu at the same time. It's a bug in Spectacle, I actually had to GIMP the screenshot for Gwenview…)
confirm -> correct
KMail, KDE's powerful email client, features some improvements in the travel data extraction engine. It now supports UIC 918.3 and SNCF train ticket barcodes and Wikidata-powered train station location lookup. Support for multi-traveler itineraries was added, and KMail now has integration with the KDE Itinerary app.
@cfeck Sorry for not providing screenshots earlier. Was just about to capture some when I noticed your commit.
- Update wording with my suggestion from yesterday.
- Remove empty line.
Mon, Aug 13
Hi, thanks for reaching out.
Sun, Aug 12
@faridb Are you still around?
(I'm aware that the size slider for Reduce Red Eye now is quite long. There will be a follow-up fixing that along with a bunch of other issues.)
Sat, Aug 11
Fri, Aug 10
Thank you everyone who wrote and improved the text! It's in a pretty good state now as far as I could tell when checking thoroughly (at least for the apps that are present in the etherpad, we might want to expand next time…).
@progwolff Any comments on the proposal below?
Thu, Aug 9
@muhlenpfordt I'd say go ahead with landing (after updating the version). It would be good to still have some testing time before the next Frameworks release.
(I'll clean up the #ifdefs separately, mainly asking for general consensus for the version bump here.)
Wed, Aug 8
One more quick idea (have not really thought about it, no final wording etc.):
Have you thought about how to keep the simple and the advanced tabs in sync, in particular when the user chooses conflicting options in both of them at the same time?
Tue, Aug 7
Thanks for the help. Works great, just one inline question about an edge case (everything else LGTM).
Mon, Aug 6
Thanks for the update. This leaves us with the Browse mode and Fullscreen issues.
- Use function instead of static const
There are two more problem I noticed, this time in View mode:
- Repeatedly clicking fast on one of the forward or backward buttons will only change the image for every second click.
- Doing the same for videos will accidentally trigger fullscreen mode.
Yeah, a lot has happened since last year. After the finishing touches are done, this should be checked carefully again.
Sun, Aug 5
This comment has been deleted.
Thanks, looking better than before now. There are still some improvements you could make:
- There is a superfluous space before the comma in the second line.
- I'd prefer the bar to be a bit wider by default. However, it turns out there is a problem with my original suggestion (see inline comment).
- The vertical spacing between the first and the second line is too big, it should be the same as for Size:. However, there should still be enough spacing so it also looks good with the Oxygen style. As far as I can see this is an issue with how Breeze renders the KCapacityBar, in particular the bounding rect contains unnecessary margins (⇧+Ctrl-click on it in GammaRay and compare Breeze and Oxygen). Of course that's material for a patch in a different repo, but the "hole" in your current screenshot does not look good (the second line is closer to the bottom than to the first line, which is bad!), and it would be better to fix the problem there before landing the KIO patch.
Sat, Aug 4
Thanks for the updates, LGTM ;)
Fri, Aug 3
Initialize HudSlider for video controls after widget is setup
Nice! This fixes even the time slider which showed the same issue when trying to open a video with an unsupported codec.
Happy birthday D7087, you are now 1 year old.
Okay, seems nobody around here has such a mouse anymore, but I think in View mode this is working fine.
Thanks, I'll have to look for such a device. Meanwhile, I've got a couple of inline comments.
Thanks for the patch.
Thu, Aug 2
Wed, Aug 1
Thanks for the patch.
Let's hope for the best ;)
Okay, here's my patch (don't laugh, I know it looks fishy):
Tue, Jul 31
Just realized this actually fixes a problem present in KDE 3 already (KDE 2 did not have the second line yet, as far as I could tell in a short but very interesting test).