rkflx (Henrik Fehlauer)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 6 2017, 7:59 PM (50 w, 22 h)
Availability
Available

Recent Activity

Today

rkflx added a comment to F5817563: thunderbird-buttons.webm.

https://bugs.kde.org/show_bug.cgi?id=344746

Sun, Apr 22, 11:48 AM
rkflx requested changes to D12301: Display document count labels in View, Browse, and Full Screen modes.

Some smaller things, but looks good mostly.

Sun, Apr 22, 11:30 AM · Gwenview
rkflx accepted D12429: Ensure full screen info label shows at least two lines of text.

Cool, works great! Perfection level 99% in the code ;)

Sun, Apr 22, 11:30 AM · Gwenview
rkflx added a comment to D10980: updated hanle icon.

Maybe less dots?:

Sun, Apr 22, 11:30 AM · Frameworks

Yesterday

rkflx added a comment to D12102: Port Language KCM to Qt Quick.

Looking better now ;)

Sat, Apr 21, 6:24 PM · Kirigami, Plasma
rkflx added a comment to D12327: Show Detailed Tree View by default.

In fact, if we integrated the Up button into the KURLNavigator widget, it would solve some issues automatically (e.g. lack of up button in Gwenview). I could see some people complaining about it though, because then the navigation buttons would be in two different vertical planes (since the URL navigator is always below the toolbar). Maybe we could live with that though?

Sat, Apr 21, 1:54 PM · Frameworks
rkflx added a comment to D12327: Show Detailed Tree View by default.
  • Bandwagon: Windows and macOS's default details style views allow expansion by default too
Sat, Apr 21, 1:40 PM · Frameworks
rkflx added a comment to D12327: Show Detailed Tree View by default.

One more idea: We could go all the way to a Windows style file dialog, i.e. use a single button to switch views, which has all options in it:

  • Short ViewNext to Filename (needs new name)
  • Short ViewAbove to Filename (needs new name)
  • Detailed View
  • Tree View
  • Detailed Tree View
Sat, Apr 21, 11:20 AM · Frameworks
rkflx added a comment to D12327: Show Detailed Tree View by default.

But Detailed View and Detailed Tree View are two different things, no? (I'm not even sure Windows supports the latter)

Sat, Apr 21, 11:09 AM · Frameworks
rkflx added a comment to D12327: Show Detailed Tree View by default.

I'm not sure I agree with this change

Sat, Apr 21, 10:03 AM · Frameworks
rkflx added a comment to D12301: Display document count labels in View, Browse, and Full Screen modes.

Aha! I've noticed this too: rm ~/.config/gwenviewrc shows 1 line, wiggling the slider shows 2 lines even for the lowest setting. Sure, go ahead and change it (but make sure to test with other styles too).

Hmm, different widget styles are a problem. But that seems to be an existing issue. The minimum thumbnail bar height is different depending on the style (it's set to mRightToolBar->sizeHint().height()).
Perhaps this needs a rework in a separate diff? 1) Make sure default and minimum sizes are the same (dynamically calculate default). 2) Ensure the minimum/default size shows exactly two lines.

Sat, Apr 21, 8:34 AM · Gwenview
rkflx added a comment to D12301: Display document count labels in View, Browse, and Full Screen modes.

Switch to KSqueezedTextLabel, and also use it in Browse mode

Are you sure for Browse it is working? If I set a narrow window width and the press Ctrl+A, the label does not elide, but the window gets wider (might also be a different problem, did not look much into it).

Sat, Apr 21, 8:22 AM · Gwenview
rkflx added a comment to D12301: Display document count labels in View, Browse, and Full Screen modes.

Switch to KSqueezedTextLabel, and also use it in Browse mode

Sat, Apr 21, 7:55 AM · Gwenview
rkflx added a comment to D12301: Display document count labels in View, Browse, and Full Screen modes.

One more thing about the fullscreen label: Before the patch it was centered vertically, now it is quite crammed to the top. I don't think we can change anything fundamental there, but perhaps we can tweak it a bit: For the default height, two lines of text are showing, but the bottom line is still positioned a bit above the image counter. If there was a way to manually align both, the top line would get a tiny bit more space to the top.

Turns out default only shows one line. The default is 75px, but the minimum size in the config widget is 88px. So it will be one line until you change the thumbnail size, and thereafter the minimum is two lines.
I've changed the margins so the lines line up at the minimum height (88px). I think we should change the default to this. Thoughts?

Sat, Apr 21, 7:50 AM · Gwenview
rkflx added a comment to D12102: Port Language KCM to Qt Quick.

Here are additional mockups for thought.

Sat, Apr 21, 6:33 AM · Kirigami, Plasma
rkflx added a comment to D12306: Filepicker dialog proper grid icon layout.

Ooh, centering when there's only one column is a nice touch.

Sat, Apr 21, 6:18 AM · Frameworks
rkflx added a comment to D12301: Display document count labels in View, Browse, and Full Screen modes.

There's also this effect that going from "9 of 10" to "10 of 10" will hide the label, but I guess there is no elegant way to prevent this, and it will probably happen only rarely in regular window configurations.

Sat, Apr 21, 6:13 AM · Gwenview

Fri, Apr 20

rkflx added a comment to D12301: Display document count labels in View, Browse, and Full Screen modes.

Thanks for the update. "500 of 10000" on a single line in fullscreen mode does work quite well after all, I think. Glad you changed it!

Fri, Apr 20, 9:30 PM · Gwenview
rkflx accepted D12372: Fix "Save As" in failed-save message box.

…and another fix done in slotSaveResult. LGTM

Fri, Apr 20, 9:29 PM
rkflx accepted D12346: Remove duplicate overwrite confirmation dialog.

I have nothing to add to the other reviewer's judgements :)

Fri, Apr 20, 9:29 PM
rkflx accepted D12343: Update markup for xi18n* in failed-save message box.

Always good to have less warnings…

Fri, Apr 20, 9:28 PM
rkflx added a comment to D12102: Port Language KCM to Qt Quick.

Hm, I could imagine regular users will have a hard time selecting their preferred language. They'll see a list of languages, and look for some kind of checkbox to "select what they want". How should they realize that the top-most language will be used as the default, with the languages below as a fallback?

Fri, Apr 20, 5:02 PM · Kirigami, Plasma
rkflx added a comment to D12130: Use the more user-friendly string "File type" in the save dialogs.

I might need some help with this. It seems that the apps whose save dialogs show a combobox in place of a filter list are creating a QDialog and setting the Mime types list with QDialog::setMimeTypeFilter(). I haven't yet managed to figure out how this call is intercepted and replaced with a KFileDialog, or how KFileDialog can detect that there's a combobox of MIME types instead of a filter widget.

Fri, Apr 20, 4:12 PM · Frameworks
rkflx added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

Sorry, I don't really get what you mean. I'm not proposing going back to KDE3, Nate is proposing going back to the KDE3 design! (In KDE4 this was improved to what we have in KF5, FYI.) Also, I don't see where you get from that I'm proposing to follow any "law"? Not sure what you mean with "2 sets of navigation buttons" which are "together in one horizontal plane", either. If you are referring to Nate's mockup, I'm the wrong person to ask. Comparisons to Windows are moot, because there you have different design constraints due to the position of the breadcrumb bar. Lastly, I don't get the connection between your example and the title of the Diff.

Fri, Apr 20, 4:11 PM · Frameworks
rkflx added a comment to D12372: Fix "Save As" in failed-save message box.

The "Save As" dialog always starts in the source file's directory now and not in the previously selected but failed one.
Is it desirable to restart in the previous folder?

Fri, Apr 20, 8:40 AM
rkflx added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

I gave a +1 to the original idea because I feel that there isn't really much closeness that you can achieve with the open dialog. It is simple, straightforward.

Fri, Apr 20, 8:34 AM · Frameworks

Thu, Apr 19

rkflx added a comment to D12337: Give the file dialogs a "Sort by" menu button on the toolbar.

Hm, now you are getting quite off-topic. I thought we wanted to make sorting easier?

Thu, Apr 19, 11:42 PM · Frameworks
rkflx added a comment to D12306: Filepicker dialog proper grid icon layout.

Video for the flickering I'm talking about (recorded with no "hacks", adding -1 will solve it):

Thu, Apr 19, 10:30 PM · Frameworks
rkflx added inline comments to D12306: Filepicker dialog proper grid icon layout.
Thu, Apr 19, 10:26 PM · Frameworks
rkflx added a comment to D12306: Filepicker dialog proper grid icon layout.

@rkflx the 3px is causing flickering on Oxygen, 4px does not.

Thu, Apr 19, 10:22 PM · Frameworks
rkflx added a comment to T8357: Announcement text for the Applications 18.04 release.
In T8357#138911, @cfeck wrote:

It's all in. Please check https://www.kde.org/announcements/announce-applications-18.04.0.php for anything that needs to be fixed before adding the link to the front page.

I hope the image choice looks sane, and please send apologizes to the translation teams for not being able to commit the text earlier...

Thu, Apr 19, 9:47 PM · KDE Applications, KDE Promo
rkflx requested changes to D12306: Filepicker dialog proper grid icon layout.
Thu, Apr 19, 9:26 PM · Frameworks
rkflx added a comment to D12306: Filepicker dialog proper grid icon layout.

Sorry for the back and forth, it seems this is all a bit tricky to get right…

Thu, Apr 19, 9:18 PM · Frameworks
rkflx added a comment to D12328: Enable preview by default in the filepicker dialog.

Could not run this yet, but IIRC deleting a key does not need a separate script, you should be able to do it inline in the upd with RemoveKey.

how about this then:

Thu, Apr 19, 8:43 PM · Frameworks
rkflx added a comment to D12321: Hide file preview when icon is too small.

In fact, perhaps we should consider this new automatically-disable-previews-at-small-sizes behavior to be a replacement for Dolphin's clunky independent-sliders-for-previews-and-non-previews feature. I suspect it was implemented that way to allay a similar concern (previews being useless at small sizes) but IMHO the solution in this patch is much more elegant and user-friendly

Thu, Apr 19, 8:09 PM · Frameworks
rkflx added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

Lately, the zoom widget is placed at the bottom in most programs, perhaps it can be moved at the left of the Save/Open Cancel buttons.

Thu, Apr 19, 6:32 PM · Frameworks
rkflx added a comment to D12306: Filepicker dialog proper grid icon layout.

Are we talking about the same thing? For me the issue is only with Oxygen, but not with Breeze or Fusion (look at the gap on the right which is not there upon start, but after resizing does not go away anymore):

Thu, Apr 19, 5:00 PM · Frameworks
rkflx added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

Here's another crude mockup: we could add only the navigation controls to the layout above the KDirOperator view.

That would actually make the dialog even more "ergonomic" from the perspective of placing the navigation controls close to the view that they affect.

Thu, Apr 19, 4:47 PM · Frameworks
rkflx added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

Ok, let's not get distracted with Dolphin…

Thu, Apr 19, 4:25 PM · Frameworks
rkflx added a comment to D12337: Give the file dialogs a "Sort by" menu button on the toolbar.

@ngraham One more idea: Instead of having the text right in the toolbar, move it as a header inside the menu, e.g. like this:

--- Sort by ---
  Name
  Size
  ...

If we want to emphasize the settings menu, I think we need to make it a lot more prominent and discoverable. I'd be on board with something like this if we gave it text:

[sliders icon] More settings

Thu, Apr 19, 3:57 PM · Frameworks
rkflx added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

Thanks for looking into this. There is one way the "more ergonomic" might have been meant: When navigating in the file view, the distance for the mouse to travel to the navigation buttons is much shorter when they are directly above the file view, i.e. like they are currently in the file dialog, but not in Dolphin.

Thu, Apr 19, 3:53 PM · Frameworks
rkflx added a comment to D12337: Give the file dialogs a "Sort by" menu button on the toolbar.

@ngraham One more idea: Instead of having the text right in the toolbar, move it as a header inside the menu, e.g. like this:

--- Sort by ---
  Name
  Size
  ...
Thu, Apr 19, 3:40 PM · Frameworks
rkflx updated subscribers of D12337: Give the file dialogs a "Sort by" menu button on the toolbar.

Thu, Apr 19, 3:36 PM · Frameworks
rkflx added a comment to D12300: Add ability to resize images based on percentage.

Late to the party, but thanks for the patch anyway…

Thu, Apr 19, 1:20 PM · Gwenview
rkflx added a comment to D11599: Add magnifier for rectangle mode.

@rkflx @ngraham It's a big change to implement Gwenview style inline tool tip, I think we can change it in later commit.

Thu, Apr 19, 12:42 PM
rkflx added a comment to D12328: Enable preview by default in the filepicker dialog.

However, the old key should not stay around in the config file, it should be removed. We have kconf_update for that. Could you provide or update such a script for ~/.config/kdeglobals?

I couldn't get enough information out of that site, the kconf_update documentation and examples is awful.

Thu, Apr 19, 12:38 PM · Frameworks
rkflx added a comment to D12306: Filepicker dialog proper grid icon layout.

Thanks, works great for me, apart from two minor inline comments.

Thu, Apr 19, 12:34 PM · Frameworks
rkflx added a comment to D12321: Hide file preview when icon is too small.

@anemeth Thanks for the update, I'll test it out later.

Thu, Apr 19, 12:33 PM · Frameworks
rkflx added a comment to D12321: Hide file preview when icon is too small.

The relation between the Preview and the Zoom slider is now a bit weird: You can override with the button, but once you move the slider the setting will be gone again. Also, when showing the dialog after closing it, the slider has preference over the button. In addition, even though the button says "enabled", users will wonder why no thumbnails are showing!

Would it make sense to both:

  • Set the button state to "off" once the icons are too small, to make it clear that no previews are to be expected.
  • Disable the button, so manually toggling thumbnails only works if icons are big enough.

Something like this might be nice, but as you observed, it'll get real complicated real fast. And as @sharvey discovered in D12094, trying to coerce a KToggleAction into doing something it doesn't want to do can be daunting.

Thu, Apr 19, 8:42 AM · Frameworks
rkflx added a comment to T8552: Polish Open/Save dialogs.
In T8552#138899, @rkflx wrote:

Move the File Name field to the top of the window, like GTK and Mac file pickers

That could be quite controversial. I have not made up my mind about this yet, but one thing to be aware of is that this would increase the distance between the name field and the OK button massively. That's bad for the efficiency metric of usability, because when both widgets (which are used most often!) are close together, they are fast to operate (for anyone not knowing

I honestly hadn't made up my mind about it yet either, for the very reasons you cite. I suspect the big commercial OS vendors wrestled with it too, since their solution appears to be a "simple mode" file picker with a filename field and a simple "where do you want to save it combobox". Both macOS and Windows have these, though only Apple had the courage to show it by default instead of the complicated mode. I do recall that this was controversial at the time.

My thinking was that we should follow the standard F-pattern of navigation by putting in the top-left corner the things that are most important--the filename being one of them. But maybe this isn't such a big deal after all.

Thu, Apr 19, 8:23 AM · VDG
rkflx added a comment to D12337: Give the file dialogs a "Sort by" menu button on the toolbar.

I know you feel strongly about putting Sort functionality right in the face of users ;) Let me play the devil's advocate to work out whether another solution would be feasible too:

  • Introducing a new string to the UI comes at a cost: It draws attention away from what's really important, i.e. the files. I'm not saying sorting is not important, but is it really that important like you claim?
  • Why would only a single icon get text added next to it?
  • The text may be partly motivated by the lack of an appropriate icon. Shouldn't we improve the icons instead?
  • This conflicts with Detailed View, where some of the options are more easily accessible by clicking on the table headers. Isn't this confusing for users?
Thu, Apr 19, 7:47 AM · Frameworks
rkflx added a comment to T8552: Polish Open/Save dialogs.

@ngraham Any reason you removed the "Double-click to confirm" from your comment? That's one of the things I (and lot's of others) miss most!

Thu, Apr 19, 12:34 AM · VDG
rkflx added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

There should be a single action from the user's point of view:

  • In the menu (with the shortcut for Find written besides it).
  • In the toolbar (ideally displaying the toggle state).
  • In the Configure Shortcuts dialog (clearly allowing to set the shortcut for Find).
  • In the Configure Toolbars dialog.
Thu, Apr 19, 12:16 AM
rkflx added a comment to D12301: Display document count labels in View, Browse, and Full Screen modes.

Any extra width will cause more wrapping for the filename, because the labels are in a horizontal layout. I will try a vertical layout, which will mean the filename will only get one line's worth of space at minimum (default) thumbnail size.

Thu, Apr 19, 12:07 AM · Gwenview

Wed, Apr 18

rkflx added a comment to D12301: Display document count labels in View, Browse, and Full Screen modes.
  • Please don't forget about BUG: 203042 ;)
Wed, Apr 18, 11:53 PM · Gwenview
rkflx updated the summary of D12301: Display document count labels in View, Browse, and Full Screen modes.
Wed, Apr 18, 11:52 PM · Gwenview
rkflx requested changes to D12328: Enable preview by default in the filepicker dialog.

This also enables it for users who previously disabled it.

Wed, Apr 18, 11:42 PM · Frameworks
rkflx requested changes to D12321: Hide file preview when icon is too small.

The relation between the Preview and the Zoom slider is now a bit weird: You can override with the button, but once you move the slider the setting will be gone again. Also, when showing the dialog after closing it, the slider has preference over the button. In addition, even though the button says "enabled", users will wonder why no thumbnails are showing!

Wed, Apr 18, 11:40 PM · Frameworks
rkflx added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

While we all think having the toggling behaviour is a nice touch, duplicating entries in the shortcut dialog and in many other places is worse, IMO. Is there really no way to solve this? Can we override the shortcut handling somehow?

Wed, Apr 18, 11:34 PM
rkflx added a comment to T8552: Polish Open/Save dialogs.

While you're compiling an impressive to-do list, would you consider adding "Full-color (Breeze) icons at 16x16 size"? I think the monochrome line-art icons are awful, with all due respect to the VDG. I know it was done for readability and clarity, but they look primitive and overly technical. I might even fire up Inkscape and try my hand at creating a few.

Wed, Apr 18, 11:31 PM · VDG
rkflx added a comment to T8552: Polish Open/Save dialogs.

Move the File Name field to the top of the window, like GTK and Mac file pickers

Wed, Apr 18, 11:22 PM · VDG
rkflx added a comment to D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does.

Please add a mockup of how your final vision of the dialog looks like after all changes in T8552 are done, in particular "Move the File Name field to the top of the window" and any toolbar additions. Otherwise it's really hard to judge an individual change like this.

Wed, Apr 18, 11:13 PM · Frameworks
rkflx updated subscribers of D12301: Display document count labels in View, Browse, and Full Screen modes.

Cool. Some quick feedback and final tweaking for things we did not catch in the design phase:

  • Please don't forget about BUG: 203042 ;)
  • Browse mode:
    • I'd prefer "with the last part hidden if there are no videos" over "0 videos".
    • Adding filters works just fine.
  • View mode:
    • I know you seldomly show the sidebar in your screenshots, but it does exist after all… As I suggested in the bug regarding: "[O]nly display the label if there is enough space, i.e. based on the width of the label plus a (generous!) amount of whitespace on both sides.". Currently you are increasing the minimum width of Gwenview, and in some situations the label looks quite cramped as well.
    • Good choice for the light table! I'm totally with you, and would not change anything.
  • Fullscreen toolbar:
    • The linebreak for >1000 images is not all that great after trying it. I think we might as well go with a single line. Some time ago I did some experiments with the toolbar which would make it wider, so there would be less need for this optimization (not done yet, because I first want to bring the number of open Gwenview reviews down…).
    • "1 of 2" instead of "1/2" would look nicer and be more consistent. In this case I'd spend the little bit of extra space this requires, what do you think?
    • Aligning the filename to the top even fixes a couple of old issues.
    • Long filenames without spaces previously resulted in the toolbar getting wider. Now they are simply cut off. I think that's acceptable, as most image filenames are probably not that long.
Wed, Apr 18, 9:29 PM · Gwenview
rkflx accepted D12302: Fix duplicate and markup displaying failed-save message box.

There are two console warnings caused by wrong markup for xi18n*:

Wed, Apr 18, 9:29 PM
rkflx accepted D12246: Fix View Mode session restore.

While I first thought the problem has been there forever, via git blame it turns out that this is actually yet another sideeffect of D8196: Try to keep ContextManager in sync with viewed files in MainWindow, which on purpose prevented opening View without a valid URL. Your patch makes sense when you think about it in this light…

Wed, Apr 18, 9:29 PM
rkflx added a comment to T8357: Announcement text for the Applications 18.04 release.
In T8357#137795, @cfeck wrote:

I would like to commit this for translation on 15th of April. Would be nice if we can get in the kmail news.

Wed, Apr 18, 4:58 PM · KDE Applications, KDE Promo
rkflx added a comment to T8552: Polish Open/Save dialogs.

@ngraham Thanks for adding the task, really helps in coordinating things. Added some points I've been working on last weekend, will polish and post patches later.

Wed, Apr 18, 4:43 PM · VDG
rkflx updated the task description for T8552: Polish Open/Save dialogs.
Wed, Apr 18, 4:41 PM · VDG
rkflx added a comment to D12306: Filepicker dialog proper grid icon layout.

Cool! Can you also tweak the vertical spacing a bit? Currently Nate displays 2 rows of text (left), while your patch shows 3 (right), resulting in fewer items visible at once. Of course the best course of action would be to make this adapt dynamically to the filename like in Dolphin, but if that is too complicated for now, I think we should go with 2 rows, because that seems to fit most situations:

Wed, Apr 18, 3:50 PM · Frameworks
rkflx added a comment to D9552: libinput/connection: Don't hardcode seat0 anymore.

was this rebase correct?

Wed, Apr 18, 1:06 PM · KWin
rkflx updated subscribers of D12306: Filepicker dialog proper grid icon layout.

Nice! Make sure to talk to @ngraham in D12149: Improve grid spacing in icons-on-top mode for open/save dialogs, where he worked on something similar (but also set a larger text width for small icons). We might want to pick parts from both patches, but currently they are conflicting.

Wed, Apr 18, 1:05 PM · Frameworks
rkflx added a comment to D10932: [Okular] Option to reset forms.

FWIW, Foxit Reader does have a Reset Form button, which upon clicking shows a dialog asking "This option will reset all form fields to their default values. You may lose some data. Are you sure?".

Wed, Apr 18, 7:51 AM · Okular

Tue, Apr 17

rkflx added a comment to D11599: Add magnifier for rectangle mode.

Please also review my tool tip.

I had to read the source code to know where to look for it. What about something like this (inspired by Gwenview):

Tue, Apr 17, 9:54 PM
rkflx added a comment to D11599: Add magnifier for rectangle mode.

@rkflx I add maigc key, so that we can toggle magnifier on/off use alt key

Tue, Apr 17, 8:19 AM

Mon, Apr 16

rkflx added a comment to D11599: Add magnifier for rectangle mode.

@guotao Thanks for the updates! The config settings are working great now, just some final code polishing to be done.

Mon, Apr 16, 11:39 PM
rkflx added a comment to T8357: Announcement text for the Applications 18.04 release.

We'll see if we can improve the style with the next major release.

Mon, Apr 16, 11:39 PM · KDE Applications, KDE Promo
rkflx added a comment to D12218: Remove Reload button from the file dialogs' toolbar.

Can we find a compromise? For example, the Places panel already seems to know when something is on a remote location. Could we show Refresh only for remote folders? The toolbar reorganizing itself would also make users aware of the need to manually refresh in some cases.

Mon, Apr 16, 11:39 PM · Frameworks
rkflx added a comment to D12218: Remove Reload button from the file dialogs' toolbar.

And up? Well, it's twice in there already. You have the breadcrumb bar which allows you to go up.

Mon, Apr 16, 2:57 PM · Frameworks

Sun, Apr 15

rkflx added a comment to D12105: Enable redo for undone image operations.

(Will look at the rest later.)

Sun, Apr 15, 11:17 PM

Sat, Apr 14

rkflx added a comment to D11798: Ensure image View actions are disabled upon switching to Browse.

Ah, sorry. Thought you meant to enter a percentage for the zoom value. Just ignore my comment. Too many reviews today…

Sat, Apr 14, 11:40 PM
rkflx added a comment to D11798: Ensure image View actions are disabled upon switching to Browse.
Sat, Apr 14, 11:38 PM
rkflx added a comment to D11798: Ensure image View actions are disabled upon switching to Browse.

Sorry to hear, but which Diff is this supposed to be a duplicate of? For me the problem is still there, and your patch fixes it (pending complete review).

D11633

Oops ;) I guess I did not make the connection because you retitled the other Diff.

Occurred to me that you may have wasted time reviewing this patch. Apologies for that!

Sat, Apr 14, 11:21 PM
rkflx edited reviewers for D12206: Don't show top "Open With" app for folders; only for files, added: elvisangelaccio; removed: rkflx.

@ngraham The way I understood @elvisangelaccio was that the possibility to open a folder with another application should stay, but featured less prominently (i.e. like before). My ping was mainly to get the conversation going again, because it looked like Elvis' concern was being ignored.

Sat, Apr 14, 11:18 PM · Frameworks
rkflx accepted D12207: Use text "Other Application..." in "Open With" submenu.

LGTM, as discussed in D11569#235002.

Sat, Apr 14, 11:18 PM · Frameworks
rkflx accepted D12077: Show view mode buttons in the open/save dialog's toolbar.

Ah, small misunderstanding: I was mainly referring to not making Above filename (in conjunction with Short View) the overall default for the dialog. If Detailed (Tree) View was the default, changing the mode of Short View is probably fine. We could also add a third button, so it would work just like in Dolphin (needs removing Reload, but who is using that anyway, because it's not even present in Dolphin? See also D12215 ;).

Sat, Apr 14, 11:18 PM · Frameworks
rkflx added a comment to D12130: Use the more user-friendly string "File type" in the save dialogs.

in a new user account

That's a bit pointless in this case, why would you let your reviewers jump through such hoops…

Not sure what you mean?

Sat, Apr 14, 11:18 PM · Frameworks
rkflx accepted D12187: Fix reloading of SVG images.

Haha, reading the title I thought this was a fix for https://bugs.kde.org/show_bug.cgi?id=131068, but eliminating a crash is even better, of course ;)

Sat, Apr 14, 11:17 PM
rkflx accepted D12170: Update view offset in higher zoom levels after image size changed.

First I wondered why now the zoom slider was jumping when rotating, but then it made sense: The minimum zoom changes for non-square images upon rotating due to it corresponding to Fit.

Sat, Apr 14, 11:17 PM
rkflx accepted D12167: Center image after edit operation changed size.

Elegant fix which works great ;)

Sat, Apr 14, 11:17 PM
rkflx requested changes to D12105: Enable redo for undone image operations.

Added DocumentTest::testUndoRedo()

Hope the test isn't too paranoid? ;)

Sat, Apr 14, 11:17 PM
rkflx added a comment to D12077: Show view mode buttons in the open/save dialog's toolbar.

If we did this (after making icons-on-top mode the default for file pickers), then both Dolphin and the file pickers would have the same number of buttons, with each one display the same view and using a consistent icon.

Sat, Apr 14, 7:44 AM · Frameworks
rkflx accepted D12149: Improve grid spacing in icons-on-top mode for open/save dialogs.

Anybody from Frameworks still having objections on code or behaviour?

Sat, Apr 14, 6:24 AM · Frameworks
rkflx added a comment to D12062: Slightly update the docs, add configuration section.

@yurchor I guess you can land this now.

Sat, Apr 14, 6:20 AM

Fri, Apr 13

rkflx added a comment to D11569: Improve consistency of "Open With" UI by always showing top app inline.

I'll leave the string the way it is for now so this can go into Frameworks 5.45, and change it after the string freeze.

Fri, Apr 13, 11:53 PM · Frameworks
rkflx added a comment to D12130: Use the more user-friendly string "File type" in the save dialogs.

Forgot something important:

Fri, Apr 13, 9:19 PM · Frameworks
rkflx added a comment to D12130: Use the more user-friendly string "File type" in the save dialogs.

I wonder if having a filter feature even makes any sense when saving files, and if it does--why only for Kate?

Fri, Apr 13, 9:09 PM · Frameworks
rkflx added a comment to D12149: Improve grid spacing in icons-on-top mode for open/save dialogs.

Ok, forget about Dolphin, which for small sizes IMO could be much more dense than it is now.

Fri, Apr 13, 9:09 PM · Frameworks
rkflx added a comment to D12077: Show view mode buttons in the open/save dialog's toolbar.

The third step would be to look at Dolphin (where I think you should do a poll to gauge usage of what you describe as the "horrible" mode, an assessment which I'd agree with but maybe other don't… Also currently there is not much need in Dolphin to reduce the number of view mode icons in the toolbar, there is still enough space).

Fri, Apr 13, 6:34 PM · Frameworks
rkflx added a comment to D12149: Improve grid spacing in icons-on-top mode for open/save dialogs.

@ngraham Before I look at this in detail: Did you aim for a spacing consistent with Dolphin? Because on a short try with different icon sizes in both Dolphin and the file dialog, sometimes one was wider and sometimes the other…

Fri, Apr 13, 6:00 PM · Frameworks
rkflx added a comment to D12077: Show view mode buttons in the open/save dialog's toolbar.

Let's do one step at a time ;) First, decide which mode we want to show. Then think about the icon, i.e. either switch icons or redo the icon itself. (Basing the mode on the icon instead of on the behaviour is very questionable, I'm surprised you even bring this up…) The third step would be to look at Dolphin (where I think you should do a poll to gauge usage of what you describe as the "horrible" mode, an assessment which I'd agree with but maybe other don't…).

Fri, Apr 13, 5:51 PM · Frameworks