hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (239 w, 3 d)
Availability
Available

Recent Activity

Tue, Mar 31

hindenburg committed R319:c3ada2be32a6: Remove shortcut for detach tab (authored by hindenburg).
Remove shortcut for detach tab
Tue, Mar 31, 4:55 PM
hindenburg committed R319:a889f6aa4b2b: Remove shortcut for detach tab (authored by hindenburg).
Remove shortcut for detach tab
Tue, Mar 31, 4:46 PM

Sat, Mar 28

hindenburg committed R319:fbe6295bb8e8: Use empty() for emptiness instead of size() (authored by hindenburg).
Use empty() for emptiness instead of size()
Sat, Mar 28, 8:24 PM
hindenburg committed R319:3e8401391aa9: Add comments about QSet deprecated methods (authored by hindenburg).
Add comments about QSet deprecated methods
Sat, Mar 28, 7:31 PM
hindenburg committed R319:09df31fe6adc: Remove un-needed semi-colons (authored by hindenburg).
Remove un-needed semi-colons
Sat, Mar 28, 7:31 PM
hindenburg committed R319:b6973dfe6df1: Set QT5.12 as minimum as next release will be 20.08 (authored by hindenburg).
Set QT5.12 as minimum as next release will be 20.08
Sat, Mar 28, 6:57 PM
hindenburg committed R319:449fdd90c974: Revert "Replace deprecated QSet::toList and QSet::fromList()" (authored by hindenburg).
Revert "Replace deprecated QSet::toList and QSet::fromList()"
Sat, Mar 28, 6:41 PM
hindenburg added a reverting change for R319:c07210056cea: Replace deprecated QSet::toList and QSet::fromList(): R319:449fdd90c974: Revert "Replace deprecated QSet::toList and QSet::fromList()".
Sat, Mar 28, 6:41 PM
hindenburg committed R319:c07210056cea: Replace deprecated QSet::toList and QSet::fromList() (authored by joaoeudes7).
Replace deprecated QSet::toList and QSet::fromList()
Sat, Mar 28, 6:21 PM
hindenburg committed R319:ab0636de8ab3: Q_UNUSED() does not need semi-colon at end (authored by hindenburg).
Q_UNUSED() does not need semi-colon at end
Sat, Mar 28, 6:07 PM
hindenburg committed R319:f476e936eaf1: Remove un-needed includes (authored by joaoeudes7).
Remove un-needed includes
Sat, Mar 28, 5:39 PM
hindenburg committed R319:d65e6e9709a1: Remove shortcut for detach tab (authored by hindenburg).
Remove shortcut for detach tab
Sat, Mar 28, 4:30 PM
hindenburg committed R319:8ad28a12574c: Group rendered characters by script (authored by mglb).
Group rendered characters by script
Sat, Mar 28, 3:14 PM
hindenburg committed R319:86085d4acdc4: Allow for grouping extended characters (authored by mglb).
Allow for grouping extended characters
Sat, Mar 28, 3:14 PM
hindenburg committed R319:94ff722fc0e6: Malayalam support: primitive PoC (authored by mglb).
Malayalam support: primitive PoC
Sat, Mar 28, 3:14 PM

Wed, Mar 25

hindenburg committed R319:5d2bae3cbf83: Revert "CMakeLists.txt: use ccache if present" (authored by asturmlechner).
Revert "CMakeLists.txt: use ccache if present"
Wed, Mar 25, 1:10 AM
hindenburg added a reverting change for R319:007c2a085238: CMakeLists.txt: use ccache if present: R319:5d2bae3cbf83: Revert "CMakeLists.txt: use ccache if present".
Wed, Mar 25, 1:10 AM
hindenburg abandoned D28006: Fix build with Qt 5.15 beta2.

Thanks ,someone already committed this.

Wed, Mar 25, 1:06 AM · Konsole
hindenburg commandeered D28006: Fix build with Qt 5.15 beta2.
Wed, Mar 25, 1:06 AM · Konsole
hindenburg added a comment to D27110: Fix scrollbar sometimes reappearing when set to 'hidden' and scrolling using the touchpad.

I'm having problems updating my laptop - can anyone confirm the issue and fix?

Wed, Mar 25, 1:05 AM · Konsole
hindenburg committed R319:3c171015c0d5: Revert "CMakeLists.txt: use ccache if present" (authored by asturmlechner).
Revert "CMakeLists.txt: use ccache if present"
Wed, Mar 25, 1:03 AM
hindenburg added a reverting change for R319:007c2a085238: CMakeLists.txt: use ccache if present: R319:3c171015c0d5: Revert "CMakeLists.txt: use ccache if present".
Wed, Mar 25, 1:03 AM
hindenburg closed D24805: Revert "CMakeLists.txt: use ccache if present".
Wed, Mar 25, 1:03 AM · Konsole
hindenburg accepted D24805: Revert "CMakeLists.txt: use ccache if present".
Wed, Mar 25, 12:50 AM · Konsole
hindenburg updated the summary of D24805: Revert "CMakeLists.txt: use ccache if present".
Wed, Mar 25, 12:45 AM · Konsole

Tue, Mar 24

hindenburg added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

Is there really any reason to fully revert? Why not just make it not the default per the above comment.

Tue, Mar 24, 1:13 PM · Konsole

Feb 22 2020

hindenburg added a comment to D27110: Fix scrollbar sometimes reappearing when set to 'hidden' and scrolling using the touchpad.

Looks fine - thanks - I'll commit shortly

Feb 22 2020, 5:06 PM · Konsole
hindenburg committed R319:173806fc61f3: Konsole tests: update Unicode texts from the Kermit project (authored by knambiar).
Konsole tests: update Unicode texts from the Kermit project
Feb 22 2020, 2:02 PM
hindenburg closed D26599: Konsole tests: update Unicode texts from the Kermit project.
Feb 22 2020, 2:02 PM · Konsole
hindenburg accepted D26599: Konsole tests: update Unicode texts from the Kermit project.

Thanks, if you can in the future do gitlab merge requests. We can still do these phabricator until they shut it down.

Feb 22 2020, 1:51 PM · Konsole

Feb 1 2020

hindenburg committed R319:9babfb2efe65: Re-add correct ProvidersUrl; needed for non-Plasma systems per ml (authored by hindenburg).
Re-add correct ProvidersUrl; needed for non-Plasma systems per ml
Feb 1 2020, 2:16 AM

Jan 30 2020

hindenburg committed R319:048edf73955a: Remove default ProvidersUrl to use KNewStuff's default (authored by hindenburg).
Remove default ProvidersUrl to use KNewStuff's default
Jan 30 2020, 1:10 PM
hindenburg committed R319:72a5acc335d0: Revert "Use RAII to manage QApplication memory" (authored by sandsmark).
Revert "Use RAII to manage QApplication memory"
Jan 30 2020, 1:04 PM
hindenburg added a reverting change for R319:d5d8496cd285: Use RAII to manage QApplication memory: R319:72a5acc335d0: Revert "Use RAII to manage QApplication memory".
Jan 30 2020, 1:04 PM
hindenburg closed D26764: Another revert to unbreak crash fix.
Jan 30 2020, 1:04 PM · Konsole
hindenburg added a comment to D26764: Another revert to unbreak crash fix.

Is there a consensus here? Should we revert to previous code and then if someone wants to put in another merge request.

Jan 30 2020, 1:37 AM · Konsole
hindenburg committed R319:09cc4f6bb97d: Fix Separator (authored by tcanabrava).
Fix Separator
Jan 30 2020, 1:11 AM
hindenburg committed R319:96cda154c16e: Fix context menu actions when search bar is enabled (authored by tcanabrava).
Fix context menu actions when search bar is enabled
Jan 30 2020, 1:11 AM

Jan 24 2020

hindenburg added a comment to D26761: Unbreak opening in separate process and fix crashes.

Is there still some confusion here?

Jan 24 2020, 1:57 AM · Konsole
hindenburg added a comment to D26764: Another revert to unbreak crash fix.

I don't have a problem w/ reverting this. @kkharlamov if you want to try again, please make sure you add the other people here for their comments on it.

Jan 24 2020, 1:57 AM · Konsole

Jan 17 2020

hindenburg committed R319:967c42a1b094: Support status report requests for text-colors (authored by muesli).
Support status report requests for text-colors
Jan 17 2020, 3:34 PM

Jan 8 2020

hindenburg added a comment to D26479: Fix warning on launch from QCommandLineParser.

Yea I noticed that - he does that a lot - thanks for this patch regardless - you can close this.

Jan 8 2020, 3:27 PM · Konsole

Jan 7 2020

hindenburg added a comment to D26479: Fix warning on launch from QCommandLineParser.

But konsole's minimum KF5 version is 5.6.0 currently. Maybe this should be increased?

As the minimum Qt version is 5.9.0, I highly doubt that anyone would want to build konsole with KF5 5.6.0 (which is more than 2 years older) anyway...

Jan 7 2020, 3:05 PM · Konsole
hindenburg committed R319:7ee9350bbab8: Update copyright year (authored by hindenburg).
Update copyright year
Jan 7 2020, 2:14 AM
hindenburg committed R319:2fc470507e42: ColorScheme: fix stack-use-after-scope detected by ASAN (authored by mglb).
ColorScheme: fix stack-use-after-scope detected by ASAN
Jan 7 2020, 2:06 AM
hindenburg added a comment to D26479: Fix warning on launch from QCommandLineParser.

Thanks I just noticed this - I wonder when it started or if depends on KF5/Qt5 version.

Jan 7 2020, 1:56 AM · Konsole

Jan 5 2020

hindenburg committed R319:7cfe2c8a36fd: Copy _colorRandomization when copying a new ColorScheme (authored by wbauer).
Copy _colorRandomization when copying a new ColorScheme
Jan 5 2020, 6:28 PM
hindenburg committed R319:771c1733fd5e: Copy _colorRandomization when copying a new ColorScheme (authored by wbauer).
Copy _colorRandomization when copying a new ColorScheme
Jan 5 2020, 6:25 PM
hindenburg closed D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 6:25 PM · Konsole
hindenburg updated the summary of D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 6:20 PM · Konsole
hindenburg updated the test plan for D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 6:16 PM · Konsole
hindenburg updated the test plan for D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 6:15 PM · Konsole
hindenburg accepted D26439: Copy _colorRandomization when copying a new ColorScheme.

Thanks nice catch. We are trying to migrate to gitlab; if you can in the future use merge requests.

Jan 5 2020, 6:12 PM · Konsole
hindenburg committed R319:23ddfcc4fcd3: Fix token buffer indexing (authored by mglb).
Fix token buffer indexing
Jan 5 2020, 3:51 PM

Jan 3 2020

hindenburg added a comment to D25151: Fix tabs not indicating activity.

This appears to have caused this bug https://bugs.kde.org/show_bug.cgi?id=415249

Jan 3 2020, 2:10 AM · Konsole

Jan 1 2020

hindenburg committed R319:409844712947: Sync method parameter names (authored by hindenburg).
Sync method parameter names
Jan 1 2020, 10:07 PM
hindenburg committed R319:180a366d97d8: Add comment for reference (authored by hindenburg).
Add comment for reference
Jan 1 2020, 10:06 PM
hindenburg committed R319:49cd9b82a2fd: Fix potential use after free issue (authored by hindenburg).
Fix potential use after free issue
Jan 1 2020, 8:49 PM
hindenburg committed R319:78dbc0a010eb: Update copyright year (authored by hindenburg).
Update copyright year
Jan 1 2020, 7:35 PM

Dec 27 2019

hindenburg added a reverting change for R319:d0ae59834896: Remove currentBookmarkList() - hasn't been used in years: R319:e52ec8f420e5: Revert removal to allow Bookmark tabs as Folders to work.
Dec 27 2019, 5:26 AM
hindenburg committed R319:e52ec8f420e5: Revert removal to allow Bookmark tabs as Folders to work (authored by hindenburg).
Revert removal to allow Bookmark tabs as Folders to work
Dec 27 2019, 5:26 AM
hindenburg added a reverting change for R319:d0ae59834896: Remove currentBookmarkList() - hasn't been used in years: R319:7f2f55c30bfd: Revert removal to allow Bookmark tabs as Folders to work.
Dec 27 2019, 5:06 AM
hindenburg committed R319:7f2f55c30bfd: Revert removal to allow Bookmark tabs as Folders to work (authored by hindenburg).
Revert removal to allow Bookmark tabs as Folders to work
Dec 27 2019, 5:06 AM
hindenburg added a reverting change for R319:0995c1dc95bb: Remove supportsTabs() - hasn't been used in years: R319:00c20b240d0b: Revert supportTabs() removal to fix bookmenu issue.
Dec 27 2019, 4:56 AM
hindenburg committed R319:00c20b240d0b: Revert supportTabs() removal to fix bookmenu issue (authored by hindenburg).
Revert supportTabs() removal to fix bookmenu issue
Dec 27 2019, 4:56 AM
hindenburg added a reverting change for R319:0995c1dc95bb: Remove supportsTabs() - hasn't been used in years: R319:5b5ad9f93eb7: Revert supportTabs() removal to fix bookmenu issue.
Dec 27 2019, 4:56 AM
hindenburg committed R319:5b5ad9f93eb7: Revert supportTabs() removal to fix bookmenu issue (authored by hindenburg).
Revert supportTabs() removal to fix bookmenu issue
Dec 27 2019, 4:56 AM

Dec 23 2019

hindenburg committed R319:db974fcb397c: Remove unused methods keyboardCursorShape and keyboardCursorColor (authored by hindenburg).
Remove unused methods keyboardCursorShape and keyboardCursorColor
Dec 23 2019, 4:21 AM
hindenburg committed R319:bed6aa1e208e: Remove unused method masterMode (authored by hindenburg).
Remove unused method masterMode
Dec 23 2019, 3:50 AM
hindenburg committed R319:d413e0bdefa0: Remove unused method masterStatus (authored by hindenburg).
Remove unused method masterStatus
Dec 23 2019, 3:50 AM
hindenburg committed R319:5cc4c6c1347c: Use the same link to ctlseqs.html (authored by hindenburg).
Use the same link to ctlseqs.html
Dec 23 2019, 3:41 AM
hindenburg committed R319:77ce8f6a334e: Use entity for ASCII (authored by hindenburg).
Use entity for ASCII
Dec 23 2019, 3:33 AM
hindenburg committed R319:74e227184e15: Remove unused method masters (authored by hindenburg).
Remove unused method masters
Dec 23 2019, 3:29 AM
hindenburg committed R319:259a11c9f597: Remove unused method writeSelectionToStream (authored by hindenburg).
Remove unused method writeSelectionToStream
Dec 23 2019, 2:58 AM
hindenburg committed R319:4572ecd2b1ee: Mark method as const (authored by hindenburg).
Mark method as const
Dec 23 2019, 12:02 AM

Dec 22 2019

hindenburg committed R319:19f65ed7b3c1: Sync method parameter names (authored by hindenburg).
Sync method parameter names
Dec 22 2019, 7:38 PM
hindenburg committed R319:55f14ca3dbbf: Remove unused methods shortcuts and findByShortcut (authored by hindenburg).
Remove unused methods shortcuts and findByShortcut
Dec 22 2019, 7:04 PM
hindenburg committed R319:cf260af00bb4: Remove unused variable (authored by hindenburg).
Remove unused variable
Dec 22 2019, 5:08 PM

Dec 18 2019

hindenburg committed R319:b439309b8e9f: Remove phabricator's arcconfig file (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Remove phabricator's arcconfig file
Dec 18 2019, 2:36 AM
hindenburg committed R319:e5e50b913bd8: Remove phabricator's arcconfig file (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Remove phabricator's arcconfig file
Dec 18 2019, 2:13 AM
hindenburg committed R319:52d2720007bb: Revert "GIT_SILENT: minor qstring optimization" (authored by mglb).
Revert "GIT_SILENT: minor qstring optimization"
Dec 18 2019, 2:08 AM
hindenburg added a reverting change for R319:f96deb39aacc: GIT_SILENT: minor qstring optimization: R319:52d2720007bb: Revert "GIT_SILENT: minor qstring optimization".
Dec 18 2019, 2:08 AM

Dec 12 2019

hindenburg committed R319:2251d55857c9: ColorScheme: fix stack-use-after-scope detected by ASAN (authored by mglb).
ColorScheme: fix stack-use-after-scope detected by ASAN
Dec 12 2019, 2:06 PM

Dec 6 2019

hindenburg added a comment to D16138: Create the default profile if it doesn't exist.

What's the ping? Should Konsole ship a default profile? and if so which one? or fix this code?

Dec 6 2019, 1:27 AM · Konsole

Dec 4 2019

hindenburg committed R319:931a12d22272: Add QT_NO_FOREACH now that we do not use any foreach (authored by hindenburg).
Add QT_NO_FOREACH now that we do not use any foreach
Dec 4 2019, 3:02 AM
hindenburg committed R319:e6f3d0a14e4f: Replace Q_DECL_OVERRIDE with override (authored by nicolasfella).
Replace Q_DECL_OVERRIDE with override
Dec 4 2019, 2:55 AM

Nov 25 2019

hindenburg committed R319:30f64c8a2133: Fix loop anaylysis issue (authored by hindenburg).
Fix loop anaylysis issue
Nov 25 2019, 1:00 AM
hindenburg committed R319:fc14f277c26c: Fix implicit conversion increases floating-point precision (authored by hindenburg).
Fix implicit conversion increases floating-point precision
Nov 25 2019, 12:44 AM
hindenburg committed R319:9bc892eff0dd: Paste urls of local files as a list of quoted strings (authored by ahmadsamir).
Paste urls of local files as a list of quoted strings
Nov 25 2019, 12:11 AM

Nov 22 2019

hindenburg added a comment to D21055: Highlight lines coming into view when scrolling.

You can use phabricator for now if that works for you - setting up a merge request https://invent.kde.org/kde/konsole/merge_requests would also work. Until phabricator is removed, it is up to you which patch is easier to maintain.

Nov 22 2019, 2:52 PM · Konsole
hindenburg committed R319:59ff5d37301a: Correctly trigger a Konsole window when using single process (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Correctly trigger a Konsole window when using single process
Nov 22 2019, 2:47 PM

Nov 10 2019

hindenburg added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

After this patch, you'd need to add -DENABLE_CCACHE=TRUE to enable ccache - I don't really see this as a big hurdle and 19.12 is around the corner so I'd like some consensus here.

Nov 10 2019, 12:57 AM · Konsole

Nov 7 2019

hindenburg committed R319:69a8a99d15ee: Fix tabs not indicating activity (authored by velan).
Fix tabs not indicating activity
Nov 7 2019, 3:08 PM
hindenburg closed D25151: Fix tabs not indicating activity.
Nov 7 2019, 3:08 PM · Konsole
hindenburg accepted D25151: Fix tabs not indicating activity.

I see it in line above, but using qobject_cast and not checking for nullptr is waste of time, say if you're sure in type use static_cast, if not check result of qobject_cast against nullptr.

Nov 7 2019, 3:05 PM · Konsole
hindenburg added a comment to D25151: Fix tabs not indicating activity.

Sorry I didn't see your changes before I did mine.

Nov 7 2019, 2:35 PM · Konsole
hindenburg updated the test plan for D25151: Fix tabs not indicating activity.
Nov 7 2019, 2:14 PM · Konsole

Nov 2 2019

hindenburg added a comment to D20466: Rework scrollback settings.

What's the status of this?

Nov 2 2019, 4:23 PM · Konsole
hindenburg committed R319:324d78c07fc4: Fix OSC sequence parsing (authored by mglb).
Fix OSC sequence parsing
Nov 2 2019, 4:10 PM
hindenburg committed R319:0deb808bbb94: Use uint for ucs4 characters (authored by mglb).
Use uint for ucs4 characters
Nov 2 2019, 4:10 PM