hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (222 w, 6 d)
Availability
Available

Recent Activity

Yesterday

hindenburg committed R319:2251d55857c9: ColorScheme: fix stack-use-after-scope detected by ASAN (authored by mglb).
ColorScheme: fix stack-use-after-scope detected by ASAN
Thu, Dec 12, 2:06 PM

Fri, Dec 6

hindenburg added a comment to D16138: Create the default profile if it doesn't exist.

What's the ping? Should Konsole ship a default profile? and if so which one? or fix this code?

Fri, Dec 6, 1:27 AM · Konsole

Wed, Dec 4

hindenburg committed R319:931a12d22272: Add QT_NO_FOREACH now that we do not use any foreach (authored by hindenburg).
Add QT_NO_FOREACH now that we do not use any foreach
Wed, Dec 4, 3:02 AM
hindenburg committed R319:e6f3d0a14e4f: Replace Q_DECL_OVERRIDE with override (authored by nicolasfella).
Replace Q_DECL_OVERRIDE with override
Wed, Dec 4, 2:55 AM

Mon, Nov 25

hindenburg committed R319:30f64c8a2133: Fix loop anaylysis issue (authored by hindenburg).
Fix loop anaylysis issue
Mon, Nov 25, 1:00 AM
hindenburg committed R319:fc14f277c26c: Fix implicit conversion increases floating-point precision (authored by hindenburg).
Fix implicit conversion increases floating-point precision
Mon, Nov 25, 12:44 AM
hindenburg committed R319:9bc892eff0dd: Paste urls of local files as a list of quoted strings (authored by ahmadsamir).
Paste urls of local files as a list of quoted strings
Mon, Nov 25, 12:11 AM

Fri, Nov 22

hindenburg added a comment to D21055: Highlight lines coming into view when scrolling.

You can use phabricator for now if that works for you - setting up a merge request https://invent.kde.org/kde/konsole/merge_requests would also work. Until phabricator is removed, it is up to you which patch is easier to maintain.

Fri, Nov 22, 2:52 PM · Konsole
hindenburg committed R319:59ff5d37301a: Correctly trigger a Konsole window when using single process (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Correctly trigger a Konsole window when using single process
Fri, Nov 22, 2:47 PM

Nov 10 2019

hindenburg added a comment to D24805: Add ENABLE_CCACHE option (default=off).

After this patch, you'd need to add -DENABLE_CCACHE=TRUE to enable ccache - I don't really see this as a big hurdle and 19.12 is around the corner so I'd like some consensus here.

Nov 10 2019, 12:57 AM · Konsole

Nov 7 2019

hindenburg committed R319:69a8a99d15ee: Fix tabs not indicating activity (authored by velan).
Fix tabs not indicating activity
Nov 7 2019, 3:08 PM
hindenburg closed D25151: Fix tabs not indicating activity.
Nov 7 2019, 3:08 PM · Konsole
hindenburg accepted D25151: Fix tabs not indicating activity.

I see it in line above, but using qobject_cast and not checking for nullptr is waste of time, say if you're sure in type use static_cast, if not check result of qobject_cast against nullptr.

Nov 7 2019, 3:05 PM · Konsole
hindenburg added a comment to D25151: Fix tabs not indicating activity.

Sorry I didn't see your changes before I did mine.

Nov 7 2019, 2:35 PM · Konsole
hindenburg updated the test plan for D25151: Fix tabs not indicating activity.
Nov 7 2019, 2:14 PM · Konsole

Nov 2 2019

hindenburg added a comment to D20466: Rework scrollback settings.

What's the status of this?

Nov 2 2019, 4:23 PM · Konsole
hindenburg committed R319:324d78c07fc4: Fix OSC sequence parsing (authored by mglb).
Fix OSC sequence parsing
Nov 2 2019, 4:10 PM
hindenburg committed R319:0deb808bbb94: Use uint for ucs4 characters (authored by mglb).
Use uint for ucs4 characters
Nov 2 2019, 4:10 PM
hindenburg added a comment to D21203: Accessibility improvements.

Are you still working on this or would you like this committed for 19.12?

Nov 2 2019, 3:19 PM · Konsole
hindenburg committed R319:bbdf27cc9fee: Add missing setFocusProxy() call in ViewManager (authored by alexmi).
Add missing setFocusProxy() call in ViewManager
Nov 2 2019, 3:18 PM
hindenburg closed D25001: Add missing setFocusProxy() call in ViewManager.
Nov 2 2019, 3:17 PM · Konsole
hindenburg accepted D25001: Add missing setFocusProxy() call in ViewManager.
Nov 2 2019, 3:17 PM · Konsole

Oct 28 2019

hindenburg committed R319:f9a5763dc6bc: Add TODO about obsolete setWorldMatrix (authored by hindenburg).
Add TODO about obsolete setWorldMatrix
Oct 28 2019, 2:05 PM
hindenburg added a comment to D25001: Add missing setFocusProxy() call in ViewManager.

Thanks, I'll test shortly

Oct 28 2019, 1:45 PM · Konsole
hindenburg committed R319:d5f45993f9ae: Port obsoleted QDrag->start() to exec() (authored by hindenburg).
Port obsoleted QDrag->start() to exec()
Oct 28 2019, 1:43 PM
hindenburg committed R319:538f5bc1d3f7: Port depreciated KRun::binaryName (authored by hindenburg).
Port depreciated KRun::binaryName
Oct 28 2019, 3:38 AM

Oct 24 2019

hindenburg committed R319:8851933bc840: Use qCDebug() (authored by hindenburg).
Use qCDebug()
Oct 24 2019, 2:17 PM
hindenburg committed R319:472524355bd0: Use QFile::encodeName() (authored by hindenburg).
Use QFile::encodeName()
Oct 24 2019, 1:29 PM
hindenburg committed R319:98854d3032b5: Fix search bar placement (authored by mglb).
Fix search bar placement
Oct 24 2019, 1:26 AM
hindenburg committed R319:8d049d7ef4f1: Move search bar positioning code to TerminalDisplay (authored by mglb).
Move search bar positioning code to TerminalDisplay
Oct 24 2019, 1:26 AM
hindenburg committed R319:ee430fc4b8c6: Debug: print path to history files in /proc/pid/fd/ (authored by mglb).
Debug: print path to history files in /proc/pid/fd/
Oct 24 2019, 1:04 AM
hindenburg committed R319:0f19efa5b27c: unlink() history file after opening it (authored by mglb).
unlink() history file after opening it
Oct 24 2019, 1:04 AM
hindenburg committed R319:1da01df0692b: Remove unused argument from history-related classes (authored by mglb).
Remove unused argument from history-related classes
Oct 24 2019, 1:04 AM

Oct 20 2019

hindenburg committed R159:196b04531764: tests: fix macos build failure (authored by hindenburg).
tests: fix macos build failure
Oct 20 2019, 11:56 PM
hindenburg closed D24811: tests: fix macos build failure.
Oct 20 2019, 11:56 PM · Frameworks
hindenburg requested review of D24811: tests: fix macos build failure.
Oct 20 2019, 6:52 PM · Frameworks

Oct 17 2019

hindenburg committed R319:77ce0888d82e: Fix scrollbar position (authored by mglb).
Fix scrollbar position
Oct 17 2019, 12:50 AM

Oct 8 2019

hindenburg committed R319:2455faf68aaf: Add a "Do not ask again" option to close session dialog (authored by hindenburg).
Add a "Do not ask again" option to close session dialog
Oct 8 2019, 2:57 PM

Oct 6 2019

hindenburg committed R319:1561f6203bbf: Allow loading of pre 19.08 session files (authored by jpalecek).
Allow loading of pre 19.08 session files
Oct 6 2019, 2:34 PM
hindenburg committed R319:2de43394c983: Allow loading of pre 19.08 session files (authored by jpalecek).
Allow loading of pre 19.08 session files
Oct 6 2019, 2:32 PM

Oct 5 2019

hindenburg committed R935:a1f7e3147e50: Add 19.12 changelog; unreleased ATM (authored by hindenburg).
Add 19.12 changelog; unreleased ATM
Oct 5 2019, 10:41 PM
hindenburg committed R935:c887996d38c5: Add 19.08 changelog (authored by hindenburg).
Add 19.08 changelog
Oct 5 2019, 10:25 PM
hindenburg committed R319:67a29e4134ff: Keep empty lines when "trim leading spaces" is enabled (authored by mglb).
Keep empty lines when "trim leading spaces" is enabled
Oct 5 2019, 9:13 PM

Oct 3 2019

hindenburg committed R319:b9d2cd668bc0: Correct split view and keyboard navigation (authored by hindenburg).
Correct split view and keyboard navigation
Oct 3 2019, 4:55 PM
hindenburg committed R319:ba84640a7bd8: Fix split view crashes when using keyboard navigation with some themes (authored by hindenburg).
Fix split view crashes when using keyboard navigation with some themes
Oct 3 2019, 4:55 PM
hindenburg committed R319:64cc52754baa: Make sure font weight value is within allowed range (authored by mglb).
Make sure font weight value is within allowed range
Oct 3 2019, 4:55 PM
hindenburg committed R319:b27c8e7fd3b0: Correct split view and keyboard navigation (authored by hindenburg).
Correct split view and keyboard navigation
Oct 3 2019, 2:21 PM

Oct 2 2019

hindenburg committed R319:63ef8872bfc4: Fix split view crashes when using keyboard navigation with some themes (authored by hindenburg).
Fix split view crashes when using keyboard navigation with some themes
Oct 2 2019, 3:55 PM

Sep 27 2019

hindenburg committed R319:9e3a30fdca20: Remove env variable KONSOLE_PROFILE_NAME (authored by hindenburg).
Remove env variable KONSOLE_PROFILE_NAME
Sep 27 2019, 2:31 AM
hindenburg committed R319:05f5663a9010: Add dbus profile() to return profile name of current session (authored by hindenburg).
Add dbus profile() to return profile name of current session
Sep 27 2019, 2:31 AM

Sep 9 2019

hindenburg added inline comments to D20115: Re enable move tab left / right via keyboard shortcuts.
Sep 9 2019, 2:06 PM · Konsole

Sep 6 2019

hindenburg committed R319:bccb702d962c: Fix cmake endif() mis-matching arguments (authored by hindenburg).
Fix cmake endif() mis-matching arguments
Sep 6 2019, 12:14 PM

Sep 2 2019

hindenburg committed R319:1df621390e82: Fix the fallback code used when restoring session fails (authored by jpalecek).
Fix the fallback code used when restoring session fails
Sep 2 2019, 1:26 PM
hindenburg added a comment to D23601: Fix the fallback code used when restoring session fails.

On the 19.08 branch I get a lot of these when exiting a konsole session that uses this code. I don't see this warning on master.

Sep 2 2019, 12:58 AM · Konsole

Sep 1 2019

hindenburg committed R319:656f6804ea2c: Fix the fallback code used when restoring session fails (authored by jpalecek).
Fix the fallback code used when restoring session fails
Sep 1 2019, 10:47 PM
hindenburg closed D23601: Fix the fallback code used when restoring session fails.
Sep 1 2019, 10:47 PM · Konsole
hindenburg updated the test plan for D23601: Fix the fallback code used when restoring session fails.
Sep 1 2019, 10:31 PM · Konsole
hindenburg accepted D23601: Fix the fallback code used when restoring session fails.

Thanks, I'll look at the other patch shortly. This regression should have been caught in my testing.

Sep 1 2019, 10:30 PM · Konsole
hindenburg updated the test plan for D23601: Fix the fallback code used when restoring session fails.
Sep 1 2019, 10:29 PM · Konsole
hindenburg added a comment to D23601: Fix the fallback code used when restoring session fails.

This looks fine - I'll test the restore patch

Sep 1 2019, 9:22 PM · Konsole
hindenburg added a reviewer for D23601: Fix the fallback code used when restoring session fails: Konsole.
Sep 1 2019, 9:12 PM · Konsole
hindenburg accepted D23636: Add icons to desktop file actions.

thanks makes sense

Sep 1 2019, 9:00 PM · Konsole
hindenburg committed R319:158bbf5cdf31: clean up includes - remove KIO::Job (authored by hindenburg).
clean up includes - remove KIO::Job
Sep 1 2019, 3:45 PM
hindenburg committed R319:d8dc0dbf4a19: It is not obvious toUcs4 returns QVector<uint> so remove auto (authored by hindenburg).
It is not obvious toUcs4 returns QVector<uint> so remove auto
Sep 1 2019, 3:34 PM
hindenburg committed R319:eb96410ffdfd: clean up includes (authored by hindenburg).
clean up includes
Sep 1 2019, 3:34 PM
hindenburg committed R319:3db90bbf70ab: Merge branch 'konstantink/konsole-remove-deprecated-qcopy' (authored by hindenburg).
Merge branch 'konstantink/konsole-remove-deprecated-qcopy'
Sep 1 2019, 2:14 PM
hindenburg added a comment to D20263: Keep perceived contrast in random background color.

FYI, these are showing up in the builds

https://build.kde.org/job/Applications/job/konsole/job/kf5-qt5%20SUSEQt5.12/lastSuccessfulBuild/warnings30Result/

ColorScheme.cpp:314, GNU Make + GNU C Compiler (gcc), Priority: Normal

assignment from temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]

ColorScheme.cpp:316, GNU Make + GNU C Compiler (gcc), Priority: Normal

assignment from temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]

Sep 1 2019, 1:56 PM · VDG, Konsole

Aug 30 2019

hindenburg committed R319:ed44f288c2d2: Add scrollbuttons for tabs when tabbar is full (authored by Yap Sok Ann <sokann@gmail.com>).
Add scrollbuttons for tabs when tabbar is full
Aug 30 2019, 12:59 AM
hindenburg committed R319:f79ee976fb9c: Add scrollbuttons for tabs when tabbar is full (authored by Yap Sok Ann <sokann@gmail.com>).
Add scrollbuttons for tabs when tabbar is full
Aug 30 2019, 12:45 AM

Aug 29 2019

hindenburg committed R319:dd2c940cc7da: fix memory leaks (coverity) (authored by hindenburg).
fix memory leaks (coverity)
Aug 29 2019, 12:47 PM
hindenburg committed R319:8040bb2678fc: fix memory leak (coverity) (authored by hindenburg).
fix memory leak (coverity)
Aug 29 2019, 2:39 AM

Aug 28 2019

hindenburg committed R319:9c19368ce555: Remove leading/trailingWhitespace() - they were never used (authored by hindenburg).
Remove leading/trailingWhitespace() - they were never used
Aug 28 2019, 3:09 PM
hindenburg committed R319:d0ae59834896: Remove currentBookmarkList() - hasn't been used in years (authored by hindenburg).
Remove currentBookmarkList() - hasn't been used in years
Aug 28 2019, 2:26 PM
hindenburg committed R319:0995c1dc95bb: Remove supportsTabs() - hasn't been used in years (authored by hindenburg).
Remove supportsTabs() - hasn't been used in years
Aug 28 2019, 2:08 PM
hindenburg committed R319:ec1c08c4ed86: hotSpotsAtLine() has not been used in years (authored by hindenburg).
hotSpotsAtLine() has not been used in years
Aug 28 2019, 1:57 PM
hindenburg committed R319:2339f20ccafb: config-konsole.h is not installed; krazy has been fixed (authored by hindenburg).
config-konsole.h is not installed; krazy has been fixed
Aug 28 2019, 12:49 PM
hindenburg committed R319:8ce959ab6cf9: Use QThread::sleep instead of sleep/usleep (authored by hindenburg).
Use QThread::sleep instead of sleep/usleep
Aug 28 2019, 3:12 AM
hindenburg committed R319:490f174c2242: Correct parameter's names (authored by hindenburg).
Correct parameter's names
Aug 28 2019, 2:53 AM
hindenburg committed R319:3b4f835ebbc6: Initialize variable in constructor (coverity/cppcheck) (authored by hindenburg).
Initialize variable in constructor (coverity/cppcheck)
Aug 28 2019, 1:58 AM
hindenburg committed R319:f121ecd24a3d: Use std::any_of instead of loop (authored by hindenburg).
Use std::any_of instead of loop
Aug 28 2019, 1:43 AM

Aug 25 2019

hindenburg committed R319:6f0a83284c22: Make the layout better (authored by hindenburg).
Make the layout better
Aug 25 2019, 6:32 PM
hindenburg committed R319:f780383096c1: Restore "Show 'new tab' button" option in Konsole Settings (authored by hindenburg).
Restore "Show 'new tab' button" option in Konsole Settings
Aug 25 2019, 4:07 PM
hindenburg committed R319:616f5554b11b: Restore "Show 'new tab' button" option in Konsole Settings (authored by mglb).
Restore "Show 'new tab' button" option in Konsole Settings
Aug 25 2019, 2:19 PM

Aug 24 2019

hindenburg added a comment to D22243: Add Breeze Light and Chrome color schemes.

How's this going?

Aug 24 2019, 7:51 PM · Konsole
hindenburg committed R319:1852b6bae73e: Add note about duplicates in sub-folders (authored by hindenburg).
Add note about duplicates in sub-folders
Aug 24 2019, 7:14 PM
hindenburg committed R319:befaaa0255b2: Do not allow adding duplicates in bookmarks (authored by sandsmark).
Do not allow adding duplicates in bookmarks
Aug 24 2019, 7:14 PM
hindenburg committed R319:230463105624: Correct parameter documentation (authored by hindenburg).
Correct parameter documentation
Aug 24 2019, 6:22 PM
hindenburg committed R319:a7303156f251: use 'using' instead of 'typedef' (authored by hindenburg).
use 'using' instead of 'typedef'
Aug 24 2019, 6:22 PM
hindenburg committed R319:a4818f0b8e2d: avoid repeating the return type; use a braced initializer list instead (authored by hindenburg).
avoid repeating the return type; use a braced initializer list instead
Aug 24 2019, 6:22 PM

Aug 23 2019

hindenburg added a comment to D20263: Keep perceived contrast in random background color.

FYI, these are showing up in the builds

Aug 23 2019, 1:46 PM · VDG, Konsole
hindenburg committed R319:6943a31745c1: Explicitly add data type s/unsigned/unsigned int/ (authored by hindenburg).
Explicitly add data type s/unsigned/unsigned int/
Aug 23 2019, 12:53 PM
hindenburg committed R319:08931fbd335a: Tweak tab title options: home and Bourne prompt sigils (authored by rrosch).
Tweak tab title options: home and Bourne prompt sigils
Aug 23 2019, 12:50 PM

Aug 22 2019

hindenburg committed R319:9a37e0b265d1: Correct include guard name (authored by hindenburg).
Correct include guard name
Aug 22 2019, 2:51 PM

Aug 20 2019

hindenburg committed R319:eb57ab7cdbdf: hsluv add copyright emails - taken from their github repos (authored by hindenburg).
hsluv add copyright emails - taken from their github repos
Aug 20 2019, 2:15 AM

Aug 18 2019

hindenburg added a comment to D23246: Fix crash on "Close Current Tab" handling.

if possible, use https://invent.kde.org/kde/konsole/merge_requests instead of phrabicator. I don't mind using phrabicator while it is still up abut I often forget to amend the author.

Aug 18 2019, 9:38 PM · Konsole
hindenburg committed R319:3c25aafdbaf7: Fix crash on "Close Current Tab" handling (authored by AndreyYashkin).
Fix crash on "Close Current Tab" handling
Aug 18 2019, 9:36 PM
hindenburg committed R319:82bca348c270: Merge branch 'konstantink/konsole-small-cleanup' (authored by hindenburg).
Merge branch 'konstantink/konsole-small-cleanup'
Aug 18 2019, 9:24 PM
hindenburg committed R319:62a5f1d7947d: Fix crash on "Close Current Tab" handling (authored by hindenburg).
Fix crash on "Close Current Tab" handling
Aug 18 2019, 9:00 PM
hindenburg closed D23246: Fix crash on "Close Current Tab" handling.
Aug 18 2019, 9:00 PM · Konsole
hindenburg accepted D23246: Fix crash on "Close Current Tab" handling.

Thanks a lot for fixing this - please don't add // italic/bold to commit messages as it messes up what shows up in the logs

Aug 18 2019, 8:49 PM · Konsole