hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (145 w, 4 d)
Availability
Available

Recent Activity

Today

hindenburg added a comment to D13620: fix potential crash.

I recall this now - I wonder if this is still try 9+ years later. If we revert, let's at least add a comment about this issue in the code

Wed, Jun 20, 12:26 AM · Konsole

Sun, Jun 17

hindenburg added a comment to D13582: ScrollBar overlay theme aware..

I'm unable to get the non-overlay to show up after changing to use non breeze themes like Oxygen, Air.

Sun, Jun 17, 4:20 PM · Konsole
hindenburg added reviewers for D13579: apply blur to windows using Konsole as KPart: Konsole, hindenburg.
Sun, Jun 17, 11:35 AM · Konsole
hindenburg committed R319:b2d90711a207: Only consider startDragDistance for drag-n-drop tabs (authored by hindenburg).
Only consider startDragDistance for drag-n-drop tabs
Sun, Jun 17, 3:06 AM
hindenburg committed R319:420821b29a86: Expose profile switching through d-bus (authored by michaeleden).
Expose profile switching through d-bus
Sun, Jun 17, 2:34 AM
hindenburg closed D13486: Expose profile switching through d-bus.
Sun, Jun 17, 2:34 AM · Konsole
hindenburg accepted D13486: Expose profile switching through d-bus.
Sun, Jun 17, 2:34 AM · Konsole
hindenburg updated the test plan for D13486: Expose profile switching through d-bus.
Sun, Jun 17, 2:30 AM · Konsole
hindenburg accepted D13512: Cleanup IncrementalSearchBar.
Sun, Jun 17, 1:58 AM · Konsole

Sat, Jun 16

hindenburg accepted D13532: Code cleanup on the Profile Settings.

Looks fine - go ahead and commit when you want

Sat, Jun 16, 7:30 PM · Konsole
hindenburg committed R319:5c0a5fd496e9: Simplify saveShortcuts and saveFavorites (authored by tcanabrava).
Simplify saveShortcuts and saveFavorites
Sat, Jun 16, 6:26 PM
hindenburg closed D13539: Simplify saveShortcuts and saveFavorites.
Sat, Jun 16, 6:26 PM · Konsole
hindenburg accepted D13539: Simplify saveShortcuts and saveFavorites.

Thanks, if there's only one commit I'll go ahead and land them.

Sat, Jun 16, 6:26 PM · Konsole
hindenburg committed R319:05f2469c1a00: Show the scrollbar only when needed (authored by anemeth).
Show the scrollbar only when needed
Sat, Jun 16, 6:09 PM
hindenburg closed D11843: Show the scrollbar only when needed.
Sat, Jun 16, 6:09 PM · Konsole
hindenburg accepted D11843: Show the scrollbar only when needed.

Thanks

Sat, Jun 16, 6:09 PM · Konsole

Fri, Jun 15

hindenburg added a comment to D13557: Set the scrollbar style transparent background.

It appears this makes the scrollbar wider; was that expected?

Fri, Jun 15, 1:42 PM · Konsole
hindenburg added a comment to D11843: Show the scrollbar only when needed.

Can you rebase this please?

Fri, Jun 15, 1:18 AM · Konsole
hindenburg committed R319:f4c73346d0cc: Treat scrollBar as overlay (authored by tcanabrava).
Treat scrollBar as overlay
Fri, Jun 15, 1:05 AM
hindenburg committed R319:81e80ba41fe9: Treat scrollbar as overlay (authored by tcanabrava).
Treat scrollbar as overlay
Fri, Jun 15, 1:05 AM
hindenburg closed D13543: Treat scrollbar as overlay.
Fri, Jun 15, 1:05 AM · Konsole
hindenburg accepted D13543: Treat scrollbar as overlay.
Fri, Jun 15, 1:05 AM · Konsole
hindenburg updated the summary of D13543: Treat scrollbar as overlay.
Fri, Jun 15, 12:54 AM · Konsole
hindenburg committed R319:7c1fd8d71fab: Simplify: Use locals instead of pointers (authored by tcanabrava).
Simplify: Use locals instead of pointers
Fri, Jun 15, 12:46 AM
hindenburg closed D13538: Simplify: Use locals instead of pointers.
Fri, Jun 15, 12:46 AM · Konsole
hindenburg accepted D13538: Simplify: Use locals instead of pointers.
Fri, Jun 15, 12:46 AM · Konsole

Thu, Jun 14

hindenburg committed R319:e1f7107cc0b4: Simplify code dealing with creating new sessions. (authored by tcanabrava).
Simplify code dealing with creating new sessions.
Thu, Jun 14, 2:39 PM
hindenburg closed D12968: Simplify code dealing with creating new sessions..
Thu, Jun 14, 2:39 PM · Konsole
hindenburg accepted D12968: Simplify code dealing with creating new sessions..
Thu, Jun 14, 2:39 PM · Konsole
hindenburg updated the summary of D12968: Simplify code dealing with creating new sessions..
Thu, Jun 14, 2:28 PM · Konsole
hindenburg added a comment to D13511: Remove SearchBar from the MainWindowOverview.

This looks really good.

Thu, Jun 14, 1:45 PM · Konsole
hindenburg added a comment to D12968: Simplify code dealing with creating new sessions..

and window->createSession calls ViewManager::newSession that calls
session->addEnvironmentEntry(QStringLiteral("KONSOLE_DBUS_WINDOW=/Windows/%1").arg(managerId()));

that's the reason I said it's strange that the KONSOLE_DBUS_WINDOW is not set, as the only codepoint that I can follow always sets it.

Thu, Jun 14, 1:13 PM · Konsole
hindenburg committed R319:68ddd7b97824: simplify isProfileDeletable (authored by tcanabrava).
simplify isProfileDeletable
Thu, Jun 14, 12:57 PM
hindenburg closed D13516: simplify isProfileDeletable.
Thu, Jun 14, 12:57 PM · Konsole
hindenburg updated the summary of D13511: Remove SearchBar from the MainWindowOverview.
Thu, Jun 14, 12:53 PM · Konsole
hindenburg added a comment to D12968: Simplify code dealing with creating new sessions..
> Having a Konsole open and then logging off your desktop; when you log back in, the Konsole should be restored

I found the code that deals with that:

void restoreSession(Application &app)
{
    int n = 1;
    while (KMainWindow::canBeRestored(n)) {
        app.newMainWindow()->restore(n++);
    }
}

Application::newMainWindow, it calls this

Thu, Jun 14, 12:40 PM · Konsole
hindenburg accepted D13516: simplify isProfileDeletable.
Thu, Jun 14, 12:31 PM · Konsole

Wed, Jun 13

hindenburg added a comment to D13516: simplify isProfileDeletable.

Thanks, we put {} around all "if" for consistency and following KDE's style

Wed, Jun 13, 2:33 PM · Konsole
hindenburg added a comment to D12968: Simplify code dealing with creating new sessions..
Wed, Jun 13, 2:03 PM · Konsole
hindenburg added a comment to D12968: Simplify code dealing with creating new sessions..

Ok, haven't found any regressions. The below item should be fixed later as I didn't realize it before.

Wed, Jun 13, 11:40 AM · Konsole

Tue, Jun 12

hindenburg added a comment to D13486: Expose profile switching through d-bus.

Thanks, I'll look at this shortly

Tue, Jun 12, 2:08 AM · Konsole

Sun, Jun 10

hindenburg added a comment to D13174: New layout for the search bar..

If the tab detached had search enabled, the search will be disabled and you need to search again
^ This could be fixed at a later point.

Sun, Jun 10, 12:36 AM · Konsole
hindenburg committed R319:f084dbfbeeb4: Remove unnecessary forward-calls (authored by tcanabrava).
Remove unnecessary forward-calls
Sun, Jun 10, 12:12 AM
hindenburg closed D12967: Remove unnecessary forward-calls.
Sun, Jun 10, 12:12 AM · Konsole
hindenburg accepted D12967: Remove unnecessary forward-calls.
Sun, Jun 10, 12:12 AM · Konsole
hindenburg retitled D12967: Remove unnecessary forward-calls from Remove unecessary forward-calls to Remove unnecessary forward-calls.
Sun, Jun 10, 12:11 AM · Konsole

Sat, Jun 9

hindenburg added inline comments to D12968: Simplify code dealing with creating new sessions..
Sat, Jun 9, 11:10 PM · Konsole
hindenburg added a comment to D13429: Remove calls that are only forward calling.

These are for use via dbus; example: qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW defaultProfile

Sat, Jun 9, 11:04 PM · Konsole
hindenburg committed R319:547745d7ab98: Simplify if-logic (authored by tcanabrava).
Simplify if-logic
Sat, Jun 9, 10:58 PM
hindenburg closed D13432: Simplify if-logic.
Sat, Jun 9, 10:58 PM · Konsole
hindenburg accepted D13432: Simplify if-logic.
Sat, Jun 9, 10:58 PM · Konsole
hindenburg committed R319:8c7d05f3a7cf: De duplicate setContainerFeatures (authored by tcanabrava).
De duplicate setContainerFeatures
Sat, Jun 9, 10:47 PM
hindenburg closed D13428: De duplicate setContainerFeatures.
Sat, Jun 9, 10:47 PM · Konsole
hindenburg accepted D13428: De duplicate setContainerFeatures.
Sat, Jun 9, 10:47 PM · Konsole
hindenburg committed R319:e15c57e3fa90: Simplify Apply Profile to View (authored by tcanabrava).
Simplify Apply Profile to View
Sat, Jun 9, 10:27 PM
hindenburg closed D13430: Simplify Apply Profile to View.
Sat, Jun 9, 10:27 PM · Konsole
hindenburg accepted D13430: Simplify Apply Profile to View.

Thanks much cleaner

Sat, Jun 9, 10:25 PM · Konsole
hindenburg committed R319:5a3bfc649729: Simplify calls using a lambda (authored by tcanabrava).
Simplify calls using a lambda
Sat, Jun 9, 7:12 PM
hindenburg closed D13431: Simplify calls using a lambda.
Sat, Jun 9, 7:12 PM · Konsole
hindenburg accepted D13431: Simplify calls using a lambda.
Sat, Jun 9, 7:08 PM · Konsole

Fri, Jun 8

hindenburg committed R319:6ca007fcb326: Correctly list the open programs when trying to quit (authored by tcanabrava).
Correctly list the open programs when trying to quit
Fri, Jun 8, 3:10 AM
hindenburg closed D13364: Correctly list the open programs when trying to quit.
Fri, Jun 8, 3:10 AM · Konsole
hindenburg updated the summary of D13364: Correctly list the open programs when trying to quit.
Fri, Jun 8, 3:05 AM · Konsole
hindenburg accepted D13364: Correctly list the open programs when trying to quit.

Nice, thanks

Fri, Jun 8, 3:02 AM · Konsole

Thu, Jun 7

hindenburg added a comment to D13174: New layout for the search bar..

Thanks, can you update the title and commit message at some point.

Thu, Jun 7, 3:06 PM · Konsole
hindenburg committed R319:85ee52b10fc5: Use Q_ASSERT to catch null pointers for _sessionController and session() (authored by ahmadsamir).
Use Q_ASSERT to catch null pointers for _sessionController and session()
Thu, Jun 7, 2:51 PM
hindenburg closed D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Thu, Jun 7, 2:51 PM · Konsole
hindenburg accepted D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Thu, Jun 7, 2:49 PM · Konsole

Wed, Jun 6

hindenburg added a comment to D13363: Don't rely on a layout for the initial resize.

This ignores the profile's terminal size settings; it is not as easy to set the size to 1/2 width by 1/2 height

Wed, Jun 6, 12:33 PM · Konsole
hindenburg added inline comments to D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Wed, Jun 6, 12:13 PM · Konsole
hindenburg committed R319:f9a26694865a: Fix block selection mode in a couple of cases (authored by ahmadsamir).
Fix block selection mode in a couple of cases
Wed, Jun 6, 11:51 AM
hindenburg closed D13356: Fix block selection mode in a couple of cases.
Wed, Jun 6, 11:51 AM · Konsole
hindenburg accepted D13356: Fix block selection mode in a couple of cases.

Thanks

Wed, Jun 6, 11:50 AM · Konsole

Tue, Jun 5

hindenburg added inline comments to D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Tue, Jun 5, 12:17 PM · Konsole

Sat, Jun 2

hindenburg added a comment to D13174: New layout for the search bar..

This is a great first attempt - thanks - I'll test it out - I agree likely it needs a frame around it.

Sat, Jun 2, 3:14 AM · Konsole
hindenburg added inline comments to D13271: Use Q_ASSERT to catch null pointers for _sessionController and session().
Sat, Jun 2, 3:07 AM · Konsole

Fri, Jun 1

hindenburg committed R319:41b0b20a1946: Only consider startDragDistance for drag-n-drop tabs (authored by hindenburg).
Only consider startDragDistance for drag-n-drop tabs
Fri, Jun 1, 1:06 PM
hindenburg committed R319:5a47df158d53: Move isPrimaryScreen() to Session (authored by ahmadsamir).
Move isPrimaryScreen() to Session
Fri, Jun 1, 12:49 PM
hindenburg closed D13217: Move isPrimaryScreen() to Session.
Fri, Jun 1, 12:49 PM · Konsole
hindenburg accepted D13217: Move isPrimaryScreen() to Session.
Fri, Jun 1, 12:42 PM · Konsole
hindenburg added a comment to D7451: Dragging tabs in konsole lags.

Thanks for the reminder - I meant to look at this earlier

Fri, Jun 1, 3:10 AM · Konsole
hindenburg added a comment to D13217: Move isPrimaryScreen() to Session.

OK thanks, using 'man man' did not work for me but yes vim file did work in the testing.

Fri, Jun 1, 2:57 AM · Konsole

Thu, May 31

hindenburg added a comment to D13217: Move isPrimaryScreen() to Session.

Thanks- I'll test it more later

Thu, May 31, 2:57 AM · Konsole
hindenburg updated the summary of D13217: Move isPrimaryScreen() to Session.
Thu, May 31, 2:55 AM · Konsole

Wed, May 30

hindenburg added a comment to D13174: New layout for the search bar..

Ok that'd be great - I never got around to working on it - I was thinking of a lineedit, perhaps up/down arrows and a "gear" drop down menu w/ the options.

Wed, May 30, 1:17 PM · Konsole
hindenburg added a comment to D7068: Add switch to alternate tab action.

Thanks for the patch; sorry for not replying sooner. I'm not sure what the best name for this feature would be. I'll look at the code when I have time.

Wed, May 30, 4:11 AM · Konsole
hindenburg abandoned D10939: KeyboardTranslator: Accept non-alpha-numeric keys.

A slightly different patch was committed for 18.08; regardless, thanks for the patch

Wed, May 30, 4:02 AM · Konsole
hindenburg commandeered D10939: KeyboardTranslator: Accept non-alpha-numeric keys.
Wed, May 30, 4:01 AM · Konsole
hindenburg added a comment to D12968: Simplify code dealing with creating new sessions..

I like the removal of duplicated code; however something still not correct. If you have konsole debug turned on and run konsole from another term you can see "org.kde.konsole: Attempted to re-run an already running session ( 28261 )" which should not be there. Briefly looking at the code, ViewManager::newSession has session->run() which is the removed code does not.

Wed, May 30, 3:56 AM · Konsole
hindenburg added a comment to D13174: New layout for the search bar..

On a side note, I've always disliked the searching in Konsole since the bar changes the terminal height. I thought a floating smaller widget (like in Chrome) would be better.

Wed, May 30, 3:31 AM · Konsole
hindenburg committed R319:03b0026e2025: Remove default edge to getCharacterPosition() (authored by hindenburg).
Remove default edge to getCharacterPosition()
Wed, May 30, 12:51 AM
hindenburg committed R319:8f02c3ed9b9c: Fix mouse coords for programs interested with it (authored by mbeniamino).
Fix mouse coords for programs interested with it
Wed, May 30, 12:47 AM
hindenburg closed D13089: Fix mouse coords for programs interested with it.
Wed, May 30, 12:47 AM · Konsole
hindenburg accepted D13089: Fix mouse coords for programs interested with it.

Thanks

Wed, May 30, 12:43 AM · Konsole

Tue, May 29

hindenburg updated the summary of D13089: Fix mouse coords for programs interested with it.
Tue, May 29, 12:30 PM · Konsole

Mon, May 28

hindenburg added a comment to D13089: Fix mouse coords for programs interested with it.

Do you have time to rebase and change these to !_usesMouseTracking? If not, I can do it.

Mon, May 28, 6:48 PM · Konsole
hindenburg added a comment to D13089: Fix mouse coords for programs interested with it.

Can you try to use arcanist for patches? Once you have it setup, it should help. Currently your patches don't have the author set. I can work around it until you get is working.

Mon, May 28, 6:10 PM · Konsole
hindenburg committed R319:033e20319f76: Replace setUserTitle() with setSessionAttribute() (authored by ahmadsamir).
Replace setUserTitle() with setSessionAttribute()
Mon, May 28, 6:07 PM
hindenburg closed D13147: Replace setUserTitle() with setSessionAttribute().
Mon, May 28, 6:07 PM · Konsole
hindenburg accepted D13147: Replace setUserTitle() with setSessionAttribute().

Thanks looks fine

Mon, May 28, 6:07 PM · Konsole