hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (170 w, 4 d)
Availability
Available

Recent Activity

Today

hindenburg added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

I don't really know how to test this in the embedded terminal in Kate for example. Could someone provide some guidance ?

Wed, Dec 12, 2:29 AM · Konsole
hindenburg committed R319:f2fab9a26a32: Add missing emit keyword (authored by tcanabrava).
Add missing emit keyword
Wed, Dec 12, 2:23 AM
hindenburg closed D17506: Add missing emit keyword.
Wed, Dec 12, 2:23 AM · Konsole
hindenburg accepted D17506: Add missing emit keyword.

thanks

Wed, Dec 12, 2:21 AM · Konsole
hindenburg added a comment to D17492: Be explicit on what the ViewContainer accepts.

I'll see if I find anything after testing

Wed, Dec 12, 2:14 AM · Konsole

Yesterday

hindenburg added a comment to D17267: Don't duplicate the tabs when Spliting the View.

ViewContainer.cpp:133:44: warning: Missing emit keyword on signal call Konsole::TabbedViewContainer::newViewWithProfileRequest

Tue, Dec 11, 2:34 PM · Konsole
hindenburg committed R319:9ff0d4602169: Revert "Re-add DBusTest to verify if build ci move to Qt5.10 fixes this issue" (authored by hindenburg).
Revert "Re-add DBusTest to verify if build ci move to Qt5.10 fixes this issue"
Tue, Dec 11, 2:24 PM
hindenburg added a reverting change for R319:d679f19f4143: Re-add DBusTest to verify if build ci move to Qt5.10 fixes this issue: R319:9ff0d4602169: Revert "Re-add DBusTest to verify if build ci move to Qt5.10 fixes this issue".
Tue, Dec 11, 2:24 PM
hindenburg committed R319:d679f19f4143: Re-add DBusTest to verify if build ci move to Qt5.10 fixes this issue (authored by hindenburg).
Re-add DBusTest to verify if build ci move to Qt5.10 fixes this issue
Tue, Dec 11, 1:58 PM
hindenburg committed R319:d1e18d9dda39: Remove three classes form the SessionController header/source (authored by tcanabrava).
Remove three classes form the SessionController header/source
Tue, Dec 11, 1:53 PM
hindenburg closed D17485: Remove three classes form the SessionController header/source.
Tue, Dec 11, 1:53 PM · Konsole
hindenburg accepted D17485: Remove three classes form the SessionController header/source.
Tue, Dec 11, 1:53 PM · Konsole

Mon, Dec 10

hindenburg committed R319:c2a08bf35e15: Fix condition to redraw search result line (authored by thsurrel).
Fix condition to redraw search result line
Mon, Dec 10, 3:24 PM
hindenburg committed R319:f193805dde59: Fix condition to redraw search result line (authored by thsurrel).
Fix condition to redraw search result line
Mon, Dec 10, 3:23 PM
hindenburg closed D17471: Fix condition to redraw search result line.
Mon, Dec 10, 3:23 PM · Konsole
hindenburg accepted D17471: Fix condition to redraw search result line.

Nice catch thanks

Mon, Dec 10, 3:22 PM · Konsole
hindenburg committed R319:e7085310d6d5: fix cursor when anti aliasing is enabled (authored by sandsmark).
fix cursor when anti aliasing is enabled
Mon, Dec 10, 3:14 PM
hindenburg closed D17414: fix cursor when anti aliasing is enabled.
Mon, Dec 10, 3:14 PM · Konsole
hindenburg accepted D17414: fix cursor when anti aliasing is enabled.
Mon, Dec 10, 3:13 PM · Konsole
hindenburg updated the summary of D17414: fix cursor when anti aliasing is enabled.
Mon, Dec 10, 3:09 PM · Konsole
hindenburg committed R319:7a43e3b2cde0: Don't duplicate the tabs when Spliting the View (authored by tcanabrava).
Don't duplicate the tabs when Spliting the View
Mon, Dec 10, 3:02 PM
hindenburg closed D17267: Don't duplicate the tabs when Spliting the View.
Mon, Dec 10, 3:02 PM · Konsole
hindenburg accepted D17267: Don't duplicate the tabs when Spliting the View.
Mon, Dec 10, 3:01 PM · Konsole
hindenburg committed R319:d39d51973a34: Add special support for block characters (authored by sandsmark).
Add special support for block characters
Mon, Dec 10, 12:24 AM
hindenburg closed D17294: Add special support for block characters.
Mon, Dec 10, 12:24 AM · Konsole
hindenburg accepted D17294: Add special support for block characters.

Thanks

Mon, Dec 10, 12:23 AM · Konsole
hindenburg added a comment to D17267: Don't duplicate the tabs when Spliting the View.

This is really good - I noticed that once you detach/close views, the menus View->Close/Expand/Shrink are still active (they don't do anything when selected).

Mon, Dec 10, 12:11 AM · Konsole
hindenburg updated the summary of D17267: Don't duplicate the tabs when Spliting the View.
Mon, Dec 10, 12:10 AM · Konsole

Sat, Dec 8

hindenburg added a comment to D17267: Don't duplicate the tabs when Spliting the View.

I've noticed a few issues

  1. detach split tabs maintain the same size (ie not the full window) but the size the tab was - is this expected behavior?
  2. close one side of the view causing the menus to not have all the menus until switching tabs
  3. opening a new tab on the non-focus side will not update the tab text (ie should be "src:zsh", it is ":" until you click on tab).
Sat, Dec 8, 5:16 PM · Konsole

Fri, Dec 7

hindenburg updated the summary of D17267: Don't duplicate the tabs when Spliting the View.
Fri, Dec 7, 3:35 PM · Konsole
hindenburg added inline comments to D17294: Add special support for block characters.
Fri, Dec 7, 3:26 PM · Konsole

Thu, Dec 6

hindenburg updated the summary of D17294: Add special support for block characters.
Thu, Dec 6, 3:49 PM · Konsole
hindenburg committed R319:14b3c8be2c15: fix drawing box chars, avoid storing and saving state all the time (authored by sandsmark).
fix drawing box chars, avoid storing and saving state all the time
Thu, Dec 6, 3:27 PM
hindenburg closed D16947: fix drawing box chars, avoid storing and saving state all the time.
Thu, Dec 6, 3:27 PM · Konsole
hindenburg accepted D16947: fix drawing box chars, avoid storing and saving state all the time.
Thu, Dec 6, 3:26 PM · Konsole
hindenburg updated the summary of D16947: fix drawing box chars, avoid storing and saving state all the time.
Thu, Dec 6, 3:08 PM · Konsole

Wed, Dec 5

hindenburg added a comment to D17267: Don't duplicate the tabs when Spliting the View.

Ok let me look at this - I notice if you double-click on an empty spot in the non-focused view's tabbar, the new tab is created in the focused view. Which is a bit confusing.

Wed, Dec 5, 2:52 PM · Konsole
hindenburg added a reviewer for D17267: Don't duplicate the tabs when Spliting the View: Konsole.

w/o the Konsole reviewer, it doesn't show up on https://phabricator.kde.org/project/37/item/view/637/ which is what I use

Wed, Dec 5, 2:38 PM · Konsole
hindenburg added a comment to D16947: fix drawing box chars, avoid storing and saving state all the time.

OK so this is for when 'Use Line characters contained in in Font' is disabled. I see a big improvement then.

Wed, Dec 5, 2:30 PM · Konsole
hindenburg committed R319:e7a945741937: Fix crash when changing from blinking cursor to block cursor (authored by hindenburg).
Fix crash when changing from blinking cursor to block cursor
Wed, Dec 5, 2:24 PM
hindenburg closed D17264: Fix crash when changing from blinking cursor to block cursor.
Wed, Dec 5, 2:24 PM · Konsole
hindenburg accepted D17264: Fix crash when changing from blinking cursor to block cursor.
Wed, Dec 5, 2:23 PM · Konsole
hindenburg updated the summary of D17264: Fix crash when changing from blinking cursor to block cursor.
Wed, Dec 5, 2:23 PM · Konsole
hindenburg committed R319:633eb056fece: Simplify/Speedup reading Stylesheet file (authored by tcanabrava).
Simplify/Speedup reading Stylesheet file
Wed, Dec 5, 2:09 PM
hindenburg closed D17329: Simplify/Speedup reading Stylesheet file.
Wed, Dec 5, 2:09 PM · Konsole
hindenburg accepted D17329: Simplify/Speedup reading Stylesheet file.

Of course thanks

Wed, Dec 5, 2:08 PM · Konsole

Tue, Dec 4

hindenburg added a comment to D17244: Edit Profile Dialog UI redesign.

Wow, that's impressive. Thanks a lot for working on this - let me look at it further.

Tue, Dec 4, 2:02 AM · Konsole
hindenburg added a comment to D17329: Simplify/Speedup reading Stylesheet file.

Ok, I think I/someone read the docs and did it that way from the start - I wonder what the Qt docs thinks is a large file.

Tue, Dec 4, 1:49 AM · Konsole

Sun, Dec 2

hindenburg added a comment to D17264: Fix crash when changing from blinking cursor to block cursor.

same issue here - can you fix?

Sun, Dec 2, 5:54 PM · Konsole
hindenburg added a comment to D16947: fix drawing box chars, avoid storing and saving state all the time.

The arc patch is moving files - can you re-upload?

Sun, Dec 2, 4:44 PM · Konsole
hindenburg committed R319:534d070602e0: Profile::ReverseUrlHints is a bool not an int (authored by hindenburg).
Profile::ReverseUrlHints is a bool not an int
Sun, Dec 2, 3:49 PM
hindenburg committed R319:20f1b968ba85: fix readability-implicit-bool-cast issues (authored by hindenburg).
fix readability-implicit-bool-cast issues
Sun, Dec 2, 3:49 PM

Sat, Dec 1

hindenburg added a comment to D16947: fix drawing box chars, avoid storing and saving state all the time.

Ok if you want - I thought you might be still working on it

Sat, Dec 1, 1:22 AM · Konsole

Fri, Nov 30

hindenburg committed R319:0709fdcbb535: Add Ctrl-Tab to switch tabs in chronological order (authored by thsurrel).
Add Ctrl-Tab to switch tabs in chronological order
Fri, Nov 30, 2:12 PM
hindenburg closed D16884: Add Ctrl-Tab to switch tabs in chronological order.
Fri, Nov 30, 2:12 PM · Konsole
hindenburg accepted D16884: Add Ctrl-Tab to switch tabs in chronological order.

Looks fine - thanks

Fri, Nov 30, 2:12 PM · Konsole
hindenburg committed R319:4e83457c06a1: Don't hide setFont, it's not virtual (authored by tcanabrava).
Don't hide setFont, it's not virtual
Fri, Nov 30, 1:43 PM
hindenburg closed D17221: Don't hide setFont, it's not virtual.
Fri, Nov 30, 1:43 PM · Konsole
hindenburg accepted D17221: Don't hide setFont, it's not virtual.
Fri, Nov 30, 1:43 PM · Konsole
hindenburg committed R319:6e715d8c4f72: Remove virtual for non-virtual calls (authored by tcanabrava).
Remove virtual for non-virtual calls
Fri, Nov 30, 1:40 PM
hindenburg closed D17222: Remove virtual for non-virtual calls.
Fri, Nov 30, 1:40 PM · Konsole
hindenburg accepted D17222: Remove virtual for non-virtual calls.
Fri, Nov 30, 1:40 PM · Konsole

Thu, Nov 29

hindenburg added reviewers for D17221: Don't hide setFont, it's not virtual: Konsole, hindenburg.
Thu, Nov 29, 3:21 PM · Konsole
hindenburg added reviewers for D17222: Remove virtual for non-virtual calls: Konsole, hindenburg.
Thu, Nov 29, 3:21 PM · Konsole

Sun, Nov 25

hindenburg added a comment to D16919: Re-add DBus test.

Yes, I was actually surprised I managed to get it all to run. Are there official docs on how to setup an ci image and run applications? If not, it would be helpful.

Sun, Nov 25, 4:15 PM · Konsole

Sat, Nov 24

hindenburg added a comment to D16919: Re-add DBus test.

Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results.
Did you run "make tests" / "ctest" or did you use the run-tests.py script to execute the unit tests?

Sat, Nov 24, 1:14 AM · Konsole

Fri, Nov 23

hindenburg added a comment to D16919: Re-add DBus test.

When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself?

Fri, Nov 23, 2:00 PM · Konsole

Thu, Nov 22

hindenburg added a comment to D16919: Re-add DBus test.

I manage to build the docker kdeorg/ci-suse-qt59 image - and of course the tests pass - so I'm not sure how to help now. I've already disabled this test again to avoid the sysadmins having more work to do.

Thu, Nov 22, 7:07 PM · Konsole
hindenburg committed R319:d2dd767e464d: Fix ASAN issue for determining if running in a KPart (authored by hindenburg).
Fix ASAN issue for determining if running in a KPart
Thu, Nov 22, 4:05 PM
hindenburg committed R319:bf71cb54ac4a: Fix ASAN issue for determining if running in a KPart (authored by hindenburg).
Fix ASAN issue for determining if running in a KPart
Thu, Nov 22, 4:00 PM
hindenburg committed R319:25ec27819055: Allow small colour changes when varying dark backgrounds (authored by EspadaV8).
Allow small colour changes when varying dark backgrounds
Thu, Nov 22, 3:14 PM
hindenburg committed R319:72368b71e29a: Allow small colour changes when varying dark backgrounds (authored by EspadaV8).
Allow small colour changes when varying dark backgrounds
Thu, Nov 22, 3:13 PM
hindenburg closed D17045: Allow small colour changes when varying dark backgrounds.
Thu, Nov 22, 3:13 PM · Konsole
hindenburg accepted D17045: Allow small colour changes when varying dark backgrounds.

Thanks

Thu, Nov 22, 3:12 PM · Konsole
hindenburg updated the test plan for D17045: Allow small colour changes when varying dark backgrounds.
Thu, Nov 22, 3:10 PM · Konsole
hindenburg committed R319:d1e5296ef4e4: Remove option to hide application name from titlebar (authored by EspadaV8).
Remove option to hide application name from titlebar
Thu, Nov 22, 3:06 PM
hindenburg closed D17049: Remove option to hide application name from titlebar.
Thu, Nov 22, 3:06 PM · Konsole
hindenburg accepted D17049: Remove option to hide application name from titlebar.
Thu, Nov 22, 3:05 PM · Konsole
hindenburg updated the summary of D17049: Remove option to hide application name from titlebar.
Thu, Nov 22, 3:01 PM · Konsole
hindenburg updated the test plan for D17049: Remove option to hide application name from titlebar.
Thu, Nov 22, 2:59 PM · Konsole
hindenburg added a comment to D16837: Persist after closing last tab when running in background mode.

@ngraham Is there anyway to progress this and to decide if this change (or something like it) could be merged into Konsole? I spoke briefly with @hein on the #kde-devel channel on IRC and they didn't see any reason why Yakuake features couldn't be merged into Konsole itself (just that no one has done it before). They did mention that they'd like to see the Konsole KPart functionality improved but I'm not in a position to be able to know exactly what would need to be done to implement those changes.

If this revision isn't okay then I'd be happy to make any suggestions that you have to help get these features directly into Konsole.

Thu, Nov 22, 2:44 PM · Konsole
hindenburg added a comment to D16706: Hide tabbar in KParts.

This throws ASAN errors

Thu, Nov 22, 3:29 AM · Konsole

Tue, Nov 20

hindenburg added a comment to D17045: Allow small colour changes when varying dark backgrounds.

The change appears to be so slight as to be unnoticeable. Only when I change the 48 to 148 can I actually see changes. I would suggest following up on your comment about not just checking for pure black and then also make the change noticeable.

Tue, Nov 20, 2:26 PM · Konsole
hindenburg added a comment to D17047: Use correct icon in Edit Profile settings panel.

I think the icons are correct as-is, though their may be some other issue w/ the themes as detailed in the bug report. The 'Initial Dir' is asking for a folder so folder-open seems correct. The "User user-defined stylesheet' is asking for a file so the document-open seems OK.

Tue, Nov 20, 2:00 PM · Konsole
hindenburg committed R319:8adad74f2d75: Disable DBusTest temporarily due to buildbot issue (authored by hindenburg).
Disable DBusTest temporarily due to buildbot issue
Tue, Nov 20, 1:40 PM
hindenburg added a comment to D16947: fix drawing box chars, avoid storing and saving state all the time.

OK the boxes look better w/ patch regardless

Tue, Nov 20, 1:39 PM · Konsole
hindenburg updated the summary of D16947: fix drawing box chars, avoid storing and saving state all the time.
Tue, Nov 20, 12:52 AM · Konsole

Fri, Nov 16

hindenburg added a comment to D16919: Re-add DBus test.

yea - feel free to commit any changes related to this yourself if you want.

Fri, Nov 16, 3:36 PM · Konsole
hindenburg committed R319:c25b70944beb: set variable in initialize list and explictly use bool in if (authored by hindenburg).
set variable in initialize list and explictly use bool in if
Fri, Nov 16, 2:59 PM
hindenburg committed R319:2754e08ff23f: Fix search result highlight when scrolling (authored by thsurrel).
Fix search result highlight when scrolling
Fri, Nov 16, 2:59 PM
hindenburg committed R319:3eb9a34f62c8: Re-add DBus test (authored by davidedmundson).
Re-add DBus test
Fri, Nov 16, 2:58 PM
hindenburg closed D16919: Re-add DBus test.
Fri, Nov 16, 2:58 PM · Konsole
hindenburg accepted D16919: Re-add DBus test.

Thanks so much for looking into this.

Fri, Nov 16, 2:58 PM · Konsole

Tue, Nov 13

hindenburg committed R319:dd03c26ad1a7: set variable in initialize list and explictly use bool in if (authored by hindenburg).
set variable in initialize list and explictly use bool in if
Tue, Nov 13, 2:03 AM
hindenburg committed R319:3fc9fab788cb: Fix search result highlight when scrolling (authored by thsurrel).
Fix search result highlight when scrolling
Tue, Nov 13, 1:46 AM
hindenburg closed D16820: Fix search result highlight when scrolling.
Tue, Nov 13, 1:46 AM · Konsole
hindenburg accepted D16820: Fix search result highlight when scrolling.
Tue, Nov 13, 1:45 AM · Konsole

Nov 11 2018

hindenburg added inline comments to D16820: Fix search result highlight when scrolling.
Nov 11 2018, 5:27 PM · Konsole
hindenburg committed R319:274214f445c3: Add three missing tests for tokens (authored by hindenburg).
Add three missing tests for tokens
Nov 11 2018, 4:34 PM
hindenburg committed R319:930594bf9446: Add StartupWMClass to .desktop file (authored by hallas).
Add StartupWMClass to .desktop file
Nov 11 2018, 3:43 PM