hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (206 w, 5 d)
Availability
Available

Recent Activity

Today

hindenburg committed R319:9a37e0b265d1: Correct include guard name (authored by hindenburg).
Correct include guard name
Thu, Aug 22, 2:51 PM

Tue, Aug 20

hindenburg committed R319:eb57ab7cdbdf: hsluv add copyright emails - taken from their github repos (authored by hindenburg).
hsluv add copyright emails - taken from their github repos
Tue, Aug 20, 2:15 AM

Sun, Aug 18

hindenburg added a comment to D23246: Fix crash on "Close Current Tab" handling.

if possible, use https://invent.kde.org/kde/konsole/merge_requests instead of phrabicator. I don't mind using phrabicator while it is still up abut I often forget to amend the author.

Sun, Aug 18, 9:38 PM · Konsole
hindenburg committed R319:3c25aafdbaf7: Fix crash on "Close Current Tab" handling (authored by AndreyYashkin).
Fix crash on "Close Current Tab" handling
Sun, Aug 18, 9:36 PM
hindenburg committed R319:82bca348c270: Merge branch 'konstantink/konsole-small-cleanup' (authored by hindenburg).
Merge branch 'konstantink/konsole-small-cleanup'
Sun, Aug 18, 9:24 PM
hindenburg committed R319:62a5f1d7947d: Fix crash on "Close Current Tab" handling (authored by hindenburg).
Fix crash on "Close Current Tab" handling
Sun, Aug 18, 9:00 PM
hindenburg closed D23246: Fix crash on "Close Current Tab" handling.
Sun, Aug 18, 9:00 PM · Konsole
hindenburg accepted D23246: Fix crash on "Close Current Tab" handling.

Thanks a lot for fixing this - please don't add // italic/bold to commit messages as it messes up what shows up in the logs

Sun, Aug 18, 8:49 PM · Konsole
hindenburg updated the test plan for D23246: Fix crash on "Close Current Tab" handling.
Sun, Aug 18, 8:48 PM · Konsole
hindenburg updated the summary of D23246: Fix crash on "Close Current Tab" handling.
Sun, Aug 18, 8:47 PM · Konsole

Sat, Aug 17

hindenburg committed R319:dc29be39a640: Keep perceived contrast in random background color (authored by mglb).
Keep perceived contrast in random background color
Sat, Aug 17, 8:09 PM
hindenburg closed D20263: Keep perceived contrast in random background color.
Sat, Aug 17, 8:09 PM · VDG, Konsole
hindenburg accepted D20263: Keep perceived contrast in random background color.

thanks for sticking w/ this

Sat, Aug 17, 8:08 PM · VDG, Konsole
hindenburg added inline comments to D20263: Keep perceived contrast in random background color.
Sat, Aug 17, 5:33 PM · VDG, Konsole
hindenburg added a comment to D20263: Keep perceived contrast in random background color.

I don't see any issues testing so far - minor issue obseloteKeys is misspelled

Sat, Aug 17, 3:47 PM · VDG, Konsole
hindenburg committed R319:74a01214229d: Add note about depreciated width() (authored by hindenburg).
Add note about depreciated width()
Sat, Aug 17, 3:04 PM
hindenburg committed R319:9baecd741766: Merge branch 'arcpatch-D23144' (authored by hindenburg).
Merge branch 'arcpatch-D23144'
Sat, Aug 17, 2:34 PM
hindenburg committed R319:6a064319629d: Port from QFontMetrics::width() to boundingRect().width() (authored by gladhorn).
Port from QFontMetrics::width() to boundingRect().width()
Sat, Aug 17, 2:25 PM
hindenburg closed D23144: Port from QFontMetrics::width() to boundingRect().width().
Sat, Aug 17, 2:25 PM · Konsole
hindenburg accepted D23144: Port from QFontMetrics::width() to boundingRect().width().

I agree thanks

Sat, Aug 17, 2:23 PM · Konsole

Fri, Aug 16

hindenburg added a comment to D23144: Port from QFontMetrics::width() to boundingRect().width().
Fri, Aug 16, 4:20 PM · Konsole
hindenburg committed R319:83ea331675c1: Merge branch 'arcpatch-D23143' (authored by hindenburg).
Merge branch 'arcpatch-D23143'
Fri, Aug 16, 4:09 PM
hindenburg committed R319:6029f813f711: Use QCommandLineOption::HiddenFromHelp instead of deprecated API (authored by gladhorn).
Use QCommandLineOption::HiddenFromHelp instead of deprecated API
Fri, Aug 16, 4:09 PM
hindenburg closed D23143: Use QCommandLineOption::HiddenFromHelp instead of deprecated API.
Fri, Aug 16, 4:09 PM · Konsole
hindenburg accepted D23143: Use QCommandLineOption::HiddenFromHelp instead of deprecated API.

Thanks

Fri, Aug 16, 4:08 PM · Konsole
hindenburg added a comment to D20263: Keep perceived contrast in random background color.

Ok, those can be done later IMHO - any objection to committing this now?

Fri, Aug 16, 4:00 PM · VDG, Konsole
hindenburg committed R319:276a6dca6602: In confirm close dialog, remove 'close current tab' option (authored by AndreyYashkin).
In confirm close dialog, remove 'close current tab' option
Fri, Aug 16, 3:55 PM
hindenburg closed D23146: In confirm close dialog, remove 'close current tab' option.
Fri, Aug 16, 3:55 PM · Konsole
hindenburg accepted D23146: In confirm close dialog, remove 'close current tab' option.

thanks

Fri, Aug 16, 3:46 PM · Konsole
hindenburg updated the test plan for D23146: In confirm close dialog, remove 'close current tab' option.
Fri, Aug 16, 3:41 PM · Konsole
hindenburg committed R319:420266f7e918: Move enabling dbus sendText/runCommand to 'Configure Konsole' dialog (authored by hindenburg).
Move enabling dbus sendText/runCommand to 'Configure Konsole' dialog
Fri, Aug 16, 3:25 PM

Thu, Aug 8

hindenburg added a comment to D22980: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde.

Thanks you very much!

That said, I'm still curious on the answer, because it might be useful to know for the next time I gonna contribute.

Thu, Aug 8, 12:28 AM · Konsole

Wed, Aug 7

hindenburg committed R319:f8f7b43936b7: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde (authored by hiangel).
Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde
Wed, Aug 7, 2:31 PM
hindenburg committed R319:0107e68e22d3: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde (authored by hiangel).
Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde
Wed, Aug 7, 2:26 PM
hindenburg closed D22980: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde.
Wed, Aug 7, 2:26 PM · Konsole
hindenburg added a comment to D22980: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde.

This looks fine to me and fixes the issue.

Wed, Aug 7, 1:26 AM · Konsole
hindenburg committed R319:a49332e5537d: Do not allow 'Close Current Tab" to crash (authored by hindenburg).
Do not allow 'Close Current Tab" to crash
Wed, Aug 7, 12:55 AM
hindenburg added reviewers for D22980: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde: Konsole, hindenburg.

Thanks putting this here is fine for now

Wed, Aug 7, 12:54 AM · Konsole

Tue, Aug 6

hindenburg committed R319:ac9ccc948321: Merge branch 'mglebocki/konsole-Mark-intended-int-division-in-double-context' (authored by hindenburg).
Merge branch 'mglebocki/konsole-Mark-intended-int-division-in-double-context'
Tue, Aug 6, 2:19 AM
hindenburg committed R319:a8d152f11e8c: Merge branch 'mglebocki/konsole-Split-tab-bar-configuration-into-tabs' (authored by hindenburg).
Merge branch 'mglebocki/konsole-Split-tab-bar-configuration-into-tabs'
Tue, Aug 6, 2:07 AM
hindenburg committed R319:a3ec064f2f2a: Fix dbus newSession() three methods to work (authored by hindenburg).
Fix dbus newSession() three methods to work
Tue, Aug 6, 12:24 AM
hindenburg committed R319:b23a7c2e4dcc: Remove accelerators from tabs when pressing ALT (authored by hindenburg).
Remove accelerators from tabs when pressing ALT
Tue, Aug 6, 12:24 AM

Mon, Aug 5

hindenburg committed R319:3824de3e4f07: Fix dbus newSession() three methods to work (authored by hindenburg).
Fix dbus newSession() three methods to work
Mon, Aug 5, 2:14 PM
hindenburg committed R319:841397f3b0a7: Remove accelerators from tabs when pressing ALT (authored by hindenburg).
Remove accelerators from tabs when pressing ALT
Mon, Aug 5, 1:44 PM

Jul 23 2019

hindenburg added a comment to D20816: Configure Konsole dialog GUI redesign.

Note that on a 800x600 screen, the 'Configure Konsole' dialog is too big - the 'Tab Bar' page is too long. I typically have tried to keep the dialogs usable in 800x600 screens.

Jul 23 2019, 2:33 PM · VDG, Konsole
hindenburg added a comment to D20263: Keep perceived contrast in random background color.

What's the status of this? Still a WIP? I'm fine w/ adding it to Konsole; the other schemes could be adjusted to use this later correct?

Jul 23 2019, 2:11 PM · VDG, Konsole

Jul 20 2019

hindenburg committed R319:e78ebd521c03: Add/fix KUIT context marker (authored by hindenburg).
Add/fix KUIT context marker
Jul 20 2019, 7:13 PM
hindenburg committed R319:597ffa6a5e89: Mark constructor explicit (authored by hindenburg).
Mark constructor explicit
Jul 20 2019, 7:13 PM
hindenburg committed R319:9eac29b10cc7: Add KUIT context marker (authored by hindenburg).
Add KUIT context marker
Jul 20 2019, 7:13 PM
hindenburg committed R319:6faf8b5b614a: Fix initial terminal size (authored by mglb).
Fix initial terminal size
Jul 20 2019, 7:10 PM

Jul 18 2019

hindenburg committed R319:2162f2711bba: Fix void-const-params-in-decls issue (authored by hindenburg).
Fix void-const-params-in-decls issue
Jul 18 2019, 12:58 AM
hindenburg committed R319:dcb846719dfb: Fix implicit-bool-conversion issues (authored by hindenburg).
Fix implicit-bool-conversion issues
Jul 18 2019, 12:43 AM

Jul 17 2019

hindenburg committed R319:7fd3e37dfdf1: Fix braces-around-statements issues (authored by hindenburg).
Fix braces-around-statements issues
Jul 17 2019, 3:11 PM
hindenburg committed R319:26fa79607474: Use empty() instead of size() for emptiness (authored by hindenburg).
Use empty() instead of size() for emptiness
Jul 17 2019, 3:11 PM
hindenburg committed R319:2c0fb16d3ccb: Fix unnecessary-copy-initialization (authored by hindenburg).
Fix unnecessary-copy-initialization
Jul 17 2019, 2:39 PM
hindenburg committed R319:6969afb8ef73: Fix unnecessary-value-param (authored by hindenburg).
Fix unnecessary-value-param
Jul 17 2019, 2:39 PM
hindenburg committed R319:799fb461907a: Use modernize-return-braced-init-list (authored by hindenburg).
Use modernize-return-braced-init-list
Jul 17 2019, 2:39 PM
hindenburg committed R319:2043b03e5119: Use auto to avoid duplicating the type name (authored by hindenburg).
Use auto to avoid duplicating the type name
Jul 17 2019, 2:39 PM
hindenburg committed R319:ccc4c2eee62e: Fix readability-implicit-bool-conversion issues (authored by hindenburg).
Fix readability-implicit-bool-conversion issues
Jul 17 2019, 1:01 AM

Jul 16 2019

hindenburg committed R319:397a99d03092: Add krazy excludeall for copyright and license - simple test script (authored by hindenburg).
Add krazy excludeall for copyright and license - simple test script
Jul 16 2019, 1:46 AM
hindenburg committed R319:e605cd4b4329: Add/fix KUIT context marker (authored by hindenburg).
Add/fix KUIT context marker
Jul 16 2019, 1:46 AM
hindenburg committed R319:c8ad9ec5ae62: Add KUIT context marker (authored by hindenburg).
Add KUIT context marker
Jul 16 2019, 12:22 AM
hindenburg committed R319:b3073651071d: Mark constructor explicit (authored by hindenburg).
Mark constructor explicit
Jul 16 2019, 12:22 AM

Jul 15 2019

hindenburg committed R319:fca4ece1d89d: Comment spelling fix (authored by hindenburg).
Comment spelling fix
Jul 15 2019, 3:12 PM
hindenburg committed R319:7018f269d30f: Comment spelling fix (authored by hindenburg).
Comment spelling fix
Jul 15 2019, 3:12 PM
hindenburg committed R319:b75d99edbb0c: Remove duplicate include (authored by hindenburg).
Remove duplicate include
Jul 15 2019, 3:12 PM
hindenburg committed R319:bbc4f4c080c9: action:tooltip is not valid, change to info:tooltip (authored by hindenburg).
action:tooltip is not valid, change to info:tooltip
Jul 15 2019, 3:12 PM

Jul 12 2019

hindenburg committed R319:00b1edb245fc: Adjust text since profile shortcuts now create new tabs (authored by hindenburg).
Adjust text since profile shortcuts now create new tabs
Jul 12 2019, 2:41 AM
hindenburg committed R319:2aa158fcd02a: Add missing emit (authored by hindenburg).
Add missing emit
Jul 12 2019, 2:39 AM
hindenburg committed R319:433b8ec984bc: Correct function documentation (authored by hindenburg).
Correct function documentation
Jul 12 2019, 2:39 AM
hindenburg committed R319:d93b8cad396a: Remove unused variable (authored by hindenburg).
Remove unused variable
Jul 12 2019, 2:39 AM
hindenburg committed R319:103ba229f83a: Use Q_UNUSED() (authored by hindenburg).
Use Q_UNUSED()
Jul 12 2019, 2:39 AM

Jul 10 2019

hindenburg added a comment to D22243: Add Breeze Light and Chrome color schemes.

@hindenburg
are

Opacity=1
 Wallpaper=

also the defaults that could be removed from color schemes?

Jul 10 2019, 12:26 AM · Konsole

Jul 7 2019

hindenburg added a comment to D22243: Add Breeze Light and Chrome color schemes.

Blur=false is the default so you don't need it.

Jul 7 2019, 11:23 PM · Konsole
hindenburg added a comment to D22243: Add Breeze Light and Chrome color schemes.

I'll add the BreezeLight one - you also have to add the files to CMakeLists.txt

Jul 7 2019, 11:15 PM · Konsole
hindenburg committed R319:a1b64d795648: Revert "Profile shortcuts switch profile instead of opening new tab" (authored by hindenburg).
Revert "Profile shortcuts switch profile instead of opening new tab"
Jul 7 2019, 11:07 PM
hindenburg added a reverting change for R319:d689ba5403ce: Profile shortcuts switch profile instead of opening new tab: R319:a1b64d795648: Revert "Profile shortcuts switch profile instead of opening new tab".
Jul 7 2019, 11:07 PM
hindenburg closed D22291: Fix display sometimes randomly scrolling down.

Thanks, already merged - we can still use phabricator for simple request if people have it already setup.

Jul 7 2019, 10:46 PM · Konsole

Jul 3 2019

hindenburg added a comment to T11133: Decide on the icon to use for konsole.kde.org.

I"m fine w/ the Breeze icon; if/when they update the icon we can change it again.

Jul 3 2019, 9:18 PM · Konsole

Jul 2 2019

hindenburg committed R319:fb8890c1ac20: Merge branch 'gitlab/drag_drop_terminal_split' into 'master' (authored by hindenburg).
Merge branch 'gitlab/drag_drop_terminal_split' into 'master'
Jul 2 2019, 3:17 PM
hindenburg committed R319:2fd8cef01bd1: Implement Drag & Drop for Tiling Operations (authored by tcanabrava).
Implement Drag & Drop for Tiling Operations
Jul 2 2019, 3:17 PM

Jul 1 2019

hindenburg committed R319:01e23151f19f: Run DBusTest if we are not running under jenkins (authored by hindenburg).
Run DBusTest if we are not running under jenkins
Jul 1 2019, 11:58 PM
hindenburg committed R319:09b4aebdae3e: Add test if we are running tests under jenkins (authored by hindenburg).
Add test if we are running tests under jenkins
Jul 1 2019, 11:48 PM
hindenburg committed R319:7d52678a94a1: Skip some tests when on MACOS (authored by hindenburg).
Skip some tests when on MACOS
Jul 1 2019, 11:23 PM
hindenburg committed R319:8aa33a3d134c: Try to use the build konsolepart for tests. (authored by hindenburg).
Try to use the build konsolepart for tests.
Jul 1 2019, 11:01 PM
hindenburg committed R319:44bc4d7fe881: Try to use the build konsolepart for tests. (authored by hindenburg).
Try to use the build konsolepart for tests.
Jul 1 2019, 10:44 PM
hindenburg committed R319:ae55654433f3: Mark all tests nongui (authored by hindenburg).
Mark all tests nongui
Jul 1 2019, 10:24 PM
hindenburg added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

Running the command would be a step that needs fixed when switching profiles regardless. However, I think we need the option to have shortcuts open new profile tabs. I had plans to try to work on it this week and if I can't find something revert it for 19.08.

Jul 1 2019, 10:12 PM · Konsole

Jun 26 2019

hindenburg committed R319:68ea9bf6cc11: Merge branch 'gitlab/fix-shortcuts-for-only-one-tab' into 'master' (authored by hindenburg).
Merge branch 'gitlab/fix-shortcuts-for-only-one-tab' into 'master'
Jun 26 2019, 1:23 AM
hindenburg added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

If I can't find a good way to re-do this by July 13th, I'm going to revert this.

Jun 26 2019, 12:57 AM · Konsole

Jun 22 2019

hindenburg added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

Anyone have anything to say about Thiago's comment? There's now only one shortcut to open a new tab.

Jun 22 2019, 2:45 AM · Konsole

Jun 17 2019

hindenburg committed R319:f95a46f58084: Variables for column/row are switched for Profile-Initial Terminal Size (authored by marten).
Variables for column/row are switched for Profile-Initial Terminal Size
Jun 17 2019, 12:35 PM
hindenburg committed R319:2562c3a003f6: Fixes crash when copying hotspot (authored by hallas).
Fixes crash when copying hotspot
Jun 17 2019, 12:48 AM
hindenburg closed D21849: Fixes crash when copying hotspot.
Jun 17 2019, 12:48 AM · Konsole
hindenburg accepted D21849: Fixes crash when copying hotspot.
Jun 17 2019, 12:44 AM · Konsole

Jun 16 2019

hindenburg committed R319:716884e78e9d: Restore compatibility with Qt < 5.11 (authored by mglb).
Restore compatibility with Qt < 5.11
Jun 16 2019, 12:46 PM
hindenburg closed D21840: Restore compatibility with Qt < 5.11.
Jun 16 2019, 12:46 PM · Konsole

Jun 15 2019

hindenburg added a comment to D21055: Highlight lines coming into view when scrolling.

I can see how this could be useful. If we use the current visual effect, we'll have issues w/ different colors (ie the fade not being easily seen). Perhaps the side visual might be better? At one time, there's a wish to have the scroll bar similar to Kate in that it shows a representation of what's in the window in the scrollbar.

Jun 15 2019, 9:32 PM · Konsole
hindenburg committed R319:d4aeefbd7797: Set ECM min version to KF5_MIN_VERSION to keep them in alignment (authored by hindenburg).
Set ECM min version to KF5_MIN_VERSION to keep them in alignment
Jun 15 2019, 9:13 PM
hindenburg committed R319:7a1116ccff5d: CSI 2J: Do not append current screen to history (authored by mglb).
CSI 2J: Do not append current screen to history
Jun 15 2019, 9:09 PM