On the 19.08 branch I get a lot of these when exiting a konsole session that uses this code. I don't see this warning on master.

Thanks, I'll look at the other patch shortly. This regression should have been caught in my testing.

This looks fine - I'll test the restore patch

thanks makes sense

In D20263#517529, @hindenburg wrote:

FYI, these are showing up in the builds

https://build.kde.org/job/Applications/job/konsole/job/kf5-qt5%20SUSEQt5.12/lastSuccessfulBuild/warnings30Result/

ColorScheme.cpp:314, GNU Make + GNU C Compiler (gcc), Priority: Normal

assignment from temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]

ColorScheme.cpp:316, GNU Make + GNU C Compiler (gcc), Priority: Normal

assignment from temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]

How's this going?

FYI, these are showing up in the builds

if possible, use https://invent.kde.org/kde/konsole/merge_requests instead of phrabicator. I don't mind using phrabicator while it is still up abut I often forget to amend the author.

Thanks a lot for fixing this - please don't add // italic/bold to commit messages as it messes up what shows up in the logs

thanks for sticking w/ this

I don't see any issues testing so far - minor issue obseloteKeys is misspelled

I agree thanks

In D23144#511617, @gladhorn wrote:

See also https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

Thanks

Ok, those can be done later IMHO - any objection to committing this now?

thanks

In D22980#508391, @hiangel wrote:

Thanks you very much!

That said, I'm still curious on the answer, because it might be useful to know for the next time I gonna contribute.

This looks fine to me and fixes the issue.

Thanks putting this here is fine for now