I think this has to be cmake optional check and then a UI checkbox for user to disable. If you're not familiar w/ the UI, I or someone else can do that. We can try to get this in 18.12 though I see no need to rush it.

I need to double-check if frameworks/plasma require QCA; if they do, then it should be installed for Konsole

I'd prefer having QCA as an optional dependent. Did you do any benchmarks on if this slows Konsole down?

I don't recall off-hand what happens w/o these 2 files - most distros include profiles

It appears this causes File->Print Screen save as pdf to crash

I can confirm this fixes the bug - it will need more testing to avoid any regressions

I can confirm the bug

For some reason arc moves the Screen.cpp file - can you re-do the patch please? Or I can just manually commit it.

In D15915#337892, @cfeck wrote:

Kurt, please use 'git commit --author=...' to give proper attribution to patches from contributors.

Thanks for the reminder. I wish arc had a way to notify me when landing that the author isn't correct.

Thanks, nice catch

Thanks

Thanks, I don't see anything obviously wrong; let me test it a bit more and we'll get it into master for more testing.

I thought this was fixed as well but the 'New tab behavior" setting appears to be ignored.

The note I added is not a show stopper - I'll fix that later.

This needs a rebase as well

Thanks for that patch - I'll test it shortly although I don't think I have a laptop w/ wayland on it.

Thanks for taking the time to do this

This was reverted by Tomaz

This doesn't apply cleanly w/ 'arc patch D15757' - not sure if I need to do something special or if you need to rebase.

LGTM thanks for continuing to work on this

Unless you want to add another option for this, with default as-it, I'll veto the close tab click. I don't see an issue w/ the new tab part.

thanks

I really dislike the middle click tab = close tab; we don't want to provide an easy accidentally way to close tabs IMHO.

Can you rebase this please? It applies cleanly but won't land for some reason.

I appear to have forgotten about this one - I'll look at it now

thanks

thanks

I don't have any strong objections

Does there need to be a followup change to add this back to DetachableTabBar as you mention in your summary?

In D15383#326966, @lbergdoll wrote:

In D15383#326927, @hindenburg wrote:

I'm not against this per se but why does every application need this in its source folder?

For reference: https://editorconfig.org/

How else would you achieve this?

I'm not against this per se but why does every application need this in its source folder?

looks fine ATM - let me test it some more - I'll go through the others this weekend

In D14595#313317, @tcanabrava wrote:

Closing this review because I'm splitting this in many small reviews to ease the review request.

In D14798#311336, @cfeck wrote:

Is this a compile-time or runtime version check?

https://cgit.kde.org/konsole.git/commit/?id=b2c8322a461ba6506f3a89069ba36153137e2be5

The concern I have about this is someone is going to wait to disable this, change the actions, etc. It is too bad this can't be done in the shortcut dialog/interface.

1. Don't allow a window that has only 1 tab to be DND out to create a new window with the same one tab
2. We still have the issue where newly created window's text is not visible until some other interaction.

In D14558#302815, @ngraham wrote:

Thanks for the fix! BTW for future reference, the preferred workflow for bugfixes is to commit to the stable branch (Applications/18.08` in this case) and then merge to master, rather than cherry-picking to the stable branch after first landing on master.

Just to clarify, this is for a mouse which have extra button on side correct? I actually don't think I own such a mouse.

Thanks, for Konsole, I commit to master and backport but since this is simple it is OK