hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (189 w, 20 h)
Availability
Available

Recent Activity

Today

hindenburg added a comment to D16138: Create the default profile if it doesn't exist.

I'm still not sure about this.

Sat, Apr 20, 12:53 AM · Konsole

Thu, Apr 18

hindenburg committed R319:c597c0aa4de7: add newline at end of file (authored by hindenburg).
add newline at end of file
Thu, Apr 18, 2:35 AM
hindenburg committed R319:a25e50a9f7f1: Do not shadow variables (authored by hindenburg).
Do not shadow variables
Thu, Apr 18, 2:27 AM
hindenburg committed R319:f7cd5267ad4c: Fix documentation tags (authored by hindenburg).
Fix documentation tags
Thu, Apr 18, 1:50 AM
hindenburg committed R319:5d591a6a7d8d: std::stable_sort requires !(a < a) (authored by hindenburg).
std::stable_sort requires !(a < a)
Thu, Apr 18, 1:38 AM
hindenburg committed R319:b3ceeb044d2c: std::stable_sort requires !(a < a) (authored by hindenburg).
std::stable_sort requires !(a < a)
Thu, Apr 18, 1:35 AM
hindenburg added a comment to D20439: Fix alignment boundary.

This doesn't build - all the initializing code has to be re-arranged.

Thu, Apr 18, 1:03 AM · Konsole

Wed, Apr 17

hindenburg added reviewers for D20439: Fix alignment boundary: Konsole, hindenburg.
Wed, Apr 17, 2:48 PM · Konsole
hindenburg added a comment to D20263: [WIP] Keep perceived contrast in random background color.

Thanks, I agree the colors look much better. This seems like a lot of code for just random backgrounds and I"m not sure how many people use that colorscheme.

Wed, Apr 17, 2:45 PM · VDG, Konsole
hindenburg committed R319:e590afb08109: Ctrl-Tab should work in "split-only" view as well (authored by thsurrel).
Ctrl-Tab should work in "split-only" view as well
Wed, Apr 17, 2:24 PM
hindenburg closed D20395: Ctrl-Tab should work in "split-only" view as well.
Wed, Apr 17, 2:24 PM · Konsole
hindenburg accepted D20395: Ctrl-Tab should work in "split-only" view as well.
Wed, Apr 17, 2:24 PM · Konsole
hindenburg committed R319:ee45b20e70f5: Fix warning "variable loses precision int to uint8" (authored by tcanabrava).
Fix warning "variable loses precision int to uint8"
Wed, Apr 17, 2:09 PM
hindenburg closed D20440: Fix warning "variable loses precision int to uint8".
Wed, Apr 17, 2:09 PM · Konsole
hindenburg accepted D20440: Fix warning "variable loses precision int to uint8".

Thanks there are over 180 of these warnings which I never got around to fixing.

Wed, Apr 17, 2:09 PM · Konsole
hindenburg added a comment to D20395: Ctrl-Tab should work in "split-only" view as well.

I'm fine with this. Tomaz, any objection?

Wed, Apr 17, 2:03 PM · Konsole

Sat, Apr 13

hindenburg added a comment to D18352: Remember last output save directory.

Can you try this?

Sat, Apr 13, 10:20 PM · Konsole
hindenburg added a comment to D20466: Rework scrollback settings.
In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session

Sat, Apr 13, 9:13 PM · Konsole

Fri, Apr 12

hindenburg committed R319:4b0df4454079: Add DesktopEntry to notifyrc (authored by broulik).
Add DesktopEntry to notifyrc
Fri, Apr 12, 2:04 PM
hindenburg closed D20470: Add DesktopEntry to notifyrc.
Fri, Apr 12, 2:04 PM · Konsole
hindenburg updated the summary of D20470: Add DesktopEntry to notifyrc.
Fri, Apr 12, 1:45 PM · Konsole
hindenburg added a comment to D20466: Rework scrollback settings.

The 3 options should be a radio - you have to pick one - now you can de-select all 3

Fri, Apr 12, 1:27 PM · Konsole
hindenburg added a comment to D20466: Rework scrollback settings.

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

This is already happening dudes.

Fri, Apr 12, 1:25 PM · Konsole
hindenburg added a comment to D20466: Rework scrollback settings.

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

Fri, Apr 12, 1:14 PM · Konsole

Thu, Apr 11

hindenburg added a comment to D18352: Remember last output save directory.

It seems not isolated for different konsole instances.
Usually I have two konsole instance to save log files. one for serials com, one for adb log.

Thu, Apr 11, 2:29 PM · Konsole
hindenburg added a comment to D20169: Add profile support interface for TerminalInterface.

Can someone from the frameworks group clarify if this can be committed for the next release 5.58 next month? I know years ago, we had a TerminalInterfaceV2 because the interface was changed.

Thu, Apr 11, 3:56 AM · Frameworks

Wed, Apr 10

hindenburg added a comment to D14200: Simplify newSession code.

and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0

Well sometimes it is set and sometimes not

Wed, Apr 10, 2:27 PM · Konsole
hindenburg added a comment to D14200: Simplify newSession code.

qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1 /tmp

Wed, Apr 10, 2:17 PM · Konsole
hindenburg added a comment to D14200: Simplify newSession code.

Oh this is actually broken in master. So this patch might be OK once that's fixed.

Wed, Apr 10, 2:09 PM · Konsole
hindenburg added a comment to D14200: Simplify newSession code.

Something not correct as it doesn't actually start a new session.

Wed, Apr 10, 2:06 PM · Konsole
hindenburg committed R319:c53e8cb17e11: Re enable move tab left / right via keyboard shortcuts (authored by tcanabrava).
Re enable move tab left / right via keyboard shortcuts
Wed, Apr 10, 1:50 PM
hindenburg closed D20115: Re enable move tab left / right via keyboard shortcuts.
Wed, Apr 10, 1:50 PM · Konsole
hindenburg accepted D20115: Re enable move tab left / right via keyboard shortcuts.

Sounds good

Wed, Apr 10, 1:47 PM · Konsole
hindenburg added a comment to D18352: Remember last output save directory.

Well I decided to try again. This seems much cleaner and doesn't add any extra dependents. It works locally and with sftp URLs. On a side note, I don't think the foreach() loop actually works, so there should be real issue w/ reading/writing the config file every time.

Wed, Apr 10, 3:39 AM · Konsole
hindenburg added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.

Wed, Apr 10, 2:50 AM · Konsole
hindenburg added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.

Wed, Apr 10, 1:24 AM · Konsole
hindenburg committed R319:becc0b4771a5: With recent code changes, detaching tabs now works on Mac OS (authored by hindenburg).
With recent code changes, detaching tabs now works on Mac OS
Wed, Apr 10, 12:53 AM
hindenburg added a comment to D18352: Remember last output save directory.

The other option I looked is using KFileWidget and KRecents but there's issues there. Ping me if it gets close to July w/o a resolution here.

Wed, Apr 10, 12:40 AM · Konsole
hindenburg added a comment to D17643: Multiple Splits per Tab.

Thanks for continuing to work on this - did the yakuake patch get committed to avoid crashes?

Wed, Apr 10, 12:34 AM · Konsole

Tue, Apr 9

hindenburg added a comment to D20224: Implement saving sessions recursively.

I'm fine w/ this

Tue, Apr 9, 12:52 PM · Konsole
hindenburg added a comment to D20224: Implement saving sessions recursively.

A couple of clazy warning if you want to look at

Tue, Apr 9, 2:14 AM · Konsole
hindenburg added a comment to D20224: Implement saving sessions recursively.

Nonetheless, with git master, the tab switching keyboard shortcuts work for me, and with this patch, they do not. :(

Tue, Apr 9, 1:16 AM · Konsole

Mon, Apr 8

hindenburg updated the summary of D20224: Implement saving sessions recursively.
Mon, Apr 8, 1:55 PM · Konsole

Sun, Apr 7

hindenburg committed R319:b9cf6729ea1e: remove commas from enum lists for c++98 (authored by hindenburg).
remove commas from enum lists for c++98
Sun, Apr 7, 11:45 PM
hindenburg committed R319:2e1071fc9049: Use QVariant::toInt() (authored by hindenburg).
Use QVariant::toInt()
Sun, Apr 7, 11:36 PM
hindenburg committed R319:074f74930476: add emit to signal call (authored by hindenburg).
add emit to signal call
Sun, Apr 7, 11:16 PM
hindenburg committed R319:f911b62f6b06: Remove unused function (authored by hindenburg).
Remove unused function
Sun, Apr 7, 9:22 PM

Sat, Apr 6

hindenburg added a comment to D18352: Remember last output save directory.

Ok thanks I didn't think about non KDE distros. I'll look at this again

Sat, Apr 6, 9:00 PM · Konsole

Fri, Apr 5

hindenburg added a comment to D18352: Remember last output save directory.

If you look in ~/.config/konsolerc

Fri, Apr 5, 12:52 PM · Konsole

Thu, Apr 4

hindenburg added a comment to D18352: Remember last output save directory.

This was what I was thinking about - it seems to work - let me know if you have concerns.

Thu, Apr 4, 9:20 PM · Konsole

Wed, Apr 3

hindenburg added a reviewer for D20169: Add profile support interface for TerminalInterface: Frameworks.
Wed, Apr 3, 1:55 PM · Frameworks
hindenburg added a reviewer for D20169: Add profile support interface for TerminalInterface: Konsole.
Wed, Apr 3, 1:52 PM · Frameworks
hindenburg added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

The QAction names need to stay the same if possible, otherwise previous shortcuts don't work. If they are changed, I'm not sure there's a way to automatically update them.

Wed, Apr 3, 1:40 PM · Konsole
hindenburg added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

OK I'll try again - not sure why it didn't work for me the first time.

Wed, Apr 3, 12:25 PM · Konsole
hindenburg added a comment to D20224: Implement saving sessions recursively.

log out with the konsole's sessions you want to test and log back in - you could use 2nd system, VM, docker, etc as well

Wed, Apr 3, 12:24 PM · Konsole

Sat, Mar 30

hindenburg added a comment to D17643: Multiple Splits per Tab.

Session restore also doesn't work - you just get a blank area w/o a session

Sat, Mar 30, 4:37 PM · Konsole
hindenburg added a comment to D20115: Re enable move tab left / right via keyboard shortcuts.

This doesn't seem to work at all... tested w/ just 2 tabs

Sat, Mar 30, 2:02 AM · Konsole
hindenburg added a comment to D18871: Move selection code from TerminalDisplay to ScreenWindow.

The biggest part I have trouble following are the new changes to the findWordStart and findWordEnd. I wonder if doing a straight move to ScreenWindow and then changing the code in a new patch would be best.

Sat, Mar 30, 1:50 AM · Konsole

Fri, Mar 29

hindenburg added a comment to D17643: Multiple Splits per Tab.

Issues I see so far:

  1. Shortcuts to move tabs don't work
  2. Tab menu doesn't have 'Read Only' entry
Fri, Mar 29, 2:39 PM · Konsole
hindenburg committed R309:6b46411622b0: Add bison minimum version of 2.4.1 due to %code (authored by hindenburg).
Add bison minimum version of 2.4.1 due to %code
Fri, Mar 29, 2:01 PM
hindenburg closed D19092: Add bison minimum version of 2.4.1 due to %code.
Fri, Mar 29, 2:01 PM · Frameworks
hindenburg added a comment to D19092: Add bison minimum version of 2.4.1 due to %code.

Is it OK to commit this now? It looks like the next tagging is April 6th

Fri, Mar 29, 1:38 AM · Frameworks

Thu, Mar 28

hindenburg added a comment to D19092: Add bison minimum version of 2.4.1 due to %code.

ping?

Thu, Mar 28, 2:09 PM · Frameworks
hindenburg added a comment to D18871: Move selection code from TerminalDisplay to ScreenWindow.

Thanks still looking at this - need to find a better diff program to follow something this complex

Thu, Mar 28, 2:08 PM · Konsole
hindenburg committed R319:4cddc420e319: Simplify TerminalDisplay code (authored by tcanabrava).
Simplify TerminalDisplay code
Thu, Mar 28, 1:50 PM
hindenburg closed D20088: Simplify TerminalDisplay code .
Thu, Mar 28, 1:50 PM · Konsole
hindenburg accepted D20088: Simplify TerminalDisplay code .

thanks

Thu, Mar 28, 1:50 PM · Konsole
hindenburg added a comment to D19634: Fixes minor memory leaks.

i also backported the original diff to 19.04

Thu, Mar 28, 1:45 PM · Konsole
hindenburg committed R319:4cef9b9cf66a: Fixes minor memory leaks (authored by hallas).
Fixes minor memory leaks
Thu, Mar 28, 1:24 PM
hindenburg committed R319:03a78c2a9f42: Fixes minor memory leaks (authored by hallas).
Fixes minor memory leaks
Thu, Mar 28, 1:14 PM
hindenburg closed D19634: Fixes minor memory leaks.
Thu, Mar 28, 1:14 PM · Konsole
hindenburg accepted D19634: Fixes minor memory leaks.

Thanks a lot

Thu, Mar 28, 1:14 PM · Konsole
hindenburg committed R319:d67c23f71fa6: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Thu, Mar 28, 12:38 PM

Wed, Mar 27

hindenburg added a comment to D18352: Remember last output save directory.

Thanks, this works but I think there might be a better way of doing this - let me work on it - if I can't find a better way I'll merge this

Wed, Mar 27, 2:44 PM · Konsole
hindenburg added a comment to D16138: Create the default profile if it doesn't exist.

Do you have time to rebase this? If not, I can still work around it.

Wed, Mar 27, 2:34 AM · Konsole
hindenburg committed R319:f1e7d8966735: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Wed, Mar 27, 2:27 AM
hindenburg closed D20067: Use QTEST_GUILESS_MAIN.
Wed, Mar 27, 2:27 AM · Konsole
hindenburg accepted D20067: Use QTEST_GUILESS_MAIN.

thanks

Wed, Mar 27, 2:23 AM · Konsole
hindenburg added a comment to D17643: Multiple Splits per Tab.

Also can you link the yakuake patch so we make sure it gets in

Wed, Mar 27, 1:53 AM · Konsole
hindenburg committed R319:6e8153a78e3c: Multiple Splits per Tab (authored by tcanabrava).
Multiple Splits per Tab
Wed, Mar 27, 1:50 AM
hindenburg closed D17643: Multiple Splits per Tab.
Wed, Mar 27, 1:50 AM · Konsole
hindenburg accepted D17643: Multiple Splits per Tab.

OK thanks - I'm fine with that - I just notice that the shortcut to move tabs doesn't work

Wed, Mar 27, 1:49 AM · Konsole

Sun, Mar 24

hindenburg added a comment to D17643: Multiple Splits per Tab.

Will do that today

Checking in...

Sun, Mar 24, 7:33 AM · Konsole

Sat, Mar 23

hindenburg added a comment to D19318: compile without foreach.

There's a FOREACH still in the macpoller.cpp file

Sat, Mar 23, 4:57 PM · Frameworks
hindenburg added a comment to D19551: [knotifications] compile without foreach.

This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers.

Sat, Mar 23, 12:50 AM · Frameworks

Fri, Mar 22

hindenburg added a comment to D19298: Make it compile without foreach.

On Mac, this change gives this error (after removing -DQT_NO_FOREACH) - the recent changes did not fix the error below - f9b835c66a1facfcd6257fe84d3c7e8ead508353 builds fine.

Fri, Mar 22, 1:21 PM · Frameworks
hindenburg added a comment to D19298: Make it compile without foreach.

FYI, this breaks mac building since there's a foreach in src/backends/mac/kauth-policy-gen-mac.cpp; also a few under src/backends/fake

Fri, Mar 22, 12:49 AM · Frameworks

Mar 21 2019

hindenburg committed R319:e9bb01a02eb6: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0 (authored by mglb).
Fix undefined behavior and set QT_MIN_VERSION to 5.9.0
Mar 21 2019, 2:42 AM
hindenburg committed R319:8ad52bc4ee7c: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0 (authored by mglb).
Fix undefined behavior and set QT_MIN_VERSION to 5.9.0
Mar 21 2019, 2:41 AM
hindenburg closed D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.
Mar 21 2019, 2:41 AM · Konsole
hindenburg accepted D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.
Mar 21 2019, 2:41 AM · Konsole
hindenburg added a comment to D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.

OK, thanks - I thought about casting but it seemed strange to only affect Qt 5.9.x

Mar 21 2019, 2:29 AM · Konsole

Mar 20 2019

hindenburg added a comment to D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.

I changed it to 5.9.4; it required some #ifs in KeyboardTranslatorTest.cpp; the only 5.9.x I could find were .4 and .5

Mar 20 2019, 3:44 AM · Konsole
hindenburg committed R319:3b40171cf32f: Set Qt minimum to 5.9.4 (authored by hindenburg).
Set Qt minimum to 5.9.4
Mar 20 2019, 3:40 AM
hindenburg committed R319:ed8847ec94a7: Set Qt minimum to 5.9.4 (authored by hindenburg).
Set Qt minimum to 5.9.4
Mar 20 2019, 3:40 AM

Mar 19 2019

hindenburg added a comment to D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.

To get it compile w/ 5.9.4, I have to comment out all the QCOMPAREs - I thought I tested this w/ 5.9.7 but I appear to have upgraded my VMs

Mar 19 2019, 1:47 PM · Konsole
hindenburg added a comment to D19859: Fix undefined behavior and set QT_MIN_VERSION to 5.9.0.

It fails here w/ 5.9.4 in the tests and .7 was the current so that's why I picked it.

Mar 19 2019, 12:38 AM · Konsole

Mar 17 2019

hindenburg committed R319:8124abecd1b5: Add disambiguation/comments to UI strings (authored by hindenburg).
Add disambiguation/comments to UI strings
Mar 17 2019, 12:18 AM

Mar 16 2019

hindenburg committed R319:d5e4b4490976: Minor .ui files cleanup - loading/saving in Qt Designer 5.12.0 (authored by hindenburg).
Minor .ui files cleanup - loading/saving in Qt Designer 5.12.0
Mar 16 2019, 10:20 PM
hindenburg committed R319:2593e56efede: Minor .ui files cleanup - loading/saving in Qt Designer 5.12.0 (authored by hindenburg).
Minor .ui files cleanup - loading/saving in Qt Designer 5.12.0
Mar 16 2019, 10:20 PM