Thanks for working on this everyone.

I don't think we should put this in Konsole. Instead, we should let users either do disk encryption or other means. They can change the location of Konsole's file to be saved there.

yea give me a few

In D15742#414238, @ngraham wrote:

Another idea: always allow middle-click to open new tabs, but just have the option toggle its close behavior. Then the string can be nice and simple.

Thanks for working on this - I think perhaps this should be committed to master after the 19.04 is branched next month. Objections?

This doesn't apply now - I believe the fix the extended bug was already committed w/ your other patch.

In D15742#414002, @shubham wrote:

what should I now name the gui message? It will become quite big then.

In D15742#413810, @ngraham wrote:

I can't get middle-click-in-empty-space-to-open-a-new-tab to work with this patch. Double-clicking currently does this, but for me this patch doesn't add that behavior.

Tao, are you planning on working on the issues brought up?

Thanks

The code actually closes when on a tab and opens a new tab when over an empty space. You'll need to update the message and GUI text.

The 19.04 branch will be created around March 14th. What do you think about committing this to master after the branch? That should give everyone 2-3 months in master to resolve any issues and get any apps using the KonsolePart to get fixed.

Thanks

Thanks I'll look at this weekend

I don't see any issues w/ this. The only thing that might be fixed later could be when moving the cursor, the full image/character would be highlighted (terminator does this).

can you reopen this pls? we need to add a GUI option to disable the closing part.

Thanks still working on reading these changes.

I'd rather use the other one D15742 - we still need a GUI option added

In D16837#410242, @EspadaV8 wrote:

Any update on having this reviewed? If it's unlikely to make it into Konsole would it be possible to still get a review of the code since I'm curious if it could be improved in any way. I was thinking too that this could be added as either checkbox option or as an extra command line parameter if having it as the default behaviour wasn't wanted.

The output looks fine and I don't see anything wrong w/ the code. However, when selecting one of these wide chars, the "right half" selection grabs the space while the "left half" selection grabs the entire character. If that's something that can't be fixed or is the preferred way to handle that, then OK.

Ok good thanks I can't get it to crash and don't see any regressions

Looks fine - thanks - we can leave the default as-is for now

This one works for me - the other doesn't

Can you rebase this please? A lot of the code has changed since Dec

I can't get this code to work - middle click doesn't do anything - however, https://phabricator.kde.org/D15742 does work - I assume you didn't see that as it duplicate the new/close middle button.

In D18606#406508, @shubham wrote:

@hindenburg Are you okay with this after me and nate have explained it's pros? If not, I will abandon this.

looks fine w/ the one minor nitpick

It appears this causing yakuake to crash when closing a tab/session. I typically try to test the konsolepart using dolphin/yakuake/kdevelop/demo_konsolepart - it can be a pain depending on what distro/setup your using to get them to use the code you're testing.

A quick look running and I'm not a big fan: 1) It doesn't handle split views (assume that after the split tab changes go in, this could be fix), 2) if only tab, don't show anything, 3) releasing the Ctrl+Tab should close popup and go to selected 4) I'm tempted to have a way to turn off the popup.

I've been against this in the past - it is too easy to accidentally close a tab. Unlike other KDE apps, accidentally closing a Konsole tab would be really bad IMHO.

I thought this had to wait until the split tabs code went in - if not I can review now

In D17643#399928, @tcanabrava wrote:

• Dim unfocused terminals

minor nitpicks

I'm still testing - I also notice it is hard to see the splitters - often I get another's view scrollbar confused w/ the splitter. I also notice some issues w/ how multiple splits hare calculated; I would think the other view would not change size.
If anyone could review the code, I'd appreciate more people looking now.

In D17643#395164, @tcanabrava wrote:

I just tested here:

• if you detach the *focused terminal*, it takes the size of the old window, ie (bigger than it was)
• if you detach the *current tab*, it takes the tab of the old window (should be the same size)
  
  which one are you hitting? which one do you think it's wrong?
  
  you want the detached *focused terminal* to keep the same size after detached?

Testing now.

1. Split view either vertical or horizontal
2. detach that tab
3. the detached window is much bigger than the original window.

This looks rather bad on some of my color schemes. How do we handle where this looks bad w/ color schemes?

The default should be None as it is now

A lot of the code has changed since this patch - I've committed a patch that should do what you want - if you are running master Konsole, give it a try. If not, it will be in released April 2019.

Thanks for the effort/code - it appears this has since been fixed.

Are you working on this? I can help along if you want.

Are you still planning on working on this to just have the middle-click to open a new tab?

Is this still needed?

In D16138#354531, @hindenburg wrote:

In D16138#354335, @tcanabrava wrote:

In D16138#352911, @hindenburg wrote:

well I'm a bit confused why I don't see your results under the current master branch - I've tried 2 different VMs and verified there are no konsole files anywhere and get the results I mentioned above.

I'll also test those today to verify the results.
Kurt, do you mind telling us what vm's you used so I can replicate?

I've tried one of my neon desktops twice and a freebsd VM twice.

This is very nice - thanks for working on this and staying with it. Good catch with the read only code.

thanks

Looks fine - thanks - I notice this seems to fix %u which hasn't worked for a while it seems