- User Since
- Sep 4 2015, 9:41 PM (132 w, 2 d)
Sat, Mar 17
Do you time to look at https://bugs.kde.org/show_bug.cgi?id=391788 ?
Fri, Mar 16
looks fine thanks
Thu, Mar 15
If you hide all the menus the UI will look quite a bit different and IMHO confusing to the use. When disabled, the user knows they menu items are there but can't be used ATM.
I'd rather they menu items were disabled - not removed.
Thanks, only need FIXED-IN if there's a BR
Wed, Mar 14
Tue, Mar 13
Anyone else have a comment on this?
Mon, Mar 12
That screenshot is not the default correct? The menubar is shown by default. I don't like the 'ShowWhenNeeded' but I don't really have an opinion on the default.
phabricator really needs a way to tell column #s so they match the commit guidelines.
Ok that's fine - thanks
I'm tempted to have you re-upload this w/o the whitespace/indent changes; that makes it much easier to see only 3 lines are changing.
Thanks, so this basically forces the character into single width which can cut off part of the character. It looks better and correct the cursor/insert issues.
Sun, Mar 11
Can you reproduce the bug? I can't on any of my systems nor any VMs.
Thanks - a much cleaner approach
please put Konsole as reviewers - other wise it won't show up in https://phabricator.kde.org/project/37/item/view/637/
That's a lot more complex than I expected. Since this has always been like this, I'm not concerned about getting it in 18.04
Sat, Mar 10
ping... have you had a chance to look at this again?
Sorry for all the noise on these last 2 reviews - trying to get a pattern down for handling these patches
I'm sure I could use the web UI - was trying to use arc from command line. It would be nice to not have to keep switching from the web to arc and back
Well it looks I can't update message/diff unless I commandeer this patch - arc isn't making this easier IMHO
You can only update revisions you own. You can 'Commandeer' this revision from the web interface if you want to become the owner.
looks fine thanks
OK thanks for the info - could you try to add your email/name to arc to I don't have to remember to use --author
Fri, Mar 9
What I mean should the BR be changed to WONTFIX? Also, I can't find something easy to test this that shows the difference.
Is this patch really fixing the BR?
Are you using arc? If not perhaps it will make it easier. I see your name is not attached to the patch.
copy/paste from other ticket:
Thu, Mar 8
This fixes the main BR - however, if the profile starts zsh and then you type bash, the old/bad behavior is back. I wonder how other terminals handle that.
Wed, Mar 7
I'm missing something - arc land shows my changed message but uses the old message
My only issue is how to change the commit message - doing 'git commit --amend; arc land' on the previous "read only" patch didn't use the new message.
That's fine I don't want to hold this up - I'll try to commit this today
If the "output has been suspended" is active and that tab is dnd to create another window, the kmessage is not shown and it seems to take an extra Ctrl+q to get the tab to resume.
Thanks for the --skip-dependencies help
Tue, Mar 6
Can you redo this patch so it apples cleanly to master?
It looks like I should have done a 'arc amend' with my updated message otherwise it is ignored.
Mon, Mar 5
Looks fine - konsolepart also works - when you correct issues, you can mark them as done.
Sun, Mar 4
Thanks, overall I don't see any major issues.
OK thanks - confirmed - I'll look at the code although change the update* could cause a mess
We need to have any new strings committed by the 21st for the 18.04 release schedule - I would prefer a week earlier. If you're having issues w/ some of the issues, we could separate the patches to get the new strings in first.
What version are you using? It works here showing the prompt.
Fri, Mar 2
Thanks, I'll look at this
Thu, Mar 1
another bad commit message didn't close this
Appears my commit message didn't close this
Anyone please comment on the below suggestions/ideas:
Wed, Feb 28
Do you want me to commit this? Perhaps change the commit message to show the opendesktop cat?
I have code that changes that label to a kmessagewidget; the changes were so small that I haven't bothered committing.
Tue, Feb 27
Mon, Feb 26
OK yea it works now after adjusting the XDG variables - LGTM
Sat, Feb 24
I notice w/ this patch, if you change the font size via shortcut and then edit profile, you get a new profile w/o a name.