hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (154 w, 1 h)
Availability
Available

Recent Activity

Today

hindenburg committed R319:b2c8322a461b: Scope the glib hack to only < Qt5.11.2 versions (authored by svuorela).
Scope the glib hack to only < Qt5.11.2 versions
Fri, Aug 17, 1:03 PM
hindenburg closed D14798: Scope the glib hack to older Qt versions.

https://cgit.kde.org/konsole.git/commit/?id=b2c8322a461ba6506f3a89069ba36153137e2be5

Fri, Aug 17, 12:06 PM · Konsole

Tue, Aug 14

hindenburg added a comment to D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

The concern I have about this is someone is going to wait to disable this, change the actions, etc. It is too bad this can't be done in the shortcut dialog/interface.

Tue, Aug 14, 12:39 PM · Konsole
hindenburg added a reviewer for D14798: Scope the glib hack to older Qt versions: Konsole.
Tue, Aug 14, 2:44 AM · Konsole

Tue, Aug 7

hindenburg added a comment to D14595: Fixes Tabbar Drag and Drop.
  1. Don't allow a window that has only 1 tab to be DND out to create a new window with the same one tab
  2. We still have the issue where newly created window's text is not visible until some other interaction.
Tue, Aug 7, 1:15 PM · Konsole

Fri, Aug 3

hindenburg added a comment to D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.

Thanks for the fix! BTW for future reference, the preferred workflow for bugfixes is to commit to the stable branch (Applications/18.08` in this case) and then merge to master, rather than cherry-picking to the stable branch after first landing on master.

Fri, Aug 3, 2:02 PM · Konsole
hindenburg committed R319:db51e08b1874: Add tests for emoji character width - currently expected failures (authored by hindenburg).
Add tests for emoji character width - currently expected failures
Fri, Aug 3, 1:49 PM

Thu, Aug 2

hindenburg added a reviewer for D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB: sandsmark.
Thu, Aug 2, 2:05 PM · Konsole
hindenburg added a comment to D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

Just to clarify, this is for a mouse which have extra button on side correct? I actually don't think I own such a mouse.

Thu, Aug 2, 3:36 AM · Konsole
hindenburg committed R319:ee5e70e7d988: Vt102EmulationTest: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Vt102EmulationTest: Use QTEST_GUILESS_MAIN
Thu, Aug 2, 3:31 AM
hindenburg committed R319:5146575dbceb: Vt102EmulationTest: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Vt102EmulationTest: Use QTEST_GUILESS_MAIN
Thu, Aug 2, 3:31 AM
hindenburg closed D14539: Vt102EmulationTest: Use QTEST_GUILESS_MAIN.
Thu, Aug 2, 3:31 AM · Konsole
hindenburg accepted D14539: Vt102EmulationTest: Use QTEST_GUILESS_MAIN.

Thanks, for Konsole, I commit to master and backport but since this is simple it is OK

Thu, Aug 2, 2:26 AM · Konsole

Sat, Jul 28

hindenburg committed R319:c9bb564722a4: Move script konsoleprofile to tools/ directory (authored by hindenburg).
Move script konsoleprofile to tools/ directory
Sat, Jul 28, 6:00 PM
hindenburg committed R319:9941ac6a5d6f: Revert "Change internal character type size to 32 bit" (authored by hindenburg).
Revert "Change internal character type size to 32 bit"
Sat, Jul 28, 12:21 AM
hindenburg added a reverting change for R319:5128781a824c: Change internal character type size to 32 bit: R319:9941ac6a5d6f: Revert "Change internal character type size to 32 bit".
Sat, Jul 28, 12:21 AM

Wed, Jul 25

hindenburg added a comment to D13882: Use QTabBar: drop tons of code.

open items:

Wed, Jul 25, 2:47 PM · Konsole
hindenburg committed R319:150c98a50a23: Match argument names (authored by hindenburg).
Match argument names
Wed, Jul 25, 2:37 PM
hindenburg committed R319:5d3e086575da: Match argument names (authored by hindenburg).
Match argument names
Wed, Jul 25, 2:15 PM
hindenburg committed R319:f29ca068d4e6: move container usage after nullptr check (authored by hindenburg).
move container usage after nullptr check
Wed, Jul 25, 2:13 PM
hindenburg committed R319:8b377385ab3b: Re-Enable --hide-tabbar and --show-tabbar (authored by tcanabrava).
Re-Enable --hide-tabbar and --show-tabbar
Wed, Jul 25, 1:20 PM
hindenburg closed D14294: Re-Enable --hide-tabbar and --show-tabbar.
Wed, Jul 25, 1:20 PM · Konsole

Tue, Jul 24

hindenburg committed R319:fe678362b619: fix API param docs (authored by hindenburg).
fix API param docs
Tue, Jul 24, 2:45 PM
hindenburg committed R319:af82a3a70a5e: set to public domain license for a small snippet of code/fair use (authored by hindenburg).
set to public domain license for a small snippet of code/fair use
Tue, Jul 24, 2:45 PM
hindenburg added a reverting change for R319:6ab8ce7a7f99: break build to test failure email to ml: R319:90ec94f7b6d5: Revert "break build to test failure email to ml".
Tue, Jul 24, 2:24 PM
hindenburg committed R319:90ec94f7b6d5: Revert "break build to test failure email to ml" (authored by hindenburg).
Revert "break build to test failure email to ml"
Tue, Jul 24, 2:24 PM
hindenburg committed R319:6ab8ce7a7f99: break build to test failure email to ml (authored by hindenburg).
break build to test failure email to ml
Tue, Jul 24, 2:13 PM
hindenburg added a comment to D14294: Re-Enable --hide-tabbar and --show-tabbar.

Can you rebase this please?

Tue, Jul 24, 2:10 PM · Konsole
hindenburg accepted D14294: Re-Enable --hide-tabbar and --show-tabbar.

Let's leave the old way for now where you can change this in the settings. Thanks

Tue, Jul 24, 2:07 PM · Konsole
hindenburg updated the summary of D14294: Re-Enable --hide-tabbar and --show-tabbar.
Tue, Jul 24, 1:56 PM · Konsole
hindenburg committed R319:50cbc1d9301d: Fix option "Expand individual tab to full window" (authored by tcanabrava).
Fix option "Expand individual tab to full window"
Tue, Jul 24, 1:48 PM
hindenburg closed D14296: Fix option "Expand individual tab to full window".
Tue, Jul 24, 1:48 PM · Konsole
hindenburg retitled D14296: Fix option "Expand individual tab to full window" from Fix "expand tabs to full window" to Fix option "Expand individual tab to full window".
Tue, Jul 24, 1:45 PM · Konsole
hindenburg accepted D14296: Fix option "Expand individual tab to full window".

Thanks, I meant to test how it worked before the changes but didn't get around to it.

Tue, Jul 24, 1:43 PM · Konsole
hindenburg committed R319:46e4938cb342: Fix base-class-event issue; return QDialog::eventFilter() (authored by hindenburg).
Fix base-class-event issue; return QDialog::eventFilter()
Tue, Jul 24, 5:05 AM
hindenburg committed R319:56184b319ced: For QString.split() use QLatin1Char() (authored by hindenburg).
For QString.split() use QLatin1Char()
Tue, Jul 24, 4:47 AM
hindenburg committed R319:35d8833a3a57: mark constructor with one arg as explicit (authored by hindenburg).
mark constructor with one arg as explicit
Tue, Jul 24, 4:37 AM
hindenburg added a comment to D13882: Use QTabBar: drop tons of code.

just realized this has been failing https://build.kde.org/job/Applications%20konsole%20kf5-qt5%20SUSEQt5.9/

Also note, Konsole currently only requires 5.6 - I'd really perfer to not change this unless really needed.

02:50:58 /home/jenkins/workspace/Applications konsole kf5-qt5 SUSEQt5.9/src/ViewContainer.cpp:316:52: error: ‘currentType’ is not a member of ‘QOperatingSystemVersion’
02:50:58 const auto isDarwin = QOperatingSystemVersion::currentType() == QOperatingSystemVersion::MacOS;

Tue, Jul 24, 3:45 AM · Konsole
hindenburg committed R319:c5182b5e6f29: Revert back to using cmake variable ENABLE_DETACHING to fix build (authored by hindenburg).
Revert back to using cmake variable ENABLE_DETACHING to fix build
Tue, Jul 24, 3:41 AM
hindenburg added a comment to D13882: Use QTabBar: drop tons of code.

just realized this has been failing https://build.kde.org/job/Applications%20konsole%20kf5-qt5%20SUSEQt5.9/

Tue, Jul 24, 3:02 AM · Konsole
hindenburg committed R319:953c250fe9db: Re-enable profile menu for new tab button and restore close button behavior (authored by tcanabrava).
Re-enable profile menu for new tab button and restore close button behavior
Tue, Jul 24, 2:49 AM
hindenburg closed D14295: Re-enable profile menu for new tab button and restore close button behavior.
Tue, Jul 24, 2:49 AM · Konsole
hindenburg accepted D14295: Re-enable profile menu for new tab button and restore close button behavior.
Tue, Jul 24, 2:48 AM · Konsole
hindenburg requested changes to D14295: Re-enable profile menu for new tab button and restore close button behavior.
Tue, Jul 24, 2:48 AM · Konsole
hindenburg updated the summary of D14295: Re-enable profile menu for new tab button and restore close button behavior.
Tue, Jul 24, 2:47 AM · Konsole
hindenburg accepted D14295: Re-enable profile menu for new tab button and restore close button behavior.
Tue, Jul 24, 2:45 AM · Konsole
hindenburg added a comment to D14294: Re-Enable --hide-tabbar and --show-tabbar.

This seems over complex - This can wait if you want to rework when you have time.

Tue, Jul 24, 2:36 AM · Konsole
hindenburg updated the summary of D14294: Re-Enable --hide-tabbar and --show-tabbar.
Tue, Jul 24, 1:45 AM · Konsole
hindenburg added a comment to D14296: Fix option "Expand individual tab to full window".

Calling qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW setTabWidthToText true and false causes visual glitches *tabs overlap" for a few seconds until it corrects itself. And sometimes false doesn't work. Tested w/ close button enabled.

Tue, Jul 24, 1:35 AM · Konsole
hindenburg committed R319:033d293d88f7: Fix crash with detach tab / hide tab buttons (authored by tcanabrava).
Fix crash with detach tab / hide tab buttons
Tue, Jul 24, 1:26 AM
hindenburg closed D14298: Fix crash with detach tab / hide tab buttons.
Tue, Jul 24, 1:26 AM · Konsole
hindenburg accepted D14298: Fix crash with detach tab / hide tab buttons.
Tue, Jul 24, 1:24 AM · Konsole

Mon, Jul 23

hindenburg added a comment to D14262: fix emoji rendering.

Let's wait to see what Mariusz's plan.

Mon, Jul 23, 2:41 PM · Konsole
hindenburg committed R319:78f768ac8f75: Add missing license (authored by tcanabrava).
Add missing license
Mon, Jul 23, 2:40 PM
hindenburg closed D14297: Add missing license.
Mon, Jul 23, 2:40 PM · Konsole
hindenburg accepted D14297: Add missing license.
Mon, Jul 23, 2:37 PM · Konsole

Sun, Jul 22

hindenburg added a comment to D13882: Use QTabBar: drop tons of code.

Sorry for the mess people, I have a lack of time this week for work related
issues, if you guys want to revert I completely understand and I can open a
new review later without the regressions.

I'm open to revert if someone could tell me how using git; there's a merge here so that complicates it.

Sun, Jul 22, 3:54 PM · Konsole
hindenburg added a comment to D13882: Use QTabBar: drop tons of code.

I would have preferred that I could have looked the code over before this was committed. The new files don't have the license/copyright on them.

Sun, Jul 22, 1:05 PM · Konsole

Jul 14 2018

hindenburg committed R319:fcea6742c142: Move search line upper bound check to less generic function (authored by mglb).
Move search line upper bound check to less generic function
Jul 14 2018, 5:11 PM
hindenburg closed D14106: Move search line upper bound check to less generic function.
Jul 14 2018, 5:11 PM · Konsole
hindenburg accepted D14106: Move search line upper bound check to less generic function.
Jul 14 2018, 5:09 PM · Konsole
hindenburg added a comment to D14106: Move search line upper bound check to less generic function.

Thanks for looking at this. It appears to fix this issue.

Jul 14 2018, 12:40 AM · Konsole

Jul 12 2018

hindenburg committed R319:7aaf7eddfcf0: add a sample emoji test file (authored by hindenburg).
add a sample emoji test file
Jul 12 2018, 1:04 PM
hindenburg committed R319:9655cf033753: IncrementalSearchBox: use autoFillBackground (authored by mglb).
IncrementalSearchBox: use autoFillBackground
Jul 12 2018, 1:25 AM
hindenburg closed D14039: IncrementalSearchBox: use autoFillBackground.
Jul 12 2018, 1:25 AM · Konsole
hindenburg accepted D14039: IncrementalSearchBox: use autoFillBackground.
Jul 12 2018, 1:24 AM · Konsole
hindenburg added a comment to D14039: IncrementalSearchBox: use autoFillBackground.

I'm getting crashes when I switch to another profile (with smaller font) with the search box open - can you duplicate?

I'll check w/o this patch but I couldn't duplicate it the first time

ASSERT: "screenLine <= _screenLinesSize" in file /home/kurthindenburg/Devel/KDE/src/kde/applications/konsole/src/Screen.cpp, line 1346

Jul 12 2018, 1:17 AM · Konsole
hindenburg requested changes to D14039: IncrementalSearchBox: use autoFillBackground.

I'm getting crashes when I switch to another profile (with smaller font) with the search box open - can you duplicate?

Jul 12 2018, 1:04 AM · Konsole
hindenburg committed R319:77c5d5bcfdb0: IncrementalSearchBox: do not propagate unhandled keys to parent (authored by mglb).
IncrementalSearchBox: do not propagate unhandled keys to parent
Jul 12 2018, 12:54 AM
hindenburg closed D14037: IncrementalSearchBox: do not propagate unhandled keys to parent.
Jul 12 2018, 12:54 AM · Konsole
hindenburg committed R319:e176667d6809: IncrementalSearchBox: fix rendering during terminal scroll (authored by mglb).
IncrementalSearchBox: fix rendering during terminal scroll
Jul 12 2018, 12:49 AM
hindenburg closed D14038: IncrementalSearchBox: fix rendering during terminal scroll.
Jul 12 2018, 12:49 AM · Konsole
hindenburg added a comment to D14038: IncrementalSearchBox: fix rendering during terminal scroll.

I had to add more info in the summary area to get the BUG: to be on a new line instead of summary line.

Jul 12 2018, 12:44 AM · Konsole
hindenburg updated the summary of D14038: IncrementalSearchBox: fix rendering during terminal scroll.
Jul 12 2018, 12:43 AM · Konsole

Jul 11 2018

hindenburg accepted D14037: IncrementalSearchBox: do not propagate unhandled keys to parent.
Jul 11 2018, 11:43 AM · Konsole
hindenburg accepted D14039: IncrementalSearchBox: use autoFillBackground.
Jul 11 2018, 11:35 AM · Konsole
hindenburg accepted D14038: IncrementalSearchBox: fix rendering during terminal scroll.

very nice - glad this was a simple fix

Jul 11 2018, 11:24 AM · Konsole

Jul 10 2018

hindenburg added a comment to D13847: Random Ternaries.

I don't mind the smaller ones, but I'm not 100% sure about some of the multi-line ones.

Jul 10 2018, 1:21 PM · Konsole
hindenburg committed R319:4add8545fa61: For QPointer do not compare to nullptr, use isNull() (authored by hindenburg).
For QPointer do not compare to nullptr, use isNull()
Jul 10 2018, 2:04 AM
hindenburg committed R319:1b11b1d3fb6c: Fix crashes when font's height() < 1 (authored by hindenburg).
Fix crashes when font's height() < 1
Jul 10 2018, 2:04 AM
hindenburg changed the end date for E456: KDE Apps 18.08.3 Release from Nov 9 2018 to Nov 8 2018.
Jul 10 2018, 1:34 AM · Event: Release
hindenburg changed the end date for E456: KDE Apps 18.08.3 Release from Oct 11 2018 to Nov 9 2018.
Jul 10 2018, 1:10 AM · Event: Release
hindenburg added a comment to D14012: Fix SearchBar font.

What about the issue of the widget scrolling up? That's needs fixed before 18.08

Jul 10 2018, 12:56 AM · Konsole

Jul 7 2018

hindenburg committed R319:1b49c1ab40d2: For demo_konsolepart, enable blur from the profile's settings (authored by hindenburg).
For demo_konsolepart, enable blur from the profile's settings
Jul 7 2018, 12:20 AM

Jul 6 2018

hindenburg cancelled E449: KDE Apps 18.08.0 Release.
Jul 6 2018, 10:54 PM · Event: Release
hindenburg updated the event description for E455: KDE Apps 18.08.3 Tag.
Jul 6 2018, 10:50 PM · Event: Release
hindenburg updated the event description for E454: KDE Apps 18.08.2 Release.
Jul 6 2018, 10:49 PM · Event: Release
hindenburg updated the event description for E456: KDE Apps 18.08.3 Release.
Jul 6 2018, 10:49 PM · Event: Release
hindenburg updated the event description for E453: KDE Apps 18.08.2 tag.
Jul 6 2018, 10:49 PM · Event: Release
hindenburg updated the event description for E452: KDE Apps 18.08.1 Release.
Jul 6 2018, 10:49 PM · Event: Release
hindenburg updated the event description for E451: KDE Apps 18.08.1 Tag.
Jul 6 2018, 10:49 PM · Event: Release
hindenburg updated the event description for E450: KDE Apps 18.08.0 Release.
Jul 6 2018, 10:49 PM · Event: Release
hindenburg updated the event description for E448: KDE Apps 18.08.0 Tag.
Jul 6 2018, 10:48 PM · Event: Release
hindenburg updated the event description for E447: KDE Apps 18.08 RC.
Jul 6 2018, 10:48 PM · Event: Release
hindenburg updated the event description for E446: KDE Apps 18.08 freeze and beta.
Jul 6 2018, 10:47 PM · Event: Release

Jul 5 2018

hindenburg updated the event description for E445: KDE Apps 18.08 dep freeze.
Jul 5 2018, 9:58 PM · Event: Release
hindenburg added a comment to D13891: Fix KConfig.

As David mentioned, try to get the first line of the commit log to be more informative

Jul 5 2018, 2:25 PM · Konsole

Jun 27 2018

hindenburg committed R319:56fb0fe47268: Add a global shortcut (Ctrl+Alt+T) to launch Konsole (authored by ngraham).
Add a global shortcut (Ctrl+Alt+T) to launch Konsole
Jun 27 2018, 3:21 AM
hindenburg closed D13708: Add a global shortcut (Ctrl+Alt+T) to launch Konsole.
Jun 27 2018, 3:21 AM · Konsole
hindenburg committed R319:50c2ab682842: Remove SearchBar from the MainWindowOverview (authored by tcanabrava).
Remove SearchBar from the MainWindowOverview
Jun 27 2018, 3:21 AM