if possible, use https://invent.kde.org/kde/konsole/merge_requests instead of phrabicator. I don't mind using phrabicator while it is still up abut I often forget to amend the author.

Thanks a lot for fixing this - please don't add // italic/bold to commit messages as it messes up what shows up in the logs

thanks for sticking w/ this

I don't see any issues testing so far - minor issue obseloteKeys is misspelled

I agree thanks

In D23144#511617, @gladhorn wrote:

See also https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

Thanks

Ok, those can be done later IMHO - any objection to committing this now?

thanks

In D22980#508391, @hiangel wrote:

Thanks you very much!

That said, I'm still curious on the answer, because it might be useful to know for the next time I gonna contribute.

This looks fine to me and fixes the issue.

Thanks putting this here is fine for now

Note that on a 800x600 screen, the 'Configure Konsole' dialog is too big - the 'Tab Bar' page is too long. I typically have tried to keep the dialogs usable in 800x600 screens.

What's the status of this? Still a WIP? I'm fine w/ adding it to Konsole; the other schemes could be adjusted to use this later correct?

In D22243#493062, @pdabrowski wrote:

@hindenburg
are

Opacity=1
 Wallpaper=

also the defaults that could be removed from color schemes?

Blur=false is the default so you don't need it.

I'll add the BreezeLight one - you also have to add the files to CMakeLists.txt

Thanks, already merged - we can still use phabricator for simple request if people have it already setup.

I"m fine w/ the Breeze icon; if/when they update the icon we can change it again.

Running the command would be a step that needs fixed when switching profiles regardless. However, I think we need the option to have shortcuts open new profile tabs. I had plans to try to work on it this week and if I can't find something revert it for 19.08.

If I can't find a good way to re-do this by July 13th, I'm going to revert this.

In D17374#478139, @hindenburg wrote:

Anyone have anything to say about Thiago's comment? There's now only one shortcut to open a new tab.

I can see how this could be useful. If we use the current visual effect, we'll have issues w/ different colors (ie the fade not being easily seen). Perhaps the side visual might be better? At one time, there's a wish to have the scroll bar similar to Kate in that it shows a representation of what's in the window in the scrollbar.