hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (197 w, 2 d)
Availability
Available

Recent Activity

Today

hindenburg committed R319:716884e78e9d: Restore compatibility with Qt < 5.11 (authored by mglb).
Restore compatibility with Qt < 5.11
Sun, Jun 16, 12:46 PM
hindenburg closed D21840: Restore compatibility with Qt < 5.11.
Sun, Jun 16, 12:46 PM · Konsole

Yesterday

hindenburg added a comment to D21055: Highlight lines coming into view when scrolling.

I can see how this could be useful. If we use the current visual effect, we'll have issues w/ different colors (ie the fade not being easily seen). Perhaps the side visual might be better? At one time, there's a wish to have the scroll bar similar to Kate in that it shows a representation of what's in the window in the scrollbar.

Sat, Jun 15, 9:32 PM · Konsole
hindenburg committed R319:d4aeefbd7797: Set ECM min version to KF5_MIN_VERSION to keep them in alignment (authored by hindenburg).
Set ECM min version to KF5_MIN_VERSION to keep them in alignment
Sat, Jun 15, 9:13 PM
hindenburg committed R319:7a1116ccff5d: CSI 2J: Do not append current screen to history (authored by mglb).
CSI 2J: Do not append current screen to history
Sat, Jun 15, 9:09 PM
hindenburg closed D21282: CSI 2J: Do not append current screen to history.
Sat, Jun 15, 9:09 PM · Konsole
hindenburg accepted D21282: CSI 2J: Do not append current screen to history.

I'm fine with adding this.

Sat, Jun 15, 8:53 PM · Konsole
hindenburg added a comment to D20816: Configure Konsole dialog GUI redesign.

QFontMetrics::horizontalAdvance is only in qt5.11 - can you find a replacement for Qt5.9-10?

Sat, Jun 15, 5:38 PM · VDG, Konsole
hindenburg committed R319:22d8bd5b0959: Merge branch 'D20816' into 'master' (authored by hindenburg).
Merge branch 'D20816' into 'master'
Sat, Jun 15, 5:01 PM
hindenburg added a comment to D20816: Configure Konsole dialog GUI redesign.

Now that konsole is using invent, I can't do an 'arc land' anymore - I'm moving the diff over to a branch and then committing. Not ideal as when I push the branch, the commit keywords are parsed. I need to streamline this somehow.

Sat, Jun 15, 4:57 PM · VDG, Konsole
hindenburg committed R319:a8ec9ad28adf: Configure Konsole dialog GUI redesign (authored by mglb).
Configure Konsole dialog GUI redesign
Sat, Jun 15, 4:55 PM
hindenburg closed D20816: Configure Konsole dialog GUI redesign.
Sat, Jun 15, 4:55 PM · VDG, Konsole
hindenburg committed R935:baefcfaa8f3c: Redo update website (authored by ognarb).
Redo update website
Sat, Jun 15, 3:35 PM
hindenburg closed D21796: Redo update website.
Sat, Jun 15, 3:35 PM · Konsole
hindenburg committed R319:023c52904265: Merge branch 'gitlab/header_bar_splits' into 'master' (authored by hindenburg).
Merge branch 'gitlab/header_bar_splits' into 'master'
Sat, Jun 15, 2:56 PM
hindenburg accepted D21796: Redo update website.
Sat, Jun 15, 2:02 PM · Konsole
hindenburg updated the summary of D21796: Redo update website.
Sat, Jun 15, 2:01 PM · Konsole

Fri, Jun 14

hindenburg added a comment to D21796: Redo update website.

Thanks, I'll work on this weekend and try to get it committed correctly.

Fri, Jun 14, 1:58 PM · Konsole

Wed, Jun 12

hindenburg added a comment to D20816: Configure Konsole dialog GUI redesign.

@mglb If you busy, we can commit this now and fix minor issues later.

Wed, Jun 12, 2:28 PM · VDG, Konsole
hindenburg added a comment to D21282: CSI 2J: Do not append current screen to history.

Thanks let me look at this week

Wed, Jun 12, 2:27 PM · Konsole

Tue, Jun 11

hindenburg added a comment to D17374: Profile shortcuts switch profile instead of opening new tab.

Anyone have anything to say about Thiago's comment? There's now only one shortcut to open a new tab.

Tue, Jun 11, 2:54 PM · Konsole
hindenburg committed R306:11547a552d6b: Add profile support interface for TerminalInterface (authored by mschiller).
Add profile support interface for TerminalInterface
Tue, Jun 11, 12:58 AM
hindenburg closed D20169: Add profile support interface for TerminalInterface.
Tue, Jun 11, 12:58 AM · Frameworks
hindenburg accepted D20169: Add profile support interface for TerminalInterface.
Tue, Jun 11, 12:50 AM · Frameworks
hindenburg updated the summary of D20169: Add profile support interface for TerminalInterface.
Tue, Jun 11, 12:38 AM · Frameworks

Wed, Jun 5

hindenburg committed R319:12eb5c193465: Implement the new interface of TerminalInterface for profile handling (authored by mschiller).
Implement the new interface of TerminalInterface for profile handling
Wed, Jun 5, 1:25 PM
hindenburg closed D20170: Implement the new interface of TerminalInterface for profile handling.

Forgot to add the line to close this.

Wed, Jun 5, 1:25 PM · Konsole
hindenburg accepted D20170: Implement the new interface of TerminalInterface for profile handling.

Thanks, it worked the 2nd time I tried.

Wed, Jun 5, 12:39 PM · Konsole

Tue, Jun 4

hindenburg added a comment to D20170: Implement the new interface of TerminalInterface for profile handling.

KDE uses spaces instead of tabs. Does the tests past if you manually install the new kde_terminal_interface.h and remove the #IF? I get failures in the QVERIFY(terminal).

Tue, Jun 4, 2:51 PM · Konsole

Mon, Jun 3

hindenburg added a comment to D20170: Implement the new interface of TerminalInterface for profile handling.

Thanks, do you have time to add some tests? They would be added to autotests/TerminalInterfaceTest.cpp TerminalInterfaceTest.h

Mon, Jun 3, 2:10 PM · Konsole

Sun, Jun 2

hindenburg added a comment to D20170: Implement the new interface of TerminalInterface for profile handling.

Can you update this patch assuming that frameworks 5.60 will have the new code?

Sun, Jun 2, 2:13 PM · Konsole
hindenburg added a comment to D20169: Add profile support interface for TerminalInterface.

ping

Sun, Jun 2, 2:09 PM · Frameworks
hindenburg committed R319:0cc5d041cb67: Merge branch 'BR407822' into 'master' (authored by hindenburg).
Merge branch 'BR407822' into 'master'
Sun, Jun 2, 12:23 AM
hindenburg committed R319:9685e23e2efe: Remove unneeded setZModemBusy(true) (authored by hindenburg).
Remove unneeded setZModemBusy(true)
Sun, Jun 2, 12:23 AM

Sat, Jun 1

hindenburg committed R319:0509982a7cd1: Remove unneeded setZModemBusy(true) (authored by hindenburg).
Remove unneeded setZModemBusy(true)
Sat, Jun 1, 6:54 PM
hindenburg added a comment to D21516: Variables for column/row are switched for Profile - Initial Terminal Size.

Since the move to invent, arc land doesn't work for me ATM - I need to re-arrange my system - I merged the branch in invent.

Sat, Jun 1, 4:43 PM · Konsole
hindenburg committed R319:47c4e399d3a6: Merge branch 'D21516' into 'master' (authored by hindenburg).
Merge branch 'D21516' into 'master'
Sat, Jun 1, 4:40 PM
hindenburg committed R319:1cecc8ae38ba: Variables for column/row are switched for Profile-Initial Terminal Size (authored by marten).
Variables for column/row are switched for Profile-Initial Terminal Size
Sat, Jun 1, 4:38 PM
hindenburg closed D21516: Variables for column/row are switched for Profile - Initial Terminal Size.
Sat, Jun 1, 4:38 PM · Konsole
hindenburg accepted D21516: Variables for column/row are switched for Profile - Initial Terminal Size.

Nice catch - thanks a lot.

Sat, Jun 1, 4:24 PM · Konsole
hindenburg updated the test plan for D21516: Variables for column/row are switched for Profile - Initial Terminal Size.
Sat, Jun 1, 4:06 PM · Konsole

Fri, May 31

hindenburg committed R935:20b7949a671e: Update konsole website (authored by ognarb).
Update konsole website
Fri, May 31, 3:48 AM
hindenburg committed R319:7e4c17dbd5e2: test branch (authored by hindenburg).
test branch
Fri, May 31, 1:54 AM
hindenburg closed D20701: Update konsole website.

Thanks to everyone who helped on this. I manually committed this as I couldn't get arc to work correctly.

Fri, May 31, 1:50 AM · Konsole

Thu, May 30

hindenburg added a comment to D20701: Update konsole website.

@hindenburg Sysadmin did the setup, you need now to push the change to make it live 🎉.

Thu, May 30, 2:44 PM · Konsole

Sun, May 26

hindenburg added a comment to D20701: Update konsole website.

Kurt, could you please create a branch in the Konsole website repository containing this work?
I'll then be able to arrange the switchover.

Sun, May 26, 1:16 PM · Konsole

Sat, May 25

hindenburg accepted D20701: Update konsole website.

Thanks, any minor changes can be done afterwards.

Sat, May 25, 9:57 AM · Konsole

Fri, May 24

hindenburg added a comment to D21301: Add a TerminalHeader when using splits.

We are but it’s a per project basis

Fri, May 24, 8:15 PM · Konsole
hindenburg added a comment to D20701: Update konsole website.

Are we waiting on the sysadmins? And if so, does anyone know the timeline? BTW, thanks for working on this.

Fri, May 24, 8:10 PM · Konsole

Thu, May 23

hindenburg added a comment to D21301: Add a TerminalHeader when using splits.

@hindenburg I have a long list of branches that are build on top of other branches, and phabricator is breaking my reviews (four to date, just this week).
would you accept konsole to move to gitlab?

+1, I think that would be fantastic!

Thu, May 23, 2:59 PM · Konsole
hindenburg added a comment to D21309: Use only one accelerator to Maximize / Unmaximize a split view.

Ok I see this request now - I'm a bit behind on my emails. This makes sense to have one toggle, but I'm still unclear on why anyone would want to max/min a split-view. It would be easy to forget you have a min view.

Thu, May 23, 2:58 PM · Konsole
hindenburg added a comment to D21308: Fix the logic for Maximize / Minimize.

This doesn't seem to maximize now. I'm not clear on why the splits need a maximize. I can't figure how to un-maximize the view.

Thu, May 23, 2:52 PM · Konsole
hindenburg added a comment to D20170: Implement the new interface of TerminalInterface for profile handling.

I believe that once the KParts code is committed to frameworks, Konsole needs to add checks the frameworks version. I'd rather not require the new framework version for all of Konsole, just this new code.

Thu, May 23, 2:17 PM · Konsole

May 17 2019

hindenburg committed R319:6c77a4c193d7: Fix sessions not correcly loading untill a tab is focused (authored by tcanabrava).
Fix sessions not correcly loading untill a tab is focused
May 17 2019, 12:57 AM
hindenburg closed D21216: Fix sessions not correcly loading untill a tab is focused.
May 17 2019, 12:57 AM · Konsole
hindenburg accepted D21216: Fix sessions not correcly loading untill a tab is focused.

There have been a number of hacks in Konsole; I'm fine w/ this for now.

May 17 2019, 12:56 AM · Konsole

May 14 2019

hindenburg added a comment to D20169: Add profile support interface for TerminalInterface.

I would prefer using TerminalInterfaceV2 in the current file instead of a new file. It would make using it much easier to use, document, etc and when kf6 comes out, easier to re-combine.

May 14 2019, 11:54 AM · Frameworks
hindenburg committed R319:02aeb9e67ac0: Fix-ish scrollbar background with Qt Fusion style (authored by sandsmark).
Fix-ish scrollbar background with Qt Fusion style
May 14 2019, 11:37 AM
hindenburg closed D19482: Fix-ish scrollbar background with Qt Fusion style.
May 14 2019, 11:37 AM · Konsole
hindenburg updated the test plan for D19482: Fix-ish scrollbar background with Qt Fusion style.
May 14 2019, 11:36 AM · Konsole

May 11 2019

hindenburg added a comment to D21123: Compile without Q_FOREACH.

Thanks for doing this - I was going to eventually get around to it.

May 11 2019, 2:28 PM · Konsole
hindenburg committed R319:cb05664071e7: Toggle all actions when a session restore happens (authored by tcanabrava).
Toggle all actions when a session restore happens
May 11 2019, 2:16 PM
hindenburg closed D21118: Toggle all actions when a session restore happens.
May 11 2019, 2:16 PM · Konsole
hindenburg updated the summary of D21118: Toggle all actions when a session restore happens.
May 11 2019, 2:04 PM · Konsole

May 10 2019

hindenburg added a comment to D21118: Toggle all actions when a session restore happens.

Thanks, his does seem to fix the shortcut issues w/ restoring. I'll look at this and the others this weekend.

May 10 2019, 2:25 PM · Konsole

Apr 26 2019

hindenburg added a comment to D20816: Configure Konsole dialog GUI redesign.

This looks really good - very nice job.

Apr 26 2019, 2:41 PM · VDG, Konsole
hindenburg added a comment to D20816: Configure Konsole dialog GUI redesign.
  1. "Rename "File Location" to "Temporary Files" - this page probably will be removed (D20466)" - This isn't going to be removed - there are valid reasons to allow users to change the file locations.
  2. The Manage Profile page still needs the info 'The Show column must be checked for these shortcuts to work' until it gets fixed.
Apr 26 2019, 2:28 PM · VDG, Konsole
hindenburg committed R319:9680e1f5f1d5: Fix New tab behavior (authored by thsurrel).
Fix New tab behavior
Apr 26 2019, 1:50 PM
hindenburg closed D20836: Fix New tab behavior.
Apr 26 2019, 1:50 PM · Konsole

Apr 23 2019

hindenburg added a comment to D20744: [WIP] Apply new window flags only when necessary.

FYI, we'd need to test this in wayland as well - at least to avoid any regressions (if possible).

Apr 23 2019, 1:08 PM · Konsole

Apr 21 2019

hindenburg committed R319:61ed2c88a4e2: Remember last 'Save Output As' directory (authored by hindenburg).
Remember last 'Save Output As' directory
Apr 21 2019, 7:16 PM
hindenburg closed D18352: Remember last output save directory.
Apr 21 2019, 7:16 PM · Konsole
hindenburg added a comment to D16138: Create the default profile if it doesn't exist.

If the internal fallback profile has issues, let's fix that.

Apr 21 2019, 6:25 PM · Konsole

Apr 20 2019

hindenburg added a comment to D16138: Create the default profile if it doesn't exist.

I'm still not sure about this.

Apr 20 2019, 12:53 AM · Konsole

Apr 18 2019

hindenburg committed R319:c597c0aa4de7: add newline at end of file (authored by hindenburg).
add newline at end of file
Apr 18 2019, 2:35 AM
hindenburg committed R319:a25e50a9f7f1: Do not shadow variables (authored by hindenburg).
Do not shadow variables
Apr 18 2019, 2:27 AM
hindenburg committed R319:f7cd5267ad4c: Fix documentation tags (authored by hindenburg).
Fix documentation tags
Apr 18 2019, 1:50 AM
hindenburg committed R319:5d591a6a7d8d: std::stable_sort requires !(a < a) (authored by hindenburg).
std::stable_sort requires !(a < a)
Apr 18 2019, 1:38 AM
hindenburg committed R319:b3ceeb044d2c: std::stable_sort requires !(a < a) (authored by hindenburg).
std::stable_sort requires !(a < a)
Apr 18 2019, 1:35 AM
hindenburg added a comment to D20439: Fix alignment boundary.

This doesn't build - all the initializing code has to be re-arranged.

Apr 18 2019, 1:03 AM · Konsole

Apr 17 2019

hindenburg added reviewers for D20439: Fix alignment boundary: Konsole, hindenburg.
Apr 17 2019, 2:48 PM · Konsole
hindenburg added a comment to D20263: [WIP] Keep perceived contrast in random background color.

Thanks, I agree the colors look much better. This seems like a lot of code for just random backgrounds and I"m not sure how many people use that colorscheme.

Apr 17 2019, 2:45 PM · VDG, Konsole
hindenburg committed R319:e590afb08109: Ctrl-Tab should work in "split-only" view as well (authored by thsurrel).
Ctrl-Tab should work in "split-only" view as well
Apr 17 2019, 2:24 PM
hindenburg closed D20395: Ctrl-Tab should work in "split-only" view as well.
Apr 17 2019, 2:24 PM · Konsole
hindenburg accepted D20395: Ctrl-Tab should work in "split-only" view as well.
Apr 17 2019, 2:24 PM · Konsole
hindenburg committed R319:ee45b20e70f5: Fix warning "variable loses precision int to uint8" (authored by tcanabrava).
Fix warning "variable loses precision int to uint8"
Apr 17 2019, 2:09 PM
hindenburg closed D20440: Fix warning "variable loses precision int to uint8".
Apr 17 2019, 2:09 PM · Konsole
hindenburg accepted D20440: Fix warning "variable loses precision int to uint8".

Thanks there are over 180 of these warnings which I never got around to fixing.

Apr 17 2019, 2:09 PM · Konsole
hindenburg added a comment to D20395: Ctrl-Tab should work in "split-only" view as well.

I'm fine with this. Tomaz, any objection?

Apr 17 2019, 2:03 PM · Konsole

Apr 13 2019

hindenburg added a comment to D18352: Remember last output save directory.

Can you try this?

Apr 13 2019, 10:20 PM · Konsole
hindenburg added a comment to D20466: Rework scrollback settings.
In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session

Apr 13 2019, 9:13 PM · Konsole

Apr 12 2019

hindenburg committed R319:4b0df4454079: Add DesktopEntry to notifyrc (authored by broulik).
Add DesktopEntry to notifyrc
Apr 12 2019, 2:04 PM
hindenburg closed D20470: Add DesktopEntry to notifyrc.
Apr 12 2019, 2:04 PM · Konsole
hindenburg updated the summary of D20470: Add DesktopEntry to notifyrc.
Apr 12 2019, 1:45 PM · Konsole
hindenburg added a comment to D20466: Rework scrollback settings.

The 3 options should be a radio - you have to pick one - now you can de-select all 3

Apr 12 2019, 1:27 PM · Konsole
hindenburg added a comment to D20466: Rework scrollback settings.

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

This is already happening dudes.

Apr 12 2019, 1:25 PM · Konsole
hindenburg added a comment to D20466: Rework scrollback settings.

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

Apr 12 2019, 1:14 PM · Konsole

Apr 11 2019

hindenburg added a comment to D18352: Remember last output save directory.

It seems not isolated for different konsole instances.
Usually I have two konsole instance to save log files. one for serials com, one for adb log.

Apr 11 2019, 2:29 PM · Konsole
hindenburg added a comment to D20169: Add profile support interface for TerminalInterface.

Can someone from the frameworks group clarify if this can be committed for the next release 5.58 next month? I know years ago, we had a TerminalInterfaceV2 because the interface was changed.

Apr 11 2019, 3:56 AM · Frameworks

Apr 10 2019

hindenburg added a comment to D14200: Simplify newSession code.

and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0

Well sometimes it is set and sometimes not

Apr 10 2019, 2:27 PM · Konsole