hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (180 w, 5 d)
Availability
Available

Recent Activity

Yesterday

hindenburg committed R319:1c8ba770b176: Correct slot called for changing tab text color - not implemented (authored by hindenburg).
Correct slot called for changing tab text color - not implemented
Wed, Feb 20, 5:40 AM
hindenburg committed R319:b792c52f27bf: Remove old commented out code (authored by hindenburg).
Remove old commented out code
Wed, Feb 20, 4:29 AM
hindenburg committed R319:d187b43a6569: Correctly set icon when changing default profile in Manage dialog (authored by hindenburg).
Correctly set icon when changing default profile in Manage dialog
Wed, Feb 20, 3:55 AM
hindenburg committed R319:2a8b3dfb76e0: Use QStringLiteral in two test instances (authored by hindenburg).
Use QStringLiteral in two test instances
Wed, Feb 20, 2:13 AM
hindenburg committed R319:42eb5132e0da: Add close tab and create new tab on middle click event (authored by shubham).
Add close tab and create new tab on middle click event
Wed, Feb 20, 1:51 AM
hindenburg closed D15742: Add close tab and create new tab on middle click event.
Wed, Feb 20, 1:51 AM · Konsole
hindenburg updated the summary of D15742: Add close tab and create new tab on middle click event.
Wed, Feb 20, 1:50 AM · Konsole
hindenburg updated the summary of D15742: Add close tab and create new tab on middle click event.
Wed, Feb 20, 1:48 AM · Konsole
hindenburg accepted D15742: Add close tab and create new tab on middle click event.

Thanks for working on this everyone.

Wed, Feb 20, 1:44 AM · Konsole
hindenburg updated the summary of D15742: Add close tab and create new tab on middle click event.
Wed, Feb 20, 1:44 AM · Konsole
hindenburg added a comment to D16134: Secure history file.

I don't think we should put this in Konsole. Instead, we should let users either do disk encryption or other means. They can change the location of Konsole's file to be saved there.

Wed, Feb 20, 1:15 AM · Konsole
hindenburg added a reviewer for D19092: Add bison minimum version of 2.4.1 due to %code: Frameworks.
Wed, Feb 20, 1:11 AM · Frameworks
hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

yea give me a few

Wed, Feb 20, 1:09 AM · Konsole

Tue, Feb 19

hindenburg committed R319:0ed33b1211e0: Update copyright to 2019 (authored by hindenburg).
Update copyright to 2019
Tue, Feb 19, 2:20 AM

Sun, Feb 17

hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

Another idea: always allow middle-click to open new tabs, but just have the option toggle its close behavior. Then the string can be nice and simple.

Sun, Feb 17, 9:53 PM · Konsole
hindenburg added a comment to D18735: Improve built-in line/block characters drawing.

Thanks for working on this - I think perhaps this should be committed to master after the 19.04 is branched next month. Objections?

Sun, Feb 17, 7:55 PM · Konsole
hindenburg added a comment to D18870: Clean up/refactor selection code in TerminalDisplay.

This doesn't apply now - I believe the fix the extended bug was already committed w/ your other patch.

Sun, Feb 17, 7:53 PM · Konsole
hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

what should I now name the gui message? It will become quite big then.

Sun, Feb 17, 7:47 PM · Konsole
hindenburg requested review of D19092: Add bison minimum version of 2.4.1 due to %code.
Sun, Feb 17, 3:16 PM · Frameworks
hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

I can't get middle-click-in-empty-space-to-open-a-new-tab to work with this patch. Double-clicking currently does this, but for me this patch doesn't add that behavior.

Sun, Feb 17, 12:26 AM · Konsole

Sat, Feb 16

hindenburg added a comment to D18352: Remember last output save directory.

Tao, are you planning on working on the issues brought up?

Sat, Feb 16, 7:27 PM · Konsole
hindenburg committed R319:6ba7907ccb27: Change depreciated KAboutData::setProgramIconName() (authored by hindenburg).
Change depreciated KAboutData::setProgramIconName()
Sat, Feb 16, 7:04 PM
hindenburg committed R319:421019de38f9: Change QStyleOptionViewItemV3 and V4 to QStyleOptionViewItem (authored by hindenburg).
Change QStyleOptionViewItemV3 and V4 to QStyleOptionViewItem
Sat, Feb 16, 7:04 PM
hindenburg committed R319:d3d2653b1b72: Remove -Wno-deprecated-declarations (authored by hindenburg).
Remove -Wno-deprecated-declarations
Sat, Feb 16, 7:04 PM
hindenburg committed R319:392c7d0fcc52: Remove dead code in TerminalDisplay (authored by tcanabrava).
Remove dead code in TerminalDisplay
Sat, Feb 16, 5:21 PM
hindenburg closed D18520: Remove dead code in TerminalDisplay.
Sat, Feb 16, 5:21 PM · Konsole
hindenburg accepted D18520: Remove dead code in TerminalDisplay.

Thanks

Sat, Feb 16, 5:21 PM · Konsole
hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

The code actually closes when on a tab and opens a new tab when over an empty space. You'll need to update the message and GUI text.

Sat, Feb 16, 5:09 PM · Konsole
hindenburg added a comment to D17643: Multiple Splits per Tab.

The 19.04 branch will be created around March 14th. What do you think about committing this to master after the branch? That should give everyone 2-3 months in master to resolve any issues and get any apps using the KonsolePart to get fixed.

Sat, Feb 16, 3:28 PM · Konsole
hindenburg closed D18858: Some trivial cleanup of the TerminalDisplay::hotSpotRegion() function.
Sat, Feb 16, 3:13 PM · Konsole
hindenburg committed R319:7c831e188dcf: Some trivial cleanup of the TerminalDisplay::hotSpotRegion() function (authored by sandsmark).
Some trivial cleanup of the TerminalDisplay::hotSpotRegion() function
Sat, Feb 16, 3:13 PM
hindenburg accepted D18858: Some trivial cleanup of the TerminalDisplay::hotSpotRegion() function.

Thanks

Sat, Feb 16, 3:12 PM · Konsole
hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

Thanks I'll look at this weekend

Sat, Feb 16, 3:06 PM · Konsole
hindenburg committed R319:ed6d8b702fd5: Extend character clipping by grouping it with spaces (authored by mglb).
Extend character clipping by grouping it with spaces
Sat, Feb 16, 2:50 PM
hindenburg closed D18784: Extend character clipping by grouping it with spaces.
Sat, Feb 16, 2:50 PM · Konsole
hindenburg accepted D18784: Extend character clipping by grouping it with spaces.

I don't see any issues w/ this. The only thing that might be fixed later could be when moving the cursor, the full image/character would be highlighted (terminator does this).

Sat, Feb 16, 2:45 PM · Konsole

Fri, Feb 15

hindenburg added inline comments to D14200: Simplify newSession code.
Fri, Feb 15, 3:46 PM · Konsole

Tue, Feb 12

hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

can you reopen this pls? we need to add a GUI option to disable the closing part.

Tue, Feb 12, 6:39 PM · Konsole
hindenburg added inline comments to D18735: Improve built-in line/block characters drawing.
Tue, Feb 12, 6:36 PM · Konsole
hindenburg added a comment to D17742: Clean up content rect in TerminalDisplay.

Thanks still working on reading these changes.

Tue, Feb 12, 6:18 PM · Konsole
hindenburg added a comment to D18606: [WIP]Close tab on middle mouse button event.

I'd rather use the other one D15742 - we still need a GUI option added

Tue, Feb 12, 4:21 PM · Konsole
hindenburg added a comment to D16837: Persist after closing last tab when running in background mode.

Any update on having this reviewed? If it's unlikely to make it into Konsole would it be possible to still get a review of the code since I'm curious if it could be improved in any way. I was thinking too that this could be added as either checkbox option or as an extra command line parameter if having it as the default behaviour wasn't wanted.

Tue, Feb 12, 3:39 AM · Konsole

Mon, Feb 11

hindenburg added a comment to D18784: Extend character clipping by grouping it with spaces.

The output looks fine and I don't see anything wrong w/ the code. However, when selecting one of these wide chars, the "right half" selection grabs the space while the "left half" selection grabs the entire character. If that's something that can't be fixed or is the preferred way to handle that, then OK.

Mon, Feb 11, 10:48 PM · Konsole
hindenburg committed R319:f7d54a69b60d: Fix crash when extending selection (authored by sandsmark).
Fix crash when extending selection
Mon, Feb 11, 10:16 PM
hindenburg closed D18862: Fix crash when extending selection.
Mon, Feb 11, 10:16 PM · Konsole
hindenburg accepted D18862: Fix crash when extending selection.

Ok good thanks I can't get it to crash and don't see any regressions

Mon, Feb 11, 10:15 PM · Konsole
hindenburg committed R319:dd6cddfd9944: Use QOverload instead of static_cast for connection overloads (authored by hindenburg).
Use QOverload instead of static_cast for connection overloads
Mon, Feb 11, 9:47 PM
hindenburg committed R319:c86d468e3620: Add option to have close button on each tab (authored by marssola).
Add option to have close button on each tab
Mon, Feb 11, 8:59 PM
hindenburg closed D17814: Add option to have close button on each tab.
Mon, Feb 11, 8:59 PM · Konsole
hindenburg accepted D17814: Add option to have close button on each tab.

Looks fine - thanks - we can leave the default as-is for now

Mon, Feb 11, 8:58 PM · Konsole

Fri, Feb 8

hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

This one works for me - the other doesn't

Fri, Feb 8, 1:42 PM · Konsole
hindenburg updated the summary of D17814: Add option to have close button on each tab.
Fri, Feb 8, 3:48 AM · Konsole
hindenburg added a comment to D17814: Add option to have close button on each tab.

Can you rebase this please? A lot of the code has changed since Dec

Fri, Feb 8, 3:44 AM · Konsole
hindenburg committed R319:6adea54e2b4f: Add BookMarkTest - currently only testing URL (authored by hindenburg).
Add BookMarkTest - currently only testing URL
Fri, Feb 8, 3:43 AM
hindenburg added a comment to D18606: [WIP]Close tab on middle mouse button event.

I can't get this code to work - middle click doesn't do anything - however, https://phabricator.kde.org/D15742 does work - I assume you didn't see that as it duplicate the new/close middle button.

Fri, Feb 8, 3:29 AM · Konsole

Wed, Feb 6

hindenburg added a comment to D18606: [WIP]Close tab on middle mouse button event.

@hindenburg Are you okay with this after me and nate have explained it's pros? If not, I will abandon this.

Wed, Feb 6, 3:16 PM · Konsole

Sat, Feb 2

hindenburg added a comment to D18520: Remove dead code in TerminalDisplay.

looks fine w/ the one minor nitpick

Sat, Feb 2, 8:53 PM · Konsole
hindenburg added reviewers for D18587: [WIP ] terminal headers: hindenburg, Konsole.
Sat, Feb 2, 7:45 PM
hindenburg added a comment to D17643: Multiple Splits per Tab.

It appears this causing yakuake to crash when closing a tab/session. I typically try to test the konsolepart using dolphin/yakuake/kdevelop/demo_konsolepart - it can be a pain depending on what distro/setup your using to get them to use the code you're testing.

Sat, Feb 2, 7:43 PM · Konsole

Wed, Jan 30

hindenburg added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.

A quick look running and I'm not a big fan: 1) It doesn't handle split views (assume that after the split tab changes go in, this could be fix), 2) if only tab, don't show anything, 3) releasing the Ctrl+Tab should close popup and go to selected 4) I'm tempted to have a way to turn off the popup.

Wed, Jan 30, 3:10 PM · Konsole
hindenburg added a comment to D18606: [WIP]Close tab on middle mouse button event.

I've been against this in the past - it is too easy to accidentally close a tab. Unlike other KDE apps, accidentally closing a Konsole tab would be really bad IMHO.

Wed, Jan 30, 3:02 PM · Konsole
hindenburg added a comment to D18154: Add a "Session Switcher" via Ctrl + Tab.

I thought this had to wait until the split tabs code went in - if not I can review now

Wed, Jan 30, 1:29 PM · Konsole

Sat, Jan 26

hindenburg added a comment to D17643: Multiple Splits per Tab.
  • Dim unfocused terminals
Sat, Jan 26, 4:37 AM · Konsole

Fri, Jan 25

hindenburg added a comment to D17643: Multiple Splits per Tab.

minor nitpicks

Fri, Jan 25, 3:56 AM · Konsole
hindenburg added a comment to D17643: Multiple Splits per Tab.

I'm still testing - I also notice it is hard to see the splitters - often I get another's view scrollbar confused w/ the splitter. I also notice some issues w/ how multiple splits hare calculated; I would think the other view would not change size.
If anyone could review the code, I'd appreciate more people looking now.

Fri, Jan 25, 3:34 AM · Konsole

Jan 17 2019

hindenburg added a comment to D17643: Multiple Splits per Tab.

I just tested here:

  • if you detach the *focused terminal*, it takes the size of the old window, ie (bigger than it was)
  • if you detach the *current tab*, it takes the tab of the old window (should be the same size)

    which one are you hitting? which one do you think it's wrong?

    you want the detached *focused terminal* to keep the same size after detached?
Jan 17 2019, 2:45 PM · Konsole
hindenburg added a comment to D17643: Multiple Splits per Tab.

Testing now.

  1. Split view either vertical or horizontal
  2. detach that tab
  3. the detached window is much bigger than the original window.
Jan 17 2019, 2:18 PM · Konsole

Jan 14 2019

hindenburg committed R319:313f9b0335bf: Correct const range-loop (authored by hindenburg).
Correct const range-loop
Jan 14 2019, 3:54 AM
hindenburg committed R319:2620b48ed7ce: Remove , at end of enumerator lists C++98 (authored by hindenburg).
Remove , at end of enumerator lists C++98
Jan 14 2019, 3:34 AM
hindenburg committed R319:14e004085dbd: Add param info (authored by hindenburg).
Add param info
Jan 14 2019, 2:12 AM
hindenburg committed R319:e5b2db2a74fc: Remove text about Qt5.9 (authored by hindenburg).
Remove text about Qt5.9
Jan 14 2019, 1:43 AM
hindenburg committed R319:ed95869ccc1f: Since we now require Qt5.9+, remove info about < Qt5.9 (authored by hindenburg).
Since we now require Qt5.9+, remove info about < Qt5.9
Jan 14 2019, 1:38 AM
hindenburg committed R319:29fb688d247f: Change variable names to avoid shadowing (authored by hindenburg).
Change variable names to avoid shadowing
Jan 14 2019, 1:30 AM

Jan 3 2019

hindenburg abandoned D14262: fix emoji rendering.
Jan 3 2019, 3:38 AM · Konsole
hindenburg commandeered D14262: fix emoji rendering.
Jan 3 2019, 3:38 AM · Konsole

Jan 1 2019

hindenburg committed R319:9cfd6695d82b: Remove extra ; (authored by hindenburg).
Remove extra ;
Jan 1 2019, 9:07 PM
hindenburg committed R319:48cdea03e4f4: Remove space at end of license line (authored by hindenburg).
Remove space at end of license line
Jan 1 2019, 9:03 PM
hindenburg added a comment to D17744: New search result look, resurrected.

This looks rather bad on some of my color schemes. How do we handle where this looks bad w/ color schemes?

Jan 1 2019, 3:03 AM · Konsole
hindenburg added a comment to D17814: Add option to have close button on each tab.

The default should be None as it is now

Jan 1 2019, 1:58 AM · Konsole

Dec 31 2018

hindenburg abandoned D7068: Add switch to alternate tab action.
Dec 31 2018, 4:09 AM · Konsole
hindenburg commandeered D7068: Add switch to alternate tab action.

A lot of the code has changed since this patch - I've committed a patch that should do what you want - if you are running master Konsole, give it a try. If not, it will be in released April 2019.

Dec 31 2018, 4:09 AM · Konsole
hindenburg committed R319:e97974fa1513: Add ability to toggle/jump between two tabs (authored by hindenburg).
Add ability to toggle/jump between two tabs
Dec 31 2018, 4:08 AM

Dec 30 2018

hindenburg abandoned D8464: Add support for DECSCUSR..
Dec 30 2018, 11:28 PM · Konsole
hindenburg commandeered D8464: Add support for DECSCUSR..

Thanks for the effort/code - it appears this has since been fixed.

Dec 30 2018, 11:28 PM · Konsole
hindenburg added a comment to D15570: Use new connection style.

Are you working on this? I can help along if you want.

Dec 30 2018, 11:23 PM · Konsole
hindenburg added a comment to D15742: Add close tab and create new tab on middle click event.

Are you still planning on working on this to just have the middle-click to open a new tab?

Dec 30 2018, 11:19 PM · Konsole
hindenburg added a comment to D14262: fix emoji rendering.

Is this still needed?

Dec 30 2018, 11:16 PM · Konsole
hindenburg added a comment to D16138: Create the default profile if it doesn't exist.

well I'm a bit confused why I don't see your results under the current master branch - I've tried 2 different VMs and verified there are no konsole files anywhere and get the results I mentioned above.

I'll also test those today to verify the results.
Kurt, do you mind telling us what vm's you used so I can replicate?

I've tried one of my neon desktops twice and a freebsd VM twice.

Dec 30 2018, 11:15 PM · Konsole
hindenburg committed R319:d689ba5403ce: Profile shortcuts switch profile instead of opening new tab (authored by thsurrel).
Profile shortcuts switch profile instead of opening new tab
Dec 30 2018, 11:08 PM
hindenburg closed D17374: Profile shortcuts switch profile instead of opening new tab.
Dec 30 2018, 11:08 PM · Konsole
hindenburg accepted D17374: Profile shortcuts switch profile instead of opening new tab.

This is very nice - thanks for working on this and staying with it. Good catch with the read only code.

Dec 30 2018, 11:07 PM · Konsole
hindenburg committed R319:137ee3307893: Properly show "/" for %d tab title format (authored by mglb).
Properly show "/" for %d tab title format
Dec 30 2018, 11:01 PM
hindenburg closed D17866: Properly show "/" for %d tab title format.
Dec 30 2018, 11:01 PM · Konsole
hindenburg accepted D17866: Properly show "/" for %d tab title format.

thanks

Dec 30 2018, 11:01 PM · Konsole
hindenburg committed R319:79c31d359f0e: Show valid subprocess CWD for %D tab title format (authored by mglb).
Show valid subprocess CWD for %D tab title format
Dec 30 2018, 10:59 PM
hindenburg closed D17865: Show valid subprocess CWD for %D tab title format.
Dec 30 2018, 10:59 PM · Konsole
hindenburg accepted D17865: Show valid subprocess CWD for %D tab title format.

Looks fine - thanks - I notice this seems to fix %u which hasn't worked for a while it seems

Dec 30 2018, 10:58 PM · Konsole
hindenburg committed R319:80b09936a438: Add some basic checks for invalid values (authored by hindenburg).
Add some basic checks for invalid values
Dec 30 2018, 10:38 PM
hindenburg committed R319:d801b2d015f8: Uncompress any colorscheme archive downloaded from KNewStuff store (authored by hindenburg).
Uncompress any colorscheme archive downloaded from KNewStuff store
Dec 30 2018, 7:26 PM
hindenburg committed R319:ca133ca3aad8: Add copyright and license (authored by hindenburg).
Add copyright and license
Dec 30 2018, 4:19 PM