♟ hindenburg

ColorScheme: fix stack-use-after-scope detected by ASAN

What's the ping? Should Konsole ship a default profile? and if so which one? or fix this code?

Add QT_NO_FOREACH now that we do not use any foreach

Replace Q_DECL_OVERRIDE with override

Fix loop anaylysis issue

Fix implicit conversion increases floating-point precision

Paste urls of local files as a list of quoted strings

You can use phabricator for now if that works for you - setting up a merge request https://invent.kde.org/kde/konsole/merge_requests would also work. Until phabricator is removed, it is up to you which patch is easier to maintain.

Correctly trigger a Konsole window when using single process

After this patch, you'd need to add -DENABLE_CCACHE=TRUE to enable ccache - I don't really see this as a big hurdle and 19.12 is around the corner so I'd like some consensus here.

Fix tabs not indicating activity

In D25151#559473, @anthonyfieroni wrote:

I see it in line above, but using qobject_cast and not checking for nullptr is waste of time, say if you're sure in type use static_cast, if not check result of qobject_cast against nullptr.

Sorry I didn't see your changes before I did mine.

What's the status of this?

Fix OSC sequence parsing

Use uint for ucs4 characters

Are you still working on this or would you like this committed for 19.12?

Add missing setFocusProxy() call in ViewManager

Add TODO about obsolete setWorldMatrix

Thanks, I'll test shortly

Port obsoleted QDrag->start() to exec()

Port depreciated KRun::binaryName

Use QFile::encodeName()

Fix search bar placement

Move search bar positioning code to TerminalDisplay

Debug: print path to history files in /proc/pid/fd/

unlink() history file after opening it

Remove unused argument from history-related classes

tests: fix macos build failure

Fix scrollbar position

Add a "Do not ask again" option to close session dialog

Allow loading of pre 19.08 session files

Add 19.12 changelog; unreleased ATM

Keep empty lines when "trim leading spaces" is enabled

Correct split view and keyboard navigation

Fix split view crashes when using keyboard navigation with some themes

Make sure font weight value is within allowed range

Correct split view and keyboard navigation

Fix split view crashes when using keyboard navigation with some themes

Remove env variable KONSOLE_PROFILE_NAME

Add dbus profile() to return profile name of current session

Fix cmake endif() mis-matching arguments

Fix the fallback code used when restoring session fails

On the 19.08 branch I get a lot of these when exiting a konsole session that uses this code. I don't see this warning on master.

Fix the fallback code used when restoring session fails

Thanks, I'll look at the other patch shortly. This regression should have been caught in my testing.

This looks fine - I'll test the restore patch

clean up includes - remove KIO::Job

It is not obvious toUcs4 returns QVector<uint> so remove auto

Merge branch 'konstantink/konsole-remove-deprecated-qcopy'

In D20263#517529, @hindenburg wrote:

FYI, these are showing up in the builds

https://build.kde.org/job/Applications/job/konsole/job/kf5-qt5%20SUSEQt5.12/lastSuccessfulBuild/warnings30Result/

ColorScheme.cpp:314, GNU Make + GNU C Compiler (gcc), Priority: Normal

assignment from temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]

ColorScheme.cpp:316, GNU Make + GNU C Compiler (gcc), Priority: Normal

assignment from temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]

Add scrollbuttons for tabs when tabbar is full

fix memory leaks (coverity)

fix memory leak (coverity)

Remove leading/trailingWhitespace() - they were never used

Remove currentBookmarkList() - hasn't been used in years

Remove supportsTabs() - hasn't been used in years

hotSpotsAtLine() has not been used in years

config-konsole.h is not installed; krazy has been fixed

Use QThread::sleep instead of sleep/usleep

Correct parameter's names

Initialize variable in constructor (coverity/cppcheck)

Use std::any_of instead of loop

Make the layout better

Restore "Show 'new tab' button" option in Konsole Settings

Add note about duplicates in sub-folders

Do not allow adding duplicates in bookmarks

Correct parameter documentation

use 'using' instead of 'typedef'

avoid repeating the return type; use a braced initializer list instead

FYI, these are showing up in the builds

Explicitly add data type s/unsigned/unsigned int/

Tweak tab title options: home and Bourne prompt sigils

Correct include guard name

hsluv add copyright emails - taken from their github repos

if possible, use https://invent.kde.org/kde/konsole/merge_requests instead of phrabicator. I don't mind using phrabicator while it is still up abut I often forget to amend the author.

Fix crash on "Close Current Tab" handling

Merge branch 'konstantink/konsole-small-cleanup'

Fix crash on "Close Current Tab" handling

Thanks a lot for fixing this - please don't add // italic/bold to commit messages as it messes up what shows up in the logs

hindenburg (Kurt Hindenburg)
User

Projects

Calendar

Today

Tomorrow

Sunday

User Details

Recent Activity
View All

Yesterday

Fri, Dec 6

Wed, Dec 4

Mon, Nov 25

Fri, Nov 22

Nov 10 2019

Nov 7 2019

Nov 2 2019

Oct 28 2019

Oct 24 2019

Oct 20 2019

Oct 17 2019

Oct 8 2019

Oct 6 2019

Oct 5 2019

Oct 3 2019

Oct 2 2019

Sep 27 2019

Sep 9 2019

Sep 6 2019

Sep 2 2019

Sep 1 2019

Aug 30 2019

Aug 29 2019

Aug 28 2019

Aug 25 2019

Aug 24 2019

Aug 23 2019

Aug 22 2019

Aug 20 2019

Aug 18 2019

hindenburg (Kurt Hindenburg)User