hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (162 w, 3 d)
Availability
Available

Recent Activity

Sun, Oct 14

hindenburg added a comment to D16134: Secure history file.

I think this has to be cmake optional check and then a UI checkbox for user to disable. If you're not familiar w/ the UI, I or someone else can do that. We can try to get this in 18.12 though I see no need to rush it.

Sun, Oct 14, 6:36 PM · Konsole

Sat, Oct 13

hindenburg added a comment to D16134: Secure history file.

I need to double-check if frameworks/plasma require QCA; if they do, then it should be installed for Konsole

Sat, Oct 13, 2:51 PM · Konsole

Fri, Oct 12

hindenburg added a comment to D16134: Secure history file.

I'd prefer having QCA as an optional dependent. Did you do any benchmarks on if this slows Konsole down?

Fri, Oct 12, 2:04 PM · Konsole
hindenburg added a comment to D16138: Create the default profile if it doesn't exist.

I don't recall off-hand what happens w/o these 2 files - most distros include profiles

Fri, Oct 12, 2:42 AM · Konsole
hindenburg added reviewers for D16138: Create the default profile if it doesn't exist: Konsole, hindenburg.
Fri, Oct 12, 2:39 AM · Konsole

Thu, Oct 11

hindenburg added a comment to D16033: Fix double render when scrolling with visible search bar.

It appears this causes File->Print Screen save as pdf to crash

Thu, Oct 11, 3:45 AM · Konsole

Wed, Oct 10

hindenburg added a comment to D16033: Fix double render when scrolling with visible search bar.

I can confirm this fixes the bug - it will need more testing to avoid any regressions

Wed, Oct 10, 3:21 AM · Konsole

Tue, Oct 9

hindenburg added a comment to D16033: Fix double render when scrolling with visible search bar.

I can confirm the bug

Tue, Oct 9, 2:27 PM · Konsole
hindenburg committed R319:994fdae6f5f2: Add license and copyright (authored by hindenburg).
Add license and copyright
Tue, Oct 9, 1:33 AM

Sun, Oct 7

hindenburg added a comment to D16010: Re-introduce bounds check removed in fcea6742c142fdbfdf53d17c862bfae7652fae3b.

For some reason arc moves the Screen.cpp file - can you re-do the patch please? Or I can just manually commit it.

Sun, Oct 7, 2:26 PM · Konsole
hindenburg added a comment to D15915: Antialias line drawing characters.

Kurt, please use 'git commit --author=...' to give proper attribution to patches from contributors.

Thanks for the reminder. I wish arc had a way to notify me when landing that the author isn't correct.

Sun, Oct 7, 2:14 PM · Konsole

Sat, Oct 6

hindenburg committed R319:aab3056e621d: Use isEmpty() rather than size() > 0 (authored by hindenburg).
Use isEmpty() rather than size() > 0
Sat, Oct 6, 7:43 PM
hindenburg committed R319:7f4b89f79258: Add braces around if statements (authored by hindenburg).
Add braces around if statements
Sat, Oct 6, 7:37 PM
hindenburg committed R319:c8cb7f9ead8c: Remove nullptr check as deleting null pointer has no effect (authored by hindenburg).
Remove nullptr check as deleting null pointer has no effect
Sat, Oct 6, 7:10 PM
hindenburg committed R319:37493241ab31: Avoid implicit bool conversion (authored by hindenburg).
Avoid implicit bool conversion
Sat, Oct 6, 6:54 PM
hindenburg committed R319:15bf4d7cc73f: Fix readability static accessed through instance (authored by hindenburg).
Fix readability static accessed through instance
Sat, Oct 6, 6:54 PM
hindenburg committed R319:1a4500ea819c: Avoid implicit bool conversions (authored by hindenburg).
Avoid implicit bool conversions
Sat, Oct 6, 5:54 PM
hindenburg committed R319:2d330c005b74: Remove redundant return statements (authored by hindenburg).
Remove redundant return statements
Sat, Oct 6, 5:54 PM
hindenburg committed R319:67b8c3f8dc1d: Fix system language dependent unit test (authored by hindenburg).
Fix system language dependent unit test
Sat, Oct 6, 5:21 PM
hindenburg closed D15923: Fix system language dependent unit test.
Sat, Oct 6, 5:21 PM · Konsole
hindenburg accepted D15923: Fix system language dependent unit test.

Thanks, nice catch

Sat, Oct 6, 5:09 PM · Konsole
hindenburg updated the summary of D15923: Fix system language dependent unit test.
Sat, Oct 6, 5:07 PM · Konsole
hindenburg updated the test plan for D15923: Fix system language dependent unit test.
Sat, Oct 6, 5:06 PM · Konsole
hindenburg committed R319:ed5fa1f855a0: Antialias line drawing characters (authored by hindenburg).
Antialias line drawing characters
Sat, Oct 6, 4:39 PM
hindenburg closed D15915: Antialias line drawing characters.
Sat, Oct 6, 4:39 PM · Konsole
hindenburg updated the summary of D15915: Antialias line drawing characters.
Sat, Oct 6, 4:33 PM · Konsole
hindenburg accepted D15915: Antialias line drawing characters.

Thanks

Sat, Oct 6, 4:31 PM · Konsole

Wed, Oct 3

hindenburg committed R319:e74cf6c36642: Use new character width code based on Unicode 11 (authored by mglb).
Use new character width code based on Unicode 11
Wed, Oct 3, 3:12 PM
hindenburg closed D15758: Use new character width code based on Unicode 11.
Wed, Oct 3, 3:12 PM · Konsole
hindenburg accepted D15758: Use new character width code based on Unicode 11.
Wed, Oct 3, 3:11 PM · Konsole
hindenburg updated the test plan for D15758: Use new character width code based on Unicode 11.
Wed, Oct 3, 3:05 PM · Konsole
hindenburg updated the summary of D15758: Use new character width code based on Unicode 11.
Wed, Oct 3, 3:03 PM · Konsole

Tue, Oct 2

hindenburg added a comment to D15758: Use new character width code based on Unicode 11.

Thanks, I don't see anything obviously wrong; let me test it a bit more and we'll get it into master for more testing.

Tue, Oct 2, 1:57 AM · Konsole

Mon, Oct 1

hindenburg added a comment to D15828: Restore new tab behavior.

I thought this was fixed as well but the 'New tab behavior" setting appears to be ignored.

Mon, Oct 1, 2:22 PM · Konsole

Sun, Sep 30

hindenburg committed R319:bfb91aac49f2: Check clipboard->mimeData() is valid (authored by hindenburg).
Check clipboard->mimeData() is valid
Sun, Sep 30, 5:48 PM
hindenburg closed D15794: Check clipboard->mimeData() is valid.
Sun, Sep 30, 5:48 PM · Konsole
hindenburg accepted D15794: Check clipboard->mimeData() is valid.

The note I added is not a show stopper - I'll fix that later.

Sun, Sep 30, 5:48 PM · Konsole
hindenburg updated the summary of D15794: Check clipboard->mimeData() is valid.
Sun, Sep 30, 5:44 PM · Konsole
hindenburg added inline comments to D15794: Check clipboard->mimeData() is valid.
Sun, Sep 30, 5:20 PM · Konsole
hindenburg added a comment to D15758: Use new character width code based on Unicode 11.

This needs a rebase as well

Sun, Sep 30, 4:42 PM · Konsole
hindenburg added a comment to D15794: Check clipboard->mimeData() is valid.

Thanks for that patch - I'll test it shortly although I don't think I have a laptop w/ wayland on it.

Sun, Sep 30, 4:27 PM · Konsole
hindenburg committed R319:5f32cb3c44f2: Add a tool for generating character width tables (authored by mglb).
Add a tool for generating character width tables
Sun, Sep 30, 4:22 PM
hindenburg closed D15757: Add a tool for generating character width tables.
Sun, Sep 30, 4:22 PM · Konsole
hindenburg accepted D15757: Add a tool for generating character width tables.

Thanks for taking the time to do this

Sun, Sep 30, 4:13 PM · Konsole

Fri, Sep 28

hindenburg added reviewers for D15794: Check clipboard->mimeData() is valid: Konsole, hindenburg.
Fri, Sep 28, 2:18 PM · Konsole
hindenburg reopened D13854: Refactor Profile and ColorScheme.

This was reverted by Tomaz

Fri, Sep 28, 2:05 PM · Konsole

Thu, Sep 27

hindenburg added a comment to D15757: Add a tool for generating character width tables.

This doesn't apply cleanly w/ 'arc patch D15757' - not sure if I need to do something special or if you need to rebase.

Thu, Sep 27, 2:11 PM · Konsole
hindenburg committed R319:0f33ee504bc2: Move character width functions to Character class (authored by mglb).
Move character width functions to Character class
Thu, Sep 27, 2:46 AM
hindenburg closed D15756: Move character width functions to Character class.
Thu, Sep 27, 2:46 AM · Konsole
hindenburg accepted D15756: Move character width functions to Character class.

LGTM thanks for continuing to work on this

Thu, Sep 27, 2:45 AM · Konsole
hindenburg added a comment to D15742: Handle middle click on tabs.

Unless you want to add another option for this, with default as-it, I'll veto the close tab click. I don't see an issue w/ the new tab part.

Thu, Sep 27, 1:55 AM · Konsole
hindenburg committed R319:3dad0d6209fc: Ignore default null eol in Session::sendTextToTerminal (authored by hindenburg).
Ignore default null eol in Session::sendTextToTerminal
Thu, Sep 27, 1:54 AM
hindenburg closed D15732: Ignore default null eol in Session::sendTextToTerminal.
Thu, Sep 27, 1:54 AM · Konsole

Wed, Sep 26

hindenburg accepted D15732: Ignore default null eol in Session::sendTextToTerminal.

thanks

Wed, Sep 26, 3:13 AM · Konsole
hindenburg added a comment to D15742: Handle middle click on tabs.

I really dislike the middle click tab = close tab; we don't want to provide an easy accidentally way to close tabs IMHO.

Wed, Sep 26, 2:57 AM · Konsole

Sun, Sep 23

hindenburg added a comment to D13854: Refactor Profile and ColorScheme.

Can you rebase this please? It applies cleanly but won't land for some reason.

Sun, Sep 23, 3:37 PM · Konsole
hindenburg retitled D13854: Refactor Profile and ColorScheme from Return the default ColorScheme in case of a failure to Refactor Profile and ColorScheme.
Sun, Sep 23, 3:33 PM · Konsole
hindenburg accepted D13854: Refactor Profile and ColorScheme.
Sun, Sep 23, 3:31 PM · Konsole

Tue, Sep 18

hindenburg added a comment to D13854: Refactor Profile and ColorScheme.

I appear to have forgotten about this one - I'll look at it now

Tue, Sep 18, 1:50 PM · Konsole
hindenburg added a reviewer for D15570: Use new connection style: Konsole.
Tue, Sep 18, 1:49 PM · Konsole
hindenburg committed R319:fb6c0eeed151: Add option to reverse URL hint numbering (authored by hindenburg).
Add option to reverse URL hint numbering
Tue, Sep 18, 1:41 PM
hindenburg closed D15362: Add option to reverse URL hint numbering.
Tue, Sep 18, 1:41 PM · Konsole
hindenburg committed R319:7907b7a88fd3: Add editorconfig (authored by lbergdoll).
Add editorconfig
Tue, Sep 18, 1:36 PM
hindenburg closed D15383: Add editorconfig.
Tue, Sep 18, 1:36 PM · Konsole
hindenburg accepted D15362: Add option to reverse URL hint numbering.

thanks

Tue, Sep 18, 1:32 PM · Konsole
hindenburg accepted D15383: Add editorconfig.
Tue, Sep 18, 1:32 PM · Konsole

Mon, Sep 17

hindenburg committed R319:209d43f9866a: Remove MimeType related code (authored by tcanabrava).
Remove MimeType related code
Mon, Sep 17, 2:28 PM
hindenburg closed D15378: Remove MimeType related code.
Mon, Sep 17, 2:28 PM · Konsole
hindenburg accepted D15378: Remove MimeType related code.

thanks

Mon, Sep 17, 2:26 PM · Konsole
hindenburg added inline comments to D15362: Add option to reverse URL hint numbering.
Mon, Sep 17, 2:25 PM · Konsole

Sun, Sep 16

hindenburg added a comment to D15362: Add option to reverse URL hint numbering.

I don't have any strong objections

Sun, Sep 16, 11:25 PM · Konsole
hindenburg added a comment to D15378: Remove MimeType related code.

Does there need to be a followup change to add this back to DetachableTabBar as you mention in your summary?

Sun, Sep 16, 11:02 PM · Konsole
hindenburg updated the summary of D15383: Add editorconfig.
Sun, Sep 16, 10:50 PM · Konsole
hindenburg committed R319:6330bb82bb74: Fixes crashes related to closing tabs with splits (authored by tcanabrava).
Fixes crashes related to closing tabs with splits
Sun, Sep 16, 10:28 PM
hindenburg closed D15379: Fixes crashes related to closing tabs with splits.
Sun, Sep 16, 10:28 PM · Konsole
hindenburg accepted D15379: Fixes crashes related to closing tabs with splits.
Sun, Sep 16, 10:27 PM · Konsole
hindenburg added a comment to D15383: Add editorconfig.

I'm not against this per se but why does every application need this in its source folder?

For reference: https://editorconfig.org/

How else would you achieve this?

Sun, Sep 16, 7:51 PM · Konsole
hindenburg added a comment to D15383: Add editorconfig.

I'm not against this per se but why does every application need this in its source folder?

Sun, Sep 16, 5:30 PM · Konsole
hindenburg committed R319:8fd74e8b74be: Fix tab attach/reattach and simplify tab dnd code (authored by tcanabrava).
Fix tab attach/reattach and simplify tab dnd code
Sun, Sep 16, 4:48 PM
hindenburg closed D15377: Fix tab attach/reattach and simplify tab dnd code.
Sun, Sep 16, 4:48 PM · Konsole
hindenburg accepted D15377: Fix tab attach/reattach and simplify tab dnd code.
Sun, Sep 16, 4:36 PM · Konsole
hindenburg updated the summary of D15377: Fix tab attach/reattach and simplify tab dnd code.
Sun, Sep 16, 4:36 PM · Konsole

Sep 15 2018

hindenburg added a comment to D15377: Fix tab attach/reattach and simplify tab dnd code.

looks fine ATM - let me test it some more - I'll go through the others this weekend

Sep 15 2018, 7:17 PM · Konsole

Sep 5 2018

hindenburg added a comment to D14595: Fixes Tabbar Drag and Drop.

Closing this review because I'm splitting this in many small reviews to ease the review request.

Sep 5 2018, 2:38 PM · Konsole

Aug 21 2018

hindenburg added a comment to D14798: Scope the glib hack to older Qt versions.

Is this a compile-time or runtime version check?

Aug 21 2018, 2:47 AM · Konsole

Aug 18 2018

hindenburg committed R319:2c9cbdd1d0ac: Scope the glib hack to only < Qt5.11.2 versions (authored by svuorela).
Scope the glib hack to only < Qt5.11.2 versions
Aug 18 2018, 10:55 PM

Aug 17 2018

hindenburg committed R319:b2c8322a461b: Scope the glib hack to only < Qt5.11.2 versions (authored by svuorela).
Scope the glib hack to only < Qt5.11.2 versions
Aug 17 2018, 1:03 PM
hindenburg closed D14798: Scope the glib hack to older Qt versions.

https://cgit.kde.org/konsole.git/commit/?id=b2c8322a461ba6506f3a89069ba36153137e2be5

Aug 17 2018, 12:06 PM · Konsole

Aug 14 2018

hindenburg added a comment to D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

The concern I have about this is someone is going to wait to disable this, change the actions, etc. It is too bad this can't be done in the shortcut dialog/interface.

Aug 14 2018, 12:39 PM · Konsole
hindenburg added a reviewer for D14798: Scope the glib hack to older Qt versions: Konsole.
Aug 14 2018, 2:44 AM · Konsole

Aug 7 2018

hindenburg added a comment to D14595: Fixes Tabbar Drag and Drop.
  1. Don't allow a window that has only 1 tab to be DND out to create a new window with the same one tab
  2. We still have the issue where newly created window's text is not visible until some other interaction.
Aug 7 2018, 1:15 PM · Konsole

Aug 3 2018

hindenburg added a comment to D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.

Thanks for the fix! BTW for future reference, the preferred workflow for bugfixes is to commit to the stable branch (Applications/18.08` in this case) and then merge to master, rather than cherry-picking to the stable branch after first landing on master.

Aug 3 2018, 2:02 PM · Konsole
hindenburg committed R319:db51e08b1874: Add tests for emoji character width - currently expected failures (authored by hindenburg).
Add tests for emoji character width - currently expected failures
Aug 3 2018, 1:49 PM

Aug 2 2018

hindenburg added a reviewer for D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB: sandsmark.
Aug 2 2018, 2:05 PM · Konsole
hindenburg added a comment to D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

Just to clarify, this is for a mouse which have extra button on side correct? I actually don't think I own such a mouse.

Aug 2 2018, 3:36 AM · Konsole
hindenburg committed R319:ee5e70e7d988: Vt102EmulationTest: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Vt102EmulationTest: Use QTEST_GUILESS_MAIN
Aug 2 2018, 3:31 AM
hindenburg committed R319:5146575dbceb: Vt102EmulationTest: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Vt102EmulationTest: Use QTEST_GUILESS_MAIN
Aug 2 2018, 3:31 AM
hindenburg closed D14539: Vt102EmulationTest: Use QTEST_GUILESS_MAIN.
Aug 2 2018, 3:31 AM · Konsole
hindenburg accepted D14539: Vt102EmulationTest: Use QTEST_GUILESS_MAIN.

Thanks, for Konsole, I commit to master and backport but since this is simple it is OK

Aug 2 2018, 2:26 AM · Konsole

Jul 28 2018

hindenburg committed R319:c9bb564722a4: Move script konsoleprofile to tools/ directory (authored by hindenburg).
Move script konsoleprofile to tools/ directory
Jul 28 2018, 6:00 PM