♟ hindenburg

Remove shortcut for detach tab

Use empty() for emptiness instead of size()

Add comments about QSet deprecated methods

Remove un-needed semi-colons

Set QT5.12 as minimum as next release will be 20.08

Revert "Replace deprecated QSet::toList and QSet::fromList()"

Replace deprecated QSet::toList and QSet::fromList()

Q_UNUSED() does not need semi-colon at end

Remove un-needed includes

Remove shortcut for detach tab

Group rendered characters by script

Allow for grouping extended characters

Malayalam support: primitive PoC

Revert "CMakeLists.txt: use ccache if present"

Thanks ,someone already committed this.

I'm having problems updating my laptop - can anyone confirm the issue and fix?

Revert "CMakeLists.txt: use ccache if present"

Is there really any reason to fully revert? Why not just make it not the default per the above comment.

Looks fine - thanks - I'll commit shortly

Konsole tests: update Unicode texts from the Kermit project

Thanks, if you can in the future do gitlab merge requests. We can still do these phabricator until they shut it down.

Re-add correct ProvidersUrl; needed for non-Plasma systems per ml

Remove default ProvidersUrl to use KNewStuff's default

Revert "Use RAII to manage QApplication memory"

Is there a consensus here? Should we revert to previous code and then if someone wants to put in another merge request.

Fix context menu actions when search bar is enabled

Is there still some confusion here?

I don't have a problem w/ reverting this. @kkharlamov if you want to try again, please make sure you add the other people here for their comments on it.

Support status report requests for text-colors

Yea I noticed that - he does that a lot - thanks for this patch regardless - you can close this.

In D26479#589562, @wbauer wrote:

In D26479#589560, @wbauer wrote:

But konsole's minimum KF5 version is 5.6.0 currently. Maybe this should be increased?

As the minimum Qt version is 5.9.0, I highly doubt that anyone would want to build konsole with KF5 5.6.0 (which is more than 2 years older) anyway...

Update copyright year

ColorScheme: fix stack-use-after-scope detected by ASAN

Thanks I just noticed this - I wonder when it started or if depends on KF5/Qt5 version.

Copy _colorRandomization when copying a new ColorScheme

Thanks nice catch. We are trying to migrate to gitlab; if you can in the future use merge requests.

Fix token buffer indexing

This appears to have caused this bug https://bugs.kde.org/show_bug.cgi?id=415249

Sync method parameter names

Add comment for reference

Fix potential use after free issue

Update copyright year

Revert removal to allow Bookmark tabs as Folders to work

Revert supportTabs() removal to fix bookmenu issue

Remove unused methods keyboardCursorShape and keyboardCursorColor

Remove unused method masterMode

Remove unused method masterStatus

Use the same link to ctlseqs.html

Use entity for ASCII

Remove unused method masters

Remove unused method writeSelectionToStream

Mark method as const

Sync method parameter names

Remove unused methods shortcuts and findByShortcut

Remove unused variable

Remove phabricator's arcconfig file

Revert "GIT_SILENT: minor qstring optimization"

ColorScheme: fix stack-use-after-scope detected by ASAN

What's the ping? Should Konsole ship a default profile? and if so which one? or fix this code?

Add QT_NO_FOREACH now that we do not use any foreach

Replace Q_DECL_OVERRIDE with override

Fix loop anaylysis issue

Fix implicit conversion increases floating-point precision

Paste urls of local files as a list of quoted strings

You can use phabricator for now if that works for you - setting up a merge request https://invent.kde.org/kde/konsole/merge_requests would also work. Until phabricator is removed, it is up to you which patch is easier to maintain.

Correctly trigger a Konsole window when using single process

After this patch, you'd need to add -DENABLE_CCACHE=TRUE to enable ccache - I don't really see this as a big hurdle and 19.12 is around the corner so I'd like some consensus here.

Fix tabs not indicating activity

In D25151#559473, @anthonyfieroni wrote:

I see it in line above, but using qobject_cast and not checking for nullptr is waste of time, say if you're sure in type use static_cast, if not check result of qobject_cast against nullptr.

Sorry I didn't see your changes before I did mine.

What's the status of this?

Fix OSC sequence parsing

Use uint for ucs4 characters

hindenburg (Kurt Hindenburg)
User

Projects

Calendar

Today

Tomorrow

Thursday

User Details

Recent Activity
View All

Tue, Mar 31

Sat, Mar 28

Wed, Mar 25

Tue, Mar 24

Feb 22 2020

Feb 1 2020

Jan 30 2020

Jan 24 2020

Jan 17 2020

Jan 8 2020

Jan 7 2020

Jan 5 2020

Jan 3 2020

Jan 1 2020

Dec 27 2019

Dec 23 2019

Dec 22 2019

Dec 18 2019

Dec 12 2019

Dec 6 2019

Dec 4 2019

Nov 25 2019

Nov 22 2019

Nov 10 2019

Nov 7 2019

Nov 2 2019

hindenburg (Kurt Hindenburg)User