I'm still not sure about this.

This doesn't build - all the initializing code has to be re-arranged.

Thanks, I agree the colors look much better. This seems like a lot of code for just random backgrounds and I"m not sure how many people use that colorscheme.

Thanks there are over 180 of these warnings which I never got around to fixing.

I'm fine with this. Tomaz, any objection?

Can you try this?

In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session

The 3 options should be a radio - you have to pick one - now you can de-select all 3

In D20466#448716, @tcanabrava wrote:

In D20466#448705, @ngraham wrote:

In D20466#448704, @hindenburg wrote:

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

This is already happening dudes.

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

In D18352#447911, @guotao wrote:

It seems not isolated for different konsole instances.
Usually I have two konsole instance to save log files. one for serials com, one for adb log.

Can someone from the frameworks group clarify if this can be committed for the next release 5.58 next month? I know years ago, we had a TerminalInterfaceV2 because the interface was changed.

In D14200#447412, @hindenburg wrote:

and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0

Well sometimes it is set and sometimes not

qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1 /tmp

Oh this is actually broken in master. So this patch might be OK once that's fixed.

Something not correct as it doesn't actually start a new session.

Sounds good

Well I decided to try again. This seems much cleaner and doesn't add any extra dependents. It works locally and with sftp URLs. On a side note, I don't think the foreach() loop actually works, so there should be real issue w/ reading/writing the config file every time.

In D20115#447119, @hindenburg wrote:

The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.

The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.

The other option I looked is using KFileWidget and KRecents but there's issues there. Ping me if it gets close to July w/o a resolution here.

Thanks for continuing to work on this - did the yakuake patch get committed to avoid crashes?

I'm fine w/ this

A couple of clazy warning if you want to look at

In D20224#446121, @ngraham wrote:

Nonetheless, with git master, the tab switching keyboard shortcuts work for me, and with this patch, they do not. :(

Ok thanks I didn't think about non KDE distros. I'll look at this again

If you look in ~/.config/konsolerc

This was what I was thinking about - it seems to work - let me know if you have concerns.

The QAction names need to stay the same if possible, otherwise previous shortcuts don't work. If they are changed, I'm not sure there's a way to automatically update them.

OK I'll try again - not sure why it didn't work for me the first time.

log out with the konsole's sessions you want to test and log back in - you could use 2nd system, VM, docker, etc as well

Session restore also doesn't work - you just get a blank area w/o a session

This doesn't seem to work at all... tested w/ just 2 tabs

The biggest part I have trouble following are the new changes to the findWordStart and findWordEnd. I wonder if doing a straight move to ScreenWindow and then changing the code in a new patch would be best.

Issues I see so far:

1. Shortcuts to move tabs don't work
2. Tab menu doesn't have 'Read Only' entry

Is it OK to commit this now? It looks like the next tagging is April 6th

ping?

Thanks still looking at this - need to find a better diff program to follow something this complex

thanks

i also backported the original diff to 19.04

Thanks a lot

Thanks, this works but I think there might be a better way of doing this - let me work on it - if I can't find a better way I'll merge this

Do you have time to rebase this? If not, I can still work around it.

thanks

Also can you link the yakuake patch so we make sure it gets in

OK thanks - I'm fine with that - I just notice that the shortcut to move tabs doesn't work

In D17643#432191, @tcanabrava wrote:

Will do that today

Checking in...

There's a FOREACH still in the macpoller.cpp file

In D19551#436264, @kossebau wrote:

This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers.

On Mac, this change gives this error (after removing -DQT_NO_FOREACH) - the recent changes did not fix the error below - f9b835c66a1facfcd6257fe84d3c7e8ead508353 builds fine.

FYI, this breaks mac building since there's a foreach in src/backends/mac/kauth-policy-gen-mac.cpp; also a few under src/backends/fake

OK, thanks - I thought about casting but it seemed strange to only affect Qt 5.9.x

I changed it to 5.9.4; it required some #ifs in KeyboardTranslatorTest.cpp; the only 5.9.x I could find were .4 and .5

To get it compile w/ 5.9.4, I have to comment out all the QCOMPAREs - I thought I tested this w/ 5.9.7 but I appear to have upgraded my VMs

It fails here w/ 5.9.4 in the tests and .7 was the current so that's why I picked it.