I can see how this could be useful. If we use the current visual effect, we'll have issues w/ different colors (ie the fade not being easily seen). Perhaps the side visual might be better? At one time, there's a wish to have the scroll bar similar to Kate in that it shows a representation of what's in the window in the scrollbar.

I'm fine with adding this.

QFontMetrics::horizontalAdvance is only in qt5.11 - can you find a replacement for Qt5.9-10?

Now that konsole is using invent, I can't do an 'arc land' anymore - I'm moving the diff over to a branch and then committing. Not ideal as when I push the branch, the commit keywords are parsed. I need to streamline this somehow.

Thanks, I'll work on this weekend and try to get it committed correctly.

@mglb If you busy, we can commit this now and fix minor issues later.

Thanks let me look at this week

Anyone have anything to say about Thiago's comment? There's now only one shortcut to open a new tab.

Forgot to add the line to close this.

Thanks, it worked the 2nd time I tried.

KDE uses spaces instead of tabs. Does the tests past if you manually install the new kde_terminal_interface.h and remove the #IF? I get failures in the QVERIFY(terminal).

Thanks, do you have time to add some tests? They would be added to autotests/TerminalInterfaceTest.cpp TerminalInterfaceTest.h

Can you update this patch assuming that frameworks 5.60 will have the new code?

In D20169#473105, @mschiller wrote:

ping

Since the move to invent, arc land doesn't work for me ATM - I need to re-arrange my system - I merged the branch in invent.

Nice catch - thanks a lot.

Thanks to everyone who helped on this. I manually committed this as I couldn't get arc to work correctly.

In D20701#472087, @ognarb wrote:

@hindenburg Sysadmin did the setup, you need now to push the change to make it live 🎉.

In D20701#470115, @bcooksley wrote:

Kurt, could you please create a branch in the Konsole website repository containing this work?
I'll then be able to arrange the switchover.

Thanks, any minor changes can be done afterwards.

In D21301#469115, @tcanabrava wrote:

We are but it’s a per project basis

Are we waiting on the sysadmins? And if so, does anyone know the timeline? BTW, thanks for working on this.

In D21301#467910, @ngraham wrote:

In D21301#467903, @tcanabrava wrote:

@hindenburg I have a long list of branches that are build on top of other branches, and phabricator is breaking my reviews (four to date, just this week).
would you accept konsole to move to gitlab?

+1, I think that would be fantastic!

Ok I see this request now - I'm a bit behind on my emails. This makes sense to have one toggle, but I'm still unclear on why anyone would want to max/min a split-view. It would be easy to forget you have a min view.

This doesn't seem to maximize now. I'm not clear on why the splits need a maximize. I can't figure how to un-maximize the view.

I believe that once the KParts code is committed to frameworks, Konsole needs to add checks the frameworks version. I'd rather not require the new framework version for all of Konsole, just this new code.

There have been a number of hacks in Konsole; I'm fine w/ this for now.

I would prefer using TerminalInterfaceV2 in the current file instead of a new file. It would make using it much easier to use, document, etc and when kf6 comes out, easier to re-combine.

Thanks for doing this - I was going to eventually get around to it.

Thanks, his does seem to fix the shortcut issues w/ restoring. I'll look at this and the others this weekend.

This looks really good - very nice job.

1. "Rename "File Location" to "Temporary Files" - this page probably will be removed (D20466)" - This isn't going to be removed - there are valid reasons to allow users to change the file locations.
2. The Manage Profile page still needs the info 'The Show column must be checked for these shortcuts to work' until it gets fixed.

FYI, we'd need to test this in wayland as well - at least to avoid any regressions (if possible).

If the internal fallback profile has issues, let's fix that.

I'm still not sure about this.

This doesn't build - all the initializing code has to be re-arranged.

Thanks, I agree the colors look much better. This seems like a lot of code for just random backgrounds and I"m not sure how many people use that colorscheme.

Thanks there are over 180 of these warnings which I never got around to fixing.

I'm fine with this. Tomaz, any objection?

Can you try this?

In D20466#448806, @mglb wrote:

After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session

The 3 options should be a radio - you have to pick one - now you can de-select all 3

In D20466#448716, @tcanabrava wrote:

In D20466#448705, @ngraham wrote:

In D20466#448704, @hindenburg wrote:

Another way to display this would be to only show the "info box" when unlimited is selected.

+1

This is already happening dudes.

A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?

In D18352#447911, @guotao wrote:

It seems not isolated for different konsole instances.
Usually I have two konsole instance to save log files. one for serials com, one for adb log.

Can someone from the frameworks group clarify if this can be committed for the next release 5.58 next month? I know years ago, we had a TerminalInterfaceV2 because the interface was changed.

In D14200#447412, @hindenburg wrote:

and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0

Well sometimes it is set and sometimes not