I recall this now - I wonder if this is still try 9+ years later. If we revert, let's at least add a comment about this issue in the code

I'm unable to get the non-overlay to show up after changing to use non breeze themes like Oxygen, Air.

Looks fine - go ahead and commit when you want

Thanks, if there's only one commit I'll go ahead and land them.

Thanks

It appears this makes the scrollbar wider; was that expected?

Can you rebase this please?

This looks really good.

In D12968#278262, @tcanabrava wrote:

and window->createSession calls ViewManager::newSession that calls
session->addEnvironmentEntry(QStringLiteral("KONSOLE_DBUS_WINDOW=/Windows/%1").arg(managerId()));

that's the reason I said it's strange that the KONSOLE_DBUS_WINDOW is not set, as the only codepoint that I can follow always sets it.

In D12968#277887, @tcanabrava wrote:

> Having a Konsole open and then logging off your desktop; when you log back in, the Konsole should be restored

I found the code that deals with that:

void restoreSession(Application &app)
{
    int n = 1;
    while (KMainWindow::canBeRestored(n)) {
        app.newMainWindow()->restore(n++);
    }
}

Application::newMainWindow, it calls this

Thanks, we put {} around all "if" for consistency and following KDE's style

In D12968#277814, @tcanabrava wrote:

Ok, haven't found any regressions. The below item should be fixed later as I didn't realize it before.

Thanks, I'll look at this shortly

If the tab detached had search enabled, the search will be disabled and you need to search again
^ This could be fixed at a later point.

These are for use via dbus; example: qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW defaultProfile

Thanks much cleaner

Nice, thanks

Thanks, can you update the title and commit message at some point.

This ignores the profile's terminal size settings; it is not as easy to set the size to 1/2 width by 1/2 height

Thanks

This is a great first attempt - thanks - I'll test it out - I agree likely it needs a frame around it.

Thanks for the reminder - I meant to look at this earlier

OK thanks, using 'man man' did not work for me but yes vim file did work in the testing.

Thanks- I'll test it more later

Ok that'd be great - I never got around to working on it - I was thinking of a lineedit, perhaps up/down arrows and a "gear" drop down menu w/ the options.

Thanks for the patch; sorry for not replying sooner. I'm not sure what the best name for this feature would be. I'll look at the code when I have time.

A slightly different patch was committed for 18.08; regardless, thanks for the patch

I like the removal of duplicated code; however something still not correct. If you have konsole debug turned on and run konsole from another term you can see "org.kde.konsole: Attempted to re-run an already running session ( 28261 )" which should not be there. Briefly looking at the code, ViewManager::newSession has session->run() which is the removed code does not.

On a side note, I've always disliked the searching in Konsole since the bar changes the terminal height. I thought a floating smaller widget (like in Chrome) would be better.

Thanks

Do you have time to rebase and change these to !_usesMouseTracking? If not, I can do it.

Can you try to use arcanist for patches? Once you have it setup, it should help. Currently your patches don't have the author set. I can work around it until you get is working.

Thanks looks fine