hindenburg (Kurt Hindenburg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 9:41 PM (215 w, 19 h)
Availability
Available

Recent Activity

Thu, Oct 17

hindenburg committed R319:77ce0888d82e: Fix scrollbar position (authored by mglb).
Fix scrollbar position
Thu, Oct 17, 12:50 AM

Tue, Oct 8

hindenburg committed R319:2455faf68aaf: Add a "Do not ask again" option to close session dialog (authored by hindenburg).
Add a "Do not ask again" option to close session dialog
Tue, Oct 8, 2:57 PM

Sun, Oct 6

hindenburg committed R319:1561f6203bbf: Allow loading of pre 19.08 session files (authored by jpalecek).
Allow loading of pre 19.08 session files
Sun, Oct 6, 2:34 PM
hindenburg committed R319:2de43394c983: Allow loading of pre 19.08 session files (authored by jpalecek).
Allow loading of pre 19.08 session files
Sun, Oct 6, 2:32 PM

Sat, Oct 5

hindenburg committed R935:a1f7e3147e50: Add 19.12 changelog; unreleased ATM (authored by hindenburg).
Add 19.12 changelog; unreleased ATM
Sat, Oct 5, 10:41 PM
hindenburg committed R935:c887996d38c5: Add 19.08 changelog (authored by hindenburg).
Add 19.08 changelog
Sat, Oct 5, 10:25 PM
hindenburg committed R319:67a29e4134ff: Keep empty lines when "trim leading spaces" is enabled (authored by mglb).
Keep empty lines when "trim leading spaces" is enabled
Sat, Oct 5, 9:13 PM

Thu, Oct 3

hindenburg committed R319:b9d2cd668bc0: Correct split view and keyboard navigation (authored by hindenburg).
Correct split view and keyboard navigation
Thu, Oct 3, 4:55 PM
hindenburg committed R319:ba84640a7bd8: Fix split view crashes when using keyboard navigation with some themes (authored by hindenburg).
Fix split view crashes when using keyboard navigation with some themes
Thu, Oct 3, 4:55 PM
hindenburg committed R319:64cc52754baa: Make sure font weight value is within allowed range (authored by mglb).
Make sure font weight value is within allowed range
Thu, Oct 3, 4:55 PM
hindenburg committed R319:b27c8e7fd3b0: Correct split view and keyboard navigation (authored by hindenburg).
Correct split view and keyboard navigation
Thu, Oct 3, 2:21 PM

Wed, Oct 2

hindenburg committed R319:63ef8872bfc4: Fix split view crashes when using keyboard navigation with some themes (authored by hindenburg).
Fix split view crashes when using keyboard navigation with some themes
Wed, Oct 2, 3:55 PM

Fri, Sep 27

hindenburg committed R319:9e3a30fdca20: Remove env variable KONSOLE_PROFILE_NAME (authored by hindenburg).
Remove env variable KONSOLE_PROFILE_NAME
Fri, Sep 27, 2:31 AM
hindenburg committed R319:05f5663a9010: Add dbus profile() to return profile name of current session (authored by hindenburg).
Add dbus profile() to return profile name of current session
Fri, Sep 27, 2:31 AM

Sep 9 2019

hindenburg added inline comments to D20115: Re enable move tab left / right via keyboard shortcuts.
Sep 9 2019, 2:06 PM · Konsole

Sep 6 2019

hindenburg committed R319:bccb702d962c: Fix cmake endif() mis-matching arguments (authored by hindenburg).
Fix cmake endif() mis-matching arguments
Sep 6 2019, 12:14 PM

Sep 2 2019

hindenburg committed R319:1df621390e82: Fix the fallback code used when restoring session fails (authored by jpalecek).
Fix the fallback code used when restoring session fails
Sep 2 2019, 1:26 PM
hindenburg added a comment to D23601: Fix the fallback code used when restoring session fails.

On the 19.08 branch I get a lot of these when exiting a konsole session that uses this code. I don't see this warning on master.

Sep 2 2019, 12:58 AM · Konsole

Sep 1 2019

hindenburg committed R319:656f6804ea2c: Fix the fallback code used when restoring session fails (authored by jpalecek).
Fix the fallback code used when restoring session fails
Sep 1 2019, 10:47 PM
hindenburg closed D23601: Fix the fallback code used when restoring session fails.
Sep 1 2019, 10:47 PM · Konsole
hindenburg updated the test plan for D23601: Fix the fallback code used when restoring session fails.
Sep 1 2019, 10:31 PM · Konsole
hindenburg accepted D23601: Fix the fallback code used when restoring session fails.

Thanks, I'll look at the other patch shortly. This regression should have been caught in my testing.

Sep 1 2019, 10:30 PM · Konsole
hindenburg updated the test plan for D23601: Fix the fallback code used when restoring session fails.
Sep 1 2019, 10:29 PM · Konsole
hindenburg added a comment to D23601: Fix the fallback code used when restoring session fails.

This looks fine - I'll test the restore patch

Sep 1 2019, 9:22 PM · Konsole
hindenburg added a reviewer for D23601: Fix the fallback code used when restoring session fails: Konsole.
Sep 1 2019, 9:12 PM · Konsole
hindenburg accepted D23636: Add icons to desktop file actions.

thanks makes sense

Sep 1 2019, 9:00 PM · Konsole
hindenburg committed R319:158bbf5cdf31: clean up includes - remove KIO::Job (authored by hindenburg).
clean up includes - remove KIO::Job
Sep 1 2019, 3:45 PM
hindenburg committed R319:d8dc0dbf4a19: It is not obvious toUcs4 returns QVector<uint> so remove auto (authored by hindenburg).
It is not obvious toUcs4 returns QVector<uint> so remove auto
Sep 1 2019, 3:34 PM
hindenburg committed R319:eb96410ffdfd: clean up includes (authored by hindenburg).
clean up includes
Sep 1 2019, 3:34 PM
hindenburg committed R319:3db90bbf70ab: Merge branch 'konstantink/konsole-remove-deprecated-qcopy' (authored by hindenburg).
Merge branch 'konstantink/konsole-remove-deprecated-qcopy'
Sep 1 2019, 2:14 PM
hindenburg added a comment to D20263: Keep perceived contrast in random background color.

FYI, these are showing up in the builds

https://build.kde.org/job/Applications/job/konsole/job/kf5-qt5%20SUSEQt5.12/lastSuccessfulBuild/warnings30Result/

ColorScheme.cpp:314, GNU Make + GNU C Compiler (gcc), Priority: Normal

assignment from temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]

ColorScheme.cpp:316, GNU Make + GNU C Compiler (gcc), Priority: Normal

assignment from temporary initializer_list does not extend the lifetime of the underlying array [-Winit-list-lifetime]

Sep 1 2019, 1:56 PM · VDG, Konsole

Aug 30 2019

hindenburg committed R319:ed44f288c2d2: Add scrollbuttons for tabs when tabbar is full (authored by Yap Sok Ann <sokann@gmail.com>).
Add scrollbuttons for tabs when tabbar is full
Aug 30 2019, 12:59 AM
hindenburg committed R319:f79ee976fb9c: Add scrollbuttons for tabs when tabbar is full (authored by Yap Sok Ann <sokann@gmail.com>).
Add scrollbuttons for tabs when tabbar is full
Aug 30 2019, 12:45 AM

Aug 29 2019

hindenburg committed R319:dd2c940cc7da: fix memory leaks (coverity) (authored by hindenburg).
fix memory leaks (coverity)
Aug 29 2019, 12:47 PM
hindenburg committed R319:8040bb2678fc: fix memory leak (coverity) (authored by hindenburg).
fix memory leak (coverity)
Aug 29 2019, 2:39 AM

Aug 28 2019

hindenburg committed R319:9c19368ce555: Remove leading/trailingWhitespace() - they were never used (authored by hindenburg).
Remove leading/trailingWhitespace() - they were never used
Aug 28 2019, 3:09 PM
hindenburg committed R319:d0ae59834896: Remove currentBookmarkList() - hasn't been used in years (authored by hindenburg).
Remove currentBookmarkList() - hasn't been used in years
Aug 28 2019, 2:26 PM
hindenburg committed R319:0995c1dc95bb: Remove supportsTabs() - hasn't been used in years (authored by hindenburg).
Remove supportsTabs() - hasn't been used in years
Aug 28 2019, 2:08 PM
hindenburg committed R319:ec1c08c4ed86: hotSpotsAtLine() has not been used in years (authored by hindenburg).
hotSpotsAtLine() has not been used in years
Aug 28 2019, 1:57 PM
hindenburg committed R319:2339f20ccafb: config-konsole.h is not installed; krazy has been fixed (authored by hindenburg).
config-konsole.h is not installed; krazy has been fixed
Aug 28 2019, 12:49 PM
hindenburg committed R319:8ce959ab6cf9: Use QThread::sleep instead of sleep/usleep (authored by hindenburg).
Use QThread::sleep instead of sleep/usleep
Aug 28 2019, 3:12 AM
hindenburg committed R319:490f174c2242: Correct parameter's names (authored by hindenburg).
Correct parameter's names
Aug 28 2019, 2:53 AM
hindenburg committed R319:3b4f835ebbc6: Initialize variable in constructor (coverity/cppcheck) (authored by hindenburg).
Initialize variable in constructor (coverity/cppcheck)
Aug 28 2019, 1:58 AM
hindenburg committed R319:f121ecd24a3d: Use std::any_of instead of loop (authored by hindenburg).
Use std::any_of instead of loop
Aug 28 2019, 1:43 AM

Aug 25 2019

hindenburg committed R319:6f0a83284c22: Make the layout better (authored by hindenburg).
Make the layout better
Aug 25 2019, 6:32 PM
hindenburg committed R319:f780383096c1: Restore "Show 'new tab' button" option in Konsole Settings (authored by hindenburg).
Restore "Show 'new tab' button" option in Konsole Settings
Aug 25 2019, 4:07 PM
hindenburg committed R319:616f5554b11b: Restore "Show 'new tab' button" option in Konsole Settings (authored by mglb).
Restore "Show 'new tab' button" option in Konsole Settings
Aug 25 2019, 2:19 PM

Aug 24 2019

hindenburg added a comment to D22243: Add Breeze Light and Chrome color schemes.

How's this going?

Aug 24 2019, 7:51 PM · Konsole
hindenburg committed R319:1852b6bae73e: Add note about duplicates in sub-folders (authored by hindenburg).
Add note about duplicates in sub-folders
Aug 24 2019, 7:14 PM
hindenburg committed R319:befaaa0255b2: Do not allow adding duplicates in bookmarks (authored by sandsmark).
Do not allow adding duplicates in bookmarks
Aug 24 2019, 7:14 PM
hindenburg committed R319:230463105624: Correct parameter documentation (authored by hindenburg).
Correct parameter documentation
Aug 24 2019, 6:22 PM
hindenburg committed R319:a7303156f251: use 'using' instead of 'typedef' (authored by hindenburg).
use 'using' instead of 'typedef'
Aug 24 2019, 6:22 PM
hindenburg committed R319:a4818f0b8e2d: avoid repeating the return type; use a braced initializer list instead (authored by hindenburg).
avoid repeating the return type; use a braced initializer list instead
Aug 24 2019, 6:22 PM

Aug 23 2019

hindenburg added a comment to D20263: Keep perceived contrast in random background color.

FYI, these are showing up in the builds

Aug 23 2019, 1:46 PM · VDG, Konsole
hindenburg committed R319:6943a31745c1: Explicitly add data type s/unsigned/unsigned int/ (authored by hindenburg).
Explicitly add data type s/unsigned/unsigned int/
Aug 23 2019, 12:53 PM
hindenburg committed R319:08931fbd335a: Tweak tab title options: home and Bourne prompt sigils (authored by rrosch).
Tweak tab title options: home and Bourne prompt sigils
Aug 23 2019, 12:50 PM

Aug 22 2019

hindenburg committed R319:9a37e0b265d1: Correct include guard name (authored by hindenburg).
Correct include guard name
Aug 22 2019, 2:51 PM

Aug 20 2019

hindenburg committed R319:eb57ab7cdbdf: hsluv add copyright emails - taken from their github repos (authored by hindenburg).
hsluv add copyright emails - taken from their github repos
Aug 20 2019, 2:15 AM

Aug 18 2019

hindenburg added a comment to D23246: Fix crash on "Close Current Tab" handling.

if possible, use https://invent.kde.org/kde/konsole/merge_requests instead of phrabicator. I don't mind using phrabicator while it is still up abut I often forget to amend the author.

Aug 18 2019, 9:38 PM · Konsole
hindenburg committed R319:3c25aafdbaf7: Fix crash on "Close Current Tab" handling (authored by AndreyYashkin).
Fix crash on "Close Current Tab" handling
Aug 18 2019, 9:36 PM
hindenburg committed R319:82bca348c270: Merge branch 'konstantink/konsole-small-cleanup' (authored by hindenburg).
Merge branch 'konstantink/konsole-small-cleanup'
Aug 18 2019, 9:24 PM
hindenburg committed R319:62a5f1d7947d: Fix crash on "Close Current Tab" handling (authored by hindenburg).
Fix crash on "Close Current Tab" handling
Aug 18 2019, 9:00 PM
hindenburg closed D23246: Fix crash on "Close Current Tab" handling.
Aug 18 2019, 9:00 PM · Konsole
hindenburg accepted D23246: Fix crash on "Close Current Tab" handling.

Thanks a lot for fixing this - please don't add // italic/bold to commit messages as it messes up what shows up in the logs

Aug 18 2019, 8:49 PM · Konsole
hindenburg updated the test plan for D23246: Fix crash on "Close Current Tab" handling.
Aug 18 2019, 8:48 PM · Konsole
hindenburg updated the summary of D23246: Fix crash on "Close Current Tab" handling.
Aug 18 2019, 8:47 PM · Konsole

Aug 17 2019

hindenburg committed R319:dc29be39a640: Keep perceived contrast in random background color (authored by mglb).
Keep perceived contrast in random background color
Aug 17 2019, 8:09 PM
hindenburg closed D20263: Keep perceived contrast in random background color.
Aug 17 2019, 8:09 PM · VDG, Konsole
hindenburg accepted D20263: Keep perceived contrast in random background color.

thanks for sticking w/ this

Aug 17 2019, 8:08 PM · VDG, Konsole
hindenburg added inline comments to D20263: Keep perceived contrast in random background color.
Aug 17 2019, 5:33 PM · VDG, Konsole
hindenburg added a comment to D20263: Keep perceived contrast in random background color.

I don't see any issues testing so far - minor issue obseloteKeys is misspelled

Aug 17 2019, 3:47 PM · VDG, Konsole
hindenburg committed R319:74a01214229d: Add note about depreciated width() (authored by hindenburg).
Add note about depreciated width()
Aug 17 2019, 3:04 PM
hindenburg committed R319:9baecd741766: Merge branch 'arcpatch-D23144' (authored by hindenburg).
Merge branch 'arcpatch-D23144'
Aug 17 2019, 2:34 PM
hindenburg committed R319:6a064319629d: Port from QFontMetrics::width() to boundingRect().width() (authored by gladhorn).
Port from QFontMetrics::width() to boundingRect().width()
Aug 17 2019, 2:25 PM
hindenburg closed D23144: Port from QFontMetrics::width() to boundingRect().width().
Aug 17 2019, 2:25 PM · Konsole
hindenburg accepted D23144: Port from QFontMetrics::width() to boundingRect().width().

I agree thanks

Aug 17 2019, 2:23 PM · Konsole

Aug 16 2019

hindenburg added a comment to D23144: Port from QFontMetrics::width() to boundingRect().width().
Aug 16 2019, 4:20 PM · Konsole
hindenburg committed R319:83ea331675c1: Merge branch 'arcpatch-D23143' (authored by hindenburg).
Merge branch 'arcpatch-D23143'
Aug 16 2019, 4:09 PM
hindenburg committed R319:6029f813f711: Use QCommandLineOption::HiddenFromHelp instead of deprecated API (authored by gladhorn).
Use QCommandLineOption::HiddenFromHelp instead of deprecated API
Aug 16 2019, 4:09 PM
hindenburg closed D23143: Use QCommandLineOption::HiddenFromHelp instead of deprecated API.
Aug 16 2019, 4:09 PM · Konsole
hindenburg accepted D23143: Use QCommandLineOption::HiddenFromHelp instead of deprecated API.

Thanks

Aug 16 2019, 4:08 PM · Konsole
hindenburg added a comment to D20263: Keep perceived contrast in random background color.

Ok, those can be done later IMHO - any objection to committing this now?

Aug 16 2019, 4:00 PM · VDG, Konsole
hindenburg committed R319:276a6dca6602: In confirm close dialog, remove 'close current tab' option (authored by AndreyYashkin).
In confirm close dialog, remove 'close current tab' option
Aug 16 2019, 3:55 PM
hindenburg closed D23146: In confirm close dialog, remove 'close current tab' option.
Aug 16 2019, 3:55 PM · Konsole
hindenburg accepted D23146: In confirm close dialog, remove 'close current tab' option.

thanks

Aug 16 2019, 3:46 PM · Konsole
hindenburg updated the test plan for D23146: In confirm close dialog, remove 'close current tab' option.
Aug 16 2019, 3:41 PM · Konsole
hindenburg committed R319:420266f7e918: Move enabling dbus sendText/runCommand to 'Configure Konsole' dialog (authored by hindenburg).
Move enabling dbus sendText/runCommand to 'Configure Konsole' dialog
Aug 16 2019, 3:25 PM

Aug 8 2019

hindenburg added a comment to D22980: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde.

Thanks you very much!

That said, I'm still curious on the answer, because it might be useful to know for the next time I gonna contribute.

Aug 8 2019, 12:28 AM · Konsole

Aug 7 2019

hindenburg committed R319:f8f7b43936b7: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde (authored by hiangel).
Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde
Aug 7 2019, 2:31 PM
hindenburg committed R319:0107e68e22d3: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde (authored by hiangel).
Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde
Aug 7 2019, 2:26 PM
hindenburg closed D22980: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde.
Aug 7 2019, 2:26 PM · Konsole
hindenburg added a comment to D22980: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde.

This looks fine to me and fixes the issue.

Aug 7 2019, 1:26 AM · Konsole
hindenburg committed R319:a49332e5537d: Do not allow 'Close Current Tab" to crash (authored by hindenburg).
Do not allow 'Close Current Tab" to crash
Aug 7 2019, 12:55 AM
hindenburg added reviewers for D22980: Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde: Konsole, hindenburg.

Thanks putting this here is fine for now

Aug 7 2019, 12:54 AM · Konsole

Aug 6 2019

hindenburg committed R319:ac9ccc948321: Merge branch 'mglebocki/konsole-Mark-intended-int-division-in-double-context' (authored by hindenburg).
Merge branch 'mglebocki/konsole-Mark-intended-int-division-in-double-context'
Aug 6 2019, 2:19 AM
hindenburg committed R319:a8d152f11e8c: Merge branch 'mglebocki/konsole-Split-tab-bar-configuration-into-tabs' (authored by hindenburg).
Merge branch 'mglebocki/konsole-Split-tab-bar-configuration-into-tabs'
Aug 6 2019, 2:07 AM
hindenburg committed R319:a3ec064f2f2a: Fix dbus newSession() three methods to work (authored by hindenburg).
Fix dbus newSession() three methods to work
Aug 6 2019, 12:24 AM
hindenburg committed R319:b23a7c2e4dcc: Remove accelerators from tabs when pressing ALT (authored by hindenburg).
Remove accelerators from tabs when pressing ALT
Aug 6 2019, 12:24 AM

Aug 5 2019

hindenburg committed R319:3824de3e4f07: Fix dbus newSession() three methods to work (authored by hindenburg).
Fix dbus newSession() three methods to work
Aug 5 2019, 2:14 PM
hindenburg committed R319:841397f3b0a7: Remove accelerators from tabs when pressing ALT (authored by hindenburg).
Remove accelerators from tabs when pressing ALT
Aug 5 2019, 1:44 PM