- User Since
- Sep 4 2015, 9:41 PM (197 w, 2 d)
I can see how this could be useful. If we use the current visual effect, we'll have issues w/ different colors (ie the fade not being easily seen). Perhaps the side visual might be better? At one time, there's a wish to have the scroll bar similar to Kate in that it shows a representation of what's in the window in the scrollbar.
I'm fine with adding this.
QFontMetrics::horizontalAdvance is only in qt5.11 - can you find a replacement for Qt5.9-10?
Now that konsole is using invent, I can't do an 'arc land' anymore - I'm moving the diff over to a branch and then committing. Not ideal as when I push the branch, the commit keywords are parsed. I need to streamline this somehow.
Fri, Jun 14
Thanks, I'll work on this weekend and try to get it committed correctly.
Wed, Jun 12
@mglb If you busy, we can commit this now and fix minor issues later.
Thanks let me look at this week
Tue, Jun 11
Anyone have anything to say about Thiago's comment? There's now only one shortcut to open a new tab.
Wed, Jun 5
Forgot to add the line to close this.
Thanks, it worked the 2nd time I tried.
Tue, Jun 4
KDE uses spaces instead of tabs. Does the tests past if you manually install the new kde_terminal_interface.h and remove the #IF? I get failures in the QVERIFY(terminal).
Mon, Jun 3
Thanks, do you have time to add some tests? They would be added to autotests/TerminalInterfaceTest.cpp TerminalInterfaceTest.h
Sun, Jun 2
Can you update this patch assuming that frameworks 5.60 will have the new code?
Sat, Jun 1
Since the move to invent, arc land doesn't work for me ATM - I need to re-arrange my system - I merged the branch in invent.
Nice catch - thanks a lot.
Fri, May 31
Thanks to everyone who helped on this. I manually committed this as I couldn't get arc to work correctly.
Thu, May 30
Sun, May 26
Sat, May 25
Thanks, any minor changes can be done afterwards.
Fri, May 24
Are we waiting on the sysadmins? And if so, does anyone know the timeline? BTW, thanks for working on this.
Thu, May 23
Ok I see this request now - I'm a bit behind on my emails. This makes sense to have one toggle, but I'm still unclear on why anyone would want to max/min a split-view. It would be easy to forget you have a min view.
This doesn't seem to maximize now. I'm not clear on why the splits need a maximize. I can't figure how to un-maximize the view.
I believe that once the KParts code is committed to frameworks, Konsole needs to add checks the frameworks version. I'd rather not require the new framework version for all of Konsole, just this new code.
May 17 2019
There have been a number of hacks in Konsole; I'm fine w/ this for now.
May 14 2019
I would prefer using TerminalInterfaceV2 in the current file instead of a new file. It would make using it much easier to use, document, etc and when kf6 comes out, easier to re-combine.
May 11 2019
Thanks for doing this - I was going to eventually get around to it.
May 10 2019
Thanks, his does seem to fix the shortcut issues w/ restoring. I'll look at this and the others this weekend.
Apr 26 2019
This looks really good - very nice job.
- "Rename "File Location" to "Temporary Files" - this page probably will be removed (D20466)" - This isn't going to be removed - there are valid reasons to allow users to change the file locations.
- The Manage Profile page still needs the info 'The Show column must be checked for these shortcuts to work' until it gets fixed.
Apr 23 2019
FYI, we'd need to test this in wayland as well - at least to avoid any regressions (if possible).
Apr 21 2019
If the internal fallback profile has issues, let's fix that.
Apr 20 2019
I'm still not sure about this.
Apr 18 2019
This doesn't build - all the initializing code has to be re-arranged.
Apr 17 2019
Thanks, I agree the colors look much better. This seems like a lot of code for just random backgrounds and I"m not sure how many people use that colorscheme.
Thanks there are over 180 of these warnings which I never got around to fixing.
I'm fine with this. Tomaz, any objection?
Apr 13 2019
Can you try this?
Apr 12 2019
The 3 options should be a radio - you have to pick one - now you can de-select all 3
A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?
Apr 11 2019
Can someone from the frameworks group clarify if this can be committed for the next release 5.58 next month? I know years ago, we had a TerminalInterfaceV2 because the interface was changed.