- User Since
- Sep 4 2015, 9:41 PM (189 w, 20 h)
I'm still not sure about this.
Thu, Apr 18
This doesn't build - all the initializing code has to be re-arranged.
Wed, Apr 17
Thanks, I agree the colors look much better. This seems like a lot of code for just random backgrounds and I"m not sure how many people use that colorscheme.
Thanks there are over 180 of these warnings which I never got around to fixing.
I'm fine with this. Tomaz, any objection?
Sat, Apr 13
Can you try this?
Fri, Apr 12
The 3 options should be a radio - you have to pick one - now you can de-select all 3
A quick test of picking the other 2 save locations ,it doesn't seem to work. The location settings are still stored in konsolerc. Aren't they suppose to be in the .profile file now?
Thu, Apr 11
Can someone from the frameworks group clarify if this can be committed for the next release 5.58 next month? I know years ago, we had a TerminalInterfaceV2 because the interface was changed.
Wed, Apr 10
Well sometimes it is set and sometimes not
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1 /tmp
Oh this is actually broken in master. So this patch might be OK once that's fixed.
Something not correct as it doesn't actually start a new session.
Well I decided to try again. This seems much cleaner and doesn't add any extra dependents. It works locally and with sftp URLs. On a side note, I don't think the foreach() loop actually works, so there should be real issue w/ reading/writing the config file every time.
The one issue I have, if you open just one tab and press the move left/right I get C for 'move right' and D for 'move left" echoed on the terminal. They go away when I open another terminal and don't appear to return even if I close all but one.
The other option I looked is using KFileWidget and KRecents but there's issues there. Ping me if it gets close to July w/o a resolution here.
Thanks for continuing to work on this - did the yakuake patch get committed to avoid crashes?
Tue, Apr 9
I'm fine w/ this
A couple of clazy warning if you want to look at
Mon, Apr 8
Sun, Apr 7
Sat, Apr 6
Ok thanks I didn't think about non KDE distros. I'll look at this again
Fri, Apr 5
If you look in ~/.config/konsolerc
Thu, Apr 4
This was what I was thinking about - it seems to work - let me know if you have concerns.
Wed, Apr 3
The QAction names need to stay the same if possible, otherwise previous shortcuts don't work. If they are changed, I'm not sure there's a way to automatically update them.
OK I'll try again - not sure why it didn't work for me the first time.
log out with the konsole's sessions you want to test and log back in - you could use 2nd system, VM, docker, etc as well
Sat, Mar 30
Session restore also doesn't work - you just get a blank area w/o a session
This doesn't seem to work at all... tested w/ just 2 tabs
The biggest part I have trouble following are the new changes to the findWordStart and findWordEnd. I wonder if doing a straight move to ScreenWindow and then changing the code in a new patch would be best.
Fri, Mar 29
Issues I see so far:
- Shortcuts to move tabs don't work
- Tab menu doesn't have 'Read Only' entry
Is it OK to commit this now? It looks like the next tagging is April 6th
Thu, Mar 28
Thanks still looking at this - need to find a better diff program to follow something this complex
i also backported the original diff to 19.04
Wed, Mar 27
Thanks, this works but I think there might be a better way of doing this - let me work on it - if I can't find a better way I'll merge this
Do you have time to rebase this? If not, I can still work around it.
Also can you link the yakuake patch so we make sure it gets in
OK thanks - I'm fine with that - I just notice that the shortcut to move tabs doesn't work
Sun, Mar 24
Sat, Mar 23
There's a FOREACH still in the macpoller.cpp file
Fri, Mar 22
On Mac, this change gives this error (after removing -DQT_NO_FOREACH) - the recent changes did not fix the error below - f9b835c66a1facfcd6257fe84d3c7e8ead508353 builds fine.
FYI, this breaks mac building since there's a foreach in src/backends/mac/kauth-policy-gen-mac.cpp; also a few under src/backends/fake
Mar 21 2019
OK, thanks - I thought about casting but it seemed strange to only affect Qt 5.9.x
Mar 20 2019
I changed it to 5.9.4; it required some #ifs in KeyboardTranslatorTest.cpp; the only 5.9.x I could find were .4 and .5
Mar 19 2019
To get it compile w/ 5.9.4, I have to comment out all the QCOMPAREs - I thought I tested this w/ 5.9.7 but I appear to have upgraded my VMs
It fails here w/ 5.9.4 in the tests and .7 was the current so that's why I picked it.