Show "Search wrapped" message in center of view for better visibility
ClosedPublic

Authored by dhaumann on Dec 18 2017, 11:20 AM.

Details

Summary

This patch uses the "CenterInView" message position instead of
"TopInView" and "BottomInView". The reason for this change is
better visibility, since the corner widgets quickly hide unnoticed
and the user doesn't know what's going on.

Test Plan

make test, manual testing

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Dec 18 2017, 11:20 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 18 2017, 11:20 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested review of this revision.Dec 18 2017, 11:20 AM

Example for a wrapping search at bottom, continuing at top:

dhaumann updated this revision to Diff 24063.Dec 18 2017, 11:34 AM
  • Avoid queuing messages if F3 is continuously pressed

Isn't "Search wrapped" a bit technical?

That could very well be the case. Another possibility would be to simply show an icon, like Qt Creator does it.

Or change the text, but I tried to avoid long messages (which will be a possible issue in translations anyways)... Suggestions welcome :-)

neundorf accepted this revision.EditedDec 18 2017, 9:55 PM

Definitely an improvement :-)

Btw. I don't think "Search wrapped" is too technical.

This revision is now accepted and ready to land.Dec 18 2017, 9:55 PM

@neundorf Did you try the patch? Or anyone else? I would like to get this right instead of having yet another solution that is not good enough.

I tried it, it is more obvious, if that is perfect, I don't know.

I will push that now, before it rots ;=) (like other requests).

And if the outcry is large, we can still revert it.
I think there is no way to see if it is better beside user testing.

Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. · View Herald TranscriptJul 14 2018, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Retroactive +1 on the positioning and wording, but I would have stayed with an Informational (blue) KMessageWidget instead of making it Positive (and hence, green). Eh, not a huge deal. Shoulda piped up sooner!