Dictionary doesn't have enough time to complete query before resetting by milou
Needs ReviewPublic

Authored by McPain on Thu, Jul 12, 7:22 AM.

Details

Reviewers
broulik
Summary

CCBUG: 390776

Diff Detail

Repository
R112 Milou
Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Thu, Jul 12, 7:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Jul 12, 7:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Thu, Jul 12, 7:22 AM
McPain retitled this revision from Dictionary haven't enough time to complete query before resetting by milou to Dictionary doesn't have enough time to complete query before resetting by milou.Thu, Jul 12, 11:43 AM

Thanks for the patch! It will be nice to get the Dictionary runner working again.

Please change https://bugs.kde.org/show_bug.cgi?id=390776 to CCBUG: 390776. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords

I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I don't understand why it has this code in the first place.

McPain edited the summary of this revision. (Show Details)Thu, Jul 12, 2:25 PM

I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I don't understand why it has this code in the first place.

As far as I know, krunner uses milou to launch queries:

https://cgit.kde.org/milou.git/tree/lib/sourcesmodel.cpp#n215