CCBUG: 390776
Details
Diff Detail
- Repository
- R112 Milou
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Thanks for the patch! It will be nice to get the Dictionary runner working again.
Please change https://bugs.kde.org/show_bug.cgi?id=390776 to CCBUG: 390776. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords
I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I don't understand why it has this code in the first place.
As far as I know, krunner uses milou to launch queries:
https://cgit.kde.org/milou.git/tree/lib/sourcesmodel.cpp#n215
Any movement on this? It would be great to use the dictionary in krunner. Still broken in 5.13.4.
Urgh. Just read the code.
We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back.
That leaves a problem when you search for "firefo" ( with 1 result) to "firefodfhhxtffrdh" with zero results. Which is what this timer "solves"
Clearly its not a good solution to the problem. Changing it to 5 seconds isn't helping.
which solution would be good?
PS I didn't understand yet why this solution isn't good enough and what things are still broken