This moves the URL rewriting logic to the KIO slave so the client just sees a pretty baloosearch:/images URL and the rewriting to a JSON query happens inside the KIO
Details
Details
- Reviewers
bruns dfaure renatoo franckarrecot hein ngraham - Group Reviewers
Frameworks - Commits
- R293:d02597aa9406: Support special URLs for finding files of a certain type
Mostly copy paste from KFilePlacesModel
- Opened baloosearch:/images and got pictures
(Could probably use Query class directly instead of going through JSON but it was the simplest way to move this code over)
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Tested with a new and existing user. Entries in Kickoff, Dolphin, Gwenview, and the file dialogs all work perfectly, and the subtitles in Kickoff are pretty. Code looks sane.
Comment Actions
Does it make sense to name the queries after XDG_USER_DIRS, so e.g. pictures instead of images?
Comment Actions
That might introduce the potential for user confusion, for people who add the XDG dirs to their Places panels (or if we ever did that by default), because then there would be multiple entries in different sections with the same text.