Use a broom-style icon for clearing clipboard and notification history
ClosedPublic

Authored by ngraham on Jul 13 2018, 10:44 PM.

Details

Summary

Use Breeze's new broom-style icon for the Clear History buttons in the Klipper and Notification plasmoids.

Test Plan

With Frameworks 5.48, the broom-style icon will be shown:


With an earlier Frameworks version or a different icon theme, a backspace-style icon will be displayed:

Diff Detail

Repository
R120 Plasma Workspace
Branch
broom-style-clear-history-icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 840
Build 853: arc lint + arc unit
ngraham created this revision.Jul 13 2018, 10:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 13 2018, 10:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 13 2018, 10:44 PM
ngraham edited the test plan for this revision. (Show Details)Jul 13 2018, 11:12 PM
Zren added a subscriber: Zren.Jul 14 2018, 1:28 AM

Should the context menu also use this icon?

ngraham updated this revision to Diff 37745.Jul 14 2018, 1:52 PM

Also use the new icon in the context menu

ngraham edited the test plan for this revision. (Show Details)Jul 14 2018, 1:52 PM
davidedmundson accepted this revision.Jul 14 2018, 2:42 PM
This revision is now accepted and ready to land.Jul 14 2018, 2:42 PM

Thanks! @Fuchs and/or @broulik?

Can't test it currently, looks fine, just one question: did you test what happens on other icon sets than breeze?
If that doesn't work, I'd say we should fix it in the icon theme, but that would be something that would make me think don't ship yet.

Otherwise I'd say ship :)

This comment was removed by ngraham.

Right, it's not a problem:

  1. Either the theme has its own version of that icon (as Oxygen does)
  2. ...Or else the theme symlinks that icon to something else (as Papirus does; it's symlinked to edit-clear which looks like the backspace symbol)...
  3. ...Or else it falls back to the Breeze icon (which in 5.48 is a broom, and prior to 5.48 looks like the backspace symbol)
Fuchs accepted this revision.Jul 15 2018, 3:22 PM

if it falls back then all is perfect :)

ngraham closed this revision.Jul 15 2018, 3:29 PM
abetts added a subscriber: abetts.Jul 23 2018, 6:52 PM

Can you share the svg file for this icon please? I would like to edit it a little bit

It's the edit-clear-history icon in the breeze-icons repo.

It's the edit-clear-history icon in the breeze-icons repo.

Can you help me find that repo please? I have no clue how to get there.

<teach-a-man-to-fish-mode>Check out https://community.kde.org/Get_Involved/development#Get_the_code :)</teach-a-man-to-fish-mode>