Move scale and unify button to the top, next to primary combo
ClosedPublic

Authored by gladhorn on Tue, Jul 10, 8:57 AM.

Details

Reviewers
sebas
ngraham
davidedmundson
Group Reviewers
VDG
Plasma

Diff Detail

Repository
R104 KScreen
Branch
gladhorn/ui
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 727
Build 739: arc lint + arc unit
gladhorn created this revision.Tue, Jul 10, 8:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Jul 10, 8:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Tue, Jul 10, 8:57 AM

The diff is confusing. It actually moves the buttons into the other layout :)

Please add a screenshot when you do UI changes

This is at least a first step in making the UI a bit nicer. And imho it's a low-hanging fruit.

ngraham accepted this revision.Tue, Jul 10, 12:14 PM
ngraham added a subscriber: ngraham.

+1

The correct way to express this is: Depends on D14024, and it has to be in the Summary section.

This revision is now accepted and ready to land.Tue, Jul 10, 12:14 PM
davidedmundson accepted this revision.Wed, Jul 11, 1:03 PM
gladhorn closed this revision.Wed, Jul 11, 7:49 PM

Pushed, sadly without the phabricator tag, since I'm struggling to manage > 1 patch with phabricator.
b01b567296b70b9b593eaa438d86dffe7b663afa

The Unify Outputs button definitely makes sense to be there, but I'm not sure about the "Scale display" button.

The "Primary display" selection and the Unify Outputs button both affect the whole setup, whereas Scale Display only affects the selected display, correct?
Or does the latter depend on whether we're on X11 or Wayland?

It (currently) depends. There are two scale UI options with the appropriate one visible.

The global scale factor for X is the only one that's moved.

It (currently) depends. There are two scale UI options with the appropriate one visible.

The global scale factor for X is the only one that's moved.

Ah, cool, that's perfect then :)