Add bluetooth plugin
ClosedPublic
Actions

Authored by nicolasfella on Jul 11 2018, 5:13 PM.

Details

Reviewers

apol
ngraham

Commits

R495:0c9bf25e18a8: Add bluetooth plugin

Summary

Replace Bluedevil's FileItemActionPlugin

Test Plan

Share > Send via Bluetooth > Pick Device. Check for received file on other device.

Repository

R495 Purpose Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Jul 11 2018, 5:13 PM

Looks great and works great!

This revision is now accepted and ready to land.Jul 13 2018, 1:01 PM

@apol I would like your opinion before merging

LGTM overall.

src/plugins/bluetooth/CMakeLists.txt
2	Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`?

src/plugins/bluetooth/CMakeLists.txt
2	Makes sense. When I include it cmake tells me it's not found, although /usr/lib/qt/qml/org/kde/bluezqt exists. Am I missing something?

Yes, I can reproduce too. qmlplugindump-qt5 org.kde.bluezqt 1.0 returns 2 for some reason. Will have to investigate.

Land this for now if you want.

This revision was automatically updated to reflect the committed changes.

		Path
M		src/plugins/CMakeLists.txt (1 line)
A	M	src/plugins/bluetooth/CMakeLists.txt (1 line)
A	M	src/plugins/bluetooth/Messages.sh (4 lines)
A	M	src/plugins/bluetooth/bluetoothplugin.cpp (95 lines)
A	M	src/plugins/bluetooth/bluetoothplugin.json (23 lines)
A	M	src/plugins/bluetooth/bluetoothplugin_config.qml (51 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37582	8191f4a		Jul 11 2018, 5:13 PM	★	★
Diff 2	37583	8191f4a	- Revert unintended change	Jul 11 2018, 5:15 PM	★	★
Diff 3	37969	6803b12	R495:0c9bf25e18a8e396af73d0a3066205bbc18d62f5	Jul 17 2018, 4:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a537699d3034	73ca64392e5a	e5cd2b12b71e	Nicolas Fella	Revert unintended change	Jul 11 2018, 5:15 PM
e5cd2b12b71e	80de6b7c7515	4a85c985a1e4	Nicolas Fella	Add bluetooth plugin (Show More…)	Jul 11 2018, 5:08 PM
4a85c985a1e4	96275dd9aa42	1cb92e240c1c 8191f4a739d5	Nicolas Fella	Merge branch 'master' into bluetooth	Jul 11 2018, 1:22 PM
1cb92e240c1c	cb73af529008	6f74cbb9659f	Nicolas Fella	Bluetooth stub	May 27 2018, 1:47 PM