jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (212 w, 6 d)
Availability
Available

Recent Activity

Wed, Sep 18

jgrulich committed R257:f41edbbb7564: Remove dconf access, should be handled now through portal (authored by jgrulich).
Remove dconf access, should be handled now through portal
Wed, Sep 18, 12:30 PM
jgrulich committed R257:b717ed993e22: Replace html5-codecs with correct extension (authored by jgrulich).
Replace html5-codecs with correct extension
Wed, Sep 18, 11:47 AM
jgrulich committed R257:e776094bd85b: html5-codecs extension no longer exists (authored by jgrulich).
html5-codecs extension no longer exists
Wed, Sep 18, 11:24 AM
jgrulich added inline comments to D23578: Before requesting a scan, check the time threshold.
Wed, Sep 18, 7:35 AM · Plasma
jgrulich committed R838:d65e389b4df0: PipeWire: use thread loop instead of watching a socket (authored by jgrulich).
PipeWire: use thread loop instead of watching a socket
Wed, Sep 18, 6:59 AM

Tue, Sep 17

jgrulich added inline comments to D23578: Before requesting a scan, check the time threshold.
Tue, Sep 17, 7:43 AM · Plasma

Mon, Sep 16

jgrulich committed R257:e534908241a8: Fix build of kwayland-integration (authored by jgrulich).
Fix build of kwayland-integration
Mon, Sep 16, 10:43 AM
jgrulich committed R257:74d91b0f045b: Cleanup (authored by jgrulich).
Cleanup
Mon, Sep 16, 9:52 AM
jgrulich committed R257:eb79591fa243: Qt 5.13 runtime based on Freedesktop runtime 19.08 (authored by jgrulich).
Qt 5.13 runtime based on Freedesktop runtime 19.08
Mon, Sep 16, 8:45 AM

Fri, Sep 13

jgrulich committed R116:695846c500d8: Show connectivity status in tooltip (authored by jgrulich).
Show connectivity status in tooltip
Fri, Sep 13, 6:36 PM
jgrulich closed D23852: Show connectivity status in tooltip.
Fri, Sep 13, 6:36 PM · Plasma

Thu, Sep 12

l10n daemon script <scripty@kde.org> committed R282:3ce19df2ba71: ActiveConnection: connect stateChanged() signal to correct interface (authored by jgrulich).
ActiveConnection: connect stateChanged() signal to correct interface
Thu, Sep 12, 8:56 AM

Tue, Sep 10

jgrulich accepted D23713: strongswan support for custom proposals.
Tue, Sep 10, 9:23 PM · Plasma, Frameworks
jgrulich updated the diff for D23852: Show connectivity status in tooltip.
  • Address review comments
Tue, Sep 10, 9:22 PM · Plasma
jgrulich added a comment to D23852: Show connectivity status in tooltip.

Don't you need to connect to connectivity change signal, too?

Tue, Sep 10, 9:13 PM · Plasma
jgrulich committed R282:a7cddf6196ad: ActiveConnection: connect stateChanged() signal to correct interface (authored by jgrulich).
ActiveConnection: connect stateChanged() signal to correct interface
Tue, Sep 10, 9:12 PM
jgrulich requested review of D23852: Show connectivity status in tooltip.
Tue, Sep 10, 8:23 PM · Plasma
jgrulich accepted D23578: Before requesting a scan, check the time threshold.
Tue, Sep 10, 8:37 AM · Plasma
jgrulich added a comment to D23713: strongswan support for custom proposals.

Do not enable "Custom cipher proposals" by default, that forces everyone to uncheck it.

Tue, Sep 10, 7:38 AM · Plasma, Frameworks

Sat, Sep 7

jgrulich updated the diff for D23766: FakeInput: add support for keyboard key press and release.

Bump framework version

Sat, Sep 7, 8:48 PM · Frameworks
jgrulich added a dependency for D23769: Add support for keyboard key press and release from fake input protocol: D23766: FakeInput: add support for keyboard key press and release.
Sat, Sep 7, 11:37 AM · KWin
jgrulich added a dependent revision for D23766: FakeInput: add support for keyboard key press and release: D23769: Add support for keyboard key press and release from fake input protocol.
Sat, Sep 7, 11:37 AM · Frameworks
jgrulich requested review of D23769: Add support for keyboard key press and release from fake input protocol.
Sat, Sep 7, 11:36 AM · KWin
jgrulich added inline comments to D23766: FakeInput: add support for keyboard key press and release.
Sat, Sep 7, 11:16 AM · Frameworks
jgrulich added inline comments to D23766: FakeInput: add support for keyboard key press and release.
Sat, Sep 7, 10:38 AM · Frameworks
jgrulich added reviewers for D23766: FakeInput: add support for keyboard key press and release: davidedmundson, apol, Plasma, romangg.
Sat, Sep 7, 10:00 AM · Frameworks
jgrulich requested review of D23766: FakeInput: add support for keyboard key press and release.
Sat, Sep 7, 9:59 AM · Frameworks

Wed, Sep 4

jgrulich added a comment to D23713: strongswan support for custom proposals.

I'm not sure the "Cipher Proposals" groupbox should be inside the "Options" groupbox, imo it should be separated groupbox

Wed, Sep 4, 11:48 AM · Plasma, Frameworks
jgrulich added inline comments to D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.
Wed, Sep 4, 11:35 AM · Frameworks
jgrulich added inline comments to D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.
Wed, Sep 4, 10:52 AM · Frameworks

Mon, Sep 2

jgrulich accepted D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.
Mon, Sep 2, 9:06 AM · Frameworks
jgrulich accepted D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.

Sorry, I missed that last one. Once it's fixed it's ready to go.

Mon, Sep 2, 8:47 AM · Frameworks
jgrulich added inline comments to D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.
Mon, Sep 2, 8:25 AM · Frameworks

Fri, Aug 30

jgrulich added inline comments to D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.
Fri, Aug 30, 12:39 PM · Frameworks
jgrulich added inline comments to D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.
Fri, Aug 30, 12:15 PM · Frameworks
jgrulich added inline comments to D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.
Fri, Aug 30, 12:12 PM · Frameworks
jgrulich added a comment to D23576: Add property lastScanTime and lastRequestTime to WirelessDevice.

I am hesitant to add a second field "previousScan" that would store the previous lastScan timeStamp when a new one arrives.
This would be used to compute the time elapsed between the scans which is necessary to do since Network manager requires scans to be at least 10 seconds apart :
https://github.com/NetworkManager/NetworkManager/blob/master/src/devices/wifi/nm-device-wifi.c#L1205

Fri, Aug 30, 11:26 AM · Frameworks

Mon, Aug 26

jgrulich edited reviewers for D21035: Remove disconnected network devices from Network Monitor., added: mart; removed: jgrulich.
Mon, Aug 26, 11:37 AM · Plasma
jgrulich updated subscribers of D21035: Remove disconnected network devices from Network Monitor..

Looks good to me, but I'm not the author of this code. I would rather let @mart to approve this review.

Mon, Aug 26, 11:37 AM · Plasma

Aug 22 2019

jgrulich accepted D23248: Make "Network Disconnected" notification low priority.
Aug 22 2019, 3:11 PM · Plasma
jgrulich accepted D23125: fix bridge master:slave mapping by-name.
Aug 22 2019, 3:11 PM · Plasma

Aug 16 2019

jgrulich added a comment to D23125: fix bridge master:slave mapping by-name.

The parent knows the connection id, if you look into ConnectionEditorBase::initialize(), then you can get the id using

"m_connection->id()"
Aug 16 2019, 10:17 AM · Plasma

Aug 14 2019

jgrulich accepted D23148: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON.
Aug 14 2019, 9:32 AM · Plasma

Aug 12 2019

jgrulich committed R257:2ac4fd348b94: Add extension point for Qt wayland decorations (authored by jgrulich).
Add extension point for Qt wayland decorations
Aug 12 2019, 11:53 AM
jgrulich closed D23040: Add extension point for Qt wayland decorations.
Aug 12 2019, 11:53 AM
jgrulich committed R116:ccce9e3cd247: Use QQuickWidget instead of a QQuickView placed into QWidget (authored by jgrulich).
Use QQuickWidget instead of a QQuickView placed into QWidget
Aug 12 2019, 11:52 AM
jgrulich closed D23020: Use QQuickWidget instead of a QQuickView placed into QWidget.
Aug 12 2019, 11:52 AM · Plasma

Aug 9 2019

jgrulich requested review of D23040: Add extension point for Qt wayland decorations.
Aug 9 2019, 10:25 AM
jgrulich updated the diff for D23027: Add information about substituting font into properties dialog.

Better use of i18nc API

Aug 9 2019, 7:52 AM · Okular
jgrulich updated the diff for D23027: Add information about substituting font into properties dialog.

Use translatable string

Aug 9 2019, 7:10 AM · Okular
jgrulich updated the diff for D23027: Add information about substituting font into properties dialog.

Move information about substituting fonto into the first column

Aug 9 2019, 3:41 AM · Okular

Aug 8 2019

jgrulich requested review of D23027: Add information about substituting font into properties dialog.
Aug 8 2019, 10:10 AM · Okular
jgrulich updated the summary of D23020: Use QQuickWidget instead of a QQuickView placed into QWidget.
Aug 8 2019, 6:48 AM · Plasma
jgrulich added a reviewer for D23020: Use QQuickWidget instead of a QQuickView placed into QWidget: Plasma.
Aug 8 2019, 6:48 AM · Plasma
jgrulich requested review of D23020: Use QQuickWidget instead of a QQuickView placed into QWidget.
Aug 8 2019, 6:47 AM · Plasma

Aug 6 2019

jgrulich committed R257:d2db53cd1024: Use wayland platform plugin on Gnome (authored by jgrulich).
Use wayland platform plugin on Gnome
Aug 6 2019, 11:57 AM
jgrulich closed D22829: Use wayland platform plugin on Gnome.
Aug 6 2019, 11:09 AM
jgrulich added a comment to D22829: Use wayland platform plugin on Gnome.

Aleix, do you think we can get this merged? It might take a while to get this upstreamed and it's pretty annoying to have Qt apps use xcb plugin on Gnome wayland when you use HiDPI display, it forces me to set everything manually.

Aug 6 2019, 7:14 AM

Jul 31 2019

jgrulich requested review of D22850: Update appstream metadata with missing tags.
Jul 31 2019, 10:17 AM
jgrulich added a comment to D22829: Use wayland platform plugin on Gnome.
In D22829#504209, @apol wrote:

Can we get this upstream? If it works for us it should work for everyone.

Jul 31 2019, 7:47 AM

Jul 30 2019

jgrulich added a comment to D22829: Use wayland platform plugin on Gnome.
In D22829#504209, @apol wrote:

Can we get this upstream? If it works for us it should work for everyone.

Jul 30 2019, 2:17 PM
jgrulich added a reviewer for D22829: Use wayland platform plugin on Gnome: apol.
Jul 30 2019, 2:07 PM
jgrulich requested review of D22829: Use wayland platform plugin on Gnome.
Jul 30 2019, 2:05 PM

Jul 29 2019

jgrulich committed R257:a419cec83d2c: Runtime doesn't use /app prefix (authored by jgrulich).
Runtime doesn't use /app prefix
Jul 29 2019, 2:55 PM
jgrulich committed R257:25acd8addfa4: Add udev and enable to build udisks2 backend for Solid (authored by jgrulich).
Add udev and enable to build udisks2 backend for Solid
Jul 29 2019, 11:45 AM

Jul 25 2019

jgrulich committed R116:1840ff48f11d: Remove leftover from abandoned review (authored by jgrulich).
Remove leftover from abandoned review
Jul 25 2019, 12:11 PM
jgrulich committed R116:5157c8982686: Some property changes affect more roles (authored by jgrulich).
Some property changes affect more roles
Jul 25 2019, 11:29 AM
jgrulich abandoned D22734: Support displaying emoticons in connection name and SSID.

-1 to dragging in KEmoticons for that.
Aren't they just unicode Emojis which we can render just fine elsewhere.

Jul 25 2019, 11:22 AM · Plasma
jgrulich added a reviewer for D22734: Support displaying emoticons in connection name and SSID: Plasma.
Jul 25 2019, 8:51 AM · Plasma
jgrulich updated the summary of D22734: Support displaying emoticons in connection name and SSID.
Jul 25 2019, 8:50 AM · Plasma
jgrulich requested review of D22734: Support displaying emoticons in connection name and SSID.
Jul 25 2019, 8:50 AM · Plasma
jgrulich committed R116:f8c62a42f9f1: Alphabeticaly sort list of dependencies (authored by jgrulich).
Alphabeticaly sort list of dependencies
Jul 25 2019, 7:05 AM
jgrulich committed R116:71503bacae90: Merge branch 'Plasma/5.16' (authored by jgrulich).
Merge branch 'Plasma/5.16'
Jul 25 2019, 6:42 AM
jgrulich committed R116:7dd740aa9630: Airplane mode improvements (authored by jgrulich).
Airplane mode improvements
Jul 25 2019, 5:33 AM
jgrulich closed D22680: Airplane mode improvements.
Jul 25 2019, 5:33 AM · Plasma

Jul 23 2019

jgrulich updated the summary of D22680: Airplane mode improvements.
Jul 23 2019, 12:36 PM · Plasma
jgrulich added a reviewer for D22680: Airplane mode improvements: Plasma.
Jul 23 2019, 11:35 AM · Plasma
jgrulich requested review of D22680: Airplane mode improvements.
Jul 23 2019, 11:34 AM · Plasma

Jul 22 2019

jgrulich committed R838:c8112eb20f76: GLIB2 shouldn't be required (authored by jgrulich).
GLIB2 shouldn't be required
Jul 22 2019, 8:33 AM
jgrulich committed R116:a6bce5fccc14: Exclude non-managed devices from plasma-nm (authored by jgrulich).
Exclude non-managed devices from plasma-nm
Jul 22 2019, 5:24 AM
jgrulich closed D19440: Exclude non-managed devices from plasma-nm.
Jul 22 2019, 5:24 AM · Plasma
jgrulich added a comment to D19440: Exclude non-managed devices from plasma-nm.
Jul 22 2019, 5:22 AM · Plasma
jgrulich added a comment to D19440: Exclude non-managed devices from plasma-nm.

@jgrulich should we land this?

Yes.

Jul 22 2019, 5:20 AM · Plasma

Jul 21 2019

jgrulich added a comment to D18114: FakeInput: add support for pointer move with absolute coordinates.

@jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question about keysyms and key events but we should discuss this in the new diff. Maybe we can have both: Keysyms for special keys / combinations like Alt+Tab and text input via text-input protocol?

Jul 21 2019, 8:08 AM · Frameworks

Jul 19 2019

jgrulich accepted D22550: Make Prison optional.
Jul 19 2019, 8:46 AM · Plasma
jgrulich accepted D22549: Add Prison as RUNTIME dependency.
Jul 19 2019, 8:45 AM · Plasma

Jul 17 2019

jgrulich added a comment to D22482: WIP: Show file dialog in directory mode when only directory is requested.

What would be the usecase here? I can think of Firefox only, but as I mentioned, it won't work with Firefox, because it behaves exactly the same way as Qt, which means a dialog inside sandbox is opened when requesting to open a folder.

Jul 17 2019, 7:39 AM · Plasma
jgrulich accepted D22457: Make it possible to show the QR of a network connection.

Much simple! Thanks.

Jul 17 2019, 4:15 AM · Plasma

Jul 16 2019

jgrulich added a comment to D22482: WIP: Show file dialog in directory mode when only directory is requested.

If this is meant to be used by Firefox, then it won't work either, even when you use GTK_USE_PORTAL=1.

Jul 16 2019, 7:27 AM · Plasma
jgrulich added inline comments to D22457: Make it possible to show the QR of a network connection.
Jul 16 2019, 6:02 AM · Plasma
jgrulich added a comment to D22482: WIP: Show file dialog in directory mode when only directory is requested.

The FileChooser portal will never ask for directories, it's currently not possible to expose a directory to the sandbox environment. If you look at [1], you can see it always uses native file dialog in case of directories, which means native file dialog will be opened inside the sandbox, not through the portal.

Jul 16 2019, 5:56 AM · Plasma

Jul 15 2019

jgrulich committed R257:82334ff23ca6: Backport upstream fix reverting qtbase change which breaks some widgets (authored by jgrulich).
Backport upstream fix reverting qtbase change which breaks some widgets
Jul 15 2019, 12:11 PM
jgrulich closed D22470: Backport upstream fix reverting qtbase change which breaks some widgets.
Jul 15 2019, 12:11 PM
jgrulich added a comment to D22470: Backport upstream fix reverting qtbase change which breaks some widgets.

For reference: I dropped a patch which introduced https://bugs.kde.org/show_bug.cgi?id=409711 for me. That patch shouldn't be necessary as explained in the bug, because the change for which this patch was used has been reverted.

Jul 15 2019, 10:10 AM
jgrulich added a reviewer for D22470: Backport upstream fix reverting qtbase change which breaks some widgets: apol.
Jul 15 2019, 10:09 AM
jgrulich requested review of D22470: Backport upstream fix reverting qtbase change which breaks some widgets.
Jul 15 2019, 10:08 AM
jgrulich added inline comments to D22457: Make it possible to show the QR of a network connection.
Jul 15 2019, 4:48 AM · Plasma
jgrulich accepted D22467: Make captive portal notification persistent but low priority.
Jul 15 2019, 4:28 AM · Plasma

Jul 11 2019

jgrulich committed R282:2d5a66004425: device: include reapplyConnection() in the interface (authored by aleksanderm).
device: include reapplyConnection() in the interface
Jul 11 2019, 12:04 PM
jgrulich closed D20238: device: include reapplyConnection() in the interface.
Jul 11 2019, 12:04 PM · Frameworks