jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (230 w, 2 d)
Availability
Available

Recent Activity

Yesterday

jgrulich committed R838:8ce0ca844642: Update support for PipeWire 0.3 (authored by jgrulich).
Update support for PipeWire 0.3
Tue, Jan 21, 12:20 PM
jgrulich committed R116:2d9889410d71: Merge branch 'Plasma/5.18' (authored by jgrulich).
Merge branch 'Plasma/5.18'
Tue, Jan 21, 9:18 AM
jgrulich committed R116:70c5d48f320b: Do not emit signals from lambda slot and constructor (authored by jgrulich).
Do not emit signals from lambda slot and constructor
Tue, Jan 21, 9:17 AM
jgrulich accepted D26802: [Applet] Focus search field after showing it.
Tue, Jan 21, 6:13 AM · Plasma

Thu, Jan 16

jgrulich committed R116:a612f63b1494: Merge branch 'Plasma/5.18' (authored by jgrulich).
Merge branch 'Plasma/5.18'
Thu, Jan 16, 2:45 PM
jgrulich committed R116:5ff67ff964b9: Do not hardcode icon sizes (authored by jgrulich).
Do not hardcode icon sizes
Thu, Jan 16, 2:20 PM
jgrulich accepted D26706: Remove notification inhibitor lock.
Thu, Jan 16, 2:04 PM · Plasma
jgrulich committed R116:86af881456da: Check whether the hotspot still exists after reboot or suspend (authored by jgrulich).
Check whether the hotspot still exists after reboot or suspend
Thu, Jan 16, 10:25 AM

Wed, Jan 15

jgrulich committed R116:5e55e45d8794: Add option to easily configure and start a hotspot (authored by jgrulich).
Add option to easily configure and start a hotspot
Wed, Jan 15, 11:53 AM
jgrulich closed D26392: Add option to easily configure and start a hotspot.
Wed, Jan 15, 11:53 AM · Plasma
jgrulich updated the diff for D26392: Add option to easily configure and start a hotspot.
  • Code improvements
Wed, Jan 15, 11:49 AM · Plasma

Mon, Jan 13

jgrulich updated the diff for D26392: Add option to easily configure and start a hotspot.

Address review comments:

  1. Add text to the toolbutton and make it checkable
  2. Allow to create hotspot only if WiFi is available or it's not used as primary connection
Mon, Jan 13, 4:47 PM · Plasma
jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.

Can someone please look into this review? Either try it or check the code? I would like to have this as part of Plasma 5.18 and deadline for that is in few days. @ngraham how is it going with the icon?

@cblack is working on it IIRC. It's too late to show the icon in Plasma 5.18 anyway (the icon will be in the breeze-icons repo which is a framework, and Frameworks 5.66 which Plasma 5.18 relies on has already been tagged. So there's no huge rush there IMO.

I'm still unable to test this because of the odd build failure that I cannot understand, explain, or overcome. :/

Mon, Jan 13, 8:58 AM · Plasma
jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.
In D26392#592136, @apol wrote:
In D26392#587159, @mthw wrote:

@apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi network. Currently enabling hotspot disables your previous connection (WiFi) and hides available WiFi networks.

That's a question. Do we want to allow to create a hotspot if users are already connected to w WiFi network? You are allowed to do this for example on Android. Users might not realize why they are not allowed to create a hotspot and disconnecting from WiFi doesn't seem to me be a good first step.

Leaving the user without a connection would be quite dishearting and possibly confusing.

I can imagine the use-case of: I am in this building with weird authentication (thinking university) and I want to share that connection with my phone, so I create a hotspot and we don't have to do weird configuration on the phone. Would apply to e.g. vpns too.

Mon, Jan 13, 8:56 AM · Plasma

Sat, Jan 11

jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.

Can someone please look into this review? Either try it or check the code? I would like to have this as part of Plasma 5.18 and deadline for that is in few days. @ngraham how is it going with the icon?

Sat, Jan 11, 7:41 PM · Plasma

Thu, Jan 9

jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.

No, even with networkmanager-qt from git master, I still get the same build failure here. :(

Thu, Jan 9, 4:00 PM · Plasma
jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.

This no longer compiles for me:

/home/nate/kde/src/plasma-nm/libs/handler.cpp: In member function ‘void Handler::createHotspot()’:
/home/nate/kde/src/plasma-nm/libs/handler.cpp:622:94: error: ‘addAndActivateConnection2’ is not a member of ‘NetworkManager’; did you mean ‘addAndActivateConnection’?
  622 |     QDBusPendingReply<QDBusObjectPath, QDBusObjectPath, QVariantMap> reply = NetworkManager::addAndActivateConnection2(connectionSettings->toMap(), wifiDev->uni(), QString(), options);
      |                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                              addAndActivateConnection
Thu, Jan 9, 9:15 AM · Plasma

Tue, Jan 7

jgrulich added a comment to D26421: Only show full name in review dialog.

I don't really remember, but I can see in the userHash() it's not used so this is probably safe. In the userHash() we directly use KUser().

Tue, Jan 7, 12:46 PM · Plasma

Mon, Jan 6

jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.

It requires networkmanager-qt from master (upcoming 5.66 version).

Mon, Jan 6, 7:26 PM · Plasma
jgrulich accepted D26461: [networkmanager-qt] Port QRegExp to QRegularExpression.
Mon, Jan 6, 1:09 PM · Frameworks
jgrulich accepted D26462: RFC: Register Secret Agent on startup.
Mon, Jan 6, 1:06 PM · Plasma
jgrulich committed R116:429aaa6f1e4a: Merge branch 'Plasma/5.17' (authored by jgrulich).
Merge branch 'Plasma/5.17'
Mon, Jan 6, 10:10 AM
jgrulich committed R116:0fa90285dc90: Merge branch 'Plasma/5.17' of git://anongit.kde.org/plasma-nm into Plasma/5.17 (authored by jgrulich).
Merge branch 'Plasma/5.17' of git://anongit.kde.org/plasma-nm into Plasma/5.17
Mon, Jan 6, 10:10 AM
jgrulich committed R116:fa1257cfc9f5: Do not crash when changing advanced IPv4 configuration (authored by jgrulich).
Do not crash when changing advanced IPv4 configuration
Mon, Jan 6, 10:10 AM
jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.

I used ToolButton instead of a regular button, reason is that I don't think there is enough space. If there is modem device available, there will be three checkboxes on the left and with a regular button in various languages this might not be enough space.

Mon, Jan 6, 8:16 AM · Plasma
jgrulich updated the diff for D26392: Add option to easily configure and start a hotspot.

Use button instead of checkbox

Mon, Jan 6, 8:14 AM · Plasma
jgrulich added inline comments to D26392: Add option to easily configure and start a hotspot.
Mon, Jan 6, 5:25 AM · Plasma
jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.

UI-wise, this would probably be better off as a button than a checkbox.

Personally, I'm more inclined to a checkbox. Why is "turn wifi on/off" not an action? Right now, I don't see the big difference.

Is the new "hotspot" equivalent to the "shared wifi", you can already set up?
If so, without really reading the patch details yet, just some remarks or ideas:

  1. If you have configured several hotspots in the KCM, you probably need to choose a default one or a specific one when activating the hotspot.
Mon, Jan 6, 5:23 AM · Plasma
jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.
In D26392#587159, @mthw wrote:

@apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi network. Currently enabling hotspot disables your previous connection (WiFi) and hides available WiFi networks.

Mon, Jan 6, 5:18 AM · Plasma

Fri, Jan 3

jgrulich updated the summary of D26392: Add option to easily configure and start a hotspot.
Fri, Jan 3, 1:11 PM · Plasma
jgrulich added a comment to D26392: Add option to easily configure and start a hotspot.

There are two things which need work or I'm not sure about:

  1. If this should be placed as a checkbox in the applet
  2. We need a different icon for the hotspot, currently there is no such icon in the Plasma theme and freeze for Plasma 5.18 is soon
Fri, Jan 3, 1:06 PM · Plasma
jgrulich updated the summary of D26392: Add option to easily configure and start a hotspot.
Fri, Jan 3, 1:05 PM · Plasma
jgrulich added reviewers for D26392: Add option to easily configure and start a hotspot: Plasma, ngraham.
Fri, Jan 3, 1:05 PM · Plasma
jgrulich requested review of D26392: Add option to easily configure and start a hotspot.
Fri, Jan 3, 1:04 PM · Plasma
jgrulich committed R282:72a30f13c5ce: Manager: add support for AddAndActivateConnection2 (authored by jgrulich).
Manager: add support for AddAndActivateConnection2
Fri, Jan 3, 10:48 AM
jgrulich accepted D26382: Port KCM menu away from PlasmaComponents.
Fri, Jan 3, 8:45 AM · Plasma

Thu, Jan 2

jgrulich committed R282:c833304eea82: Sync Utils::securityIsValid with NetworkManager (authored by jgrulich).
Sync Utils::securityIsValid with NetworkManager
Thu, Jan 2, 1:38 PM

Dec 20 2019

jgrulich committed R256:2415ebe0b7ed: Add --socket=cups for printing support (authored by jgrulich).
Add --socket=cups for printing support
Dec 20 2019, 1:15 PM
jgrulich closed D26080: Add --socket=cups for printing support.
Dec 20 2019, 1:15 PM

Dec 18 2019

jgrulich added a comment to D26080: Add --socket=cups for printing support.

I will land this once Flatpak 1.6 is released. While this can be used by older Flatpak version, it will not build with older Flatpak versions.

Dec 18 2019, 2:43 PM
jgrulich committed R116:7601936e3642: Move applet configuration to KCM (authored by jgrulich).
Move applet configuration to KCM
Dec 18 2019, 1:48 PM
jgrulich closed D26041: Move applet configuration to KCM.
Dec 18 2019, 1:48 PM · Plasma
jgrulich added inline comments to D26041: Move applet configuration to KCM.
Dec 18 2019, 1:43 PM · Plasma
jgrulich updated the diff for D26041: Move applet configuration to KCM.

Simplify tooltips

Dec 18 2019, 1:42 PM · Plasma
jgrulich added reviewers for D26080: Add --socket=cups for printing support: apol, aacid.
Dec 18 2019, 12:35 PM
jgrulich requested review of D26080: Add --socket=cups for printing support.
Dec 18 2019, 12:32 PM

Dec 17 2019

jgrulich committed R116:b91f05b721d0: Use QPointer for captive portal notification (authored by jgrulich).
Use QPointer for captive portal notification
Dec 17 2019, 10:54 AM
jgrulich added inline comments to D26041: Move applet configuration to KCM.
Dec 17 2019, 10:09 AM · Plasma
jgrulich updated the diff for D26041: Move applet configuration to KCM.

Fix review comments

Dec 17 2019, 10:06 AM · Plasma
jgrulich committed R116:1ffef126b8f0: Captive portal notification improvements (authored by jgrulich).
Captive portal notification improvements
Dec 17 2019, 9:47 AM
jgrulich closed D26042: Captive portal notification improvements.
Dec 17 2019, 9:47 AM · Plasma

Dec 16 2019

jgrulich committed R116:e5bc1e04dc94: Merge branch 'Plasma/5.17' (authored by jgrulich).
Merge branch 'Plasma/5.17'
Dec 16 2019, 2:13 PM
jgrulich committed R116:fd8303b6a5e7: Fortisslvpn: add option to ignore the password BUG: 414975 (authored by jgrulich).
Fortisslvpn: add option to ignore the password BUG: 414975
Dec 16 2019, 2:13 PM
jgrulich updated the diff for D26042: Captive portal notification improvements.

: - Notification might be already closed

Dec 16 2019, 10:19 AM · Plasma
jgrulich added a reviewer for D26042: Captive portal notification improvements: Plasma.
Dec 16 2019, 10:15 AM · Plasma
jgrulich requested review of D26042: Captive portal notification improvements.
Dec 16 2019, 10:15 AM · Plasma
jgrulich added reviewers for D26041: Move applet configuration to KCM: ngraham, Plasma.
Dec 16 2019, 9:53 AM · Plasma
jgrulich requested review of D26041: Move applet configuration to KCM.
Dec 16 2019, 9:51 AM · Plasma

Dec 14 2019

jgrulich accepted D25970: [applet] Make details text fully opaque and normal style.
Dec 14 2019, 2:57 PM · Plasma

Dec 12 2019

jgrulich committed R838:db8c092527ca: Merge branch 'Plasma/5.17' (authored by jgrulich).
Merge branch 'Plasma/5.17'
Dec 12 2019, 2:45 PM
jgrulich committed R838:6f4c4f350315: Print portal: xdg-desktop-portal assumes the pages to be used as indexes (authored by jgrulich).
Print portal: xdg-desktop-portal assumes the pages to be used as indexes
Dec 12 2019, 2:28 PM

Dec 9 2019

jgrulich added a comment to D25737: Avoid texture bleed rendering X11 window - New version.

I tested this now on KWin from master and the scaling seems to work fine, but I experienced broken Plasma, which might be because I installed KWin from master. Basically all Plasma stuff (panel, notifications) were semi-transparent and unclickable.

Dec 9 2019, 7:39 AM · KWin

Dec 6 2019

jgrulich added a comment to D25737: Avoid texture bleed rendering X11 window - New version.

I tried this patch in combination with https://phabricator.kde.org/D25611 and it breaks it completely.

Dec 6 2019, 12:08 PM · KWin

Dec 5 2019

jgrulich committed R116:8b9eb87388cc: Wired setting: improve handling of link negotiation (authored by jgrulich).
Wired setting: improve handling of link negotiation
Dec 5 2019, 2:43 PM
jgrulich closed D24866: Wired setting: improve handling of link negotiation.
Dec 5 2019, 2:43 PM · Plasma
jgrulich added inline comments to D24866: Wired setting: improve handling of link negotiation.
Dec 5 2019, 2:42 PM · Plasma
jgrulich added a comment to D24866: Wired setting: improve handling of link negotiation.

UI looks good to me.

Dec 5 2019, 12:53 PM · Plasma

Dec 3 2019

jgrulich committed R257:e4cf10ef222f: Build with CUPS support (authored by jgrulich).
Build with CUPS support
Dec 3 2019, 2:05 PM

Nov 26 2019

jgrulich committed R116:82e187663135: Add support for WPA3 (authored by jgrulich).
Add support for WPA3
Nov 26 2019, 6:30 AM
jgrulich closed D24691: Add support for WPA3.
Nov 26 2019, 6:30 AM · Plasma

Nov 25 2019

jgrulich added a comment to D24691: Add support for WPA3.

Ping?

Nov 25 2019, 1:01 PM · Plasma
jgrulich added a comment to D24866: Wired setting: improve handling of link negotiation.

Ping?

Nov 25 2019, 1:01 PM · Plasma
jgrulich committed R257:f6056c1aacae: Add executable permission to build script (authored by jgrulich).
Add executable permission to build script
Nov 25 2019, 9:29 AM

Nov 20 2019

jgrulich accepted D25408: [KCM] Port main page to QQC2.
Nov 20 2019, 7:14 AM · Plasma

Nov 19 2019

jgrulich accepted D25385: Use icon name instead of pixmap in notification.
Nov 19 2019, 6:39 AM · Plasma

Nov 18 2019

jgrulich accepted D25368: connect groupbox toggles to change signal.
Nov 18 2019, 3:10 PM · Plasma
jgrulich added a comment to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.

Hmm, reading the code more closely, it looks like it should already work. In fact, when I remove all my changes... it does work! I could have sworn that it didn't work before though.

Does this make any sense? Could it have been fixed by 7dd740aa963057c255fbbe83366504bbe48a240e?

Nov 18 2019, 8:40 AM · Plasma

Nov 15 2019

jgrulich added a comment to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.

We were actually saving already the value of current BT state, it was just not used. Your code assumes there is just one BT adapter, while in theory there might be more of them. What I would just is just simply not add property like m_tmpBluetoothEnabled and use m_bluetoothAdapters to check if the specific BT adapter was enabled before, that's why we save the object path together with the value. This should be done in the else if (enable && m_bluetoothAdapters.value(objPath)) branch. Just check whether it was enabled before and enable it in that case.

Nov 15 2019, 10:00 AM · Plasma
jgrulich committed R257:50a105e04b71: Fix path for KF5 plugins (authored by jgrulich).
Fix path for KF5 plugins
Nov 15 2019, 9:31 AM

Nov 14 2019

jgrulich committed R257:9ab7f1d56345: Add KIO extension point (authored by jgrulich).
Add KIO extension point
Nov 14 2019, 10:54 AM
jgrulich added a comment to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.

You are right, I didn't properly read what you do. I still think we should modify the already existing function to additionaly save the previous state, because most of the code is same. The only difference is "Set" vs "Get" method on DBus.

Nov 14 2019, 7:41 AM · Plasma

Nov 13 2019

jgrulich added a comment to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.

There is already a method to enable/disable BT, why don't you reuse it?

Nov 13 2019, 9:10 AM · Plasma

Nov 6 2019

jgrulich committed R437:b8861cd22970: Merge branch 'Applications/19.08' (authored by jgrulich).
Merge branch 'Applications/19.08'
Nov 6 2019, 1:52 PM
jgrulich committed R437:80db244c7ddd: Un-break portal support (authored by jgrulich).
Un-break portal support
Nov 6 2019, 1:51 PM
jgrulich closed D25167: Un-break portal support.
Nov 6 2019, 1:51 PM
jgrulich added a reviewer for D25167: Un-break portal support: apol.
Nov 6 2019, 11:07 AM
jgrulich requested review of D25167: Un-break portal support.
Nov 6 2019, 11:05 AM
jgrulich committed R838:db12a964b139: Un-break remote input portal (authored by apol).
Un-break remote input portal
Nov 6 2019, 11:03 AM

Nov 5 2019

jgrulich committed R257:14eb56552e20: Another attempt to fix qtwebengine build (authored by jgrulich).
Another attempt to fix qtwebengine build
Nov 5 2019, 2:36 PM
jgrulich committed R257:1f49574f5fa4: Another attempt to fix qtwebengine build (authored by jgrulich).
Another attempt to fix qtwebengine build
Nov 5 2019, 1:04 PM
jgrulich added a comment to D24866: Wired setting: improve handling of link negotiation.

Looks like a complete fix to #413211. I've tested it on Arch Linux with different modes. For me Ignore, Auto and 10/100/1000 Mbps modes worked as intended as well as duplex setup for 10 and 100.

The only questionable thing is an ability to set Half duplex for 1Gbps and 10 Gbps. The first one is virtually never used IRL (and does not work for some (I guess many) NIC's, and the second one is absent in the standard and therefore unlikely to be found anywhere. NetworkManager saves these values and silently ignores it's unabilty to apply them to the hardware.

Nov 5 2019, 8:13 AM · Plasma

Oct 31 2019

jgrulich committed R257:15a5efc4b7a0: Attempt to fix python installation (authored by jgrulich).
Attempt to fix python installation
Oct 31 2019, 3:04 PM

Oct 26 2019

jgrulich committed R257:be4d1a0b49f7: Disable debuginfo for python 2.7 (authored by jgrulich).
Disable debuginfo for python 2.7
Oct 26 2019, 6:48 AM

Oct 25 2019

jgrulich committed R257:b040a9f7750e: Drop dependencies which are already in runtime (authored by jgrulich).
Drop dependencies which are already in runtime
Oct 25 2019, 3:38 PM
jgrulich committed R257:2c92cf10b695: Update and fix python installation (authored by jgrulich).
Update and fix python installation
Oct 25 2019, 12:51 PM
jgrulich committed R257:cd2b1b6db390: Fix json syntax (authored by jgrulich).
Fix json syntax
Oct 25 2019, 10:55 AM
jgrulich committed R257:500fad52247c: Add qtwebengine (authored by jgrulich).
Add qtwebengine
Oct 25 2019, 10:53 AM
jgrulich accepted D24940: [Applet] Show more information in the Details tab.
Oct 25 2019, 10:41 AM · Plasma
jgrulich requested changes to D24940: [Applet] Show more information in the Details tab.
Oct 25 2019, 4:52 AM · Plasma
jgrulich committed R838:c85055441a22: Rewrite AppChooser dialog (authored by jgrulich).
Rewrite AppChooser dialog
Oct 25 2019, 4:49 AM