- User Since
- Aug 24 2015, 11:06 AM (220 w, 3 d)
You are right, I didn't properly read what you do. I still think we should modify the already existing function to additionaly save the previous state, because most of the code is same. The only difference is "Set" vs "Get" method on DBus.
There is already a method to enable/disable BT, why don't you reuse it?
Wed, Nov 6
Tue, Nov 5
Thu, Oct 31
Sat, Oct 26
Fri, Oct 25
Thu, Oct 24
I just pushed the very same change so you don't need to do the review. Can be closed then.
Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically.
- Add border around the view and use small radius around for item highlight
You could just push this without me doing review :).
Wed, Oct 23
Tue, Oct 22
- Add Kirigami2 as a dependency
- Code improvements
Mon, Oct 21
Can we drop this request? I believe it works just fine now.
Sun, Oct 20
- Improvements based on review comments
Fri, Oct 18
Address review comments
Thu, Oct 17
Use Dolphin from Flathub to open some file.
- Coding style
Is this better?
Add text to the button rather then using tooltip
This is the initial state of the dialog, which presents only apps associated with given mimetype. Then if you click at the button below, it will show all the apps and provide a search bar.
Do not duplicate desktop files
Alright, I believe you are correct.
Wed, Oct 16
Drop cmake change
Compare against lowercase value