jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (187 w, 22 h)
Availability
Available

Recent Activity

Yesterday

jgrulich committed R282:d75813d0b738: Fix constructors (authored by jgrulich).
Fix constructors
Mon, Mar 25, 11:23 AM
jgrulich committed R282:85cdcd5f6a6c: Add missing support for WireGuard into base setting class (authored by jgrulich).
Add missing support for WireGuard into base setting class
Mon, Mar 25, 11:23 AM
jgrulich committed R282:b5b7fb0b0fa3: WireGuard: fix constructor (authored by jgrulich).
WireGuard: fix constructor
Mon, Mar 25, 10:55 AM
jgrulich committed R282:c3f665a4788b: WireGuard: fix name (authored by jgrulich).
WireGuard: fix name
Mon, Mar 25, 8:25 AM

Thu, Mar 21

jgrulich accepted D19862: Several fixes related to the network state and applet messages/notifications..

Looks good to me. Thanks.

Thu, Mar 21, 1:47 PM
jgrulich committed R282:97c67bb0f04e: Wireguard: handle private key as secrets (authored by jgrulich).
Wireguard: handle private key as secrets
Thu, Mar 21, 7:30 AM
jgrulich committed R282:8f0abb4eebfd: Fix tcsetting test (authored by jgrulich).
Fix tcsetting test
Thu, Mar 21, 7:30 AM
jgrulich committed R282:fb1e2a0bcaf5: Wireguard: peers property should be NMVariantMapList (authored by jgrulich).
Wireguard: peers property should be NMVariantMapList
Thu, Mar 21, 7:30 AM

Sun, Mar 17

jgrulich committed R282:34e230cd94ef: Add Wireguard connection type support (authored by jgrulich).
Add Wireguard connection type support
Sun, Mar 17, 4:06 PM
jgrulich committed R282:2a39b623b68b: ActiveConnecton: add stateChangedReason signal where we can see the reason of… (authored by jgrulich).
ActiveConnecton: add stateChangedReason signal where we can see the reason of…
Sun, Mar 17, 9:47 AM

Fri, Mar 15

jgrulich committed R116:3dea89bad64a: Change entry of Endpoint UI (authored by andersonbruce).
Change entry of Endpoint UI
Fri, Mar 15, 2:23 PM
jgrulich closed D19434: Change entry of Endpoint UI.
Fri, Mar 15, 2:23 PM · Plasma
jgrulich accepted D19434: Change entry of Endpoint UI.
Fri, Mar 15, 12:46 PM · Plasma

Tue, Mar 5

Restricted Application added 1 blocking reviewer(s) for D17487: Check if the form has changed, and only reconnect if it has: jgrulich.

Can be closed if I'm not mistaken, the issue has been already fixed.

Tue, Mar 5, 10:52 AM · Plasma
Restricted Application added 1 blocking reviewer(s) for D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time: jgrulich.

Can you please rebase this change on top of master? It doesn't apply.

Tue, Mar 5, 10:33 AM · Plasma

Mon, Mar 4

jgrulich added a comment to D19434: Change entry of Endpoint UI.

Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min and max values so you don't need to validate it.

My preference is to only use a spinbox for entries with less than 100 possible values. I believe that the up/down arrows give the impression that clicking on them is the "proper" method of selecting a value and while some people know that you can type in a value into a spinbox, I believe that there are others who do not and I really don't want users to be metaphorically cursing my name when they are trying to click their way up to a port number of say, 23517. Also, using a simple LineEdit with color coding for indicating an unacceptable input is consistent with the rest of the interface.

Mon, Mar 4, 9:34 AM · Plasma

Sat, Mar 2

jgrulich accepted D19306: send a signal over dbus when the wrong password is provided.

Good idea to remove the failed connection.

Sat, Mar 2, 8:14 PM · Plasma
jgrulich accepted D19435: Remove redundant parameter fields.
Sat, Mar 2, 7:56 PM · Plasma
jgrulich added a comment to D19434: Change entry of Endpoint UI.

Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min and max values so you don't need to validate it.

Sat, Mar 2, 7:52 PM · Plasma
jgrulich added a comment to D19440: Exclude non-managed devices from plasma-nm.

Can you attach output from:

  1. nmcli -f all connection
  2. nmcli -f all device show
Sat, Mar 2, 7:41 PM · Plasma

Fri, Mar 1

jgrulich accepted D19440: Exclude non-managed devices from plasma-nm.

Should be enough I guess, but not sure if this would filter your connections also from the kcm, did you check?

Fri, Mar 1, 11:30 AM · Plasma
jgrulich accepted D19441: [File Chooser Portal] Confirm overwrite on saving.
Fri, Mar 1, 11:26 AM · Plasma

Feb 24 2019

jgrulich committed R838:8ef6eb3f7a95: Fix selection of multiple files BUG: 404739 (authored by jgrulich).
Fix selection of multiple files BUG: 404739
Feb 24 2019, 9:18 AM

Feb 23 2019

jgrulich committed R838:9d6acd6e718b: Merge branch 'Plasma/5.15' (authored by jgrulich).
Merge branch 'Plasma/5.15'
Feb 23 2019, 8:07 AM
jgrulich committed R838:27651ce21756: Properly convert filename to string from bytearray BUG: 404445 (authored by jgrulich).
Properly convert filename to string from bytearray BUG: 404445
Feb 23 2019, 8:07 AM

Feb 22 2019

jgrulich committed R257:9a812bce9b32: Backport fix for FileChooser portal (authored by jgrulich).
Backport fix for FileChooser portal
Feb 22 2019, 11:36 AM
jgrulich committed R257:819fabdc517d: Backport fix for FileChooser portal (authored by jgrulich).
Backport fix for FileChooser portal
Feb 22 2019, 10:43 AM

Feb 14 2019

jgrulich accepted D18896: [plasma-nm] Refresh wifi networks as fast as possible.

Looks good. Thank you.

Feb 14 2019, 1:48 PM · Plasma
jgrulich committed R838:7b01db1548ef: Merge branch 'remote-desktop' (authored by jgrulich).
Merge branch 'remote-desktop'
Feb 14 2019, 12:50 PM
jgrulich committed R108:b4a8977b3ab6: Add support for fake pointer move with absolute coordinates (authored by jgrulich).
Add support for fake pointer move with absolute coordinates
Feb 14 2019, 12:47 PM
jgrulich closed D18115: Add support for fake pointer move with absolute coordinates.
Feb 14 2019, 12:47 PM · KWin
jgrulich committed R127:12b58edd254a: FakeInput: add support for pointer move with absolute coordinates (authored by jgrulich).
FakeInput: add support for pointer move with absolute coordinates
Feb 14 2019, 12:44 PM
jgrulich closed D18114: FakeInput: add support for pointer move with absolute coordinates.
Feb 14 2019, 12:44 PM · Frameworks
jgrulich added inline comments to D18896: [plasma-nm] Refresh wifi networks as fast as possible.
Feb 14 2019, 11:48 AM · Plasma

Feb 13 2019

jgrulich added inline comments to D18896: [plasma-nm] Refresh wifi networks as fast as possible.
Feb 13 2019, 7:14 AM · Plasma
jgrulich committed R116:29b6d0ee5900: Remove redundant DNS field (authored by andersonbruce).
Remove redundant DNS field
Feb 13 2019, 7:10 AM
jgrulich closed D18867: Remove redundant DNS field.
Feb 13 2019, 7:10 AM · Plasma

Feb 12 2019

jgrulich committed R116:d77d4cb4bdce: Do not check NM version++ (authored by jgrulich).
Do not check NM version++
Feb 12 2019, 4:08 PM
jgrulich committed R116:12ebc3fde7bd: Do not check NM version (authored by jgrulich).
Do not check NM version
Feb 12 2019, 3:35 PM
jgrulich accepted D18867: Remove redundant DNS field.

I wonder whether this should also go to Plasma 5.15 branch, it's an improvement and doesn't introduce new strings so should be ok to be backported.

Feb 12 2019, 2:55 PM · Plasma
jgrulich added a comment to D18896: [plasma-nm] Refresh wifi networks as fast as possible.

I would keep the 15s interval, everyone does 15s. Also from what I have read, every scan drops your connection for a while, which might be a problem for bad wifi drivers, where the scan can take 15+ seconds so doing this more often is not a good idea. Other thing I would change is to try to repeat the scan if it fails only for the first time (when you open the applet), then I don't think it's necessary to keep spamming NetworkManager with our requests.

Everyone using 15 seconds for a timeout doesn't mean it's good for the users...

Feb 12 2019, 2:07 PM · Plasma

Feb 11 2019

jgrulich added inline comments to D18896: [plasma-nm] Refresh wifi networks as fast as possible.
Feb 11 2019, 7:05 AM · Plasma
jgrulich added a comment to D18896: [plasma-nm] Refresh wifi networks as fast as possible.

I would keep the 15s interval, everyone does 15s. Also from what I have read, every scan drops your connection for a while, which might be a problem for bad wifi drivers, where the scan can take 15+ seconds so doing this more often is not a good idea. Other thing I would change is to try to repeat the scan if it fails only for the first time (when you open the applet), then I don't think it's necessary to keep spamming NetworkManager with our requests.

Feb 11 2019, 6:58 AM · Plasma

Feb 6 2019

jgrulich committed R116:bc4d82c15657: plasma-nm Connection Icon not showing correct icon when using a bridge (authored by jgrulich).
plasma-nm Connection Icon not showing correct icon when using a bridge
Feb 6 2019, 4:48 PM
jgrulich closed D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.
Feb 6 2019, 4:47 PM · Plasma
jgrulich committed R116:e8e6a91d8fc9: Merge branch 'master' (authored by jgrulich).
Merge branch 'master'
Feb 6 2019, 7:55 AM
jgrulich committed R116:b7ac69861904: Get rid of Q_FOREACH (authored by jgrulich).
Get rid of Q_FOREACH
Feb 6 2019, 7:50 AM
jgrulich accepted D18745: Fix connections' context menus position and parent.

Seems to work. Thanks.

Feb 6 2019, 6:47 AM · Plasma
jgrulich added a comment to D18762: Add support for portals in KRun.

Looks good from the portal point of view, but I would rather wait for someone who knows KRun internally to approve this review.

Feb 6 2019, 6:42 AM · Frameworks
jgrulich accepted D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.
Feb 6 2019, 6:37 AM · Plasma

Feb 5 2019

jgrulich added a comment to D18745: Fix connections' context menus position and parent.

This breaks connection details, try to expand details for some available connection. There appears to be some issue with heigh of the items.

Feb 5 2019, 8:24 AM · Plasma
jgrulich accepted D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.
Feb 5 2019, 7:06 AM · Plasma

Feb 4 2019

jgrulich added a comment to D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

That sounds like a bug in NetworkManager, because ActivatingConnection should be the one which will become PrimaryConnection, that's what the documentation says, that's the reason why we use it. If it's a NM bug, we still need a workaround.

Feb 4 2019, 7:02 AM · Plasma
jgrulich committed R116:3a9706bafbf8: We require NM 1.4.0+ so we can remove these conditions (authored by jgrulich).
We require NM 1.4.0+ so we can remove these conditions
Feb 4 2019, 6:45 AM

Feb 3 2019

jgrulich added a comment to D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

Correct fix would be to set icon for bridge connections in the last else branch at the end of setIcons() method, probably guarded with a condition whether the user has enabled virtual connections.

Feb 3 2019, 5:44 PM · Plasma
jgrulich added a comment to D18689: plasma-nm Connection Icon not showing correct icon when using a bridge.

This doesn't seem to be a correct fix. We should be using icon for whatever connection is primary, not only when primary connection is wifi / ethernet / modem / bluetooth. If you check NM on dbus, what is the primary connection there? Is it the bridge one?

Feb 3 2019, 5:40 PM · Plasma

Feb 1 2019

jgrulich added a comment to D18621: Add again a button to manually scan for wireless networks.

If it wil be made configurable, you wouldn't be still able to use it, without depending on newer NM version.

Feb 1 2019, 7:17 AM · Plasma

Jan 31 2019

jgrulich added a comment to D18621: Add again a button to manually scan for wireless networks.

It's in 1.12.

If that's not an option, it wouldn't be the end of the world to re-request a scan on a 2 second timer in case Handler::replyFinished->Handler::RequestScan:
It'll just retry until it passes then go back to the 15s.

Jan 31 2019, 4:06 PM · Plasma
jgrulich added a comment to D18621: Add again a button to manually scan for wireless networks.

I can find LastScan in the fd.o apidox, but not in NMQt... ?!?

It doesn't seem to be there. So lets add it.

Jan 31 2019, 3:53 PM · Plasma
jgrulich added a comment to D18621: Add again a button to manually scan for wireless networks.

But there are legit cases where this timeout is way too long for no reason.

If you close the popup and reopen it before the NM timeout expires, then the first request will fail, no attempt will be made at redoing the scan, and you're stuck for 30 seconds with the same list.

Jan 31 2019, 12:47 PM · Plasma
jgrulich accepted D18607: Add a popup search bar to the plasma-nm applet.

Looks good to me and also seems to work properly.

Jan 31 2019, 7:02 AM · Plasma
jgrulich added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Does the hug allow for just a search button and a non-always visible search field?

Jan 31 2019, 6:38 AM · Plasma
jgrulich added a comment to D18621: Add again a button to manually scan for wireless networks.

In my opinion, this sort of thing is a "help the user feel in control" issue.

+1, it would be cool to have a button to scan for wireless networks. Today I tried to connect to Wi-Fi while having a wired connection activated, and no W-Fi networks were shown in plasma-nm applet. I had to use nmtui to connect to wireless net, so shame that plasma-nm lacks this functionality.

Jan 31 2019, 6:21 AM · Plasma
jgrulich added a comment to D18607: Add a popup search bar to the plasma-nm applet.

+1, I actually like it now with the search button. I will try it properly later and go through your code.

Jan 31 2019, 6:15 AM · Plasma

Jan 30 2019

jgrulich added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Besides, it doesn't seem to work as it should:

  1. It removed the button in the top right corner which opens the KCM
  2. When I restart plasmashell, the search bar is visible even when I have only 4 connections (no scrollbar), typing some text and clearing it makes it disappear correctly
Jan 30 2019, 7:18 PM · Plasma
jgrulich added a comment to D18621: Add again a button to manually scan for wireless networks.

I'm wrong, it actually doesn't perform scanning when the applet is opened. It should maybe be doing that, do initial scan on applet popup and then every 15 seconds only if you keep it opened.

Jan 30 2019, 6:52 PM · Plasma
jgrulich added a comment to D18621: Add again a button to manually scan for wireless networks.

I'm wrong, it actually doesn't perform scanning when the applet is opened. It should maybe be doing that, do initial scan on applet popup and then every 15 seconds only if you keep it opened.

Jan 30 2019, 6:29 PM · Plasma
jgrulich added a comment to D18607: Add a popup search bar to the plasma-nm applet.

With this approach I will basically see it all the time, you can have just one connection hidden and the search bar will pop up, I don't want that and in my opinion it doesn't look good. Either should be placed in the toolbar or visible only when you start typing.

Jan 30 2019, 6:20 PM · Plasma
jgrulich added a comment to D18621: Add again a button to manually scan for wireless networks.

I don't think this should be added again, there is no reason to. Plasma-nm will do an initial scan once the applet is opened so you get the new networks immediately. This has been discussed with NetworkManager developers and everyone has to do now periodic scanning in some sane interval. Gnome does the some.

Jan 30 2019, 6:11 PM · Plasma
jgrulich added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Putting the search bar in the toolbar on top is an interesting idea. There's definitely room on mine. However it does start to feel a bit cramped. +1 for the idea of a search field though.

Jan 30 2019, 3:18 PM · Plasma
jgrulich added a comment to D18607: Add a popup search bar to the plasma-nm applet.

I guess it's not, maybe this can be configured in Phabricator somehow, no idea, I just don't want to miss any plasma-nm review as its maintainer.

This is something that Phabricator can do automatically, if it's configured. I've asked Sysadmin to do so: {T10420}

Jan 30 2019, 3:14 PM · Plasma
jgrulich added a comment to D18114: FakeInput: add support for pointer move with absolute coordinates.

Martin, can you please look into this?

Jan 30 2019, 12:46 PM · Frameworks
jgrulich added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Wouldn't be a small search bar placed next to the aiplane mode enough? That way it will not need additional vertical space. Hiding it when there is only a small amount of connections is a good idea.

Isn't there way too little space for it inside of the toolbar?

Jan 30 2019, 12:35 PM · Plasma
jgrulich added a comment to D18607: Add a popup search bar to the plasma-nm applet.

Wouldn't be a small search bar placed next to the aiplane mode enough? That way it will not need additional vertical space. Hiding it when there is only a small amount of connections is a good idea.

Jan 30 2019, 8:23 AM · Plasma

Jan 29 2019

jgrulich accepted D18588: Configuration to never show the passwors dialog.
Jan 29 2019, 10:49 AM · Plasma

Jan 28 2019

jgrulich committed R116:c1e7b79967b6: Connection settings: Add metered property (authored by jgrulich).
Connection settings: Add metered property
Jan 28 2019, 3:37 PM
jgrulich committed R116:f30a0aad0273: Implement connection saving (authored by jgrulich).
Implement connection saving
Jan 28 2019, 3:37 PM
jgrulich committed R116:e085d2716e3b: Merge branch 'master' into plasma-kcm (authored by jgrulich).
Merge branch 'master' into plasma-kcm
Jan 28 2019, 3:37 PM
jgrulich accepted D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection.

Looks good to me, I woud personally keep the header in the popup menu, at least I know I clicked on correct connection.

Jan 28 2019, 6:56 AM · Plasma

Jan 25 2019

jgrulich added a comment to D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection.

I'm not convinced this is needed at all. How often do you need to modify a connection?

Often enough that it annoys me that I have to open the connection editor first and then search the connection *again* in the list of connections. +1 for the change.

Jan 25 2019, 11:53 AM · Plasma
jgrulich added a comment to D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection.

I'm not convinced this is needed at all. How often do you need to modify a connection? I also don't think many people would discover this feature, because many of them also didn't discover context menu in KCM.

Jan 25 2019, 6:55 AM · Plasma

Jan 18 2019

jgrulich accepted D18364: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:42 PM · Plasma

Jan 17 2019

jgrulich added a comment to D18114: FakeInput: add support for pointer move with absolute coordinates.

Hi, can I get please this re-approved? It's now just again about the additional mouse support.

Jan 17 2019, 7:57 AM · Frameworks

Jan 10 2019

jgrulich added a comment to D18115: Add support for fake pointer move with absolute coordinates.

Just for the info, this will need to be pushed once Plasma 5.15 is branched, because it introduces dependency on KDE Frameworks 5.55.

Jan 10 2019, 9:30 AM · KWin
jgrulich committed R437:6c44260016ca: Implement mouse support (authored by jgrulich).
Implement mouse support
Jan 10 2019, 8:26 AM
jgrulich committed R838:5f64fb5bbd4e: Merge branch 'master' into remote-desktop (authored by jgrulich).
Merge branch 'master' into remote-desktop
Jan 10 2019, 7:59 AM
jgrulich committed R838:ecf84c4626c9: Implement mouse support (authored by jgrulich).
Implement mouse support
Jan 10 2019, 7:57 AM
jgrulich retitled D18115: Add support for fake pointer move with absolute coordinates from Add support for fake pointer move with absolute coordinates and keyboard key press and release to Add support for fake pointer move with absolute coordinates.
Jan 10 2019, 5:55 AM · KWin
jgrulich updated the diff for D18115: Add support for fake pointer move with absolute coordinates.

Drop keyboard support

Jan 10 2019, 5:55 AM · KWin
jgrulich updated the summary of D18114: FakeInput: add support for pointer move with absolute coordinates.
Jan 10 2019, 5:54 AM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Drop keyboard support from this review

Jan 10 2019, 5:53 AM · Frameworks

Jan 9 2019

jgrulich committed R257:a029f2957e94: Include missing patch (authored by jgrulich).
Include missing patch
Jan 9 2019, 5:26 PM
jgrulich committed R257:0a49ddc60e41: Avoid requiring kernel 3.17.0+ (authored by jgrulich).
Avoid requiring kernel 3.17.0+
Jan 9 2019, 5:24 PM
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Fix documentation

Jan 9 2019, 4:08 PM · Frameworks
jgrulich added a comment to D18114: FakeInput: add support for pointer move with absolute coordinates.

I didn't intent to push this together, but when creating a branch from master which already had first round of changes caused my second part of changes to be pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to get exception from David Faure to include this with KDE Frameworks 5.54. I thought the tagging is this saturday and tarballs are made after that, but I was wrong. I would really like to push the remote desktop support into Plasma 5.15, I have almost complete support in xdg-desktop-portal-kde and krfb.

Jan 9 2019, 3:48 PM · Frameworks
jgrulich retitled D18115: Add support for fake pointer move with absolute coordinates from Add support for fake pointer move with absolute coordinates to Add support for fake pointer move with absolute coordinates and keyboard key press and release.
Jan 9 2019, 3:39 PM · KWin
jgrulich updated the diff for D18115: Add support for fake pointer move with absolute coordinates.

Add support for keyboard key press and release

Jan 9 2019, 3:39 PM · KWin
jgrulich updated the summary of D18114: FakeInput: add support for pointer move with absolute coordinates.
Jan 9 2019, 3:38 PM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Add support for keyboard key press and release

Jan 9 2019, 3:37 PM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Bump fake interface version

Jan 9 2019, 3:16 PM · Frameworks