jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (203 w, 16 h)
Availability
Available

Recent Activity

Yesterday

jgrulich committed R257:82334ff23ca6: Backport upstream fix reverting qtbase change which breaks some widgets (authored by jgrulich).
Backport upstream fix reverting qtbase change which breaks some widgets
Mon, Jul 15, 12:11 PM
jgrulich closed D22470: Backport upstream fix reverting qtbase change which breaks some widgets.
Mon, Jul 15, 12:11 PM
jgrulich added a comment to D22470: Backport upstream fix reverting qtbase change which breaks some widgets.

For reference: I dropped a patch which introduced https://bugs.kde.org/show_bug.cgi?id=409711 for me. That patch shouldn't be necessary as explained in the bug, because the change for which this patch was used has been reverted.

Mon, Jul 15, 10:10 AM
jgrulich added a reviewer for D22470: Backport upstream fix reverting qtbase change which breaks some widgets: apol.
Mon, Jul 15, 10:09 AM
jgrulich requested review of D22470: Backport upstream fix reverting qtbase change which breaks some widgets.
Mon, Jul 15, 10:08 AM
jgrulich added inline comments to D22457: Make it possible to show the QR of a network connection.
Mon, Jul 15, 4:48 AM · Plasma
jgrulich accepted D22467: Make captive portal notification persistent but low priority.
Mon, Jul 15, 4:28 AM · Plasma

Thu, Jul 11

jgrulich committed R282:2d5a66004425: device: include reapplyConnection() in the interface (authored by aleksanderm).
device: include reapplyConnection() in the interface
Thu, Jul 11, 12:04 PM
jgrulich closed D20238: device: include reapplyConnection() in the interface.
Thu, Jul 11, 12:04 PM · Frameworks
jgrulich committed R281:a3d262f58d2f: Allow updating default DBus timeout on every interface (authored by aleksanderm).
Allow updating default DBus timeout on every interface
Thu, Jul 11, 11:32 AM
jgrulich closed D22395: Allow updating default DBus timeout on every interface.
Thu, Jul 11, 11:32 AM · Frameworks
jgrulich accepted D22395: Allow updating default DBus timeout on every interface.
Thu, Jul 11, 11:29 AM · Frameworks
jgrulich added a comment to D22395: Allow updating default DBus timeout on every interface.

I think all the methods should be called timeout() and setTimeout(), you are not changing default timeout which will always be 25s if -1 is set as timeout value. Also the getters should be const methods.

Thu, Jul 11, 11:05 AM · Frameworks
jgrulich accepted D22394: Polish IPv4 settings dialog.
Thu, Jul 11, 10:37 AM · Plasma
jgrulich accepted D22385: [mobile/wifi] Port settings to Kirigami Formlayout.

Hi Nicolas,

Thu, Jul 11, 6:07 AM · Plasma
jgrulich accepted D22344: Expose some more settings in an Advanced dialog.

Looks good to me now.

Thu, Jul 11, 5:57 AM · Plasma

Wed, Jul 10

jgrulich added a comment to D22344: Expose some more settings in an Advanced dialog.

You still need to add following lines to the loadConfig() method, otherwise those properties won't be filled when editing an existing connection:

Wed, Jul 10, 3:00 PM · Plasma
jgrulich added a comment to D22344: Expose some more settings in an Advanced dialog.

Don't you miss loading/saving of those properties in loadConfig() and setting() methods?

Wed, Jul 10, 5:46 AM · Plasma

Tue, Jul 9

jgrulich accepted D22341: [mobile/wifi] Port to SimpleKCM.
Tue, Jul 9, 4:38 PM · Plasma

Mon, Jul 8

jgrulich committed R116:3ebb0ad8cb60: Change validator for Endpoint Address entry field (authored by andersonbruce).
Change validator for Endpoint Address entry field
Mon, Jul 8, 7:15 AM
jgrulich closed D22283: Change validator for Endpoint Address entry field.
Mon, Jul 8, 7:12 AM · Plasma
jgrulich committed R116:12a7ea055197: Change validator for Endpoint Address entry field (authored by andersonbruce).
Change validator for Endpoint Address entry field
Mon, Jul 8, 7:12 AM
jgrulich accepted D22283: Change validator for Endpoint Address entry field.
Mon, Jul 8, 6:07 AM · Plasma

Wed, Jul 3

jgrulich committed R257:c8ebe366193c: Backport upstream fixes for qtwayland (authored by jgrulich).
Backport upstream fixes for qtwayland
Wed, Jul 3, 7:03 AM
jgrulich added a comment to D22205: Backport upstream fixes for qtwayland.

Thank you, I didn't know that.

Wed, Jul 3, 5:40 AM
jgrulich closed D22205: Backport upstream fixes for qtwayland.
Wed, Jul 3, 5:40 AM
jgrulich added a comment to D22205: Backport upstream fixes for qtwayland.

I'm from some reason unable to push it, I get:

remote: error: hook declined to update refs/heads/qt5.12lts
To ssh://git.kde.org/flatpak-kde-runtime
 ! [remote rejected] a6aabdda95d2d52b03b5259bd7eb905fc1b62f6b -> qt5.12lts (hook declined)
error: failed to push some refs to 'ssh://git@git.kde.org/flatpak-kde-runtime
Wed, Jul 3, 4:54 AM

Tue, Jul 2

jgrulich requested review of D22205: Backport upstream fixes for qtwayland.
Tue, Jul 2, 6:48 AM
jgrulich accepted D22202: [mobile/wifi] Rework NetworkSetting footer.
Tue, Jul 2, 5:58 AM · Plasma

Mon, Jul 1

jgrulich accepted D22189: [mobile/wifi] Remove useless margin declaration.
Mon, Jul 1, 3:48 PM · Plasma
jgrulich accepted D22188: [mobile/wifi] Rework list header.
Mon, Jul 1, 12:46 PM · Plasma
jgrulich accepted D22184: [mobile/wifi] Improve connection removal drawer.
Mon, Jul 1, 11:23 AM · Plasma
jgrulich accepted D22185: [mobile/wifi] Properly use i18n.
Mon, Jul 1, 11:22 AM · Plasma
jgrulich accepted D22178: [mobile/wifi] Fix some qml warnings in ConnectionItemDelegate.
Mon, Jul 1, 5:29 AM · Plasma
jgrulich accepted D22180: [mobile/wifi] Use default height for ConnectionItemDelegate.
Mon, Jul 1, 5:28 AM · Plasma
jgrulich accepted D22179: [mobile/wifi] Move network en/disable into main action.
Mon, Jul 1, 5:28 AM · Plasma

Wed, Jun 26

jgrulich accepted D22098: Don't keep requesting scans when wifi is disabled.
Wed, Jun 26, 5:43 AM · Plasma

Tue, Jun 25

jgrulich accepted D22079: Show an entry on the system tray indicator when a portal is needed.
Tue, Jun 25, 6:15 AM · Plasma

Mon, Jun 24

jgrulich accepted D21975: Remove explicit initialization of default constructed members.
Mon, Jun 24, 5:39 AM
jgrulich accepted D21974: Fix warning, remove unsigned int < 0 check.
Mon, Jun 24, 5:39 AM
jgrulich accepted D21976: Port away from KDELibs4Support, use Solid::Power interface.
Mon, Jun 24, 5:38 AM

Jun 6 2019

jgrulich added a comment to D21620: Handle Esc properly when focus is in searchbox.

@jgrulich unless you object, I'll land this on the stable branch once my comment has been addressed.

Jun 6 2019, 3:14 PM · Plasma
jgrulich accepted D21620: Handle Esc properly when focus is in searchbox.
Jun 6 2019, 2:47 PM · Plasma

Jun 5 2019

jgrulich accepted D21595: [CompactRepresentation] Glow on hover.
Jun 5 2019, 10:01 AM · Plasma

May 31 2019

jgrulich added a comment to D21501: Don't keep a full NetworkModel instance alive when it's not visible.

Doesn't seem to have any impact on performance.

May 31 2019, 6:29 AM · Plasma
jgrulich accepted D21501: Don't keep a full NetworkModel instance alive when it's not visible.
May 31 2019, 6:19 AM · Plasma

May 30 2019

jgrulich accepted D21486: Don't fetch device statistics upon construction.
May 30 2019, 5:49 AM · Frameworks

May 27 2019

jgrulich committed R116:179cd8baea41: Add the option to configure the realm (authored by jgrulich).
Add the option to configure the realm
May 27 2019, 5:41 AM
jgrulich closed D21296: Add the option to configure the realm.
May 27 2019, 5:41 AM · Plasma

May 24 2019

jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

\o/

For promo purposes, how can I use this or see it in action? What apps are necessary?

May 24 2019, 6:44 PM
jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

The only issue left is clipboard sharing. I'm certain it's triggered in some weird way and sends stray packets when VNC Server expects password. I've definitely seen network activity when the password field is selected/filled on Wayland.
Something I didn't see on X. Other than that, I'm mostly satisfied with the result.

May 24 2019, 11:55 AM
jgrulich committed R437:c05707884c17: Implement Wayland support using PipeWire and xdg-desktop-portal (authored by jgrulich).
Implement Wayland support using PipeWire and xdg-desktop-portal
May 24 2019, 11:51 AM
jgrulich closed D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.
May 24 2019, 11:51 AM

May 23 2019

jgrulich committed R838:ef64182a5369: Merge branch 'Plasma/5.16' (authored by jgrulich).
Merge branch 'Plasma/5.16'
May 23 2019, 11:45 AM
jgrulich committed R838:40f611855e0b: Fix potential build failure (authored by jgrulich).
Fix potential build failure
May 23 2019, 11:45 AM
jgrulich committed R838:170c27431d1d: Merge branch 'Plasma/5.16' (authored by jgrulich).
Merge branch 'Plasma/5.16'
May 23 2019, 9:44 AM
jgrulich committed R838:4d1df4e2d0c1: Allow some portals to run only on Plasma sessions (authored by jgrulich).
Allow some portals to run only on Plasma sessions
May 23 2019, 9:41 AM
jgrulich committed R116:2a56782e15d7: Openconnect: give context to the login button for correct translation BUG… (authored by jgrulich).
Openconnect: give context to the login button for correct translation BUG…
May 23 2019, 8:53 AM

May 20 2019

jgrulich accepted D21307: Optimise the NetworkModel.

Looks good.

May 20 2019, 6:03 PM · Plasma
jgrulich accepted D21296: Add the option to configure the realm.

Looks good.

May 20 2019, 6:39 AM · Plasma
jgrulich updated the diff for D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Remove [ru] and [x-test] translations from desktop and json files

May 20 2019, 6:10 AM

May 17 2019

jgrulich committed R838:33e0afa635e6: Add a TODO list (authored by jgrulich).
Add a TODO list
May 17 2019, 8:06 AM
jgrulich committed R838:2e03c8504018: Handle 'use_associated_app' option (authored by jgrulich).
Handle 'use_associated_app' option
May 17 2019, 7:26 AM

May 16 2019

jgrulich committed R116:7a7d1b731eb2: Fortissl VPN: fix crash when obtaining properties in the auth dialog (authored by jgrulich).
Fortissl VPN: fix crash when obtaining properties in the auth dialog
May 16 2019, 1:55 PM
jgrulich committed R838:73f22438122a: Merge branch 'Plasma/5.15' (authored by jgrulich).
Merge branch 'Plasma/5.15'
May 16 2019, 11:06 AM
jgrulich committed R838:83773f668215: AppChooser: put list of applications into a scrollarea (authored by jgrulich).
AppChooser: put list of applications into a scrollarea
May 16 2019, 11:05 AM

May 15 2019

jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Oh, only now noticed this patch. Should I take directly a look at it or is there some more work to do at the moment?

May 15 2019, 5:10 AM

May 14 2019

jgrulich committed R116:f585fde4298e: Make tests to build (authored by jgrulich).
Make tests to build
May 14 2019, 1:15 PM
jgrulich committed R116:0feb3062a90f: Add WireGuard at the end of the list of VPNs to make it correctly sorted (authored by jgrulich).
Add WireGuard at the end of the list of VPNs to make it correctly sorted
May 14 2019, 1:06 PM
jgrulich committed R116:557c415977ad: Add default value for parent in contructors of all validator classes (authored by jgrulich).
Add default value for parent in contructors of all validator classes
May 14 2019, 12:24 PM
jgrulich committed R116:751f4da01b42: Update WireGuard to match NetworkManager 1.16 interface (authored by jgrulich).
Update WireGuard to match NetworkManager 1.16 interface
May 14 2019, 8:47 AM
jgrulich closed D20930: Update WireGuard to match NetworkManager 1.16 interface.
May 14 2019, 8:47 AM · Plasma

May 13 2019

jgrulich accepted D20930: Update WireGuard to match NetworkManager 1.16 interface.

Good work!!

May 13 2019, 9:12 AM · Plasma
jgrulich added a comment to D20930: Update WireGuard to match NetworkManager 1.16 interface.

I think it doesn't matter in this case, you can just change it in your code, you don't need to have that change in your local copy, if this is merged than it's applied on top of that so it will be ok.

May 13 2019, 7:17 AM · Plasma
jgrulich added a comment to D20930: Update WireGuard to match NetworkManager 1.16 interface.

Updated SecretAgent class to always try to get the secrets from kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 random characters long and we don't expect the user to enter these manually when trying to make a connection. If data is not available in kwallet then trying to make a connection will fail. Also updated the configuration screens to not allow a configuration with "AlwaysAsk" flags on either key.

You can disable "AlwaysAsk" option with PasswordField::setPasswordNotRequiredEnabled(false).

Sorry, that's not it, I added a new option to do that, you can now use PasswordField::setPasswordNotSavedEnabled(false).

Great! Should I make the change in this review? If so, what is the correct procedure (with git, arc, ...) to merge that change into this review?

May 13 2019, 6:47 AM · Plasma
jgrulich added a comment to D20930: Update WireGuard to match NetworkManager 1.16 interface.

Updated SecretAgent class to always try to get the secrets from kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 random characters long and we don't expect the user to enter these manually when trying to make a connection. If data is not available in kwallet then trying to make a connection will fail. Also updated the configuration screens to not allow a configuration with "AlwaysAsk" flags on either key.

You can disable "AlwaysAsk" option with PasswordField::setPasswordNotRequiredEnabled(false).

May 13 2019, 6:21 AM · Plasma
jgrulich committed R116:5986ffbb1584: PasswordField: add option to hide AlwaysAsk mode (authored by jgrulich).
PasswordField: add option to hide AlwaysAsk mode
May 13 2019, 6:21 AM
jgrulich added inline comments to D20930: Update WireGuard to match NetworkManager 1.16 interface.
May 13 2019, 6:05 AM · Plasma
jgrulich added a comment to D20930: Update WireGuard to match NetworkManager 1.16 interface.

Updated SecretAgent class to always try to get the secrets from kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 random characters long and we don't expect the user to enter these manually when trying to make a connection. If data is not available in kwallet then trying to make a connection will fail. Also updated the configuration screens to not allow a configuration with "AlwaysAsk" flags on either key.

May 13 2019, 5:57 AM · Plasma
jgrulich closed D21111: Added new option to use GlobalProtect with openconnect.
May 13 2019, 5:17 AM · Plasma
jgrulich committed R116:dfbcf8b18a4b: Added new option to use GlobalProtect with openconnect (authored by avaldes).
Added new option to use GlobalProtect with openconnect
May 13 2019, 5:17 AM

May 12 2019

jgrulich added inline comments to D20930: Update WireGuard to match NetworkManager 1.16 interface.
May 12 2019, 2:43 PM · Plasma
jgrulich accepted D21111: Added new option to use GlobalProtect with openconnect.
May 12 2019, 9:33 AM · Plasma

May 10 2019

jgrulich added inline comments to D20930: Update WireGuard to match NetworkManager 1.16 interface.
May 10 2019, 12:19 PM · Plasma
jgrulich added inline comments to D21111: Added new option to use GlobalProtect with openconnect.
May 10 2019, 8:51 AM · Plasma
jgrulich added a comment to D21111: Added new option to use GlobalProtect with openconnect.

networkmanager-openconnect has added support in master for global protect, so now we can use it from plasma.

This was tested in my machine with Plasma 5.15.5 and the lastest networkmanager-openconnect.

The VPN works but I'm having an issue with the existing configuration options:

Unselecting the option "Use only for resources on this connection" in IPv4 > Routes doesn't work, I can access the network resources only available at the VPN but all my internet connections goes to the default internet route. I was able to solve this temporally by modifying the kernel routes. Is this intended?

May 10 2019, 8:42 AM · Plasma
jgrulich accepted D21104: Port widget settings window to QQC2+Kirigami FormLayout.
May 10 2019, 5:54 AM · Plasma
jgrulich accepted D21102: Mark "Connection Activated" notifications as low priority.
May 10 2019, 5:53 AM · Plasma

May 8 2019

jgrulich committed R282:0f8c7010562b: Add WireGuard device support to manager (authored by jgrulich).
Add WireGuard device support to manager
May 8 2019, 5:52 AM

May 7 2019

jgrulich committed R282:d246f367126d: Add WireGuard device (authored by jgrulich).
Add WireGuard device
May 7 2019, 2:16 PM
jgrulich committed R282:fbf135c2f136: WireGuard: Do not require 'private-key' to be non-empty for 'private-key-flags' (authored by jgrulich).
WireGuard: Do not require 'private-key' to be non-empty for 'private-key-flags'
May 7 2019, 11:09 AM

May 6 2019

jgrulich added a comment to D20833: Simpler check for flatpak.

Lookgs good to me, I'll wait for Kai to approve this since he is the maintainer. One thing to consider maybe, did /.flatpak-info always exist or is it something new? I always assumed there is just one flatpak-info file in $XDG_RUNTIME_DIR. Just to be sure it will work for older Flatpak versions.

May 6 2019, 7:01 PM · Frameworks
jgrulich committed R116:8fb5c6192c15: Add OTP support for openconnect VPN (authored by jgrulich).
Add OTP support for openconnect VPN
May 6 2019, 9:37 AM
jgrulich closed D18394: Add OTP support for openconnect VPN.
May 6 2019, 9:37 AM · Plasma

May 2 2019

jgrulich updated subscribers of D20930: Update WireGuard to match NetworkManager 1.16 interface.

Can we maybe have some assistence from anyone from VDG? @ngraham maybe?

May 2 2019, 1:19 PM · Plasma
jgrulich accepted D18394: Add OTP support for openconnect VPN.

Just fix those minor issues, otherwise it looks good to me, I'll verify on Monday, but I believe it's safe to push this.

May 2 2019, 9:35 AM · Plasma

Apr 30 2019

jgrulich committed R116:8355649e6abf: Merge branch 'Plasma/5.15' (authored by jgrulich).
Merge branch 'Plasma/5.15'
Apr 30 2019, 3:01 PM
jgrulich accepted D20900: Reject invalid keys.
Apr 30 2019, 12:11 PM · Plasma
jgrulich added a comment to D18394: Add OTP support for openconnect VPN.

Sorry for the delay, I promise that I will start reviewing this more frequently so it gets merged just in time for Plasma 5.16 (we have 2 weeks).

Apr 30 2019, 12:02 PM · Plasma
jgrulich added inline comments to D20900: Reject invalid keys.
Apr 30 2019, 10:59 AM · Plasma