jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (248 w, 2 d)
Availability
Available

Recent Activity

Thu, May 14

jgrulich committed R838:d66be2276329: Background portal: do not notify about apps in background when we don't track… (authored by jgrulich).
Background portal: do not notify about apps in background when we don't track…
Thu, May 14, 2:07 PM
jgrulich committed R838:0392647e0085: Background portal: correctly send respond whether we allow application in the… (authored by jgrulich).
Background portal: correctly send respond whether we allow application in the…
Thu, May 14, 2:07 PM
jgrulich accepted D29716: [applet] Show KCM in System Settings.
Thu, May 14, 5:04 AM · Plasma

Wed, May 13

jgrulich accepted D29701: Disable horizontal scrollbar in kcm.

I would say push it also to master.

Wed, May 13, 11:17 AM · Plasma

Wed, May 6

jgrulich committed R116:da52d01788f5: Icon in system tray missing when WireGuard connection active on startup (authored by andersonbruce).
Icon in system tray missing when WireGuard connection active on startup
Wed, May 6, 6:05 AM
jgrulich committed R116:040a5c8ce9b0: Icon in system tray missing when WireGuard connection active on startup (authored by andersonbruce).
Icon in system tray missing when WireGuard connection active on startup
Wed, May 6, 6:04 AM
jgrulich closed D29469: Icon in system tray missing when WireGuard connection active on startup.
Wed, May 6, 6:04 AM · Plasma
jgrulich accepted D29469: Icon in system tray missing when WireGuard connection active on startup.
Wed, May 6, 5:59 AM · Plasma

Sat, May 2

jgrulich committed R116:5d8b3d8e600b: Implement connection saving (authored by jgrulich).
Implement connection saving
Sat, May 2, 10:35 AM
jgrulich committed R116:01ca88c3d0b0: port to the new multilevel KCM api (authored by mart).
port to the new multilevel KCM api
Sat, May 2, 10:35 AM
jgrulich committed R116:9e5b8462efb5: Connection settings: Add metered property (authored by jgrulich).
Connection settings: Add metered property
Sat, May 2, 10:35 AM
jgrulich committed R116:67e5d3635f4e: Add accidentaly removed mobilyproxymodel (authored by jgrulich).
Add accidentaly removed mobilyproxymodel
Sat, May 2, 10:34 AM
jgrulich committed R116:8c6619bb254e: Remove wrongly used anchors (authored by jgrulich).
Remove wrongly used anchors
Sat, May 2, 10:34 AM
jgrulich committed R116:93626b0151f9: make the layout work (authored by mart).
make the layout work
Sat, May 2, 10:34 AM
jgrulich committed R116:ea7f02188e8a: Add missing includes and frameworks (authored by jgrulich).
Add missing includes and frameworks
Sat, May 2, 10:34 AM
jgrulich committed R116:83a63004d8eb: WIP: Add simple/expert mode option (authored by jgrulich).
WIP: Add simple/expert mode option
Sat, May 2, 10:34 AM
jgrulich committed R116:41c49f426875: Remove unused stuff (authored by jgrulich).
Remove unused stuff
Sat, May 2, 10:34 AM
jgrulich committed R116:54d303a3b00e: Attempt to use multipage KCM feature (authored by jgrulich).
Attempt to use multipage KCM feature
Sat, May 2, 10:34 AM
jgrulich committed R116:d5df98a3c03e: Fix search header and make connections properly clickable (authored by jgrulich).
Fix search header and make connections properly clickable
Sat, May 2, 10:34 AM
jgrulich committed R116:7b53424f4a23: Add missing files from previous commit++ (authored by jgrulich).
Add missing files from previous commit++
Sat, May 2, 10:34 AM
jgrulich committed R116:5064f3dbe2cf: Add common wireless configuration (authored by jgrulich).
Add common wireless configuration
Sat, May 2, 10:34 AM
jgrulich committed R116:ecd3a1c7d008: Add missing files from previous commit (authored by jgrulich).
Add missing files from previous commit
Sat, May 2, 10:34 AM
jgrulich committed R116:be8cccecd3d9: Use PageRow for navigating between connection view and editor (authored by jgrulich).
Use PageRow for navigating between connection view and editor
Sat, May 2, 10:34 AM
jgrulich committed R116:9191c41f32be: Load rest of connection setting (authored by jgrulich).
Load rest of connection setting
Sat, May 2, 10:34 AM
jgrulich committed R116:119352b41b94: Use Q_INVOKABLE instead of public slots (authored by jgrulich).
Use Q_INVOKABLE instead of public slots
Sat, May 2, 10:34 AM
jgrulich committed R116:f04032e47c7c: WIP: Start rewriting KCM fully to QML (authored by jgrulich).
WIP: Start rewriting KCM fully to QML
Sat, May 2, 10:34 AM

Fri, May 1

jgrulich added a comment to T12675: File picker.
  1. I don't mind having it directly in xdg-desktop-portal-kde, but if it's something that might be re-used, it might be better to put it into some framework.

2-3) Kirigami-addons will be probably my preference. It sounds like something that can be re-used so why not write it that way. Then in xdg-desktop-portal-kde we will just check if it's running on mobile and create a dialog based on that.

  1. This might complicate it a bit, because you either would need to implement all the other portals which are same for both the desktop and mobile, or you would need to set different value to XDG_CURRENT_DESKTOP so xdg-desktop-portal first loads your portal implementation for some portals and then xdg-desktop-portal-kde as fallback for the rest.
Fri, May 1, 12:56 PM · Plasma: Mobile (PM 1.0)

Tue, Apr 28

jgrulich committed R838:976d0c5fade9: FileChooser portal: add support for opening directories (authored by jgrulich).
FileChooser portal: add support for opening directories
Tue, Apr 28, 11:29 AM
jgrulich closed D29071: FileChooser portal: add support for opening directories.
Tue, Apr 28, 11:29 AM · Plasma

Apr 23 2020

jgrulich added a comment to D28882: Create protocol to manage video feeds.

I have tested this and it now works as before, tested with Chromium, while checking all the values we pass to the portal and PipeWire which seem to be correct.

Apr 23 2020, 3:07 PM · Frameworks
jgrulich added a comment to D29015: Move screencasting to KWin.

I have tested this and it now works as before, tested with Chromium, while checking all the values we pass to the portal and PipeWire which seem to be correct.

Apr 23 2020, 3:07 PM · KWin
jgrulich accepted D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol.

Looks good and it works for me, tested with Chromium.

Apr 23 2020, 3:05 PM · Plasma
jgrulich accepted D29121: Replace foreach with range-for.
Apr 23 2020, 9:03 AM · Frameworks
jgrulich added inline comments to D29015: Move screencasting to KWin.
Apr 23 2020, 7:56 AM · KWin
jgrulich accepted D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass.
Apr 23 2020, 6:32 AM · Frameworks
jgrulich accepted D29091: [NetworkManager-qt] Replace foreach with range/index for loop, third pass.
Apr 23 2020, 6:29 AM · Frameworks
jgrulich accepted D29117: [applet] Put the toolbar in the header area.
Apr 23 2020, 5:57 AM · Plasma

Apr 22 2020

jgrulich accepted D29086: [NetworkManager-qt] Replace foreach with range/index for loop.
Apr 22 2020, 10:06 AM · Frameworks
jgrulich accepted D29086: [NetworkManager-qt] Replace foreach with range/index for loop.
Apr 22 2020, 10:00 AM · Frameworks
jgrulich updated the summary of D29071: FileChooser portal: add support for opening directories.
Apr 22 2020, 5:50 AM · Plasma

Apr 21 2020

jgrulich added reviewers for D29071: FileChooser portal: add support for opening directories: apol, Plasma.
Apr 21 2020, 8:13 PM · Plasma
jgrulich requested review of D29071: FileChooser portal: add support for opening directories.
Apr 21 2020, 8:11 PM · Plasma
jgrulich accepted D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass.
Apr 21 2020, 7:54 PM · Frameworks
jgrulich added inline comments to D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol.
Apr 21 2020, 12:18 PM · Plasma
jgrulich added a comment to D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol.

With all code relevant to PipeWire removed, you can remove all needed CMake find modules in cmake subdir and you can also remove the ENABLE_PIPEWIRE option as it shouldn't be needed anymore (including all ifdefs).

Apr 21 2020, 11:10 AM · Plasma
jgrulich added a comment to D28882: Create protocol to manage video feeds.

Doesn't seem to build here:

In file included from /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:121: error: ‘std::function’ has not been declared
   32 |     ScreencastingSource(const QString &description, const QString &iconName, bool isOutput, const QRect &geometry, std::function<void(const ScreencastingSource &, wl_resource *)>);
      |                                                                                                                         ^~~~~~~~
In file included from /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:129: error: expected ‘,’ or ‘...’ before ‘<’ token
   32 |     ScreencastingSource(const QString &description, const QString &iconName, bool isOutput, const QRect &geometry, std::function<void(const ScreencastingSource &, wl_resource *)>);
      |                                                                                                                                 ^
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:41:1: error: no declaration matches ‘KWayland::Server::ScreencastingSource::ScreencastingSource(const QString&, const QString&, bool, const QRect&, std::function<void(const KWayland::Server::ScreencastingSource&, wl_resource*)>)’
   41 | ScreencastingSource::ScreencastingSource(const QString &description, const QString &iconName, bool isOutput, const QRect &geometry, std::function<void(const ScreencastingSource &,wl_resource *r)> call)
      | ^~~~~~~~~~~~~~~~~~~
Apr 21 2020, 11:06 AM · Frameworks
jgrulich added a comment to D28882: Create protocol to manage video feeds.

Doesn't seem to build here:

Apr 21 2020, 11:04 AM · Frameworks

Apr 20 2020

jgrulich accepted D29019: Create a hotspot KCM for Plasma Mobile.
Apr 20 2020, 7:53 PM · Plasma
jgrulich added a comment to D29015: Move screencasting to KWin.

I think we can drop support for PipeWire 0.2 (you don't seem to search for it anyway) so you can drop all PW_CHECK_VERSION(0, 2, 90) and keep just the branch for PipeWire 0.3. I will do some proper testing tomorrow.

Apr 20 2020, 4:53 PM · KWin

Apr 17 2020

jgrulich added inline comments to D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol.
Apr 17 2020, 8:30 AM · Plasma
jgrulich added inline comments to D28882: Create protocol to manage video feeds.
Apr 17 2020, 8:30 AM · Frameworks

Apr 16 2020

jgrulich accepted D28881: [Applet] Fix connecting with a password.
Apr 16 2020, 2:02 PM · Plasma
jgrulich committed R838:d1f0ec4d3a4c: Screensharing: support variable stride (authored by jgrulich).
Screensharing: support variable stride
Apr 16 2020, 1:16 PM
jgrulich closed D28875: Screensharing: support variable stride.
Apr 16 2020, 1:16 PM · Plasma
jgrulich added reviewers for D28875: Screensharing: support variable stride: Plasma, cblack.
Apr 16 2020, 7:42 AM · Plasma
jgrulich requested review of D28875: Screensharing: support variable stride.
Apr 16 2020, 7:38 AM · Plasma

Apr 14 2020

jgrulich accepted D28838: Show SSID as title in mobile wifi connection editor.
Apr 14 2020, 7:28 PM · Plasma
jgrulich committed R257:1b8458eb825a: Skip icon check on the runtime (authored by jgrulich).
Skip icon check on the runtime
Apr 14 2020, 12:43 PM
jgrulich committed R257:ab524bad534b: Skip icon check on the runtime (authored by jgrulich).
Skip icon check on the runtime
Apr 14 2020, 12:41 PM
jgrulich accepted D28799: Refactor and fix the mobile wifi kcm.

I wanted to let @ngraham to review this UI wise, but I see there are no UI changes. I don't follow mobile KCM development so I'm not sure I'm the right person to review this, but it looks good to me. I haven't tried it, but I believe you.

Apr 14 2020, 11:44 AM · Plasma
Restricted Application added a reviewer for D28799: Refactor and fix the mobile wifi kcm: jgrulich.
Apr 14 2020, 11:32 AM · Plasma
Restricted Application added a reviewer for D28799: Refactor and fix the mobile wifi kcm: jgrulich.
Apr 14 2020, 11:32 AM · Plasma
jgrulich accepted D28034: [Applet] Port to ExpandableListItem.

Those were probably all issues I could find. I will keep using it and if I find something later, I will let you know. Thank you.

Apr 14 2020, 11:31 AM · Plasma
jgrulich accepted D28714: Refactor enableBluetooth function.
Apr 14 2020, 11:30 AM · Plasma
jgrulich committed R257:6c23e907c46a: Build with CUPS support (authored by jgrulich).
Build with CUPS support
Apr 14 2020, 6:56 AM
jgrulich committed R257:f30f988ccd50: Build with CUPS support (authored by jgrulich).
Build with CUPS support
Apr 14 2020, 6:53 AM

Apr 13 2020

jgrulich committed R838:b8af0f136865: Make PipeWire, GBM and Epoxy libs as required dependencies (authored by jgrulich).
Make PipeWire, GBM and Epoxy libs as required dependencies
Apr 13 2020, 12:36 PM
jgrulich closed D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.
Apr 13 2020, 12:36 PM · Plasma
jgrulich updated the diff for D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.
  • Better naming for the cmake option disabling PipeWire
Apr 13 2020, 12:35 PM · Plasma

Apr 12 2020

jgrulich added inline comments to D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.
Apr 12 2020, 6:17 PM · Plasma
jgrulich updated the diff for D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.

Make DISABLE_PIPEWIRE_SUPPORT a cmake option and remove a leftover from previous change

Apr 12 2020, 6:16 PM · Plasma

Apr 10 2020

jgrulich accepted D28713: Return buffer to pipewire when returning early from recordFrame.
Apr 10 2020, 5:31 AM · Plasma

Apr 9 2020

jgrulich accepted D28698: Save unneeded DBus roundtrip.

(the ugly notification which pops on the top of screen) when Plasma notifications are not ready yet

Plasma ships a trick for that which means that we always get plasma notifications when plasma is installed regardless of if it's running.

Apr 9 2020, 9:32 AM · Plasma
jgrulich added a comment to D28698: Save unneeded DBus roundtrip.

I see that we already initialize the secret agent right when the kded module is loaded, but I see a potential problem in showing a notification using a fallback backend (the ugly notification which pops on the top of screen) when Plasma notifications are not ready yet.

Apr 9 2020, 9:16 AM · Plasma
jgrulich added a comment to D28698: Save unneeded DBus roundtrip.

Actually it was me who pushed this, Lukáš just did some changes to it.

Apr 9 2020, 9:10 AM · Plasma
jgrulich added a comment to D28698: Save unneeded DBus roundtrip.

Yes, but I don't see this being a problem

Apr 9 2020, 9:09 AM · Plasma
jgrulich added a comment to D28698: Save unneeded DBus roundtrip.

Isn't that Handler also used from the plasmoid and KCM, which is in a separate process from kded?

Apr 9 2020, 9:01 AM · Plasma
jgrulich updated the summary of D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.
Apr 9 2020, 8:34 AM · Plasma
jgrulich accepted D28696: Use std::any_of.
Apr 9 2020, 8:26 AM · Plasma
jgrulich added a comment to D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.

Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet.

I don't follow, why don't we just disable the screencasting thing if we don't have pipewire. I don't see why we would affect the rest.

Apr 9 2020, 7:25 AM · Plasma
jgrulich updated the diff for D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.

Allow to disable only PipeWire, while keeping rest of Wayland support

Apr 9 2020, 7:23 AM · Plasma
jgrulich accepted D28693: Replace old notification when new notification for connection appears.
Apr 9 2020, 6:27 AM · Plasma
jgrulich accepted D28691: [kded] Clean up notification handling.
Apr 9 2020, 5:37 AM · Plasma

Apr 8 2020

jgrulich added a comment to D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.

I asked on kde-distribution-packagers, so far I got only response from Slack and the response was they don't care about Wayland, if they would, they would have included PipeWire. I think it should be either don't support Wayland at all if distribution doesn't care or support it fully and let them get PipeWire included.

Apr 8 2020, 10:19 AM · Plasma
jgrulich added a comment to D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.

Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet.

I don't follow, why don't we just disable the screencasting thing if we don't have pipewire. I don't see why we would affect the rest.

Apr 8 2020, 10:15 AM · Plasma
jgrulich added a reviewer for D28677: Make PipeWire, GBM and Epoxy libs as required dependencies: Plasma.
Apr 8 2020, 10:08 AM · Plasma
jgrulich requested review of D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.
Apr 8 2020, 10:08 AM · Plasma
jgrulich added a comment to D28517: Send notification when screencasting fails.

Looks good to me. @broulik what do you think?

Apr 8 2020, 9:49 AM · Plasma

Apr 7 2020

jgrulich added a comment to D28214: Add background portal.
Apr 7 2020, 12:13 PM · Plasma
jgrulich added inline comments to D28214: Add background portal.
Apr 7 2020, 12:12 PM · Plasma
jgrulich committed R838:0cefb5e18db4: Add background portal (authored by jgrulich).
Add background portal
Apr 7 2020, 5:09 AM
jgrulich closed D28214: Add background portal.
Apr 7 2020, 5:09 AM · Plasma

Apr 6 2020

jgrulich added a comment to D28034: [Applet] Port to ExpandableListItem.

Yeah, the PC3 busy indicator component itself seems to be to blame for items 1 and 3. I'll look into it.

I hadn't really considered #2 as a valid use case while working on the component, but I can look into it.

Apr 6 2020, 7:34 PM · Plasma
jgrulich added a comment to D28034: [Applet] Port to ExpandableListItem.

Both issues fixed, however I found two news:

  1. Getting file:///usr/lib64/qt5/qml/org/kde/plasma/extras/ExpandableListItem.qml:438:13: QML BusyIndicator: Binding loop detected for property "implicitHeight" spammed in terminal from plasmashell process, but this is not related to this review.
  2. You are not able to disconnect a connection which is being activated, for example when you accidentally click on one to connect and want to stop it, I don't know if it's super important, but it was there and I'm using it from time to time (wanted to use it right now).
  3. I'm thinking of not using the busy indicator, it makes the UI to lag and I have been experiencing it recently and it's super annoying, I don't know it's the rendering process or what, but everytime I activate a connection, the UI is super slow until it connects. Might be combination of the busy indicator and something in the background, but not using the busy indicator made it significantly less laggy. Do you experince it as well?
Apr 6 2020, 7:16 PM · Plasma
jgrulich added inline comments to D28214: Add background portal.
Apr 6 2020, 6:25 PM · Plasma
jgrulich updated the diff for D28214: Add background portal.

Update to fix review comments

Apr 6 2020, 6:24 PM · Plasma
jgrulich committed R838:b8f317599fa9: Merge branch 'Plasma/5.18' (authored by jgrulich).
Merge branch 'Plasma/5.18'
Apr 6 2020, 6:10 PM
jgrulich committed R838:556f26ac2db5: ScreenSharing: close dialogs when session is closed (authored by jgrulich).
ScreenSharing: close dialogs when session is closed
Apr 6 2020, 6:09 PM
jgrulich committed R838:a1128f123e3b: ScreenSharing: close dialogs when session is closed (authored by jgrulich).
ScreenSharing: close dialogs when session is closed
Apr 6 2020, 11:20 AM
jgrulich closed D28618: ScreenSharing: close dialogs when session is closed.
Apr 6 2020, 11:20 AM · Plasma