jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (195 w, 6 d)
Availability
Available

Recent Activity

Today

jgrulich committed R116:179cd8baea41: Add the option to configure the realm (authored by jgrulich).
Add the option to configure the realm
Mon, May 27, 5:41 AM
jgrulich closed D21296: Add the option to configure the realm.
Mon, May 27, 5:41 AM · Plasma

Fri, May 24

jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

\o/

For promo purposes, how can I use this or see it in action? What apps are necessary?

Fri, May 24, 6:44 PM
jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

The only issue left is clipboard sharing. I'm certain it's triggered in some weird way and sends stray packets when VNC Server expects password. I've definitely seen network activity when the password field is selected/filled on Wayland.
Something I didn't see on X. Other than that, I'm mostly satisfied with the result.

Fri, May 24, 11:55 AM
jgrulich committed R437:c05707884c17: Implement Wayland support using PipeWire and xdg-desktop-portal (authored by jgrulich).
Implement Wayland support using PipeWire and xdg-desktop-portal
Fri, May 24, 11:51 AM
jgrulich closed D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.
Fri, May 24, 11:51 AM

Thu, May 23

jgrulich committed R838:ef64182a5369: Merge branch 'Plasma/5.16' (authored by jgrulich).
Merge branch 'Plasma/5.16'
Thu, May 23, 11:45 AM
jgrulich committed R838:40f611855e0b: Fix potential build failure (authored by jgrulich).
Fix potential build failure
Thu, May 23, 11:45 AM
jgrulich committed R838:170c27431d1d: Merge branch 'Plasma/5.16' (authored by jgrulich).
Merge branch 'Plasma/5.16'
Thu, May 23, 9:44 AM
jgrulich committed R838:4d1df4e2d0c1: Allow some portals to run only on Plasma sessions (authored by jgrulich).
Allow some portals to run only on Plasma sessions
Thu, May 23, 9:41 AM
jgrulich committed R116:2a56782e15d7: Openconnect: give context to the login button for correct translation BUG… (authored by jgrulich).
Openconnect: give context to the login button for correct translation BUG…
Thu, May 23, 8:53 AM

Mon, May 20

jgrulich accepted D21307: Optimise the NetworkModel.

Looks good.

Mon, May 20, 6:03 PM · Plasma
jgrulich accepted D21296: Add the option to configure the realm.

Looks good.

Mon, May 20, 6:39 AM · Plasma
jgrulich updated the diff for D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Remove [ru] and [x-test] translations from desktop and json files

Mon, May 20, 6:10 AM

Fri, May 17

jgrulich committed R838:33e0afa635e6: Add a TODO list (authored by jgrulich).
Add a TODO list
Fri, May 17, 8:06 AM
jgrulich committed R838:2e03c8504018: Handle 'use_associated_app' option (authored by jgrulich).
Handle 'use_associated_app' option
Fri, May 17, 7:26 AM

Thu, May 16

jgrulich committed R116:7a7d1b731eb2: Fortissl VPN: fix crash when obtaining properties in the auth dialog (authored by jgrulich).
Fortissl VPN: fix crash when obtaining properties in the auth dialog
Thu, May 16, 1:55 PM
jgrulich committed R838:73f22438122a: Merge branch 'Plasma/5.15' (authored by jgrulich).
Merge branch 'Plasma/5.15'
Thu, May 16, 11:06 AM
jgrulich committed R838:83773f668215: AppChooser: put list of applications into a scrollarea (authored by jgrulich).
AppChooser: put list of applications into a scrollarea
Thu, May 16, 11:05 AM

Wed, May 15

jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Oh, only now noticed this patch. Should I take directly a look at it or is there some more work to do at the moment?

Wed, May 15, 5:10 AM

Tue, May 14

jgrulich committed R116:f585fde4298e: Make tests to build (authored by jgrulich).
Make tests to build
Tue, May 14, 1:15 PM
jgrulich committed R116:0feb3062a90f: Add WireGuard at the end of the list of VPNs to make it correctly sorted (authored by jgrulich).
Add WireGuard at the end of the list of VPNs to make it correctly sorted
Tue, May 14, 1:06 PM
jgrulich committed R116:557c415977ad: Add default value for parent in contructors of all validator classes (authored by jgrulich).
Add default value for parent in contructors of all validator classes
Tue, May 14, 12:24 PM
jgrulich committed R116:751f4da01b42: Update WireGuard to match NetworkManager 1.16 interface (authored by jgrulich).
Update WireGuard to match NetworkManager 1.16 interface
Tue, May 14, 8:47 AM
jgrulich closed D20930: Update WireGuard to match NetworkManager 1.16 interface.
Tue, May 14, 8:47 AM · Plasma

Mon, May 13

jgrulich accepted D20930: Update WireGuard to match NetworkManager 1.16 interface.

Good work!!

Mon, May 13, 9:12 AM · Plasma
jgrulich added a comment to D20930: Update WireGuard to match NetworkManager 1.16 interface.

I think it doesn't matter in this case, you can just change it in your code, you don't need to have that change in your local copy, if this is merged than it's applied on top of that so it will be ok.

Mon, May 13, 7:17 AM · Plasma
jgrulich added a comment to D20930: Update WireGuard to match NetworkManager 1.16 interface.

Updated SecretAgent class to always try to get the secrets from kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 random characters long and we don't expect the user to enter these manually when trying to make a connection. If data is not available in kwallet then trying to make a connection will fail. Also updated the configuration screens to not allow a configuration with "AlwaysAsk" flags on either key.

You can disable "AlwaysAsk" option with PasswordField::setPasswordNotRequiredEnabled(false).

Sorry, that's not it, I added a new option to do that, you can now use PasswordField::setPasswordNotSavedEnabled(false).

Great! Should I make the change in this review? If so, what is the correct procedure (with git, arc, ...) to merge that change into this review?

Mon, May 13, 6:47 AM · Plasma
jgrulich added a comment to D20930: Update WireGuard to match NetworkManager 1.16 interface.

Updated SecretAgent class to always try to get the secrets from kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 random characters long and we don't expect the user to enter these manually when trying to make a connection. If data is not available in kwallet then trying to make a connection will fail. Also updated the configuration screens to not allow a configuration with "AlwaysAsk" flags on either key.

You can disable "AlwaysAsk" option with PasswordField::setPasswordNotRequiredEnabled(false).

Mon, May 13, 6:21 AM · Plasma
jgrulich committed R116:5986ffbb1584: PasswordField: add option to hide AlwaysAsk mode (authored by jgrulich).
PasswordField: add option to hide AlwaysAsk mode
Mon, May 13, 6:21 AM
jgrulich added inline comments to D20930: Update WireGuard to match NetworkManager 1.16 interface.
Mon, May 13, 6:05 AM · Plasma
jgrulich added a comment to D20930: Update WireGuard to match NetworkManager 1.16 interface.

Updated SecretAgent class to always try to get the secrets from kwallet even if the 'allow-interaction' flag is set. The keys WireGuard uses are 43 random characters long and we don't expect the user to enter these manually when trying to make a connection. If data is not available in kwallet then trying to make a connection will fail. Also updated the configuration screens to not allow a configuration with "AlwaysAsk" flags on either key.

Mon, May 13, 5:57 AM · Plasma
jgrulich closed D21111: Added new option to use GlobalProtect with openconnect.
Mon, May 13, 5:17 AM · Plasma
jgrulich committed R116:dfbcf8b18a4b: Added new option to use GlobalProtect with openconnect (authored by avaldes).
Added new option to use GlobalProtect with openconnect
Mon, May 13, 5:17 AM

Sun, May 12

jgrulich added inline comments to D20930: Update WireGuard to match NetworkManager 1.16 interface.
Sun, May 12, 2:43 PM · Plasma
jgrulich accepted D21111: Added new option to use GlobalProtect with openconnect.
Sun, May 12, 9:33 AM · Plasma

Fri, May 10

jgrulich added inline comments to D20930: Update WireGuard to match NetworkManager 1.16 interface.
Fri, May 10, 12:19 PM · Plasma
jgrulich added inline comments to D21111: Added new option to use GlobalProtect with openconnect.
Fri, May 10, 8:51 AM · Plasma
jgrulich added a comment to D21111: Added new option to use GlobalProtect with openconnect.

networkmanager-openconnect has added support in master for global protect, so now we can use it from plasma.

This was tested in my machine with Plasma 5.15.5 and the lastest networkmanager-openconnect.

The VPN works but I'm having an issue with the existing configuration options:

Unselecting the option "Use only for resources on this connection" in IPv4 > Routes doesn't work, I can access the network resources only available at the VPN but all my internet connections goes to the default internet route. I was able to solve this temporally by modifying the kernel routes. Is this intended?

Fri, May 10, 8:42 AM · Plasma
jgrulich accepted D21104: Port widget settings window to QQC2+Kirigami FormLayout.
Fri, May 10, 5:54 AM · Plasma
jgrulich accepted D21102: Mark "Connection Activated" notifications as low priority.
Fri, May 10, 5:53 AM · Plasma

Wed, May 8

jgrulich committed R282:0f8c7010562b: Add WireGuard device support to manager (authored by jgrulich).
Add WireGuard device support to manager
Wed, May 8, 5:52 AM

Tue, May 7

jgrulich committed R282:d246f367126d: Add WireGuard device (authored by jgrulich).
Add WireGuard device
Tue, May 7, 2:16 PM
jgrulich committed R282:fbf135c2f136: WireGuard: Do not require 'private-key' to be non-empty for 'private-key-flags' (authored by jgrulich).
WireGuard: Do not require 'private-key' to be non-empty for 'private-key-flags'
Tue, May 7, 11:09 AM

Mon, May 6

jgrulich added a comment to D20833: Simpler check for flatpak.

Lookgs good to me, I'll wait for Kai to approve this since he is the maintainer. One thing to consider maybe, did /.flatpak-info always exist or is it something new? I always assumed there is just one flatpak-info file in $XDG_RUNTIME_DIR. Just to be sure it will work for older Flatpak versions.

Mon, May 6, 7:01 PM · Frameworks
jgrulich committed R116:8fb5c6192c15: Add OTP support for openconnect VPN (authored by jgrulich).
Add OTP support for openconnect VPN
Mon, May 6, 9:37 AM
jgrulich closed D18394: Add OTP support for openconnect VPN.
Mon, May 6, 9:37 AM · Plasma

Thu, May 2

jgrulich updated subscribers of D20930: Update WireGuard to match NetworkManager 1.16 interface.

Can we maybe have some assistence from anyone from VDG? @ngraham maybe?

Thu, May 2, 1:19 PM · Plasma
jgrulich accepted D18394: Add OTP support for openconnect VPN.

Just fix those minor issues, otherwise it looks good to me, I'll verify on Monday, but I believe it's safe to push this.

Thu, May 2, 9:35 AM · Plasma

Tue, Apr 30

jgrulich committed R116:8355649e6abf: Merge branch 'Plasma/5.15' (authored by jgrulich).
Merge branch 'Plasma/5.15'
Tue, Apr 30, 3:01 PM
jgrulich accepted D20900: Reject invalid keys.
Tue, Apr 30, 12:11 PM · Plasma
jgrulich added a comment to D18394: Add OTP support for openconnect VPN.

Sorry for the delay, I promise that I will start reviewing this more frequently so it gets merged just in time for Plasma 5.16 (we have 2 weeks).

Tue, Apr 30, 12:02 PM · Plasma
jgrulich added inline comments to D20900: Reject invalid keys.
Tue, Apr 30, 10:59 AM · Plasma
jgrulich added inline comments to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.
Tue, Apr 30, 10:41 AM
jgrulich updated the diff for D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Make Krfb event handlers as plugins

Tue, Apr 30, 10:40 AM
jgrulich added inline comments to D20900: Reject invalid keys.
Tue, Apr 30, 9:14 AM · Plasma
jgrulich added a comment to D20900: Reject invalid keys.

Use NetworkManagerQt::Utils::wpaPskIsValid() and NetworkManagerQt::Utils:wepKeyIsValid(). It doesn't make sense to have only validation for WPA.

Tue, Apr 30, 8:39 AM · Plasma
jgrulich accepted D20788: Reset model when there are new available connections.
Tue, Apr 30, 6:34 AM · Plasma

Mon, Apr 29

jgrulich added a comment to D20900: Reject invalid keys.

Then the password dialog should use some sort of validation (we already use it for example in the editor and applet) and do not allow to accept a password which is likely not valid.

Mon, Apr 29, 2:56 PM · Plasma
jgrulich requested changes to D20788: Reset model when there are new available connections.

You said it's broken so I would preffer not landing a broken patch.

Mon, Apr 29, 2:54 PM · Plasma
jgrulich added a comment to D20788: Reset model when there are new available connections.

I think resetting the model might not be necessary, when addAvailableConnection() is called, it then updates item with a new available connection, which invalidates the filter anyway or at least it should.

Mon, Apr 29, 6:21 AM · Plasma
jgrulich committed R838:29609c3eb0a4: Destroy gbm_device only when it's initialized (authored by jgrulich).
Destroy gbm_device only when it's initialized
Mon, Apr 29, 6:11 AM

Apr 25 2019

jgrulich accepted D20788: Reset model when there are new available connections.
Apr 25 2019, 6:31 AM · Plasma

Apr 21 2019

jgrulich committed R838:b4403de26918: Merge branch 'Plasma/5.15' (authored by jgrulich).
Merge branch 'Plasma/5.15'
Apr 21 2019, 6:53 PM
jgrulich committed R838:045302b5292c: Settings portal: do not return QDBusVariant directly when calling Read() method (authored by jgrulich).
Settings portal: do not return QDBusVariant directly when calling Read() method
Apr 21 2019, 6:53 PM

Apr 18 2019

jgrulich accepted D20651: Support default action, priority hints, set desktop-entry.

Works for me. I tested both like the default action and urgency.

Apr 18 2019, 10:41 AM · Plasma
jgrulich accepted D20649: [Notify by Portal] Support default action and priority hints.

Works for me. I tested both like the default action and urgency.

Apr 18 2019, 10:40 AM · Frameworks

Apr 16 2019

jgrulich committed R838:122e4cde9c60: Merge branch 'Plasma/5.15' (authored by jgrulich).
Merge branch 'Plasma/5.15'
Apr 16 2019, 7:44 AM
jgrulich committed R838:42626859eabe: Remove additional call of items initialization (authored by jgrulich).
Remove additional call of items initialization
Apr 16 2019, 7:44 AM
jgrulich committed R838:73b2cd9327a9: AppChooser dialog: async loading of items (authored by jgrulich).
AppChooser dialog: async loading of items
Apr 16 2019, 7:44 AM

Apr 14 2019

jgrulich accepted D20522: Don't load the KSharedConfig instance on every read.
Apr 14 2019, 8:38 AM · Plasma

Apr 11 2019

jgrulich abandoned D20461: AppChooser dialog: async loading of items.

Doesn't seem to make any effect.

Apr 11 2019, 11:25 AM · Plasma
jgrulich updated the diff for D20461: AppChooser dialog: async loading of items.

Remove additional call of items initialization

Apr 11 2019, 8:47 AM · Plasma
jgrulich added a reviewer for D20461: AppChooser dialog: async loading of items: Plasma.
Apr 11 2019, 8:45 AM · Plasma
jgrulich requested review of D20461: AppChooser dialog: async loading of items.
Apr 11 2019, 8:45 AM · Plasma
jgrulich committed R282:464334886b20: WireGuard: workaround wrong secret flag type (authored by jgrulich).
WireGuard: workaround wrong secret flag type
Apr 11 2019, 6:23 AM
jgrulich committed R116:5014b50b719f: No need to set height to implicitHeight (authored by jgrulich).
No need to set height to implicitHeight
Apr 11 2019, 6:08 AM
jgrulich closed D20436: No need to set height to implicitHeight.
Apr 11 2019, 6:08 AM · Plasma
jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

P.S.

@jgrulich I also have to say that I'm not against DBus implementation in general, merely worried a bit. I see you also have keyboard protocol, that's a breakthrough! Never managed to grasp keysyms conversion myself.

Apr 11 2019, 5:49 AM
jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

PW framebuffer looks okay, it's the event system that worries me.

  1. We kind of force krfb to link with DBus, even if our plugin is not present.
  2. Are we moving mouse via D-Bus?..
Apr 11 2019, 5:43 AM

Apr 10 2019

jgrulich requested review of D20436: No need to set height to implicitHeight.
Apr 10 2019, 2:37 PM · Plasma
jgrulich committed R282:b3125a520ca8: WireGuard: private-key and preshared-keys can be requested together (authored by jgrulich).
WireGuard: private-key and preshared-keys can be requested together
Apr 10 2019, 9:28 AM
jgrulich added a comment to D20403: AppChooserDialog: make it more usable.

Uppps, I accidentaly pushed the change instead running "arc diff". I made it to select app with just a single click as you wanted to, without buttons below.

Apr 10 2019, 7:14 AM · Plasma
jgrulich committed R838:d15fc4aeb8b0: Select application with a single click (authored by jgrulich).
Select application with a single click
Apr 10 2019, 7:11 AM
jgrulich committed R838:5ddeff154725: AppChooserDialog: make it more usable (authored by jgrulich).
AppChooserDialog: make it more usable
Apr 10 2019, 7:11 AM
jgrulich closed D20403: AppChooserDialog: make it more usable.
Apr 10 2019, 7:11 AM · Plasma

Apr 9 2019

jgrulich added a comment to D20403: AppChooserDialog: make it more usable.

IMO this should be a single-click UI, with no Open button: since there's nothing useful you can do with a selected item besides opening it, it should always open with a single-click.

Apr 9 2019, 1:28 PM · Plasma
jgrulich added a reviewer for D20403: AppChooserDialog: make it more usable: Plasma.
Apr 9 2019, 7:31 AM · Plasma
jgrulich requested review of D20403: AppChooserDialog: make it more usable.
Apr 9 2019, 7:28 AM · Plasma
jgrulich added a comment to D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Note that this change requires KWin and xdg-desktop-portal-kde from master (upcoming Plasma 5.16) for mouse control, otherwise only screen content will be seen, but you won't be able to control it with your mouse.

Apr 9 2019, 7:19 AM
jgrulich updated the diff for D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.

Remove unwanted kdev4 file

Apr 9 2019, 7:14 AM
jgrulich added a reviewer for D20402: Implement Wayland support using PipeWire and xdg-desktop-portal: Kanedias.
Apr 9 2019, 7:13 AM
jgrulich requested review of D20402: Implement Wayland support using PipeWire and xdg-desktop-portal.
Apr 9 2019, 7:13 AM
jgrulich committed R437:4efc81124610: Fix merge issues (authored by jgrulich).
Fix merge issues
Apr 9 2019, 7:09 AM
jgrulich committed R437:f177c9564009: Merge branch 'master' into jgrulich/wayland-pipewire (authored by jgrulich).
Merge branch 'master' into jgrulich/wayland-pipewire
Apr 9 2019, 7:08 AM

Apr 7 2019

jgrulich added a comment to D18394: Add OTP support for openconnect VPN.
  1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token secret should be on the same line, and you should probably use PasswordField instead? It can be our PasswordField widget from libs/editor/widgets/. Or it's not secret in the same sense as other secrets and it will not need to be saved by secret agent, like rest of passwords? I would also follow nm-connection-editor and make tokens options visible in the main UI, not under specific button.

a) I don't see any need for the QComboBox and theQLineEdit to be in the same line, but that's a matter of taste, not functionality. Both fields are sort of independent: same key works with different OTP options.

Apr 7 2019, 2:30 PM · Plasma

Apr 6 2019

jgrulich added a comment to D18394: Add OTP support for openconnect VPN.
  1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token secret should be on the same line, and you should probably use PasswordField instead? It can be our PasswordField widget from libs/editor/widgets/. Or it's not secret in the same sense as other secrets and it will not need to be saved by secret agent, like rest of passwords? I would also follow nm-connection-editor and make tokens options visible in the main UI, not under specific button.
  2. Your code is full of trailing spaces
  3. How can I try this? Is there any public Openconnect server which I can use to test this?
Apr 6 2019, 7:56 PM · Plasma

Apr 4 2019

jgrulich accepted D20238: device: include reapplyConnection() in the interface.
Apr 4 2019, 8:26 AM · Frameworks
jgrulich accepted D20231: Don't force a check for updates when the applet runs.
Apr 4 2019, 6:16 AM
jgrulich added inline comments to D20238: device: include reapplyConnection() in the interface.
Apr 4 2019, 5:59 AM · Frameworks