jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (151 w, 6 d)
Availability
Available

Recent Activity

Thu, Jul 19

jgrulich committed R838:8170d53e647b: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Thu, Jul 19, 5:27 PM
jgrulich committed R838:96abec69d281: Support PipeWire 0.2.0 (authored by jgrulich).
Support PipeWire 0.2.0
Thu, Jul 19, 5:26 PM
jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

There is now new release of PipeWire (version 0.2.0), which breaks API a bit. I would suggest to bump PipeWire requirements to 0.2.0 and change your code. There is also now a version file included so in future we can use this to check PW version during build time and support more versions of the code. Unfortunately this header file was not included before and thus you cannot use it now, you would need to do the check in CMake in case you would want to support both PW 0.1.9 and PW 0.2.0. I'll be changing my code in xdg-desktop-portal-kde today, trying to support both in stable and only new PW 0.2.0 in master.

Thu, Jul 19, 7:24 AM · Plasma on Wayland

Mon, Jul 16

jgrulich accepted D14130: Parse protocol in port option.
Mon, Jul 16, 8:23 AM · Plasma

Fri, Jul 13

jgrulich added inline comments to D14035: Unbreak SSH agent support for SSH VPN tunnels..
Fri, Jul 13, 1:32 PM · Plasma
jgrulich committed R116:a36764241628: Merge branch 'master' (authored by jgrulich).
Merge branch 'master'
Fri, Jul 13, 8:25 AM

Wed, Jul 4

jgrulich committed R954:21b0fb28ea19: Update feed url for Jgrulich's blog (authored by jgrulich).
Update feed url for Jgrulich's blog
Wed, Jul 4, 9:01 AM
jgrulich committed R838:12a9ebac7dd2: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Wed, Jul 4, 8:01 AM
jgrulich committed R838:0bff2d4d107a: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Wed, Jul 4, 8:00 AM
jgrulich committed R838:78046e8203cd: Create stream once we are supposed to start a stream (authored by jgrulich).
Create stream once we are supposed to start a stream
Wed, Jul 4, 7:53 AM

Mon, Jul 2

jgrulich accepted D13818: Port from KStandardDirs to QStandardPaths.
Mon, Jul 2, 5:24 AM · Plasma

Fri, Jun 29

jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

One more possible thing to improve, I don't know if there is interest in supporting Gnome, but Gnome creates streams in BGRx format, which means it wouldn't mach your stream, if you want to support it you need to change it to something like :
":", pwType->format_video.format, "Ieu", pwType->video_format.RGBx, SPA_POD_PROP_ENUM(2, pwType_->video_format.RGBx, pwType_->video_format.BGRx)

Fri, Jun 29, 8:08 AM · Plasma on Wayland

Tue, Jun 26

jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

I have two things I observed when implementing same in WebRTC to have this working in Firefox and Chrome:

  1. Please use "Fru" for max_framerate and "Rru" for size, as it allows some negotiation when matching streams, I used the same in xdg-desktop-portal-kde now and in WebRTC and same will be used in Mutter
  2. Does it always stop streaming in x-d-p-kde when you stop receiving stream in KRfb? I've been experiencing this in WebRTC where when I disconnected my consuming stream, it still kept streaming in x-d-p-kde which you can see in the log. I solved this by calling Session->Close() in WebRTC and stop streaming in x-d-p-kde when the session has been closed.
Tue, Jun 26, 10:04 AM · Plasma on Wayland
jgrulich committed R838:bb74421e006b: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Tue, Jun 26, 9:55 AM
jgrulich committed R838:eac0062220bb: Stop streaming when session is closed and allow some stream negotiation (authored by jgrulich).
Stop streaming when session is closed and allow some stream negotiation
Tue, Jun 26, 9:54 AM

Jun 18 2018

jgrulich committed R116:1b5bfcb4b88e: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jun 18 2018, 8:51 AM
jgrulich committed R116:c43ae59a06b7: Properly fix icon size for connection delegate BUG: 394580 (authored by jgrulich).
Properly fix icon size for connection delegate BUG: 394580
Jun 18 2018, 8:51 AM
jgrulich committed R281:7b9d2badd52a: Implement support for the Voice and Call interfaces (authored by aleksanderm).
Implement support for the Voice and Call interfaces
Jun 18 2018, 6:25 AM
jgrulich closed D13482: Implement support for the Voice and Call interfaces.
Jun 18 2018, 6:25 AM · Frameworks
jgrulich committed R116:0739b0b6ab1e: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jun 18 2018, 5:52 AM
jgrulich committed R116:6dc2fc113a89: Attempt to fix icon size for connection delegate BUG: 394580 (authored by jgrulich).
Attempt to fix icon size for connection delegate BUG: 394580
Jun 18 2018, 5:50 AM

Jun 13 2018

jgrulich accepted D13482: Implement support for the Voice and Call interfaces.

Looks good to me. Having a test for this would be nice, but looks that not all interfaces are unit tested.

Jun 13 2018, 11:55 AM · Frameworks

Jun 12 2018

jgrulich committed R281:54cc344aa659: Don't set custom domain filter rules (authored by aleksanderm).
Don't set custom domain filter rules
Jun 12 2018, 8:18 AM
jgrulich closed D13117: Don't set custom domain filter rules.
Jun 12 2018, 8:18 AM · Frameworks

Jun 6 2018

jgrulich committed R257:af750742925a: Merge branch 'qt5.10' (authored by jgrulich).
Merge branch 'qt5.10'
Jun 6 2018, 4:43 PM
jgrulich committed R257:4c54d205fd8e: Don't crash app when native file dialog is used (authored by jgrulich).
Don't crash app when native file dialog is used
Jun 6 2018, 4:43 PM

Jun 5 2018

jgrulich committed R257:542ce20fe057: Merge branch 'qt5.10' (authored by jgrulich).
Merge branch 'qt5.10'
Jun 5 2018, 11:11 AM
jgrulich committed R257:6898c90da009: FileChooser portal: native dialog fixes (authored by jgrulich).
FileChooser portal: native dialog fixes
Jun 5 2018, 11:11 AM

Jun 1 2018

jgrulich committed R116:6b10d42027a7: WIP: Add simple/expert mode option (authored by jgrulich).
WIP: Add simple/expert mode option
Jun 1 2018, 6:51 AM

May 28 2018

jgrulich committed R116:3cfbcfe240ec: Remove unused stuff (authored by jgrulich).
Remove unused stuff
May 28 2018, 6:17 AM

May 26 2018

jgrulich accepted D13117: Don't set custom domain filter rules.
May 26 2018, 7:40 AM · Frameworks

May 24 2018

jgrulich committed R257:f3009fbf08c1: Merge branch 'qt5.10' (authored by jgrulich).
Merge branch 'qt5.10'
May 24 2018, 12:52 PM
jgrulich committed R257:9870ee160e5a: FileChooser portal: use native dialog for directories (authored by jgrulich).
FileChooser portal: use native dialog for directories
May 24 2018, 12:51 PM
jgrulich committed R872:a88b1c8157e9: Search for GLIB2 (authored by jgrulich).
Search for GLIB2
May 24 2018, 12:16 PM

May 23 2018

jgrulich committed R116:1a39f6a78db5: Fix search header and make connections properly clickable (authored by jgrulich).
Fix search header and make connections properly clickable
May 23 2018, 12:42 PM
jgrulich committed R282:eedead69e024: Make information about unhandled property just debug messages (authored by jgrulich).
Make information about unhandled property just debug messages
May 23 2018, 11:39 AM
jgrulich committed R282:8845146ba7d3: WirelessSetting: implement assignedMacAddress property (authored by jgrulich).
WirelessSetting: implement assignedMacAddress property
May 23 2018, 11:39 AM
jgrulich committed R116:6cfc42e41565: Attempt to use multipage KCM feature (authored by jgrulich).
Attempt to use multipage KCM feature
May 23 2018, 9:52 AM
jgrulich added reviewers for D13056: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64 based on architecture: broulik, fvogt.
May 23 2018, 8:22 AM · Plasma
jgrulich committed R856:d115fea3cb23: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64… (authored by jgrulich).
Install mozilla native messaging manifest to either /usr/lib or /usr/lib64…
May 23 2018, 8:21 AM
jgrulich closed D13056: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64 based on architecture.
May 23 2018, 8:21 AM · Plasma
jgrulich requested review of D13056: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64 based on architecture.
May 23 2018, 8:21 AM · Plasma
jgrulich committed R872:ed13ccc0da7f: Add additional tests for opening files and directories (authored by jgrulich).
Add additional tests for opening files and directories
May 23 2018, 7:38 AM

May 21 2018

jgrulich committed R623:2f4f2c68fe1f: Bump version to 0.3.2 (authored by jgrulich).
Bump version to 0.3.2
May 21 2018, 10:34 AM
jgrulich accepted D12976: Check cmake <foo>_FOUND variables for existance.
May 21 2018, 8:29 AM · Plasma

May 19 2018

jgrulich added a comment to T6944: [wip] Wireless networking in Plasma Mobile.

@mkacej is also working on the mobile broadband part, he has done some work already, but there is still lots of work ahead.

May 19 2018, 4:32 PM · Plasma: Mobile (PM 1.0)

May 17 2018

jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Thanks for the xml, I was able to pass it to qdbus2cpp. Amusingly, if I just try auto reply = dbusXdpService->CreateSession(QVariantMap()); (with empty parameter map), the main desktop portal app just segfaults! I mean, not the kde impl one but the main XDG Desktop Portal!
I'm fixing my parameters thanks to your test app, but... should that really happen?

May 17 2018, 5:20 AM · Plasma on Wayland
jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Hmm XDG Desktop Portal 0.11 just simply doesn't have ScreenCast interface on DBus... @jgrulich do I need some bleeding edge version or is it not yet in master branch?

May 17 2018, 5:08 AM · Plasma on Wayland

May 16 2018

jgrulich committed R116:8c502a89a1a3: Merge branch 'origin/master' (authored by jgrulich).
Merge branch 'origin/master'
May 16 2018, 10:35 AM
jgrulich committed R116:d35b6049cd14: Remove unused code (authored by jgrulich).
Remove unused code
May 16 2018, 8:50 AM
jgrulich committed R116:b76ce3936f53: Simplify connection item delegate (authored by jgrulich).
Simplify connection item delegate
May 16 2018, 8:50 AM
jgrulich committed R116:274feba06a49: Use QtQuick's built-in HSV color features for cycling download color (authored by jgrulich).
Use QtQuick's built-in HSV color features for cycling download color
May 16 2018, 8:50 AM
jgrulich committed R116:5be0a7f8f100: Coding style and minor improvements (authored by jgrulich).
Coding style and minor improvements
May 16 2018, 8:50 AM

May 15 2018

jgrulich committed R257:4d93dca2d76f: Merge branch 'qt5.9lts' (authored by jgrulich).
Merge branch 'qt5.9lts'
May 15 2018, 10:38 AM
jgrulich committed R257:b929bb1fc369: Adwaita-qt, highcontrast-qt and qgnomeplatform are now in Flathub (authored by jgrulich).
Adwaita-qt, highcontrast-qt and qgnomeplatform are now in Flathub
May 15 2018, 10:37 AM
jgrulich committed R257:a003e8f301c2: Merge remote-tracking branch 'origin/qt5.9lts' (authored by jgrulich).
Merge remote-tracking branch 'origin/qt5.9lts'
May 15 2018, 10:35 AM
jgrulich committed R257:09fae412febf: Fix filter parsing in flatpak FileChooser portal (authored by jgrulich).
Fix filter parsing in flatpak FileChooser portal
May 15 2018, 10:30 AM

May 14 2018

jgrulich committed R116:553bbb982913: Merge branch 'Plasma/5.12' (authored by jgrulich).
Merge branch 'Plasma/5.12'
May 14 2018, 11:17 AM
jgrulich committed R116:46c1dcbeb0c9: Unquote remote when importing OpenVPN connections (authored by jgrulich).
Unquote remote when importing OpenVPN connections
May 14 2018, 10:51 AM

May 10 2018

jgrulich committed R116:7f44a45ffcf3: Use ScrollView from QtQuickControls in the main connection view (authored by jgrulich).
Use ScrollView from QtQuickControls in the main connection view
May 10 2018, 1:58 PM
jgrulich accepted D12790: Use \n instead of <br> for the extra part of the summary.
May 10 2018, 7:02 AM
jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

The Screencast portal DBus interface is here: https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.ScreenCast.xml

May 10 2018, 7:02 AM · Plasma on Wayland
jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

@jgrulich I started to hack together a very simple krfb-with-dbus-with-xdp-kde-with-pipewire... thingie.
Now I'm curious, you have handle and session_handle paths everywhere in Screencast interface inside XDP-KDE source. Why? I can understand why session_handle is there - to create and track sessions of course, but what is handle used for?

May 10 2018, 7:01 AM · Plasma on Wayland

May 6 2018

jgrulich accepted D12716: Check for device not being null.
May 6 2018, 4:25 PM · Plasma

May 4 2018

jgrulich committed R838:06ceacee329c: Add Screenshot portal (authored by jgrulich).
Add Screenshot portal
May 4 2018, 12:11 PM
jgrulich closed D12068: Add Screenshot portal.
May 4 2018, 12:11 PM
jgrulich added a comment to D12068: Add Screenshot portal.

It should be correct, because from Qt documentation, using QDbusUnixFileDescriptor creates a duplicate of that file descriptor so it should be safe to close it right after.

May 4 2018, 12:10 PM

Apr 26 2018

jgrulich updated the diff for D12068: Add Screenshot portal.

Make sure the file url we return is in correct format

Apr 26 2018, 1:05 PM
jgrulich committed R838:7bd8db5c5518: Improve app chooser dialog (authored by jgrulich).
Improve app chooser dialog
Apr 26 2018, 11:31 AM

Apr 25 2018

jgrulich added a reviewer for D12068: Add Screenshot portal: Kanedias.
Apr 25 2018, 9:27 AM

Apr 24 2018

jgrulich committed R116:11d88a91b6d9: Add missing files from previous commit++ (authored by jgrulich).
Add missing files from previous commit++
Apr 24 2018, 12:08 PM
jgrulich committed R116:4f720682275e: Add missing files from previous commit (authored by jgrulich).
Add missing files from previous commit
Apr 24 2018, 11:57 AM
jgrulich committed R116:ed39a63a138f: Add common wireless configuration (authored by jgrulich).
Add common wireless configuration
Apr 24 2018, 11:56 AM
jgrulich committed R116:66d2ac6ff4cd: Merge branch 'master' into plasma-kcm (authored by jgrulich).
Merge branch 'master' into plasma-kcm
Apr 24 2018, 11:56 AM
jgrulich added a reviewer for D12493: Require NetworkManager 1.4.0 and newer: Frameworks.
Apr 24 2018, 10:10 AM · Frameworks
jgrulich requested review of D12493: Require NetworkManager 1.4.0 and newer.
Apr 24 2018, 10:10 AM · Frameworks

Apr 23 2018

jgrulich abandoned D9980: Do not reset the size of window once we move it to an edge.
Apr 23 2018, 6:35 AM · KWin

Apr 22 2018

jgrulich updated the diff for D12378: Properly search for NetworkManager.

Do not use prefix for NM header and remove unnecessary workarounds

Apr 22 2018, 6:05 PM · Frameworks

Apr 20 2018

jgrulich updated the summary of D12378: Properly search for NetworkManager.
Apr 20 2018, 12:07 PM · Frameworks
jgrulich updated the summary of D12378: Properly search for NetworkManager.
Apr 20 2018, 12:07 PM · Frameworks
jgrulich added a reviewer for D12378: Properly search for NetworkManager: Frameworks.
Apr 20 2018, 11:47 AM · Frameworks
jgrulich requested review of D12378: Properly search for NetworkManager.
Apr 20 2018, 11:47 AM · Frameworks
jgrulich committed R239:b3d2fd62a4d1: Fix file encoding (authored by jgrulich).
Fix file encoding
Apr 20 2018, 11:43 AM
jgrulich committed R257:d141fba40426: Bump Qt version for gnome plugins (authored by jgrulich).
Bump Qt version for gnome plugins
Apr 20 2018, 9:47 AM
jgrulich committed R257:a451fad3b94b: Merge branch 'qt5.9lts' (authored by jgrulich).
Merge branch 'qt5.9lts'
Apr 20 2018, 9:47 AM
jgrulich committed R257:59a6af13a167: Move gnome integration plugins back to runtime repo (authored by jgrulich).
Move gnome integration plugins back to runtime repo
Apr 20 2018, 9:45 AM
jgrulich closed D12370: Move gnome integration plugins back to runtime repo.
Apr 20 2018, 9:45 AM
jgrulich added a reviewer for D12370: Move gnome integration plugins back to runtime repo: apol.
Apr 20 2018, 7:45 AM
jgrulich requested review of D12370: Move gnome integration plugins back to runtime repo.
Apr 20 2018, 7:44 AM

Apr 18 2018

jgrulich committed R838:0ff113d3dcbd: Search properly for pipewire and other libs (authored by jgrulich).
Search properly for pipewire and other libs
Apr 18 2018, 10:06 AM
jgrulich closed D12147: Search properly for pipewire and other libs.
Apr 18 2018, 10:06 AM
jgrulich updated the diff for D12147: Search properly for pipewire and other libs.

Remove custom GLib cmake module and fix module naming

Apr 18 2018, 9:47 AM
jgrulich added a comment to D12147: Search properly for pipewire and other libs.

@cgiboudeaux are the cmake modules correct now?

Apr 18 2018, 6:21 AM
jgrulich added a comment to D12068: Add Screenshot portal.

Ping?

Apr 18 2018, 6:21 AM
jgrulich added a reviewer for D12068: Add Screenshot portal: romangg.
Apr 18 2018, 6:20 AM

Apr 13 2018

jgrulich updated the diff for D12147: Search properly for pipewire and other libs.

Fix naming of cmake modules

Apr 13 2018, 8:36 AM

Apr 12 2018

jgrulich updated the diff for D12147: Search properly for pipewire and other libs.

Remove leftover from another review

Apr 12 2018, 1:06 PM
jgrulich added a comment to D12147: Search properly for pipewire and other libs.

Findpipewire.cmake and Findspa.cmake are copies of Findgbm.cmake and just modified accordingly, Findglib.cmake is copied from webkit.

Apr 12 2018, 1:05 PM
jgrulich added a reviewer for D12147: Search properly for pipewire and other libs: Plasma.
Apr 12 2018, 1:04 PM
jgrulich updated subscribers of D12147: Search properly for pipewire and other libs.
Apr 12 2018, 1:04 PM