jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (160 w, 5 d)
Availability
Available

Recent Activity

Today

jgrulich added a comment to T7785: PipeWire support in remote access to KWin.

Screen sharing works just fine with Plasma 5.13 and upcoming Plasma 5.14. There was a major issue in KWayland which will be fixed in KF5 5.51 so we might want to mention this to anyone trying screen sharing on Wayland. We still need some work to be done on KWin side to be able to share just a window, but this is not implement even in Mutter yet. I also still have to finish remote desktop support, which I didn't make to Plasma 5.14, but it will definitely be in Plasma 5.15. I did lots of rewrites in xdg-desktop-portal-kde recently and you can also get screen sharing done through remote desktop portal now. I also did changes in Krfb to support new PipeWire API and to use remote desktop portal to get screen content. What is missing is to handle input in Krfb and pass it to remote desktop portal in xdg-desktop-portal-kde where I miss to forward them to KWayland, this is still all in progress.

Sun, Sep 23, 7:33 AM · Plasma (Plasma 5.14), KWin, Plasma on Wayland

Thu, Sep 20

jgrulich committed R116:9e4db88fe601: Fix ampersand and other characters in tooltip (authored by jgrulich).
Fix ampersand and other characters in tooltip
Thu, Sep 20, 1:57 PM
jgrulich committed R116:effee745b00e: Merge branch 'Plasma/5.13' into Plasma/5.14 (authored by jgrulich).
Merge branch 'Plasma/5.13' into Plasma/5.14
Thu, Sep 20, 1:56 PM
jgrulich committed R116:9a3febeb0a21: Fix ampersand and other characters in tooltip (authored by jgrulich).
Fix ampersand and other characters in tooltip
Thu, Sep 20, 1:34 PM
jgrulich committed R838:adc23c04e5ac: Fix getting application name from application desktop file (authored by jgrulich).
Fix getting application name from application desktop file
Thu, Sep 20, 11:29 AM

Tue, Sep 18

jgrulich added a comment to D15093: Add WireGuard capability..

Since I added a validator function for the WireGuard style keys, is there any way to assign a validator to the PasswordField widget without a fairly substantial rewrite of that class?

Tue, Sep 18, 5:42 AM · Plasma

Mon, Sep 17

jgrulich committed R437:a13b1e56c4da: Simplify buffer handling (authored by jgrulich).
Simplify buffer handling
Mon, Sep 17, 9:32 AM
jgrulich added a comment to D15093: Add WireGuard capability..

Please, update all your reviews so they don't duplicate changes. I would personally have one review for all your IPv[4,6]Validator changes and one review just for WireGuard VPN plugin.

Mon, Sep 17, 9:31 AM · Plasma
jgrulich committed R838:3bcb64592014: Merge branch 'master' of git://anongit.kde.org/xdg-desktop-portal-kde (authored by jgrulich).
Merge branch 'master' of git://anongit.kde.org/xdg-desktop-portal-kde
Mon, Sep 17, 9:23 AM
jgrulich committed R838:e4a788d8ac2c: Merge branch 'jgrulich/remotedesktop' (authored by jgrulich).
Merge branch 'jgrulich/remotedesktop'
Mon, Sep 17, 9:23 AM
jgrulich committed R838:98010fae711b: Merge branch 'Plasma/5.13' into Plasma/5.14 (authored by jgrulich).
Merge branch 'Plasma/5.13' into Plasma/5.14
Mon, Sep 17, 9:21 AM
jgrulich committed R838:fcbbedd8eb1c: Make remote desktop portal to start screen sharing (authored by jgrulich).
Make remote desktop portal to start screen sharing
Mon, Sep 17, 9:20 AM
jgrulich committed R838:4fb19e697534: Use correct stream size (authored by jgrulich).
Use correct stream size
Mon, Sep 17, 9:20 AM
jgrulich added a comment to D15521: Add validator for lists of IP addresses Added as separate review per comment from Pino on review D15093. This code will not compile without the updated code in review D15520. Also includes unit test..

Maybe merge this review with D15520. I think they should go together.

Mon, Sep 17, 5:54 AM · Plasma
jgrulich added inline comments to D15521: Add validator for lists of IP addresses Added as separate review per comment from Pino on review D15093. This code will not compile without the updated code in review D15520. Also includes unit test..
Mon, Sep 17, 5:52 AM · Plasma

Thu, Sep 13

jgrulich committed R437:8f198a0979b9: Wayland initialization can be removed (authored by jgrulich).
Wayland initialization can be removed
Thu, Sep 13, 12:38 PM
jgrulich committed R437:3985fa8e0eaf: Make screen sharing work through remote desktop portal (authored by jgrulich).
Make screen sharing work through remote desktop portal
Thu, Sep 13, 12:36 PM
jgrulich committed R437:c7ff786dcd04: Do not check for running portal as it can be started automatically (authored by jgrulich).
Do not check for running portal as it can be started automatically
Thu, Sep 13, 12:36 PM
jgrulich committed R116:0491738ced86: Make sure we change icon on NM connectivity change (authored by jgrulich).
Make sure we change icon on NM connectivity change
Thu, Sep 13, 11:46 AM
jgrulich committed R116:340e0d26e370: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Thu, Sep 13, 11:26 AM
jgrulich committed R116:a71ca963f798: Make sure we change icon on NM connectivity change (authored by jgrulich).
Make sure we change icon on NM connectivity change
Thu, Sep 13, 11:26 AM

Wed, Sep 12

jgrulich committed R838:da725066d8fe: Move some stream related code from screencast portal to screencast stream (authored by jgrulich).
Move some stream related code from screencast portal to screencast stream
Wed, Sep 12, 1:44 PM
jgrulich committed R838:31363e46940a: Add ScreenCastWidget to CMakeLists (authored by jgrulich).
Add ScreenCastWidget to CMakeLists
Wed, Sep 12, 1:44 PM
jgrulich committed R838:995066dd8b84: Make separated widget with screens to be shared with remote desktop dialog (authored by jgrulich).
Make separated widget with screens to be shared with remote desktop dialog
Wed, Sep 12, 1:44 PM
jgrulich committed R838:760170e90fed: Use correct stream size (authored by jgrulich).
Use correct stream size
Wed, Sep 12, 1:44 PM

Tue, Sep 11

jgrulich added a comment to D15422: [server] Fix remote access buffer handling when output not bound.

Both versions solve issue I have and KWin no longer opens dozens of fds and abort when reaches the limit.

Tue, Sep 11, 1:24 PM · Frameworks

Mon, Sep 10

jgrulich committed R838:531a7e72dd4a: Move Wayland integration bits into separated class so they can be shared… (authored by jgrulich).
Move Wayland integration bits into separated class so they can be shared…
Mon, Sep 10, 11:49 AM

Thu, Sep 6

jgrulich committed R838:cd513b72f4ec: Initial work on remote desktop (authored by jgrulich).
Initial work on remote desktop
Thu, Sep 6, 12:40 PM
jgrulich committed R838:ddd12bc744bc: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Thu, Sep 6, 12:40 PM
jgrulich committed R838:8c06afa97a64: We don't need to link against libspa (authored by jgrulich).
We don't need to link against libspa
Thu, Sep 6, 12:40 PM

Wed, Sep 5

jgrulich accepted D15297: Use QOverload to select overloaded functions.
Wed, Sep 5, 3:27 PM · Plasma
jgrulich added a comment to D15093: Add WireGuard capability..

Does wg-quick support both, like simple commands and script files? If so, we should support both as well, if it supports only commands/snippets, we should leave it as it is.

.....
Given this new information as well as the fact that there is a disconnect between what wg-quick wants and what the NM addon takes in, most notably, wg-quick specifically accepts multiple instances of each but the NM addon only allows one line of input.

I would therefore propose that I remove all of the Pre/Post Up/Down entries for now since they won't do anything anyway and worry about adding them back in if the NM addon implements them properly and then match its implementation.

Wed, Sep 5, 10:32 AM · Plasma
jgrulich committed R437:1bcc2a179498: Support PW 0.2+ and do not link against libspa (authored by jgrulich).
Support PW 0.2+ and do not link against libspa
Wed, Sep 5, 8:07 AM
jgrulich added a comment to D15093: Add WireGuard capability..

I think you can completely remove WireguardAuth dialog if there is no use for it. I also spotted few trailing spaces in the patch, please remove them.

Wed, Sep 5, 7:35 AM · Plasma
jgrulich added a comment to D15093: Add WireGuard capability..
In D15093#319253, @pino wrote:

Much better now!

  • regarding the UI for all the pre/post scripts: since they are file paths, better use a KUrlRequester widget (limited to local existing files only, no URLs), so the users have a Browse button next to each line edit that can be used to open a file dialog

I debated with myself when I started this whether to include these at all. They are included in the base NetworkManager implementation which "inherited" them from the underlying wg-quick command but they duplicate functionality that NM provides directly and it seems to me that if someone is using NM then they can use those methods instead. Also, wg-quick specifies these as "script snippets" meaning actual direct commands that are executed by bash not necessarily a shell script. It also specifies that there can be multiple instances of each, a capability that the base NM implementation does not support. So my quandary is, do I implement this like the base NM does and possibly, as you suggest, force it to be a single shell script which sort of violates the spirit of the wg-quick command or do I delete it completely and not support something that base NM does, or do I leave it like it is?

Personally I think that the base NM should get rid of these and force users to rely on the capability in NM to perform pre and post operations but given what exists, I don't think any of the alternatives are good and I'm not sure what the "least bad" solution is. If someone uses nm-connection-editor and enters something which is not a script and then opens the connection in a plasma-nm interface which only supports a file, I'm not sure what will happen. On the other hand if I delete the fields completely and open something created in nm-connection-editor with these fields, that's not good either.

Since I initially was doing this only for my own use and was probably going to use NM for this, I admit that I took the easiest way out and duplicated what base NM has, which is a single string which can contain a shell script but also a snippet as the base WireGuard does and then said in the tool-tip that it was preferable to use NM capability instead.

If you as a representative of the plasma-nm philosophy have a preference on which way to go or have a brilliant idea which solves all the problems, I will follow your lead.

Wed, Sep 5, 7:10 AM · Plasma

Tue, Sep 4

jgrulich committed R838:77c9ec54a612: Fix build condition for screencast portal (authored by jgrulich).
Fix build condition for screencast portal
Tue, Sep 4, 10:08 AM

Mon, Sep 3

jgrulich added inline comments to D15093: Add WireGuard capability..
Mon, Sep 3, 6:26 AM · Plasma

Fri, Aug 31

jgrulich committed R116:4a12cae5065a: Merge branch 'master' into plasma-kcm (authored by jgrulich).
Merge branch 'master' into plasma-kcm
Fri, Aug 31, 11:22 AM
jgrulich committed R116:5080db87ce24: Add missing includes and frameworks (authored by jgrulich).
Add missing includes and frameworks
Fri, Aug 31, 9:31 AM
jgrulich committed R116:e72304fbaf66: Merge branch 'master' into plasma-kcm (authored by jgrulich).
Merge branch 'master' into plasma-kcm
Fri, Aug 31, 9:31 AM
jgrulich committed R282:1ddc9857cdac: Remove notes from API documentation about older NM versions (authored by jgrulich).
Remove notes from API documentation about older NM versions
Fri, Aug 31, 8:53 AM
jgrulich committed R838:23e139b7e8d4: We don't need to link against libspa (authored by jgrulich).
We don't need to link against libspa
Fri, Aug 31, 8:32 AM

Thu, Aug 30

jgrulich committed R116:888058adbed3: Require NM 1.4.0 and newer (authored by jgrulich).
Require NM 1.4.0 and newer
Thu, Aug 30, 11:22 AM
jgrulich accepted D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine.
Thu, Aug 30, 11:19 AM · Plasma
jgrulich committed R282:d5d45a61e324: Require NetworkManager 1.4.0 and newer (authored by jgrulich).
Require NetworkManager 1.4.0 and newer
Thu, Aug 30, 11:18 AM
jgrulich closed D12493: Require NetworkManager 1.4.0 and newer.
Thu, Aug 30, 11:18 AM · Frameworks
jgrulich added a comment to D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine.

Another thing is, can Plasma 5.14 depend on KDE Frameworks 5.50?

Thu, Aug 30, 11:14 AM · Plasma

Wed, Aug 29

jgrulich added a comment to D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine.

Can we get some opinions from KDE Neon people? I have older review to bump NM requirements to 1.4.0 here https://phabricator.kde.org/D12493.

Wed, Aug 29, 7:19 PM · Plasma
jgrulich added reviewers for D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine: sitter, jriddell.
Wed, Aug 29, 7:19 PM · Plasma
jgrulich committed R116:38b659465d86: Unbreak SSH agent support for SSH VPN tunnels. (authored by jgrulich).
Unbreak SSH agent support for SSH VPN tunnels.
Wed, Aug 29, 7:15 PM
jgrulich closed D14035: Unbreak SSH agent support for SSH VPN tunnels..
Wed, Aug 29, 7:15 PM · Plasma
jgrulich committed R116:1feaa4ca1cdf: Parse protocol in port option (authored by martinschulze).
Parse protocol in port option
Wed, Aug 29, 7:14 PM
jgrulich closed D14130: Parse protocol in port option.
Wed, Aug 29, 7:14 PM · Plasma
jgrulich committed R282:6b2c3e8fce2f: manager: add support to R/W the GlobalDnsConfiguration property (authored by aleksanderm).
manager: add support to R/W the GlobalDnsConfiguration property
Wed, Aug 29, 7:12 PM
jgrulich closed D11353: manager: add support to R/W the GlobalDnsConfiguration property.
Wed, Aug 29, 7:12 PM · Frameworks

Mon, Aug 27

jgrulich added a comment to D15093: Add WireGuard capability..

That's a big change/patch, I'll look more closely as soon as possible. One thing I see at first look is different coding style, can you please follow Qt coding style? I'm sure that many parts of plasma-nm are not using consistent coding style, but you should try to follow this one https://wiki.qt.io/Qt_Coding_Style.

Mon, Aug 27, 10:41 AM · Plasma
jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

Now I realized what you mean, you mean that I didn't change libspa version as I did for pipewire, right? That hasn't change in released PW tarballs, but it's already changed now in master (Wim started versioning it) so I will have to fix this as well.

Mon, Aug 27, 8:46 AM · Plasma on Wayland
jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

@jgrulich you didn't change FindSPA, is it ok?

Mon, Aug 27, 7:42 AM · Plasma on Wayland

Aug 16 2018

jgrulich added a comment to D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine.

I assume we can bump requirements to NM 1.4, even Debian stable is now using NM 1.6.

Aug 16 2018, 10:27 AM · Plasma
jgrulich requested changes to D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine.

Hmm, taking it back, actually this cannot be used as it requires NM 1.4 and newer and we require NM 1.0 and newer.

Aug 16 2018, 10:19 AM · Plasma
jgrulich accepted D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine.

Looks good to me. I was thinking about using it already some time ago, but didn't really find time to change that so thank you for implementing it. Actually, I think it was not possible before as we supported older NM versions where device statistics interface was not available yet.

Aug 16 2018, 10:16 AM · Plasma

Aug 13 2018

jgrulich accepted D14794: Port away from KLocale and KDELibs4Support.
Aug 13 2018, 4:01 PM · Plasma
jgrulich accepted D14793: Update connection details only when necessary.
Aug 13 2018, 3:55 PM · Plasma
jgrulich accepted D14786: Fix archive name in README.md.
Aug 13 2018, 12:54 PM · Plasma

Aug 10 2018

jgrulich accepted D14732: Actually allow to set the refresh rate for device statistics.
Aug 10 2018, 10:10 PM · Frameworks

Aug 8 2018

jgrulich accepted D14691: make the layout work.

Works \o/. Thanks.

Aug 8 2018, 12:27 PM · Plasma

Aug 7 2018

jgrulich closed D14667: Fix a text label in the password dialog.
Aug 7 2018, 11:56 AM · Plasma
jgrulich committed R116:af9f12b2909d: Fix a text label in the password dialog (authored by jgrulich).
Fix a text label in the password dialog
Aug 7 2018, 11:56 AM
jgrulich committed R116:9a06a8e033a6: Add additional checks for device existence (authored by jgrulich).
Add additional checks for device existence
Aug 7 2018, 11:03 AM
jgrulich accepted D14667: Fix a text label in the password dialog.
Aug 7 2018, 10:13 AM · Plasma

Aug 6 2018

jgrulich accepted D14651: [Notifications Engine] Guard "this".

I can no longer reproduce the crash from bug 397105.

Aug 6 2018, 2:13 PM · Plasma
jgrulich added a comment to D14035: Unbreak SSH agent support for SSH VPN tunnels..

Thank you for your contribution.

Aug 6 2018, 6:06 AM · Plasma
jgrulich accepted D14035: Unbreak SSH agent support for SSH VPN tunnels..
Aug 6 2018, 6:05 AM · Plasma

Aug 2 2018

jgrulich committed R838:ee590b224225: Add support for PickColor method from Screenshot portal (authored by jgrulich).
Add support for PickColor method from Screenshot portal
Aug 2 2018, 1:17 PM

Aug 1 2018

jgrulich committed R838:df164ec6cfb1: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Aug 1 2018, 7:39 AM
jgrulich committed R838:a96074bd1bc2: Search also for libpipewire-0.2 (authored by jgrulich).
Search also for libpipewire-0.2
Aug 1 2018, 7:31 AM
jgrulich requested changes to D14035: Unbreak SSH agent support for SSH VPN tunnels..
Aug 1 2018, 5:30 AM · Plasma

Jul 23 2018

jgrulich committed R838:92885afdf9df: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jul 23 2018, 6:25 AM
jgrulich committed R838:8a3516cdaa63: Minor changes to macros (authored by jgrulich).
Minor changes to macros
Jul 23 2018, 6:25 AM

Jul 19 2018

jgrulich committed R838:8170d53e647b: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jul 19 2018, 5:27 PM
jgrulich committed R838:96abec69d281: Support PipeWire 0.2.0 (authored by jgrulich).
Support PipeWire 0.2.0
Jul 19 2018, 5:26 PM
jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

There is now new release of PipeWire (version 0.2.0), which breaks API a bit. I would suggest to bump PipeWire requirements to 0.2.0 and change your code. There is also now a version file included so in future we can use this to check PW version during build time and support more versions of the code. Unfortunately this header file was not included before and thus you cannot use it now, you would need to do the check in CMake in case you would want to support both PW 0.1.9 and PW 0.2.0. I'll be changing my code in xdg-desktop-portal-kde today, trying to support both in stable and only new PW 0.2.0 in master.

Jul 19 2018, 7:24 AM · Plasma on Wayland

Jul 16 2018

jgrulich accepted D14130: Parse protocol in port option.
Jul 16 2018, 8:23 AM · Plasma

Jul 13 2018

jgrulich added inline comments to D14035: Unbreak SSH agent support for SSH VPN tunnels..
Jul 13 2018, 1:32 PM · Plasma
jgrulich committed R116:a36764241628: Merge branch 'master' (authored by jgrulich).
Merge branch 'master'
Jul 13 2018, 8:25 AM

Jul 4 2018

jgrulich committed R954:21b0fb28ea19: Update feed url for Jgrulich's blog (authored by jgrulich).
Update feed url for Jgrulich's blog
Jul 4 2018, 9:01 AM
jgrulich committed R838:12a9ebac7dd2: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jul 4 2018, 8:01 AM
jgrulich committed R838:0bff2d4d107a: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jul 4 2018, 8:00 AM
jgrulich committed R838:78046e8203cd: Create stream once we are supposed to start a stream (authored by jgrulich).
Create stream once we are supposed to start a stream
Jul 4 2018, 7:53 AM

Jul 2 2018

jgrulich accepted D13818: Port from KStandardDirs to QStandardPaths.
Jul 2 2018, 5:24 AM · Plasma

Jun 29 2018

jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

One more possible thing to improve, I don't know if there is interest in supporting Gnome, but Gnome creates streams in BGRx format, which means it wouldn't mach your stream, if you want to support it you need to change it to something like :
":", pwType->format_video.format, "Ieu", pwType->video_format.RGBx, SPA_POD_PROP_ENUM(2, pwType_->video_format.RGBx, pwType_->video_format.BGRx)

Jun 29 2018, 8:08 AM · Plasma on Wayland

Jun 26 2018

jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

I have two things I observed when implementing same in WebRTC to have this working in Firefox and Chrome:

  1. Please use "Fru" for max_framerate and "Rru" for size, as it allows some negotiation when matching streams, I used the same in xdg-desktop-portal-kde now and in WebRTC and same will be used in Mutter
  2. Does it always stop streaming in x-d-p-kde when you stop receiving stream in KRfb? I've been experiencing this in WebRTC where when I disconnected my consuming stream, it still kept streaming in x-d-p-kde which you can see in the log. I solved this by calling Session->Close() in WebRTC and stop streaming in x-d-p-kde when the session has been closed.
Jun 26 2018, 10:04 AM · Plasma on Wayland
jgrulich committed R838:bb74421e006b: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jun 26 2018, 9:55 AM
jgrulich committed R838:eac0062220bb: Stop streaming when session is closed and allow some stream negotiation (authored by jgrulich).
Stop streaming when session is closed and allow some stream negotiation
Jun 26 2018, 9:54 AM

Jun 18 2018

jgrulich committed R116:1b5bfcb4b88e: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jun 18 2018, 8:51 AM
jgrulich committed R116:c43ae59a06b7: Properly fix icon size for connection delegate BUG: 394580 (authored by jgrulich).
Properly fix icon size for connection delegate BUG: 394580
Jun 18 2018, 8:51 AM
jgrulich committed R281:7b9d2badd52a: Implement support for the Voice and Call interfaces (authored by aleksanderm).
Implement support for the Voice and Call interfaces
Jun 18 2018, 6:25 AM
jgrulich closed D13482: Implement support for the Voice and Call interfaces.
Jun 18 2018, 6:25 AM · Frameworks
jgrulich committed R116:0739b0b6ab1e: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Jun 18 2018, 5:52 AM
jgrulich committed R116:6dc2fc113a89: Attempt to fix icon size for connection delegate BUG: 394580 (authored by jgrulich).
Attempt to fix icon size for connection delegate BUG: 394580
Jun 18 2018, 5:50 AM