- User Since
- Aug 24 2015, 11:06 AM (160 w, 5 d)
Screen sharing works just fine with Plasma 5.13 and upcoming Plasma 5.14. There was a major issue in KWayland which will be fixed in KF5 5.51 so we might want to mention this to anyone trying screen sharing on Wayland. We still need some work to be done on KWin side to be able to share just a window, but this is not implement even in Mutter yet. I also still have to finish remote desktop support, which I didn't make to Plasma 5.14, but it will definitely be in Plasma 5.15. I did lots of rewrites in xdg-desktop-portal-kde recently and you can also get screen sharing done through remote desktop portal now. I also did changes in Krfb to support new PipeWire API and to use remote desktop portal to get screen content. What is missing is to handle input in Krfb and pass it to remote desktop portal in xdg-desktop-portal-kde where I miss to forward them to KWayland, this is still all in progress.
Thu, Sep 20
Tue, Sep 18
Mon, Sep 17
Please, update all your reviews so they don't duplicate changes. I would personally have one review for all your IPv[4,6]Validator changes and one review just for WireGuard VPN plugin.
Maybe merge this review with D15520. I think they should go together.
Thu, Sep 13
Wed, Sep 12
Tue, Sep 11
Both versions solve issue I have and KWin no longer opens dozens of fds and abort when reaches the limit.
Mon, Sep 10
Thu, Sep 6
Wed, Sep 5
I think you can completely remove WireguardAuth dialog if there is no use for it. I also spotted few trailing spaces in the patch, please remove them.
Tue, Sep 4
Mon, Sep 3
Fri, Aug 31
Thu, Aug 30
Another thing is, can Plasma 5.14 depend on KDE Frameworks 5.50?
Wed, Aug 29
Can we get some opinions from KDE Neon people? I have older review to bump NM requirements to 1.4.0 here https://phabricator.kde.org/D12493.
Mon, Aug 27
That's a big change/patch, I'll look more closely as soon as possible. One thing I see at first look is different coding style, can you please follow Qt coding style? I'm sure that many parts of plasma-nm are not using consistent coding style, but you should try to follow this one https://wiki.qt.io/Qt_Coding_Style.
Now I realized what you mean, you mean that I didn't change libspa version as I did for pipewire, right? That hasn't change in released PW tarballs, but it's already changed now in master (Wim started versioning it) so I will have to fix this as well.
Aug 16 2018
I assume we can bump requirements to NM 1.4, even Debian stable is now using NM 1.6.
Hmm, taking it back, actually this cannot be used as it requires NM 1.4 and newer and we require NM 1.0 and newer.
Looks good to me. I was thinking about using it already some time ago, but didn't really find time to change that so thank you for implementing it. Actually, I think it was not possible before as we supported older NM versions where device statistics interface was not available yet.
Aug 13 2018
Aug 10 2018
Aug 8 2018
Aug 7 2018
Aug 6 2018
I can no longer reproduce the crash from bug 397105.
Thank you for your contribution.
Aug 2 2018
Aug 1 2018
Jul 23 2018
Jul 19 2018
There is now new release of PipeWire (version 0.2.0), which breaks API a bit. I would suggest to bump PipeWire requirements to 0.2.0 and change your code. There is also now a version file included so in future we can use this to check PW version during build time and support more versions of the code. Unfortunately this header file was not included before and thus you cannot use it now, you would need to do the check in CMake in case you would want to support both PW 0.1.9 and PW 0.2.0. I'll be changing my code in xdg-desktop-portal-kde today, trying to support both in stable and only new PW 0.2.0 in master.
Jul 16 2018
Jul 13 2018
Jul 4 2018
Jul 2 2018
Jun 29 2018
One more possible thing to improve, I don't know if there is interest in supporting Gnome, but Gnome creates streams in BGRx format, which means it wouldn't mach your stream, if you want to support it you need to change it to something like :
":", pwType->format_video.format, "Ieu", pwType->video_format.RGBx, SPA_POD_PROP_ENUM(2, pwType_->video_format.RGBx, pwType_->video_format.BGRx)
Jun 26 2018
I have two things I observed when implementing same in WebRTC to have this working in Firefox and Chrome:
- Please use "Fru" for max_framerate and "Rru" for size, as it allows some negotiation when matching streams, I used the same in xdg-desktop-portal-kde now and in WebRTC and same will be used in Mutter
- Does it always stop streaming in x-d-p-kde when you stop receiving stream in KRfb? I've been experiencing this in WebRTC where when I disconnected my consuming stream, it still kept streaming in x-d-p-kde which you can see in the log. I solved this by calling Session->Close() in WebRTC and stop streaming in x-d-p-kde when the session has been closed.