jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (168 w, 1 d)
Availability
Available

Recent Activity

Fri, Nov 9

jgrulich committed R116:be1a876fcf94: Build mobile kcm optionally (authored by jgrulich).
Build mobile kcm optionally
Fri, Nov 9, 9:49 AM
jgrulich committed R116:97c5df0c215c: Revert unwanted change (authored by jgrulich).
Revert unwanted change
Fri, Nov 9, 9:49 AM
jgrulich committed R116:61600430d683: Make broadband support optional based on enabled ModemManager support (authored by jgrulich).
Make broadband support optional based on enabled ModemManager support
Fri, Nov 9, 9:49 AM
jgrulich committed R116:59f7fc153bb7: We don't need ModemManager includes here (authored by jgrulich).
We don't need ModemManager includes here
Fri, Nov 9, 9:49 AM
jgrulich committed R116:6d22ea888990: Merge remote-tracking branch 'plasma-mobile/master' (authored by jgrulich).
Merge remote-tracking branch 'plasma-mobile/master'
Fri, Nov 9, 9:49 AM
jgrulich committed R116:b96bfc94bc4c: Better naming and minor coding style fixes (authored by jgrulich).
Better naming and minor coding style fixes
Fri, Nov 9, 9:49 AM
jgrulich committed R116:5785c88260b6: Naming consistency (authored by jgrulich).
Naming consistency
Fri, Nov 9, 9:48 AM
jgrulich committed R116:48df8ac573af: Minor coding style and other improvements (authored by jgrulich).
Minor coding style and other improvements
Fri, Nov 9, 9:48 AM
jgrulich committed R116:b9f37a836004: Import missing Kirigami module (authored by jgrulich).
Import missing Kirigami module
Fri, Nov 9, 9:48 AM
jgrulich committed R116:41567057e6cf: Make some other texts translatable (authored by jgrulich).
Make some other texts translatable
Fri, Nov 9, 9:48 AM
jgrulich committed R116:48bcd2205c70: IP addresses are not translatable (authored by jgrulich).
IP addresses are not translatable
Fri, Nov 9, 9:48 AM
jgrulich committed R116:fbe3657ea94f: Minor coding style improvements (authored by jgrulich).
Minor coding style improvements
Fri, Nov 9, 9:48 AM
jgrulich committed R116:265504de54f7: We definitely don't want to ignore these files (authored by jgrulich).
We definitely don't want to ignore these files
Fri, Nov 9, 9:48 AM
jgrulich committed R116:8d82198e696d: Merge branch 'master' of https://github.com/KDE/plasma-nm (authored by jgrulich).
Merge branch 'master' of https://github.com/KDE/plasma-nm
Fri, Nov 9, 9:48 AM
jgrulich committed R116:4049109a29d3: We probably want by default show only available connections (authored by jgrulich).
We probably want by default show only available connections
Fri, Nov 9, 9:48 AM
jgrulich committed R116:c59d20abb837: Fix name of the mobile proxy applet (authored by jgrulich).
Fix name of the mobile proxy applet
Fri, Nov 9, 9:48 AM
jgrulich committed R116:a81709ae9ec3: Make mobile proxy model to inherit QSortFilterProxyModel (authored by jgrulich).
Make mobile proxy model to inherit QSortFilterProxyModel
Fri, Nov 9, 9:48 AM
jgrulich committed R116:f0b20f72b32e: Minor improvements and coding style fixes (authored by jgrulich).
Minor improvements and coding style fixes
Fri, Nov 9, 9:48 AM
jgrulich committed R116:1bfff89762f2: Proxy configuration has been removed (authored by jgrulich).
Proxy configuration has been removed
Fri, Nov 9, 9:48 AM
jgrulich committed R116:c8c0f6367e2a: Minor coding style fixes (authored by jgrulich).
Minor coding style fixes
Fri, Nov 9, 9:48 AM
jgrulich committed R116:edc48c2d2add: Make security types translatable and sync names with kcm (authored by jgrulich).
Make security types translatable and sync names with kcm
Fri, Nov 9, 9:48 AM

Thu, Nov 8

jgrulich committed R838:89bedd36c08f: Do not use autoconnect flag (authored by jgrulich).
Do not use autoconnect flag
Thu, Nov 8, 10:06 AM

Wed, Nov 7

jgrulich committed R437:002f57531f78: Initialize rfb framebuffer once we obtain parameters from portal (authored by jgrulich).
Initialize rfb framebuffer once we obtain parameters from portal
Wed, Nov 7, 1:45 PM
jgrulich committed R838:98a7ebba47b0: Add support for upcoming PipeWire 0.3 (authored by jgrulich).
Add support for upcoming PipeWire 0.3
Wed, Nov 7, 1:40 PM
jgrulich committed R116:3e66c00404d0: Minor coding style improvements (authored by jgrulich).
Minor coding style improvements
Wed, Nov 7, 8:53 AM
jgrulich committed R116:389a5e195bce: Add WireGuard capability. (authored by andersonbruce).
Add WireGuard capability.
Wed, Nov 7, 8:53 AM
jgrulich closed D15093: Add WireGuard capability..
Wed, Nov 7, 8:53 AM · Plasma
jgrulich accepted D15093: Add WireGuard capability..
Wed, Nov 7, 8:33 AM · Plasma

Tue, Nov 6

jgrulich accepted D16471: Listen for added DBus interfaces instead of registered services.

Seems to work, let's push this for now and we will see if there is no regression.

Tue, Nov 6, 7:12 PM · Frameworks
jgrulich added a comment to D15093: Add WireGuard capability..

I still don't like the way how to get QPalette in the advanced dialog, can you please just simply construct it the same way you do it in the standard dialog? Other than that it looks good and I think it's ready to go. Those mentioned coding style can be fixed later, I can go through that after it's merged.

Tue, Nov 6, 11:34 AM · Plasma

Mon, Nov 5

jgrulich added a comment to D16471: Listen for added DBus interfaces instead of registered services.

Is this supposed to fix also the issue where when you log into a Plasma session, you first get a notification that it failed to activate a connection and then it gets activated successfuly?

Mon, Nov 5, 6:23 PM · Frameworks

Tue, Oct 30

jgrulich committed R282:b2244600b00c: Add missing ipv4 setting options (authored by Billy Laws <blaws05@gmail.com>).
Add missing ipv4 setting options
Tue, Oct 30, 5:29 PM
jgrulich added a comment to D16471: Listen for added DBus interfaces instead of registered services.

This is RFC because:

I'm not sure whether it's guaranteed that InterfacesAdded is emitted on service registration as well or both connections are necessary

I'm not sure about this either. I'll build it locally and try to use it for a while.

I don't know how it's possible to test this as org.kde.fakenetwork does not support the org.freedesktop.ObjectManager API

The fakenetwork stuff supports or simulates only a small portion of NM dbus, we don't currently test secret agent at all.

Tue, Oct 30, 2:00 PM · Frameworks

Mon, Oct 29

jgrulich committed R282:a17d13ddcd71: Add vxlan setting (authored by Billy Laws <blaws05@gmail.com>).
Add vxlan setting
Mon, Oct 29, 9:17 AM

Thu, Oct 18

jgrulich committed R838:6d45f5abeed8: Remove non-existing includes (authored by jgrulich).
Remove non-existing includes
Thu, Oct 18, 12:56 PM
jgrulich committed R838:530ed29aaaf6: Merge screencastcommon into waylandintegration (authored by jgrulich).
Merge screencastcommon into waylandintegration
Thu, Oct 18, 12:15 PM
jgrulich added inline comments to D15093: Add WireGuard capability..
Thu, Oct 18, 10:41 AM · Plasma

Wed, Oct 17

jgrulich added inline comments to D15093: Add WireGuard capability..
Wed, Oct 17, 11:44 AM · Plasma
jgrulich committed R116:788def2743ee: Simplify tests and make them optional (authored by jgrulich).
Simplify tests and make them optional
Wed, Oct 17, 10:37 AM
jgrulich committed R116:71833088fb26: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator (authored by andersonbruce).
Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator
Wed, Oct 17, 10:37 AM
jgrulich closed D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator.
Wed, Oct 17, 10:37 AM · Plasma
jgrulich accepted D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator.

Thanks for the contribution. I'll push this change and do just some minor changes to the tests so you don't have to again go through review.

Wed, Oct 17, 10:34 AM · Plasma
jgrulich committed R116:ea9a3207d761: Merge branch 'Plasma/5.14' (authored by jgrulich).
Merge branch 'Plasma/5.14'
Wed, Oct 17, 10:15 AM
jgrulich closed D16269: Show correct current download and upload speed.
Wed, Oct 17, 9:52 AM · Plasma
jgrulich committed R116:c5593b02df38: Show correct current download and upload speed (authored by jgrulich).
Show correct current download and upload speed
Wed, Oct 17, 9:52 AM
jgrulich added a reviewer for D16269: Show correct current download and upload speed: Plasma.
Wed, Oct 17, 8:07 AM · Plasma
jgrulich requested review of D16269: Show correct current download and upload speed.
Wed, Oct 17, 8:07 AM · Plasma

Tue, Oct 16

jgrulich committed R838:ab4ee68e9822: Improve debug and don't leak gbm handle (authored by jgrulich).
Improve debug and don't leak gbm handle
Tue, Oct 16, 10:25 AM
jgrulich committed R838:dbabcd60f33c: Make sure we don't process more frames then configured framerate (authored by jgrulich).
Make sure we don't process more frames then configured framerate
Tue, Oct 16, 10:13 AM

Oct 12 2018

jgrulich committed R838:3f8cf28dda5f: ScreenCast: properly return failure when user cancel the dialog (authored by jgrulich).
ScreenCast: properly return failure when user cancel the dialog
Oct 12 2018, 5:35 AM
jgrulich committed R838:15fdb17e37e0: ScreenCast: properly return failure when user cancel the dialog (authored by jgrulich).
ScreenCast: properly return failure when user cancel the dialog
Oct 12 2018, 5:34 AM

Oct 11 2018

jgrulich committed R838:20b720ec6243: Make initialization of drm and egl non-fatal (authored by jgrulich).
Make initialization of drm and egl non-fatal
Oct 11 2018, 11:59 AM
jgrulich committed R838:24c6010aee6f: Make initialization of drm and egl non-fatal (authored by jgrulich).
Make initialization of drm and egl non-fatal
Oct 11 2018, 9:47 AM

Oct 5 2018

jgrulich committed R256:0ccbc7165684: Give applications access to kdeglobals and dbus menu (authored by jgrulich).
Give applications access to kdeglobals and dbus menu
Oct 5 2018, 2:49 PM
jgrulich closed D15958: Give applications access to kdeglobals and dbus menu.
Oct 5 2018, 2:49 PM
jgrulich added a reviewer for D15958: Give applications access to kdeglobals and dbus menu: apol.
Oct 5 2018, 7:42 AM
jgrulich requested review of D15958: Give applications access to kdeglobals and dbus menu.
Oct 5 2018, 7:42 AM

Sep 29 2018

jgrulich added a comment to D6096: Add Wayland RemoteAccess capabilities to KRfb.

@jgrulich In my regularly-irregular wanderings I noticed you already picked up changes from this diff and that's totally okay. Should I close this?

Sep 29 2018, 5:51 PM · Plasma on Wayland

Sep 24 2018

jgrulich added a comment to D15093: Add WireGuard capability..

I agree with @ngraham, I was also planning a similar approach for other connection types.

Sep 24 2018, 8:11 AM · Plasma
jgrulich added a comment to D15521: Add validator for lists of IP addresses Added as separate review per comment from Pino on review D15093. This code will not compile without the updated code in review D15520. Also includes unit test..

Please mark this review as abandoned.

Sep 24 2018, 8:09 AM · Plasma

Sep 23 2018

jgrulich added a comment to T7785: PipeWire support in remote access to KWin.

Screen sharing works just fine with Plasma 5.13 and upcoming Plasma 5.14. There was a major issue in KWayland which will be fixed in KF5 5.51 so we might want to mention this to anyone trying screen sharing on Wayland. We still need some work to be done on KWin side to be able to share just a window, but this is not implement even in Mutter yet. I also still have to finish remote desktop support, which I didn't make to Plasma 5.14, but it will definitely be in Plasma 5.15. I did lots of rewrites in xdg-desktop-portal-kde recently and you can also get screen sharing done through remote desktop portal now. I also did changes in Krfb to support new PipeWire API and to use remote desktop portal to get screen content. What is missing is to handle input in Krfb and pass it to remote desktop portal in xdg-desktop-portal-kde where I miss to forward them to KWayland, this is still all in progress.

Sep 23 2018, 7:33 AM · Plasma (Plasma 5.14), KWin, Plasma on Wayland

Sep 20 2018

jgrulich committed R116:9e4db88fe601: Fix ampersand and other characters in tooltip (authored by jgrulich).
Fix ampersand and other characters in tooltip
Sep 20 2018, 1:57 PM
jgrulich committed R116:effee745b00e: Merge branch 'Plasma/5.13' into Plasma/5.14 (authored by jgrulich).
Merge branch 'Plasma/5.13' into Plasma/5.14
Sep 20 2018, 1:56 PM
jgrulich committed R116:9a3febeb0a21: Fix ampersand and other characters in tooltip (authored by jgrulich).
Fix ampersand and other characters in tooltip
Sep 20 2018, 1:34 PM
jgrulich committed R838:adc23c04e5ac: Fix getting application name from application desktop file (authored by jgrulich).
Fix getting application name from application desktop file
Sep 20 2018, 11:29 AM

Sep 18 2018

jgrulich added a comment to D15093: Add WireGuard capability..

Since I added a validator function for the WireGuard style keys, is there any way to assign a validator to the PasswordField widget without a fairly substantial rewrite of that class?

Sep 18 2018, 5:42 AM · Plasma

Sep 17 2018

jgrulich committed R437:a13b1e56c4da: Simplify buffer handling (authored by jgrulich).
Simplify buffer handling
Sep 17 2018, 9:32 AM
jgrulich added a comment to D15093: Add WireGuard capability..

Please, update all your reviews so they don't duplicate changes. I would personally have one review for all your IPv[4,6]Validator changes and one review just for WireGuard VPN plugin.

Sep 17 2018, 9:31 AM · Plasma
jgrulich committed R838:3bcb64592014: Merge branch 'master' of git://anongit.kde.org/xdg-desktop-portal-kde (authored by jgrulich).
Merge branch 'master' of git://anongit.kde.org/xdg-desktop-portal-kde
Sep 17 2018, 9:23 AM
jgrulich committed R838:e4a788d8ac2c: Merge branch 'jgrulich/remotedesktop' (authored by jgrulich).
Merge branch 'jgrulich/remotedesktop'
Sep 17 2018, 9:23 AM
jgrulich committed R838:98010fae711b: Merge branch 'Plasma/5.13' into Plasma/5.14 (authored by jgrulich).
Merge branch 'Plasma/5.13' into Plasma/5.14
Sep 17 2018, 9:21 AM
jgrulich committed R838:fcbbedd8eb1c: Make remote desktop portal to start screen sharing (authored by jgrulich).
Make remote desktop portal to start screen sharing
Sep 17 2018, 9:20 AM
jgrulich committed R838:4fb19e697534: Use correct stream size (authored by jgrulich).
Use correct stream size
Sep 17 2018, 9:20 AM
jgrulich added a comment to D15521: Add validator for lists of IP addresses Added as separate review per comment from Pino on review D15093. This code will not compile without the updated code in review D15520. Also includes unit test..

Maybe merge this review with D15520. I think they should go together.

Sep 17 2018, 5:54 AM · Plasma
jgrulich added inline comments to D15521: Add validator for lists of IP addresses Added as separate review per comment from Pino on review D15093. This code will not compile without the updated code in review D15520. Also includes unit test..
Sep 17 2018, 5:52 AM · Plasma

Sep 13 2018

jgrulich committed R437:8f198a0979b9: Wayland initialization can be removed (authored by jgrulich).
Wayland initialization can be removed
Sep 13 2018, 12:38 PM
jgrulich committed R437:3985fa8e0eaf: Make screen sharing work through remote desktop portal (authored by jgrulich).
Make screen sharing work through remote desktop portal
Sep 13 2018, 12:36 PM
jgrulich committed R437:c7ff786dcd04: Do not check for running portal as it can be started automatically (authored by jgrulich).
Do not check for running portal as it can be started automatically
Sep 13 2018, 12:36 PM
jgrulich committed R116:0491738ced86: Make sure we change icon on NM connectivity change (authored by jgrulich).
Make sure we change icon on NM connectivity change
Sep 13 2018, 11:46 AM
jgrulich committed R116:340e0d26e370: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Sep 13 2018, 11:26 AM
jgrulich committed R116:a71ca963f798: Make sure we change icon on NM connectivity change (authored by jgrulich).
Make sure we change icon on NM connectivity change
Sep 13 2018, 11:26 AM

Sep 12 2018

jgrulich committed R838:da725066d8fe: Move some stream related code from screencast portal to screencast stream (authored by jgrulich).
Move some stream related code from screencast portal to screencast stream
Sep 12 2018, 1:44 PM
jgrulich committed R838:31363e46940a: Add ScreenCastWidget to CMakeLists (authored by jgrulich).
Add ScreenCastWidget to CMakeLists
Sep 12 2018, 1:44 PM
jgrulich committed R838:995066dd8b84: Make separated widget with screens to be shared with remote desktop dialog (authored by jgrulich).
Make separated widget with screens to be shared with remote desktop dialog
Sep 12 2018, 1:44 PM
jgrulich committed R838:760170e90fed: Use correct stream size (authored by jgrulich).
Use correct stream size
Sep 12 2018, 1:44 PM

Sep 11 2018

jgrulich added a comment to D15422: [server] Fix remote access buffer handling when output not bound.

Both versions solve issue I have and KWin no longer opens dozens of fds and abort when reaches the limit.

Sep 11 2018, 1:24 PM · Frameworks

Sep 10 2018

jgrulich committed R838:531a7e72dd4a: Move Wayland integration bits into separated class so they can be shared… (authored by jgrulich).
Move Wayland integration bits into separated class so they can be shared…
Sep 10 2018, 11:49 AM

Sep 6 2018

jgrulich committed R838:cd513b72f4ec: Initial work on remote desktop (authored by jgrulich).
Initial work on remote desktop
Sep 6 2018, 12:40 PM
jgrulich committed R838:ddd12bc744bc: Merge branch 'Plasma/5.13' (authored by jgrulich).
Merge branch 'Plasma/5.13'
Sep 6 2018, 12:40 PM
jgrulich committed R838:8c06afa97a64: We don't need to link against libspa (authored by jgrulich).
We don't need to link against libspa
Sep 6 2018, 12:40 PM

Sep 5 2018

jgrulich accepted D15297: Use QOverload to select overloaded functions.
Sep 5 2018, 3:27 PM · Plasma
jgrulich added a comment to D15093: Add WireGuard capability..

Does wg-quick support both, like simple commands and script files? If so, we should support both as well, if it supports only commands/snippets, we should leave it as it is.

.....
Given this new information as well as the fact that there is a disconnect between what wg-quick wants and what the NM addon takes in, most notably, wg-quick specifically accepts multiple instances of each but the NM addon only allows one line of input.

I would therefore propose that I remove all of the Pre/Post Up/Down entries for now since they won't do anything anyway and worry about adding them back in if the NM addon implements them properly and then match its implementation.

Sep 5 2018, 10:32 AM · Plasma
jgrulich committed R437:1bcc2a179498: Support PW 0.2+ and do not link against libspa (authored by jgrulich).
Support PW 0.2+ and do not link against libspa
Sep 5 2018, 8:07 AM
jgrulich added a comment to D15093: Add WireGuard capability..

I think you can completely remove WireguardAuth dialog if there is no use for it. I also spotted few trailing spaces in the patch, please remove them.

Sep 5 2018, 7:35 AM · Plasma
jgrulich added a comment to D15093: Add WireGuard capability..
In D15093#319253, @pino wrote:

Much better now!

  • regarding the UI for all the pre/post scripts: since they are file paths, better use a KUrlRequester widget (limited to local existing files only, no URLs), so the users have a Browse button next to each line edit that can be used to open a file dialog

I debated with myself when I started this whether to include these at all. They are included in the base NetworkManager implementation which "inherited" them from the underlying wg-quick command but they duplicate functionality that NM provides directly and it seems to me that if someone is using NM then they can use those methods instead. Also, wg-quick specifies these as "script snippets" meaning actual direct commands that are executed by bash not necessarily a shell script. It also specifies that there can be multiple instances of each, a capability that the base NM implementation does not support. So my quandary is, do I implement this like the base NM does and possibly, as you suggest, force it to be a single shell script which sort of violates the spirit of the wg-quick command or do I delete it completely and not support something that base NM does, or do I leave it like it is?

Personally I think that the base NM should get rid of these and force users to rely on the capability in NM to perform pre and post operations but given what exists, I don't think any of the alternatives are good and I'm not sure what the "least bad" solution is. If someone uses nm-connection-editor and enters something which is not a script and then opens the connection in a plasma-nm interface which only supports a file, I'm not sure what will happen. On the other hand if I delete the fields completely and open something created in nm-connection-editor with these fields, that's not good either.

Since I initially was doing this only for my own use and was probably going to use NM for this, I admit that I took the easiest way out and duplicated what base NM has, which is a single string which can contain a shell script but also a snippet as the base WireGuard does and then said in the tool-tip that it was preferable to use NM capability instead.

If you as a representative of the plasma-nm philosophy have a preference on which way to go or have a brilliant idea which solves all the problems, I will follow your lead.

Sep 5 2018, 7:10 AM · Plasma

Sep 4 2018

jgrulich committed R838:77c9ec54a612: Fix build condition for screencast portal (authored by jgrulich).
Fix build condition for screencast portal
Sep 4 2018, 10:08 AM

Sep 3 2018

jgrulich added inline comments to D15093: Add WireGuard capability..
Sep 3 2018, 6:26 AM · Plasma

Aug 31 2018

jgrulich committed R116:4a12cae5065a: Merge branch 'master' into plasma-kcm (authored by jgrulich).
Merge branch 'master' into plasma-kcm
Aug 31 2018, 11:22 AM
jgrulich committed R116:5080db87ce24: Add missing includes and frameworks (authored by jgrulich).
Add missing includes and frameworks
Aug 31 2018, 9:31 AM
jgrulich committed R116:e72304fbaf66: Merge branch 'master' into plasma-kcm (authored by jgrulich).
Merge branch 'master' into plasma-kcm
Aug 31 2018, 9:31 AM