jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (220 w, 3 d)
Availability
Available

Recent Activity

Today

jgrulich committed R257:9ab7f1d56345: Add KIO extension point (authored by jgrulich).
Add KIO extension point
Thu, Nov 14, 10:54 AM
jgrulich added a comment to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.

You are right, I didn't properly read what you do. I still think we should modify the already existing function to additionaly save the previous state, because most of the code is same. The only difference is "Set" vs "Get" method on DBus.

Thu, Nov 14, 7:41 AM · Plasma

Yesterday

jgrulich added a comment to D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before.

There is already a method to enable/disable BT, why don't you reuse it?

Wed, Nov 13, 9:10 AM · Plasma

Wed, Nov 6

jgrulich committed R437:b8861cd22970: Merge branch 'Applications/19.08' (authored by jgrulich).
Merge branch 'Applications/19.08'
Wed, Nov 6, 1:52 PM
jgrulich committed R437:80db244c7ddd: Un-break portal support (authored by jgrulich).
Un-break portal support
Wed, Nov 6, 1:51 PM
jgrulich closed D25167: Un-break portal support.
Wed, Nov 6, 1:51 PM
jgrulich added a reviewer for D25167: Un-break portal support: apol.
Wed, Nov 6, 11:07 AM
jgrulich requested review of D25167: Un-break portal support.
Wed, Nov 6, 11:05 AM
jgrulich committed R838:db12a964b139: Un-break remote input portal (authored by apol).
Un-break remote input portal
Wed, Nov 6, 11:03 AM

Tue, Nov 5

jgrulich committed R257:14eb56552e20: Another attempt to fix qtwebengine build (authored by jgrulich).
Another attempt to fix qtwebengine build
Tue, Nov 5, 2:36 PM
jgrulich committed R257:1f49574f5fa4: Another attempt to fix qtwebengine build (authored by jgrulich).
Another attempt to fix qtwebengine build
Tue, Nov 5, 1:04 PM
jgrulich added a comment to D24866: Wired setting: improve handling of link negotiation.

Looks like a complete fix to #413211. I've tested it on Arch Linux with different modes. For me Ignore, Auto and 10/100/1000 Mbps modes worked as intended as well as duplex setup for 10 and 100.

The only questionable thing is an ability to set Half duplex for 1Gbps and 10 Gbps. The first one is virtually never used IRL (and does not work for some (I guess many) NIC's, and the second one is absent in the standard and therefore unlikely to be found anywhere. NetworkManager saves these values and silently ignores it's unabilty to apply them to the hardware.

Tue, Nov 5, 8:13 AM · Plasma

Thu, Oct 31

jgrulich committed R257:15a5efc4b7a0: Attempt to fix python installation (authored by jgrulich).
Attempt to fix python installation
Thu, Oct 31, 3:04 PM

Sat, Oct 26

jgrulich committed R257:be4d1a0b49f7: Disable debuginfo for python 2.7 (authored by jgrulich).
Disable debuginfo for python 2.7
Sat, Oct 26, 6:48 AM

Fri, Oct 25

jgrulich committed R257:b040a9f7750e: Drop dependencies which are already in runtime (authored by jgrulich).
Drop dependencies which are already in runtime
Fri, Oct 25, 3:38 PM
jgrulich committed R257:2c92cf10b695: Update and fix python installation (authored by jgrulich).
Update and fix python installation
Fri, Oct 25, 12:51 PM
jgrulich committed R257:cd2b1b6db390: Fix json syntax (authored by jgrulich).
Fix json syntax
Fri, Oct 25, 10:55 AM
jgrulich committed R257:500fad52247c: Add qtwebengine (authored by jgrulich).
Add qtwebengine
Fri, Oct 25, 10:53 AM
jgrulich accepted D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid.
Fri, Oct 25, 10:41 AM · Plasma
jgrulich requested changes to D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid.
Fri, Oct 25, 4:52 AM · Plasma
jgrulich committed R838:c85055441a22: Rewrite AppChooser dialog (authored by jgrulich).
Rewrite AppChooser dialog
Fri, Oct 25, 4:49 AM
jgrulich closed D24732: Rewrite AppChooser dialog.
Fri, Oct 25, 4:49 AM · Plasma

Thu, Oct 24

jgrulich added a comment to D24927: Use updateItem.

I just pushed the very same change so you don't need to do the review. Can be closed then.

Thu, Oct 24, 3:36 PM · Plasma
jgrulich committed R116:a2825eb323e8: Use updateItem() function instead of doing manuall work (authored by jgrulich).
Use updateItem() function instead of doing manuall work
Thu, Oct 24, 3:35 PM
jgrulich accepted D24924: Don't reset model when adding an active connection.
Thu, Oct 24, 3:33 PM · Plasma
jgrulich committed R116:c3291119b359: Add curly braces for consistency (authored by jgrulich).
Add curly braces for consistency
Thu, Oct 24, 3:33 PM
jgrulich accepted D24919: Don't reset model when device state changes.
Thu, Oct 24, 3:32 PM · Plasma
jgrulich requested changes to D24919: Don't reset model when device state changes.
Thu, Oct 24, 3:28 PM · Plasma
jgrulich added a comment to D24924: Don't reset model when adding an active connection.

Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically.

Thu, Oct 24, 3:21 PM · Plasma
jgrulich requested changes to D24924: Don't reset model when adding an active connection.

Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically.

Thu, Oct 24, 3:20 PM · Plasma
jgrulich accepted D24924: Don't reset model when adding an active connection.
Thu, Oct 24, 3:19 PM · Plasma
jgrulich accepted D24923: Use more return early.
Thu, Oct 24, 3:10 PM · Plasma
jgrulich requested changes to D24924: Don't reset model when adding an active connection.
Thu, Oct 24, 3:08 PM · Plasma
jgrulich requested changes to D24919: Don't reset model when device state changes.
Thu, Oct 24, 3:08 PM · Plasma
jgrulich accepted D24919: Don't reset model when device state changes.
Thu, Oct 24, 3:07 PM · Plasma
jgrulich accepted D24922: Don't reset model when available connection appears.
Thu, Oct 24, 3:05 PM · Plasma
jgrulich accepted D24920: Add missing role changes.
Thu, Oct 24, 3:05 PM · Plasma
jgrulich accepted D24924: Don't reset model when adding an active connection.
Thu, Oct 24, 3:04 PM · Plasma
jgrulich added a comment to D24732: Rewrite AppChooser dialog.

There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle.

Thu, Oct 24, 12:33 PM · Plasma
jgrulich updated the diff for D24732: Rewrite AppChooser dialog.
  • Add border around the view and use small radius around for item highlight
Thu, Oct 24, 12:32 PM · Plasma
jgrulich accepted D24910: Fix build.

You could just push this without me doing review :).

Thu, Oct 24, 10:34 AM · Plasma
jgrulich accepted D24905: Use return early.
Thu, Oct 24, 10:24 AM · Plasma
jgrulich requested changes to D24905: Use return early.
Thu, Oct 24, 10:14 AM · Plasma
jgrulich added a comment to D24905: Use return early.

I think all of thise breaks in loops must be continues?

Thu, Oct 24, 8:16 AM · Plasma
jgrulich accepted D24905: Use return early.
Thu, Oct 24, 5:28 AM · Plasma
jgrulich accepted D24897: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection.
Thu, Oct 24, 5:25 AM · Plasma
jgrulich accepted D24899: Remove commented out code.
Thu, Oct 24, 5:25 AM · Plasma
jgrulich accepted D24900: [mobile/wifi] Remove special font style for active connection.
Thu, Oct 24, 5:24 AM · Plasma
jgrulich accepted D24903: Don't reset model when activeconnectionstate changed.
Thu, Oct 24, 5:24 AM · Plasma

Wed, Oct 23

jgrulich accepted D24888: Rename kded Networkmanagement -> Network Management.
Wed, Oct 23, 1:01 PM · Plasma
jgrulich added a comment to D24732: Rewrite AppChooser dialog.

There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle.

Wed, Oct 23, 8:31 AM · Plasma

Tue, Oct 22

jgrulich added a comment to D24732: Rewrite AppChooser dialog.

Updated screenshot:

Tue, Oct 22, 2:12 PM · Plasma
jgrulich updated the test plan for D24866: Wired setting: improve handling of link negotiation.
Tue, Oct 22, 1:55 PM · Plasma
jgrulich added a reviewer for D24866: Wired setting: improve handling of link negotiation: Plasma.
Tue, Oct 22, 1:53 PM · Plasma
jgrulich requested review of D24866: Wired setting: improve handling of link negotiation.
Tue, Oct 22, 1:52 PM · Plasma
jgrulich committed R127:b12b919307d9: FakeInput: add support for keyboard key press and release (authored by jgrulich).
FakeInput: add support for keyboard key press and release
Tue, Oct 22, 11:29 AM
jgrulich committed R108:3faeb543a7a2: Add support for keyboard key press and release from fake input protocol (authored by jgrulich).
Add support for keyboard key press and release from fake input protocol
Tue, Oct 22, 11:25 AM
jgrulich closed D23769: Add support for keyboard key press and release from fake input protocol.
Tue, Oct 22, 11:25 AM · KWin
jgrulich closed D23766: FakeInput: add support for keyboard key press and release.
Tue, Oct 22, 11:24 AM · Frameworks
jgrulich updated the diff for D24732: Rewrite AppChooser dialog.
  • Add Kirigami2 as a dependency
Tue, Oct 22, 7:49 AM · Plasma
jgrulich updated the diff for D24732: Rewrite AppChooser dialog.
  • Code improvements
Tue, Oct 22, 7:48 AM · Plasma
jgrulich added a comment to D23766: FakeInput: add support for keyboard key press and release.
In D23766#533644, @apol wrote:

The patch looks good to me, is there a reason why it wasn't accepted?

Tue, Oct 22, 6:59 AM · Frameworks
jgrulich accepted D24808: [mobile/wifi] Group networks by connection state.
Tue, Oct 22, 5:56 AM · Plasma

Mon, Oct 21

jgrulich added a comment to D20132: Actually make the network list view show up.

Can we drop this request? I believe it works just fine now.

Mon, Oct 21, 12:27 PM · Plasma
jgrulich accepted D22201: [mobile/wifi] Rework NetworkSetting header.
Mon, Oct 21, 12:26 PM · Plasma
jgrulich added a comment to D24732: Rewrite AppChooser dialog.

So close! You don't need to create a Rectangle to give the ScrollView a white background; just set Component.onCompleted: background.visible = true on the scrollview itself. Here's an example of how it's done in the Notifications KCM: https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n94

Mon, Oct 21, 4:12 AM · Plasma

Sun, Oct 20

jgrulich updated the diff for D24732: Rewrite AppChooser dialog.
  • Improvements based on review comments
Sun, Oct 20, 6:03 PM · Plasma
jgrulich committed R116:68ea715fafae: Merge branch 'Plasma/5.17' (authored by jgrulich).
Merge branch 'Plasma/5.17'
Sun, Oct 20, 5:44 PM
jgrulich committed R116:14f7ab5e3c68: Wired connection: default to Full duplex when duplex is not set BUG: 413211 (authored by jgrulich).
Wired connection: default to Full duplex when duplex is not set BUG: 413211
Sun, Oct 20, 5:39 PM
jgrulich added inline comments to D24808: [mobile/wifi] Group networks by connection state.
Sun, Oct 20, 5:30 PM · Plasma

Fri, Oct 18

jgrulich added a comment to D24732: Rewrite AppChooser dialog.

On my system, it's at /usr/lib64/libexec/xdg-desktop-portal-kde. I tried overriding that file with the one I just built from source (because it didn't seem to use the built-from-source one at ~/kde/usr/lib64/libexec/xdg-desktop-portal-kde) but even then, I still get the old dialog in the Flatpak version of Dolphin. What am I doing wrong here?

Fri, Oct 18, 1:06 PM · Plasma
jgrulich added a comment to D24732: Rewrite AppChooser dialog.

Finally, I would consider adding the "Other applications are available in Discover" text to the bottom, so it doesn't interrupt the dialog's flow.

Fri, Oct 18, 8:11 AM · Plasma
jgrulich updated the diff for D24732: Rewrite AppChooser dialog.

Address review comments

Fri, Oct 18, 8:10 AM · Plasma
jgrulich added a comment to D24732: Rewrite AppChooser dialog.

Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller:

Also why are there duplicates in here?

Fri, Oct 18, 5:17 AM · Plasma

Thu, Oct 17

jgrulich added a comment to D24732: Rewrite AppChooser dialog.

Use Dolphin from Flathub to open some file.

Thu, Oct 17, 5:04 PM · Plasma
jgrulich committed R282:4a6a5e708077: Add support for SAE authentication used by WPA3 (authored by jgrulich).
Add support for SAE authentication used by WPA3
Thu, Oct 17, 3:06 PM
jgrulich closed D24689: Add support for SAE authentication used by WPA3.
Thu, Oct 17, 3:06 PM · Frameworks
jgrulich updated the diff for D24689: Add support for SAE authentication used by WPA3.
  • Coding style
Thu, Oct 17, 3:05 PM · Frameworks
jgrulich updated the diff for D24691: Add support for WPA3.

Simplify code

Thu, Oct 17, 3:02 PM · Plasma
jgrulich added a comment to D24732: Rewrite AppChooser dialog.

Is this better?

Thu, Oct 17, 1:56 PM · Plasma
jgrulich updated the diff for D24732: Rewrite AppChooser dialog.

Add text to the button rather then using tooltip

Thu, Oct 17, 1:55 PM · Plasma
jgrulich added a comment to D24732: Rewrite AppChooser dialog.

I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps

Thu, Oct 17, 1:52 PM · Plasma
jgrulich added a comment to D24732: Rewrite AppChooser dialog.

This is the initial state of the dialog, which presents only apps associated with given mimetype. Then if you click at the button below, it will show all the apps and provide a search bar.

Thu, Oct 17, 1:46 PM · Plasma
jgrulich added a reviewer for D24732: Rewrite AppChooser dialog: Plasma.
Thu, Oct 17, 1:43 PM · Plasma
jgrulich updated the diff for D24732: Rewrite AppChooser dialog.

Do not duplicate desktop files

Thu, Oct 17, 1:41 PM · Plasma
jgrulich requested review of D24732: Rewrite AppChooser dialog.
Thu, Oct 17, 1:30 PM · Plasma
jgrulich accepted D23578: Before requesting a scan, check the time threshold.

Alright, I believe you are correct.

Thu, Oct 17, 10:14 AM · Plasma

Wed, Oct 16

jgrulich updated the diff for D24691: Add support for WPA3.

Drop cmake change

Wed, Oct 16, 11:28 AM · Plasma
jgrulich added a dependent revision for D24689: Add support for SAE authentication used by WPA3: D24691: Add support for WPA3.
Wed, Oct 16, 11:28 AM · Frameworks
jgrulich added a dependency for D24691: Add support for WPA3: D24689: Add support for SAE authentication used by WPA3.
Wed, Oct 16, 11:28 AM · Plasma
jgrulich requested review of D24691: Add support for WPA3.
Wed, Oct 16, 11:27 AM · Plasma
jgrulich added a reviewer for D24689: Add support for SAE authentication used by WPA3: Frameworks.
Wed, Oct 16, 9:37 AM · Frameworks
jgrulich updated the diff for D24689: Add support for SAE authentication used by WPA3.

Compare against lowercase value

Wed, Oct 16, 9:37 AM · Frameworks
jgrulich requested review of D24689: Add support for SAE authentication used by WPA3.
Wed, Oct 16, 9:35 AM · Frameworks
jgrulich accepted D24654: [Notifications] Don't bind model inside headerItem.
Wed, Oct 16, 5:54 AM · Plasma

Oct 7 2019

jgrulich accepted D24452: Un-break remote input portal.
Oct 7 2019, 9:21 AM · Plasma

Sep 18 2019

jgrulich committed R257:f41edbbb7564: Remove dconf access, should be handled now through portal (authored by jgrulich).
Remove dconf access, should be handled now through portal
Sep 18 2019, 12:30 PM
jgrulich committed R257:b717ed993e22: Replace html5-codecs with correct extension (authored by jgrulich).
Replace html5-codecs with correct extension
Sep 18 2019, 11:47 AM
jgrulich committed R257:e776094bd85b: html5-codecs extension no longer exists (authored by jgrulich).
html5-codecs extension no longer exists
Sep 18 2019, 11:24 AM
jgrulich added inline comments to D23578: Before requesting a scan, check the time threshold.
Sep 18 2019, 7:35 AM · Plasma