- User Since
- Aug 24 2015, 11:06 AM (168 w, 1 d)
Fri, Nov 9
Thu, Nov 8
Wed, Nov 7
Tue, Nov 6
Seems to work, let's push this for now and we will see if there is no regression.
I still don't like the way how to get QPalette in the advanced dialog, can you please just simply construct it the same way you do it in the standard dialog? Other than that it looks good and I think it's ready to go. Those mentioned coding style can be fixed later, I can go through that after it's merged.
Mon, Nov 5
Is this supposed to fix also the issue where when you log into a Plasma session, you first get a notification that it failed to activate a connection and then it gets activated successfuly?
Tue, Oct 30
This is RFC because:
I'm not sure whether it's guaranteed that InterfacesAdded is emitted on service registration as well or both connections are necessary
I'm not sure about this either. I'll build it locally and try to use it for a while.
I don't know how it's possible to test this as org.kde.fakenetwork does not support the org.freedesktop.ObjectManager API
The fakenetwork stuff supports or simulates only a small portion of NM dbus, we don't currently test secret agent at all.
Mon, Oct 29
Thu, Oct 18
Wed, Oct 17
Thanks for the contribution. I'll push this change and do just some minor changes to the tests so you don't have to again go through review.
Tue, Oct 16
Oct 12 2018
Oct 11 2018
Oct 5 2018
Sep 29 2018
Sep 24 2018
I agree with @ngraham, I was also planning a similar approach for other connection types.
Please mark this review as abandoned.
Sep 23 2018
Screen sharing works just fine with Plasma 5.13 and upcoming Plasma 5.14. There was a major issue in KWayland which will be fixed in KF5 5.51 so we might want to mention this to anyone trying screen sharing on Wayland. We still need some work to be done on KWin side to be able to share just a window, but this is not implement even in Mutter yet. I also still have to finish remote desktop support, which I didn't make to Plasma 5.14, but it will definitely be in Plasma 5.15. I did lots of rewrites in xdg-desktop-portal-kde recently and you can also get screen sharing done through remote desktop portal now. I also did changes in Krfb to support new PipeWire API and to use remote desktop portal to get screen content. What is missing is to handle input in Krfb and pass it to remote desktop portal in xdg-desktop-portal-kde where I miss to forward them to KWayland, this is still all in progress.
Sep 20 2018
Sep 18 2018
Sep 17 2018
Please, update all your reviews so they don't duplicate changes. I would personally have one review for all your IPv[4,6]Validator changes and one review just for WireGuard VPN plugin.
Maybe merge this review with D15520. I think they should go together.
Sep 13 2018
Sep 12 2018
Sep 11 2018
Both versions solve issue I have and KWin no longer opens dozens of fds and abort when reaches the limit.
Sep 10 2018
Sep 6 2018
Sep 5 2018
I think you can completely remove WireguardAuth dialog if there is no use for it. I also spotted few trailing spaces in the patch, please remove them.