jgrulich (Jan Grulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 11:06 AM (178 w, 1 d)
Availability
Available

Recent Activity

Fri, Jan 18

jgrulich accepted D18364: [build] Search for kirigami as a runtime dependency.
Fri, Jan 18, 1:42 PM · Plasma

Thu, Jan 17

jgrulich added a comment to D18114: FakeInput: add support for pointer move with absolute coordinates.

Hi, can I get please this re-approved? It's now just again about the additional mouse support.

Thu, Jan 17, 7:57 AM · Frameworks

Thu, Jan 10

jgrulich added a comment to D18115: Add support for fake pointer move with absolute coordinates.

Just for the info, this will need to be pushed once Plasma 5.15 is branched, because it introduces dependency on KDE Frameworks 5.55.

Thu, Jan 10, 9:30 AM · KWin
jgrulich committed R437:6c44260016ca: Implement mouse support (authored by jgrulich).
Implement mouse support
Thu, Jan 10, 8:26 AM
jgrulich committed R838:5f64fb5bbd4e: Merge branch 'master' into remote-desktop (authored by jgrulich).
Merge branch 'master' into remote-desktop
Thu, Jan 10, 7:59 AM
jgrulich committed R838:ecf84c4626c9: Implement mouse support (authored by jgrulich).
Implement mouse support
Thu, Jan 10, 7:57 AM
jgrulich retitled D18115: Add support for fake pointer move with absolute coordinates from Add support for fake pointer move with absolute coordinates and keyboard key press and release to Add support for fake pointer move with absolute coordinates.
Thu, Jan 10, 5:55 AM · KWin
jgrulich updated the diff for D18115: Add support for fake pointer move with absolute coordinates.

Drop keyboard support

Thu, Jan 10, 5:55 AM · KWin
jgrulich updated the summary of D18114: FakeInput: add support for pointer move with absolute coordinates.
Thu, Jan 10, 5:54 AM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Drop keyboard support from this review

Thu, Jan 10, 5:53 AM · Frameworks

Wed, Jan 9

jgrulich committed R257:a029f2957e94: Include missing patch (authored by jgrulich).
Include missing patch
Wed, Jan 9, 5:26 PM
jgrulich committed R257:0a49ddc60e41: Avoid requiring kernel 3.17.0+ (authored by jgrulich).
Avoid requiring kernel 3.17.0+
Wed, Jan 9, 5:24 PM
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Fix documentation

Wed, Jan 9, 4:08 PM · Frameworks
jgrulich added a comment to D18114: FakeInput: add support for pointer move with absolute coordinates.

I didn't intent to push this together, but when creating a branch from master which already had first round of changes caused my second part of changes to be pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to get exception from David Faure to include this with KDE Frameworks 5.54. I thought the tagging is this saturday and tarballs are made after that, but I was wrong. I would really like to push the remote desktop support into Plasma 5.15, I have almost complete support in xdg-desktop-portal-kde and krfb.

Wed, Jan 9, 3:48 PM · Frameworks
jgrulich retitled D18115: Add support for fake pointer move with absolute coordinates from Add support for fake pointer move with absolute coordinates to Add support for fake pointer move with absolute coordinates and keyboard key press and release.
Wed, Jan 9, 3:39 PM · KWin
jgrulich updated the diff for D18115: Add support for fake pointer move with absolute coordinates.

Add support for keyboard key press and release

Wed, Jan 9, 3:39 PM · KWin
jgrulich updated the summary of D18114: FakeInput: add support for pointer move with absolute coordinates.
Wed, Jan 9, 3:38 PM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Add support for keyboard key press and release

Wed, Jan 9, 3:37 PM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Bump fake interface version

Wed, Jan 9, 3:16 PM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Coding style

Wed, Jan 9, 1:00 PM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Fix review comments

Wed, Jan 9, 12:50 PM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Adress review comments

Wed, Jan 9, 12:37 PM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Add information when new methods were introduced and bump version of FakeInput in registry

Wed, Jan 9, 11:37 AM · Frameworks
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Revert unwanted changes in CMakeLists

Wed, Jan 9, 10:08 AM · Frameworks
jgrulich updated the diff for D18115: Add support for fake pointer move with absolute coordinates.

Update to reflect KWayland changes

Wed, Jan 9, 6:46 AM · KWin
jgrulich updated the diff for D18114: FakeInput: add support for pointer move with absolute coordinates.

Use QPointF instead of QSizeF and bump interface version

Wed, Jan 9, 6:45 AM · Frameworks

Tue, Jan 8

jgrulich added a dependent revision for D18114: FakeInput: add support for pointer move with absolute coordinates: D18115: Add support for fake pointer move with absolute coordinates.
Tue, Jan 8, 6:18 PM · Frameworks
jgrulich requested review of D18115: Add support for fake pointer move with absolute coordinates.
Tue, Jan 8, 6:18 PM · KWin
jgrulich added a reviewer for D18114: FakeInput: add support for pointer move with absolute coordinates: davidedmundson.
Tue, Jan 8, 6:16 PM · Frameworks
jgrulich requested review of D18114: FakeInput: add support for pointer move with absolute coordinates.
Tue, Jan 8, 6:15 PM · Frameworks

Mon, Jan 7

jgrulich committed R116:b8f580a749f8: Allow the use of One-Time Password (authored by enriquem).
Allow the use of One-Time Password
Mon, Jan 7, 11:49 AM
jgrulich closed D17834: Allow the use of One-Time Password.
Mon, Jan 7, 11:48 AM · Plasma
jgrulich accepted D17834: Allow the use of One-Time Password.
Mon, Jan 7, 11:45 AM · Plasma

Sun, Jan 6

jgrulich added a comment to D17834: Allow the use of One-Time Password.

It doesn't build now, can you please fix that?

Sun, Jan 6, 10:26 AM · Plasma

Sat, Jan 5

jgrulich added inline comments to D17834: Allow the use of One-Time Password.
Sat, Jan 5, 6:29 PM · Plasma
jgrulich added a comment to D17834: Allow the use of One-Time Password.

I implemented all of your comments except one. I created a new VPN setting wit nm-connection-editor, and it sets it to 0, that is, to NetworkManager::Setting::None. Thus, I believe that part is correct.

Sat, Jan 5, 3:27 PM · Plasma

Fri, Jan 4

jgrulich added inline comments to D17834: Allow the use of One-Time Password.
Fri, Jan 4, 7:57 AM · Plasma

Thu, Jan 3

jgrulich added a comment to D17834: Allow the use of One-Time Password.

Can you please work with "otp-flags" same way we work with "password-flags"? You work with it as with string, it would be more readable if you use NetworkManager::Setting::SecretFlags.

Thu, Jan 3, 8:49 AM · Plasma

Fri, Dec 28

jgrulich added a comment to D17834: Allow the use of One-Time Password.

I don't think this is a complete support for this. You need to add support into the auth-dialog as well, without it the connection would expect an otp password, but there will be no way how to provide it.

Fri, Dec 28, 6:26 PM · Plasma

Tue, Dec 25

jgrulich committed R838:57b21790f452: Set parent window for remote desktop dialog (authored by jgrulich).
Set parent window for remote desktop dialog
Tue, Dec 25, 7:28 PM
jgrulich committed R838:f715cc4aee3f: Set parent window for dialogs (authored by volkov).
Set parent window for dialogs
Tue, Dec 25, 7:28 PM

Sun, Dec 23

jgrulich committed R838:66eb2fe654b9: Add workaround for gtk file chooser filter patterns (authored by jgrulich).
Add workaround for gtk file chooser filter patterns
Sun, Dec 23, 1:30 PM
jgrulich closed D17677: Add workaround for gtk file chooser filter patterns.
Sun, Dec 23, 1:30 PM · Plasma

Dec 23 2018

jgrulich added a comment to D17677: Add workaround for gtk file chooser filter patterns.

David, can you accept this revision then? I'll push it to Plasma/5.14 branch only.

Dec 23 2018, 10:19 AM · Plasma
jgrulich accepted D17743: Extend getExtensionFromPatternList reg exp filtering.
Dec 23 2018, 10:18 AM · Frameworks
jgrulich committed R838:9f0c704e96ea: Use KFileWidget instead of QFileDialog (authored by jgrulich).
Use KFileWidget instead of QFileDialog
Dec 23 2018, 10:17 AM
jgrulich closed D17738: Use KFileWidget instead of QFileDialog.
Dec 23 2018, 10:17 AM · Plasma

Dec 22 2018

jgrulich added a comment to D17738: Use KFileWidget instead of QFileDialog.

Yes, it does work with your patch, thank you for that and sorry for my laziness.

Dec 22 2018, 8:28 PM · Plasma
jgrulich updated the diff for D17738: Use KFileWidget instead of QFileDialog.

Use QScopedPointer for file dialogs

Dec 22 2018, 8:26 PM · Plasma
jgrulich added a comment to D17677: Add workaround for gtk file chooser filter patterns.

but the "automatic extension" feature will add the file extension unmodified

Can you expand on what this means.

Dec 22 2018, 5:06 PM · Plasma
jgrulich added a comment to D17738: Use KFileWidget instead of QFileDialog.

This still doesn't resolve bug 399889 so review https://phabricator.kde.org/D17677 will be still needed.

Dec 22 2018, 5:03 PM · Plasma
jgrulich reclaimed D17677: Add workaround for gtk file chooser filter patterns.
Dec 22 2018, 5:02 PM · Plasma
jgrulich requested review of D17738: Use KFileWidget instead of QFileDialog.
Dec 22 2018, 5:01 PM · Plasma
jgrulich added a comment to D17677: Add workaround for gtk file chooser filter patterns.

I have now a new version using KFileWidget and it still suffers from the same problem. It does filter properly when I use regexp, but the "automatic extension" feature will add the file extension unmodified so it results into the same problem. It looks that my workaround will be needed anyway.

Dec 22 2018, 4:47 PM · Plasma
jgrulich added a comment to D17677: Add workaround for gtk file chooser filter patterns.

Is there a new version of this patch somewhere else?

Dec 22 2018, 8:36 AM · Plasma

Dec 21 2018

jgrulich abandoned D17677: Add workaround for gtk file chooser filter patterns.
Dec 21 2018, 9:09 AM · Plasma

Dec 20 2018

jgrulich added inline comments to D17677: Add workaround for gtk file chooser filter patterns.
Dec 20 2018, 12:01 PM · Plasma

Dec 19 2018

jgrulich committed R437:fb0bb4a3c9fb: Obtain allowed devices from remote desktop portal (authored by jgrulich).
Obtain allowed devices from remote desktop portal
Dec 19 2018, 3:24 PM
jgrulich committed R838:844716dcdc4a: Remote desktop: implement missing device selection (authored by jgrulich).
Remote desktop: implement missing device selection
Dec 19 2018, 3:16 PM
jgrulich updated the summary of D17677: Add workaround for gtk file chooser filter patterns.
Dec 19 2018, 3:02 PM · Plasma
jgrulich added inline comments to D17677: Add workaround for gtk file chooser filter patterns.
Dec 19 2018, 1:46 PM · Plasma
jgrulich updated the diff for D17677: Add workaround for gtk file chooser filter patterns.

Allow also patterns like '*.ab[cC]de[fF]'

Dec 19 2018, 9:57 AM · Plasma
jgrulich updated the diff for D17677: Add workaround for gtk file chooser filter patterns.

Be more specific about the pattern

Dec 19 2018, 9:44 AM · Plasma
jgrulich updated the summary of D17677: Add workaround for gtk file chooser filter patterns.
Dec 19 2018, 9:33 AM · Plasma
jgrulich added a reviewer for D17677: Add workaround for gtk file chooser filter patterns: broulik.
Dec 19 2018, 9:27 AM · Plasma
jgrulich requested review of D17677: Add workaround for gtk file chooser filter patterns.
Dec 19 2018, 9:26 AM · Plasma

Dec 17 2018

jgrulich committed R116:48e5c8079c86: Merge branch 'Plasma/5.14' (authored by jgrulich).
Merge branch 'Plasma/5.14'
Dec 17 2018, 3:28 PM
jgrulich committed R116:cf11d51f2b7a: Fix a wrong check in previous patch (authored by jgrulich).
Fix a wrong check in previous patch
Dec 17 2018, 3:27 PM
jgrulich committed R116:876c9731532b: Merge branch 'Plasma/5.14' (authored by jgrulich).
Merge branch 'Plasma/5.14'
Dec 17 2018, 3:26 PM
jgrulich committed R116:b2f6422c89c7: Openconnect: do not reload dialog when group changes for Juniper protocol (authored by jgrulich).
Openconnect: do not reload dialog when group changes for Juniper protocol
Dec 17 2018, 3:22 PM
jgrulich added a comment to D17487: Check if the form has changed, and only reconnect if it has.

After a discussion with Openconnect main developer, we have come up with a fix in Openconnect itself and a workaround on plasma-nm side. Basically it's based on your previous patch where you just check the protocol to see if it's Juniper or not and if it's Juniper, then do not reload the dialog when group changes. This is because Juniper's groups are different from Anyconnect ones.

Dec 17 2018, 3:17 PM · Plasma

Dec 16 2018

jgrulich committed R838:23b11bf6c493: Flatpak is not needed runtime dependency (authored by jgrulich).
Flatpak is not needed runtime dependency
Dec 16 2018, 4:56 PM

Dec 13 2018

jgrulich committed R838:ccea985840cf: FileChooser: make use of current_name property in Save dialog (authored by jgrulich).
FileChooser: make use of current_name property in Save dialog
Dec 13 2018, 10:06 AM
jgrulich committed R838:fa5161c17e6a: FileChooser: make use of current_name property in Save dialog (authored by jgrulich).
FileChooser: make use of current_name property in Save dialog
Dec 13 2018, 6:48 AM
jgrulich committed R838:428d3c993bba: Avoid disabling the stream twice (authored by jgrulich).
Avoid disabling the stream twice
Dec 13 2018, 6:37 AM

Dec 12 2018

jgrulich accepted D17529: [proxysetting] Fix build with NM 1.4.
Dec 12 2018, 1:38 PM · Frameworks
jgrulich added a comment to D17529: [proxysetting] Fix build with NM 1.4.

So maybe go with the easiest approach and just instead of defines use 0 and 1?

Fine with me.

Should I make that conditional depending on the NM version maybe, or just unconditionally use the numbers?

Dec 12 2018, 1:24 PM · Frameworks
jgrulich added a comment to D17529: [proxysetting] Fix build with NM 1.4.

So maybe go with the easiest approach and just instead of defines use 0 and 1?

Dec 12 2018, 1:06 PM · Frameworks
jgrulich accepted D17529: [proxysetting] Fix build with NM 1.4.
Dec 12 2018, 12:13 PM · Frameworks
jgrulich added a comment to D17529: [proxysetting] Fix build with NM 1.4.

I think the easiest solution here is just to set 0 and 1 to the enum values, instead of NM defines. I'm not sure if adding/removing enum is ABI compatible change, because the enum will disapper once you build it against NM 1.6.0+.

Dec 12 2018, 11:37 AM · Frameworks

Dec 11 2018

jgrulich committed R116:9f01039ddec9: Applet: show that current upload/download is per second (authored by jgrulich).
Applet: show that current upload/download is per second
Dec 11 2018, 1:22 PM
jgrulich added a comment to D17487: Check if the form has changed, and only reconnect if it has.

It looks good to me and makes sense. I'll try to ask those who had problems to connect to Cisco AnyConnect servers with my first attempt. Thank you for looking into that.

Dec 11 2018, 1:12 PM · Plasma
jgrulich committed R282:4332597370b8: Added DCB settings (authored by pranavgade).
Added DCB settings
Dec 11 2018, 10:35 AM
jgrulich closed D17425: Added DCB settings.
Dec 11 2018, 10:35 AM · Frameworks
jgrulich accepted D17425: Added DCB settings.
Dec 11 2018, 10:28 AM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Dec 11 2018, 9:50 AM · Frameworks
jgrulich committed R282:7036e0ade135: A minor typo in ipv4 test (authored by jgrulich).
A minor typo in ipv4 test
Dec 11 2018, 6:53 AM
jgrulich closed D17497: A minor typo in ipv4 test.
Dec 11 2018, 6:53 AM · Frameworks
jgrulich accepted D17497: A minor typo in ipv4 test.
Dec 11 2018, 6:50 AM · Frameworks

Dec 10 2018

jgrulich added a comment to D17425: Added DCB settings.

This was last round, otherwise it's ready to go, just fix the remaining issues. Thanks.

Dec 10 2018, 3:08 PM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Dec 10 2018, 3:08 PM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Dec 10 2018, 2:20 PM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Dec 10 2018, 12:05 PM · Frameworks
jgrulich committed R282:2edc30be9f3e: A minor bug in ipv4 and ipv6 test (authored by jgrulich).
A minor bug in ipv4 and ipv6 test
Dec 10 2018, 12:03 PM
jgrulich closed D17474: A minor bug in ipv4 and ipv6 test.
Dec 10 2018, 12:03 PM · Frameworks
jgrulich accepted D17474: A minor bug in ipv4 and ipv6 test.
Dec 10 2018, 12:02 PM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Dec 10 2018, 11:41 AM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Dec 10 2018, 10:56 AM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Dec 10 2018, 10:42 AM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Dec 10 2018, 8:38 AM · Frameworks