Change default sort order in the download dialog to Rating

Authored by ngraham on Jul 13 2018, 12:39 PM.



This changed the default sort ordering of the download dialog to Rating, for the following reasons:

  • It's more relevant and useful to users to see content that the community thinks is best by default instead of simply what's been uploaded most recently
  • Match Discover's default sort ordering for KNS content
Test Plan

Open a GHNS dialog and see that the default sort ordering of the content is by Rating, and that the Rating radio button is checked:

Diff Detail

R304 KNewStuff
sort-by-rating-by-default (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 814
Build 827: arc lint + arc unit
ngraham created this revision.Jul 13 2018, 12:39 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 13 2018, 12:39 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 13 2018, 12:39 PM
ngraham edited the test plan for this revision. (Show Details)Jul 13 2018, 12:41 PM
apol added a comment.Jul 13 2018, 1:11 PM

+1 this makes most sense to me.

leinir accepted this revision.Jul 16 2018, 8:06 AM

As an aside, I'd probably like this to end up being remembered between sessions, but this no different to the current state, and so outside the scope of this patch. As a default setting, yup, sorting by Rating definitely makes better sense than Newest :) (Newest would make better sense for people who look regularly, but Rating is definitely the best first-run thing, and that's the experience we're trying to improve - we can get to remembering the state later on, if everybody else agrees that that's something we want to do)

This revision is now accepted and ready to land.Jul 16 2018, 8:06 AM
ngraham closed this revision.Jul 16 2018, 3:00 PM