| davidedmundson |
| Plasma | |
| VDG |
I often find myself clicking the widget handle's Remove button and accidentally removing the widget itself when I'm just trying to hide the handle, because the button's current icon communicates "close this thing" better than "delete this thing". By switching it to a trash icon, we communicate its true meaning better and it becomes clear that the button will remove the widget.
This also brings that icon into consistency with the icon used in the context menu's Remove this [widget] entry.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 847 | |
| Build 860: arc lint + arc unit |
+1. I have a similar experience with the red X-Button as shown here for the Activity Manager:
Ah yes, I've accidentally removed my panel widgets that way too! I'll submit a similar patch for that shortly.
Can you make the same change also for the panel? There it's even more confusing as the "X" looks like it would close the popup but it's actually for deleting the widget.
Code is in plasma-desktop/desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml
Indeed I was planning to do that! However I was having trouble locating the code in question, so thanks for letting me know what it is. Patch incoming soon.
Hmm actually that's for the toolbar above the panel, not the little menus that appear when you hover the mouse over a panel widget.
Found it. Here's the patch: D14138: Use a trash icon for anything that will remove a widget or a panel